[GitHub] incubator-beam pull request #947: [BEAM-618] Disallow NAN, INF and -INF inva...
Github user ajamato closed the pull request at: https://github.com/apache/incubator-beam/pull/947 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-beam pull request #947: [BEAM-618] Disallow NAN, INF and -INF inva...
Github user ajamato closed the pull request at: https://github.com/apache/incubator-beam/pull/947 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-beam pull request #947: [BEAM-618] Disallow NAN, INF and -INF inva...
GitHub user ajamato reopened a pull request: https://github.com/apache/incubator-beam/pull/947 [BEAM-618] Disallow NAN, INF and -INF invalid JSON values in bigquery exporter Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [x] Make sure the PR title is formatted like: `[BEAM-] Description of pull request` - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [x] Replace `` in the title with the actual Jira issue number, if there is one. - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- Now exporting JSON will fail with invalid NAN, INF or -INF values. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajamato/incubator-beam py_json Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-beam/pull/947.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #947 commit 442bed71e68524368408573ce0bcb22901d7f861 Author: Alex Amato Date: 2016-09-09T00:57:28Z Set allow_nan=False on bigquery JSON encoding commit bd7f920faf41a3a203d854de626c9dcd90a90e29 Author: Alex Amato Date: 2016-09-12T20:09:34Z Remove unused line commit 441b59bdf2de88cae119f0399bd38f64ecbbf96f Author: Alex Amato Date: 2016-09-14T17:05:25Z Fix Lint Error --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-beam pull request #947: [BEAM-618] Disallow NAN, INF and -INF inva...
GitHub user ajamato opened a pull request: https://github.com/apache/incubator-beam/pull/947 [BEAM-618] Disallow NAN, INF and -INF invalid JSON values in bigquery exporter Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[BEAM-] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- Now exporting JSON will fail with invalid NAN, INF or -INF values. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajamato/incubator-beam py_json Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-beam/pull/947.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #947 commit 442bed71e68524368408573ce0bcb22901d7f861 Author: Alex Amato Date: 2016-09-09T00:57:28Z Set allow_nan=False on bigquery JSON encoding --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
