[GitHub] incubator-beam pull request #949: Update code to import into eclipse using m...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-beam/pull/949


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-beam pull request #949: Update code to import into eclipse using m...

[dkulp]

GitHub user dkulp opened a pull request:

https://github.com/apache/incubator-beam/pull/949

Update code to import into eclipse using m2e and compile (checkstyle …

I'm trying to get beam to load into Eclipse (Neon) using m2e.   Currently, 
there are a bunch of compile errors which prevents it from building within 
Eclipse due to some differences between the standard Oracle "javac" compiler 
and Eclipse's ejc compiler with certain generics usages.   Also, the eclipse 
compiler complains if there are two package-info.java files in the same package 
(usually due to one in the "test" tree that duplicates the package from the 
non-test tree) so I eliminated the ones in the test tree.  

This is a start.  With this, beam will import into Eclipse, but then 
generates a TON of Checkstyle errors due to checkstyle checking the avro 
generated code.   You can right click on the projects and disable Checkstyle 
for now and beam will build/test within Eclipse.   I'm working on figuring out 
the checkstyle parts, but I wanted to submit this for review as this involves 
actual code changes.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dkulp/incubator-beam eclipse-ide

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/949.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #949


commit aa5495863fe2b87b61637ceeb278268bc69557a5
Author: Daniel Kulp 
Date:   2016-09-12T21:31:22Z

Update code to import into eclipse using m2e and compile (checkstyle still 
generates a ton of errors)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---