[jira] [Commented] (BEAM-1117) Support for new Timer API in Direct runner

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15768294#comment-15768294
 ] 

ASF GitHub Bot commented on BEAM-1117:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-beam/pull/1669


> Support for new Timer API in Direct runner
> --
>
> Key: BEAM-1117
> URL: https://issues.apache.org/jira/browse/BEAM-1117
> Project: Beam
>  Issue Type: New Feature
>  Components: runner-direct
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BEAM-1117) Support for new Timer API in Direct runner

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15765551#comment-15765551
 ] 

ASF GitHub Bot commented on BEAM-1117:
--

GitHub user kennknowles opened a pull request:

https://github.com/apache/incubator-beam/pull/1669

[BEAM-1117] Direct runner timers prereqs

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [x] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [x] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [x] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---

Per request, here are some commits from #1667 broken out. I am happy to 
trim off more, etc, whatever is easiest for review.

R: @tgroh 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kennknowles/incubator-beam 
DirectRunner-timers-prereqs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/1669.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1669


commit f64816e0cf2e4fcc9525f40ede01c2f8e4ecf28d
Author: Kenneth Knowles 
Date:   2016-12-20T04:40:11Z

Add informative Instant formatter to BoundedWindow

commit 46c6a4f613629f09b48e3630aa344760b0ad46d4
Author: Kenneth Knowles 
Date:   2016-12-20T04:40:47Z

Use informative Instant formatter in WatermarkHold

commit 92baa418fbe53c0e7c7afc81db31fc02ab7f3915
Author: Kenneth Knowles 
Date:   2016-12-20T21:57:55Z

Add static Window.withOutputTimeFn to match build method

commit 7118c4ff85636a65431be54fa2e2f18fb52914cf
Author: Kenneth Knowles 
Date:   2016-12-20T22:20:07Z

Add UsesTestStream for use with JUnit @Category

commit f667a3e8abcd95be7a235132219c936178ab6bc8
Author: Kenneth Knowles 
Date:   2016-12-08T04:18:44Z

Allow setting timer by ID in DirectTimerInternals

commit 217e5245e59800d57aa36551fbbdb642a5b447a0
Author: Kenneth Knowles 
Date:   2016-12-20T21:37:40Z

Hold output watermark according to pending timers




> Support for new Timer API in Direct runner
> --
>
> Key: BEAM-1117
> URL: https://issues.apache.org/jira/browse/BEAM-1117
> Project: Beam
>  Issue Type: New Feature
>  Components: runner-direct
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BEAM-1117) Support for new Timer API in Direct runner

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15765203#comment-15765203
 ] 

ASF GitHub Bot commented on BEAM-1117:
--

GitHub user kennknowles opened a pull request:

https://github.com/apache/incubator-beam/pull/1667

[BEAM-1117] Support user timers for ParDo in the direct runner

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [x] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [x] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [x] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---

R: @tgroh 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kennknowles/incubator-beam DirectRunner-timers

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/1667.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1667


commit a3ac176cd7edb18d4f633682ee0e6ff30ab76f64
Author: Kenneth Knowles 
Date:   2016-12-08T04:18:44Z

Allow setting timer by ID in DirectTimerInternals

commit 445750d6cf36f1eda1094531541788260c3fe229
Author: Kenneth Knowles 
Date:   2016-12-08T18:27:23Z

No longer reject timers for ParDo in direct runner

commit d428abe9e12ddd2609773512a180589ff960d954
Author: Kenneth Knowles 
Date:   2016-12-08T23:18:44Z

Deliver timers in the direct runner

commit 6915bbc550ad692656e8eeb1ba7161213c9a6ce6
Author: Kenneth Knowles 
Date:   2016-12-20T04:40:11Z

Add informative Instant formatter to BoundedWindow

commit 2af3f93602b5299cc33c876310a784fc82ff4941
Author: Kenneth Knowles 
Date:   2016-12-20T04:40:47Z

Use informative Instant formatter in WatermarkHold




> Support for new Timer API in Direct runner
> --
>
> Key: BEAM-1117
> URL: https://issues.apache.org/jira/browse/BEAM-1117
> Project: Beam
>  Issue Type: New Feature
>  Components: runner-direct
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BEAM-1117) Support for new Timer API in Direct runner

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15765191#comment-15765191
 ] 

ASF GitHub Bot commented on BEAM-1117:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-beam/pull/1581


> Support for new Timer API in Direct runner
> --
>
> Key: BEAM-1117
> URL: https://issues.apache.org/jira/browse/BEAM-1117
> Project: Beam
>  Issue Type: New Feature
>  Components: runner-direct
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BEAM-1117) Support for new Timer API in Direct runner

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15743184#comment-15743184
 ] 

ASF GitHub Bot commented on BEAM-1117:
--

GitHub user kennknowles opened a pull request:

https://github.com/apache/incubator-beam/pull/1581

[BEAM-1117] Port Direct runner stateful ParDo to take KeyedWorkItem

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [x] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [x] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [x] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---

This is based upon the required PR #1556 but adds the motivating use of 
key-preservation logic.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kennknowles/incubator-beam 
DirectRunner-Stateful-KeyedWorkItem

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/1581.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1581


commit 746a78f98615a51355a901c50c5fd4db7c504a79
Author: Kenneth Knowles 
Date:   2016-12-08T19:44:48Z

Propagate key through ParDo if DoFn is key-preserving

commit 9ae20e5b8ff0b1365a324062bce2e74799fbb68e
Author: Kenneth Knowles 
Date:   2016-12-08T19:49:15Z

Add some key-preserving to KeyedPValueTrackingVisitor

commit d4129c6405fdc17ace4defc027cc5dafd61f232c
Author: Kenneth Knowles 
Date:   2016-12-08T21:28:44Z

Move responsibility for knowing about keyedness into EvaluationContext

This will allow transform evaluators to inquire about whether
various collections are keyed.

commit d590f7436ef09520a531fb1561cbdb1f1cad94af
Author: Kenneth Knowles 
Date:   2016-12-08T19:29:21Z

Port direct runner StatefulParDo to KeyedWorkItem




> Support for new Timer API in Direct runner
> --
>
> Key: BEAM-1117
> URL: https://issues.apache.org/jira/browse/BEAM-1117
> Project: Beam
>  Issue Type: New Feature
>  Components: runner-direct
>Reporter: Kenneth Knowles
>Assignee: Kenneth Knowles
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)