[jira] [Commented] (BEAM-254) Add maven-rat-plugin execution
[ https://issues.apache.org/jira/browse/BEAM-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308449#comment-15308449 ] ASF GitHub Bot commented on BEAM-254: - Github user asfgit closed the pull request at: https://github.com/apache/incubator-beam/pull/297 > Add maven-rat-plugin execution > -- > > Key: BEAM-254 > URL: https://issues.apache.org/jira/browse/BEAM-254 > Project: Beam > Issue Type: Task > Components: build-system >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré > > In order to check the license headers and validate we are "Apache compliant", > I will add the maven-rat-plugin execution in the main parent POM. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BEAM-254) Add maven-rat-plugin execution
[ https://issues.apache.org/jira/browse/BEAM-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15275710#comment-15275710 ] Davor Bonaci commented on BEAM-254: --- We should double-check that the checkstyle plugin cannot be configured to do the same thing. If so, it would be better to maintain one system, as opposed to two. > Add maven-rat-plugin execution > -- > > Key: BEAM-254 > URL: https://issues.apache.org/jira/browse/BEAM-254 > Project: Beam > Issue Type: Task > Components: build-system >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré > > In order to check the license headers and validate we are "Apache compliant", > I will add the maven-rat-plugin execution in the main parent POM. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BEAM-254) Add maven-rat-plugin execution
[
https://issues.apache.org/jira/browse/BEAM-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270899#comment-15270899
]
Jean-Baptiste Onofré commented on BEAM-254:
---
Good point. Actually, I think it's better to exclude {{**/*.java}} in the rat
configuration. Thanks to that, rat will only consider "non" java files.
> Add maven-rat-plugin execution
> --
>
> Key: BEAM-254
> URL: https://issues.apache.org/jira/browse/BEAM-254
> Project: Beam
> Issue Type: Task
> Components: build-system
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>
> In order to check the license headers and validate we are "Apache compliant",
> I will add the maven-rat-plugin execution in the main parent POM.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (BEAM-254) Add maven-rat-plugin execution
[ https://issues.apache.org/jira/browse/BEAM-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270888#comment-15270888 ] Scott Wegner commented on BEAM-254: --- I see; I hadn't considered that we need a header on non-source files. When you add this, should we remove the checkstyle Header check? As long as it's redundant, removing it should be safe and help speed up the build a bit. > Add maven-rat-plugin execution > -- > > Key: BEAM-254 > URL: https://issues.apache.org/jira/browse/BEAM-254 > Project: Beam > Issue Type: Task > Components: build-system >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré > > In order to check the license headers and validate we are "Apache compliant", > I will add the maven-rat-plugin execution in the main parent POM. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BEAM-254) Add maven-rat-plugin execution
[ https://issues.apache.org/jira/browse/BEAM-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269510#comment-15269510 ] Jean-Baptiste Onofré commented on BEAM-254: --- Checkstyle applies on Java source, rat can check any kind of files. For instance, I did a first rat run: README.md doesn't contain the license header, the travis files don't contain it, etc. I agree that it's not a strong requirement, but a good to have. > Add maven-rat-plugin execution > -- > > Key: BEAM-254 > URL: https://issues.apache.org/jira/browse/BEAM-254 > Project: Beam > Issue Type: Task > Components: build-system >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré > > In order to check the license headers and validate we are "Apache compliant", > I will add the maven-rat-plugin execution in the main parent POM. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BEAM-254) Add maven-rat-plugin execution
[ https://issues.apache.org/jira/browse/BEAM-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269494#comment-15269494 ] Scott Wegner commented on BEAM-254: --- Doesn't checkstyle already provide this via the [Header|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/checkstyle.xml#L37] module? > Add maven-rat-plugin execution > -- > > Key: BEAM-254 > URL: https://issues.apache.org/jira/browse/BEAM-254 > Project: Beam > Issue Type: Task > Components: build-system >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré > > In order to check the license headers and validate we are "Apache compliant", > I will add the maven-rat-plugin execution in the main parent POM. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
