[jira] [Commented] (BEAM-372) CoderProperties: Test that the coder doesn't consume more bytes than it produces
[ https://issues.apache.org/jira/browse/BEAM-372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387771#comment-15387771 ] ASF GitHub Bot commented on BEAM-372: - Github user asfgit closed the pull request at: https://github.com/apache/incubator-beam/pull/695 > CoderProperties: Test that the coder doesn't consume more bytes than it > produces > > > Key: BEAM-372 > URL: https://issues.apache.org/jira/browse/BEAM-372 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Ben Chambers >Assignee: Chandni Singh >Priority: Minor > Labels: beginner, newbie, starter > > Add a test to CoderProperties that does the following: > 1. Encode a value using the Coder in the nested context > 2. Decode the value using the Coder in the nested context > 3. Verify that the input stream wasn't requested to consume any extra bytes > (This could possibly just be an enhancement to the existing round-trip > encode/decode test) > When this fails it can lead to very difficult to debug situations in a coder > wrapped around the problematic coder. This would be an easy test that would > clearly fail *for the coder which was problematic*. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BEAM-372) CoderProperties: Test that the coder doesn't consume more bytes than it produces
[ https://issues.apache.org/jira/browse/BEAM-372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368748#comment-15368748 ] Chandni Singh commented on BEAM-372: Sorry haven't started working on it yet. If you will like to take it up, please do so. I'll pick up another started ticket later. > CoderProperties: Test that the coder doesn't consume more bytes than it > produces > > > Key: BEAM-372 > URL: https://issues.apache.org/jira/browse/BEAM-372 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Ben Chambers >Assignee: Chandni Singh >Priority: Minor > Labels: beginner, newbie, starter > > Add a test to CoderProperties that does the following: > 1. Encode a value using the Coder in the nested context > 2. Decode the value using the Coder in the nested context > 3. Verify that the input stream wasn't requested to consume any extra bytes > (This could possibly just be an enhancement to the existing round-trip > encode/decode test) > When this fails it can lead to very difficult to debug situations in a coder > wrapped around the problematic coder. This would be an easy test that would > clearly fail *for the coder which was problematic*. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BEAM-372) CoderProperties: Test that the coder doesn't consume more bytes than it produces
[ https://issues.apache.org/jira/browse/BEAM-372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368718#comment-15368718 ] Daniel Halperin commented on BEAM-372: -- [~csingh] have you had any progress or blockers? Should I unassign? > CoderProperties: Test that the coder doesn't consume more bytes than it > produces > > > Key: BEAM-372 > URL: https://issues.apache.org/jira/browse/BEAM-372 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Ben Chambers >Assignee: Chandni Singh >Priority: Minor > Labels: beginner, newbie, starter > > Add a test to CoderProperties that does the following: > 1. Encode a value using the Coder in the nested context > 2. Decode the value using the Coder in the nested context > 3. Verify that the input stream wasn't requested to consume any extra bytes > (This could possibly just be an enhancement to the existing round-trip > encode/decode test) > When this fails it can lead to very difficult to debug situations in a coder > wrapped around the problematic coder. This would be an easy test that would > clearly fail *for the coder which was problematic*. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BEAM-372) CoderProperties: Test that the coder doesn't consume more bytes than it produces
[ https://issues.apache.org/jira/browse/BEAM-372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368716#comment-15368716 ] Daniel Halperin commented on BEAM-372: -- Another idea: put elements in a list and use a list coder to encode/decode. > CoderProperties: Test that the coder doesn't consume more bytes than it > produces > > > Key: BEAM-372 > URL: https://issues.apache.org/jira/browse/BEAM-372 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Ben Chambers >Assignee: Chandni Singh >Priority: Minor > Labels: beginner, newbie, starter > > Add a test to CoderProperties that does the following: > 1. Encode a value using the Coder in the nested context > 2. Decode the value using the Coder in the nested context > 3. Verify that the input stream wasn't requested to consume any extra bytes > (This could possibly just be an enhancement to the existing round-trip > encode/decode test) > When this fails it can lead to very difficult to debug situations in a coder > wrapped around the problematic coder. This would be an easy test that would > clearly fail *for the coder which was problematic*. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BEAM-372) CoderProperties: Test that the coder doesn't consume more bytes than it produces
[ https://issues.apache.org/jira/browse/BEAM-372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352469#comment-15352469 ] Chandni Singh commented on BEAM-372: Can you please assign it to me? > CoderProperties: Test that the coder doesn't consume more bytes than it > produces > > > Key: BEAM-372 > URL: https://issues.apache.org/jira/browse/BEAM-372 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Ben Chambers >Priority: Minor > Labels: beginner, newbie, starter > > Add a test to CoderProperties that does the following: > 1. Encode a value using the Coder in the nested context > 2. Decode the value using the Coder in the nested context > 3. Verify that the input stream wasn't requested to consume any extra bytes > (This could possibly just be an enhancement to the existing round-trip > encode/decode test) > When this fails it can lead to very difficult to debug situations in a coder > wrapped around the problematic coder. This would be an easy test that would > clearly fail *for the coder which was problematic*. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BEAM-372) CoderProperties: Test that the coder doesn't consume more bytes than it produces
[ https://issues.apache.org/jira/browse/BEAM-372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352464#comment-15352464 ] Daniel Halperin commented on BEAM-372: -- Sounds good to me! > CoderProperties: Test that the coder doesn't consume more bytes than it > produces > > > Key: BEAM-372 > URL: https://issues.apache.org/jira/browse/BEAM-372 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Ben Chambers >Priority: Minor > Labels: beginner, newbie, starter > > Add a test to CoderProperties that does the following: > 1. Encode a value using the Coder in the nested context > 2. Decode the value using the Coder in the nested context > 3. Verify that the input stream wasn't requested to consume any extra bytes > (This could possibly just be an enhancement to the existing round-trip > encode/decode test) > When this fails it can lead to very difficult to debug situations in a coder > wrapped around the problematic coder. This would be an easy test that would > clearly fail *for the coder which was problematic*. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BEAM-372) CoderProperties: Test that the coder doesn't consume more bytes than it produces
[ https://issues.apache.org/jira/browse/BEAM-372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352461#comment-15352461 ] Chandni Singh commented on BEAM-372: Can I work on this JIRA? > CoderProperties: Test that the coder doesn't consume more bytes than it > produces > > > Key: BEAM-372 > URL: https://issues.apache.org/jira/browse/BEAM-372 > Project: Beam > Issue Type: Bug > Components: sdk-java-core >Reporter: Ben Chambers >Priority: Minor > Labels: beginner, newbie, starter > > Add a test to CoderProperties that does the following: > 1. Encode a value using the Coder in the nested context > 2. Decode the value using the Coder in the nested context > 3. Verify that the input stream wasn't requested to consume any extra bytes > (This could possibly just be an enhancement to the existing round-trip > encode/decode test) > When this fails it can lead to very difficult to debug situations in a coder > wrapped around the problematic coder. This would be an easy test that would > clearly fail *for the coder which was problematic*. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
