[jira] [Commented] (BEAM-615) Add Support for Processing-Time Timers in FlinkRunner Window Operator

2016-09-28 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15530201#comment-15530201
 ] 

ASF GitHub Bot commented on BEAM-615:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-beam/pull/1021


> Add Support for Processing-Time Timers in FlinkRunner Window Operator
> -
>
> Key: BEAM-615
> URL: https://issues.apache.org/jira/browse/BEAM-615
> Project: Beam
>  Issue Type: Bug
>  Components: runner-flink
>Affects Versions: 0.1.0-incubating, 0.2.0-incubating, 0.3.0-incubating
>Reporter: Aljoscha Krettek
>Assignee: Aljoscha Krettek
> Fix For: 0.3.0-incubating
>
>
> The Flink runner never had support for processing-time timers, they are 
> silently ignored when a trigger tries to set one. This should be easy to add 
> in {{WindowFnOperator}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BEAM-615) Add Support for Processing-Time Timers in FlinkRunner Window Operator

2016-09-26 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523377#comment-15523377
 ] 

ASF GitHub Bot commented on BEAM-615:
-

Github user kennknowles closed the pull request at:

https://github.com/apache/incubator-beam/pull/994


> Add Support for Processing-Time Timers in FlinkRunner Window Operator
> -
>
> Key: BEAM-615
> URL: https://issues.apache.org/jira/browse/BEAM-615
> Project: Beam
>  Issue Type: Bug
>  Components: runner-flink
>Affects Versions: 0.1.0-incubating, 0.2.0-incubating, 0.3.0-incubating
>Reporter: Aljoscha Krettek
>Assignee: Kenneth Knowles
>
> The Flink runner never had support for processing-time timers, they are 
> silently ignored when a trigger tries to set one. This should be easy to add 
> in {{WindowFnOperator}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BEAM-615) Add Support for Processing-Time Timers in FlinkRunner Window Operator

2016-09-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517558#comment-15517558
 ] 

ASF GitHub Bot commented on BEAM-615:
-

GitHub user kennknowles opened a pull request:

https://github.com/apache/incubator-beam/pull/994

[BEAM-615] Add support for processing time timers in FlinkRunner

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [x] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [x] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [x] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---

R: @aljoscha or @mxm 

I coded this very quickly without learning probably what I need to about 
the `FlinkRunner` or Flink. It seems to work for the naive examples I am 
experimenting with. Perhaps you can find errors and suggest corrections, or 
pull it and do it right?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kennknowles/incubator-beam 
flink-processing-time

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/994.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #994


commit 29684fec8a0885ac202f6614f458af1221ed8bb6
Author: Kenneth Knowles 
Date:   2016-09-23T20:54:21Z

Add support for processing time timers in FlinkRunner




> Add Support for Processing-Time Timers in FlinkRunner Window Operator
> -
>
> Key: BEAM-615
> URL: https://issues.apache.org/jira/browse/BEAM-615
> Project: Beam
>  Issue Type: Bug
>  Components: runner-flink
>Affects Versions: 0.1.0-incubating, 0.2.0-incubating, 0.3.0-incubating
>Reporter: Aljoscha Krettek
>Assignee: Kenneth Knowles
>
> The Flink runner never had support for processing-time timers, they are 
> silently ignored when a trigger tries to set one. This should be easy to add 
> in {{WindowFnOperator}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)