[jira] [Commented] (BEAM-678) Python executable should be overridable

2016-09-26 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15524270#comment-15524270
 ] 

ASF GitHub Bot commented on BEAM-678:
-

Github user swegner closed the pull request at:

https://github.com/apache/incubator-beam/pull/1006


> Python executable should be overridable
> ---
>
> Key: BEAM-678
> URL: https://issues.apache.org/jira/browse/BEAM-678
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-py
>Reporter: Scott Wegner
>Assignee: Scott Wegner
>Priority: Minor
>
> Since [PR 962|https://github.com/apache/incubator-beam/pull/962], 
> dependency.py will use {{sys.executable}} to source the python executable to 
> use for managing dependencies. However, as stated in the [python 
> docs|https://docs.python.org/2/library/sys.html#sys.executable]:
> bq. If Python is unable to retrieve the real path to its executable, 
> sys.executable will be an empty string or None.
> To mitigate this, we should allow setting the python executable to use via an 
> environment variable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (BEAM-678) Python executable should be overridable

2016-09-26 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523625#comment-15523625
 ] 

ASF GitHub Bot commented on BEAM-678:
-

GitHub user swegner opened a pull request:

https://github.com/apache/incubator-beam/pull/1006

[BEAM-678] Add BEAM_PYTHON environment override to set the python executable

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [ ] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [ ] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/swegner/incubator-beam set-python-executable

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/1006.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1006


commit 046e9b0139ee989d1821036eddb7d0b93a4ae246
Author: Scott Wegner 
Date:   2016-09-26T17:05:01Z

Add BEAM_PYTHON environment override to set the python executable




> Python executable should be overridable
> ---
>
> Key: BEAM-678
> URL: https://issues.apache.org/jira/browse/BEAM-678
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-py
>Reporter: Scott Wegner
>Assignee: Scott Wegner
>Priority: Minor
>
> Since [PR 962|https://github.com/apache/incubator-beam/pull/962], 
> dependency.py will use {{sys.executable}} to source the python executable to 
> use for managing dependencies. However, as stated in the [python 
> docs|https://docs.python.org/2/library/sys.html#sys.executable]:
> bq. If Python is unable to retrieve the real path to its executable, 
> sys.executable will be an empty string or None.
> To mitigate this, we should allow setting the python executable to use via an 
> environment variable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)