Re: [Apache Bloodhound] #668: Negative integers for ticket IDs
#668: Negative integers for ticket IDs ---+--- Reporter: olemis| Owner: olemis Type: defect| Status: review Priority: blocker | Milestone: Release 8 Component: multiproduct |Version: Resolution:| Keywords: bep-0010 , postgresql ---+--- Changes (by rjollos): * owner: = olemis Comment: I'll leave for you to decide whether to close the ticket or investigate the underlying issue further in this ticket. -- Ticket URL: https://issues.apache.org/bloodhound/ticket/668#comment:8 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #668: Negative integers for ticket IDs
#668: Negative integers for ticket IDs ---+--- Reporter: olemis| Owner: olemis Type: defect| Status: closed Priority: blocker | Milestone: Release 8 Component: multiproduct |Version: Resolution: fixed | Keywords: bep-0010 , postgresql ---+--- Changes (by olemis): * status: review = closed * resolution: = fixed Comment: Replying to [comment:8 rjollos]: I'll leave for you to decide whether to close the ticket or investigate the underlying issue further in this ticket. Let's better close this one and defer root cause investigation to be tracked in a separate ticket . -- Ticket URL: https://issues.apache.org/bloodhound/ticket/668#comment:9 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #668: Negative integers for ticket IDs
#668: Negative integers for ticket IDs ---+--- Reporter: olemis| Owner: olemis Type: defect| Status: new Priority: blocker | Milestone: Release 8 Component: multiproduct |Version: Resolution:| Keywords: bep-0010 , postgresql ---+--- Changes (by olemis): * status: closed = new * resolution: fixed = Comment: hmmm ... let's better find out what's the `UnboundLocalError` about . -- Ticket URL: https://issues.apache.org/bloodhound/ticket/668#comment:10 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #668: Negative integers for ticket IDs
#668: Negative integers for ticket IDs ---+--- Reporter: olemis| Owner: olemis Type: defect| Status: accepted Priority: blocker | Milestone: Release 8 Component: multiproduct |Version: Resolution:| Keywords: bep-0010 , postgresql ---+--- Changes (by olemis): * status: new = accepted -- Ticket URL: https://issues.apache.org/bloodhound/ticket/668#comment:11 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #668: Negative integers for ticket IDs
#668: Negative integers for ticket IDs
---+---
Reporter: olemis| Owner: olemis
Type: defect| Status: accepted
Priority: blocker | Milestone: Release 8
Component: multiproduct |Version:
Resolution:| Keywords: bep-0010 , postgresql
---+---
Comment (by rjollos):
It looks like the `UnboundLocalError` may just be a side-effect of the
ticket not existing. Perhaps we should push this patch to Trac:
{{{#!diff
diff --git a/trac/trac/ticket/notification.py
b/trac/trac/ticket/notification.py
index 2de8ec9..5c52982 100644
--- a/trac/trac/ticket/notification.py
+++ b/trac/trac/ticket/notification.py
@@ -80,6 +80,7 @@ def get_ticket_notification_recipients(env, config,
tktid, prev_cc):
ccrecipients = prev_cc
torecipients = []
+reporter = owner = None
with env.db_query as db:
# Harvest email addresses from the cc, reporter, and owner fields
for row in db(SELECT cc, reporter, owner FROM ticket WHERE
id=%s,
}}}
Note however that I'm reworking the entire function in trac:#2311
(proposed stages are changed, but I'm doing some additional refactoring
before pushing them), which may prevent issues such as this.
--
Ticket URL: https://issues.apache.org/bloodhound/ticket/668#comment:12
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound issue tracker
svn commit: r1554007 - in /bloodhound/trunk/bloodhound_multiproduct: multiproduct/product_admin.py multiproduct/templates/admin_products.html tests/functional/admin.py
Author: rjollos
Date: Sun Dec 29 09:21:48 2013
New Revision: 1554007
URL: http://svn.apache.org/r1554007
Log:
0.8dev: Added a Clear Default button for the products table on the Manage
Products page. Refs #722.Add a Clear Default button for the products table on
the Manage Products page
Modified:
bloodhound/trunk/bloodhound_multiproduct/multiproduct/product_admin.py
bloodhound/trunk/bloodhound_multiproduct/multiproduct/templates/admin_products.html
bloodhound/trunk/bloodhound_multiproduct/tests/functional/admin.py
Modified: bloodhound/trunk/bloodhound_multiproduct/multiproduct/product_admin.py
URL:
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_multiproduct/multiproduct/product_admin.py?rev=1554007r1=1554006r2=1554007view=diff
==
--- bloodhound/trunk/bloodhound_multiproduct/multiproduct/product_admin.py
(original)
+++ bloodhound/trunk/bloodhound_multiproduct/multiproduct/product_admin.py Sun
Dec 29 09:21:48 2013
@@ -142,6 +142,13 @@ class ProductAdminPanel(TicketAdminPanel
prefix)
_save_config(self.config, req, self.log)
req.redirect(req.href.admin(cat, page))
+
+# Clear default product
+elif req.args.get('clear'):
+self.log.info(Clearing default product)
+self.config.set('ticket', 'default_product', '')
+_save_config(self.config, req, self.log)
+req.redirect(req.href.admin(cat, page))
products = Product.select(self.env)
data = {'view': 'list',
Modified:
bloodhound/trunk/bloodhound_multiproduct/multiproduct/templates/admin_products.html
URL:
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_multiproduct/multiproduct/templates/admin_products.html?rev=1554007r1=1554006r2=1554007view=diff
==
---
bloodhound/trunk/bloodhound_multiproduct/multiproduct/templates/admin_products.html
(original)
+++
bloodhound/trunk/bloodhound_multiproduct/multiproduct/templates/admin_products.html
Sun Dec 29 09:21:48 2013
@@ -123,6 +123,7 @@ $product.description/textarea
div class=buttons
input type=submit name=remove value=${_('Remove selected
items')} /
input type=submit name=apply value=${_('Apply changes')}
/
+ input type=submit name=clear value=${_('Clear default')}
/
/div
p class=help
You can remove all items from this list to completely hide this
Modified: bloodhound/trunk/bloodhound_multiproduct/tests/functional/admin.py
URL:
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_multiproduct/tests/functional/admin.py?rev=1554007r1=1554006r2=1554007view=diff
==
--- bloodhound/trunk/bloodhound_multiproduct/tests/functional/admin.py
(original)
+++ bloodhound/trunk/bloodhound_multiproduct/tests/functional/admin.py Sun Dec
29 09:21:48 2013
@@ -31,6 +31,27 @@ from tests.functional import Multiproduc
#
+class TestAdminProductDefault(MultiproductFunctionalTestCase,
+ FunctionalTwillTestCaseSetup):
+def runTest(self):
+Admin set default product
+name = self._tester.create_product()
+products_url = self._tester.url + '/admin/ticket/products'
+tc.go(products_url)
+tc.formvalue('product_table', 'default', name)
+tc.submit('apply')
+tc.find('type=radio name=default value=%s checked=checked'
+% name)
+tc.go(self._tester.url + '/newticket')
+tc.find('option selected=selected value=%s%s/option'
+% (name, name))
+# Test the Clear default button
+tc.go(products_url)
+tc.submit('clear', 'product_table')
+tc.notfind('type=radio name=default value=.+ checked=checked')
+tid = self._tester.create_ticket()
+
+
class RegressionTestBhTicket667(MultiproductFunctionalTestCase,
FunctionalTwillTestCaseSetup):
@@ -59,6 +80,7 @@ def functionalSuite(suite=None):
import tests.functional
suite = tests.functional.functionalSuite()
+suite.addTest(TestAdminProductDefault())
suite.addTest(RegressionTestBhTicket667())
return suite
Re: [Apache Bloodhound] #695: Add support for the CommitTicketUpdater component
#695: Add support for the CommitTicketUpdater component --+--- Reporter: bsmithers| Owner: rjollos Type: enhancement | Status: review Priority: major| Milestone: Release 8 Component: trac core|Version: 0.7.0 Resolution: | Keywords: vcs hooks --+--- Changes (by rjollos): * owner: = rjollos * milestone: = Release 8 -- Ticket URL: https://issues.apache.org/bloodhound/ticket/695#comment:10 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #668: Negative integers for ticket IDs
#668: Negative integers for ticket IDs ---+--- Reporter: olemis| Owner: olemis Type: defect| Status: accepted Priority: blocker | Milestone: Release 8 Component: multiproduct |Version: Resolution:| Keywords: bep-0010 , postgresql ---+--- Comment (by olemis): Replying to [comment:12 rjollos]: [...] Perhaps we should push this patch to Trac: [...] +1 [...] -- Ticket URL: https://issues.apache.org/bloodhound/ticket/668#comment:13 Apache Bloodhound https://issues.apache.org/bloodhound/ The Apache Bloodhound issue tracker
