Re: [Apache Bloodhound] #745: Edit workflow dialog may be partially hidden by activity feed

2014-01-22 Thread Apache Bloodhound
#745: Edit workflow dialog may be partially hidden by activity feed
+---
  Reporter:  rjollos|  Owner:  nobody
  Type:  defect | Status:  new
  Priority:  major  |  Milestone:  Release 9
 Component:  ui design  |Version:
Resolution: |   Keywords:
+---
Description changed by rjollos:

Old description:

> To reproduce:
>  * Go to an open ticket and select //Modify Ticket//
>  * Click on the status and select //resolve as duplicate//. Enter some
> nonsense for the duplicate ID such as //abc//.
>  * //Submit changes//
>  * **Secondary issue**: When the page refreshes, the following warning is
> displayed **outside** the visible area of the screen:
>  {{{#!html
> 
>  dismiss="alert">×
>   Warning
>   Invalid duplicate ticket ID.
>   
> }}}
>  * Select //Modify ticket// again and expand the workflow drop-down. It
> is hidden because the `ticketdraft` class has the rule //overflow:
> auto//.
>
> [[Image(WorkflowHidden.png,100%)]]
>
>  * **Secondary Issue**: Click //Cancel// and the draft image is still
> displayed in the ticket properties.

New description:

 To reproduce:
  * Go to an open ticket and select //Modify Ticket//
  * Click on the status and select //resolve as duplicate//. Enter some
 nonsense for the //Duplicate ID// such as //abc//, or leave the input
 empty.
  * //Submit changes//
  * **Secondary issue**: When the page refreshes, the following warning is
 displayed **outside** the visible area of the screen:
  {{{#!html
 
 ×
   Warning
   Invalid duplicate ticket ID.
   
 }}}
  * Select //Modify ticket// again and expand the workflow drop-down. It is
 hidden because the `ticketdraft` class has the rule //overflow: auto//.
  * **Secondary issue**: the radio button for //resolve as duplicate// is
 selected, but the //Duplicate ID// input is not displayed. In order to
 make the //Duplicate ID// input appear, the selection must be changed to
 another //Resolution//, then back to //duplicate//.

 [[Image(WorkflowHidden.png,100%)]]

  * **Secondary Issue**: Click //Cancel// and the draft image is still
 displayed in the ticket properties.

--

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker


svn commit: r1560601 - in /bloodhound/trunk: bloodhound_relations/bhrelations/api.py bloodhound_theme/bhtheme/templates/bh_ticket.html

2014-01-22 Thread rjollos
Author: rjollos
Date: Thu Jan 23 07:08:51 2014
New Revision: 1560601

URL: http://svn.apache.org/r1560601
Log:
0.8dev: //resolve as duplicate// now works correctly for any action with the 
`set_resolution` operation. Refs #742.

Previously, the //Duplicate ID// input would not be displayed for any action 
other than //resolve//. Also the `duplicate` attribute would only be bound in 
`ITicketManipulator` when the action was named `resolve`.

Now a //Duplicate ID// input will be attached to the workflow action and the 
`duplicate` attribute will be bound by `ITicketManipulator` for any action with 
the `set_resolution` operation. This has been tested and functions property 
when there are multiple actions that specify the `set_resolution` operation.


Modified:
bloodhound/trunk/bloodhound_relations/bhrelations/api.py
bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_ticket.html

Modified: bloodhound/trunk/bloodhound_relations/bhrelations/api.py
URL: 
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_relations/bhrelations/api.py?rev=1560601&r1=1560600&r2=1560601&view=diff
==
--- bloodhound/trunk/bloodhound_relations/bhrelations/api.py (original)
+++ bloodhound/trunk/bloodhound_relations/bhrelations/api.py Thu Jan 23 
07:08:51 2014
@@ -37,6 +37,7 @@ from trac.db import DatabaseManager
 from trac.resource import (ResourceSystem, Resource, ResourceNotFound,
get_resource_shortname, Neighborhood)
 from trac.ticket import Ticket, ITicketManipulator, ITicketChangeListener
+from trac.ticket.api import TicketSystem
 from trac.util.datefmt import utc, to_utimestamp
 from trac.web.chrome import ITemplateProvider
 
@@ -521,7 +522,9 @@ class TicketRelationsSpecifics(Component
 )
 
 def _check_blockers(self, req, ticket):
-if req.args.get('action') == 'resolve':
+action = req.args.get('action')
+operations = self._get_operations_for_action(req, ticket, action)
+if 'set_resolution' in operations:
 blockers = self.rls.find_blockers(ticket, self.is_blocker)
 if blockers:
 blockers_str = ', '.join(
@@ -533,7 +536,9 @@ class TicketRelationsSpecifics(Component
 yield None, msg
 
 def _check_open_children(self, req, ticket):
-if req.args.get('action') == 'resolve':
+action = req.args.get('action')
+operations = self._get_operations_for_action(req, ticket, action)
+if 'set_resolution' in operations:
 for relation in [r for r in self.rls.get_relations(ticket)
  if r['type'] == self.rls.CHILDREN_RELATION_TYPE]:
 ticket = 
self._create_ticket_by_full_id(relation['destination'])
@@ -543,8 +548,10 @@ class TicketRelationsSpecifics(Component
 yield None, msg
 
 def _check_duplicate_id(self, req, ticket):
-if req.args.get('action') == 'resolve':
-resolution = req.args.get('action_resolve_resolve_resolution')
+action = req.args.get('action')
+operations = self._get_operations_for_action(req, ticket, action)
+if 'set_resolution' in operations:
+resolution = req.args.get('action_%s_resolve_resolution' % action)
 if resolution == 'duplicate':
 duplicate_id = req.args.get('duplicate_id')
 if not duplicate_id:
@@ -558,6 +565,15 @@ class TicketRelationsSpecifics(Component
 except NoSuchTicketError:
 yield None, "Invalid duplicate ticket ID."
 
+def _get_operations_for_action(self, req, ticket, action):
+operations = []
+for controller in TicketSystem(self.env).action_controllers:
+actions = [a for w, a in
+   controller.get_ticket_actions(req, ticket) or []]
+if action in actions:
+operations += controller.actions[action]['operations']
+return operations
+
 def find_ticket(self, ticket_spec):
 ticket = None
 m = re.match(r'#?(?:(?P[^-]+)-)?(?P\d+)', ticket_spec)

Modified: bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_ticket.html
URL: 
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_ticket.html?rev=1560601&r1=1560600&r2=1560601&view=diff
==
--- bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_ticket.html 
(original)
+++ bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_ticket.html Thu Jan 
23 07:08:51 2014
@@ -162,10 +162,13 @@
 }
 
 function install_workflow(){
-  
-  var act = $('#action_resolve_resolve_resolution').parent();
-  act.append('Duplicate 
ID: ');
-  
+  /**/
   var actions_box = $('#workflow-actions')
   .click(function(e) { e.stopPropagation(); });
   

svn commit: r1560599 - /bloodhound/trunk/bloodhound_relations/bhrelations/api.py

2014-01-22 Thread rjollos
Author: rjollos
Date: Thu Jan 23 07:03:26 2014
New Revision: 1560599

URL: http://svn.apache.org/r1560599
Log:
0.8dev: Part of [1560598]. Refs #742.

Modified:
bloodhound/trunk/bloodhound_relations/bhrelations/api.py

Modified: bloodhound/trunk/bloodhound_relations/bhrelations/api.py
URL: 
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_relations/bhrelations/api.py?rev=1560599&r1=1560598&r2=1560599&view=diff
==
--- bloodhound/trunk/bloodhound_relations/bhrelations/api.py (original)
+++ bloodhound/trunk/bloodhound_relations/bhrelations/api.py Thu Jan 23 
07:03:26 2014
@@ -37,7 +37,6 @@ from trac.db import DatabaseManager
 from trac.resource import (ResourceSystem, Resource, ResourceNotFound,
get_resource_shortname, Neighborhood)
 from trac.ticket import Ticket, ITicketManipulator, ITicketChangeListener
-from trac.ticket.api import TicketSystem
 from trac.util.datefmt import utc, to_utimestamp
 from trac.web.chrome import ITemplateProvider
 
@@ -522,9 +521,7 @@ class TicketRelationsSpecifics(Component
 )
 
 def _check_blockers(self, req, ticket):
-action = req.args.get('action')
-operations = self._get_operations_for_action(req, ticket, action)
-if 'set_resolution' in operations:
+if req.args.get('action') == 'resolve':
 blockers = self.rls.find_blockers(ticket, self.is_blocker)
 if blockers:
 blockers_str = ', '.join(
@@ -536,9 +533,7 @@ class TicketRelationsSpecifics(Component
 yield None, msg
 
 def _check_open_children(self, req, ticket):
-action = req.args.get('action')
-operations = self._get_operations_for_action(req, ticket, action)
-if 'set_resolution' in operations:
+if req.args.get('action') == 'resolve':
 for relation in [r for r in self.rls.get_relations(ticket)
  if r['type'] == self.rls.CHILDREN_RELATION_TYPE]:
 ticket = 
self._create_ticket_by_full_id(relation['destination'])
@@ -548,10 +543,8 @@ class TicketRelationsSpecifics(Component
 yield None, msg
 
 def _check_duplicate_id(self, req, ticket):
-action = req.args.get('action')
-operations = self._get_operations_for_action(req, ticket, action)
-if 'set_resolution' in operations:
-resolution = req.args.get('action_%s_resolve_resolution' % action)
+if req.args.get('action') == 'resolve':
+resolution = req.args.get('action_resolve_resolve_resolution')
 if resolution == 'duplicate':
 duplicate_id = req.args.get('duplicate_id')
 if not duplicate_id:
@@ -565,15 +558,6 @@ class TicketRelationsSpecifics(Component
 except NoSuchTicketError:
 yield None, "Invalid duplicate ticket ID."
 
-def _get_operations_for_action(self, req, ticket, action):
-operations = []
-for controller in TicketSystem(self.env).action_controllers:
-actions = [a for w, a in
-   controller.get_ticket_actions(req, ticket) or []]
-if action in actions:
-operations += controller.actions[action]['operations']
-return operations
-
 def find_ticket(self, ticket_spec):
 ticket = None
 m = re.match(r'#?(?:(?P[^-]+)-)?(?P\d+)', ticket_spec)




Re: [Apache Bloodhound] #742: Duplicate relation can't be set on action other than "fixed"

2014-01-22 Thread Apache Bloodhound
#742: Duplicate relation can't be set on action other than "fixed"
+---
  Reporter:  rjollos|  Owner:  rjollos
  Type:  defect | Status:  closed
  Priority:  major  |  Milestone:  Release 8
 Component:  relations  |Version:
Resolution:  fixed  |   Keywords:
+---
Changes (by rjollos):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 (In [1560598])

 0.8dev: //resolve as duplicate// now works correctly for any action with
 the `set_resolution` operation. Refs #742.

 Previously, the //Duplicate ID// input would not be displayed for any
 action other than //resolve//. Also the `duplicate` attribute would only
 be bound in `ITicketManipulator` when the action was named `resolve`.

 Now a //Duplicate ID// input will be attached to the workflow action and
 the `duplicate` attribute will be bound by `ITicketManipulator` for any
 action with the `set_resolution` operation. This has been tested and
 functions property when there are multiple actions that specify the
 `set_resolution` operation.

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker


svn commit: r1560598 - /bloodhound/trunk/bloodhound_relations/bhrelations/api.py

2014-01-22 Thread rjollos
Author: rjollos
Date: Thu Jan 23 07:00:33 2014
New Revision: 1560598

URL: http://svn.apache.org/r1560598
Log:
0.8dev: //resolve as duplicate// now works correctly for any action with the 
`set_resolution` operation. Refs #742.

Previously, the //Duplicate ID// input would not be displayed for any action 
other than //resolve//. Also the `duplicate` attribute would only be bound in 
`ITicketManipulator` when the action was named `resolve`.

Now a //Duplicate ID// input will be attached to the workflow action and the 
`duplicate` attribute will be bound by `ITicketManipulator` for any action with 
the `set_resolution` operation. This has been tested and functions property 
when there are multiple actions that specify the `set_resolution` operation.


Modified:
bloodhound/trunk/bloodhound_relations/bhrelations/api.py

Modified: bloodhound/trunk/bloodhound_relations/bhrelations/api.py
URL: 
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_relations/bhrelations/api.py?rev=1560598&r1=1560597&r2=1560598&view=diff
==
--- bloodhound/trunk/bloodhound_relations/bhrelations/api.py (original)
+++ bloodhound/trunk/bloodhound_relations/bhrelations/api.py Thu Jan 23 
07:00:33 2014
@@ -37,6 +37,7 @@ from trac.db import DatabaseManager
 from trac.resource import (ResourceSystem, Resource, ResourceNotFound,
get_resource_shortname, Neighborhood)
 from trac.ticket import Ticket, ITicketManipulator, ITicketChangeListener
+from trac.ticket.api import TicketSystem
 from trac.util.datefmt import utc, to_utimestamp
 from trac.web.chrome import ITemplateProvider
 
@@ -521,7 +522,9 @@ class TicketRelationsSpecifics(Component
 )
 
 def _check_blockers(self, req, ticket):
-if req.args.get('action') == 'resolve':
+action = req.args.get('action')
+operations = self._get_operations_for_action(req, ticket, action)
+if 'set_resolution' in operations:
 blockers = self.rls.find_blockers(ticket, self.is_blocker)
 if blockers:
 blockers_str = ', '.join(
@@ -533,7 +536,9 @@ class TicketRelationsSpecifics(Component
 yield None, msg
 
 def _check_open_children(self, req, ticket):
-if req.args.get('action') == 'resolve':
+action = req.args.get('action')
+operations = self._get_operations_for_action(req, ticket, action)
+if 'set_resolution' in operations:
 for relation in [r for r in self.rls.get_relations(ticket)
  if r['type'] == self.rls.CHILDREN_RELATION_TYPE]:
 ticket = 
self._create_ticket_by_full_id(relation['destination'])
@@ -543,8 +548,10 @@ class TicketRelationsSpecifics(Component
 yield None, msg
 
 def _check_duplicate_id(self, req, ticket):
-if req.args.get('action') == 'resolve':
-resolution = req.args.get('action_resolve_resolve_resolution')
+action = req.args.get('action')
+operations = self._get_operations_for_action(req, ticket, action)
+if 'set_resolution' in operations:
+resolution = req.args.get('action_%s_resolve_resolution' % action)
 if resolution == 'duplicate':
 duplicate_id = req.args.get('duplicate_id')
 if not duplicate_id:
@@ -558,6 +565,15 @@ class TicketRelationsSpecifics(Component
 except NoSuchTicketError:
 yield None, "Invalid duplicate ticket ID."
 
+def _get_operations_for_action(self, req, ticket, action):
+operations = []
+for controller in TicketSystem(self.env).action_controllers:
+actions = [a for w, a in
+   controller.get_ticket_actions(req, ticket) or []]
+if action in actions:
+operations += controller.actions[action]['operations']
+return operations
+
 def find_ticket(self, ticket_spec):
 ticket = None
 m = re.match(r'#?(?:(?P[^-]+)-)?(?P\d+)', ticket_spec)




[Apache Bloodhound] #745: Edit workflow dialog may be partially hidden by activity feed

2014-01-22 Thread Apache Bloodhound
#745: Edit workflow dialog may be partially hidden by activity feed
---+---
 Reporter:  rjollos|  Owner:  nobody
 Type:  defect | Status:  new
 Priority:  major  |  Milestone:  Release 9
Component:  ui design  |Version:
 Keywords: |
---+---
 To reproduce:
  * Go to an open ticket and select //Modify Ticket//
  * Click on the status and select //resolve as duplicate//. Enter some
 nonsense for the duplicate ID such as //abc//.
  * //Submit changes//
  * **Secondary issue**: When the page refreshes, the following warning is
 displayed **outside** the visible area of the screen:
  {{{#!html
 
 ×
   Warning
   Invalid duplicate ticket ID.
   
 }}}
  * Select //Modify ticket// again and expand the workflow drop-down. It is
 hidden because the `ticketdraft` class has the rule //overflow: auto//.

 [[Image(WorkflowHidden.png,100%)]]

  * **Secondary Issue**: Click //Cancel// and the draft image is still
 displayed in the ticket properties.

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker


svn commit: r1560582 - in /bloodhound/trunk: bloodhound_multiproduct/multiproduct/ bloodhound_multiproduct/tests/ bloodhound_relations/bhrelations/ bloodhound_relations/bhrelations/tests/ bloodhound_s

2014-01-22 Thread rjollos
Author: rjollos
Date: Thu Jan 23 03:47:17 2014
New Revision: 1560582

URL: http://svn.apache.org/r1560582
Log:
0.8dev: Utilize database API for handling exceptions.

This resolves issues reported by Saint Germain when `python-pysqlite2` is 
installed in the environment.

Modified:
bloodhound/trunk/bloodhound_multiproduct/multiproduct/env.py
bloodhound/trunk/bloodhound_multiproduct/tests/env.py
bloodhound/trunk/bloodhound_multiproduct/tests/model.py
bloodhound/trunk/bloodhound_multiproduct/tests/upgrade.py
bloodhound/trunk/bloodhound_relations/bhrelations/search.py
bloodhound/trunk/bloodhound_relations/bhrelations/tests/api.py
bloodhound/trunk/bloodhound_relations/bhrelations/tests/base.py
bloodhound/trunk/bloodhound_search/bhsearch/tests/security.py

Modified: bloodhound/trunk/bloodhound_multiproduct/multiproduct/env.py
URL: 
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_multiproduct/multiproduct/env.py?rev=1560582&r1=1560581&r2=1560582&view=diff
==
--- bloodhound/trunk/bloodhound_multiproduct/multiproduct/env.py (original)
+++ bloodhound/trunk/bloodhound_multiproduct/multiproduct/env.py Thu Jan 23 
03:47:17 2014
@@ -21,7 +21,6 @@
 
 import os.path
 from urlparse import urlsplit
-from sqlite3 import OperationalError
 
 from trac.config import BoolOption, ConfigSection, Option
 from trac.core import Component, ComponentManager, ExtensionPoint, implements, 
\

Modified: bloodhound/trunk/bloodhound_multiproduct/tests/env.py
URL: 
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_multiproduct/tests/env.py?rev=1560582&r1=1560581&r2=1560582&view=diff
==
--- bloodhound/trunk/bloodhound_multiproduct/tests/env.py (original)
+++ bloodhound/trunk/bloodhound_multiproduct/tests/env.py Thu Jan 23 03:47:17 
2014
@@ -23,7 +23,6 @@ from inspect import stack
 import os.path
 import shutil
 import tempfile
-from sqlite3 import OperationalError
 from tests import unittest
 from types import MethodType
 
@@ -230,7 +229,7 @@ class MultiproductTestCase(unittest.Test
 mpsystem = MultiProductSystem(env)
 try:
 mpsystem.upgrade_environment(env.db_transaction)
-except OperationalError:
+except env.db_exc.OperationalError:
 # Database is upgraded, but database version was deleted.
 # Complete the upgrade by inserting default product.
 mpsystem._insert_default_product(env.db_transaction)
@@ -310,7 +309,7 @@ class ProductEnvApiTestCase(Multiproduct
 if self.env is not None:
 try:
 self.env.reset_db()
-except OperationalError:
+except self.env.db_exc.OperationalError:
 # "Database not found ...",
 # "OperationalError: no such table: system" or the like
 pass
@@ -575,7 +574,7 @@ class ProductEnvHrefTestCase(Multiproduc
 if self.env is not None:
 try:
 self.env.reset_db()
-except OperationalError:
+except self.env.db_exc.OperationalError:
 # "Database not found ...",
 # "OperationalError: no such table: system" or the like
 pass

Modified: bloodhound/trunk/bloodhound_multiproduct/tests/model.py
URL: 
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_multiproduct/tests/model.py?rev=1560582&r1=1560581&r2=1560582&view=diff
==
--- bloodhound/trunk/bloodhound_multiproduct/tests/model.py (original)
+++ bloodhound/trunk/bloodhound_multiproduct/tests/model.py Thu Jan 23 03:47:17 
2014
@@ -19,7 +19,6 @@
 """Tests for multiproduct/model.py"""
 import shutil
 import tempfile
-from sqlite3 import OperationalError
 from tests import unittest
 
 from trac.core import TracError
@@ -46,7 +45,7 @@ class ProductTestCase(unittest.TestCase)
 self.mpsystem = MultiProductSystem(self.env)
 try:
 self.mpsystem.upgrade_environment(self.env.db_transaction)
-except OperationalError:
+except self.env.db_exc.OperationalError:
 # table remains but database version is deleted
 pass
 

Modified: bloodhound/trunk/bloodhound_multiproduct/tests/upgrade.py
URL: 
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_multiproduct/tests/upgrade.py?rev=1560582&r1=1560581&r2=1560582&view=diff
==
--- bloodhound/trunk/bloodhound_multiproduct/tests/upgrade.py (original)
+++ bloodhound/trunk/bloodhound_multiproduct/tests/upgrade.py Thu Jan 23 
03:47:17 2014
@@ -21,7 +21,6 @@ import os
 import shutil
 import tempfile
 import uuid
-from sqlite3 import OperationalError
 from contextlib import contextmanager
 from tests import unittest
 
@@ -434,13 +433,13 @@ class

svn commit: r1560571 - in /bloodhound/trunk/bloodhound_theme/bhtheme/templates: bh_changeset.html bh_diff_form.html bh_roadmap.html

2014-01-22 Thread rjollos
Author: rjollos
Date: Thu Jan 23 01:52:03 2014
New Revision: 1560571

URL: http://svn.apache.org/r1560571
Log:
0.8dev: Reverse merge incorrect commit [1560568].

Modified:
bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_changeset.html
bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_diff_form.html
bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_roadmap.html

Modified: bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_changeset.html
URL: 
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_changeset.html?rev=1560571&r1=1560570&r2=1560571&view=diff
==
--- bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_changeset.html 
(original)
+++ bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_changeset.html Thu 
Jan 23 01:52:03 2014
@@ -1,3 +1,22 @@
+
+
 http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>

Modified: bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_diff_form.html
URL: 
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_diff_form.html?rev=1560571&r1=1560570&r2=1560571&view=diff
==
--- bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_diff_form.html 
(original)
+++ bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_diff_form.html Thu 
Jan 23 01:52:03 2014
@@ -1,3 +1,22 @@
+
+
 http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>

Modified: bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_roadmap.html
URL: 
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_roadmap.html?rev=1560571&r1=1560570&r2=1560571&view=diff
==
--- bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_roadmap.html 
(original)
+++ bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_roadmap.html Thu Jan 
23 01:52:03 2014
@@ -1,3 +1,22 @@
+
+
 http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>




svn commit: r1560569 - /bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_ticket.html

2014-01-22 Thread rjollos
Author: rjollos
Date: Thu Jan 23 01:46:25 2014
New Revision: 1560569

URL: http://svn.apache.org/r1560569
Log:
0.8dev: When at global scope, use the `[ticket] default product` as the default 
value. Refs #304.

Before this change, the product select would be set to the empty value and the 
//Create// button would be disabled until a product is selected. That behavior 
is preserved when `[ticket] default product` has not been set.

Modified:
bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_ticket.html

Modified: bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_ticket.html
URL: 
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_ticket.html?rev=1560569&r1=1560568&r2=1560569&view=diff
==
--- bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_ticket.html 
(original)
+++ bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_ticket.html Thu Jan 
23 01:46:25 2014
@@ -57,7 +57,10 @@
 

svn commit: r1560568 - in /bloodhound/trunk/bloodhound_theme/bhtheme/templates: bh_changeset.html bh_diff_form.html bh_roadmap.html

2014-01-22 Thread rjollos
Author: rjollos
Date: Thu Jan 23 01:45:54 2014
New Revision: 1560568

URL: http://svn.apache.org/r1560568
Log:
Show better error message when bloodhound_setup is run in an environment with 
no Trac installed.


git-svn-id: https://svn.apache.org/repos/asf/bloodhound/trunk@1557980 
13f79535-47bb-0310-9956-ffa450edef68


Modified:
bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_changeset.html
bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_diff_form.html
bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_roadmap.html

Modified: bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_changeset.html
URL: 
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_changeset.html?rev=1560568&r1=1560567&r2=1560568&view=diff
==
--- bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_changeset.html 
(original)
+++ bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_changeset.html Thu 
Jan 23 01:45:54 2014
@@ -1,22 +1,3 @@
-
-
 http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>

Modified: bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_diff_form.html
URL: 
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_diff_form.html?rev=1560568&r1=1560567&r2=1560568&view=diff
==
--- bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_diff_form.html 
(original)
+++ bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_diff_form.html Thu 
Jan 23 01:45:54 2014
@@ -1,22 +1,3 @@
-
-
 http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>

Modified: bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_roadmap.html
URL: 
http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_roadmap.html?rev=1560568&r1=1560567&r2=1560568&view=diff
==
--- bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_roadmap.html 
(original)
+++ bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_roadmap.html Thu Jan 
23 01:45:54 2014
@@ -1,22 +1,3 @@
-
-
 http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>




Re: [Apache Bloodhound] #741: Update Whoosh dependency

2014-01-22 Thread Apache Bloodhound
#741: Update Whoosh dependency
---+---
  Reporter:  SaintGermain  |  Owner:  nobody
  Type:  enhancement   | Status:  new
  Priority:  major |  Milestone:  Unscheduled
 Component:  search|Version:  0.7.0
Resolution:|   Keywords:  whoosh search
---+---

Comment (by SaintGermain):

 I would need some guidance to see if we need additional tests.
 Can someone confirm that:
 * tests of the Whoosh API is done in
 bloodhound_search/bhsearch/tests/whoosh_backend.py
 * tests of the search through the web interface is done in
 bloodhound_search/bhsearch/tests/web_ui.py
 * is the tests through the web interface means that we are testing through
 the URL or through the Search box ?

 In addition it seems that the call to the search backend is not
 "protected" from exception.
 If the backend failed with an exception, what should be the behavior ?
 Do we return an empty result or an error message ?

 Thanks !

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker


Re: [Apache Bloodhound] #668: Negative integers for ticket IDs

2014-01-22 Thread Apache Bloodhound
#668: Negative integers for ticket IDs
---+---
  Reporter:  olemis|  Owner:  rjollos
  Type:  defect| Status:  closed
  Priority:  blocker   |  Milestone:  Release 8
 Component:  multiproduct  |Version:
Resolution:  fixed |   Keywords:  bep-0010 , postgresql
---+---

Comment (by olemis):

 Both #653 and #744 marked as duplicates of this ticket .

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker


Re: [Apache Bloodhound] #653: Notification error on (product) batch modifications

2014-01-22 Thread Apache Bloodhound
#653: Notification error on (product) batch modifications
+--
  Reporter:  olemis |  Owner:  nobody
  Type:  defect | Status:  closed
  Priority:  major  |  Milestone:  Release 8
 Component:  trac core  |Version:  0.7.0
Resolution:  duplicate  |   Keywords:  ticket, batch, notitfication
+--
Changes (by olemis):

 * status:  new => closed
 * component:  multiproduct => trac core
 * version:   => 0.7.0
 * milestone:   => Release 8
 * keywords:  ticket, batch => ticket, batch, notitfication
 * resolution:   => duplicate


Comment:

 This is a duplicate of #688 , see comment:15:ticket:688

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker


Re: [Apache Bloodhound] #744: Error on creating a ticket relation between products

2014-01-22 Thread Apache Bloodhound
#744: Error on creating a ticket relation between products
+-
  Reporter:  jav|  Owner:  nobody
  Type:  defect | Status:  closed
  Priority:  major  |  Milestone:  Release 8
 Component:  trac core  |Version:  0.7.0
Resolution:  duplicate  |   Keywords:  ticket notification
+-
Changes (by olemis):

 * status:  new => closed
 * keywords:   => ticket notification
 * component:  relations => trac core
 * resolution:   => duplicate
 * milestone:   => Release 8


Comment:

 This is a duplicate of #688 , see comment:15:ticket:688

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker


[Apache Bloodhound] #744: Error on creating a ticket relation between products

2014-01-22 Thread Apache Bloodhound
#744: Error on creating a ticket relation between products
---+
 Reporter:  jav|  Owner:  nobody
 Type:  defect | Status:  new
 Priority:  major  |  Milestone:
Component:  relations  |Version:  0.7.0
 Keywords: |
---+
  How to Reproduce 
 Creating a relation (type: referrs to) between two tickets in different
 products results in an error message.
 {{{
 UnboundLocalError: local variable 'reporter' referenced before assignment
 }}}

 While doing a POST operation on `/ticket/65/relations`, Trac issued an
 internal error.

 ''(please provide additional details here)''

 Request parameters:
 {{{
 {'__FORM_TOKEN': u'd39f62b5d7ceb17d806ee511',
  'add': u'Add',
  'comment': u'',
  'dest_tid': u'66',
  'id': u'65',
  'reltype': u'refersto'}
 }}}

 User agent: `Mozilla/5.0 (X11; Linux x86_64; rv:26.0) Gecko/20100101
 Firefox/26.0`

  System Information 
 || '''`Trac`''' || `1.0.1` [[br]] `` ||
 || '''`Babel`''' || `0.9.6` ||
 || '''`Bloodhound Trac`''' || `1.0.1` ||
 || '''`Genshi`''' || `0.6.1 (without speedups)` ||
 || '''`GIT`''' || `1.8.1.4` ||
 || '''`mod_wsgi`''' || `3.3 (WSGIProcessGroup bh_tracker
 WSGIApplicationGroup %{GLOBAL})` ||
 || '''`psycopg2`''' || `2.4.5` ||
 || '''`Pygments`''' || `1.6` ||
 || '''`Python`''' || `2.7.3 (default, Apr 14 2012, 08:58:41) [GCC]` ||
 || '''`pytz`''' || `2013b` ||
 || '''`setuptools`''' || `1.1` ||
 || '''`jQuery`''' || `1.7.2` ||

  Enabled Plugins 
 || '''`BloodhoundDashboardPlugin`''' || `0.7.0` ||
 || '''`BloodhoundMultiProduct`''' || `0.7.0` ||
 || '''`BloodhoundRelationsPlugin`''' || `0.7.0` ||
 || '''`BloodhoundSearchPlugin`''' || `0.7.0` ||
 || '''`BloodhoundTheme`''' || `0.7.0` ||
 || '''`TracAccountManager`''' || `0.4.3` ||
 || '''`TracPermRedirect`''' || `3.0` ||
 || '''`TracThemeEngine`''' || `2.2.1` ||

  Python Traceback 
 {{{
 Traceback (most recent call last):
   File "/opt/apache-bloodhound-0.7/installer/bloodhound/lib/python2.7
 /site-packages/trac/web/main.py", line 477, in _dispatch_request
 dispatcher.dispatch(req)
   File "/opt/apache-bloodhound-0.7/installer/bloodhound/lib/python2.7
 /site-packages/trac/web/main.py", line 214, in dispatch
 resp = chosen_handler.process_request(req)
   File "/opt/apache-bloodhound-0.7/installer/bloodhound/lib/python2.7
 /site-packages/bhrelations/web_ui.py", line 99, in process_request
 req.authname)
   File "/opt/apache-bloodhound-0.7/installer/bloodhound/lib/python2.7
 /site-packages/bhrelations/api.py", line 252, in add
 self.add_relation(relation)
   File "/opt/apache-bloodhound-0.7/installer/bloodhound/lib/python2.7
 /site-packages/bhrelations/api.py", line 273, in add_relation
 RelationNotifyEmail(self.env).notify(relation)
   File "/opt/apache-bloodhound-0.7/installer/bloodhound/lib/python2.7
 /site-packages/bhrelations/notification.py", line 47, in notify
 TicketNotifyEmail.notify(self, t, newticket=False, modtime=modtime)
   File "/opt/apache-bloodhound-0.7/installer/bloodhound/lib/python2.7
 /site-packages/trac/ticket/notification.py", line 156, in notify
 self._notify(ticket, newticket, modtime)
   File "/opt/apache-bloodhound-0.7/installer/bloodhound/lib/python2.7
 /site-packages/trac/ticket/notification.py", line 270, in _notify
 NotifyEmail.notify(self, ticket.id, subject, author)
   File "/opt/apache-bloodhound-0.7/installer/bloodhound/lib/python2.7
 /site-packages/trac/notification.py", line 344, in notify
 Notify.notify(self, resid)
   File "/opt/apache-bloodhound-0.7/installer/bloodhound/lib/python2.7
 /site-packages/trac/notification.py", line 230, in notify
 (torcpts, ccrcpts) = self.get_recipients(resid)
   File "/opt/apache-bloodhound-0.7/installer/bloodhound/lib/python2.7
 /site-packages/bhrelations/notification.py", line 73, in get_recipients
 resource.id, [])
   File "/opt/apache-bloodhound-0.7/installer/bloodhound/lib/python2.7
 /site-packages/trac/ticket/notification.py", line 129, in
 get_ticket_notification_recipients
 return (torecipients, ccrecipients, reporter, owner)
 UnboundLocalError: local variable 'reporter' referenced before assignment
 }}}

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker