Re: [Apache Bloodhound] #772: Many multiproduct test modules can't be executed in isolation

2014-02-27 Thread Apache Bloodhound
#772: Many multiproduct test modules can't be executed in isolation
---+--
  Reporter:  rjollos   |  Owner:  olemis
  Type:  defect| Status:  accepted
  Priority:  major |  Milestone:
 Component:  multiproduct  |Version:
Resolution:|   Keywords:
---+--
Changes (by olemis):

 * owner:  nobody => olemis
 * status:  new => accepted


-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker


[Apache Bloodhound] #772: Many multiproduct test modules can't be executed in isolation

2014-02-27 Thread Apache Bloodhound
#772: Many multiproduct test modules can't be executed in isolation
--+
 Reporter:  rjollos   |  Owner:  nobody
 Type:  defect| Status:  new
 Priority:  major |  Milestone:
Component:  multiproduct  |Version:
 Keywords:|
--+
 There are several cases in which executing the entire test suit succeeds,
 however executing the test suite in single module results in failures. For
 example,
 {{{#!pycon
 $ PYTHONPATH=. python -m tests.attachment
 EE
 ==
 ERROR: test_delete (__main__.ProductAttachmentTestCase)
 --
 Traceback (most recent call last):
   File
 
"/home/user/Workspace/bhdev/bloodhound.git/bloodhound_multiproduct/tests/attachment.py",
 line 39, in setUp
 self.global_env = self.env
 AttributeError: 'ProductAttachmentTestCase' object has no attribute 'env'

 ...

 ==
 ERROR: test_select_empty (__main__.ProductAttachmentTestCase)
 --
 Traceback (most recent call last):
   File
 
"/home/user/Workspace/bhdev/bloodhound.git/bloodhound_multiproduct/tests/attachment.py",
 line 39, in setUp
 self.global_env = self.env
 AttributeError: 'ProductAttachmentTestCase' object has no attribute 'env'

 --
 Ran 14 tests in 0.173s

 FAILED (errors=14)
 }}}

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker


Re: [Apache Bloodhound] #570: Bootstrap template for product_edit.html

2014-02-27 Thread Apache Bloodhound
#570: Bootstrap template for product_edit.html
--+--
  Reporter:  rjollos  |  Owner:  nobody
  Type:  enhancement  | Status:  new
  Priority:  major|  Milestone:  next 0.x
 Component:  ui design|Version:
Resolution:   |   Keywords:  starter
--+--
Changes (by olemis):

 * component:  dashboard => ui design


-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker


Re: [Apache Bloodhound] #769: Move multiproduct changes to resource module from trac.resource to multiproduct.resource

2014-02-27 Thread Apache Bloodhound
#769: Move multiproduct changes to resource module from trac.resource to
multiproduct.resource
---+---
  Reporter:  rjollos   |  Owner:  rjollos
  Type:  enhancement   | Status:  new
  Priority:  major |  Milestone:  Release 8
 Component:  multiproduct  |Version:
Resolution:|   Keywords:
---+---

Comment (by olemis):

 Ok , jfyi , once upon a time I tried to do so , but noticed that there are
 many imports hard-coded all over Trac source code . Therefore the
 replacement techniques used for environments were not as easy to reproduce
 in this case , thus leaving dangling references to the old resource
 classes (e.g. lacking on neighborhood support) instead of the new ones .
 That's why I did not separate them since the beginning . This is an
 important aspect to consider . The goal of this ticket is convenient ,
 that's sure , so I look forward to review the patch once it will be
 available .

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker


Re: [Apache Bloodhound] #770: Location of test cases for bloodhound_multiproduct is not consistent with other projects

2014-02-27 Thread Apache Bloodhound
#770: Location of test cases for bloodhound_multiproduct is not consistent with
other projects
---+
  Reporter:  rjollos   |  Owner:  nobody
  Type:  defect| Status:  new
  Priority:  major |  Milestone:
 Component:  multiproduct  |Version:
Resolution:|   Keywords:
---+

Comment (by olemis):

 Replying to [comment:2 rjollos]:
 > Do you have a reason other than just personal preference? Trac has
 already chosen to locate tests in a `tests` subdirectory of the module.

 I really do not recommend doing this .

 > In general, it is logical to maintain consistency with Trac on things
 like this (and code style issue),

 I do not think that's a good reference to follow

 > unless there is a solid argument to go a different direction, and the
 argument can cite significant advantages.

 ... considering the facts in comment:3

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker


Re: [Apache Bloodhound] #770: Location of test cases for bloodhound_multiproduct is not consistent with other projects

2014-02-27 Thread Apache Bloodhound
#770: Location of test cases for bloodhound_multiproduct is not consistent with
other projects
---+
  Reporter:  rjollos   |  Owner:  nobody
  Type:  defect| Status:  new
  Priority:  major |  Milestone:
 Component:  multiproduct  |Version:
Resolution:|   Keywords:
---+

Comment (by olemis):

 Well , the reasons are :

   1. Having a single top-level tests module (as opposite to Trac's
 scattered test modules)
  is convenient considering the package test discovery code
   2. For code with functional + unit tests (i.e. quite often) I prefer to
 write tests in a separate
  package hierarchy because :
  * they should not be installed in production deployments
  * they might be packaged and distributed independently should they be
 run against a
given source tree to identify a certain issue , but then discarded
  * in practice there might be no need to import top-level source tree
 in order to
import top-level test module and contained test code especially if
 writing functional tests
   - you'll need other dependencies instead e.g. [pypi:selenium] ,
 [pypi:twill] , stdlid `xmlrpclib` ...
   - and even for unit tests the top-level source package may always be
 imported
 and resources located with the help of `pkg_resources`
   3. other references
  * https://pytest.org/latest/goodpractises.html#choosing-a-test-
 layout-import-rules
  * http://stackoverflow.com/questions/5341006/where-should-i-put-
 tests-when-packaging-python-modules
  * http://stackoverflow.com/questions/61151/where-do-the-python-unit-
 tests-go

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker


Re: [Apache Bloodhound] #769: Move multiproduct changes to resource module from trac.resource to multiproduct.resource

2014-02-27 Thread Apache Bloodhound
#769: Move multiproduct changes to resource module from trac.resource to
multiproduct.resource
---+---
  Reporter:  rjollos   |  Owner:  rjollos
  Type:  enhancement   | Status:  new
  Priority:  major |  Milestone:  Release 8
 Component:  multiproduct  |Version:
Resolution:|   Keywords:
---+---
Changes (by rjollos):

 * milestone:   => Release 8


Comment:

 Patch will posted to this ticket soon.

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker


[Apache Bloodhound] Batch modify: #652, #739

2014-02-27 Thread Apache Bloodhound
Batch modification to #652, #739 by rjollos:
milestone to Release 9

-- 
Tickets URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker


[Apache Bloodhound] Batch modify: #613, #652, #654, #681, #685, #688, #705, #730, #388, #602, #618, #658, #680, #416, #424, #427, #501, #545, #553, #554, #570, #578, #587, #615, #632, #636, #650, #659

2014-02-27 Thread Apache Bloodhound
Batch modification to #613, #652, #654, #681, #685, #688, #705, #730, #388, 
#602, #618, #658, #680, #416, #424, #427, #501, #545, #553, #554, #570, #578, 
#587, #615, #632, #636, #650, #659, #661, #678, #679, #686, #739, #749, #761, 
#763, #567, #583, #651, #747 by rjollos:
milestone to next 0.x

Comment:
Moving tickets forward that probably won't be completed for 0.9 release. 
Tickets can be rescheduled for release 0.9 once work has started.

-- 
Tickets URL: 

Apache Bloodhound 
The Apache Bloodhound issue tracker


Re: [Apache Bloodhound] #634: Ticket comments overlap edit workflow drop-down dialog

2014-02-27 Thread Apache Bloodhound
#634: Ticket comments overlap edit workflow drop-down dialog
+---
  Reporter:  rjollos|  Owner:  nobody
  Type:  defect | Status:  new
  Priority:  minor  |  Milestone:  Release 9
 Component:  relations  |Version:  0.6.0
Resolution: |   Keywords:
+---

Comment (by rjollos):

 #745 closed as duplicate. More info can be found in that ticket.

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker


Re: [Apache Bloodhound] #771: Improve test case coverage for trac-admin command

2014-02-27 Thread Apache Bloodhound
#771: Improve test case coverage for trac-admin command
---+
  Reporter:  rjollos   |  Owner:  nobody
  Type:  defect| Status:  new
  Priority:  major |  Milestone:  Release 9
 Component:  multiproduct  |Version:
Resolution:|   Keywords:  trac-1.0.2
---+
Changes (by rjollos):

 * keywords:   => trac-1.0.2


-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker


Re: [Apache Bloodhound] #745: Edit workflow dialog may be partially hidden by activity feed

2014-02-27 Thread Apache Bloodhound
#745: Edit workflow dialog may be partially hidden by activity feed
+
  Reporter:  rjollos|  Owner:  nobody
  Type:  defect | Status:  closed
  Priority:  major  |  Milestone:
 Component:  ui design  |Version:
Resolution:  duplicate  |   Keywords:
+
Changes (by rjollos):

 * status:  new => closed
 * resolution:   => duplicate


-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker


Re: [Apache Bloodhound] #745: Edit workflow dialog may be partially hidden by activity feed

2014-02-27 Thread Apache Bloodhound
#745: Edit workflow dialog may be partially hidden by activity feed
+
  Reporter:  rjollos|  Owner:  nobody
  Type:  defect | Status:  new
  Priority:  major  |  Milestone:
 Component:  ui design  |Version:
Resolution: |   Keywords:
+
Changes (by rjollos):

 * status:  closed => new
 * resolution:  wontfix =>


-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker


Re: [Apache Bloodhound] #745: Edit workflow dialog may be partially hidden by activity feed

2014-02-27 Thread Apache Bloodhound
#745: Edit workflow dialog may be partially hidden by activity feed
+
  Reporter:  rjollos|  Owner:  nobody
  Type:  defect | Status:  closed
  Priority:  major  |  Milestone:
 Component:  ui design  |Version:
Resolution:  wontfix|   Keywords:
+
Changes (by rjollos):

 * status:  new => closed
 * resolution:   => wontfix
 * milestone:  Release 9 =>


Comment:

 Duplicate of #634.

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker


Re: [Apache Bloodhound] #570: Bootstrap template for product_edit.html

2014-02-27 Thread Apache Bloodhound
#570: Bootstrap template for product_edit.html
--+---
  Reporter:  rjollos  |  Owner:  nobody
  Type:  enhancement  | Status:  new
  Priority:  major|  Milestone:  Release 9
 Component:  dashboard|Version:
Resolution:   |   Keywords:  starter
--+---
Changes (by rjollos):

 * keywords:   => starter
 * owner:   => nobody
 * component:   => dashboard


-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker