Re: [Apache Bloodhound] #795: request_factory and environment_factory options point to files in the bloodhound source directory

[Apache Bloodhound]

#795: request_factory and environment_factory options point to files in the
bloodhound source directory
+---
  Reporter:  rjollos|  Owner:  rjollos
  Type:  defect | Status:  closed
  Priority:  major  |  Milestone:  Release 8
 Component:  installer  |Version:
Resolution:  fixed  |   Keywords:
+---

Comment (by rjollos):

 Brief upgrade documentation added in BloodhoundUpgrade@4.

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #795: request_factory and environment_factory options point to files in the bloodhound source directory

[Apache Bloodhound]

#795: request_factory and environment_factory options point to files in the
bloodhound source directory
+---
  Reporter:  rjollos|  Owner:  rjollos
  Type:  defect | Status:  closed
  Priority:  major  |  Milestone:  Release 8
 Component:  installer  |Version:
Resolution:  fixed  |   Keywords:
+---
Changes (by rjollos):

 * status:  accepted => closed
 * resolution:   => fixed


-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #795: request_factory and environment_factory options point to files in the bloodhound source directory

[Apache Bloodhound]

#795: request_factory and environment_factory options point to files in the
bloodhound source directory
+---
  Reporter:  rjollos|  Owner:  rjollos
  Type:  defect | Status:  accepted
  Priority:  major  |  Milestone:  Release 8
 Component:  installer  |Version:
Resolution: |   Keywords:
+---

Comment (by rjollos):

 The changes in this ticket will require edits to the `[trac]`
 configuration section. We haven't implemented an automatic upgrade step
 and I don't imagine finding time to do that anytime soon, so we will end
 up having a manual upgrade step, which will be described in the release
 notes. We don't want to have more manual upgrade steps than necessary. If
 you have a different idea on how this should be implemented, now is the
 time to provide a patch, or at least sketch out the changes in detail so
 that we can discuss.

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #795: request_factory and environment_factory options point to files in the bloodhound source directory

[Apache Bloodhound]

#795: request_factory and environment_factory options point to files in the
bloodhound source directory
+---
  Reporter:  rjollos|  Owner:  rjollos
  Type:  defect | Status:  accepted
  Priority:  major  |  Milestone:  Release 8
 Component:  installer  |Version:
Resolution: |   Keywords:
+---

Comment (by olemis):

 It is possible to deal with this in a separate ticket . This should not be
 a blocker looking forward to [milestone:"Release 8"]

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #795: request_factory and environment_factory options point to files in the bloodhound source directory

[Apache Bloodhound]

#795: request_factory and environment_factory options point to files in the
bloodhound source directory
+---
  Reporter:  rjollos|  Owner:  rjollos
  Type:  defect | Status:  accepted
  Priority:  major  |  Milestone:  Release 8
 Component:  installer  |Version:
Resolution: |   Keywords:
+---

Comment (by rjollos):

 You are welcome to provide a patch to support your opinion.

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #795: request_factory and environment_factory options point to files in the bloodhound source directory

[Apache Bloodhound]

#795: request_factory and environment_factory options point to files in the
bloodhound source directory
+---
  Reporter:  rjollos|  Owner:  rjollos
  Type:  defect | Status:  accepted
  Priority:  major  |  Milestone:  Release 8
 Component:  installer  |Version:
Resolution: |   Keywords:
+---

Comment (by olemis):

 IMO these should be expressed using
 [http://pythonhosted.org/setuptools/pkg_resources.html#entry-points entry
 point notation] (see also stackoverflow:774824) .

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #795: request_factory and environment_factory options point to files in the bloodhound source directory

[Apache Bloodhound]

#795: request_factory and environment_factory options point to files in the
bloodhound source directory
+---
  Reporter:  rjollos|  Owner:  rjollos
  Type:  defect | Status:  accepted
  Priority:  major  |  Milestone:  Release 8
 Component:  installer  |Version:
Resolution: |   Keywords:
+---

Comment (by rjollos):

 (In [1616400])

 0.8dev: Use fully-qualified name for `request_factory` and
 `environment_factory`. Refs #795.

  * For the typically multiproduct environment, `[trac] environment_factory
 = multiproduct.hooks.MultiProductEnvironmentFactory` and `[trac]
 request_factory = multiproduct.hooks.ProductRequestFactory`.
  * Use `abc` module for abstract base classes.

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #795: request_factory and environment_factory options point to files in the bloodhound source directory

[Apache Bloodhound]

#795: request_factory and environment_factory options point to files in the
bloodhound source directory
+---
  Reporter:  rjollos|  Owner:  rjollos
  Type:  defect | Status:  accepted
  Priority:  major  |  Milestone:  Release 8
 Component:  installer  |Version:
Resolution: |   Keywords:
+---

Comment (by rjollos):

 Replying to [comment:4 olemis]:
 > Replying to [comment:2 rjollos]:
 > > Replying to [ticket:795 rjollos]:
 > > > ... or instead refer to component classes.
 > >
 > [...]
 > >  `BootstrapHandlerBase` would also need to be a `Component` class.
 >
 > This part I do not think it is on the right track because
 `BootstrapHandlerBase.open_environment()` is responsible for instantiating
 environments . Should you turn the class into a component then you'd need
 an environment beforehand for the component meant to instantiate an
 environment , thus leading to a chicken egg situation .

 That makes sense. Thanks for the feedback. So maybe I will try to workup a
 patch which doesn't change `BootstrapHandlerBase`, but changes
 `EnvironmentFactoryBase` and `RequestFactoryBase` to be `Component`
 classes.

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #795: request_factory and environment_factory options point to files in the bloodhound source directory

[Apache Bloodhound]

#795: request_factory and environment_factory options point to files in the
bloodhound source directory
+---
  Reporter:  rjollos|  Owner:  rjollos
  Type:  defect | Status:  accepted
  Priority:  major  |  Milestone:  Release 8
 Component:  installer  |Version:
Resolution: |   Keywords:
+---

Comment (by olemis):

 Replying to [comment:2 rjollos]:
 > Replying to [ticket:795 rjollos]:
 > > ... or instead refer to component classes.
 >
 [...]
 >  `BootstrapHandlerBase` would also need to be a `Component` class.

 This part I do not think it is on the right track because
 `BootstrapHandlerBase.open_environment()` is responsible for instantiating
 environments . Should you turn the class into a component then you'd need
 an environment beforehand for the component meant to instantiate an
 environment , thus leading to a chicken egg situation .

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #795: request_factory and environment_factory options point to files in the bloodhound source directory

[Apache Bloodhound]

#795: request_factory and environment_factory options point to files in the
bloodhound source directory
+---
  Reporter:  rjollos|  Owner:  rjollos
  Type:  defect | Status:  accepted
  Priority:  major  |  Milestone:  Release 8
 Component:  installer  |Version:
Resolution: |   Keywords:
+---

Comment (by rjollos):

 New iteration of the patch, but still researching better ways to
 accomplish this: [attachment:t795.2.diff].

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #795: request_factory and environment_factory options point to files in the bloodhound source directory

[Apache Bloodhound]

#795: request_factory and environment_factory options point to files in the
bloodhound source directory
+---
  Reporter:  rjollos|  Owner:  rjollos
  Type:  defect | Status:  accepted
  Priority:  major  |  Milestone:  Release 8
 Component:  installer  |Version:
Resolution: |   Keywords:
+---

Comment (by rjollos):

 Replying to [ticket:795 rjollos]:
 > ... or instead refer to component classes.

 More specifically, `EnvironmentFactoryBase` and `RequestFactoryBase` would
 be component classes. `[trac] request_factory` and `[trac]
 environment_factory` would be `ExtensionOptions`, and
 `self.request_factory`/ `self.environment_factory` would return instances.
 `BootstrapHandlerBase` would also need to be a `Component` class.

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker

Re: [Apache Bloodhound] #795: request_factory and environment_factory options point to files in the bloodhound source directory

[Apache Bloodhound]

#795: request_factory and environment_factory options point to files in the
bloodhound source directory
+---
  Reporter:  rjollos|  Owner:  rjollos
  Type:  defect | Status:  accepted
  Priority:  major  |  Milestone:  Release 8
 Component:  installer  |Version:
Resolution: |   Keywords:
+---
Changes (by rjollos):

 * status:  new => accepted


Comment:

 Proposed change is to use a fully-qualified name for `[trac]
 environment_factory` and `[trac] request_factory`. Patch in
 [attachment:t795.diff].

 `load_class` is from SO:547867/121694, with exception handling added.

-- 
Ticket URL: 
Apache Bloodhound 
The Apache Bloodhound issue tracker