Re: [PR] [CALCITE-6011] Add the RelRule that pushes the Filter past a Window [calcite]
sonarcloud[bot] commented on PR #3439: URL: https://github.com/apache/calcite/pull/3439#issuecomment-1749905947 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_calcite=3439) [](https://sonarcloud.io/project/issues?id=apache_calcite=3439=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite=3439=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_calcite=3439=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite=3439=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_calcite=3439=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_calcite=3439=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3439=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3439=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3439=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_calcite=3439=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_calcite=3439=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_calcite=3439=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_calcite=3439=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_calcite=3439=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_calcite=3439=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_calcite=3439=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-5948] Use explicit casting if element type in ARRAY/MAP does not equal derived component type [calcite]
chucheng92 commented on PR #3395: URL: https://github.com/apache/calcite/pull/3395#issuecomment-1749904911 @tanclary Hi, Tanner, I have updated the commit/jira name and add javadocs. Since it's been a long time, If you have time, can you help to review it again? thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6034] Adds isAutoIncrement and isGenerated arguments to MetaColumn constructor [calcite-avatica]
tanclary commented on PR #229: URL: https://github.com/apache/calcite-avatica/pull/229#issuecomment-1749784973 nit: update commit message and PR description to be imperative (adds -> add) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-5549] Adds isAutoIncrement and isGenerated args to MetaColumn constructor [calcite-avatica]
tjbanghart closed pull request #216: [CALCITE-5549] Adds isAutoIncrement and isGenerated args to MetaColumn constructor URL: https://github.com/apache/calcite-avatica/pull/216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [CALCITE-6034] Adds isAutoIncrement and isGenerated arguments to MetaColumn constructor [calcite-avatica]
tjbanghart opened a new pull request, #229: URL: https://github.com/apache/calcite-avatica/pull/229 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[calcite-avatica] branch tjbanghart/5549 updated (f4ce2b893 -> 0c9d0b1b4)
This is an automated email from the ASF dual-hosted git repository. tjbanghart pushed a change to branch tjbanghart/5549 in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git discard f4ce2b893 Adds isAutoIncrement and isGenerated args to MetaColumn constructor new 0c9d0b1b4 [CALCITE-6034] Adds isAutoIncrement and isGenerated args to MetaColumn constructor This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (f4ce2b893) \ N -- N -- N refs/heads/tjbanghart/5549 (0c9d0b1b4) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes:
[calcite-avatica] 01/01: [CALCITE-6034] Adds isAutoIncrement and isGenerated args to MetaColumn constructor
This is an automated email from the ASF dual-hosted git repository.
tjbanghart pushed a commit to branch tjbanghart/5549
in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git
commit 0c9d0b1b49df082460fa23f0b09f09a592f8b24a
Author: TJ Banghart
AuthorDate: Mon Mar 20 10:07:36 2023 -0700
[CALCITE-6034] Adds isAutoIncrement and isGenerated args to MetaColumn
constructor
---
core/src/main/java/org/apache/calcite/avatica/MetaImpl.java | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/core/src/main/java/org/apache/calcite/avatica/MetaImpl.java
b/core/src/main/java/org/apache/calcite/avatica/MetaImpl.java
index c41f8edfc..2cf389bf8 100644
--- a/core/src/main/java/org/apache/calcite/avatica/MetaImpl.java
+++ b/core/src/main/java/org/apache/calcite/avatica/MetaImpl.java
@@ -352,9 +352,9 @@ public abstract class MetaImpl implements Meta {
public final String scopeTable = null;
public final Short sourceDataType = null;
@ColumnNoNulls
-public final String isAutoincrement = "";
+public final String isAutoincrement;
@ColumnNoNulls
-public final String isGeneratedcolumn = "";
+public final String isGeneratedcolumn;
public MetaColumn(
String tableCat,
@@ -369,7 +369,9 @@ public abstract class MetaImpl implements Meta {
int nullable,
Integer charOctetLength,
int ordinalPosition,
-String isNullable) {
+String isNullable,
+String isAutoincrement,
+String isGeneratedcolumn) {
this.tableCat = tableCat;
this.tableSchem = tableSchem;
this.tableName = tableName;
@@ -383,6 +385,8 @@ public abstract class MetaImpl implements Meta {
this.charOctetLength = charOctetLength;
this.ordinalPosition = ordinalPosition;
this.isNullable = isNullable;
+ this.isAutoincrement = isAutoincrement;
+ this.isGeneratedcolumn = isGeneratedcolumn;
}
public String getName() {
[calcite-avatica] branch tjbanghart/5549 created (now f4ce2b893)
This is an automated email from the ASF dual-hosted git repository. tjbanghart pushed a change to branch tjbanghart/5549 in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git at f4ce2b893 Adds isAutoIncrement and isGenerated args to MetaColumn constructor This branch includes the following new commits: new f4ce2b893 Adds isAutoIncrement and isGenerated args to MetaColumn constructor The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[calcite-avatica] 01/01: Adds isAutoIncrement and isGenerated args to MetaColumn constructor
This is an automated email from the ASF dual-hosted git repository.
tjbanghart pushed a commit to branch tjbanghart/5549
in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git
commit f4ce2b89394ad6e632de2505e3b8fdff98609d76
Author: TJ Banghart
AuthorDate: Mon Mar 20 10:07:36 2023 -0700
Adds isAutoIncrement and isGenerated args to MetaColumn constructor
---
core/src/main/java/org/apache/calcite/avatica/MetaImpl.java | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/core/src/main/java/org/apache/calcite/avatica/MetaImpl.java
b/core/src/main/java/org/apache/calcite/avatica/MetaImpl.java
index c41f8edfc..2cf389bf8 100644
--- a/core/src/main/java/org/apache/calcite/avatica/MetaImpl.java
+++ b/core/src/main/java/org/apache/calcite/avatica/MetaImpl.java
@@ -352,9 +352,9 @@ public abstract class MetaImpl implements Meta {
public final String scopeTable = null;
public final Short sourceDataType = null;
@ColumnNoNulls
-public final String isAutoincrement = "";
+public final String isAutoincrement;
@ColumnNoNulls
-public final String isGeneratedcolumn = "";
+public final String isGeneratedcolumn;
public MetaColumn(
String tableCat,
@@ -369,7 +369,9 @@ public abstract class MetaImpl implements Meta {
int nullable,
Integer charOctetLength,
int ordinalPosition,
-String isNullable) {
+String isNullable,
+String isAutoincrement,
+String isGeneratedcolumn) {
this.tableCat = tableCat;
this.tableSchem = tableSchem;
this.tableName = tableName;
@@ -383,6 +385,8 @@ public abstract class MetaImpl implements Meta {
this.charOctetLength = charOctetLength;
this.ordinalPosition = ordinalPosition;
this.isNullable = isNullable;
+ this.isAutoincrement = isAutoincrement;
+ this.isGeneratedcolumn = isGeneratedcolumn;
}
public String getName() {
[PR] [CALCITE-6021] Finish CURRENT_DATETIME implementation [calcite]
tanclary opened a new pull request, #3457: URL: https://github.com/apache/calcite/pull/3457 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-5949] RexExecutable should return unchanged original expressions when it fails [calcite]
rubenada commented on code in PR #3390:
URL: https://github.com/apache/calcite/pull/3390#discussion_r1346978695
##
core/src/test/java/org/apache/calcite/rex/RexExecutorTest.java:
##
@@ -378,4 +378,28 @@ public void run() {
interface Action {
void check(RexBuilder rexBuilder, RexExecutorImpl executor);
}
+
+ /** Test case for
+ * https://issues.apache.org/jira/browse/CALCITE-5949;>[CALCITE-5949]
+ * RexExecutable should properly handle invalid constant expressions in
reduction.
Review Comment:
@arkanovicz kind reminder about this minor (old) remark regarding the
ticket title on this javadoc.
Feel free to squash commits into a single one after you take care of it; and
I'll merge the PR afterwards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [CALCITE-6033] Correct broken links on adapter page [calcite]
sonarcloud[bot] commented on PR #3456: URL: https://github.com/apache/calcite/pull/3456#issuecomment-1748802365 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_calcite=3456) [](https://sonarcloud.io/project/issues?id=apache_calcite=3456=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite=3456=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_calcite=3456=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite=3456=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_calcite=3456=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_calcite=3456=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3456=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3456=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3456=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_calcite=3456=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_calcite=3456=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_calcite=3456=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_calcite=3456=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_calcite=3456=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [CALCITE-6033] Correct broken links on adapter page [calcite]
strongduanmu opened a new pull request, #3456: URL: https://github.com/apache/calcite/pull/3456 - fix following broken links on adapter page: https://calcite.apache.org/avatica/apidocs/org/apache/calcite/avatica/ConnectStringParser.html https://calcite.apache.org/javadocAggregate/org/apache/calcite/sql/fun/SqlGroupedWindowFunction.html https://pig.apache.org/docs/r0.7.0/piglatin_ref1.html https://calcite.apache.org/javadocAggregate/org/apache/calcite/rel/cassandra/CassandraProject.html https://calcite.apache.org/javadocAggregate/org/apache/calcite/rel/metadata/RelMetadataQuery.html#getSelectivity-org.apache.calcite.rel.RelNode-org.apache.calcite.rex.RexNode- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6033] Correct broken links on adapter page [calcite]
strongduanmu closed pull request #3455: [CALCITE-6033] Correct broken links on adapter page URL: https://github.com/apache/calcite/pull/3455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [CALCITE-6033] Fix broken links on adapter page [calcite]
strongduanmu opened a new pull request, #3455: URL: https://github.com/apache/calcite/pull/3455 - fix following broken links on adapter page: https://calcite.apache.org/avatica/apidocs/org/apache/calcite/avatica/ConnectStringParser.html https://calcite.apache.org/javadocAggregate/org/apache/calcite/sql/fun/SqlGroupedWindowFunction.html https://pig.apache.org/docs/r0.7.0/piglatin_ref1.html https://calcite.apache.org/javadocAggregate/org/apache/calcite/rel/cassandra/CassandraProject.html https://calcite.apache.org/javadocAggregate/org/apache/calcite/rel/metadata/RelMetadataQuery.html#getSelectivity-org.apache.calcite.rel.RelNode-org.apache.calcite.rex.RexNode- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-5949] RexExecutable should return unchanged original expressions when it fails [calcite]
rubenada commented on code in PR #3390:
URL: https://github.com/apache/calcite/pull/3390#discussion_r1346986432
##
core/src/main/java/org/apache/calcite/rex/RexExecutable.java:
##
@@ -87,11 +88,14 @@ public void reduce(RexBuilder rexBuilder, List
constExps,
values = new Object[constExps.size()];
} else {
assert values.length == constExps.size();
+final List successfullyReduced = new ArrayList<>();
final List<@Nullable Object> valueList = Arrays.asList(values);
for (Pair value : Pair.zip(constExps,
valueList)) {
- reducedValues.add(
+ successfullyReduced.add(
rexBuilder.makeLiteral(value.right, value.left.getType(), true));
}
+assert successfullyReduced.size() == constExps.size();
Review Comment:
Certainly I can't imagine a scenario where that equality won't hold (if the
`Pair#zip` behaves as it should), but the assertion doesn't hurt (and
assertions can be disabled anyway), so I'm not against having it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [CALCITE-5949] RexExecutable should return unchanged original expressions when it fails [calcite]
rubenada commented on code in PR #3390:
URL: https://github.com/apache/calcite/pull/3390#discussion_r1346978695
##
core/src/test/java/org/apache/calcite/rex/RexExecutorTest.java:
##
@@ -378,4 +378,28 @@ public void run() {
interface Action {
void check(RexBuilder rexBuilder, RexExecutorImpl executor);
}
+
+ /** Test case for
+ * https://issues.apache.org/jira/browse/CALCITE-5949;>[CALCITE-5949]
+ * RexExecutable should properly handle invalid constant expressions in
reduction.
Review Comment:
@arkanovicz kind reminder about this minor (old) remark regarding the
ticket title on this javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [CALCITE-5387] Type-mismatch on nullability in JoinPushTransitivePredicatesRule RelRule [calcite]
LakeShen commented on PR #3452: URL: https://github.com/apache/calcite/pull/3452#issuecomment-1748326807 More details could see developing Calcite guide:https://calcite.apache.org/develop/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update project.copy() in RelBuilder.aggregate_ to reuse the traitSet() [calcite]
LakeShen commented on PR #3454: URL: https://github.com/apache/calcite/pull/3454#issuecomment-1748325875 More details could see developing Calcite guide:https://calcite.apache.org/develop/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-5949] RexExecutable should return unchanged original expressions when it fails [calcite]
JiajunBernoulli commented on code in PR #3390:
URL: https://github.com/apache/calcite/pull/3390#discussion_r1346972738
##
core/src/main/java/org/apache/calcite/rex/RexExecutable.java:
##
@@ -87,11 +88,14 @@ public void reduce(RexBuilder rexBuilder, List
constExps,
values = new Object[constExps.size()];
} else {
assert values.length == constExps.size();
+final List successfullyReduced = new ArrayList<>();
final List<@Nullable Object> valueList = Arrays.asList(values);
for (Pair value : Pair.zip(constExps,
valueList)) {
- reducedValues.add(
+ successfullyReduced.add(
rexBuilder.makeLiteral(value.right, value.left.getType(), true));
}
+assert successfullyReduced.size() == constExps.size();
Review Comment:
Maybe `assert successfullyReduced.size() == constExps.size()` is redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Update project.copy() in RelBuilder.aggregate_ to reuse the traitSet() [calcite]
LakeShen commented on PR #3454: URL: https://github.com/apache/calcite/pull/3454#issuecomment-1748237264 @njriasan Could you create a Calcite JIRA for this problem? And at the same tile, the PR's title and commits should keep the same with JIRA's title. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
