[GitHub] [calcite] DonnyZone commented on a change in pull request #1988: [CALCITE-4019] Visit SqlInsert with SqlShuttle cause NullPointerException

2020-05-27 Thread GitBox 


DonnyZone commented on a change in pull request #1988:
URL: https://github.com/apache/calcite/pull/1988#discussion_r430893526



##
File path: core/src/main/java/org/apache/calcite/sql/SqlInsert.java
##
@@ -62,7 +62,11 @@ public SqlOperator getOperator() {
   }
 
   public List getOperandList() {
-return ImmutableNullableList.of(keywords, targetTable, source, columnList);
+if (columnList == null) {

Review comment:
   Thanks for clarification.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [calcite] DonnyZone commented on a change in pull request #1988: [CALCITE-4019] Visit SqlInsert with SqlShuttle cause NullPointerException

2020-05-26 Thread GitBox 


DonnyZone commented on a change in pull request #1988:
URL: https://github.com/apache/calcite/pull/1988#discussion_r430830028



##
File path: core/src/main/java/org/apache/calcite/sql/SqlInsert.java
##
@@ -62,7 +62,11 @@ public SqlOperator getOperator() {
   }
 
   public List getOperandList() {
-return ImmutableNullableList.of(keywords, targetTable, source, columnList);
+if (columnList == null) {

Review comment:
   Is it possible that `targetTable` is `null` or `source` is `null`?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org