[GitHub] [calcite] hsyuan commented on a change in pull request #1403: [CALCITE-3283] RelSubSet's best is not existed in the set

2019-08-23 Thread GitBox 
hsyuan commented on a change in pull request #1403: [CALCITE-3283] RelSubSet's 
best is not existed in the set
URL: https://github.com/apache/calcite/pull/1403#discussion_r316984263
 
 

 ##
 File path: 
core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java
 ##
 @@ -176,6 +176,14 @@
   public static final CalciteSystemProperty TEST_SLOW =
   booleanProperty("calcite.test.slow", false);
 
+  /**
+   * Whether to do validation within VolcanoPlanner after each rule firing.
+   * Note that doing so would significantly slow down the planning. Should only
+   * enable for unit test.
+   */
+  public static final CalciteSystemProperty 
TEST_VALIDATE_VOLCANO_PLANNER =
+  booleanProperty("calcite.test.validate.volcano.planner", false);
 
 Review comment:
   +1 on `assert`. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [calcite] hsyuan commented on a change in pull request #1403: [CALCITE-3283] RelSubSet's best is not existed in the set

2019-08-22 Thread GitBox 
hsyuan commented on a change in pull request #1403: [CALCITE-3283] RelSubSet's 
best is not existed in the set
URL: https://github.com/apache/calcite/pull/1403#discussion_r316905704
 
 

 ##
 File path: 
core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java
 ##
 @@ -176,6 +176,14 @@
   public static final CalciteSystemProperty TEST_SLOW =
   booleanProperty("calcite.test.slow", false);
 
+  /**
+   * Whether to do validation within VolcanoPlanner after each rule firing.
+   * Note that doing so would significantly slow down the planning. Should only
+   * enable for unit test.
+   */
+  public static final CalciteSystemProperty 
TEST_VALIDATE_VOLCANO_PLANNER =
+  booleanProperty("calcite.test.validate.volcano.planner", false);
 
 Review comment:
   I think the flag is not limited to test, so we can remove `test` from the 
flag name.
   TEST_VALIDATE_VOLCANO_PLANNER -> VALIDATE_VOLCANO_PLANNER


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services