Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
JiajunBernoulli commented on PR #3577: URL: https://github.com/apache/calcite/pull/3577#issuecomment-1851182969 Close #3544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
mihaibudiu merged PR #3577: URL: https://github.com/apache/calcite/pull/3577 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
JiajunBernoulli commented on PR #3577: URL: https://github.com/apache/calcite/pull/3577#issuecomment-1851175055 > cli passed, which was pretty amazing, and I didn't reproduce it locally Yes, failure is not your responsibility. The issue is https://issues.apache.org/jira/browse/CALCITE-4824 I just ran again to make it pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
caicancai commented on PR #3577: URL: https://github.com/apache/calcite/pull/3577#issuecomment-1851171711 cli passed, which was pretty amazing, and I didn't reproduce it locally -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
caicancai commented on PR #3577: URL: https://github.com/apache/calcite/pull/3577#issuecomment-1851092065 I'll try it in my local Windows environment and see if it comes up -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
mihaibudiu commented on PR #3577: URL: https://github.com/apache/calcite/pull/3577#issuecomment-1850601893 This is a very strange failure in CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
caicancai commented on PR #3577: URL: https://github.com/apache/calcite/pull/3577#issuecomment-1850086830 @mihaibudiu @JiajunBernoulli It seems that the cli has not happened, but I don’t know why this happens. It seems that similar situations have happened before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
sonarcloud[bot] commented on PR #3577: URL: https://github.com/apache/calcite/pull/3577#issuecomment-1850085249 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_calcite=3577) [](https://sonarcloud.io/project/issues?id=apache_calcite=3577=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite=3577=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_calcite=3577=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite=3577=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_calcite=3577=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_calcite=3577=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3577=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3577=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3577=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_calcite=3577=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_calcite=3577=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_calcite=3577=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_calcite=3577=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_calcite=3577=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
caicancai commented on PR #3577: URL: https://github.com/apache/calcite/pull/3577#issuecomment-1849198311 > @caicancai Please rebase main again. ok, there was no such problem yesterday. I will git rebase later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
JiajunBernoulli commented on PR #3577: URL: https://github.com/apache/calcite/pull/3577#issuecomment-1849194978 @caicancai Please rebase main again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
caicancai commented on PR #3577: URL: https://github.com/apache/calcite/pull/3577#issuecomment-1848962414 cc @JiajunBernoulli -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
sonarcloud[bot] commented on PR #3577: URL: https://github.com/apache/calcite/pull/3577#issuecomment-1848962175 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_calcite=3577) [](https://sonarcloud.io/project/issues?id=apache_calcite=3577=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite=3577=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_calcite=3577=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite=3577=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_calcite=3577=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_calcite=3577=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3577=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3577=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3577=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_calcite=3577=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_calcite=3577=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_calcite=3577=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_calcite=3577=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_calcite=3577=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
caicancai closed pull request #3544: [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest URL: https://github.com/apache/calcite/pull/3544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
caicancai commented on PR #3544: URL: https://github.com/apache/calcite/pull/3544#issuecomment-1846452483 I'll be sure to fix it this weekend. Sorry to take up everyone's time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
caicancai commented on PR #3544: URL: https://github.com/apache/calcite/pull/3544#issuecomment-1846450674 > Since you have changes to a single file, one simple approach is to create a new PR starting from the main branch. > > * save the modified file to some external location: `core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java` > * check out the main branch (`git checkout main`) > * copy the modified file back over the main branch > * create a new branch `git checkout -b newbranch` > * add the changed file `git add core/` > * commit the changes `git commit -s -m"[CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest"` > * push the changes `git push origin newbranch` > * submit a new PR and close this one That's what I did before以上翻译结果来自有道神经网络翻译（YNMT）· 通用场景 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
caicancai commented on PR #3544: URL: https://github.com/apache/calcite/pull/3544#issuecomment-1846450384 > As for rebase, usually it's enough to do `git fetch upstream; git rebase upstream main` But this can be more complicated if you have conflicts. In your case you have to not just rebase but combine all your 4 commits into one. yes, I'm trying -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
mihaibudiu commented on PR #3544: URL: https://github.com/apache/calcite/pull/3544#issuecomment-1846448834 As for rebase, usually it's enough to do `git fetch upstream; git rebase upstream main` But this can be more complicated if you have conflicts. In your case you have to not just rebase but combine all your 4 commits into one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
mihaibudiu commented on PR #3544: URL: https://github.com/apache/calcite/pull/3544#issuecomment-1846447899 Since you have changes to a single file, one simple approach is to create a new PR starting from the main branch. - save the modified file to some external location: `core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java` - check out the main branch (`git checkout main`) - copy the modified file back over the main branch - create a new branch `git checkout -b newbranch` - add the changed file `git add core/` - commit the changes `git commit -s -m"[CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest"` - push the changes `git push origin newbranch` - submit a new PR and close this one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
caicancai commented on PR #3544: URL: https://github.com/apache/calcite/pull/3544#issuecomment-1846436641 > @caicancai Not merge, we should rebase main branch. > Please follow the instructions here: https://calcite.apache.org/develop/ to combine all these 4 commits into a single one. The commit message should be exactly the same as the title of this PR and the JIRA issue that you have filed. Thanks for reminding me, I am trying, please forgive me for not being familiar with git rebase operation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
mihaibudiu commented on PR #3544: URL: https://github.com/apache/calcite/pull/3544#issuecomment-1846413387 Please follow the instructions here: https://calcite.apache.org/develop/ to combine all these 4 commits into a single one. The commit message should be exactly the same as the title of this PR and the JIRA issue that you have filed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
JiajunBernoulli commented on PR #3544: URL: https://github.com/apache/calcite/pull/3544#issuecomment-1844028708 @caicancai Not merge, we should rebase main branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
sonarcloud[bot] commented on PR #3544: URL: https://github.com/apache/calcite/pull/3544#issuecomment-1843040672 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_calcite=3544) [](https://sonarcloud.io/project/issues?id=apache_calcite=3544=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite=3544=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_calcite=3544=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite=3544=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_calcite=3544=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_calcite=3544=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3544=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3544=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3544=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_calcite=3544=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_calcite=3544=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_calcite=3544=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_calcite=3544=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_calcite=3544=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
sonarcloud[bot] commented on PR #3544: URL: https://github.com/apache/calcite/pull/3544#issuecomment-1843021712 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_calcite=3544) [](https://sonarcloud.io/project/issues?id=apache_calcite=3544=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite=3544=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_calcite=3544=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite=3544=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_calcite=3544=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_calcite=3544=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3544=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3544=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3544=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_calcite=3544=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_calcite=3544=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_calcite=3544=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_calcite=3544=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_calcite=3544=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
sonarcloud[bot] commented on PR #3566: URL: https://github.com/apache/calcite/pull/3566#issuecomment-1842996439 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_calcite=3566) [](https://sonarcloud.io/project/issues?id=apache_calcite=3566=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite=3566=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_calcite=3566=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite=3566=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_calcite=3566=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_calcite=3566=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3566=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3566=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3566=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_calcite=3566=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_calcite=3566=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_calcite=3566=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_calcite=3566=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_calcite=3566=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
caicancai closed pull request #3544: [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest URL: https://github.com/apache/calcite/pull/3544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
caicancai closed pull request #3566: [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest URL: https://github.com/apache/calcite/pull/3566 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
caicancai closed pull request #3544: [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest URL: https://github.com/apache/calcite/pull/3544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
sonarcloud[bot] commented on PR #3544: URL: https://github.com/apache/calcite/pull/3544#issuecomment-1842964714 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_calcite=3544) [](https://sonarcloud.io/project/issues?id=apache_calcite=3544=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite=3544=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_calcite=3544=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite=3544=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_calcite=3544=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_calcite=3544=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3544=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3544=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3544=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_calcite=3544=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_calcite=3544=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_calcite=3544=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_calcite=3544=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_calcite=3544=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
caicancai closed pull request #3544: [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest URL: https://github.com/apache/calcite/pull/3544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
caicancai commented on PR #3544: URL: https://github.com/apache/calcite/pull/3544#issuecomment-1842940648 > @caicancai CI passed. Please squash your commits. Thank you, > @caicancai CI passed. Please squash your commits. It seems that there is something wrong with my operation. I will submit a PR again. Sorry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
JiajunBernoulli commented on PR #3544: URL: https://github.com/apache/calcite/pull/3544#issuecomment-1842834874 @caicancai CI passed. Please squash your commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
caicancai commented on PR #3544: URL: https://github.com/apache/calcite/pull/3544#issuecomment-1837377550 > @caicancai , The main branch is freezing because druid test failed. > > I will merge it if druid test is fixed. OK, thank you for your reply -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
JiajunBernoulli commented on PR #3544: URL: https://github.com/apache/calcite/pull/3544#issuecomment-1837368861 @caicancai , The main branch is freezing because druid test failed. I will merge it if druid test is fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
caicancai commented on PR #3544: URL: https://github.com/apache/calcite/pull/3544#issuecomment-1837339930 @chucheng92 @JiajunBernoulli Hello, excuse me, is it good to merge this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
chucheng92 commented on code in PR #3544:
URL: https://github.com/apache/calcite/pull/3544#discussion_r1405669804
##
core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java:
##
@@ -76,8 +76,6 @@ class SqlTypeUtilTest {
is(true));
assertThat(areSameFamily(ImmutableList.of(bigIntAndFloat, bigIntAndFloat)),
is(true));
-assertThat(areSameFamily(ImmutableList.of(bigIntAndFloat, bigIntAndFloat)),
Review Comment:
+1 agree with JiaJun.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
caicancai commented on PR #3544: URL: https://github.com/apache/calcite/pull/3544#issuecomment-1826549889 cc @JiajunBernoulli -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
sonarcloud[bot] commented on PR #3544: URL: https://github.com/apache/calcite/pull/3544#issuecomment-1826544695 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_calcite=3544) [](https://sonarcloud.io/project/issues?id=apache_calcite=3544=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite=3544=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_calcite=3544=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite=3544=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_calcite=3544=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_calcite=3544=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3544=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3544=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite=3544=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_calcite=3544=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_calcite=3544=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_calcite=3544=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_calcite=3544=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_calcite=3544=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [CALCITE-6131] There are duplicate sample tests in SqlTypeUtilTest [calcite]
JiajunBernoulli commented on code in PR #3544:
URL: https://github.com/apache/calcite/pull/3544#discussion_r1405323066
##
core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java:
##
@@ -76,8 +76,6 @@ class SqlTypeUtilTest {
is(true));
assertThat(areSameFamily(ImmutableList.of(bigIntAndFloat, bigIntAndFloat)),
is(true));
-assertThat(areSameFamily(ImmutableList.of(bigIntAndFloat, bigIntAndFloat)),
Review Comment:
It should be `assertThat(areSameFamily(ImmutableList.of(floatAndBigInt,
bigIntAndFloat)),
is(true));`
1. [bigIntAndFloat, floatAndBigInt]
2. [bigIntAndFloat, bigIntAndFloat]
3. [floatAndBigInt, bigIntAndFloat]
4. [floatAndBigInt, floatAndBigInt]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] CALCITE-6131: There are duplicate sample tests in SqlTypeUtilTest [calcite]
caicancai closed pull request #3543: CALCITE-6131: There are duplicate sample tests in SqlTypeUtilTest URL: https://github.com/apache/calcite/pull/3543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
