Fix CS
Project: http://git-wip-us.apache.org/repos/asf/camel/repo Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/b1e5a108 Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/b1e5a108 Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/b1e5a108 Branch: refs/heads/master Commit: b1e5a108f3975d50d7c00ef80019f8ed5437d7eb Parents: c0e7e60 Author: lburgazzoli <lburgazz...@gmail.com> Authored: Thu Mar 30 18:05:24 2017 +0200 Committer: lburgazzoli <lburgazz...@gmail.com> Committed: Thu Mar 30 18:05:24 2017 +0200 ---------------------------------------------------------------------- .../org/apache/camel/ComponentVerifierHelper.java | 16 ++++++++++++---- .../org/apache/camel/ComponentVerifierTest.java | 15 ++++++++------- .../salesforce/SalesforceComponentVerifier.java | 3 +-- .../twitter/CamelComponentVerifierTest.java | 2 +- 4 files changed, 22 insertions(+), 14 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/camel/blob/b1e5a108/camel-core/src/main/java/org/apache/camel/ComponentVerifierHelper.java ---------------------------------------------------------------------- diff --git a/camel-core/src/main/java/org/apache/camel/ComponentVerifierHelper.java b/camel-core/src/main/java/org/apache/camel/ComponentVerifierHelper.java index 1c6f288..7be03d4 100644 --- a/camel-core/src/main/java/org/apache/camel/ComponentVerifierHelper.java +++ b/camel-core/src/main/java/org/apache/camel/ComponentVerifierHelper.java @@ -46,8 +46,12 @@ class ComponentVerifierHelper { @Override public boolean equals(Object o) { - if (this == o) return true; - if (!(o instanceof Code)) return false; + if (this == o) { + return true; + } + if (!(o instanceof Code)) { + return false; + } Code errorCode = (Code) o; @@ -84,8 +88,12 @@ class ComponentVerifierHelper { @Override public boolean equals(Object o) { - if (this == o) return true; - if (!(o instanceof Attribute)) return false; + if (this == o) { + return true; + } + if (!(o instanceof Attribute)) { + return false; + } Attribute that = (Attribute) o; http://git-wip-us.apache.org/repos/asf/camel/blob/b1e5a108/camel-core/src/test/java/org/apache/camel/ComponentVerifierTest.java ---------------------------------------------------------------------- diff --git a/camel-core/src/test/java/org/apache/camel/ComponentVerifierTest.java b/camel-core/src/test/java/org/apache/camel/ComponentVerifierTest.java index b14541b..5173053 100644 --- a/camel-core/src/test/java/org/apache/camel/ComponentVerifierTest.java +++ b/camel-core/src/test/java/org/apache/camel/ComponentVerifierTest.java @@ -23,15 +23,15 @@ import org.junit.Assert; public class ComponentVerifierTest extends TestCase { public void testGetErrorDetails() { - VerificationError error = - ResultErrorBuilder.withCodeAndDescription(VerificationError.asCode("test_code"), "test error desc") - .detail(VerificationError.asAttribute("test_attr_1"), "test_detail_1") - .detail(VerificationError.HttpAttribute.HTTP_CODE,"test_detail_2") - .build(); + VerificationError error = ResultErrorBuilder.withCodeAndDescription(VerificationError.asCode("test_code"), "test error desc") + .detail(VerificationError.asAttribute("test_attr_1"), "test_detail_1") + .detail(VerificationError.HttpAttribute.HTTP_CODE, "test_detail_2") + .build(); + Assert.assertEquals("test_detail_1", error.getDetail(VerificationError.asAttribute("test_attr_1"))); Assert.assertEquals("test_detail_1", error.getDetail("test_attr_1")); Assert.assertEquals("test_detail_2", error.getDetail(VerificationError.HttpAttribute.HTTP_CODE)); -Assert.assertNull(error.getDetail(VerificationError.HttpAttribute.HTTP_TEXT)); + Assert.assertNull(error.getDetail(VerificationError.HttpAttribute.HTTP_TEXT)); Assert.assertNull(error.getDetail(VerificationError.asAttribute("test_attr_non_existant"))); } @@ -78,6 +78,7 @@ Assert.assertNull(error.getDetail(VerificationError.HttpAttribute.HTTP_TEXT)); try { ComponentVerifier.Scope.fromString("unknown"); fail(); - } catch (IllegalArgumentException exp) {} + } catch (IllegalArgumentException exp) { + } } } http://git-wip-us.apache.org/repos/asf/camel/blob/b1e5a108/components/camel-salesforce/camel-salesforce-component/src/main/java/org/apache/camel/component/salesforce/SalesforceComponentVerifier.java ---------------------------------------------------------------------- diff --git a/components/camel-salesforce/camel-salesforce-component/src/main/java/org/apache/camel/component/salesforce/SalesforceComponentVerifier.java b/components/camel-salesforce/camel-salesforce-component/src/main/java/org/apache/camel/component/salesforce/SalesforceComponentVerifier.java index 72b6f35..67ed24f 100644 --- a/components/camel-salesforce/camel-salesforce-component/src/main/java/org/apache/camel/component/salesforce/SalesforceComponentVerifier.java +++ b/components/camel-salesforce/camel-salesforce-component/src/main/java/org/apache/camel/component/salesforce/SalesforceComponentVerifier.java @@ -21,7 +21,6 @@ import java.net.URISyntaxException; import java.util.Map; import java.util.Optional; -import org.apache.camel.ComponentVerifier; import org.apache.camel.NoSuchOptionException; import org.apache.camel.component.salesforce.api.SalesforceException; import org.apache.camel.component.salesforce.api.dto.RestError; @@ -153,7 +152,7 @@ public class SalesforceComponentVerifier extends DefaultComponentVerifier { ResultErrorBuilder.withCode(VerificationError.StandardCode.GENERIC) .description(error.getMessage()) .parameterKeys(error.getFields()) - .detail("salesforce_code",error.getErrorCode()) + .detail("salesforce_code", error.getErrorCode()) .build() ); } http://git-wip-us.apache.org/repos/asf/camel/blob/b1e5a108/components/camel-twitter/src/test/java/org/apache/camel/component/twitter/CamelComponentVerifierTest.java ---------------------------------------------------------------------- diff --git a/components/camel-twitter/src/test/java/org/apache/camel/component/twitter/CamelComponentVerifierTest.java b/components/camel-twitter/src/test/java/org/apache/camel/component/twitter/CamelComponentVerifierTest.java index 48df2bc..f317b78 100644 --- a/components/camel-twitter/src/test/java/org/apache/camel/component/twitter/CamelComponentVerifierTest.java +++ b/components/camel-twitter/src/test/java/org/apache/camel/component/twitter/CamelComponentVerifierTest.java @@ -97,7 +97,7 @@ public class CamelComponentVerifierTest extends CamelTwitterTestSupport { expected.add("accessToken"); expected.add("accessTokenSecret"); - for(VerificationError error : result.getErrors()) { + for (VerificationError error : result.getErrors()) { expected.removeAll(error.getParameterKeys()); }
