[GitHub] [camel] aryankoul commented on pull request #4697: [CAMEL-15341] Create camel-azure-storage-datalake to serve Azure DataLakes Gen2

2021-01-26 Thread GitBox 


aryankoul commented on pull request #4697:
URL: https://github.com/apache/camel/pull/4697#issuecomment-767741560


   > If you run the mvn install on this component the tests will run anyway and 
fail. No matter the profile.
   
   AFAIK , only those files are included automatically for test which have 
"Test" as prefix or suffix. Thats why i changed the names of the test files 
that were failing due to lack of access key,  to have prefix "IT" instead of 
"Test", so that they do not run automatically in mvn commands. I have added a 
profile to run them explicitly. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] aryankoul commented on pull request #4697: [CAMEL-15341] Create camel-azure-storage-datalake to serve Azure DataLakes Gen2

2021-01-26 Thread GitBox 


aryankoul commented on pull request #4697:
URL: https://github.com/apache/camel/pull/4697#issuecomment-767716992


   > For the moment it is in a local branch on my machine, correctly rebased. 
Please fix the tests.
   
   @oscerd i have fixed the tests, please check now.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] aryankoul commented on pull request #4697: [CAMEL-15341] Create camel-azure-storage-datalake to serve Azure DataLakes Gen2

2021-01-22 Thread GitBox 


aryankoul commented on pull request #4697:
URL: https://github.com/apache/camel/pull/4697#issuecomment-765885449


   > LGTM! Thank you @aryankoul !
   > Once this is merged, the next step to create the Spring boot starter in 
camel-spring-boot and if you have time, would be great if you can add an 
example demonstrate the component in the camel-examples repo, you can re-use 
[this](https://github.com/apache/camel-examples/tree/master/examples/camel-example-debezium-eventhubs-blob)
 example for datalake component.
   > 
   > Let's see if others have any other comments cc @davsclaus @oscerd
   > 
   > P/S: there are some conflicts, can you please resolve them? thanks
   
   Thanks @omarsmak!
   Sure, i'll look into the camel-examples repo.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] aryankoul commented on pull request #4697: [CAMEL-15341] Create camel-azure-storage-datalake to serve Azure DataLakes Gen2

2021-01-19 Thread GitBox 


aryankoul commented on pull request #4697:
URL: https://github.com/apache/camel/pull/4697#issuecomment-763326293


   > hey @aryankoul, any progress on this PR?
   
   Hi @omarsmak , i have pushed new changes. please review the same.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] aryankoul commented on pull request #4697: [CAMEL-15341] Create camel-azure-storage-datalake to serve Azure DataLakes Gen2

2020-12-17 Thread GitBox 


aryankoul commented on pull request #4697:
URL: https://github.com/apache/camel/pull/4697#issuecomment-747383731


   > Can you please rebase and solve conflicts? Thanks
   
   Sure. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] aryankoul commented on pull request #4697: [CAMEL-15341] Create camel-azure-storage-datalake to serve Azure DataLakes Gen2

2020-12-11 Thread GitBox 


aryankoul commented on pull request #4697:
URL: https://github.com/apache/camel/pull/4697#issuecomment-743238556


   > Is there any update on this? As we are closing down for 3.7 release so 
this needs to be done soon, otherwise it will miss the release
   
   I'll need some time for adding proper unit and integration tests. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org