[GitHub] [camel] davsclaus commented on pull request #3837: [CAMEL-7810] Fix JdbcAggregationRepository optimistic locking feature

2020-05-19 Thread GitBox 


davsclaus commented on pull request #3837:
URL: https://github.com/apache/camel/pull/3837#issuecomment-630747443


   For 2.25.x you could create the fix with the version column in a new class 
so the end users can decide to use this new version by using the new class and 
keep the old



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] davsclaus commented on pull request #3837: [CAMEL-7810] Fix JdbcAggregationRepository optimistic locking feature

2020-05-19 Thread GitBox 


davsclaus commented on pull request #3837:
URL: https://github.com/apache/camel/pull/3837#issuecomment-630662801


   Yeah lets gets this merged on master, if @fvaleri can provide a new PR. If 
not we can take this PR and then put on 2.25.x temporary on local and then 
cherry-pick to master and remove the 2.25.x PR. We cannot apply this to 2.25.x 
as its a breaking change for existing users.
   
   If Camel 2.26 is done then yeah we can go back and cherry pick this PR.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [camel] davsclaus commented on pull request #3837: [CAMEL-7810] Fix JdbcAggregationRepository optimistic locking feature

2020-05-18 Thread GitBox 


davsclaus commented on pull request #3837:
URL: https://github.com/apache/camel/pull/3837#issuecomment-630571288


   Ah this is 2.x - We dont do this upstream as it breaks users there, so we 
need a PR for master branch only.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org