[GitHub] [camel-kafka-connector] orpiske edited a comment on pull request #343: Set default and doc config properties as private
orpiske edited a comment on pull request #343: URL: https://github.com/apache/camel-kafka-connector/pull/343#issuecomment-666340690 > > I agree that moving to private would follow generally accepted good practices (for lack of a better "term"). However, I still feel -1 towards making it `private`. My feeling towards this comes from the fact that Kafka seems to also use [public visibility](https://github.com/apache/kafka/blob/trunk/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java#L98) on their code base. > > Even though these are separate projects, I believe that maintaining them as `public` would be consistent to how it is done right now on the Kafka Connect code base. I believe that maintaining this consistency could simplify the job for developers looking to extend the Camel Kafka Connector connectors. > > Therefore, my suggestion is -1. > > Well, I see a mixed approach in that class. There are some `_DOC` and `_DISPALY` properties that are actually private, which is what I'm proposing here (make private every metadata associated with a given key). The `_CONF` properties would remain public, because they are actually needed outside of this class. > > That said, I understand that this is more a matter of good practices than a real need, so I'm ok with whatever we choose. Thanks for the clarification. I had initially thought that this would change the _CONF ones too. With your explanation I see that's not the case. So, given that with this change it would be consistent with the way Kafka Connect code base is doing ... That's +1 from me. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-kafka-connector] orpiske edited a comment on pull request #343: Set default and doc config properties as private
orpiske edited a comment on pull request #343: URL: https://github.com/apache/camel-kafka-connector/pull/343#issuecomment-666311561 I agree that moving to private would follow generally accepted good practices (for lack of a better "term"). However, I still feel -1 towards making it `private`. My feeling towards this comes from the fact that Kafka seems to also use [public visibility](https://github.com/apache/kafka/blob/trunk/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java#L98) on their code base. Even though these are separate projects, I believe that maintaining them as `public` would be consistent to how it is done right now on the Kafka Connect code base. I believe that maintaining this consistency could simplify the job for developers looking to extend the Camel Kafka Connector connectors. Therefore, my suggestion is -1. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-kafka-connector] orpiske edited a comment on pull request #343: Set default and doc config properties as private
orpiske edited a comment on pull request #343: URL: https://github.com/apache/camel-kafka-connector/pull/343#issuecomment-666311561 I agree that moving to private would follow generally accepted good practices (for lack of a better "term"). However, I still feel -1 towards making it private. My feeling towards this comes from the fact that Kafka seems to also use [public visibility](https://github.com/apache/kafka/blob/trunk/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java#L98) on their code base. Even though these are separate projects, I believe that maintaining them as `public` would be consistent to how it is done right now on the Kafka Connect code base. I believe that maintaining this consistency could simplify the job for developers looking to extend the Camel Kafka Connect connectors. Therefore, my suggestion is -1. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
