[GitHub] [camel-quarkus] lburgazzoli commented on issue #482: Fix #476 List itests in an XML file for the Quarkus platform
lburgazzoli commented on issue #482: Fix #476 List itests in an XML file for the Quarkus platform URL: https://github.com/apache/camel-quarkus/pull/482#issuecomment-559421867 @ppalaga I have no objection to keep it now but long term solution would be better to remove it. We may think to move support test extension in a dedicated support folder so main and core and future it tests are just like other tests and we only need to skip indexing the support folder This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #482: Fix #476 List itests in an XML file for the Quarkus platform
lburgazzoli commented on issue #482: Fix #476 List itests in an XML file for the Quarkus platform URL: https://github.com/apache/camel-quarkus/pull/482#issuecomment-559420584 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #482: Fix #476 List itests in an XML file for the Quarkus platform
lburgazzoli commented on issue #482: Fix #476 List itests in an XML file for the Quarkus platform URL: https://github.com/apache/camel-quarkus/pull/482#issuecomment-559402296 in general I'd go for not including auto generated code as It may be another source of conflicts and confusion as people may try to change them manually but it is not a huge issue This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #482: Fix #476 List itests in an XML file for the Quarkus platform
lburgazzoli commented on issue #482: Fix #476 List itests in an XML file for the Quarkus platform URL: https://github.com/apache/camel-quarkus/pull/482#issuecomment-559392600 got confused because I saw the generated file also included in the repo, maybe as it is auto generated it should not be checked in This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #482: Fix #476 List itests in an XML file for the Quarkus platform
lburgazzoli commented on issue #482: Fix #476 List itests in an XML file for the Quarkus platform URL: https://github.com/apache/camel-quarkus/pull/482#issuecomment-559391675 oh, damn me. didn't notice This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #482: Fix #476 List itests in an XML file for the Quarkus platform
lburgazzoli commented on issue #482: Fix #476 List itests in an XML file for the Quarkus platform URL: https://github.com/apache/camel-quarkus/pull/482#issuecomment-559388096 wonder if as future evolution, the xml with the list of the integration-test could be auto generated like all the it with a specific property are included (or excluded) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
