[GitHub] [camel-website] aashnajena commented on issue #207: [CAMEL-14700] Improve colour contrast
aashnajena commented on issue #207: [CAMEL-14700] Improve colour contrast URL: https://github.com/apache/camel-website/pull/207#issuecomment-606128656 @zregvart can you please tell me what is the verdict on this PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-website] aashnajena commented on issue #207: [CAMEL-14700] Improve colour contrast
aashnajena commented on issue #207: [CAMEL-14700] Improve colour contrast URL: https://github.com/apache/camel-website/pull/207#issuecomment-605457525 Hey, I have resolved this issue in #282 and tested it here, the highlight becomes end to end and the sub-menu starts where required. Please review it! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-website] aashnajena commented on issue #207: [CAMEL-14700] Improve colour contrast
aashnajena commented on issue #207: [CAMEL-14700] Improve colour contrast URL: https://github.com/apache/camel-website/pull/207#issuecomment-605415591 > This is how it looks for me on the last [preview](https://builds.apache.org/job/Camel.website/job/PR-207/Preview/index.html). > >  > > Not sure if that was intended, I think if we're going to have the highlight, it should go end to end. > > I guess we also broke the positioning of the menu at some point. The menus used to start at the base grey line below separating the main navigation and the content, now it overlaps. Hi can you check the current website once? For me, the sub-menu seems broken there also, it's not starting from below the line. I tried on 3 different browsers. I'm trying to resolve this in a separate PR.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-website] aashnajena commented on issue #207: [CAMEL-14700] Improve colour contrast
aashnajena commented on issue #207: [CAMEL-14700] Improve colour contrast URL: https://github.com/apache/camel-website/pull/207#issuecomment-604491513 I don't see this happening on my localhost. I just pulled changes and rebased again to make sure it's not happening because of some other merged PRs. Any idea why there is this discrepancy? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-website] aashnajena commented on issue #207: [CAMEL-14700] Improve colour contrast
aashnajena commented on issue #207: [CAMEL-14700] Improve colour contrast URL: https://github.com/apache/camel-website/pull/207#issuecomment-604346754 Hi, does the sub-menu selection look like this for you on the preview? I just tried pulling changes from master and rebasing, my localhost still shows this :  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-website] aashnajena commented on issue #207: [CAMEL-14700] Improve colour contrast
aashnajena commented on issue #207: [CAMEL-14700] Improve colour contrast URL: https://github.com/apache/camel-website/pull/207#issuecomment-604336131 Hey, the hovering on sub-menu items looks different for on my localhost and the preview provided above. This is how it looks for me -  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-website] aashnajena commented on issue #207: [CAMEL-14700] Improve colour contrast
aashnajena commented on issue #207: [CAMEL-14700] Improve colour contrast URL: https://github.com/apache/camel-website/pull/207#issuecomment-602624526 About the colour, maybe we can have a third person's opinion! I think the colour is very close to the background colour. I honestly cannot make out the difference in colours if I don't have my spectacles on! But yes, as soon as I try to make that colour any darker, it starts looking odd, which is why I resorted to colouring the text instead of the background. Besides, I went to several webpages and tried to select text. In all the cases, the background colour of the highlighted text is dark orange or dark blue - even though it's not very aesthetic. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-website] aashnajena commented on issue #207: [CAMEL-14700] Improve colour contrast
aashnajena commented on issue #207: [CAMEL-14700] Improve colour contrast URL: https://github.com/apache/camel-website/pull/207#issuecomment-602618975 Hey! I don't remember exactly which blogs I read, but what most blogs said is that people with low vision have problem observing cursor changes, since the cursor is often very small, even with magnified screens. Hence in order to know what they are selecting (or what they are hovering on), it is crucial to have contrasting colours (like blue on white). Because even if they can't read the entire menu properly, they should be able to read the part they are selecting/hovering on. In the current website, hovering on the main menu just changes the cursor, the focused element is not decorated at all. This link might be helpful https://ux.stackexchange.com/questions/126893/does-hover-state-button-text-need-to-meet-accessibility-guidelines And I've followed this guide to understand how to make accessible menus : https://www.smashingmagazine.com/2017/11/building-accessible-menu-systems/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-website] aashnajena commented on issue #207: [CAMEL-14700] Improve colour contrast
aashnajena commented on issue #207: [CAMEL-14700] Improve colour contrast URL: https://github.com/apache/camel-website/pull/207#issuecomment-599075109 Hi I've added a change - menu items now turn dark blue on hovering (earlier there has no visible change on hovering, which makes it less accessible). Updated the first screenshot to reflect this! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-website] aashnajena commented on issue #207: [CAMEL-14700] Improve colour contrast
aashnajena commented on issue #207: [CAMEL-14700] Improve colour contrast URL: https://github.com/apache/camel-website/pull/207#issuecomment-598652702 Are the rest of the changes okay? I've made changes such that text marked as are displayed boldly in orange, but user-selected text becomes white with dark orange background. Please check now!  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-website] aashnajena commented on issue #207: [CAMEL-14700] Improve colour contrast
aashnajena commented on issue #207: [CAMEL-14700] Improve colour contrast URL: https://github.com/apache/camel-website/pull/207#issuecomment-598648666 Aaah, I think I know where the problem is. Give me 5 minutes, I'll try to fix it! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-website] aashnajena commented on issue #207: [CAMEL-14700] Improve colour contrast
aashnajena commented on issue #207: [CAMEL-14700] Improve colour contrast URL: https://github.com/apache/camel-website/pull/207#issuecomment-598577632 Hello @oscerd I'm so sorry, there weren't any comments by the other person on the JIRA issue so I wasn't aware that someone else was working on the same issue. I'll wait for the preview on PR 205, it seems like @avgupt has made some changes in the navbar colours. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
