[GitHub] [camel-website] aashnajena edited a comment on issue #207: [CAMEL-14700] Improve colour contrast
aashnajena edited a comment on issue #207: [CAMEL-14700] Improve colour contrast URL: https://github.com/apache/camel-website/pull/207#issuecomment-605457525 Hey, I have resolved this issue in #282. Please review and merge #282 first, then the changes here will look fine. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-website] aashnajena edited a comment on issue #207: [CAMEL-14700] Improve colour contrast
aashnajena edited a comment on issue #207: [CAMEL-14700] Improve colour contrast URL: https://github.com/apache/camel-website/pull/207#issuecomment-604491513 I don't see this happening on my localhost. I see the highlight coming from end to end and sub-menu starting from below the line. I just pulled changes and rebased again to make sure it's not happening because of some other merged PRs. Any idea why there is this discrepancy? Working fine for me on all browsers.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-website] aashnajena edited a comment on issue #207: [CAMEL-14700] Improve colour contrast
aashnajena edited a comment on issue #207: [CAMEL-14700] Improve colour contrast URL: https://github.com/apache/camel-website/pull/207#issuecomment-604491513 I don't see this happening on my localhost. I see the highlight coming from end to end and sub-menu starting from below the line. I just pulled changes and rebased again to make sure it's not happening because of some other merged PRs. Any idea why there is this discrepancy? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-website] aashnajena edited a comment on issue #207: [CAMEL-14700] Improve colour contrast
aashnajena edited a comment on issue #207: [CAMEL-14700] Improve colour contrast URL: https://github.com/apache/camel-website/pull/207#issuecomment-602624526 About the "mark" colour, maybe we can have a third person's opinion! I think the colour is very close to the background colour. I honestly cannot make out the difference in colours if I don't have my spectacles on! But yes, as soon as I try to make that colour any darker, it starts looking odd, which is why I resorted to colouring the text instead of the background. Other than that, I went to several webpages and tried to select text. In all the cases, the background colour of the highlighted text is dark orange or dark blue - even though it's not very aesthetic. I definitely do understand your point though, I hope this helps clarify my changes :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-website] aashnajena edited a comment on issue #207: [CAMEL-14700] Improve colour contrast
aashnajena edited a comment on issue #207: [CAMEL-14700] Improve colour contrast URL: https://github.com/apache/camel-website/pull/207#issuecomment-602618975 Hey! First of all, I agree that the menus are expanding, but a) We are anyway trying to do away with submenus so we won't have expanding menus for most items anymore and b) There are items on the menu which don't expand like Download and Blog. I don't remember exactly which blogs I read, but what most blogs said is that people with low vision have problem observing cursor changes, since the cursor is often very small, even with magnified screens. Hence in order to know what they are selecting (or what they are hovering on), it is crucial to have contrasting colours (like blue on white). Because even if they can't read the entire menu properly, they should be able to read the part they are selecting/hovering on. In the current website, hovering on the main menu just changes the cursor, the focused element is not decorated at all. This link might be helpful https://ux.stackexchange.com/questions/126893/does-hover-state-button-text-need-to-meet-accessibility-guidelines And I've followed this guide to understand how to make accessible menus : https://www.smashingmagazine.com/2017/11/building-accessible-menu-systems/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-website] aashnajena edited a comment on issue #207: [CAMEL-14700] Improve colour contrast
aashnajena edited a comment on issue #207: [CAMEL-14700] Improve colour contrast URL: https://github.com/apache/camel-website/pull/207#issuecomment-602624526 About the "mark" colour, maybe we can have a third person's opinion! I think the colour is very close to the background colour. I honestly cannot make out the difference in colours if I don't have my spectacles on! But yes, as soon as I try to make that colour any darker, it starts looking odd, which is why I resorted to colouring the text instead of the background. Besides, I went to several webpages and tried to select text. In all the cases, the background colour of the highlighted text is dark orange or dark blue - even though it's not very aesthetic. I definitely do understand your point though, I hope this helps clarify my changes :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-website] aashnajena edited a comment on issue #207: [CAMEL-14700] Improve colour contrast
aashnajena edited a comment on issue #207: [CAMEL-14700] Improve colour contrast URL: https://github.com/apache/camel-website/pull/207#issuecomment-602624526 About the "mark" colour, maybe we can have a third person's opinion! I think the colour is very close to the background colour. I honestly cannot make out the difference in colours if I don't have my spectacles on! But yes, as soon as I try to make that colour any darker, it starts looking odd, which is why I resorted to colouring the text instead of the background. Besides, I went to several webpages and tried to select text. In all the cases, the background colour of the highlighted text is dark orange or dark blue - even though it's not very aesthetic. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-website] aashnajena edited a comment on issue #207: [CAMEL-14700] Improve colour contrast
aashnajena edited a comment on issue #207: [CAMEL-14700] Improve colour contrast URL: https://github.com/apache/camel-website/pull/207#issuecomment-602618975 Hey! First of all, I agree that the menus are expanding, but a) We are anyway trying to do away with submenus so we won't have expanding menus anymore and b) There are items on the menu which don't expand like Download and Blog. I don't remember exactly which blogs I read, but what most blogs said is that people with low vision have problem observing cursor changes, since the cursor is often very small, even with magnified screens. Hence in order to know what they are selecting (or what they are hovering on), it is crucial to have contrasting colours (like blue on white). Because even if they can't read the entire menu properly, they should be able to read the part they are selecting/hovering on. In the current website, hovering on the main menu just changes the cursor, the focused element is not decorated at all. This link might be helpful https://ux.stackexchange.com/questions/126893/does-hover-state-button-text-need-to-meet-accessibility-guidelines And I've followed this guide to understand how to make accessible menus : https://www.smashingmagazine.com/2017/11/building-accessible-menu-systems/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-website] aashnajena edited a comment on issue #207: [CAMEL-14700] Improve colour contrast
aashnajena edited a comment on issue #207: [CAMEL-14700] Improve colour contrast URL: https://github.com/apache/camel-website/pull/207#issuecomment-598652702 Are the rest of the changes okay? I've made changes such that text marked with a "mark" tag are displayed boldly in orange, but user-selected text becomes white with dark orange background. Please check now!  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-website] aashnajena edited a comment on issue #207: [CAMEL-14700] Improve colour contrast
aashnajena edited a comment on issue #207: [CAMEL-14700] Improve colour contrast URL: https://github.com/apache/camel-website/pull/207#issuecomment-598652702 Are the rest of the changes okay? I've made changes such that text marked as are displayed boldly in orange, but user-selected text becomes white with dark orange background. Please check now!  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
