Re: [PR] Reduced Cognitive complexity of the code. [camel]
anjaliInfy1822 closed pull request #13921: Reduced Cognitive complexity of the code. URL: https://github.com/apache/camel/pull/13921 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Reduced Cognitive complexity of the code. [camel]
orpiske commented on code in PR #13921:
URL: https://github.com/apache/camel/pull/13921#discussion_r1579081967
##
catalog/camel-catalog/src/main/java/org/apache/camel/catalog/DefaultCamelCatalog.java:
##
@@ -659,4 +654,15 @@ private String loadResource(String file) {
}
}
+private ArtifactModel matchArtifactModelFromList(List
artifactModelList, String groupId, String artifactId,
+String version) {
+for (String name : artifactModelList) {
+ArtifactModel am = componentModel(name);
Review Comment:
@anjaliInfy1822 My .2 cents: focus on the ["easy" tickets and "help
wanted"](https://camel.apache.org/camel-core/contributing/#_contributing_to_apache_camel)
first to gain some experience with the code base before proceeding with things
like this.
As Claus said, get involved with the community (specially on the [Zulip
chat](https://camel.zulipchat.com) at #camel-core-dev) to keep an eye on things
we need help with.
Once you have a good grasp of the code base and know what to expect, then
it's OK to focus on cleaning up things (we do have a lot of things to
cleanup!!! But this one is not one of them).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Reduced Cognitive complexity of the code. [camel]
orpiske commented on code in PR #13921:
URL: https://github.com/apache/camel/pull/13921#discussion_r1579081967
##
catalog/camel-catalog/src/main/java/org/apache/camel/catalog/DefaultCamelCatalog.java:
##
@@ -659,4 +654,15 @@ private String loadResource(String file) {
}
}
+private ArtifactModel matchArtifactModelFromList(List
artifactModelList, String groupId, String artifactId,
+String version) {
+for (String name : artifactModelList) {
+ArtifactModel am = componentModel(name);
Review Comment:
@anjaliInfy1822 My .2 cents: focus on the "easy" tickets and "help wanted"
first to gain some experience with the code base before proceeding with things
like this.
As Claus said, get involved with the community (specially on the Zulip chat)
to keep an eye on things we need help with.
Once you have a good grasp of the code base and know what to expect, then
it's OK to focus on cleaning up things (we do have a lot of things to
cleanup!!! But this one is not one of them).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Reduced Cognitive complexity of the code. [camel]
anjaliInfy1822 closed pull request #13921: Reduced Cognitive complexity of the code. URL: https://github.com/apache/camel/pull/13921 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Reduced Cognitive complexity of the code. [camel]
anjaliInfy1822 commented on code in PR #13921:
URL: https://github.com/apache/camel/pull/13921#discussion_r1579000323
##
catalog/camel-catalog/src/main/java/org/apache/camel/catalog/DefaultCamelCatalog.java:
##
@@ -659,4 +654,15 @@ private String loadResource(String file) {
}
}
+private ArtifactModel matchArtifactModelFromList(List
artifactModelList, String groupId, String artifactId,
+String version) {
+for (String name : artifactModelList) {
+ArtifactModel am = componentModel(name);
Review Comment:
@davsclaus sure Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Reduced Cognitive complexity of the code. [camel]
anjaliInfy1822 closed pull request #13921: Reduced Cognitive complexity of the code. URL: https://github.com/apache/camel/pull/13921 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Reduced Cognitive complexity of the code. [camel]
davsclaus commented on code in PR #13921:
URL: https://github.com/apache/camel/pull/13921#discussion_r1578997116
##
catalog/camel-catalog/src/main/java/org/apache/camel/catalog/DefaultCamelCatalog.java:
##
@@ -659,4 +654,15 @@ private String loadResource(String file) {
}
}
+private ArtifactModel matchArtifactModelFromList(List
artifactModelList, String groupId, String artifactId,
+String version) {
+for (String name : artifactModelList) {
+ArtifactModel am = componentModel(name);
Review Comment:
This PR does not improve anything, the old code is fine, and also avoids
backport problems.
If you want to help with Camel, then help with better things, than this
stuff. Also it helps to get involved with Camel first than open your first PR
out of "the blue".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Reduced Cognitive complexity of the code. [camel]
anjaliInfy1822 commented on code in PR #13921:
URL: https://github.com/apache/camel/pull/13921#discussion_r1578983860
##
catalog/camel-catalog/src/main/java/org/apache/camel/catalog/DefaultCamelCatalog.java:
##
@@ -659,4 +654,15 @@ private String loadResource(String file) {
}
}
+private ArtifactModel matchArtifactModelFromList(List
artifactModelList, String groupId, String artifactId,
+String version) {
+for (String name : artifactModelList) {
+ArtifactModel am = componentModel(name);
Review Comment:
Hi @davsclaus , sorry I missed that part. Would it be okay to have different
function for each case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Reduced Cognitive complexity of the code. [camel]
davsclaus commented on code in PR #13921:
URL: https://github.com/apache/camel/pull/13921#discussion_r1578971277
##
catalog/camel-catalog/src/main/java/org/apache/camel/catalog/DefaultCamelCatalog.java:
##
@@ -659,4 +654,15 @@ private String loadResource(String file) {
}
}
+private ArtifactModel matchArtifactModelFromList(List
artifactModelList, String groupId, String artifactId,
+String version) {
+for (String name : artifactModelList) {
+ArtifactModel am = componentModel(name);
Review Comment:
this is wrong, here is only component, the old had per different type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
