[camel] branch master updated: Regen
This is an automated email from the ASF dual-hosted git repository. acosentino pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/camel.git The following commit(s) were added to refs/heads/master by this push: new b36af24 Regen b36af24 is described below commit b36af24364a84bef7c1f675def4f30dacdc39a35 Author: Andrea Cosentino AuthorDate: Mon Nov 11 12:26:14 2019 +0100 Regen --- components/camel-jetty/src/main/docs/jetty-component.adoc | 4 +--- docs/components/modules/ROOT/pages/jetty-component.adoc | 8 ++-- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/components/camel-jetty/src/main/docs/jetty-component.adoc b/components/camel-jetty/src/main/docs/jetty-component.adoc index 8bc91eb..a9685a4 100644 --- a/components/camel-jetty/src/main/docs/jetty-component.adoc +++ b/components/camel-jetty/src/main/docs/jetty-component.adoc @@ -175,7 +175,7 @@ When using Spring Boot make sure to use the following Maven dependency to have s -The component supports 34 options, which are listed below. +The component supports 32 options, which are listed below. @@ -190,8 +190,6 @@ The component supports 34 options, which are listed below. | *camel.component.jetty.error-handler* | This option is used to set the ErrorHandler that Jetty server uses. The option is a org.eclipse.jetty.server.handler.ErrorHandler type. | | String | *camel.component.jetty.header-filter-strategy* | To use a custom org.apache.camel.spi.HeaderFilterStrategy to filter header to and from Camel message. The option is a org.apache.camel.spi.HeaderFilterStrategy type. | | String | *camel.component.jetty.http-binding* | Not to be used - use JettyHttpBinding instead. The option is a org.apache.camel.http.common.HttpBinding type. | | String -| *camel.component.jetty.http-client-max-threads* | To set a value for maximum number of threads in HttpClient thread pool. Notice that both a min and max size must be configured. | | Integer -| *camel.component.jetty.http-client-min-threads* | To set a value for minimum number of threads in HttpClient thread pool. Notice that both a min and max size must be configured. | | Integer | *camel.component.jetty.http-configuration* | Jetty component does not use HttpConfiguration. The option is a org.apache.camel.http.common.HttpConfiguration type. | | String | *camel.component.jetty.jetty-http-binding* | To use a custom org.apache.camel.component.jetty.JettyHttpBinding, which are used to customize how a response should be written for the producer. The option is a org.apache.camel.component.jetty.JettyHttpBinding type. | | String | *camel.component.jetty.keystore* | Specifies the location of the Java keystore file, which contains the Jetty server's own X.509 certificate in a key entry. | | String diff --git a/docs/components/modules/ROOT/pages/jetty-component.adoc b/docs/components/modules/ROOT/pages/jetty-component.adoc index fdc5caa..9103e7b 100644 --- a/docs/components/modules/ROOT/pages/jetty-component.adoc +++ b/docs/components/modules/ROOT/pages/jetty-component.adoc @@ -50,7 +50,7 @@ You can append query options to the URI in the following format, // component options: START -The Jetty component supports 33 options, which are listed below. +The Jetty component supports 31 options, which are listed below. @@ -63,8 +63,6 @@ The Jetty component supports 33 options, which are listed below. | *errorHandler* (advanced) | This option is used to set the ErrorHandler that Jetty server uses. | | ErrorHandler | *sslSocketConnectors* (security) | A map which contains per port number specific SSL connectors. | | Map | *socketConnectors* (security) | A map which contains per port number specific HTTP connectors. Uses the same principle as sslSocketConnectors. | | Map -| *httpClientMinThreads* (producer) | To set a value for minimum number of threads in HttpClient thread pool. Notice that both a min and max size must be configured. | | Integer -| *httpClientMaxThreads* (producer) | To set a value for maximum number of threads in HttpClient thread pool. Notice that both a min and max size must be configured. | | Integer | *minThreads* (consumer) | To set a value for minimum number of threads in server thread pool. Notice that both a min and max size must be configured. | | Integer | *maxThreads* (consumer) | To set a value for maximum number of threads in server thread pool. Notice that both a min and max size must be configured. | | Integer | *threadPool* (consumer) | To use a custom thread pool for the server. This option should only be used in special circumstances. | | ThreadPool @@ -178,7 +176,7 @@ When using Spring Boot make sure to use the following Maven dependency to have s -The component supports 34 options, which are listed below. +The component supports 32 options, which are listed below. @@ -193,8 +191,6 @@ The component supports 34 options, which
[GitHub] [camel-quarkus] lburgazzoli opened a new pull request #392: Perform TypeConverterLoader discovery using jandex instead of camel's class path scanner
lburgazzoli opened a new pull request #392: Perform TypeConverterLoader discovery using jandex instead of camel's class path scanner URL: https://github.com/apache/camel-quarkus/pull/392 Fixes #389 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[camel-quarkus] branch master updated (396e008 -> b9eb61e)
This is an automated email from the ASF dual-hosted git repository.
lburgazzoli pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/camel-quarkus.git.
from 396e008 feat: controlbus extension. (#388)
add 28b70c4 Add SnakeYAML extension
add b9eb61e chore(build): Make PR validate run package phase to avoid
downloading stale SNAPSHOT artifacts
No new revisions were added by this update.
Summary of changes:
.github/workflows/pr-validate.yml | 4 +-
.../pages/list-of-camel-quarkus-extensions.adoc| 4 +-
extensions/pom.xml | 1 +
extensions/readme.adoc | 4 +-
.../{controlbus => snakeyaml}/deployment/pom.xml | 8 ++--
.../snakeyaml/deployment/SnakeyamlProcessor.java} | 6 +--
extensions/{netty => snakeyaml}/pom.xml| 4 +-
.../{controlbus => snakeyaml}/runtime/pom.xml | 8 ++--
.../main/resources/META-INF/quarkus-extension.yaml | 10 +
integration-tests/pom.xml | 1 +
.../snakeyaml/pom.xml | 14 +++
.../component/snakeyaml/it/SnakeYAMLResource.java} | 28 --
.../component/snakeyaml/it/SnakeYAMLRoutes.java} | 21 +-
.../component/snakeyaml/it/model/TestPojo.java | 45 +-
.../component/snakeyaml/it/SnakeYAMLIT.java} | 8 ++--
.../component/snakeyaml/it/SnakeYAMLTest.java} | 35 -
poms/bom-deployment/pom.xml| 5 +++
poms/bom/pom.xml | 10 +
18 files changed, 122 insertions(+), 94 deletions(-)
copy extensions/{controlbus => snakeyaml}/deployment/pom.xml (91%)
copy
extensions/{bean/deployment/src/main/java/org/apache/camel/quarkus/component/bean/deployment/BeanProcessor.java
=>
snakeyaml/deployment/src/main/java/org/apache/camel/quarkus/component/snakeyaml/deployment/SnakeyamlProcessor.java}
(86%)
copy extensions/{netty => snakeyaml}/pom.xml (93%)
copy extensions/{controlbus => snakeyaml}/runtime/pom.xml (92%)
create mode 100644
extensions/snakeyaml/runtime/src/main/resources/META-INF/quarkus-extension.yaml
copy build/create-extension-templates/integration-test-pom.xml =>
integration-tests/snakeyaml/pom.xml (92%)
copy
integration-tests/{infinispan/src/main/java/org/apache/camel/quarkus/component/infinispan/CamelServlet.java
=>
snakeyaml/src/main/java/org/apache/camel/quarkus/component/snakeyaml/it/SnakeYAMLResource.java}
(61%)
copy
integration-tests/{controlbus/src/main/java/org/apache/camel/quarkus/component/controlbus/it/ControlbusRoute.java
=>
snakeyaml/src/main/java/org/apache/camel/quarkus/component/snakeyaml/it/SnakeYAMLRoutes.java}
(62%)
copy examples/rest-json/src/main/java/org/acme/rest/json/Fruit.java =>
integration-tests/snakeyaml/src/main/java/org/apache/camel/quarkus/component/snakeyaml/it/model/TestPojo.java
(60%)
copy
integration-tests/{csv/src/test/java/org/apache/camel/quarkus/component/csv/it/CsvIT.java
=>
snakeyaml/src/test/java/org/apache/camel/quarkus/component/snakeyaml/it/SnakeYAMLIT.java}
(83%)
copy
integration-tests/{slack/src/test/java/org/apache/camel/quarkus/component/slack/it/SlackTest.java
=>
snakeyaml/src/test/java/org/apache/camel/quarkus/component/snakeyaml/it/SnakeYAMLTest.java}
(59%)
[GitHub] [camel-quarkus] lburgazzoli merged pull request #390: Add SnakeYAML extension
lburgazzoli merged pull request #390: Add SnakeYAML extension URL: https://github.com/apache/camel-quarkus/pull/390 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] davsclaus commented on issue #391: camel-validator component
davsclaus commented on issue #391: camel-validator component URL: https://github.com/apache/camel-quarkus/issues/391#issuecomment-552384606 Just mind you may need to add the new extensions to some pom files in the poms folder. The create extension tool dont get around doing all that 100%. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[camel] branch master updated: [CAMEL-14165] Pubnub does not define its dependency on okio
This is an automated email from the ASF dual-hosted git repository.
acosentino pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/master by this push:
new 2fcb6e0 [CAMEL-14165] Pubnub does not define its dependency on okio
2fcb6e0 is described below
commit 2fcb6e0eb208ca7ed8e4a4219dcebeb95c92d8da
Author: Thomas Diesler
AuthorDate: Mon Nov 11 13:05:26 2019 +0100
[CAMEL-14165] Pubnub does not define its dependency on okio
---
components/camel-pubnub/pom.xml | 7 ++-
parent/pom.xml | 3 ++-
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/components/camel-pubnub/pom.xml b/components/camel-pubnub/pom.xml
index 8a9d0cd..0c250d7 100644
--- a/components/camel-pubnub/pom.xml
+++ b/components/camel-pubnub/pom.xml
@@ -50,7 +50,12 @@
com.squareup.okhttp3
okhttp
- ${squareup-okhttp-pubnub-version}
+ ${squareup-okhttp-version}
+
+
+com.squareup.okio
+okio
+${squareup-okio-version}
com.google.code.gson
diff --git a/parent/pom.xml b/parent/pom.xml
index 15e3b35..0001023 100644
--- a/parent/pom.xml
+++ b/parent/pom.xml
@@ -605,7 +605,8 @@
2.5_2
2.12.0
1.5
-3.12.0
+3.12.0
+1.15.0
2.7.5_1
1.15.0_1
2.5.0_2
[GitHub] [camel-quarkus] asf-ci commented on issue #390: Add SnakeYAML extension
asf-ci commented on issue #390: Add SnakeYAML extension URL: https://github.com/apache/camel-quarkus/pull/390#issuecomment-552423909 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/385/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #392: Perform TypeConverterLoader discovery using jandex instead of camel's class path scanner
lburgazzoli commented on issue #392: Perform TypeConverterLoader discovery using jandex instead of camel's class path scanner URL: https://github.com/apache/camel-quarkus/pull/392#issuecomment-552423722 The default type registry does it's own class-path scanning and does not offer an hook for quarkus idiomatic injection of a custom type converter loaders, this PR aims to leverage Quarkus facilities to discover resource files at build time and add an option to inject custom type converter using a build item. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli closed issue #338: Create a Camel SnakeYAML extension
lburgazzoli closed issue #338: Create a Camel SnakeYAML extension URL: https://github.com/apache/camel-quarkus/issues/338 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #390: Add SnakeYAML extension
lburgazzoli commented on issue #390: Add SnakeYAML extension URL: https://github.com/apache/camel-quarkus/pull/390#issuecomment-552378989 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
lburgazzoli commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders URL: https://github.com/apache/camel-quarkus/pull/358#discussion_r344665013 ## File path: extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java ## @@ -232,7 +228,6 @@ CamelMainBuildItem main( CamelContextBuildItem context, CamelRoutesCollectorBuildItem routesCollector, List listeners, -List routesBuilders, Review comment: No CamelBeanBuildItem is - IMHO - the right bean to use as every route bound to the registry is then automatically discovered so CamelRoutesBuilderBuildItem is superfluous. The problem about using ArC in STATIC_INIT is that it may not be aware of the "runtime beans" at that point in time, at least in my experience. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #392: Perform TypeConverterLoader discovery using jandex instead of camel's class path scanner
lburgazzoli commented on issue #392: Perform TypeConverterLoader discovery using jandex instead of camel's class path scanner URL: https://github.com/apache/camel-quarkus/pull/392#issuecomment-552409366 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[camel] branch master updated: Upgrade Mongodb Java driver to version 3.11.2
This is an automated email from the ASF dual-hosted git repository. acosentino pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/camel.git The following commit(s) were added to refs/heads/master by this push: new 5934639 Upgrade Mongodb Java driver to version 3.11.2 5934639 is described below commit 59346397f20ea8f1823ade601281b9f15d463dad Author: Andrea Cosentino AuthorDate: Mon Nov 11 13:00:20 2019 +0100 Upgrade Mongodb Java driver to version 3.11.2 --- parent/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/parent/pom.xml b/parent/pom.xml index 38f8bdd..15e3b35 100644 --- a/parent/pom.xml +++ b/parent/pom.xml @@ -464,7 +464,7 @@ 1.9 0.1.7 3.1.0 -3.11.1 +3.11.2 1.5.0 2013.6.1 0.9.6
[GitHub] [camel-quarkus] ppalaga commented on issue #389: [code formatter] multi line TODOs are not supported
ppalaga commented on issue #389: [code formatter] multi line TODOs are not supported URL: https://github.com/apache/camel-quarkus/issues/389#issuecomment-552353847 In Quarkus it works the way you describe and they have the following two settings that might be what we are missing: ``` ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ploef opened a new issue #391: camel-validator component
ploef opened a new issue #391: camel-validator component URL: https://github.com/apache/camel-quarkus/issues/391 Hi, I'm converting some of my Spring Boot services to Quarkus and see that the camel-validation-component is missing. I will try to create an extension for it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
ppalaga commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders URL: https://github.com/apache/camel-quarkus/pull/358#discussion_r344661828 ## File path: extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java ## @@ -232,7 +228,6 @@ CamelMainBuildItem main( CamelContextBuildItem context, CamelRoutesCollectorBuildItem routesCollector, List listeners, -List routesBuilders, Review comment: Yes, I agree. You perhaps meant CamelRoutesBuilderBuildItem rather than CamelBeanBuildItem? The ultimate aim of this PR is to make the `@Inject`, `@ConfigProperty`, etc. work in RoutesBuilders (see the tests in this PR that currently fail). I agree that the problem of double Route initialization is actually the root cause. My previous proposal to solve both problems by delegating the creation of all RouteBuilders to Arc was rejected for boot performance reasons which I found quite legitimate. I proposed an alternative approach where Arc beans are thrown away from the list provided via CamelRoutesBuilderBuildItem, but I see no feedback for that. In between, I looked how to implement that reliably, and found that the list of Arc beans could perhaps be pulled from Arc itself like this: https://github.com/ppalaga/camel-quarkus/commit/cdbfd1999b35e103944d41e570d266d73fd20995#diff-ec6205752018e84a80fcd9eaa92af189R203-R209 (once they change the visibility of some methods, I asked the Arc guys about that). What do you think about the linked solution? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[camel] 03/04: Upgrade MicroProfile Health API to 2.1
This is an automated email from the ASF dual-hosted git repository. jamesnetherton pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/camel.git commit f7170f7208f37013db226fe04374c80e0926d45d Author: James Netherton AuthorDate: Mon Nov 11 11:10:03 2019 + Upgrade MicroProfile Health API to 2.1 --- parent/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/parent/pom.xml b/parent/pom.xml index 7aca9d2..03fd2d2 100644 --- a/parent/pom.xml +++ b/parent/pom.xml @@ -455,7 +455,7 @@ 1.2.2 1.3 2.2 -2.0.1 +2.1 0.2.5 1.9.12 2.0.21
[camel] 04/04: Upgrade SmallRye Health to 2.1.0
This is an automated email from the ASF dual-hosted git repository. jamesnetherton pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/camel.git commit 4894d65f76f3c1410e81a30ce218653073c0f9b4 Author: James Netherton AuthorDate: Mon Nov 11 11:10:21 2019 + Upgrade SmallRye Health to 2.1.0 --- parent/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/parent/pom.xml b/parent/pom.xml index 03fd2d2..38f8bdd 100644 --- a/parent/pom.xml +++ b/parent/pom.xml @@ -569,7 +569,7 @@ 4.3.4 1.0.0 2.3.0 -2.0.0 +2.1.0 1.25 1.1.4 2.6.3_1
[camel] 01/04: Upgrade MicroProfile Metrics API to 2.2
This is an automated email from the ASF dual-hosted git repository. jamesnetherton pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/camel.git commit 09c80ce2e4a1eb13d1b5e5b46f172946df448168 Author: James Netherton AuthorDate: Mon Nov 11 11:07:10 2019 + Upgrade MicroProfile Metrics API to 2.2 --- parent/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/parent/pom.xml b/parent/pom.xml index bed083e..036ce85 100644 --- a/parent/pom.xml +++ b/parent/pom.xml @@ -454,7 +454,7 @@ 3.2.6 1.2.2 1.3 -2.1.0 +2.2 2.0.1 0.2.5 1.9.12
[camel] branch master updated (5403c9a -> 4894d65)
This is an automated email from the ASF dual-hosted git repository. jamesnetherton pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/camel.git. from 5403c9a Upgrade Kubernetes client to version 4.6.3 new 09c80ce Upgrade MicroProfile Metrics API to 2.2 new d8e5a1a Upgrade SmallRye Metrics to 2.3.0 new f7170f7 Upgrade MicroProfile Health API to 2.1 new 4894d65 Upgrade SmallRye Health to 2.1.0 The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: parent/pom.xml | 8 1 file changed, 4 insertions(+), 4 deletions(-)
[camel] 02/04: Upgrade SmallRye Metrics to 2.3.0
This is an automated email from the ASF dual-hosted git repository. jamesnetherton pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/camel.git commit d8e5a1a2a0b645972d4f1f613c1fa8ad57d5a4a4 Author: James Netherton AuthorDate: Mon Nov 11 11:07:30 2019 + Upgrade SmallRye Metrics to 2.3.0 --- parent/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/parent/pom.xml b/parent/pom.xml index 036ce85..7aca9d2 100644 --- a/parent/pom.xml +++ b/parent/pom.xml @@ -568,7 +568,7 @@ 1.7.29 4.3.4 1.0.0 -2.2.0 +2.3.0 2.0.0 1.25 1.1.4
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
lburgazzoli commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders URL: https://github.com/apache/camel-quarkus/pull/358#discussion_r344665013 ## File path: extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java ## @@ -232,7 +228,6 @@ CamelMainBuildItem main( CamelContextBuildItem context, CamelRoutesCollectorBuildItem routesCollector, List listeners, -List routesBuilders, Review comment: No CamelBeanBuildItem is - IMHO - the right bean to use as every route bound to the registry is then automatically discovered so CamelRoutesBuilderBuildItem is superfluous but that is a minor issue. The problem about using ArC in STATIC_INIT is that it may not be aware of the "runtime beans" at that point in time, at least in my experience. You may think to override the route discovery class and apply the filter there. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #392: Perform TypeConverterLoader discovery using jandex instead of camel's class path scanner
lburgazzoli commented on a change in pull request #392: Perform
TypeConverterLoader discovery using jandex instead of camel's class path scanner
URL: https://github.com/apache/camel-quarkus/pull/392#discussion_r344684441
##
File path:
extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelSupport.java
##
@@ -87,6 +88,14 @@ public static boolean isPublic(ClassInfo ci) {
.map(ClassInfo::toString);
}
+public static CamelBeanBuildItem createBeanFromType(RecorderContext
context, String type) {
+return new CamelBeanBuildItem(type, context.classProxy(type),
context.newInstance(type));
+}
+
+public static CamelBeanBuildItem createBeanFromType(RecorderContext
context, ClassInfo info) {
+return createBeanFromType(context, info.name().toString());
+}
+
Review comment:
they are leftover, let me remove them
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ploef opened a new pull request #393: added Camel validation extension
ploef opened a new pull request #393: added Camel validation extension URL: https://github.com/apache/camel-quarkus/pull/393 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] jamesnetherton opened a new pull request #390: Add SnakeYAML extension
jamesnetherton opened a new pull request #390: Add SnakeYAML extension URL: https://github.com/apache/camel-quarkus/pull/390 fixes #338 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[camel] branch master updated: Upgrade Kubernetes client to version 4.6.3
This is an automated email from the ASF dual-hosted git repository. acosentino pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/camel.git The following commit(s) were added to refs/heads/master by this push: new 5403c9a Upgrade Kubernetes client to version 4.6.3 5403c9a is described below commit 5403c9ade14469d730c1260c9738b6cdce99d714 Author: Andrea Cosentino AuthorDate: Mon Nov 11 11:54:18 2019 +0100 Upgrade Kubernetes client to version 4.6.3 --- parent/pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/parent/pom.xml b/parent/pom.xml index 9b638d1..bed083e 100644 --- a/parent/pom.xml +++ b/parent/pom.xml @@ -402,8 +402,8 @@ 2.3.1_1 4.2.7 7.29.0.Final -4.6.2 -4.6.2 +4.6.3 +4.6.3 1.10.0 2.3.0_3 1.8
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
lburgazzoli commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders URL: https://github.com/apache/camel-quarkus/pull/358#discussion_r344665013 ## File path: extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java ## @@ -232,7 +228,6 @@ CamelMainBuildItem main( CamelContextBuildItem context, CamelRoutesCollectorBuildItem routesCollector, List listeners, -List routesBuilders, Review comment: No CamelBeanBuildItem is - IMHO - the right bean to use as every route bound to the registry is then automatically discovered so CamelRoutesBuilderBuildItem is superfluous but that is a minor issue. The problem about using ArC in STATIC_INIT is that it may not be aware of the "runtime beans" at that point in time, at least in my experience. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #392: Perform TypeConverterLoader discovery using jandex instead of camel's class path scanner
ppalaga commented on a change in pull request #392: Perform TypeConverterLoader
discovery using jandex instead of camel's class path scanner
URL: https://github.com/apache/camel-quarkus/pull/392#discussion_r344679240
##
File path:
extensions/core/runtime/src/main/java/org/apache/camel/quarkus/core/FastTypeConverter.java
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.core;
+
+import org.apache.camel.impl.converter.DefaultTypeConverter;
+import org.apache.camel.spi.TypeConverterLoader;
+
+public class FastTypeConverter extends DefaultTypeConverter {
+public FastTypeConverter() {
+super(null, null, null, null, false);
+}
+
+@Override
+protected void doStart() throws Exception {
+for (TypeConverterLoader loader :
getCamelContext().getRegistry().findByType(TypeConverterLoader.class)) {
+log.debug("TypeConverterLoader: {} loading converters", loader);
+loader.load(this);
+}
+}
+
+@Override
+public void loadCoreAndFastTypeConverters() throws Exception {
+throw new IllegalStateException("This method should not be invoked");
Review comment:
The message is not useful unless it gives a hint why it should not be
invoked.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #392: Perform TypeConverterLoader discovery using jandex instead of camel's class path scanner
ppalaga commented on a change in pull request #392: Perform TypeConverterLoader
discovery using jandex instead of camel's class path scanner
URL: https://github.com/apache/camel-quarkus/pull/392#discussion_r344677133
##
File path:
extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelSupport.java
##
@@ -87,6 +88,14 @@ public static boolean isPublic(ClassInfo ci) {
.map(ClassInfo::toString);
}
+public static CamelBeanBuildItem createBeanFromType(RecorderContext
context, String type) {
+return new CamelBeanBuildItem(type, context.classProxy(type),
context.newInstance(type));
+}
+
+public static CamelBeanBuildItem createBeanFromType(RecorderContext
context, ClassInfo info) {
+return createBeanFromType(context, info.name().toString());
+}
+
Review comment:
I do not see any of these methods used anywhere. Are you sure we need them?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli opened a new issue #389: [code formatter] multi line TODOs are not supported
lburgazzoli opened a new issue #389: [code formatter] multi line TODOs are not supported URL: https://github.com/apache/camel-quarkus/issues/389 Assuming I have a TODO like: ```java // TODO: blablabla // blablabla ``` This is then re-formatted as: ```java // TODO: blablabla // blablabla ``` Which loses IDE support This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #391: camel-validator component
ppalaga commented on issue #391: camel-validator component URL: https://github.com/apache/camel-quarkus/issues/391#issuecomment-552383469 Nice to hear that! Do not hesitate to ask here if you have specific questions. You might want to check https://camel.apache.org/camel-quarkus/latest/contributor-guide.html This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[camel-k-runtime] branch master updated: chore(actions): set the right phase
This is an automated email from the ASF dual-hosted git repository. lburgazzoli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/camel-k-runtime.git The following commit(s) were added to refs/heads/master by this push: new 47c124d chore(actions): set the right phase 47c124d is described below commit 47c124d2858f0a7dac4389e559eca6c8c2d1c643 Author: lburgazzoli AuthorDate: Mon Nov 11 11:45:23 2019 +0100 chore(actions): set the right phase --- .github/workflows/pr-build-java-11.yml | 2 +- .github/workflows/pr-build-java-8.yml | 2 +- .github/workflows/pr-validate.yml | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/pr-build-java-11.yml b/.github/workflows/pr-build-java-11.yml index e3ce547..c3c640a 100644 --- a/.github/workflows/pr-build-java-11.yml +++ b/.github/workflows/pr-build-java-11.yml @@ -29,5 +29,5 @@ jobs: uses: actions/setup-java@v1 with: java-version: 11 -- name: mvn verify +- name: mvn install run: ./mvnw -V -B -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn clean install diff --git a/.github/workflows/pr-build-java-8.yml b/.github/workflows/pr-build-java-8.yml index d17e410..8fd6414 100644 --- a/.github/workflows/pr-build-java-8.yml +++ b/.github/workflows/pr-build-java-8.yml @@ -29,5 +29,5 @@ jobs: uses: actions/setup-java@v1 with: java-version: 1.8 -- name: mvn verify +- name: mvn install run: ./mvnw -V -B -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn clean install diff --git a/.github/workflows/pr-validate.yml b/.github/workflows/pr-validate.yml index 591a5bf..7f033b8 100644 --- a/.github/workflows/pr-validate.yml +++ b/.github/workflows/pr-validate.yml @@ -29,5 +29,5 @@ jobs: uses: actions/setup-java@v1 with: java-version: 1.8 -- name: mvn -Psourcecheck,license - run: ./mvnw -fae -B -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn -Dcheckstyle.failOnViolation=true validate -Psourcecheck,license +- name: mvn package + run: ./mvnw -fae -B -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn -Dcheckstyle.failOnViolation=true clean package -Psourcecheck,license -DskipTests
[GitHub] [camel-quarkus] asf-ci commented on issue #392: Perform TypeConverterLoader discovery using jandex instead of camel's class path scanner
asf-ci commented on issue #392: Perform TypeConverterLoader discovery using jandex instead of camel's class path scanner URL: https://github.com/apache/camel-quarkus/pull/392#issuecomment-552460424 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/386/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] nicolaferraro opened a new pull request #1049: chore(magic): auto-add dependency on camel-jackson when using plain .…
nicolaferraro opened a new pull request #1049: chore(magic): auto-add dependency on camel-jackson when using plain .… URL: https://github.com/apache/camel-k/pull/1049 …json() Now that jackson is the default on Camel 3. **Release Note** ```release-note NONE ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
ppalaga commented on issue #358: Fix #136 @ConfigProperty and @Inject do not
work in RouteBuilders
URL: https://github.com/apache/camel-quarkus/pull/358#issuecomment-552491730
Hm... looking at the test failures, it looks like there is one more problem:
The registry sees only CDI beans instantiated eagerly - e.g. if they have `void
onStart(@Observes StartupEvent event) {}`. Let me check if that can be fixed
somehow.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
ppalaga commented on issue #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders URL: https://github.com/apache/camel-quarkus/pull/358#issuecomment-552461053 About ac51838: * Publish discovered RoutesBuilders via CamelBeanBuildItem instead of CamelRoutesBuilderBuildItem * Introduces CamelRoutesBuilderClassBuildItem to query for RoutesBuilder just once * Got an advice how to "legally" get the list of beans from Arc https://github.com/apache/camel-quarkus/pull/358/files#diff-ec6205752018e84a80fcd9eaa92af189R231 All open questions are solved from my PoV This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga edited a comment on issue #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
ppalaga edited a comment on issue #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders URL: https://github.com/apache/camel-quarkus/pull/358#issuecomment-552461053 About ac51838: * Publish discovered RoutesBuilders via CamelBeanBuildItem instead of CamelRoutesBuilderBuildItem * Introduces CamelRoutesBuilderClassBuildItem to query for RoutesBuilder just once * Got an advice how to "legally" get the list of beans from Arc https://github.com/apache/camel-quarkus/pull/358/files#diff-ec6205752018e84a80fcd9eaa92af189R231 All open questions are solved from my PoV This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli merged pull request #392: Perform TypeConverterLoader discovery using jandex instead of camel's class path scanner
lburgazzoli merged pull request #392: Perform TypeConverterLoader discovery using jandex instead of camel's class path scanner URL: https://github.com/apache/camel-quarkus/pull/392 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[camel] branch master updated: CAMEL-14167: camel-stream - Remove url support
This is an automated email from the ASF dual-hosted git repository. davsclaus pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/camel.git The following commit(s) were added to refs/heads/master by this push: new 726e9dd CAMEL-14167: camel-stream - Remove url support 726e9dd is described below commit 726e9dd0d5a21a7caa1bba3ade39a6bb51c1871d Author: Claus Ibsen AuthorDate: Mon Nov 11 14:48:25 2019 +0100 CAMEL-14167: camel-stream - Remove url support --- components/camel-stream/pom.xml| 5 - .../src/main/docs/stream-component.adoc| 18 +- .../camel/component/stream/StreamComponent.java| 7 - .../camel/component/stream/StreamConsumer.java | 24 --- .../camel/component/stream/StreamEndpoint.java | 49 + .../camel/component/stream/StreamProducer.java | 40 +--- .../component/stream/StreamToUrlJettyTest.java | 53 - .../camel/component/stream/StreamToUrlTest.java| 74 --- .../endpoint/dsl/StreamEndpointBuilderFactory.java | 221 + .../springboot/StreamComponentConfiguration.java | 2 +- 10 files changed, 11 insertions(+), 482 deletions(-) diff --git a/components/camel-stream/pom.xml b/components/camel-stream/pom.xml index 1a4ecf0..b1a967a 100644 --- a/components/camel-stream/pom.xml +++ b/components/camel-stream/pom.xml @@ -69,11 +69,6 @@ junit test - -org.apache.camel -camel-jetty -test - diff --git a/components/camel-stream/src/main/docs/stream-component.adoc b/components/camel-stream/src/main/docs/stream-component.adoc index 0891083..d6e6642 100644 --- a/components/camel-stream/src/main/docs/stream-component.adoc +++ b/components/camel-stream/src/main/docs/stream-component.adoc @@ -4,7 +4,7 @@ *Since Camel 1.3* The Stream component provides access to the `System.in`, `System.out` -and `System.err` streams as well as allowing streaming of file and URL. +and `System.err` streams as well as allowing streaming of file. Maven users will need to add the following dependency to their `pom.xml` for this component: @@ -21,21 +21,14 @@ for this component: == URI format -[source,java] +[source,text] --- stream:in[?options] stream:out[?options] stream:err[?options] stream:header[?options] - -In addition, the `file` and `url` endpoint URIs are supported: - -[source,java] -- stream:file?fileName=/foo/bar.txt -stream:url[?options] -- +--- If the `stream:header` URI is specified, the `stream` header is used to find the stream to write to. This option is available only for stream @@ -80,7 +73,7 @@ with the following path and query parameters: |=== -=== Query Parameters (24 parameters): +=== Query Parameters (21 parameters): [width="100%",cols="2,5,^1,2",options="header"] @@ -88,7 +81,6 @@ with the following path and query parameters: | Name | Description | Default | Type | *encoding* (common) | You can configure the encoding (is a charset name) to use text-based streams (for example, message body is a String object). If not provided, Camel uses the JVM default Charset. | | String | *fileName* (common) | When using the stream:file URI format, this option specifies the filename to stream to/from. | | String -| *url* (common) | When using the stream:url URI format, this option specifies the URL to stream to/from. The input/output stream will be opened using the JDK URLConnection facility. | | String | *bridgeErrorHandler* (consumer) | Allows for bridging the consumer to the Camel routing Error Handler, which mean any exceptions occurred while the consumer is trying to pickup incoming messages, or the likes, will now be processed as a message and handled by the routing Error Handler. By default the consumer will use the org.apache.camel.spi.ExceptionHandler to deal with exceptions, that will be logged at WARN or ERROR level and ignored. | false | boolean | *fileWatcher* (consumer) | To use JVM file watcher to listen for file change events to support re-loading files that may be overwritten, somewhat like tail --retry | false | boolean | *groupLines* (consumer) | To group X number of lines in the consumer. For example to group 10 lines and therefore only spit out an Exchange with 10 lines, instead of 1 Exchange per line. | | int @@ -106,8 +98,6 @@ with the following path and query parameters: | *delay* (producer) | Initial delay in milliseconds before producing the stream. | | long | *lazyStartProducer* (producer) | Whether the producer should be started lazy (on the first message). By starting lazy you can use this to allow CamelContext and routes to startup in situations where a producer may otherwise fail during starting and cause the route to fail being started. By deferring this startup
[GitHub] [camel-quarkus] lburgazzoli commented on issue #392: Perform TypeConverterLoader discovery using jandex instead of camel's class path scanner
lburgazzoli commented on issue #392: Perform TypeConverterLoader discovery using jandex instead of camel's class path scanner URL: https://github.com/apache/camel-quarkus/pull/392#issuecomment-552457320 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[camel] 03/03: CAMEL-14168 - Regen and fixed adoc
This is an automated email from the ASF dual-hosted git repository. acosentino pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/camel.git commit 131c7985486534fa52df674e012e2243f000be64 Author: Andrea Cosentino AuthorDate: Mon Nov 11 15:44:19 2019 +0100 CAMEL-14168 - Regen and fixed adoc --- docs/components/modules/ROOT/nav.adoc | 1 - docs/components/modules/ROOT/pages/index.adoc | 2 +- docs/user-manual/modules/ROOT/pages/index.adoc | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/docs/components/modules/ROOT/nav.adoc b/docs/components/modules/ROOT/nav.adoc index 213c893..588f174 100644 --- a/docs/components/modules/ROOT/nav.adoc +++ b/docs/components/modules/ROOT/nav.adoc @@ -228,7 +228,6 @@ * xref:ldap-component.adoc[LDAP Component] * xref:ldif-component.adoc[LDIF Component] * xref:leveldb.adoc[LevelDB] -* xref:linkedin-component.adoc[Linkedin Component] * xref:log-component.adoc[Log Component] * xref:lra.adoc[LRA Component] * xref:lucene-component.adoc[Lucene Component] diff --git a/docs/components/modules/ROOT/pages/index.adoc b/docs/components/modules/ROOT/pages/index.adoc index ce62947..ec47f94 100644 --- a/docs/components/modules/ROOT/pages/index.adoc +++ b/docs/components/modules/ROOT/pages/index.adoc @@ -6,7 +6,7 @@ The following Apache Camel artifacts are provided: == Components // components: START -Number of Components: 304 in 242 JAR artifacts (0 deprecated) +Number of Components: 303 in 241 JAR artifacts (0 deprecated) [width="100%",cols="4,1,5",options="header"] |=== diff --git a/docs/user-manual/modules/ROOT/pages/index.adoc b/docs/user-manual/modules/ROOT/pages/index.adoc index 627cb7b..9e123c8 100644 --- a/docs/user-manual/modules/ROOT/pages/index.adoc +++ b/docs/user-manual/modules/ROOT/pages/index.adoc @@ -308,7 +308,6 @@ camel routes without them knowing ** xref:components::kubernetes-services-component.adoc[Kubernetes Services] ** xref:components::ldap-component.adoc[LDAP] ** xref:components::ldif-component.adoc[LDIF] -** xref:components::linkedin-component.adoc[Linkedin] ** xref:components::lucene-component.adoc[Lucene] ** xref:components::lumberjack-component.adoc[Lumberjack] ** xref:components::master-component.adoc[Master]
[camel] branch master updated (726e9dd -> 131c798)
This is an automated email from the ASF dual-hosted git repository. acosentino pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/camel.git. from 726e9dd CAMEL-14167: camel-stream - Remove url support new 2804e00 CAMEL-14168 - Camel-Linkedin: Remove the component new 63103a4 CAMEL-14168 - Fixed compilation new 131c798 CAMEL-14168 - Regen and fixed adoc The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: apache-camel/pom.xml | 15 - apache-camel/src/main/descriptors/common-bin.xml |3 - bom/camel-bom/pom.xml | 20 - .../camel-linkedin/camel-linkedin-api/pom.xml | 246 --- .../component/linkedin/api/DoubleAdapter.java | 36 - .../api/EnumQueryParamConverterProvider.java | 74 - .../component/linkedin/api/LinkedInException.java | 48 - .../api/LinkedInExceptionResponseFilter.java | 96 - .../linkedin/api/LinkedInOAuthRequestFilter.java | 380 .../camel/component/linkedin/api/LongAdapter.java | 36 - .../camel/component/linkedin/api/OAuthParams.java | 107 - .../camel/component/linkedin/api/OAuthScope.java | 66 - .../component/linkedin/api/OAuthSecureStorage.java | 36 - .../camel/component/linkedin/api/OAuthToken.java | 50 - .../src/main/resources/linkedin-api-schema.xjb | 478 .../src/main/resources/linkedin-api-schema.xsd | 2293 .../src/main/resources/linkedin-api-wadl.xml | 1013 - .../camel-linkedin-api/src/main/resources/wadl.xsd | 281 --- .../api/AbstractResourceIntegrationTest.java | 141 -- .../api/PeopleResourceIntegrationTest.java | 128 -- .../api/SearchResourceIntegrationTest.java | 46 - .../src/test/resources/log4j2.properties | 28 - .../src/test/resources/test-options.properties | 33 - .../camel-linkedin-component/pom.xml | 306 --- .../src/main/docs/linkedin-component.adoc | 747 --- .../linkedin/DefaultOAuthSecureStorage.java| 38 - .../component/linkedin/LinkedInComponent.java | 121 -- .../component/linkedin/LinkedInConfiguration.java | 291 --- .../camel/component/linkedin/LinkedInConsumer.java | 77 - .../camel/component/linkedin/LinkedInEndpoint.java | 188 -- .../camel/component/linkedin/LinkedInProducer.java | 59 - .../internal/CachingOAuthSecureStorage.java| 50 - .../linkedin/internal/LinkedInConstants.java | 29 - .../internal/LinkedInPropertiesHelper.java | 40 - .../linkedin/AbstractLinkedInTestSupport.java | 89 - .../linkedin/CommentsResourceIntegrationTest.java | 80 - .../linkedin/CompaniesResourceIntegrationTest.java | 331 --- .../ComponentConfigurationIntegrationTest.java | 81 - .../linkedin/GroupsResourceIntegrationTest.java| 79 - .../linkedin/JobsResourceIntegrationTest.java | 106 - .../linkedin/PeopleResourceIntegrationTest.java| 654 -- .../linkedin/PostsResourceIntegrationTest.java | 176 -- .../linkedin/SearchResourceIntegrationTest.java| 175 -- .../src/test/resources/log4j2.properties | 28 - .../src/test/resources/test-options.properties | 33 - components/camel-linkedin/pom.xml | 67 - components/pom.xml |1 - .../builder/endpoint/EndpointBuilderFactory.java |1 - .../dsl/LinkedInEndpointBuilderFactory.java| 1585 -- docs/components/modules/ROOT/nav.adoc |1 - docs/components/modules/ROOT/pages/index.adoc |4 +- .../modules/ROOT/pages/linkedin-component.adoc | 748 --- docs/user-manual/modules/ROOT/pages/index.adoc |1 - parent/pom.xml | 20 - .../karaf/features/src/main/resources/features.xml | 29 - .../camel-linkedin-starter/pom.xml | 61 - .../LinkedInComponentAutoConfiguration.java| 128 -- .../springboot/LinkedInComponentConfiguration.java | 259 --- .../src/main/resources/META-INF/LICENSE.txt| 203 -- .../src/main/resources/META-INF/NOTICE.txt | 11 - .../additional-spring-configuration-metadata.json | 10 - .../src/main/resources/META-INF/spring.factories | 18 - .../src/main/resources/META-INF/spring.provides| 17 - platforms/spring-boot/components-starter/pom.xml |1 - .../camel-spring-boot-dependencies/pom.xml | 20 - .../camel/itest/springboot/CamelLinkedinTest.java | 50 - .../camel/maven/packaging/PackageHelper.java |1 - .../maven/packaging/PrepareCatalogKarafMojo.java |3 - .../camel/maven/packaging/PrepareCatalogMojo.java |7 +-
[camel] 02/03: CAMEL-14168 - Fixed compilation
This is an automated email from the ASF dual-hosted git repository.
acosentino pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git
commit 63103a4dd90b9b167c97ab257fd1b5d906c35f84
Author: Andrea Cosentino
AuthorDate: Mon Nov 11 14:57:20 2019 +0100
CAMEL-14168 - Fixed compilation
---
.../java/org/apache/camel/builder/endpoint/EndpointBuilderFactory.java | 1 -
.../main/java/org/apache/camel/maven/packaging/PrepareCatalogMojo.java | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git
a/core/camel-endpointdsl/src/main/java/org/apache/camel/builder/endpoint/EndpointBuilderFactory.java
b/core/camel-endpointdsl/src/main/java/org/apache/camel/builder/endpoint/EndpointBuilderFactory.java
index ec2eeb4..631c84e 100644
---
a/core/camel-endpointdsl/src/main/java/org/apache/camel/builder/endpoint/EndpointBuilderFactory.java
+++
b/core/camel-endpointdsl/src/main/java/org/apache/camel/builder/endpoint/EndpointBuilderFactory.java
@@ -198,7 +198,6 @@ public interface EndpointBuilderFactory extends
LanguageEndpointBuilderFactory,
LdapEndpointBuilderFactory,
LdifEndpointBuilderFactory,
-LinkedInEndpointBuilderFactory,
LogEndpointBuilderFactory,
LuceneEndpointBuilderFactory,
LumberjackEndpointBuilderFactory,
diff --git
a/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/PrepareCatalogMojo.java
b/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/PrepareCatalogMojo.java
index c4eb3de..293c254 100644
---
a/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/PrepareCatalogMojo.java
+++
b/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/PrepareCatalogMojo.java
@@ -1190,7 +1190,7 @@ public class PrepareCatalogMojo extends AbstractMojo {
component = "ftp";
}
String name = component + "-component";
-if (!docs.contains(name) &&
!component.equalsIgnoreCase("salesforce") &&
!component.equalsIgnoreCase("servicenow"))) {
+if (!docs.contains(name) &&
(!component.equalsIgnoreCase("salesforce") &&
!component.equalsIgnoreCase("servicenow"))) {
missing.add(name);
}
}
[camel-quarkus] branch master updated (b9eb61e -> 391348d)
This is an automated email from the ASF dual-hosted git repository.
lburgazzoli pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/camel-quarkus.git.
from b9eb61e chore(build): Make PR validate run package phase to avoid
downloading stale SNAPSHOT artifacts
new b7ad857 Perform TypeConverterLoader discovery using jandex instead of
camel's class path scanner
new 4759188 code formatter] multi line TODOs are not supported #389
new 391348d Fix findings
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
build/eclipse-formatter-config.xml | 2 +
.../quarkus/core/deployment/BuildProcessor.java| 63 ++
...java => CamelTypeConverterLoaderBuildItem.java} | 14 ++---
...va => CamelTypeConverterRegistryBuildItem.java} | 13 ++---
.../apache/camel/quarkus/core/CamelRecorder.java | 21 ++--
.../camel/quarkus/core/FastCamelContext.java | 22
...sabledXmlLoader.java => FastTypeConverter.java} | 27 ++
.../support/deployment/SupportBuildStep.java | 7 +++
.../support/{SupportRecorder.java => MyPair.java} | 18 ---
.../core/runtime/support/SupportRecorder.java | 5 ++
...corder.java => SupportTypeConverterLoader.java} | 18 ---
.../apache/camel/quarkus/core/CamelServlet.java| 14 +
.../org/apache/camel/quarkus/core/CamelTest.java | 11
13 files changed, 180 insertions(+), 55 deletions(-)
copy
extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/{CamelContextBuildItem.java
=> CamelTypeConverterLoaderBuildItem.java} (68%)
copy
extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/{CamelContextBuildItem.java
=> CamelTypeConverterRegistryBuildItem.java} (70%)
copy
extensions/core/runtime/src/main/java/org/apache/camel/quarkus/core/{DisabledXmlLoader.java
=> FastTypeConverter.java} (54%)
copy
integration-tests/core-main/runtime/src/main/java/org/apache/camel/quarkus/core/runtime/support/{SupportRecorder.java
=> MyPair.java} (73%)
copy
integration-tests/core-main/runtime/src/main/java/org/apache/camel/quarkus/core/runtime/support/{SupportRecorder.java
=> SupportTypeConverterLoader.java} (59%)
[camel-quarkus] 01/03: Perform TypeConverterLoader discovery using jandex instead of camel's class path scanner
This is an automated email from the ASF dual-hosted git repository.
lburgazzoli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel-quarkus.git
commit b7ad857c2a0820c7405f1717c4f63720e92bdf17
Author: lburgazzoli
AuthorDate: Mon Nov 11 11:24:35 2019 +0100
Perform TypeConverterLoader discovery using jandex instead of camel's class
path scanner
---
.../quarkus/core/deployment/BuildProcessor.java| 63 ++
.../quarkus/core/deployment/CamelSupport.java | 9
.../CamelTypeConverterLoaderBuildItem.java | 22 +---
.../CamelTypeConverterRegistryBuildItem.java | 23 +---
.../apache/camel/quarkus/core/CamelRecorder.java | 21 ++--
.../camel/quarkus/core/FastCamelContext.java | 22
.../camel/quarkus/core/FastTypeConverter.java | 44 +++
.../support/deployment/SupportBuildStep.java | 7 +++
.../support/{SupportRecorder.java => MyPair.java} | 18 ---
.../core/runtime/support/SupportRecorder.java | 5 ++
...corder.java => SupportTypeConverterLoader.java} | 18 ---
.../apache/camel/quarkus/core/CamelServlet.java| 14 +
.../org/apache/camel/quarkus/core/CamelTest.java | 11
13 files changed, 231 insertions(+), 46 deletions(-)
diff --git
a/extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java
b/extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java
index 50478d4..5270ac7 100644
---
a/extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java
+++
b/extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java
@@ -16,11 +16,16 @@
*/
package org.apache.camel.quarkus.core.deployment;
+import java.io.IOException;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
import java.util.List;
import java.util.stream.Collectors;
import io.quarkus.arc.deployment.AdditionalBeanBuildItem;
import io.quarkus.arc.deployment.BeanContainerBuildItem;
+import io.quarkus.deployment.ApplicationArchive;
import io.quarkus.deployment.Capabilities;
import io.quarkus.deployment.annotations.BuildProducer;
import io.quarkus.deployment.annotations.BuildStep;
@@ -35,6 +40,7 @@ import io.quarkus.deployment.recording.RecorderContext;
import io.quarkus.runtime.RuntimeValue;
import org.apache.camel.CamelContext;
import org.apache.camel.RoutesBuilder;
+import org.apache.camel.impl.converter.BaseTypeConverterRegistry;
import org.apache.camel.quarkus.core.CamelMain;
import org.apache.camel.quarkus.core.CamelMainProducers;
import org.apache.camel.quarkus.core.CamelMainRecorder;
@@ -46,11 +52,15 @@ import org.apache.camel.quarkus.core.Flags;
import org.apache.camel.quarkus.core.UploadAttacher;
import org.apache.camel.quarkus.support.common.CamelCapabilities;
import org.apache.camel.spi.Registry;
+import org.apache.camel.spi.TypeConverterLoader;
+import org.apache.camel.spi.TypeConverterRegistry;
+import org.jboss.jandex.DotName;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
class BuildProcessor {
private static final Logger LOGGER =
LoggerFactory.getLogger(BuildProcessor.class);
+private static final DotName TYPE_CONVERTER_LOADER_TYPE =
DotName.createSimple(TypeConverterLoader.class.getName());
/*
* Build steps related to camel core.
@@ -71,6 +81,57 @@ class BuildProcessor {
new
CamelServiceFilterBuildItem(CamelServiceFilter.forService("properties-component-factory")));
}
+/*
+ * Discover {@link TypeConverterLoader}.
+ */
+@Record(ExecutionTime.STATIC_INIT)
+@BuildStep
+CamelTypeConverterRegistryBuildItem typeConverterRegistry(
+CamelRecorder recorder,
+RecorderContext recorderContext,
+ApplicationArchivesBuildItem applicationArchives,
+List additionalLoaders) {
+
+RuntimeValue typeConverterRegistry =
recorder.createTypeConverterRegistry();
+
+//
+// This should be simplified by searching for classes implementing
TypeConverterLoader but that
+// would lead to have
org.apache.camel.impl.converter.AnnotationTypeConverterLoader taken into
+// account even if it should not.
+//
+// TODO: we could add a filter to discard
AnnotationTypeConverterLoader but maybe we should introduce
+// a marker interface like StaticTypeConverterLoader for
loaders that do not require to perform
+// any discovery at runtime.
+//
+for (ApplicationArchive archive :
applicationArchives.getAllApplicationArchives()) {
+Path path =
[GitHub] [camel-quarkus] lburgazzoli closed issue #389: [code formatter] multi line TODOs are not supported
lburgazzoli closed issue #389: [code formatter] multi line TODOs are not supported URL: https://github.com/apache/camel-quarkus/issues/389 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[camel-quarkus] 02/03: code formatter] multi line TODOs are not supported #389
This is an automated email from the ASF dual-hosted git repository. lburgazzoli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/camel-quarkus.git commit 47591887286a8764411a1af72eef6c44dbcda2c9 Author: lburgazzoli AuthorDate: Mon Nov 11 11:25:12 2019 +0100 code formatter] multi line TODOs are not supported #389 --- build/eclipse-formatter-config.xml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/build/eclipse-formatter-config.xml b/build/eclipse-formatter-config.xml index ffe394c..d0cd7cc 100644 --- a/build/eclipse-formatter-config.xml +++ b/build/eclipse-formatter-config.xml @@ -265,5 +265,7 @@ + +
[GitHub] [camel-k-runtime] lburgazzoli commented on issue #182: Ad a specific section in the camel-k-runtime catalog to list loaders and related dependencies
lburgazzoli commented on issue #182: Ad a specific section in the camel-k-runtime catalog to list loaders and related dependencies URL: https://github.com/apache/camel-k-runtime/issues/182#issuecomment-552551655 Will remove it This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ploef commented on issue #391: camel-validator component
ploef commented on issue #391: camel-validator component URL: https://github.com/apache/camel-quarkus/issues/391#issuecomment-552555621 Thanks for the tip! I already managed to get it working locally. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
ppalaga commented on issue #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders URL: https://github.com/apache/camel-quarkus/pull/358#issuecomment-552563450 I solved the mentioned problem by marking all RouteBuilder classes as unremovable via UnremovableBeanBuildItem. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[camel] branch master updated: CAMEL-13825: Add consumer and producer info to the component docs
This is an automated email from the ASF dual-hosted git repository.
oalsafi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/master by this push:
new 20caeb4 CAMEL-13825: Add consumer and producer info to the component
docs
new 6de983c Merge pull request #3330 from omarsmak/CAMEL-13825
20caeb4 is described below
commit 20caeb46eda01a556535d6b54c8b80c53cf4f083
Author: Omar Al-Safi
AuthorDate: Mon Nov 11 18:28:05 2019 +0100
CAMEL-13825: Add consumer and producer info to the component docs
---
.../camel/maven/packaging/UpdateReadmeMojo.java| 76 --
1 file changed, 70 insertions(+), 6 deletions(-)
diff --git
a/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/UpdateReadmeMojo.java
b/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/UpdateReadmeMojo.java
index 387581d..f3e3b7c 100644
---
a/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/UpdateReadmeMojo.java
+++
b/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/UpdateReadmeMojo.java
@@ -146,6 +146,7 @@ public class UpdateReadmeMojo extends AbstractMojo {
updated = updateLink(file, componentName + "-component");
updated |= updateTitles(file, docTitle);
updated |= updateAvailableFrom(file,
model.getFirstVersion());
+updated |= updateComponentHeader(file, model);
// resolvePropertyPlaceholders is an option which only
make sense to use if the component has other options
boolean hasOptions =
model.getComponentOptions().stream().anyMatch(o ->
!o.getName().equals("resolvePropertyPlaceholders"));
@@ -479,17 +480,70 @@ public class UpdateReadmeMojo extends AbstractMojo {
return updated;
}
+private boolean updateComponentHeader(final File file, final
ComponentModel model) throws MojoExecutionException {
+if (!file.exists()) {
+return false;
+}
+
+final String markerStart = "// HEADER START";
+final String markerEnd = "// HEADER END";
+
+final String headerText = generateHeaderTextData(model);
+
+try (InputStream fileStream = new FileInputStream(file)) {
+final String loadedText = loadText(fileStream);
+
+String existing = StringHelper.between(loadedText, markerStart,
markerEnd);
+
+if (existing != null) {
+// remove leading line breaks etc
+existing = existing.trim();
+if (existing.equals(headerText)) {
+return false;
+}
+
+final String before = StringHelper.before(loadedText,
markerStart);
+final String after = StringHelper.after(loadedText, markerEnd);
+final String updatedHeaderText = before + markerStart + "\n" +
headerText + "\n" + markerEnd + after;
+
+writeText(file, updatedHeaderText);
+return true;
+} else {
+// so we don't have the marker, so we add it somewhere after
the camel version
+final String sinceVersion = "*Since Camel " +
shortenVersion(model.getFirstVersion()) + "*";
+final String before = StringHelper.before(loadedText,
sinceVersion);
+final String after = StringHelper.after(loadedText,
sinceVersion);
+final String updatedHeaderText = before + sinceVersion +
"\n\n" + markerStart + "\n" + headerText + "\n" + markerEnd + after;
+
+writeText(file, updatedHeaderText);
+return true;
+}
+} catch (Exception e) {
+throw new MojoExecutionException("Error reading file " + file + "
Reason: " + e, e);
+}
+}
+
+private static String generateHeaderTextData(final ComponentModel model) {
+final boolean consumerOnly =
Boolean.parseBoolean(model.getConsumerOnly());
+final boolean producerOnly =
Boolean.parseBoolean(model.getProducerOnly());
+// if we have only producer support
+if (!consumerOnly && producerOnly) {
+return "*Only Producer is supported*";
+}
+// if we have only consumer support
+if (consumerOnly && !producerOnly) {
+return "*Only Consumer is supported*";
+}
+
+return "*Both Producer and Consumer are supported*";
+}
+
private static boolean updateAvailableFrom(final File file, final String
firstVersion) throws MojoExecutionException {
if (firstVersion == null || !file.exists()) {
return false;
}
-String version = firstVersion;
-// cut last digit so its not 2.18.0 but 2.18
-String[] parts =
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
lburgazzoli commented on a change in pull request #358: Fix #136
@ConfigProperty and @Inject do not work in RouteBuilders
URL: https://github.com/apache/camel-quarkus/pull/358#discussion_r344864731
##
File path:
extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java
##
@@ -249,17 +262,55 @@ CamelRuntimeRegistryBuildItem bindRuntimeBeansToRegistry(
* disabled by setting quarkus.camel.disable-main = true
*/
public static class Main {
+
+@BuildStep
+public List
discoverRoutesBuilderClassNames(
+CombinedIndexBuildItem combinedIndex) {
+final IndexView index = combinedIndex.getIndex();
+Set allKnownImplementors = new HashSet<>();
+allKnownImplementors.addAll(
+
index.getAllKnownImplementors(DotName.createSimple(RoutesBuilder.class.getName(;
+allKnownImplementors.addAll(
+
index.getAllKnownSubclasses(DotName.createSimple(RouteBuilder.class.getName(;
+allKnownImplementors.addAll(
+
index.getAllKnownSubclasses(DotName.createSimple(AdviceWithRouteBuilder.class.getName(;
+
+return allKnownImplementors
+.stream()
+// public and non-abstract
+.filter(ci -> ((ci.flags() & (Modifier.ABSTRACT |
Modifier.PUBLIC)) == Modifier.PUBLIC))
+.map(ClassInfo::name)
+.map(CamelRoutesBuilderClassBuildItem::new)
+.collect(Collectors.toList());
+}
+
@Record(ExecutionTime.STATIC_INIT)
@BuildStep
-public List collectRoutes(
-CombinedIndexBuildItem combinedIndex,
+public List collectRoutes(
+List camelRoutesBuilders,
CamelMainRecorder recorder,
+BeanRegistrationPhaseBuildItem beanRegistrationPhase,
RecorderContext recorderContext) {
-return
CamelSupport.getRouteBuilderClasses(combinedIndex.getIndex())
-.map(recorderContext:: newInstance)
-.map(CamelRoutesBuilderBuildItem::new)
-.collect(Collectors.toList());
+final Set arcBeanClasses =
beanRegistrationPhase.getContext().get(BuildExtension.Key.BEANS)
+.stream()
+.map(BeanInfo::getImplClazz)
+.map(ClassInfo::name)
+.collect(Collectors.toSet());
+
+final List result = new
ArrayList();
+camelRoutesBuilders.stream()
+.map(CamelRoutesBuilderClassBuildItem::getDotName)
+.filter(dotName -> !arcBeanClasses.contains(dotName))
+.forEach(dotName -> {
Review comment:
maybe map + collect would be more idiomatic
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #391: camel-validator component
lburgazzoli commented on issue #391: camel-validator component URL: https://github.com/apache/camel-quarkus/issues/391#issuecomment-552582782 It fails on JDK 11 because the class `com.sun.org.apache.xerces.internal.impl.dv.xs` is probably hidden in a module This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[camel] branch master updated (131c798 -> 7c7a983)
This is an automated email from the ASF dual-hosted git repository. coheigea pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/camel.git. from 131c798 CAMEL-14168 - Regen and fixed adoc new 6f1b82f Use SecureRandom to generate the as2 message Id new 80df113 Make sure the temp file is jailed to the tmpdir new 91a7fb4 Updating Asciidoctor new 7c7a983 Updating plexus utils The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../main/java/org/apache/camel/component/as2/api/util/AS2Utils.java | 4 ++-- .../main/java/org/apache/camel/component/jira/FileConverter.java| 6 +- parent/pom.xml | 2 +- tooling/parent/pom.xml | 2 +- 4 files changed, 9 insertions(+), 5 deletions(-)
[camel] 03/04: Updating Asciidoctor
This is an automated email from the ASF dual-hosted git repository. coheigea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/camel.git commit 91a7fb48e96673ea26d5ecfb4fd72f934f9b8ac7 Author: Colm O hEigeartaigh AuthorDate: Mon Nov 11 18:02:27 2019 + Updating Asciidoctor --- parent/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/parent/pom.xml b/parent/pom.xml index a5de5a8..821f3c1 100644 --- a/parent/pom.xml +++ b/parent/pom.xml @@ -64,7 +64,7 @@ 1.0.2.Final 1.5.0.Final 2.0.0.Final -1.5.6 +2.1.0 5.0.4 1.9.4 3.14.0
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
lburgazzoli commented on a change in pull request #358: Fix #136
@ConfigProperty and @Inject do not work in RouteBuilders
URL: https://github.com/apache/camel-quarkus/pull/358#discussion_r344866021
##
File path:
extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java
##
@@ -274,6 +325,18 @@ void beans(BuildProducer
beanProducer) {
beanProducer.produce(AdditionalBeanBuildItem.unremovableOf(CamelMainProducers.class));
}
+@BuildStep(onlyIf = Flags.MainEnabled.class)
Review comment:
maybe add some doc explaining why it is needed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
lburgazzoli commented on a change in pull request #358: Fix #136
@ConfigProperty and @Inject do not work in RouteBuilders
URL: https://github.com/apache/camel-quarkus/pull/358#discussion_r344867677
##
File path:
extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelRoutesBuilderClassBuildItem.java
##
@@ -17,20 +17,23 @@
package org.apache.camel.quarkus.core.deployment;
import io.quarkus.builder.item.MultiBuildItem;
-import io.quarkus.runtime.RuntimeValue;
import org.apache.camel.RoutesBuilder;
+import org.jboss.jandex.DotName;
/**
- * Holds the {@link RoutesBuilder} {@link RuntimeValue}.
+ * A {@link MultiBuildItem} holding class names of all {@link RoutesBuilder}
implementations found via Jandex.
*/
-public final class CamelRoutesBuilderBuildItem extends MultiBuildItem {
-private final RuntimeValue routesBuilder;
+public final class CamelRoutesBuilderClassBuildItem extends MultiBuildItem {
-public CamelRoutesBuilderBuildItem(RuntimeValue
routesBuilder) {
-this.routesBuilder = routesBuilder;
-}
+private final DotName dotName;
-public RuntimeValue getInstance() {
-return routesBuilder;
+public CamelRoutesBuilderClassBuildItem(DotName dotName) {
+super();
Review comment:
isn't this superfluous ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #393: added Camel validation extension
lburgazzoli commented on a change in pull request #393: added Camel validation extension URL: https://github.com/apache/camel-quarkus/pull/393#discussion_r344886929 ## File path: extensions/attachments/runtime/src/main/resources/META-INF/quarkus-extension.yaml ## @@ -1,3 +1,20 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + Review comment: not very sure, each file should contain the license header afaik This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
ppalaga commented on a change in pull request #358: Fix #136 @ConfigProperty
and @Inject do not work in RouteBuilders
URL: https://github.com/apache/camel-quarkus/pull/358#discussion_r344886972
##
File path:
extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelRoutesBuilderClassBuildItem.java
##
@@ -17,20 +17,23 @@
package org.apache.camel.quarkus.core.deployment;
import io.quarkus.builder.item.MultiBuildItem;
-import io.quarkus.runtime.RuntimeValue;
import org.apache.camel.RoutesBuilder;
+import org.jboss.jandex.DotName;
/**
- * Holds the {@link RoutesBuilder} {@link RuntimeValue}.
+ * A {@link MultiBuildItem} holding class names of all {@link RoutesBuilder}
implementations found via Jandex.
Review comment:
True, let me reword it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #394: Fix license headers
ppalaga commented on a change in pull request #394: Fix license headers URL: https://github.com/apache/camel-quarkus/pull/394#discussion_r344886284 ## File path: pom.xml ## @@ -304,10 +305,14 @@ **/META-INF/persistence*.xsd **/pom.xml.versionsBackup ide-config/** +**/*.mvel +**/quarkus-extension.yaml Review comment: I think we do not want the license headers in the quarkus-extension.yaml files. WDYT? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
ppalaga commented on a change in pull request #358: Fix #136 @ConfigProperty
and @Inject do not work in RouteBuilders
URL: https://github.com/apache/camel-quarkus/pull/358#discussion_r344890711
##
File path:
extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java
##
@@ -249,17 +262,55 @@ CamelRuntimeRegistryBuildItem bindRuntimeBeansToRegistry(
* disabled by setting quarkus.camel.disable-main = true
*/
public static class Main {
+
+@BuildStep
+public List
discoverRoutesBuilderClassNames(
+CombinedIndexBuildItem combinedIndex) {
+final IndexView index = combinedIndex.getIndex();
+Set allKnownImplementors = new HashSet<>();
+allKnownImplementors.addAll(
+
index.getAllKnownImplementors(DotName.createSimple(RoutesBuilder.class.getName(;
+allKnownImplementors.addAll(
+
index.getAllKnownSubclasses(DotName.createSimple(RouteBuilder.class.getName(;
+allKnownImplementors.addAll(
+
index.getAllKnownSubclasses(DotName.createSimple(AdviceWithRouteBuilder.class.getName(;
+
+return allKnownImplementors
+.stream()
+// public and non-abstract
+.filter(ci -> ((ci.flags() & (Modifier.ABSTRACT |
Modifier.PUBLIC)) == Modifier.PUBLIC))
+.map(ClassInfo::name)
+.map(CamelRoutesBuilderClassBuildItem::new)
+.collect(Collectors.toList());
+}
+
@Record(ExecutionTime.STATIC_INIT)
@BuildStep
-public List collectRoutes(
-CombinedIndexBuildItem combinedIndex,
+public List collectRoutes(
+List camelRoutesBuilders,
CamelMainRecorder recorder,
+BeanRegistrationPhaseBuildItem beanRegistrationPhase,
RecorderContext recorderContext) {
-return
CamelSupport.getRouteBuilderClasses(combinedIndex.getIndex())
-.map(recorderContext:: newInstance)
-.map(CamelRoutesBuilderBuildItem::new)
-.collect(Collectors.toList());
+final Set arcBeanClasses =
beanRegistrationPhase.getContext().get(BuildExtension.Key.BEANS)
+.stream()
+.map(BeanInfo::getImplClazz)
+.map(ClassInfo::name)
+.collect(Collectors.toSet());
+
+final List result = new
ArrayList();
+camelRoutesBuilders.stream()
+.map(CamelRoutesBuilderClassBuildItem::getDotName)
+.filter(dotName -> !arcBeanClasses.contains(dotName))
+.forEach(dotName -> {
Review comment:
Yeah, that would be possible now. The previous revisions did not allow that.
Let me refactor.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[camel] 02/02: camel-bean: Should assume Boolean/boolean parameter types are matching.
This is an automated email from the ASF dual-hosted git repository.
davsclaus pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git
commit 074ca0fd652e69394d2db9e57065df413a6abca8
Author: Claus Ibsen
AuthorDate: Mon Nov 11 19:21:09 2019 +0100
camel-bean: Should assume Boolean/boolean parameter types are matching.
---
.../src/main/java/org/apache/camel/component/bean/BeanInfo.java | 6 ++
1 file changed, 6 insertions(+)
diff --git
a/components/camel-bean/src/main/java/org/apache/camel/component/bean/BeanInfo.java
b/components/camel-bean/src/main/java/org/apache/camel/component/bean/BeanInfo.java
index bd0f8cb..4cd5478 100644
---
a/components/camel-bean/src/main/java/org/apache/camel/component/bean/BeanInfo.java
+++
b/components/camel-bean/src/main/java/org/apache/camel/component/bean/BeanInfo.java
@@ -738,6 +738,12 @@ public class BeanInfo {
return true;
}
}
+if (Boolean.class.equals(parameterType)) {
+// boolean should match both Boolean and boolean
+if (Boolean.class.isAssignableFrom(expectedType) ||
boolean.class.isAssignableFrom(expectedType)) {
+return true;
+}
+}
return parameterType.isAssignableFrom(expectedType);
}
[camel] branch master updated (7c7a983 -> 074ca0f)
This is an automated email from the ASF dual-hosted git repository.
davsclaus pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git.
from 7c7a983 Updating plexus utils
new dad2e1f CAMEL-14153: Add support for constructor parameters to
property binding support - eg for camel-main configurations.
new 074ca0f camel-bean: Should assume Boolean/boolean parameter types are
matching.
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../org/apache/camel/component/bean/BeanInfo.java | 6 +
.../java/org/apache/camel/support}/Animal.java | 37 ++-
.../camel/support/PropertyBindingSupportTest.java | 34 +++
.../camel/support/PropertyBindingSupport.java | 258 +
4 files changed, 264 insertions(+), 71 deletions(-)
copy {components/camel-groovy/src/test/java/org/apache/camel/language/groovy
=> core/camel-core/src/test/java/org/apache/camel/support}/Animal.java (68%)
[camel] 01/02: CAMEL-14153: Add support for constructor parameters to property binding support - eg for camel-main configurations.
This is an automated email from the ASF dual-hosted git repository.
davsclaus pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git
commit dad2e1f705acc816b933cb4c808403df9bdab575
Author: Claus Ibsen
AuthorDate: Mon Nov 11 19:19:26 2019 +0100
CAMEL-14153: Add support for constructor parameters to property binding
support - eg for camel-main configurations.
---
.../test/java/org/apache/camel/support/Animal.java | 50
.../camel/support/PropertyBindingSupportTest.java | 34 +++
.../camel/support/PropertyBindingSupport.java | 258 +
3 files changed, 293 insertions(+), 49 deletions(-)
diff --git a/core/camel-core/src/test/java/org/apache/camel/support/Animal.java
b/core/camel-core/src/test/java/org/apache/camel/support/Animal.java
new file mode 100644
index 000..73ada4b
--- /dev/null
+++ b/core/camel-core/src/test/java/org/apache/camel/support/Animal.java
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.support;
+
+public class Animal {
+private String name;
+private boolean dangerous;
+
+public Animal() {
+}
+
+public Animal(String name) {
+this.name = name;
+}
+
+public Animal(boolean dangerous, int foo) {
+throw new IllegalArgumentException("Should not be invoked");
+}
+
+public Animal(String name, boolean dangerous) {
+this.name = name;
+this.dangerous = dangerous;
+}
+
+public String getName() {
+return name;
+}
+
+public boolean isDangerous() {
+return dangerous;
+}
+
+public void setDangerous(boolean dangerous) {
+this.dangerous = dangerous;
+}
+}
diff --git
a/core/camel-core/src/test/java/org/apache/camel/support/PropertyBindingSupportTest.java
b/core/camel-core/src/test/java/org/apache/camel/support/PropertyBindingSupportTest.java
index eb995d7..f0b2bec 100644
---
a/core/camel-core/src/test/java/org/apache/camel/support/PropertyBindingSupportTest.java
+++
b/core/camel-core/src/test/java/org/apache/camel/support/PropertyBindingSupportTest.java
@@ -346,9 +346,35 @@ public class PropertyBindingSupportTest extends
ContextTestSupport {
}
}
+@Test
+public void testNestedClassConstructorParameterOneParameter() throws
Exception {
+Foo foo = new Foo();
+
+PropertyBindingSupport.build().bind(context, foo, "name", "James");
+PropertyBindingSupport.build().bind(context, foo, "animal",
"#class:org.apache.camel.support.Animal('Tony Tiger')");
+PropertyBindingSupport.build().bind(context, foo, "animal.dangerous",
"true");
+
+assertEquals("James", foo.getName());
+assertEquals("Tony Tiger", foo.getAnimal().getName());
+assertEquals(true, foo.getAnimal().isDangerous());
+}
+
+@Test
+public void testNestedClassConstructorParameterTwoParameter() throws
Exception {
+Foo foo = new Foo();
+
+PropertyBindingSupport.build().bind(context, foo, "name", "James");
+PropertyBindingSupport.build().bind(context, foo, "animal",
"#class:org.apache.camel.support.Animal('Donald Duck', false)");
+
+assertEquals("James", foo.getName());
+assertEquals("Donald Duck", foo.getAnimal().getName());
+assertEquals(false, foo.getAnimal().isDangerous());
+}
+
public static class Foo {
private String name;
private Bar bar = new Bar();
+private Animal animal;
public String getName() {
return name;
@@ -365,6 +391,14 @@ public class PropertyBindingSupportTest extends
ContextTestSupport {
public void setBar(Bar bar) {
this.bar = bar;
}
+
+public Animal getAnimal() {
+return animal;
+}
+
+public void setAnimal(Animal animal) {
+this.animal = animal;
+}
}
public static class Bar {
diff --git
a/core/camel-support/src/main/java/org/apache/camel/support/PropertyBindingSupport.java
b/core/camel-support/src/main/java/org/apache/camel/support/PropertyBindingSupport.java
index f88621e..ce63ff1 100644
---
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
lburgazzoli commented on a change in pull request #358: Fix #136
@ConfigProperty and @Inject do not work in RouteBuilders
URL: https://github.com/apache/camel-quarkus/pull/358#discussion_r344863669
##
File path:
extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/NativeImageProcessor.java
##
@@ -176,17 +177,15 @@ protected void addReflectiveMethod(MethodInfo mi) {
public static class Main {
@BuildStep(onlyIf = Flags.MainEnabled.class)
void process(
-CombinedIndexBuildItem combinedIndex,
+List camelRoutesBuilders,
BuildProducer reflectiveClass) {
-IndexView view = combinedIndex.getIndex();
-
//
// Register routes as reflection aware as camel-main main use
reflection
// to bind beans to the registry
//
-CamelSupport.getRouteBuilderClasses(view).forEach(name -> {
-reflectiveClass.produce(new ReflectiveClassBuildItem(true,
false, name));
+camelRoutesBuilders.stream().forEach(dotName -> {
Review comment:
`stream()` is not needed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
lburgazzoli commented on a change in pull request #358: Fix #136
@ConfigProperty and @Inject do not work in RouteBuilders
URL: https://github.com/apache/camel-quarkus/pull/358#discussion_r344863306
##
File path:
extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelRoutesBuilderClassBuildItem.java
##
@@ -17,20 +17,23 @@
package org.apache.camel.quarkus.core.deployment;
import io.quarkus.builder.item.MultiBuildItem;
-import io.quarkus.runtime.RuntimeValue;
import org.apache.camel.RoutesBuilder;
+import org.jboss.jandex.DotName;
/**
- * Holds the {@link RoutesBuilder} {@link RuntimeValue}.
+ * A {@link MultiBuildItem} holding class names of all {@link RoutesBuilder}
implementations found via Jandex.
Review comment:
Not very sure if `implementations found via Jandex` really make sense as any
extension developer can create it programmatically.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[camel] branch master updated (0a0a8e2 -> 1c13946)
This is an automated email from the ASF dual-hosted git repository. davsclaus pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/camel.git. from 0a0a8e2 CAMEL-14153: Add support for constructor parameters to property binding support - eg for camel-main configurations. new 073a020e CAMEL-13825: Fix and regen docs new 1c13946 CAMEL-13825: Regen website docs The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../src/main/docs/activemq-component.adoc | 4 ++ .../src/main/docs/ahc-ws-component.adoc| 4 ++ .../camel-ahc/src/main/docs/ahc-component.adoc | 4 ++ .../camel-amqp/src/main/docs/amqp-component.adoc | 4 ++ .../camel-apns/src/main/docs/apns-component.adoc | 4 ++ .../src/main/docs/as2-component.adoc | 4 ++ .../src/main/docs/asterisk-component.adoc | 4 ++ .../camel-atmos/src/main/docs/atmos-component.adoc | 4 ++ .../main/docs/atmosphere-websocket-component.adoc | 4 ++ .../camel-atom/src/main/docs/atom-component.adoc | 4 ++ .../src/main/docs/atomix-map-component.adoc| 4 ++ .../src/main/docs/atomix-messaging-component.adoc | 4 ++ .../src/main/docs/atomix-multimap-component.adoc | 4 ++ .../src/main/docs/atomix-queue-component.adoc | 4 ++ .../src/main/docs/atomix-set-component.adoc| 4 ++ .../src/main/docs/atomix-value-component.adoc | 4 ++ .../camel-avro/src/main/docs/avro-component.adoc | 4 ++ .../src/main/docs/aws-cw-component.adoc| 4 ++ .../src/main/docs/aws-ddb-component.adoc | 4 ++ .../src/main/docs/aws-ddbstream-component.adoc | 4 ++ .../src/main/docs/aws-ec2-component.adoc | 4 ++ .../src/main/docs/aws-ecs-component.adoc | 4 ++ .../src/main/docs/aws-eks-component.adoc | 4 ++ .../src/main/docs/aws-iam-component.adoc | 4 ++ .../src/main/docs/aws-kinesis-component.adoc | 4 ++ .../main/docs/aws-kinesis-firehose-component.adoc | 4 ++ .../src/main/docs/aws-kms-component.adoc | 4 ++ .../src/main/docs/aws-lambda-component.adoc| 4 ++ .../src/main/docs/aws-mq-component.adoc| 4 ++ .../src/main/docs/aws-msk-component.adoc | 4 ++ .../src/main/docs/aws-s3-component.adoc| 4 ++ .../src/main/docs/aws-sdb-component.adoc | 4 ++ .../src/main/docs/aws-ses-component.adoc | 4 ++ .../src/main/docs/aws-sns-component.adoc | 4 ++ .../src/main/docs/aws-sqs-component.adoc | 4 ++ .../src/main/docs/aws-swf-component.adoc | 4 ++ .../src/main/docs/aws-translate-component.adoc | 4 ++ .../src/main/docs/azure-blob-component.adoc| 4 ++ .../src/main/docs/azure-queue-component.adoc | 4 ++ .../src/main/docs/bean-validator-component.adoc| 4 ++ .../camel-bean/src/main/docs/bean-component.adoc | 4 ++ .../camel-bean/src/main/docs/class-component.adoc | 4 ++ .../src/main/docs/beanstalk-component.adoc | 4 ++ .../src/main/docs/bonita-component.adoc| 4 ++ .../src/main/docs/box-component.adoc | 4 ++ .../src/main/docs/braintree-component.adoc | 4 ++ .../src/main/docs/browse-component.adoc| 4 ++ .../src/main/docs/caffeine-cache-component.adoc| 4 ++ .../main/docs/caffeine-loadcache-component.adoc| 4 ++ .../src/main/docs/cql-component.adoc | 4 ++ .../src/main/docs/chatscript-component.adoc| 4 ++ .../camel-chunk/src/main/docs/chunk-component.adoc | 4 ++ .../src/main/docs/cm-sms-component.adoc| 4 ++ .../camel-cmis/src/main/docs/cmis-component.adoc | 4 ++ .../camel-coap/src/main/docs/coap-component.adoc | 4 ++ .../src/main/docs/cometd-component.adoc| 4 ++ .../src/main/docs/consul-component.adoc| 4 ++ .../src/main/docs/controlbus-component.adoc| 4 ++ .../camel-corda/src/main/docs/corda-component.adoc | 6 ++- .../src/main/docs/couchbase-component.adoc | 4 ++ .../src/main/docs/couchdb-component.adoc | 4 ++ .../src/main/docs/crypto-cms-component.adoc| 4 ++ .../src/main/docs/crypto-component.adoc| 4 ++ .../camel-cxf/src/main/docs/cxf-component.adoc | 4 ++ .../camel-cxf/src/main/docs/cxfrs-component.adoc | 4 ++ .../src/main/docs/dataformat-component.adoc| 4 ++ .../src/main/docs/dataset-component.adoc | 4 ++ .../src/main/docs/dataset-test-component.adoc | 4 ++ .../src/main/docs/debezium-mongodb-component.adoc | 4 ++ .../src/main/docs/debezium-mysql-component.adoc| 4 ++ .../src/main/docs/debezium-postgres-component.adoc | 4 ++ .../main/docs/debezium-sqlserver-component.adoc| 4 ++
[GitHub] [camel-k-runtime] lburgazzoli opened a new issue #195: Remove support for java class loader
lburgazzoli opened a new issue #195: Remove support for java class loader URL: https://github.com/apache/camel-k-runtime/issues/195 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #393: added Camel validation extension
ppalaga commented on a change in pull request #393: added Camel validation extension URL: https://github.com/apache/camel-quarkus/pull/393#discussion_r344885749 ## File path: extensions/attachments/runtime/src/main/resources/META-INF/quarkus-extension.yaml ## @@ -1,3 +1,20 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + Review comment: I do not think we want license headers in quarkus-extension.yaml files. Not your fault, @ploef , it is a broken config of the license plugin. I have just sent https://github.com/apache/camel-quarkus/pull/394 to fix this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
ppalaga commented on a change in pull request #358: Fix #136 @ConfigProperty
and @Inject do not work in RouteBuilders
URL: https://github.com/apache/camel-quarkus/pull/358#discussion_r344888604
##
File path:
extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/NativeImageProcessor.java
##
@@ -176,17 +177,15 @@ protected void addReflectiveMethod(MethodInfo mi) {
public static class Main {
@BuildStep(onlyIf = Flags.MainEnabled.class)
void process(
-CombinedIndexBuildItem combinedIndex,
+List camelRoutesBuilders,
BuildProducer reflectiveClass) {
-IndexView view = combinedIndex.getIndex();
-
//
// Register routes as reflection aware as camel-main main use
reflection
// to bind beans to the registry
//
-CamelSupport.getRouteBuilderClasses(view).forEach(name -> {
-reflectiveClass.produce(new ReflectiveClassBuildItem(true,
false, name));
+camelRoutesBuilders.stream().forEach(dotName -> {
Review comment:
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
ppalaga commented on a change in pull request #358: Fix #136 @ConfigProperty
and @Inject do not work in RouteBuilders
URL: https://github.com/apache/camel-quarkus/pull/358#discussion_r344892800
##
File path:
extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java
##
@@ -274,6 +325,18 @@ void beans(BuildProducer
beanProducer) {
beanProducer.produce(AdditionalBeanBuildItem.unremovableOf(CamelMainProducers.class));
}
+@BuildStep(onlyIf = Flags.MainEnabled.class)
Review comment:
Haha, you've got me. It's a result of copy and paste. Let me figure out if I
actually want that.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[camel] 02/04: Make sure the temp file is jailed to the tmpdir
This is an automated email from the ASF dual-hosted git repository.
coheigea pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git
commit 80df11395d45e0a0e27b556bedf80cd18268f4e3
Author: Colm O hEigeartaigh
AuthorDate: Mon Nov 11 15:41:01 2019 +
Make sure the temp file is jailed to the tmpdir
---
.../main/java/org/apache/camel/component/jira/FileConverter.java| 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git
a/components/camel-jira/src/main/java/org/apache/camel/component/jira/FileConverter.java
b/components/camel-jira/src/main/java/org/apache/camel/component/jira/FileConverter.java
index 6e3bb1c..11048af 100644
---
a/components/camel-jira/src/main/java/org/apache/camel/component/jira/FileConverter.java
+++
b/components/camel-jira/src/main/java/org/apache/camel/component/jira/FileConverter.java
@@ -37,7 +37,11 @@ public final class FileConverter {
File file;
if (body instanceof byte[]) {
byte[] bos = (byte[]) body;
-file = new File(System.getProperty("java.io.tmpdir"),
genericFile.getFileName());
+String destDir = System.getProperty("java.io.tmpdir");
+file = new File(destDir, genericFile.getFileName());
+if (!file.getCanonicalPath().startsWith(destDir)) {
+throw new IOException("File is not jailed to the destination
directory");
+}
Files.write(file.toPath(), bos, StandardOpenOption.CREATE);
// delete the temporary file on exit, as other routing may need
the file for post processing
file.deleteOnExit();
[GitHub] [camel-quarkus] ploef commented on issue #391: camel-validator component
ploef commented on issue #391: camel-validator component URL: https://github.com/apache/camel-quarkus/issues/391#issuecomment-552566209 Hmmm, the checks after the pull requests keep turning red. Locally everything seems fine. Code builds ok and tests are green. It looks like the dependency for camel-quarkus-support-xml is missing but it should be there. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[camel] branch master updated: CAMEL-14153: Add support for constructor parameters to property binding support - eg for camel-main configurations.
This is an automated email from the ASF dual-hosted git repository.
davsclaus pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/master by this push:
new 0a0a8e2 CAMEL-14153: Add support for constructor parameters to
property binding support - eg for camel-main configurations.
0a0a8e2 is described below
commit 0a0a8e2f9c8b60d8df42b2144f474675f2d7c093
Author: Claus Ibsen
AuthorDate: Mon Nov 11 20:16:15 2019 +0100
CAMEL-14153: Add support for constructor parameters to property binding
support - eg for camel-main configurations.
---
.../org/apache/camel/support/PropertyBindingSupportTest.java | 12
1 file changed, 12 insertions(+)
diff --git
a/core/camel-core/src/test/java/org/apache/camel/support/PropertyBindingSupportTest.java
b/core/camel-core/src/test/java/org/apache/camel/support/PropertyBindingSupportTest.java
index f0b2bec..7b86a3e 100644
---
a/core/camel-core/src/test/java/org/apache/camel/support/PropertyBindingSupportTest.java
+++
b/core/camel-core/src/test/java/org/apache/camel/support/PropertyBindingSupportTest.java
@@ -360,6 +360,18 @@ public class PropertyBindingSupportTest extends
ContextTestSupport {
}
@Test
+public void testNestedClassConstructorParameterPlaceholder() throws
Exception {
+Foo foo = new Foo();
+
+PropertyBindingSupport.build().bind(context, foo, "name", "James");
+PropertyBindingSupport.build().bind(context, foo, "animal",
"#class:org.apache.camel.support.Animal('{{companyName}}', false)");
+
+assertEquals("James", foo.getName());
+assertEquals("Acme", foo.getAnimal().getName());
+assertEquals(false, foo.getAnimal().isDangerous());
+}
+
+@Test
public void testNestedClassConstructorParameterTwoParameter() throws
Exception {
Foo foo = new Foo();
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
lburgazzoli commented on a change in pull request #358: Fix #136
@ConfigProperty and @Inject do not work in RouteBuilders
URL: https://github.com/apache/camel-quarkus/pull/358#discussion_r344866929
##
File path:
extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java
##
@@ -249,17 +262,55 @@ CamelRuntimeRegistryBuildItem bindRuntimeBeansToRegistry(
* disabled by setting quarkus.camel.disable-main = true
*/
public static class Main {
+
+@BuildStep
+public List
discoverRoutesBuilderClassNames(
+CombinedIndexBuildItem combinedIndex) {
+final IndexView index = combinedIndex.getIndex();
+Set allKnownImplementors = new HashSet<>();
+allKnownImplementors.addAll(
+
index.getAllKnownImplementors(DotName.createSimple(RoutesBuilder.class.getName(;
+allKnownImplementors.addAll(
+
index.getAllKnownSubclasses(DotName.createSimple(RouteBuilder.class.getName(;
+allKnownImplementors.addAll(
+
index.getAllKnownSubclasses(DotName.createSimple(AdviceWithRouteBuilder.class.getName(;
+
+return allKnownImplementors
+.stream()
+// public and non-abstract
+.filter(ci -> ((ci.flags() & (Modifier.ABSTRACT |
Modifier.PUBLIC)) == Modifier.PUBLIC))
+.map(ClassInfo::name)
+.map(CamelRoutesBuilderClassBuildItem::new)
+.collect(Collectors.toList());
+}
+
@Record(ExecutionTime.STATIC_INIT)
@BuildStep
-public List collectRoutes(
-CombinedIndexBuildItem combinedIndex,
+public List collectRoutes(
+List camelRoutesBuilders,
Review comment:
maybe the name should reflect that fact thet it is about classes and not
instances, something like `camelRoutesBuilderClasses` ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga opened a new pull request #394: Fix license headers
ppalaga opened a new pull request #394: Fix license headers URL: https://github.com/apache/camel-quarkus/pull/394 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
lburgazzoli commented on issue #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders URL: https://github.com/apache/camel-quarkus/pull/358#issuecomment-552638855 ``` [INFO] [io.quarkus.deployment.pkg.steps.NativeImageBuildStep] docker run -v /home/jenkins/jenkins-slave/workspace/camel-quarkus-pr/integration-tests/core/test/target/camel-quarkus-integration-test-core-0.3.2-SNAPSHOT-native-image-source-jar:/project:z --user 910:910 --rm quay.io/quarkus/ubi-quarkus-native-image:19.2.1 -J-Dsun.nio.ch.maxUpdateArraySize=100 -J-Djava.util.logging.manager=org.jboss.logmanager.LogManager -J-Dvertx.logger-delegate-factory-class-name=io.quarkus.vertx.core.runtime.VertxLogDelegateFactory -J-Dvertx.disableDnsResolver=true -J-Dio.netty.leakDetection.level=DISABLED -J-Dio.netty.allocator.maxOrder=1 --initialize-at-build-time= -H:InitialCollectionPolicy=com.oracle.svm.core.genscavenge.CollectionPolicy$BySpaceAndTime -jar camel-quarkus-integration-test-core-0.3.2-SNAPSHOT-runner.jar -J-Djava.util.concurrent.ForkJoinPool.common.parallelism=1 -H:FallbackThreshold=0 -H:+ReportExceptionStackTraces -H:-AddAllCharsets -H:EnableURLProtocols=http -H:-JNI --no-server -H:-UseServiceLoaderFeature -H:+StackTrace camel-quarkus-integration-test-core-0.3.2-SNAPSHOT-runner [camel-quarkus-integration-test-core-0.3.2-SNAPSHOT-runner:40]classlist: 9,590.29 ms [camel-quarkus-integration-test-core-0.3.2-SNAPSHOT-runner:40](cap): 1,994.93 ms [camel-quarkus-integration-test-core-0.3.2-SNAPSHOT-runner:40]setup: 4,862.12 ms 21:20:20,130 INFO [org.jbo.threads] JBoss Threads version 3.0.0.Final [camel-quarkus-integration-test-core-0.3.2-SNAPSHOT-runner:40] analysis: 12,192.52 ms Error: Class initialization of io.quarkus.runner.ApplicationImpl failed. Use the option --initialize-at-run-time=io.quarkus.runner.ApplicationImpl to explicitly request delayed initialization of this class. Detailed message: com.oracle.svm.core.util.UserError$UserException: Class initialization of io.quarkus.runner.ApplicationImpl failed. Use the option --initialize-at-run-time=io.quarkus.runner.ApplicationImpl to explicitly request delayed initialization of this class. Detailed message: at com.oracle.svm.core.util.UserError.abort(UserError.java:75) at com.oracle.svm.hosted.FallbackFeature.reportAsFallback(FallbackFeature.java:223) at com.oracle.svm.hosted.NativeImageGenerator.runPointsToAnalysis(NativeImageGenerator.java:737) at com.oracle.svm.hosted.NativeImageGenerator.doRun(NativeImageGenerator.java:526) at com.oracle.svm.hosted.NativeImageGenerator.lambda$run$0(NativeImageGenerator.java:444) at java.util.concurrent.ForkJoinTask$AdaptedRunnableAction.exec(ForkJoinTask.java:1386) at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289) at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056) at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692) at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157) Caused by: com.oracle.graal.pointsto.constraints.UnsupportedFeatureException: Class initialization of io.quarkus.runner.ApplicationImpl failed. Use the option --initialize-at-run-time=io.quarkus.runner.ApplicationImpl to explicitly request delayed initialization of this class. Detailed message: at com.oracle.graal.pointsto.constraints.UnsupportedFeatures.report(UnsupportedFeatures.java:130) at com.oracle.graal.pointsto.BigBang.finish(BigBang.java:565) at com.oracle.svm.hosted.NativeImageGenerator.runPointsToAnalysis(NativeImageGenerator.java:688) ... 7 more Caused by: java.lang.ExceptionInInitializerError at sun.misc.Unsafe.ensureClassInitialized(Native Method) at com.oracle.svm.hosted.classinitialization.ConfigurableClassInitialization.ensureClassInitialized(ConfigurableClassInitialization.java:153) at com.oracle.svm.hosted.classinitialization.ConfigurableClassInitialization.computeInitKindAndMaybeInitializeClass(ConfigurableClassInitialization.java:557) at com.oracle.svm.hosted.classinitialization.ConfigurableClassInitialization.computeInitKindAndMaybeInitializeClass(ConfigurableClassInitialization.java:116) at com.oracle.svm.hosted.classinitialization.ConfigurableClassInitialization.maybeInitializeHosted(ConfigurableClassInitialization.java:144) at com.oracle.svm.hosted.SVMHost.registerType(SVMHost.java:190) at com.oracle.graal.pointsto.meta.AnalysisUniverse.createType(AnalysisUniverse.java:262) at com.oracle.graal.pointsto.meta.AnalysisUniverse.lookupAllowUnresolved(AnalysisUniverse.java:203) at com.oracle.graal.pointsto.infrastructure.WrappedConstantPool.lookupType(WrappedConstantPool.java:155) at
[GitHub] [camel-k] nicolaferraro opened a new pull request #1054: Fix #1048: use container mode only when no other mechanism is available
nicolaferraro opened a new pull request #1054: Fix #1048: use container mode only when no other mechanism is available URL: https://github.com/apache/camel-k/pull/1054 Fix #1048 **Release Note** ```release-note Fixed "kamel" CLI to authenticate via user credentials, if available, in containerized IDEs ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
ppalaga commented on a change in pull request #358: Fix #136 @ConfigProperty
and @Inject do not work in RouteBuilders
URL: https://github.com/apache/camel-quarkus/pull/358#discussion_r344901192
##
File path:
extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java
##
@@ -249,17 +262,55 @@ CamelRuntimeRegistryBuildItem bindRuntimeBeansToRegistry(
* disabled by setting quarkus.camel.disable-main = true
*/
public static class Main {
+
+@BuildStep
+public List
discoverRoutesBuilderClassNames(
+CombinedIndexBuildItem combinedIndex) {
+final IndexView index = combinedIndex.getIndex();
+Set allKnownImplementors = new HashSet<>();
+allKnownImplementors.addAll(
+
index.getAllKnownImplementors(DotName.createSimple(RoutesBuilder.class.getName(;
+allKnownImplementors.addAll(
+
index.getAllKnownSubclasses(DotName.createSimple(RouteBuilder.class.getName(;
+allKnownImplementors.addAll(
+
index.getAllKnownSubclasses(DotName.createSimple(AdviceWithRouteBuilder.class.getName(;
+
+return allKnownImplementors
+.stream()
+// public and non-abstract
+.filter(ci -> ((ci.flags() & (Modifier.ABSTRACT |
Modifier.PUBLIC)) == Modifier.PUBLIC))
+.map(ClassInfo::name)
+.map(CamelRoutesBuilderClassBuildItem::new)
+.collect(Collectors.toList());
+}
+
@Record(ExecutionTime.STATIC_INIT)
@BuildStep
-public List collectRoutes(
-CombinedIndexBuildItem combinedIndex,
+public List collectRoutes(
+List camelRoutesBuilders,
Review comment:
np
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k-runtime] asf-ci commented on issue #194: loaders: remove java class loader as it is misleading
asf-ci commented on issue #194: loaders: remove java class loader as it is misleading URL: https://github.com/apache/camel-k-runtime/pull/194#issuecomment-552611441 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-k-runtime-pr/3/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #394: Fix license headers
ppalaga commented on a change in pull request #394: Fix license headers URL: https://github.com/apache/camel-quarkus/pull/394#discussion_r344907157 ## File path: pom.xml ## @@ -304,10 +305,14 @@ **/META-INF/persistence*.xsd **/pom.xml.versionsBackup ide-config/** +**/*.mvel +**/quarkus-extension.yaml Review comment: OK, removed the line. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
lburgazzoli commented on issue #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders URL: https://github.com/apache/camel-quarkus/pull/358#issuecomment-552614034 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #394: Fix license headers
lburgazzoli commented on issue #394: Fix license headers URL: https://github.com/apache/camel-quarkus/pull/394#issuecomment-552623402 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] nicolaferraro opened a new pull request #1051: Fix #1036: generate k8s client for camel k resources
nicolaferraro opened a new pull request #1051: Fix #1036: generate k8s client for camel k resources URL: https://github.com/apache/camel-k/pull/1051 Fix #1036 **Release Note** ```release-note A Go client for interacting with Camel K Kubernetes resources is now available ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] lburgazzoli opened a new pull request #1052: Remove support for java class loader i
lburgazzoli opened a new pull request #1052: Remove support for java class loader i URL: https://github.com/apache/camel-k/pull/1052 Fixes #1050 **Release Note** ```release-note Remove support for loading compiled java classes ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
lburgazzoli commented on a change in pull request #358: Fix #136
@ConfigProperty and @Inject do not work in RouteBuilders
URL: https://github.com/apache/camel-quarkus/pull/358#discussion_r344900212
##
File path:
extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/BuildProcessor.java
##
@@ -274,6 +325,18 @@ void beans(BuildProducer
beanProducer) {
beanProducer.produce(AdditionalBeanBuildItem.unremovableOf(CamelMainProducers.class));
}
+@BuildStep(onlyIf = Flags.MainEnabled.class)
Review comment:
maybe add also some lines about the reason of adding unremoveable beans
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k-runtime] lburgazzoli commented on issue #194: loaders: remove java class loader as it is misleading
lburgazzoli commented on issue #194: loaders: remove java class loader as it is misleading URL: https://github.com/apache/camel-k-runtime/pull/194#issuecomment-552606542 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
ppalaga commented on issue #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders URL: https://github.com/apache/camel-quarkus/pull/358#issuecomment-552609750 All requests by @lburgazzoli addressed in 22fed9b This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
asf-ci commented on issue #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders URL: https://github.com/apache/camel-quarkus/pull/358#issuecomment-552637437 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/388/Build result: FAILURE[...truncated 1.83 MB...]at sun.reflect.GeneratedMethodAccessor255.invoke (Unknown Source)at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)at java.lang.reflect.Method.invoke (Method.java:498)at io.quarkus.deployment.ExtensionLoader$1.execute (ExtensionLoader.java:941)at io.quarkus.builder.BuildContext.run (BuildContext.java:415)at org.jboss.threads.ContextClassLoaderSavingRunnable.run (ContextClassLoaderSavingRunnable.java:35)at org.jboss.threads.EnhancedQueueExecutor.safeRun (EnhancedQueueExecutor.java:2011)at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask (EnhancedQueueExecutor.java:1535)at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run (EnhancedQueueExecutor.java:1426)at java.lang.Thread.run (Thread.java:748) at org.jboss.threads.JBossThread.run (JBossThread.java:479)[ERROR] [ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn -rf :camel-quarkus-integration-test-corechannel stoppedAdding one-line test results to commit status...Setting status of 22fed9ba53b7b3ff3537e9274e09b9538979f93e to FAILURE with url https://builds.apache.org/job/camel-quarkus-pr/388/ and message: 'FAILURE 113 tests run, 3 skipped, 0 failed.'Using context: default This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] nicolaferraro opened a new pull request #1053: Fix #1038: redeploy integration when trait config changes
nicolaferraro opened a new pull request #1053: Fix #1038: redeploy integration when trait config changes URL: https://github.com/apache/camel-k/pull/1053 Fix #1038 **Release Note** ```release-note NONE ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
ppalaga commented on a change in pull request #358: Fix #136 @ConfigProperty
and @Inject do not work in RouteBuilders
URL: https://github.com/apache/camel-quarkus/pull/358#discussion_r344902446
##
File path:
extensions/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelRoutesBuilderClassBuildItem.java
##
@@ -17,20 +17,23 @@
package org.apache.camel.quarkus.core.deployment;
import io.quarkus.builder.item.MultiBuildItem;
-import io.quarkus.runtime.RuntimeValue;
import org.apache.camel.RoutesBuilder;
+import org.jboss.jandex.DotName;
/**
- * Holds the {@link RoutesBuilder} {@link RuntimeValue}.
+ * A {@link MultiBuildItem} holding class names of all {@link RoutesBuilder}
implementations found via Jandex.
*/
-public final class CamelRoutesBuilderBuildItem extends MultiBuildItem {
-private final RuntimeValue routesBuilder;
+public final class CamelRoutesBuilderClassBuildItem extends MultiBuildItem {
-public CamelRoutesBuilderBuildItem(RuntimeValue
routesBuilder) {
-this.routesBuilder = routesBuilder;
-}
+private final DotName dotName;
-public RuntimeValue getInstance() {
-return routesBuilder;
+public CamelRoutesBuilderClassBuildItem(DotName dotName) {
+super();
Review comment:
Eclipse seems to be doing that by default.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #394: Fix license headers
lburgazzoli commented on a change in pull request #394: Fix license headers URL: https://github.com/apache/camel-quarkus/pull/394#discussion_r344902410 ## File path: pom.xml ## @@ -304,10 +305,14 @@ **/META-INF/persistence*.xsd **/pom.xml.versionsBackup ide-config/** +**/*.mvel +**/quarkus-extension.yaml Review comment: If it does not harm the quarkus processing I would say we should add to be consistent with other similar files (i.e. properties) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-k] lburgazzoli opened a new issue #1050: Remove support for java class loader
lburgazzoli opened a new issue #1050: Remove support for java class loader URL: https://github.com/apache/camel-k/issues/1050 See https://github.com/apache/camel-k-runtime/issues/195 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #395: Cleanup Netty extension
lburgazzoli commented on issue #395: Cleanup Netty extension URL: https://github.com/apache/camel-quarkus/pull/395#issuecomment-552655308 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #394: Fix license headers
asf-ci commented on issue #394: Fix license headers URL: https://github.com/apache/camel-quarkus/pull/394#issuecomment-552670770 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/389/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-quarkus] asf-ci commented on issue #395: Cleanup Netty extension
asf-ci commented on issue #395: Cleanup Netty extension URL: https://github.com/apache/camel-quarkus/pull/395#issuecomment-552701025 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/camel-quarkus-pr/390/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[camel-k-runtime] branch master updated: Remove support for java class loader #195
This is an automated email from the ASF dual-hosted git repository.
davsclaus pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel-k-runtime.git
The following commit(s) were added to refs/heads/master by this push:
new 808b0ea Remove support for java class loader #195
new 23d7599 Merge pull request #194 from lburgazzoli/java-class
808b0ea is described below
commit 808b0ea00d594c0ff6605c5c987f3f50cd8c7146
Author: lburgazzoli
AuthorDate: Mon Nov 11 20:46:32 2019 +0100
Remove support for java class loader #195
---
.../camel/k/loader/java/JavaClassRoutesLoader.java | 47 --
.../services/org/apache/camel/k/loader/class | 18 -
.../org/apache/camel/k/loader/java/MyRoutes.java | 27 -
.../camel/k/loader/java/RoutesLoaderTest.java | 14 ---
.../org/apache/camel/k/main/MyRoutesWithBeans.java | 34
.../java/org/apache/camel/k/main/RuntimeTest.java | 13 --
6 files changed, 153 deletions(-)
diff --git
a/camel-k-loader-java/src/main/java/org/apache/camel/k/loader/java/JavaClassRoutesLoader.java
b/camel-k-loader-java/src/main/java/org/apache/camel/k/loader/java/JavaClassRoutesLoader.java
deleted file mode 100644
index f0b9753..000
---
a/camel-k-loader-java/src/main/java/org/apache/camel/k/loader/java/JavaClassRoutesLoader.java
+++ /dev/null
@@ -1,47 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.camel.k.loader.java;
-
-import java.util.Collections;
-import java.util.List;
-
-import org.apache.camel.CamelContext;
-import org.apache.camel.builder.RouteBuilder;
-import org.apache.camel.k.RoutesLoader;
-import org.apache.camel.k.Source;
-import org.apache.commons.lang3.StringUtils;
-
-public class JavaClassRoutesLoader implements RoutesLoader {
-@Override
-public List getSupportedLanguages() {
-return Collections.singletonList("class");
-}
-
-@Override
-public RouteBuilder load(CamelContext camelContext, Source source) throws
Exception {
-String name = source.getName();
-name = StringUtils.removeEnd(name, ".class");
-
-Class type = Class.forName(name);
-
-if (!RouteBuilder.class.isAssignableFrom(type)) {
-throw new IllegalStateException("The class provided is not a
org.apache.camel.builder.RouteBuilder");
-}
-
-return (RouteBuilder)type.newInstance();
-}
-}
diff --git
a/camel-k-loader-java/src/main/resources/META-INF/services/org/apache/camel/k/loader/class
b/camel-k-loader-java/src/main/resources/META-INF/services/org/apache/camel/k/loader/class
deleted file mode 100644
index ca7a231..000
---
a/camel-k-loader-java/src/main/resources/META-INF/services/org/apache/camel/k/loader/class
+++ /dev/null
@@ -1,18 +0,0 @@
-#
-# Licensed to the Apache Software Foundation (ASF) under one or more
-# contributor license agreements. See the NOTICE file distributed with
-# this work for additional information regarding copyright ownership.
-# The ASF licenses this file to You under the Apache License, Version 2.0
-# (the "License"); you may not use this file except in compliance with
-# the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-class=org.apache.camel.k.loader.java.JavaClassRoutesLoader
\ No newline at end of file
diff --git
a/camel-k-loader-java/src/test/java/org/apache/camel/k/loader/java/MyRoutes.java
b/camel-k-loader-java/src/test/java/org/apache/camel/k/loader/java/MyRoutes.java
deleted file mode 100644
index 8b2f4e9..000
---
a/camel-k-loader-java/src/test/java/org/apache/camel/k/loader/java/MyRoutes.java
+++ /dev/null
@@ -1,27 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional
[GitHub] [camel-quarkus] davsclaus merged pull request #395: Cleanup Netty extension
davsclaus merged pull request #395: Cleanup Netty extension URL: https://github.com/apache/camel-quarkus/pull/395 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[camel-quarkus] branch master updated: Cleanup Netty extension (#395)
This is an automated email from the ASF dual-hosted git repository.
davsclaus pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel-quarkus.git
The following commit(s) were added to refs/heads/master by this push:
new cbbd832 Cleanup Netty extension (#395)
cbbd832 is described below
commit cbbd832b00ae878b0b9dc1223cf20e30a1ca6de9
Author: Luca Burgazzoli
AuthorDate: Tue Nov 12 05:47:59 2019 +0100
Cleanup Netty extension (#395)
* chore: fix usage of deprecated
io.quarkus.deployment.builditem.substrate.ReflectiveClassBuildItem
* netty: review and cleanup the list of classes registered for reflection
---
.../camel/quarkus/component/netty/deployment/NettyProcessor.java | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git
a/extensions/netty/deployment/src/main/java/org/apache/camel/quarkus/component/netty/deployment/NettyProcessor.java
b/extensions/netty/deployment/src/main/java/org/apache/camel/quarkus/component/netty/deployment/NettyProcessor.java
index fa4d950..f78a028 100644
---
a/extensions/netty/deployment/src/main/java/org/apache/camel/quarkus/component/netty/deployment/NettyProcessor.java
+++
b/extensions/netty/deployment/src/main/java/org/apache/camel/quarkus/component/netty/deployment/NettyProcessor.java
@@ -22,13 +22,10 @@ import java.util.List;
import io.quarkus.deployment.annotations.BuildProducer;
import io.quarkus.deployment.annotations.BuildStep;
import io.quarkus.deployment.builditem.FeatureBuildItem;
-import io.quarkus.deployment.builditem.substrate.ReflectiveClassBuildItem;
-
+import io.quarkus.deployment.builditem.nativeimage.ReflectiveClassBuildItem;
import org.apache.camel.component.netty.NettyConfiguration;
import org.apache.camel.component.netty.NettyEndpoint;
import org.apache.camel.component.netty.NettyServerBootstrapConfiguration;
-import org.apache.camel.spi.UriParam;
-import org.apache.camel.spi.UriParams;
class NettyProcessor {
@@ -37,9 +34,7 @@ class NettyProcessor {
private static final List> NETTY_REFLECTIVE_CLASSES =
Arrays.asList(
NettyConfiguration.class,
NettyServerBootstrapConfiguration.class,
-NettyEndpoint.class,
-UriParam.class,
-UriParams.class);
+NettyEndpoint.class);
@BuildStep
FeatureBuildItem feature() {
[camel-quarkus] branch master updated: Fix license headers (#394)
This is an automated email from the ASF dual-hosted git repository. davsclaus pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/camel-quarkus.git The following commit(s) were added to refs/heads/master by this push: new 9303490 Fix license headers (#394) 9303490 is described below commit 9303490d7de6bebcf48c2167108b1ee4e4c9e46c Author: Peter Palaga AuthorDate: Tue Nov 12 05:47:27 2019 +0100 Fix license headers (#394) * Add missing license header configuration * Add missing licenseheaders * Let the CI check the licenses --- .github/workflows/pr-build-java-11.yml | 17 .github/workflows/pr-validate.yml | 19 - Jenkinsfile| 27 -- Jenkinsfile.quarkus| 27 -- docs/antora.yml| 17 docs/site.yml | 17 .../org/acme/observability/ObservabilityIT.java| 16 +++ .../org/acme/observability/ObservabilityTest.java | 16 +++ .../main/resources/META-INF/resources/fruits.html | 32 -- .../main/resources/META-INF/resources/legumes.html | 32 -- .../src/main/java/org/acme/timer/package-info.java | 12 .../src/main/java/org/acme/timer/TimerRoute.java | 8 +++--- .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 extensions/fhir/deployment/pom.xml | 18 extensions/fhir/pom.xml| 18 extensions/fhir/runtime/pom.xml| 18 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 extensions/mail/deployment/pom.xml | 18 extensions/mail/pom.xml| 18 extensions/mail/runtime/pom.xml| 18 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 .../main/resources/META-INF/quarkus-extension.yaml | 17 integration-tests/core-main/deployment/pom.xml | 18 integration-tests/core-main/pom.xml| 4 +++
