[jira] [Commented] (CASSANDRA-3248) CommitLog writer should call fdatasync instead of fsync
[
https://issues.apache.org/jira/browse/CASSANDRA-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114495#comment-13114495
]
Peter Schuller commented on CASSANDRA-3248:
---
@zhu Your initial benchmark in the bug submission, on what file system was that?
I'm guessing a journaled file system that only journals meta data. I was going
to suggest that I'd expect both the meta data and the slight bit of data append
to end up in the journal so that the difference should be negligible, but then
realized this won't be the case for metadata-only journaling.
I agree about the documentation phrasing w.r.t. subsequent retrieval, but also
agree that it's dangerous to therefor assume it's safe in practice.
Maybe a configuration option defaulting to false, allowing people who really
know that it's safe on their systems and are affected by it to turn it on?
Given that it only affects a flag passed to force(), the maintenance overhead
should be very small.
CommitLog writer should call fdatasync instead of fsync
---
Key: CASSANDRA-3248
URL: https://issues.apache.org/jira/browse/CASSANDRA-3248
Project: Cassandra
Issue Type: Improvement
Components: Core
Affects Versions: 0.6.13, 0.7.9, 0.8.6, 1.0.0, 1.1
Environment: Linux
Reporter: Zhu Han
Original Estimate: 48h
Remaining Estimate: 48h
CommitLogSegment uses SequentialWriter to flush the buffered data to log
device. It depends on FileDescriptor#sync() which invokes fsync() as it force
the file attributes to disk.
However, at least on Linux, fdatasync() is good enough for commit log flush:
bq. fdatasync() is similar to fsync(), but does not flush modified metadata
unless that metadata is needed in order to allow a subsequent data retrieval
to be correctly handled. For example, changes to st_atime or st_mtime
(respectively, time of last access and time of last modification; see
stat(2)) do not require flushing because they are not necessary for a
subsequent data read to be handled correctly. On the other hand, a change to
the file size (st_size, as made by say ftruncate(2)), would require a
metadata flush.
File size is synced to disk by fdatasync() either. Although the commit log
recovery logic sorts the commit log segements on their modify timestamp, it
can be removed safely, IMHO.
I checked the native code of JRE 6. On Linux and Solaris,
FileChannel#force(false) invokes fdatasync(). On windows, the false flag does
not have any impact.
On my log device (commodity SATA HDD, write cache disabled), there is large
performance gap between fsync() and fdatasync():
{quote}
$sysbench --test=fileio --num-threads=1 --file-num=1 --file-total-size=10G
--file-fsync-all=on --file-fsync-mode={color:red}fdatasync{color}
--file-test-mode=seqwr --max-time=600 --file-block-size=2K --max-requests=0
run
{color:blue}54.90{color} Requests/sec executed
per-request statistics:
min: 8.29ms
avg: 18.18ms
max:108.36ms
approx. 95 percentile: 25.02ms
$ sysbench --test=fileio --num-threads=1 --file-num=1 --file-total-size=10G
--file-fsync-all=on --file-fsync-mode={color:red}fsync{color}
--file-test-mode=seqwr --max-time=600 --file-block-size=2K --max-requests=0
run
{color:blue}28.08{color} Requests/sec executed
per-request statistics:
min: 33.28ms
avg: 35.61ms
max:911.87ms
approx. 95 percentile: 41.69ms
{quote}
I do think this is a very critical performance improvement.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3248) CommitLog writer should call fdatasync instead of fsync
[
https://issues.apache.org/jira/browse/CASSANDRA-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114514#comment-13114514
]
Zhu Han commented on CASSANDRA-3248:
From xfs code, fsync() and fdatasync() should not have any difference for
append-only write. The meta data(inode) is journaled anyway, if the size of
file is extended because of append write.
I have no idea why there is difference in the real world. I will post the
question to file system mail list.
CommitLog writer should call fdatasync instead of fsync
---
Key: CASSANDRA-3248
URL: https://issues.apache.org/jira/browse/CASSANDRA-3248
Project: Cassandra
Issue Type: Improvement
Components: Core
Affects Versions: 0.6.13, 0.7.9, 0.8.6, 1.0.0, 1.1
Environment: Linux
Reporter: Zhu Han
Original Estimate: 48h
Remaining Estimate: 48h
CommitLogSegment uses SequentialWriter to flush the buffered data to log
device. It depends on FileDescriptor#sync() which invokes fsync() as it force
the file attributes to disk.
However, at least on Linux, fdatasync() is good enough for commit log flush:
bq. fdatasync() is similar to fsync(), but does not flush modified metadata
unless that metadata is needed in order to allow a subsequent data retrieval
to be correctly handled. For example, changes to st_atime or st_mtime
(respectively, time of last access and time of last modification; see
stat(2)) do not require flushing because they are not necessary for a
subsequent data read to be handled correctly. On the other hand, a change to
the file size (st_size, as made by say ftruncate(2)), would require a
metadata flush.
File size is synced to disk by fdatasync() either. Although the commit log
recovery logic sorts the commit log segements on their modify timestamp, it
can be removed safely, IMHO.
I checked the native code of JRE 6. On Linux and Solaris,
FileChannel#force(false) invokes fdatasync(). On windows, the false flag does
not have any impact.
On my log device (commodity SATA HDD, write cache disabled), there is large
performance gap between fsync() and fdatasync():
{quote}
$sysbench --test=fileio --num-threads=1 --file-num=1 --file-total-size=10G
--file-fsync-all=on --file-fsync-mode={color:red}fdatasync{color}
--file-test-mode=seqwr --max-time=600 --file-block-size=2K --max-requests=0
run
{color:blue}54.90{color} Requests/sec executed
per-request statistics:
min: 8.29ms
avg: 18.18ms
max:108.36ms
approx. 95 percentile: 25.02ms
$ sysbench --test=fileio --num-threads=1 --file-num=1 --file-total-size=10G
--file-fsync-all=on --file-fsync-mode={color:red}fsync{color}
--file-test-mode=seqwr --max-time=600 --file-block-size=2K --max-requests=0
run
{color:blue}28.08{color} Requests/sec executed
per-request statistics:
min: 33.28ms
avg: 35.61ms
max:911.87ms
approx. 95 percentile: 41.69ms
{quote}
I do think this is a very critical performance improvement.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (CASSANDRA-3150) ColumnFormatRecordReader loops forever (StorageService.getSplits(..) out of whack)
[
https://issues.apache.org/jira/browse/CASSANDRA-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114220#comment-13114220
]
Mck SembWever edited comment on CASSANDRA-3150 at 9/26/11 8:29 AM:
---
{{fullscan-example1.log}} is debug from a full scan job. It scans data over a
full year (and since the cluster's ring range only holds 3 months of data such
a job guarantees a full scan).
In the debug you see the splits.
{{`nodetool ring`}} gives
{noformat}Address DC RackStatus State Load
OwnsToken
Token(bytes[5554])
152.90.241.22 DC1 RAC1Up Normal 16.65 GB33.33%
Token(bytes[00])
152.90.241.23 DC2 RAC1Up Normal 63.22 GB33.33%
Token(bytes[2aaa])
152.90.241.24 DC1 RAC1Up Normal 72.4 KB 33.33%
Token(bytes[5554])
{noformat}
The problematic split ends up being
{noformat}ColumnFamilySplit{startToken='0528cbe0b2b5ff6b816c68b59973bcbc',
endToken='2aaa',
dataNodes=[cassandra02.finn.no]}{noformat} This is the split that's receiving
new data (5-10k rows/second). This new data is being written directly using
{{StorageProxy.mutate(..)}} with code somewhat similar to the second example in
[wiki: ScribeToCassandra|http://wiki.apache.org/cassandra/ScribeToCassandra].
This cluster has {{binary_memtable_throughput_in_mb: 1024}} and {{Xmx8g}}.
There are 3 nodes in the cluster each 48g ram and 24cpus.
was (Author: michaelsembwever):
{{fullscan-example1.log}} is debug from a full scan job. It scans data
over a full year (and since the cluster's ring range only holds 3 months of
data such a job guarantees a full scan).
In the debug you see the splits.
{{`nodetool ring`}} gives
{noformat}Address DC RackStatus State Load
OwnsToken
Token(bytes[5554])
152.90.241.22 DC1 RAC1Up Normal 16.65 GB33.33%
Token(bytes[00])
152.90.241.23 DC2 RAC1Up Normal 63.22 GB33.33%
Token(bytes[2aaa])
152.90.241.24 DC1 RAC1Up Normal 72.4 KB 33.33%
Token(bytes[5554])
{noformat}
The problematic split ends up being
{noformat}ColumnFamilySplit{startToken='0528cbe0b2b5ff6b816c68b59973bcbc',
endToken='2aaa',
dataNodes=[cassandra02.finn.no]}{noformat} This is the split that's receiving
new data (5-10k rows/second). This new data is being written directly using
{{StorageProxy.mutate(..)}} with code somewhat similar to the second example in
[wiki: ScribeToCassandra|http://wiki.apache.org/cassandra/ScribeToCassandra].
ColumnFormatRecordReader loops forever (StorageService.getSplits(..) out of
whack)
--
Key: CASSANDRA-3150
URL: https://issues.apache.org/jira/browse/CASSANDRA-3150
Project: Cassandra
Issue Type: Bug
Components: Hadoop
Affects Versions: 0.8.4, 0.8.5
Reporter: Mck SembWever
Assignee: Mck SembWever
Priority: Critical
Fix For: 0.8.6
Attachments: CASSANDRA-3150.patch, Screenshot-Counters for
task_201109212019_1060_m_29 - Mozilla Firefox.png, Screenshot-Hadoop map
task list for job_201109212019_1060 on cassandra01 - Mozilla Firefox.png,
attempt_201109071357_0044_m_003040_0.grep-get_range_slices.log,
fullscan-example1.log
From http://thread.gmane.org/gmane.comp.db.cassandra.user/20039
{quote}
bq. Cassandra-0.8.4 w/ ByteOrderedPartitioner
bq. CFIF's inputSplitSize=196608
bq. 3 map tasks (from 4013) is still running after read 25 million rows.
bq. Can this be a bug in StorageService.getSplits(..) ?
getSplits looks pretty foolproof to me but I guess we'd need to add
more debug logging to rule out a bug there for sure.
I guess the main alternative would be a bug in the recordreader paging.
{quote}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
svn commit: r1175725 - in /cassandra/branches/cassandra-1.0.0: CHANGES.txt src/java/org/apache/cassandra/db/commitlog/CommitLog.java
Author: slebresne
Date: Mon Sep 26 09:03:19 2011
New Revision: 1175725
URL: http://svn.apache.org/viewvc?rev=1175725view=rev
Log:
Fix deadlock in commit log during flush
patch by jbellis; reviewed by slebresne for CASSANDRA-3253
Modified:
cassandra/branches/cassandra-1.0.0/CHANGES.txt
cassandra/branches/cassandra-1.0.0/src/java/org/apache/cassandra/db/commitlog/CommitLog.java
Modified: cassandra/branches/cassandra-1.0.0/CHANGES.txt
URL:
http://svn.apache.org/viewvc/cassandra/branches/cassandra-1.0.0/CHANGES.txt?rev=1175725r1=1175724r2=1175725view=diff
==
--- cassandra/branches/cassandra-1.0.0/CHANGES.txt (original)
+++ cassandra/branches/cassandra-1.0.0/CHANGES.txt Mon Sep 26 09:03:19 2011
@@ -18,6 +18,7 @@
* Don't allow any cache loading exceptions to halt startup (CASSANDRA-3218)
* Fix sstableloader --ignores option (CASSANDRA-3247)
* File descriptor limit increased in packaging (CASSANDRA-3206)
+ * Fix deadlock in commit log during flush (CASSANDRA-3253)
1.0.0-beta1
Modified:
cassandra/branches/cassandra-1.0.0/src/java/org/apache/cassandra/db/commitlog/CommitLog.java
URL:
http://svn.apache.org/viewvc/cassandra/branches/cassandra-1.0.0/src/java/org/apache/cassandra/db/commitlog/CommitLog.java?rev=1175725r1=1175724r2=1175725view=diff
==
---
cassandra/branches/cassandra-1.0.0/src/java/org/apache/cassandra/db/commitlog/CommitLog.java
(original)
+++
cassandra/branches/cassandra-1.0.0/src/java/org/apache/cassandra/db/commitlog/CommitLog.java
Mon Sep 26 09:03:19 2011
@@ -43,6 +43,7 @@ import org.apache.cassandra.concurrent.S
import org.apache.cassandra.config.Config;
import org.apache.cassandra.config.DatabaseDescriptor;
import org.apache.cassandra.io.util.FastByteArrayInputStream;
+import org.apache.cassandra.service.StorageService;
import org.apache.cassandra.utils.ByteBufferUtil;
import org.apache.cassandra.utils.FBUtilities;
import org.apache.cassandra.utils.WrappedRunnable;
@@ -570,7 +571,18 @@ public class CommitLog implements Commit
for (Integer dirtyCFId : oldestSegment.cfLastWrite.keySet())
{
String keypace = Schema.instance.getCF(dirtyCFId).left;
-
Table.open(keypace).getColumnFamilyStore(dirtyCFId).forceFlush();
+final ColumnFamilyStore cfs =
Table.open(keypace).getColumnFamilyStore(dirtyCFId);
+// flush shouldn't run on the commitlog executor, since it
acquires Table.switchLock,
+// which may already be held by a thread waiting for the CL
executor (via getContext),
+// causing deadlock
+Runnable runnable = new Runnable()
+{
+public void run()
+{
+cfs.forceFlush();
+}
+};
+StorageService.optionalTasks.execute(runnable);
}
}
}
svn commit: r1175727 - in /cassandra/branches/cassandra-1.0: ./ contrib/ interface/thrift/gen-java/org/apache/cassandra/thrift/ src/java/org/apache/cassandra/db/commitlog/
Author: slebresne Date: Mon Sep 26 09:04:37 2011 New Revision: 1175727 URL: http://svn.apache.org/viewvc?rev=1175727view=rev Log: merge from 1.0.0 Modified: cassandra/branches/cassandra-1.0/ (props changed) cassandra/branches/cassandra-1.0/CHANGES.txt cassandra/branches/cassandra-1.0/contrib/ (props changed) cassandra/branches/cassandra-1.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java (props changed) cassandra/branches/cassandra-1.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Column.java (props changed) cassandra/branches/cassandra-1.0/interface/thrift/gen-java/org/apache/cassandra/thrift/InvalidRequestException.java (props changed) cassandra/branches/cassandra-1.0/interface/thrift/gen-java/org/apache/cassandra/thrift/NotFoundException.java (props changed) cassandra/branches/cassandra-1.0/interface/thrift/gen-java/org/apache/cassandra/thrift/SuperColumn.java (props changed) cassandra/branches/cassandra-1.0/src/java/org/apache/cassandra/db/commitlog/CommitLog.java Propchange: cassandra/branches/cassandra-1.0/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Mon Sep 26 09:04:37 2011 @@ -5,7 +5,7 @@ /cassandra/branches/cassandra-0.8.0:1125021-1130369 /cassandra/branches/cassandra-0.8.1:1101014-1125018 /cassandra/branches/cassandra-1.0:1167106,1167185 -/cassandra/branches/cassandra-1.0.0:1167104-1174472,1174704 +/cassandra/branches/cassandra-1.0.0:1167104-1174472,1174704,1175725 /cassandra/tags/cassandra-0.7.0-rc3:1051699-1053689 /cassandra/tags/cassandra-0.8.0-rc1:1102511-1125020 /cassandra/trunk:1167085-1167102,1169870 Modified: cassandra/branches/cassandra-1.0/CHANGES.txt URL: http://svn.apache.org/viewvc/cassandra/branches/cassandra-1.0/CHANGES.txt?rev=1175727r1=1175726r2=1175727view=diff == --- cassandra/branches/cassandra-1.0/CHANGES.txt (original) +++ cassandra/branches/cassandra-1.0/CHANGES.txt Mon Sep 26 09:04:37 2011 @@ -21,6 +21,7 @@ * Allow using quotes in USE keyspace; CLI command (CASSANDRA-3208) * Don't allow any cache loading exceptions to halt startup (CASSANDRA-3218) * Fix sstableloader --ignores option (CASSANDRA-3247) + * Fix deadlock in commit log during flush (CASSANDRA-3253) 1.0.0-beta1 Propchange: cassandra/branches/cassandra-1.0/contrib/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Mon Sep 26 09:04:37 2011 @@ -5,7 +5,7 @@ /cassandra/branches/cassandra-0.8.0/contrib:1125021-1130369 /cassandra/branches/cassandra-0.8.1/contrib:1101014-1125018 /cassandra/branches/cassandra-1.0/contrib:1167106,1167185 -/cassandra/branches/cassandra-1.0.0/contrib:1167104-1174472,1174704 +/cassandra/branches/cassandra-1.0.0/contrib:1167104-1174472,1174704,1175725 /cassandra/tags/cassandra-0.7.0-rc3/contrib:1051699-1053689 /cassandra/tags/cassandra-0.8.0-rc1/contrib:1102511-1125020 /cassandra/trunk/contrib:1167085-1167102,1169870 Propchange: cassandra/branches/cassandra-1.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java -- --- svn:mergeinfo (original) +++ svn:mergeinfo Mon Sep 26 09:04:37 2011 @@ -5,7 +5,7 @@ /cassandra/branches/cassandra-0.8.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1125021-1130369 /cassandra/branches/cassandra-0.8.1/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1101014-1125018 /cassandra/branches/cassandra-1.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1167106,1167185 -/cassandra/branches/cassandra-1.0.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1167104-1174472,1174704 +/cassandra/branches/cassandra-1.0.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1167104-1174472,1174704,1175725 /cassandra/tags/cassandra-0.7.0-rc3/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1051699-1053689 /cassandra/tags/cassandra-0.8.0-rc1/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1102511-1125020 /cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1167085-1167102,1169870 Propchange: cassandra/branches/cassandra-1.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Column.java -- --- svn:mergeinfo (original) +++ svn:mergeinfo Mon Sep 26 09:04:37 2011 @@ -5,7 +5,7 @@ /cassandra/branches/cassandra-0.8.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Column.java:1125021-1130369 /cassandra/branches/cassandra-0.8.1/interface/thrift/gen-java/org/apache/cassandra/thrift/Column.java:1101014-1125018
svn commit: r1175729 - in /cassandra/trunk: ./ contrib/ interface/thrift/gen-java/org/apache/cassandra/thrift/ src/java/org/apache/cassandra/db/commitlog/
Author: slebresne Date: Mon Sep 26 09:07:03 2011 New Revision: 1175729 URL: http://svn.apache.org/viewvc?rev=1175729view=rev Log: merge from 1.0 Modified: cassandra/trunk/ (props changed) cassandra/trunk/CHANGES.txt cassandra/trunk/contrib/ (props changed) cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java (props changed) cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/Column.java (props changed) cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/InvalidRequestException.java (props changed) cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/NotFoundException.java (props changed) cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/SuperColumn.java (props changed) cassandra/trunk/src/java/org/apache/cassandra/db/commitlog/CommitLog.java Propchange: cassandra/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Mon Sep 26 09:07:03 2011 @@ -4,8 +4,8 @@ /cassandra/branches/cassandra-0.8:1090934-1125013,1125019-1174469,1174701 /cassandra/branches/cassandra-0.8.0:1125021-1130369 /cassandra/branches/cassandra-0.8.1:1101014-1125018 -/cassandra/branches/cassandra-1.0:1167085-1174478,1174706 -/cassandra/branches/cassandra-1.0.0:1167104-1167229,1167232-1174472,1174704 +/cassandra/branches/cassandra-1.0:1167085-1174478,1174706,1175727 +/cassandra/branches/cassandra-1.0.0:1167104-1167229,1167232-1174472,1174704,1175725 /cassandra/tags/cassandra-0.7.0-rc3:1051699-1053689 /cassandra/tags/cassandra-0.8.0-rc1:1102511-1125020 /incubator/cassandra/branches/cassandra-0.3:774578-796573 Modified: cassandra/trunk/CHANGES.txt URL: http://svn.apache.org/viewvc/cassandra/trunk/CHANGES.txt?rev=1175729r1=1175728r2=1175729view=diff == --- cassandra/trunk/CHANGES.txt (original) +++ cassandra/trunk/CHANGES.txt Mon Sep 26 09:07:03 2011 @@ -21,6 +21,7 @@ * Allow using quotes in USE keyspace; CLI command (CASSANDRA-3208) * Don't allow any cache loading exceptions to halt startup (CASSANDRA-3218) * Fix sstableloader --ignores option (CASSANDRA-3247) + * Fix deadlock in commit log during flush (CASSANDRA-3253) 1.0.0-beta1 Propchange: cassandra/trunk/contrib/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Mon Sep 26 09:07:03 2011 @@ -4,8 +4,8 @@ /cassandra/branches/cassandra-0.8/contrib:1090934-1125013,1125019-1174469,1174701 /cassandra/branches/cassandra-0.8.0/contrib:1125021-1130369 /cassandra/branches/cassandra-0.8.1/contrib:1101014-1125018 -/cassandra/branches/cassandra-1.0/contrib:1167085-1174478,1174706 -/cassandra/branches/cassandra-1.0.0/contrib:1167104-1167229,1167232-1174472,1174704 +/cassandra/branches/cassandra-1.0/contrib:1167085-1174478,1174706,1175727 +/cassandra/branches/cassandra-1.0.0/contrib:1167104-1167229,1167232-1174472,1174704,1175725 /cassandra/tags/cassandra-0.7.0-rc3/contrib:1051699-1053689 /cassandra/tags/cassandra-0.8.0-rc1/contrib:1102511-1125020 /incubator/cassandra/branches/cassandra-0.3/contrib:774578-796573 Propchange: cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java -- --- svn:mergeinfo (original) +++ svn:mergeinfo Mon Sep 26 09:07:03 2011 @@ -4,8 +4,8 @@ /cassandra/branches/cassandra-0.8/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1090934-1125013,1125019-1174469,1174701 /cassandra/branches/cassandra-0.8.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1125021-1130369 /cassandra/branches/cassandra-0.8.1/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1101014-1125018 -/cassandra/branches/cassandra-1.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1167085-1174478,1174706 -/cassandra/branches/cassandra-1.0.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1167104-1167229,1167232-1174472,1174704 +/cassandra/branches/cassandra-1.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1167085-1174478,1174706,1175727 +/cassandra/branches/cassandra-1.0.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1167104-1167229,1167232-1174472,1174704,1175725 /cassandra/tags/cassandra-0.7.0-rc3/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1051699-1053689 /cassandra/tags/cassandra-0.8.0-rc1/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1102511-1125020 /incubator/cassandra/branches/cassandra-0.3/interface/gen-java/org/apache/cassandra/service/Cassandra.java:774578-796573 Propchange: cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/Column.java
svn commit: r1175770 - in /cassandra/branches/cassandra-1.0.0: build.xml debian/changelog
Author: slebresne
Date: Mon Sep 26 10:11:43 2011
New Revision: 1175770
URL: http://svn.apache.org/viewvc?rev=1175770view=rev
Log:
update version for rc1
Modified:
cassandra/branches/cassandra-1.0.0/build.xml
cassandra/branches/cassandra-1.0.0/debian/changelog
Modified: cassandra/branches/cassandra-1.0.0/build.xml
URL:
http://svn.apache.org/viewvc/cassandra/branches/cassandra-1.0.0/build.xml?rev=1175770r1=1175769r2=1175770view=diff
==
--- cassandra/branches/cassandra-1.0.0/build.xml (original)
+++ cassandra/branches/cassandra-1.0.0/build.xml Mon Sep 26 10:11:43 2011
@@ -25,7 +25,7 @@
property name=debuglevel value=source,lines,vars/
!-- default version and SCM information (we need the default SCM info as
people may checkout with git-svn) --
-property name=base.version value=1.0.0-beta1/
+property name=base.version value=1.0.0-rc1/
property name=scm.default.path
value=cassandra/branches/cassandra-1.0.0/
property name=scm.default.connection
value=scm:svn:http://svn.apache.org/repos/asf/${scm.default.path}/
property name=scm.default.developerConnection
value=scm:svn:https://svn.apache.org/repos/asf/${scm.default.path}/
Modified: cassandra/branches/cassandra-1.0.0/debian/changelog
URL:
http://svn.apache.org/viewvc/cassandra/branches/cassandra-1.0.0/debian/changelog?rev=1175770r1=1175769r2=1175770view=diff
==
--- cassandra/branches/cassandra-1.0.0/debian/changelog (original)
+++ cassandra/branches/cassandra-1.0.0/debian/changelog Mon Sep 26 10:11:43 2011
@@ -1,3 +1,9 @@
+cassandra (1.0.0~rc1) unstable; urgency=low
+
+ * New release candidate
+
+ -- Sylvain Lebresne slebre...@apache.org Mon, 26 Sep 2011 12:10:32 +0200
+
cassandra (1.0.0~beta1) unstable; urgency=low
* New beta release
svn commit: r1175771 - /cassandra/branches/cassandra-1.0.0/src/java/org/apache/cassandra/utils/IMergeIterator.java
Author: slebresne
Date: Mon Sep 26 10:13:55 2011
New Revision: 1175771
URL: http://svn.apache.org/viewvc?rev=1175771view=rev
Log:
Add missing licence header
Modified:
cassandra/branches/cassandra-1.0.0/src/java/org/apache/cassandra/utils/IMergeIterator.java
Modified:
cassandra/branches/cassandra-1.0.0/src/java/org/apache/cassandra/utils/IMergeIterator.java
URL:
http://svn.apache.org/viewvc/cassandra/branches/cassandra-1.0.0/src/java/org/apache/cassandra/utils/IMergeIterator.java?rev=1175771r1=1175770r2=1175771view=diff
==
---
cassandra/branches/cassandra-1.0.0/src/java/org/apache/cassandra/utils/IMergeIterator.java
(original)
+++
cassandra/branches/cassandra-1.0.0/src/java/org/apache/cassandra/utils/IMergeIterator.java
Mon Sep 26 10:13:55 2011
@@ -1,4 +1,25 @@
package org.apache.cassandra.utils;
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+ */
+
public interface IMergeIteratorIn, Out extends CloseableIteratorOut
{
svn commit: r1175772 - in /cassandra/branches/cassandra-1.0: ./ contrib/ debian/ interface/thrift/gen-java/org/apache/cassandra/thrift/ src/java/org/apache/cassandra/utils/
Author: slebresne
Date: Mon Sep 26 10:15:39 2011
New Revision: 1175772
URL: http://svn.apache.org/viewvc?rev=1175772view=rev
Log:
merge from 1.0.0
Modified:
cassandra/branches/cassandra-1.0/ (props changed)
cassandra/branches/cassandra-1.0/build.xml
cassandra/branches/cassandra-1.0/contrib/ (props changed)
cassandra/branches/cassandra-1.0/debian/changelog
cassandra/branches/cassandra-1.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java
(props changed)
cassandra/branches/cassandra-1.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Column.java
(props changed)
cassandra/branches/cassandra-1.0/interface/thrift/gen-java/org/apache/cassandra/thrift/InvalidRequestException.java
(props changed)
cassandra/branches/cassandra-1.0/interface/thrift/gen-java/org/apache/cassandra/thrift/NotFoundException.java
(props changed)
cassandra/branches/cassandra-1.0/interface/thrift/gen-java/org/apache/cassandra/thrift/SuperColumn.java
(props changed)
cassandra/branches/cassandra-1.0/src/java/org/apache/cassandra/utils/IMergeIterator.java
Propchange: cassandra/branches/cassandra-1.0/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Sep 26 10:15:39 2011
@@ -5,7 +5,7 @@
/cassandra/branches/cassandra-0.8.0:1125021-1130369
/cassandra/branches/cassandra-0.8.1:1101014-1125018
/cassandra/branches/cassandra-1.0:1167106,1167185
-/cassandra/branches/cassandra-1.0.0:1167104-1174472,1174704,1175725
+/cassandra/branches/cassandra-1.0.0:1167104-1174472,1174704,1175725,1175770-1175771
/cassandra/tags/cassandra-0.7.0-rc3:1051699-1053689
/cassandra/tags/cassandra-0.8.0-rc1:1102511-1125020
/cassandra/trunk:1167085-1167102,1169870
Modified: cassandra/branches/cassandra-1.0/build.xml
URL:
http://svn.apache.org/viewvc/cassandra/branches/cassandra-1.0/build.xml?rev=1175772r1=1175771r2=1175772view=diff
==
--- cassandra/branches/cassandra-1.0/build.xml (original)
+++ cassandra/branches/cassandra-1.0/build.xml Mon Sep 26 10:15:39 2011
@@ -25,7 +25,7 @@
property name=debuglevel value=source,lines,vars/
!-- default version and SCM information (we need the default SCM info as
people may checkout with git-svn) --
-property name=base.version value=1.0.0-beta1/
+property name=base.version value=1.0.0-rc1/
property name=scm.default.path
value=cassandra/branches/cassandra-1.0.0/
property name=scm.default.connection
value=scm:svn:http://svn.apache.org/repos/asf/${scm.default.path}/
property name=scm.default.developerConnection
value=scm:svn:https://svn.apache.org/repos/asf/${scm.default.path}/
Propchange: cassandra/branches/cassandra-1.0/contrib/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Sep 26 10:15:39 2011
@@ -5,7 +5,7 @@
/cassandra/branches/cassandra-0.8.0/contrib:1125021-1130369
/cassandra/branches/cassandra-0.8.1/contrib:1101014-1125018
/cassandra/branches/cassandra-1.0/contrib:1167106,1167185
-/cassandra/branches/cassandra-1.0.0/contrib:1167104-1174472,1174704,1175725
+/cassandra/branches/cassandra-1.0.0/contrib:1167104-1174472,1174704,1175725,1175770-1175771
/cassandra/tags/cassandra-0.7.0-rc3/contrib:1051699-1053689
/cassandra/tags/cassandra-0.8.0-rc1/contrib:1102511-1125020
/cassandra/trunk/contrib:1167085-1167102,1169870
Modified: cassandra/branches/cassandra-1.0/debian/changelog
URL:
http://svn.apache.org/viewvc/cassandra/branches/cassandra-1.0/debian/changelog?rev=1175772r1=1175771r2=1175772view=diff
==
--- cassandra/branches/cassandra-1.0/debian/changelog (original)
+++ cassandra/branches/cassandra-1.0/debian/changelog Mon Sep 26 10:15:39 2011
@@ -1,3 +1,9 @@
+cassandra (1.0.0~rc1) unstable; urgency=low
+
+ * New release candidate
+
+ -- Sylvain Lebresne slebre...@apache.org Mon, 26 Sep 2011 12:10:32 +0200
+
cassandra (1.0.0~beta1) unstable; urgency=low
* New beta release
Propchange:
cassandra/branches/cassandra-1.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Sep 26 10:15:39 2011
@@ -5,7 +5,7 @@
/cassandra/branches/cassandra-0.8.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1125021-1130369
/cassandra/branches/cassandra-0.8.1/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1101014-1125018
/cassandra/branches/cassandra-1.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1167106,1167185
-/cassandra/branches/cassandra-1.0.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1167104-1174472,1174704,1175725
svn commit: r1175773 - in /cassandra/trunk: ./ contrib/ debian/ interface/thrift/gen-java/org/apache/cassandra/thrift/ src/java/org/apache/cassandra/utils/
Author: slebresne
Date: Mon Sep 26 10:16:59 2011
New Revision: 1175773
URL: http://svn.apache.org/viewvc?rev=1175773view=rev
Log:
merge from 1.0
Modified:
cassandra/trunk/ (props changed)
cassandra/trunk/build.xml
cassandra/trunk/contrib/ (props changed)
cassandra/trunk/debian/changelog
cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java
(props changed)
cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/Column.java
(props changed)
cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/InvalidRequestException.java
(props changed)
cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/NotFoundException.java
(props changed)
cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/SuperColumn.java
(props changed)
cassandra/trunk/src/java/org/apache/cassandra/utils/IMergeIterator.java
Propchange: cassandra/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Sep 26 10:16:59 2011
@@ -4,8 +4,8 @@
/cassandra/branches/cassandra-0.8:1090934-1125013,1125019-1174469,1174701
/cassandra/branches/cassandra-0.8.0:1125021-1130369
/cassandra/branches/cassandra-0.8.1:1101014-1125018
-/cassandra/branches/cassandra-1.0:1167085-1174478,1174706,1175727
-/cassandra/branches/cassandra-1.0.0:1167104-1167229,1167232-1174472,1174704,1175725
+/cassandra/branches/cassandra-1.0:1167085-1174478,1174706,1175727,1175772
+/cassandra/branches/cassandra-1.0.0:1167104-1167229,1167232-1174472,1174704,1175725,1175770-1175771
/cassandra/tags/cassandra-0.7.0-rc3:1051699-1053689
/cassandra/tags/cassandra-0.8.0-rc1:1102511-1125020
/incubator/cassandra/branches/cassandra-0.3:774578-796573
Modified: cassandra/trunk/build.xml
URL:
http://svn.apache.org/viewvc/cassandra/trunk/build.xml?rev=1175773r1=1175772r2=1175773view=diff
==
--- cassandra/trunk/build.xml (original)
+++ cassandra/trunk/build.xml Mon Sep 26 10:16:59 2011
@@ -25,7 +25,7 @@
property name=debuglevel value=source,lines,vars/
!-- default version and SCM information (we need the default SCM info as
people may checkout with git-svn) --
-property name=base.version value=1.0.0-beta1/
+property name=base.version value=1.0.0-rc1/
property name=scm.default.path
value=cassandra/branches/cassandra-1.0.0/
property name=scm.default.connection
value=scm:svn:http://svn.apache.org/repos/asf/${scm.default.path}/
property name=scm.default.developerConnection
value=scm:svn:https://svn.apache.org/repos/asf/${scm.default.path}/
Propchange: cassandra/trunk/contrib/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Sep 26 10:16:59 2011
@@ -4,8 +4,8 @@
/cassandra/branches/cassandra-0.8/contrib:1090934-1125013,1125019-1174469,1174701
/cassandra/branches/cassandra-0.8.0/contrib:1125021-1130369
/cassandra/branches/cassandra-0.8.1/contrib:1101014-1125018
-/cassandra/branches/cassandra-1.0/contrib:1167085-1174478,1174706,1175727
-/cassandra/branches/cassandra-1.0.0/contrib:1167104-1167229,1167232-1174472,1174704,1175725
+/cassandra/branches/cassandra-1.0/contrib:1167085-1174478,1174706,1175727,1175772
+/cassandra/branches/cassandra-1.0.0/contrib:1167104-1167229,1167232-1174472,1174704,1175725,1175770-1175771
/cassandra/tags/cassandra-0.7.0-rc3/contrib:1051699-1053689
/cassandra/tags/cassandra-0.8.0-rc1/contrib:1102511-1125020
/incubator/cassandra/branches/cassandra-0.3/contrib:774578-796573
Modified: cassandra/trunk/debian/changelog
URL:
http://svn.apache.org/viewvc/cassandra/trunk/debian/changelog?rev=1175773r1=1175772r2=1175773view=diff
==
--- cassandra/trunk/debian/changelog (original)
+++ cassandra/trunk/debian/changelog Mon Sep 26 10:16:59 2011
@@ -1,3 +1,9 @@
+cassandra (1.0.0~rc1) unstable; urgency=low
+
+ * New release candidate
+
+ -- Sylvain Lebresne slebre...@apache.org Mon, 26 Sep 2011 12:10:32 +0200
+
cassandra (1.0.0~beta1) unstable; urgency=low
* New beta release
Propchange:
cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Sep 26 10:16:59 2011
@@ -4,8 +4,8 @@
/cassandra/branches/cassandra-0.8/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1090934-1125013,1125019-1174469,1174701
/cassandra/branches/cassandra-0.8.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1125021-1130369
/cassandra/branches/cassandra-0.8.1/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1101014-1125018
buildbot failure in ASF Buildbot on cassandra-trunk
The Buildbot has detected a new failure on builder cassandra-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/cassandra-trunk/builds/1688 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: isis_ubuntu Build Reason: scheduler Build Source Stamp: [branch cassandra/trunk] 1175773 Blamelist: slebresne BUILD FAILED: failed compile sincerely, -The Buildbot
[jira] [Updated] (CASSANDRA-3220) add describe_ring to cli
[
https://issues.apache.org/jira/browse/CASSANDRA-3220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylvain Lebresne updated CASSANDRA-3220:
Fix Version/s: (was: 1.0.0)
1.0.1
add describe_ring to cli
Key: CASSANDRA-3220
URL: https://issues.apache.org/jira/browse/CASSANDRA-3220
Project: Cassandra
Issue Type: Improvement
Components: Tools
Reporter: Jackson Chung
Assignee: Jackson Chung
Priority: Minor
Fix For: 1.0.1
Attachments: patch3220.diff
Lately I have found the describe_ring feature was needed to debug/analyze
issue, but the cli does not have this available.
So just in case it is useful, please see the attached patch.
here is the sample output:
{noformat}
[default@unknown] help;
...
...
decrDecrements a counter column.
describe ring Describe the token range information.
describe clusterDescribe the cluster configuration.
...
...
[default@unknown] help describe ring;
describe ring keyspace;
Describes the token range settings for the named keyspace.
Required Parameters:
- keyspace: Name of the keyspace to describe the token range.
Examples:
describe ring keyspace; - Describes the token range settings for the named
keyspace.
[default@unknown] describe ring Keyspace3;
TokenRange:
TokenRange(start_token:9739248273232290250409572410247679660,
end_token:9739248273232290250409572410247679660, endpoints:[192.168.0.125],
rpc_endpoints:[192.168.0.125],
endpoint_details:[EndpointDetails(host:192.168.0.125, port:9160,
datacenter:168)])
[default@unknown] describe ring fooks;
Keyspace with name 'fooks' wasn't found, , please, authorize to one of the
keyspaces first.
[default@unknown] describe ring;
Syntax error at position 13: mismatched input ';' expecting set null
{noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (CASSANDRA-3258) *.bat files fails when CASSANDRA_HOME contains a white space.
*.bat files fails when CASSANDRA_HOME contains a white space. - Key: CASSANDRA-3258 URL: https://issues.apache.org/jira/browse/CASSANDRA-3258 Project: Cassandra Issue Type: Bug Components: Packaging Affects Versions: 0.8.6 Environment: Windows 7 Reporter: Tim Almdal Issues 2952 and 2237 fixed the issue for cassandra.bat. But the following bat files need the same fix: json2sstable.bat nodetool.bat sstable2json.bat sstablekeys.bat -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3258) *.bat files fails when CASSANDRA_HOME contains a white space.
[ https://issues.apache.org/jira/browse/CASSANDRA-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114672#comment-13114672 ] Tim Almdal commented on CASSANDRA-3258: --- This also applies to 1.0.0 *.bat files fails when CASSANDRA_HOME contains a white space. - Key: CASSANDRA-3258 URL: https://issues.apache.org/jira/browse/CASSANDRA-3258 Project: Cassandra Issue Type: Bug Components: Packaging Affects Versions: 0.8.6 Environment: Windows 7 Reporter: Tim Almdal Issues 2952 and 2237 fixed the issue for cassandra.bat. But the following bat files need the same fix: json2sstable.bat nodetool.bat sstable2json.bat sstablekeys.bat -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
svn commit: r1175880 - in /cassandra/branches/cassandra-0.8: CHANGES.txt src/java/org/apache/cassandra/service/AntiEntropyService.java
Author: slebresne
Date: Mon Sep 26 14:18:14 2011
New Revision: 1175880
URL: http://svn.apache.org/viewvc?rev=1175880view=rev
Log:
Log a miningfull warning when a node receive a message for a repair session
that don't exist anymore
patch by slebresne; reviewed by jbellis for CASSANDRA-3256
Modified:
cassandra/branches/cassandra-0.8/CHANGES.txt
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/service/AntiEntropyService.java
Modified: cassandra/branches/cassandra-0.8/CHANGES.txt
URL:
http://svn.apache.org/viewvc/cassandra/branches/cassandra-0.8/CHANGES.txt?rev=1175880r1=1175879r2=1175880view=diff
==
--- cassandra/branches/cassandra-0.8/CHANGES.txt (original)
+++ cassandra/branches/cassandra-0.8/CHANGES.txt Mon Sep 26 14:18:14 2011
@@ -5,6 +5,8 @@
* Don't allow any cache loading exceptions to halt startup (CASSANDRA-3218)
* Fix sstableloader --ignores option (CASSANDRA-3247)
* File descriptor limit increased in packaging (CASSANDRA-3206)
+ * Log a miningfull warning when a node receive a message for a repair session
+ that don't exist anymore (CASSANDRA-3256)
0.8.6
Modified:
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/service/AntiEntropyService.java
URL:
http://svn.apache.org/viewvc/cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/service/AntiEntropyService.java?rev=1175880r1=1175879r2=1175880view=diff
==
---
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/service/AntiEntropyService.java
(original)
+++
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/service/AntiEntropyService.java
Mon Sep 26 14:18:14 2011
@@ -167,7 +167,11 @@ public class AntiEntropyService
private void rendezvous(TreeRequest request, MerkleTree tree)
{
RepairSession session = sessions.get(request.sessionid);
-assert session != null;
+if (session == null)
+{
+logger.warn(Got a merkle tree response for unknown repair session
{}: either this node has been restarted since the session was started, or the
session has been interrupted for an unknown reason. , request.sessionid);
+return;
+}
RepairSession.RepairJob job = session.jobs.peek();
assert job != null : A repair should have at least some jobs
scheduled;
svn commit: r1175882 - in /cassandra/branches/cassandra-1.0.0: ./ contrib/ interface/thrift/gen-java/org/apache/cassandra/thrift/ src/java/org/apache/cassandra/service/
Author: slebresne Date: Mon Sep 26 14:23:29 2011 New Revision: 1175882 URL: http://svn.apache.org/viewvc?rev=1175882view=rev Log: merge from 0.8 Modified: cassandra/branches/cassandra-1.0.0/ (props changed) cassandra/branches/cassandra-1.0.0/CHANGES.txt cassandra/branches/cassandra-1.0.0/contrib/ (props changed) cassandra/branches/cassandra-1.0.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java (props changed) cassandra/branches/cassandra-1.0.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Column.java (props changed) cassandra/branches/cassandra-1.0.0/interface/thrift/gen-java/org/apache/cassandra/thrift/InvalidRequestException.java (props changed) cassandra/branches/cassandra-1.0.0/interface/thrift/gen-java/org/apache/cassandra/thrift/NotFoundException.java (props changed) cassandra/branches/cassandra-1.0.0/interface/thrift/gen-java/org/apache/cassandra/thrift/SuperColumn.java (props changed) cassandra/branches/cassandra-1.0.0/src/java/org/apache/cassandra/service/AntiEntropyService.java Propchange: cassandra/branches/cassandra-1.0.0/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Mon Sep 26 14:23:29 2011 @@ -1,7 +1,7 @@ /cassandra/branches/cassandra-0.6:922689-1052356,1052358-1053452,1053454,1053456-1131291 /cassandra/branches/cassandra-0.7:1026516-1170333,1172024 /cassandra/branches/cassandra-0.7.0:1053690-1055654 -/cassandra/branches/cassandra-0.8:1090934-1125013,1125019-1175057 +/cassandra/branches/cassandra-0.8:1090934-1125013,1125019-1175057,1175880 /cassandra/branches/cassandra-0.8.0:1125021-1130369 /cassandra/branches/cassandra-0.8.1:1101014-1125018 /cassandra/tags/cassandra-0.7.0-rc3:1051699-1053689 Modified: cassandra/branches/cassandra-1.0.0/CHANGES.txt URL: http://svn.apache.org/viewvc/cassandra/branches/cassandra-1.0.0/CHANGES.txt?rev=1175882r1=1175881r2=1175882view=diff == --- cassandra/branches/cassandra-1.0.0/CHANGES.txt (original) +++ cassandra/branches/cassandra-1.0.0/CHANGES.txt Mon Sep 26 14:23:29 2011 @@ -1,3 +1,8 @@ +1.0.0-final + * Log a miningfull warning when a node receive a message for a repair session + that don't exist anymore (CASSANDRA-3256) + + 1.0.0-rc1 * Update CQL to generate microsecond timestamps by default (CASSANDRA-3227) * Fix counting CFMetadata towards Memtable liveRatio (CASSANDRA-3023) Propchange: cassandra/branches/cassandra-1.0.0/contrib/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Mon Sep 26 14:23:29 2011 @@ -1,7 +1,7 @@ /cassandra/branches/cassandra-0.6/contrib:922689-1052356,1052358-1053452,1053454,1053456-1068009 /cassandra/branches/cassandra-0.7/contrib:1026516-1170333,1172024 /cassandra/branches/cassandra-0.7.0/contrib:1053690-1055654 -/cassandra/branches/cassandra-0.8/contrib:1090934-1125013,1125019-1175057 +/cassandra/branches/cassandra-0.8/contrib:1090934-1125013,1125019-1175057,1175880 /cassandra/branches/cassandra-0.8.0/contrib:1125021-1130369 /cassandra/branches/cassandra-0.8.1/contrib:1101014-1125018 /cassandra/tags/cassandra-0.7.0-rc3/contrib:1051699-1053689 Propchange: cassandra/branches/cassandra-1.0.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java -- --- svn:mergeinfo (original) +++ svn:mergeinfo Mon Sep 26 14:23:29 2011 @@ -1,7 +1,7 @@ /cassandra/branches/cassandra-0.6/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:922689-1052356,1052358-1053452,1053454,1053456-1131291 /cassandra/branches/cassandra-0.7/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1026516-1170333,1172024 /cassandra/branches/cassandra-0.7.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1053690-1055654 -/cassandra/branches/cassandra-0.8/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1090934-1125013,1125019-1175057 +/cassandra/branches/cassandra-0.8/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1090934-1125013,1125019-1175057,1175880 /cassandra/branches/cassandra-0.8.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1125021-1130369 /cassandra/branches/cassandra-0.8.1/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1101014-1125018 /cassandra/tags/cassandra-0.7.0-rc3/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1051699-1053689 Propchange: cassandra/branches/cassandra-1.0.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Column.java -- --- svn:mergeinfo (original) +++ svn:mergeinfo Mon Sep 26 14:23:29 2011 @@ -1,7 +1,7 @@
svn commit: r1175883 - in /cassandra/branches/cassandra-1.0: ./ contrib/ interface/thrift/gen-java/org/apache/cassandra/thrift/ src/java/org/apache/cassandra/service/
Author: slebresne Date: Mon Sep 26 14:30:28 2011 New Revision: 1175883 URL: http://svn.apache.org/viewvc?rev=1175883view=rev Log: merge from 1.0.0 Modified: cassandra/branches/cassandra-1.0/ (props changed) cassandra/branches/cassandra-1.0/CHANGES.txt cassandra/branches/cassandra-1.0/contrib/ (props changed) cassandra/branches/cassandra-1.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java (props changed) cassandra/branches/cassandra-1.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Column.java (props changed) cassandra/branches/cassandra-1.0/interface/thrift/gen-java/org/apache/cassandra/thrift/InvalidRequestException.java (props changed) cassandra/branches/cassandra-1.0/interface/thrift/gen-java/org/apache/cassandra/thrift/NotFoundException.java (props changed) cassandra/branches/cassandra-1.0/interface/thrift/gen-java/org/apache/cassandra/thrift/SuperColumn.java (props changed) cassandra/branches/cassandra-1.0/src/java/org/apache/cassandra/service/AntiEntropyService.java Propchange: cassandra/branches/cassandra-1.0/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Mon Sep 26 14:30:28 2011 @@ -1,11 +1,11 @@ /cassandra/branches/cassandra-0.6:922689-1052356,1052358-1053452,1053454,1053456-1131291 /cassandra/branches/cassandra-0.7:1026516-1170333,1172024 /cassandra/branches/cassandra-0.7.0:1053690-1055654 -/cassandra/branches/cassandra-0.8:1090934-1125013,1125019-1174469,1174701 +/cassandra/branches/cassandra-0.8:1090934-1125013,1125019-1174469,1174701,1175880 /cassandra/branches/cassandra-0.8.0:1125021-1130369 /cassandra/branches/cassandra-0.8.1:1101014-1125018 /cassandra/branches/cassandra-1.0:1167106,1167185 -/cassandra/branches/cassandra-1.0.0:1167104-1174472,1174704,1175725,1175770-1175771 +/cassandra/branches/cassandra-1.0.0:1167104-1174472,1174704,1175725,1175770-1175771,1175882 /cassandra/tags/cassandra-0.7.0-rc3:1051699-1053689 /cassandra/tags/cassandra-0.8.0-rc1:1102511-1125020 /cassandra/trunk:1167085-1167102,1169870 Modified: cassandra/branches/cassandra-1.0/CHANGES.txt URL: http://svn.apache.org/viewvc/cassandra/branches/cassandra-1.0/CHANGES.txt?rev=1175883r1=1175882r2=1175883view=diff == --- cassandra/branches/cassandra-1.0/CHANGES.txt (original) +++ cassandra/branches/cassandra-1.0/CHANGES.txt Mon Sep 26 14:30:28 2011 @@ -2,6 +2,11 @@ * describe_ring should include datacenter/topology information (CASSANDRA-2882) +1.0.0-final + * Log a miningfull warning when a node receive a message for a repair session + that don't exist anymore (CASSANDRA-3256) + + 1.0.0-rc1 * Update CQL to generate microsecond timestamps by default (CASSANDRA-3227) * Fix counting CFMetadata towards Memtable liveRatio (CASSANDRA-3023) Propchange: cassandra/branches/cassandra-1.0/contrib/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Mon Sep 26 14:30:28 2011 @@ -1,11 +1,11 @@ /cassandra/branches/cassandra-0.6/contrib:922689-1052356,1052358-1053452,1053454,1053456-1068009 /cassandra/branches/cassandra-0.7/contrib:1026516-1170333,1172024 /cassandra/branches/cassandra-0.7.0/contrib:1053690-1055654 -/cassandra/branches/cassandra-0.8/contrib:1090934-1125013,1125019-1174469,1174701 +/cassandra/branches/cassandra-0.8/contrib:1090934-1125013,1125019-1174469,1174701,1175880 /cassandra/branches/cassandra-0.8.0/contrib:1125021-1130369 /cassandra/branches/cassandra-0.8.1/contrib:1101014-1125018 /cassandra/branches/cassandra-1.0/contrib:1167106,1167185 -/cassandra/branches/cassandra-1.0.0/contrib:1167104-1174472,1174704,1175725,1175770-1175771 +/cassandra/branches/cassandra-1.0.0/contrib:1167104-1174472,1174704,1175725,1175770-1175771,1175882 /cassandra/tags/cassandra-0.7.0-rc3/contrib:1051699-1053689 /cassandra/tags/cassandra-0.8.0-rc1/contrib:1102511-1125020 /cassandra/trunk/contrib:1167085-1167102,1169870 Propchange: cassandra/branches/cassandra-1.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java -- --- svn:mergeinfo (original) +++ svn:mergeinfo Mon Sep 26 14:30:28 2011 @@ -1,11 +1,11 @@ /cassandra/branches/cassandra-0.6/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:922689-1052356,1052358-1053452,1053454,1053456-1131291 /cassandra/branches/cassandra-0.7/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1026516-1170333,1172024 /cassandra/branches/cassandra-0.7.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1053690-1055654 -/cassandra/branches/cassandra-0.8/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1090934-1125013,1125019-1174469,1174701
svn commit: r1175886 - in /cassandra/trunk: ./ contrib/ interface/thrift/gen-java/org/apache/cassandra/thrift/ src/java/org/apache/cassandra/service/
Author: slebresne Date: Mon Sep 26 14:36:50 2011 New Revision: 1175886 URL: http://svn.apache.org/viewvc?rev=1175886view=rev Log: merge from 1.0 Modified: cassandra/trunk/ (props changed) cassandra/trunk/CHANGES.txt cassandra/trunk/contrib/ (props changed) cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java (props changed) cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/Column.java (props changed) cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/InvalidRequestException.java (props changed) cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/NotFoundException.java (props changed) cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/SuperColumn.java (props changed) cassandra/trunk/src/java/org/apache/cassandra/service/AntiEntropyService.java Propchange: cassandra/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Mon Sep 26 14:36:50 2011 @@ -1,11 +1,11 @@ /cassandra/branches/cassandra-0.6:922689-1052356,1052358-1053452,1053454,1053456-1131291 /cassandra/branches/cassandra-0.7:1026516-1170333,1172024 /cassandra/branches/cassandra-0.7.0:1053690-1055654 -/cassandra/branches/cassandra-0.8:1090934-1125013,1125019-1174469,1174701 +/cassandra/branches/cassandra-0.8:1090934-1125013,1125019-1174469,1174701,1175880 /cassandra/branches/cassandra-0.8.0:1125021-1130369 /cassandra/branches/cassandra-0.8.1:1101014-1125018 -/cassandra/branches/cassandra-1.0:1167085-1174478,1174706,1175727,1175772 -/cassandra/branches/cassandra-1.0.0:1167104-1167229,1167232-1174472,1174704,1175725,1175770-1175771 +/cassandra/branches/cassandra-1.0:1167085-1174478,1174706,1175727,1175772,1175883 +/cassandra/branches/cassandra-1.0.0:1167104-1167229,1167232-1174472,1174704,1175725,1175770-1175771,1175882 /cassandra/tags/cassandra-0.7.0-rc3:1051699-1053689 /cassandra/tags/cassandra-0.8.0-rc1:1102511-1125020 /incubator/cassandra/branches/cassandra-0.3:774578-796573 Modified: cassandra/trunk/CHANGES.txt URL: http://svn.apache.org/viewvc/cassandra/trunk/CHANGES.txt?rev=1175886r1=1175885r2=1175886view=diff == --- cassandra/trunk/CHANGES.txt (original) +++ cassandra/trunk/CHANGES.txt Mon Sep 26 14:36:50 2011 @@ -2,6 +2,11 @@ * describe_ring should include datacenter/topology information (CASSANDRA-2882) +1.0.0-final + * Log a miningfull warning when a node receive a message for a repair session + that don't exist anymore (CASSANDRA-3256) + + 1.0.0-rc1 * Update CQL to generate microsecond timestamps by default (CASSANDRA-3227) * Fix counting CFMetadata towards Memtable liveRatio (CASSANDRA-3023) Propchange: cassandra/trunk/contrib/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Mon Sep 26 14:36:50 2011 @@ -1,11 +1,11 @@ /cassandra/branches/cassandra-0.6/contrib:922689-1052356,1052358-1053452,1053454,1053456-1068009 /cassandra/branches/cassandra-0.7/contrib:1026516-1170333,1172024 /cassandra/branches/cassandra-0.7.0/contrib:1053690-1055654 -/cassandra/branches/cassandra-0.8/contrib:1090934-1125013,1125019-1174469,1174701 +/cassandra/branches/cassandra-0.8/contrib:1090934-1125013,1125019-1174469,1174701,1175880 /cassandra/branches/cassandra-0.8.0/contrib:1125021-1130369 /cassandra/branches/cassandra-0.8.1/contrib:1101014-1125018 -/cassandra/branches/cassandra-1.0/contrib:1167085-1174478,1174706,1175727,1175772 -/cassandra/branches/cassandra-1.0.0/contrib:1167104-1167229,1167232-1174472,1174704,1175725,1175770-1175771 +/cassandra/branches/cassandra-1.0/contrib:1167085-1174478,1174706,1175727,1175772,1175883 +/cassandra/branches/cassandra-1.0.0/contrib:1167104-1167229,1167232-1174472,1174704,1175725,1175770-1175771,1175882 /cassandra/tags/cassandra-0.7.0-rc3/contrib:1051699-1053689 /cassandra/tags/cassandra-0.8.0-rc1/contrib:1102511-1125020 /incubator/cassandra/branches/cassandra-0.3/contrib:774578-796573 Propchange: cassandra/trunk/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java -- --- svn:mergeinfo (original) +++ svn:mergeinfo Mon Sep 26 14:36:50 2011 @@ -1,11 +1,11 @@ /cassandra/branches/cassandra-0.6/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:922689-1052356,1052358-1053452,1053454,1053456-1131291 /cassandra/branches/cassandra-0.7/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1026516-1170333,1172024 /cassandra/branches/cassandra-0.7.0/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1053690-1055654 -/cassandra/branches/cassandra-0.8/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java:1090934-1125013,1125019-1174469,1174701
buildbot success in ASF Buildbot on cassandra-trunk
The Buildbot has detected a restored build on builder cassandra-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/cassandra-trunk/builds/1689 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: isis_ubuntu Build Reason: scheduler Build Source Stamp: [branch cassandra/trunk] 1175886 Blamelist: slebresne Build succeeded! sincerely, -The Buildbot
[jira] [Commented] (CASSANDRA-3150) ColumnFormatRecordReader loops forever (StorageService.getSplits(..) out of whack)
[
https://issues.apache.org/jira/browse/CASSANDRA-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114702#comment-13114702
]
T Jake Luciani commented on CASSANDRA-3150:
---
bq. The problematic split ends up being ...
So you are saying that split keeps getting called over and over? I dont see
that in the log or does it hang?
ColumnFormatRecordReader loops forever (StorageService.getSplits(..) out of
whack)
--
Key: CASSANDRA-3150
URL: https://issues.apache.org/jira/browse/CASSANDRA-3150
Project: Cassandra
Issue Type: Bug
Components: Hadoop
Affects Versions: 0.8.4, 0.8.5
Reporter: Mck SembWever
Assignee: Mck SembWever
Priority: Critical
Fix For: 0.8.6
Attachments: CASSANDRA-3150.patch, Screenshot-Counters for
task_201109212019_1060_m_29 - Mozilla Firefox.png, Screenshot-Hadoop map
task list for job_201109212019_1060 on cassandra01 - Mozilla Firefox.png,
attempt_201109071357_0044_m_003040_0.grep-get_range_slices.log,
fullscan-example1.log
From http://thread.gmane.org/gmane.comp.db.cassandra.user/20039
{quote}
bq. Cassandra-0.8.4 w/ ByteOrderedPartitioner
bq. CFIF's inputSplitSize=196608
bq. 3 map tasks (from 4013) is still running after read 25 million rows.
bq. Can this be a bug in StorageService.getSplits(..) ?
getSplits looks pretty foolproof to me but I guess we'd need to add
more debug logging to rule out a bug there for sure.
I guess the main alternative would be a bug in the recordreader paging.
{quote}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3245) Don't fail when numactl is installed, but NUMA policies are not supported
[
https://issues.apache.org/jira/browse/CASSANDRA-3245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114732#comment-13114732
]
paul cannon commented on CASSANDRA-3245:
bq. @paul Can you test whether numactl exits with a proper non-0 exit status on
the system where it is not supported?
Indeed it does; using --interleave=all when there is no NUMA policy support
causes an exit value of 1.
+1
Don't fail when numactl is installed, but NUMA policies are not supported
-
Key: CASSANDRA-3245
URL: https://issues.apache.org/jira/browse/CASSANDRA-3245
Project: Cassandra
Issue Type: Bug
Components: Packaging
Affects Versions: 1.0.0
Environment: Any Linux system where a 'numactl' executable is
available, but no NUMA policies are actually supported. EC2 nodes are easy
examples of environments with no NUMA policy support.
Reporter: paul cannon
Assignee: Peter Schuller
Priority: Minor
Fix For: 1.0.0
Attachments: 3245.txt
When numactl is installed but NUMA policies are not supported, trying to run
cassandra gives only:
{noformat}
numactl: This system does not support NUMA policy
{noformat}
..and the startup script fails there.
We should probably fail a little more gracefully. Possibly the best way to
tell if numactl will work is by using:
{noformat}
numactl --hardware
{noformat}
but I don't have ready access to a machine with proper NUMA support at the
moment so I can't check how easy it is to tell the difference in the output.
It looks just as reliable (if possibly a bit more brittle) to check for the
existence of the directory {{/sys/devices/system/node}}. If that directory
doesn't exist, we shouldn't even try to use or run numactl.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3257) Enabling SSL on a fairly light cluster leaks Open files.
[ https://issues.apache.org/jira/browse/CASSANDRA-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114747#comment-13114747 ] Vijay commented on CASSANDRA-3257: -- This issue elevates when a node is down. Enabling SSL on a fairly light cluster leaks Open files. Key: CASSANDRA-3257 URL: https://issues.apache.org/jira/browse/CASSANDRA-3257 Project: Cassandra Issue Type: Bug Components: Core Affects Versions: 0.8.6 Environment: JVM on CentOS Reporter: Vijay Priority: Minor To reproduce: Enable SSL encryption and let the server be idle for a day or so you will see the below [vijay_tcasstest@vijay_tcass--1c-i-1568885c ~]$ /usr/sbin/lsof |grep -i cassandra-app.jks |wc -l ;date 16333 Sun Sep 25 17:23:29 UTC 2011 [vijay_tcasstest@vijay_tcass--1c-i-1568885c ~]$ java -jar cmdline-jmxclient-0.10.3.jar - localhost:7501 java.lang:type=Memory gc [vijay_tcasstest@vijay_tcass--1c-i-1568885c ~]$ /usr/sbin/lsof |grep -i cassandra-app.jks |wc -l ;date 64 Sun Sep 25 17:23:53 UTC 2011 [vijay_tcasstest@vijay_tcass--1c-i-1568885c ~]$ After running GC manually the issue goes away. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (CASSANDRA-3260) MergeIterator assertion on sources != empty can be thrown
MergeIterator assertion on sources != empty can be thrown - Key: CASSANDRA-3260 URL: https://issues.apache.org/jira/browse/CASSANDRA-3260 Project: Cassandra Issue Type: Bug Components: Core Affects Versions: 1.0.0 Reporter: Sylvain Lebresne Assignee: Sylvain Lebresne Priority: Trivial Fix For: 1.0.0 Attachments: 3260.patch MergeIterator.get assert that it don't get an empty list of sources. This seems to at least not be the case in the unit test for some of tests (this don't make any test fail however, but there is a few stack trace thrown). I think it's pretty unnatural to fail on an empty list of sources and would force every caller to first take the empty case into account, so I propose to just remove that assertion. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3260) MergeIterator assertion on sources != empty can be thrown
[ https://issues.apache.org/jira/browse/CASSANDRA-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylvain Lebresne updated CASSANDRA-3260: Attachment: 3260.patch MergeIterator assertion on sources != empty can be thrown - Key: CASSANDRA-3260 URL: https://issues.apache.org/jira/browse/CASSANDRA-3260 Project: Cassandra Issue Type: Bug Components: Core Affects Versions: 1.0.0 Reporter: Sylvain Lebresne Assignee: Sylvain Lebresne Priority: Trivial Fix For: 1.0.0 Attachments: 3260.patch MergeIterator.get assert that it don't get an empty list of sources. This seems to at least not be the case in the unit test for some of tests (this don't make any test fail however, but there is a few stack trace thrown). I think it's pretty unnatural to fail on an empty list of sources and would force every caller to first take the empty case into account, so I propose to just remove that assertion. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3257) Enabling SSL on a fairly light cluster leaks Open files.
[ https://issues.apache.org/jira/browse/CASSANDRA-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114756#comment-13114756 ] Vijay commented on CASSANDRA-3257: -- Seems like the issue may be because we are opening the FIS and not closing it in SSLFactory.createSSLContext, testing it... patch soon. Enabling SSL on a fairly light cluster leaks Open files. Key: CASSANDRA-3257 URL: https://issues.apache.org/jira/browse/CASSANDRA-3257 Project: Cassandra Issue Type: Bug Components: Core Affects Versions: 0.8.6 Environment: JVM on CentOS Reporter: Vijay Priority: Minor To reproduce: Enable SSL encryption and let the server be idle for a day or so you will see the below [vijay_tcasstest@vijay_tcass--1c-i-1568885c ~]$ /usr/sbin/lsof |grep -i cassandra-app.jks |wc -l ;date 16333 Sun Sep 25 17:23:29 UTC 2011 [vijay_tcasstest@vijay_tcass--1c-i-1568885c ~]$ java -jar cmdline-jmxclient-0.10.3.jar - localhost:7501 java.lang:type=Memory gc [vijay_tcasstest@vijay_tcass--1c-i-1568885c ~]$ /usr/sbin/lsof |grep -i cassandra-app.jks |wc -l ;date 64 Sun Sep 25 17:23:53 UTC 2011 [vijay_tcasstest@vijay_tcass--1c-i-1568885c ~]$ After running GC manually the issue goes away. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CASSANDRA-3257) Enabling SSL on a fairly light cluster leaks Open files.
[ https://issues.apache.org/jira/browse/CASSANDRA-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vijay reassigned CASSANDRA-3257: Assignee: Vijay Enabling SSL on a fairly light cluster leaks Open files. Key: CASSANDRA-3257 URL: https://issues.apache.org/jira/browse/CASSANDRA-3257 Project: Cassandra Issue Type: Bug Components: Core Affects Versions: 0.8.6 Environment: JVM on CentOS Reporter: Vijay Assignee: Vijay Priority: Minor To reproduce: Enable SSL encryption and let the server be idle for a day or so you will see the below [vijay_tcasstest@vijay_tcass--1c-i-1568885c ~]$ /usr/sbin/lsof |grep -i cassandra-app.jks |wc -l ;date 16333 Sun Sep 25 17:23:29 UTC 2011 [vijay_tcasstest@vijay_tcass--1c-i-1568885c ~]$ java -jar cmdline-jmxclient-0.10.3.jar - localhost:7501 java.lang:type=Memory gc [vijay_tcasstest@vijay_tcass--1c-i-1568885c ~]$ /usr/sbin/lsof |grep -i cassandra-app.jks |wc -l ;date 64 Sun Sep 25 17:23:53 UTC 2011 [vijay_tcasstest@vijay_tcass--1c-i-1568885c ~]$ After running GC manually the issue goes away. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2989) Error creating snaphot
[
https://issues.apache.org/jira/browse/CASSANDRA-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114772#comment-13114772
]
paul cannon commented on CASSANDRA-2989:
Ok, Luis, do you still have some logs showing this problem? I'm wondering
whether you see any of these earlier:
{noformat}
JNA not found. Native methods will be disabled.
{noformat}
or
{noformat}
Unable to link C library. Native methods will be disabled.
{noformat}
or
{noformat}
Obsolete version of JNA present; unable to register C library. Upgrade to JNA
3.2.7 or later
{noformat}
Also, what exact versions of cassandra and libjna-java are installed? ({{dpkg
-s cassandra libjna-java | grep Version}})
bq. (it seams that /etc/security/limits.d/cassandra.conf did not work, I
believe that it is related to PAM in ubuntu)
Right, the settings in limits.d will only take effect under the appropriate
conditions. In the default Debian/Ubuntu PAM config, that includes login via
'login', 'sshd', and 'sudo', and execution via 'cron' or 'at'. It notably does
not include becoming a user with 'su'. But even if it did, the Debian
initscript does not use su like the Redhat one; it uses jsvc, which sheds
privileges and switches users itself, without any special PAM integration. So
really, the limits.d/cassandra.conf is only useful for users who may want to
run Cassandra via a different method from the initscript.
Error creating snaphot
--
Key: CASSANDRA-2989
URL: https://issues.apache.org/jira/browse/CASSANDRA-2989
Project: Cassandra
Issue Type: Bug
Components: Tools
Affects Versions: 0.8.1
Environment: Ubuntu, from apache repository 08x.
Reporter: Luis Eduardo Villares Matta
Assignee: paul cannon
(Note I upgraded from 0.7.x to 0.8.1 and I am having problems updating the
schemas, running nodetool compac. But now
I had this error on production so I am posting it)
Exception in thread main java.io.IOError: java.io.IOException: Cannot run
program ln: java.io.IOException: error=24, Too many open files
at
org.apache.cassandra.db.ColumnFamilyStore.snapshotWithoutFlush(ColumnFamilyStore.java:1700)
at
org.apache.cassandra.db.ColumnFamilyStore.snapshot(ColumnFamilyStore.java:1726)
at org.apache.cassandra.db.Table.snapshot(Table.java:198)
at
org.apache.cassandra.service.StorageService.takeSnapshot(StorageService.java:1409)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:93)
at
com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:27)
at
com.sun.jmx.mbeanserver.MBeanIntrospector.invokeM(MBeanIntrospector.java:208)
at com.sun.jmx.mbeanserver.PerInterface.invoke(PerInterface.java:120)
at com.sun.jmx.mbeanserver.MBeanSupport.invoke(MBeanSupport.java:262)
at
com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.invoke(DefaultMBeanServerInterceptor.java:836)
at
com.sun.jmx.mbeanserver.JmxMBeanServer.invoke(JmxMBeanServer.java:761)
at
javax.management.remote.rmi.RMIConnectionImpl.doOperation(RMIConnectionImpl.java:1427)
at
javax.management.remote.rmi.RMIConnectionImpl.access$200(RMIConnectionImpl.java:72)
at
javax.management.remote.rmi.RMIConnectionImpl$PrivilegedOperation.run(RMIConnectionImpl.java:1265)
at
javax.management.remote.rmi.RMIConnectionImpl.doPrivilegedOperation(RMIConnectionImpl.java:1360)
at
javax.management.remote.rmi.RMIConnectionImpl.invoke(RMIConnectionImpl.java:788)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:305)
at sun.rmi.transport.Transport$1.run(Transport.java:159)
at java.security.AccessController.doPrivileged(Native Method)
at sun.rmi.transport.Transport.serviceCall(Transport.java:155)
at
sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:535)
at
sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:790)
at
sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:649)
at
[jira] [Commented] (CASSANDRA-3260) MergeIterator assertion on sources != empty can be thrown
[ https://issues.apache.org/jira/browse/CASSANDRA-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114775#comment-13114775 ] Jonathan Ellis commented on CASSANDRA-3260: --- Should also then change the next line from if (sources.size() == 1) to if (sources.size() = 1) +1 w/ that MergeIterator assertion on sources != empty can be thrown - Key: CASSANDRA-3260 URL: https://issues.apache.org/jira/browse/CASSANDRA-3260 Project: Cassandra Issue Type: Bug Components: Core Affects Versions: 1.0.0 Reporter: Sylvain Lebresne Assignee: Sylvain Lebresne Priority: Trivial Fix For: 1.0.0 Attachments: 3260.patch MergeIterator.get assert that it don't get an empty list of sources. This seems to at least not be the case in the unit test for some of tests (this don't make any test fail however, but there is a few stack trace thrown). I think it's pretty unnatural to fail on an empty list of sources and would force every caller to first take the empty case into account, so I propose to just remove that assertion. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3257) Enabling SSL on a fairly light cluster leaks Open files.
[ https://issues.apache.org/jira/browse/CASSANDRA-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vijay updated CASSANDRA-3257: - Attachment: 0001-ssl-open-file-issue.patch Closing the FIS fixes the issue (in SSLFactory). Enabling SSL on a fairly light cluster leaks Open files. Key: CASSANDRA-3257 URL: https://issues.apache.org/jira/browse/CASSANDRA-3257 Project: Cassandra Issue Type: Bug Components: Core Affects Versions: 0.8.6, 1.0.0 Environment: JVM on CentOS Reporter: Vijay Assignee: Vijay Priority: Minor Fix For: 0.8.7, 1.0.0 Attachments: 0001-ssl-open-file-issue.patch To reproduce: Enable SSL encryption and let the server be idle for a day or so you will see the below [vijay_tcasstest@vijay_tcass--1c-i-1568885c ~]$ /usr/sbin/lsof |grep -i cassandra-app.jks |wc -l ;date 16333 Sun Sep 25 17:23:29 UTC 2011 [vijay_tcasstest@vijay_tcass--1c-i-1568885c ~]$ java -jar cmdline-jmxclient-0.10.3.jar - localhost:7501 java.lang:type=Memory gc [vijay_tcasstest@vijay_tcass--1c-i-1568885c ~]$ /usr/sbin/lsof |grep -i cassandra-app.jks |wc -l ;date 64 Sun Sep 25 17:23:53 UTC 2011 [vijay_tcasstest@vijay_tcass--1c-i-1568885c ~]$ After running GC manually the issue goes away. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[Cassandra Wiki] Update of HadoopSupport by jeremyhanna
Dear Wiki user,
You have subscribed to a wiki page or wiki category on Cassandra Wiki for
change notification.
The HadoopSupport page has been changed by jeremyhanna:
http://wiki.apache.org/cassandra/HadoopSupport?action=diffrev1=39rev2=40
Comment:
Adding more troubleshooting information and a caveat to OSS Brisk in the main
description
== Overview ==
Cassandra 0.6+ enables certain [[http://hadoop.apache.org/|Hadoop]]
functionality against Cassandra's data store. Specifically, support has been
added for [[http://hadoop.apache.org/mapreduce/|MapReduce]],
[[http://pig.apache.org|Pig]] and [[http://hive.apache.org/|Hive]].
- [[http://datastax.com|DataStax]] has open-sourced a Cassandra based Hadoop
distribution called Brisk.
([[http://www.datastax.com/docs/0.8/brisk/index|Documentation]])
([[http://github.com/riptano/brisk|Code]])
+ [[http://datastax.com|DataStax]] has open-sourced a Cassandra based Hadoop
distribution called Brisk.
([[http://www.datastax.com/docs/0.8/brisk/index|Documentation]])
([[http://github.com/riptano/brisk|Code]]) However this code is no longer going
to be maintained by DataStax. Future development of Brisk is now part of a
pay-for offering.
[[#Top|Top]]
@@ -92, +92 @@
* '''cassandra.range.batch.size''' - the default is 4096, but you may need
to lower this depending on your data. This is either specified in your hadoop
configuration or using
`org.apache.cassandra.hadoop.ConfigHelper.setRangeBatchSize`.
* '''rpc_timeout_in_ms''' - this is set in your `cassandra.yaml` (in 0.6
it's `RpcTimeoutInMillis` in `storage-conf.xml`). The rpc timeout is not for
timing out from the client but between nodes. This can be increased to reduce
chances of timing out.
+ If you still see timeout exceptions with resultant failed jobs and/or
blacklisted tasktrackers, there are settings that can give Cassandra more
latitude before failing the jobs. An example of usage (in either the job
configuration or taskracker mapred-site.xml):
+ {{{
+ property
+ namemapred.max.tracker.failures/name
+ value20/value
+ /property
+ property
+ namemapred.max.tracker.failures/name
+ value20/value
+ /property
+ property
+ namemapred.map.max.attempts/name
+ value20/value
+ /property
+ property
+ namemapred.reduce.max.attempts/name
+ value20/value
+ /property
+ }}}
+ The settings normally default to 4 each, but some find that too conservative.
If you set it too low, you might have blacklisted tasktrackers and failed jobs
because of occasional timeout exceptions. If you set them too high, jobs that
would otherwise fail quickly take a long time to fail, sacrificing efficiency.
Keep in mind that this can just cover a problem. It may be that you always
want these settings to be higher when operating against Cassandra. However, if
you run into these exceptions too frequently, there may be a problem with your
Cassandra or Hadoop configuration.
+
If you are seeing inconsistent data coming back, consider the consistency
level that you are reading and writing at. The two relevant properties are:
* '''cassandra.consistencylevel.read''' - defaults to !ConsistencyLevel.ONE.
* '''cassandra.consistencylevel.write''' - defaults to !ConsistencyLevel.ONE.
[Cassandra Wiki] Update of HadoopSupport by jeremyhanna
Dear Wiki user,
You have subscribed to a wiki page or wiki category on Cassandra Wiki for
change notification.
The HadoopSupport page has been changed by jeremyhanna:
http://wiki.apache.org/cassandra/HadoopSupport?action=diffrev1=40rev2=41
Comment:
Added a section on Oozie and another cluster configuration note about
speculative execution.
* [[#MapReduce|MapReduce]]
* [[#Pig|Pig]]
* [[#Hive|Hive]]
+ * [[#Oozie|Oozie]]
* [[#ClusterConfig|Cluster Configuration]]
* [[#Troubleshooting|Troubleshooting]]
* [[#Support|Support]]
@@ -16, +17 @@
== Overview ==
Cassandra 0.6+ enables certain [[http://hadoop.apache.org/|Hadoop]]
functionality against Cassandra's data store. Specifically, support has been
added for [[http://hadoop.apache.org/mapreduce/|MapReduce]],
[[http://pig.apache.org|Pig]] and [[http://hive.apache.org/|Hive]].
- [[http://datastax.com|DataStax]] has open-sourced a Cassandra based Hadoop
distribution called Brisk.
([[http://www.datastax.com/docs/0.8/brisk/index|Documentation]])
([[http://github.com/riptano/brisk|Code]]) However this code is no longer going
to be maintained by DataStax. Future development of Brisk is now part of a
pay-for offering.
+ [[http://datastax.com|DataStax]] has open-sourced a Cassandra based Hadoop
distribution called Brisk.
([[http://www.datastax.com/docs/0.8/brisk/index|Documentation]])
([[http://github.com/riptano/brisk|Code]]) However this code is no longer going
to be maintained by DataStax. Future DataStax development of Brisk is now part
of a pay-for offering.
[[#Top|Top]]
@@ -34, +35 @@
ConfigHelper.setSlicePredicate(job.getConfiguration(), predicate);
}}}
As of 0.7, configuration for Hadoop no longer resides in your job's specific
storage-conf.xml. See the `README` in the `word_count` and `pig` contrib
modules for more details.
+
Output To Cassandra
As of 0.7, there is a basic mechanism included in Cassandra for outputting
data to Cassandra. The `contrib/word_count` example in 0.7 contains two
reducers - one for outputting data to the filesystem and one to output data to
Cassandra (default) using this new mechanism. See that example in the latest
release for details.
@@ -65, +67 @@
[[#Top|Top]]
+ Anchor(Oozie)
+
+ == Oozie ==
+ [[http://incubator.apache.org/oozie/|Oozie]], the open-source workflow engine
originally from Yahoo!, can be used with Cassandra/Hadoop. Cassandra
configuration information needs to go into the oozie action configuration like
so:
+ {{{
+ property
+ namecassandra.thrift.address/name
+ value${cassandraHost}/value
+ /property
+ property
+ namecassandra.thrift.port/name
+ value${cassandraPort}/value
+ /property
+ property
+ namecassandra.partitioner.class/name
+ valueorg.apache.cassandra.dht.RandomPartitioner/value
+ /property
+ property
+ namecassandra.consistencylevel.read/name
+ value${cassandraReadConsistencyLevel}/value
+ /property
+ property
+ namecassandra.consistencylevel.write/name
+ value${cassandraWriteConsistencyLevel}/value
+ /property
+ property
+ namecassandra.range.batch.size/name
+ value${cassandraRangeBatchSize}/value
+ /property
+ }}}
+ Note that with Oozie you can specify values outright like the partitioner
here, or via variable that is typically found in the properties file.
+ One other item of note is that Oozie assumes that it can detect a filemarker
for successful completion of the job. This means that when writing to
Cassandra with, for example, Pig, the Pig script will succeed but the Oozie job
that called it will fail because filemarkers aren't written to Cassandra. So
when you write to Cassandra with Hadoop, specify this property to avoid that
check. Oozie will still get completion updates from a callback from the job
tracker, but it just won't look for the filemarker.
+ {{{
+ property
+ namemapreduce.fileoutputcommitter.marksuccessfuljobs/name
+ valuefalse/value
+ /property
+ }}}
+
+ [[#Top|Top]]
+
Anchor(ClusterConfig)
== Cluster Configuration ==
@@ -74, +117 @@
Otherwise, if you would like to configure a Cassandra cluster yourself so
that Hadoop may operate over its data, it's best to overlay a Hadoop cluster
over your Cassandra nodes. You'll want to have a separate server for your
Hadoop `NameNode`/`JobTracker`. Then install a Hadoop `TaskTracker` on each of
your Cassandra nodes. That will allow the `JobTracker` to assign tasks to the
Cassandra nodes that contain data for those tasks. Also install a Hadoop
`DataNode` on each Cassandra node. Hadoop requires a distributed filesystem
for copying dependency jars, static data, and intermediate results to be stored.
The nice thing about having a `TaskTracker` on every node is that you get
data locality and your analytics engine scales with your data. You also never
need to shuttle around your data once you've performed analytics on it - you
simply output to
[jira] [Commented] (CASSANDRA-2989) Error creating snaphot
[
https://issues.apache.org/jira/browse/CASSANDRA-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114881#comment-13114881
]
Luis Eduardo Villares Matta commented on CASSANDRA-2989:
Hello Paul,
I do not remember these messages, and after (just) executing snapshot it
runs with no messages now.
(Just to thank some one: Version 0.8.5 has stop leaking memory so my
environment is finally stable THANKS)
# dpkg -s cassandra libjna-java | grep Version
Version: 0.8.5
Version: 3.2.3-1
Finally I am currently (in /etc/init.d/cassandra) running with...
...
do_start()
{
...
ulimit -l unlimited
ulimit -n 32768
...
}
...
Rope it helps, and thanks again.
Error creating snaphot
--
Key: CASSANDRA-2989
URL: https://issues.apache.org/jira/browse/CASSANDRA-2989
Project: Cassandra
Issue Type: Bug
Components: Tools
Affects Versions: 0.8.1
Environment: Ubuntu, from apache repository 08x.
Reporter: Luis Eduardo Villares Matta
Assignee: paul cannon
(Note I upgraded from 0.7.x to 0.8.1 and I am having problems updating the
schemas, running nodetool compac. But now
I had this error on production so I am posting it)
Exception in thread main java.io.IOError: java.io.IOException: Cannot run
program ln: java.io.IOException: error=24, Too many open files
at
org.apache.cassandra.db.ColumnFamilyStore.snapshotWithoutFlush(ColumnFamilyStore.java:1700)
at
org.apache.cassandra.db.ColumnFamilyStore.snapshot(ColumnFamilyStore.java:1726)
at org.apache.cassandra.db.Table.snapshot(Table.java:198)
at
org.apache.cassandra.service.StorageService.takeSnapshot(StorageService.java:1409)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:93)
at
com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:27)
at
com.sun.jmx.mbeanserver.MBeanIntrospector.invokeM(MBeanIntrospector.java:208)
at com.sun.jmx.mbeanserver.PerInterface.invoke(PerInterface.java:120)
at com.sun.jmx.mbeanserver.MBeanSupport.invoke(MBeanSupport.java:262)
at
com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.invoke(DefaultMBeanServerInterceptor.java:836)
at
com.sun.jmx.mbeanserver.JmxMBeanServer.invoke(JmxMBeanServer.java:761)
at
javax.management.remote.rmi.RMIConnectionImpl.doOperation(RMIConnectionImpl.java:1427)
at
javax.management.remote.rmi.RMIConnectionImpl.access$200(RMIConnectionImpl.java:72)
at
javax.management.remote.rmi.RMIConnectionImpl$PrivilegedOperation.run(RMIConnectionImpl.java:1265)
at
javax.management.remote.rmi.RMIConnectionImpl.doPrivilegedOperation(RMIConnectionImpl.java:1360)
at
javax.management.remote.rmi.RMIConnectionImpl.invoke(RMIConnectionImpl.java:788)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:305)
at sun.rmi.transport.Transport$1.run(Transport.java:159)
at java.security.AccessController.doPrivileged(Native Method)
at sun.rmi.transport.Transport.serviceCall(Transport.java:155)
at
sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:535)
at
sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:790)
at
sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:649)
at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:662)
Caused by: java.io.IOException: Cannot run program ln: java.io.IOException:
error=24, Too many open files
at java.lang.ProcessBuilder.start(ProcessBuilder.java:460)
at
org.apache.cassandra.utils.CLibrary.createHardLinkWithExec(CLibrary.java:181)
at org.apache.cassandra.utils.CLibrary.createHardLink(CLibrary.java:147)
at
org.apache.cassandra.io.sstable.SSTableReader.createLinks(SSTableReader.java:730)
at
org.apache.cassandra.db.ColumnFamilyStore.snapshotWithoutFlush(ColumnFamilyStore.java:1693)
[jira] [Resolved] (CASSANDRA-2989) Error creating snaphot
[ https://issues.apache.org/jira/browse/CASSANDRA-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] paul cannon resolved CASSANDRA-2989. Resolution: Not A Problem Splendid. Glad things are going well for you. Error creating snaphot -- Key: CASSANDRA-2989 URL: https://issues.apache.org/jira/browse/CASSANDRA-2989 Project: Cassandra Issue Type: Bug Components: Tools Affects Versions: 0.8.1 Environment: Ubuntu, from apache repository 08x. Reporter: Luis Eduardo Villares Matta Assignee: paul cannon (Note I upgraded from 0.7.x to 0.8.1 and I am having problems updating the schemas, running nodetool compac. But now I had this error on production so I am posting it) Exception in thread main java.io.IOError: java.io.IOException: Cannot run program ln: java.io.IOException: error=24, Too many open files at org.apache.cassandra.db.ColumnFamilyStore.snapshotWithoutFlush(ColumnFamilyStore.java:1700) at org.apache.cassandra.db.ColumnFamilyStore.snapshot(ColumnFamilyStore.java:1726) at org.apache.cassandra.db.Table.snapshot(Table.java:198) at org.apache.cassandra.service.StorageService.takeSnapshot(StorageService.java:1409) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:93) at com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:27) at com.sun.jmx.mbeanserver.MBeanIntrospector.invokeM(MBeanIntrospector.java:208) at com.sun.jmx.mbeanserver.PerInterface.invoke(PerInterface.java:120) at com.sun.jmx.mbeanserver.MBeanSupport.invoke(MBeanSupport.java:262) at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.invoke(DefaultMBeanServerInterceptor.java:836) at com.sun.jmx.mbeanserver.JmxMBeanServer.invoke(JmxMBeanServer.java:761) at javax.management.remote.rmi.RMIConnectionImpl.doOperation(RMIConnectionImpl.java:1427) at javax.management.remote.rmi.RMIConnectionImpl.access$200(RMIConnectionImpl.java:72) at javax.management.remote.rmi.RMIConnectionImpl$PrivilegedOperation.run(RMIConnectionImpl.java:1265) at javax.management.remote.rmi.RMIConnectionImpl.doPrivilegedOperation(RMIConnectionImpl.java:1360) at javax.management.remote.rmi.RMIConnectionImpl.invoke(RMIConnectionImpl.java:788) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:305) at sun.rmi.transport.Transport$1.run(Transport.java:159) at java.security.AccessController.doPrivileged(Native Method) at sun.rmi.transport.Transport.serviceCall(Transport.java:155) at sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:535) at sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:790) at sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:649) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:662) Caused by: java.io.IOException: Cannot run program ln: java.io.IOException: error=24, Too many open files at java.lang.ProcessBuilder.start(ProcessBuilder.java:460) at org.apache.cassandra.utils.CLibrary.createHardLinkWithExec(CLibrary.java:181) at org.apache.cassandra.utils.CLibrary.createHardLink(CLibrary.java:147) at org.apache.cassandra.io.sstable.SSTableReader.createLinks(SSTableReader.java:730) at org.apache.cassandra.db.ColumnFamilyStore.snapshotWithoutFlush(ColumnFamilyStore.java:1693) ... 33 more Caused by: java.io.IOException: java.io.IOException: error=24, Too many open files at java.lang.UNIXProcess.init(UNIXProcess.java:148) at java.lang.ProcessImpl.start(ProcessImpl.java:65) at java.lang.ProcessBuilder.start(ProcessBuilder.java:453) ... 37 more -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators:
svn commit: r1176048 - in /cassandra/branches/cassandra-1.0.0: CHANGES.txt bin/cassandra
Author: jbellis Date: Mon Sep 26 20:48:52 2011 New Revision: 1176048 URL: http://svn.apache.org/viewvc?rev=1176048view=rev Log: test for NUMA policy support as well as numactl presence patch by Peter Schuller; reviewed by Paul Cannon for CASSANDRA-3245 Modified: cassandra/branches/cassandra-1.0.0/CHANGES.txt cassandra/branches/cassandra-1.0.0/bin/cassandra Modified: cassandra/branches/cassandra-1.0.0/CHANGES.txt URL: http://svn.apache.org/viewvc/cassandra/branches/cassandra-1.0.0/CHANGES.txt?rev=1176048r1=1176047r2=1176048view=diff == --- cassandra/branches/cassandra-1.0.0/CHANGES.txt (original) +++ cassandra/branches/cassandra-1.0.0/CHANGES.txt Mon Sep 26 20:48:52 2011 @@ -1,6 +1,7 @@ 1.0.0-final * Log a miningfull warning when a node receive a message for a repair session that don't exist anymore (CASSANDRA-3256) + * test for NUMA policy support as well as numactl presence (CASSANDRA-3245) 1.0.0-rc1 Modified: cassandra/branches/cassandra-1.0.0/bin/cassandra URL: http://svn.apache.org/viewvc/cassandra/branches/cassandra-1.0.0/bin/cassandra?rev=1176048r1=1176047r2=1176048view=diff == --- cassandra/branches/cassandra-1.0.0/bin/cassandra (original) +++ cassandra/branches/cassandra-1.0.0/bin/cassandra Mon Sep 26 20:48:52 2011 @@ -91,10 +91,12 @@ fi # If numactl is available, use it. For Cassandra, the priority is to # avoid disk I/O. Even for the purpose of CPU efficiency, we don't -# really have CPU-data affinity anyway. -if which numactl /dev/null 2/dev/null +# really have CPU-data affinity anyway. Also, empirically test that numactl +# works before trying to use it (CASSANDRA-3245). +NUMACTL_ARGS=--interleave=all +if which numactl /dev/null 2/dev/null numactl $NUMACTL_ARGS ls / /dev/null 2/dev/null then -NUMACTL=numactl --interleave=all +NUMACTL=numactl $NUMACTL_ARGS else NUMACTL= fi
svn commit: r1176070 - in /cassandra/trunk: build.xml drivers/py/ test/system/test_cql.py
Author: eevans
Date: Mon Sep 26 21:26:47 2011
New Revision: 1176070
URL: http://svn.apache.org/viewvc?rev=1176070view=rev
Log:
relocate Python driver
Moved to: http://code.google.com/a/apache-extras.org/p/cassandra-dbapi2/
Patch by eevans; reviewed by paul cannon for CASSANDRA-3180
Removed:
cassandra/trunk/drivers/py/
cassandra/trunk/test/system/test_cql.py
Modified:
cassandra/trunk/build.xml
Modified: cassandra/trunk/build.xml
URL:
http://svn.apache.org/viewvc/cassandra/trunk/build.xml?rev=1176070r1=1176069r2=1176070view=diff
==
--- cassandra/trunk/build.xml (original)
+++ cassandra/trunk/build.xml Mon Sep 26 21:26:47 2011
@@ -873,7 +873,7 @@ url=${svn.entry.url}?pathrev=${svn.entry
/target
!-- creates release tarballs --
-target name=artifacts depends=jar,javadoc,py-cql-driver
+target name=artifacts depends=jar,javadoc
description=Create Cassandra release artifacts
mkdir dir=${dist.dir}/
copy todir=${dist.dir}/lib
@@ -1319,17 +1319,6 @@ url=${svn.entry.url}?pathrev=${svn.entry
delete dir=build/eclipse-classes /
/target
- target name=py-cql-driver
- description=Generate Python CQL driver artifact
-echoCreating Python CQL driver artifact.../echo
-exec executable=python dir=${basedir}/drivers/py failonerror=true
- arg line=setup.py /
- arg line=sdist /
- arg line=--dist-dir /
- arg line=${build.dir} /
-/exec
- /target
-
!-- Publish artifacts to Maven repositories --
target name=mvn-install
depends=maven-declare-dependencies,artifacts,jar,sources-jar,javadoc-jar
[jira] [Commented] (CASSANDRA-3214) Make CFIF use rpc_endpoint prior to trying endpoint
[ https://issues.apache.org/jira/browse/CASSANDRA-3214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114945#comment-13114945 ] Brandon Williams commented on CASSANDRA-3214: - That's true, and I agree, but we should still try our hardest and give listen_address a try. Make CFIF use rpc_endpoint prior to trying endpoint --- Key: CASSANDRA-3214 URL: https://issues.apache.org/jira/browse/CASSANDRA-3214 Project: Cassandra Issue Type: Improvement Components: Hadoop Affects Versions: 0.8.6 Environment: Hadoop 0.20 / Cassandra 0.8.5 / Ubuntu 10.04 / Reporter: Eldon Stegall Assignee: Eldon Stegall Priority: Minor Fix For: 0.8.7, 1.0.0 Attachments: CASSANDRA-3214-make-cfif-use-rpc-endpoints-v1.txt Following up on CASSANDRA-3187 , we probably need to attempt to use the rpc_endpoint address first, and then fall back to the gossip endpoint if we don't get what we want. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3257) Enabling SSL on a fairly light cluster leaks Open files.
[ https://issues.apache.org/jira/browse/CASSANDRA-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13115021#comment-13115021 ] Jonathan Ellis commented on CASSANDRA-3257: --- should use FileUtils.closeQuietly so if one close throws, the other still happens Enabling SSL on a fairly light cluster leaks Open files. Key: CASSANDRA-3257 URL: https://issues.apache.org/jira/browse/CASSANDRA-3257 Project: Cassandra Issue Type: Bug Components: Core Affects Versions: 0.8.6, 1.0.0 Environment: JVM on CentOS Reporter: Vijay Assignee: Vijay Priority: Minor Fix For: 0.8.7, 1.0.0 Attachments: 0001-ssl-open-file-issue.patch To reproduce: Enable SSL encryption and let the server be idle for a day or so you will see the below [vijay_tcasstest@vijay_tcass--1c-i-1568885c ~]$ /usr/sbin/lsof |grep -i cassandra-app.jks |wc -l ;date 16333 Sun Sep 25 17:23:29 UTC 2011 [vijay_tcasstest@vijay_tcass--1c-i-1568885c ~]$ java -jar cmdline-jmxclient-0.10.3.jar - localhost:7501 java.lang:type=Memory gc [vijay_tcasstest@vijay_tcass--1c-i-1568885c ~]$ /usr/sbin/lsof |grep -i cassandra-app.jks |wc -l ;date 64 Sun Sep 25 17:23:53 UTC 2011 [vijay_tcasstest@vijay_tcass--1c-i-1568885c ~]$ After running GC manually the issue goes away. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3214) Make CFIF use rpc_endpoint prior to trying endpoint
[ https://issues.apache.org/jira/browse/CASSANDRA-3214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13115001#comment-13115001 ] Jonathan Ellis commented on CASSANDRA-3214: --- +0 from me then Make CFIF use rpc_endpoint prior to trying endpoint --- Key: CASSANDRA-3214 URL: https://issues.apache.org/jira/browse/CASSANDRA-3214 Project: Cassandra Issue Type: Improvement Components: Hadoop Affects Versions: 0.8.6 Environment: Hadoop 0.20 / Cassandra 0.8.5 / Ubuntu 10.04 / Reporter: Eldon Stegall Assignee: Eldon Stegall Priority: Minor Fix For: 0.8.7, 1.0.0 Attachments: CASSANDRA-3214-make-cfif-use-rpc-endpoints-v1.txt Following up on CASSANDRA-3187 , we probably need to attempt to use the rpc_endpoint address first, and then fall back to the gossip endpoint if we don't get what we want. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3180) relocate Python CQL driver
[ https://issues.apache.org/jira/browse/CASSANDRA-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13115002#comment-13115002 ] Hudson commented on CASSANDRA-3180: --- Integrated in Cassandra #1129 (See [https://builds.apache.org/job/Cassandra/1129/]) relocate Python driver Moved to: http://code.google.com/a/apache-extras.org/p/cassandra-dbapi2/ Patch by eevans; reviewed by paul cannon for CASSANDRA-3180 eevans : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1176070 Files : * /cassandra/trunk/build.xml * /cassandra/trunk/drivers/py * /cassandra/trunk/test/system/test_cql.py relocate Python CQL driver -- Key: CASSANDRA-3180 URL: https://issues.apache.org/jira/browse/CASSANDRA-3180 Project: Cassandra Issue Type: Task Components: Drivers Reporter: Eric Evans Assignee: Eric Evans Priority: Minor Labels: cql Fix For: 1.0.0 Attachments: v1-0001-CASSANDRA-3180-remove-Python-driver-artifact.txt A new project as been created at http://code.google.com/a/apache-extras.org/p/cassandra-dbapi2, a current snapshot of the code from trunk has been imported, and the tests updated. I've configured commit notifications to be sent to client-...@cassandra.apache.org, though this can be changed if people object. To the best of my knowledge, the only thing remaining is to configure the initial set of committers and admins. My thought was to setup all current Cassandra committers (that want access), and Tyler Hobbs. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3258) *.bat files fails when CASSANDRA_HOME contains a white space.
[ https://issues.apache.org/jira/browse/CASSANDRA-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13115019#comment-13115019 ] Jonathan Ellis commented on CASSANDRA-3258: --- Can you submit a patch? *.bat files fails when CASSANDRA_HOME contains a white space. - Key: CASSANDRA-3258 URL: https://issues.apache.org/jira/browse/CASSANDRA-3258 Project: Cassandra Issue Type: Bug Components: Packaging Affects Versions: 0.8.6 Environment: Windows 7 Reporter: Tim Almdal Issues 2952 and 2237 fixed the issue for cassandra.bat. But the following bat files need the same fix: json2sstable.bat nodetool.bat sstable2json.bat sstablekeys.bat -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3261) Thrift sockets are not buffered properly
[ https://issues.apache.org/jira/browse/CASSANDRA-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] T Jake Luciani updated CASSANDRA-3261: -- Summary: Thrift sockets are not buffered properly (was: Thrift sockets are not buffered well) Thrift sockets are not buffered properly Key: CASSANDRA-3261 URL: https://issues.apache.org/jira/browse/CASSANDRA-3261 Project: Cassandra Issue Type: Improvement Affects Versions: 0.8.0 Reporter: T Jake Luciani Assignee: T Jake Luciani Fix For: 1.0.0 workaround for THRIFT-1121 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3261) Thrift sockets are not buffered properly
[ https://issues.apache.org/jira/browse/CASSANDRA-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] T Jake Luciani updated CASSANDRA-3261: -- Description: workaround for THRIFT-1121 adds back BufferedInputStream and BufferedOutputStream to TSocket in new TCustomSocket class was:workaround for THRIFT-1121 Thrift sockets are not buffered properly Key: CASSANDRA-3261 URL: https://issues.apache.org/jira/browse/CASSANDRA-3261 Project: Cassandra Issue Type: Improvement Affects Versions: 0.8.0 Reporter: T Jake Luciani Assignee: T Jake Luciani Fix For: 1.0.0 Attachments: buffered-tsocket.txt workaround for THRIFT-1121 adds back BufferedInputStream and BufferedOutputStream to TSocket in new TCustomSocket class -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3258) *.bat files fails when CASSANDRA_HOME contains a white space.
[ https://issues.apache.org/jira/browse/CASSANDRA-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13115153#comment-13115153 ] Tim Almdal commented on CASSANDRA-3258: --- Sure, I'll try getting that done tomorrow *.bat files fails when CASSANDRA_HOME contains a white space. - Key: CASSANDRA-3258 URL: https://issues.apache.org/jira/browse/CASSANDRA-3258 Project: Cassandra Issue Type: Bug Components: Packaging Affects Versions: 0.8.6 Environment: Windows 7 Reporter: Tim Almdal Issues 2952 and 2237 fixed the issue for cassandra.bat. But the following bat files need the same fix: json2sstable.bat nodetool.bat sstable2json.bat sstablekeys.bat -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
svn commit: r1176204 - /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/security/SSLFactory.java
Author: jbellis
Date: Tue Sep 27 05:33:06 2011
New Revision: 1176204
URL: http://svn.apache.org/viewvc?rev=1176204view=rev
Log:
fix formatting, use closeQuietly
Modified:
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/security/SSLFactory.java
Modified:
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/security/SSLFactory.java
URL:
http://svn.apache.org/viewvc/cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/security/SSLFactory.java?rev=1176204r1=1176203r2=1176204view=diff
==
---
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/security/SSLFactory.java
(original)
+++
cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/security/SSLFactory.java
Tue Sep 27 05:33:06 2011
@@ -25,7 +25,6 @@ import java.io.FileInputStream;
import java.io.IOException;
import java.net.InetAddress;
import java.net.InetSocketAddress;
-import java.net.SocketAddress;
import java.security.KeyStore;
import javax.net.ssl.KeyManagerFactory;
@@ -35,6 +34,7 @@ import javax.net.ssl.SSLSocket;
import javax.net.ssl.TrustManagerFactory;
import org.apache.cassandra.config.EncryptionOptions;
+import org.apache.cassandra.io.util.FileUtils;
/**
* A Factory for providing and setting up Client and Server SSL wrapped
@@ -46,7 +46,6 @@ public final class SSLFactory
private static final String ALGORITHM = SunX509;
private static final String STORE_TYPE = JKS;
-
public static SSLServerSocket getServerSocket(EncryptionOptions options,
InetAddress address, int port) throws IOException
{
SSLContext ctx = createSSLContext(options);
@@ -75,14 +74,16 @@ public final class SSLFactory
return socket;
}
-private static SSLContext createSSLContext(EncryptionOptions options)
throws IOException {
+private static SSLContext createSSLContext(EncryptionOptions options)
throws IOException
+{
FileInputStream tsf = new FileInputStream(options.truststore);
FileInputStream ksf = new FileInputStream(options.keystore);
SSLContext ctx;
-try {
+try
+{
ctx = SSLContext.getInstance(PROTOCOL);
-TrustManagerFactory tmf = null;
-KeyManagerFactory kmf = null;
+TrustManagerFactory tmf;
+KeyManagerFactory kmf;
tmf = TrustManagerFactory.getInstance(ALGORITHM);
KeyStore ts = KeyStore.getInstance(STORE_TYPE);
@@ -96,11 +97,15 @@ public final class SSLFactory
ctx.init(kmf.getKeyManagers(), tmf.getTrustManagers(), null);
-} catch (Exception e) {
+}
+catch (Exception e)
+{
throw new IOException(Error creating the initializing the SSL
Context, e);
-} finally {
-tsf.close();
-ksf.close();
+}
+finally
+{
+FileUtils.closeQuietly(tsf);
+FileUtils.closeQuietly(ksf);
}
return ctx;
}
svn commit: r1176206 - in /cassandra/branches/cassandra-1.0.0: ./ CHANGES.txt src/java/org/apache/cassandra/security/SSLFactory.java
Author: jbellis
Date: Tue Sep 27 05:34:31 2011
New Revision: 1176206
URL: http://svn.apache.org/viewvc?rev=1176206view=rev
Log:
merge #3257 from 0.8
Modified:
cassandra/branches/cassandra-1.0.0/ (props changed)
cassandra/branches/cassandra-1.0.0/CHANGES.txt
cassandra/branches/cassandra-1.0.0/src/java/org/apache/cassandra/security/SSLFactory.java
Propchange: cassandra/branches/cassandra-1.0.0/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Sep 27 05:34:31 2011
@@ -1,7 +1,7 @@
/cassandra/branches/cassandra-0.6:922689-1052356,1052358-1053452,1053454,1053456-1131291
/cassandra/branches/cassandra-0.7:1026516-1170333,1172024
/cassandra/branches/cassandra-0.7.0:1053690-1055654
-/cassandra/branches/cassandra-0.8:1090934-1125013,1125019-1175057,1175880
+/cassandra/branches/cassandra-0.8:1090934-1125013,1125019-1176205
/cassandra/branches/cassandra-0.8.0:1125021-1130369
/cassandra/branches/cassandra-0.8.1:1101014-1125018
/cassandra/tags/cassandra-0.7.0-rc3:1051699-1053689
Modified: cassandra/branches/cassandra-1.0.0/CHANGES.txt
URL:
http://svn.apache.org/viewvc/cassandra/branches/cassandra-1.0.0/CHANGES.txt?rev=1176206r1=1176205r2=1176206view=diff
==
--- cassandra/branches/cassandra-1.0.0/CHANGES.txt (original)
+++ cassandra/branches/cassandra-1.0.0/CHANGES.txt Tue Sep 27 05:34:31 2011
@@ -25,6 +25,7 @@
* Fix sstableloader --ignores option (CASSANDRA-3247)
* File descriptor limit increased in packaging (CASSANDRA-3206)
* Fix deadlock in commit log during flush (CASSANDRA-3253)
+ * Fix FD leak when internode encryption is enabled (CASSANDRA-3257)
1.0.0-beta1
Modified:
cassandra/branches/cassandra-1.0.0/src/java/org/apache/cassandra/security/SSLFactory.java
URL:
http://svn.apache.org/viewvc/cassandra/branches/cassandra-1.0.0/src/java/org/apache/cassandra/security/SSLFactory.java?rev=1176206r1=1176205r2=1176206view=diff
==
---
cassandra/branches/cassandra-1.0.0/src/java/org/apache/cassandra/security/SSLFactory.java
(original)
+++
cassandra/branches/cassandra-1.0.0/src/java/org/apache/cassandra/security/SSLFactory.java
Tue Sep 27 05:34:31 2011
@@ -25,7 +25,6 @@ import java.io.FileInputStream;
import java.io.IOException;
import java.net.InetAddress;
import java.net.InetSocketAddress;
-import java.net.SocketAddress;
import java.security.KeyStore;
import javax.net.ssl.KeyManagerFactory;
@@ -35,6 +34,7 @@ import javax.net.ssl.SSLSocket;
import javax.net.ssl.TrustManagerFactory;
import org.apache.cassandra.config.EncryptionOptions;
+import org.apache.cassandra.io.util.FileUtils;
/**
* A Factory for providing and setting up Client and Server SSL wrapped
@@ -46,7 +46,6 @@ public final class SSLFactory
private static final String ALGORITHM = SunX509;
private static final String STORE_TYPE = JKS;
-
public static SSLServerSocket getServerSocket(EncryptionOptions options,
InetAddress address, int port) throws IOException
{
SSLContext ctx = createSSLContext(options);
@@ -75,28 +74,39 @@ public final class SSLFactory
return socket;
}
-private static SSLContext createSSLContext(EncryptionOptions options)
throws IOException {
+private static SSLContext createSSLContext(EncryptionOptions options)
throws IOException
+{
+FileInputStream tsf = new FileInputStream(options.truststore);
+FileInputStream ksf = new FileInputStream(options.keystore);
SSLContext ctx;
-try {
+try
+{
ctx = SSLContext.getInstance(PROTOCOL);
-TrustManagerFactory tmf = null;
-KeyManagerFactory kmf = null;
+TrustManagerFactory tmf;
+KeyManagerFactory kmf;
tmf = TrustManagerFactory.getInstance(ALGORITHM);
KeyStore ts = KeyStore.getInstance(STORE_TYPE);
-ts.load(new FileInputStream(options.truststore),
options.truststore_password.toCharArray());
+ts.load(tsf, options.truststore_password.toCharArray());
tmf.init(ts);
kmf = KeyManagerFactory.getInstance(ALGORITHM);
KeyStore ks = KeyStore.getInstance(STORE_TYPE);
-ks.load(new FileInputStream(options.keystore),
options.keystore_password.toCharArray());
+ks.load(ksf, options.keystore_password.toCharArray());
kmf.init(ks, options.keystore_password.toCharArray());
ctx.init(kmf.getKeyManagers(), tmf.getTrustManagers(), null);
-} catch (Exception e) {
+}
+catch (Exception e)
+{
throw new IOException(Error creating the initializing the SSL
Context, e);
}
+finally
+{
+FileUtils.closeQuietly(tsf);
+FileUtils.closeQuietly(ksf);
+
[jira] [Commented] (CASSANDRA-3257) Enabling SSL on a fairly light cluster leaks Open files.
[ https://issues.apache.org/jira/browse/CASSANDRA-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13115231#comment-13115231 ] Jonathan Ellis commented on CASSANDRA-3257: --- done in r1176204. also cleaned up formatting. Enabling SSL on a fairly light cluster leaks Open files. Key: CASSANDRA-3257 URL: https://issues.apache.org/jira/browse/CASSANDRA-3257 Project: Cassandra Issue Type: Bug Components: Core Affects Versions: 0.8.6, 1.0.0 Environment: JVM on CentOS Reporter: Vijay Assignee: Vijay Priority: Minor Fix For: 0.8.7, 1.0.0 Attachments: 0001-ssl-open-file-issue.patch To reproduce: Enable SSL encryption and let the server be idle for a day or so you will see the below [vijay_tcasstest@vijay_tcass--1c-i-1568885c ~]$ /usr/sbin/lsof |grep -i cassandra-app.jks |wc -l ;date 16333 Sun Sep 25 17:23:29 UTC 2011 [vijay_tcasstest@vijay_tcass--1c-i-1568885c ~]$ java -jar cmdline-jmxclient-0.10.3.jar - localhost:7501 java.lang:type=Memory gc [vijay_tcasstest@vijay_tcass--1c-i-1568885c ~]$ /usr/sbin/lsof |grep -i cassandra-app.jks |wc -l ;date 64 Sun Sep 25 17:23:53 UTC 2011 [vijay_tcasstest@vijay_tcass--1c-i-1568885c ~]$ After running GC manually the issue goes away. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
svn commit: r1176207 - /cassandra/branches/cassandra-1.0.0/CHANGES.txt
Author: jbellis Date: Tue Sep 27 05:35:14 2011 New Revision: 1176207 URL: http://svn.apache.org/viewvc?rev=1176207view=rev Log: update CHANGES Modified: cassandra/branches/cassandra-1.0.0/CHANGES.txt Modified: cassandra/branches/cassandra-1.0.0/CHANGES.txt URL: http://svn.apache.org/viewvc/cassandra/branches/cassandra-1.0.0/CHANGES.txt?rev=1176207r1=1176206r2=1176207view=diff == --- cassandra/branches/cassandra-1.0.0/CHANGES.txt (original) +++ cassandra/branches/cassandra-1.0.0/CHANGES.txt Tue Sep 27 05:35:14 2011 @@ -2,6 +2,7 @@ * Log a miningfull warning when a node receive a message for a repair session that don't exist anymore (CASSANDRA-3256) * test for NUMA policy support as well as numactl presence (CASSANDRA-3245) + * Fix FD leak when internode encryption is enabled (CASSANDRA-3257) 1.0.0-rc1 @@ -25,8 +26,7 @@ * Fix sstableloader --ignores option (CASSANDRA-3247) * File descriptor limit increased in packaging (CASSANDRA-3206) * Fix deadlock in commit log during flush (CASSANDRA-3253) - * Fix FD leak when internode encryption is enabled (CASSANDRA-3257) - + 1.0.0-beta1 * removed binarymemtable (CASSANDRA-2692)
[jira] [Updated] (CASSANDRA-3176) Disabling hinted handoff counterintuitively continues to log handoff messages
[
https://issues.apache.org/jira/browse/CASSANDRA-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jonathan Ellis updated CASSANDRA-3176:
--
Summary: Disabling hinted handoff counterintuitively continues to log
handoff messages (was: Disabling hinted handoff is currently a noop)
Disabling hinted handoff counterintuitively continues to log handoff messages
-
Key: CASSANDRA-3176
URL: https://issues.apache.org/jira/browse/CASSANDRA-3176
Project: Cassandra
Issue Type: Bug
Components: Core
Reporter: Jeremy Hanna
Fix For: 1.0.0
In order to test a theory, we tried to disable hinted handoff on our cluster.
We updated all of the yaml files and then restarted all the nodes in our
cluster. However we continue to get messages such as this in the logs after
restarting:
{quote}
INFO [HintedHandoff:1] 2011-09-10 22:41:40,813 HintedHandOffManager.java
(line 323) Started hinted handoff for endpoint /10.1.2.3
INFO [HintedHandoff:1] 2011-09-10 22:41:40,813 HintedHandOffManager.java
(line 379) Finished hinted handoff of 0 rows to endpoint /10.1.2.3
INFO [HintedHandoff:1] 2011-09-10 22:41:45,025 HintedHandOffManager.java
(line 323) Started hinted handoff for endpoint /10.2.3.4
INFO [HintedHandoff:1] 2011-09-10 22:41:45,026 HintedHandOffManager.java
(line 379) Finished hinted handoff of 0 rows to endpoint /10.2.3.4
INFO [HintedHandoff:1] 2011-09-10 22:42:10,017 HintedHandOffManager.java
(line 323) Started hinted handoff for endpoint /10.3.4.5
INFO [HintedHandoff:1] 2011-09-10 22:42:10,017 HintedHandOffManager.java
(line 379) Finished hinted handoff of 0 rows to endpoint /10.3.4.5
{quote}
Also looking at the System.HintsColumnFamily in jmx there is activity there
such as pending tasks that come and go.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3176) Disabling hinted handoff counterintuitively continues to log handoff messages
[
https://issues.apache.org/jira/browse/CASSANDRA-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jonathan Ellis updated CASSANDRA-3176:
--
Component/s: Core
Priority: Minor (was: Major)
Affects Version/s: (was: 0.8.4)
Fix Version/s: 1.0.0
Assignee: Jonathan Ellis
Disabling hinted handoff counterintuitively continues to log handoff messages
-
Key: CASSANDRA-3176
URL: https://issues.apache.org/jira/browse/CASSANDRA-3176
Project: Cassandra
Issue Type: Bug
Components: Core
Reporter: Jeremy Hanna
Assignee: Jonathan Ellis
Priority: Minor
Fix For: 1.0.0
In order to test a theory, we tried to disable hinted handoff on our cluster.
We updated all of the yaml files and then restarted all the nodes in our
cluster. However we continue to get messages such as this in the logs after
restarting:
{quote}
INFO [HintedHandoff:1] 2011-09-10 22:41:40,813 HintedHandOffManager.java
(line 323) Started hinted handoff for endpoint /10.1.2.3
INFO [HintedHandoff:1] 2011-09-10 22:41:40,813 HintedHandOffManager.java
(line 379) Finished hinted handoff of 0 rows to endpoint /10.1.2.3
INFO [HintedHandoff:1] 2011-09-10 22:41:45,025 HintedHandOffManager.java
(line 323) Started hinted handoff for endpoint /10.2.3.4
INFO [HintedHandoff:1] 2011-09-10 22:41:45,026 HintedHandOffManager.java
(line 379) Finished hinted handoff of 0 rows to endpoint /10.2.3.4
INFO [HintedHandoff:1] 2011-09-10 22:42:10,017 HintedHandOffManager.java
(line 323) Started hinted handoff for endpoint /10.3.4.5
INFO [HintedHandoff:1] 2011-09-10 22:42:10,017 HintedHandOffManager.java
(line 379) Finished hinted handoff of 0 rows to endpoint /10.3.4.5
{quote}
Also looking at the System.HintsColumnFamily in jmx there is activity there
such as pending tasks that come and go.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
buildbot failure in ASF Buildbot on cassandra-1.0.0
The Buildbot has detected a new failure on builder cassandra-1.0.0 while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/cassandra-1.0.0/builds/6 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: isis_ubuntu Build Reason: scheduler Build Source Stamp: [branch cassandra/branches/cassandra-1.0.0] 1176206 Blamelist: jbellis BUILD FAILED: failed compile sincerely, -The Buildbot
buildbot failure in ASF Buildbot on cassandra-0.8
The Buildbot has detected a new failure on builder cassandra-0.8 while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/cassandra-0.8/builds/2 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: isis_ubuntu Build Reason: scheduler Build Source Stamp: [branch cassandra/branches/cassandra-0.8] 1176204 Blamelist: jbellis BUILD FAILED: failed compile sincerely, -The Buildbot
buildbot success in ASF Buildbot on cassandra-1.0.0
The Buildbot has detected a restored build on builder cassandra-1.0.0 while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/cassandra-1.0.0/builds/7 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: isis_ubuntu Build Reason: scheduler Build Source Stamp: [branch cassandra/branches/cassandra-1.0.0] 1176207 Blamelist: jbellis Build succeeded! sincerely, -The Buildbot
