[jira] [Commented] (CASSANDRA-12728) Handling partially written hint files

[Harikrishnan (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15604272#comment-15604272
 ] 

Harikrishnan commented on CASSANDRA-12728:
--

Reproduced the same error in 3.9 also.Run nodetool drain in one node , 3 nodes 
went down with this error.

ERROR [HintsDispatcher:2] 2016-10-25 05:08:00,157 
HintsDispatchExecutor.java:225 - Failed to dispatch hints file 
49c3290a-fafd-456c-966e-8bcd1eab9af8-1477371781565-1.hints: file is corrupted 
({})
org.apache.cassandra.io.FSReadError: java.io.EOFException
at 
org.apache.cassandra.hints.HintsReader$BuffersIterator.computeNext(HintsReader.java:284)
 ~[apache-cassandra-3.9.jar:3.9]
at 
org.apache.cassandra.hints.HintsReader$BuffersIterator.computeNext(HintsReader.java:254)
 ~[apache-cassandra-3.9.jar:3.9]
at 
org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) 
~[apache-cassandra-3.9.jar:3.9]
at 
org.apache.cassandra.hints.HintsDispatcher.sendHints(HintsDispatcher.java:156) 
~[apache-cassandra-3.9.jar:3.9]
at 
org.apache.cassandra.hints.HintsDispatcher.sendHintsAndAwait(HintsDispatcher.java:137)
 ~[apache-cassandra-3.9.jar:3.9]
at 
org.apache.cassandra.hints.HintsDispatcher.dispatch(HintsDispatcher.java:119) 
~[apache-cassandra-3.9.jar:3.9]
at 
org.apache.cassandra.hints.HintsDispatcher.dispatch(HintsDispatcher.java:91) 
~[apache-cassandra-3.9.jar:3.9]
at 
org.apache.cassandra.hints.HintsDispatchExecutor$DispatchHintsTask.deliver(HintsDispatchExecutor.java:259)
 [apache-cassandra-3.9.jar:3.9]
at 
org.apache.cassandra.hints.HintsDispatchExecutor$DispatchHintsTask.dispatch(HintsDispatchExecutor.java:242)
 [apache-cassandra-3.9.jar:3.9]
at 
org.apache.cassandra.hints.HintsDispatchExecutor$DispatchHintsTask.dispatch(HintsDispatchExecutor.java:220)
 [apache-cassandra-3.9.jar:3.9]
at 
org.apache.cassandra.hints.HintsDispatchExecutor$DispatchHintsTask.run(HintsDispatchExecutor.java:199)
 [apache-cassandra-3.9.jar:3.9]
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
[na:1.8.0_102]
at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
[na:1.8.0_102]
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) 
[na:1.8.0_102]
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) 
[na:1.8.0_102]
at java.lang.Thread.run(Thread.java:745) [na:1.8.0_102]
Caused by: java.io.EOFException: null
at 
org.apache.cassandra.io.util.RebufferingInputStream.readByte(RebufferingInputStream.java:146)
 ~[apache-cassandra-3.9.jar:3.9]
at 
org.apache.cassandra.io.util.RebufferingInputStream.readPrimitiveSlowly(RebufferingInputStream.java:108)
 ~[apache-cassandra-3.9.jar:3.9]
at 
org.apache.cassandra.io.util.RebufferingInputStream.readInt(RebufferingInputStream.java:188)
 ~[apache-cassandra-3.9.jar:3.9]
at 
org.apache.cassandra.hints.HintsReader$BuffersIterator.computeNextInternal(HintsReader.java:297)
 ~[apache-cassandra-3.9.jar:3.9]
at 
org.apache.cassandra.hints.HintsReader$BuffersIterator.computeNext(HintsReader.java:280)
 ~[apache-cassandra-3.9.jar:3.9]
... 15 common frames omitted

> Handling partially written hint files
> -
>
> Key: CASSANDRA-12728
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12728
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Sharvanath Pathak
>Assignee: Aleksey Yeschenko
> Attachments: CASSANDRA-12728.patch
>
>
> {noformat}
> ERROR [HintsDispatcher:1] 2016-09-28 17:44:43,397 
> HintsDispatchExecutor.java:225 - Failed to dispatch hints file 
> d5d7257c-9f81-49b2-8633-6f9bda6e3dea-1474892654160-1.hints: file is corrupted 
> ({})
> org.apache.cassandra.io.FSReadError: java.io.EOFException
> at 
> org.apache.cassandra.hints.HintsReader$BuffersIterator.computeNext(HintsReader.java:282)
>  ~[apache-cassandra-3.0.6.jar:3.0.6]
> at 
> org.apache.cassandra.hints.HintsReader$BuffersIterator.computeNext(HintsReader.java:252)
>  ~[apache-cassandra-3.0.6.jar:3.0.6]
> at 
> org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) 
> ~[apache-cassandra-3.0.6.jar:3.0.6]
> at 
> org.apache.cassandra.hints.HintsDispatcher.sendHints(HintsDispatcher.java:156)
>  ~[apache-cassandra-3.0.6.jar:3.0.6]
> at 
> org.apache.cassandra.hints.HintsDispatcher.sendHintsAndAwait(HintsDispatcher.java:137)
>  ~[apache-cassandra-3.0.6.jar:3.0.6]
> at 
> org.apache.cassandra.hints.HintsDispatcher.dispatch(HintsDispatcher.java:119) 
> ~[apache-cassandra-3.0.6.jar:3.0.6]
> at 
> org.apache.cassandra.hints.HintsDispatcher.dispatch(HintsDispatcher.java:91) 
> ~[apache-cassandra-3.0.6.jar:3.0.6]
> at 
> 

[jira] [Commented] (CASSANDRA-12802) RecoveryManagerTruncateTest fails in 2.1

[Stefania (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15604267#comment-15604267
 ] 

Stefania commented on CASSANDRA-12802:
--

Noted, and if this is too risky then I suggest ignoring this test in 2.1. 
However, it is not just a test scenario, CASSANDRA-11743 could happen in 2.1 as 
well. The fix has been released in 2.2.7 and so far it has not caused problems 
that I know of, but let's hear [~blambov]'s opinion since I am still not that 
familiar with CL internals.

> RecoveryManagerTruncateTest fails in 2.1
> 
>
> Key: CASSANDRA-12802
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12802
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Stefania
>Assignee: Stefania
> Fix For: 2.1.x
>
>
> Example failure:
> http://cassci.datastax.com/view/cassandra-2.1/job/cassandra-2.1_testall/388/testReport/junit/org.apache.cassandra.db/RecoveryManagerTruncateTest/testTruncatePointInTime/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-11743) Race condition in CommitLog.recover can prevent startup

[Stefania (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefania updated CASSANDRA-11743:
-
Fix Version/s: (was: 3.0.x)
   (was: 2.2.x)
   (was: 3.x)
   2.2.7
   3.0.7
   3.7

> Race condition in CommitLog.recover can prevent startup
> ---
>
> Key: CASSANDRA-11743
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11743
> Project: Cassandra
>  Issue Type: Bug
>  Components: Lifecycle
>Reporter: Benjamin Lerer
>Assignee: Benjamin Lerer
> Fix For: 2.2.7, 3.0.7, 3.7
>
> Attachments: 11743-2.2.txt
>
>
> In {{CommitLog::recover}} the list of segments to recover from is determined 
> by removing the files managed by the {{CommitLogSegmentManager}} from the 
> list of files present in the commit log directory. Unfortunatly, due to the 
> way the creation of segments is done there is a time window where a segment 
> file has been created but has not been added yet to the list of segments 
> managed by the {{CommitLogSegmentManager}}. If the filtering ocurs during 
> that time window the Commit log might try to recover from that new segment 
> and crash.   



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12802) RecoveryManagerTruncateTest fails in 2.1

[Nate McCall (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15604120#comment-15604120
 ] 

Nate McCall commented on CASSANDRA-12802:
-

[~Stefania] I'm super nervous about changing the behavior of CL.recover in 2.1 
to address a (admittedly annoying) test scenario. 

> RecoveryManagerTruncateTest fails in 2.1
> 
>
> Key: CASSANDRA-12802
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12802
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Stefania
>Assignee: Stefania
> Fix For: 2.1.x
>
>
> Example failure:
> http://cassci.datastax.com/view/cassandra-2.1/job/cassandra-2.1_testall/388/testReport/junit/org.apache.cassandra.db/RecoveryManagerTruncateTest/testTruncatePointInTime/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12806) NullPointerException thrown in org.apache.cassandra.client.TestRingCache

[Lynch Lee (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lynch Lee updated CASSANDRA-12806:
--
Description: 
{panel:title=While I run testing org.apache.cassandra.client.TestRingCache in 
my Idea, I got this 
exception:|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1|bgColor=#CE}
 

{noformat} 
Exception in thread "main" java.lang.NullPointerException
at 
org.apache.cassandra.hadoop.ConfigHelper.setOutputKeyspace(ConfigHelper.java:119)
at 
org.apache.cassandra.hadoop.ConfigHelper.setOutputColumnFamily(ConfigHelper.java:142)
at 
org.apache.cassandra.client.TestRingCache.(TestRingCache.java:50)
at org.apache.cassandra.client.TestRingCache.main(TestRingCache.java:98)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at com.intellij.rt.execution.application.AppMain.main(AppMain.java:144)
{noformat} 
Code shown:
in Constructor of TestRingCache:
{noformat} 
ConfigHelper.setOutputColumnFamily(conf, keyspace, "Standard1");
{noformat} 
when varible conf haven't be initialized.

  was:
{panel:title=While I run testing org.apache.cassandra.client.TestRingCache in 
my Idea, I got this 
exception:|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1|bgColor=#CE}
 

{noformat} 
Exception in thread "main" java.lang.NullPointerException
at 
org.apache.cassandra.hadoop.ConfigHelper.setOutputKeyspace(ConfigHelper.java:119)
at 
org.apache.cassandra.hadoop.ConfigHelper.setOutputColumnFamily(ConfigHelper.java:142)
at 
org.apache.cassandra.client.TestRingCache.(TestRingCache.java:50)
at org.apache.cassandra.client.TestRingCache.main(TestRingCache.java:98)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at com.intellij.rt.execution.application.AppMain.main(AppMain.java:144)
{noformat} 
Code shown:
in Constructor of TestRingCache:
{noformat} 
ConfigHelper.setOutputColumnFamily(conf, keyspace, "Standard1");
{noformat} 
when varible conf haven't be initialized.

@[~jbellis]
*Could I create a pr to fix it into branch trunk ??*


> NullPointerException thrown in org.apache.cassandra.client.TestRingCache
> 
>
> Key: CASSANDRA-12806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12806
> Project: Cassandra
>  Issue Type: Bug
>  Components: Testing
>Reporter: Lynch Lee
> Fix For: 3.0.x
>
>
> {panel:title=While I run testing org.apache.cassandra.client.TestRingCache in 
> my Idea, I got this 
> exception:|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1|bgColor=#CE}
>  
> {noformat} 
> Exception in thread "main" java.lang.NullPointerException
>   at 
> org.apache.cassandra.hadoop.ConfigHelper.setOutputKeyspace(ConfigHelper.java:119)
>   at 
> org.apache.cassandra.hadoop.ConfigHelper.setOutputColumnFamily(ConfigHelper.java:142)
>   at 
> org.apache.cassandra.client.TestRingCache.(TestRingCache.java:50)
>   at org.apache.cassandra.client.TestRingCache.main(TestRingCache.java:98)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at com.intellij.rt.execution.application.AppMain.main(AppMain.java:144)
> {noformat} 
> Code shown:
> in Constructor of TestRingCache:
> {noformat} 
> ConfigHelper.setOutputColumnFamily(conf, keyspace, "Standard1");
> {noformat} 
> when varible conf haven't be initialized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12806) NullPointerException thrown in org.apache.cassandra.client.TestRingCache

[Lynch Lee (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15604053#comment-15604053
 ] 

Lynch Lee commented on CASSANDRA-12806:
---

@[~jbellis]
*Could we create a pr to fix it into branch trunk ??*

> NullPointerException thrown in org.apache.cassandra.client.TestRingCache
> 
>
> Key: CASSANDRA-12806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12806
> Project: Cassandra
>  Issue Type: Bug
>  Components: Testing
>Reporter: Lynch Lee
> Fix For: 3.0.x
>
>
> {panel:title=While I run testing org.apache.cassandra.client.TestRingCache in 
> my Idea, I got this 
> exception:|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1|bgColor=#CE}
>  
> {noformat} 
> Exception in thread "main" java.lang.NullPointerException
>   at 
> org.apache.cassandra.hadoop.ConfigHelper.setOutputKeyspace(ConfigHelper.java:119)
>   at 
> org.apache.cassandra.hadoop.ConfigHelper.setOutputColumnFamily(ConfigHelper.java:142)
>   at 
> org.apache.cassandra.client.TestRingCache.(TestRingCache.java:50)
>   at org.apache.cassandra.client.TestRingCache.main(TestRingCache.java:98)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at com.intellij.rt.execution.application.AppMain.main(AppMain.java:144)
> {noformat} 
> Code shown:
> in Constructor of TestRingCache:
> {noformat} 
> ConfigHelper.setOutputColumnFamily(conf, keyspace, "Standard1");
> {noformat} 
> when varible conf haven't be initialized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12802) RecoveryManagerTruncateTest fails in 2.1

[Stefania (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15604047#comment-15604047
 ] 

Stefania commented on CASSANDRA-12802:
--

Thanks for the feedback [~blambov]. Would you mind reviewing the full patch? 

It's basically CASSANDRA-11743 plus the hack:

|2.1|[patch|https://github.com/stef1927/cassandra/tree/12802-2.1]|[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-12802-2.1-testall/]|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-12802-2.1-dtest/]|

I then plan to do a {{merge -s ours}} into 2.2 and upwards.

I'm also multiplexing one more time with the final patch 
[here|http://cassci.datastax.com/job/stef1927-testall-multiplex-2/9/].


> RecoveryManagerTruncateTest fails in 2.1
> 
>
> Key: CASSANDRA-12802
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12802
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Stefania
>Assignee: Stefania
> Fix For: 2.1.x
>
>
> Example failure:
> http://cassci.datastax.com/view/cassandra-2.1/job/cassandra-2.1_testall/388/testReport/junit/org.apache.cassandra.db/RecoveryManagerTruncateTest/testTruncatePointInTime/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12802) RecoveryManagerTruncateTest fails in 2.1

[Stefania (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefania updated CASSANDRA-12802:
-
Status: Patch Available  (was: In Progress)

> RecoveryManagerTruncateTest fails in 2.1
> 
>
> Key: CASSANDRA-12802
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12802
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Stefania
>Assignee: Stefania
> Fix For: 2.1.x
>
>
> Example failure:
> http://cassci.datastax.com/view/cassandra-2.1/job/cassandra-2.1_testall/388/testReport/junit/org.apache.cassandra.db/RecoveryManagerTruncateTest/testTruncatePointInTime/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12815) cqlsh may throw AttributeError due to no table metadata

[Stefania (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefania updated CASSANDRA-12815:
-
Resolution: Fixed
Status: Resolved  (was: Patch Available)

Thank you for the review, committed to 3.X as 
13b7362494c4c0ff3c5ce80b8e7ee7fe64d65785 and merged into trunk.

> cqlsh may throw AttributeError due to no table metadata
> ---
>
> Key: CASSANDRA-12815
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12815
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tools
>Reporter: Stefania
>Assignee: Stefania
> Fix For: 3.10
>
>
> Since CASSANDRA-11534 there is a potential bug in this code:
> {code}
> if result.column_types:
> ks_meta = self.conn.metadata.keyspaces[table_meta.keyspace_name]
> cql_types = [CqlType(cql_typename(t), ks_meta) for t in 
> result.column_types]
> {code}
> It cannot be reproduced with any of our tests but there is a code path that 
> could cause {{table_meta}} to be {{None}} when the statement cannot be 
> parsed. Given that the code before 11534 used to check on {{table_meta}} not 
> being {{None}}, I prefer to put back the same check in order to avoid any 
> possible regressions once 3.10 is released. Also, since we check in all other 
> places, this helps with consistency too.
> The only reason we need the table metadata in that code block is to get the 
> keyspace name. We should fallback to the current keyspace name if we have no 
> table metadata.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[2/3] cassandra git commit: Avoid potential AttributeError in cqlsh due to no table metadata

[stefania]

Avoid potential AttributeError in cqlsh due to no table metadata

Patch by Stefania Alborghetti; reviewed by Robert Stupp for CASSANDRA-12815


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/13b73624
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/13b73624
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/13b73624

Branch: refs/heads/trunk
Commit: 13b7362494c4c0ff3c5ce80b8e7ee7fe64d65785
Parents: 3cb0233
Author: Stefania Alborghetti 
Authored: Thu Oct 20 10:06:50 2016 +0800
Committer: Stefania Alborghetti 
Committed: Tue Oct 25 10:03:21 2016 +0800

--
 CHANGES.txt  | 1 +
 bin/cqlsh.py | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/13b73624/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index d1f2677..ef728c7 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 3.10
+ * Avoid potential AttributeError in cqlsh due to no table metadata 
(CASSANDRA-12815)
  * Fix RandomReplicationAwareTokenAllocatorTest.testExistingCluster 
(CASSANDRA-12812)
  * Upgrade commons-codec to 1.9 (CASSANDRA-12790)
  * Make the fanout size for LeveledCompactionStrategy to be configurable 
(CASSANDRA-11550)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/13b73624/bin/cqlsh.py
--
diff --git a/bin/cqlsh.py b/bin/cqlsh.py
index e741752..072ef08 100644
--- a/bin/cqlsh.py
+++ b/bin/cqlsh.py
@@ -1334,7 +1334,8 @@ class Shell(cmd.Cmd):
 
 cql_types = []
 if result.column_types:
-ks_meta = self.conn.metadata.keyspaces[table_meta.keyspace_name]
+ks_name = table_meta.keyspace_name if table_meta else 
self.current_keyspace
+ks_meta = self.conn.metadata.keyspaces.get(ks_name, None)
 cql_types = [CqlType(cql_typename(t), ks_meta) for t in 
result.column_types]
 
 formatted_values = [map(self.myformat_value, row.values(), cql_types) 
for row in result.current_rows]

[3/3] cassandra git commit: Merge branch 'cassandra-3.X' into trunk

[stefania]

Merge branch 'cassandra-3.X' into trunk


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/9d4fd903
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/9d4fd903
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/9d4fd903

Branch: refs/heads/trunk
Commit: 9d4fd903fb1888cbbaca85d43458fda0b10dac22
Parents: b921ddf 13b7362
Author: Stefania Alborghetti 
Authored: Tue Oct 25 10:03:37 2016 +0800
Committer: Stefania Alborghetti 
Committed: Tue Oct 25 10:03:37 2016 +0800

--
 CHANGES.txt  | 1 +
 bin/cqlsh.py | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/9d4fd903/CHANGES.txt
--
diff --cc CHANGES.txt
index 8504e0b,ef728c7..7b2666d
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,17 -1,9 +1,18 @@@
 +4.0
 + * Add column definition kind to dropped columns in schema (CASSANDRA-12705)
 + * Add (automate) Nodetool Documentation (CASSANDRA-12672)
 + * Update bundled cqlsh python driver to 3.7.0 (CASSANDRA-12736)
 + * Reject invalid replication settings when creating or altering a keyspace 
(CASSANDRA-12681)
 + * Clean up the SSTableReader#getScanner API wrt removal of RateLimiter 
(CASSANDRA-12422)
 +Merged from 3.0:
 + * Include SSTable filename in compacting large row message (CASSANDRA-12384)
 +
  3.10
+  * Avoid potential AttributeError in cqlsh due to no table metadata 
(CASSANDRA-12815)
   * Fix RandomReplicationAwareTokenAllocatorTest.testExistingCluster 
(CASSANDRA-12812)
   * Upgrade commons-codec to 1.9 (CASSANDRA-12790)
 - * Make the fanout size for LeveledCompactionStrategy to be configurable 
(CASSANDRA-11550)
   * Add duration data type (CASSANDRA-11873)
 + * Make the fanout size for LeveledCompactionStrategy to be configurable 
(CASSANDRA-11550)
   * Fix timeout in ReplicationAwareTokenAllocatorTest (CASSANDRA-12784)
   * Improve sum aggregate functions (CASSANDRA-12417)
   * Make cassandra.yaml docs for batch_size_*_threshold_in_kb reflect changes 
in CASSANDRA-10876 (CASSANDRA-12761)

[1/3] cassandra git commit: Avoid potential AttributeError in cqlsh due to no table metadata

[stefania]

Repository: cassandra
Updated Branches:
  refs/heads/cassandra-3.X 3cb023355 -> 13b736249
  refs/heads/trunk b921ddf2f -> 9d4fd903f


Avoid potential AttributeError in cqlsh due to no table metadata

Patch by Stefania Alborghetti; reviewed by Robert Stupp for CASSANDRA-12815


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/13b73624
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/13b73624
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/13b73624

Branch: refs/heads/cassandra-3.X
Commit: 13b7362494c4c0ff3c5ce80b8e7ee7fe64d65785
Parents: 3cb0233
Author: Stefania Alborghetti 
Authored: Thu Oct 20 10:06:50 2016 +0800
Committer: Stefania Alborghetti 
Committed: Tue Oct 25 10:03:21 2016 +0800

--
 CHANGES.txt  | 1 +
 bin/cqlsh.py | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/13b73624/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index d1f2677..ef728c7 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 3.10
+ * Avoid potential AttributeError in cqlsh due to no table metadata 
(CASSANDRA-12815)
  * Fix RandomReplicationAwareTokenAllocatorTest.testExistingCluster 
(CASSANDRA-12812)
  * Upgrade commons-codec to 1.9 (CASSANDRA-12790)
  * Make the fanout size for LeveledCompactionStrategy to be configurable 
(CASSANDRA-11550)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/13b73624/bin/cqlsh.py
--
diff --git a/bin/cqlsh.py b/bin/cqlsh.py
index e741752..072ef08 100644
--- a/bin/cqlsh.py
+++ b/bin/cqlsh.py
@@ -1334,7 +1334,8 @@ class Shell(cmd.Cmd):
 
 cql_types = []
 if result.column_types:
-ks_meta = self.conn.metadata.keyspaces[table_meta.keyspace_name]
+ks_name = table_meta.keyspace_name if table_meta else 
self.current_keyspace
+ks_meta = self.conn.metadata.keyspaces.get(ks_name, None)
 cql_types = [CqlType(cql_typename(t), ks_meta) for t in 
result.column_types]
 
 formatted_values = [map(self.myformat_value, row.values(), cql_types) 
for row in result.current_rows]

[jira] [Updated] (CASSANDRA-12801) KeyCacheCqlTest fails on 3.0, 3.X and trunk

[Stefania (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefania updated CASSANDRA-12801:
-
   Resolution: Fixed
Fix Version/s: (was: 3.0.x)
   (was: 3.x)
   3.10
   3.0.10
   Status: Resolved  (was: Ready to Commit)

Thank you for the review, committed to 3.0 as 
c0886d87728a0f0a73b20edcd39373fa1458aba0 and merged upwards.

> KeyCacheCqlTest fails on 3.0, 3.X and trunk
> ---
>
> Key: CASSANDRA-12801
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12801
> Project: Cassandra
>  Issue Type: Bug
>  Components: Testing
>Reporter: Stefania
>Assignee: Stefania
> Fix For: 3.0.10, 3.10
>
>
> Sample failures:
> http://cassci.datastax.com/view/trunk/job/trunk_testall/1213/testReport/junit/org.apache.cassandra.cql3/KeyCacheCqlTest/testKeyCacheClusteredShallowIndexEntry/
> http://cassci.datastax.com/view/cassandra-3.X/job/cassandra-3.X_testall/31/testReport/junit/org.apache.cassandra.cql3/KeyCacheCqlTest/test2iKeyCachePathsIndexInfoOnHeap/
> https://cassci.datastax.com/view/cassandra-3.0/job/cassandra-3.0_testall/704/testReport/org.apache.cassandra.cql3/KeyCacheCqlTest/test2iKeyCachePaths_compression/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12801) KeyCacheCqlTest fails on 3.0, 3.X and trunk

[Stefania (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefania updated CASSANDRA-12801:
-
Component/s: Testing

> KeyCacheCqlTest fails on 3.0, 3.X and trunk
> ---
>
> Key: CASSANDRA-12801
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12801
> Project: Cassandra
>  Issue Type: Bug
>  Components: Testing
>Reporter: Stefania
>Assignee: Stefania
> Fix For: 3.0.10, 3.10
>
>
> Sample failures:
> http://cassci.datastax.com/view/trunk/job/trunk_testall/1213/testReport/junit/org.apache.cassandra.cql3/KeyCacheCqlTest/testKeyCacheClusteredShallowIndexEntry/
> http://cassci.datastax.com/view/cassandra-3.X/job/cassandra-3.X_testall/31/testReport/junit/org.apache.cassandra.cql3/KeyCacheCqlTest/test2iKeyCachePathsIndexInfoOnHeap/
> https://cassci.datastax.com/view/cassandra-3.0/job/cassandra-3.0_testall/704/testReport/org.apache.cassandra.cql3/KeyCacheCqlTest/test2iKeyCachePaths_compression/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[1/6] cassandra git commit: Fix for KeyCacheCqlTest flakiness

[stefania]

Repository: cassandra
Updated Branches:
  refs/heads/cassandra-3.0 ee85507c2 -> c0886d877
  refs/heads/cassandra-3.X 94a01f62a -> 3cb023355
  refs/heads/trunk fc3b9bfd7 -> b921ddf2f


Fix for KeyCacheCqlTest flakiness

patch by Stefania Alborghetti; reviewed by Robert Stupp for CASSANDRA-12801


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/c0886d87
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/c0886d87
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/c0886d87

Branch: refs/heads/cassandra-3.0
Commit: c0886d87728a0f0a73b20edcd39373fa1458aba0
Parents: ee85507
Author: Stefania Alborghetti 
Authored: Tue Oct 18 12:11:25 2016 +0800
Committer: Stefania Alborghetti 
Committed: Tue Oct 25 09:53:47 2016 +0800

--
 CHANGES.txt |  1 +
 .../apache/cassandra/schema/CachingParams.java  |  4 +-
 .../org/apache/cassandra/cql3/CQLTester.java| 41 ---
 .../apache/cassandra/cql3/KeyCacheCqlTest.java  | 76 
 4 files changed, 98 insertions(+), 24 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/c0886d87/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 6d38f83..9910245 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 3.0.10
+ * Fix for KeyCacheCqlTest flakiness (CASSANDRA-12801)
  * Include SSTable filename in compacting large row message (CASSANDRA-12384)
  * Fix potential socket leak (CASSANDRA-12329, CASSANDRA-12330)
  * Fix ViewTest.testCompaction (CASSANDRA-12789)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/c0886d87/src/java/org/apache/cassandra/schema/CachingParams.java
--
diff --git a/src/java/org/apache/cassandra/schema/CachingParams.java 
b/src/java/org/apache/cassandra/schema/CachingParams.java
index 2b5ab7c..1976835 100644
--- a/src/java/org/apache/cassandra/schema/CachingParams.java
+++ b/src/java/org/apache/cassandra/schema/CachingParams.java
@@ -20,6 +20,7 @@ package org.apache.cassandra.schema;
 import java.util.HashMap;
 import java.util.Map;
 
+import com.google.common.annotations.VisibleForTesting;
 import com.google.common.base.Objects;
 import com.google.common.collect.ImmutableMap;
 import org.apache.commons.lang3.StringUtils;
@@ -53,7 +54,8 @@ public final class CachingParams
 public static final CachingParams CACHE_KEYS = new CachingParams(true, 0);
 public static final CachingParams CACHE_EVERYTHING = new 
CachingParams(true, Integer.MAX_VALUE);
 
-static final CachingParams DEFAULT = new CachingParams(DEFAULT_CACHE_KEYS, 
DEFAULT_ROWS_PER_PARTITION_TO_CACHE);
+@VisibleForTesting
+public static CachingParams DEFAULT = new 
CachingParams(DEFAULT_CACHE_KEYS, DEFAULT_ROWS_PER_PARTITION_TO_CACHE);
 
 final boolean cacheKeys;
 final int rowsPerPartitionToCache;

http://git-wip-us.apache.org/repos/asf/cassandra/blob/c0886d87/test/unit/org/apache/cassandra/cql3/CQLTester.java
--
diff --git a/test/unit/org/apache/cassandra/cql3/CQLTester.java 
b/test/unit/org/apache/cassandra/cql3/CQLTester.java
index 7f5eb02..3d45393 100644
--- a/test/unit/org/apache/cassandra/cql3/CQLTester.java
+++ b/test/unit/org/apache/cassandra/cql3/CQLTester.java
@@ -543,8 +543,13 @@ public abstract class CQLTester
 
 protected String createTable(String query)
 {
+return createTable(KEYSPACE, query);
+}
+
+protected String createTable(String keyspace, String query)
+{
 String currentTable = createTableName();
-String fullQuery = formatQuery(query);
+String fullQuery = formatQuery(keyspace, query);
 logger.info(fullQuery);
 schemaChange(fullQuery);
 return currentTable;
@@ -581,16 +586,24 @@ public abstract class CQLTester
 
 protected void dropTable(String query)
 {
-String fullQuery = String.format(query, KEYSPACE + "." + 
currentTable());
-logger.info(fullQuery);
-schemaChange(fullQuery);
+dropFormattedTable(String.format(query, KEYSPACE + "." + 
currentTable()));
+}
+
+protected void dropFormattedTable(String formattedQuery)
+{
+logger.info(formattedQuery);
+schemaChange(formattedQuery);
 }
 
 protected void createIndex(String query)
 {
-String fullQuery = formatQuery(query);
-logger.info(fullQuery);
-schemaChange(fullQuery);
+createFormattedIndex(formatQuery(query));
+}
+
+protected void createFormattedIndex(String formattedQuery)
+{
+logger.info(formattedQuery);
+

[4/6] cassandra git commit: Merge branch 'cassandra-3.0' into cassandra-3.X

[stefania]

Merge branch 'cassandra-3.0' into cassandra-3.X


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/3cb02335
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/3cb02335
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/3cb02335

Branch: refs/heads/trunk
Commit: 3cb023355a3bf039725a55ad3ecdc3f9ce880997
Parents: 94a01f6 c0886d8
Author: Stefania Alborghetti 
Authored: Tue Oct 25 09:55:40 2016 +0800
Committer: Stefania Alborghetti 
Committed: Tue Oct 25 09:56:21 2016 +0800

--
 CHANGES.txt |  1 +
 .../apache/cassandra/schema/CachingParams.java  |  4 +-
 .../org/apache/cassandra/cql3/CQLTester.java| 20 --
 .../apache/cassandra/cql3/KeyCacheCqlTest.java  | 76 
 4 files changed, 81 insertions(+), 20 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/3cb02335/CHANGES.txt
--
diff --cc CHANGES.txt
index aa49a68,9910245..d1f2677
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,93 -1,5 +1,94 @@@
 -3.0.10
 +3.10
 + * Fix RandomReplicationAwareTokenAllocatorTest.testExistingCluster 
(CASSANDRA-12812)
 + * Upgrade commons-codec to 1.9 (CASSANDRA-12790)
 + * Make the fanout size for LeveledCompactionStrategy to be configurable 
(CASSANDRA-11550)
 + * Add duration data type (CASSANDRA-11873)
 + * Fix timeout in ReplicationAwareTokenAllocatorTest (CASSANDRA-12784)
 + * Improve sum aggregate functions (CASSANDRA-12417)
 + * Make cassandra.yaml docs for batch_size_*_threshold_in_kb reflect changes 
in CASSANDRA-10876 (CASSANDRA-12761)
 + * cqlsh fails to format collections when using aliases (CASSANDRA-11534)
 + * Check for hash conflicts in prepared statements (CASSANDRA-12733)
 + * Exit query parsing upon first error (CASSANDRA-12598)
 + * Fix cassandra-stress to use single seed in UUID generation 
(CASSANDRA-12729)
 + * CQLSSTableWriter does not allow Update statement (CASSANDRA-12450)
 + * Config class uses boxed types but DD exposes primitive types 
(CASSANDRA-12199)
 + * Add pre- and post-shutdown hooks to Storage Service (CASSANDRA-12461)
 + * Add hint delivery metrics (CASSANDRA-12693)
 + * Remove IndexInfo cache from FileIndexInfoRetriever (CASSANDRA-12731)
 + * ColumnIndex does not reuse buffer (CASSANDRA-12502)
 + * cdc column addition still breaks schema migration tasks (CASSANDRA-12697)
 + * Upgrade metrics-reporter dependencies (CASSANDRA-12089)
 + * Tune compaction thread count via nodetool (CASSANDRA-12248)
 + * Add +=/-= shortcut syntax for update queries (CASSANDRA-12232)
 + * Include repair session IDs in repair start message (CASSANDRA-12532)
 + * Add a blocking task to Index, run before joining the ring (CASSANDRA-12039)
 + * Fix NPE when using CQLSSTableWriter (CASSANDRA-12667)
 + * Support optional backpressure strategies at the coordinator 
(CASSANDRA-9318)
 + * Make randompartitioner work with new vnode allocation (CASSANDRA-12647)
 + * Fix cassandra-stress graphing (CASSANDRA-12237)
 + * Allow filtering on partition key columns for queries without secondary 
indexes (CASSANDRA-11031)
 + * Fix Cassandra Stress reporting thread model and precision (CASSANDRA-12585)
 + * Add JMH benchmarks.jar (CASSANDRA-12586)
 + * Add row offset support to SASI (CASSANDRA-11990)
 + * Cleanup uses of AlterTableStatementColumn (CASSANDRA-12567)
 + * Add keep-alive to streaming (CASSANDRA-11841)
 + * Tracing payload is passed through newSession(..) (CASSANDRA-11706)
 + * avoid deleting non existing sstable files and improve related log messages 
(CASSANDRA-12261)
 + * json/yaml output format for nodetool compactionhistory (CASSANDRA-12486)
 + * Retry all internode messages once after a connection is
 +   closed and reopened (CASSANDRA-12192)
 + * Add support to rebuild from targeted replica (CASSANDRA-9875)
 + * Add sequence distribution type to cassandra stress (CASSANDRA-12490)
 + * "SELECT * FROM foo LIMIT ;" does not error out (CASSANDRA-12154)
 + * Define executeLocally() at the ReadQuery Level (CASSANDRA-12474)
 + * Extend read/write failure messages with a map of replica addresses
 +   to error codes in the v5 native protocol (CASSANDRA-12311)
 + * Fix rebuild of SASI indexes with existing index files (CASSANDRA-12374)
 + * Let DatabaseDescriptor not implicitly startup services (CASSANDRA-9054, 
12550)
 + * Fix clustering indexes in presence of static columns in SASI 
(CASSANDRA-12378)
 + * Fix queries on columns with reversed type on SASI indexes (CASSANDRA-12223)
 + * Added slow query log (CASSANDRA-12403)
 + * Count full coordinated request against timeout (CASSANDRA-12256)
 + * Allow TTL with null value on insert and update (CASSANDRA-12216)
 + * Make decommission 

[3/6] cassandra git commit: Fix for KeyCacheCqlTest flakiness

[stefania]

Fix for KeyCacheCqlTest flakiness

patch by Stefania Alborghetti; reviewed by Robert Stupp for CASSANDRA-12801


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/c0886d87
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/c0886d87
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/c0886d87

Branch: refs/heads/trunk
Commit: c0886d87728a0f0a73b20edcd39373fa1458aba0
Parents: ee85507
Author: Stefania Alborghetti 
Authored: Tue Oct 18 12:11:25 2016 +0800
Committer: Stefania Alborghetti 
Committed: Tue Oct 25 09:53:47 2016 +0800

--
 CHANGES.txt |  1 +
 .../apache/cassandra/schema/CachingParams.java  |  4 +-
 .../org/apache/cassandra/cql3/CQLTester.java| 41 ---
 .../apache/cassandra/cql3/KeyCacheCqlTest.java  | 76 
 4 files changed, 98 insertions(+), 24 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/c0886d87/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 6d38f83..9910245 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 3.0.10
+ * Fix for KeyCacheCqlTest flakiness (CASSANDRA-12801)
  * Include SSTable filename in compacting large row message (CASSANDRA-12384)
  * Fix potential socket leak (CASSANDRA-12329, CASSANDRA-12330)
  * Fix ViewTest.testCompaction (CASSANDRA-12789)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/c0886d87/src/java/org/apache/cassandra/schema/CachingParams.java
--
diff --git a/src/java/org/apache/cassandra/schema/CachingParams.java 
b/src/java/org/apache/cassandra/schema/CachingParams.java
index 2b5ab7c..1976835 100644
--- a/src/java/org/apache/cassandra/schema/CachingParams.java
+++ b/src/java/org/apache/cassandra/schema/CachingParams.java
@@ -20,6 +20,7 @@ package org.apache.cassandra.schema;
 import java.util.HashMap;
 import java.util.Map;
 
+import com.google.common.annotations.VisibleForTesting;
 import com.google.common.base.Objects;
 import com.google.common.collect.ImmutableMap;
 import org.apache.commons.lang3.StringUtils;
@@ -53,7 +54,8 @@ public final class CachingParams
 public static final CachingParams CACHE_KEYS = new CachingParams(true, 0);
 public static final CachingParams CACHE_EVERYTHING = new 
CachingParams(true, Integer.MAX_VALUE);
 
-static final CachingParams DEFAULT = new CachingParams(DEFAULT_CACHE_KEYS, 
DEFAULT_ROWS_PER_PARTITION_TO_CACHE);
+@VisibleForTesting
+public static CachingParams DEFAULT = new 
CachingParams(DEFAULT_CACHE_KEYS, DEFAULT_ROWS_PER_PARTITION_TO_CACHE);
 
 final boolean cacheKeys;
 final int rowsPerPartitionToCache;

http://git-wip-us.apache.org/repos/asf/cassandra/blob/c0886d87/test/unit/org/apache/cassandra/cql3/CQLTester.java
--
diff --git a/test/unit/org/apache/cassandra/cql3/CQLTester.java 
b/test/unit/org/apache/cassandra/cql3/CQLTester.java
index 7f5eb02..3d45393 100644
--- a/test/unit/org/apache/cassandra/cql3/CQLTester.java
+++ b/test/unit/org/apache/cassandra/cql3/CQLTester.java
@@ -543,8 +543,13 @@ public abstract class CQLTester
 
 protected String createTable(String query)
 {
+return createTable(KEYSPACE, query);
+}
+
+protected String createTable(String keyspace, String query)
+{
 String currentTable = createTableName();
-String fullQuery = formatQuery(query);
+String fullQuery = formatQuery(keyspace, query);
 logger.info(fullQuery);
 schemaChange(fullQuery);
 return currentTable;
@@ -581,16 +586,24 @@ public abstract class CQLTester
 
 protected void dropTable(String query)
 {
-String fullQuery = String.format(query, KEYSPACE + "." + 
currentTable());
-logger.info(fullQuery);
-schemaChange(fullQuery);
+dropFormattedTable(String.format(query, KEYSPACE + "." + 
currentTable()));
+}
+
+protected void dropFormattedTable(String formattedQuery)
+{
+logger.info(formattedQuery);
+schemaChange(formattedQuery);
 }
 
 protected void createIndex(String query)
 {
-String fullQuery = formatQuery(query);
-logger.info(fullQuery);
-schemaChange(fullQuery);
+createFormattedIndex(formatQuery(query));
+}
+
+protected void createFormattedIndex(String formattedQuery)
+{
+logger.info(formattedQuery);
+schemaChange(formattedQuery);
 }
 
 /**
@@ -694,16 +707,24 @@ public abstract class CQLTester
 return sessions.get(protocolVersion);
 }
 
-private String 

[2/6] cassandra git commit: Fix for KeyCacheCqlTest flakiness

[stefania]

Fix for KeyCacheCqlTest flakiness

patch by Stefania Alborghetti; reviewed by Robert Stupp for CASSANDRA-12801


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/c0886d87
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/c0886d87
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/c0886d87

Branch: refs/heads/cassandra-3.X
Commit: c0886d87728a0f0a73b20edcd39373fa1458aba0
Parents: ee85507
Author: Stefania Alborghetti 
Authored: Tue Oct 18 12:11:25 2016 +0800
Committer: Stefania Alborghetti 
Committed: Tue Oct 25 09:53:47 2016 +0800

--
 CHANGES.txt |  1 +
 .../apache/cassandra/schema/CachingParams.java  |  4 +-
 .../org/apache/cassandra/cql3/CQLTester.java| 41 ---
 .../apache/cassandra/cql3/KeyCacheCqlTest.java  | 76 
 4 files changed, 98 insertions(+), 24 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/c0886d87/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 6d38f83..9910245 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 3.0.10
+ * Fix for KeyCacheCqlTest flakiness (CASSANDRA-12801)
  * Include SSTable filename in compacting large row message (CASSANDRA-12384)
  * Fix potential socket leak (CASSANDRA-12329, CASSANDRA-12330)
  * Fix ViewTest.testCompaction (CASSANDRA-12789)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/c0886d87/src/java/org/apache/cassandra/schema/CachingParams.java
--
diff --git a/src/java/org/apache/cassandra/schema/CachingParams.java 
b/src/java/org/apache/cassandra/schema/CachingParams.java
index 2b5ab7c..1976835 100644
--- a/src/java/org/apache/cassandra/schema/CachingParams.java
+++ b/src/java/org/apache/cassandra/schema/CachingParams.java
@@ -20,6 +20,7 @@ package org.apache.cassandra.schema;
 import java.util.HashMap;
 import java.util.Map;
 
+import com.google.common.annotations.VisibleForTesting;
 import com.google.common.base.Objects;
 import com.google.common.collect.ImmutableMap;
 import org.apache.commons.lang3.StringUtils;
@@ -53,7 +54,8 @@ public final class CachingParams
 public static final CachingParams CACHE_KEYS = new CachingParams(true, 0);
 public static final CachingParams CACHE_EVERYTHING = new 
CachingParams(true, Integer.MAX_VALUE);
 
-static final CachingParams DEFAULT = new CachingParams(DEFAULT_CACHE_KEYS, 
DEFAULT_ROWS_PER_PARTITION_TO_CACHE);
+@VisibleForTesting
+public static CachingParams DEFAULT = new 
CachingParams(DEFAULT_CACHE_KEYS, DEFAULT_ROWS_PER_PARTITION_TO_CACHE);
 
 final boolean cacheKeys;
 final int rowsPerPartitionToCache;

http://git-wip-us.apache.org/repos/asf/cassandra/blob/c0886d87/test/unit/org/apache/cassandra/cql3/CQLTester.java
--
diff --git a/test/unit/org/apache/cassandra/cql3/CQLTester.java 
b/test/unit/org/apache/cassandra/cql3/CQLTester.java
index 7f5eb02..3d45393 100644
--- a/test/unit/org/apache/cassandra/cql3/CQLTester.java
+++ b/test/unit/org/apache/cassandra/cql3/CQLTester.java
@@ -543,8 +543,13 @@ public abstract class CQLTester
 
 protected String createTable(String query)
 {
+return createTable(KEYSPACE, query);
+}
+
+protected String createTable(String keyspace, String query)
+{
 String currentTable = createTableName();
-String fullQuery = formatQuery(query);
+String fullQuery = formatQuery(keyspace, query);
 logger.info(fullQuery);
 schemaChange(fullQuery);
 return currentTable;
@@ -581,16 +586,24 @@ public abstract class CQLTester
 
 protected void dropTable(String query)
 {
-String fullQuery = String.format(query, KEYSPACE + "." + 
currentTable());
-logger.info(fullQuery);
-schemaChange(fullQuery);
+dropFormattedTable(String.format(query, KEYSPACE + "." + 
currentTable()));
+}
+
+protected void dropFormattedTable(String formattedQuery)
+{
+logger.info(formattedQuery);
+schemaChange(formattedQuery);
 }
 
 protected void createIndex(String query)
 {
-String fullQuery = formatQuery(query);
-logger.info(fullQuery);
-schemaChange(fullQuery);
+createFormattedIndex(formatQuery(query));
+}
+
+protected void createFormattedIndex(String formattedQuery)
+{
+logger.info(formattedQuery);
+schemaChange(formattedQuery);
 }
 
 /**
@@ -694,16 +707,24 @@ public abstract class CQLTester
 return sessions.get(protocolVersion);
 }
 
-private String 

[6/6] cassandra git commit: Merge branch 'cassandra-3.X' into trunk

[stefania]

Merge branch 'cassandra-3.X' into trunk


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/b921ddf2
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/b921ddf2
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/b921ddf2

Branch: refs/heads/trunk
Commit: b921ddf2fc44bc446f932195c433d87ea7179983
Parents: fc3b9bf 3cb0233
Author: Stefania Alborghetti 
Authored: Tue Oct 25 09:57:48 2016 +0800
Committer: Stefania Alborghetti 
Committed: Tue Oct 25 09:57:48 2016 +0800

--
 CHANGES.txt |  1 +
 .../apache/cassandra/schema/CachingParams.java  |  4 +-
 .../org/apache/cassandra/cql3/CQLTester.java| 20 --
 .../apache/cassandra/cql3/KeyCacheCqlTest.java  | 76 
 4 files changed, 81 insertions(+), 20 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/b921ddf2/CHANGES.txt
--
diff --cc CHANGES.txt
index 2405f48,d1f2677..8504e0b
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -95,8 -86,9 +95,9 @@@ Merged from 3.0
   * Remove pre-startup check for open JMX port (CASSANDRA-12074)
   * Remove compaction Severity from DynamicEndpointSnitch (CASSANDRA-11738)
   * Restore resumable hints delivery (CASSANDRA-11960)
 - * Properly report LWT contention (CASSANDRA-12626)
 + * Properly record CAS contention (CASSANDRA-12626)
  Merged from 3.0:
+  * Fix for KeyCacheCqlTest flakiness (CASSANDRA-12801)
   * Include SSTable filename in compacting large row message (CASSANDRA-12384)
   * Fix potential socket leak (CASSANDRA-12329, CASSANDRA-12330)
   * Fix ViewTest.testCompaction (CASSANDRA-12789)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/b921ddf2/test/unit/org/apache/cassandra/cql3/CQLTester.java
--

[5/6] cassandra git commit: Merge branch 'cassandra-3.0' into cassandra-3.X

[stefania]

Merge branch 'cassandra-3.0' into cassandra-3.X


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/3cb02335
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/3cb02335
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/3cb02335

Branch: refs/heads/cassandra-3.X
Commit: 3cb023355a3bf039725a55ad3ecdc3f9ce880997
Parents: 94a01f6 c0886d8
Author: Stefania Alborghetti 
Authored: Tue Oct 25 09:55:40 2016 +0800
Committer: Stefania Alborghetti 
Committed: Tue Oct 25 09:56:21 2016 +0800

--
 CHANGES.txt |  1 +
 .../apache/cassandra/schema/CachingParams.java  |  4 +-
 .../org/apache/cassandra/cql3/CQLTester.java| 20 --
 .../apache/cassandra/cql3/KeyCacheCqlTest.java  | 76 
 4 files changed, 81 insertions(+), 20 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/3cb02335/CHANGES.txt
--
diff --cc CHANGES.txt
index aa49a68,9910245..d1f2677
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,93 -1,5 +1,94 @@@
 -3.0.10
 +3.10
 + * Fix RandomReplicationAwareTokenAllocatorTest.testExistingCluster 
(CASSANDRA-12812)
 + * Upgrade commons-codec to 1.9 (CASSANDRA-12790)
 + * Make the fanout size for LeveledCompactionStrategy to be configurable 
(CASSANDRA-11550)
 + * Add duration data type (CASSANDRA-11873)
 + * Fix timeout in ReplicationAwareTokenAllocatorTest (CASSANDRA-12784)
 + * Improve sum aggregate functions (CASSANDRA-12417)
 + * Make cassandra.yaml docs for batch_size_*_threshold_in_kb reflect changes 
in CASSANDRA-10876 (CASSANDRA-12761)
 + * cqlsh fails to format collections when using aliases (CASSANDRA-11534)
 + * Check for hash conflicts in prepared statements (CASSANDRA-12733)
 + * Exit query parsing upon first error (CASSANDRA-12598)
 + * Fix cassandra-stress to use single seed in UUID generation 
(CASSANDRA-12729)
 + * CQLSSTableWriter does not allow Update statement (CASSANDRA-12450)
 + * Config class uses boxed types but DD exposes primitive types 
(CASSANDRA-12199)
 + * Add pre- and post-shutdown hooks to Storage Service (CASSANDRA-12461)
 + * Add hint delivery metrics (CASSANDRA-12693)
 + * Remove IndexInfo cache from FileIndexInfoRetriever (CASSANDRA-12731)
 + * ColumnIndex does not reuse buffer (CASSANDRA-12502)
 + * cdc column addition still breaks schema migration tasks (CASSANDRA-12697)
 + * Upgrade metrics-reporter dependencies (CASSANDRA-12089)
 + * Tune compaction thread count via nodetool (CASSANDRA-12248)
 + * Add +=/-= shortcut syntax for update queries (CASSANDRA-12232)
 + * Include repair session IDs in repair start message (CASSANDRA-12532)
 + * Add a blocking task to Index, run before joining the ring (CASSANDRA-12039)
 + * Fix NPE when using CQLSSTableWriter (CASSANDRA-12667)
 + * Support optional backpressure strategies at the coordinator 
(CASSANDRA-9318)
 + * Make randompartitioner work with new vnode allocation (CASSANDRA-12647)
 + * Fix cassandra-stress graphing (CASSANDRA-12237)
 + * Allow filtering on partition key columns for queries without secondary 
indexes (CASSANDRA-11031)
 + * Fix Cassandra Stress reporting thread model and precision (CASSANDRA-12585)
 + * Add JMH benchmarks.jar (CASSANDRA-12586)
 + * Add row offset support to SASI (CASSANDRA-11990)
 + * Cleanup uses of AlterTableStatementColumn (CASSANDRA-12567)
 + * Add keep-alive to streaming (CASSANDRA-11841)
 + * Tracing payload is passed through newSession(..) (CASSANDRA-11706)
 + * avoid deleting non existing sstable files and improve related log messages 
(CASSANDRA-12261)
 + * json/yaml output format for nodetool compactionhistory (CASSANDRA-12486)
 + * Retry all internode messages once after a connection is
 +   closed and reopened (CASSANDRA-12192)
 + * Add support to rebuild from targeted replica (CASSANDRA-9875)
 + * Add sequence distribution type to cassandra stress (CASSANDRA-12490)
 + * "SELECT * FROM foo LIMIT ;" does not error out (CASSANDRA-12154)
 + * Define executeLocally() at the ReadQuery Level (CASSANDRA-12474)
 + * Extend read/write failure messages with a map of replica addresses
 +   to error codes in the v5 native protocol (CASSANDRA-12311)
 + * Fix rebuild of SASI indexes with existing index files (CASSANDRA-12374)
 + * Let DatabaseDescriptor not implicitly startup services (CASSANDRA-9054, 
12550)
 + * Fix clustering indexes in presence of static columns in SASI 
(CASSANDRA-12378)
 + * Fix queries on columns with reversed type on SASI indexes (CASSANDRA-12223)
 + * Added slow query log (CASSANDRA-12403)
 + * Count full coordinated request against timeout (CASSANDRA-12256)
 + * Allow TTL with null value on insert and update (CASSANDRA-12216)
 + * Make 

[jira] [Updated] (CASSANDRA-12754) Change cassandra.wait_for_tracing_events_timeout_secs default to -1 so C* doesn't wait on trace events to be written before responding to request by default

[Stefania (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefania updated CASSANDRA-12754:
-
   Resolution: Fixed
Fix Version/s: (was: 3.0.x)
   (was: 2.2.x)
   (was: 3.x)
   3.10
   3.0.10
   2.2.9
Reproduced In: 3.0.9, 2.2.8  (was: 2.2.8, 3.0.9)
   Status: Resolved  (was: Ready to Commit)

Thank you for the review, committed to 2.2 as 
2122ff88fe8f5cec5985570b71437e782b580715 and merged upwards.

> Change cassandra.wait_for_tracing_events_timeout_secs default to -1 so C* 
> doesn't wait on trace events to be written before responding to request by 
> default
> 
>
> Key: CASSANDRA-12754
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12754
> Project: Cassandra
>  Issue Type: Bug
>  Components: Observability
>Reporter: Andy Tolbert
>Assignee: Stefania
> Fix For: 2.2.9, 3.0.10, 3.10
>
>
> [CASSANDRA-11465] introduces a new system property 
> {{cassandra.wait_for_tracing_events_timeout_secs}} that controls whether or 
> not C* waits for events to be written before responding to client.   The 
> current default behavior is to wait up to 1 second and then respond and 
> timeout.  
> If using probabilistic tracing this can cause queries to be randomly delayed 
> up to 1 second.
> Changing the default to -1 (disabled and enabling it explicitly in 
> {{cql_tracing_test.TestCqlTracing.tracing_unknown_impl_test}}.
> Ideally it would be nice to be able to control this behavior on a per request 
> basis (which would require native protocol changes).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[06/10] cassandra git commit: Merge branch 'cassandra-2.2' into cassandra-3.0

[stefania]

Merge branch 'cassandra-2.2' into cassandra-3.0


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/ee85507c
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/ee85507c
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/ee85507c

Branch: refs/heads/cassandra-3.0
Commit: ee85507c2634261c77b188ee153f141b6dc511a0
Parents: 5883e43 2122ff8
Author: Stefania Alborghetti 
Authored: Tue Oct 25 09:42:46 2016 +0800
Committer: Stefania Alborghetti 
Committed: Tue Oct 25 09:42:46 2016 +0800

--
 CHANGES.txt   | 1 +
 src/java/org/apache/cassandra/tracing/TraceState.java | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/ee85507c/CHANGES.txt
--
diff --cc CHANGES.txt
index 46f27a6,a22439b..6d38f83
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,29 -1,5 +1,30 @@@
 -2.2.9
 +3.0.10
 + * Include SSTable filename in compacting large row message (CASSANDRA-12384)
 + * Fix potential socket leak (CASSANDRA-12329, CASSANDRA-12330)
 + * Fix ViewTest.testCompaction (CASSANDRA-12789)
 + * Improve avg aggregate functions (CASSANDRA-12417)
 + * Preserve quoted reserved keyword column names in MV creation 
(CASSANDRA-11803)
 + * nodetool stopdaemon errors out (CASSANDRA-12646)
 + * Split materialized view mutations on build to prevent OOM (CASSANDRA-12268)
 + * mx4j does not work in 3.0.8 (CASSANDRA-12274)
 + * Abort cqlsh copy-from in case of no answer after prolonged period of time 
(CASSANDRA-12740)
 + * Avoid sstable corrupt exception due to dropped static column 
(CASSANDRA-12582)
 + * Make stress use client mode to avoid checking commit log size on startup 
(CASSANDRA-12478)
 + * Fix exceptions with new vnode allocation (CASSANDRA-12715)
 + * Unify drain and shutdown processes (CASSANDRA-12509)
 + * Fix NPE in ComponentOfSlice.isEQ() (CASSANDRA-12706)
 + * Fix failure in LogTransactionTest (CASSANDRA-12632)
 + * Fix potentially incomplete non-frozen UDT values when querying with the
 +   full primary key specified (CASSANDRA-12605)
 + * Skip writing MV mutations to commitlog on mutation.applyUnsafe() 
(CASSANDRA-11670)
 + * Establish consistent distinction between non-existing partition and NULL 
value for LWTs on static columns (CASSANDRA-12060)
 + * Extend ColumnIdentifier.internedInstances key to include the type that 
generated the byte buffer (CASSANDRA-12516)
 + * Backport CASSANDRA-10756 (race condition in NativeTransportService 
shutdown) (CASSANDRA-12472)
 + * If CF has no clustering columns, any row cache is full partition cache 
(CASSANDRA-12499)
 + * Correct log message for statistics of offheap memtable flush 
(CASSANDRA-12776)
 + * Explicitly set locale for string validation 
(CASSANDRA-12541,CASSANDRA-12542,CASSANDRA-12543,CASSANDRA-12545)
 +Merged from 2.2:
+  * Change cassandra.wait_for_tracing_events_timeout_secs default to 0 
(CASSANDRA-12754)
   * Clean up permissions when a UDA is dropped (CASSANDRA-12720)
   * Limit colUpdateTimeDelta histogram updates to reasonable deltas 
(CASSANDRA-7)
   * Fix leak errors and execution rejected exceptions when draining 
(CASSANDRA-12457)

[10/10] cassandra git commit: Merge branch 'cassandra-3.X' into trunk

[stefania]

Merge branch 'cassandra-3.X' into trunk


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/fc3b9bfd
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/fc3b9bfd
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/fc3b9bfd

Branch: refs/heads/trunk
Commit: fc3b9bfd7e5cfc1e54b1c3a38981cd2569a51110
Parents: 3c72060 94a01f6
Author: Stefania Alborghetti 
Authored: Tue Oct 25 09:44:24 2016 +0800
Committer: Stefania Alborghetti 
Committed: Tue Oct 25 09:44:24 2016 +0800

--
 CHANGES.txt  |  1 +
 .../apache/cassandra/tracing/TraceStateImpl.java |  7 +--
 .../org/apache/cassandra/cql3/TraceCqlTest.java  | 19 +++
 3 files changed, 25 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/fc3b9bfd/CHANGES.txt
--

[04/10] cassandra git commit: Change cassandra.wait_for_tracing_events_timeout_secs default to 0

[stefania]

Change cassandra.wait_for_tracing_events_timeout_secs default to 0

Patch by Stefania Alborghetti; reviewed by Paulo Motta for CASSANDRA-12754


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/2122ff88
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/2122ff88
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/2122ff88

Branch: refs/heads/trunk
Commit: 2122ff88fe8f5cec5985570b71437e782b580715
Parents: 2871377
Author: Stefania Alborghetti 
Authored: Tue Oct 11 12:02:18 2016 +0800
Committer: Stefania Alborghetti 
Committed: Tue Oct 25 09:42:02 2016 +0800

--
 CHANGES.txt   | 1 +
 src/java/org/apache/cassandra/tracing/TraceState.java | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/2122ff88/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 8b61da4..a22439b 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 2.2.9
+ * Change cassandra.wait_for_tracing_events_timeout_secs default to 0 
(CASSANDRA-12754)
  * Clean up permissions when a UDA is dropped (CASSANDRA-12720)
  * Limit colUpdateTimeDelta histogram updates to reasonable deltas 
(CASSANDRA-7)
  * Fix leak errors and execution rejected exceptions when draining 
(CASSANDRA-12457)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/2122ff88/src/java/org/apache/cassandra/tracing/TraceState.java
--
diff --git a/src/java/org/apache/cassandra/tracing/TraceState.java 
b/src/java/org/apache/cassandra/tracing/TraceState.java
index 03e510f..88f36d8 100644
--- a/src/java/org/apache/cassandra/tracing/TraceState.java
+++ b/src/java/org/apache/cassandra/tracing/TraceState.java
@@ -52,7 +52,7 @@ public class TraceState implements ProgressEventNotifier
 {
 private static final Logger logger = 
LoggerFactory.getLogger(TraceState.class);
 private static final int WAIT_FOR_PENDING_EVENTS_TIMEOUT_SECS =
-
Integer.valueOf(System.getProperty("cassandra.wait_for_tracing_events_timeout_secs",
 "1"));
+
Integer.valueOf(System.getProperty("cassandra.wait_for_tracing_events_timeout_secs",
 "0"));
 
 public final UUID sessionId;
 public final InetAddress coordinator;

[01/10] cassandra git commit: Change cassandra.wait_for_tracing_events_timeout_secs default to 0

[stefania]

Repository: cassandra
Updated Branches:
  refs/heads/cassandra-2.2 28713778a -> 2122ff88f
  refs/heads/cassandra-3.0 5883e4358 -> ee85507c2
  refs/heads/cassandra-3.X 7c759e2c3 -> 94a01f62a
  refs/heads/trunk 3c7206078 -> fc3b9bfd7


Change cassandra.wait_for_tracing_events_timeout_secs default to 0

Patch by Stefania Alborghetti; reviewed by Paulo Motta for CASSANDRA-12754


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/2122ff88
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/2122ff88
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/2122ff88

Branch: refs/heads/cassandra-2.2
Commit: 2122ff88fe8f5cec5985570b71437e782b580715
Parents: 2871377
Author: Stefania Alborghetti 
Authored: Tue Oct 11 12:02:18 2016 +0800
Committer: Stefania Alborghetti 
Committed: Tue Oct 25 09:42:02 2016 +0800

--
 CHANGES.txt   | 1 +
 src/java/org/apache/cassandra/tracing/TraceState.java | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/2122ff88/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 8b61da4..a22439b 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 2.2.9
+ * Change cassandra.wait_for_tracing_events_timeout_secs default to 0 
(CASSANDRA-12754)
  * Clean up permissions when a UDA is dropped (CASSANDRA-12720)
  * Limit colUpdateTimeDelta histogram updates to reasonable deltas 
(CASSANDRA-7)
  * Fix leak errors and execution rejected exceptions when draining 
(CASSANDRA-12457)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/2122ff88/src/java/org/apache/cassandra/tracing/TraceState.java
--
diff --git a/src/java/org/apache/cassandra/tracing/TraceState.java 
b/src/java/org/apache/cassandra/tracing/TraceState.java
index 03e510f..88f36d8 100644
--- a/src/java/org/apache/cassandra/tracing/TraceState.java
+++ b/src/java/org/apache/cassandra/tracing/TraceState.java
@@ -52,7 +52,7 @@ public class TraceState implements ProgressEventNotifier
 {
 private static final Logger logger = 
LoggerFactory.getLogger(TraceState.class);
 private static final int WAIT_FOR_PENDING_EVENTS_TIMEOUT_SECS =
-
Integer.valueOf(System.getProperty("cassandra.wait_for_tracing_events_timeout_secs",
 "1"));
+
Integer.valueOf(System.getProperty("cassandra.wait_for_tracing_events_timeout_secs",
 "0"));
 
 public final UUID sessionId;
 public final InetAddress coordinator;

[08/10] cassandra git commit: Merge branch 'cassandra-3.0' into cassandra-3.X

[stefania]

Merge branch 'cassandra-3.0' into cassandra-3.X


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/94a01f62
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/94a01f62
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/94a01f62

Branch: refs/heads/cassandra-3.X
Commit: 94a01f62a6db2ffed561fbfac05c6caf5e2ba53c
Parents: 7c759e2 ee85507
Author: Stefania Alborghetti 
Authored: Tue Oct 25 09:43:17 2016 +0800
Committer: Stefania Alborghetti 
Committed: Tue Oct 25 09:43:57 2016 +0800

--
 CHANGES.txt  |  1 +
 .../apache/cassandra/tracing/TraceStateImpl.java |  7 +--
 .../org/apache/cassandra/cql3/TraceCqlTest.java  | 19 +++
 3 files changed, 25 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/94a01f62/CHANGES.txt
--

http://git-wip-us.apache.org/repos/asf/cassandra/blob/94a01f62/src/java/org/apache/cassandra/tracing/TraceStateImpl.java
--
diff --cc src/java/org/apache/cassandra/tracing/TraceStateImpl.java
index fe78e64,000..349000a
mode 100644,00..100644
--- a/src/java/org/apache/cassandra/tracing/TraceStateImpl.java
+++ b/src/java/org/apache/cassandra/tracing/TraceStateImpl.java
@@@ -1,127 -1,0 +1,130 @@@
 +/*
 + * Licensed to the Apache Software Foundation (ASF) under one
 + * or more contributor license agreements.  See the NOTICE file
 + * distributed with this work for additional information
 + * regarding copyright ownership.  The ASF licenses this file
 + * to you under the Apache License, Version 2.0 (the
 + * "License"); you may not use this file except in compliance
 + * with the License.  You may obtain a copy of the License at
 + *
 + * http://www.apache.org/licenses/LICENSE-2.0
 + *
 + * Unless required by applicable law or agreed to in writing, software
 + * distributed under the License is distributed on an "AS IS" BASIS,
 + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 + * See the License for the specific language governing permissions and
 + * limitations under the License.
 + */
 +package org.apache.cassandra.tracing;
 +
 +import java.net.InetAddress;
 +import java.util.Collections;
 +import java.util.Set;
 +import java.util.UUID;
 +import java.util.concurrent.CompletableFuture;
 +import java.util.concurrent.ConcurrentHashMap;
 +import java.util.concurrent.Future;
 +import java.util.concurrent.TimeUnit;
 +import java.util.concurrent.TimeoutException;
 +
++import com.google.common.annotations.VisibleForTesting;
 +import org.slf4j.Logger;
 +import org.slf4j.LoggerFactory;
 +
 +import org.apache.cassandra.concurrent.Stage;
 +import org.apache.cassandra.concurrent.StageManager;
 +import org.apache.cassandra.db.ConsistencyLevel;
 +import org.apache.cassandra.db.Mutation;
 +import org.apache.cassandra.exceptions.OverloadedException;
 +import org.apache.cassandra.service.StorageProxy;
 +import org.apache.cassandra.utils.JVMStabilityInspector;
 +import org.apache.cassandra.utils.WrappedRunnable;
 +
 +/**
 + * ThreadLocal state for a tracing session. The presence of an instance of 
this class as a ThreadLocal denotes that an
 + * operation is being traced.
 + */
 +public class TraceStateImpl extends TraceState
 +{
 +private static final Logger logger = 
LoggerFactory.getLogger(TraceStateImpl.class);
- private static final int WAIT_FOR_PENDING_EVENTS_TIMEOUT_SECS =
-   
Integer.parseInt(System.getProperty("cassandra.wait_for_tracing_events_timeout_secs",
 "1"));
++
++@VisibleForTesting
++public static int WAIT_FOR_PENDING_EVENTS_TIMEOUT_SECS =
++  
Integer.parseInt(System.getProperty("cassandra.wait_for_tracing_events_timeout_secs",
 "0"));
 +
 +private final Set pendingFutures = 
ConcurrentHashMap.newKeySet();
 +
 +public TraceStateImpl(InetAddress coordinator, UUID sessionId, 
Tracing.TraceType traceType)
 +{
 +super(coordinator, sessionId, traceType);
 +}
 +
 +protected void traceImpl(String message)
 +{
 +final String threadName = Thread.currentThread().getName();
 +final int elapsed = elapsed();
 +
 +executeMutation(TraceKeyspace.makeEventMutation(sessionIdBytes, 
message, elapsed, threadName, ttl));
 +if (logger.isTraceEnabled())
 +logger.trace("Adding <{}> to trace events", message);
 +}
 +
 +/**
 + * Wait on submitted futures
 + */
 +protected void waitForPendingEvents()
 +{
 +if (WAIT_FOR_PENDING_EVENTS_TIMEOUT_SECS <= 0)
 +return;
 +
 +try
 +{
 +if 

[07/10] cassandra git commit: Merge branch 'cassandra-2.2' into cassandra-3.0

[stefania]

Merge branch 'cassandra-2.2' into cassandra-3.0


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/ee85507c
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/ee85507c
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/ee85507c

Branch: refs/heads/trunk
Commit: ee85507c2634261c77b188ee153f141b6dc511a0
Parents: 5883e43 2122ff8
Author: Stefania Alborghetti 
Authored: Tue Oct 25 09:42:46 2016 +0800
Committer: Stefania Alborghetti 
Committed: Tue Oct 25 09:42:46 2016 +0800

--
 CHANGES.txt   | 1 +
 src/java/org/apache/cassandra/tracing/TraceState.java | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/ee85507c/CHANGES.txt
--
diff --cc CHANGES.txt
index 46f27a6,a22439b..6d38f83
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,29 -1,5 +1,30 @@@
 -2.2.9
 +3.0.10
 + * Include SSTable filename in compacting large row message (CASSANDRA-12384)
 + * Fix potential socket leak (CASSANDRA-12329, CASSANDRA-12330)
 + * Fix ViewTest.testCompaction (CASSANDRA-12789)
 + * Improve avg aggregate functions (CASSANDRA-12417)
 + * Preserve quoted reserved keyword column names in MV creation 
(CASSANDRA-11803)
 + * nodetool stopdaemon errors out (CASSANDRA-12646)
 + * Split materialized view mutations on build to prevent OOM (CASSANDRA-12268)
 + * mx4j does not work in 3.0.8 (CASSANDRA-12274)
 + * Abort cqlsh copy-from in case of no answer after prolonged period of time 
(CASSANDRA-12740)
 + * Avoid sstable corrupt exception due to dropped static column 
(CASSANDRA-12582)
 + * Make stress use client mode to avoid checking commit log size on startup 
(CASSANDRA-12478)
 + * Fix exceptions with new vnode allocation (CASSANDRA-12715)
 + * Unify drain and shutdown processes (CASSANDRA-12509)
 + * Fix NPE in ComponentOfSlice.isEQ() (CASSANDRA-12706)
 + * Fix failure in LogTransactionTest (CASSANDRA-12632)
 + * Fix potentially incomplete non-frozen UDT values when querying with the
 +   full primary key specified (CASSANDRA-12605)
 + * Skip writing MV mutations to commitlog on mutation.applyUnsafe() 
(CASSANDRA-11670)
 + * Establish consistent distinction between non-existing partition and NULL 
value for LWTs on static columns (CASSANDRA-12060)
 + * Extend ColumnIdentifier.internedInstances key to include the type that 
generated the byte buffer (CASSANDRA-12516)
 + * Backport CASSANDRA-10756 (race condition in NativeTransportService 
shutdown) (CASSANDRA-12472)
 + * If CF has no clustering columns, any row cache is full partition cache 
(CASSANDRA-12499)
 + * Correct log message for statistics of offheap memtable flush 
(CASSANDRA-12776)
 + * Explicitly set locale for string validation 
(CASSANDRA-12541,CASSANDRA-12542,CASSANDRA-12543,CASSANDRA-12545)
 +Merged from 2.2:
+  * Change cassandra.wait_for_tracing_events_timeout_secs default to 0 
(CASSANDRA-12754)
   * Clean up permissions when a UDA is dropped (CASSANDRA-12720)
   * Limit colUpdateTimeDelta histogram updates to reasonable deltas 
(CASSANDRA-7)
   * Fix leak errors and execution rejected exceptions when draining 
(CASSANDRA-12457)

[03/10] cassandra git commit: Change cassandra.wait_for_tracing_events_timeout_secs default to 0

[stefania]

Change cassandra.wait_for_tracing_events_timeout_secs default to 0

Patch by Stefania Alborghetti; reviewed by Paulo Motta for CASSANDRA-12754


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/2122ff88
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/2122ff88
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/2122ff88

Branch: refs/heads/cassandra-3.X
Commit: 2122ff88fe8f5cec5985570b71437e782b580715
Parents: 2871377
Author: Stefania Alborghetti 
Authored: Tue Oct 11 12:02:18 2016 +0800
Committer: Stefania Alborghetti 
Committed: Tue Oct 25 09:42:02 2016 +0800

--
 CHANGES.txt   | 1 +
 src/java/org/apache/cassandra/tracing/TraceState.java | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/2122ff88/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 8b61da4..a22439b 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 2.2.9
+ * Change cassandra.wait_for_tracing_events_timeout_secs default to 0 
(CASSANDRA-12754)
  * Clean up permissions when a UDA is dropped (CASSANDRA-12720)
  * Limit colUpdateTimeDelta histogram updates to reasonable deltas 
(CASSANDRA-7)
  * Fix leak errors and execution rejected exceptions when draining 
(CASSANDRA-12457)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/2122ff88/src/java/org/apache/cassandra/tracing/TraceState.java
--
diff --git a/src/java/org/apache/cassandra/tracing/TraceState.java 
b/src/java/org/apache/cassandra/tracing/TraceState.java
index 03e510f..88f36d8 100644
--- a/src/java/org/apache/cassandra/tracing/TraceState.java
+++ b/src/java/org/apache/cassandra/tracing/TraceState.java
@@ -52,7 +52,7 @@ public class TraceState implements ProgressEventNotifier
 {
 private static final Logger logger = 
LoggerFactory.getLogger(TraceState.class);
 private static final int WAIT_FOR_PENDING_EVENTS_TIMEOUT_SECS =
-
Integer.valueOf(System.getProperty("cassandra.wait_for_tracing_events_timeout_secs",
 "1"));
+
Integer.valueOf(System.getProperty("cassandra.wait_for_tracing_events_timeout_secs",
 "0"));
 
 public final UUID sessionId;
 public final InetAddress coordinator;

[09/10] cassandra git commit: Merge branch 'cassandra-3.0' into cassandra-3.X

[stefania]

Merge branch 'cassandra-3.0' into cassandra-3.X


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/94a01f62
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/94a01f62
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/94a01f62

Branch: refs/heads/trunk
Commit: 94a01f62a6db2ffed561fbfac05c6caf5e2ba53c
Parents: 7c759e2 ee85507
Author: Stefania Alborghetti 
Authored: Tue Oct 25 09:43:17 2016 +0800
Committer: Stefania Alborghetti 
Committed: Tue Oct 25 09:43:57 2016 +0800

--
 CHANGES.txt  |  1 +
 .../apache/cassandra/tracing/TraceStateImpl.java |  7 +--
 .../org/apache/cassandra/cql3/TraceCqlTest.java  | 19 +++
 3 files changed, 25 insertions(+), 2 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/94a01f62/CHANGES.txt
--

http://git-wip-us.apache.org/repos/asf/cassandra/blob/94a01f62/src/java/org/apache/cassandra/tracing/TraceStateImpl.java
--
diff --cc src/java/org/apache/cassandra/tracing/TraceStateImpl.java
index fe78e64,000..349000a
mode 100644,00..100644
--- a/src/java/org/apache/cassandra/tracing/TraceStateImpl.java
+++ b/src/java/org/apache/cassandra/tracing/TraceStateImpl.java
@@@ -1,127 -1,0 +1,130 @@@
 +/*
 + * Licensed to the Apache Software Foundation (ASF) under one
 + * or more contributor license agreements.  See the NOTICE file
 + * distributed with this work for additional information
 + * regarding copyright ownership.  The ASF licenses this file
 + * to you under the Apache License, Version 2.0 (the
 + * "License"); you may not use this file except in compliance
 + * with the License.  You may obtain a copy of the License at
 + *
 + * http://www.apache.org/licenses/LICENSE-2.0
 + *
 + * Unless required by applicable law or agreed to in writing, software
 + * distributed under the License is distributed on an "AS IS" BASIS,
 + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 + * See the License for the specific language governing permissions and
 + * limitations under the License.
 + */
 +package org.apache.cassandra.tracing;
 +
 +import java.net.InetAddress;
 +import java.util.Collections;
 +import java.util.Set;
 +import java.util.UUID;
 +import java.util.concurrent.CompletableFuture;
 +import java.util.concurrent.ConcurrentHashMap;
 +import java.util.concurrent.Future;
 +import java.util.concurrent.TimeUnit;
 +import java.util.concurrent.TimeoutException;
 +
++import com.google.common.annotations.VisibleForTesting;
 +import org.slf4j.Logger;
 +import org.slf4j.LoggerFactory;
 +
 +import org.apache.cassandra.concurrent.Stage;
 +import org.apache.cassandra.concurrent.StageManager;
 +import org.apache.cassandra.db.ConsistencyLevel;
 +import org.apache.cassandra.db.Mutation;
 +import org.apache.cassandra.exceptions.OverloadedException;
 +import org.apache.cassandra.service.StorageProxy;
 +import org.apache.cassandra.utils.JVMStabilityInspector;
 +import org.apache.cassandra.utils.WrappedRunnable;
 +
 +/**
 + * ThreadLocal state for a tracing session. The presence of an instance of 
this class as a ThreadLocal denotes that an
 + * operation is being traced.
 + */
 +public class TraceStateImpl extends TraceState
 +{
 +private static final Logger logger = 
LoggerFactory.getLogger(TraceStateImpl.class);
- private static final int WAIT_FOR_PENDING_EVENTS_TIMEOUT_SECS =
-   
Integer.parseInt(System.getProperty("cassandra.wait_for_tracing_events_timeout_secs",
 "1"));
++
++@VisibleForTesting
++public static int WAIT_FOR_PENDING_EVENTS_TIMEOUT_SECS =
++  
Integer.parseInt(System.getProperty("cassandra.wait_for_tracing_events_timeout_secs",
 "0"));
 +
 +private final Set pendingFutures = 
ConcurrentHashMap.newKeySet();
 +
 +public TraceStateImpl(InetAddress coordinator, UUID sessionId, 
Tracing.TraceType traceType)
 +{
 +super(coordinator, sessionId, traceType);
 +}
 +
 +protected void traceImpl(String message)
 +{
 +final String threadName = Thread.currentThread().getName();
 +final int elapsed = elapsed();
 +
 +executeMutation(TraceKeyspace.makeEventMutation(sessionIdBytes, 
message, elapsed, threadName, ttl));
 +if (logger.isTraceEnabled())
 +logger.trace("Adding <{}> to trace events", message);
 +}
 +
 +/**
 + * Wait on submitted futures
 + */
 +protected void waitForPendingEvents()
 +{
 +if (WAIT_FOR_PENDING_EVENTS_TIMEOUT_SECS <= 0)
 +return;
 +
 +try
 +{
 +if 

[02/10] cassandra git commit: Change cassandra.wait_for_tracing_events_timeout_secs default to 0

[stefania]

Change cassandra.wait_for_tracing_events_timeout_secs default to 0

Patch by Stefania Alborghetti; reviewed by Paulo Motta for CASSANDRA-12754


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/2122ff88
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/2122ff88
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/2122ff88

Branch: refs/heads/cassandra-3.0
Commit: 2122ff88fe8f5cec5985570b71437e782b580715
Parents: 2871377
Author: Stefania Alborghetti 
Authored: Tue Oct 11 12:02:18 2016 +0800
Committer: Stefania Alborghetti 
Committed: Tue Oct 25 09:42:02 2016 +0800

--
 CHANGES.txt   | 1 +
 src/java/org/apache/cassandra/tracing/TraceState.java | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/2122ff88/CHANGES.txt
--
diff --git a/CHANGES.txt b/CHANGES.txt
index 8b61da4..a22439b 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 2.2.9
+ * Change cassandra.wait_for_tracing_events_timeout_secs default to 0 
(CASSANDRA-12754)
  * Clean up permissions when a UDA is dropped (CASSANDRA-12720)
  * Limit colUpdateTimeDelta histogram updates to reasonable deltas 
(CASSANDRA-7)
  * Fix leak errors and execution rejected exceptions when draining 
(CASSANDRA-12457)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/2122ff88/src/java/org/apache/cassandra/tracing/TraceState.java
--
diff --git a/src/java/org/apache/cassandra/tracing/TraceState.java 
b/src/java/org/apache/cassandra/tracing/TraceState.java
index 03e510f..88f36d8 100644
--- a/src/java/org/apache/cassandra/tracing/TraceState.java
+++ b/src/java/org/apache/cassandra/tracing/TraceState.java
@@ -52,7 +52,7 @@ public class TraceState implements ProgressEventNotifier
 {
 private static final Logger logger = 
LoggerFactory.getLogger(TraceState.class);
 private static final int WAIT_FOR_PENDING_EVENTS_TIMEOUT_SECS =
-
Integer.valueOf(System.getProperty("cassandra.wait_for_tracing_events_timeout_secs",
 "1"));
+
Integer.valueOf(System.getProperty("cassandra.wait_for_tracing_events_timeout_secs",
 "0"));
 
 public final UUID sessionId;
 public final InetAddress coordinator;

[05/10] cassandra git commit: Merge branch 'cassandra-2.2' into cassandra-3.0

[stefania]

Merge branch 'cassandra-2.2' into cassandra-3.0


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/ee85507c
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/ee85507c
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/ee85507c

Branch: refs/heads/cassandra-3.X
Commit: ee85507c2634261c77b188ee153f141b6dc511a0
Parents: 5883e43 2122ff8
Author: Stefania Alborghetti 
Authored: Tue Oct 25 09:42:46 2016 +0800
Committer: Stefania Alborghetti 
Committed: Tue Oct 25 09:42:46 2016 +0800

--
 CHANGES.txt   | 1 +
 src/java/org/apache/cassandra/tracing/TraceState.java | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/ee85507c/CHANGES.txt
--
diff --cc CHANGES.txt
index 46f27a6,a22439b..6d38f83
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,29 -1,5 +1,30 @@@
 -2.2.9
 +3.0.10
 + * Include SSTable filename in compacting large row message (CASSANDRA-12384)
 + * Fix potential socket leak (CASSANDRA-12329, CASSANDRA-12330)
 + * Fix ViewTest.testCompaction (CASSANDRA-12789)
 + * Improve avg aggregate functions (CASSANDRA-12417)
 + * Preserve quoted reserved keyword column names in MV creation 
(CASSANDRA-11803)
 + * nodetool stopdaemon errors out (CASSANDRA-12646)
 + * Split materialized view mutations on build to prevent OOM (CASSANDRA-12268)
 + * mx4j does not work in 3.0.8 (CASSANDRA-12274)
 + * Abort cqlsh copy-from in case of no answer after prolonged period of time 
(CASSANDRA-12740)
 + * Avoid sstable corrupt exception due to dropped static column 
(CASSANDRA-12582)
 + * Make stress use client mode to avoid checking commit log size on startup 
(CASSANDRA-12478)
 + * Fix exceptions with new vnode allocation (CASSANDRA-12715)
 + * Unify drain and shutdown processes (CASSANDRA-12509)
 + * Fix NPE in ComponentOfSlice.isEQ() (CASSANDRA-12706)
 + * Fix failure in LogTransactionTest (CASSANDRA-12632)
 + * Fix potentially incomplete non-frozen UDT values when querying with the
 +   full primary key specified (CASSANDRA-12605)
 + * Skip writing MV mutations to commitlog on mutation.applyUnsafe() 
(CASSANDRA-11670)
 + * Establish consistent distinction between non-existing partition and NULL 
value for LWTs on static columns (CASSANDRA-12060)
 + * Extend ColumnIdentifier.internedInstances key to include the type that 
generated the byte buffer (CASSANDRA-12516)
 + * Backport CASSANDRA-10756 (race condition in NativeTransportService 
shutdown) (CASSANDRA-12472)
 + * If CF has no clustering columns, any row cache is full partition cache 
(CASSANDRA-12499)
 + * Correct log message for statistics of offheap memtable flush 
(CASSANDRA-12776)
 + * Explicitly set locale for string validation 
(CASSANDRA-12541,CASSANDRA-12542,CASSANDRA-12543,CASSANDRA-12545)
 +Merged from 2.2:
+  * Change cassandra.wait_for_tracing_events_timeout_secs default to 0 
(CASSANDRA-12754)
   * Clean up permissions when a UDA is dropped (CASSANDRA-12720)
   * Limit colUpdateTimeDelta histogram updates to reasonable deltas 
(CASSANDRA-7)
   * Fix leak errors and execution rejected exceptions when draining 
(CASSANDRA-12457)

[jira] [Commented] (CASSANDRA-11888) cassandra-env.sh may not work properly with jvm args containing a space

[Murukesh Mohanan (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-11888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15603777#comment-15603777
 ] 

Murukesh Mohanan commented on CASSANDRA-11888:
--

The {{bin/cassandra}} script relies on unquoted expansion of {{$JVM_OPTS}} to 
split supplied options to separate arguments. Unfortunately, there's no simple 
way to safeguard spaces in an environment variable that gets included in this 
unquoted expansion (no combination of quoting or backslash-escaping can help).

The simplest way out of this problem is to use a script whenever the command 
you need to run contains whitespace or globs ({{?}}, {{*}}, etc.).

More modern shells support arrays, which can help with keeping arguments 
separate, but the first step of dealing with multiple options in 
{{$JVM_EXTRA_OPTS}} which are separated by whitespace, and any of which might 
contain whitespace themselves remains a problem. This cannot be fixed by simple 
changes (options include reading in all options from a file and using something 
like {{xargs}} to create the command, or restricting {{$JVM_EXTRA_OPTS}} to a 
single option so that whitespace can be preserved for it, or some ugly hack 
involving {{eval}}).

{{bin/cassandra}} also has this note at the start, after the boilerplate:

{code}
# NB: Developers should be aware that this script should remain compatible with
# POSIX sh and Solaris sh. This means, in particular, no $(( )) and no $( ).
{code}

This means using a modern shell is out of the question, so something like the 
following can't be used, where we take advantage of bash's {{read}}'s ability 
to handle escaped input:

{code}
bash-4.4$ JVM_EXTRA_OPTS='-XX:foo\ bar\ \*'
bash-4.4$ JVM_OPTS='-XX:blah'
bash-4.4$ JVM_OPTS="$JVM_OPTS $JVM_EXTRA_OPTS"
bash-4.4$ printf "%s\n" "$JVM_OPTS" | while read -a args; do printf "|%s|\n" 
"${args[@]}" ; done
|-XX:blah|
|-XX:foo bar *|
{code}

Workarounds like reserving a character like tab for this could also break 
things for others who rely on the default IFS (space, tab, newline).

I suppose this issue should be closed as won't fix.

Related: [Is it possible to “protect” an IFS character from field splitting? - 
Unix & Linux|http://unix.stackexchange.com/q/318460/70524]



> cassandra-env.sh may not work properly with jvm args containing a space
> ---
>
> Key: CASSANDRA-11888
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11888
> Project: Cassandra
>  Issue Type: Bug
> Environment: linux
>Reporter: Russ Hatch
>Priority: Minor
>  Labels: lhf
>
> When using the JVM_EXTRA_OPTS environment variable, it looks like there's 
> some cases that may not work if an env var contains a space.
> For example, setting:
> {noformat}
> export JVM_EXTRA_OPTS='-XX:OnOutOfMemoryError="echo oh_no"'
> {noformat}
> Results in the jvm not starting because the resultant startup command looks 
> to java like it should load a class called oh_no.
> {noformat}
> Error: Could not find or load main class oh_no
> {noformat}
> I think this results from the last line of cassandra-env.sh, where it does 
> this:
> {noformat}
> JVM_OPTS="$JVM_OPTS $JVM_EXTRA_OPTS"
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12816) Rebuild failing while adding new datacenter

[Jai Bheemsen Rao Dhanwada (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15603565#comment-15603565
 ] 

Jai Bheemsen Rao Dhanwada commented on CASSANDRA-12816:
---

This isn't correct. For example I have 10 Keyspaces in a cluster and I want to 
have 5 Keyspaces in DC-1 and other 5 keyspaces in DC-1 and DC-2, in this is the 
rebuild fails and I can't replicate the data to the newly added DC.

> Rebuild failing while adding new datacenter
> ---
>
> Key: CASSANDRA-12816
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12816
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Jai Bheemsen Rao Dhanwada
>Priority: Critical
>
> Hello All,
> I have single datacenter with 3 C* nodes and we are trying to expand the 
> cluster to another region/DC. I am seeing the below error while doing a 
> "nodetool rebuild -- name_of_existing_data_center" .  
> {code:java}
> [user@machine ~]$ nodetool rebuild DC1
> nodetool: Unable to find sufficient sources for streaming range 
> (-402178150752044282,-396707578307430827] in keyspace system_distributed
> See 'nodetool help' or 'nodetool help '.
> [user@machine ~]$
> {code}
> {code:java}
> user@cqlsh> SELECT * from system_schema.keyspaces where 
> keyspace_name='system_distributed';
>  keyspace_name | durable_writes | replication
> ---++-
>  system_distributed |   True | {'class': 
> 'org.apache.cassandra.locator.SimpleStrategy', 'replication_factor': '3'}
> (1 rows)
> {code}
> To overcome this I have updated system_distributed keyspace to DC1:3 and 
> DC2:3 with NetworkTopologyStrategy
> C* Version - 3.0.8
> Is this a bug that is introduced in 3.0.8 version of cassandra? as I haven't 
> seen this issue with the older versions?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12816) Rebuild failing while adding new datacenter

[Jeremy Hanna (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15603437#comment-15603437
 ] 

Jeremy Hanna commented on CASSANDRA-12816:
--

If you change it to NetworkTopologyStrategy, the strategy is datacenter aware.  
You are then able to specify the datacenter where the replicas will be stored.  
If you aren't using SimpleStrategy and you bootstrap other nodes in another 
datacenter, then try to rebuild, it will likely try to put data for those 
keyspaces in the new datacenter.  The rebuild operation requires a source 
datacenter argument, so I wonder if it's failing because the source datacenter 
in this case doesn't have all of the data according to the replication 
strategies for those keyspaces.  So I would always change to NTS before trying 
rebuild.

> Rebuild failing while adding new datacenter
> ---
>
> Key: CASSANDRA-12816
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12816
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Jai Bheemsen Rao Dhanwada
>Priority: Critical
>
> Hello All,
> I have single datacenter with 3 C* nodes and we are trying to expand the 
> cluster to another region/DC. I am seeing the below error while doing a 
> "nodetool rebuild -- name_of_existing_data_center" .  
> {code:java}
> [user@machine ~]$ nodetool rebuild DC1
> nodetool: Unable to find sufficient sources for streaming range 
> (-402178150752044282,-396707578307430827] in keyspace system_distributed
> See 'nodetool help' or 'nodetool help '.
> [user@machine ~]$
> {code}
> {code:java}
> user@cqlsh> SELECT * from system_schema.keyspaces where 
> keyspace_name='system_distributed';
>  keyspace_name | durable_writes | replication
> ---++-
>  system_distributed |   True | {'class': 
> 'org.apache.cassandra.locator.SimpleStrategy', 'replication_factor': '3'}
> (1 rows)
> {code}
> To overcome this I have updated system_distributed keyspace to DC1:3 and 
> DC2:3 with NetworkTopologyStrategy
> C* Version - 3.0.8
> Is this a bug that is introduced in 3.0.8 version of cassandra? as I haven't 
> seen this issue with the older versions?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (CASSANDRA-12835) Tracing payload not passed from QueryMessage to tracing session

[mck (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

mck reassigned CASSANDRA-12835:
---

Assignee: mck

> Tracing payload not passed from QueryMessage to tracing session
> ---
>
> Key: CASSANDRA-12835
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12835
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Hannu Kröger
>Assignee: mck
>Priority: Critical
>  Labels: tracing
>
> Caused by CASSANDRA-10392.
> Related to CASSANDRA-11706.
> When querying using CQL statements (not prepared) the message type is 
> QueryMessage and the code in 
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/transport/messages/QueryMessage.java#L101
>  is as follows:
> {code:java}
> if (state.traceNextQuery())
> {
> state.createTracingSession();
> ImmutableMap.Builder builder = 
> ImmutableMap.builder();
> {code}
> {{state.createTracingSession();}} should probably be 
> {{state.createTracingSession(getCustomPayload());}}. At least that fixes the 
> problem for me.
> This also raises the question whether some other parts of the code should 
> pass the custom payload as well (I'm not the right person to analyze this):
> {code}
> $ ag createTracingSession
> src/java/org/apache/cassandra/service/QueryState.java
> 80:public void createTracingSession()
> 82:createTracingSession(Collections.EMPTY_MAP);
> 85:public void createTracingSession(Map customPayload)
> src/java/org/apache/cassandra/thrift/CassandraServer.java
> 2528:state().getQueryState().createTracingSession();
> src/java/org/apache/cassandra/transport/messages/BatchMessage.java
> 163:state.createTracingSession();
> src/java/org/apache/cassandra/transport/messages/ExecuteMessage.java
> 114:state.createTracingSession(getCustomPayload());
> src/java/org/apache/cassandra/transport/messages/QueryMessage.java
> 101:state.createTracingSession();
> src/java/org/apache/cassandra/transport/messages/PrepareMessage.java
> 74:state.createTracingSession();
> {code}
> This is not marked as `minor` as the CASSANDRA-11706 was because this cannot 
> be fixed by the tracing plugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12816) Rebuild failing while adding new datacenter

[Jai Bheemsen Rao Dhanwada (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15603306#comment-15603306
 ] 

Jai Bheemsen Rao Dhanwada commented on CASSANDRA-12816:
---

system_traces and system_distributed are using SimpleStrategy, If I change it 
to the NetworkTopologyStrategy, the rebuild operation works. any idea what are 
the implications of changing them to NetworkTopologyStrategy?

> Rebuild failing while adding new datacenter
> ---
>
> Key: CASSANDRA-12816
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12816
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Jai Bheemsen Rao Dhanwada
>Priority: Critical
>
> Hello All,
> I have single datacenter with 3 C* nodes and we are trying to expand the 
> cluster to another region/DC. I am seeing the below error while doing a 
> "nodetool rebuild -- name_of_existing_data_center" .  
> {code:java}
> [user@machine ~]$ nodetool rebuild DC1
> nodetool: Unable to find sufficient sources for streaming range 
> (-402178150752044282,-396707578307430827] in keyspace system_distributed
> See 'nodetool help' or 'nodetool help '.
> [user@machine ~]$
> {code}
> {code:java}
> user@cqlsh> SELECT * from system_schema.keyspaces where 
> keyspace_name='system_distributed';
>  keyspace_name | durable_writes | replication
> ---++-
>  system_distributed |   True | {'class': 
> 'org.apache.cassandra.locator.SimpleStrategy', 'replication_factor': '3'}
> (1 rows)
> {code}
> To overcome this I have updated system_distributed keyspace to DC1:3 and 
> DC2:3 with NetworkTopologyStrategy
> C* Version - 3.0.8
> Is this a bug that is introduced in 3.0.8 version of cassandra? as I haven't 
> seen this issue with the older versions?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12816) Rebuild failing while adding new datacenter

[Jeremy Hanna (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15603275#comment-15603275
 ] 

Jeremy Hanna commented on CASSANDRA-12816:
--

If it is using the LocalStrategy, don't change it.  In fact I don't think you 
can change it.  If it's not using the local strategy, set it to 
NetworkTopologyStrategy.

> Rebuild failing while adding new datacenter
> ---
>
> Key: CASSANDRA-12816
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12816
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Jai Bheemsen Rao Dhanwada
>Priority: Critical
>
> Hello All,
> I have single datacenter with 3 C* nodes and we are trying to expand the 
> cluster to another region/DC. I am seeing the below error while doing a 
> "nodetool rebuild -- name_of_existing_data_center" .  
> {code:java}
> [user@machine ~]$ nodetool rebuild DC1
> nodetool: Unable to find sufficient sources for streaming range 
> (-402178150752044282,-396707578307430827] in keyspace system_distributed
> See 'nodetool help' or 'nodetool help '.
> [user@machine ~]$
> {code}
> {code:java}
> user@cqlsh> SELECT * from system_schema.keyspaces where 
> keyspace_name='system_distributed';
>  keyspace_name | durable_writes | replication
> ---++-
>  system_distributed |   True | {'class': 
> 'org.apache.cassandra.locator.SimpleStrategy', 'replication_factor': '3'}
> (1 rows)
> {code}
> To overcome this I have updated system_distributed keyspace to DC1:3 and 
> DC2:3 with NetworkTopologyStrategy
> C* Version - 3.0.8
> Is this a bug that is introduced in 3.0.8 version of cassandra? as I haven't 
> seen this issue with the older versions?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12816) Rebuild failing while adding new datacenter

[Jai Bheemsen Rao Dhanwada (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15603265#comment-15603265
 ] 

Jai Bheemsen Rao Dhanwada commented on CASSANDRA-12816:
---

[~jeromatron] correct, but I am concerned about altering system level keyspaces 
(system, systems_traces, system_distributed). 
Do you know what is the impact (if any) of making system keyspaces to 
NetworkTopologyStrategy ?

> Rebuild failing while adding new datacenter
> ---
>
> Key: CASSANDRA-12816
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12816
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Jai Bheemsen Rao Dhanwada
>Priority: Critical
>
> Hello All,
> I have single datacenter with 3 C* nodes and we are trying to expand the 
> cluster to another region/DC. I am seeing the below error while doing a 
> "nodetool rebuild -- name_of_existing_data_center" .  
> {code:java}
> [user@machine ~]$ nodetool rebuild DC1
> nodetool: Unable to find sufficient sources for streaming range 
> (-402178150752044282,-396707578307430827] in keyspace system_distributed
> See 'nodetool help' or 'nodetool help '.
> [user@machine ~]$
> {code}
> {code:java}
> user@cqlsh> SELECT * from system_schema.keyspaces where 
> keyspace_name='system_distributed';
>  keyspace_name | durable_writes | replication
> ---++-
>  system_distributed |   True | {'class': 
> 'org.apache.cassandra.locator.SimpleStrategy', 'replication_factor': '3'}
> (1 rows)
> {code}
> To overcome this I have updated system_distributed keyspace to DC1:3 and 
> DC2:3 with NetworkTopologyStrategy
> C* Version - 3.0.8
> Is this a bug that is introduced in 3.0.8 version of cassandra? as I haven't 
> seen this issue with the older versions?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (CASSANDRA-12816) Rebuild failing while adding new datacenter

[Jeremy Hanna (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15603246#comment-15603246
 ] 

Jeremy Hanna edited comment on CASSANDRA-12816 at 10/24/16 9:17 PM:


fwiw, before going to multiple datacenters it is *always* advisable to make all 
keyspaces NetworkTopologyStrategy to avoid confusion about where replicas are 
stored.  SimpleStrategy ignores datacenters.


was (Author: jeromatron):
fwiw, befire going to multiple datacenters it is *always* advisable to make all 
keyspaces NetworkTopologyStrategy to avoid confusion about where replicas are 
stored.  SimpleStrategy ignores datacenters.

> Rebuild failing while adding new datacenter
> ---
>
> Key: CASSANDRA-12816
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12816
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Jai Bheemsen Rao Dhanwada
>Priority: Critical
>
> Hello All,
> I have single datacenter with 3 C* nodes and we are trying to expand the 
> cluster to another region/DC. I am seeing the below error while doing a 
> "nodetool rebuild -- name_of_existing_data_center" .  
> {code:java}
> [user@machine ~]$ nodetool rebuild DC1
> nodetool: Unable to find sufficient sources for streaming range 
> (-402178150752044282,-396707578307430827] in keyspace system_distributed
> See 'nodetool help' or 'nodetool help '.
> [user@machine ~]$
> {code}
> {code:java}
> user@cqlsh> SELECT * from system_schema.keyspaces where 
> keyspace_name='system_distributed';
>  keyspace_name | durable_writes | replication
> ---++-
>  system_distributed |   True | {'class': 
> 'org.apache.cassandra.locator.SimpleStrategy', 'replication_factor': '3'}
> (1 rows)
> {code}
> To overcome this I have updated system_distributed keyspace to DC1:3 and 
> DC2:3 with NetworkTopologyStrategy
> C* Version - 3.0.8
> Is this a bug that is introduced in 3.0.8 version of cassandra? as I haven't 
> seen this issue with the older versions?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (CASSANDRA-12816) Rebuild failing while adding new datacenter

[Jeremy Hanna (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15603246#comment-15603246
 ] 

Jeremy Hanna edited comment on CASSANDRA-12816 at 10/24/16 9:17 PM:


fwiw, befire going to multiple datacenters it is *always* advisable to make all 
keyspaces NetworkTopologyStrategy to avoid confusion about where replicas are 
stored.  SimpleStrategy ignores datacenters.


was (Author: jeromatron):
fwiw, when going to multiple datacenters it is always advisable to make all 
keyspaces NetworkTopologyStrategy to avoid confusion about where replicas are 
stored.  SimpleStrategy ignores datacenters.

> Rebuild failing while adding new datacenter
> ---
>
> Key: CASSANDRA-12816
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12816
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Jai Bheemsen Rao Dhanwada
>Priority: Critical
>
> Hello All,
> I have single datacenter with 3 C* nodes and we are trying to expand the 
> cluster to another region/DC. I am seeing the below error while doing a 
> "nodetool rebuild -- name_of_existing_data_center" .  
> {code:java}
> [user@machine ~]$ nodetool rebuild DC1
> nodetool: Unable to find sufficient sources for streaming range 
> (-402178150752044282,-396707578307430827] in keyspace system_distributed
> See 'nodetool help' or 'nodetool help '.
> [user@machine ~]$
> {code}
> {code:java}
> user@cqlsh> SELECT * from system_schema.keyspaces where 
> keyspace_name='system_distributed';
>  keyspace_name | durable_writes | replication
> ---++-
>  system_distributed |   True | {'class': 
> 'org.apache.cassandra.locator.SimpleStrategy', 'replication_factor': '3'}
> (1 rows)
> {code}
> To overcome this I have updated system_distributed keyspace to DC1:3 and 
> DC2:3 with NetworkTopologyStrategy
> C* Version - 3.0.8
> Is this a bug that is introduced in 3.0.8 version of cassandra? as I haven't 
> seen this issue with the older versions?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12816) Rebuild failing while adding new datacenter

[Jeremy Hanna (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15603246#comment-15603246
 ] 

Jeremy Hanna commented on CASSANDRA-12816:
--

fwiw, when going to multiple datacenters it is always advisable to make all 
keyspaces NetworkTopologyStrategy to avoid confusion about where replicas are 
stored.  SimpleStrategy ignores datacenters.

> Rebuild failing while adding new datacenter
> ---
>
> Key: CASSANDRA-12816
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12816
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Jai Bheemsen Rao Dhanwada
>Priority: Critical
>
> Hello All,
> I have single datacenter with 3 C* nodes and we are trying to expand the 
> cluster to another region/DC. I am seeing the below error while doing a 
> "nodetool rebuild -- name_of_existing_data_center" .  
> {code:java}
> [user@machine ~]$ nodetool rebuild DC1
> nodetool: Unable to find sufficient sources for streaming range 
> (-402178150752044282,-396707578307430827] in keyspace system_distributed
> See 'nodetool help' or 'nodetool help '.
> [user@machine ~]$
> {code}
> {code:java}
> user@cqlsh> SELECT * from system_schema.keyspaces where 
> keyspace_name='system_distributed';
>  keyspace_name | durable_writes | replication
> ---++-
>  system_distributed |   True | {'class': 
> 'org.apache.cassandra.locator.SimpleStrategy', 'replication_factor': '3'}
> (1 rows)
> {code}
> To overcome this I have updated system_distributed keyspace to DC1:3 and 
> DC2:3 with NetworkTopologyStrategy
> C* Version - 3.0.8
> Is this a bug that is introduced in 3.0.8 version of cassandra? as I haven't 
> seen this issue with the older versions?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12816) Rebuild failing while adding new datacenter

[sai k potturi (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15603224#comment-15603224
 ] 

sai k potturi commented on CASSANDRA-12816:
---

We've observed this in the older versions like 2.1.15 and 2.1.16 too. 

If we happen to change the replication factor and strategy to 
'network-topology', rebuild is successful.  Will altering the replication 
factor for system_traces have any effect on major upgrades?

> Rebuild failing while adding new datacenter
> ---
>
> Key: CASSANDRA-12816
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12816
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Jai Bheemsen Rao Dhanwada
>Priority: Critical
>
> Hello All,
> I have single datacenter with 3 C* nodes and we are trying to expand the 
> cluster to another region/DC. I am seeing the below error while doing a 
> "nodetool rebuild -- name_of_existing_data_center" .  
> {code:java}
> [user@machine ~]$ nodetool rebuild DC1
> nodetool: Unable to find sufficient sources for streaming range 
> (-402178150752044282,-396707578307430827] in keyspace system_distributed
> See 'nodetool help' or 'nodetool help '.
> [user@machine ~]$
> {code}
> {code:java}
> user@cqlsh> SELECT * from system_schema.keyspaces where 
> keyspace_name='system_distributed';
>  keyspace_name | durable_writes | replication
> ---++-
>  system_distributed |   True | {'class': 
> 'org.apache.cassandra.locator.SimpleStrategy', 'replication_factor': '3'}
> (1 rows)
> {code}
> To overcome this I have updated system_distributed keyspace to DC1:3 and 
> DC2:3 with NetworkTopologyStrategy
> C* Version - 3.0.8
> Is this a bug that is introduced in 3.0.8 version of cassandra? as I haven't 
> seen this issue with the older versions?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12805) Website documentation for commitlog

[Hau Phan (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hau Phan updated CASSANDRA-12805:
-
Attachment: 12805-trunk.txt

> Website documentation for commitlog
> ---
>
> Key: CASSANDRA-12805
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12805
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Documentation and Website
>Reporter: Hau Phan
>Priority: Minor
>  Labels: documentation
> Attachments: 12805-trunk.txt
>
>
> Updated Storage Engine page for commitlogs
> Commit: 
> https://github.com/nothau/cassandra/commit/876d395b4188bb230f869a161c3d7fe317506b34



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12805) Website documentation for commitlog

[Hau Phan (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hau Phan updated CASSANDRA-12805:
-
Description: 
Updated Storage Engine page for commitlogs

Commit: 
https://github.com/nothau/cassandra/commit/876d395b4188bb230f869a161c3d7fe317506b34


  was:
Updated Storage Engine page for commitlogs

Commit: 
https://github.com/nothau/cassandra/commit/0c461134b18c75bbd63b18186547a6428f865422



> Website documentation for commitlog
> ---
>
> Key: CASSANDRA-12805
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12805
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Documentation and Website
>Reporter: Hau Phan
>Priority: Minor
>  Labels: documentation
>
> Updated Storage Engine page for commitlogs
> Commit: 
> https://github.com/nothau/cassandra/commit/876d395b4188bb230f869a161c3d7fe317506b34



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12805) Website documentation for commitlog

[Hau Phan (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hau Phan updated CASSANDRA-12805:
-
Attachment: (was: 12805-trunk.txt)

> Website documentation for commitlog
> ---
>
> Key: CASSANDRA-12805
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12805
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Documentation and Website
>Reporter: Hau Phan
>Priority: Minor
>  Labels: documentation
>
> Updated Storage Engine page for commitlogs
> Commit: 
> https://github.com/nothau/cassandra/commit/0c461134b18c75bbd63b18186547a6428f865422



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12725) dtest failure in repair_tests.incremental_repair_test.TestIncRepair.sstable_marking_test_not_intersecting_all_ranges

[Philip Thompson (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15603056#comment-15603056
 ] 

Philip Thompson commented on CASSANDRA-12725:
-

https://github.com/riptano/cassandra-dtest/pull/1370

> dtest failure in 
> repair_tests.incremental_repair_test.TestIncRepair.sstable_marking_test_not_intersecting_all_ranges
> 
>
> Key: CASSANDRA-12725
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12725
> Project: Cassandra
>  Issue Type: Test
>Reporter: Sean McCarthy
>Assignee: Philip Thompson
>  Labels: dtest
>
> example failure:
> http://cassci.datastax.com/job/trunk_offheap_dtest/406/testReport/repair_tests.incremental_repair_test/TestIncRepair/sstable_marking_test_not_intersecting_all_ranges
> {code}
> Error Message
> Subprocess sstablemetadata on keyspace: keyspace1, column_family: None exited 
> with non-zero status; exit status: 1; 
> stdout: 
> usage: Usage: sstablemetadata [--gc_grace_seconds n] 
> Dump contents of given SSTable to standard output in JSON format.
> --gc_grace_secondsThe gc_grace_seconds to use when
>calculating droppable tombstones
> {code}
> {code}
> Stacktrace
>   File "/usr/lib/python2.7/unittest/case.py", line 329, in run
> testMethod()
>   File 
> "/home/automaton/cassandra-dtest/repair_tests/incremental_repair_test.py", 
> line 366, in sstable_marking_test_not_intersecting_all_ranges
> for out in (node.run_sstablemetadata(keyspace='keyspace1').stdout for 
> node in cluster.nodelist()):
>   File 
> "/home/automaton/cassandra-dtest/repair_tests/incremental_repair_test.py", 
> line 366, in 
> for out in (node.run_sstablemetadata(keyspace='keyspace1').stdout for 
> node in cluster.nodelist()):
>   File "/usr/local/lib/python2.7/dist-packages/ccmlib/node.py", line 1021, in 
> run_sstablemetadata
> return handle_external_tool_process(p, "sstablemetadata on keyspace: {}, 
> column_family: {}".format(keyspace, column_families))
>   File "/usr/local/lib/python2.7/dist-packages/ccmlib/node.py", line 1983, in 
> handle_external_tool_process
> raise ToolError(cmd_args, rc, out, err)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12725) dtest failure in repair_tests.incremental_repair_test.TestIncRepair.sstable_marking_test_not_intersecting_all_ranges

[Philip Thompson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Philip Thompson updated CASSANDRA-12725:

Status: Patch Available  (was: In Progress)

> dtest failure in 
> repair_tests.incremental_repair_test.TestIncRepair.sstable_marking_test_not_intersecting_all_ranges
> 
>
> Key: CASSANDRA-12725
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12725
> Project: Cassandra
>  Issue Type: Test
>Reporter: Sean McCarthy
>Assignee: Philip Thompson
>  Labels: dtest
>
> example failure:
> http://cassci.datastax.com/job/trunk_offheap_dtest/406/testReport/repair_tests.incremental_repair_test/TestIncRepair/sstable_marking_test_not_intersecting_all_ranges
> {code}
> Error Message
> Subprocess sstablemetadata on keyspace: keyspace1, column_family: None exited 
> with non-zero status; exit status: 1; 
> stdout: 
> usage: Usage: sstablemetadata [--gc_grace_seconds n] 
> Dump contents of given SSTable to standard output in JSON format.
> --gc_grace_secondsThe gc_grace_seconds to use when
>calculating droppable tombstones
> {code}
> {code}
> Stacktrace
>   File "/usr/lib/python2.7/unittest/case.py", line 329, in run
> testMethod()
>   File 
> "/home/automaton/cassandra-dtest/repair_tests/incremental_repair_test.py", 
> line 366, in sstable_marking_test_not_intersecting_all_ranges
> for out in (node.run_sstablemetadata(keyspace='keyspace1').stdout for 
> node in cluster.nodelist()):
>   File 
> "/home/automaton/cassandra-dtest/repair_tests/incremental_repair_test.py", 
> line 366, in 
> for out in (node.run_sstablemetadata(keyspace='keyspace1').stdout for 
> node in cluster.nodelist()):
>   File "/usr/local/lib/python2.7/dist-packages/ccmlib/node.py", line 1021, in 
> run_sstablemetadata
> return handle_external_tool_process(p, "sstablemetadata on keyspace: {}, 
> column_family: {}".format(keyspace, column_families))
>   File "/usr/local/lib/python2.7/dist-packages/ccmlib/node.py", line 1983, in 
> handle_external_tool_process
> raise ToolError(cmd_args, rc, out, err)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12149) NullPointerException on SELECT using index with token restrictions fully overriden by other PK restrictions

[Benjamin Lerer (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15603000#comment-15603000
 ] 

Benjamin Lerer commented on CASSANDRA-12149:


While thinking about it, I realized that the {{TokenFilter::isOnToken}} method 
might not return the correct result.
If we have a query like {{SELECT * FROM %s WHERE token(a, b) > token(10, 10) 
AND a < 8 AND b < 8 ALLOW FILTERING}}, as {{a}} and {{b}} have a non token 
restriction the {{TokenFilter::isOnToken}} method will return {{false}}. Due to 
that, Cassandra will believe that the query is not a range query and as the 
call to {{TokenFilter::needFiltering}} will return {{true}} in 
{{StatementRestrictions:getPartitionKeyBound}} the token restriction will be 
completely ignored.

The problem can be reproduced with the following test:
{code}
@Test
public void testFilteringOnAllPartitionKeysWithTokenRestriction() throws 
Throwable
{
createTable("CREATE TABLE %s (a int, b int, c int, d int, PRIMARY KEY 
((a, b), c))");

for (int i = 0; i < 10; i++)
{
execute("INSERT INTO %s (a,b,c,d) VALUES (?, ?, ?, ?)", i, i, i, i);
execute("INSERT INTO %s (a,b,c,d) VALUES (?, ?, ?, ?)", i, i + 10, 
i + 10, i + 10);
}

assertEmpty(execute("SELECT * FROM %s WHERE token(a, b) > token(10, 
10)"));
assertEmpty(execute("SELECT * FROM %s WHERE token(a, b) > token(10, 10) 
AND a < 8 AND b < 8 ALLOW FILTERING"));
}
{code}

Sorry for not noticing the problem sooner.

> NullPointerException on SELECT using index with token restrictions fully 
> overriden by other PK restrictions 
> 
>
> Key: CASSANDRA-12149
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12149
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Andrey Konstantinov
>Assignee: Alex Petrov
> Attachments: CASSANDRA-12149.txt
>
>
> If I execute the sequence of queries (see the attached file), Cassandra 
> aborts a connection reporting NPE on server side. SELECT query without token 
> range filter works, but does not work when token range filter is specified. 
> My intent was to issue multiple SELECT queries targeting the same single 
> partition, filtered by a column indexed by SASI, partitioning results by 
> different token ranges.
> Output from cqlsh on SELECT is the following:
> {code}
> cqlsh> SELECT namespace, entity, timestamp, feature1, feature2 FROM 
> mykeyspace.myrecordtable WHERE namespace = 'ns2' AND entity = 'entity2' AND 
> feature1 > 11 AND feature1 < 31  AND token(namespace, entity) <= 
> 9223372036854775807;
> ServerError:  message="java.lang.NullPointerException">
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12829) DELETE query with an empty IN clause can delete more than expected

[Alex Petrov (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15602967#comment-15602967
 ] 

Alex Petrov commented on CASSANDRA-12829:
-

{{DELETE}} in this case removes the whole partition, since there's just one 
clustering column and clustering list is empty.

{{UPDATE}} queries would also fail in this case with an exception:

{code}
java.lang.AssertionError: Invalid clustering for the table: 
org.apache.cassandra.db.Clustering$2@633128cf

at 
org.apache.cassandra.db.Clustering$Serializer.serialize(Clustering.java:130)
at 
org.apache.cassandra.db.rows.UnfilteredSerializer.serialize(UnfilteredSerializer.java:183)
at 
org.apache.cassandra.db.rows.UnfilteredSerializer.serialize(UnfilteredSerializer.java:132)
at 
org.apache.cassandra.db.rows.UnfilteredSerializer.serialize(UnfilteredSerializer.java:120)
at 
org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:137)
at 
org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:92)
at 
org.apache.cassandra.db.partitions.PartitionUpdate$PartitionUpdateSerializer.serialize(PartitionUpdate.java:790)
at 
org.apache.cassandra.db.Mutation$MutationSerializer.serialize(Mutation.java:393)
at org.apache.cassandra.db.commitlog.CommitLog.add(CommitLog.java:249)
at org.apache.cassandra.db.Keyspace.apply(Keyspace.java:522)
at org.apache.cassandra.db.Keyspace.apply(Keyspace.java:425)
{code}

I've prepared a patch (CI pending) that handles empty clustering correctly. 
This logic is slightly different from {{SELECT}} though.

> DELETE query with an empty IN clause can delete more than expected
> --
>
> Key: CASSANDRA-12829
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12829
> Project: Cassandra
>  Issue Type: Bug
>  Components: CQL
> Environment: Arch Linux x64, kernel 4.7.6, Cassandra 3.9 downloaded 
> from the website
>Reporter: Jason T. Bradshaw
>Assignee: Alex Petrov
>
> When deleting from a table with a certain structure and using an *in* clause 
> with an empty list, the *in* clause with an empty list can be ignored, 
> resulting in deleting more than is expected.
> *Setup:*
> {code}
> cqlsh> create table test (a text, b text, id uuid, primary key ((a, b), id));
> cqlsh> insert into test (a, b, id) values ('a', 'b', 
> ----);
> cqlsh> insert into test (a, b, id) values ('b', 'c', 
> ----);
> cqlsh> insert into test (a, b, id) values ('a', 'c', 
> ----);
> cqlsh> select * from test;
>  a | b | id
> ---+---+--
>  a | c | ----
>  b | c | ----
>  a | b | ----
> (3 rows)
> {code}
> *Expected:*
> {code}
> cqlsh> delete from test where a = 'a' and b in ('a', 'b', 'c') and id in ();
> cqlsh> select * from test;
>  a | b | id
> ---+---+--
>  a | c | ----
>  b | c | ----
>  a | b | ----
> (3 rows)
> {code}
> *Actual:*
> {code}
> cqlsh> delete from test where a = 'a' and b in ('a', 'b', 'c') and id in ();
> cqlsh> select * from test;
>  a | b | id
> ---+---+--
>  b | c | ----
> (1 rows)
> {code}
> Instead of deleting nothing, as the final empty *in* clause would imply, it 
> instead deletes everything that matches the first two clauses, acting as if 
> the following query had been issued instead:
> {code}
> cqlsh> delete from test where a = 'a' and b in ('a', 'b', 'c');
> {code}
> This seems to be related to the presence of a tuple clustering key, as I 
> could not reproduce it without one.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12822) dtest failure in compaction_test.TestCompaction_with_SizeTieredCompactionStrategy.fanout_size_test

[Philip Thompson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Philip Thompson updated CASSANDRA-12822:

Resolution: Fixed
Status: Resolved  (was: Patch Available)

> dtest failure in 
> compaction_test.TestCompaction_with_SizeTieredCompactionStrategy.fanout_size_test
> --
>
> Key: CASSANDRA-12822
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12822
> Project: Cassandra
>  Issue Type: Test
>Reporter: Sean McCarthy
>Assignee: Dikang Gu
>  Labels: dtest
> Attachments: node1.log, node1_debug.log, node1_gc.log
>
>
> example failure:
> http://cassci.datastax.com/job/trunk_dtest/1403/testReport/compaction_test/TestCompaction_with_SizeTieredCompactionStrategy/fanout_size_test
> {code}
> Error Message
> 75 != 74
> {code}{code}
> Stacktrace
>   File "/usr/lib/python2.7/unittest/case.py", line 329, in run
> testMethod()
>   File "/home/automaton/cassandra-dtest/tools/decorators.py", line 46, in 
> wrapped
> f(obj)
>   File "/home/automaton/cassandra-dtest/compaction_test.py", line 553, in 
> fanout_size_test
> self.assertEqual(25 * len(node1.data_directories()), int(m.group(2)))
>   File "/usr/lib/python2.7/unittest/case.py", line 513, in assertEqual
> assertion_func(first, second, msg=msg)
>   File "/usr/lib/python2.7/unittest/case.py", line 506, in _baseAssertEqual
> raise self.failureException(msg)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (CASSANDRA-12836) Set JOINING mode before executing the pre-join index callback

[Sergio Bossa (JIRA)]

Sergio Bossa created CASSANDRA-12836:


 Summary: Set JOINING mode before executing the pre-join index 
callback
 Key: CASSANDRA-12836
 URL: https://issues.apache.org/jira/browse/CASSANDRA-12836
 Project: Cassandra
  Issue Type: Bug
Reporter: Sergio Bossa
Assignee: Sergio Bossa


The pre-join index callback introduced by CASSANDRA-12039 might perform long 
running tasks, and given it's blocking, it would be good to set the node in 
JOINING mode, which currently only happens in case of bootstrap, so that:
1) The mode can be properly read by tools.
2) Async callback implementation can read the mode themselves to verify at 
which point of the startup process they are executing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-6719) redesign loadnewsstables

[Bhaskar Muppana (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-6719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15602673#comment-15602673
 ] 

Bhaskar Muppana commented on CASSANDRA-6719:


Thanks for the fix [~MarkReddy]. This is quite useful. I have couple of 
comments on patch.


* In your patch I see you are using {{getWriteableLocationAsFile()}} to get the 
data directory to move the SSTable into. Here, we can reduce the disk overhead, 
by taking advantage of the possibility that external SSTable directory provided 
by user could be on the same disk partition as one of the Cassandra data 
directories, if so we can just use that as data directory. As same partition 
move would be simple inode operations. Between partitions that will involve lot 
of unnecessary data copy taking extra disk ops having effect on read/write 
latencies. I am suggesting using a function like below instead
{code:java|borderStyle=solid}
public File getWriteableLocationForLoadingAsFile(final File sourceFile) 
throws IOException
{
final FileStore srcFileStore = Files.getFileStore(sourceFile.toPath());
for (final DataDirectory dataDir : paths)
{
if 
(BlacklistedDirectories.isUnwritable(getLocationForDisk(dataDir)))
{
logger.trace("removing blacklisted candidate {}", 
dataDir.location);
continue;
}

final File dataPath = getLocationForDisk(dataDir);
if (Files.getFileStore(dataPath.toPath()).equals(srcFileStore))
{
return dataPath;
}
}

return getWriteableLocationAsFile(sourceFile.length());
}
{code}
* Does it make sense to provide an option weather to move or just copy SSTables 
to user? So, user will have SSTables even after completing {{nodetool 
refresh}}. I agree, default has to be moving SSTables.
* Shall we make SSTableLister a static class not depending on Directories 
object. So, the definition would be less ambiguous as the constructor either 
means it is working on dataDirectories or just on external directory but linked 
to directories object in both cases.
{code:java|borderStyle=solid}
public static class SSTableLister
{
  public SSTableLister(List directory, OnTxnErr onTxnErr, String 
keyspace, String table)
  {

  }
}
{code}


> redesign loadnewsstables
> 
>
> Key: CASSANDRA-6719
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6719
> Project: Cassandra
>  Issue Type: New Feature
>  Components: Tools
>Reporter: Jonathan Ellis
>Priority: Minor
>  Labels: lhf
> Fix For: 3.x
>
> Attachments: 6719.patch
>
>
> CFSMBean.loadNewSSTables scans data directories for new sstables dropped 
> there by an external agent.  This is dangerous because of possible filename 
> conflicts with existing or newly generated sstables.
> Instead, we should support leaving the new sstables in a separate directory 
> (specified by a parameter, or configured as a new location in yaml) and take 
> care of renaming as necessary automagically.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-10855) Use Caffeine (W-TinyLFU) for on-heap caches

[Ben Manes (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15602688#comment-15602688
 ] 

Ben Manes commented on CASSANDRA-10855:
---

The test failure might be due to delegating maintenance work (e.g. writes 
triggering an eviction) to an executor. CLHM and Guava amortized this on the 
calling threads, whereas Caffeine tries to hide it on ForkJoinPool to minimize 
user-facing latencies. By setting Caffeine.executor(Runnable::run) it will 
behave similar to its predecessors, ideally set only in tests for 
predictability. Alternatively calling cache.cleanUp() prior to inspecting is 
another easy alternative.

I don't want to delay this again, but would like to ensure Cassandra updates to 
the upcoming 2.3.4 release. There is a difficult to trigger 
[race|https://github.com/ben-manes/caffeine/issues/127] in JCTools that we 
fixed over the weekend.

> Use Caffeine (W-TinyLFU) for on-heap caches
> ---
>
> Key: CASSANDRA-10855
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10855
> Project: Cassandra
>  Issue Type: Improvement
>Reporter: Ben Manes
>  Labels: performance
> Attachments: CASSANDRA-10855.patch, CASSANDRA-10855.patch
>
>
> Cassandra currently uses 
> [ConcurrentLinkedHashMap|https://code.google.com/p/concurrentlinkedhashmap] 
> for performance critical caches (key, counter) and Guava's cache for 
> non-critical (auth, metrics, security). All of these usages have been 
> replaced by [Caffeine|https://github.com/ben-manes/caffeine], written by the 
> author of the previously mentioned libraries.
> The primary incentive is to switch from LRU policy to W-TinyLFU, which 
> provides [near optimal|https://github.com/ben-manes/caffeine/wiki/Efficiency] 
> hit rates. It performs particularly well in database and search traces, is 
> scan resistant, and as adds a very small time/space overhead to LRU.
> Secondarily, Guava's caches never obtained similar 
> [performance|https://github.com/ben-manes/caffeine/wiki/Benchmarks] to CLHM 
> due to some optimizations not being ported over. This change results in 
> faster reads and not creating garbage as a side-effect.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12805) Website documentation for commitlog

[Hau Phan (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hau Phan updated CASSANDRA-12805:
-
Description: 
Updated Storage Engine page for commitlogs

Commit: 
https://github.com/nothau/cassandra/commit/0c461134b18c75bbd63b18186547a6428f865422


  was:
Updated Storage Engine page for commitlogs

Commit: 
https://github.com/nothau/cassandra/commit/b8b8b6c18d4ab19558b5489f73ebc4f6ffdb52f1



> Website documentation for commitlog
> ---
>
> Key: CASSANDRA-12805
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12805
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Documentation and Website
>Reporter: Hau Phan
>Priority: Minor
>  Labels: documentation
> Attachments: 12805-trunk.txt
>
>
> Updated Storage Engine page for commitlogs
> Commit: 
> https://github.com/nothau/cassandra/commit/0c461134b18c75bbd63b18186547a6428f865422



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12805) Website documentation for commitlog

[Hau Phan (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hau Phan updated CASSANDRA-12805:
-
Attachment: 12805-trunk.txt

> Website documentation for commitlog
> ---
>
> Key: CASSANDRA-12805
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12805
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Documentation and Website
>Reporter: Hau Phan
>Priority: Minor
>  Labels: documentation
> Attachments: 12805-trunk.txt
>
>
> Updated Storage Engine page for commitlogs
> Commit: 
> https://github.com/nothau/cassandra/commit/0c461134b18c75bbd63b18186547a6428f865422



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12805) Website documentation for commitlog

[Hau Phan (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15602534#comment-15602534
 ] 

Hau Phan commented on CASSANDRA-12805:
--

Updated commit and patch file per Romain Hardouin comments.

> Website documentation for commitlog
> ---
>
> Key: CASSANDRA-12805
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12805
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Documentation and Website
>Reporter: Hau Phan
>Priority: Minor
>  Labels: documentation
> Attachments: 12805-trunk.txt
>
>
> Updated Storage Engine page for commitlogs
> Commit: 
> https://github.com/nothau/cassandra/commit/0c461134b18c75bbd63b18186547a6428f865422



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12805) Website documentation for commitlog

[Hau Phan (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hau Phan updated CASSANDRA-12805:
-
Attachment: (was: 12805-trunk.txt)

> Website documentation for commitlog
> ---
>
> Key: CASSANDRA-12805
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12805
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Documentation and Website
>Reporter: Hau Phan
>Priority: Minor
>  Labels: documentation
> Attachments: 12805-trunk.txt
>
>
> Updated Storage Engine page for commitlogs
> Commit: 
> https://github.com/nothau/cassandra/commit/0c461134b18c75bbd63b18186547a6428f865422



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12835) Tracing payload not passed from QueryMessage to tracing session

[JIRA]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hannu Kröger updated CASSANDRA-12835:
-
Reproduced In: 3.x

> Tracing payload not passed from QueryMessage to tracing session
> ---
>
> Key: CASSANDRA-12835
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12835
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Hannu Kröger
>Priority: Critical
>  Labels: tracing
>
> Caused by CASSANDRA-10392.
> Related to CASSANDRA-11706.
> When querying using CQL statements (not prepared) the message type is 
> QueryMessage and the code in 
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/transport/messages/QueryMessage.java#L101
>  is as follows:
> {code:java}
> if (state.traceNextQuery())
> {
> state.createTracingSession();
> ImmutableMap.Builder builder = 
> ImmutableMap.builder();
> {code}
> {{state.createTracingSession();}} should probably be 
> {{state.createTracingSession(getCustomPayload());}}. At least that fixes the 
> problem for me.
> This also raises the question whether some other parts of the code should 
> pass the custom payload as well (I'm not the right person to analyze this):
> {code}
> $ ag createTracingSession
> src/java/org/apache/cassandra/service/QueryState.java
> 80:public void createTracingSession()
> 82:createTracingSession(Collections.EMPTY_MAP);
> 85:public void createTracingSession(Map customPayload)
> src/java/org/apache/cassandra/thrift/CassandraServer.java
> 2528:state().getQueryState().createTracingSession();
> src/java/org/apache/cassandra/transport/messages/BatchMessage.java
> 163:state.createTracingSession();
> src/java/org/apache/cassandra/transport/messages/ExecuteMessage.java
> 114:state.createTracingSession(getCustomPayload());
> src/java/org/apache/cassandra/transport/messages/QueryMessage.java
> 101:state.createTracingSession();
> src/java/org/apache/cassandra/transport/messages/PrepareMessage.java
> 74:state.createTracingSession();
> {code}
> This is not marked as `minor` as the CASSANDRA-11706 was because this cannot 
> be fixed by the tracing plugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12620) Resurrected empty rows on update to 3.x

[Michael Guissine (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15602304#comment-15602304
 ] 

Michael Guissine commented on CASSANDRA-12620:
--

[~blerer] Unfortunately we don't have backups of the data from pre-upgrade, 
those have been purged a while back. 

> Resurrected empty rows on update to 3.x
> ---
>
> Key: CASSANDRA-12620
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12620
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Collin Sauve
>Assignee: Benjamin Lerer
>
> We had the below table on C* 2.x (dse 4.8.4, we assume was 2.1.15.1423 
> according to documentation), and were entering TTLs at write-time using the 
> DataStax C# Driver (using the POCO mapper).
> Upon upgrade to 3.0.8.1293 (DSE 5.0.2), we are seeing a lot of rows that:
> * should have been TTL'd
> * have no non-primary-key column data
> {code}
> CREATE TABLE applicationservices.aggregate_bucket_event_v3 (
> bucket_type int,
> bucket_id text,
> date timestamp,
> aggregate_id text,
> event_type int,
> event_id text,
> entities list>>,
> identity_sid text,
> PRIMARY KEY ((bucket_type, bucket_id), date, aggregate_id, event_type, 
> event_id)
> ) WITH CLUSTERING ORDER BY (date DESC, aggregate_id ASC, event_type ASC, 
> event_id ASC)
> AND bloom_filter_fp_chance = 0.1
> AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'}
> AND comment = ''
> AND compaction = {'class': 
> 'org.apache.cassandra.db.compaction.LeveledCompactionStrategy'}
> AND compression = {'chunk_length_in_kb': '64', 'class': 
> 'org.apache.cassandra.io.compress.LZ4Compressor'}
> AND crc_check_chance = 1.0
> AND dclocal_read_repair_chance = 0.1
> AND default_time_to_live = 0
> AND gc_grace_seconds = 864000
> AND max_index_interval = 2048
> AND memtable_flush_period_in_ms = 0
> AND min_index_interval = 128
> AND read_repair_chance = 0.0
> AND speculative_retry = '99PERCENTILE';
> {code}
> {code}
> {
> "partition" : {
>   "key" : [ "0", "26492" ],
>   "position" : 54397932
> },
> "rows" : [
>   {
> "type" : "row",
> "position" : 54397961,
> "clustering" : [ "2016-09-07 23:33Z", "3651664", "0", 
> "773665449947099136" ],
> "liveness_info" : { "tstamp" : "2016-09-07T23:34:09.758Z", "ttl" : 
> 172741, "expires_at" : "2016-09-09T23:33:10Z", "expired" : false },
> "cells" : [
>   { "name" : "identity_sid", "value" : "p_tw_zahidana" },
>   { "name" : "entities", "deletion_info" : { "marked_deleted" : 
> "2016-09-07T23:34:09.757999Z", "local_delete_time" : "2016-09-07T23:34:09Z" } 
> },
>   { "name" : "entities", "path" : [ 
> "936e17e1-7553-11e6-9b92-29a33b5827c3" ], "value" : 
> "0:https\\://www.youtube.com/watch?v=pwAJAssv6As" },
>   { "name" : "entities", "path" : [ 
> "936e17e2-7553-11e6-9b92-29a33b5827c3" ], "value" : "2:youtube" }
> ]
>   },
>   {
> "type" : "row",
>},
>   {
> "type" : "row",
> "position" : 54397177,
> "clustering" : [ "2016-08-17 10:00Z", "6387376", "0", 
> "765850666296225792" ],
> "liveness_info" : { "tstamp" : "2016-08-17T11:26:15.917001Z" },
> "cells" : [ ]
>   },
>   {
> "type" : "row",
> "position" : 54397227,
> "clustering" : [ "2016-08-17 07:00Z", "6387376", "0", 
> "765805367347601409" ],
> "liveness_info" : { "tstamp" : "2016-08-17T08:11:17.587Z" },
> "cells" : [ ]
>   },
>   {
> "type" : "row",
> "position" : 54397276,
> "clustering" : [ "2016-08-17 04:00Z", "6387376", "0", 
> "765760069858365441" ],
> "liveness_info" : { "tstamp" : "2016-08-17T05:58:11.228Z" },
> "cells" : [ ]
>   },
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12835) Tracing payload not passed from QueryMessage to tracing session

[JIRA]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hannu Kröger updated CASSANDRA-12835:
-
Description: 
Caused by CASSANDRA-10392.
Related to CASSANDRA-11706.

When querying using CQL statements (not prepared) the message type is 
QueryMessage and the code in 
https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/transport/messages/QueryMessage.java#L101
 is as follows:
{code:java}
if (state.traceNextQuery())
{
state.createTracingSession();

ImmutableMap.Builder builder = 
ImmutableMap.builder();
{code}

{{state.createTracingSession();}} should probably be 
{{state.createTracingSession(getCustomPayload());}}. At least that fixes the 
problem for me.

This also raises the question whether some other parts of the code should pass 
the custom payload as well (I'm not the right person to analyze this):
{code}
$ ag createTracingSession
src/java/org/apache/cassandra/service/QueryState.java
80:public void createTracingSession()
82:createTracingSession(Collections.EMPTY_MAP);
85:public void createTracingSession(Map customPayload)

src/java/org/apache/cassandra/thrift/CassandraServer.java
2528:state().getQueryState().createTracingSession();

src/java/org/apache/cassandra/transport/messages/BatchMessage.java
163:state.createTracingSession();

src/java/org/apache/cassandra/transport/messages/ExecuteMessage.java
114:state.createTracingSession(getCustomPayload());

src/java/org/apache/cassandra/transport/messages/QueryMessage.java
101:state.createTracingSession();

src/java/org/apache/cassandra/transport/messages/PrepareMessage.java
74:state.createTracingSession();
{code}

This is not marked as `minor` as the CASSANDRA-11706 was because this cannot be 
fixed by the tracing plugin.

  was:
Caused by CASSANDRA-10392.
Related to CASSANDRA-11706.

When querying using CQL statements (not prepared) the message type is 
QueryMessage and the code in 
https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/transport/messages/QueryMessage.java#L101
 is as follows:
{code:java}
if (state.traceNextQuery())
{
state.createTracingSession();

ImmutableMap.Builder builder = 
ImmutableMap.builder();
{code}

`state.createTracingSession();` should probably be 
`state.createTracingSession(getCustomPayload());`. At least that fixes the 
problem for me.

This is not marked as `minor` as the CASSANDRA-11706 was because this cannot be 
fixed by the tracing plugin.


> Tracing payload not passed from QueryMessage to tracing session
> ---
>
> Key: CASSANDRA-12835
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12835
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Hannu Kröger
>Priority: Critical
>  Labels: tracing
>
> Caused by CASSANDRA-10392.
> Related to CASSANDRA-11706.
> When querying using CQL statements (not prepared) the message type is 
> QueryMessage and the code in 
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/transport/messages/QueryMessage.java#L101
>  is as follows:
> {code:java}
> if (state.traceNextQuery())
> {
> state.createTracingSession();
> ImmutableMap.Builder builder = 
> ImmutableMap.builder();
> {code}
> {{state.createTracingSession();}} should probably be 
> {{state.createTracingSession(getCustomPayload());}}. At least that fixes the 
> problem for me.
> This also raises the question whether some other parts of the code should 
> pass the custom payload as well (I'm not the right person to analyze this):
> {code}
> $ ag createTracingSession
> src/java/org/apache/cassandra/service/QueryState.java
> 80:public void createTracingSession()
> 82:createTracingSession(Collections.EMPTY_MAP);
> 85:public void createTracingSession(Map customPayload)
> src/java/org/apache/cassandra/thrift/CassandraServer.java
> 2528:state().getQueryState().createTracingSession();
> src/java/org/apache/cassandra/transport/messages/BatchMessage.java
> 163:state.createTracingSession();
> src/java/org/apache/cassandra/transport/messages/ExecuteMessage.java
> 114:state.createTracingSession(getCustomPayload());
> src/java/org/apache/cassandra/transport/messages/QueryMessage.java
> 101:state.createTracingSession();
> src/java/org/apache/cassandra/transport/messages/PrepareMessage.java
> 74:state.createTracingSession();
> {code}
> This is not marked as `minor` as the 

[jira] [Updated] (CASSANDRA-12835) Tracing payload not passed from QueryMessage to tracing session

[JIRA]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hannu Kröger updated CASSANDRA-12835:
-
Description: 
Caused by CASSANDRA-10392.
Related to CASSANDRA-11706.

When querying using CQL statements (not prepared) the message type is 
QueryMessage and the code in 
https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/transport/messages/QueryMessage.java#L101
 is as follows:
{code:java}
if (state.traceNextQuery())
{
state.createTracingSession();

ImmutableMap.Builder builder = 
ImmutableMap.builder();
{code}

`state.createTracingSession();` should probably be 
`state.createTracingSession(getCustomPayload());`. At least that fixes the 
problem for me.

This is not marked as `minor` as the CASSANDRA-11706 was because this cannot be 
fixed by the tracing plugin.

  was:
Caused by CASSANDRA-10392.
Related to CASSANDRA-11706.

When querying using CQL statements (not prepared) the message type is 
QueryMessage and the code in 
https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/transport/messages/QueryMessage.java#L101
 is as follows:
```
if (state.traceNextQuery())
{
state.createTracingSession();

ImmutableMap.Builder builder = 
ImmutableMap.builder();
```

`state.createTracingSession();` should probably be 
`state.createTracingSession(getCustomPayload());`. At least that fixes the 
problem for me.

This is not marked as `minor` as the CASSANDRA-11706 was because this cannot be 
fixed by the tracing plugin.


> Tracing payload not passed from QueryMessage to tracing session
> ---
>
> Key: CASSANDRA-12835
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12835
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Hannu Kröger
>Priority: Critical
>  Labels: tracing
>
> Caused by CASSANDRA-10392.
> Related to CASSANDRA-11706.
> When querying using CQL statements (not prepared) the message type is 
> QueryMessage and the code in 
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/transport/messages/QueryMessage.java#L101
>  is as follows:
> {code:java}
> if (state.traceNextQuery())
> {
> state.createTracingSession();
> ImmutableMap.Builder builder = 
> ImmutableMap.builder();
> {code}
> `state.createTracingSession();` should probably be 
> `state.createTracingSession(getCustomPayload());`. At least that fixes the 
> problem for me.
> This is not marked as `minor` as the CASSANDRA-11706 was because this cannot 
> be fixed by the tracing plugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12835) Tracing payload not passed from QueryMessage to tracing session

[JIRA]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hannu Kröger updated CASSANDRA-12835:
-
Description: 
Caused by CASSANDRA-10392.
Related to CASSANDRA-11706.

When querying using CQL statements (not prepared) the message type is 
QueryMessage and the code in 
https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/transport/messages/QueryMessage.java#L101
 is as follows:
```
if (state.traceNextQuery())
{
state.createTracingSession();

ImmutableMap.Builder builder = 
ImmutableMap.builder();
```

`state.createTracingSession();` should probably be 
`state.createTracingSession(getCustomPayload());`. At least that fixes the 
problem for me.

This is not marked as `minor` as the CASSANDRA-11706 was because this cannot be 
fixed by the tracing plugin.

> Tracing payload not passed from QueryMessage to tracing session
> ---
>
> Key: CASSANDRA-12835
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12835
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Hannu Kröger
>Priority: Critical
>  Labels: tracing
>
> Caused by CASSANDRA-10392.
> Related to CASSANDRA-11706.
> When querying using CQL statements (not prepared) the message type is 
> QueryMessage and the code in 
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/transport/messages/QueryMessage.java#L101
>  is as follows:
> ```
> if (state.traceNextQuery())
> {
> state.createTracingSession();
> ImmutableMap.Builder builder = 
> ImmutableMap.builder();
> ```
> `state.createTracingSession();` should probably be 
> `state.createTracingSession(getCustomPayload());`. At least that fixes the 
> problem for me.
> This is not marked as `minor` as the CASSANDRA-11706 was because this cannot 
> be fixed by the tracing plugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (CASSANDRA-12835) Tracing payload not passed from QueryMessage to tracing session

[JIRA]

Hannu Kröger created CASSANDRA-12835:


 Summary: Tracing payload not passed from QueryMessage to tracing 
session
 Key: CASSANDRA-12835
 URL: https://issues.apache.org/jira/browse/CASSANDRA-12835
 Project: Cassandra
  Issue Type: Bug
Reporter: Hannu Kröger
Priority: Critical






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-6696) Partition sstables by token range

[Carl Yeksigian (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-6696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carl Yeksigian updated CASSANDRA-6696:
--
Component/s: Compaction

> Partition sstables by token range
> -
>
> Key: CASSANDRA-6696
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6696
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Compaction
>Reporter: sankalp kohli
>Assignee: Marcus Eriksson
>  Labels: compaction, correctness, dense-storage, doc-impacting, 
> jbod-aware-compaction, lcs, performance
> Fix For: 3.2, 3.3
>
>
> In JBOD, when someone gets a bad drive, the bad drive is replaced with a new 
> empty one and repair is run. 
> This can cause deleted data to come back in some cases. Also this is true for 
> corrupt stables in which we delete the corrupt stable and run repair. 
> Here is an example:
> Say we have 3 nodes A,B and C and RF=3 and GC grace=10days. 
> row=sankalp col=sankalp is written 20 days back and successfully went to all 
> three nodes. 
> Then a delete/tombstone was written successfully for the same row column 15 
> days back. 
> Since this tombstone is more than gc grace, it got compacted in Nodes A and B 
> since it got compacted with the actual data. So there is no trace of this row 
> column in node A and B.
> Now in node C, say the original data is in drive1 and tombstone is in drive2. 
> Compaction has not yet reclaimed the data and tombstone.  
> Drive2 becomes corrupt and was replaced with new empty drive. 
> Due to the replacement, the tombstone in now gone and row=sankalp col=sankalp 
> has come back to life. 
> Now after replacing the drive we run repair. This data will be propagated to 
> all nodes. 
> Note: This is still a problem even if we run repair every gc grace. 
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted

[Carl Yeksigian (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carl Yeksigian updated CASSANDRA-8805:
--
Component/s: Compaction

> runWithCompactionsDisabled only cancels compactions, which is not the only 
> source of markCompacted
> --
>
> Key: CASSANDRA-8805
> URL: https://issues.apache.org/jira/browse/CASSANDRA-8805
> Project: Cassandra
>  Issue Type: Bug
>  Components: Compaction
>Reporter: Benedict
>Assignee: Carl Yeksigian
> Fix For: 2.1.13, 2.2.5, 3.0.3, 3.2
>
> Attachments: 8805-2.1.txt
>
>
> Operations like repair that may operate over all sstables cancel compactions 
> before beginning, and fail if there are any files marked compacting after 
> doing so. Redistribution of index summaries is not a compaction, so is not 
> cancelled by this action, but does mark sstables as compacting, so such an 
> action will fail to initiate if there is an index summary redistribution in 
> progress. It seems that IndexSummaryManager needs to register itself as 
> interruptible along with compactions (AFAICT no other actions that may 
> markCompacting are not themselves compactions).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-10863) HSHA test_closing_connections test still flaps on 3.0

[Carl Yeksigian (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-10863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carl Yeksigian updated CASSANDRA-10863:
---
Component/s: Testing

> HSHA test_closing_connections test still flaps on 3.0
> -
>
> Key: CASSANDRA-10863
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10863
> Project: Cassandra
>  Issue Type: Sub-task
>  Components: Testing
>Reporter: Jim Witschey
>Assignee: Carl Yeksigian
> Fix For: 3.0.3
>
>
> The problem reported in CASSANDRA-10570 still seems to be happening on 
> CassCI, as recently as a couple days ago:
> http://cassci.datastax.com/job/cassandra-3.0_dtest/433/
> [~carlyeks] The fix in #10570 was to increase how long we'd sleep in the 
> tests. Should we just bump it up further, or does this make you suspect a 
> larger problem here?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-10829) cleanup + repair generates a lot of logs

[Carl Yeksigian (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-10829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carl Yeksigian updated CASSANDRA-10829:
---
Component/s: Streaming and Messaging

> cleanup + repair generates a lot of logs
> 
>
> Key: CASSANDRA-10829
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10829
> Project: Cassandra
>  Issue Type: Bug
>  Components: Streaming and Messaging
> Environment: 5 nodes on Cassandra 2.1.11 (on Debian)
>Reporter: Fabien Rousseau
>Assignee: Marcus Eriksson
> Fix For: 2.1.13, 2.2.5, 3.0.3, 3.3
>
>
> One of our node generates a lot of cassandra logs (int the 10 MB/s) and CPU 
> usage has increased (by a factor 2-3).
> This was most probably triggered by a "nodetool snapshot" while a cleanup was 
> already running on this node.
> An example of those logs:
> 2015-12-08 09:15:17,794 INFO  
> [ValidationExecutor:689]ColumnFamilyStore.java:1923 Spinning trying to 
> capture released readers [...]
> 2015-12-08 09:15:17,794 INFO  
> [ValidationExecutor:689]ColumnFamilyStore.java:1924 Spinning trying to 
> capture all readers [...]
> 2015-12-08 09:15:17,795 INFO  
> [ValidationExecutor:689]ColumnFamilyStore.java:1923 Spinning trying to 
> capture released readers [...]
> 2015-12-08 09:15:17,795 INFO  
> [ValidationExecutor:689]ColumnFamilyStore.java:1924 Spinning trying to 
> capture all readers [...]
> (I removed SSTableReader information because it's rather long... I can share 
> it privately if needed)
> Note that the date has not been changed (only 1ms between logs)
> It should not generate that gigantic amount of logs :)
> This is probably linked to: 
> https://issues.apache.org/jira/browse/CASSANDRA-9637



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-10795) Improve Failure Detector Unknown EP message

[Carl Yeksigian (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-10795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carl Yeksigian updated CASSANDRA-10795:
---
Component/s: Observability

> Improve Failure Detector Unknown EP message
> ---
>
> Key: CASSANDRA-10795
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10795
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Observability
>Reporter: Anthony Cozzie
>Assignee: Anthony Cozzie
>Priority: Minor
> Fix For: 3.2
>
> Attachments: trunk-10795-2.txt, trunk-10795.txt
>
>
> When the failure detector is asked whether an unknown endpoint is alive, it 
> prints an uninformative error message.  This patch adds a stack trace to the 
> print statement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-10652) Tracing prevents startup after upgrading

[Carl Yeksigian (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-10652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carl Yeksigian updated CASSANDRA-10652:
---
Component/s: Observability

> Tracing prevents startup after upgrading
> 
>
> Key: CASSANDRA-10652
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10652
> Project: Cassandra
>  Issue Type: Bug
>  Components: Observability
>Reporter: Carl Yeksigian
>Assignee: Sylvain Lebresne
>Priority: Blocker
> Fix For: 2.2.4, 3.0.0
>
>
> After upgrading from 2.1 to 3.0, the {{system_traces.sessions}} table is not 
> properly upgraded to include the {{client}} column added in CASSANDRA-8162. 
> Just upgrading from a clean 2.2 install to 3.0 won't show this error because 
> the column was included in 2.2, it just doesn't break the queries in that 
> release.
> The errors I get when querying {{system_traces.sessions}}:
> {noformat}
> java.lang.RuntimeException: java.lang.IllegalStateException: 
> [ColumnDefinition{name=client, 
> type=org.apache.cassandra.db.marshal.InetAddressType, kind=REGULAR, 
> position=-1}, ColumnDefinition{name=command, 
> type=org.apache.cassandra.db.marshal.UTF8Type, kind=REGULAR, position=-1}, 
> ColumnDefinition{name=coordinator, 
> type=org.apache.cassandra.db.marshal.InetAddressType, kind=REGULAR, 
> position=-1}, ColumnDefinition{name=duration, 
> type=org.apache.cassandra.db.marshal.Int32Type, kind=REGULAR, position=-1}, 
> ColumnDefinition{name=request, type=org.apache.cassandra.db.marshal.UTF8Type, 
> kind=REGULAR, position=-1}, ColumnDefinition{name=started_at, 
> type=org.apache.cassandra.db.marshal.TimestampType, kind=REGULAR, 
> position=-1}, ColumnDefinition{name=parameters, 
> type=org.apache.cassandra.db.marshal.MapType(org.apache.cassandra.db.marshal.UTF8Type,org.apache.cassandra.db.marshal.UTF8Type),
>  kind=REGULAR, position=-1}] is not a subset of [coordinator duration request 
> started_at parameters]
>   at 
> org.apache.cassandra.service.StorageProxy$DroppableRunnable.run(StorageProxy.java:2350)
>  ~[main/:na]
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
> ~[na:1.8.0_45]
>   at 
> org.apache.cassandra.concurrent.AbstractTracingAwareExecutorService$FutureTask.run(AbstractTracingAwareExecutorService.java:164)
>  ~[main/:na]
>   at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:105) 
> [main/:na]
>   at java.lang.Thread.run(Thread.java:745) [na:1.8.0_45]
> Caused by: java.lang.IllegalStateException: [ColumnDefinition{name=client, 
> type=org.apache.cassandra.db.marshal.InetAddressType, kind=REGULAR, 
> position=-1}, ColumnDefinition{name=command, 
> type=org.apache.cassandra.db.marshal.UTF8Type, kind=REGULAR, position=-1}, 
> ColumnDefinition{name=coordinator, 
> type=org.apache.cassandra.db.marshal.InetAddressType, kind=REGULAR, 
> position=-1}, ColumnDefinition{name=duration, 
> type=org.apache.cassandra.db.marshal.Int32Type, kind=REGULAR, position=-1}, 
> ColumnDefinition{name=request, type=org.apache.cassandra.db.marshal.UTF8Type, 
> kind=REGULAR, position=-1}, ColumnDefinition{name=started_at, 
> type=org.apache.cassandra.db.marshal.TimestampType, kind=REGULAR, 
> position=-1}, ColumnDefinition{name=parameters, 
> type=org.apache.cassandra.db.marshal.MapType(org.apache.cassandra.db.marshal.UTF8Type,org.apache.cassandra.db.marshal.UTF8Type),
>  kind=REGULAR, position=-1}] is not a subset of [coordinator duration request 
> started_at parameters]
>   at 
> org.apache.cassandra.db.Columns$Serializer.encodeBitmap(Columns.java:531) 
> ~[main/:na]
>   at 
> org.apache.cassandra.db.Columns$Serializer.serializeSubset(Columns.java:465) 
> ~[main/:na]
>   at 
> org.apache.cassandra.db.rows.UnfilteredSerializer.serialize(UnfilteredSerializer.java:178)
>  ~[main/:na]
>   at 
> org.apache.cassandra.db.rows.UnfilteredSerializer.serialize(UnfilteredSerializer.java:108)
>  ~[main/:na]
>   at 
> org.apache.cassandra.db.rows.UnfilteredSerializer.serialize(UnfilteredSerializer.java:96)
>  ~[main/:na]
>   at 
> org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:132)
>  ~[main/:na]
>   at 
> org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:87)
>  ~[main/:na]
>   at 
> org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:77)
>  ~[main/:na]
>   at 
> org.apache.cassandra.db.partitions.UnfilteredPartitionIterators$Serializer.serialize(UnfilteredPartitionIterators.java:298)
>  ~[main/:na]
>   at 
> org.apache.cassandra.db.ReadResponse$LocalDataResponse.build(ReadResponse.java:136)
>  ~[main/:na]
>   at 
> 

[jira] [Updated] (CASSANDRA-10909) NPE in ActiveRepairService

[Carl Yeksigian (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-10909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carl Yeksigian updated CASSANDRA-10909:
---
Component/s: Streaming and Messaging

> NPE in ActiveRepairService 
> ---
>
> Key: CASSANDRA-10909
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10909
> Project: Cassandra
>  Issue Type: Bug
>  Components: Streaming and Messaging
> Environment: cassandra-3.0.1.777
>Reporter: Eduard Tudenhoefner
>Assignee: Marcus Eriksson
> Fix For: 2.1.13, 2.2.5, 3.0.3, 3.3
>
>
> NPE after one started multiple incremental repairs
> {code}
> INFO  [Thread-62] 2015-12-21 11:40:53,742  RepairRunnable.java:125 - Starting 
> repair command #1, repairing keyspace keyspace1 with repair options 
> (parallelism: parallel, primary range: false, incremental: true, job threads: 
> 1, ColumnFamilies: [], dataCenters: [], hosts: [], # of ranges: 2)
> INFO  [Thread-62] 2015-12-21 11:40:53,813  RepairSession.java:237 - [repair 
> #b13e3740-a7d7-11e5-b568-f565b837eb0d] new session: will sync /10.200.177.32, 
> /10.200.177.33 on range [(10,-9223372036854775808]] for keyspace1.[counter1, 
> standard1]
> INFO  [Repair#1:1] 2015-12-21 11:40:53,853  RepairJob.java:100 - [repair 
> #b13e3740-a7d7-11e5-b568-f565b837eb0d] requesting merkle trees for counter1 
> (to [/10.200.177.33, /10.200.177.32])
> INFO  [Repair#1:1] 2015-12-21 11:40:53,853  RepairJob.java:174 - [repair 
> #b13e3740-a7d7-11e5-b568-f565b837eb0d] Requesting merkle trees for counter1 
> (to [/10.200.177.33, /10.200.177.32])
> INFO  [Thread-62] 2015-12-21 11:40:53,854  RepairSession.java:237 - [repair 
> #b1449fe0-a7d7-11e5-b568-f565b837eb0d] new session: will sync /10.200.177.32, 
> /10.200.177.31 on range [(0,10]] for keyspace1.[counter1, standard1]
> INFO  [AntiEntropyStage:1] 2015-12-21 11:40:53,896  RepairSession.java:181 - 
> [repair #b13e3740-a7d7-11e5-b568-f565b837eb0d] Received merkle tree for 
> counter1 from /10.200.177.32
> INFO  [AntiEntropyStage:1] 2015-12-21 11:40:53,906  RepairSession.java:181 - 
> [repair #b13e3740-a7d7-11e5-b568-f565b837eb0d] Received merkle tree for 
> counter1 from /10.200.177.33
> INFO  [Repair#1:1] 2015-12-21 11:40:53,906  RepairJob.java:100 - [repair 
> #b13e3740-a7d7-11e5-b568-f565b837eb0d] requesting merkle trees for standard1 
> (to [/10.200.177.33, /10.200.177.32])
> INFO  [Repair#1:1] 2015-12-21 11:40:53,906  RepairJob.java:174 - [repair 
> #b13e3740-a7d7-11e5-b568-f565b837eb0d] Requesting merkle trees for standard1 
> (to [/10.200.177.33, /10.200.177.32])
> INFO  [RepairJobTask:2] 2015-12-21 11:40:53,910  SyncTask.java:66 - [repair 
> #b13e3740-a7d7-11e5-b568-f565b837eb0d] Endpoints /10.200.177.33 and 
> /10.200.177.32 are consistent for counter1
> INFO  [RepairJobTask:1] 2015-12-21 11:40:53,910  RepairJob.java:145 - [repair 
> #b13e3740-a7d7-11e5-b568-f565b837eb0d] counter1 is fully synced
> INFO  [AntiEntropyStage:1] 2015-12-21 11:40:54,823  Validator.java:272 - 
> [repair #b17a2ed0-a7d7-11e5-ada8-8304f5629908] Sending completed merkle tree 
> to /10.200.177.33 for keyspace1.counter1
> ERROR [ValidationExecutor:3] 2015-12-21 11:40:55,104  
> CompactionManager.java:1065 - Cannot start multiple repair sessions over the 
> same sstables
> ERROR [ValidationExecutor:3] 2015-12-21 11:40:55,105  Validator.java:259 - 
> Failed creating a merkle tree for [repair 
> #b17a2ed0-a7d7-11e5-ada8-8304f5629908 on keyspace1/standard1, 
> [(10,-9223372036854775808]]], /10.200.177.33 (see log for details)
> ERROR [ValidationExecutor:3] 2015-12-21 11:40:55,110  
> CassandraDaemon.java:195 - Exception in thread 
> Thread[ValidationExecutor:3,1,main]
> java.lang.RuntimeException: Cannot start multiple repair sessions over the 
> same sstables
>   at 
> org.apache.cassandra.db.compaction.CompactionManager.doValidationCompaction(CompactionManager.java:1066)
>  ~[cassandra-all-3.0.1.777.jar:3.0.1.777]
>   at 
> org.apache.cassandra.db.compaction.CompactionManager.access$700(CompactionManager.java:80)
>  ~[cassandra-all-3.0.1.777.jar:3.0.1.777]
>   at 
> org.apache.cassandra.db.compaction.CompactionManager$10.call(CompactionManager.java:679)
>  ~[cassandra-all-3.0.1.777.jar:3.0.1.777]
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
> ~[na:1.8.0_40]
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  ~[na:1.8.0_40]
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  [na:1.8.0_40]
>   at java.lang.Thread.run(Thread.java:745) [na:1.8.0_40]
> ERROR [AntiEntropyStage:1] 2015-12-21 11:40:55,174  
> RepairMessageVerbHandler.java:161 - Got error, removing parent repair session
> INFO  [CompactionExecutor:3] 2015-12-21 11:40:55,175  
> CompactionManager.java:489 - Starting anticompaction for 

[jira] [Updated] (CASSANDRA-10991) Cleanup OpsCenter keyspace fails - node thinks that didn't joined the ring yet

[Carl Yeksigian (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-10991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carl Yeksigian updated CASSANDRA-10991:
---
Component/s: Observability

> Cleanup OpsCenter keyspace fails - node thinks that didn't joined the ring yet
> --
>
> Key: CASSANDRA-10991
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10991
> Project: Cassandra
>  Issue Type: Bug
>  Components: Observability
> Environment: C* 2.1.12, Debian Wheezy
>Reporter: mlowicki
>Assignee: Marcus Eriksson
> Fix For: 2.2.6, 3.0.4, 3.4
>
>
> I've C* cluster spread across 3 DCs. Running {{cleanup}} on all nodes in one 
> DC always fails:
> {code}
> root@db1:~# nt cleanup system
> root@db1:~# nt cleanup sync
> root@db1:~# nt cleanup OpsCenter
> Aborted cleaning up atleast one column family in keyspace OpsCenter, check 
> server logs for more information.
> error: nodetool failed, check server logs
> -- StackTrace --
> java.lang.RuntimeException: nodetool failed, check server logs
> at 
> org.apache.cassandra.tools.NodeTool$NodeToolCmd.run(NodeTool.java:292)
> at org.apache.cassandra.tools.NodeTool.main(NodeTool.java:204)
> root@db1:~# 
> {code}
> Checked two other DCs and running cleanup there works fine (it didn't fail 
> immediately).
> Output from {{nodetool status}} from one node in problematic DC:
> {code}
> root@db1:~# nt status
> Datacenter: Amsterdam
> =
> Status=Up/Down
> |/ State=Normal/Leaving/Joining/Moving
> --  AddressLoad   Tokens  OwnsHost ID 
>   Rack
> UN  10.210.3.162   518.54 GB  256 ?   
> 50e606f5-e893-4a3b-86d3-1e5986dceea9  RAC1
> UN  10.210.3.230   532.63 GB  256 ?   
> 7b8fc988-8a6a-4d94-ae84-ab9da9ab01e8  RAC1
> UN  10.210.3.161   538.82 GB  256 ?   
> d44b0f6d-7933-4a7c-ba7b-f8648e038f85  RAC1
> UN  10.210.3.160   497.6 GB   256 ?   
> e7332179-a47e-471d-bcd4-08c638ab9ea4  RAC1
> UN  10.210.3.224   334.25 GB  256 ?   
> 92b0bd8c-0a5a-446a-83ea-2feea4988fe3  RAC1
> UN  10.210.3.118   518.34 GB  256 ?   
> ebddeaf3-1433-4372-a4ca-9c7ba3d4a26b  RAC1
> UN  10.210.3.221   516.57 GB  256 ?   
> 44d67a49-5310-4ab5-b448-a44be350abf5  RAC1
> UN  10.210.3.117   493.83 GB  256 ?   
> aae92956-82d6-421e-8f3f-22393ac7e5f7  RAC1
> Datacenter: Analytics
> =
> Status=Up/Down
> |/ State=Normal/Leaving/Joining/Moving
> --  AddressLoad   Tokens  OwnsHost ID 
>   Rack
> UN  10.210.59.124  392.83 GB  320 ?   
> f770a8cc-b7bf-44ac-8cc0-214d9228dfcd  RAC1
> UN  10.210.59.151  411.9 GB   320 ?   
> 3cc87422-0e43-4cd1-91bf-484f121be072  RAC1
> UN  10.210.58.132  309.8 GB   256 ?   
> 84d94d13-28d3-4b49-a3d9-557ab47e79b9  RAC1
> UN  10.210.58.133  281.82 GB  256 ?   
> 02bd2d02-41c5-4193-81b0-dee434adb0da  RAC1
> UN  10.210.59.86   285.84 GB  256 ?   
> bc6422ea-22e9-431a-ac16-c4c040f0c4e5  RAC1
> UN  10.210.59.84   331.06 GB  256 ?   
> a798e6b0-3a84-4ec2-82bb-8474086cb315  RAC1
> UN  10.210.59.85   366.26 GB  256 ?   
> 52699077-56cf-4c1e-b308-bf79a1644b7e  RAC1
> Datacenter: Ashburn
> ===
> Status=Up/Down
> |/ State=Normal/Leaving/Joining/Moving
> --  AddressLoad   Tokens  OwnsHost ID 
>   Rack
> UN  10.195.15.176  534.51 GB  256 ?   
> c6ac22df-c43a-4b25-b3b5-5e12ce9c69da  RAC1
> UN  10.195.15.177  313.73 GB  256 ?   
> eafa2a72-84a2-4cdc-a634-3c660acc6af8  RAC1
> UN  10.195.15.163  470.92 GB  256 ?   
> bcd2a534-94c4-4406-8d16-c1fc26b41844  RAC1
> UN  10.195.15.162  539.82 GB  256 ?   
> bb649cef-21de-4077-a35f-994319011a06  RAC1
> UN  10.195.15.182  499.64 GB  256 ?   
> 6ce2d14d-9fb8-4494-8e97-3add05bd35de  RAC1
> UN  10.195.15.167  508.48 GB  256 ?   
> 6f359675-852a-4842-9ff2-bdc69e6b04a2  RAC1
> UN  10.195.15.166  490.28 GB  256 ?   
> 1ec5d0c5-e8bd-4973-96d9-523de91d08c5  RAC1
> UN  10.195.15.183  447.78 GB  256 ?   
> 824165b0-1f1b-40e8-9695-e2f596cb8611  RAC1
> Note: Non-system keyspaces don't have the same replication settings, 
> effective ownership information is meaningless
> {code}
> Logs from one of the nodes where {{cleanup}} fails:
> {code}
> INFO  [RMI TCP Connection(158004)-10.210.59.86] 2016-01-09 15:58:33,942 
> CompactionManager.java:388 - Cleanup cannot run before a node has joined the 
> ring
> INFO  [RMI TCP Connection(158004)-10.210.59.86] 2016-01-09 15:58:33,970 
> CompactionManager.java:388 - Cleanup cannot run before a node has joined the 
> ring
> INFO  [RMI TCP Connection(158004)-10.210.59.86] 2016-01-09 15:58:34,000 
> CompactionManager.java:388 - 

[jira] [Updated] (CASSANDRA-10910) Materialized view remained rows

[Carl Yeksigian (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-10910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carl Yeksigian updated CASSANDRA-10910:
---
Component/s: Coordination

> Materialized view remained rows
> ---
>
> Key: CASSANDRA-10910
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10910
> Project: Cassandra
>  Issue Type: Bug
>  Components: Coordination
> Environment: Cassandra 3.0.0
>Reporter: Gábor Auth
>Assignee: Carl Yeksigian
> Fix For: 3.0.3, 3.3
>
>
> I've created a table and a materialized view.
> {code}
> > CREATE TABLE test (id text PRIMARY KEY, key text, value int);
> > CREATE MATERIALIZED VIEW test_view AS SELECT * FROM test WHERE key IS NOT 
> > NULL PRIMARY KEY(key, id);
> {code}
> I've put a value into the table:
> {code}
> > update test set key='key', value=1 where id='id';
> > select * from test; select * from test_view ;
>  id | key | value
> +-+---
>  id | key | 1
> (1 rows)
>  key | id | value
> -++---
>  key | id | 1
> (1 rows)
> {code}
> I've updated the value without specified the key of the materialized view:
> {code}
> > update test set value=2 where id='id';
> > select * from test; select * from test_view ;
>  id | key | value
> +-+---
>  id | key | 2
> (1 rows)
>  key | id | value
> -++---
>  key | id | 2
> (1 rows)
> {code}
> It works as I think...
> ...but I've updated the key of the materialized view:
> {code}
> > update test set key='newKey' where id='id';
> > select * from test; select * from test_view ;
>  id | key| value
> ++---
>  id | newKey | 2
> (1 rows)
>  key| id | value
> ++---
> key | id | 2
>  newKey | id | 2
> (2 rows)
> {code}
> ...I've updated the value of the row:
> {code}
> > update test set key='newKey', value=3 where id='id';
> > select * from test; select * from test_view ;
>  id | key| value
> ++---
>  id | newKey | 3
> (1 rows)
>  key| id | value
> ++---
> key | id | 2
>  newKey | id | 3
> (2 rows)
> {code}
> ...I've deleted the row by the id key:
> {code}
> > delete from test where id='id';
> > select * from test; select * from test_view ;
>  id | key | value
> +-+---
> (0 rows)
>  key | id | value
> -++---
>  key | id | 2
> (1 rows)
> {code}
> Is it a bug?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-11151) Remove unused method introduced in CASSANDRA-6696

[Carl Yeksigian (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-11151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carl Yeksigian updated CASSANDRA-11151:
---
Component/s: Compaction

> Remove unused method introduced in CASSANDRA-6696
> -
>
> Key: CASSANDRA-11151
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11151
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Compaction
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Minor
> Fix For: 3.4
>
>
> We introduced an abstract method {{finish(long repairedAt)}} in 
> CompactionAwareWriter in CASSANDRA-6696 which we don't use, remove it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-11602) Materialized View Does Not Have Static Columns

[Carl Yeksigian (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-11602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carl Yeksigian updated CASSANDRA-11602:
---
Component/s: Coordination
Summary: Materialized View Does Not Have Static Columns  (was: 
Materialized View Doest Not Have Static Columns)

> Materialized View Does Not Have Static Columns
> --
>
> Key: CASSANDRA-11602
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11602
> Project: Cassandra
>  Issue Type: Bug
>  Components: Coordination
>Reporter: Ravishankar Rajendran
>Assignee: Carl Yeksigian
> Fix For: 3.0.6, 3.6
>
>
> {quote}
> CREATE TABLE "team" (teamname text, manager text, location text static, 
> PRIMARY KEY ((teamname), manager));
> INSERT INTO team (teamname, manager, location) VALUES ('Red Bull1', 
> 'Ricciardo11', 'Australian');
> INSERT INTO team (teamname, manager, location) VALUES ('Red Bull2', 
> 'Ricciardo12', 'Australian');
> INSERT INTO team (teamname, manager, location) VALUES ('Red Bull2', 
> 'Ricciardo13', 'Australian');
> select * From team;
> CREATE MATERIALIZED VIEW IF NOT EXISTS "teamMV" AS SELECT "teamname", 
> "manager", "location" FROM "team" WHERE "teamname" IS NOT NULL AND "manager" 
> is NOT NULL AND "location" is NOT NULL PRIMARY KEY("manager", "teamname");  
> select * from "teamMV";
> {quote}
> The teamMV does not have "location" column. Static columns are not getting 
> created in MV.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-11069) Materialised views require all collections to be selected.

[Carl Yeksigian (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-11069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carl Yeksigian updated CASSANDRA-11069:
---
Component/s: Coordination

> Materialised views require all collections to be selected.
> --
>
> Key: CASSANDRA-11069
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11069
> Project: Cassandra
>  Issue Type: Bug
>  Components: Coordination
>Reporter: Vassil Lunchev
>Assignee: Carl Yeksigian
>  Labels: materializedviews
> Fix For: 3.0.4, 3.4
>
>
> Running Cassandra 3.0.2
> Using the official example from: 
> http://www.datastax.com/dev/blog/new-in-cassandra-3-0-materialized-views
> The only difference is that I have added a map column to the base table.
> {code}
> CREATE TABLE scores
> (
>   user TEXT,
>   game TEXT,
>   year INT,
>   month INT,
>   day INT,
>   score INT,
>   a_map map,
>   PRIMARY KEY (user, game, year, month, day)
> );
> CREATE MATERIALIZED VIEW alltimehigh AS
>SELECT user FROM scores
>WHERE game IS NOT NULL AND score IS NOT NULL AND user IS NOT NULL AND 
> year IS NOT NULL AND month IS NOT NULL AND day IS NOT NULL
>PRIMARY KEY (game, score, user, year, month, day)
>WITH CLUSTERING ORDER BY (score desc);
> INSERT INTO scores (user, game, year, month, day, score) VALUES ('pcmanus', 
> 'Coup', 2015, 06, 02, 2000);
> SELECT * FROM scores;
> SELECT * FROM alltimehigh;
> {code}
> All of the above works perfectly fine. Until you insert a row where the 
> 'a_map' column is not null.
> {code}
> INSERT INTO scores (user, game, year, month, day, score, a_map) VALUES 
> ('pcmanus_2', 'Coup', 2015, 06, 02, 2000, {1: 'text'});
> {code}
> This results in:
> {code}
> Traceback (most recent call last):
>   File "/Users/vassil/apache-cassandra-3.0.2/bin/cqlsh.py", line 1258, in 
> perform_simple_statement
> result = future.result()
>   File 
> "/Users/vassil/apache-cassandra-3.0.2/bin/../lib/cassandra-driver-internal-only-3.0.0-6af642d.zip/cassandra-driver-3.0.0-6af642d/cassandra/cluster.py",
>  line 3122, in result
> raise self._final_exception
> WriteFailure: code=1500 [Replica(s) failed to execute write] 
> message="Operation failed - received 0 responses and 1 failures" 
> info={'failures': 1, 'received_responses': 0, 'required_responses': 1, 
> 'consistency': 'ONE'}
> {code}
> Selecting the base table and the materialised view is also interesting:
> {code}
> SELECT * FROM scores;
> SELECT * FROM alltimehigh;
> {code}
> The result is:
> {code}
> cqlsh:tests> SELECT * FROM scores;
>  user| game | year | month | day | a_map | score
> -+--+--+---+-+---+---
>  pcmanus | Coup | 2015 | 6 |   2 |  null |  2000
> (1 rows)
> cqlsh:tests> SELECT * FROM alltimehigh;
>  game | score | user  | year | month | day
> --+---+---+--+---+-
>  Coup |  2000 |   pcmanus | 2015 | 6 |   2
>  Coup |  2000 | pcmanus_2 | 2015 | 6 |   2
> (2 rows)
> {code}
> In the logs you can see:
> {code:java}
> ERROR [SharedPool-Worker-2] 2016-01-26 03:25:27,456 Keyspace.java:484 - 
> Unknown exception caught while attempting to update MaterializedView! 
> tests.scores
> java.lang.IllegalStateException: [ColumnDefinition{name=a_map, 
> type=org.apache.cassandra.db.marshal.MapType(org.apache.cassandra.db.marshal.Int32Type,org.apache.cassandra.db.marshal.UTF8Type),
>  kind=REGULAR, position=-1}] is not a subset of []
>   at 
> org.apache.cassandra.db.Columns$Serializer.encodeBitmap(Columns.java:531) 
> ~[apache-cassandra-3.0.2.jar:3.0.2]
>   at 
> org.apache.cassandra.db.Columns$Serializer.serializedSubsetSize(Columns.java:483)
>  ~[apache-cassandra-3.0.2.jar:3.0.2]
>   at 
> org.apache.cassandra.db.rows.UnfilteredSerializer.serializedRowBodySize(UnfilteredSerializer.java:275)
>  ~[apache-cassandra-3.0.2.jar:3.0.2]
>   at 
> org.apache.cassandra.db.rows.UnfilteredSerializer.serializedSize(UnfilteredSerializer.java:247)
>  ~[apache-cassandra-3.0.2.jar:3.0.2]
>   at 
> org.apache.cassandra.db.rows.UnfilteredSerializer.serializedSize(UnfilteredSerializer.java:234)
>  ~[apache-cassandra-3.0.2.jar:3.0.2]
>   at 
> org.apache.cassandra.db.rows.UnfilteredSerializer.serializedSize(UnfilteredSerializer.java:227)
>  ~[apache-cassandra-3.0.2.jar:3.0.2]
>   at 
> org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serializedSize(UnfilteredRowIteratorSerializer.java:169)
>  ~[apache-cassandra-3.0.2.jar:3.0.2]
>   at 
> org.apache.cassandra.db.partitions.PartitionUpdate$PartitionUpdateSerializer.serializedSize(PartitionUpdate.java:683)
>  ~[apache-cassandra-3.0.2.jar:3.0.2]
>   at 
> org.apache.cassandra.db.Mutation$MutationSerializer.serializedSize(Mutation.java:354)
>  

[jira] [Updated] (CASSANDRA-11475) MV code refactor

[Carl Yeksigian (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-11475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carl Yeksigian updated CASSANDRA-11475:
---
Component/s: Coordination

> MV code refactor
> 
>
> Key: CASSANDRA-11475
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11475
> Project: Cassandra
>  Issue Type: Bug
>  Components: Coordination
>Reporter: Sylvain Lebresne
>Assignee: Sylvain Lebresne
> Fix For: 3.0.7, 3.7
>
>
> While working on CASSANDRA-5546 I run into a problem with TTLs on MVs, which 
> looking more closely is a bug of the MV code. But one thing leading to 
> another I reviewed a good portion of the MV code and found the following 
> correction problems:
> * If a base row is TTLed then even if an update remove that TTL the view 
> entry remained TTLed and expires, leading to an inconsistency.
> * Due to calling the wrong ctor for {{LivenessInfo}}, when a TTL was set on 
> the base table, the view entry was living twice as long as the TTL. Again 
> leading to a temporary inconsistency.
> * When reading existing data to compute view updates, all deletion 
> informations are completely ignored (the code uses a {{PartitionIterator}} 
> instead of an {{UnfilteredPartitionIterator}}). This is a serious issue since 
> it means some deletions could be totally ignored as far as views are 
> concerned especially when messages are delivered to a replica out of order. 
> I'll note that while the 2 previous points are relatively easy to fix, I 
> didn't find an easy and clean way to fix this one on the current code.
> Further, I think the MV code in general has inefficiencies/code complexities 
> that should be avoidable:
> * {{TemporalRow.Set}} is buffering both everything read and a pretty much 
> complete copy of the updates. That's a potentially high memory requirement. 
> We shouldn't have to copy the updates and we shouldn't buffer all reads but 
> rather work incrementally.
> * {{TemporalRow}}/{{TemporalRow.Set}}/{{TemporalCell}} classes are somewhat 
> re-inventing the wheel. They are really just storing both an update we're 
> doing and the corresponding existing data, but we already have 
> {{Row}}/{{Partition}}/{{Cell}} for that. In practice, those {{Temporal*}} 
> class generates a lot of allocations that we could avoid.
> * The code from CASSANDRA-10060 to avoid multiple reads of the base table 
> with multiple views doesn't work when the update has partition/range 
> tombstones because the code uses {{TemporalRow.Set.setTombstonedExisting()}} 
> to trigger reuse, but the {{TemporalRow.Set.withNewViewPrimaryKey()}} method 
> is used between view and it does not preseve the {{hasTombstonedExisting}} 
> flag.  But that oversight, which is trivial to fix, is kind of a good thing 
> since if you fix it, you're left with a correction problem.
>   The read done when there is a partition deletion depends on the view itself 
> (if there is clustering filters in particular) and so reusing that read for 
> other views is wrong. Which makes that whole reuse code really dodgy imo: the 
> read for existing data is in {{View.java}}, suggesting that it depends on the 
> view (which again, it does at least for partition deletion), but it shouldn't 
> if we're going to reuse the result across multiple views.
> * Even ignoring the previous point, we still potentially read the base table 
> twice if the update mix both row updates and partition/range deletions, 
> potentially re-reading the same values.
> * It's probably more minor but the reading code is using {{QueryPager}}, 
> which is probably an artifact of the initial version of the code being 
> pre-8099, but it's not necessary anymore (the reads are local and locally 
> we're completely iterator based), adding, especially when we do page. I'll 
> note that despite using paging, the current code still buffers everything in 
> {{TemporalRow.Set}} anyway .
> Overall, I suspect trying to fix the problems above (particularly the fact 
> that existing deletion infos are ignored) is only going to add complexity 
> with the current code and we'd still have to fix the inefficiencies. So I 
> propose a refactor of that code which does 2 main things:
> # it removes all of {{TemporalRow}} and related classes. Instead, it directly 
> uses the existing {{Row}} (with all its deletion infos) and the update being 
> applied to it and compute the updates for the view from that. I submit that 
> this is more clear/simple, but this also avoid copying every cell of both the 
> existing and update data as a {{TemporalCell}}. We can also reuse codes like 
> {{Rows.merge}} and {{Rows.diff}} to make the handling of deletions relatively 
> painless.
> # instead of dealing with each view one at a time, re-iterating over all 
> updates each time, it iterates over each individual updates once 

[jira] [Updated] (CASSANDRA-11034) consistent_reads_after_move_test is failing on trunk

[Carl Yeksigian (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-11034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carl Yeksigian updated CASSANDRA-11034:
---
Component/s: Testing

> consistent_reads_after_move_test is failing on trunk
> 
>
> Key: CASSANDRA-11034
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11034
> Project: Cassandra
>  Issue Type: Bug
>  Components: Testing
>Reporter: Philip Thompson
>Assignee: Marcus Eriksson
>Priority: Blocker
>  Labels: dtest
> Fix For: 3.3
>
> Attachments: node1.log, node1_debug.log, node2.log, node2_debug.log, 
> node3.log, node3_debug.log
>
>
> The novnode dtest 
> {{consistent_bootstrap_test.TestBootstrapConsistency.consistent_reads_after_move_test}}
>  is failing on trunk. See an example failure 
> [here|http://cassci.datastax.com/job/trunk_novnode_dtest/274/testReport/consistent_bootstrap_test/TestBootstrapConsistency/consistent_reads_after_move_test/].
> On trunk I am getting an OOM of one of my C* nodes [node3], which is what 
> causes the nodetool move to fail. Logs are attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-11988) NullPointerException when reading/compacting table

[Carl Yeksigian (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-11988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carl Yeksigian updated CASSANDRA-11988:
---
Component/s: Compaction
Summary: NullPointerException when reading/compacting table  (was: 
NullPointerExpception when reading/compacting table)

> NullPointerException when reading/compacting table
> --
>
> Key: CASSANDRA-11988
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11988
> Project: Cassandra
>  Issue Type: Bug
>  Components: Compaction
>Reporter: Nimi Wariboko Jr.
>Assignee: Sylvain Lebresne
> Fix For: 3.0.9, 3.8
>
>
> I have a table that suddenly refuses to be read or compacted. Issuing a read 
> on the table causes a NPE.
> On compaction, it returns the error
> {code}
> ERROR [CompactionExecutor:6] 2016-06-09 17:10:15,724 CassandraDaemon.java:213 
> - Exception in thread Thread[CompactionExecutor:6,1,main]
> java.lang.NullPointerException: null
>   at 
> org.apache.cassandra.db.transform.UnfilteredRows.isEmpty(UnfilteredRows.java:38)
>  ~[apache-cassandra-3.6.jar:3.6]
>   at 
> org.apache.cassandra.db.partitions.PurgeFunction.applyToPartition(PurgeFunction.java:64)
>  ~[apache-cassandra-3.6.jar:3.6]
>   at 
> org.apache.cassandra.db.partitions.PurgeFunction.applyToPartition(PurgeFunction.java:24)
>  ~[apache-cassandra-3.6.jar:3.6]
>   at 
> org.apache.cassandra.db.transform.BasePartitions.hasNext(BasePartitions.java:76)
>  ~[apache-cassandra-3.6.jar:3.6]
>   at 
> org.apache.cassandra.db.compaction.CompactionIterator.hasNext(CompactionIterator.java:226)
>  ~[apache-cassandra-3.6.jar:3.6]
>   at 
> org.apache.cassandra.db.compaction.CompactionTask.runMayThrow(CompactionTask.java:182)
>  ~[apache-cassandra-3.6.jar:3.6]
>   at 
> org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28) 
> ~[apache-cassandra-3.6.jar:3.6]
>   at 
> org.apache.cassandra.db.compaction.CompactionTask.executeInternal(CompactionTask.java:82)
>  ~[apache-cassandra-3.6.jar:3.6]
>   at 
> org.apache.cassandra.db.compaction.AbstractCompactionTask.execute(AbstractCompactionTask.java:60)
>  ~[apache-cassandra-3.6.jar:3.6]
>   at 
> org.apache.cassandra.db.compaction.CompactionManager$BackgroundCompactionCandidate.run(CompactionManager.java:264)
>  ~[apache-cassandra-3.6.jar:3.6]
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
> ~[na:1.8.0_45]
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
> ~[na:1.8.0_45]
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  ~[na:1.8.0_45]
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  [na:1.8.0_45]
>   at java.lang.Thread.run(Thread.java:745) [na:1.8.0_45]
> {code}
> Schema:
> {code}
> CREATE TABLE cmpayments.report_payments (
> reportid timeuuid,
> userid timeuuid,
> adjustedearnings decimal,
> deleted set static,
> earnings map,
> gross map,
> organizationid text,
> payall timestamp static,
> status text,
> PRIMARY KEY (reportid, userid)
> ) WITH CLUSTERING ORDER BY (userid ASC)
> AND bloom_filter_fp_chance = 0.01
> AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'}
> AND comment = ''
> AND compaction = {'class': 
> 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy', 
> 'max_threshold': '32', 'min_threshold': '4'}
> AND compression = {'chunk_length_in_kb': '64', 'class': 
> 'org.apache.cassandra.io.compress.LZ4Compressor'}
> AND crc_check_chance = 1.0
> AND dclocal_read_repair_chance = 0.1
> AND default_time_to_live = 0
> AND gc_grace_seconds = 864000
> AND max_index_interval = 2048
> AND memtable_flush_period_in_ms = 0
> AND min_index_interval = 128
> AND read_repair_chance = 0.0
> AND speculative_retry = '99PERCENTILE';
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12413) CompactionsCQLTest.testTriggerMinorCompactionDTCS fails

[Carl Yeksigian (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carl Yeksigian updated CASSANDRA-12413:
---
Component/s: Testing

> CompactionsCQLTest.testTriggerMinorCompactionDTCS fails
> ---
>
> Key: CASSANDRA-12413
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12413
> Project: Cassandra
>  Issue Type: Bug
>  Components: Testing
>Reporter: Joshua McKenzie
>Assignee: Marcus Eriksson
>  Labels: unittest
> Fix For: 3.10
>
>
> [Link|http://cassci.datastax.com/job/cassandra-3.9_testall/lastCompletedBuild/testReport/org.apache.cassandra.db.compaction/CompactionsCQLTest/testTriggerMinorCompactionDTCS/]
> Error Message
> No minor compaction triggered in 5000ms
> Stacktrace
> {noformat}
> junit.framework.AssertionFailedError: No minor compaction triggered in 5000ms
>   at 
> org.apache.cassandra.db.compaction.CompactionsCQLTest.waitForMinor(CompactionsCQLTest.java:247)
>   at 
> org.apache.cassandra.db.compaction.CompactionsCQLTest.testTriggerMinorCompactionDTCS(CompactionsCQLTest.java:72)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-11698) dtest failure in materialized_views_test.TestMaterializedViews.clustering_column_test

[Carl Yeksigian (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-11698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carl Yeksigian updated CASSANDRA-11698:
---
Component/s: Testing

> dtest failure in 
> materialized_views_test.TestMaterializedViews.clustering_column_test
> -
>
> Key: CASSANDRA-11698
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11698
> Project: Cassandra
>  Issue Type: Bug
>  Components: Testing
>Reporter: Russ Hatch
>Assignee: Carl Yeksigian
>  Labels: dtest
> Attachments: node1.log, node1_debug.log, node2.log, node2_debug.log, 
> node3.log, node3_debug.log
>
>
> recent failure, test has flapped before a while back.
> {noformat}
> Expecting 2 users, got 1
> {noformat}
> http://cassci.datastax.com/job/cassandra-3.0_dtest/688/testReport/materialized_views_test/TestMaterializedViews/clustering_column_test
> Failed on CassCI build cassandra-3.0_dtest #688



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12044) Materialized view definition regression in clustering key

[Carl Yeksigian (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carl Yeksigian updated CASSANDRA-12044:
---
Component/s: CQL

> Materialized view definition regression in clustering key
> -
>
> Key: CASSANDRA-12044
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12044
> Project: Cassandra
>  Issue Type: Bug
>  Components: CQL
>Reporter: Michael Mior
>Assignee: Carl Yeksigian
> Fix For: 3.0.9, 3.8
>
>
> This bug was reported on the 
> [users|https://mail-archives.apache.org/mod_mbox/cassandra-user/201606.mbox/%3CCAG0vsSJRtRjLJqKsd3M8X-8nXpPwRj7Q80mNkuy8sy%2B%2B%3D%2BocHA%40mail.gmail.com%3E]
>  mailing list. The following definitions work in 3.0.3 but fail in 3.0.7.
> {code}
> CREATE TABLE ks.pa (
> id bigint,
> sub_id text,
> name text,
> class text,
> r_id bigint,
> k_id bigint,
> created timestamp,
> priority int,
> updated timestamp,
> value text,
> PRIMARY KEY (id, sub_id, name)
> );
> CREATE ks.mv_pa AS
> SELECT k_id, name, value, sub_id, id, class, r_id
> FROM ks.pa
> WHERE k_id IS NOT NULL AND name IS NOT NULL AND value IS NOT NULL AND 
> sub_id IS NOT NULL AND id IS NOT NULL
> PRIMARY KEY ((k_id, name), value, sub_id, id);
> {code}
> After running bisect, I've narrowed it down to commit 
> [86ba227|https://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=commit;h=86ba227477b9f8595eb610ecaf950cfbc29dd36b]
>  from [CASSANDRA-11475|https://issues.apache.org/jira/browse/CASSANDRA-11475].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12247) AssertionError with MVs on updating a row that isn't indexed due to a null value

[Carl Yeksigian (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carl Yeksigian updated CASSANDRA-12247:
---
Component/s: Local Write-Read Paths

> AssertionError with MVs on updating a row that isn't indexed due to a null 
> value
> 
>
> Key: CASSANDRA-12247
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12247
> Project: Cassandra
>  Issue Type: Bug
>  Components: Local Write-Read Paths
> Environment: Linux, Ubuntu Xenial
> openjdk-8-jre-headless:amd64   8u91-b14-0ubuntu4~16.04.1
>Reporter: Benjamin Roth
>Assignee: Sylvain Lebresne
>Priority: Critical
> Fix For: 3.0.9, 3.8
>
>
> Complete steps to reproduce:
> https://gist.github.com/brstgt/4c3269eaec50a7d4abac5690157b238c



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12198) Deadlock in CDC during segment flush

[Carl Yeksigian (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carl Yeksigian updated CASSANDRA-12198:
---
Component/s: Local Write-Read Paths

> Deadlock in CDC during segment flush
> 
>
> Key: CASSANDRA-12198
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12198
> Project: Cassandra
>  Issue Type: Bug
>  Components: Local Write-Read Paths
>Reporter: Joshua McKenzie
>Assignee: Joshua McKenzie
>Priority: Blocker
> Fix For: 3.8
>
>
> In the patch for CASSANDRA-8844, we added a {{synchronized(this)}} block 
> inside CommitLogSegment.setCDCState. This introduces the possibility of 
> deadlock in the following scenario:
> # A {{CommitLogSegment.sync()}} call is made (synchronized method)
> # A {{CommitLogSegment.allocate}} call from a cdc-enabled write is in flight 
> and acquires a reference to the Group on appendOrder (the OpOrder in the 
> Segment)
> # {{CommmitLogSegment.sync}} hits {{waitForModifications}} which calls 
> {{appendOrder.awaitNewBarrier}}
> # The in-flight write, if changing the state of the segment from 
> CDCState.PERMITTED to CDCState.CONTAINS, enters {{setCDCState}} and blocks on 
> synchronized(this)
> And neither of them ever come back. This came up while doing some further 
> work on CASSANDRA-12148.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12287) offline_tools_test.TestOfflineTools.sstablelevelreset_test

[Carl Yeksigian (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carl Yeksigian updated CASSANDRA-12287:
---
Component/s: Testing

> offline_tools_test.TestOfflineTools.sstablelevelreset_test
> --
>
> Key: CASSANDRA-12287
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12287
> Project: Cassandra
>  Issue Type: Test
>  Components: Testing
>Reporter: Craig Kodman
>Assignee: Eduard Tudenhoefner
> Attachments: node1.log, node1_debug.log, node1_gc.log
>
>
> example failure:
> http://cassci.datastax.com/job/cassandra-3.9_dtest/lastCompletedBuild/testReport/offline_tools_test/TestOfflineTools/sstablelevelreset_test/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12180) Should be able to override compaction space check

[Carl Yeksigian (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carl Yeksigian updated CASSANDRA-12180:
---
Component/s: Compaction

> Should be able to override compaction space check
> -
>
> Key: CASSANDRA-12180
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12180
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Compaction
>Reporter: sankalp kohli
>Assignee: sankalp kohli
>Priority: Trivial
> Fix For: 3.0.9, 3.8
>
> Attachments: CASSANDRA-12180_3.0.txt
>
>
> If there's not enough space for a compaction it won't do it and print the 
> exception below. Sometimes we know compaction will free up lot of space since 
> an ETL job could have inserted a lot of deletes. This override helps in this 
> case. 
> ERROR [CompactionExecutor:17] CassandraDaemon.java (line 258) Exception in 
> thread Thread
> [CompactionExecutor:17,1,main]
> java.lang.RuntimeException: Not enough space for compaction, estimated 
> sstables = 1552, expected
> write size = 260540558535
> at org.apache.cassandra.db.compaction.CompactionTask.checkAvailableDiskSpace
> (CompactionTask.java:306)
> at 
> org.apache.cassandra.db.compaction.CompactionTask.runMayThrow(CompactionTask.
> java:106)
> at org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28)
> at 
> org.apache.cassandra.db.compaction.CompactionTask.executeInternal(CompactionTask.
> java:60)
> at 
> org.apache.cassandra.db.compaction.AbstractCompactionTask.execute(AbstractCompactionTask.
> java:59)
> at 
> org.apache.cassandra.db.compaction.CompactionManager$BackgroundCompactionTask.run
> (CompactionManager.java:198)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12225) dtest failure in materialized_views_test.TestMaterializedViews.clustering_column_test

[Carl Yeksigian (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carl Yeksigian updated CASSANDRA-12225:
---
Component/s: Testing

> dtest failure in 
> materialized_views_test.TestMaterializedViews.clustering_column_test
> -
>
> Key: CASSANDRA-12225
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12225
> Project: Cassandra
>  Issue Type: Test
>  Components: Testing
>Reporter: Sean McCarthy
>Assignee: Carl Yeksigian
>  Labels: dtest
> Fix For: 3.0.10, 3.10
>
> Attachments: node1.log, node1_debug.log, node1_gc.log, node2.log, 
> node2_debug.log, node2_gc.log, node3.log, node3_debug.log, node3_gc.log
>
>
> example failure:
> http://cassci.datastax.com/job/trunk_offheap_dtest/336/testReport/materialized_views_test/TestMaterializedViews/clustering_column_test
> Failed on CassCI build trunk_offheap_dtest #336
> {code}
> Stacktrace
>   File "/usr/lib/python2.7/unittest/case.py", line 329, in run
> testMethod()
>   File "/home/automaton/cassandra-dtest/materialized_views_test.py", line 
> 321, in clustering_column_test
> self.assertEqual(len(result), 2, "Expecting {} users, got {}".format(2, 
> len(result)))
>   File "/usr/lib/python2.7/unittest/case.py", line 513, in assertEqual
> assertion_func(first, second, msg=msg)
>   File "/usr/lib/python2.7/unittest/case.py", line 506, in _baseAssertEqual
> raise self.failureException(msg)
> "Expecting 2 users, got 1
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (CASSANDRA-12834) testall failure in org.apache.cassandra.index.internal.CassandraIndexTest.indexOnFirstClusteringColumn

[Sean McCarthy (JIRA)]

Sean McCarthy created CASSANDRA-12834:
-

 Summary: testall failure in 
org.apache.cassandra.index.internal.CassandraIndexTest.indexOnFirstClusteringColumn
 Key: CASSANDRA-12834
 URL: https://issues.apache.org/jira/browse/CASSANDRA-12834
 Project: Cassandra
  Issue Type: Bug
Reporter: Sean McCarthy


example failure:

http://cassci.datastax.com/job/trunk_testall/1250/testReport/org.apache.cassandra.index.internal/CassandraIndexTest/indexOnFirstClusteringColumn/

{code}
Error Message

Error setting schema for test (query was: CREATE INDEX c_index ON 
cql_test_keyspace.table_20(c))
{code}{code}
Stacktrace

java.lang.RuntimeException: Error setting schema for test (query was: CREATE 
INDEX c_index ON cql_test_keyspace.table_20(c))
at org.apache.cassandra.cql3.CQLTester.schemaChange(CQLTester.java:705)
at org.apache.cassandra.cql3.CQLTester.createIndex(CQLTester.java:627)
at 
org.apache.cassandra.index.internal.CassandraIndexTest.access$400(CassandraIndexTest.java:56)
at 
org.apache.cassandra.index.internal.CassandraIndexTest$TestScript.run(CassandraIndexTest.java:626)
at 
org.apache.cassandra.index.internal.CassandraIndexTest.indexOnFirstClusteringColumn(CassandraIndexTest.java:86)
Caused by: org.apache.cassandra.exceptions.InvalidRequestException: Index 
c_index already exists
at 
org.apache.cassandra.cql3.statements.CreateIndexStatement.validate(CreateIndexStatement.java:133)
at org.apache.cassandra.cql3.CQLTester.schemaChange(CQLTester.java:696)
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (CASSANDRA-12833) dtest failure in auth_test.TestAuthRoles.udf_permissions_in_update_test

[Sean McCarthy (JIRA)]

Sean McCarthy created CASSANDRA-12833:
-

 Summary: dtest failure in 
auth_test.TestAuthRoles.udf_permissions_in_update_test
 Key: CASSANDRA-12833
 URL: https://issues.apache.org/jira/browse/CASSANDRA-12833
 Project: Cassandra
  Issue Type: Test
Reporter: Sean McCarthy
Assignee: DS Test Eng


example failure:

http://cassci.datastax.com/job/cassandra-3.0_dtest/838/testReport/auth_test/TestAuthRoles/udf_permissions_in_update_test

{code}
Error Message

[Errno 2] No such file or directory: 
'/tmp/dtest-ZILXmx/test/node1/logs/system.log'
{code}{code}
Stacktrace

  File "/usr/lib/python2.7/unittest/case.py", line 329, in run
testMethod()
  File "/home/automaton/cassandra-dtest/auth_test.py", line 2358, in 
udf_permissions_in_update_test
self.verify_udf_permissions("UPDATE ks.t1 SET v = ks.plus_one(2) WHERE k = 
ks.plus_one(0)")
  File "/home/automaton/cassandra-dtest/auth_test.py", line 2375, in 
verify_udf_permissions
self.prepare()
  File "/home/automaton/cassandra-dtest/auth_test.py", line 2622, in prepare
self.wait_for_any_log(self.cluster.nodelist(), 'Created default superuser', 
25)
  File "/home/automaton/cassandra-dtest/dtest.py", line 642, in wait_for_any_log
found = node.grep_log(pattern, filename=filename)
  File "/usr/local/lib/python2.7/dist-packages/ccmlib/node.py", line 347, in 
grep_log
with open(os.path.join(self.get_path(), 'logs', filename)) as f:
{code}

There were no logs saved for this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12802) RecoveryManagerTruncateTest fails in 2.1

[Branimir Lambov (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15601968#comment-15601968
 ] 

Branimir Lambov commented on CASSANDRA-12802:
-

I don't think this is critical enough to fix in 2.1, the changes to commit log 
we do for that will be a risk in themselves.

I would go with the hacky test fix.

> RecoveryManagerTruncateTest fails in 2.1
> 
>
> Key: CASSANDRA-12802
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12802
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Stefania
>Assignee: Stefania
> Fix For: 2.1.x
>
>
> Example failure:
> http://cassci.datastax.com/view/cassandra-2.1/job/cassandra-2.1_testall/388/testReport/junit/org.apache.cassandra.db/RecoveryManagerTruncateTest/testTruncatePointInTime/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (CASSANDRA-12829) DELETE query with an empty IN clause can delete more than expected

[Alex Petrov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Petrov reassigned CASSANDRA-12829:
---

Assignee: Alex Petrov

> DELETE query with an empty IN clause can delete more than expected
> --
>
> Key: CASSANDRA-12829
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12829
> Project: Cassandra
>  Issue Type: Bug
>  Components: CQL
> Environment: Arch Linux x64, kernel 4.7.6, Cassandra 3.9 downloaded 
> from the website
>Reporter: Jason T. Bradshaw
>Assignee: Alex Petrov
>
> When deleting from a table with a certain structure and using an *in* clause 
> with an empty list, the *in* clause with an empty list can be ignored, 
> resulting in deleting more than is expected.
> *Setup:*
> {code}
> cqlsh> create table test (a text, b text, id uuid, primary key ((a, b), id));
> cqlsh> insert into test (a, b, id) values ('a', 'b', 
> ----);
> cqlsh> insert into test (a, b, id) values ('b', 'c', 
> ----);
> cqlsh> insert into test (a, b, id) values ('a', 'c', 
> ----);
> cqlsh> select * from test;
>  a | b | id
> ---+---+--
>  a | c | ----
>  b | c | ----
>  a | b | ----
> (3 rows)
> {code}
> *Expected:*
> {code}
> cqlsh> delete from test where a = 'a' and b in ('a', 'b', 'c') and id in ();
> cqlsh> select * from test;
>  a | b | id
> ---+---+--
>  a | c | ----
>  b | c | ----
>  a | b | ----
> (3 rows)
> {code}
> *Actual:*
> {code}
> cqlsh> delete from test where a = 'a' and b in ('a', 'b', 'c') and id in ();
> cqlsh> select * from test;
>  a | b | id
> ---+---+--
>  b | c | ----
> (1 rows)
> {code}
> Instead of deleting nothing, as the final empty *in* clause would imply, it 
> instead deletes everything that matches the first two clauses, acting as if 
> the following query had been issued instead:
> {code}
> cqlsh> delete from test where a = 'a' and b in ('a', 'b', 'c');
> {code}
> This seems to be related to the presence of a tuple clustering key, as I 
> could not reproduce it without one.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-10855) Use Caffeine (W-TinyLFU) for on-heap caches

[Robert Stupp (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15601956#comment-15601956
 ] 

Robert Stupp commented on CASSANDRA-10855:
--

Rebased your patch against current trunk and triggered CI.
||trunk|[branch|https://github.com/apache/cassandra/compare/trunk...snazy:10855-caffeine-trunk]|[testall|http://cassci.datastax.com/view/Dev/view/snazy/job/snazy-10855-caffeine-trunk-testall/lastSuccessfulBuild/]|[dtest|http://cassci.datastax.com/view/Dev/view/snazy/job/snazy-10855-caffeine-trunk-dtest/lastSuccessfulBuild/]


> Use Caffeine (W-TinyLFU) for on-heap caches
> ---
>
> Key: CASSANDRA-10855
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10855
> Project: Cassandra
>  Issue Type: Improvement
>Reporter: Ben Manes
>  Labels: performance
> Attachments: CASSANDRA-10855.patch, CASSANDRA-10855.patch
>
>
> Cassandra currently uses 
> [ConcurrentLinkedHashMap|https://code.google.com/p/concurrentlinkedhashmap] 
> for performance critical caches (key, counter) and Guava's cache for 
> non-critical (auth, metrics, security). All of these usages have been 
> replaced by [Caffeine|https://github.com/ben-manes/caffeine], written by the 
> author of the previously mentioned libraries.
> The primary incentive is to switch from LRU policy to W-TinyLFU, which 
> provides [near optimal|https://github.com/ben-manes/caffeine/wiki/Efficiency] 
> hit rates. It performs particularly well in database and search traces, is 
> scan resistant, and as adds a very small time/space overhead to LRU.
> Secondarily, Guava's caches never obtained similar 
> [performance|https://github.com/ben-manes/caffeine/wiki/Benchmarks] to CLHM 
> due to some optimizations not being ported over. This change results in 
> faster reads and not creating garbage as a side-effect.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12803) PER PARTITION LIMIT not recognized by cqlsh auto completion

[Robert Stupp (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15601939#comment-15601939
 ] 

Robert Stupp commented on CASSANDRA-12803:
--

+1

> PER PARTITION LIMIT not recognized by cqlsh auto completion
> ---
>
> Key: CASSANDRA-12803
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12803
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Robert Stupp
>Assignee: Benjamin Lerer
>Priority: Trivial
> Fix For: 3.x
>
> Attachments: 12803-3.X.txt
>
>
> cqlsh's syntax definition does not know about {{PER PARTITION LIMIT}} and 
> therefore does not propose it for auto-completion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12803) PER PARTITION LIMIT not recognized by cqlsh auto completion

[Robert Stupp (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Stupp updated CASSANDRA-12803:
-
Status: Ready to Commit  (was: Patch Available)

> PER PARTITION LIMIT not recognized by cqlsh auto completion
> ---
>
> Key: CASSANDRA-12803
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12803
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Robert Stupp
>Assignee: Benjamin Lerer
>Priority: Trivial
> Fix For: 3.x
>
> Attachments: 12803-3.X.txt
>
>
> cqlsh's syntax definition does not know about {{PER PARTITION LIMIT}} and 
> therefore does not propose it for auto-completion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12803) PER PARTITION LIMIT not recognized by cqlsh auto completion

[Benjamin Lerer (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Lerer updated CASSANDRA-12803:
---
Reviewer: Robert Stupp
  Status: Patch Available  (was: Open)

> PER PARTITION LIMIT not recognized by cqlsh auto completion
> ---
>
> Key: CASSANDRA-12803
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12803
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Robert Stupp
>Assignee: Benjamin Lerer
>Priority: Trivial
> Fix For: 3.x
>
> Attachments: 12803-3.X.txt
>
>
> cqlsh's syntax definition does not know about {{PER PARTITION LIMIT}} and 
> therefore does not propose it for auto-completion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12803) PER PARTITION LIMIT not recognized by cqlsh auto completion

[Benjamin Lerer (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Lerer updated CASSANDRA-12803:
---
Attachment: 12803-3.X.txt

The patch add autocompletion for PER PARTITION LIMIT

> PER PARTITION LIMIT not recognized by cqlsh auto completion
> ---
>
> Key: CASSANDRA-12803
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12803
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Robert Stupp
>Assignee: Benjamin Lerer
>Priority: Trivial
> Fix For: 3.x
>
> Attachments: 12803-3.X.txt
>
>
> cqlsh's syntax definition does not know about {{PER PARTITION LIMIT}} and 
> therefore does not propose it for auto-completion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12754) Change cassandra.wait_for_tracing_events_timeout_secs default to -1 so C* doesn't wait on trace events to be written before responding to request by default

[Paulo Motta (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15601795#comment-15601795
 ] 

Paulo Motta commented on CASSANDRA-12754:
-

Sorry, this fell off my radar. LGTM! Marking as ready to commit, thanks!

> Change cassandra.wait_for_tracing_events_timeout_secs default to -1 so C* 
> doesn't wait on trace events to be written before responding to request by 
> default
> 
>
> Key: CASSANDRA-12754
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12754
> Project: Cassandra
>  Issue Type: Bug
>  Components: Observability
>Reporter: Andy Tolbert
>Assignee: Stefania
> Fix For: 2.2.x, 3.0.x, 3.x
>
>
> [CASSANDRA-11465] introduces a new system property 
> {{cassandra.wait_for_tracing_events_timeout_secs}} that controls whether or 
> not C* waits for events to be written before responding to client.   The 
> current default behavior is to wait up to 1 second and then respond and 
> timeout.  
> If using probabilistic tracing this can cause queries to be randomly delayed 
> up to 1 second.
> Changing the default to -1 (disabled and enabling it explicitly in 
> {{cql_tracing_test.TestCqlTracing.tracing_unknown_impl_test}}.
> Ideally it would be nice to be able to control this behavior on a per request 
> basis (which would require native protocol changes).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12754) Change cassandra.wait_for_tracing_events_timeout_secs default to -1 so C* doesn't wait on trace events to be written before responding to request by default

[Paulo Motta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paulo Motta updated CASSANDRA-12754:

Status: Ready to Commit  (was: Patch Available)

> Change cassandra.wait_for_tracing_events_timeout_secs default to -1 so C* 
> doesn't wait on trace events to be written before responding to request by 
> default
> 
>
> Key: CASSANDRA-12754
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12754
> Project: Cassandra
>  Issue Type: Bug
>  Components: Observability
>Reporter: Andy Tolbert
>Assignee: Stefania
> Fix For: 2.2.x, 3.0.x, 3.x
>
>
> [CASSANDRA-11465] introduces a new system property 
> {{cassandra.wait_for_tracing_events_timeout_secs}} that controls whether or 
> not C* waits for events to be written before responding to client.   The 
> current default behavior is to wait up to 1 second and then respond and 
> timeout.  
> If using probabilistic tracing this can cause queries to be randomly delayed 
> up to 1 second.
> Changing the default to -1 (disabled and enabling it explicitly in 
> {{cql_tracing_test.TestCqlTracing.tracing_unknown_impl_test}}.
> Ideally it would be nice to be able to control this behavior on a per request 
> basis (which would require native protocol changes).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CASSANDRA-12754) Change cassandra.wait_for_tracing_events_timeout_secs default to -1 so C* doesn't wait on trace events to be written before responding to request by default

[Paulo Motta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-12754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paulo Motta updated CASSANDRA-12754:

Component/s: Observability

> Change cassandra.wait_for_tracing_events_timeout_secs default to -1 so C* 
> doesn't wait on trace events to be written before responding to request by 
> default
> 
>
> Key: CASSANDRA-12754
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12754
> Project: Cassandra
>  Issue Type: Bug
>  Components: Observability
>Reporter: Andy Tolbert
>Assignee: Stefania
> Fix For: 2.2.x, 3.0.x, 3.x
>
>
> [CASSANDRA-11465] introduces a new system property 
> {{cassandra.wait_for_tracing_events_timeout_secs}} that controls whether or 
> not C* waits for events to be written before responding to client.   The 
> current default behavior is to wait up to 1 second and then respond and 
> timeout.  
> If using probabilistic tracing this can cause queries to be randomly delayed 
> up to 1 second.
> Changing the default to -1 (disabled and enabling it explicitly in 
> {{cql_tracing_test.TestCqlTracing.tracing_unknown_impl_test}}.
> Ideally it would be nice to be able to control this behavior on a per request 
> basis (which would require native protocol changes).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12654) Query Validation Error : CQL IN operator over last partitioning|clustering column (valid) is rejected if a query fetches collection columns

[Benjamin Lerer (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15601775#comment-15601775
 ] 

Benjamin Lerer commented on CASSANDRA-12654:


CASSANDRA-5376 -> it seems that the problem was due to a code limitation.
That is why Tyler suggested in its email to try to see if it now works (after 
CASSANDRA-8099).
 

> Query Validation Error : CQL IN operator over last partitioning|clustering 
> column (valid) is rejected if a query fetches collection columns
> ---
>
> Key: CASSANDRA-12654
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12654
> Project: Cassandra
>  Issue Type: Bug
>  Components: CQL
>Reporter: Samba Siva Rao Kolusu
>Assignee: Alex Petrov
>Priority: Minor
>  Labels: easyfix
> Fix For: 3.x
>
>
> although IN operator is allowed over the last clustering or partitioning 
> columns, the CQL Query Validator is rejecting queries when they attempt to 
> fetch collection columns in their result set.
> It seems a similar bug (CASSANDRA-5376) was raised some time ago, and a fix 
> (rather mask) was provided to give a better error message to such queries in 
> 1.2.4. 
> Considering that Cassandra & CQL has evolved a great deal from that period, 
> it now seems possible to provide an actual fix to this problem, i.e. allowing 
> queries to fetch collection columns even when IN operator is used.
> please read the following mail thread to understand the context : 
> https://lists.apache.org/thread.html/8e1765d14bd9798bf9c0938a793f1dbc9c9349062a8705db2e28d291@%3Cuser.cassandra.apache.org%3E



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12654) Query Validation Error : CQL IN operator over last partitioning|clustering column (valid) is rejected if a query fetches collection columns

[DOAN DuyHai (JIRA)]

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15601766#comment-15601766
 ] 

DOAN DuyHai commented on CASSANDRA-12654:
-

Because we need to understand the *rationale* to forbid selecting collections 
when using {{IN}} clause with _clustering columns_

> Query Validation Error : CQL IN operator over last partitioning|clustering 
> column (valid) is rejected if a query fetches collection columns
> ---
>
> Key: CASSANDRA-12654
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12654
> Project: Cassandra
>  Issue Type: Bug
>  Components: CQL
>Reporter: Samba Siva Rao Kolusu
>Assignee: Alex Petrov
>Priority: Minor
>  Labels: easyfix
> Fix For: 3.x
>
>
> although IN operator is allowed over the last clustering or partitioning 
> columns, the CQL Query Validator is rejecting queries when they attempt to 
> fetch collection columns in their result set.
> It seems a similar bug (CASSANDRA-5376) was raised some time ago, and a fix 
> (rather mask) was provided to give a better error message to such queries in 
> 1.2.4. 
> Considering that Cassandra & CQL has evolved a great deal from that period, 
> it now seems possible to provide an actual fix to this problem, i.e. allowing 
> queries to fetch collection columns even when IN operator is used.
> please read the following mail thread to understand the context : 
> https://lists.apache.org/thread.html/8e1765d14bd9798bf9c0938a793f1dbc9c9349062a8705db2e28d291@%3Cuser.cassandra.apache.org%3E



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)