[jira] [Commented] (CASSANDRA-13528) nodetool describeclusters shows different snitch info as to what is configured.
[ https://issues.apache.org/jira/browse/CASSANDRA-13528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016916#comment-16016916 ] Paul Villacorta commented on CASSANDRA-13528: - I like the solution! It provides proper information of the snitch and eliminates the confusion. It would be nice also to have this patch on the forthcoming releases. Thanks! > nodetool describeclusters shows different snitch info as to what is > configured. > --- > > Key: CASSANDRA-13528 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13528 > Project: Cassandra > Issue Type: Bug >Reporter: Paul Villacorta >Assignee: Lerh Chuan Low >Priority: Minor > Labels: lhf > Attachments: 13528-2.1.txt, 13528-trunk.txt, Screen Shot 2017-05-12 > at 14.15.04.png > > > I couldn't find any similar issue as this one so I'm creating one. > I noticed that doing nodetool describecluster shows a different Snitch > Information as to what is being set in the configuration file. > My setup is hosted in AWS and I am using Ec2Snitch. > cassandra@cassandra3$ nodetool describecluster > Cluster Information: > Name: testv3 > Snitch: org.apache.cassandra.locator.DynamicEndpointSnitch > Partitioner: org.apache.cassandra.dht.Murmur3Partitioner > Schema versions: > fc6e8656-ee7a-341b-9782-b569d1fd1a51: > [10.0.3.61,10.0.3.62,10.0.3.63] > I checked via MX4J and it shows the same, I haven't verified tho using a > different Snitch and I am using 2.2.6 above and 3.0.X -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13209) test failure in cqlsh_tests.cqlsh_copy_tests.CqlshCopyTest.test_bulk_round_trip_blogposts_with_max_connections
[ https://issues.apache.org/jira/browse/CASSANDRA-13209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016784#comment-16016784 ] Kurt Greaves commented on CASSANDRA-13209: -- actually it's always less, and it appears the majority of the issues come from the COPY FROM. Not every test failure seems to be caused by the same thing, but the majority appear to be because when timeouts occur in the COPY FROM they don't actually get retried, so some rows don't get written. Also once the COPY FROM code in cqlsh gets over 1000 failed rows it exits, which kind of explains why a lot of the failures are because of a difference of a 1000 rows. Corresponding error is the following, note it mentions the # of attempts, however it will never go past 1. {code}:2:Failed to import 9 rows: OperationTimedOut - errors={'127.0.0.3': 'Client request timeout. See Session.execute[_async](timeout)'}, last_host=127.0.0.3, will retry later, attempt 1 of 5{code} Going to fix the error handling in the COPY FROM command to actually do retries (like COPY TO does), that should make the tests less flaky, as COPY TO also suffers from the timeouts but effectively retries and thus rarely has issues. There is still the underlying problem of why COPY is timing out in the first place, but to be honest I'd put it down to the command and nodes simply using too much resources on the servers. If it's still very flaky after fixing the retries we can look into performance issues more. > test failure in > cqlsh_tests.cqlsh_copy_tests.CqlshCopyTest.test_bulk_round_trip_blogposts_with_max_connections > -- > > Key: CASSANDRA-13209 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13209 > Project: Cassandra > Issue Type: Bug >Reporter: Michael Shuler >Assignee: Kurt Greaves > Labels: dtest, test-failure > Attachments: node1.log, node2.log, node3.log, node4.log, node5.log > > > example failure: > http://cassci.datastax.com/job/cassandra-2.1_dtest/528/testReport/cqlsh_tests.cqlsh_copy_tests/CqlshCopyTest/test_bulk_round_trip_blogposts_with_max_connections > {noformat} > Error Message > errors={'127.0.0.4': 'Client request timeout. See > Session.execute[_async](timeout)'}, last_host=127.0.0.4 > >> begin captured logging << > dtest: DEBUG: cluster ccm directory: /tmp/dtest-792s6j > dtest: DEBUG: Done setting configuration options: > { 'initial_token': None, > 'num_tokens': '32', > 'phi_convict_threshold': 5, > 'range_request_timeout_in_ms': 1, > 'read_request_timeout_in_ms': 1, > 'request_timeout_in_ms': 1, > 'truncate_request_timeout_in_ms': 1, > 'write_request_timeout_in_ms': 1} > dtest: DEBUG: removing ccm cluster test at: /tmp/dtest-792s6j > dtest: DEBUG: clearing ssl stores from [/tmp/dtest-792s6j] directory > dtest: DEBUG: cluster ccm directory: /tmp/dtest-uNMsuW > dtest: DEBUG: Done setting configuration options: > { 'initial_token': None, > 'num_tokens': '32', > 'phi_convict_threshold': 5, > 'range_request_timeout_in_ms': 1, > 'read_request_timeout_in_ms': 1, > 'request_timeout_in_ms': 1, > 'truncate_request_timeout_in_ms': 1, > 'write_request_timeout_in_ms': 1} > cassandra.policies: INFO: Using datacenter 'datacenter1' for > DCAwareRoundRobinPolicy (via host '127.0.0.1'); if incorrect, please specify > a local_dc to the constructor, or limit contact points to local cluster nodes > cassandra.cluster: INFO: New Cassandra host > discovered > cassandra.cluster: INFO: New Cassandra host > discovered > cassandra.cluster: INFO: New Cassandra host > discovered > cassandra.cluster: INFO: New Cassandra host > discovered > dtest: DEBUG: Running stress with user profile > /home/automaton/cassandra-dtest/cqlsh_tests/blogposts.yaml > - >> end captured logging << - > Stacktrace > File "/usr/lib/python2.7/unittest/case.py", line 329, in run > testMethod() > File "/home/automaton/cassandra-dtest/dtest.py", line 1090, in wrapped > f(obj) > File "/home/automaton/cassandra-dtest/cqlsh_tests/cqlsh_copy_tests.py", > line 2571, in test_bulk_round_trip_blogposts_with_max_connections > copy_from_options={'NUMPROCESSES': 2}) > File "/home/automaton/cassandra-dtest/cqlsh_tests/cqlsh_copy_tests.py", > line 2500, in _test_bulk_round_trip > num_records = create_records() > File "/home/automaton/cassandra-dtest/cqlsh_tests/cqlsh_copy_tests.py", > line 2473, in create_records > ret = rows_to_list(self.session.execute(count_statement))[0][0] > File "/home/automaton/src/cassandra-driver/cassandra/cluster.py", line > 1998, in execute > return
[jira] [Updated] (CASSANDRA-13521) Add configurable upper bound for validation executor threads
[ https://issues.apache.org/jira/browse/CASSANDRA-13521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Eggleston updated CASSANDRA-13521: Resolution: Fixed Status: Resolved (was: Ready to Commit) Committed to trunk as {{8028d4bdd646058f18f45cad10b5de74efc415e6}} > Add configurable upper bound for validation executor threads > > > Key: CASSANDRA-13521 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13521 > Project: Cassandra > Issue Type: Improvement >Reporter: Blake Eggleston >Assignee: Blake Eggleston > Fix For: 4.0 > > > CompactionManager.validationExecutor has no upper limit on the maximum number > of threads it can use. This could cause a node to become overwhelmed with > simultaneous validation tasks in some cases. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
cassandra git commit: Add configurable upper bound for validation executor threads
Repository: cassandra Updated Branches: refs/heads/trunk d2cb90fc5 -> 8028d4bdd Add configurable upper bound for validation executor threads Patch by Blake Eggleston; Reviewed by Jeff Jirsa for CASSANDRA-13521 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/8028d4bd Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/8028d4bd Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/8028d4bd Branch: refs/heads/trunk Commit: 8028d4bdd646058f18f45cad10b5de74efc415e6 Parents: d2cb90f Author: Blake EgglestonAuthored: Wed May 10 13:10:14 2017 -0700 Committer: Blake Eggleston Committed: Thu May 18 16:15:33 2017 -0700 -- CHANGES.txt | 1 + conf/cassandra.yaml | 4 src/java/org/apache/cassandra/config/Config.java | 2 ++ .../apache/cassandra/config/DatabaseDescriptor.java | 14 ++ .../cassandra/db/compaction/CompactionManager.java| 8 +++- .../org/apache/cassandra/service/StorageService.java | 11 +++ .../apache/cassandra/service/StorageServiceMBean.java | 3 +++ 7 files changed, 42 insertions(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/8028d4bd/CHANGES.txt -- diff --git a/CHANGES.txt b/CHANGES.txt index 9d1323d..a5afb86 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,4 +1,5 @@ 4.0 + * Add configurable upper bound for validation executor threads (CASSANDRA-13521) * Bring back maxHintTTL propery (CASSANDRA-12982) * Add testing guidelines (CASSANDRA-13497) * Add more repair metrics (CASSANDRA-13531) http://git-wip-us.apache.org/repos/asf/cassandra/blob/8028d4bd/conf/cassandra.yaml -- diff --git a/conf/cassandra.yaml b/conf/cassandra.yaml index e968b0c..bdc68d1 100644 --- a/conf/cassandra.yaml +++ b/conf/cassandra.yaml @@ -748,6 +748,10 @@ column_index_cache_size_in_kb: 2 # to the number of cores. #concurrent_compactors: 1 +# Number of simultaneous repair validations to allow. Default is unbounded +# Values less than one are interpreted as unbounded (the default) +# concurrent_validations: 0 + # Throttles compaction to the given total throughput across the entire # system. The faster you insert data, the faster you need to compact in # order to keep the sstable count down, but in general, setting this to http://git-wip-us.apache.org/repos/asf/cassandra/blob/8028d4bd/src/java/org/apache/cassandra/config/Config.java -- diff --git a/src/java/org/apache/cassandra/config/Config.java b/src/java/org/apache/cassandra/config/Config.java index e76284d..b7bacde 100644 --- a/src/java/org/apache/cassandra/config/Config.java +++ b/src/java/org/apache/cassandra/config/Config.java @@ -171,6 +171,8 @@ public class Config public volatile int compaction_large_partition_warning_threshold_mb = 100; public int min_free_space_per_drive_in_mb = 50; +public volatile int concurrent_validations = Integer.MAX_VALUE; + /** * @deprecated retry support removed on CASSANDRA-10992 */ http://git-wip-us.apache.org/repos/asf/cassandra/blob/8028d4bd/src/java/org/apache/cassandra/config/DatabaseDescriptor.java -- diff --git a/src/java/org/apache/cassandra/config/DatabaseDescriptor.java b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java index 85f070f..2d4f191 100644 --- a/src/java/org/apache/cassandra/config/DatabaseDescriptor.java +++ b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java @@ -562,6 +562,9 @@ public class DatabaseDescriptor if (conf.concurrent_compactors == null) conf.concurrent_compactors = Math.min(8, Math.max(2, Math.min(FBUtilities.getAvailableProcessors(), conf.data_file_directories.length))); +if (conf.concurrent_validations < 1) +conf.concurrent_validations = Integer.MAX_VALUE; + if (conf.concurrent_compactors <= 0) throw new ConfigurationException("concurrent_compactors should be strictly greater than 0, but was " + conf.concurrent_compactors, false); @@ -1400,6 +1403,17 @@ public class DatabaseDescriptor public static int getCompactionLargePartitionWarningThreshold() { return conf.compaction_large_partition_warning_threshold_mb * 1024 * 1024; } +public static int getConcurrentValidations() +{ +return conf.concurrent_validations; +} + +public static void setConcurrentValidations(int value) +{ +value = value > 0 ? value : Integer.MAX_VALUE; +
[jira] [Commented] (CASSANDRA-13508) Make system.paxos table compaction strategy configurable
[ https://issues.apache.org/jira/browse/CASSANDRA-13508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016627#comment-16016627 ] Jeff Jirsa commented on CASSANDRA-13508: Also cc [~kohlisankalp] and [~bdeggleston] - both of whom have spent quite a bit of time thinking about paxos. I think LCS is better than TWCS, for read performance (if we have to go to disk), so I'm glad you've wont-fixed that. Tuning compaction (or compression, more likely, as dropping compression chunk size can be really helpful for read performance) may be useful, but I suspect your patch allows the altering of more than just properties - would also let users edit schema structure, which we should definitely prevent. > Make system.paxos table compaction strategy configurable > > > Key: CASSANDRA-13508 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13508 > Project: Cassandra > Issue Type: Improvement >Reporter: Jay Zhuang >Assignee: Jay Zhuang > Fix For: 4.0, 4.x > > Attachments: test11.png, test2.png > > > The default compaction strategy for {{system.paxos}} table is LCS for > performance reason: CASSANDRA-7753. But for CAS heavily used cluster, the > system is busy with {{system.paxos}} compaction. > As the data in {{paxos}} table are TTL'ed, TWCS might be a better fit. In our > test, it significantly reduced the number of compaction without impacting the > latency too much: > !test11.png! > The time window for TWCS is set to 2 minutes for the test. > Here is the p99 latency impact: > !test2.png! > the yellow one is LCS, the purple one is TWCS. Average p99 has about 10% > increase. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13508) Make system.paxos table compaction strategy configurable
[ https://issues.apache.org/jira/browse/CASSANDRA-13508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016611#comment-16016611 ] Jay Zhuang commented on CASSANDRA-13508: Hi [~jjirsa], what do you think about this? Paxos table could be very large. In our case, it's actually even larger than one user table. As all the CAS write data are stored in Paxos table with gc_grace TTL. If we have several tables using CAS write, the paxos table is very large. Tuning the compaction would be useful. This patch is giving the customer the option to change or configure the compaction strategy. Let me know if you have any suggestion. > Make system.paxos table compaction strategy configurable > > > Key: CASSANDRA-13508 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13508 > Project: Cassandra > Issue Type: Improvement >Reporter: Jay Zhuang >Assignee: Jay Zhuang > Fix For: 4.0, 4.x > > Attachments: test11.png, test2.png > > > The default compaction strategy for {{system.paxos}} table is LCS for > performance reason: CASSANDRA-7753. But for CAS heavily used cluster, the > system is busy with {{system.paxos}} compaction. > As the data in {{paxos}} table are TTL'ed, TWCS might be a better fit. In our > test, it significantly reduced the number of compaction without impacting the > latency too much: > !test11.png! > The time window for TWCS is set to 2 minutes for the test. > Here is the p99 latency impact: > !test2.png! > the yellow one is LCS, the purple one is TWCS. Average p99 has about 10% > increase. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13528) nodetool describeclusters shows different snitch info as to what is configured.
[ https://issues.apache.org/jira/browse/CASSANDRA-13528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016585#comment-16016585 ] Lerh Chuan Low commented on CASSANDRA-13528: I like that approach, sounds reasonable. I've attached some patches, one for 2.1 and one for 2.2, 3.0, 3.X, trunk (it applies cleanly). Any thoughts? {code} Cluster Information: Name: Test Cluster Snitch: org.apache.cassandra.locator.SimpleSnitch DynamicEndPointSnitch: enabled Partitioner: org.apache.cassandra.dht.Murmur3Partitioner Schema versions: 9cf2fd0e-ab63-348e-b9af-6db0a3da5a29: [127.0.0.1] {code} {code} Cluster Information: Name: Test Cluster Snitch: org.apache.cassandra.locator.SimpleSnitch DynamicEndPointSnitch: disabled Partitioner: org.apache.cassandra.dht.Murmur3Partitioner Schema versions: 9cf2fd0e-ab63-348e-b9af-6db0a3da5a29: [127.0.0.1] {code} > nodetool describeclusters shows different snitch info as to what is > configured. > --- > > Key: CASSANDRA-13528 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13528 > Project: Cassandra > Issue Type: Bug >Reporter: Paul Villacorta >Priority: Minor > Labels: lhf > Attachments: 13528-2.1.txt, 13528-trunk.txt, Screen Shot 2017-05-12 > at 14.15.04.png > > > I couldn't find any similar issue as this one so I'm creating one. > I noticed that doing nodetool describecluster shows a different Snitch > Information as to what is being set in the configuration file. > My setup is hosted in AWS and I am using Ec2Snitch. > cassandra@cassandra3$ nodetool describecluster > Cluster Information: > Name: testv3 > Snitch: org.apache.cassandra.locator.DynamicEndpointSnitch > Partitioner: org.apache.cassandra.dht.Murmur3Partitioner > Schema versions: > fc6e8656-ee7a-341b-9782-b569d1fd1a51: > [10.0.3.61,10.0.3.62,10.0.3.63] > I checked via MX4J and it shows the same, I haven't verified tho using a > different Snitch and I am using 2.2.6 above and 3.0.X -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-13528) nodetool describeclusters shows different snitch info as to what is configured.
[ https://issues.apache.org/jira/browse/CASSANDRA-13528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lerh Chuan Low updated CASSANDRA-13528: --- Attachment: 13528-trunk.txt 13528-2.1.txt > nodetool describeclusters shows different snitch info as to what is > configured. > --- > > Key: CASSANDRA-13528 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13528 > Project: Cassandra > Issue Type: Bug >Reporter: Paul Villacorta >Priority: Minor > Labels: lhf > Attachments: 13528-2.1.txt, 13528-trunk.txt, Screen Shot 2017-05-12 > at 14.15.04.png > > > I couldn't find any similar issue as this one so I'm creating one. > I noticed that doing nodetool describecluster shows a different Snitch > Information as to what is being set in the configuration file. > My setup is hosted in AWS and I am using Ec2Snitch. > cassandra@cassandra3$ nodetool describecluster > Cluster Information: > Name: testv3 > Snitch: org.apache.cassandra.locator.DynamicEndpointSnitch > Partitioner: org.apache.cassandra.dht.Murmur3Partitioner > Schema versions: > fc6e8656-ee7a-341b-9782-b569d1fd1a51: > [10.0.3.61,10.0.3.62,10.0.3.63] > I checked via MX4J and it shows the same, I haven't verified tho using a > different Snitch and I am using 2.2.6 above and 3.0.X -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-13528) nodetool describeclusters shows different snitch info as to what is configured.
[ https://issues.apache.org/jira/browse/CASSANDRA-13528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lerh Chuan Low updated CASSANDRA-13528: --- Assignee: Lerh Chuan Low Status: Patch Available (was: Open) > nodetool describeclusters shows different snitch info as to what is > configured. > --- > > Key: CASSANDRA-13528 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13528 > Project: Cassandra > Issue Type: Bug >Reporter: Paul Villacorta >Assignee: Lerh Chuan Low >Priority: Minor > Labels: lhf > Attachments: 13528-2.1.txt, 13528-trunk.txt, Screen Shot 2017-05-12 > at 14.15.04.png > > > I couldn't find any similar issue as this one so I'm creating one. > I noticed that doing nodetool describecluster shows a different Snitch > Information as to what is being set in the configuration file. > My setup is hosted in AWS and I am using Ec2Snitch. > cassandra@cassandra3$ nodetool describecluster > Cluster Information: > Name: testv3 > Snitch: org.apache.cassandra.locator.DynamicEndpointSnitch > Partitioner: org.apache.cassandra.dht.Murmur3Partitioner > Schema versions: > fc6e8656-ee7a-341b-9782-b569d1fd1a51: > [10.0.3.61,10.0.3.62,10.0.3.63] > I checked via MX4J and it shows the same, I haven't verified tho using a > different Snitch and I am using 2.2.6 above and 3.0.X -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13539) The keyspace repairTime metric is not updated
[ https://issues.apache.org/jira/browse/CASSANDRA-13539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016552#comment-16016552 ] Blake Eggleston commented on CASSANDRA-13539: - +1, will commit after [utests|https://circleci.com/gh/bdeggleston/cassandra/52] finish > The keyspace repairTime metric is not updated > - > > Key: CASSANDRA-13539 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13539 > Project: Cassandra > Issue Type: Bug > Components: Observability >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Minor > Fix For: 4.0 > > > repairTime metric at keyspace metric isnt updated when repairs complete so > its always zeros. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-13346) Failed unregistering mbean during drop keyspace
[ https://issues.apache.org/jira/browse/CASSANDRA-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Jirsa updated CASSANDRA-13346: --- Status: Ready to Commit (was: Patch Available) > Failed unregistering mbean during drop keyspace > --- > > Key: CASSANDRA-13346 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13346 > Project: Cassandra > Issue Type: Bug > Components: Materialized Views > Environment: Cassandra 3.9 >Reporter: Gábor Auth >Assignee: Lerh Chuan Low >Priority: Minor > Labels: lhf > Fix For: 3.10, 3.0.x > > Attachments: 13346-3.0.X.txt, 13346-3.X.txt, 13346-trunk.txt > > > All node throw exceptions about materialized views during drop keyspace: > {code} > WARN [MigrationStage:1] 2017-03-16 16:54:25,016 ColumnFamilyStore.java:535 - > Failed unregistering mbean: > org.apache.cassandra.db:type=Tables,keyspace=test20160810,table=unit_by_account > java.lang.NullPointerException: null > at > java.util.concurrent.ConcurrentHashMap.replaceNode(ConcurrentHashMap.java:1106) > ~[na:1.8.0_121] > at > java.util.concurrent.ConcurrentHashMap.remove(ConcurrentHashMap.java:1097) > ~[na:1.8.0_121] > at > java.util.concurrent.ConcurrentHashMap$KeySetView.remove(ConcurrentHashMap.java:4569) > ~[na:1.8.0_121] > at > org.apache.cassandra.metrics.TableMetrics.release(TableMetrics.java:712) > ~[apache-cassandra-3.9.0.jar:3.9.0] > at > org.apache.cassandra.db.ColumnFamilyStore.unregisterMBean(ColumnFamilyStore.java:570) > [apache-cassandra-3.9.0.jar:3.9.0] > at > org.apache.cassandra.db.ColumnFamilyStore.invalidate(ColumnFamilyStore.java:527) > [apache-cassandra-3.9.0.jar:3.9.0] > at > org.apache.cassandra.db.ColumnFamilyStore.invalidate(ColumnFamilyStore.java:517) > [apache-cassandra-3.9.0.jar:3.9.0] > at org.apache.cassandra.db.Keyspace.unloadCf(Keyspace.java:365) > [apache-cassandra-3.9.0.jar:3.9.0] > at org.apache.cassandra.db.Keyspace.dropCf(Keyspace.java:358) > [apache-cassandra-3.9.0.jar:3.9.0] > at org.apache.cassandra.config.Schema.dropView(Schema.java:744) > [apache-cassandra-3.9.0.jar:3.9.0] > at > org.apache.cassandra.schema.SchemaKeyspace.lambda$mergeSchema$373(SchemaKeyspace.java:1287) > [apache-cassandra-3.9.0.jar:3.9.0] > at java.lang.Iterable.forEach(Iterable.java:75) ~[na:1.8.0_121] > at > org.apache.cassandra.schema.SchemaKeyspace.mergeSchema(SchemaKeyspace.java:1287) > [apache-cassandra-3.9.0.jar:3.9.0] > at > org.apache.cassandra.schema.SchemaKeyspace.mergeSchemaAndAnnounceVersion(SchemaKeyspace.java:1256) > [apache-cassandra-3.9.0.jar:3.9.0] > at > org.apache.cassandra.db.DefinitionsUpdateVerbHandler$1.runMayThrow(DefinitionsUpdateVerbHandler.java:51) > ~[apache-cassandra-3.9.0.jar:3.9.0] > at > org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28) > ~[apache-cassandra-3.9.0.jar:3.9.0] > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) > ~[na:1.8.0_121] > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > ~[na:1.8.0_121] > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > ~[na:1.8.0_121] > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > ~[na:1.8.0_121] > at java.lang.Thread.run(Thread.java:745) ~[na:1.8.0_121] > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-13346) Failed unregistering mbean during drop keyspace
[ https://issues.apache.org/jira/browse/CASSANDRA-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Jirsa updated CASSANDRA-13346: --- Reproduced In: 3.10, 3.0.13 (was: 3.0.13, 3.10) Reviewer: Chris Lohfink > Failed unregistering mbean during drop keyspace > --- > > Key: CASSANDRA-13346 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13346 > Project: Cassandra > Issue Type: Bug > Components: Materialized Views > Environment: Cassandra 3.9 >Reporter: Gábor Auth >Assignee: Lerh Chuan Low >Priority: Minor > Labels: lhf > Fix For: 3.10, 3.0.x > > Attachments: 13346-3.0.X.txt, 13346-3.X.txt, 13346-trunk.txt > > > All node throw exceptions about materialized views during drop keyspace: > {code} > WARN [MigrationStage:1] 2017-03-16 16:54:25,016 ColumnFamilyStore.java:535 - > Failed unregistering mbean: > org.apache.cassandra.db:type=Tables,keyspace=test20160810,table=unit_by_account > java.lang.NullPointerException: null > at > java.util.concurrent.ConcurrentHashMap.replaceNode(ConcurrentHashMap.java:1106) > ~[na:1.8.0_121] > at > java.util.concurrent.ConcurrentHashMap.remove(ConcurrentHashMap.java:1097) > ~[na:1.8.0_121] > at > java.util.concurrent.ConcurrentHashMap$KeySetView.remove(ConcurrentHashMap.java:4569) > ~[na:1.8.0_121] > at > org.apache.cassandra.metrics.TableMetrics.release(TableMetrics.java:712) > ~[apache-cassandra-3.9.0.jar:3.9.0] > at > org.apache.cassandra.db.ColumnFamilyStore.unregisterMBean(ColumnFamilyStore.java:570) > [apache-cassandra-3.9.0.jar:3.9.0] > at > org.apache.cassandra.db.ColumnFamilyStore.invalidate(ColumnFamilyStore.java:527) > [apache-cassandra-3.9.0.jar:3.9.0] > at > org.apache.cassandra.db.ColumnFamilyStore.invalidate(ColumnFamilyStore.java:517) > [apache-cassandra-3.9.0.jar:3.9.0] > at org.apache.cassandra.db.Keyspace.unloadCf(Keyspace.java:365) > [apache-cassandra-3.9.0.jar:3.9.0] > at org.apache.cassandra.db.Keyspace.dropCf(Keyspace.java:358) > [apache-cassandra-3.9.0.jar:3.9.0] > at org.apache.cassandra.config.Schema.dropView(Schema.java:744) > [apache-cassandra-3.9.0.jar:3.9.0] > at > org.apache.cassandra.schema.SchemaKeyspace.lambda$mergeSchema$373(SchemaKeyspace.java:1287) > [apache-cassandra-3.9.0.jar:3.9.0] > at java.lang.Iterable.forEach(Iterable.java:75) ~[na:1.8.0_121] > at > org.apache.cassandra.schema.SchemaKeyspace.mergeSchema(SchemaKeyspace.java:1287) > [apache-cassandra-3.9.0.jar:3.9.0] > at > org.apache.cassandra.schema.SchemaKeyspace.mergeSchemaAndAnnounceVersion(SchemaKeyspace.java:1256) > [apache-cassandra-3.9.0.jar:3.9.0] > at > org.apache.cassandra.db.DefinitionsUpdateVerbHandler$1.runMayThrow(DefinitionsUpdateVerbHandler.java:51) > ~[apache-cassandra-3.9.0.jar:3.9.0] > at > org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28) > ~[apache-cassandra-3.9.0.jar:3.9.0] > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) > ~[na:1.8.0_121] > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > ~[na:1.8.0_121] > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > ~[na:1.8.0_121] > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > ~[na:1.8.0_121] > at java.lang.Thread.run(Thread.java:745) ~[na:1.8.0_121] > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13346) Failed unregistering mbean during drop keyspace
[ https://issues.apache.org/jira/browse/CASSANDRA-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016460#comment-16016460 ] Lerh Chuan Low commented on CASSANDRA-13346: Ahhh I see, thanks for going through all that with me though :) > Failed unregistering mbean during drop keyspace > --- > > Key: CASSANDRA-13346 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13346 > Project: Cassandra > Issue Type: Bug > Components: Materialized Views > Environment: Cassandra 3.9 >Reporter: Gábor Auth >Assignee: Lerh Chuan Low >Priority: Minor > Labels: lhf > Fix For: 3.10, 3.0.x > > Attachments: 13346-3.0.X.txt, 13346-3.X.txt, 13346-trunk.txt > > > All node throw exceptions about materialized views during drop keyspace: > {code} > WARN [MigrationStage:1] 2017-03-16 16:54:25,016 ColumnFamilyStore.java:535 - > Failed unregistering mbean: > org.apache.cassandra.db:type=Tables,keyspace=test20160810,table=unit_by_account > java.lang.NullPointerException: null > at > java.util.concurrent.ConcurrentHashMap.replaceNode(ConcurrentHashMap.java:1106) > ~[na:1.8.0_121] > at > java.util.concurrent.ConcurrentHashMap.remove(ConcurrentHashMap.java:1097) > ~[na:1.8.0_121] > at > java.util.concurrent.ConcurrentHashMap$KeySetView.remove(ConcurrentHashMap.java:4569) > ~[na:1.8.0_121] > at > org.apache.cassandra.metrics.TableMetrics.release(TableMetrics.java:712) > ~[apache-cassandra-3.9.0.jar:3.9.0] > at > org.apache.cassandra.db.ColumnFamilyStore.unregisterMBean(ColumnFamilyStore.java:570) > [apache-cassandra-3.9.0.jar:3.9.0] > at > org.apache.cassandra.db.ColumnFamilyStore.invalidate(ColumnFamilyStore.java:527) > [apache-cassandra-3.9.0.jar:3.9.0] > at > org.apache.cassandra.db.ColumnFamilyStore.invalidate(ColumnFamilyStore.java:517) > [apache-cassandra-3.9.0.jar:3.9.0] > at org.apache.cassandra.db.Keyspace.unloadCf(Keyspace.java:365) > [apache-cassandra-3.9.0.jar:3.9.0] > at org.apache.cassandra.db.Keyspace.dropCf(Keyspace.java:358) > [apache-cassandra-3.9.0.jar:3.9.0] > at org.apache.cassandra.config.Schema.dropView(Schema.java:744) > [apache-cassandra-3.9.0.jar:3.9.0] > at > org.apache.cassandra.schema.SchemaKeyspace.lambda$mergeSchema$373(SchemaKeyspace.java:1287) > [apache-cassandra-3.9.0.jar:3.9.0] > at java.lang.Iterable.forEach(Iterable.java:75) ~[na:1.8.0_121] > at > org.apache.cassandra.schema.SchemaKeyspace.mergeSchema(SchemaKeyspace.java:1287) > [apache-cassandra-3.9.0.jar:3.9.0] > at > org.apache.cassandra.schema.SchemaKeyspace.mergeSchemaAndAnnounceVersion(SchemaKeyspace.java:1256) > [apache-cassandra-3.9.0.jar:3.9.0] > at > org.apache.cassandra.db.DefinitionsUpdateVerbHandler$1.runMayThrow(DefinitionsUpdateVerbHandler.java:51) > ~[apache-cassandra-3.9.0.jar:3.9.0] > at > org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28) > ~[apache-cassandra-3.9.0.jar:3.9.0] > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) > ~[na:1.8.0_121] > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > ~[na:1.8.0_121] > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > ~[na:1.8.0_121] > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > ~[na:1.8.0_121] > at java.lang.Thread.run(Thread.java:745) ~[na:1.8.0_121] > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-8877) Ability to read the TTL and WRITE TIME of an element in a collection
[ https://issues.apache.org/jira/browse/CASSANDRA-8877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Lerer reassigned CASSANDRA-8877: - Assignee: Benjamin Lerer > Ability to read the TTL and WRITE TIME of an element in a collection > > > Key: CASSANDRA-8877 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8877 > Project: Cassandra > Issue Type: Improvement >Reporter: Drew Kutcharian >Assignee: Benjamin Lerer >Priority: Minor > Fix For: 4.x > > > Currently it's possible to set the TTL and WRITE TIME of an element in a > collection using CQL, but there is no way to read them back. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
cassandra git commit: Fix broken url to "Building a Better Bloom Filter"
Repository: cassandra Updated Branches: refs/heads/trunk 4a12dabef -> d2cb90fc5 Fix broken url to "Building a Better Bloom Filter" Closes #112 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/d2cb90fc Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/d2cb90fc Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/d2cb90fc Branch: refs/heads/trunk Commit: d2cb90fc5115bf321816ea2dee2b7b63e409b523 Parents: 4a12dab Author: André LaszloAuthored: Thu May 18 20:26:30 2017 +0200 Committer: Stefan Podkowinski Committed: Thu May 18 20:26:55 2017 +0200 -- src/java/org/apache/cassandra/utils/BloomFilter.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/d2cb90fc/src/java/org/apache/cassandra/utils/BloomFilter.java -- diff --git a/src/java/org/apache/cassandra/utils/BloomFilter.java b/src/java/org/apache/cassandra/utils/BloomFilter.java index bc52c09..bf48d43 100644 --- a/src/java/org/apache/cassandra/utils/BloomFilter.java +++ b/src/java/org/apache/cassandra/utils/BloomFilter.java @@ -59,7 +59,7 @@ public class BloomFilter extends WrappedSharedCloseable implements IFilter // Murmur is faster than an SHA-based approach and provides as-good collision // resistance. The combinatorial generation approach described in -// http://www.eecs.harvard.edu/~kirsch/pubs/bbbf/esa06.pdf +// https://www.eecs.harvard.edu/~michaelm/postscripts/tr-02-05.pdf // does prove to work in actual tests, and is obviously faster // than performing further iterations of murmur. - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13492) RPM Init: don't attempt to start if it's running
[ https://issues.apache.org/jira/browse/CASSANDRA-13492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016197#comment-16016197 ] Stefan Podkowinski commented on CASSANDRA-13492: Using the existing SysV scripts is simply the fasted way to provide working packages for new releases. The existing debian package is also making use of SysV scripting and if we want to migrate to systemd, we should do it for both debian and rpm. But we need a bit more time for that if we're really doing that step and we need the RPMs now, as users are left with no alternative source. Speaking of alternative sources, there's work on the way to get Cassandra packaged for Fedora (see comments on CASSANDRA-12996). Looking at what's being done there, systemd support would be included and I'm looking forward to see how packaging would look like when done in spirit of the "Fedora way". > RPM Init: don't attempt to start if it's running > > > Key: CASSANDRA-13492 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13492 > Project: Cassandra > Issue Type: Sub-task > Components: Packaging >Reporter: martin a langhoff >Assignee: Stefan Podkowinski > Attachments: 0002-RPM-Init-avoid-starting-cassandra-if-it-is-up.patch > > > We don't check whether Cassandra is running. Attempts to start Cassandra when > it's already running overwrite the pidfile, make a confusing mess of > logfiles, _fail to start, as the port is taken_; and then the init script > cannot bring the first Cassandra process down because the init file has been > clobbered. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-13493) RPM Init: Service startup ordering
[ https://issues.apache.org/jira/browse/CASSANDRA-13493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Podkowinski updated CASSANDRA-13493: --- Resolution: Fixed Assignee: Stefan Podkowinski Fix Version/s: 4.0 3.0.14 2.2.10 Status: Resolved (was: Ready to Commit) Merged as dd6aa991b33caef4c1b6f2b5bc5ef3237cb87865 > RPM Init: Service startup ordering > -- > > Key: CASSANDRA-13493 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13493 > Project: Cassandra > Issue Type: Sub-task > Components: Packaging >Reporter: martin a langhoff >Assignee: Stefan Podkowinski > Fix For: 2.2.10, 3.0.14, 3.11.0, 4.0 > > Attachments: > 0001-RPM-Init-ordering-start-after-network-and-name-servi.patch > > > Currently, Cassandra is setup to start _before_ network and name services > come up, and setup to be town down _after_ them, dangerously close to the > final shutdown call. > A service daemon which may use network-based storage, and serves requests > over a network needs to start clearly after network and network mounts, and > come down clearly after. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13510) CI for valdiating cassandra on power platform
[ https://issues.apache.org/jira/browse/CASSANDRA-13510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016165#comment-16016165 ] Michael Shuler commented on CASSANDRA-13510: That run failed eclipse-warnings, [~amitkumar_ghatwal], so if these errors get cleaned up, it will move to running the other unit tests: {noformat} eclipse-warnings: [mkdir] Created dir: /home/jenkins/jenkins-slave/workspace/cassandra-devbranch-ppc64le-testall/build/ecj [echo] Running Eclipse Code Analysis. Output logged to /home/jenkins/jenkins-slave/workspace/cassandra-devbranch-ppc64le-testall/build/ecj/eclipse_compiler_checks.txt [java] -- [java] 1. ERROR in /home/jenkins/jenkins-slave/workspace/cassandra-devbranch-ppc64le-testall/src/java/org/apache/cassandra/cache/capi/CapiChunkDriver.java (at line 292) [java] throw new IOException(ex); [java] ^^ [java] Potential resource leak: 'chunk' may not be closed at this location [java] -- [java] 2. ERROR in /home/jenkins/jenkins-slave/workspace/cassandra-devbranch-ppc64le-testall/src/java/org/apache/cassandra/cache/capi/CapiChunkDriver.java (at line 296) [java] throw new IOException("capi device error: " + chunk2Device.get(chunk)); [java] ^^^ [java] Potential resource leak: 'chunk' may not be closed at this location [java] -- [java] 3. ERROR in /home/jenkins/jenkins-slave/workspace/cassandra-devbranch-ppc64le-testall/src/java/org/apache/cassandra/cache/capi/CapiChunkDriver.java (at line 318) [java] throw new IOException(ex); [java] ^^ [java] Potential resource leak: 'chunk' may not be closed at this location [java] -- [java] 4. ERROR in /home/jenkins/jenkins-slave/workspace/cassandra-devbranch-ppc64le-testall/src/java/org/apache/cassandra/cache/capi/CapiChunkDriver.java (at line 322) [java] throw new IOException("capi device error: " + chunk2Device.get(chunk)); [java] ^^^ [java] Potential resource leak: 'chunk' may not be closed at this location [java] -- [java] 4 problems (4 errors) {noformat} > CI for valdiating cassandra on power platform > - > > Key: CASSANDRA-13510 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13510 > Project: Cassandra > Issue Type: Improvement >Reporter: Amitkumar Ghatwal > > Hi All, > As i understand that currently CI available for cassandra ( to validate any > code updates ) is : http://cassci.datastax.com/view/Dev/ and as can be seen > most of the deployment here is on Intel - X86 arch . > Just wanted to know your views/comments/suggestions for having a CI of > cassandra on Power . > 1) If the community will be willing to add - vm's/slaves ( ppc64le based ) to > their current above CI . May be some externally hosted - ppc64le vm's can be > attached as slaves to above jenkins server. > 2) Use an externally hosted jenkins CI - for running cassandra build on power > and link the results of the build to the above CI. > This ticket is just a follow up on CI query for Cassandra on power - > https://issues.apache.org/jira/browse/CASSANDRA-13486. > Please let me know your thoughts. > Regards, > Amit -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-13490) RPM Spec - disable binary check, improve readme instructions
[ https://issues.apache.org/jira/browse/CASSANDRA-13490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Podkowinski updated CASSANDRA-13490: --- Resolution: Fixed Assignee: Stefan Podkowinski Fix Version/s: 4.0 3.0.14 2.2.10 Status: Resolved (was: Ready to Commit) Merged as 480a612eeffa6d3e77cd4f25676a90a2917da4a4 Thanks! > RPM Spec - disable binary check, improve readme instructions > > > Key: CASSANDRA-13490 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13490 > Project: Cassandra > Issue Type: Sub-task > Components: Packaging >Reporter: martin a langhoff >Assignee: Stefan Podkowinski > Fix For: 2.2.10, 3.0.14, 3.11.0, 4.0 > > Attachments: > 0001-RPM-rpmbuild-tolerate-binaries-in-noarch-README-upda.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[09/22] cassandra git commit: Merge branch 'cassandra-2.2' into cassandra-3.0
Merge branch 'cassandra-2.2' into cassandra-3.0 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/9092d745 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/9092d745 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/9092d745 Branch: refs/heads/cassandra-3.0 Commit: 9092d7458d70b119dd227cce31651ac4d1bf990a Parents: 95635f3 480a612 Author: Stefan PodkowinskiAuthored: Thu May 18 19:32:34 2017 +0200 Committer: Stefan Podkowinski Committed: Thu May 18 19:32:41 2017 +0200 -- redhat/README.md | 19 ++- redhat/cassandra.spec | 5 - 2 files changed, 14 insertions(+), 10 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/9092d745/redhat/cassandra.spec -- - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[13/22] cassandra git commit: RPM: Add init info stanzas, change startup ordering
RPM: Add init info stanzas, change startup ordering patch by Martin A. Langhoff; reviewed by Stefan Podkowinski for CASSANDRA-13493 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/dd6aa991 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/dd6aa991 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/dd6aa991 Branch: refs/heads/cassandra-2.2 Commit: dd6aa991b33caef4c1b6f2b5bc5ef3237cb87865 Parents: 480a612 Author: Martin LanghoffAuthored: Wed May 17 10:40:52 2017 +0200 Committer: Stefan Podkowinski Committed: Thu May 18 19:40:25 2017 +0200 -- redhat/cassandra | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/dd6aa991/redhat/cassandra -- diff --git a/redhat/cassandra b/redhat/cassandra index a45..677ff8c 100644 --- a/redhat/cassandra +++ b/redhat/cassandra @@ -3,11 +3,24 @@ # /etc/init.d/cassandra # # Startup script for Cassandra -# -# chkconfig: 2345 20 80 +# +# chkconfig: 2345 80 20 # description: Starts and stops Cassandra # pidfile: /var/run/cassandra/cassandra.pid +### BEGIN INIT INFO +# Provides: cassandra +# Required-Start:$remote_fs $network $named $time +# Required-Stop: $remote_fs $network $named $time +# Should-Start: ntp mdadm +# Should-Stop: ntp mdadm +# Default-Start: 2 3 4 5 +# Default-Stop: 0 1 6 +# Short-Description: distributed storage system for structured data +# Description: Cassandra is a distributed (peer-to-peer) system for +#the management and storage of structured data. +### END INIT INFO + . /etc/rc.d/init.d/functions export CASSANDRA_HOME=/usr/share/cassandra - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[17/22] cassandra git commit: Merge branch 'cassandra-2.2' into cassandra-3.0
Merge branch 'cassandra-2.2' into cassandra-3.0 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/7db6a3b3 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/7db6a3b3 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/7db6a3b3 Branch: refs/heads/cassandra-3.11 Commit: 7db6a3b3cdf784c002a788a3f9e8d61c9691d18d Parents: 9092d74 dd6aa99 Author: Stefan PodkowinskiAuthored: Thu May 18 19:41:02 2017 +0200 Committer: Stefan Podkowinski Committed: Thu May 18 19:41:25 2017 +0200 -- redhat/cassandra | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) -- - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[20/22] cassandra git commit: Merge branch 'cassandra-3.0' into cassandra-3.11
Merge branch 'cassandra-3.0' into cassandra-3.11 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/83c9ac31 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/83c9ac31 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/83c9ac31 Branch: refs/heads/cassandra-3.11 Commit: 83c9ac3135d2c0fd0c65731684061e6bc7de0324 Parents: 92de354 7db6a3b Author: Stefan PodkowinskiAuthored: Thu May 18 19:42:06 2017 +0200 Committer: Stefan Podkowinski Committed: Thu May 18 19:42:12 2017 +0200 -- redhat/cassandra | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) -- - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[11/22] cassandra git commit: Merge branch 'cassandra-3.0' into cassandra-3.11
Merge branch 'cassandra-3.0' into cassandra-3.11 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/92de3545 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/92de3545 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/92de3545 Branch: refs/heads/trunk Commit: 92de3545227a123b83938f58e4161cb31c325fd8 Parents: 9723db2 9092d74 Author: Stefan PodkowinskiAuthored: Thu May 18 19:33:04 2017 +0200 Committer: Stefan Podkowinski Committed: Thu May 18 19:33:10 2017 +0200 -- redhat/README.md | 19 ++- redhat/cassandra.spec | 5 - 2 files changed, 14 insertions(+), 10 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/92de3545/redhat/cassandra.spec -- - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[08/22] cassandra git commit: Merge branch 'cassandra-2.2' into cassandra-3.0
Merge branch 'cassandra-2.2' into cassandra-3.0 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/9092d745 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/9092d745 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/9092d745 Branch: refs/heads/trunk Commit: 9092d7458d70b119dd227cce31651ac4d1bf990a Parents: 95635f3 480a612 Author: Stefan PodkowinskiAuthored: Thu May 18 19:32:34 2017 +0200 Committer: Stefan Podkowinski Committed: Thu May 18 19:32:41 2017 +0200 -- redhat/README.md | 19 ++- redhat/cassandra.spec | 5 - 2 files changed, 14 insertions(+), 10 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/9092d745/redhat/cassandra.spec -- - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[22/22] cassandra git commit: Merge branch 'cassandra-3.11' into trunk
Merge branch 'cassandra-3.11' into trunk Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/4a12dabe Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/4a12dabe Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/4a12dabe Branch: refs/heads/trunk Commit: 4a12dabef6a2a12b2838da8b42b8a083d9201f06 Parents: dc0b389 83c9ac3 Author: Stefan PodkowinskiAuthored: Thu May 18 19:42:27 2017 +0200 Committer: Stefan Podkowinski Committed: Thu May 18 19:42:38 2017 +0200 -- redhat/cassandra | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) -- - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[03/22] cassandra git commit: RPM - rpmbuild tolerate binaries in noarch, README update
RPM - rpmbuild tolerate binaries in noarch, README update patch by Martin A. Langhoff; reviewed by Stefan Podkowinski for CASSANDRA-13433 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/480a612e Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/480a612e Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/480a612e Branch: refs/heads/cassandra-2.2 Commit: 480a612eeffa6d3e77cd4f25676a90a2917da4a4 Parents: 486b82a Author: Martin LanghoffAuthored: Wed May 3 16:54:28 2017 -0400 Committer: Stefan Podkowinski Committed: Thu May 18 19:12:18 2017 +0200 -- redhat/README.md | 19 ++- redhat/cassandra.spec | 5 - 2 files changed, 14 insertions(+), 10 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/480a612e/redhat/README.md -- diff --git a/redhat/README.md b/redhat/README.md index 0b2ab0d..cab42a7 100644 --- a/redhat/README.md +++ b/redhat/README.md @@ -7,25 +7,26 @@ ### Step 1: - Build and copy sources to build tree: ``` -ant artifacts -cp build/apache-cassandra-*-src.tar.gz $RPM_BUILD_DIR/SOURCES/ +ant artifacts -Drelease=true ``` ### Step 2: - Since there is no version specified in the SPEC file, one needs to be passed at `rpmbuild` time (example with 4.0): ``` -rpmbuild --define="version 4.0" -ba redhat/cassandra.spec +mkdir -p build/rpmbuild/{BUILD,RPMS,SPECS,SRPMS} +rpmbuild --define="version 4.0" \ +--define="revision $(date +"%Y%m%d")git$(git rev-parse --short HEAD)%{?dist}" \ +--define "_topdir $(pwd)/build/rpmbuild" \ +--define "_sourcedir $(pwd)/build" \ +-ba redhat/cassandra.spec ``` +Use revision value in the example above for git based snapshots. Change to `--define="revision 1"` for non-snapshot releases. + - RPM files can be found in their respective build tree directories: ``` -ls -l $RPM_BUILD_DIR/{SRPMS,RPMS}/ +ls -l build/rpmbuild/{SRPMS,RPMS}/ ``` ### Hint: - Don't build packages as root.. -``` -# this makes your RPM_BUILD_DIR = ~/rpmbuild -mkdir -p ~/rpmbuild/{BUILD,RPMS,SOURCES,SPECS,SRPMS} -echo '%_topdir %(echo $HOME)/rpmbuild' > ~/.rpmmacros -``` http://git-wip-us.apache.org/repos/asf/cassandra/blob/480a612e/redhat/cassandra.spec -- diff --git a/redhat/cassandra.spec b/redhat/cassandra.spec index c3c22d0..ad4095d 100644 --- a/redhat/cassandra.spec +++ b/redhat/cassandra.spec @@ -2,10 +2,13 @@ # Turn off the brp-python-bytecompile script %global __os_install_post %(echo '%{__os_install_post}' | sed -e 's!/usr/lib[^[:space:]]*/brp-python-bytecompile[[:space:]].*$!!g') +# rpmbuild should not barf when it spots we ship +# binary executable files in our 'noarch' package +%define _binaries_in_noarch_packages_terminate_build 0 + %global username cassandra %define relname apache-cassandra-%{version} -%define revision 1 Name: cassandra Version: %{version} - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[16/22] cassandra git commit: RPM: Add init info stanzas, change startup ordering
RPM: Add init info stanzas, change startup ordering patch by Martin A. Langhoff; reviewed by Stefan Podkowinski for CASSANDRA-13493 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/dd6aa991 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/dd6aa991 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/dd6aa991 Branch: refs/heads/cassandra-3.0 Commit: dd6aa991b33caef4c1b6f2b5bc5ef3237cb87865 Parents: 480a612 Author: Martin LanghoffAuthored: Wed May 17 10:40:52 2017 +0200 Committer: Stefan Podkowinski Committed: Thu May 18 19:40:25 2017 +0200 -- redhat/cassandra | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/dd6aa991/redhat/cassandra -- diff --git a/redhat/cassandra b/redhat/cassandra index a45..677ff8c 100644 --- a/redhat/cassandra +++ b/redhat/cassandra @@ -3,11 +3,24 @@ # /etc/init.d/cassandra # # Startup script for Cassandra -# -# chkconfig: 2345 20 80 +# +# chkconfig: 2345 80 20 # description: Starts and stops Cassandra # pidfile: /var/run/cassandra/cassandra.pid +### BEGIN INIT INFO +# Provides: cassandra +# Required-Start:$remote_fs $network $named $time +# Required-Stop: $remote_fs $network $named $time +# Should-Start: ntp mdadm +# Should-Stop: ntp mdadm +# Default-Start: 2 3 4 5 +# Default-Stop: 0 1 6 +# Short-Description: distributed storage system for structured data +# Description: Cassandra is a distributed (peer-to-peer) system for +#the management and storage of structured data. +### END INIT INFO + . /etc/rc.d/init.d/functions export CASSANDRA_HOME=/usr/share/cassandra - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[19/22] cassandra git commit: Merge branch 'cassandra-2.2' into cassandra-3.0
Merge branch 'cassandra-2.2' into cassandra-3.0 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/7db6a3b3 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/7db6a3b3 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/7db6a3b3 Branch: refs/heads/trunk Commit: 7db6a3b3cdf784c002a788a3f9e8d61c9691d18d Parents: 9092d74 dd6aa99 Author: Stefan PodkowinskiAuthored: Thu May 18 19:41:02 2017 +0200 Committer: Stefan Podkowinski Committed: Thu May 18 19:41:25 2017 +0200 -- redhat/cassandra | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) -- - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[21/22] cassandra git commit: Merge branch 'cassandra-3.0' into cassandra-3.11
Merge branch 'cassandra-3.0' into cassandra-3.11 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/83c9ac31 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/83c9ac31 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/83c9ac31 Branch: refs/heads/trunk Commit: 83c9ac3135d2c0fd0c65731684061e6bc7de0324 Parents: 92de354 7db6a3b Author: Stefan PodkowinskiAuthored: Thu May 18 19:42:06 2017 +0200 Committer: Stefan Podkowinski Committed: Thu May 18 19:42:12 2017 +0200 -- redhat/cassandra | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) -- - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[14/22] cassandra git commit: RPM: Add init info stanzas, change startup ordering
RPM: Add init info stanzas, change startup ordering patch by Martin A. Langhoff; reviewed by Stefan Podkowinski for CASSANDRA-13493 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/dd6aa991 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/dd6aa991 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/dd6aa991 Branch: refs/heads/trunk Commit: dd6aa991b33caef4c1b6f2b5bc5ef3237cb87865 Parents: 480a612 Author: Martin LanghoffAuthored: Wed May 17 10:40:52 2017 +0200 Committer: Stefan Podkowinski Committed: Thu May 18 19:40:25 2017 +0200 -- redhat/cassandra | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/dd6aa991/redhat/cassandra -- diff --git a/redhat/cassandra b/redhat/cassandra index a45..677ff8c 100644 --- a/redhat/cassandra +++ b/redhat/cassandra @@ -3,11 +3,24 @@ # /etc/init.d/cassandra # # Startup script for Cassandra -# -# chkconfig: 2345 20 80 +# +# chkconfig: 2345 80 20 # description: Starts and stops Cassandra # pidfile: /var/run/cassandra/cassandra.pid +### BEGIN INIT INFO +# Provides: cassandra +# Required-Start:$remote_fs $network $named $time +# Required-Stop: $remote_fs $network $named $time +# Should-Start: ntp mdadm +# Should-Stop: ntp mdadm +# Default-Start: 2 3 4 5 +# Default-Stop: 0 1 6 +# Short-Description: distributed storage system for structured data +# Description: Cassandra is a distributed (peer-to-peer) system for +#the management and storage of structured data. +### END INIT INFO + . /etc/rc.d/init.d/functions export CASSANDRA_HOME=/usr/share/cassandra - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[07/22] cassandra git commit: Merge branch 'cassandra-2.2' into cassandra-3.0
Merge branch 'cassandra-2.2' into cassandra-3.0 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/9092d745 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/9092d745 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/9092d745 Branch: refs/heads/cassandra-3.11 Commit: 9092d7458d70b119dd227cce31651ac4d1bf990a Parents: 95635f3 480a612 Author: Stefan PodkowinskiAuthored: Thu May 18 19:32:34 2017 +0200 Committer: Stefan Podkowinski Committed: Thu May 18 19:32:41 2017 +0200 -- redhat/README.md | 19 ++- redhat/cassandra.spec | 5 - 2 files changed, 14 insertions(+), 10 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/9092d745/redhat/cassandra.spec -- - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[15/22] cassandra git commit: RPM: Add init info stanzas, change startup ordering
RPM: Add init info stanzas, change startup ordering patch by Martin A. Langhoff; reviewed by Stefan Podkowinski for CASSANDRA-13493 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/dd6aa991 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/dd6aa991 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/dd6aa991 Branch: refs/heads/cassandra-3.11 Commit: dd6aa991b33caef4c1b6f2b5bc5ef3237cb87865 Parents: 480a612 Author: Martin LanghoffAuthored: Wed May 17 10:40:52 2017 +0200 Committer: Stefan Podkowinski Committed: Thu May 18 19:40:25 2017 +0200 -- redhat/cassandra | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/dd6aa991/redhat/cassandra -- diff --git a/redhat/cassandra b/redhat/cassandra index a45..677ff8c 100644 --- a/redhat/cassandra +++ b/redhat/cassandra @@ -3,11 +3,24 @@ # /etc/init.d/cassandra # # Startup script for Cassandra -# -# chkconfig: 2345 20 80 +# +# chkconfig: 2345 80 20 # description: Starts and stops Cassandra # pidfile: /var/run/cassandra/cassandra.pid +### BEGIN INIT INFO +# Provides: cassandra +# Required-Start:$remote_fs $network $named $time +# Required-Stop: $remote_fs $network $named $time +# Should-Start: ntp mdadm +# Should-Stop: ntp mdadm +# Default-Start: 2 3 4 5 +# Default-Stop: 0 1 6 +# Short-Description: distributed storage system for structured data +# Description: Cassandra is a distributed (peer-to-peer) system for +#the management and storage of structured data. +### END INIT INFO + . /etc/rc.d/init.d/functions export CASSANDRA_HOME=/usr/share/cassandra - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[10/22] cassandra git commit: Merge branch 'cassandra-3.0' into cassandra-3.11
Merge branch 'cassandra-3.0' into cassandra-3.11 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/92de3545 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/92de3545 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/92de3545 Branch: refs/heads/cassandra-3.11 Commit: 92de3545227a123b83938f58e4161cb31c325fd8 Parents: 9723db2 9092d74 Author: Stefan PodkowinskiAuthored: Thu May 18 19:33:04 2017 +0200 Committer: Stefan Podkowinski Committed: Thu May 18 19:33:10 2017 +0200 -- redhat/README.md | 19 ++- redhat/cassandra.spec | 5 - 2 files changed, 14 insertions(+), 10 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/92de3545/redhat/cassandra.spec -- - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[05/22] cassandra git commit: RPM - rpmbuild tolerate binaries in noarch, README update
RPM - rpmbuild tolerate binaries in noarch, README update patch by Martin A. Langhoff; reviewed by Stefan Podkowinski for CASSANDRA-13433 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/480a612e Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/480a612e Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/480a612e Branch: refs/heads/cassandra-3.11 Commit: 480a612eeffa6d3e77cd4f25676a90a2917da4a4 Parents: 486b82a Author: Martin LanghoffAuthored: Wed May 3 16:54:28 2017 -0400 Committer: Stefan Podkowinski Committed: Thu May 18 19:12:18 2017 +0200 -- redhat/README.md | 19 ++- redhat/cassandra.spec | 5 - 2 files changed, 14 insertions(+), 10 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/480a612e/redhat/README.md -- diff --git a/redhat/README.md b/redhat/README.md index 0b2ab0d..cab42a7 100644 --- a/redhat/README.md +++ b/redhat/README.md @@ -7,25 +7,26 @@ ### Step 1: - Build and copy sources to build tree: ``` -ant artifacts -cp build/apache-cassandra-*-src.tar.gz $RPM_BUILD_DIR/SOURCES/ +ant artifacts -Drelease=true ``` ### Step 2: - Since there is no version specified in the SPEC file, one needs to be passed at `rpmbuild` time (example with 4.0): ``` -rpmbuild --define="version 4.0" -ba redhat/cassandra.spec +mkdir -p build/rpmbuild/{BUILD,RPMS,SPECS,SRPMS} +rpmbuild --define="version 4.0" \ +--define="revision $(date +"%Y%m%d")git$(git rev-parse --short HEAD)%{?dist}" \ +--define "_topdir $(pwd)/build/rpmbuild" \ +--define "_sourcedir $(pwd)/build" \ +-ba redhat/cassandra.spec ``` +Use revision value in the example above for git based snapshots. Change to `--define="revision 1"` for non-snapshot releases. + - RPM files can be found in their respective build tree directories: ``` -ls -l $RPM_BUILD_DIR/{SRPMS,RPMS}/ +ls -l build/rpmbuild/{SRPMS,RPMS}/ ``` ### Hint: - Don't build packages as root.. -``` -# this makes your RPM_BUILD_DIR = ~/rpmbuild -mkdir -p ~/rpmbuild/{BUILD,RPMS,SOURCES,SPECS,SRPMS} -echo '%_topdir %(echo $HOME)/rpmbuild' > ~/.rpmmacros -``` http://git-wip-us.apache.org/repos/asf/cassandra/blob/480a612e/redhat/cassandra.spec -- diff --git a/redhat/cassandra.spec b/redhat/cassandra.spec index c3c22d0..ad4095d 100644 --- a/redhat/cassandra.spec +++ b/redhat/cassandra.spec @@ -2,10 +2,13 @@ # Turn off the brp-python-bytecompile script %global __os_install_post %(echo '%{__os_install_post}' | sed -e 's!/usr/lib[^[:space:]]*/brp-python-bytecompile[[:space:]].*$!!g') +# rpmbuild should not barf when it spots we ship +# binary executable files in our 'noarch' package +%define _binaries_in_noarch_packages_terminate_build 0 + %global username cassandra %define relname apache-cassandra-%{version} -%define revision 1 Name: cassandra Version: %{version} - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[12/22] cassandra git commit: Merge branch 'cassandra-3.11' into trunk
Merge branch 'cassandra-3.11' into trunk Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/dc0b3896 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/dc0b3896 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/dc0b3896 Branch: refs/heads/trunk Commit: dc0b389646094ac6032123e7a6418332b96ef8df Parents: d8836d4 92de354 Author: Stefan PodkowinskiAuthored: Thu May 18 19:33:24 2017 +0200 Committer: Stefan Podkowinski Committed: Thu May 18 19:33:36 2017 +0200 -- redhat/README.md | 19 ++- redhat/cassandra.spec | 5 - 2 files changed, 14 insertions(+), 10 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/dc0b3896/redhat/cassandra.spec -- - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[02/22] cassandra git commit: Merge branch 'cassandra-2.1' into cassandra-2.2
Merge branch 'cassandra-2.1' into cassandra-2.2 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/486b82a6 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/486b82a6 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/486b82a6 Branch: refs/heads/cassandra-3.0 Commit: 486b82a6b056abee533b67662b927d90178c730e Parents: 6c5ea19 b0db519 Author: adelapenaAuthored: Wed May 10 11:02:40 2017 +0100 Committer: adelapena Committed: Wed May 10 11:02:40 2017 +0100 -- CHANGES.txt | 1 + .../AbstractSimplePerColumnSecondaryIndex.java | 2 +- .../validation/entities/SecondaryIndexTest.java | 42 3 files changed, 44 insertions(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/486b82a6/CHANGES.txt -- diff --cc CHANGES.txt index bb2e3ba,f62f162..ef2e12c --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,24 -1,5 +1,25 @@@ -2.1.18 +2.2.10 + * nodetool upgradesstables should upgrade system tables (CASSANDRA-13119) + * Avoid starting gossiper in RemoveTest (CASSANDRA-13407) + * Fix weightedSize() for row-cache reported by JMX and NodeTool (CASSANDRA-13393) + * Fix JVM metric paths (CASSANDRA-13103) + * Honor truststore-password parameter in cassandra-stress (CASSANDRA-12773) + * Discard in-flight shadow round responses (CASSANDRA-12653) + * Don't anti-compact repaired data to avoid inconsistencies (CASSANDRA-13153) + * Wrong logger name in AnticompactionTask (CASSANDRA-13343) + * Fix queries updating multiple time the same list (CASSANDRA-13130) + * Fix GRANT/REVOKE when keyspace isn't specified (CASSANDRA-13053) + * Avoid race on receiver by starting streaming sender thread after sending init message (CASSANDRA-12886) + * Fix "multiple versions of ant detected..." when running ant test (CASSANDRA-13232) + * Coalescing strategy sleeps too much (CASSANDRA-13090) + * Make sure compaction stats are updated when compaction is interrupted (Backport from 3.0, CASSANDRA-12100) + * Fix flaky LongLeveledCompactionStrategyTest (CASSANDRA-12202) + * Fix failing COPY TO STDOUT (CASSANDRA-12497) + * Fix ColumnCounter::countAll behaviour for reverse queries (CASSANDRA-13222) + * Exceptions encountered calling getSeeds() breaks OTC thread (CASSANDRA-13018) + * Commitlog replay may fail if last mutation is within 4 bytes of end of segment (CASSANDRA-13282) +Merged from 2.1: + * Fix 2ndary indexes on primary key columns to don't create expiring entries (CASSANDRA-13412) * Set javac encoding to utf-8 (CASSANDRA-13466) * Fix 2ndary index queries on partition keys for tables with static columns (CASSANDRA-13147) * Fix ParseError unhashable type list in cqlsh copy from (CASSANDRA-13364) http://git-wip-us.apache.org/repos/asf/cassandra/blob/486b82a6/src/java/org/apache/cassandra/db/index/AbstractSimplePerColumnSecondaryIndex.java -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/486b82a6/test/unit/org/apache/cassandra/cql3/validation/entities/SecondaryIndexTest.java -- diff --cc test/unit/org/apache/cassandra/cql3/validation/entities/SecondaryIndexTest.java index b653f4e,1e63e3a..e3616f6 --- a/test/unit/org/apache/cassandra/cql3/validation/entities/SecondaryIndexTest.java +++ b/test/unit/org/apache/cassandra/cql3/validation/entities/SecondaryIndexTest.java @@@ -860,109 -820,45 +860,151 @@@ public class SecondaryIndexTest extend row(1, 1, 9, 1)); } + @Test + public void testIndexOnPartitionKeyInsertExpiringColumn() throws Throwable + { + createTable("CREATE TABLE %s (k1 int, k2 int, a int, b int, PRIMARY KEY ((k1, k2)))"); + createIndex("CREATE INDEX on %s(k1)"); + execute("INSERT INTO %s (k1, k2, a, b) VALUES (1, 2, 3, 4)"); + assertRows(execute("SELECT * FROM %s WHERE k1 = 1"), row(1, 2, 3, 4)); + execute("UPDATE %s USING TTL 1 SET b = 10 WHERE k1 = 1 AND k2 = 2"); + Thread.sleep(1000); + assertRows(execute("SELECT * FROM %s WHERE k1 = 1"), row(1, 2, 3, null)); + } + + @Test + public void testIndexOnClusteringKeyInsertExpiringColumn() throws Throwable + { + createTable("CREATE TABLE %s (pk int, ck int, a int, b int, PRIMARY KEY (pk, ck))"); + createIndex("CREATE INDEX on %s(ck)"); + execute("INSERT INTO %s (pk, ck, a, b) VALUES (1, 2, 3, 4)"); + assertRows(execute("SELECT * FROM %s WHERE ck = 2"), row(1, 2, 3, 4)); + execute("UPDATE %s USING TTL 1 SET b = 10 WHERE pk = 1 AND ck =
[18/22] cassandra git commit: Merge branch 'cassandra-2.2' into cassandra-3.0
Merge branch 'cassandra-2.2' into cassandra-3.0 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/7db6a3b3 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/7db6a3b3 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/7db6a3b3 Branch: refs/heads/cassandra-3.0 Commit: 7db6a3b3cdf784c002a788a3f9e8d61c9691d18d Parents: 9092d74 dd6aa99 Author: Stefan PodkowinskiAuthored: Thu May 18 19:41:02 2017 +0200 Committer: Stefan Podkowinski Committed: Thu May 18 19:41:25 2017 +0200 -- redhat/cassandra | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) -- - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[06/22] cassandra git commit: RPM - rpmbuild tolerate binaries in noarch, README update
RPM - rpmbuild tolerate binaries in noarch, README update patch by Martin A. Langhoff; reviewed by Stefan Podkowinski for CASSANDRA-13433 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/480a612e Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/480a612e Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/480a612e Branch: refs/heads/trunk Commit: 480a612eeffa6d3e77cd4f25676a90a2917da4a4 Parents: 486b82a Author: Martin LanghoffAuthored: Wed May 3 16:54:28 2017 -0400 Committer: Stefan Podkowinski Committed: Thu May 18 19:12:18 2017 +0200 -- redhat/README.md | 19 ++- redhat/cassandra.spec | 5 - 2 files changed, 14 insertions(+), 10 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/480a612e/redhat/README.md -- diff --git a/redhat/README.md b/redhat/README.md index 0b2ab0d..cab42a7 100644 --- a/redhat/README.md +++ b/redhat/README.md @@ -7,25 +7,26 @@ ### Step 1: - Build and copy sources to build tree: ``` -ant artifacts -cp build/apache-cassandra-*-src.tar.gz $RPM_BUILD_DIR/SOURCES/ +ant artifacts -Drelease=true ``` ### Step 2: - Since there is no version specified in the SPEC file, one needs to be passed at `rpmbuild` time (example with 4.0): ``` -rpmbuild --define="version 4.0" -ba redhat/cassandra.spec +mkdir -p build/rpmbuild/{BUILD,RPMS,SPECS,SRPMS} +rpmbuild --define="version 4.0" \ +--define="revision $(date +"%Y%m%d")git$(git rev-parse --short HEAD)%{?dist}" \ +--define "_topdir $(pwd)/build/rpmbuild" \ +--define "_sourcedir $(pwd)/build" \ +-ba redhat/cassandra.spec ``` +Use revision value in the example above for git based snapshots. Change to `--define="revision 1"` for non-snapshot releases. + - RPM files can be found in their respective build tree directories: ``` -ls -l $RPM_BUILD_DIR/{SRPMS,RPMS}/ +ls -l build/rpmbuild/{SRPMS,RPMS}/ ``` ### Hint: - Don't build packages as root.. -``` -# this makes your RPM_BUILD_DIR = ~/rpmbuild -mkdir -p ~/rpmbuild/{BUILD,RPMS,SOURCES,SPECS,SRPMS} -echo '%_topdir %(echo $HOME)/rpmbuild' > ~/.rpmmacros -``` http://git-wip-us.apache.org/repos/asf/cassandra/blob/480a612e/redhat/cassandra.spec -- diff --git a/redhat/cassandra.spec b/redhat/cassandra.spec index c3c22d0..ad4095d 100644 --- a/redhat/cassandra.spec +++ b/redhat/cassandra.spec @@ -2,10 +2,13 @@ # Turn off the brp-python-bytecompile script %global __os_install_post %(echo '%{__os_install_post}' | sed -e 's!/usr/lib[^[:space:]]*/brp-python-bytecompile[[:space:]].*$!!g') +# rpmbuild should not barf when it spots we ship +# binary executable files in our 'noarch' package +%define _binaries_in_noarch_packages_terminate_build 0 + %global username cassandra %define relname apache-cassandra-%{version} -%define revision 1 Name: cassandra Version: %{version} - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[04/22] cassandra git commit: RPM - rpmbuild tolerate binaries in noarch, README update
RPM - rpmbuild tolerate binaries in noarch, README update patch by Martin A. Langhoff; reviewed by Stefan Podkowinski for CASSANDRA-13433 Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/480a612e Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/480a612e Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/480a612e Branch: refs/heads/cassandra-3.0 Commit: 480a612eeffa6d3e77cd4f25676a90a2917da4a4 Parents: 486b82a Author: Martin LanghoffAuthored: Wed May 3 16:54:28 2017 -0400 Committer: Stefan Podkowinski Committed: Thu May 18 19:12:18 2017 +0200 -- redhat/README.md | 19 ++- redhat/cassandra.spec | 5 - 2 files changed, 14 insertions(+), 10 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/480a612e/redhat/README.md -- diff --git a/redhat/README.md b/redhat/README.md index 0b2ab0d..cab42a7 100644 --- a/redhat/README.md +++ b/redhat/README.md @@ -7,25 +7,26 @@ ### Step 1: - Build and copy sources to build tree: ``` -ant artifacts -cp build/apache-cassandra-*-src.tar.gz $RPM_BUILD_DIR/SOURCES/ +ant artifacts -Drelease=true ``` ### Step 2: - Since there is no version specified in the SPEC file, one needs to be passed at `rpmbuild` time (example with 4.0): ``` -rpmbuild --define="version 4.0" -ba redhat/cassandra.spec +mkdir -p build/rpmbuild/{BUILD,RPMS,SPECS,SRPMS} +rpmbuild --define="version 4.0" \ +--define="revision $(date +"%Y%m%d")git$(git rev-parse --short HEAD)%{?dist}" \ +--define "_topdir $(pwd)/build/rpmbuild" \ +--define "_sourcedir $(pwd)/build" \ +-ba redhat/cassandra.spec ``` +Use revision value in the example above for git based snapshots. Change to `--define="revision 1"` for non-snapshot releases. + - RPM files can be found in their respective build tree directories: ``` -ls -l $RPM_BUILD_DIR/{SRPMS,RPMS}/ +ls -l build/rpmbuild/{SRPMS,RPMS}/ ``` ### Hint: - Don't build packages as root.. -``` -# this makes your RPM_BUILD_DIR = ~/rpmbuild -mkdir -p ~/rpmbuild/{BUILD,RPMS,SOURCES,SPECS,SRPMS} -echo '%_topdir %(echo $HOME)/rpmbuild' > ~/.rpmmacros -``` http://git-wip-us.apache.org/repos/asf/cassandra/blob/480a612e/redhat/cassandra.spec -- diff --git a/redhat/cassandra.spec b/redhat/cassandra.spec index c3c22d0..ad4095d 100644 --- a/redhat/cassandra.spec +++ b/redhat/cassandra.spec @@ -2,10 +2,13 @@ # Turn off the brp-python-bytecompile script %global __os_install_post %(echo '%{__os_install_post}' | sed -e 's!/usr/lib[^[:space:]]*/brp-python-bytecompile[[:space:]].*$!!g') +# rpmbuild should not barf when it spots we ship +# binary executable files in our 'noarch' package +%define _binaries_in_noarch_packages_terminate_build 0 + %global username cassandra %define relname apache-cassandra-%{version} -%define revision 1 Name: cassandra Version: %{version} - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[01/22] cassandra git commit: Fix 2ndary indexes on primary key columns to don't create expiring entries (CASSANDRA-13412)
Repository: cassandra Updated Branches: refs/heads/cassandra-2.2 486b82a6b -> dd6aa991b refs/heads/cassandra-3.0 95635f312 -> 7db6a3b3c refs/heads/cassandra-3.11 9723db271 -> 83c9ac313 refs/heads/trunk d8836d485 -> 4a12dabef Fix 2ndary indexes on primary key columns to don't create expiring entries (CASSANDRA-13412) Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/b0db519b Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/b0db519b Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/b0db519b Branch: refs/heads/cassandra-3.0 Commit: b0db519b79701cecac92a7a2c93101cf17fb928d Parents: 572fef8 Author: adelapenaAuthored: Fri Apr 21 09:33:16 2017 +0100 Committer: adelapena Committed: Wed May 10 10:52:50 2017 +0100 -- CHANGES.txt | 1 + .../AbstractSimplePerColumnSecondaryIndex.java | 2 +- .../validation/entities/SecondaryIndexTest.java | 42 3 files changed, 44 insertions(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra/blob/b0db519b/CHANGES.txt -- diff --git a/CHANGES.txt b/CHANGES.txt index 2517432..f62f162 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,4 +1,5 @@ 2.1.18 + * Fix 2ndary indexes on primary key columns to don't create expiring entries (CASSANDRA-13412) * Set javac encoding to utf-8 (CASSANDRA-13466) * Fix 2ndary index queries on partition keys for tables with static columns (CASSANDRA-13147) * Fix ParseError unhashable type list in cqlsh copy from (CASSANDRA-13364) http://git-wip-us.apache.org/repos/asf/cassandra/blob/b0db519b/src/java/org/apache/cassandra/db/index/AbstractSimplePerColumnSecondaryIndex.java -- diff --git a/src/java/org/apache/cassandra/db/index/AbstractSimplePerColumnSecondaryIndex.java b/src/java/org/apache/cassandra/db/index/AbstractSimplePerColumnSecondaryIndex.java index e80c7bd..d7a1d8a 100644 --- a/src/java/org/apache/cassandra/db/index/AbstractSimplePerColumnSecondaryIndex.java +++ b/src/java/org/apache/cassandra/db/index/AbstractSimplePerColumnSecondaryIndex.java @@ -116,7 +116,7 @@ public abstract class AbstractSimplePerColumnSecondaryIndex extends PerColumnSec DecoratedKey valueKey = getIndexKeyFor(getIndexedValue(rowKey, cell)); ColumnFamily cfi = ArrayBackedSortedColumns.factory.create(indexCfs.metadata, false, 1); CellName name = makeIndexColumnName(rowKey, cell); -if (cell instanceof ExpiringCell) +if (!columnDef.isPrimaryKeyColumn() && cell instanceof ExpiringCell) { ExpiringCell ec = (ExpiringCell) cell; cfi.addColumn(new BufferExpiringCell(name, ByteBufferUtil.EMPTY_BYTE_BUFFER, ec.timestamp(), ec.getTimeToLive(), ec.getLocalDeletionTime())); http://git-wip-us.apache.org/repos/asf/cassandra/blob/b0db519b/test/unit/org/apache/cassandra/cql3/validation/entities/SecondaryIndexTest.java -- diff --git a/test/unit/org/apache/cassandra/cql3/validation/entities/SecondaryIndexTest.java b/test/unit/org/apache/cassandra/cql3/validation/entities/SecondaryIndexTest.java index b723f60..1e63e3a 100644 --- a/test/unit/org/apache/cassandra/cql3/validation/entities/SecondaryIndexTest.java +++ b/test/unit/org/apache/cassandra/cql3/validation/entities/SecondaryIndexTest.java @@ -819,4 +819,46 @@ public class SecondaryIndexTest extends CQLTester assertRows(execute("SELECT * FROM %s WHERE v = ?", 1), row(1, 1, 9, 1)); } + +@Test +public void testIndexOnPartitionKeyInsertExpiringColumn() throws Throwable +{ +createTable("CREATE TABLE %s (k1 int, k2 int, a int, b int, PRIMARY KEY ((k1, k2)))"); +createIndex("CREATE INDEX on %s(k1)"); +execute("INSERT INTO %s (k1, k2, a, b) VALUES (1, 2, 3, 4)"); +assertRows(execute("SELECT * FROM %s WHERE k1 = 1"), row(1, 2, 3, 4)); +execute("UPDATE %s USING TTL 1 SET b = 10 WHERE k1 = 1 AND k2 = 2"); +Thread.sleep(1000); +assertRows(execute("SELECT * FROM %s WHERE k1 = 1"), row(1, 2, 3, null)); +} + +@Test +public void testIndexOnClusteringKeyInsertExpiringColumn() throws Throwable +{ +createTable("CREATE TABLE %s (pk int, ck int, a int, b int, PRIMARY KEY (pk, ck))"); +createIndex("CREATE INDEX on %s(ck)"); +execute("INSERT INTO %s (pk, ck, a, b) VALUES (1, 2, 3, 4)"); +assertRows(execute("SELECT * FROM %s WHERE ck = 2"), row(1, 2, 3, 4)); +execute("UPDATE %s USING TTL 1 SET b = 10 WHERE pk = 1 AND ck = 2"); +
[jira] [Commented] (CASSANDRA-13052) Repair process is violating the start/end token limits for small ranges
[ https://issues.apache.org/jira/browse/CASSANDRA-13052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016120#comment-16016120 ] Blake Eggleston commented on CASSANDRA-13052: - That makes sense. IIRC, a range with the same start and end token means 'the entire token range', which is unlikely to be what the person doing the repairing wanted. In the case of this test though, it's only checking that providing a subrange causes isGlobal to return false... so it should be ok to change it to "41:42" > Repair process is violating the start/end token limits for small ranges > --- > > Key: CASSANDRA-13052 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13052 > Project: Cassandra > Issue Type: Bug > Components: Streaming and Messaging > Environment: We tried this in 2.0.14 and 3.9, same bug. >Reporter: Cristian P >Assignee: Stefan Podkowinski > Attachments: 13052-2.1.patch, ccm_reproduce-13052.txt, > system-dev-debug-13052.log > > > We tried to do a single token repair by providing 2 consecutive token values > for a large column family. We soon notice heavy streaming and according to > the logs the number of ranges streamed was in thousands. > After investigation we found a bug in the two partitioner classes we use > (RandomPartitioner and Murmur3Partitioner). > The midpoint method used by MerkleTree.differenceHelper method to find ranges > with differences for streaming returns abnormal values (way out of the > initial range requested for repair) if the repair requested range is small (I > expect smaller than 2^15). > Here is the simple code to reproduce the bug for Murmur3Partitioner: > Token left = new Murmur3Partitioner.LongToken(123456789L); > Token right = new Murmur3Partitioner.LongToken(123456789L); > IPartitioner partitioner = new Murmur3Partitioner(); > Token midpoint = partitioner.midpoint(left, right); > System.out.println("Murmur3: [ " + left.getToken() + " : " + > midpoint.getToken() + " : " + right.getToken() + " ]"); > The output is: > Murmur3: [ 123456789 : -9223372036731319019 : 123456789 ] > Note that the midpoint token is nowhere near the suggested repair range. This > will happen if during the parsing of the tree (in > MerkleTree.differenceHelper) in search for differences there isn't enough > tokens for the split and the subrange becomes 0 (left.token=right.token) as > in the above test. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13510) CI for valdiating cassandra on power platform
[ https://issues.apache.org/jira/browse/CASSANDRA-13510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016118#comment-16016118 ] Jeff Jirsa commented on CASSANDRA-13510: Took me a bit to get setup, but [this build|https://builds.apache.org/view/A-D/view/Cassandra/job/cassandra-devbranch-ppc64le-testall/8/] should be the first real run. Note that it appears to have failed with errors, but it did run. Please ping me if you'd like to kick off more runs - you can reach me by email, or by commenting here. > CI for valdiating cassandra on power platform > - > > Key: CASSANDRA-13510 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13510 > Project: Cassandra > Issue Type: Improvement >Reporter: Amitkumar Ghatwal > > Hi All, > As i understand that currently CI available for cassandra ( to validate any > code updates ) is : http://cassci.datastax.com/view/Dev/ and as can be seen > most of the deployment here is on Intel - X86 arch . > Just wanted to know your views/comments/suggestions for having a CI of > cassandra on Power . > 1) If the community will be willing to add - vm's/slaves ( ppc64le based ) to > their current above CI . May be some externally hosted - ppc64le vm's can be > attached as slaves to above jenkins server. > 2) Use an externally hosted jenkins CI - for running cassandra build on power > and link the results of the build to the above CI. > This ticket is just a follow up on CI query for Cassandra on power - > https://issues.apache.org/jira/browse/CASSANDRA-13486. > Please let me know your thoughts. > Regards, > Amit -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-13510) CI for valdiating cassandra on power platform
[ https://issues.apache.org/jira/browse/CASSANDRA-13510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016043#comment-16016043 ] Jeff Jirsa edited comment on CASSANDRA-13510 at 5/18/17 4:38 PM: - The ppc64le instances are named hadoop, so hadoop should get higher preferences, but it doesn't explicitly say we can't tie jobs to those nodes (like beam+cassandra explicitly says). Should be something we can setup. I'll try to get a one-time build going on ppc64le, then once we see how that run goes, and then we can get it setup to be regular/repeatable. was (Author: jjirsa): The ppc64le instances are named hadoop, so hadoop should get higher preferences, but it doesn't explicitly say we can't tie jobs to those nodes (like beam+cassandra explicitly says). Should be something we can setup. I have started a one-time build [here|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-testall/8/] Let's see how that run goes, and then we can get it setup to be regular/repeatable. > CI for valdiating cassandra on power platform > - > > Key: CASSANDRA-13510 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13510 > Project: Cassandra > Issue Type: Improvement >Reporter: Amitkumar Ghatwal > > Hi All, > As i understand that currently CI available for cassandra ( to validate any > code updates ) is : http://cassci.datastax.com/view/Dev/ and as can be seen > most of the deployment here is on Intel - X86 arch . > Just wanted to know your views/comments/suggestions for having a CI of > cassandra on Power . > 1) If the community will be willing to add - vm's/slaves ( ppc64le based ) to > their current above CI . May be some externally hosted - ppc64le vm's can be > attached as slaves to above jenkins server. > 2) Use an externally hosted jenkins CI - for running cassandra build on power > and link the results of the build to the above CI. > This ticket is just a follow up on CI query for Cassandra on power - > https://issues.apache.org/jira/browse/CASSANDRA-13486. > Please let me know your thoughts. > Regards, > Amit -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13510) CI for valdiating cassandra on power platform
[ https://issues.apache.org/jira/browse/CASSANDRA-13510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016043#comment-16016043 ] Jeff Jirsa commented on CASSANDRA-13510: The ppc64le instances are named hadoop, so hadoop should get higher preferences, but it doesn't explicitly say we can't tie jobs to those nodes (like beam+cassandra explicitly says). Should be something we can setup. I have started a one-time build [here|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-testall/8/] Let's see how that run goes, and then we can get it setup to be regular/repeatable. > CI for valdiating cassandra on power platform > - > > Key: CASSANDRA-13510 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13510 > Project: Cassandra > Issue Type: Improvement >Reporter: Amitkumar Ghatwal > > Hi All, > As i understand that currently CI available for cassandra ( to validate any > code updates ) is : http://cassci.datastax.com/view/Dev/ and as can be seen > most of the deployment here is on Intel - X86 arch . > Just wanted to know your views/comments/suggestions for having a CI of > cassandra on Power . > 1) If the community will be willing to add - vm's/slaves ( ppc64le based ) to > their current above CI . May be some externally hosted - ppc64le vm's can be > attached as slaves to above jenkins server. > 2) Use an externally hosted jenkins CI - for running cassandra build on power > and link the results of the build to the above CI. > This ticket is just a follow up on CI query for Cassandra on power - > https://issues.apache.org/jira/browse/CASSANDRA-13486. > Please let me know your thoughts. > Regards, > Amit -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-10446) Run repair with down replicas
[ https://issues.apache.org/jira/browse/CASSANDRA-10446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Eggleston updated CASSANDRA-10446: Status: Patch Available (was: Open) |[trunk|https://github.com/bdeggleston/cassandra/commits/10446]|[utests|https://circleci.com/gh/bdeggleston/cassandra/51#tests/containers/2]| [dtest|https://github.com/bdeggleston/cassandra-dtest/commits/10446] > Run repair with down replicas > - > > Key: CASSANDRA-10446 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10446 > Project: Cassandra > Issue Type: Improvement >Reporter: sankalp kohli >Assignee: Blake Eggleston >Priority: Minor > Fix For: 4.0 > > > We should have an option of running repair when replicas are down. We can > call it -force. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-10446) Run repair with down replicas
[ https://issues.apache.org/jira/browse/CASSANDRA-10446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Eggleston updated CASSANDRA-10446: Reviewer: Marcus Eriksson > Run repair with down replicas > - > > Key: CASSANDRA-10446 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10446 > Project: Cassandra > Issue Type: Improvement >Reporter: sankalp kohli >Assignee: Blake Eggleston >Priority: Minor > Fix For: 4.0 > > > We should have an option of running repair when replicas are down. We can > call it -force. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-13539) The keyspace repairTime metric is not updated
[ https://issues.apache.org/jira/browse/CASSANDRA-13539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Eggleston updated CASSANDRA-13539: Reviewer: Blake Eggleston Fix Version/s: 4.0 > The keyspace repairTime metric is not updated > - > > Key: CASSANDRA-13539 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13539 > Project: Cassandra > Issue Type: Bug > Components: Observability >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Minor > Fix For: 4.0 > > > repairTime metric at keyspace metric isnt updated when repairs complete so > its always zeros. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-13482) NPE on non-existing row read when row cache is enabled
[ https://issues.apache.org/jira/browse/CASSANDRA-13482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandr Batenev updated CASSANDRA-13482: -- Reproduced In: 3.10 Status: Awaiting Feedback (was: Open) > NPE on non-existing row read when row cache is enabled > -- > > Key: CASSANDRA-13482 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13482 > Project: Cassandra > Issue Type: Bug >Reporter: Alex Petrov >Assignee: Alex Petrov > > The problem is reproducible on 3.0 with: > {code} > -# row_cache_class_name: org.apache.cassandra.cache.OHCProvider > +row_cache_class_name: org.apache.cassandra.cache.OHCProvider > -row_cache_size_in_mb: 0 > +row_cache_size_in_mb: 100 > {code} > Table setup: > {code} > CREATE TABLE cache_tables (pk int, v1 int, v2 int, v3 int, primary key (pk, > v1)) WITH CACHING = { 'keys': 'ALL', 'rows_per_partition': '1' } ; > {code} > No data is required, only a head query (or any pk/ck query but with full > partitions cached). > {code} > select * from cross_page_queries where pk = 1 ; > {code} > {code} > java.lang.AssertionError: null > at > org.apache.cassandra.db.rows.UnfilteredRowIterators.concat(UnfilteredRowIterators.java:193) > ~[main/:na] > at > org.apache.cassandra.db.SinglePartitionReadCommand.getThroughCache(SinglePartitionReadCommand.java:461) > ~[main/:na] > at > org.apache.cassandra.db.SinglePartitionReadCommand.queryStorage(SinglePartitionReadCommand.java:358) > ~[main/:na] > at > org.apache.cassandra.db.ReadCommand.executeLocally(ReadCommand.java:395) > ~[main/:na] > at > org.apache.cassandra.service.StorageProxy$LocalReadRunnable.runMayThrow(StorageProxy.java:1794) > ~[main/:na] > at > org.apache.cassandra.service.StorageProxy$DroppableRunnable.run(StorageProxy.java:2472) > ~[main/:na] > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) > ~[na:1.8.0_121] > at > org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$FutureTask.run(AbstractLocalAwareExecutorService.java:164) > ~[main/:na] > at > org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$LocalSessionFutureTask.run(AbstractLocalAwareExecutorService.java:136) > [main/:na] > at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:105) > [main/:na] > at java.lang.Thread.run(Thread.java:745) [na:1.8.0_121] > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13482) NPE on non-existing row read when row cache is enabled
[ https://issues.apache.org/jira/browse/CASSANDRA-13482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015990#comment-16015990 ] Aleksandr Batenev commented on CASSANDRA-13482: --- I have same error on cassandra 3.10: query fail with row_cache on, and fine with cache off. consistency level doesn't matter - one/quorum/all -> same result. switch cache off and when on and/or restart cassandra doesn't fix problem. java.lang.AssertionError: null at org.apache.cassandra.db.rows.UnfilteredRowIterators.concat(UnfilteredRowIterators.java:210) ~[apache-cassandra-3.10.jar:3.10] at org.apache.cassandra.db.SinglePartitionReadCommand.getThroughCache(SinglePartitionReadCommand.java:474) ~[apache-cassandra-3.10.jar:3.10] at org.apache.cassandra.db.SinglePartitionReadCommand.queryStorage(SinglePartitionReadCommand.java:374) ~[apache-cassandra-3.10.jar:3.10] at org.apache.cassandra.db.ReadCommand.executeLocally(ReadCommand.java:407) ~[apache-cassandra-3.10.jar:3.10] at org.apache.cassandra.db.ReadCommandVerbHandler.doVerb(ReadCommandVerbHandler.java:48) ~[apache-cassandra-3.10.jar:3.10] at org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:66) ~[apache-cassandra-3.10.jar:3.10] at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[na:1.8.0_131] at org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$FutureTask.run(AbstractLocalAwareExecutorService.java:162) ~[apache-cassandra-3.10.jar:3.10] at org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$LocalSessionFutureTask.run(AbstractLocalAwareExecutorService.java:134) [apache-cassandra-3.10.jar:3.10] at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:109) [apache-cassandra-3.10.jar:3.10] at java.lang.Thread.run(Thread.java:748) [na:1.8.0_131] --- cassandra@cqlsh:sb> select * from session where agent_id = 846bed6c-978c-4cdb-958a-6a6155e9cdb5; ReadFailure: Error from server: code=1300 [Replica(s) failed to execute read] message="Operation failed - received 0 responses and 2 failures" info={'failures': 2, 'received_responses': 0, 'required_responses': 2, 'consistency': 'QUORUM'} cassandra@cqlsh:sb> ALTER TABLE session WITH caching = {'keys': 'ALL'}; cassandra@cqlsh:sb> select * from session where agent_id = 846bed6c-978c-4cdb-958a-6a6155e9cdb5; agent_id | session_id | all_isps | all_locations | all_logins | last_ip | last_login | last_page | last_time | legacy_id --++--+---++-++---+---+--- (0 rows) cassandra@cqlsh:sb> ALTER TABLE session WITH compaction = {'class': 'LeveledCompactionStrategy'} and caching = {'keys': 'ALL','rows_per_partition': 1}; cassandra@cqlsh:sb> select * from session where agent_id = 846bed6c-978c-4cdb-958a-6a6155e9cdb5; ReadFailure: Error from server: code=1300 [Replica(s) failed to execute read] message="Operation failed - received 0 responses and 2 failures" info={'failures': 2, 'received_responses': 0, 'required_responses': 2, 'consistency': 'QUORUM'} --- if i do select with another agent_id - all work fine! only one key fail... > NPE on non-existing row read when row cache is enabled > -- > > Key: CASSANDRA-13482 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13482 > Project: Cassandra > Issue Type: Bug >Reporter: Alex Petrov >Assignee: Alex Petrov > > The problem is reproducible on 3.0 with: > {code} > -# row_cache_class_name: org.apache.cassandra.cache.OHCProvider > +row_cache_class_name: org.apache.cassandra.cache.OHCProvider > -row_cache_size_in_mb: 0 > +row_cache_size_in_mb: 100 > {code} > Table setup: > {code} > CREATE TABLE cache_tables (pk int, v1 int, v2 int, v3 int, primary key (pk, > v1)) WITH CACHING = { 'keys': 'ALL', 'rows_per_partition': '1' } ; > {code} > No data is required, only a head query (or any pk/ck query but with full > partitions cached). > {code} > select * from cross_page_queries where pk = 1 ; > {code} > {code} > java.lang.AssertionError: null > at > org.apache.cassandra.db.rows.UnfilteredRowIterators.concat(UnfilteredRowIterators.java:193) > ~[main/:na] > at > org.apache.cassandra.db.SinglePartitionReadCommand.getThroughCache(SinglePartitionReadCommand.java:461) > ~[main/:na] > at > org.apache.cassandra.db.SinglePartitionReadCommand.queryStorage(SinglePartitionReadCommand.java:358) > ~[main/:na] > at > org.apache.cassandra.db.ReadCommand.executeLocally(ReadCommand.java:395) > ~[main/:na] > at > org.apache.cassandra.service.StorageProxy$LocalReadRunnable.runMayThrow(StorageProxy.java:1794) > ~[main/:na] > at >
[jira] [Issue Comment Deleted] (CASSANDRA-13539) The keyspace repairTime metric is not updated
[ https://issues.apache.org/jira/browse/CASSANDRA-13539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lohfink updated CASSANDRA-13539: -- Comment: was deleted (was: PR at https://github.com/apache/cassandra/pull/113) > The keyspace repairTime metric is not updated > - > > Key: CASSANDRA-13539 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13539 > Project: Cassandra > Issue Type: Bug > Components: Observability >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Minor > > repairTime metric at keyspace metric isnt updated when repairs complete so > its always zeros. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-13539) The keyspace repairTime metric is not updated
[ https://issues.apache.org/jira/browse/CASSANDRA-13539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lohfink updated CASSANDRA-13539: -- Status: Patch Available (was: Open) > The keyspace repairTime metric is not updated > - > > Key: CASSANDRA-13539 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13539 > Project: Cassandra > Issue Type: Bug > Components: Observability >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Minor > > repairTime metric at keyspace metric isnt updated when repairs complete so > its always zeros. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13539) The keyspace repairTime metric is not updated
[ https://issues.apache.org/jira/browse/CASSANDRA-13539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015949#comment-16015949 ] Chris Lohfink commented on CASSANDRA-13539: --- PR at https://github.com/apache/cassandra/pull/113 > The keyspace repairTime metric is not updated > - > > Key: CASSANDRA-13539 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13539 > Project: Cassandra > Issue Type: Bug > Components: Observability >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Minor > > repairTime metric at keyspace metric isnt updated when repairs complete so > its always zeros. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13539) The keyspace repairTime metric is not updated
[ https://issues.apache.org/jira/browse/CASSANDRA-13539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015944#comment-16015944 ] ASF GitHub Bot commented on CASSANDRA-13539: GitHub user clohfink opened a pull request: https://github.com/apache/cassandra/pull/113 Update repairTime for keyspaces on completion (CASSANDRA-13539) You can merge this pull request into a Git repository by running: $ git pull https://github.com/clohfink/cassandra 13539 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cassandra/pull/113.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #113 commit 2132d7b66f05cd9c6e5b4488a5025754456c82cc Author: Chris LohfinkDate: 2017-05-18T15:27:51Z Update repairTime for keyspaces on completion (CASSANDRA-13539) > The keyspace repairTime metric is not updated > - > > Key: CASSANDRA-13539 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13539 > Project: Cassandra > Issue Type: Bug > Components: Observability >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Minor > > repairTime metric at keyspace metric isnt updated when repairs complete so > its always zeros. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13492) RPM Init: don't attempt to start if it's running
[ https://issues.apache.org/jira/browse/CASSANDRA-13492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015924#comment-16015924 ] martin a langhoff commented on CASSANDRA-13492: --- My testing is on CentOS6 and friends; on CentOS6, I'll be testing it explicitly and report back. My 2c is that if you plan to only support systemd, there's a lot of good stuff to gain from using it right. Why would you use a SysV script? > RPM Init: don't attempt to start if it's running > > > Key: CASSANDRA-13492 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13492 > Project: Cassandra > Issue Type: Sub-task > Components: Packaging >Reporter: martin a langhoff >Assignee: Stefan Podkowinski > Attachments: 0002-RPM-Init-avoid-starting-cassandra-if-it-is-up.patch > > > We don't check whether Cassandra is running. Attempts to start Cassandra when > it's already running overwrite the pidfile, make a confusing mess of > logfiles, _fail to start, as the port is taken_; and then the init script > cannot bring the first Cassandra process down because the init file has been > clobbered. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-13539) The keyspace repairTime metric is not updated
Chris Lohfink created CASSANDRA-13539: - Summary: The keyspace repairTime metric is not updated Key: CASSANDRA-13539 URL: https://issues.apache.org/jira/browse/CASSANDRA-13539 Project: Cassandra Issue Type: Bug Components: Observability Reporter: Chris Lohfink Assignee: Chris Lohfink Priority: Minor repairTime metric at keyspace metric isnt updated when repairs complete so its always zeros. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-7396) Allow selecting Map key, List index
[ https://issues.apache.org/jira/browse/CASSANDRA-7396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015829#comment-16015829 ] Robert Stupp commented on CASSANDRA-7396: - Overall this patch looks pretty solid! Very nice work! Few comments and one bug though: * Having unit tests for UDTs (frozen and non frozen) that include frozen and non-frozen collections would be great. * the javadoc param {{from}} is duplicated in {{getSliceFromSerialized}} * Wonder, whether to return the {{baseType}} if {{ReversedType.getInstance()}} is called with a {{ReversedType}} is more efficient than creating a {{ReversedType(ReversedType(someType))}}. * {{WRITETIME()}} + {{TTL()}} don’t work with element/slice selections, but UDFs + CAST do work with element/slice selections. * IMO you can remove the copied javadocs on overrides/implementations * A couple of “ugly” methods & constructs have been refactored and became way more readable. * There's some incorrectness with nested slice/element selections: The unit and dtests look fine so far. {code} create keyspace foo WITH replication = {'class': 'NetworkTopologyStrategy', 'datacenter1':1}; CREATE TABLE foo.t1 ( id text PRIMARY KEY, m map>>, s set ); insert into foo.t1 (id,m) values ('1', {1: {2: 'one-two'}}); cqlsh> select m[1][2] from foo.t1 where id='1'; m[1][2] - one-two (1 rows) cqlsh> select m[1..][2] from foo.t1 where id='1'; m[1..][2] --- null (1 rows) cqlsh> select m[1][..2] from foo.t1 where id='1'; m[1][..2] {2: 'one-two'} (1 rows) cqlsh> select m[1..][..2] from foo.t1 where id='1'; m[1..][..2] - {1: {2: 'one-two'}} (1 rows) cqlsh> select m[1..][2] from foo.t1 where id='1'; m[1..][2] --- null (1 rows) {code} > Allow selecting Map key, List index > --- > > Key: CASSANDRA-7396 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7396 > Project: Cassandra > Issue Type: New Feature > Components: CQL >Reporter: Jonathan Ellis >Assignee: Sylvain Lebresne > Labels: cql, docs-impacting > Fix For: 4.x > > Attachments: 7396_unit_tests.txt > > > Allow "SELECT map['key]" and "SELECT list[index]." (Selecting a UDT subfield > is already supported.) -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13346) Failed unregistering mbean during drop keyspace
[ https://issues.apache.org/jira/browse/CASSANDRA-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015789#comment-16015789 ] Chris Lohfink commented on CASSANDRA-13346: --- I cant commit but +1 from me > Failed unregistering mbean during drop keyspace > --- > > Key: CASSANDRA-13346 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13346 > Project: Cassandra > Issue Type: Bug > Components: Materialized Views > Environment: Cassandra 3.9 >Reporter: Gábor Auth >Assignee: Lerh Chuan Low >Priority: Minor > Labels: lhf > Fix For: 3.10, 3.0.x > > Attachments: 13346-3.0.X.txt, 13346-3.X.txt, 13346-trunk.txt > > > All node throw exceptions about materialized views during drop keyspace: > {code} > WARN [MigrationStage:1] 2017-03-16 16:54:25,016 ColumnFamilyStore.java:535 - > Failed unregistering mbean: > org.apache.cassandra.db:type=Tables,keyspace=test20160810,table=unit_by_account > java.lang.NullPointerException: null > at > java.util.concurrent.ConcurrentHashMap.replaceNode(ConcurrentHashMap.java:1106) > ~[na:1.8.0_121] > at > java.util.concurrent.ConcurrentHashMap.remove(ConcurrentHashMap.java:1097) > ~[na:1.8.0_121] > at > java.util.concurrent.ConcurrentHashMap$KeySetView.remove(ConcurrentHashMap.java:4569) > ~[na:1.8.0_121] > at > org.apache.cassandra.metrics.TableMetrics.release(TableMetrics.java:712) > ~[apache-cassandra-3.9.0.jar:3.9.0] > at > org.apache.cassandra.db.ColumnFamilyStore.unregisterMBean(ColumnFamilyStore.java:570) > [apache-cassandra-3.9.0.jar:3.9.0] > at > org.apache.cassandra.db.ColumnFamilyStore.invalidate(ColumnFamilyStore.java:527) > [apache-cassandra-3.9.0.jar:3.9.0] > at > org.apache.cassandra.db.ColumnFamilyStore.invalidate(ColumnFamilyStore.java:517) > [apache-cassandra-3.9.0.jar:3.9.0] > at org.apache.cassandra.db.Keyspace.unloadCf(Keyspace.java:365) > [apache-cassandra-3.9.0.jar:3.9.0] > at org.apache.cassandra.db.Keyspace.dropCf(Keyspace.java:358) > [apache-cassandra-3.9.0.jar:3.9.0] > at org.apache.cassandra.config.Schema.dropView(Schema.java:744) > [apache-cassandra-3.9.0.jar:3.9.0] > at > org.apache.cassandra.schema.SchemaKeyspace.lambda$mergeSchema$373(SchemaKeyspace.java:1287) > [apache-cassandra-3.9.0.jar:3.9.0] > at java.lang.Iterable.forEach(Iterable.java:75) ~[na:1.8.0_121] > at > org.apache.cassandra.schema.SchemaKeyspace.mergeSchema(SchemaKeyspace.java:1287) > [apache-cassandra-3.9.0.jar:3.9.0] > at > org.apache.cassandra.schema.SchemaKeyspace.mergeSchemaAndAnnounceVersion(SchemaKeyspace.java:1256) > [apache-cassandra-3.9.0.jar:3.9.0] > at > org.apache.cassandra.db.DefinitionsUpdateVerbHandler$1.runMayThrow(DefinitionsUpdateVerbHandler.java:51) > ~[apache-cassandra-3.9.0.jar:3.9.0] > at > org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28) > ~[apache-cassandra-3.9.0.jar:3.9.0] > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) > ~[na:1.8.0_121] > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > ~[na:1.8.0_121] > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > ~[na:1.8.0_121] > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > ~[na:1.8.0_121] > at java.lang.Thread.run(Thread.java:745) ~[na:1.8.0_121] > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-10130) Node failure during 2i update after streaming can have incomplete 2i when restarted
[ https://issues.apache.org/jira/browse/CASSANDRA-10130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015593#comment-16015593 ] Sergio Bossa commented on CASSANDRA-10130: -- [~adelapena], the approach looks good to me, here is some specific feedback: * Why executing the [preBuildTask|https://github.com/apache/cassandra/compare/trunk...adelapena:10130-trunk#diff-3f2c8994c4ff8748c3faf7e70958520dR389] in another thread via {{executeBlocking}}, rather than just calling {{Runnable#run}}? * Currently, {{buildIndexesBlocking}} will end up rebuilding *all* indexes even if just a single one failed, because {{markIndexBuilt}} is called in bulk at the very end; I know this is in line with the previous behaviour, but wouldn't it make sense to improve it in this issue? * Do we have tests checking: ** Index status pre and post (re)building actions (create index, rebuild index). ** Index status upon index removal. ** Index status and automatic rebuild in case of failures. > Node failure during 2i update after streaming can have incomplete 2i when > restarted > --- > > Key: CASSANDRA-10130 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10130 > Project: Cassandra > Issue Type: Bug > Components: Coordination >Reporter: Yuki Morishita >Assignee: Andrés de la Peña >Priority: Minor > > Since MV/2i update happens after SSTables are received, node failure during > MV/2i update can leave received SSTables live when restarted while MV/2i are > partially up to date. > We can add some kind of tracking mechanism to automatically rebuild at the > startup, or at least warn user when the node restarts. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-10857) Allow dropping COMPACT STORAGE flag from tables in 3.X
[ https://issues.apache.org/jira/browse/CASSANDRA-10857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Yeschenko updated CASSANDRA-10857: -- Fix Version/s: (was: 4.0) 3.11.x > Allow dropping COMPACT STORAGE flag from tables in 3.X > -- > > Key: CASSANDRA-10857 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10857 > Project: Cassandra > Issue Type: Improvement > Components: CQL, Distributed Metadata >Reporter: Aleksey Yeschenko >Assignee: Alex Petrov >Priority: Blocker > Fix For: 3.11.x > > > Thrift allows users to define flexible mixed column families - where certain > columns would have explicitly pre-defined names, potentially non-default > validation types, and be indexed. > Example: > {code} > create column family foo > and default_validation_class = UTF8Type > and column_metadata = [ > {column_name: bar, validation_class: Int32Type, index_type: KEYS}, > {column_name: baz, validation_class: UUIDType, index_type: KEYS} > ]; > {code} > Columns named {{bar}} and {{baz}} will be validated as {{Int32Type}} and > {{UUIDType}}, respectively, and be indexed. Columns with any other name will > be validated by {{UTF8Type}} and will not be indexed. > With CASSANDRA-8099, {{bar}} and {{baz}} would be mapped to static columns > internally. However, being {{WITH COMPACT STORAGE}}, the table will only > expose {{bar}} and {{baz}} columns. Accessing any dynamic columns (any column > not named {{bar}} and {{baz}}) right now requires going through Thrift. > This is blocking Thrift -> CQL migration for users who have mixed > dynamic/static column families. That said, it *shouldn't* be hard to allow > users to drop the {{compact}} flag to expose the table as it is internally > now, and be able to access all columns. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-10857) Allow dropping COMPACT STORAGE flag from tables in 3.X
[ https://issues.apache.org/jira/browse/CASSANDRA-10857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Yeschenko updated CASSANDRA-10857: -- Fix Version/s: (was: 4.x) 4.0 > Allow dropping COMPACT STORAGE flag from tables in 3.X > -- > > Key: CASSANDRA-10857 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10857 > Project: Cassandra > Issue Type: Improvement > Components: CQL, Distributed Metadata >Reporter: Aleksey Yeschenko >Assignee: Alex Petrov > Fix For: 4.0 > > > Thrift allows users to define flexible mixed column families - where certain > columns would have explicitly pre-defined names, potentially non-default > validation types, and be indexed. > Example: > {code} > create column family foo > and default_validation_class = UTF8Type > and column_metadata = [ > {column_name: bar, validation_class: Int32Type, index_type: KEYS}, > {column_name: baz, validation_class: UUIDType, index_type: KEYS} > ]; > {code} > Columns named {{bar}} and {{baz}} will be validated as {{Int32Type}} and > {{UUIDType}}, respectively, and be indexed. Columns with any other name will > be validated by {{UTF8Type}} and will not be indexed. > With CASSANDRA-8099, {{bar}} and {{baz}} would be mapped to static columns > internally. However, being {{WITH COMPACT STORAGE}}, the table will only > expose {{bar}} and {{baz}} columns. Accessing any dynamic columns (any column > not named {{bar}} and {{baz}}) right now requires going through Thrift. > This is blocking Thrift -> CQL migration for users who have mixed > dynamic/static column families. That said, it *shouldn't* be hard to allow > users to drop the {{compact}} flag to expose the table as it is internally > now, and be able to access all columns. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-10857) Allow dropping COMPACT STORAGE flag from tables in 3.X
[ https://issues.apache.org/jira/browse/CASSANDRA-10857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Yeschenko updated CASSANDRA-10857: -- Priority: Blocker (was: Major) > Allow dropping COMPACT STORAGE flag from tables in 3.X > -- > > Key: CASSANDRA-10857 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10857 > Project: Cassandra > Issue Type: Improvement > Components: CQL, Distributed Metadata >Reporter: Aleksey Yeschenko >Assignee: Alex Petrov >Priority: Blocker > Fix For: 4.0 > > > Thrift allows users to define flexible mixed column families - where certain > columns would have explicitly pre-defined names, potentially non-default > validation types, and be indexed. > Example: > {code} > create column family foo > and default_validation_class = UTF8Type > and column_metadata = [ > {column_name: bar, validation_class: Int32Type, index_type: KEYS}, > {column_name: baz, validation_class: UUIDType, index_type: KEYS} > ]; > {code} > Columns named {{bar}} and {{baz}} will be validated as {{Int32Type}} and > {{UUIDType}}, respectively, and be indexed. Columns with any other name will > be validated by {{UTF8Type}} and will not be indexed. > With CASSANDRA-8099, {{bar}} and {{baz}} would be mapped to static columns > internally. However, being {{WITH COMPACT STORAGE}}, the table will only > expose {{bar}} and {{baz}} columns. Accessing any dynamic columns (any column > not named {{bar}} and {{baz}}) right now requires going through Thrift. > This is blocking Thrift -> CQL migration for users who have mixed > dynamic/static column families. That said, it *shouldn't* be hard to allow > users to drop the {{compact}} flag to expose the table as it is internally > now, and be able to access all columns. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-13262) Incorrect cqlsh results when selecting same columns multiple times
[ https://issues.apache.org/jira/browse/CASSANDRA-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015553#comment-16015553 ] mck edited comment on CASSANDRA-13262 at 5/18/17 10:38 AM: --- [~Anthony Grasso], the {{cqlsh_tests.cqlsh_tests.TestCqlsh.test_with_empty_values}} failed in the dtest run¹ against the 3.11 patch. (the history of the runs before that has been lost before i got a chance to check it.) Could you take a look at this to see if it's actually caused from the patch? (i would get a chance to before next tuesday.) ¹ https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/48/ was (Author: michaelsembwever): [~Anthony Grasso], the {{cqlsh_tests.cqlsh_tests.TestCqlsh.test_with_empty_values}} failed in the dtest run against the 3.11 patch. (the history of the runs before that has been lost before i got a chance to check it.) Could you take a look at this to see if it's actually caused from the patch? (i would get a chance to before next tuesday.) > Incorrect cqlsh results when selecting same columns multiple times > -- > > Key: CASSANDRA-13262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13262 > Project: Cassandra > Issue Type: Bug >Reporter: Stefan Podkowinski >Assignee: Murukesh Mohanan >Priority: Minor > Labels: lhf > Fix For: 4.0 > > Attachments: > 0001-Fix-incorrect-cqlsh-results-when-selecting-same-colu.patch, > CASSANDRA-13262-v2.2.txt, CASSANDRA-13262-v3.0.txt, CASSANDRA-13262-v3.11.txt > > > Just stumbled over this on trunk: > {quote} > cqlsh:test1> select a, b, c from table1; > a | b| c > ---+--+- > 1 |b | 2 > 2 | null | 2.2 > (2 rows) > cqlsh:test1> select a, a, b, c from table1; > a | a| b | c > ---+--+-+-- > 1 |b | 2 | null > 2 | null | 2.2 | null > (2 rows) > cqlsh:test1> select a, a, a, b, c from table1; > a | a| a | b| c > ---+--+---+--+-- > 1 |b | 2.0 | null | null > 2 | null | 2.2004768 | null | null > {quote} > My guess is that his is on the Python side, but haven't really looked into it. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13262) Incorrect cqlsh results when selecting same columns multiple times
[ https://issues.apache.org/jira/browse/CASSANDRA-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015553#comment-16015553 ] mck commented on CASSANDRA-13262: - [~Anthony Grasso], the {{cqlsh_tests.cqlsh_tests.TestCqlsh.test_with_empty_values}} failed in the dtest run against the 3.11 patch. (the history of the runs before that has been lost before i got a chance to check it.) Could you take a look at this to see if it's actually caused from the patch? (i would get a chance to before next tuesday.) > Incorrect cqlsh results when selecting same columns multiple times > -- > > Key: CASSANDRA-13262 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13262 > Project: Cassandra > Issue Type: Bug >Reporter: Stefan Podkowinski >Assignee: Murukesh Mohanan >Priority: Minor > Labels: lhf > Fix For: 4.0 > > Attachments: > 0001-Fix-incorrect-cqlsh-results-when-selecting-same-colu.patch, > CASSANDRA-13262-v2.2.txt, CASSANDRA-13262-v3.0.txt, CASSANDRA-13262-v3.11.txt > > > Just stumbled over this on trunk: > {quote} > cqlsh:test1> select a, b, c from table1; > a | b| c > ---+--+- > 1 |b | 2 > 2 | null | 2.2 > (2 rows) > cqlsh:test1> select a, a, b, c from table1; > a | a| b | c > ---+--+-+-- > 1 |b | 2 | null > 2 | null | 2.2 | null > (2 rows) > cqlsh:test1> select a, a, a, b, c from table1; > a | a| a | b| c > ---+--+---+--+-- > 1 |b | 2.0 | null | null > 2 | null | 2.2004768 | null | null > {quote} > My guess is that his is on the Python side, but haven't really looked into it. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13510) CI for valdiating cassandra on power platform
[ https://issues.apache.org/jira/browse/CASSANDRA-13510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015427#comment-16015427 ] Amitkumar Ghatwal commented on CASSANDRA-13510: --- ok thanks - [~jjirsa] . So right now i am thinking of using existing Jenkins : https://builds.apache.org/view/A-D/view/Cassandra/ which is present. Will keep adding slaves/resources to this server for hold for sometime now . For this could you please let me know who can grant me access to this jenkins server so that i can create a jenkins job for my git branch : https://github.com/ghatwala/cassandra/tree/ppc64le-CAPI/trunk wherein i have added power specific code. I understand that from here : https://cwiki.apache.org/confluence/display/INFRA/Jenkins+node+labels , INFRA does have 'ppc64le' slaves vm's wherein my power specific code can be validated. > CI for valdiating cassandra on power platform > - > > Key: CASSANDRA-13510 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13510 > Project: Cassandra > Issue Type: Improvement >Reporter: Amitkumar Ghatwal > > Hi All, > As i understand that currently CI available for cassandra ( to validate any > code updates ) is : http://cassci.datastax.com/view/Dev/ and as can be seen > most of the deployment here is on Intel - X86 arch . > Just wanted to know your views/comments/suggestions for having a CI of > cassandra on Power . > 1) If the community will be willing to add - vm's/slaves ( ppc64le based ) to > their current above CI . May be some externally hosted - ppc64le vm's can be > attached as slaves to above jenkins server. > 2) Use an externally hosted jenkins CI - for running cassandra build on power > and link the results of the build to the above CI. > This ticket is just a follow up on CI query for Cassandra on power - > https://issues.apache.org/jira/browse/CASSANDRA-13486. > Please let me know your thoughts. > Regards, > Amit -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13052) Repair process is violating the start/end token limits for small ranges
[ https://issues.apache.org/jira/browse/CASSANDRA-13052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015423#comment-16015423 ] Stefan Podkowinski commented on CASSANDRA-13052: Looks like [RepairOptionTest.java#L154|https://github.com/apache/cassandra/blob/cassandra-3.11/test/unit/org/apache/cassandra/repair/messages/RepairOptionTest.java#L154] uses a range that will now cause an "java.lang.IllegalArgumentException: Start and end tokens must be different." error. If we define a token range to be start-exclusive and end-inclusive, creating a range based on a single token shouldn't be possible and we shouldn't allow "42:42" as "ranges" argument. The correct range for a single token in this case would be "41:42". /cc [~aweisberg] > Repair process is violating the start/end token limits for small ranges > --- > > Key: CASSANDRA-13052 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13052 > Project: Cassandra > Issue Type: Bug > Components: Streaming and Messaging > Environment: We tried this in 2.0.14 and 3.9, same bug. >Reporter: Cristian P >Assignee: Stefan Podkowinski > Attachments: 13052-2.1.patch, ccm_reproduce-13052.txt, > system-dev-debug-13052.log > > > We tried to do a single token repair by providing 2 consecutive token values > for a large column family. We soon notice heavy streaming and according to > the logs the number of ranges streamed was in thousands. > After investigation we found a bug in the two partitioner classes we use > (RandomPartitioner and Murmur3Partitioner). > The midpoint method used by MerkleTree.differenceHelper method to find ranges > with differences for streaming returns abnormal values (way out of the > initial range requested for repair) if the repair requested range is small (I > expect smaller than 2^15). > Here is the simple code to reproduce the bug for Murmur3Partitioner: > Token left = new Murmur3Partitioner.LongToken(123456789L); > Token right = new Murmur3Partitioner.LongToken(123456789L); > IPartitioner partitioner = new Murmur3Partitioner(); > Token midpoint = partitioner.midpoint(left, right); > System.out.println("Murmur3: [ " + left.getToken() + " : " + > midpoint.getToken() + " : " + right.getToken() + " ]"); > The output is: > Murmur3: [ 123456789 : -9223372036731319019 : 123456789 ] > Note that the midpoint token is nowhere near the suggested repair range. This > will happen if during the parsing of the tree (in > MerkleTree.differenceHelper) in search for differences there isn't enough > tokens for the split and the subrange becomes 0 (left.token=right.token) as > in the above test. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org