[jira] [Updated] (CASSANDRA-13760) presize collections

2017-12-02 Thread Jeff Jirsa (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Jirsa updated CASSANDRA-13760:
---
   Resolution: Fixed
Fix Version/s: (was: 4.x)
   4.0
   Status: Resolved  (was: Ready to Commit)

Committed  as {{95b43b195e4074533100f863344c182a118a8b6c}}

Thanks again [~dbrosius]!


> presize collections
> ---
>
> Key: CASSANDRA-13760
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13760
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Core
>Reporter: Dave Brosius
>Assignee: Dave Brosius
>Priority: Trivial
> Fix For: 4.0
>
> Attachments: 0001-Presize-collections.patch, 13760.txt, Screen Shot 
> 2017-09-18 at 9.50.17 PM.png, test-output.png
>
>
> presize collections where sane, to avoid reallocs, or excess garbage



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Comment Edited] (CASSANDRA-13760) presize collections

2017-12-02 Thread Jeff Jirsa (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275845#comment-16275845
 ] 

Jeff Jirsa edited comment on CASSANDRA-13760 at 12/3/17 7:32 AM:
-

Confirmed offline via email that Dave's OK with my changes. Committed as 
{{95b43b195e4074533100f863344c182a118a8b6c}}

Thanks again [~dbrosius]!



was (Author: jjirsa):
Committed  as {{95b43b195e4074533100f863344c182a118a8b6c}}

Thanks again [~dbrosius]!


> presize collections
> ---
>
> Key: CASSANDRA-13760
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13760
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Core
>Reporter: Dave Brosius
>Assignee: Dave Brosius
>Priority: Trivial
> Fix For: 4.0
>
> Attachments: 0001-Presize-collections.patch, 13760.txt, Screen Shot 
> 2017-09-18 at 9.50.17 PM.png, test-output.png
>
>
> presize collections where sane, to avoid reallocs, or excess garbage



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

cassandra git commit: Presize collections

2017-12-02 Thread jjirsa 
Repository: cassandra
Updated Branches:
  refs/heads/trunk b04e4136f -> 95b43b195


Presize collections

Patch by Dave Brosius; Reviewed by Jeff Jirsa for CASSANDRA-13760


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/95b43b19
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/95b43b19
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/95b43b19

Branch: refs/heads/trunk
Commit: 95b43b195e4074533100f863344c182a118a8b6c
Parents: b04e413
Author: Jeff Jirsa 
Authored: Wed Aug 30 20:43:56 2017 -0700
Committer: Jeff Jirsa 
Committed: Sat Dec 2 23:30:41 2017 -0800

--
 src/java/org/apache/cassandra/auth/FunctionResource.java  |  2 +-
 src/java/org/apache/cassandra/cql3/Relation.java  |  2 +-
 .../apache/cassandra/cql3/statements/SelectStatement.java |  9 +
 .../apache/cassandra/db/AbstractReadCommandBuilder.java   |  4 +++-
 .../apache/cassandra/db/ColumnFamilyStoreCQLHelper.java   |  4 ++--
 src/java/org/apache/cassandra/db/Directories.java |  6 --
 src/java/org/apache/cassandra/db/commitlog/CommitLog.java |  7 ---
 .../db/compaction/AbstractCompactionStrategy.java |  4 ++--
 .../apache/cassandra/db/compaction/CompactionManager.java |  2 +-
 .../db/compaction/CompactionStrategyManager.java  | 10 ++
 .../db/compaction/DateTieredCompactionStrategy.java   |  2 +-
 .../db/compaction/LeveledCompactionStrategy.java  |  4 ++--
 src/java/org/apache/cassandra/db/view/ViewManager.java|  7 +--
 .../org/apache/cassandra/dht/ByteOrderedPartitioner.java  |  6 --
 .../apache/cassandra/gms/GossipDigestSynVerbHandler.java  |  4 +++-
 .../org/apache/cassandra/hadoop/cql3/CqlInputFormat.java  |  9 +
 .../cassandra/index/sasi/disk/PerSSTableIndexWriter.java  |  3 ++-
 .../apache/cassandra/index/sasi/plan/QueryController.java |  5 +++--
 src/java/org/apache/cassandra/io/sstable/Descriptor.java  |  2 +-
 src/java/org/apache/cassandra/io/sstable/SSTable.java |  2 +-
 src/java/org/apache/cassandra/repair/RepairJobDesc.java   |  2 +-
 .../cassandra/repair/SystemDistributedKeyspace.java   |  2 +-
 .../repair/consistent/PendingAntiCompaction.java  |  5 +++--
 src/java/org/apache/cassandra/schema/Indexes.java |  3 ++-
 src/java/org/apache/cassandra/schema/Types.java   |  2 +-
 src/java/org/apache/cassandra/utils/concurrent/Ref.java   |  2 +-
 26 files changed, 65 insertions(+), 45 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/95b43b19/src/java/org/apache/cassandra/auth/FunctionResource.java
--
diff --git a/src/java/org/apache/cassandra/auth/FunctionResource.java 
b/src/java/org/apache/cassandra/auth/FunctionResource.java
index f9f51d5..2c09c05 100644
--- a/src/java/org/apache/cassandra/auth/FunctionResource.java
+++ b/src/java/org/apache/cassandra/auth/FunctionResource.java
@@ -150,7 +150,7 @@ public class FunctionResource implements IResource
 if (keyspace == null)
 throw new InvalidRequestException("In this context function name 
must be " +
   "explictly qualified by a 
keyspace");
-List abstractTypes = new ArrayList<>();
+List abstractTypes = new ArrayList<>(argTypes.size());
 for (CQL3Type.Raw cqlType : argTypes)
 abstractTypes.add(cqlType.prepare(keyspace).getType());
 

http://git-wip-us.apache.org/repos/asf/cassandra/blob/95b43b19/src/java/org/apache/cassandra/cql3/Relation.java
--
diff --git a/src/java/org/apache/cassandra/cql3/Relation.java 
b/src/java/org/apache/cassandra/cql3/Relation.java
index 1d27874..0dcb3fa 100644
--- a/src/java/org/apache/cassandra/cql3/Relation.java
+++ b/src/java/org/apache/cassandra/cql3/Relation.java
@@ -243,7 +243,7 @@ public abstract class Relation
 if (raws == null)
 return null;
 
-List terms = new ArrayList<>();
+List terms = new ArrayList<>(raws.size());
 for (int i = 0, m = raws.size(); i < m; i++)
 terms.add(toTerm(receivers, raws.get(i), keyspace, boundNames));
 

http://git-wip-us.apache.org/repos/asf/cassandra/blob/95b43b19/src/java/org/apache/cassandra/cql3/statements/SelectStatement.java
--
diff --git a/src/java/org/apache/cassandra/cql3/statements/SelectStatement.java 
b/src/java/org/apache/cassandra/cql3/statements/SelectStatement.java
index 84fef5e..3754ee6 100644
--- a/src/java/org/apache/cassandra/cql3/statements/SelectStatement.java
+++

[jira] [Commented] (CASSANDRA-14060) Separate CorruptSSTableException and FSError handling policies

2017-12-02 Thread Jeff Jirsa (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-14060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275782#comment-16275782
 ] 

Jeff Jirsa commented on CASSANDRA-14060:


I think what you're proposing sounds reasonable, but before I actually review, 
I want to look at some of the history to remember how we got to this point.

Linking some topics for background:

- CASSANDRA-6646
- CASSANDRA-6364 

[~iamaleksey] and [~kohlisankalp] - you two were involved in some of the 
earlier work. Does this seem like we need a new policy here? 

[~jay.zhuang] - when you say most of your corrupt sstables aren't disk issues - 
to what do you attribute them?

> Separate CorruptSSTableException and FSError handling policies
> --
>
> Key: CASSANDRA-14060
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14060
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Configuration
>Reporter: Jay Zhuang
>Assignee: Jay Zhuang
>Priority: Minor
>
> Currently, if 
> [{{disk_failure_policy}}|https://github.com/apache/cassandra/blob/trunk/conf/cassandra.yaml#L230]
>  is set to {{stop}} (default), StorageService will shutdown for {{FSError}}, 
> but not {{CorruptSSTableException}} 
> [DefaultFSErrorHandler.java:40|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/service/DefaultFSErrorHandler.java#L40].
> But when we use policy: {{die}}, it has different behave, JVM will be killed 
> for both {{FSError}} and {{CorruptSSTableException}} 
> [JVMStabilityInspector.java:63|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/JVMStabilityInspector.java#L63]:
> ||{{disk_failure_policy}}|| hit {{FSError}} Exception || hit 
> {{CorruptSSTableException}} ||
> |{{stop}}| (/) stop | (x) not stop |
> |{{die}}| (/) die | (/) die |
> We saw {{CorruptSSTableException}} from time to time in our production, but 
> mostly it's *not* because of a disk issue. So I would suggest having a 
> separate policy for CorruptSSTable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Updated] (CASSANDRA-13916) Remove OpenJDK log warning

2017-12-02 Thread Jeff Jirsa (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Jirsa updated CASSANDRA-13916:
---
Status: Ready to Commit  (was: Patch Available)

> Remove OpenJDK log warning
> --
>
> Key: CASSANDRA-13916
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13916
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Core
>Reporter: Anthony Grasso
>Assignee: Jason Brown
>Priority: Minor
>  Labels: lhf
> Fix For: 3.11.x, 4.x
>
>
> The following warning message will appear in the logs when using OpenJDK
> {noformat}
> WARN  [main] ... OpenJDK is not recommended. Please upgrade to the newest 
> Oracle Java release
> {noformat}
> The above warning dates back to when OpenJDK 6 was released and there were 
> some issues in early releases of this version. The OpenJDK implementation is 
> used as a reference for the OracleJDK which means the implementations are 
> very close. In addition, most users have moved off Java 6 so we can probably 
> remove this warning message.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Updated] (CASSANDRA-13916) Remove OpenJDK log warning

2017-12-02 Thread Jeff Jirsa (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Jirsa updated CASSANDRA-13916:
---
Fix Version/s: 4.x
   3.11.x

> Remove OpenJDK log warning
> --
>
> Key: CASSANDRA-13916
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13916
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Core
>Reporter: Anthony Grasso
>Assignee: Jason Brown
>Priority: Minor
>  Labels: lhf
> Fix For: 3.11.x, 4.x
>
>
> The following warning message will appear in the logs when using OpenJDK
> {noformat}
> WARN  [main] ... OpenJDK is not recommended. Please upgrade to the newest 
> Oracle Java release
> {noformat}
> The above warning dates back to when OpenJDK 6 was released and there were 
> some issues in early releases of this version. The OpenJDK implementation is 
> used as a reference for the OracleJDK which means the implementations are 
> very close. In addition, most users have moved off Java 6 so we can probably 
> remove this warning message.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Updated] (CASSANDRA-13916) Remove OpenJDK log warning

2017-12-02 Thread Jeff Jirsa (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-13916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Jirsa updated CASSANDRA-13916:
---
Reviewer: Jeff Jirsa
  Status: Patch Available  (was: Open)

> Remove OpenJDK log warning
> --
>
> Key: CASSANDRA-13916
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13916
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Core
>Reporter: Anthony Grasso
>Assignee: Jason Brown
>Priority: Minor
>  Labels: lhf
>
> The following warning message will appear in the logs when using OpenJDK
> {noformat}
> WARN  [main] ... OpenJDK is not recommended. Please upgrade to the newest 
> Oracle Java release
> {noformat}
> The above warning dates back to when OpenJDK 6 was released and there were 
> some issues in early releases of this version. The OpenJDK implementation is 
> used as a reference for the OracleJDK which means the implementations are 
> very close. In addition, most users have moved off Java 6 so we can probably 
> remove this warning message.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13916) Remove OpenJDK log warning

2017-12-02 Thread Jeff Jirsa (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275769#comment-16275769
 ] 

Jeff Jirsa commented on CASSANDRA-13916:


lgtm, ready to commit.

> Remove OpenJDK log warning
> --
>
> Key: CASSANDRA-13916
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13916
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Core
>Reporter: Anthony Grasso
>Assignee: Jason Brown
>Priority: Minor
>  Labels: lhf
> Fix For: 3.11.x, 4.x
>
>
> The following warning message will appear in the logs when using OpenJDK
> {noformat}
> WARN  [main] ... OpenJDK is not recommended. Please upgrade to the newest 
> Oracle Java release
> {noformat}
> The above warning dates back to when OpenJDK 6 was released and there were 
> some issues in early releases of this version. The OpenJDK implementation is 
> used as a reference for the OracleJDK which means the implementations are 
> very close. In addition, most users have moved off Java 6 so we can probably 
> remove this warning message.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-14061) trunk eclipse-warnings

2017-12-02 Thread Jay Zhuang (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-14061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275744#comment-16275744
 ] 

Jay Zhuang commented on CASSANDRA-14061:


I think the warnings are false alert, maybe we {{iterator.close();}} here: 
[SSTableIdentityIterator.java:175|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java#L175].
 The warning is introduced in CASSANDRA-13299. cc [~jasonstack]

> trunk eclipse-warnings
> --
>
> Key: CASSANDRA-14061
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14061
> Project: Cassandra
>  Issue Type: Bug
>  Components: Testing
>Reporter: Jay Zhuang
>Assignee: Jay Zhuang
>Priority: Minor
>
> {noformat}
> eclipse-warnings:
> [mkdir] Created dir: /home/ubuntu/cassandra/build/ecj
>  [echo] Running Eclipse Code Analysis.  Output logged to 
> /home/ubuntu/cassandra/build/ecj/eclipse_compiler_checks.txt
>  [java] --
>  [java] 1. ERROR in 
> /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java
>  (at line 59)
>  [java]   return new SSTableIdentityIterator(sstable, key, 
> partitionLevelDeletion, file.getPath(), iterator);
>  [java]   
> ^^^
>  [java] Potential resource leak: 'iterator' may not be closed at this 
> location
>  [java] --
>  [java] 2. ERROR in 
> /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java
>  (at line 79)
>  [java]   return new SSTableIdentityIterator(sstable, key, 
> partitionLevelDeletion, dfile.getPath(), iterator);
>  [java]   
> 
>  [java] Potential resource leak: 'iterator' may not be closed at this 
> location
>  [java] --
>  [java] 2 problems (2 errors)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Comment Edited] (CASSANDRA-14061) trunk eclipse-warnings

2017-12-02 Thread Jay Zhuang (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-14061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275744#comment-16275744
 ] 

Jay Zhuang edited comment on CASSANDRA-14061 at 12/2/17 8:57 PM:
-

I think the warnings are false alert, maybe could add {{iterator.close();}} 
here: 
[SSTableIdentityIterator.java:175|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java#L175].
 The warning is introduced in CASSANDRA-13299. cc [~jasonstack]


was (Author: jay.zhuang):
I think the warnings are false alert, maybe we {{iterator.close();}} here: 
[SSTableIdentityIterator.java:175|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java#L175].
 The warning is introduced in CASSANDRA-13299. cc [~jasonstack]

> trunk eclipse-warnings
> --
>
> Key: CASSANDRA-14061
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14061
> Project: Cassandra
>  Issue Type: Bug
>  Components: Testing
>Reporter: Jay Zhuang
>Assignee: Jay Zhuang
>Priority: Minor
>
> {noformat}
> eclipse-warnings:
> [mkdir] Created dir: /home/ubuntu/cassandra/build/ecj
>  [echo] Running Eclipse Code Analysis.  Output logged to 
> /home/ubuntu/cassandra/build/ecj/eclipse_compiler_checks.txt
>  [java] --
>  [java] 1. ERROR in 
> /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java
>  (at line 59)
>  [java]   return new SSTableIdentityIterator(sstable, key, 
> partitionLevelDeletion, file.getPath(), iterator);
>  [java]   
> ^^^
>  [java] Potential resource leak: 'iterator' may not be closed at this 
> location
>  [java] --
>  [java] 2. ERROR in 
> /home/ubuntu/cassandra/src/java/org/apache/cassandra/io/sstable/SSTableIdentityIterator.java
>  (at line 79)
>  [java]   return new SSTableIdentityIterator(sstable, key, 
> partitionLevelDeletion, dfile.getPath(), iterator);
>  [java]   
> 
>  [java] Potential resource leak: 'iterator' may not be closed at this 
> location
>  [java] --
>  [java] 2 problems (2 errors)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13916) Remove OpenJDK log warning

2017-12-02 Thread Jason Brown (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275569#comment-16275569
 ] 

Jason Brown commented on CASSANDRA-13916:
-

Trivial patch available

||3.11||trunk||
|[branch|https://github.com/jasobrown/cassandra/tree/13916-3.11]|[branch|https://github.com/jasobrown/cassandra/tree/13916-trunk]|
|[utests  
dtests|https://circleci.com/gh/jasobrown/workflows/cassandra/tree/13916-3.11]|[utests
  
dtests|https://circleci.com/gh/jasobrown/workflows/cassandra/tree/13916-trunk]|
||


> Remove OpenJDK log warning
> --
>
> Key: CASSANDRA-13916
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13916
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Core
>Reporter: Anthony Grasso
>Assignee: Jason Brown
>Priority: Minor
>  Labels: lhf
>
> The following warning message will appear in the logs when using OpenJDK
> {noformat}
> WARN  [main] ... OpenJDK is not recommended. Please upgrade to the newest 
> Oracle Java release
> {noformat}
> The above warning dates back to when OpenJDK 6 was released and there were 
> some issues in early releases of this version. The OpenJDK implementation is 
> used as a reference for the OracleJDK which means the implementations are 
> very close. In addition, most users have moved off Java 6 so we can probably 
> remove this warning message.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

cassandra git commit: ninja-fix messy commit of 13530

2017-12-02 Thread jasobrown 
Repository: cassandra
Updated Branches:
  refs/heads/trunk f58072142 -> b04e4136f


ninja-fix messy commit of 13530


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/b04e4136
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/b04e4136
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/b04e4136

Branch: refs/heads/trunk
Commit: b04e4136ff24ff42408b5d116ec9fbb5216ca5e7
Parents: f580721
Author: Jason Brown 
Authored: Sat Dec 2 05:57:43 2017 -0800
Committer: Jason Brown 
Committed: Sat Dec 2 05:57:43 2017 -0800

--
 .circleci/config.yml | 254 --
 CHANGES.txt  |   1 +
 2 files changed, 1 insertion(+), 254 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/cassandra/blob/b04e4136/.circleci/config.yml
--
diff --git a/.circleci/config.yml b/.circleci/config.yml
deleted file mode 100644
index 387e0f6..000
--- a/.circleci/config.yml
+++ /dev/null
@@ -1,254 +0,0 @@
-env_vars: _vars
-JAVA_HOME: /usr/local/openjdk8u154-cassandra-b02
-ANT_HOME: /usr/local/apache-ant-1.10.1
-LANG: en_US.UTF-8
-JDK_HOME: /usr/local/openjdk8u154-cassandra-b02
-JAVA8_HOME: /usr/local/openjdk8u154-cassandra-b02
-JAVA7_HOME: /usr/local/openjdk7u82-cassandra-b02
-DEBUG: true
-PRINT_DEBUG: true
-KEEP_TEST_DIR: true
-CASSANDRA_DIR: /home/cassandra/cassandra
-DEFAULT_DIR: /home/cassandra/cassandra-dtest
-PYTHONIOENCODING: utf-8
-PYTHONUNBUFFERED: true
-CASS_DRIVER_NO_EXTENSIONS: true
-CASS_DRIVER_NO_CYTHON: true
-CCM_MAX_HEAP_SIZE: 3072M
-CCM_HEAP_NEWSIZE: 256M
-version: 2
-jobs:
-  build:
-resource_class: xlarge
-working_directory: ~/
-shell: /bin/bash -eo pipefail -l
-docker:
-  - image: kjellman/cassandra-test:0.1.2
-environment:
-<<: *env_vars
-steps:
-  - run:
-  name: Log Environment Information
-  command: |
-  echo '*** id ***'
-  id
-  echo '*** cat /proc/cpuinfo ***'
-  cat /proc/cpuinfo
-  echo '*** free -m ***'
-  free -m
-  echo '*** df -m ***'
-  df -m
-  echo '*** ifconfig -a ***'
-  ifconfig -a
-  echo '*** uname -a ***'
-  uname -a
-  echo '*** mount ***'
-  mount
-  echo '*** env ***'
-  env
-  - run:
-  name: Clone Cassandra Repository (via git)
-  command: |
-export LANG=en_US.UTF-8
-git clone --single-branch --depth 1 --branch $CIRCLE_BRANCH 
git://github.com/$CIRCLE_PROJECT_USERNAME/$CIRCLE_PROJECT_REPONAME.git 
~/cassandra
-  - run:
-  name: Build Cassandra
-  command: |
-export LANG=en_US.UTF-8
-export JAVA_TOOL_OPTIONS="-Dfile.encoding=UTF8"
-export PATH=$PATH:$ANT_HOME/bin:$JAVA_HOME/bin
-cd ~/cassandra
-# Loop to prevent failure due to maven-ant-tasks not downloading a 
jar..
-for x in $(seq 1 3); do
-${ANT_HOME}/bin/ant clean jar
-RETURN="$?"
-if [ "${RETURN}" -eq "0" ]; then
-break
-fi
-done
-# Exit, if we didn't build successfully
-if [ "${RETURN}" -ne "0" ]; then
-echo "Build failed with exit code: ${RETURN}"
-exit ${RETURN}
-fi
-  no_output_timeout: 20m
-  - persist_to_workspace:
-root: /home/cassandra
-paths:
-- cassandra
-- .m2
-  unit_tests:
-resource_class: xlarge
-parallelism: 100
-working_directory: ~/
-shell: /bin/bash -eo pipefail -l
-docker:
-  - image: kjellman/cassandra-test:0.1.2
-environment:
-<<: *env_vars
-steps:
-  - attach_workspace:
-  at: /home/cassandra
-  - run:
-  name: Determine Tests to Run
-  no_output_timeout: 10m
-  command: |
-# reminder: this code (along with all the steps) is independently 
executed on every circle container
-# so the goal here is to get the circleci script to return the 
tests *this* container will run
-# which we do via the `circleci` cli tool.
- 
-export LANG=en_US.UTF-8
-rm -fr ~/cassandra-dtest/upgrade_tests
-echo "***java tests***"
-
-# get all of our unit test filenames
-set -eo pipefail && circleci tests glob 
"$HOME/cassandra/test/unit/**/*.java" > /tmp/all_java_unit_tests.txt
-
-# split

[jira] [Updated] (CASSANDRA-14091) DynamicSnitch creates a lot of garbage

2017-12-02 Thread Jason Brown (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown updated CASSANDRA-14091:

Status: Ready to Commit  (was: Patch Available)

> DynamicSnitch creates a lot of garbage
> --
>
> Key: CASSANDRA-14091
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14091
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Blake Eggleston
>Assignee: Blake Eggleston
> Fix For: 3.0.16, 3.11.2, 4.0
>
>
> The ExponentiallyDecayingReservoir snapshots we take during score updates 
> generate a lot of garbage, and we call getSnapshot twice per endpoint when we 
> only need to call it once.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-14091) DynamicSnitch creates a lot of garbage

2017-12-02 Thread Jason Brown (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-14091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275556#comment-16275556
 ] 

Jason Brown commented on CASSANDRA-14091:
-

Nice find. +1

> DynamicSnitch creates a lot of garbage
> --
>
> Key: CASSANDRA-14091
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14091
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Blake Eggleston
>Assignee: Blake Eggleston
> Fix For: 3.0.16, 3.11.2, 4.0
>
>
> The ExponentiallyDecayingReservoir snapshots we take during score updates 
> generate a lot of garbage, and we call getSnapshot twice per endpoint when we 
> only need to call it once.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Updated] (CASSANDRA-14091) DynamicSnitch creates a lot of garbage

2017-12-02 Thread Jason Brown (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-14091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Brown updated CASSANDRA-14091:

Reviewer: Jason Brown

> DynamicSnitch creates a lot of garbage
> --
>
> Key: CASSANDRA-14091
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14091
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Blake Eggleston
>Assignee: Blake Eggleston
> Fix For: 3.0.16, 3.11.2, 4.0
>
>
> The ExponentiallyDecayingReservoir snapshots we take during score updates 
> generate a lot of garbage, and we call getSnapshot twice per endpoint when we 
> only need to call it once.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org