[jira] [Commented] (CASSANDRA-14291) Nodetool command to recreate SSTable components
[
https://issues.apache.org/jira/browse/CASSANDRA-14291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548244#comment-16548244
]
Chris Lohfink commented on CASSANDRA-14291:
---
Seems a little scary to be deleting and recreating components on an active
sstable, but the bf and summary are not directly read from except from tooling
so it looks safe to me.
Since others are same as just doing an upgradesstables there seems to be a lot
of overlap with that command. Since that command doesnt have much right now
(just -a) it doesnt seem to me like it would bloat to much to add a -c or
--components to it. Maybe naming gets confusing and a "rebuildsstables" command
is really what we want but I wont argue the semantics.
I dont see anything that recreates the bloom filter with current settings, just
reserializing whats already in memory.
> Nodetool command to recreate SSTable components
> ---
>
> Key: CASSANDRA-14291
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14291
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Kurt Greaves
>Assignee: Alexander Ivakov
>Priority: Minor
>
> Need a JMX/Nodetool command to recreate components for SSTables without
> re-writing the data files.
> Possible implementation idea:
> Create a {{nodetool (recreate|regen)component}} command that would enable you
> to recreate specific components of an SSTable, and also allow specifying
> SSTables or columnfamilies.
> I'd say a flag for a list of components and a flag for SSTables with
> keyspace.columnfamilies as positional arguments would work
> Alternatively this could become part of upgradesstables, but would likely
> make that command a bit bloated.
> Background:
> In CASSANDRA-11163 we changed it so summaries and bloomfilters were not
> regenerated or persisted on startup. This means we would rely on
> compactions/upgrades to regenerate the bloomfilter (or other components)
> after a configuration change. While this works, it's pretty inefficient on
> large tables just because you changed the bloomfilter size or summary chunk
> sizes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14458) Add virtual table to list active connections
[
https://issues.apache.org/jira/browse/CASSANDRA-14458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548080#comment-16548080
]
ASF GitHub Bot commented on CASSANDRA-14458:
Github user clohfink closed the pull request at:
https://github.com/apache/cassandra/pull/227
> Add virtual table to list active connections
>
>
> Key: CASSANDRA-14458
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14458
> Project: Cassandra
> Issue Type: New Feature
>Reporter: Chris Lohfink
>Assignee: Chris Lohfink
>Priority: Minor
> Labels: virtual-tables
> Fix For: 4.0
>
>
> List all active connections in virtual table like:
> {code:sql}
> cqlsh:system> select * from system_views.clients ;
>
> client_address | cipher | driver_name | driver_version | keyspace |
> protocol | requests | ssl | user | version
> --+---+-++--+---+--+---+---+-
> /127.0.0.1:63903 | undefined | undefined | undefined | |
> undefined | 13 | False | anonymous | 4
> /127.0.0.1:63904 | undefined | undefined | undefined | system |
> undefined | 16 | False | anonymous | 4
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14524) Client metrics refactor
[ https://issues.apache.org/jira/browse/CASSANDRA-14524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548084#comment-16548084 ] ASF GitHub Bot commented on CASSANDRA-14524: Github user clohfink closed the pull request at: https://github.com/apache/cassandra/pull/235 > Client metrics refactor > --- > > Key: CASSANDRA-14524 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14524 > Project: Cassandra > Issue Type: Improvement >Reporter: Chris Lohfink >Assignee: Aleksey Yeschenko >Priority: Minor > Fix For: 4.0 > > > Moving refactoring out of CASSANDRA-14458 to be reviewed separately. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14524) Client metrics refactor
[ https://issues.apache.org/jira/browse/CASSANDRA-14524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548082#comment-16548082 ] ASF GitHub Bot commented on CASSANDRA-14524: GitHub user clohfink reopened a pull request: https://github.com/apache/cassandra/pull/235 Refactor client metrics for CASSANDRA-14524 You can merge this pull request into a Git repository by running: $ git pull https://github.com/clohfink/cassandra nativestatsrefactor Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cassandra/pull/235.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #235 commit 062187b05473abb2e9ba82b74f91bf68217beac0 Author: Chris Lohfink Date: 2018-06-17T03:05:51Z Refactor client metrics for CASSANDRA-14524 > Client metrics refactor > --- > > Key: CASSANDRA-14524 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14524 > Project: Cassandra > Issue Type: Improvement >Reporter: Chris Lohfink >Assignee: Aleksey Yeschenko >Priority: Minor > Fix For: 4.0 > > > Moving refactoring out of CASSANDRA-14458 to be reviewed separately. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14524) Client metrics refactor
[ https://issues.apache.org/jira/browse/CASSANDRA-14524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548081#comment-16548081 ] ASF GitHub Bot commented on CASSANDRA-14524: Github user clohfink closed the pull request at: https://github.com/apache/cassandra/pull/235 > Client metrics refactor > --- > > Key: CASSANDRA-14524 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14524 > Project: Cassandra > Issue Type: Improvement >Reporter: Chris Lohfink >Assignee: Aleksey Yeschenko >Priority: Minor > Fix For: 4.0 > > > Moving refactoring out of CASSANDRA-14458 to be reviewed separately. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14457) Add a virtual table with current compactions
[ https://issues.apache.org/jira/browse/CASSANDRA-14457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548079#comment-16548079 ] ASF GitHub Bot commented on CASSANDRA-14457: Github user clohfink closed the pull request at: https://github.com/apache/cassandra/pull/226 > Add a virtual table with current compactions > > > Key: CASSANDRA-14457 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14457 > Project: Cassandra > Issue Type: New Feature >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Minor > Labels: virtual-tables > Fix For: 4.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14574) Racy incorrect handling of incoming messages
[
https://issues.apache.org/jira/browse/CASSANDRA-14574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547717#comment-16547717
]
Aleksey Yeschenko commented on CASSANDRA-14574:
---
bq. Probably a regression due to CASSANDRA-14485. Will investigate
FWIW, I think I saw that same issue in CI before CASSANDRA-14485 got committed.
So I think it's likelier that it wasn't caused by it than it was.
> Racy incorrect handling of incoming messages
> -
>
> Key: CASSANDRA-14574
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14574
> Project: Cassandra
> Issue Type: Bug
> Components: Streaming and Messaging
>Reporter: Aleksey Yeschenko
>Assignee: Jason Brown
>Priority: Major
> Fix For: 4.0
>
>
> {{MessageInHandler.decode()}} occasionally reads the payload incorrectly,
> passing the full message to {{MessageIn.read()}} instead of just the payload
> bytes.
> You can see the stack trace in the logs from this [CI
> run|https://circleci.com/gh/iamaleksey/cassandra/437#tests/containers/38].
> {code}
> Caused by: java.lang.AssertionError: null
> at
> org.apache.cassandra.db.Mutation$MutationSerializer.deserialize(Mutation.java:351)
> at
> org.apache.cassandra.db.Mutation$MutationSerializer.deserialize(Mutation.java:371)
> at
> org.apache.cassandra.db.Mutation$MutationSerializer.deserialize(Mutation.java:335)
> at org.apache.cassandra.net.MessageIn.read(MessageIn.java:158)
> at
> org.apache.cassandra.net.async.MessageInHandler.decode(MessageInHandler.java:132)
> {code}
> Reconstructed, truncated stream passed to {{MessageIn.read()}}:
> {{000b000743414c5f42414301002a01e1a5c9b089fd11e8b517436ee124300704005d10fc50ec}}
> You can clearly see parameters in there encoded before the payload:
> {{[43414c5f424143 - CAL_BAC] [01 - ONE_BYTE] [002a - 42, payload size] 01 e1
> a5 c9 b0 89 fd 11 e8 b5 17 43 6e e1 24 30 07 04 00 00 00 1d 10 fc 50 ec}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-12757) NPE if allocate_tokens_for_keyspace is typo/doesn't exist.
[
https://issues.apache.org/jira/browse/CASSANDRA-12757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547483#comment-16547483
]
Yuki Morishita commented on CASSANDRA-12757:
Hi Damien,
Thanks for the patch.
My concern to your change is that it changes {{Keyspace.open}} method's
behavior. Right now it throws {{AssertionError}} stating that given keyspace
does not exist (if assertion is enabled which is default in Cassandra). It is
not perfect, but I prefer it stays the same than returning null resulting
{{NullPointerException}} without detail ({{Keyspace.open}} is used everywhere
without checking its returned value being null).
I think the original error happens if assertion is disabled. So, why don't we
check keyspace existence for this specific case?
> NPE if allocate_tokens_for_keyspace is typo/doesn't exist.
> --
>
> Key: CASSANDRA-12757
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12757
> Project: Cassandra
> Issue Type: Bug
> Components: Configuration
>Reporter: Jeremiah Jordan
>Assignee: Damien Stevenson
>Priority: Major
> Labels: lhf
> Fix For: 3.0.x, 3.11.x
>
>
> If the keyspace specified in allocate_tokens_for_keyspace does not exist you
> get an NPE. Should probably have a better error here letting people know
> what the issue was.
> {code}
> INFO 21:07:22,582 StorageService.java:1152 - JOINING: getting bootstrap
> token
> Exception (java.lang.NullPointerException) encountered during startup: null
> ERROR 21:07:22,590 CassandraDaemon.java:709 - Exception encountered during
> startup
> java.lang.NullPointerException: null
>at
> org.apache.cassandra.db.Keyspace.createReplicationStrategy(Keyspace.java:325)
> ~[cassandra-all-3.0.8.jar:3.0.8]
>at org.apache.cassandra.db.Keyspace.(Keyspace.java:298)
> ~[cassandra-all-3.0.8.jar:3.0.8]
>at org.apache.cassandra.db.Keyspace.open(Keyspace.java:129)
> ~[cassandra-all-3.0.8.jar:3.0.8]
>at org.apache.cassandra.db.Keyspace.open(Keyspace.java:106)
> ~[cassandra-all-3.0.8.jar:3.0.8]
>at
> org.apache.cassandra.dht.BootStrapper.allocateTokens(BootStrapper.java:201)
> ~[cassandra-all-3.0.8.jar:3.0.8]
>at
> org.apache.cassandra.dht.BootStrapper.getBootstrapTokens(BootStrapper.java:173)
> ~[cassandra-all-3.0.8:3.0.8]
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-12757) NPE if allocate_tokens_for_keyspace is typo/doesn't exist.
[
https://issues.apache.org/jira/browse/CASSANDRA-12757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuki Morishita updated CASSANDRA-12757:
---
Reviewer: Yuki Morishita
> NPE if allocate_tokens_for_keyspace is typo/doesn't exist.
> --
>
> Key: CASSANDRA-12757
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12757
> Project: Cassandra
> Issue Type: Bug
> Components: Configuration
>Reporter: Jeremiah Jordan
>Assignee: Damien Stevenson
>Priority: Major
> Labels: lhf
> Fix For: 3.0.x, 3.11.x
>
>
> If the keyspace specified in allocate_tokens_for_keyspace does not exist you
> get an NPE. Should probably have a better error here letting people know
> what the issue was.
> {code}
> INFO 21:07:22,582 StorageService.java:1152 - JOINING: getting bootstrap
> token
> Exception (java.lang.NullPointerException) encountered during startup: null
> ERROR 21:07:22,590 CassandraDaemon.java:709 - Exception encountered during
> startup
> java.lang.NullPointerException: null
>at
> org.apache.cassandra.db.Keyspace.createReplicationStrategy(Keyspace.java:325)
> ~[cassandra-all-3.0.8.jar:3.0.8]
>at org.apache.cassandra.db.Keyspace.(Keyspace.java:298)
> ~[cassandra-all-3.0.8.jar:3.0.8]
>at org.apache.cassandra.db.Keyspace.open(Keyspace.java:129)
> ~[cassandra-all-3.0.8.jar:3.0.8]
>at org.apache.cassandra.db.Keyspace.open(Keyspace.java:106)
> ~[cassandra-all-3.0.8.jar:3.0.8]
>at
> org.apache.cassandra.dht.BootStrapper.allocateTokens(BootStrapper.java:201)
> ~[cassandra-all-3.0.8.jar:3.0.8]
>at
> org.apache.cassandra.dht.BootStrapper.getBootstrapTokens(BootStrapper.java:173)
> ~[cassandra-all-3.0.8:3.0.8]
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
