[jira] [Updated] (CASSANDRA-14613) ant generate-idea-files / generate-eclipse-files needs update after CASSANDRA-9608
[ https://issues.apache.org/jira/browse/CASSANDRA-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson updated CASSANDRA-14613: Summary: ant generate-idea-files / generate-eclipse-files needs update after CASSANDRA-9608 (was: ant generate-idea-files needs update after CASSANDRA-9608) > ant generate-idea-files / generate-eclipse-files needs update after > CASSANDRA-9608 > -- > > Key: CASSANDRA-14613 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14613 > Project: Cassandra > Issue Type: Bug >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Major > Fix For: 4.x > > > {{ide/idea-iml-file.xml}} looks hard coded to include {{src/java11}} when > creating the project, this should probably detect what version we are > building for instead > cc [~snazy] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14523) Thread pool stats virtual table
[ https://issues.apache.org/jira/browse/CASSANDRA-14523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lohfink updated CASSANDRA-14523: -- Status: Patch Available (was: Open) > Thread pool stats virtual table > --- > > Key: CASSANDRA-14523 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14523 > Project: Cassandra > Issue Type: New Feature >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Minor > Labels: virtual-tables > > Expose the thread pools like in status logger/tpstats. Additionally be nice > to include the scheduled executor pools that are currently unmonitored. > {code:java} > cqlsh> select * from system_views.thread_pools; > thread_pool | active | active_max | completed | pending > | tasks_blocked | total_blocked > --+++---+-+---+--- >anti_entropy_stage | 0 | 1 | 0 | 0 > | 0 | 0 >cache_cleanup_executor | 0 | 1 | 0 | 0 > | 0 | 0 > compaction_executor | 0 | 4 |41 | 0 > | 0 | 0 >counter_mutation_stage | 0 | 32 | 0 | 0 > | 0 | 0 > gossip_stage | 0 | 1 | 0 | 0 > | 0 | 0 > hints_dispatcher | 0 | 2 | 0 | 0 > | 0 | 0 > internal_response_stage | 0 | 8 | 0 | 0 > | 0 | 0 > memtable_flush_writer | 0 | 2 | 5 | 0 > | 0 | 0 > memtable_post_flush | 0 | 1 |20 | 0 > | 0 | 0 > memtable_reclaim_memory | 0 | 1 | 5 | 0 > | 0 | 0 > migration_stage | 0 | 1 | 0 | 0 > | 0 | 0 >misc_stage | 0 | 1 | 0 | 0 > | 0 | 0 >mutation_stage | 0 | 32 | 247 | 0 > | 0 | 0 > native_transport_requests | 1 |128 |28 | 0 > | 0 | 0 > pending_range_calculator | 0 | 1 | 2 | 0 > | 0 | 0 > per_disk_memtable_flush_writer_0 | 0 | 2 | 5 | 0 > | 0 | 0 > read_repair_stage | 0 | 8 | 0 | 0 > | 0 | 0 >read_stage | 0 | 32 |13 | 0 > | 0 | 0 > repair_task | 0 | 2147483647 | 0 | 0 > | 0 | 0 >request_response_stage | 0 | 8 | 0 | 0 > | 0 | 0 > sampler | 0 | 1 | 0 | 0 > | 0 | 0 > scheduled_fast_tasks | 0 | 2147483647 | 1398 | 1 > | 0 | 0 > scheduled_heartbeat | 0 | 2147483647 |14 | 1 > | 0 | 0 > scheduled_hotness_tracker | 0 | 2147483647 | 0 | 1 > | 0 | 0 > scheduled_non_periodic_tasks | 0 | 2147483647 |10 | 0 > | 0 | 0 > scheduled_optional_tasks | 0 | 2147483647 | 5 | 8 > | 0 | 0 > scheduled_summary_builder | 0 | 2147483647 | 0 | 1 > | 0 | 0 > scheduled_tasks | 0 | 2147483647 | 194 | 74 > | 0 | 0 >secondary_index_management | 0 | 1 | 0 | 0 > | 0 | 0 > validation_executor | 0 | 2147483647 | 0 | 0 > | 0 | 0 > view_build_executor | 0 | 1 | 0 | 0 > | 0 | 0 > view_mutation_stage | 0 | 32 | 0 | 0 > | 0 | 0 > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional co
[jira] [Updated] (CASSANDRA-14613) ant generate-idea-files needs update after CASSANDRA-9608
[ https://issues.apache.org/jira/browse/CASSANDRA-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson updated CASSANDRA-14613: Assignee: Marcus Eriksson Reviewer: Jason Brown Status: Patch Available (was: Open) patch [here|https://github.com/krummas/cassandra/commits/marcuse/14613] which simply defaults everything to java8 - if anyone wants to run java11 they can probably update the project themselves (language level should be 8 until we only support 11 though) > ant generate-idea-files needs update after CASSANDRA-9608 > - > > Key: CASSANDRA-14613 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14613 > Project: Cassandra > Issue Type: Bug >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Major > Fix For: 4.x > > > {{ide/idea-iml-file.xml}} looks hard coded to include {{src/java11}} when > creating the project, this should probably detect what version we are > building for instead > cc [~snazy] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14573) Expose settings in virtual table
[ https://issues.apache.org/jira/browse/CASSANDRA-14573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563153#comment-16563153 ] ASF GitHub Bot commented on CASSANDRA-14573: GitHub user clohfink opened a pull request: https://github.com/apache/cassandra/pull/242 Expose settings in virtual table for CASSANDRA-14573 You can merge this pull request into a Git repository by running: $ git pull https://github.com/clohfink/cassandra trunk-14573 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cassandra/pull/242.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #242 commit 30bd71f4cba9c0a633c12ba80414af50863c1c2e Author: Chris Lohfink Date: 2018-07-31T05:33:54Z Expose settings in virtual table for CASSANDRA-14573 > Expose settings in virtual table > > > Key: CASSANDRA-14573 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14573 > Project: Cassandra > Issue Type: New Feature >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Minor > Labels: virtual-tables > > Allow both viewing what the settings are (currently impossible for some) and > allow changing some settings. > Example: > {code:java} > UPDATE system_info.settings SET value = 'false' WHERE setting = > 'hinted_handoff_enabled'; > SELECT * FROM system_info.settings WHERE writable = True; > setting | value | writable > --++-- > batch_size_fail_threshold_in_kb | 50 | True > batch_size_warn_threshold_in_kb | 5 | True > cas_contention_timeout_in_ms | 1000 | True > compaction_throughput_mb_per_sec | 16 | True > concurrent_compactors | 2 | True >concurrent_validations | 2147483647 | True > counter_write_request_timeout_in_ms | 5000 | True >hinted_handoff_enabled | false | True > hinted_handoff_throttle_in_kb | 1024 | True > incremental_backups | false | True > inter_dc_stream_throughput_outbound_megabits_per_sec |200 | True > phi_convict_threshold |8.0 | True > range_request_timeout_in_ms | 1 | True >read_request_timeout_in_ms | 5000 | True > request_timeout_in_ms | 1 | True > stream_throughput_outbound_megabits_per_sec |200 | True > tombstone_failure_threshold | 10 | True > tombstone_warn_threshold | 1000 | True >truncate_request_timeout_in_ms | 6 | True > write_request_timeout_in_ms | 2000 | > True{code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14573) Expose settings in virtual table
[ https://issues.apache.org/jira/browse/CASSANDRA-14573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lohfink updated CASSANDRA-14573: -- Status: Patch Available (was: Open) > Expose settings in virtual table > > > Key: CASSANDRA-14573 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14573 > Project: Cassandra > Issue Type: New Feature >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Minor > Labels: virtual-tables > > Allow both viewing what the settings are (currently impossible for some) and > allow changing some settings. > Example: > {code:java} > UPDATE system_info.settings SET value = 'false' WHERE setting = > 'hinted_handoff_enabled'; > SELECT * FROM system_info.settings WHERE writable = True; > setting | value | writable > --++-- > batch_size_fail_threshold_in_kb | 50 | True > batch_size_warn_threshold_in_kb | 5 | True > cas_contention_timeout_in_ms | 1000 | True > compaction_throughput_mb_per_sec | 16 | True > concurrent_compactors | 2 | True >concurrent_validations | 2147483647 | True > counter_write_request_timeout_in_ms | 5000 | True >hinted_handoff_enabled | false | True > hinted_handoff_throttle_in_kb | 1024 | True > incremental_backups | false | True > inter_dc_stream_throughput_outbound_megabits_per_sec |200 | True > phi_convict_threshold |8.0 | True > range_request_timeout_in_ms | 1 | True >read_request_timeout_in_ms | 5000 | True > request_timeout_in_ms | 1 | True > stream_throughput_outbound_megabits_per_sec |200 | True > tombstone_failure_threshold | 10 | True > tombstone_warn_threshold | 1000 | True >truncate_request_timeout_in_ms | 6 | True > write_request_timeout_in_ms | 2000 | > True{code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] Git Push Summary
Repository: cassandra Updated Tags: refs/tags/3.11.3-tentative [deleted] 31d5d870f - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] Git Push Summary
Repository: cassandra Updated Tags: refs/tags/cassandra-3.11.3 [created] 153b760c3 - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] Git Push Summary
Repository: cassandra Updated Tags: refs/tags/cassandra-3.0.17 [created] caedb9121 - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] Git Push Summary
Repository: cassandra Updated Tags: refs/tags/3.0.17-tentative [deleted] d52c7b8c5 - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] Git Push Summary
Repository: cassandra Updated Tags: refs/tags/cassandra-2.2.13 [created] 5250fcef7 - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] Git Push Summary
Repository: cassandra Updated Tags: refs/tags/cassandra-2.2.13 [deleted] ad6956490 - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] Git Push Summary
Repository: cassandra Updated Tags: refs/tags/cassandra-2.2.13 [created] ad6956490 - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] Git Push Summary
Repository: cassandra Updated Tags: refs/tags/2.2.13-tentative [deleted] 3482370df - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14614) CircleCI config has dtests enabled but not the correct resources settings
[ https://issues.apache.org/jira/browse/CASSANDRA-14614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Brown updated CASSANDRA-14614: Status: Ready to Commit (was: Patch Available) > CircleCI config has dtests enabled but not the correct resources settings > - > > Key: CASSANDRA-14614 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14614 > Project: Cassandra > Issue Type: Bug > Components: Testing >Reporter: Jordan West >Assignee: Jordan West >Priority: Trivial > > The commit for -CASSANDRA-9608- enabled the {{with_dtests_jobs}} > configuration in {{.circleci/config.yml}} but not the necessary env var > settings. We should revert this, unless we planned to start running dtests > with the correct resources on every master commit, in which case we should > fix the resources. > (cc [~snazy] [~jasobrown]) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14614) CircleCI config has dtests enabled but not the correct resources settings
[ https://issues.apache.org/jira/browse/CASSANDRA-14614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563003#comment-16563003 ] Jason Brown commented on CASSANDRA-14614: - +1. Commit later tonight. > CircleCI config has dtests enabled but not the correct resources settings > - > > Key: CASSANDRA-14614 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14614 > Project: Cassandra > Issue Type: Bug > Components: Testing >Reporter: Jordan West >Assignee: Jordan West >Priority: Trivial > > The commit for -CASSANDRA-9608- enabled the {{with_dtests_jobs}} > configuration in {{.circleci/config.yml}} but not the necessary env var > settings. We should revert this, unless we planned to start running dtests > with the correct resources on every master commit, in which case we should > fix the resources. > (cc [~snazy] [~jasobrown]) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14614) CircleCI config has dtests enabled but not the correct resources settings
[ https://issues.apache.org/jira/browse/CASSANDRA-14614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Brown updated CASSANDRA-14614: Status: Patch Available (was: Open) > CircleCI config has dtests enabled but not the correct resources settings > - > > Key: CASSANDRA-14614 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14614 > Project: Cassandra > Issue Type: Bug > Components: Testing >Reporter: Jordan West >Assignee: Jordan West >Priority: Trivial > > The commit for -CASSANDRA-9608- enabled the {{with_dtests_jobs}} > configuration in {{.circleci/config.yml}} but not the necessary env var > settings. We should revert this, unless we planned to start running dtests > with the correct resources on every master commit, in which case we should > fix the resources. > (cc [~snazy] [~jasobrown]) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14614) CircleCI config has dtests enabled but not the correct resources settings
[ https://issues.apache.org/jira/browse/CASSANDRA-14614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Brown updated CASSANDRA-14614: Reviewer: Jason Brown > CircleCI config has dtests enabled but not the correct resources settings > - > > Key: CASSANDRA-14614 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14614 > Project: Cassandra > Issue Type: Bug > Components: Testing >Reporter: Jordan West >Assignee: Jordan West >Priority: Trivial > > The commit for -CASSANDRA-9608- enabled the {{with_dtests_jobs}} > configuration in {{.circleci/config.yml}} but not the necessary env var > settings. We should revert this, unless we planned to start running dtests > with the correct resources on every master commit, in which case we should > fix the resources. > (cc [~snazy] [~jasobrown]) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14612) Please add OWASP Dependency Check to the build (pom.xml)
[ https://issues.apache.org/jira/browse/CASSANDRA-14612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562735#comment-16562735 ] Jason Brown commented on CASSANDRA-14612: - tbh, running this on nightly builds is kinda overkill, as nobody runs nightly builds in production (and we don't make them, as [~djoshi3] points out). Even if we ran this proposal as part of the release process, and posted that as part of the vote, it sounds like like we'd still be much closer to the intent of this request. We don't change dependencies that often, and when we do, it's probably simpler to just run the "OWASP checker" task at release time. Hell, we could add it to the the CI jobs, if we cared to go that far. > Please add OWASP Dependency Check to the build (pom.xml) > > > Key: CASSANDRA-14612 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14612 > Project: Cassandra > Issue Type: New Feature > Components: Build, Lifecycle, Observability, Repair, Testing > Environment: All development, build, test, environments. >Reporter: Albert Baker >Priority: Major > Labels: build, easyfix, security > Fix For: 3.11.x, 4.x > > Original Estimate: 1h > Remaining Estimate: 1h > > Please add OWASP Dependency Check to the build (pom.xml). OWASP DC makes an > outbound REST call to MITRE Common Vulnerabilities & Exposures (CVE) to > perform a lookup for each dependant .jar to list any/all known > vulnerabilities for each jar. This step is needed because a manual MITRE CVE > lookup/check on the main component does not include checking for > vulnerabilities in components or in dependant libraries. > OWASP Dependency check : > https://www.owasp.org/index.php/OWASP_Dependency_Check has plug-ins for most > Java build/make types (ant, maven, ivy, gradle). > Also, add the appropriate command to the nightly build to generate a report > of all known vulnerabilities in any/all third party libraries/dependencies > that get pulled in. example : mvn -Powasp -Dtest=false -DfailIfNoTests=false > clean aggregate > Generating this report nightly/weekly will help inform the project's > development team if any dependant libraries have a reported known > vulnerailities. Project teams that keep up with removing vulnerabilities on a > weekly basis will help protect businesses that rely on these open source > componets. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14612) Please add OWASP Dependency Check to the build (pom.xml)
[ https://issues.apache.org/jira/browse/CASSANDRA-14612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562694#comment-16562694 ] Dinesh Joshi commented on CASSANDRA-14612: -- I'm not aware of nightly builds on this project. We would need to set those up in addition to adding this to the ant build target. > Please add OWASP Dependency Check to the build (pom.xml) > > > Key: CASSANDRA-14612 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14612 > Project: Cassandra > Issue Type: New Feature > Components: Build, Lifecycle, Observability, Repair, Testing > Environment: All development, build, test, environments. >Reporter: Albert Baker >Priority: Major > Labels: build, easyfix, security > Fix For: 3.11.x, 4.x > > Original Estimate: 1h > Remaining Estimate: 1h > > Please add OWASP Dependency Check to the build (pom.xml). OWASP DC makes an > outbound REST call to MITRE Common Vulnerabilities & Exposures (CVE) to > perform a lookup for each dependant .jar to list any/all known > vulnerabilities for each jar. This step is needed because a manual MITRE CVE > lookup/check on the main component does not include checking for > vulnerabilities in components or in dependant libraries. > OWASP Dependency check : > https://www.owasp.org/index.php/OWASP_Dependency_Check has plug-ins for most > Java build/make types (ant, maven, ivy, gradle). > Also, add the appropriate command to the nightly build to generate a report > of all known vulnerabilities in any/all third party libraries/dependencies > that get pulled in. example : mvn -Powasp -Dtest=false -DfailIfNoTests=false > clean aggregate > Generating this report nightly/weekly will help inform the project's > development team if any dependant libraries have a reported known > vulnerailities. Project teams that keep up with removing vulnerabilities on a > weekly basis will help protect businesses that rely on these open source > componets. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14614) CircleCI config has dtests enabled but not the correct resources settings
[ https://issues.apache.org/jira/browse/CASSANDRA-14614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562673#comment-16562673 ] Jordan West commented on CASSANDRA-14614: - [branch|https://github.com/jrwest/cassandra/tree/14614-trunk] | [tests|https://circleci.com/gh/jrwest/cassandra/tree/14614-trunk] > CircleCI config has dtests enabled but not the correct resources settings > - > > Key: CASSANDRA-14614 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14614 > Project: Cassandra > Issue Type: Bug > Components: Testing >Reporter: Jordan West >Assignee: Jordan West >Priority: Trivial > > The commit for -CASSANDRA-9608- enabled the {{with_dtests_jobs}} > configuration in {{.circleci/config.yml}} but not the necessary env var > settings. We should revert this, unless we planned to start running dtests > with the correct resources on every master commit, in which case we should > fix the resources. > (cc [~snazy] [~jasobrown]) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14613) ant generate-idea-files needs update after CASSANDRA-9608
[ https://issues.apache.org/jira/browse/CASSANDRA-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562647#comment-16562647 ] Jason Brown commented on CASSANDRA-14613: - [~krummas] Thank you for volunteering; I will review. bq. [~iamaleksey] I feel like a more appropriate workaround would be to revert CASSANDRA-9608 This seems unnecessarily heavy-handed. Let's fix the known, tractable problems before throwing everything out the window. > ant generate-idea-files needs update after CASSANDRA-9608 > - > > Key: CASSANDRA-14613 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14613 > Project: Cassandra > Issue Type: Bug >Reporter: Marcus Eriksson >Priority: Major > Fix For: 4.x > > > {{ide/idea-iml-file.xml}} looks hard coded to include {{src/java11}} when > creating the project, this should probably detect what version we are > building for instead > cc [~snazy] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14612) Please add OWASP Dependency Check to the build (pom.xml)
[ https://issues.apache.org/jira/browse/CASSANDRA-14612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562480#comment-16562480 ] Albert Baker commented on CASSANDRA-14612: -- Unfortunatetly I am prevented by a very restrictive non-compete contract to contribute to any other clients including even open-source projects. Creating a jira item, for me, is skating the line. > Please add OWASP Dependency Check to the build (pom.xml) > > > Key: CASSANDRA-14612 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14612 > Project: Cassandra > Issue Type: New Feature > Components: Build, Lifecycle, Observability, Repair, Testing > Environment: All development, build, test, environments. >Reporter: Albert Baker >Priority: Major > Labels: build, easyfix, security > Fix For: 3.11.x, 4.x > > Original Estimate: 1h > Remaining Estimate: 1h > > Please add OWASP Dependency Check to the build (pom.xml). OWASP DC makes an > outbound REST call to MITRE Common Vulnerabilities & Exposures (CVE) to > perform a lookup for each dependant .jar to list any/all known > vulnerabilities for each jar. This step is needed because a manual MITRE CVE > lookup/check on the main component does not include checking for > vulnerabilities in components or in dependant libraries. > OWASP Dependency check : > https://www.owasp.org/index.php/OWASP_Dependency_Check has plug-ins for most > Java build/make types (ant, maven, ivy, gradle). > Also, add the appropriate command to the nightly build to generate a report > of all known vulnerabilities in any/all third party libraries/dependencies > that get pulled in. example : mvn -Powasp -Dtest=false -DfailIfNoTests=false > clean aggregate > Generating this report nightly/weekly will help inform the project's > development team if any dependant libraries have a reported known > vulnerailities. Project teams that keep up with removing vulnerabilities on a > weekly basis will help protect businesses that rely on these open source > componets. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14614) CircleCI config has dtests enabled but not the correct resources settings
[ https://issues.apache.org/jira/browse/CASSANDRA-14614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562462#comment-16562462 ] Jordan West commented on CASSANDRA-14614: - I'll have a patch up later this afternoon if no one wants to take this. Just need to run to a few meetings. > CircleCI config has dtests enabled but not the correct resources settings > - > > Key: CASSANDRA-14614 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14614 > Project: Cassandra > Issue Type: Bug > Components: Testing >Reporter: Jordan West >Assignee: Jordan West >Priority: Trivial > > The commit for -CASSANDRA-9608- enabled the {{with_dtests_jobs}} > configuration in {{.circleci/config.yml}} but not the necessary env var > settings. We should revert this, unless we planned to start running dtests > with the correct resources on every master commit, in which case we should > fix the resources. > (cc [~snazy] [~jasobrown]) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-14614) CircleCI config has dtests enabled but not the correct resources settings
Jordan West created CASSANDRA-14614: --- Summary: CircleCI config has dtests enabled but not the correct resources settings Key: CASSANDRA-14614 URL: https://issues.apache.org/jira/browse/CASSANDRA-14614 Project: Cassandra Issue Type: Bug Components: Testing Reporter: Jordan West Assignee: Jordan West The commit for -CASSANDRA-9608- enabled the {{with_dtests_jobs}} configuration in {{.circleci/config.yml}} but not the necessary env var settings. We should revert this, unless we planned to start running dtests with the correct resources on every master commit, in which case we should fix the resources. (cc [~snazy] [~jasobrown]) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14605) Major compaction of LCS tables very slow
[ https://issues.apache.org/jira/browse/CASSANDRA-14605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562449#comment-16562449 ] Joseph Lynch commented on CASSANDRA-14605: -- [~krummas] I've set the parameter and taken another flamegraph, all of the {{moveStarts}} usage is gone (nice!) and it appears to be proceeding about twice as fast (instead of taking 4 days it will take 2 days). I've attached the new flamegraph which looks much more reasonable, although now I notice the 50% spent in {{SSTableReader::getCachedPosition}} which I believe is just invalidating the key cache, and in particular {{ConcurrentLinkedHashMap}} appears to be pretty slow for high miss rate queries. There may be some low hanging fruit performance improvements to have there as well. [^sstable_reopen.svg] > Major compaction of LCS tables very slow > > > Key: CASSANDRA-14605 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14605 > Project: Cassandra > Issue Type: Improvement > Components: Compaction > Environment: AWS, i3.4xlarge instance (very fast local nvme storage), > Linux 4.13 > Cassandra 3.0.16 >Reporter: Joseph Lynch >Assignee: Benedict >Priority: Minor > Labels: lcs, performance > Attachments: slow_major_compaction_lcs.svg, sstable_reopen.svg > > > We've recently started deploying 3.0.16 more heavily in production and today > I noticed that full compaction of LCS tables takes a much longer time than it > should. In particular it appears to be faster to convert a large dataset to > STCS, run full compaction, and then convert it to LCS (with re-leveling) than > it is to just run full compaction on LCS (with re-leveling). > I was able to get a CPU flame graph showing 50% of the major compaction's cpu > time being spent in > [{{SSTableRewriter::maybeReopenEarly}}|https://github.com/apache/cassandra/blob/6ba2fb9395226491872b41312d978a169f36fcdb/src/java/org/apache/cassandra/io/sstable/SSTableRewriter.java#L184] > calling > [{{SSTableRewriter::moveStarts}}|https://github.com/apache/cassandra/blob/6ba2fb9395226491872b41312d978a169f36fcdb/src/java/org/apache/cassandra/io/sstable/SSTableRewriter.java#L223]. > I've attached the flame graph here which was generated by running Cassandra > using {{-XX:+PreserveFramePointer}}, then using jstack to get the compaction > native thread id (nid) which I then used perf to get on cpu time: > {noformat} > perf record -t -o -F 49 -g sleep 60 > >/dev/null > {noformat} > I took this data and collapsed it using the steps talked about in [Brendan > Gregg's java in flames > blogpost|https://medium.com/netflix-techblog/java-in-flames-e763b3d32166] > (Instructions section) to generate the graph. > The results are that at least on this dataset (700GB of data compressed, > 2.2TB uncompressed), we are spending 50% of our cpu time in {{moveStarts}} > and I am unsure that we need to be doing that as frequently as we are. I'll > see if I can come up with a clean reproduction to confirm if it's a general > problem or just on this particular dataset. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14605) Major compaction of LCS tables very slow
[ https://issues.apache.org/jira/browse/CASSANDRA-14605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Lynch updated CASSANDRA-14605: - Attachment: sstable_reopen.svg > Major compaction of LCS tables very slow > > > Key: CASSANDRA-14605 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14605 > Project: Cassandra > Issue Type: Improvement > Components: Compaction > Environment: AWS, i3.4xlarge instance (very fast local nvme storage), > Linux 4.13 > Cassandra 3.0.16 >Reporter: Joseph Lynch >Assignee: Benedict >Priority: Minor > Labels: lcs, performance > Attachments: slow_major_compaction_lcs.svg, sstable_reopen.svg > > > We've recently started deploying 3.0.16 more heavily in production and today > I noticed that full compaction of LCS tables takes a much longer time than it > should. In particular it appears to be faster to convert a large dataset to > STCS, run full compaction, and then convert it to LCS (with re-leveling) than > it is to just run full compaction on LCS (with re-leveling). > I was able to get a CPU flame graph showing 50% of the major compaction's cpu > time being spent in > [{{SSTableRewriter::maybeReopenEarly}}|https://github.com/apache/cassandra/blob/6ba2fb9395226491872b41312d978a169f36fcdb/src/java/org/apache/cassandra/io/sstable/SSTableRewriter.java#L184] > calling > [{{SSTableRewriter::moveStarts}}|https://github.com/apache/cassandra/blob/6ba2fb9395226491872b41312d978a169f36fcdb/src/java/org/apache/cassandra/io/sstable/SSTableRewriter.java#L223]. > I've attached the flame graph here which was generated by running Cassandra > using {{-XX:+PreserveFramePointer}}, then using jstack to get the compaction > native thread id (nid) which I then used perf to get on cpu time: > {noformat} > perf record -t -o -F 49 -g sleep 60 > >/dev/null > {noformat} > I took this data and collapsed it using the steps talked about in [Brendan > Gregg's java in flames > blogpost|https://medium.com/netflix-techblog/java-in-flames-e763b3d32166] > (Instructions section) to generate the graph. > The results are that at least on this dataset (700GB of data compressed, > 2.2TB uncompressed), we are spending 50% of our cpu time in {{moveStarts}} > and I am unsure that we need to be doing that as frequently as we are. I'll > see if I can come up with a clean reproduction to confirm if it's a general > problem or just on this particular dataset. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14605) Major compaction of LCS tables very slow
[ https://issues.apache.org/jira/browse/CASSANDRA-14605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Lynch updated CASSANDRA-14605: - Attachment: (was: sstable_reopen.svg) > Major compaction of LCS tables very slow > > > Key: CASSANDRA-14605 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14605 > Project: Cassandra > Issue Type: Improvement > Components: Compaction > Environment: AWS, i3.4xlarge instance (very fast local nvme storage), > Linux 4.13 > Cassandra 3.0.16 >Reporter: Joseph Lynch >Assignee: Benedict >Priority: Minor > Labels: lcs, performance > Attachments: slow_major_compaction_lcs.svg > > > We've recently started deploying 3.0.16 more heavily in production and today > I noticed that full compaction of LCS tables takes a much longer time than it > should. In particular it appears to be faster to convert a large dataset to > STCS, run full compaction, and then convert it to LCS (with re-leveling) than > it is to just run full compaction on LCS (with re-leveling). > I was able to get a CPU flame graph showing 50% of the major compaction's cpu > time being spent in > [{{SSTableRewriter::maybeReopenEarly}}|https://github.com/apache/cassandra/blob/6ba2fb9395226491872b41312d978a169f36fcdb/src/java/org/apache/cassandra/io/sstable/SSTableRewriter.java#L184] > calling > [{{SSTableRewriter::moveStarts}}|https://github.com/apache/cassandra/blob/6ba2fb9395226491872b41312d978a169f36fcdb/src/java/org/apache/cassandra/io/sstable/SSTableRewriter.java#L223]. > I've attached the flame graph here which was generated by running Cassandra > using {{-XX:+PreserveFramePointer}}, then using jstack to get the compaction > native thread id (nid) which I then used perf to get on cpu time: > {noformat} > perf record -t -o -F 49 -g sleep 60 > >/dev/null > {noformat} > I took this data and collapsed it using the steps talked about in [Brendan > Gregg's java in flames > blogpost|https://medium.com/netflix-techblog/java-in-flames-e763b3d32166] > (Instructions section) to generate the graph. > The results are that at least on this dataset (700GB of data compressed, > 2.2TB uncompressed), we are spending 50% of our cpu time in {{moveStarts}} > and I am unsure that we need to be doing that as frequently as we are. I'll > see if I can come up with a clean reproduction to confirm if it's a general > problem or just on this particular dataset. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14605) Major compaction of LCS tables very slow
[ https://issues.apache.org/jira/browse/CASSANDRA-14605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Lynch updated CASSANDRA-14605: - Attachment: sstable_reopen.svg > Major compaction of LCS tables very slow > > > Key: CASSANDRA-14605 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14605 > Project: Cassandra > Issue Type: Improvement > Components: Compaction > Environment: AWS, i3.4xlarge instance (very fast local nvme storage), > Linux 4.13 > Cassandra 3.0.16 >Reporter: Joseph Lynch >Assignee: Benedict >Priority: Minor > Labels: lcs, performance > Attachments: slow_major_compaction_lcs.svg, sstable_reopen.svg > > > We've recently started deploying 3.0.16 more heavily in production and today > I noticed that full compaction of LCS tables takes a much longer time than it > should. In particular it appears to be faster to convert a large dataset to > STCS, run full compaction, and then convert it to LCS (with re-leveling) than > it is to just run full compaction on LCS (with re-leveling). > I was able to get a CPU flame graph showing 50% of the major compaction's cpu > time being spent in > [{{SSTableRewriter::maybeReopenEarly}}|https://github.com/apache/cassandra/blob/6ba2fb9395226491872b41312d978a169f36fcdb/src/java/org/apache/cassandra/io/sstable/SSTableRewriter.java#L184] > calling > [{{SSTableRewriter::moveStarts}}|https://github.com/apache/cassandra/blob/6ba2fb9395226491872b41312d978a169f36fcdb/src/java/org/apache/cassandra/io/sstable/SSTableRewriter.java#L223]. > I've attached the flame graph here which was generated by running Cassandra > using {{-XX:+PreserveFramePointer}}, then using jstack to get the compaction > native thread id (nid) which I then used perf to get on cpu time: > {noformat} > perf record -t -o -F 49 -g sleep 60 > >/dev/null > {noformat} > I took this data and collapsed it using the steps talked about in [Brendan > Gregg's java in flames > blogpost|https://medium.com/netflix-techblog/java-in-flames-e763b3d32166] > (Instructions section) to generate the graph. > The results are that at least on this dataset (700GB of data compressed, > 2.2TB uncompressed), we are spending 50% of our cpu time in {{moveStarts}} > and I am unsure that we need to be doing that as frequently as we are. I'll > see if I can come up with a clean reproduction to confirm if it's a general > problem or just on this particular dataset. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14613) ant generate-idea-files needs update after CASSANDRA-9608
[ https://issues.apache.org/jira/browse/CASSANDRA-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562349#comment-16562349 ] Marcus Eriksson commented on CASSANDRA-14613: - I’ll do the simple fix tomorrow > ant generate-idea-files needs update after CASSANDRA-9608 > - > > Key: CASSANDRA-14613 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14613 > Project: Cassandra > Issue Type: Bug >Reporter: Marcus Eriksson >Priority: Major > Fix For: 4.x > > > {{ide/idea-iml-file.xml}} looks hard coded to include {{src/java11}} when > creating the project, this should probably detect what version we are > building for instead > cc [~snazy] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14598) [dtest] flakey test: test_decommissioned_node_cant_rejoin - topology_test.TestTopology
[ https://issues.apache.org/jira/browse/CASSANDRA-14598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562287#comment-16562287 ] Jay Zhuang commented on CASSANDRA-14598: Tested locally with {{3.0}}, seems fine: {noformat} $ pytest --count 10 -p no:flaky --cassandra-dir=~/ws/cassandra topology_test.py::TestTopology::test_decommissioned_node_cant_rejoin ... == 10 passed in 883.98 seconds == {noformat} > [dtest] flakey test: test_decommissioned_node_cant_rejoin - > topology_test.TestTopology > -- > > Key: CASSANDRA-14598 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14598 > Project: Cassandra > Issue Type: Bug >Reporter: Jason Brown >Priority: Minor > Labels: dtest > > Only saw this fail on 3.0, but looks like a problem with the dtest itself > (ubder some failure scenario). Output from pytest error: > {noformat} > > assert re.search(rejoin_err, > '\n'.join(['\n'.join(err_list) for err_list in > node3.grep_log_for_errors()]), re.MULTILINE) > E AssertionError: assert None > E + where None = ('This node was > decommissioned and will not rejoin the ring', '', ) > E + where = re.search > E + and '' = ([]) > E + where = '\n'.join > E + and = re.MULTILINE > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14613) ant generate-idea-files needs update after CASSANDRA-9608
[ https://issues.apache.org/jira/browse/CASSANDRA-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562282#comment-16562282 ] Aleksey Yeschenko commented on CASSANDRA-14613: --- [~snazy] I'm sorry, Robert, but this is an unacceptable answer. I feel like a more appropriate workaround would be to revert CASSANDRA-9608 - until someone has time to do it properly. > ant generate-idea-files needs update after CASSANDRA-9608 > - > > Key: CASSANDRA-14613 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14613 > Project: Cassandra > Issue Type: Bug >Reporter: Marcus Eriksson >Priority: Major > Fix For: 4.x > > > {{ide/idea-iml-file.xml}} looks hard coded to include {{src/java11}} when > creating the project, this should probably detect what version we are > building for instead > cc [~snazy] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14613) ant generate-idea-files needs update after CASSANDRA-9608
[ https://issues.apache.org/jira/browse/CASSANDRA-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562259#comment-16562259 ] Robert Stupp commented on CASSANDRA-14613: -- As a workaround, just remove {{src/java11}} and add {{src/java8}}. I won't have much spare time to work on this in the next 3-4 weeks. > ant generate-idea-files needs update after CASSANDRA-9608 > - > > Key: CASSANDRA-14613 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14613 > Project: Cassandra > Issue Type: Bug >Reporter: Marcus Eriksson >Priority: Major > Fix For: 4.x > > > {{ide/idea-iml-file.xml}} looks hard coded to include {{src/java11}} when > creating the project, this should probably detect what version we are > building for instead > cc [~snazy] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14598) [dtest] flakey test: test_decommissioned_node_cant_rejoin - topology_test.TestTopology
[ https://issues.apache.org/jira/browse/CASSANDRA-14598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Zhuang updated CASSANDRA-14598: --- Environment: (was: Only saw this fail on 3.0, but looks like a problem with the dtest itself (ubder some failure scenario). Output from pytest error: {noformat} > assert re.search(rejoin_err, '\n'.join(['\n'.join(err_list) for err_list in node3.grep_log_for_errors()]), re.MULTILINE) E AssertionError: assert None E+ where None = ('This node was decommissioned and will not rejoin the ring', '', ) E+where = re.search E+and '' = ([]) E+ where = '\n'.join E+and= re.MULTILINE {noformat}) Description: Only saw this fail on 3.0, but looks like a problem with the dtest itself (ubder some failure scenario). Output from pytest error: {noformat} > assert re.search(rejoin_err, '\n'.join(['\n'.join(err_list) for err_list in node3.grep_log_for_errors()]), re.MULTILINE) E AssertionError: assert None E + where None = ('This node was decommissioned and will not rejoin the ring', '', ) E + where = re.search E + and '' = ([]) E + where = '\n'.join E + and = re.MULTILINE {noformat} > [dtest] flakey test: test_decommissioned_node_cant_rejoin - > topology_test.TestTopology > -- > > Key: CASSANDRA-14598 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14598 > Project: Cassandra > Issue Type: Bug >Reporter: Jason Brown >Priority: Minor > Labels: dtest > > Only saw this fail on 3.0, but looks like a problem with the dtest itself > (ubder some failure scenario). Output from pytest error: > {noformat} > > assert re.search(rejoin_err, > '\n'.join(['\n'.join(err_list) for err_list in > node3.grep_log_for_errors()]), re.MULTILINE) > E AssertionError: assert None > E + where None = ('This node was > decommissioned and will not rejoin the ring', '', ) > E + where = re.search > E + and '' = ([]) > E + where = '\n'.join > E + and = re.MULTILINE > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14613) ant generate-idea-files needs update after CASSANDRA-9608
[ https://issues.apache.org/jira/browse/CASSANDRA-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562245#comment-16562245 ] Marcus Eriksson commented on CASSANDRA-14613: - [~snazy] since Runtime.version() is not available in java8, building from inside (and running unit tests etc) idea fails: {code} Error:(47, 20) java: cannot find symbol symbol: method version() location: class java.lang.Runtime {code} the language level is also set wrong (to 10?) but not sure if we can set that in the files we generate > ant generate-idea-files needs update after CASSANDRA-9608 > - > > Key: CASSANDRA-14613 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14613 > Project: Cassandra > Issue Type: Bug >Reporter: Marcus Eriksson >Priority: Major > Fix For: 4.x > > > {{ide/idea-iml-file.xml}} looks hard coded to include {{src/java11}} when > creating the project, this should probably detect what version we are > building for instead > cc [~snazy] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14289) Document sstable tools
[ https://issues.apache.org/jira/browse/CASSANDRA-14289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562244#comment-16562244 ] Valerie Parham-Thompson commented on CASSANDRA-14289: - I've created a draft page here, if you have any feedback on the format of examples or can see a major section to add: https://github.com/dataindataout/cassandra/blob/docs_sstable_manually/doc/source/tools/sstable/sstabledump.rst (Other than this one, the rest are WIP with just text from help.) > Document sstable tools > -- > > Key: CASSANDRA-14289 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14289 > Project: Cassandra > Issue Type: Improvement > Components: Documentation and Website >Reporter: Hannu Kröger >Priority: Major > Attachments: gen-sstable-docs.py, sstabledocs.tar.gz > > > Following tools are missing in the documentation of cassandra tools on the > documentation site (http://cassandra.apache.org/doc/latest/tools/index.html): > * sstabledump > * sstableexpiredblockers > * sstablelevelreset > * sstableloader > * sstablemetadata > * sstableofflinerelevel > * sstablerepairedset > * sstablescrub > * sstablesplit > * sstableupgrade > * sstableutil > * sstableverify -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14613) ant generate-idea-files needs update after CASSANDRA-9608
[ https://issues.apache.org/jira/browse/CASSANDRA-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562231#comment-16562231 ] Robert Stupp commented on CASSANDRA-14613: -- Java 11 sources are part of the source code, so it's correct to include those sources. > ant generate-idea-files needs update after CASSANDRA-9608 > - > > Key: CASSANDRA-14613 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14613 > Project: Cassandra > Issue Type: Bug >Reporter: Marcus Eriksson >Priority: Major > Fix For: 4.x > > > {{ide/idea-iml-file.xml}} looks hard coded to include {{src/java11}} when > creating the project, this should probably detect what version we are > building for instead > cc [~snazy] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14613) ant generate-idea-files needs update after CASSANDRA-9608
[ https://issues.apache.org/jira/browse/CASSANDRA-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562224#comment-16562224 ] Benedict commented on CASSANDRA-14613: -- {quote}yeah but I don't have java11 installed on my machine, so making the idea project default to java11 is wrong {quote} +1 > ant generate-idea-files needs update after CASSANDRA-9608 > - > > Key: CASSANDRA-14613 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14613 > Project: Cassandra > Issue Type: Bug >Reporter: Marcus Eriksson >Priority: Major > Fix For: 4.x > > > {{ide/idea-iml-file.xml}} looks hard coded to include {{src/java11}} when > creating the project, this should probably detect what version we are > building for instead > cc [~snazy] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14613) ant generate-idea-files needs update after CASSANDRA-9608
[ https://issues.apache.org/jira/browse/CASSANDRA-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562212#comment-16562212 ] Marcus Eriksson commented on CASSANDRA-14613: - yeah but I don't have java11 installed on my machine, so making the idea project default to java11 is wrong > ant generate-idea-files needs update after CASSANDRA-9608 > - > > Key: CASSANDRA-14613 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14613 > Project: Cassandra > Issue Type: Bug >Reporter: Marcus Eriksson >Priority: Major > Fix For: 4.x > > > {{ide/idea-iml-file.xml}} looks hard coded to include {{src/java11}} when > creating the project, this should probably detect what version we are > building for instead > cc [~snazy] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14613) ant generate-idea-files needs update after CASSANDRA-9608
[ https://issues.apache.org/jira/browse/CASSANDRA-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562207#comment-16562207 ] Robert Stupp commented on CASSANDRA-14613: -- {quote}detect what version we are building for {quote} WDYM? That's in trunk - and trunk has src/java11 > ant generate-idea-files needs update after CASSANDRA-9608 > - > > Key: CASSANDRA-14613 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14613 > Project: Cassandra > Issue Type: Bug >Reporter: Marcus Eriksson >Priority: Major > Fix For: 4.x > > > {{ide/idea-iml-file.xml}} looks hard coded to include {{src/java11}} when > creating the project, this should probably detect what version we are > building for instead > cc [~snazy] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14600) [dtest] test_system_auth_ks_is_alterable - auth_test.TestAuth
[ https://issues.apache.org/jira/browse/CASSANDRA-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562199#comment-16562199 ] Jay Zhuang commented on CASSANDRA-14600: Thanks [~jasobrown]. Committed as [{{17e0656}}|https://github.com/apache/cassandra-dtest/commit/17e0656a948d52cc55a40e8bf6dc139dd5fa6920]. > [dtest] test_system_auth_ks_is_alterable - auth_test.TestAuth > - > > Key: CASSANDRA-14600 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14600 > Project: Cassandra > Issue Type: Bug > Components: Testing >Reporter: Jason Brown >Assignee: Jay Zhuang >Priority: Minor > Labels: dtest > > Test 'fails' on 3.0 and 3.11 with this error from pytest: > > {noformat} > test teardown failure > Unexpected error found in node logs (see stdout for full details). Errors: > [ERROR [Native-Transport-Requests-1] 2018-07-23 18:14:34,585 Message.java:629 > - Unexpected exception during request; channel = [id: 0x0ffc99f5, > L:/127.0.0.3:9042 - R:/127.0.0.1:54516] > java.lang.RuntimeException: > org.apache.cassandra.exceptions.UnavailableException: Cannot achieve > consistency level QUORUM > at > org.apache.cassandra.auth.CassandraRoleManager.getRole(CassandraRoleManager.java:518) > ~[main/:na] > at > org.apache.cassandra.auth.CassandraRoleManager.canLogin(CassandraRoleManager.java:312) > ~[main/:na] > at org.apache.cassandra.service.ClientState.login(ClientState.java:281) > ~[main/:na] > at > org.apache.cassandra.transport.messages.AuthResponse.execute(AuthResponse.java:80) > ~[main/:na] > at > org.apache.cassandra.transport.Message$Dispatcher.channelRead0(Message.java:517) > [main/:na] > at > org.apache.cassandra.transport.Message$Dispatcher.channelRead0(Message.java:410) > [main/:na] > at > io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105) > [netty-all-4.0.44.Final.jar:4.0.44.Final] > at > io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:357) > [netty-all-4.0.44.Final.jar:4.0.44.Final] > at > io.netty.channel.AbstractChannelHandlerContext.access$600(AbstractChannelHandlerContext.java:35) > [netty-all-4.0.44.Final.jar:4.0.44.Final] > at > io.netty.channel.AbstractChannelHandlerContext$7.run(AbstractChannelHandlerContext.java:348) > [netty-all-4.0.44.Final.jar:4.0.44.Final] > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) > [na:1.8.0_154-cassandra] > at > org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$FutureTask.run(AbstractLocalAwareExecutorService.java:162) > [main/:na] > at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:109) > [main/:na] > at java.lang.Thread.run(Thread.java:748) [na:1.8.0_154-cassandra] > Caused by: org.apache.cassandra.exceptions.UnavailableException: Cannot > achieve consistency level QUORUM > at > org.apache.cassandra.db.ConsistencyLevel.assureSufficientLiveNodes(ConsistencyLevel.java:334) > ~[main/:na] > at > org.apache.cassandra.service.AbstractReadExecutor.getReadExecutor(AbstractReadExecutor.java:162) > ~[main/:na] > at > org.apache.cassandra.service.StorageProxy$SinglePartitionReadLifecycle.(StorageProxy.java:1779) > ~[main/:na] > at > org.apache.cassandra.service.StorageProxy.fetchRows(StorageProxy.java:1741) > ~[main/:na] > at > org.apache.cassandra.service.StorageProxy.readRegular(StorageProxy.java:1684) > ~[main/:na] > at > org.apache.cassandra.service.StorageProxy.read(StorageProxy.java:1599) > ~[main/:na] > at > org.apache.cassandra.db.SinglePartitionReadCommand$Group.execute(SinglePartitionReadCommand.java:1176) > ~[main/:na] > at > org.apache.cassandra.cql3.statements.SelectStatement.execute(SelectStatement.java:315) > ~[main/:na] > at > org.apache.cassandra.cql3.statements.SelectStatement.execute(SelectStatement.java:285) > ~[main/:na] > at > org.apache.cassandra.auth.CassandraRoleManager.getRoleFromTable(CassandraRoleManager.java:526) > ~[main/:na] > at > org.apache.cassandra.auth.CassandraRoleManager.getRole(CassandraRoleManager.java:508) > ~[main/:na] > ... 13 common frames omitted, ERROR [Native-Transport-Requests-3] > 2018-07-23 18:14:35,759 Message.java:629 - Unexpected exception during > request; channel = [id: 0x3bf15467, L:/127.0.0.3:9042 - R:/127.0.0.1:54528] > {noformat} > Not sure if we need just another log error exclude, or if this is legit. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org Fo
[jira] [Updated] (CASSANDRA-14600) [dtest] test_system_auth_ks_is_alterable - auth_test.TestAuth
[ https://issues.apache.org/jira/browse/CASSANDRA-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Zhuang updated CASSANDRA-14600: --- Resolution: Fixed Status: Resolved (was: Ready to Commit) > [dtest] test_system_auth_ks_is_alterable - auth_test.TestAuth > - > > Key: CASSANDRA-14600 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14600 > Project: Cassandra > Issue Type: Bug > Components: Testing >Reporter: Jason Brown >Assignee: Jay Zhuang >Priority: Minor > Labels: dtest > > Test 'fails' on 3.0 and 3.11 with this error from pytest: > > {noformat} > test teardown failure > Unexpected error found in node logs (see stdout for full details). Errors: > [ERROR [Native-Transport-Requests-1] 2018-07-23 18:14:34,585 Message.java:629 > - Unexpected exception during request; channel = [id: 0x0ffc99f5, > L:/127.0.0.3:9042 - R:/127.0.0.1:54516] > java.lang.RuntimeException: > org.apache.cassandra.exceptions.UnavailableException: Cannot achieve > consistency level QUORUM > at > org.apache.cassandra.auth.CassandraRoleManager.getRole(CassandraRoleManager.java:518) > ~[main/:na] > at > org.apache.cassandra.auth.CassandraRoleManager.canLogin(CassandraRoleManager.java:312) > ~[main/:na] > at org.apache.cassandra.service.ClientState.login(ClientState.java:281) > ~[main/:na] > at > org.apache.cassandra.transport.messages.AuthResponse.execute(AuthResponse.java:80) > ~[main/:na] > at > org.apache.cassandra.transport.Message$Dispatcher.channelRead0(Message.java:517) > [main/:na] > at > org.apache.cassandra.transport.Message$Dispatcher.channelRead0(Message.java:410) > [main/:na] > at > io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105) > [netty-all-4.0.44.Final.jar:4.0.44.Final] > at > io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:357) > [netty-all-4.0.44.Final.jar:4.0.44.Final] > at > io.netty.channel.AbstractChannelHandlerContext.access$600(AbstractChannelHandlerContext.java:35) > [netty-all-4.0.44.Final.jar:4.0.44.Final] > at > io.netty.channel.AbstractChannelHandlerContext$7.run(AbstractChannelHandlerContext.java:348) > [netty-all-4.0.44.Final.jar:4.0.44.Final] > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) > [na:1.8.0_154-cassandra] > at > org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$FutureTask.run(AbstractLocalAwareExecutorService.java:162) > [main/:na] > at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:109) > [main/:na] > at java.lang.Thread.run(Thread.java:748) [na:1.8.0_154-cassandra] > Caused by: org.apache.cassandra.exceptions.UnavailableException: Cannot > achieve consistency level QUORUM > at > org.apache.cassandra.db.ConsistencyLevel.assureSufficientLiveNodes(ConsistencyLevel.java:334) > ~[main/:na] > at > org.apache.cassandra.service.AbstractReadExecutor.getReadExecutor(AbstractReadExecutor.java:162) > ~[main/:na] > at > org.apache.cassandra.service.StorageProxy$SinglePartitionReadLifecycle.(StorageProxy.java:1779) > ~[main/:na] > at > org.apache.cassandra.service.StorageProxy.fetchRows(StorageProxy.java:1741) > ~[main/:na] > at > org.apache.cassandra.service.StorageProxy.readRegular(StorageProxy.java:1684) > ~[main/:na] > at > org.apache.cassandra.service.StorageProxy.read(StorageProxy.java:1599) > ~[main/:na] > at > org.apache.cassandra.db.SinglePartitionReadCommand$Group.execute(SinglePartitionReadCommand.java:1176) > ~[main/:na] > at > org.apache.cassandra.cql3.statements.SelectStatement.execute(SelectStatement.java:315) > ~[main/:na] > at > org.apache.cassandra.cql3.statements.SelectStatement.execute(SelectStatement.java:285) > ~[main/:na] > at > org.apache.cassandra.auth.CassandraRoleManager.getRoleFromTable(CassandraRoleManager.java:526) > ~[main/:na] > at > org.apache.cassandra.auth.CassandraRoleManager.getRole(CassandraRoleManager.java:508) > ~[main/:na] > ... 13 common frames omitted, ERROR [Native-Transport-Requests-3] > 2018-07-23 18:14:35,759 Message.java:629 - Unexpected exception during > request; channel = [id: 0x3bf15467, L:/127.0.0.3:9042 - R:/127.0.0.1:54528] > {noformat} > Not sure if we need just another log error exclude, or if this is legit. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
cassandra-dtest git commit: TestAuth: shutdown client before cluster stop
Repository: cassandra-dtest Updated Branches: refs/heads/master 79d8ddd4a -> 17e0656a9 TestAuth: shutdown client before cluster stop patch by Jay Zhuang; reviewed by Jason Brown for CASSANDRA-14600 Project: http://git-wip-us.apache.org/repos/asf/cassandra-dtest/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra-dtest/commit/17e0656a Tree: http://git-wip-us.apache.org/repos/asf/cassandra-dtest/tree/17e0656a Diff: http://git-wip-us.apache.org/repos/asf/cassandra-dtest/diff/17e0656a Branch: refs/heads/master Commit: 17e0656a948d52cc55a40e8bf6dc139dd5fa6920 Parents: 79d8ddd Author: Jay Zhuang Authored: Sat Jul 28 18:56:56 2018 -0700 Committer: Jay Zhuang Committed: Mon Jul 30 10:32:15 2018 -0700 -- auth_test.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra-dtest/blob/17e0656a/auth_test.py -- diff --git a/auth_test.py b/auth_test.py index 8d82b63..f2cd844 100644 --- a/auth_test.py +++ b/auth_test.py @@ -69,8 +69,8 @@ class TestAuth(Tester): logger.debug("Repairing before altering RF") self.cluster.repair() -logger.debug("Shutting down client session") -session.shutdown() +logger.debug("Shutting down client cluster") +session.cluster.shutdown() # make sure schema change is persistent logger.debug("Stopping cluster..") - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14601) [dtest] test_failure_threshold_deletions - paging_test.TestPagingWithDeletions
[ https://issues.apache.org/jira/browse/CASSANDRA-14601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562188#comment-16562188 ] Jay Zhuang commented on CASSANDRA-14601: Thanks [~jasobrown] for the review. Committed as [{{79d8ddd}}|https://github.com/apache/cassandra-dtest/commit/79d8ddd4a418c52d913ccd5f535f75228877301d]. > [dtest] test_failure_threshold_deletions - paging_test.TestPagingWithDeletions > -- > > Key: CASSANDRA-14601 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14601 > Project: Cassandra > Issue Type: Bug > Components: Testing >Reporter: Jason Brown >Assignee: Jay Zhuang >Priority: Minor > Labels: dtest > > failing dtest on 3.11 only. Error output from pytest: > {noformat} > except ReadFailure as exc: > if supports_v5_protocol: > > assert exc.error_code_map is not None > E assert None is not None > E+ where None = ReadFailure('Error from server: code=1300 > [Replica(s) failed to execute read] message="Operation failed - received 0 > r...d 2 failures" info={\'consistency\': \'ALL\', \'required_responses\': 2, > \'received_responses\': 0, \'failures\': 2}',).error_code_map > paging_test.py:3447: AssertionError > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14601) [dtest] test_failure_threshold_deletions - paging_test.TestPagingWithDeletions
[ https://issues.apache.org/jira/browse/CASSANDRA-14601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Zhuang updated CASSANDRA-14601: --- Resolution: Fixed Status: Resolved (was: Ready to Commit) > [dtest] test_failure_threshold_deletions - paging_test.TestPagingWithDeletions > -- > > Key: CASSANDRA-14601 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14601 > Project: Cassandra > Issue Type: Bug > Components: Testing >Reporter: Jason Brown >Assignee: Jay Zhuang >Priority: Minor > Labels: dtest > > failing dtest on 3.11 only. Error output from pytest: > {noformat} > except ReadFailure as exc: > if supports_v5_protocol: > > assert exc.error_code_map is not None > E assert None is not None > E+ where None = ReadFailure('Error from server: code=1300 > [Replica(s) failed to execute read] message="Operation failed - received 0 > r...d 2 failures" info={\'consistency\': \'ALL\', \'required_responses\': 2, > \'received_responses\': 0, \'failures\': 2}',).error_code_map > paging_test.py:3447: AssertionError > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
cassandra-dtest git commit: paging_test: use function to check protocol v5 support
Repository: cassandra-dtest Updated Branches: refs/heads/master c13a78c53 -> 79d8ddd4a paging_test: use function to check protocol v5 support patch by Jay Zhuang; reviewed by Jason Brown for CASSANDRA-14601 Project: http://git-wip-us.apache.org/repos/asf/cassandra-dtest/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra-dtest/commit/79d8ddd4 Tree: http://git-wip-us.apache.org/repos/asf/cassandra-dtest/tree/79d8ddd4 Diff: http://git-wip-us.apache.org/repos/asf/cassandra-dtest/diff/79d8ddd4 Branch: refs/heads/master Commit: 79d8ddd4a418c52d913ccd5f535f75228877301d Parents: c13a78c Author: Jay Zhuang Authored: Sat Jul 28 21:14:09 2018 -0700 Committer: Jay Zhuang Committed: Mon Jul 30 10:26:01 2018 -0700 -- paging_test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra-dtest/blob/79d8ddd4/paging_test.py -- diff --git a/paging_test.py b/paging_test.py index d41b8f3..6be3f7d 100644 --- a/paging_test.py +++ b/paging_test.py @@ -3419,7 +3419,7 @@ class TestPagingWithDeletions(BasePagingTester, PageAssertionMixin): def test_failure_threshold_deletions(self): """Test that paging throws a failure in case of tombstone threshold """ -supports_v5_protocol = self.cluster.version() >= LooseVersion('3.10') +supports_v5_protocol = self.supports_v5_protocol(self.cluster.version()) self.fixture_dtest_setup.allow_log_errors = True self.cluster.set_configuration_options( - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-14522) sstableloader options assume the rpc/native interface is the same as the internode interface
[ https://issues.apache.org/jira/browse/CASSANDRA-14522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16537451#comment-16537451 ] Ariel Weisberg edited comment on CASSANDRA-14522 at 7/30/18 5:22 PM: - There are (almost) no silly questions. You can run a cluster of Cassandra nodes on a single machine using https://github.com/riptano/ccm We write automated tests that use ccm called dtests https://github.com/apache/cassandra-dtest which I don't think you will have to work with for this. You will need some familiarity with Python and virtual environments and setting up requirements files. We use Python 3 now for the tests but cqlsh is Python 2. Let me know if you need help. For testing this you don't need multiple Cassandra processes, but you would need to setup up a second loopback interface that isn't reachable from your usual one so if it picks the incorrect outbound interface it fails to connect. You can probably do this with a firewall rule. So that code you are looking at isn't the problem code I think. It's picking the correct interface to connect to based on the cluster metadata from the driver, but it's probably picking the wrong interface to connect on in BulkLoadConnectionFactory. On trunk this code has changed so I am not sure if it's still an issue https://github.com/apache/cassandra/commit/fc92db2b9b56c143516026ba29cecdec37e286bb#diff-fc44570de4b634df61bd83b639db98d4L51 and where things go wrong is buried a little deeper. https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/streaming/StreamSession.java#L197 [~jasobrown] ^ I think this may be an issue with Netty intracluster streaming and security? Is it going to pick the wrong address just like the bulk loader? I am assuming not because the server loads the YAML and it all works out fine even in an AWS like setup. In 3.0 where this is reported it is https://github.com/apache/cassandra/blob/cassandra-3.0/src/java/org/apache/cassandra/tools/BulkLoadConnectionFactory.java#L51 and it's calling FBUtilities.getLocalAddress() to pick the outbound interface. Looking at the ticket I see connection refused so it's reaching the other node, but the other node isn't bound. Just be aware if you test this you will get a different result if there is no route. TL;DR in all cases I think what we want is FBUtilities.getLocalAddress() to be used to provide a default interface, but there is a command line option to specify the outbound interface for streaming. In 3.0 and other versions forwards (3.11) and backwards (2.2, 2.1) this propagates into BulkLoadConnectionFactory. In trunk/4.0 it will have to propagate all the way into where StreamSession is calling FBUtilities.getLocalAddress(). One option might be to manually set the value in FBUtilities. You will need to create and test a patch for each version. was (Author: aweisberg): There are (almost) no silly questions. You can run a cluster of Cassandra nodes on a single machine using https://github.com/riptano/ccm We write automated tests that use ccm called dtests https://github.com/apache/cassandra-dtest which I don't think you'll have to work with for this. You will need some familiarity with Python and virtual environments and setting up requirements files. We use Python 3 now for the tests but cqlsh is Python 2. Let me know if you need help. For testing this you don't need multiple Cassandra processes, but you would need to setup up an a second loopback interface that isn't reachable from your usual one so if it picks the incorrect outbound interface it fails to connect. You can probably do this with a firewall rule. So that code you are looking at isn't the problem code I think. It's picking the correct interface to connect to based on the cluster metadata from the driver, but it's probably picking the wrong interface to connect on in BulkLoadConnectionFactory. On trunk this code has changed so I am not sure if it's still an issue https://github.com/apache/cassandra/commit/fc92db2b9b56c143516026ba29cecdec37e286bb#diff-fc44570de4b634df61bd83b639db98d4L51 and where things go wrong is buried a little deeper. https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/streaming/StreamSession.java#L197 [~jasobrown] ^ I think this may be an issue with Netty intracluster streaming and security? Is it going to pick the wrong address just like the bulk loader? I am assuming not because the server loads the YAML and it all works out fine even in an AWS like setup. In 3.0 where this is reported it is https://github.com/apache/cassandra/blob/cassandra-3.0/src/java/org/apache/cassandra/tools/BulkLoadConnectionFactory.java#L51 and it's calling FBUtilities.getLocalAddress() to pick the outbound interface. Looking at the ticket I see connection refused so it's reaching the other node, but the
[jira] [Commented] (CASSANDRA-14407) Transient Replication: Add support for correct reads when transient replication is in use
[ https://issues.apache.org/jira/browse/CASSANDRA-14407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562117#comment-16562117 ] Ariel Weisberg commented on CASSANDRA-14407: Note here, that speculative retry for writes doesn't have a separate config option, it uses the same config as read. We should evaluate if that is a good idea. > Transient Replication: Add support for correct reads when transient > replication is in use > - > > Key: CASSANDRA-14407 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14407 > Project: Cassandra > Issue Type: Sub-task > Components: Coordination >Reporter: Ariel Weisberg >Assignee: Blake Eggleston >Priority: Major > Fix For: 4.0 > > > Digest reads should never be sent to transient replicas. > Mismatches with results from transient replicas shouldn't trigger read repair. > Read repair should never attempt to repair a transient replica. > Reads should always include at least one full replica. They should also > prefer transient replicas where possible. > Range scans must ensure the entire scanned range performs replica selection > that satisfies the requirement that every range scanned includes one full > replica. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14502) toDate() CQL function is instantiated for wrong argument type
[ https://issues.apache.org/jira/browse/CASSANDRA-14502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Lerer updated CASSANDRA-14502: --- Attachment: CASSANDRA-14502.txt Status: Patch Available (was: Open) > toDate() CQL function is instantiated for wrong argument type > - > > Key: CASSANDRA-14502 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14502 > Project: Cassandra > Issue Type: Bug > Components: CQL >Reporter: Piotr Sarna >Assignee: Benjamin Lerer >Priority: Minor > Fix For: 4.x > > Attachments: CASSANDRA-14502.txt > > > {{toDate()}} function is instantiated to work for {{timeuuid}} and {{date}} > types passed as an argument, instead of {{timeuuid}} and {{timestamp}}, as > stated in this documentation: > [http://cassandra.apache.org/doc/latest/cql/functions.html#datetime-functions] > As a result it's possible to convert a {{date}} into {{date}}, but not a > {{timestamp}} into {{date}}, which is probably what was meant. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14599) [dtest] test_functional - global_row_key_cache_test.TestGlobalRowKeyCache
[ https://issues.apache.org/jira/browse/CASSANDRA-14599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson updated CASSANDRA-14599: Resolution: Fixed Status: Resolved (was: Ready to Commit) committed as {{32b53217da060343bcb8dcd272edf46df38d90b7}}, thanks! > [dtest] test_functional - global_row_key_cache_test.TestGlobalRowKeyCache > - > > Key: CASSANDRA-14599 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14599 > Project: Cassandra > Issue Type: Bug > Components: Testing >Reporter: Jason Brown >Assignee: Marcus Eriksson >Priority: Major > Labels: dtest > > dtest fails all the time on 3.0, but not other branches. Error from pytest > output: > {code} > test teardown failure > Unexpected error found in node logs (see stdout for full details). Errors: > [WARN [main] 2018-07-23 18:53:10,075 Uns.java:169 - Failed to load Java8 > implementation ohc-core-j8 : java.lang.NoSuchMethodException: > org.caffinitas.ohc.linked.UnsExt8.(java.lang.Class), WARN [main] > 2018-07-23 18:53:56,966 Uns.java:169 - Failed to load Java8 implementation > ohc-core-j8 : java.lang.NoSuchMethodException: > org.caffinitas.ohc.linked.UnsExt8.(java.lang.Class), WARN [main] > 2018-07-23 18:55:54,508 Uns.java:169 - Failed to load Java8 implementation > ohc-core-j8 : java.lang.NoSuchMethodException: > org.caffinitas.ohc.linked.UnsExt8.(java.lang.Class), WARN [main] > 2018-07-23 18:56:42,688 Uns.java:169 - Failed to load Java8 implementation > ohc-core-j8 : java.lang.NoSuchMethodException: > org.caffinitas.ohc.linked.UnsExt8.(java.lang.Class), WARN [main] > 2018-07-23 18:53:10,075 Uns.java:169 - Failed to load Java8 implementation > ohc-core-j8 : java.lang.NoSuchMethodException: > org.caffinitas.ohc.linked.UnsExt8.(java.lang.Class)] > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14602) [dtest] test_sstableofflinerelevel - offline_tools_test.TestOfflineTools
[ https://issues.apache.org/jira/browse/CASSANDRA-14602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson updated CASSANDRA-14602: Resolution: Fixed Status: Resolved (was: Ready to Commit) committed as {{c13a78c533c9e025c6ea705fc010f67cf2224d55}}, thanks! > [dtest] test_sstableofflinerelevel - offline_tools_test.TestOfflineTools > > > Key: CASSANDRA-14602 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14602 > Project: Cassandra > Issue Type: Bug > Components: Testing >Reporter: Jason Brown >Assignee: Marcus Eriksson >Priority: Minor > Labels: dtest > > consistently failing dtest on 3.0 (no other branches). Output from pytest: > {noformat} > output, _, rc = node1.run_sstableofflinerelevel("keyspace1", > "standard1") > > assert re.search("L0=1", output) > E AssertionError: assert None > E+ where None = ('L0=1', 'New > leveling: \nL0=0\nL1 10\n') > E+where = re.search > offline_tools_test.py:160: AssertionError > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[1/2] cassandra-dtest git commit: Ignore ohc error
Repository: cassandra-dtest Updated Branches: refs/heads/master daa37bfb5 -> c13a78c53 Ignore ohc error Patch by marcuse; reviewed by Jason Brown for CASSANDRA-14599 Project: http://git-wip-us.apache.org/repos/asf/cassandra-dtest/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra-dtest/commit/32b53217 Tree: http://git-wip-us.apache.org/repos/asf/cassandra-dtest/tree/32b53217 Diff: http://git-wip-us.apache.org/repos/asf/cassandra-dtest/diff/32b53217 Branch: refs/heads/master Commit: 32b53217da060343bcb8dcd272edf46df38d90b7 Parents: daa37bf Author: Marcus Eriksson Authored: Fri Jul 27 13:37:52 2018 +0200 Committer: Marcus Eriksson Committed: Mon Jul 30 16:16:20 2018 +0200 -- global_row_key_cache_test.py | 7 +++ 1 file changed, 7 insertions(+) -- http://git-wip-us.apache.org/repos/asf/cassandra-dtest/blob/32b53217/global_row_key_cache_test.py -- diff --git a/global_row_key_cache_test.py b/global_row_key_cache_test.py index 74c67f4..4d2d906 100644 --- a/global_row_key_cache_test.py +++ b/global_row_key_cache_test.py @@ -1,3 +1,4 @@ +import pytest import time import logging @@ -10,6 +11,12 @@ logger = logging.getLogger(__name__) class TestGlobalRowKeyCache(Tester): +@pytest.fixture(autouse=True) +def fixture_add_additional_log_patterns(self, fixture_dtest_setup): +fixture_dtest_setup.ignore_log_patterns = ( +r'Failed to load Java8 implementation ohc-core-j8' +) + def test_functional(self): cluster = self.cluster cluster.populate(3) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[2/2] cassandra-dtest git commit: Make sure we only have one sstable when running offline relevel first time
Make sure we only have one sstable when running offline relevel first time Patch by marcuse; reviewed by Jason Brown for CASSANDRA-14602 Project: http://git-wip-us.apache.org/repos/asf/cassandra-dtest/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra-dtest/commit/c13a78c5 Tree: http://git-wip-us.apache.org/repos/asf/cassandra-dtest/tree/c13a78c5 Diff: http://git-wip-us.apache.org/repos/asf/cassandra-dtest/diff/c13a78c5 Branch: refs/heads/master Commit: c13a78c533c9e025c6ea705fc010f67cf2224d55 Parents: 32b5321 Author: Marcus Eriksson Authored: Fri Jul 27 10:41:53 2018 +0200 Committer: Marcus Eriksson Committed: Mon Jul 30 16:16:54 2018 +0200 -- offline_tools_test.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- http://git-wip-us.apache.org/repos/asf/cassandra-dtest/blob/c13a78c5/offline_tools_test.py -- diff --git a/offline_tools_test.py b/offline_tools_test.py index fce1f5f..2b8b7a3 100644 --- a/offline_tools_test.py +++ b/offline_tools_test.py @@ -146,7 +146,7 @@ class TestOfflineTools(Tester): cluster.start(wait_for_binary_proto=True) session = self.patient_cql_connection(node1) logger.debug("Altering compaction strategy to LCS") -session.execute("ALTER TABLE keyspace1.standard1 with compaction={'class': 'LeveledCompactionStrategy', 'sstable_size_in_mb':1};") +session.execute("ALTER TABLE keyspace1.standard1 with compaction={'class': 'LeveledCompactionStrategy', 'sstable_size_in_mb':1, 'enabled':'false'};") node1.stress(['write', 'n=1K', 'no-warmup', '-schema', 'replication(factor=1)', @@ -161,6 +161,7 @@ class TestOfflineTools(Tester): assert rc == 0, str(rc) cluster.start(wait_for_binary_proto=True) +node1.nodetool('enableautocompaction keyspace1 standard1') # test by loading large amount data so we have multiple sstables # must write enough to create more than just L1 sstables keys = 8 * cluster.data_dir_count - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14600) [dtest] test_system_auth_ks_is_alterable - auth_test.TestAuth
[ https://issues.apache.org/jira/browse/CASSANDRA-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Brown updated CASSANDRA-14600: Status: Ready to Commit (was: Patch Available) > [dtest] test_system_auth_ks_is_alterable - auth_test.TestAuth > - > > Key: CASSANDRA-14600 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14600 > Project: Cassandra > Issue Type: Bug > Components: Testing >Reporter: Jason Brown >Assignee: Jay Zhuang >Priority: Minor > Labels: dtest > > Test 'fails' on 3.0 and 3.11 with this error from pytest: > > {noformat} > test teardown failure > Unexpected error found in node logs (see stdout for full details). Errors: > [ERROR [Native-Transport-Requests-1] 2018-07-23 18:14:34,585 Message.java:629 > - Unexpected exception during request; channel = [id: 0x0ffc99f5, > L:/127.0.0.3:9042 - R:/127.0.0.1:54516] > java.lang.RuntimeException: > org.apache.cassandra.exceptions.UnavailableException: Cannot achieve > consistency level QUORUM > at > org.apache.cassandra.auth.CassandraRoleManager.getRole(CassandraRoleManager.java:518) > ~[main/:na] > at > org.apache.cassandra.auth.CassandraRoleManager.canLogin(CassandraRoleManager.java:312) > ~[main/:na] > at org.apache.cassandra.service.ClientState.login(ClientState.java:281) > ~[main/:na] > at > org.apache.cassandra.transport.messages.AuthResponse.execute(AuthResponse.java:80) > ~[main/:na] > at > org.apache.cassandra.transport.Message$Dispatcher.channelRead0(Message.java:517) > [main/:na] > at > org.apache.cassandra.transport.Message$Dispatcher.channelRead0(Message.java:410) > [main/:na] > at > io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105) > [netty-all-4.0.44.Final.jar:4.0.44.Final] > at > io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:357) > [netty-all-4.0.44.Final.jar:4.0.44.Final] > at > io.netty.channel.AbstractChannelHandlerContext.access$600(AbstractChannelHandlerContext.java:35) > [netty-all-4.0.44.Final.jar:4.0.44.Final] > at > io.netty.channel.AbstractChannelHandlerContext$7.run(AbstractChannelHandlerContext.java:348) > [netty-all-4.0.44.Final.jar:4.0.44.Final] > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) > [na:1.8.0_154-cassandra] > at > org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$FutureTask.run(AbstractLocalAwareExecutorService.java:162) > [main/:na] > at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:109) > [main/:na] > at java.lang.Thread.run(Thread.java:748) [na:1.8.0_154-cassandra] > Caused by: org.apache.cassandra.exceptions.UnavailableException: Cannot > achieve consistency level QUORUM > at > org.apache.cassandra.db.ConsistencyLevel.assureSufficientLiveNodes(ConsistencyLevel.java:334) > ~[main/:na] > at > org.apache.cassandra.service.AbstractReadExecutor.getReadExecutor(AbstractReadExecutor.java:162) > ~[main/:na] > at > org.apache.cassandra.service.StorageProxy$SinglePartitionReadLifecycle.(StorageProxy.java:1779) > ~[main/:na] > at > org.apache.cassandra.service.StorageProxy.fetchRows(StorageProxy.java:1741) > ~[main/:na] > at > org.apache.cassandra.service.StorageProxy.readRegular(StorageProxy.java:1684) > ~[main/:na] > at > org.apache.cassandra.service.StorageProxy.read(StorageProxy.java:1599) > ~[main/:na] > at > org.apache.cassandra.db.SinglePartitionReadCommand$Group.execute(SinglePartitionReadCommand.java:1176) > ~[main/:na] > at > org.apache.cassandra.cql3.statements.SelectStatement.execute(SelectStatement.java:315) > ~[main/:na] > at > org.apache.cassandra.cql3.statements.SelectStatement.execute(SelectStatement.java:285) > ~[main/:na] > at > org.apache.cassandra.auth.CassandraRoleManager.getRoleFromTable(CassandraRoleManager.java:526) > ~[main/:na] > at > org.apache.cassandra.auth.CassandraRoleManager.getRole(CassandraRoleManager.java:508) > ~[main/:na] > ... 13 common frames omitted, ERROR [Native-Transport-Requests-3] > 2018-07-23 18:14:35,759 Message.java:629 - Unexpected exception during > request; channel = [id: 0x3bf15467, L:/127.0.0.3:9042 - R:/127.0.0.1:54528] > {noformat} > Not sure if we need just another log error exclude, or if this is legit. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14600) [dtest] test_system_auth_ks_is_alterable - auth_test.TestAuth
[ https://issues.apache.org/jira/browse/CASSANDRA-14600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16561921#comment-16561921 ] Jason Brown commented on CASSANDRA-14600: - I verified locally, as well, and test passes. +1 > [dtest] test_system_auth_ks_is_alterable - auth_test.TestAuth > - > > Key: CASSANDRA-14600 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14600 > Project: Cassandra > Issue Type: Bug > Components: Testing >Reporter: Jason Brown >Assignee: Jay Zhuang >Priority: Minor > Labels: dtest > > Test 'fails' on 3.0 and 3.11 with this error from pytest: > > {noformat} > test teardown failure > Unexpected error found in node logs (see stdout for full details). Errors: > [ERROR [Native-Transport-Requests-1] 2018-07-23 18:14:34,585 Message.java:629 > - Unexpected exception during request; channel = [id: 0x0ffc99f5, > L:/127.0.0.3:9042 - R:/127.0.0.1:54516] > java.lang.RuntimeException: > org.apache.cassandra.exceptions.UnavailableException: Cannot achieve > consistency level QUORUM > at > org.apache.cassandra.auth.CassandraRoleManager.getRole(CassandraRoleManager.java:518) > ~[main/:na] > at > org.apache.cassandra.auth.CassandraRoleManager.canLogin(CassandraRoleManager.java:312) > ~[main/:na] > at org.apache.cassandra.service.ClientState.login(ClientState.java:281) > ~[main/:na] > at > org.apache.cassandra.transport.messages.AuthResponse.execute(AuthResponse.java:80) > ~[main/:na] > at > org.apache.cassandra.transport.Message$Dispatcher.channelRead0(Message.java:517) > [main/:na] > at > org.apache.cassandra.transport.Message$Dispatcher.channelRead0(Message.java:410) > [main/:na] > at > io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105) > [netty-all-4.0.44.Final.jar:4.0.44.Final] > at > io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:357) > [netty-all-4.0.44.Final.jar:4.0.44.Final] > at > io.netty.channel.AbstractChannelHandlerContext.access$600(AbstractChannelHandlerContext.java:35) > [netty-all-4.0.44.Final.jar:4.0.44.Final] > at > io.netty.channel.AbstractChannelHandlerContext$7.run(AbstractChannelHandlerContext.java:348) > [netty-all-4.0.44.Final.jar:4.0.44.Final] > at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) > [na:1.8.0_154-cassandra] > at > org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$FutureTask.run(AbstractLocalAwareExecutorService.java:162) > [main/:na] > at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:109) > [main/:na] > at java.lang.Thread.run(Thread.java:748) [na:1.8.0_154-cassandra] > Caused by: org.apache.cassandra.exceptions.UnavailableException: Cannot > achieve consistency level QUORUM > at > org.apache.cassandra.db.ConsistencyLevel.assureSufficientLiveNodes(ConsistencyLevel.java:334) > ~[main/:na] > at > org.apache.cassandra.service.AbstractReadExecutor.getReadExecutor(AbstractReadExecutor.java:162) > ~[main/:na] > at > org.apache.cassandra.service.StorageProxy$SinglePartitionReadLifecycle.(StorageProxy.java:1779) > ~[main/:na] > at > org.apache.cassandra.service.StorageProxy.fetchRows(StorageProxy.java:1741) > ~[main/:na] > at > org.apache.cassandra.service.StorageProxy.readRegular(StorageProxy.java:1684) > ~[main/:na] > at > org.apache.cassandra.service.StorageProxy.read(StorageProxy.java:1599) > ~[main/:na] > at > org.apache.cassandra.db.SinglePartitionReadCommand$Group.execute(SinglePartitionReadCommand.java:1176) > ~[main/:na] > at > org.apache.cassandra.cql3.statements.SelectStatement.execute(SelectStatement.java:315) > ~[main/:na] > at > org.apache.cassandra.cql3.statements.SelectStatement.execute(SelectStatement.java:285) > ~[main/:na] > at > org.apache.cassandra.auth.CassandraRoleManager.getRoleFromTable(CassandraRoleManager.java:526) > ~[main/:na] > at > org.apache.cassandra.auth.CassandraRoleManager.getRole(CassandraRoleManager.java:508) > ~[main/:na] > ... 13 common frames omitted, ERROR [Native-Transport-Requests-3] > 2018-07-23 18:14:35,759 Message.java:629 - Unexpected exception during > request; channel = [id: 0x3bf15467, L:/127.0.0.3:9042 - R:/127.0.0.1:54528] > {noformat} > Not sure if we need just another log error exclude, or if this is legit. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-14613) ant generate-idea-files needs update after CASSANDRA-9608
Marcus Eriksson created CASSANDRA-14613: --- Summary: ant generate-idea-files needs update after CASSANDRA-9608 Key: CASSANDRA-14613 URL: https://issues.apache.org/jira/browse/CASSANDRA-14613 Project: Cassandra Issue Type: Bug Reporter: Marcus Eriksson Fix For: 4.x {{ide/idea-iml-file.xml}} looks hard coded to include {{src/java11}} when creating the project, this should probably detect what version we are building for instead cc [~snazy] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14601) [dtest] test_failure_threshold_deletions - paging_test.TestPagingWithDeletions
[ https://issues.apache.org/jira/browse/CASSANDRA-14601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Brown updated CASSANDRA-14601: Status: Ready to Commit (was: Patch Available) > [dtest] test_failure_threshold_deletions - paging_test.TestPagingWithDeletions > -- > > Key: CASSANDRA-14601 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14601 > Project: Cassandra > Issue Type: Bug > Components: Testing >Reporter: Jason Brown >Assignee: Jay Zhuang >Priority: Minor > Labels: dtest > > failing dtest on 3.11 only. Error output from pytest: > {noformat} > except ReadFailure as exc: > if supports_v5_protocol: > > assert exc.error_code_map is not None > E assert None is not None > E+ where None = ReadFailure('Error from server: code=1300 > [Replica(s) failed to execute read] message="Operation failed - received 0 > r...d 2 failures" info={\'consistency\': \'ALL\', \'required_responses\': 2, > \'received_responses\': 0, \'failures\': 2}',).error_code_map > paging_test.py:3447: AssertionError > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14601) [dtest] test_failure_threshold_deletions - paging_test.TestPagingWithDeletions
[ https://issues.apache.org/jira/browse/CASSANDRA-14601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16561863#comment-16561863 ] Jason Brown commented on CASSANDRA-14601: - tested locally and passed multiple times. +1 > [dtest] test_failure_threshold_deletions - paging_test.TestPagingWithDeletions > -- > > Key: CASSANDRA-14601 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14601 > Project: Cassandra > Issue Type: Bug > Components: Testing >Reporter: Jason Brown >Assignee: Jay Zhuang >Priority: Minor > Labels: dtest > > failing dtest on 3.11 only. Error output from pytest: > {noformat} > except ReadFailure as exc: > if supports_v5_protocol: > > assert exc.error_code_map is not None > E assert None is not None > E+ where None = ReadFailure('Error from server: code=1300 > [Replica(s) failed to execute read] message="Operation failed - received 0 > r...d 2 failures" info={\'consistency\': \'ALL\', \'required_responses\': 2, > \'received_responses\': 0, \'failures\': 2}',).error_code_map > paging_test.py:3447: AssertionError > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14612) Please add OWASP Dependency Check to the build (pom.xml)
[ https://issues.apache.org/jira/browse/CASSANDRA-14612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16561835#comment-16561835 ] Jason Brown commented on CASSANDRA-14612: - I'm +1 on the idea here. We can add this to the build.xml (an ant script, not maven or anything else atm) rather simply. Not sure how far back to go with a patch like this, but as it's build-time only, at least 3.0 is fine. [~ABakerIII] If you can put together a patch, I can review. > Please add OWASP Dependency Check to the build (pom.xml) > > > Key: CASSANDRA-14612 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14612 > Project: Cassandra > Issue Type: New Feature > Components: Build, Lifecycle, Observability, Repair, Testing > Environment: All development, build, test, environments. >Reporter: Albert Baker >Priority: Major > Labels: build, easyfix, security > Fix For: 3.11.x, 4.x > > Original Estimate: 1h > Remaining Estimate: 1h > > Please add OWASP Dependency Check to the build (pom.xml). OWASP DC makes an > outbound REST call to MITRE Common Vulnerabilities & Exposures (CVE) to > perform a lookup for each dependant .jar to list any/all known > vulnerabilities for each jar. This step is needed because a manual MITRE CVE > lookup/check on the main component does not include checking for > vulnerabilities in components or in dependant libraries. > OWASP Dependency check : > https://www.owasp.org/index.php/OWASP_Dependency_Check has plug-ins for most > Java build/make types (ant, maven, ivy, gradle). > Also, add the appropriate command to the nightly build to generate a report > of all known vulnerabilities in any/all third party libraries/dependencies > that get pulled in. example : mvn -Powasp -Dtest=false -DfailIfNoTests=false > clean aggregate > Generating this report nightly/weekly will help inform the project's > development team if any dependant libraries have a reported known > vulnerailities. Project teams that keep up with removing vulnerabilities on a > weekly basis will help protect businesses that rely on these open source > componets. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14599) [dtest] test_functional - global_row_key_cache_test.TestGlobalRowKeyCache
[ https://issues.apache.org/jira/browse/CASSANDRA-14599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Brown updated CASSANDRA-14599: Status: Ready to Commit (was: Patch Available) > [dtest] test_functional - global_row_key_cache_test.TestGlobalRowKeyCache > - > > Key: CASSANDRA-14599 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14599 > Project: Cassandra > Issue Type: Bug > Components: Testing >Reporter: Jason Brown >Assignee: Marcus Eriksson >Priority: Major > Labels: dtest > > dtest fails all the time on 3.0, but not other branches. Error from pytest > output: > {code} > test teardown failure > Unexpected error found in node logs (see stdout for full details). Errors: > [WARN [main] 2018-07-23 18:53:10,075 Uns.java:169 - Failed to load Java8 > implementation ohc-core-j8 : java.lang.NoSuchMethodException: > org.caffinitas.ohc.linked.UnsExt8.(java.lang.Class), WARN [main] > 2018-07-23 18:53:56,966 Uns.java:169 - Failed to load Java8 implementation > ohc-core-j8 : java.lang.NoSuchMethodException: > org.caffinitas.ohc.linked.UnsExt8.(java.lang.Class), WARN [main] > 2018-07-23 18:55:54,508 Uns.java:169 - Failed to load Java8 implementation > ohc-core-j8 : java.lang.NoSuchMethodException: > org.caffinitas.ohc.linked.UnsExt8.(java.lang.Class), WARN [main] > 2018-07-23 18:56:42,688 Uns.java:169 - Failed to load Java8 implementation > ohc-core-j8 : java.lang.NoSuchMethodException: > org.caffinitas.ohc.linked.UnsExt8.(java.lang.Class), WARN [main] > 2018-07-23 18:53:10,075 Uns.java:169 - Failed to load Java8 implementation > ohc-core-j8 : java.lang.NoSuchMethodException: > org.caffinitas.ohc.linked.UnsExt8.(java.lang.Class)] > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14599) [dtest] test_functional - global_row_key_cache_test.TestGlobalRowKeyCache
[ https://issues.apache.org/jira/browse/CASSANDRA-14599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16561824#comment-16561824 ] Jason Brown commented on CASSANDRA-14599: - +1 to [~krummas]'s patch. Also, I'm -1 on upgrading OHC so late into 3.0's lifecycle - unless, of course, there's some CVE or other security/stability problem > [dtest] test_functional - global_row_key_cache_test.TestGlobalRowKeyCache > - > > Key: CASSANDRA-14599 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14599 > Project: Cassandra > Issue Type: Bug > Components: Testing >Reporter: Jason Brown >Assignee: Marcus Eriksson >Priority: Major > Labels: dtest > > dtest fails all the time on 3.0, but not other branches. Error from pytest > output: > {code} > test teardown failure > Unexpected error found in node logs (see stdout for full details). Errors: > [WARN [main] 2018-07-23 18:53:10,075 Uns.java:169 - Failed to load Java8 > implementation ohc-core-j8 : java.lang.NoSuchMethodException: > org.caffinitas.ohc.linked.UnsExt8.(java.lang.Class), WARN [main] > 2018-07-23 18:53:56,966 Uns.java:169 - Failed to load Java8 implementation > ohc-core-j8 : java.lang.NoSuchMethodException: > org.caffinitas.ohc.linked.UnsExt8.(java.lang.Class), WARN [main] > 2018-07-23 18:55:54,508 Uns.java:169 - Failed to load Java8 implementation > ohc-core-j8 : java.lang.NoSuchMethodException: > org.caffinitas.ohc.linked.UnsExt8.(java.lang.Class), WARN [main] > 2018-07-23 18:56:42,688 Uns.java:169 - Failed to load Java8 implementation > ohc-core-j8 : java.lang.NoSuchMethodException: > org.caffinitas.ohc.linked.UnsExt8.(java.lang.Class), WARN [main] > 2018-07-23 18:53:10,075 Uns.java:169 - Failed to load Java8 implementation > ohc-core-j8 : java.lang.NoSuchMethodException: > org.caffinitas.ohc.linked.UnsExt8.(java.lang.Class)] > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14603) [dtest] read_repair_test.TestReadRepair
[ https://issues.apache.org/jira/browse/CASSANDRA-14603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Tunnicliffe updated CASSANDRA-14603: Resolution: Fixed Fix Version/s: (was: 3.0.x) (was: 2.2.x) 3.0.17 2.2.13 Status: Resolved (was: Ready to Commit) Thanks, committed to cassandra-dtest in [daa37bf|https://github.com/apache/cassandra-dtest/commit/daa37bfb56fbcf627abc7179fd5924af08bac429] > [dtest] read_repair_test.TestReadRepair > --- > > Key: CASSANDRA-14603 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14603 > Project: Cassandra > Issue Type: Bug > Components: Testing >Reporter: Jason Brown >Assignee: Sam Tunnicliffe >Priority: Major > Labels: dtest > Fix For: 2.2.13, 3.0.17 > > > tests {{test_alter_rf_and_run_read_repair}} and {{test_read_repair_chance}} > consistently fail on 3.0; the latter also fails on 2.2. I suspect it's the > same cause, as the output from pytest shows the same error in the same shared > function ({{check_data_on_each_replica}}): > {noformat} > res = rows_to_list(session.execute(stmt)) > logger.debug("Actual result: " + str(res)) > expected = [[1, 1, 1]] if expect_fully_repaired or n == > initial_replica else [[1, 1, None]] > if res != expected: > > raise NotRepairedException() > E read_repair_test.NotRepairedException > read_repair_test.py:204: NotRepairedException > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
cassandra-dtest git commit: Only expect value skipping during reads from 3.4+
Repository: cassandra-dtest Updated Branches: refs/heads/master bed040c54 -> daa37bfb5 Only expect value skipping during reads from 3.4+ Patch by Sam Tunnicliffe; reviewed by Jason Brown for CASSANDRA-14603 Project: http://git-wip-us.apache.org/repos/asf/cassandra-dtest/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra-dtest/commit/daa37bfb Tree: http://git-wip-us.apache.org/repos/asf/cassandra-dtest/tree/daa37bfb Diff: http://git-wip-us.apache.org/repos/asf/cassandra-dtest/diff/daa37bfb Branch: refs/heads/master Commit: daa37bfb56fbcf627abc7179fd5924af08bac429 Parents: bed040c Author: Sam Tunnicliffe Authored: Fri Jul 27 14:17:49 2018 +0100 Committer: Sam Tunnicliffe Committed: Mon Jul 30 09:21:28 2018 +0100 -- read_repair_test.py | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) -- http://git-wip-us.apache.org/repos/asf/cassandra-dtest/blob/daa37bfb/read_repair_test.py -- diff --git a/read_repair_test.py b/read_repair_test.py index b6bfc37..175e19e 100644 --- a/read_repair_test.py +++ b/read_repair_test.py @@ -58,7 +58,8 @@ class TestReadRepair(Tester): # The read repair should have repaired the replicas, at least partially (see CASSANDRA-10655) # verify by querying each replica in turn. -self.check_data_on_each_replica(expect_fully_repaired=False, initial_replica=initial_replica) +value_skipping_disabled = True if self.cluster.version() < '3.4' else False + self.check_data_on_each_replica(expect_fully_repaired=value_skipping_disabled, initial_replica=initial_replica) # Now query again at CL.ALL but this time selecting all columns, which should ensure that 'b' also gets repaired query = "SELECT * FROM alter_rf_test.t1 WHERE k=1" @@ -92,14 +93,16 @@ class TestReadRepair(Tester): consistency_level=ConsistencyLevel.ONE)) # Query each replica individually to ensure that read repair was triggered. We should expect that only -# the initial replica has data for both the 'a' and 'b' columns. The read repair should only have affected -# the selected column, so the other two replicas should only have that data. +# the initial replica has data for both the 'a' and 'b' columns. If the cluster is on > 3.4, the read repair +# should only have affected the selected column (CASSANDRA-10655), so the other two replicas should only have +# that data. # Note: we need to temporarily set read_repair_chance to 0 while we perform this check. logger.debug("Setting table read repair chance to 0 while we verify each replica's data") session.execute("""ALTER TABLE alter_rf_test.t1 WITH read_repair_chance = 0;""") # The read repair is run in the background, so we spin while checking that the repair has completed +value_skipping_disabled = True if self.cluster.version() < '3.4' else False retry_till_success(self.check_data_on_each_replica, - expect_fully_repaired=False, + expect_fully_repaired=value_skipping_disabled, initial_replica=initial_replica, timeout=30, bypassed_exception=NotRepairedException) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org