[jira] [Commented] (CASSANDRA-15104) Dtest change python2 grammar to python3
[ https://issues.apache.org/jira/browse/CASSANDRA-15104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826660#comment-16826660 ] Dinesh Joshi commented on CASSANDRA-15104: -- Hi [~maxwellguo], are you talking about this tests in this repo? https://github.com/apache/cassandra-dtest They're already compatible with Python 3. > Dtest change python2 grammar to python3 > > > Key: CASSANDRA-15104 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15104 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest >Reporter: maxwellguo >Assignee: maxwellguo >Priority: Normal > > We know that for some code are written in python2, such as dtest.py (line > :91) , and some major version of python2 will be dropped. So if it is nessary > to change some of the code to python3 style ? -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15104) Dtest change python2 grammar to python3
[ https://issues.apache.org/jira/browse/CASSANDRA-15104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826628#comment-16826628 ] maxwellguo commented on CASSANDRA-15104: [~bdeggleston] [~jay.zhuang] , do you think if it is needed to do this thing ? I am looking forward for your reply. > Dtest change python2 grammar to python3 > > > Key: CASSANDRA-15104 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15104 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest >Reporter: maxwellguo >Assignee: maxwellguo >Priority: Normal > > We know that for some code are written in python2, such as dtest.py (line > :91) , and some major version of python2 will be dropped. So if it is nessary > to change some of the code to python3 style ? -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15104) Dtest change python2 grammar to python3
maxwellguo created CASSANDRA-15104: -- Summary: Dtest change python2 grammar to python3 Key: CASSANDRA-15104 URL: https://issues.apache.org/jira/browse/CASSANDRA-15104 Project: Cassandra Issue Type: Improvement Components: Test/dtest Reporter: maxwellguo Assignee: maxwellguo We know that for some code are written in python2, such as dtest.py (line :91) , and some major version of python2 will be dropped. So if it is nessary to change some of the code to python3 style ? -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-2.2' into cassandra-3.0
This is an automated email from the ASF dual-hosted git repository. bdeggleston pushed a commit to branch cassandra-3.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit e7492d3114252ee7d106af61d5c44627b46e545a Merge: c3ce32e 5275141 Author: Blake Eggleston AuthorDate: Thu Apr 25 15:20:27 2019 -0700 Merge branch 'cassandra-2.2' into cassandra-3.0 .../org/apache/cassandra/distributed/impl/AbstractCluster.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-2.2 updated: ninja: fix CASSANDRA-15078 NPE
This is an automated email from the ASF dual-hosted git repository.
bdeggleston pushed a commit to branch cassandra-2.2
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-2.2 by this push:
new 5275141 ninja: fix CASSANDRA-15078 NPE
5275141 is described below
commit 527514109469b925ee310abf06848c8eb484da13
Author: Blake Eggleston
AuthorDate: Thu Apr 25 15:18:07 2019 -0700
ninja: fix CASSANDRA-15078 NPE
---
.../org/apache/cassandra/distributed/impl/AbstractCluster.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/test/distributed/org/apache/cassandra/distributed/impl/AbstractCluster.java
b/test/distributed/org/apache/cassandra/distributed/impl/AbstractCluster.java
index 1dc7a65..c27d9bf 100644
---
a/test/distributed/org/apache/cassandra/distributed/impl/AbstractCluster.java
+++
b/test/distributed/org/apache/cassandra/distributed/impl/AbstractCluster.java
@@ -141,7 +141,7 @@ public abstract class AbstractCluster
implements ICluster,
{
if (!isShutdown)
throw new IllegalStateException();
-delegate.startup(AbstractCluster.this);
+delegate().startup(AbstractCluster.this);
isShutdown = false;
updateMessagingVersions();
}
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.0 updated (c3ce32e -> e7492d3)
This is an automated email from the ASF dual-hosted git repository. bdeggleston pushed a change to branch cassandra-3.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from c3ce32e Fix assorted gossip races and add related runtime checks new 5275141 ninja: fix CASSANDRA-15078 NPE new e7492d3 Merge branch 'cassandra-2.2' into cassandra-3.0 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../org/apache/cassandra/distributed/impl/AbstractCluster.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (587961a -> b0bb339)
This is an automated email from the ASF dual-hosted git repository. bdeggleston pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 587961a Merge branch 'cassandra-3.11' into trunk new 5275141 ninja: fix CASSANDRA-15078 NPE new e7492d3 Merge branch 'cassandra-2.2' into cassandra-3.0 new c86f9b8 Merge branch 'cassandra-3.0' into cassandra-3.11 new b0bb339 Merge branch 'cassandra-3.11' into trunk The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../org/apache/cassandra/distributed/impl/AbstractCluster.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.11 updated (01d6548 -> c86f9b8)
This is an automated email from the ASF dual-hosted git repository. bdeggleston pushed a change to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 01d6548 Merge branch 'cassandra-3.0' into cassandra-3.11 new 5275141 ninja: fix CASSANDRA-15078 NPE new e7492d3 Merge branch 'cassandra-2.2' into cassandra-3.0 new c86f9b8 Merge branch 'cassandra-3.0' into cassandra-3.11 The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../org/apache/cassandra/distributed/impl/AbstractCluster.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.0' into cassandra-3.11
This is an automated email from the ASF dual-hosted git repository. bdeggleston pushed a commit to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit c86f9b8a552c8417a142e2e571464f56ac72a51f Merge: 01d6548 e7492d3 Author: Blake Eggleston AuthorDate: Thu Apr 25 15:22:17 2019 -0700 Merge branch 'cassandra-3.0' into cassandra-3.11 .../org/apache/cassandra/distributed/impl/AbstractCluster.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.11' into trunk
This is an automated email from the ASF dual-hosted git repository. bdeggleston pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit b0bb3393666a6a0b934815431697b9fb1a1927b7 Merge: 587961a c86f9b8 Author: Blake Eggleston AuthorDate: Thu Apr 25 15:25:37 2019 -0700 Merge branch 'cassandra-3.11' into trunk .../org/apache/cassandra/distributed/impl/AbstractCluster.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15066) Improvements to Internode Messaging
[
https://issues.apache.org/jira/browse/CASSANDRA-15066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826475#comment-16826475
]
Benedict commented on CASSANDRA-15066:
--
For those interested, real-time adhoc coordination of the testing work for this
ticket, as part of CASSANDRA-14746, is taking place on freenode IRC at
#cass-messaging-testing. This is to facilitate more rapid responses to
questions of note to those performing the work, _not_ to make decisions or set
direction for this ticket or work. The results of all tests will be promptly
reported back to this ticket, CASSANDRA-14746 or one of its children -
whichever is most appropriate.
> Improvements to Internode Messaging
> ---
>
> Key: CASSANDRA-15066
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15066
> Project: Cassandra
> Issue Type: Improvement
> Components: Messaging/Internode
>Reporter: Benedict
>Assignee: Benedict
>Priority: High
> Fix For: 4.0
>
>
> CASSANDRA-8457 introduced asynchronous networking to internode messaging, but
> there have been several follow-up endeavours to improve some semantic issues.
> CASSANDRA-14503 and CASSANDRA-13630 are the latest such efforts, and were
> combined some months ago into a single overarching refactor of the original
> work, to address some of the issues that have been discovered. Given the
> criticality of this work to the project, we wanted to bring some more eyes to
> bear to ensure the release goes ahead smoothly. In doing so, we uncovered a
> number of issues with messaging, some of which long standing, that we felt
> needed to be addressed. This patch widens the scope of CASSANDRA-14503 and
> CASSANDRA-13630 in an effort to close the book on the messaging service, at
> least for the foreseeable future.
> The patch includes a number of clarifying refactors that touch outside of the
> {{net.async}} package, and a number of semantic changes to the {{net.async}}
> packages itself. We believe it clarifies the intent and behaviour of the
> code while improving system stability, which we will outline in comments
> below.
> https://github.com/belliottsmith/cassandra/tree/messaging-improvements
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-15102) Add Architecture Overview Documentation
[ https://issues.apache.org/jira/browse/CASSANDRA-15102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shane Lester reassigned CASSANDRA-15102: Assignee: Shane Lester > Add Architecture Overview Documentation > --- > > Key: CASSANDRA-15102 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15102 > Project: Cassandra > Issue Type: Task >Reporter: Elijah Augustin >Assignee: Shane Lester >Priority: Normal > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-15103) Add Failure Detection Documentation
[ https://issues.apache.org/jira/browse/CASSANDRA-15103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elijah Augustin reassigned CASSANDRA-15103: --- Assignee: Elijah Augustin > Add Failure Detection Documentation > --- > > Key: CASSANDRA-15103 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15103 > Project: Cassandra > Issue Type: Task >Reporter: Elijah Augustin >Assignee: Elijah Augustin >Priority: Normal > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15103) Add Failure Detection Documentation
Elijah Augustin created CASSANDRA-15103: --- Summary: Add Failure Detection Documentation Key: CASSANDRA-15103 URL: https://issues.apache.org/jira/browse/CASSANDRA-15103 Project: Cassandra Issue Type: Task Reporter: Elijah Augustin -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15102) Add Architecture Overview Documentation
Elijah Augustin created CASSANDRA-15102: --- Summary: Add Architecture Overview Documentation Key: CASSANDRA-15102 URL: https://issues.apache.org/jira/browse/CASSANDRA-15102 Project: Cassandra Issue Type: Task Reporter: Elijah Augustin -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15059) Gossiper#markAlive can race with Gossiper#markDead
[ https://issues.apache.org/jira/browse/CASSANDRA-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Eggleston updated CASSANDRA-15059: Fix Version/s: 4.0 3.11.5 3.0.19 Since Version: 3.0.0 Status: Resolved (was: Ready to Commit) Resolution: Fixed Committed to 3.0 as [c3ce32e239b1ba41faf1d58a942465b9bf45b986|https://github.com/apache/cassandra/commit/c3ce32e239b1ba41faf1d58a942465b9bf45b986] and merged up. Thanks! > Gossiper#markAlive can race with Gossiper#markDead > -- > > Key: CASSANDRA-15059 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15059 > Project: Cassandra > Issue Type: Bug > Components: Cluster/Gossip >Reporter: Blake Eggleston >Assignee: Blake Eggleston >Priority: Normal > Fix For: 3.0.19, 3.11.5, 4.0 > > > The Gossiper class is not threadsafe and assumes all state changes happen in > a single thread (the gossip stage). Gossiper#convict, however, can be called > from the GossipTasks thread. This creates a race where calls to > Gossiper#markAlive and Gossiper#markDead can interleave, corrupting gossip > state. Gossiper#assassinateEndpoint has a similar problem, being called from > the mbean server thread. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15059) Gossiper#markAlive can race with Gossiper#markDead
[ https://issues.apache.org/jira/browse/CASSANDRA-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Eggleston updated CASSANDRA-15059: Reviewers: Ariel Weisberg (was: Ariel Weisberg, Jordan West) Status: Review In Progress (was: Patch Available) > Gossiper#markAlive can race with Gossiper#markDead > -- > > Key: CASSANDRA-15059 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15059 > Project: Cassandra > Issue Type: Bug > Components: Cluster/Gossip >Reporter: Blake Eggleston >Assignee: Blake Eggleston >Priority: Normal > > The Gossiper class is not threadsafe and assumes all state changes happen in > a single thread (the gossip stage). Gossiper#convict, however, can be called > from the GossipTasks thread. This creates a race where calls to > Gossiper#markAlive and Gossiper#markDead can interleave, corrupting gossip > state. Gossiper#assassinateEndpoint has a similar problem, being called from > the mbean server thread. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15059) Gossiper#markAlive can race with Gossiper#markDead
[ https://issues.apache.org/jira/browse/CASSANDRA-15059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Eggleston updated CASSANDRA-15059: Status: Ready to Commit (was: Review In Progress) > Gossiper#markAlive can race with Gossiper#markDead > -- > > Key: CASSANDRA-15059 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15059 > Project: Cassandra > Issue Type: Bug > Components: Cluster/Gossip >Reporter: Blake Eggleston >Assignee: Blake Eggleston >Priority: Normal > > The Gossiper class is not threadsafe and assumes all state changes happen in > a single thread (the gossip stage). Gossiper#convict, however, can be called > from the GossipTasks thread. This creates a race where calls to > Gossiper#markAlive and Gossiper#markDead can interleave, corrupting gossip > state. Gossiper#assassinateEndpoint has a similar problem, being called from > the mbean server thread. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.0 updated: Fix assorted gossip races and add related runtime checks
This is an automated email from the ASF dual-hosted git repository.
bdeggleston pushed a commit to branch cassandra-3.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-3.0 by this push:
new c3ce32e Fix assorted gossip races and add related runtime checks
c3ce32e is described below
commit c3ce32e239b1ba41faf1d58a942465b9bf45b986
Author: Blake Eggleston
AuthorDate: Thu Mar 21 13:01:49 2019 -0700
Fix assorted gossip races and add related runtime checks
Patch by Blake Eggleston; Reviewed by Ariel Weisberg for CASSANDRA-15059
---
CHANGES.txt| 1 +
build.xml | 1 +
ide/idea/workspace.xml | 2 +-
.../cassandra/config/DatabaseDescriptor.java | 8 +
src/java/org/apache/cassandra/gms/Gossiper.java| 192 +++--
.../apache/cassandra/service/StorageService.java | 10 +-
.../cassandra/distributed/impl/Instance.java | 21 ++-
.../org/apache/cassandra/gms/GossiperTest.java | 1 +
.../gms/PendingRangeCalculatorServiceTest.java | 1 +
.../cassandra/locator/CloudstackSnitchTest.java| 1 +
.../apache/cassandra/locator/EC2SnitchTest.java| 1 +
.../cassandra/locator/GoogleCloudSnitchTest.java | 1 +
.../cassandra/locator/PropertyFileSnitchTest.java | 1 +
13 files changed, 170 insertions(+), 71 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index 4f76c70..596d902 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
3.0.19
+ * Fix assorted gossip races and add related runtime checks (CASSANDRA-15059)
* Fix mixed mode partition range scans with limit (CASSANDRA-15072)
* cassandra-stress works with frozen collections: list and set
(CASSANDRA-14907)
* For nodetool listsnapshots output, put spaces between columns, and increase
snapshot padding (CASSANDRA-14876)
diff --git a/build.xml b/build.xml
index 593b1c3..8ef8c67 100644
--- a/build.xml
+++ b/build.xml
@@ -1224,6 +1224,7 @@
+
diff --git a/ide/idea/workspace.xml b/ide/idea/workspace.xml
index e632b5f..3424af3 100644
--- a/ide/idea/workspace.xml
+++ b/ide/idea/workspace.xml
@@ -168,7 +168,7 @@
-
+
diff --git a/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
index 8f4b338..db55c20 100644
--- a/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
+++ b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
@@ -106,6 +106,9 @@ public class DatabaseDescriptor
private static boolean daemonInitialized;
+// turns some warnings into exceptions for testing
+private static final boolean strictRuntimeChecks =
Boolean.getBoolean("cassandra.strict.runtime.checks");
+
public static boolean isDaemonInitialized()
{
return daemonInitialized;
@@ -2105,4 +2108,9 @@ public class DatabaseDescriptor
{
return conf.gc_warn_threshold_in_ms;
}
+
+public static boolean strictRuntimeChecks()
+{
+return strictRuntimeChecks;
+}
}
diff --git a/src/java/org/apache/cassandra/gms/Gossiper.java
b/src/java/org/apache/cassandra/gms/Gossiper.java
index 59b366a..4ea0a4a 100644
--- a/src/java/org/apache/cassandra/gms/Gossiper.java
+++ b/src/java/org/apache/cassandra/gms/Gossiper.java
@@ -25,11 +25,15 @@ import java.util.concurrent.*;
import java.util.concurrent.locks.ReentrantLock;
import com.google.common.annotations.VisibleForTesting;
+import com.google.common.base.Throwables;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableMap;
+import com.google.common.util.concurrent.ListenableFutureTask;
import com.google.common.util.concurrent.Uninterruptibles;
+import io.netty.util.concurrent.FastThreadLocal;
import org.apache.cassandra.utils.MBeanWrapper;
+import org.apache.cassandra.utils.NoSpamLogger;
import org.apache.cassandra.utils.Pair;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@@ -59,11 +63,17 @@ import org.apache.cassandra.utils.JVMStabilityInspector;
* of the three above mentioned messages updates the Failure Detector with the
liveness information.
* Upon hearing a GossipShutdownMessage, this module will instantly mark the
remote node as down in
* the Failure Detector.
+ *
+ * This class is not threadsafe and any state changes should happen in the
gossip stage.
*/
public class Gossiper implements IFailureDetectionEventListener, GossiperMBean
{
public static final String MBEAN_NAME =
"org.apache.cassandra.net:type=Gossiper";
+public static class Props
+{
+public static final String DISABLE_THREAD_VALIDATION =
"cassandra.gossip.disable_thread_validation";
+}
private static final
[cassandra] 01/01: Merge branch 'cassandra-3.11' into trunk
This is an automated email from the ASF dual-hosted git repository.
bdeggleston pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit 587961a19c493efe6b9b065d47416aa4b62cc60a
Merge: 79766f7 01d6548
Author: Blake Eggleston
AuthorDate: Thu Apr 25 10:23:11 2019 -0700
Merge branch 'cassandra-3.11' into trunk
CHANGES.txt| 1 +
build.xml | 1 +
ide/idea/workspace.xml | 2 +-
.../cassandra/config/DatabaseDescriptor.java | 8 +
src/java/org/apache/cassandra/gms/Gossiper.java| 201 ++---
.../apache/cassandra/service/StorageService.java | 10 +-
.../cassandra/distributed/impl/Instance.java | 26 +--
.../org/apache/cassandra/gms/GossiperTest.java | 1 +
.../gms/PendingRangeCalculatorServiceTest.java | 1 +
.../cassandra/locator/CloudstackSnitchTest.java| 1 +
.../apache/cassandra/locator/EC2SnitchTest.java| 1 +
.../cassandra/locator/GoogleCloudSnitchTest.java | 1 +
.../cassandra/locator/PropertyFileSnitchTest.java | 1 +
.../net/StartupClusterConnectivityCheckerTest.java | 2 +-
.../service/StorageServiceServerTest.java | 1 +
15 files changed, 179 insertions(+), 79 deletions(-)
diff --cc CHANGES.txt
index 28eb042,0506da7..54ffe5b
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -360,6 -2,8 +360,7 @@@
* Fixed nodetool cfstats printing index name twice (CASSANDRA-14903)
* Add flag to disable SASI indexes, and warnings on creation
(CASSANDRA-14866)
Merged from 3.0:
+ * Fix assorted gossip races and add related runtime checks (CASSANDRA-15059)
- * Fix mixed mode partition range scans with limit (CASSANDRA-15072)
* cassandra-stress works with frozen collections: list and set
(CASSANDRA-14907)
* Fix handling FS errors on writing and reading flat files - LogTransaction
and hints (CASSANDRA-15053)
* Avoid double closing the iterator to avoid overcounting the number of
requests (CASSANDRA-15058)
diff --cc build.xml
index 3a8dd6c,db97d05..4b23a25
--- a/build.xml
+++ b/build.xml
@@@ -1334,12 -1274,8 +1334,13 @@@
-
-
++
+
+
+
+
diff --cc ide/idea/workspace.xml
index 150f1a0,8d1b0fc..378997b
--- a/ide/idea/workspace.xml
+++ b/ide/idea/workspace.xml
@@@ -167,7 -167,7 +167,7 @@@
-
++
diff --cc src/java/org/apache/cassandra/config/DatabaseDescriptor.java
index e5fe772,e452830..e2c2ace
--- a/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
+++ b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
@@@ -2690,121 -2533,8 +2693,126 @@@ public class DatabaseDescripto
return backPressureStrategy;
}
+public static ConsistencyLevel getIdealConsistencyLevel()
+{
+return conf.ideal_consistency_level;
+}
+
+public static void setIdealConsistencyLevel(ConsistencyLevel cl)
+{
+conf.ideal_consistency_level = cl;
+}
+
+public static int getRepairCommandPoolSize()
+{
+return conf.repair_command_pool_size;
+}
+
+public static Config.RepairCommandPoolFullStrategy
getRepairCommandPoolFullStrategy()
+{
+return conf.repair_command_pool_full_strategy;
+}
+
+public static FullQueryLoggerOptions getFullQueryLogOptions()
+{
+return conf.full_query_logging_options;
+}
+
+public static boolean getBlockForPeersInRemoteDatacenters()
+{
+return conf.block_for_peers_in_remote_dcs;
+}
+
+public static int getBlockForPeersTimeoutInSeconds()
+{
+return conf.block_for_peers_timeout_in_secs;
+}
+
+public static boolean automaticSSTableUpgrade()
+{
+return conf.automatic_sstable_upgrade;
+}
+
+public static void setAutomaticSSTableUpgradeEnabled(boolean enabled)
+{
+if (conf.automatic_sstable_upgrade != enabled)
+logger.debug("Changing automatic_sstable_upgrade to {}", enabled);
+conf.automatic_sstable_upgrade = enabled;
+}
+
+public static int maxConcurrentAutoUpgradeTasks()
+{
+return conf.max_concurrent_automatic_sstable_upgrades;
+}
+
+public static void setMaxConcurrentAutoUpgradeTasks(int value)
+{
+if (conf.max_concurrent_automatic_sstable_upgrades != value)
+logger.debug("Changing max_concurrent_automatic_sstable_upgrades
to {}", value);
+validateMaxConcurrentAutoUpgradeTasksConf(value);
+conf.max_concurrent_automatic_sstable_upgrades = value;
+}
+
+private static void validateMaxConcurrentAutoUpgradeTasksConf(int value)
+{
+if (value < 0)
+throw new
[cassandra] branch cassandra-3.11 updated (839fc7e -> 01d6548)
This is an automated email from the ASF dual-hosted git repository. bdeggleston pushed a change to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 839fc7e Merge branch 'cassandra-3.0' into cassandra-3.11 new c3ce32e Fix assorted gossip races and add related runtime checks new 01d6548 Merge branch 'cassandra-3.0' into cassandra-3.11 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + build.xml | 1 + ide/idea/workspace.xml | 2 +- .../cassandra/config/DatabaseDescriptor.java | 8 + src/java/org/apache/cassandra/gms/Gossiper.java| 192 +++-- .../apache/cassandra/service/StorageService.java | 10 +- .../cassandra/distributed/impl/Instance.java | 20 ++- .../org/apache/cassandra/gms/GossiperTest.java | 1 + .../gms/PendingRangeCalculatorServiceTest.java | 1 + .../cassandra/locator/CloudstackSnitchTest.java| 1 + .../apache/cassandra/locator/EC2SnitchTest.java| 1 + .../cassandra/locator/GoogleCloudSnitchTest.java | 1 + .../cassandra/locator/PropertyFileSnitchTest.java | 1 + 13 files changed, 170 insertions(+), 70 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (79766f7 -> 587961a)
This is an automated email from the ASF dual-hosted git repository. bdeggleston pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 79766f7 Merge branch 'cassandra-3.11' into trunk new c3ce32e Fix assorted gossip races and add related runtime checks new 01d6548 Merge branch 'cassandra-3.0' into cassandra-3.11 new 587961a Merge branch 'cassandra-3.11' into trunk The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + build.xml | 1 + ide/idea/workspace.xml | 2 +- .../cassandra/config/DatabaseDescriptor.java | 8 + src/java/org/apache/cassandra/gms/Gossiper.java| 201 ++--- .../apache/cassandra/service/StorageService.java | 10 +- .../cassandra/distributed/impl/Instance.java | 26 +-- .../org/apache/cassandra/gms/GossiperTest.java | 1 + .../gms/PendingRangeCalculatorServiceTest.java | 1 + .../cassandra/locator/CloudstackSnitchTest.java| 1 + .../apache/cassandra/locator/EC2SnitchTest.java| 1 + .../cassandra/locator/GoogleCloudSnitchTest.java | 1 + .../cassandra/locator/PropertyFileSnitchTest.java | 1 + .../net/StartupClusterConnectivityCheckerTest.java | 2 +- .../service/StorageServiceServerTest.java | 1 + 15 files changed, 179 insertions(+), 79 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.0' into cassandra-3.11
This is an automated email from the ASF dual-hosted git repository.
bdeggleston pushed a commit to branch cassandra-3.11
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit 01d6548e0dec465c01df4248e1d740c51710a36b
Merge: 839fc7e c3ce32e
Author: Blake Eggleston
AuthorDate: Thu Apr 25 10:21:22 2019 -0700
Merge branch 'cassandra-3.0' into cassandra-3.11
CHANGES.txt| 1 +
build.xml | 1 +
ide/idea/workspace.xml | 2 +-
.../cassandra/config/DatabaseDescriptor.java | 8 +
src/java/org/apache/cassandra/gms/Gossiper.java| 192 +++--
.../apache/cassandra/service/StorageService.java | 10 +-
.../cassandra/distributed/impl/Instance.java | 20 ++-
.../org/apache/cassandra/gms/GossiperTest.java | 1 +
.../gms/PendingRangeCalculatorServiceTest.java | 1 +
.../cassandra/locator/CloudstackSnitchTest.java| 1 +
.../apache/cassandra/locator/EC2SnitchTest.java| 1 +
.../cassandra/locator/GoogleCloudSnitchTest.java | 1 +
.../cassandra/locator/PropertyFileSnitchTest.java | 1 +
13 files changed, 170 insertions(+), 70 deletions(-)
diff --cc CHANGES.txt
index 9ce2972,596d902..0506da7
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,9 -1,8 +1,10 @@@
-3.0.19
+3.11.5
+ * Fixed nodetool cfstats printing index name twice (CASSANDRA-14903)
+ * Add flag to disable SASI indexes, and warnings on creation
(CASSANDRA-14866)
+Merged from 3.0:
+ * Fix assorted gossip races and add related runtime checks (CASSANDRA-15059)
* Fix mixed mode partition range scans with limit (CASSANDRA-15072)
* cassandra-stress works with frozen collections: list and set
(CASSANDRA-14907)
- * For nodetool listsnapshots output, put spaces between columns, and
increase snapshot padding (CASSANDRA-14876)
* Fix handling FS errors on writing and reading flat files - LogTransaction
and hints (CASSANDRA-15053)
* Avoid double closing the iterator to avoid overcounting the number of
requests (CASSANDRA-15058)
* Improve `nodetool status -r` speed (CASSANDRA-14847)
diff --cc ide/idea/workspace.xml
index a7c991e,3424af3..8d1b0fc
--- a/ide/idea/workspace.xml
+++ b/ide/idea/workspace.xml
@@@ -167,7 -168,7 +167,7 @@@
-
-
++
diff --cc src/java/org/apache/cassandra/config/DatabaseDescriptor.java
index 99f8575,db55c20..e452830
--- a/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
+++ b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
@@@ -112,153 -102,46 +112,156 @@@ public class DatabaseDescripto
private static String localDC;
private static Comparator localComparator;
+private static EncryptionContext encryptionContext;
private static boolean hasLoggedConfig;
+private static BackPressureStrategy backPressureStrategy;
+private static DiskOptimizationStrategy diskOptimizationStrategy;
+
+private static boolean clientInitialized;
+private static boolean toolInitialized;
private static boolean daemonInitialized;
+private static final int searchConcurrencyFactor =
Integer.parseInt(System.getProperty(Config.PROPERTY_PREFIX +
"search_concurrency_factor", "1"));
+
+private static final boolean disableSTCSInL0 =
Boolean.getBoolean(Config.PROPERTY_PREFIX + "disable_stcs_in_l0");
+private static final boolean unsafeSystem =
Boolean.getBoolean(Config.PROPERTY_PREFIX + "unsafesystem");
+
+ // turns some warnings into exceptions for testing
+ private static final boolean strictRuntimeChecks =
Boolean.getBoolean("cassandra.strict.runtime.checks");
+
-public static boolean isDaemonInitialized()
+public static void daemonInitialization() throws ConfigurationException
{
-return daemonInitialized;
+daemonInitialization(DatabaseDescriptor::loadConfig);
}
-public static void setDaemonInitialized()
+public static void daemonInitialization(Supplier config) throws
ConfigurationException
{
+if (toolInitialized)
+throw new AssertionError("toolInitialization() already called");
+if (clientInitialized)
+throw new AssertionError("clientInitialization() already called");
+
+// Some unit tests require this :(
+if (daemonInitialized)
+return;
daemonInitialized = true;
+
+setConfig(config.get());
+applyAll();
+AuthConfig.applyAuth();
+}
+
+/**
+ * Equivalent to {@link #toolInitialization(boolean)
toolInitialization(true)}.
+ */
+public static void toolInitialization()
+{
+toolInitialization(true);
}
-public static void forceStaticInitialization() {}
-static
+/**
+ * Initializes this class as a tool, which means that the configuration
is loaded
+ *
[jira] [Updated] (CASSANDRA-13451) add gossip documentation
[ https://issues.apache.org/jira/browse/CASSANDRA-13451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CASSANDRA-13451: --- Labels: pull-request-available (was: ) > add gossip documentation > > > Key: CASSANDRA-13451 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13451 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Documentation and Website >Reporter: Jon Haddad >Assignee: Elijah Augustin >Priority: Normal > Labels: pull-request-available > > There's a decent amount of valid info here: > https://wiki.apache.org/cassandra/ArchitectureGossip and we have basically > nothing in the official docs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15101) Add Token Ring/Range Documentation
Elijah Augustin created CASSANDRA-15101: --- Summary: Add Token Ring/Range Documentation Key: CASSANDRA-15101 URL: https://issues.apache.org/jira/browse/CASSANDRA-15101 Project: Cassandra Issue Type: Improvement Components: Documentation/Blog, Legacy/Documentation and Website Reporter: Elijah Augustin Assignee: Elijah Augustin -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15088) PagingTest failure on trunk
[
https://issues.apache.org/jira/browse/CASSANDRA-15088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Per Otterström updated CASSANDRA-15088:
---
Fix Version/s: 4.0
> PagingTest failure on trunk
> ---
>
> Key: CASSANDRA-15088
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15088
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Marcus Olsson
>Assignee: Marcus Olsson
>Priority: Normal
> Fix For: 4.0
>
> Attachments: 15088-trunk.txt
>
>
> [Example failure|https://circleci.com/gh/emolsson/cassandra/19]
> {noformat}
> java.lang.RuntimeException: Unable to gossip with any peers
> at org.apache.cassandra.gms.Gossiper.doShadowRound(Gossiper.java:1546)
> at
> org.apache.cassandra.service.StorageService.checkForEndpointCollision(StorageService.java:553)
> at
> org.apache.cassandra.service.StorageService.prepareToJoin(StorageService.java:841)
> at
> org.apache.cassandra.service.StorageService.initServer(StorageService.java:699)
> at
> org.apache.cassandra.service.StorageService.initServer(StorageService.java:650)
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:379)
> at
> org.apache.cassandra.service.CassandraDaemon.init(CassandraDaemon.java:501)
> at
> org.apache.cassandra.service.EmbeddedCassandraService.start(EmbeddedCassandraService.java:50)
> at org.apache.cassandra.cql3.PagingTest.setup(PagingTest.java:63)
> {noformat}
> Running the test case by itself won't reproduce the issue:
> {noformat}
> ant test -Dtest.name=PagingTest
> {noformat}
> But running it in parallel with other tests will:
> {noformat}
> ant test -Dtest.name=cql3/*
> {noformat}
> From the logs the following can be observed:
> {noformat}
> INFO [main] 2019-04-11 15:32:29,916 Node
> configuration:[...seed_provider=org.apache.cassandra.locator.SimpleSeedProvider{seeds=127.0.0.1:7017};
> storage_port=7027]
> ...
> DEBUG [main] 2019-04-17 10:11:55,418 connection attempt 0 to 127.0.0.1:7044
> (GOSSIP)
> DEBUG [main] 2019-04-17 10:11:55,420 creating outbound bootstrap to peer
> 127.0.0.1:7044, compression: false, encryption: disabled, coalesce: DISABLED,
> protocolVersion: 12
> DEBUG [ScheduledFastTasks:1] 2019-04-17 10:11:55,538 connection attempt 1 to
> 127.0.0.1:7044 (GOSSIP)
> DEBUG [ScheduledFastTasks:1] 2019-04-17 10:11:55,538 creating outbound
> bootstrap to peer 127.0.0.1:7044, compression: false, encryption: disabled,
> coalesce: DISABLED, protocolVersion: 12
> {noformat}
> It seems like we have an offset issue of 10 between seed/storage_port.
> The port 7044 does not seem to be defined anywhere though.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15088) PagingTest failure on trunk
[
https://issues.apache.org/jira/browse/CASSANDRA-15088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Per Otterström updated CASSANDRA-15088:
---
Severity: Normal
Complexity: Normal
Discovered By: Existing Unit Test
Bug Category: Parent values: Correctness(12982)Level 1 values: Test
Failure(12990)
Reviewers: Per Otterström
Status: Open (was: Triage Needed)
> PagingTest failure on trunk
> ---
>
> Key: CASSANDRA-15088
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15088
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Marcus Olsson
>Assignee: Marcus Olsson
>Priority: Normal
> Attachments: 15088-trunk.txt
>
>
> [Example failure|https://circleci.com/gh/emolsson/cassandra/19]
> {noformat}
> java.lang.RuntimeException: Unable to gossip with any peers
> at org.apache.cassandra.gms.Gossiper.doShadowRound(Gossiper.java:1546)
> at
> org.apache.cassandra.service.StorageService.checkForEndpointCollision(StorageService.java:553)
> at
> org.apache.cassandra.service.StorageService.prepareToJoin(StorageService.java:841)
> at
> org.apache.cassandra.service.StorageService.initServer(StorageService.java:699)
> at
> org.apache.cassandra.service.StorageService.initServer(StorageService.java:650)
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:379)
> at
> org.apache.cassandra.service.CassandraDaemon.init(CassandraDaemon.java:501)
> at
> org.apache.cassandra.service.EmbeddedCassandraService.start(EmbeddedCassandraService.java:50)
> at org.apache.cassandra.cql3.PagingTest.setup(PagingTest.java:63)
> {noformat}
> Running the test case by itself won't reproduce the issue:
> {noformat}
> ant test -Dtest.name=PagingTest
> {noformat}
> But running it in parallel with other tests will:
> {noformat}
> ant test -Dtest.name=cql3/*
> {noformat}
> From the logs the following can be observed:
> {noformat}
> INFO [main] 2019-04-11 15:32:29,916 Node
> configuration:[...seed_provider=org.apache.cassandra.locator.SimpleSeedProvider{seeds=127.0.0.1:7017};
> storage_port=7027]
> ...
> DEBUG [main] 2019-04-17 10:11:55,418 connection attempt 0 to 127.0.0.1:7044
> (GOSSIP)
> DEBUG [main] 2019-04-17 10:11:55,420 creating outbound bootstrap to peer
> 127.0.0.1:7044, compression: false, encryption: disabled, coalesce: DISABLED,
> protocolVersion: 12
> DEBUG [ScheduledFastTasks:1] 2019-04-17 10:11:55,538 connection attempt 1 to
> 127.0.0.1:7044 (GOSSIP)
> DEBUG [ScheduledFastTasks:1] 2019-04-17 10:11:55,538 creating outbound
> bootstrap to peer 127.0.0.1:7044, compression: false, encryption: disabled,
> coalesce: DISABLED, protocolVersion: 12
> {noformat}
> It seems like we have an offset issue of 10 between seed/storage_port.
> The port 7044 does not seem to be defined anywhere though.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15088) PagingTest failure on trunk
[
https://issues.apache.org/jira/browse/CASSANDRA-15088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826026#comment-16826026
]
Per Otterström commented on CASSANDRA-15088:
I had a look at this and ran some local tests. Also, I pushed a
[branch|https://github.com/eperott/cassandra/tree/15088-trunk] with [green unit
test results|https://circleci.com/gh/eperott/cassandra/49]. And for reference
without the patch, the [failing unit test on
trunk|https://circleci.com/gh/eperott/cassandra/47#tests/containers/2] where
the {{PagingTest}} is failing.
So the way I understand it {{test/conf/cassandra-murmur.yaml}} was added to
trunk by CASSANDRA-10661. And later when CASSANDRA-7544 was merged from
{{cassandra-3.11}} branch the port was updated in {{test/conf/cassandra.yaml}},
but this was not the case for {{test/conf/cassandra-murmur.yaml}}.
At the time when {{test/conf/cassandra-murmur.yaml}} was added, the only
difference to {{test/conf/cassandra.yaml}} was the {{partitioner}} setting.
Since then a bunch of other settings have diverged between the two files. I
doubt this is intentional. Should we take this opportunity to align other
fields as well? For instance, when CASSANDRA-7544 was merged into trunk the
{{ssl_storage_port}} settings was updated in {{test/conf/cassandra.yaml}}.
> PagingTest failure on trunk
> ---
>
> Key: CASSANDRA-15088
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15088
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Marcus Olsson
>Assignee: Marcus Olsson
>Priority: Normal
> Attachments: 15088-trunk.txt
>
>
> [Example failure|https://circleci.com/gh/emolsson/cassandra/19]
> {noformat}
> java.lang.RuntimeException: Unable to gossip with any peers
> at org.apache.cassandra.gms.Gossiper.doShadowRound(Gossiper.java:1546)
> at
> org.apache.cassandra.service.StorageService.checkForEndpointCollision(StorageService.java:553)
> at
> org.apache.cassandra.service.StorageService.prepareToJoin(StorageService.java:841)
> at
> org.apache.cassandra.service.StorageService.initServer(StorageService.java:699)
> at
> org.apache.cassandra.service.StorageService.initServer(StorageService.java:650)
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:379)
> at
> org.apache.cassandra.service.CassandraDaemon.init(CassandraDaemon.java:501)
> at
> org.apache.cassandra.service.EmbeddedCassandraService.start(EmbeddedCassandraService.java:50)
> at org.apache.cassandra.cql3.PagingTest.setup(PagingTest.java:63)
> {noformat}
> Running the test case by itself won't reproduce the issue:
> {noformat}
> ant test -Dtest.name=PagingTest
> {noformat}
> But running it in parallel with other tests will:
> {noformat}
> ant test -Dtest.name=cql3/*
> {noformat}
> From the logs the following can be observed:
> {noformat}
> INFO [main] 2019-04-11 15:32:29,916 Node
> configuration:[...seed_provider=org.apache.cassandra.locator.SimpleSeedProvider{seeds=127.0.0.1:7017};
> storage_port=7027]
> ...
> DEBUG [main] 2019-04-17 10:11:55,418 connection attempt 0 to 127.0.0.1:7044
> (GOSSIP)
> DEBUG [main] 2019-04-17 10:11:55,420 creating outbound bootstrap to peer
> 127.0.0.1:7044, compression: false, encryption: disabled, coalesce: DISABLED,
> protocolVersion: 12
> DEBUG [ScheduledFastTasks:1] 2019-04-17 10:11:55,538 connection attempt 1 to
> 127.0.0.1:7044 (GOSSIP)
> DEBUG [ScheduledFastTasks:1] 2019-04-17 10:11:55,538 creating outbound
> bootstrap to peer 127.0.0.1:7044, compression: false, encryption: disabled,
> coalesce: DISABLED, protocolVersion: 12
> {noformat}
> It seems like we have an offset issue of 10 between seed/storage_port.
> The port 7044 does not seem to be defined anywhere though.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15100) Improve no-op cleanup performance
[ https://issues.apache.org/jira/browse/CASSANDRA-15100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson updated CASSANDRA-15100: Fix Version/s: 4.x 3.11.x 3.0.x > Improve no-op cleanup performance > - > > Key: CASSANDRA-15100 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15100 > Project: Cassandra > Issue Type: Improvement > Components: Local/Compaction >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.x > > > We should filter sstables in `OneSSTableOperation#filterSSTables` instead of > in the cleanup method to avoid creating unnecessary single-sstable > transactions for sstables fully contained in the owned ranges. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15100) Improve no-op cleanup performance
Marcus Eriksson created CASSANDRA-15100: --- Summary: Improve no-op cleanup performance Key: CASSANDRA-15100 URL: https://issues.apache.org/jira/browse/CASSANDRA-15100 Project: Cassandra Issue Type: Improvement Components: Local/Compaction Reporter: Marcus Eriksson Assignee: Marcus Eriksson We should filter sstables in `OneSSTableOperation#filterSSTables` instead of in the cleanup method to avoid creating unnecessary single-sstable transactions for sstables fully contained in the owned ranges. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
