[jira] [Comment Edited] (CASSANDRA-15050) JDK7 compatibility broken in cassandra-2.2 by CASSANDRA-14821
[
https://issues.apache.org/jira/browse/CASSANDRA-15050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857200#comment-16857200
]
Michael Shuler edited comment on CASSANDRA-15050 at 6/6/19 1:31 AM:
I can build on jdk8 and seem to be able to start {{./bin/cassandra}} after
switching back to jdk7, but with the changes from CASSANDRA-14821, I don't
understand how we can verify testing on jdk7 and jdk8, as this branch has
always done, if build.xml now specifies we must use jdk8 in tests.
{noformat}
+
+
{noformat}
I'm unclear as to why such a breaking chnage was committed to the 2.2 branch -
can we revert CASSANDRA-14821 [~ifesdjeen] to rework dual-JDK support for this
branch or just leave it out entirely, going back to the previous working tests?
was (Author: mshuler):
I can build on jdk8 and seem to be able to start {{./bin/cassandra}} after
switching back to jdk7, but with the changes from CASSANDRA-14821, I don't
understand how we can verify testing on jdk7 and jdk8, as this branch has
always done, if build.xml now specifies we must use jdk8 in tests.
{nofromat}
+
+
{noformat}
I'm unclear as to why such a breaking chnage was committed to the 2.2 branch -
can we revert CASSANDRA-14821 [~ifesdjeen] to rework dual-JDK support for this
branch or just leave it out entirely, going back to the previous working tests?
> JDK7 compatibility broken in cassandra-2.2 by CASSANDRA-14821
> -
>
> Key: CASSANDRA-15050
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15050
> Project: Cassandra
> Issue Type: Bug
> Components: Build
>Reporter: Michael Shuler
>Assignee: Ted Petersson
>Priority: Normal
> Fix For: 2.2.x
>
> Attachments: 15050-2.2.txt
>
>
> CASSANDRA-14821 introduced some errors on JDK7. The build fails as follows:
> {noformat}
> (cassandra-2.2)mshuler@mana:~/git/cassandra$ java -version
> java version "1.7.0_80"
> Java(TM) SE Runtime Environment (build 1.7.0_80-b15)
> Java HotSpot(TM) 64-Bit Server VM (build 24.80-b11, mixed mode)
> (cassandra-2.2)mshuler@mana:~/git/cassandra$ ant jar
> Buildfile: /home/mshuler/git/cassandra/build.xml
> init:
> [mkdir] Created dir: /home/mshuler/git/cassandra/build/classes/main
> [mkdir] Created dir: /home/mshuler/git/cassandra/build/classes/thrift
> [mkdir] Created dir: /home/mshuler/git/cassandra/build/test/lib
> [mkdir] Created dir: /home/mshuler/git/cassandra/build/test/classes
> [mkdir] Created dir: /home/mshuler/git/cassandra/src/gen-java
> [mkdir] Created dir: /home/mshuler/git/cassandra/build/lib
> [mkdir] Created dir: /home/mshuler/git/cassandra/build/jacoco
> [mkdir] Created dir: /home/mshuler/git/cassandra/build/jacoco/partials
> maven-ant-tasks-localrepo:
> [copy] Copying 1 file to /home/mshuler/git/cassandra/build
> maven-ant-tasks-download:
> maven-ant-tasks-init:
> maven-declare-dependencies:
> maven-ant-tasks-retrieve-build:
> [artifact:dependencies] Building ant file:
> /home/mshuler/git/cassandra/build/build-dependencies.xml
> [artifact:dependencies] Building ant file:
> /home/mshuler/git/cassandra/build/build-dependencies-sources.xml
> [copy] Copying 65 files to /home/mshuler/git/cassandra/build/lib/jars
> [copy] Copying 41 files to /home/mshuler/git/cassandra/build/lib/sources
> [copy] Copying 25 files to /home/mshuler/git/cassandra/build/lib/jars
> [unzip] Expanding:
> /home/mshuler/git/cassandra/build/lib/jars/org.jacoco.agent-0.7.5.201505241946.jar
> into /home/mshu
> ler/git/cassandra/build/lib/jars
> check-gen-cql3-grammar:
> gen-cql3-grammar:
> [echo] Building Grammar
> /home/mshuler/git/cassandra/src/java/org/apache/cassandra/cql3/Cql.g ...
> generate-cql-html:
> build-project:
> [echo] apache-cassandra: /home/mshuler/git/cassandra/build.xml
> [javac] Compiling 45 source files to
> /home/mshuler/git/cassandra/build/classes/thrift
> [javac] warning: Supported source version 'RELEASE_6' from annotation
> processor 'org.openjdk.jmh.generators.Benchmark
> Processor' less than -source '1.7'
> [javac] Note:
> /home/mshuler/git/cassandra/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java
> uses o
> r overrides a deprecated API.
> [javac] Note: Recompile with -Xlint:deprecation for details.
> [javac] Note: Some input files use unchecked or unsafe operations.
> [javac] Note: Recompile with -Xlint:unchecked for details.
> [javac] 1 warning
> [javac] Compiling 1171 source files to
> /home/mshuler/git/cassandra/build/classes/main
> [javac] Note: Processing compiler hints annotations
> [javac] warning: Supported source version 'RELEASE_6' from annotation
> processor 'org.openjdk.jmh.generators.Benchmark
> Processor'
[jira] [Commented] (CASSANDRA-15050) JDK7 compatibility broken in cassandra-2.2 by CASSANDRA-14821
[
https://issues.apache.org/jira/browse/CASSANDRA-15050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857200#comment-16857200
]
Michael Shuler commented on CASSANDRA-15050:
I can build on jdk8 and seem to be able to start {{./bin/cassandra}} after
switching back to jdk7, but with the changes from CASSANDRA-14821, I don't
understand how we can verify testing on jdk7 and jdk8, as this branch has
always done, if build.xml now specifies we must use jdk8 in tests.
{nofromat}
+
+
{noformat}
I'm unclear as to why such a breaking chnage was committed to the 2.2 branch -
can we revert CASSANDRA-14821 [~ifesdjeen] to rework dual-JDK support for this
branch or just leave it out entirely, going back to the previous working tests?
> JDK7 compatibility broken in cassandra-2.2 by CASSANDRA-14821
> -
>
> Key: CASSANDRA-15050
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15050
> Project: Cassandra
> Issue Type: Bug
> Components: Build
>Reporter: Michael Shuler
>Assignee: Ted Petersson
>Priority: Normal
> Fix For: 2.2.x
>
> Attachments: 15050-2.2.txt
>
>
> CASSANDRA-14821 introduced some errors on JDK7. The build fails as follows:
> {noformat}
> (cassandra-2.2)mshuler@mana:~/git/cassandra$ java -version
> java version "1.7.0_80"
> Java(TM) SE Runtime Environment (build 1.7.0_80-b15)
> Java HotSpot(TM) 64-Bit Server VM (build 24.80-b11, mixed mode)
> (cassandra-2.2)mshuler@mana:~/git/cassandra$ ant jar
> Buildfile: /home/mshuler/git/cassandra/build.xml
> init:
> [mkdir] Created dir: /home/mshuler/git/cassandra/build/classes/main
> [mkdir] Created dir: /home/mshuler/git/cassandra/build/classes/thrift
> [mkdir] Created dir: /home/mshuler/git/cassandra/build/test/lib
> [mkdir] Created dir: /home/mshuler/git/cassandra/build/test/classes
> [mkdir] Created dir: /home/mshuler/git/cassandra/src/gen-java
> [mkdir] Created dir: /home/mshuler/git/cassandra/build/lib
> [mkdir] Created dir: /home/mshuler/git/cassandra/build/jacoco
> [mkdir] Created dir: /home/mshuler/git/cassandra/build/jacoco/partials
> maven-ant-tasks-localrepo:
> [copy] Copying 1 file to /home/mshuler/git/cassandra/build
> maven-ant-tasks-download:
> maven-ant-tasks-init:
> maven-declare-dependencies:
> maven-ant-tasks-retrieve-build:
> [artifact:dependencies] Building ant file:
> /home/mshuler/git/cassandra/build/build-dependencies.xml
> [artifact:dependencies] Building ant file:
> /home/mshuler/git/cassandra/build/build-dependencies-sources.xml
> [copy] Copying 65 files to /home/mshuler/git/cassandra/build/lib/jars
> [copy] Copying 41 files to /home/mshuler/git/cassandra/build/lib/sources
> [copy] Copying 25 files to /home/mshuler/git/cassandra/build/lib/jars
> [unzip] Expanding:
> /home/mshuler/git/cassandra/build/lib/jars/org.jacoco.agent-0.7.5.201505241946.jar
> into /home/mshu
> ler/git/cassandra/build/lib/jars
> check-gen-cql3-grammar:
> gen-cql3-grammar:
> [echo] Building Grammar
> /home/mshuler/git/cassandra/src/java/org/apache/cassandra/cql3/Cql.g ...
> generate-cql-html:
> build-project:
> [echo] apache-cassandra: /home/mshuler/git/cassandra/build.xml
> [javac] Compiling 45 source files to
> /home/mshuler/git/cassandra/build/classes/thrift
> [javac] warning: Supported source version 'RELEASE_6' from annotation
> processor 'org.openjdk.jmh.generators.Benchmark
> Processor' less than -source '1.7'
> [javac] Note:
> /home/mshuler/git/cassandra/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java
> uses o
> r overrides a deprecated API.
> [javac] Note: Recompile with -Xlint:deprecation for details.
> [javac] Note: Some input files use unchecked or unsafe operations.
> [javac] Note: Recompile with -Xlint:unchecked for details.
> [javac] 1 warning
> [javac] Compiling 1171 source files to
> /home/mshuler/git/cassandra/build/classes/main
> [javac] Note: Processing compiler hints annotations
> [javac] warning: Supported source version 'RELEASE_6' from annotation
> processor 'org.openjdk.jmh.generators.Benchmark
> Processor' less than -source '1.7'
> [javac]
> /home/mshuler/git/cassandra/src/java/org/apache/cassandra/utils/MBeanWrapper.java:22:
> error: package java.uti
> l.function does not exist
> [javac] import java.util.function.Consumer;
> [javac] ^
> [javac]
> /home/mshuler/git/cassandra/src/java/org/apache/cassandra/utils/MBeanWrapper.java:203:
> error: cannot find sym
> bol
> [javac] private Consumer handler;
> [javac] ^
> [javac] symbol: class Consumer
> [javac] location: class OnException
> [javac]
>
[jira] [Commented] (CASSANDRA-15050) JDK7 compatibility broken in cassandra-2.2 by CASSANDRA-14821
[
https://issues.apache.org/jira/browse/CASSANDRA-15050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857198#comment-16857198
]
Michael Shuler commented on CASSANDRA-15050:
{noformat}
(cassandra-2.2)mshuler@mana:~/git/cassandra$ java -version
java version "1.7.0_80"
Java(TM) SE Runtime Environment (build 1.7.0_80-b15)
Java HotSpot(TM) 64-Bit Server VM (build 24.80-b11, mixed mode)
(cassandra-2.2)mshuler@mana:~/git/cassandra$
(cassandra-2.2)mshuler@mana:~/git/cassandra$ git diff origin/cassandra-2.2
diff --git a/CHANGES.txt b/CHANGES.txt
index 1cc415312d..48bf14f5d4 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
2.2.15
+ * Fix JDK7 compatibility broken in cassandra-2.2 (CASSANDRA-15050)
* Support cross version messaging in in-jvm upgrade dtests (CASSANDRA-15078)
* Fix index summary redistribution cancellation (CASSANDRA-15045)
* Refactor Circle CI configuration (CASSANDRA-14806)
diff --git a/src/java/org/apache/cassandra/utils/MBeanWrapper.java
b/src/java/org/apache/cassandra/utils/MBeanWrapper.java
index 3b5c7cb70c..1ee787d8d8 100644
--- a/src/java/org/apache/cassandra/utils/MBeanWrapper.java
+++ b/src/java/org/apache/cassandra/utils/MBeanWrapper.java
@@ -19,7 +19,6 @@
package org.apache.cassandra.utils;
import java.lang.management.ManagementFactory;
-import java.util.function.Consumer;
import javax.management.MBeanServer;
import javax.management.MalformedObjectNameException;
import javax.management.ObjectName;
@@ -206,4 +205,10 @@ public interface MBeanWrapper
this.handler = handler;
}
}
+
+ // Locally defined Consumer interface, to be compatible with Java 7. Only
needed for cassandra-2.2
+ interface Consumer
+ {
+ void accept(T e);
+ }
}
(cassandra-2.2)mshuler@mana:~/git/cassandra$
(cassandra-2.2)mshuler@mana:~/git/cassandra$ ant
Buildfile: /home/mshuler/git/cassandra/build.xml
init:
[mkdir] Created dir: /home/mshuler/git/cassandra/build/classes/main
[mkdir] Created dir: /home/mshuler/git/cassandra/build/classes/thrift
[mkdir] Created dir: /home/mshuler/git/cassandra/build/test/lib
[mkdir] Created dir: /home/mshuler/git/cassandra/build/test/classes
[mkdir] Created dir: /home/mshuler/git/cassandra/src/gen-java
[mkdir] Created dir: /home/mshuler/git/cassandra/build/lib
[mkdir] Created dir: /home/mshuler/git/cassandra/build/jacoco
[mkdir] Created dir: /home/mshuler/git/cassandra/build/jacoco/partials
maven-ant-tasks-localrepo:
[copy] Copying 1 file to /home/mshuler/git/cassandra/build
maven-ant-tasks-download:
maven-ant-tasks-init:
maven-declare-dependencies:
maven-ant-tasks-retrieve-build:
[artifact:dependencies] Building ant file:
/home/mshuler/git/cassandra/build/build-dependencies.xml
[artifact:dependencies] Building ant file:
/home/mshuler/git/cassandra/build/build-dependencies-sources.xml
[copy] Copying 65 files to /home/mshuler/git/cassandra/build/lib/jars
[copy] Copying 41 files to /home/mshuler/git/cassandra/build/lib/sources
[copy] Copying 25 files to /home/mshuler/git/cassandra/build/lib/jars
[unzip] Expanding:
/home/mshuler/git/cassandra/build/lib/jars/org.jacoco.agent-0.7.5.201505241946.jar
into /home/mshuler/git/cassandra/b
uild/lib/jars
check-gen-cql3-grammar:
gen-cql3-grammar:
[echo] Building Grammar
/home/mshuler/git/cassandra/src/java/org/apache/cassandra/cql3/Cql.g ...
generate-cql-html:
build-project:
[echo] apache-cassandra: /home/mshuler/git/cassandra/build.xml
[javac] Compiling 45 source files to
/home/mshuler/git/cassandra/build/classes/thrift
[javac] warning: Supported source version 'RELEASE_6' from annotation
processor 'org.openjdk.jmh.generators.BenchmarkProcessor' less tha
n -source '1.7'
[javac] Note:
/home/mshuler/git/cassandra/interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java
uses or overrides a depre
cated API.
[javac] Note: Recompile with -Xlint:deprecation for details.
[javac] Note: Some input files use unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.
[javac] 1 warning
[javac] Compiling 1171 source files to
/home/mshuler/git/cassandra/build/classes/main
[javac] Note: Processing compiler hints annotations
[javac] warning: Supported source version 'RELEASE_6' from annotation
processor 'org.openjdk.jmh.generators.BenchmarkProcessor' less tha
n -source '1.7'
[javac] Note: Processing compiler hints annotations
[javac] Note: Writing compiler command file at META-INF/hotspot_compiler
[javac] Note: Done processing compiler hints annotations
[javac] Note: Some input files use or override a deprecated API.
[javac] Note: Recompile with -Xlint:deprecation for details.
[javac] Note: Some input files use unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.
[javac] 1 warning
createVersionPropFile:
[mkdir] Created
[jira] [Comment Edited] (CASSANDRA-10190) Python 3 support for cqlsh
[
https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856488#comment-16856488
]
Dinesh Joshi edited comment on CASSANDRA-10190 at 6/5/19 8:22 AM:
--
Hi [~ptbannister], I have gone over your patch and here are some minor comments
-
{{cqlsh.py}}
* Why is {{FrozenType}} commented out?
* You've replaced occurrences of {{%r}} with {{"'{}'"}}. However, we should
use "\{!r}" instead which is equivalent to {{%r}}. Please remove the single
quotes surrounding the object names.
* Remove {{six}} import from L42. This is a premature import and breaks Python
2. {{six}} is imported on L150 once we have discovered the Python libraries
path for cqlsh.
* Python version check could be a bit more readable like this
{{sys.version_info.major != 3 and (sys.version_info.major == 2 and
sys.version_info.minor != 7)}} instead of using indexes.
{{copyutil.py}}
* L2514 remove commented out code.
{{cqlsh}}
* Nit: L51: python -> Python
was (Author: djoshi3):
Hi [~ptbannister], I have gone over your patch and here are some minor comments
-
{{cqlsh.py}}
* Why is {{FrozenType}} commented out?
* You've replaced occurrences of {{%r}} with {{"'{}'"}}. However, we should
use \{{"{!r}"}} instead which is equivalent to {{%r}}. Please remove the single
quotes surrounding the object names.
* Remove {{six}} import from L42. This is a premature import and breaks Python
2. {{six}} is imported on L150 once we have discovered the Python libraries
path for cqlsh.
* Python version check could be a bit more readable like this
{{sys.version_info.major != 3 and (sys.version_info.major == 2 and
sys.version_info.minor != 7)}} instead of using indexes.
{{copyutil.py}}
* L2514 remove commented out code.
{{cqlsh}}
* Nit: L51: python -> Python
> Python 3 support for cqlsh
> --
>
> Key: CASSANDRA-10190
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10190
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Tools
>Reporter: Andrew Pennebaker
>Assignee: Patrick Bannister
>Priority: Normal
> Labels: cqlsh
> Attachments: coverage_notes.txt
>
>
> Users who operate in a Python 3 environment may have trouble launching cqlsh.
> Could we please update cqlsh's syntax to run in Python 3?
> As a workaround, users can setup pyenv, and cd to a directory with a
> .python-version containing "2.7". But it would be nice if cqlsh supported
> modern Python versions out of the box.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-10190) Python 3 support for cqlsh
[
https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856488#comment-16856488
]
Dinesh Joshi edited comment on CASSANDRA-10190 at 6/5/19 8:22 AM:
--
Hi [~ptbannister], I have gone over your patch and here are some minor comments
-
{{cqlsh.py}}
* Why is {{FrozenType}} commented out?
* You've replaced occurrences of {{%r}} with {{"'{}'"}}. However, we should
use \{{"{!r}"}} instead which is equivalent to {{%r}}. Please remove the single
quotes surrounding the object names.
* Remove {{six}} import from L42. This is a premature import and breaks Python
2. {{six}} is imported on L150 once we have discovered the Python libraries
path for cqlsh.
* Python version check could be a bit more readable like this
{{sys.version_info.major != 3 and (sys.version_info.major == 2 and
sys.version_info.minor != 7)}} instead of using indexes.
{{copyutil.py}}
* L2514 remove commented out code.
{{cqlsh}}
* Nit: L51: python -> Python
was (Author: djoshi3):
Hi [~ptbannister], I have gone over your patch and here are some minor comments
-
{{cqlsh.py}}
* Why is {{FrozenType}} commented out?
* You've replaced occurrences of {{%r}} with \{{"'{}'"}}. However, we should
use \{{"{!r}"}} instead which is equivalent to \{{%r}}. Please remove the
single quotes surrounding the object names.
* Remove {{six}} import from L42. This is a premature import and breaks Python
2. {{six}} is imported on L150 once we have discovered the Python libraries
path for cqlsh.
* Python version check could be a bit more readable like this
{{sys.version_info.major != 3 and (sys.version_info.major == 2 and
sys.version_info.minor != 7)}} instead of using indexes.
{{copyutil.py}}
* L2514 remove commented out code.
{{cqlsh}}
* Nit: L51: python -> Python
> Python 3 support for cqlsh
> --
>
> Key: CASSANDRA-10190
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10190
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Tools
>Reporter: Andrew Pennebaker
>Assignee: Patrick Bannister
>Priority: Normal
> Labels: cqlsh
> Attachments: coverage_notes.txt
>
>
> Users who operate in a Python 3 environment may have trouble launching cqlsh.
> Could we please update cqlsh's syntax to run in Python 3?
> As a workaround, users can setup pyenv, and cd to a directory with a
> .python-version containing "2.7". But it would be nice if cqlsh supported
> modern Python versions out of the box.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-10190) Python 3 support for cqlsh
[
https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856488#comment-16856488
]
Dinesh Joshi edited comment on CASSANDRA-10190 at 6/5/19 8:21 AM:
--
Hi [~ptbannister], I have gone over your patch and here are some minor comments
-
{{cqlsh.py}}
* Why is {{FrozenType}} commented out?
* You've replaced occurrences of {{%r}} with \{{"'{}'"}}. However, we should
use \{{"{!r}"}} instead which is equivalent to \{{%r}}. Please remove the
single quotes surrounding the object names.
* Remove {{six}} import from L42. This is a premature import and breaks Python
2. {{six}} is imported on L150 once we have discovered the Python libraries
path for cqlsh.
* Python version check could be a bit more readable like this
{{sys.version_info.major != 3 and (sys.version_info.major == 2 and
sys.version_info.minor != 7)}} instead of using indexes.
{{copyutil.py}}
* L2514 remove commented out code.
{{cqlsh}}
* Nit: L51: python -> Python
was (Author: djoshi3):
Hi [~ptbannister], I have gone over your patch and here are some minor comments
-
{{cqlsh.py}}
* Why is {{FrozenType}} commented out?
* You've replaced occurrences of %r with "'{}'". However, we should use "{!r}"
instead which is equivalent to %r. Please remove the single quotes surrounding
the object names.
* Remove {{six}} import from L42. This is a premature import and breaks Python
2. {{six}} is imported on L150 once we have discovered the Python libraries
path for cqlsh.
* Python version check could be a bit more readable like this
{{sys.version_info.major != 3 and (sys.version_info.major == 2 and
sys.version_info.minor != 7)}} instead of using indexes.
{{copyutil.py}}
* L2514 remove commented out code.
{{cqlsh}}
* Nit: L51: python -> Python
> Python 3 support for cqlsh
> --
>
> Key: CASSANDRA-10190
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10190
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Tools
>Reporter: Andrew Pennebaker
>Assignee: Patrick Bannister
>Priority: Normal
> Labels: cqlsh
> Attachments: coverage_notes.txt
>
>
> Users who operate in a Python 3 environment may have trouble launching cqlsh.
> Could we please update cqlsh's syntax to run in Python 3?
> As a workaround, users can setup pyenv, and cd to a directory with a
> .python-version containing "2.7". But it would be nice if cqlsh supported
> modern Python versions out of the box.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-10190) Python 3 support for cqlsh
[
https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856488#comment-16856488
]
Dinesh Joshi commented on CASSANDRA-10190:
--
Hi [~ptbannister], I have gone over your patch and here are some minor comments
-
{{cqlsh.py}}
* Why is {{FrozenType}} commented out?
* You've replaced occurrences of %r with "'{}'". However, we should use "{!r}"
instead which is equivalent to %r. Please remove the single quotes surrounding
the object names.
* Remove {{six}} import from L42. This is a premature import and breaks Python
2. {{six}} is imported on L150 once we have discovered the Python libraries
path for cqlsh.
* Python version check could be a bit more readable like this
{{sys.version_info.major != 3 and (sys.version_info.major == 2 and
sys.version_info.minor != 7)}} instead of using indexes.
{{copyutil.py}}
* L2514 remove commented out code.
{{cqlsh}}
* Nit: L51: python -> Python
> Python 3 support for cqlsh
> --
>
> Key: CASSANDRA-10190
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10190
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Tools
>Reporter: Andrew Pennebaker
>Assignee: Patrick Bannister
>Priority: Normal
> Labels: cqlsh
> Attachments: coverage_notes.txt
>
>
> Users who operate in a Python 3 environment may have trouble launching cqlsh.
> Could we please update cqlsh's syntax to run in Python 3?
> As a workaround, users can setup pyenv, and cd to a directory with a
> .python-version containing "2.7". But it would be nice if cqlsh supported
> modern Python versions out of the box.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14305) Use $CASSANDRA_CONF not $CASSANDRA_HOME/conf in cassandra-env.sh
[ https://issues.apache.org/jira/browse/CASSANDRA-14305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mck updated CASSANDRA-14305: Status: Ready to Commit (was: Review In Progress) > Use $CASSANDRA_CONF not $CASSANDRA_HOME/conf in cassandra-env.sh > - > > Key: CASSANDRA-14305 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14305 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: Angelo Polo >Assignee: Angelo Polo >Priority: Low > Labels: pull-request-available > Fix For: 3.11.5, 4.0 > > Attachments: conf_cassandra-env.sh.patch > > Time Spent: 20m > Remaining Estimate: 0h > > CASSANDRA_CONF should be used uniformly in conf/cassandra-env.sh to reference > the configuration path. Currently, jaas users will have to modify the default > path provided for cassandra-jaas.config if their $CASSANDRA_CONF differs from > $CASSANDRA_HOME/conf. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14305) Use $CASSANDRA_CONF not $CASSANDRA_HOME/conf in cassandra-env.sh
[ https://issues.apache.org/jira/browse/CASSANDRA-14305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mck updated CASSANDRA-14305: Status: Review In Progress (was: Patch Available) > Use $CASSANDRA_CONF not $CASSANDRA_HOME/conf in cassandra-env.sh > - > > Key: CASSANDRA-14305 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14305 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: Angelo Polo >Assignee: Angelo Polo >Priority: Low > Labels: pull-request-available > Fix For: 3.11.5, 4.0 > > Attachments: conf_cassandra-env.sh.patch > > Time Spent: 20m > Remaining Estimate: 0h > > CASSANDRA_CONF should be used uniformly in conf/cassandra-env.sh to reference > the configuration path. Currently, jaas users will have to modify the default > path provided for cassandra-jaas.config if their $CASSANDRA_CONF differs from > $CASSANDRA_HOME/conf. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14305) Use $CASSANDRA_CONF not $CASSANDRA_HOME/conf in cassandra-env.sh
[
https://issues.apache.org/jira/browse/CASSANDRA-14305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
mck updated CASSANDRA-14305:
Status: Resolved (was: Ready to Commit)
{quote}
Fix is in https://github.com/apache/cassandra-dtest/pull/51
dtest run at
https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/673/
{quote}
Committed with
https://github.com/apache/cassandra-dtest/commit/a81e9a754ac7b56c5c1669970463578304b21105
> Use $CASSANDRA_CONF not $CASSANDRA_HOME/conf in cassandra-env.sh
> -
>
> Key: CASSANDRA-14305
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14305
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config
>Reporter: Angelo Polo
>Assignee: Angelo Polo
>Priority: Low
> Labels: pull-request-available
> Fix For: 3.11.5, 4.0
>
> Attachments: conf_cassandra-env.sh.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> CASSANDRA_CONF should be used uniformly in conf/cassandra-env.sh to reference
> the configuration path. Currently, jaas users will have to modify the default
> path provided for cassandra-jaas.config if their $CASSANDRA_CONF differs from
> $CASSANDRA_HOME/conf.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14305) Use $CASSANDRA_CONF not $CASSANDRA_HOME/conf in cassandra-env.sh
[ https://issues.apache.org/jira/browse/CASSANDRA-14305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mck updated CASSANDRA-14305: Reviewers: mck, Sam Tunnicliffe (was: mck) > Use $CASSANDRA_CONF not $CASSANDRA_HOME/conf in cassandra-env.sh > - > > Key: CASSANDRA-14305 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14305 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: Angelo Polo >Assignee: Angelo Polo >Priority: Low > Labels: pull-request-available > Fix For: 3.11.5, 4.0 > > Attachments: conf_cassandra-env.sh.patch > > Time Spent: 20m > Remaining Estimate: 0h > > CASSANDRA_CONF should be used uniformly in conf/cassandra-env.sh to reference > the configuration path. Currently, jaas users will have to modify the default > path provided for cassandra-jaas.config if their $CASSANDRA_CONF differs from > $CASSANDRA_HOME/conf. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-dtest] branch master updated: fix jmx_auth_test.TestJMXAuth.test_basic_auth after CASSANDRA-14305
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cassandra-dtest.git The following commit(s) were added to refs/heads/master by this push: new a81e9a7 fix jmx_auth_test.TestJMXAuth.test_basic_auth after CASSANDRA-14305 a81e9a7 is described below commit a81e9a754ac7b56c5c1669970463578304b21105 Author: Mick Semb Wever AuthorDate: Tue Jun 4 17:01:46 2019 +1000 fix jmx_auth_test.TestJMXAuth.test_basic_auth after CASSANDRA-14305 --- tools/jmxutils.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/jmxutils.py b/tools/jmxutils.py index dbc6e75..6986129 100644 --- a/tools/jmxutils.py +++ b/tools/jmxutils.py @@ -136,7 +136,7 @@ def apply_jmx_authentication(node): (r'#\$env:JVM_OPTS="\$env:JVM_OPTS -Dcassandra.jmx.remote.login.config=CassandraLogin"', '$env:JVM_OPTS="$env:JVM_OPTS -Dcassandra.jmx.remote.login.config=CassandraLogin"'), (r'#\$env:JVM_OPTS="\$env:JVM_OPTS -Djava.security.auth.login.config=C:/cassandra-jaas.config"', - r'$env:JVM_OPTS="$env:JVM_OPTS -Djava.security.auth.login.config=$env:CASSANDRA_HOME\conf\cassandra-jaas.config"'), + r'$env:JVM_OPTS="$env:JVM_OPTS -Djava.security.auth.login.config=$env:CASSANDRA_CONF\cassandra-jaas.config"'), (r'#\$env:JVM_OPTS="\$env:JVM_OPTS -Dcassandra.jmx.authorizer=org.apache.cassandra.auth.jmx.AuthorizationProxy"', '$env:JVM_OPTS="$env:JVM_OPTS -Dcassandra.jmx.authorizer=org.apache.cassandra.auth.jmx.AuthorizationProxy"') ] if common.is_win() else [ @@ -146,8 +146,8 @@ def apply_jmx_authentication(node): '#JVM_OPTS="$JVM_OPTS -Dcom.sun.management.jmxremote.password.file=/etc/cassandra/jmxremote.password"'), (r'#JVM_OPTS="\$JVM_OPTS -Dcassandra.jmx.remote.login.config=CassandraLogin"', 'JVM_OPTS="$JVM_OPTS -Dcassandra.jmx.remote.login.config=CassandraLogin"'), -(r'#JVM_OPTS="\$JVM_OPTS -Djava.security.auth.login.config=\$CASSANDRA_HOME/conf/cassandra-jaas.config"', - 'JVM_OPTS="$JVM_OPTS -Djava.security.auth.login.config=$CASSANDRA_HOME/conf/cassandra-jaas.config"'), +(r'#JVM_OPTS="\$JVM_OPTS -Djava.security.auth.login.config=\$CASSANDRA_CONF/cassandra-jaas.config"', + 'JVM_OPTS="$JVM_OPTS -Djava.security.auth.login.config=$CASSANDRA_CONF/cassandra-jaas.config"'), (r'#JVM_OPTS="\$JVM_OPTS -Dcassandra.jmx.authorizer=org.apache.cassandra.auth.jmx.AuthorizationProxy"', 'JVM_OPTS="$JVM_OPTS -Dcassandra.jmx.authorizer=org.apache.cassandra.auth.jmx.AuthorizationProxy"') ] - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
