[jira] [Updated] (CASSANDRA-15288) Read sidecar.yaml from sidecar.config System Property instead of classpath
[
https://issues.apache.org/jira/browse/CASSANDRA-15288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy Tolbert updated CASSANDRA-15288:
-
Test and Documentation Plan: existing tests should be sufficient.
Status: Patch Available (was: In Progress)
> Read sidecar.yaml from sidecar.config System Property instead of classpath
> --
>
> Key: CASSANDRA-15288
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15288
> Project: Cassandra
> Issue Type: Improvement
> Components: Sidecar
>Reporter: Andy Tolbert
>Assignee: Andy Tolbert
>Priority: Low
> Labels: pull-request-available
>
> I was experimenting earlier with running multiple sidecar instances against
> multiple local C* nodes (using a ccm cluster) and noticed that the
> distribution of sidecar did not include the conf directory and instead was
> loading sidecar.yaml from the classpath. I noticed the lines in build.gradle:
> {code:java}
> // Config file location should be in file:/// format for local files,
> // when we have the fix for adding /conf directory to classpaht, we can get
> away with below default JvmArg
> {code}
> From this statement I assume the expectation was that eventually the
> sidecar.config system property would be used to locate the sidecar.yaml file.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15288) Read sidecar.yaml from sidecar.config System Property instead of classpath
[
https://issues.apache.org/jira/browse/CASSANDRA-15288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy Tolbert updated CASSANDRA-15288:
-
Reviewers: Dinesh Joshi, Vinay Chella, Andy Tolbert (was: Andy Tolbert,
Dinesh Joshi, Vinay Chella)
Dinesh Joshi, Vinay Chella, Andy Tolbert (was: Dinesh Joshi,
Vinay Chella)
Status: Review In Progress (was: Patch Available)
> Read sidecar.yaml from sidecar.config System Property instead of classpath
> --
>
> Key: CASSANDRA-15288
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15288
> Project: Cassandra
> Issue Type: Improvement
> Components: Sidecar
>Reporter: Andy Tolbert
>Assignee: Andy Tolbert
>Priority: Low
> Labels: pull-request-available
>
> I was experimenting earlier with running multiple sidecar instances against
> multiple local C* nodes (using a ccm cluster) and noticed that the
> distribution of sidecar did not include the conf directory and instead was
> loading sidecar.yaml from the classpath. I noticed the lines in build.gradle:
> {code:java}
> // Config file location should be in file:/// format for local files,
> // when we have the fix for adding /conf directory to classpaht, we can get
> away with below default JvmArg
> {code}
> From this statement I assume the expectation was that eventually the
> sidecar.config system property would be used to locate the sidecar.yaml file.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15288) Read sidecar.yaml from sidecar.config System Property instead of classpath
[
https://issues.apache.org/jira/browse/CASSANDRA-15288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy Tolbert updated CASSANDRA-15288:
-
Change Category: Semantic
Complexity: Low Hanging Fruit
Status: Open (was: Triage Needed)
> Read sidecar.yaml from sidecar.config System Property instead of classpath
> --
>
> Key: CASSANDRA-15288
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15288
> Project: Cassandra
> Issue Type: Improvement
> Components: Sidecar
>Reporter: Andy Tolbert
>Assignee: Andy Tolbert
>Priority: Low
> Labels: pull-request-available
>
> I was experimenting earlier with running multiple sidecar instances against
> multiple local C* nodes (using a ccm cluster) and noticed that the
> distribution of sidecar did not include the conf directory and instead was
> loading sidecar.yaml from the classpath. I noticed the lines in build.gradle:
> {code:java}
> // Config file location should be in file:/// format for local files,
> // when we have the fix for adding /conf directory to classpaht, we can get
> away with below default JvmArg
> {code}
> From this statement I assume the expectation was that eventually the
> sidecar.config system property would be used to locate the sidecar.yaml file.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15288) Read sidecar.yaml from sidecar.config System Property instead of classpath
[
https://issues.apache.org/jira/browse/CASSANDRA-15288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy Tolbert updated CASSANDRA-15288:
-
Reviewers: Dinesh Joshi, Vinay Chella
> Read sidecar.yaml from sidecar.config System Property instead of classpath
> --
>
> Key: CASSANDRA-15288
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15288
> Project: Cassandra
> Issue Type: Improvement
> Components: Sidecar
>Reporter: Andy Tolbert
>Assignee: Andy Tolbert
>Priority: Low
> Labels: pull-request-available
>
> I was experimenting earlier with running multiple sidecar instances against
> multiple local C* nodes (using a ccm cluster) and noticed that the
> distribution of sidecar did not include the conf directory and instead was
> loading sidecar.yaml from the classpath. I noticed the lines in build.gradle:
> {code:java}
> // Config file location should be in file:/// format for local files,
> // when we have the fix for adding /conf directory to classpaht, we can get
> away with below default JvmArg
> {code}
> From this statement I assume the expectation was that eventually the
> sidecar.config system property would be used to locate the sidecar.yaml file.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15288) Read sidecar.yaml from sidecar.config System Property instead of classpath
Andy Tolbert created CASSANDRA-15288:
Summary: Read sidecar.yaml from sidecar.config System Property
instead of classpath
Key: CASSANDRA-15288
URL: https://issues.apache.org/jira/browse/CASSANDRA-15288
Project: Cassandra
Issue Type: Improvement
Components: Sidecar
Reporter: Andy Tolbert
Assignee: Andy Tolbert
I was experimenting earlier with running multiple sidecar instances against
multiple local C* nodes (using a ccm cluster) and noticed that the distribution
of sidecar did not include the conf directory and instead was loading
sidecar.yaml from the classpath. I noticed the lines in build.gradle:
{code:java}
// Config file location should be in file:/// format for local files,
// when we have the fix for adding /conf directory to classpaht, we can get
away with below default JvmArg
{code}
>From this statement I assume the expectation was that eventually the
>sidecar.config system property would be used to locate the sidecar.yaml file.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15288) Read sidecar.yaml from sidecar.config System Property instead of classpath
[
https://issues.apache.org/jira/browse/CASSANDRA-15288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy Tolbert updated CASSANDRA-15288:
-
Priority: Low (was: Normal)
> Read sidecar.yaml from sidecar.config System Property instead of classpath
> --
>
> Key: CASSANDRA-15288
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15288
> Project: Cassandra
> Issue Type: Improvement
> Components: Sidecar
>Reporter: Andy Tolbert
>Assignee: Andy Tolbert
>Priority: Low
> Labels: pull-request-available
>
> I was experimenting earlier with running multiple sidecar instances against
> multiple local C* nodes (using a ccm cluster) and noticed that the
> distribution of sidecar did not include the conf directory and instead was
> loading sidecar.yaml from the classpath. I noticed the lines in build.gradle:
> {code:java}
> // Config file location should be in file:/// format for local files,
> // when we have the fix for adding /conf directory to classpaht, we can get
> away with below default JvmArg
> {code}
> From this statement I assume the expectation was that eventually the
> sidecar.config system property would be used to locate the sidecar.yaml file.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15288) Read sidecar.yaml from sidecar.config System Property instead of classpath
[
https://issues.apache.org/jira/browse/CASSANDRA-15288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy Tolbert updated CASSANDRA-15288:
-
Labels: pull-request-available (was: )
> Read sidecar.yaml from sidecar.config System Property instead of classpath
> --
>
> Key: CASSANDRA-15288
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15288
> Project: Cassandra
> Issue Type: Improvement
> Components: Sidecar
>Reporter: Andy Tolbert
>Assignee: Andy Tolbert
>Priority: Normal
> Labels: pull-request-available
>
> I was experimenting earlier with running multiple sidecar instances against
> multiple local C* nodes (using a ccm cluster) and noticed that the
> distribution of sidecar did not include the conf directory and instead was
> loading sidecar.yaml from the classpath. I noticed the lines in build.gradle:
> {code:java}
> // Config file location should be in file:/// format for local files,
> // when we have the fix for adding /conf directory to classpaht, we can get
> away with below default JvmArg
> {code}
> From this statement I assume the expectation was that eventually the
> sidecar.config system property would be used to locate the sidecar.yaml file.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15124) Virtual tables API endpoints for sidecar
[ https://issues.apache.org/jira/browse/CASSANDRA-15124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913584#comment-16913584 ] Dinesh Joshi commented on CASSANDRA-15124: -- Hi [~cnlwsu]. thanks for the patch. I have left some feedback for you on the PR. > Virtual tables API endpoints for sidecar > > > Key: CASSANDRA-15124 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15124 > Project: Cassandra > Issue Type: New Feature > Components: Sidecar >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Normal > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Expose the existing virtual tables in sidecar api -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15124) Virtual tables API endpoints for sidecar
[ https://issues.apache.org/jira/browse/CASSANDRA-15124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRA-15124: - Reviewers: Andy Tolbert, Dinesh Joshi, Vinay Chella, Dinesh Joshi (was: Andy Tolbert, Dinesh Joshi, Vinay Chella) Andy Tolbert, Dinesh Joshi, Vinay Chella, Dinesh Joshi (was: Andy Tolbert, Dinesh Joshi, Vinay Chella) Status: Review In Progress (was: Patch Available) > Virtual tables API endpoints for sidecar > > > Key: CASSANDRA-15124 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15124 > Project: Cassandra > Issue Type: New Feature > Components: Sidecar >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Normal > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Expose the existing virtual tables in sidecar api -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15283) nodetool statushandoff does not list max hint window
[
https://issues.apache.org/jira/browse/CASSANDRA-15283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh Turner updated CASSANDRA-15283:
Resolution: Information Provided
Status: Resolved (was: Triage Needed)
> nodetool statushandoff does not list max hint window
>
>
> Key: CASSANDRA-15283
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15283
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
>Reporter: DeepakVohra
>Priority: Normal
>
> According to _CASSANDRA-13728_
> _Provide max hint window as part of nodetool_
> the nodetool statushandoff should list max hint window.
> But, with latest 4.0 build the output is still the same as before.
> {code:java}
> nodetool statushandoff
> Hinted handoff is running{code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-15283) nodetool statushandoff does not list max hint window
[
https://issues.apache.org/jira/browse/CASSANDRA-15283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh Turner reassigned CASSANDRA-15283:
---
Assignee: Josh Turner
> nodetool statushandoff does not list max hint window
>
>
> Key: CASSANDRA-15283
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15283
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
>Reporter: DeepakVohra
>Assignee: Josh Turner
>Priority: Normal
>
> According to _CASSANDRA-13728_
> _Provide max hint window as part of nodetool_
> the nodetool statushandoff should list max hint window.
> But, with latest 4.0 build the output is still the same as before.
> {code:java}
> nodetool statushandoff
> Hinted handoff is running{code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15283) nodetool statushandoff does not list max hint window
[
https://issues.apache.org/jira/browse/CASSANDRA-15283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913534#comment-16913534
]
Josh Turner commented on CASSANDRA-15283:
-
It looks like CASSANDRA-13728 placed this as a new command of nodetool
handoffwindow which does work as desired in the trunk.
{code:java}
bin/nodetool handoffwindow
Hinted handoff window is 1080
{code}
In discussion of that ticket it was decided to add a new option instead of
modifying the existing to avoid breaking automations that may already be in
place. See this comment:
https://issues.apache.org/jira/browse/CASSANDRA-13728?focusedCommentId=16131474=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16131474
> nodetool statushandoff does not list max hint window
>
>
> Key: CASSANDRA-15283
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15283
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
>Reporter: DeepakVohra
>Priority: Normal
>
> According to _CASSANDRA-13728_
> _Provide max hint window as part of nodetool_
> the nodetool statushandoff should list max hint window.
> But, with latest 4.0 build the output is still the same as before.
> {code:java}
> nodetool statushandoff
> Hinted handoff is running{code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15287) Inaccurate exception message with nodetool snapshot
[
https://issues.apache.org/jira/browse/CASSANDRA-15287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh Turner updated CASSANDRA-15287:
Test and Documentation Plan:
Reproduced error message:
{code:java}
bin/cqlsh << EOF
CREATE KEYSPACE k1 WITH replication = {'class': 'SimpleStrategy',
'replication_factor': '1'} AND durable_writes = true;
CREATE TABLE k1.t2 (
id uuid PRIMARY KEY,
val text
);
CREATE TABLE k1.t1 (
id uuid PRIMARY KEY,
val text
);
EOF
bin/nodetool snapshot --kt-list k1.t1,k1.t2 --k1
{code}
Before Patch:
{code:java}
error: When specifying the Keyspace columfamily list for a snapshot, you should
not specify columnfamilyerror: When specifying the Keyspace columfamily list
for a snapshot, you should not specify columnfamily
-- StackTrace --
java.io.IOException: When specifying the Keyspace columfamily list for a
snapshot, you should not specify columnfamily at
org.apache.cassandra.tools.nodetool.Snapshot.execute(Snapshot.java:73) at
org.apache.cassandra.tools.NodeTool$NodeToolCmd.run(NodeTool.java:307) at
org.apache.cassandra.tools.NodeTool.main(NodeTool.java:218)
{code}
After Patch:
{code:java}
error: When specifying the Keyspace columfamily list for a snapshot, you should
not specify keyspaceerror: When specifying the Keyspace columfamily list for a
snapshot, you should not specify keyspace
-- StackTrace --
java.io.IOException: When specifying the Keyspace columfamily list for a
snapshot, you should not specify keyspace at
org.apache.cassandra.tools.nodetool.Snapshot.execute(Snapshot.java:73) at
org.apache.cassandra.tools.NodeTool$NodeToolCmd.run(NodeTool.java:307) at
org.apache.cassandra.tools.NodeTool.main(NodeTool.java:218)
{code}
Status: Patch Available (was: Open)
> Inaccurate exception message with nodetool snapshot
>
>
> Key: CASSANDRA-15287
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15287
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
>Reporter: DeepakVohra
>Assignee: Josh Turner
>Priority: Normal
> Attachments: 15287.trunk, 15287.trunk.withchanges
>
>
> 1. Create a keyspace _cqlkeyspace_ (arbitrary name)
> 2. Create two tables (t1 and t2)
> 3. Run _nodetool snapshot_ to create snapshot for multiple tables in same
> command. Include the keyspace name as argument (which is not what the command
> syntax allows)
> {code:java}
> nodetool snapshot --kt-list cqlkeyspace.t1,cqlkeyspace.t2 --tag multi-table
> --cqlkeyspace
> {code}
> 4. Exception message is inaccurate in that it is referring to columnfamily
> when it should be referring to keyspace.
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a
> snapshot, you should not specify columnfamily
> {code}
> Exception message should be:
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a
> snapshot, you should not specify keyspace
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15287) Inaccurate exception message with nodetool snapshot
[
https://issues.apache.org/jira/browse/CASSANDRA-15287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913424#comment-16913424
]
Josh Turner commented on CASSANDRA-15287:
-
Confirmed the bug and see that it originated in Cassandra 2.2. The 15287.trunk
patch applies cleanly to 2.2, 3.0, 3.11, and trunk. I've split the patch in two
files as I'm not sure the proper version to modify for CHANGES.txt.
> Inaccurate exception message with nodetool snapshot
>
>
> Key: CASSANDRA-15287
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15287
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
>Reporter: DeepakVohra
>Assignee: Josh Turner
>Priority: Normal
> Attachments: 15287.trunk, 15287.trunk.withchanges
>
>
> 1. Create a keyspace _cqlkeyspace_ (arbitrary name)
> 2. Create two tables (t1 and t2)
> 3. Run _nodetool snapshot_ to create snapshot for multiple tables in same
> command. Include the keyspace name as argument (which is not what the command
> syntax allows)
> {code:java}
> nodetool snapshot --kt-list cqlkeyspace.t1,cqlkeyspace.t2 --tag multi-table
> --cqlkeyspace
> {code}
> 4. Exception message is inaccurate in that it is referring to columnfamily
> when it should be referring to keyspace.
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a
> snapshot, you should not specify columnfamily
> {code}
> Exception message should be:
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a
> snapshot, you should not specify keyspace
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15287) Inaccurate exception message with nodetool snapshot
[
https://issues.apache.org/jira/browse/CASSANDRA-15287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh Turner updated CASSANDRA-15287:
Attachment: 15287.trunk.withchanges
15287.trunk
> Inaccurate exception message with nodetool snapshot
>
>
> Key: CASSANDRA-15287
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15287
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
>Reporter: DeepakVohra
>Assignee: Josh Turner
>Priority: Normal
> Attachments: 15287.trunk, 15287.trunk.withchanges
>
>
> 1. Create a keyspace _cqlkeyspace_ (arbitrary name)
> 2. Create two tables (t1 and t2)
> 3. Run _nodetool snapshot_ to create snapshot for multiple tables in same
> command. Include the keyspace name as argument (which is not what the command
> syntax allows)
> {code:java}
> nodetool snapshot --kt-list cqlkeyspace.t1,cqlkeyspace.t2 --tag multi-table
> --cqlkeyspace
> {code}
> 4. Exception message is inaccurate in that it is referring to columnfamily
> when it should be referring to keyspace.
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a
> snapshot, you should not specify columnfamily
> {code}
> Exception message should be:
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a
> snapshot, you should not specify keyspace
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15287) Inaccurate exception message with nodetool snapshot
[
https://issues.apache.org/jira/browse/CASSANDRA-15287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh Turner updated CASSANDRA-15287:
Attachment: 15287.trunk
15287.trunk.withchanges
> Inaccurate exception message with nodetool snapshot
>
>
> Key: CASSANDRA-15287
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15287
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
>Reporter: DeepakVohra
>Assignee: Josh Turner
>Priority: Normal
>
> 1. Create a keyspace _cqlkeyspace_ (arbitrary name)
> 2. Create two tables (t1 and t2)
> 3. Run _nodetool snapshot_ to create snapshot for multiple tables in same
> command. Include the keyspace name as argument (which is not what the command
> syntax allows)
> {code:java}
> nodetool snapshot --kt-list cqlkeyspace.t1,cqlkeyspace.t2 --tag multi-table
> --cqlkeyspace
> {code}
> 4. Exception message is inaccurate in that it is referring to columnfamily
> when it should be referring to keyspace.
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a
> snapshot, you should not specify columnfamily
> {code}
> Exception message should be:
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a
> snapshot, you should not specify keyspace
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15287) Inaccurate exception message with nodetool snapshot
[
https://issues.apache.org/jira/browse/CASSANDRA-15287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh Turner updated CASSANDRA-15287:
Attachment: (was: 15287.trunk)
> Inaccurate exception message with nodetool snapshot
>
>
> Key: CASSANDRA-15287
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15287
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
>Reporter: DeepakVohra
>Assignee: Josh Turner
>Priority: Normal
>
> 1. Create a keyspace _cqlkeyspace_ (arbitrary name)
> 2. Create two tables (t1 and t2)
> 3. Run _nodetool snapshot_ to create snapshot for multiple tables in same
> command. Include the keyspace name as argument (which is not what the command
> syntax allows)
> {code:java}
> nodetool snapshot --kt-list cqlkeyspace.t1,cqlkeyspace.t2 --tag multi-table
> --cqlkeyspace
> {code}
> 4. Exception message is inaccurate in that it is referring to columnfamily
> when it should be referring to keyspace.
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a
> snapshot, you should not specify columnfamily
> {code}
> Exception message should be:
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a
> snapshot, you should not specify keyspace
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15287) Inaccurate exception message with nodetool snapshot
[
https://issues.apache.org/jira/browse/CASSANDRA-15287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh Turner updated CASSANDRA-15287:
Attachment: (was: 15287.trunk.withchanges)
> Inaccurate exception message with nodetool snapshot
>
>
> Key: CASSANDRA-15287
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15287
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
>Reporter: DeepakVohra
>Assignee: Josh Turner
>Priority: Normal
>
> 1. Create a keyspace _cqlkeyspace_ (arbitrary name)
> 2. Create two tables (t1 and t2)
> 3. Run _nodetool snapshot_ to create snapshot for multiple tables in same
> command. Include the keyspace name as argument (which is not what the command
> syntax allows)
> {code:java}
> nodetool snapshot --kt-list cqlkeyspace.t1,cqlkeyspace.t2 --tag multi-table
> --cqlkeyspace
> {code}
> 4. Exception message is inaccurate in that it is referring to columnfamily
> when it should be referring to keyspace.
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a
> snapshot, you should not specify columnfamily
> {code}
> Exception message should be:
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a
> snapshot, you should not specify keyspace
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15287) Inaccurate exception message with nodetool snapshot
[
https://issues.apache.org/jira/browse/CASSANDRA-15287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh Turner updated CASSANDRA-15287:
Bug Category: Parent values: Code(13163)Level 1 values: Bug - Unclear
Impact(13164)
Complexity: Low Hanging Fruit
Discovered By: User Report
Severity: Low
Status: Open (was: Triage Needed)
> Inaccurate exception message with nodetool snapshot
>
>
> Key: CASSANDRA-15287
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15287
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
>Reporter: DeepakVohra
>Assignee: Josh Turner
>Priority: Normal
>
> 1. Create a keyspace _cqlkeyspace_ (arbitrary name)
> 2. Create two tables (t1 and t2)
> 3. Run _nodetool snapshot_ to create snapshot for multiple tables in same
> command. Include the keyspace name as argument (which is not what the command
> syntax allows)
> {code:java}
> nodetool snapshot --kt-list cqlkeyspace.t1,cqlkeyspace.t2 --tag multi-table
> --cqlkeyspace
> {code}
> 4. Exception message is inaccurate in that it is referring to columnfamily
> when it should be referring to keyspace.
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a
> snapshot, you should not specify columnfamily
> {code}
> Exception message should be:
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a
> snapshot, you should not specify keyspace
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-15287) Inaccurate exception message with nodetool snapshot
[
https://issues.apache.org/jira/browse/CASSANDRA-15287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh Turner reassigned CASSANDRA-15287:
---
Assignee: Josh Turner
> Inaccurate exception message with nodetool snapshot
>
>
> Key: CASSANDRA-15287
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15287
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
>Reporter: DeepakVohra
>Assignee: Josh Turner
>Priority: Normal
>
> 1. Create a keyspace _cqlkeyspace_ (arbitrary name)
> 2. Create two tables (t1 and t2)
> 3. Run _nodetool snapshot_ to create snapshot for multiple tables in same
> command. Include the keyspace name as argument (which is not what the command
> syntax allows)
> {code:java}
> nodetool snapshot --kt-list cqlkeyspace.t1,cqlkeyspace.t2 --tag multi-table
> --cqlkeyspace
> {code}
> 4. Exception message is inaccurate in that it is referring to columnfamily
> when it should be referring to keyspace.
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a
> snapshot, you should not specify columnfamily
> {code}
> Exception message should be:
> {code:java}
> java.io.IOException: When specifying the Keyspace columfamily list for a
> snapshot, you should not specify keyspace
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15275) Repair failed due to data corruption in one of the production table
[ https://issues.apache.org/jira/browse/CASSANDRA-15275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913265#comment-16913265 ] Sumit commented on CASSANDRA-15275: --- Can some please update me what are reasons for data corruption?. > Repair failed due to data corruption in one of the production table > --- > > Key: CASSANDRA-15275 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15275 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Sumit >Priority: Normal > Attachments: cassandra_repair_logs > > > Issue description: > We found data corruption in one of table, while performing cluster syncing. > > Corrective actions: > We have performed 'nodetool repair' to sync up the nodes, post removing the > corrupted table. There were two, out of four node, in the cluster was down > before we triggered the 'repair'. However, during the repair all the servers > were live and active. > > We are using Cassandra 3.11.1. > Appreciate your help to pinpoint the issue, and let me know reasons to data > corruption in table and how we can prevent it? > -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15172) LegacyLayout RangeTombstoneList throws IndexOutOfBoundsException
[
https://issues.apache.org/jira/browse/CASSANDRA-15172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
mck updated CASSANDRA-15172:
Since Version: 3.0 alpha 1
Source Control Link:
https://github.com/apache/cassandra/commit/2b10a5f2b5e62f2900119a37e91637916e8b23df
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
Committed as 2b10a5f2b5e62f2900119a37e91637916e8b23df
> LegacyLayout RangeTombstoneList throws IndexOutOfBoundsException
>
>
> Key: CASSANDRA-15172
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15172
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Other
>Reporter: Shalom
>Assignee: Benedict
>Priority: Normal
> Fix For: 3.0.19, 3.11.5
>
>
> Hi All,
> This is the first time I open an issue, so apologies if I'm not following the
> rules properly.
>
> After upgrading a node from version 2.1.21 to 3.11.4, we've started seeing a
> lot of AbstractLocalAwareExecutorService exceptions. This happened right
> after the node successfully started up with the new 3.11.4 binaries.
> {noformat}
> INFO [main] 2019-06-05 04:41:37,730 Gossiper.java:1715 - No gossip backlog;
> proceeding
> INFO [main] 2019-06-05 04:41:38,036 NativeTransportService.java:70 - Netty
> using native Epoll event loop
> INFO [main] 2019-06-05 04:41:38,117 Server.java:155 - Using Netty Version:
> [netty-buffer=netty-buffer-4.0.44.Final.452812a,
> netty-codec=netty-codec-4.0.44.Final.452812a,
> netty-codec-haproxy=netty-codec-haproxy-4.0.44.Final.452812a,
> netty-codec-http=netty-codec-http-4.0.44.Final.452812a,
> netty-codec-socks=netty-codec-socks-4.0.44.Final.452812a,
> netty-common=netty-common-4.0.44.Final.452812a,
> netty-handler=netty-handler-4.0.44.Final.452812a,
> netty-tcnative=netty-tcnative-1.1.33.Fork26.142ecbb,
> netty-transport=netty-transport-4.0.44.Final.452812a,
> netty-transport-native-epoll=netty-transport-native-epoll-4.0.44.Final.452812a,
> netty-transport-rxtx=netty-transport-rxtx-4.0.44.Final.452812a,
> netty-transport-sctp=netty-transport-sctp-4.0.44.Final.452812a,
> netty-transport-udt=netty-transport-udt-4.0.44.Final.452812a]
> INFO [main] 2019-06-05 04:41:38,118 Server.java:156 - Starting listening for
> CQL clients on /0.0.0.0:9042 (unencrypted)...
> INFO [main] 2019-06-05 04:41:38,179 CassandraDaemon.java:556 - Not starting
> RPC server as requested. Use JMX (StorageService->startRPCServer()) or
> nodetool (enablethrift) to start it
> INFO [Native-Transport-Requests-21] 2019-06-05 04:41:39,145
> AuthCache.java:161 - (Re)initializing PermissionsCache (validity
> period/update interval/max entries) (2000/2000/1000)
> INFO [OptionalTasks:1] 2019-06-05 04:41:39,729 CassandraAuthorizer.java:409
> - Converting legacy permissions data
> INFO [HANDSHAKE-/10.10.10.8] 2019-06-05 04:41:39,808
> OutboundTcpConnection.java:561 - Handshaking version with /10.10.10.8
> INFO [HANDSHAKE-/10.10.10.9] 2019-06-05 04:41:39,808
> OutboundTcpConnection.java:561 - Handshaking version with /10.10.10.9
> INFO [HANDSHAKE-dc1_02/10.10.10.6] 2019-06-05 04:41:39,809
> OutboundTcpConnection.java:561 - Handshaking version with dc1_02/10.10.10.6
> WARN [ReadStage-2] 2019-06-05 04:41:39,857
> AbstractLocalAwareExecutorService.java:167 - Uncaught exception on thread
> Thread[ReadStage-2,5,main]: {}
> java.lang.ArrayIndexOutOfBoundsException: 1
> at
> org.apache.cassandra.db.AbstractBufferClusteringPrefix.get(AbstractBufferClusteringPrefix.java:55)
> at
> org.apache.cassandra.db.LegacyLayout$LegacyRangeTombstoneList.serializedSizeCompound(LegacyLayout.java:2545)
> at
> org.apache.cassandra.db.LegacyLayout$LegacyRangeTombstoneList.serializedSize(LegacyLayout.java:2522)
> at
> org.apache.cassandra.db.LegacyLayout.serializedSizeAsLegacyPartition(LegacyLayout.java:565)
> at
> org.apache.cassandra.db.ReadResponse$Serializer.serializedSize(ReadResponse.java:446)
> at
> org.apache.cassandra.db.ReadResponse$Serializer.serializedSize(ReadResponse.java:352)
> at
> org.apache.cassandra.net.MessageOut.payloadSize(MessageOut.java:171)
> at
> org.apache.cassandra.net.OutboundTcpConnectionPool.getConnection(OutboundTcpConnectionPool.java:77)
> at
> org.apache.cassandra.net.MessagingService.getConnection(MessagingService.java:802)
> at
> org.apache.cassandra.net.MessagingService.sendOneWay(MessagingService.java:953)
> at
> org.apache.cassandra.net.MessagingService.sendReply(MessagingService.java:929)
> at
> org.apache.cassandra.db.ReadCommandVerbHandler.doVerb(ReadCommandVerbHandler.java:62)
> at
> org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:66)
> at
>
[jira] [Updated] (CASSANDRA-15172) LegacyLayout RangeTombstoneList throws IndexOutOfBoundsException
[
https://issues.apache.org/jira/browse/CASSANDRA-15172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
mck updated CASSANDRA-15172:
Status: Ready to Commit (was: Review In Progress)
> LegacyLayout RangeTombstoneList throws IndexOutOfBoundsException
>
>
> Key: CASSANDRA-15172
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15172
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Other
>Reporter: Shalom
>Assignee: Benedict
>Priority: Normal
> Fix For: 3.0.19, 3.11.5
>
>
> Hi All,
> This is the first time I open an issue, so apologies if I'm not following the
> rules properly.
>
> After upgrading a node from version 2.1.21 to 3.11.4, we've started seeing a
> lot of AbstractLocalAwareExecutorService exceptions. This happened right
> after the node successfully started up with the new 3.11.4 binaries.
> {noformat}
> INFO [main] 2019-06-05 04:41:37,730 Gossiper.java:1715 - No gossip backlog;
> proceeding
> INFO [main] 2019-06-05 04:41:38,036 NativeTransportService.java:70 - Netty
> using native Epoll event loop
> INFO [main] 2019-06-05 04:41:38,117 Server.java:155 - Using Netty Version:
> [netty-buffer=netty-buffer-4.0.44.Final.452812a,
> netty-codec=netty-codec-4.0.44.Final.452812a,
> netty-codec-haproxy=netty-codec-haproxy-4.0.44.Final.452812a,
> netty-codec-http=netty-codec-http-4.0.44.Final.452812a,
> netty-codec-socks=netty-codec-socks-4.0.44.Final.452812a,
> netty-common=netty-common-4.0.44.Final.452812a,
> netty-handler=netty-handler-4.0.44.Final.452812a,
> netty-tcnative=netty-tcnative-1.1.33.Fork26.142ecbb,
> netty-transport=netty-transport-4.0.44.Final.452812a,
> netty-transport-native-epoll=netty-transport-native-epoll-4.0.44.Final.452812a,
> netty-transport-rxtx=netty-transport-rxtx-4.0.44.Final.452812a,
> netty-transport-sctp=netty-transport-sctp-4.0.44.Final.452812a,
> netty-transport-udt=netty-transport-udt-4.0.44.Final.452812a]
> INFO [main] 2019-06-05 04:41:38,118 Server.java:156 - Starting listening for
> CQL clients on /0.0.0.0:9042 (unencrypted)...
> INFO [main] 2019-06-05 04:41:38,179 CassandraDaemon.java:556 - Not starting
> RPC server as requested. Use JMX (StorageService->startRPCServer()) or
> nodetool (enablethrift) to start it
> INFO [Native-Transport-Requests-21] 2019-06-05 04:41:39,145
> AuthCache.java:161 - (Re)initializing PermissionsCache (validity
> period/update interval/max entries) (2000/2000/1000)
> INFO [OptionalTasks:1] 2019-06-05 04:41:39,729 CassandraAuthorizer.java:409
> - Converting legacy permissions data
> INFO [HANDSHAKE-/10.10.10.8] 2019-06-05 04:41:39,808
> OutboundTcpConnection.java:561 - Handshaking version with /10.10.10.8
> INFO [HANDSHAKE-/10.10.10.9] 2019-06-05 04:41:39,808
> OutboundTcpConnection.java:561 - Handshaking version with /10.10.10.9
> INFO [HANDSHAKE-dc1_02/10.10.10.6] 2019-06-05 04:41:39,809
> OutboundTcpConnection.java:561 - Handshaking version with dc1_02/10.10.10.6
> WARN [ReadStage-2] 2019-06-05 04:41:39,857
> AbstractLocalAwareExecutorService.java:167 - Uncaught exception on thread
> Thread[ReadStage-2,5,main]: {}
> java.lang.ArrayIndexOutOfBoundsException: 1
> at
> org.apache.cassandra.db.AbstractBufferClusteringPrefix.get(AbstractBufferClusteringPrefix.java:55)
> at
> org.apache.cassandra.db.LegacyLayout$LegacyRangeTombstoneList.serializedSizeCompound(LegacyLayout.java:2545)
> at
> org.apache.cassandra.db.LegacyLayout$LegacyRangeTombstoneList.serializedSize(LegacyLayout.java:2522)
> at
> org.apache.cassandra.db.LegacyLayout.serializedSizeAsLegacyPartition(LegacyLayout.java:565)
> at
> org.apache.cassandra.db.ReadResponse$Serializer.serializedSize(ReadResponse.java:446)
> at
> org.apache.cassandra.db.ReadResponse$Serializer.serializedSize(ReadResponse.java:352)
> at
> org.apache.cassandra.net.MessageOut.payloadSize(MessageOut.java:171)
> at
> org.apache.cassandra.net.OutboundTcpConnectionPool.getConnection(OutboundTcpConnectionPool.java:77)
> at
> org.apache.cassandra.net.MessagingService.getConnection(MessagingService.java:802)
> at
> org.apache.cassandra.net.MessagingService.sendOneWay(MessagingService.java:953)
> at
> org.apache.cassandra.net.MessagingService.sendReply(MessagingService.java:929)
> at
> org.apache.cassandra.db.ReadCommandVerbHandler.doVerb(ReadCommandVerbHandler.java:62)
> at
> org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:66)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at
> org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$FutureTask.run(AbstractLocalAwareExecutorService.java:162)
> at
>
[cassandra] branch cassandra-3.0 updated: Fix LegacyLayout RangeTombstoneList IndexOutOfBoundsException when upgrading and RangeTombstone bounds are asymmetric.
This is an automated email from the ASF dual-hosted git repository.
mck pushed a commit to branch cassandra-3.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-3.0 by this push:
new 2b10a5f Fix LegacyLayout RangeTombstoneList IndexOutOfBoundsException
when upgrading and RangeTombstone bounds are asymmetric.
2b10a5f is described below
commit 2b10a5f2b5e62f2900119a37e91637916e8b23df
Author: Benedict Elliott Smith
AuthorDate: Mon Aug 12 14:41:40 2019 +0100
Fix LegacyLayout RangeTombstoneList IndexOutOfBoundsException when
upgrading and RangeTombstone bounds are asymmetric.
patch by Benedict Elliott Smith; reviewed by Mick Semb Wever for
CASSANDRA-15172
---
CHANGES.txt| 1 +
src/java/org/apache/cassandra/db/LegacyLayout.java | 5 ++-
.../org/apache/cassandra/db/LegacyLayoutTest.java | 36 +++---
3 files changed, 34 insertions(+), 8 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index e956796..3f2b4d0 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
3.0.19
+ * Fix LegacyLayout RangeTombstoneList IndexOutOfBoundsException when
upgrading and RangeTombstone bounds are asymmetric (CASSANDRA-15172)
* Fix NPE when using allocate_tokens_for_keyspace on new DC/rack
(CASSANDRA-14952)
* Filter sstables earlier when running cleanup (CASSANDRA-15100)
* Use mean row count instead of mean column count for index selectivity
calculation (CASSANDRA-15259)
diff --git a/src/java/org/apache/cassandra/db/LegacyLayout.java
b/src/java/org/apache/cassandra/db/LegacyLayout.java
index a46aa91..1a03c91 100644
--- a/src/java/org/apache/cassandra/db/LegacyLayout.java
+++ b/src/java/org/apache/cassandra/db/LegacyLayout.java
@@ -2598,11 +2598,10 @@ public abstract class LegacyLayout
CompositeType.Builder startBuilder = type.builder();
CompositeType.Builder endBuilder = type.builder();
-for (int j = 0; j < start.bound.clustering().size(); j++)
-{
+for (int j = 0; j < start.bound.size(); j++)
startBuilder.add(start.bound.get(j));
+for (int j = 0; j < end.bound.size(); j++)
endBuilder.add(end.bound.get(j));
-}
if (start.collectionName != null)
startBuilder.add(start.collectionName.name.bytes);
diff --git a/test/unit/org/apache/cassandra/db/LegacyLayoutTest.java
b/test/unit/org/apache/cassandra/db/LegacyLayoutTest.java
index 580a0e7..77197d3 100644
--- a/test/unit/org/apache/cassandra/db/LegacyLayoutTest.java
+++ b/test/unit/org/apache/cassandra/db/LegacyLayoutTest.java
@@ -25,12 +25,15 @@ import java.nio.file.Path;
import java.nio.file.Paths;
import org.apache.cassandra.db.filter.ColumnFilter;
+import org.apache.cassandra.db.partitions.ImmutableBTreePartition;
import org.apache.cassandra.db.rows.BufferCell;
import org.apache.cassandra.db.rows.Cell;
import org.apache.cassandra.db.rows.RowIterator;
+import org.apache.cassandra.db.rows.Rows;
import org.apache.cassandra.db.rows.SerializationHelper;
import org.apache.cassandra.db.rows.UnfilteredRowIterator;
import org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer;
+import org.apache.cassandra.db.rows.UnfilteredRowIterators;
import org.apache.cassandra.db.transform.FilteredRows;
import org.apache.cassandra.exceptions.ConfigurationException;
import org.apache.cassandra.io.util.DataInputBuffer;
@@ -60,6 +63,7 @@ import org.apache.cassandra.schema.KeyspaceParams;
import org.apache.cassandra.utils.ByteBufferUtil;
import org.apache.cassandra.utils.Hex;
+import static org.apache.cassandra.net.MessagingService.VERSION_21;
import static org.junit.Assert.*;
public class LegacyLayoutTest
@@ -181,10 +185,10 @@ public class LegacyLayoutTest
{
try (DataOutputBuffer out = new DataOutputBuffer())
{
-LegacyLayout.serializeAsLegacyPartition(null, partition, out,
MessagingService.VERSION_21);
+LegacyLayout.serializeAsLegacyPartition(null, partition, out,
VERSION_21);
try (DataInputBuffer in = new DataInputBuffer(out.buffer(), false))
{
-return LegacyLayout.deserializeLegacyPartition(in,
MessagingService.VERSION_21, SerializationHelper.Flag.LOCAL,
partition.partitionKey().getKey());
+return LegacyLayout.deserializeLegacyPartition(in, VERSION_21,
SerializationHelper.Flag.LOCAL, partition.partitionKey().getKey());
}
}
}
@@ -278,11 +282,11 @@ public class LegacyLayoutTest
try (RowIterator before =
FilteredRows.filter(upd.unfilteredIterator(), FBUtilities.nowInSeconds());
DataOutputBuffer serialized21 = new DataOutputBuffer())
{
-LegacyLayout.serializeAsLegacyPartition(null,
upd.unfilteredIterator(), serialized21,
[cassandra] 01/01: Merge branch 'cassandra-3.11' into trunk
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit cf552941795c9883da359bda6017497ae33adafe Merge: db2ad0f 0bea2fa Author: Mick Semb Wever AuthorDate: Thu Aug 22 13:35:10 2019 +0200 Merge branch 'cassandra-3.11' into trunk CHANGES.txt | 1 + 1 file changed, 1 insertion(+) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.0' into cassandra-3.11
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 0bea2fac8c117b9701978070f591c1b328dba39a Merge: 3df63ed 2b10a5f Author: Mick Semb Wever AuthorDate: Thu Aug 22 10:54:40 2019 +0200 Merge branch 'cassandra-3.0' into cassandra-3.11 CHANGES.txt| 1 + src/java/org/apache/cassandra/db/LegacyLayout.java | 5 ++- .../org/apache/cassandra/db/LegacyLayoutTest.java | 36 +++--- 3 files changed, 34 insertions(+), 8 deletions(-) diff --cc CHANGES.txt index 772446d,3f2b4d0..2a56985 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,9 -1,5 +1,10 @@@ -3.0.19 +3.11.5 + * Make sure user defined compaction transactions are always closed (CASSANDRA-15123) + * Fix cassandra-env.sh to use $CASSANDRA_CONF to find cassandra-jaas.config (CASSANDRA-14305) + * Fixed nodetool cfstats printing index name twice (CASSANDRA-14903) + * Add flag to disable SASI indexes, and warnings on creation (CASSANDRA-14866) +Merged from 3.0: + * Fix LegacyLayout RangeTombstoneList IndexOutOfBoundsException when upgrading and RangeTombstone bounds are asymmetric (CASSANDRA-15172) * Fix NPE when using allocate_tokens_for_keyspace on new DC/rack (CASSANDRA-14952) * Filter sstables earlier when running cleanup (CASSANDRA-15100) * Use mean row count instead of mean column count for index selectivity calculation (CASSANDRA-15259) diff --cc test/unit/org/apache/cassandra/db/LegacyLayoutTest.java index a119b29,77197d3..4058b03 --- a/test/unit/org/apache/cassandra/db/LegacyLayoutTest.java +++ b/test/unit/org/apache/cassandra/db/LegacyLayoutTest.java @@@ -24,8 -24,8 +24,9 @@@ import java.nio.file.Files import java.nio.file.Path; import java.nio.file.Paths; +import org.junit.AfterClass; import org.apache.cassandra.db.filter.ColumnFilter; + import org.apache.cassandra.db.partitions.ImmutableBTreePartition; import org.apache.cassandra.db.rows.BufferCell; import org.apache.cassandra.db.rows.Cell; import org.apache.cassandra.db.rows.RowIterator; - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (db2ad0f -> cf55294)
This is an automated email from the ASF dual-hosted git repository. mck pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from db2ad0f Rename StatsMetadata estimatedColumnCount to estimatedCellPerPartitionCount new 2b10a5f Fix LegacyLayout RangeTombstoneList IndexOutOfBoundsException when upgrading and RangeTombstone bounds are asymmetric. new 0bea2fa Merge branch 'cassandra-3.0' into cassandra-3.11 new cf55294 Merge branch 'cassandra-3.11' into trunk The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt | 1 + 1 file changed, 1 insertion(+) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.11 updated (3df63ed -> 0bea2fa)
This is an automated email from the ASF dual-hosted git repository. mck pushed a change to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 3df63ed Merge branch 'cassandra-3.0' into cassandra-3.11 new 2b10a5f Fix LegacyLayout RangeTombstoneList IndexOutOfBoundsException when upgrading and RangeTombstone bounds are asymmetric. new 0bea2fa Merge branch 'cassandra-3.0' into cassandra-3.11 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + src/java/org/apache/cassandra/db/LegacyLayout.java | 5 ++- .../org/apache/cassandra/db/LegacyLayoutTest.java | 36 +++--- 3 files changed, 34 insertions(+), 8 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15172) LegacyLayout RangeTombstoneList throws IndexOutOfBoundsException
[
https://issues.apache.org/jira/browse/CASSANDRA-15172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
mck updated CASSANDRA-15172:
Fix Version/s: (was: 4.0)
> LegacyLayout RangeTombstoneList throws IndexOutOfBoundsException
>
>
> Key: CASSANDRA-15172
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15172
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Other
>Reporter: Shalom
>Assignee: Benedict
>Priority: Normal
> Fix For: 3.0.19, 3.11.5
>
>
> Hi All,
> This is the first time I open an issue, so apologies if I'm not following the
> rules properly.
>
> After upgrading a node from version 2.1.21 to 3.11.4, we've started seeing a
> lot of AbstractLocalAwareExecutorService exceptions. This happened right
> after the node successfully started up with the new 3.11.4 binaries.
> {noformat}
> INFO [main] 2019-06-05 04:41:37,730 Gossiper.java:1715 - No gossip backlog;
> proceeding
> INFO [main] 2019-06-05 04:41:38,036 NativeTransportService.java:70 - Netty
> using native Epoll event loop
> INFO [main] 2019-06-05 04:41:38,117 Server.java:155 - Using Netty Version:
> [netty-buffer=netty-buffer-4.0.44.Final.452812a,
> netty-codec=netty-codec-4.0.44.Final.452812a,
> netty-codec-haproxy=netty-codec-haproxy-4.0.44.Final.452812a,
> netty-codec-http=netty-codec-http-4.0.44.Final.452812a,
> netty-codec-socks=netty-codec-socks-4.0.44.Final.452812a,
> netty-common=netty-common-4.0.44.Final.452812a,
> netty-handler=netty-handler-4.0.44.Final.452812a,
> netty-tcnative=netty-tcnative-1.1.33.Fork26.142ecbb,
> netty-transport=netty-transport-4.0.44.Final.452812a,
> netty-transport-native-epoll=netty-transport-native-epoll-4.0.44.Final.452812a,
> netty-transport-rxtx=netty-transport-rxtx-4.0.44.Final.452812a,
> netty-transport-sctp=netty-transport-sctp-4.0.44.Final.452812a,
> netty-transport-udt=netty-transport-udt-4.0.44.Final.452812a]
> INFO [main] 2019-06-05 04:41:38,118 Server.java:156 - Starting listening for
> CQL clients on /0.0.0.0:9042 (unencrypted)...
> INFO [main] 2019-06-05 04:41:38,179 CassandraDaemon.java:556 - Not starting
> RPC server as requested. Use JMX (StorageService->startRPCServer()) or
> nodetool (enablethrift) to start it
> INFO [Native-Transport-Requests-21] 2019-06-05 04:41:39,145
> AuthCache.java:161 - (Re)initializing PermissionsCache (validity
> period/update interval/max entries) (2000/2000/1000)
> INFO [OptionalTasks:1] 2019-06-05 04:41:39,729 CassandraAuthorizer.java:409
> - Converting legacy permissions data
> INFO [HANDSHAKE-/10.10.10.8] 2019-06-05 04:41:39,808
> OutboundTcpConnection.java:561 - Handshaking version with /10.10.10.8
> INFO [HANDSHAKE-/10.10.10.9] 2019-06-05 04:41:39,808
> OutboundTcpConnection.java:561 - Handshaking version with /10.10.10.9
> INFO [HANDSHAKE-dc1_02/10.10.10.6] 2019-06-05 04:41:39,809
> OutboundTcpConnection.java:561 - Handshaking version with dc1_02/10.10.10.6
> WARN [ReadStage-2] 2019-06-05 04:41:39,857
> AbstractLocalAwareExecutorService.java:167 - Uncaught exception on thread
> Thread[ReadStage-2,5,main]: {}
> java.lang.ArrayIndexOutOfBoundsException: 1
> at
> org.apache.cassandra.db.AbstractBufferClusteringPrefix.get(AbstractBufferClusteringPrefix.java:55)
> at
> org.apache.cassandra.db.LegacyLayout$LegacyRangeTombstoneList.serializedSizeCompound(LegacyLayout.java:2545)
> at
> org.apache.cassandra.db.LegacyLayout$LegacyRangeTombstoneList.serializedSize(LegacyLayout.java:2522)
> at
> org.apache.cassandra.db.LegacyLayout.serializedSizeAsLegacyPartition(LegacyLayout.java:565)
> at
> org.apache.cassandra.db.ReadResponse$Serializer.serializedSize(ReadResponse.java:446)
> at
> org.apache.cassandra.db.ReadResponse$Serializer.serializedSize(ReadResponse.java:352)
> at
> org.apache.cassandra.net.MessageOut.payloadSize(MessageOut.java:171)
> at
> org.apache.cassandra.net.OutboundTcpConnectionPool.getConnection(OutboundTcpConnectionPool.java:77)
> at
> org.apache.cassandra.net.MessagingService.getConnection(MessagingService.java:802)
> at
> org.apache.cassandra.net.MessagingService.sendOneWay(MessagingService.java:953)
> at
> org.apache.cassandra.net.MessagingService.sendReply(MessagingService.java:929)
> at
> org.apache.cassandra.db.ReadCommandVerbHandler.doVerb(ReadCommandVerbHandler.java:62)
> at
> org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:66)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at
> org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$FutureTask.run(AbstractLocalAwareExecutorService.java:162)
> at
>
[jira] [Updated] (CASSANDRA-15186) InternodeOutboundMetrics overloaded bytes/count mixup
[ https://issues.apache.org/jira/browse/CASSANDRA-15186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Jirsa updated CASSANDRA-15186: --- Bug Category: Parent values: Code(13163)Level 1 values: Bug - Unclear Impact(13164) Discovered By: User Report Severity: Low Status: Open (was: Triage Needed) > InternodeOutboundMetrics overloaded bytes/count mixup > - > > Key: CASSANDRA-15186 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15186 > Project: Cassandra > Issue Type: Bug > Components: Observability/Metrics >Reporter: Marcus Olsson >Assignee: Josh Turner >Priority: Normal > Attachments: 15186-trunk.txt > > > In > [https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/metrics/InternodeOutboundMetrics.java] > there is a small mixup between overloaded count and bytes, in > [LargeMessageDroppedTasksDueToOverload|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/metrics/InternodeOutboundMetrics.java#L129] > and > [UrgentMessageDroppedTasksDueToOverload|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/metrics/InternodeOutboundMetrics.java#L151]. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15186) InternodeOutboundMetrics overloaded bytes/count mixup
[ https://issues.apache.org/jira/browse/CASSANDRA-15186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Jirsa updated CASSANDRA-15186: --- Test and Documentation Plan: N/A Status: Patch Available (was: Open) > InternodeOutboundMetrics overloaded bytes/count mixup > - > > Key: CASSANDRA-15186 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15186 > Project: Cassandra > Issue Type: Bug > Components: Observability/Metrics >Reporter: Marcus Olsson >Assignee: Josh Turner >Priority: Normal > Attachments: 15186-trunk.txt > > > In > [https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/metrics/InternodeOutboundMetrics.java] > there is a small mixup between overloaded count and bytes, in > [LargeMessageDroppedTasksDueToOverload|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/metrics/InternodeOutboundMetrics.java#L129] > and > [UrgentMessageDroppedTasksDueToOverload|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/metrics/InternodeOutboundMetrics.java#L151]. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-15186) InternodeOutboundMetrics overloaded bytes/count mixup
[ https://issues.apache.org/jira/browse/CASSANDRA-15186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Jirsa reassigned CASSANDRA-15186: -- Assignee: Josh Turner > InternodeOutboundMetrics overloaded bytes/count mixup > - > > Key: CASSANDRA-15186 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15186 > Project: Cassandra > Issue Type: Bug > Components: Observability/Metrics >Reporter: Marcus Olsson >Assignee: Josh Turner >Priority: Normal > Attachments: 15186-trunk.txt > > > In > [https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/metrics/InternodeOutboundMetrics.java] > there is a small mixup between overloaded count and bytes, in > [LargeMessageDroppedTasksDueToOverload|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/metrics/InternodeOutboundMetrics.java#L129] > and > [UrgentMessageDroppedTasksDueToOverload|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/metrics/InternodeOutboundMetrics.java#L151]. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15172) LegacyLayout RangeTombstoneList throws IndexOutOfBoundsException
[
https://issues.apache.org/jira/browse/CASSANDRA-15172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
mck updated CASSANDRA-15172:
Fix Version/s: 4.0
3.11.5
3.0.19
> LegacyLayout RangeTombstoneList throws IndexOutOfBoundsException
>
>
> Key: CASSANDRA-15172
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15172
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Other
>Reporter: Shalom
>Assignee: Benedict
>Priority: Normal
> Fix For: 3.0.19, 3.11.5, 4.0
>
>
> Hi All,
> This is the first time I open an issue, so apologies if I'm not following the
> rules properly.
>
> After upgrading a node from version 2.1.21 to 3.11.4, we've started seeing a
> lot of AbstractLocalAwareExecutorService exceptions. This happened right
> after the node successfully started up with the new 3.11.4 binaries.
> {noformat}
> INFO [main] 2019-06-05 04:41:37,730 Gossiper.java:1715 - No gossip backlog;
> proceeding
> INFO [main] 2019-06-05 04:41:38,036 NativeTransportService.java:70 - Netty
> using native Epoll event loop
> INFO [main] 2019-06-05 04:41:38,117 Server.java:155 - Using Netty Version:
> [netty-buffer=netty-buffer-4.0.44.Final.452812a,
> netty-codec=netty-codec-4.0.44.Final.452812a,
> netty-codec-haproxy=netty-codec-haproxy-4.0.44.Final.452812a,
> netty-codec-http=netty-codec-http-4.0.44.Final.452812a,
> netty-codec-socks=netty-codec-socks-4.0.44.Final.452812a,
> netty-common=netty-common-4.0.44.Final.452812a,
> netty-handler=netty-handler-4.0.44.Final.452812a,
> netty-tcnative=netty-tcnative-1.1.33.Fork26.142ecbb,
> netty-transport=netty-transport-4.0.44.Final.452812a,
> netty-transport-native-epoll=netty-transport-native-epoll-4.0.44.Final.452812a,
> netty-transport-rxtx=netty-transport-rxtx-4.0.44.Final.452812a,
> netty-transport-sctp=netty-transport-sctp-4.0.44.Final.452812a,
> netty-transport-udt=netty-transport-udt-4.0.44.Final.452812a]
> INFO [main] 2019-06-05 04:41:38,118 Server.java:156 - Starting listening for
> CQL clients on /0.0.0.0:9042 (unencrypted)...
> INFO [main] 2019-06-05 04:41:38,179 CassandraDaemon.java:556 - Not starting
> RPC server as requested. Use JMX (StorageService->startRPCServer()) or
> nodetool (enablethrift) to start it
> INFO [Native-Transport-Requests-21] 2019-06-05 04:41:39,145
> AuthCache.java:161 - (Re)initializing PermissionsCache (validity
> period/update interval/max entries) (2000/2000/1000)
> INFO [OptionalTasks:1] 2019-06-05 04:41:39,729 CassandraAuthorizer.java:409
> - Converting legacy permissions data
> INFO [HANDSHAKE-/10.10.10.8] 2019-06-05 04:41:39,808
> OutboundTcpConnection.java:561 - Handshaking version with /10.10.10.8
> INFO [HANDSHAKE-/10.10.10.9] 2019-06-05 04:41:39,808
> OutboundTcpConnection.java:561 - Handshaking version with /10.10.10.9
> INFO [HANDSHAKE-dc1_02/10.10.10.6] 2019-06-05 04:41:39,809
> OutboundTcpConnection.java:561 - Handshaking version with dc1_02/10.10.10.6
> WARN [ReadStage-2] 2019-06-05 04:41:39,857
> AbstractLocalAwareExecutorService.java:167 - Uncaught exception on thread
> Thread[ReadStage-2,5,main]: {}
> java.lang.ArrayIndexOutOfBoundsException: 1
> at
> org.apache.cassandra.db.AbstractBufferClusteringPrefix.get(AbstractBufferClusteringPrefix.java:55)
> at
> org.apache.cassandra.db.LegacyLayout$LegacyRangeTombstoneList.serializedSizeCompound(LegacyLayout.java:2545)
> at
> org.apache.cassandra.db.LegacyLayout$LegacyRangeTombstoneList.serializedSize(LegacyLayout.java:2522)
> at
> org.apache.cassandra.db.LegacyLayout.serializedSizeAsLegacyPartition(LegacyLayout.java:565)
> at
> org.apache.cassandra.db.ReadResponse$Serializer.serializedSize(ReadResponse.java:446)
> at
> org.apache.cassandra.db.ReadResponse$Serializer.serializedSize(ReadResponse.java:352)
> at
> org.apache.cassandra.net.MessageOut.payloadSize(MessageOut.java:171)
> at
> org.apache.cassandra.net.OutboundTcpConnectionPool.getConnection(OutboundTcpConnectionPool.java:77)
> at
> org.apache.cassandra.net.MessagingService.getConnection(MessagingService.java:802)
> at
> org.apache.cassandra.net.MessagingService.sendOneWay(MessagingService.java:953)
> at
> org.apache.cassandra.net.MessagingService.sendReply(MessagingService.java:929)
> at
> org.apache.cassandra.db.ReadCommandVerbHandler.doVerb(ReadCommandVerbHandler.java:62)
> at
> org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:66)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at
> org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$FutureTask.run(AbstractLocalAwareExecutorService.java:162)
>
