[jira] [Updated] (CASSANDRA-15427) 2.2 eclipse-warnings
[ https://issues.apache.org/jira/browse/CASSANDRA-15427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-15427: --- Fix Version/s: (was: 2.2.x) 2.2.16 Since Version: 2.2.0 beta 1 Source Control Link: https://github.com/apache/cassandra/commit/f05bf64fc1606beeba5b26ffdb63207fec549238 Resolution: Fixed Status: Resolved (was: Ready to Commit) Committed as f05bf64fc1606beeba5b26ffdb63207fec549238 > 2.2 eclipse-warnings > > > Key: CASSANDRA-15427 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15427 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 2.2.16 > > > Cassandra-2.2 artifact builds are failing from eclipse-warnings. > {noformat} > # 11/11/19 2:58:41 PM UTC > # Eclipse Compiler for Java(TM) v20150120-1634, 3.10.2, Copyright IBM Corp > 2000, 2013. All rights reserved. > incorrect classpath: > /home/jenkins/jenkins-slave/workspace/Cassandra-2.2-artifacts/build/cobertura/classes > -- > 1. ERROR in > /home/jenkins/jenkins-slave/workspace/Cassandra-2.2-artifacts/src/java/org/apache/cassandra/db/compaction/CompactionManager.java > (at line 880) > ISSTableScanner scanner = cleanupStrategy.getScanner(sstable, > getRateLimiter()); > ^^^ > Resource 'scanner' should be managed by try-with-resource > -- > -- > 2. ERROR in > /home/jenkins/jenkins-slave/workspace/Cassandra-2.2-artifacts/src/java/org/apache/cassandra/db/compaction/LeveledCompactionStrategy.java > (at line 257) > scanners.add(new LeveledScanner(intersecting, range)); >^^^ > Potential resource leak: '' may not be closed > -- > -- > 3. ERROR in > /home/jenkins/jenkins-slave/workspace/Cassandra-2.2-artifacts/src/java/org/apache/cassandra/tools/SSTableExport.java > (at line 315) > ISSTableScanner scanner = reader.getScanner(); > ^^^ > Resource 'scanner' should be managed by try-with-resource > -- > 3 problems (3 errors) > {noformat} > ref: > https://builds.apache.org/job/Cassandra-2.2-artifacts/180/artifact/build/ecj/eclipse_compiler_checks.txt -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.11' into trunk
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit afde17be282be068d4742f30691537a3f9270c99 Merge: 26a913f 9391ffa Author: Mick Semb Wever AuthorDate: Fri Nov 15 07:31:54 2019 +0100 Merge branch 'cassandra-3.11' into trunk - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-2.2' into cassandra-3.0
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch cassandra-3.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 9e8c17627f6ba67f3a850b1d02ab4245294ae51a Merge: 01b52de f05bf64 Author: Mick Semb Wever AuthorDate: Fri Nov 15 07:30:04 2019 +0100 Merge branch 'cassandra-2.2' into cassandra-3.0 - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.11 updated (91b8a89 -> 9391ffa)
This is an automated email from the ASF dual-hosted git repository. mck pushed a change to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 91b8a89 Merge branch 'cassandra-3.0' into cassandra-3.11 new f05bf64 Fix 2.2 eclipse-warnings new 9e8c176 Merge branch 'cassandra-2.2' into cassandra-3.0 new 9391ffa Merge branch 'cassandra-3.0' into cassandra-3.11 The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-2.2 updated: Fix 2.2 eclipse-warnings
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch cassandra-2.2 in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/cassandra-2.2 by this push: new f05bf64 Fix 2.2 eclipse-warnings f05bf64 is described below commit f05bf64fc1606beeba5b26ffdb63207fec549238 Author: Mick Semb Wever AuthorDate: Thu Nov 14 15:33:36 2019 +0100 Fix 2.2 eclipse-warnings patch by Mick Semb Wever; reviewed by Benedict for CASSANDRA-15427 --- src/java/org/apache/cassandra/db/compaction/CompactionManager.java | 1 + .../apache/cassandra/db/compaction/LeveledCompactionStrategy.java | 1 + src/java/org/apache/cassandra/tools/SSTableExport.java | 7 +-- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/java/org/apache/cassandra/db/compaction/CompactionManager.java b/src/java/org/apache/cassandra/db/compaction/CompactionManager.java index bd34b1f..46f0acf 100644 --- a/src/java/org/apache/cassandra/db/compaction/CompactionManager.java +++ b/src/java/org/apache/cassandra/db/compaction/CompactionManager.java @@ -844,6 +844,7 @@ public class CompactionManager implements CompactionManagerMBean * * @throws IOException */ +@SuppressWarnings("resource") private void doCleanupOne(final ColumnFamilyStore cfs, LifecycleTransaction txn, CleanupStrategy cleanupStrategy, Collection> ranges, boolean hasIndexes) throws IOException { assert !cfs.isIndex(); diff --git a/src/java/org/apache/cassandra/db/compaction/LeveledCompactionStrategy.java b/src/java/org/apache/cassandra/db/compaction/LeveledCompactionStrategy.java index bdc9141..6daea36 100644 --- a/src/java/org/apache/cassandra/db/compaction/LeveledCompactionStrategy.java +++ b/src/java/org/apache/cassandra/db/compaction/LeveledCompactionStrategy.java @@ -215,6 +215,7 @@ public class LeveledCompactionStrategy extends AbstractCompactionStrategy return maxSSTableSizeInMB * 1024L * 1024L; } +@SuppressWarnings("resource") public ScannerList getScanners(Collection sstables, Range range) { Set[] sstablesPerLevel = manifest.getSStablesPerLevelSnapshot(); diff --git a/src/java/org/apache/cassandra/tools/SSTableExport.java b/src/java/org/apache/cassandra/tools/SSTableExport.java index 58070e6..50d6611 100644 --- a/src/java/org/apache/cassandra/tools/SSTableExport.java +++ b/src/java/org/apache/cassandra/tools/SSTableExport.java @@ -312,8 +312,7 @@ public class SSTableExport excludeSet = new HashSet<>(Arrays.asList(excludes)); SSTableIdentityIterator row; -ISSTableScanner scanner = reader.getScanner(); -try +try (ISSTableScanner scanner = reader.getScanner()) { outs.println("["); @@ -340,10 +339,6 @@ public class SSTableExport outs.println("\n]"); outs.flush(); } -finally -{ -scanner.close(); -} } /** - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (26a913f -> afde17b)
This is an automated email from the ASF dual-hosted git repository. mck pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 26a913f Merge branch 'cassandra-3.11' into trunk new f05bf64 Fix 2.2 eclipse-warnings new 9e8c176 Merge branch 'cassandra-2.2' into cassandra-3.0 new 9391ffa Merge branch 'cassandra-3.0' into cassandra-3.11 new afde17b Merge branch 'cassandra-3.11' into trunk The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.0' into cassandra-3.11
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 9391ffaf01ee6c079c48c92443de3f98ee6b007a Merge: 91b8a89 9e8c176 Author: Mick Semb Wever AuthorDate: Fri Nov 15 07:31:21 2019 +0100 Merge branch 'cassandra-3.0' into cassandra-3.11 - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.0 updated (01b52de -> 9e8c176)
This is an automated email from the ASF dual-hosted git repository. mck pushed a change to branch cassandra-3.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 01b52de Make note of replicate_on_write and populate_io_cache_on_flush table options removal in NEWS.txt new f05bf64 Fix 2.2 eclipse-warnings new 9e8c176 Merge branch 'cassandra-2.2' into cassandra-3.0 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15429) Support NodeTool for in-jvm dtest
Yifan Cai created CASSANDRA-15429: - Summary: Support NodeTool for in-jvm dtest Key: CASSANDRA-15429 URL: https://issues.apache.org/jira/browse/CASSANDRA-15429 Project: Cassandra Issue Type: New Feature Components: Test/dtest Reporter: Yifan Cai Assignee: Yifan Cai In-JVM dtest framework does not support nodetool as of now. This functionality is wanted in some tests, e.g. constructing an end-to-end test scenario that uses nodetool. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15423) CVE-2015-2156 (Netty is vulnerable to Information Disclosure)
[ https://issues.apache.org/jira/browse/CASSANDRA-15423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974783#comment-16974783 ] Abhishek Singh commented on CASSANDRA-15423: Thanks Dinesh. I took a note of it. > CVE-2015-2156 (Netty is vulnerable to Information Disclosure) > -- > > Key: CASSANDRA-15423 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15423 > Project: Cassandra > Issue Type: Bug >Reporter: Abhishek Singh >Priority: Normal > > *Description :**Description :* *Severity :* CVE CVSS 3.0: 7.5Sonatype CVSS > 3.0: 7.5 > > *Weakness :* CVE CWE: 20 > > *Source :* National Vulnerability Database > > *Categories :* Data > *Description from CVE :* Netty before 3.9.8.Final, 3.10.x before > 3.10.3.Final, 4.0.x before 4.0.28.Final, and 4.1.x before 4.1.0.Beta5 and > Play Framework 2.x before 2.3.9 might allow remote attackers to bypass the > httpOnly flag on cookies and obtain sensitive information by leveraging > improper validation of cookie name and value characters. > > *Explanation :* Netty is vulnerable to Information Disclosure.Multiple > methods in multiple files improperly validate cookie names and values. This > allows the presence of single-quote and double-quote characters to break > tokenization.A remote attacker can exploit this vulnerability by inducing a > victim to send a crafted request containing quote characters in any parameter > value that sets a cookie.If that tainted cookie gets reflected in the > response, the attacker can then use Cross-Site Scripting (XSS) to potentially > retrieve the entire cookie header, despite the presence of an HttpOnly flag. > The Sonatype security research team discovered that the vulnerability is > present in all versions prior to 3.9.7.Final and 3.10.x before 3.10.2.Final, > and not in all the versions before 3.9.8.Final and 3.10.x before 3.10.3.Final > as the advisory states. > *Detection :* The application is vulnerable by using this component if it > reflects any cookie information in a HTML page, and that page is also prone > to Cross-Site Scripting (XSS) attacks. > *Recommendation :* We recommend upgrading to a version of this component > that is not vulnerable to this specific issue. > *Root Cause :* Cassandra-2.2.5.nupkgCookieDecoder.class : [5.0.0.Alpha1, > 5.0.0.Alpha2) > > *Advisories :* Project: > https://engineering.linkedin.com/security/look-netty_s-recen... > > *CVSS Details :* CVE CVSS 3.0: 7.5 > *Occurences (Paths) :* [" apache-cassandra.zip/bin/cassandra.in.bat" ; " > apache-cassandra.zip/bin/cassandra.in.sh" ; " > apache-cassandra.zip/bin/cqlsh.bat" ; " > apache-cassandra.zip/bin/debug-cql.bat" ; " > apache-cassandra.zip/bin/source-conf.ps1" ; " > apache-cassandra.zip/bin/sstableloader.bat" ; " > apache-cassandra.zip/bin/sstablescrub.bat" ; " > apache-cassandra.zip/bin/sstableupgrade.bat" ; " > apache-cassandra.zip/bin/sstableverify.bat" ; " > apache-cassandra.zip/bin/stop-server" ; " > apache-cassandra.zip/bin/stop-server.bat" ; " > apache-cassandra.zip/bin/stop-server.ps1" ; " > apache-cassandra.zip/conf/README.txt" ; " > apache-cassandra.zip/conf/cassandra-rackdc.properties" ; " > apache-cassandra.zip/conf/cassandra-topology.properties" ; " > apache-cassandra.zip/conf/commitlog_archiving.properties" ; " > apache-cassandra.zip/conf/triggers/README.txt" ; " > apache-cassandra.zip/lib/ST4-4.0.8.jar" ; " > apache-cassandra.zip/lib/airline-0.6.jar" ; " > apache-cassandra.zip/lib/antlr-runtime-3.5.2.jar" ; " > apache-cassandra.zip/lib/commons-cli-1.1.jar" ; " > apache-cassandra.zip/lib/commons-lang3-3.1.jar" ; " > apache-cassandra.zip/lib/commons-math3-3.2.jar" ; " > apache-cassandra.zip/lib/compress-lzf-0.8.4.jar" ; " > apache-cassandra.zip/lib/concurrentlinkedhashmap-lru-1.4.jar" ; " > apache-cassandra.zip/lib/disruptor-3.0.1.jar" ; " > apache-cassandra.zip/lib/ecj-4.4.2.jar" ; " > apache-cassandra.zip/lib/futures-2.1.6-py2.py3-none-any.zip" ; " > apache-cassandra.zip/lib/high-scale-lib-1.0.6.jar" ; " > apache-cassandra.zip/lib/jamm-0.3.0.jar" ; " > apache-cassandra.zip/lib/javax.inject.jar" ; " > apache-cassandra.zip/lib/jbcrypt-0.3m.jar" ; " > apache-cassandra.zip/lib/jcl-over-slf4j-1.7.7.jar" ; " > apache-cassandra.zip/lib/joda-time-2.4.jar" ; " > apache-cassandra.zip/lib/json-simple-1.1.jar" ; " > apache-cassandra.zip/lib/libthrift-0.9.2.jar" ; " > apache-cassandra.zip/lib/licenses/ST4-4.0.8.txt" ; " > apache-cassandra.zip/lib/licenses/antlr-runtime-3.5.2.txt" ; " > apache-cassandra.zip/lib/licenses/compress-lzf-0.8.4.txt" ; " > apache-cassandra.zip/lib/licenses/concurrent-trees-2.4.0.txt" ; " > apache-cassandra.zip/lib/licenses/ecj-4.4.2.txt" ; " > apache-cassandra.zip/lib/licenses/futures-2.1.6.txt" ; " >
[jira] [Assigned] (CASSANDRA-13990) Remove OldNetworkTopologyStrategy
[ https://issues.apache.org/jira/browse/CASSANDRA-13990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anthony Grasso reassigned CASSANDRA-13990: -- Assignee: Anthony Grasso (was: Pedro Gordo) > Remove OldNetworkTopologyStrategy > - > > Key: CASSANDRA-13990 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13990 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: Jeremy Hanna >Assignee: Anthony Grasso >Priority: Low > Labels: lhf > Attachments: 13990-trunk.txt > > > RackAwareStrategy was renamed OldNetworkTopologyStrategy back in 0.7 > (CASSANDRA-1392) and it's still around. Is there any reason to keep this > relatively dead code in the codebase at this point? I'm not aware of its use > and it sometimes confuses users. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15428) First of the new features - Support for Java 11
[ https://issues.apache.org/jira/browse/CASSANDRA-15428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DeepakVohra updated CASSANDRA-15428: Description: A pull request for first of the new features in 4.0. - As 4.0 is a major release created a new folder called "new" and added _new/index_ to the top-level _index.rst_ - Added _java11.rst_ to the _new_ folder for the new feature _Support for Java 11_ - Added a _index.rst_ to the _new_ folder https://github.com/apache/cassandra/pull/383 was: A pull request for first of the new features in 4.0. - As 4.0 is a major release created a new folder called "new" and added _new/index_ to the top-level _index.rst_ - Added _java11.rst _ to the _new_ folder for the new feature _Support for Java 11_ - Added a _index.rst_ to the _new_ folder https://github.com/apache/cassandra/pull/383 > First of the new features - Support for Java 11 > --- > > Key: CASSANDRA-15428 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15428 > Project: Cassandra > Issue Type: Sub-task > Components: Legacy/Documentation and Website >Reporter: DeepakVohra >Assignee: Dinesh Joshi >Priority: Normal > > A pull request for first of the new features in 4.0. > - As 4.0 is a major release created a new folder called "new" and added > _new/index_ to the top-level _index.rst_ > - Added _java11.rst_ to the _new_ folder for the new feature _Support for > Java 11_ > - Added a _index.rst_ to the _new_ folder > https://github.com/apache/cassandra/pull/383 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15428) First of the new features - Support for Java 11
[ https://issues.apache.org/jira/browse/CASSANDRA-15428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DeepakVohra updated CASSANDRA-15428: Description: A pull request for first of the new features in 4.0. - As 4.0 is a major release created a new folder called "new" and added _new/index_ to the top-level _index.rst_ - Added _java11.rst _ to the _new_ folder for the new feature _Support for Java 11_ - Added a _index.rst_ to the _new_ folder https://github.com/apache/cassandra/pull/383 was: A pull request for first of the new features in 4.0. - As 4.0 is a major release created a new folder called "new" and added _new/index_ to the top-level _index.rst_ - Added _java11.rst _to the _new_ folder for the new feature _Support for Java 11_ - Added a _index.rst_ to the _new_ folder https://github.com/apache/cassandra/pull/383 > First of the new features - Support for Java 11 > --- > > Key: CASSANDRA-15428 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15428 > Project: Cassandra > Issue Type: Sub-task > Components: Legacy/Documentation and Website >Reporter: DeepakVohra >Assignee: Dinesh Joshi >Priority: Normal > > A pull request for first of the new features in 4.0. > - As 4.0 is a major release created a new folder called "new" and added > _new/index_ to the top-level _index.rst_ > - Added _java11.rst _ to the _new_ folder for the new feature _Support for > Java 11_ > - Added a _index.rst_ to the _new_ folder > https://github.com/apache/cassandra/pull/383 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15428) First of the new features - Support for Java 11
[ https://issues.apache.org/jira/browse/CASSANDRA-15428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DeepakVohra updated CASSANDRA-15428: Description: A pull request for first of the new features in 4.0. - As 4.0 is a major release created a new folder called "new" and added _new/index_ to the top-level _index.rst_ - Added _java11.rst _to the _new_ folder for the new feature _Support for Java 11_ - Added a _index.rst_ to the _new_ folder https://github.com/apache/cassandra/pull/383 was: A pull request for first of the new features in 4.0. - As 4.0 is a major release created a new folder called "new" and added _new/index_ to the top-level _index.rst_ - Added _java11.rst _to the _new_ folder for the new feature _Support for Java 11_ - Added a _index.rst_ to the _new_ folder > First of the new features - Support for Java 11 > --- > > Key: CASSANDRA-15428 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15428 > Project: Cassandra > Issue Type: Sub-task > Components: Legacy/Documentation and Website >Reporter: DeepakVohra >Assignee: Dinesh Joshi >Priority: Normal > > A pull request for first of the new features in 4.0. > - As 4.0 is a major release created a new folder called "new" and added > _new/index_ to the top-level _index.rst_ > - Added _java11.rst _to the _new_ folder for the new feature _Support for > Java 11_ > - Added a _index.rst_ to the _new_ folder > https://github.com/apache/cassandra/pull/383 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15353) Documentation Preview - Cassandra 4.0
[ https://issues.apache.org/jira/browse/CASSANDRA-15353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974653#comment-16974653 ] DeepakVohra commented on CASSANDRA-15353: - Thanks Dinesh. Added a pull-request for the first of the new features. Please suggest modifications, if any, for the pull-request or the patch submission process. > Documentation Preview - Cassandra 4.0 > - > > Key: CASSANDRA-15353 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15353 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: DeepakVohra >Assignee: Dinesh Joshi >Priority: Normal > > Please review, and add comments to, some of the documentation preview for > Apache Cassandra 4.0. > New Features > --- > *Audit Logging* > https://docs.google.com/document/d/1WsQYjDQ9UZ7f8P3eAATht6Vz5oNibTmhsH8cu9viLTk/edit?usp=sharing > *Full Query Logging* > https://docs.google.com/document/d/1ZNfs68ZNJXqDc_2XGM6W-tpvnejUfSh8HmkbG8u35Es/edit?usp=sharing > *Support for Java 11* > https://docs.google.com/document/d/1v7ffccqk_5Son4iwfuwZae8YUam41quewKi_6Z_PQGw/edit?usp=sharing > *Transient Replication and Cheap Quorums* > https://docs.google.com/document/d/1GyJVCmwoMb7OO9NkbGdk26YxHi9fWtfzuTBTiIEpli8/edit?usp=sharing > *Virtual Tables* > https://docs.google.com/document/d/1U8qAzQnA2HcoIzTg5IXFUySUZXD1tEIl2bam-514we8/edit?usp=sharing > Improvements > > *Improved Streaming* > https://docs.google.com/document/d/1zd6AuHBgC82v598cuDtVIkxJVDV9c0A2rrMEVFHyB4Y/edit?usp=sharing > *Improved Internode Messaging* > https://docs.google.com/document/d/1ub2DBHE7hNEKe4tuCOpdbCZ7qGqCdMAYvSTC-YamuMA/edit?usp=sharing -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15428) First of the new features - Support for Java 11
DeepakVohra created CASSANDRA-15428: --- Summary: First of the new features - Support for Java 11 Key: CASSANDRA-15428 URL: https://issues.apache.org/jira/browse/CASSANDRA-15428 Project: Cassandra Issue Type: Sub-task Components: Legacy/Documentation and Website Reporter: DeepakVohra A pull request for first of the new features in 4.0. - As 4.0 is a major release created a new folder called "new" and added _new/index_ to the top-level _index.rst_ - Added _java11.rst _to the _new_ folder for the new feature _Support for Java 11_ - Added a _index.rst_ to the _new_ folder -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-15428) First of the new features - Support for Java 11
[ https://issues.apache.org/jira/browse/CASSANDRA-15428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DeepakVohra reassigned CASSANDRA-15428: --- Assignee: Dinesh Joshi > First of the new features - Support for Java 11 > --- > > Key: CASSANDRA-15428 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15428 > Project: Cassandra > Issue Type: Sub-task > Components: Legacy/Documentation and Website >Reporter: DeepakVohra >Assignee: Dinesh Joshi >Priority: Normal > > A pull request for first of the new features in 4.0. > - As 4.0 is a major release created a new folder called "new" and added > _new/index_ to the top-level _index.rst_ > - Added _java11.rst _to the _new_ folder for the new feature _Support for > Java 11_ > - Added a _index.rst_ to the _new_ folder -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15423) CVE-2015-2156 (Netty is vulnerable to Information Disclosure)
[ https://issues.apache.org/jira/browse/CASSANDRA-15423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974631#comment-16974631 ] Dinesh Joshi commented on CASSANDRA-15423: -- Thanks for reporting this. While the version of Netty is vulnerable, I don't think Cassandra uses Netty's HTTP classes at all so its unlikely we're vulnerable to the said attack. > CVE-2015-2156 (Netty is vulnerable to Information Disclosure) > -- > > Key: CASSANDRA-15423 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15423 > Project: Cassandra > Issue Type: Bug >Reporter: Abhishek Singh >Priority: Normal > > *Description :**Description :* *Severity :* CVE CVSS 3.0: 7.5Sonatype CVSS > 3.0: 7.5 > > *Weakness :* CVE CWE: 20 > > *Source :* National Vulnerability Database > > *Categories :* Data > *Description from CVE :* Netty before 3.9.8.Final, 3.10.x before > 3.10.3.Final, 4.0.x before 4.0.28.Final, and 4.1.x before 4.1.0.Beta5 and > Play Framework 2.x before 2.3.9 might allow remote attackers to bypass the > httpOnly flag on cookies and obtain sensitive information by leveraging > improper validation of cookie name and value characters. > > *Explanation :* Netty is vulnerable to Information Disclosure.Multiple > methods in multiple files improperly validate cookie names and values. This > allows the presence of single-quote and double-quote characters to break > tokenization.A remote attacker can exploit this vulnerability by inducing a > victim to send a crafted request containing quote characters in any parameter > value that sets a cookie.If that tainted cookie gets reflected in the > response, the attacker can then use Cross-Site Scripting (XSS) to potentially > retrieve the entire cookie header, despite the presence of an HttpOnly flag. > The Sonatype security research team discovered that the vulnerability is > present in all versions prior to 3.9.7.Final and 3.10.x before 3.10.2.Final, > and not in all the versions before 3.9.8.Final and 3.10.x before 3.10.3.Final > as the advisory states. > *Detection :* The application is vulnerable by using this component if it > reflects any cookie information in a HTML page, and that page is also prone > to Cross-Site Scripting (XSS) attacks. > *Recommendation :* We recommend upgrading to a version of this component > that is not vulnerable to this specific issue. > *Root Cause :* Cassandra-2.2.5.nupkgCookieDecoder.class : [5.0.0.Alpha1, > 5.0.0.Alpha2) > > *Advisories :* Project: > https://engineering.linkedin.com/security/look-netty_s-recen... > > *CVSS Details :* CVE CVSS 3.0: 7.5 > *Occurences (Paths) :* [" apache-cassandra.zip/bin/cassandra.in.bat" ; " > apache-cassandra.zip/bin/cassandra.in.sh" ; " > apache-cassandra.zip/bin/cqlsh.bat" ; " > apache-cassandra.zip/bin/debug-cql.bat" ; " > apache-cassandra.zip/bin/source-conf.ps1" ; " > apache-cassandra.zip/bin/sstableloader.bat" ; " > apache-cassandra.zip/bin/sstablescrub.bat" ; " > apache-cassandra.zip/bin/sstableupgrade.bat" ; " > apache-cassandra.zip/bin/sstableverify.bat" ; " > apache-cassandra.zip/bin/stop-server" ; " > apache-cassandra.zip/bin/stop-server.bat" ; " > apache-cassandra.zip/bin/stop-server.ps1" ; " > apache-cassandra.zip/conf/README.txt" ; " > apache-cassandra.zip/conf/cassandra-rackdc.properties" ; " > apache-cassandra.zip/conf/cassandra-topology.properties" ; " > apache-cassandra.zip/conf/commitlog_archiving.properties" ; " > apache-cassandra.zip/conf/triggers/README.txt" ; " > apache-cassandra.zip/lib/ST4-4.0.8.jar" ; " > apache-cassandra.zip/lib/airline-0.6.jar" ; " > apache-cassandra.zip/lib/antlr-runtime-3.5.2.jar" ; " > apache-cassandra.zip/lib/commons-cli-1.1.jar" ; " > apache-cassandra.zip/lib/commons-lang3-3.1.jar" ; " > apache-cassandra.zip/lib/commons-math3-3.2.jar" ; " > apache-cassandra.zip/lib/compress-lzf-0.8.4.jar" ; " > apache-cassandra.zip/lib/concurrentlinkedhashmap-lru-1.4.jar" ; " > apache-cassandra.zip/lib/disruptor-3.0.1.jar" ; " > apache-cassandra.zip/lib/ecj-4.4.2.jar" ; " > apache-cassandra.zip/lib/futures-2.1.6-py2.py3-none-any.zip" ; " > apache-cassandra.zip/lib/high-scale-lib-1.0.6.jar" ; " > apache-cassandra.zip/lib/jamm-0.3.0.jar" ; " > apache-cassandra.zip/lib/javax.inject.jar" ; " > apache-cassandra.zip/lib/jbcrypt-0.3m.jar" ; " > apache-cassandra.zip/lib/jcl-over-slf4j-1.7.7.jar" ; " > apache-cassandra.zip/lib/joda-time-2.4.jar" ; " > apache-cassandra.zip/lib/json-simple-1.1.jar" ; " > apache-cassandra.zip/lib/libthrift-0.9.2.jar" ; " > apache-cassandra.zip/lib/licenses/ST4-4.0.8.txt" ; " > apache-cassandra.zip/lib/licenses/antlr-runtime-3.5.2.txt" ; " > apache-cassandra.zip/lib/licenses/compress-lzf-0.8.4.txt" ; " >
[jira] [Updated] (CASSANDRA-15353) Documentation Preview - Cassandra 4.0
[ https://issues.apache.org/jira/browse/CASSANDRA-15353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRA-15353: - Change Category: Code Clarity Complexity: Low Hanging Fruit Status: Open (was: Triage Needed) Hi Deepak, thanks for all the documentation. I have added a few comments in the docs and we should open a ticket and add a patch for each of the documents you have linked here. I believe we're using the restructured text format. It would be best to create a github PR per doc that you have here. > Documentation Preview - Cassandra 4.0 > - > > Key: CASSANDRA-15353 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15353 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: DeepakVohra >Assignee: Dinesh Joshi >Priority: Normal > > Please review, and add comments to, some of the documentation preview for > Apache Cassandra 4.0. > New Features > --- > *Audit Logging* > https://docs.google.com/document/d/1WsQYjDQ9UZ7f8P3eAATht6Vz5oNibTmhsH8cu9viLTk/edit?usp=sharing > *Full Query Logging* > https://docs.google.com/document/d/1ZNfs68ZNJXqDc_2XGM6W-tpvnejUfSh8HmkbG8u35Es/edit?usp=sharing > *Support for Java 11* > https://docs.google.com/document/d/1v7ffccqk_5Son4iwfuwZae8YUam41quewKi_6Z_PQGw/edit?usp=sharing > *Transient Replication and Cheap Quorums* > https://docs.google.com/document/d/1GyJVCmwoMb7OO9NkbGdk26YxHi9fWtfzuTBTiIEpli8/edit?usp=sharing > *Virtual Tables* > https://docs.google.com/document/d/1U8qAzQnA2HcoIzTg5IXFUySUZXD1tEIl2bam-514we8/edit?usp=sharing > Improvements > > *Improved Streaming* > https://docs.google.com/document/d/1zd6AuHBgC82v598cuDtVIkxJVDV9c0A2rrMEVFHyB4Y/edit?usp=sharing > *Improved Internode Messaging* > https://docs.google.com/document/d/1ub2DBHE7hNEKe4tuCOpdbCZ7qGqCdMAYvSTC-YamuMA/edit?usp=sharing -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15397) IntervalTree performance comparison with Linear Walk and Binary Search based Elimination.
[ https://issues.apache.org/jira/browse/CASSANDRA-15397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chandrasekhar Thumuluru updated CASSANDRA-15397: Attachment: TESTS-TestSuites.xml.lz4 > IntervalTree performance comparison with Linear Walk and Binary Search based > Elimination. > -- > > Key: CASSANDRA-15397 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15397 > Project: Cassandra > Issue Type: Improvement > Components: Local/SSTable >Reporter: Chandrasekhar Thumuluru >Assignee: Chandrasekhar Thumuluru >Priority: Low > Attachments: 95p_1_SSTable_with_5000_Searches.png, > 95p_15000_SSTable_with_5000_Searches.png, > 95p_2_SSTable_with_5000_Searches.png, > 95p_25000_SSTable_with_5000_Searches.png, > 95p_3_SSTable_with_5000_Searches.png, > 95p_5000_SSTable_with_5000_Searches.png, > 99p_1_SSTable_with_5000_Searches.png, > 99p_15000_SSTable_with_5000_Searches.png, > 99p_2_SSTable_with_5000_Searches.png, > 99p_25000_SSTable_with_5000_Searches.png, > 99p_3_SSTable_with_5000_Searches.png, > 99p_5000_SSTable_with_5000_Searches.png, IntervalList.java, > IntervalListWithElimination.java, IntervalTreeSimplified.java, > Mean_1_SSTable_with_5000_Searches.png, > Mean_15000_SSTable_with_5000_Searches.png, > Mean_2_SSTable_with_5000_Searches.png, > Mean_25000_SSTable_with_5000_Searches.png, > Mean_3_SSTable_with_5000_Searches.png, > Mean_5000_SSTable_with_5000_Searches.png, TESTS-TestSuites.xml.lz4, > replace_intervaltree_with_intervallist.patch > > > Cassandra uses IntervalTrees to identify the SSTables that overlap with > search interval. In Cassandra, IntervalTrees are not mutated. They are > recreated each time a mutation is required. This can be an issue during > repairs. In fact we noticed such issues during repair. > Since lists are cache friendly compared to linked lists and trees, I decided > to compare the search performance with: > * Linear Walk. > * Elimination using Binary Search (idea is to eliminate intervals using start > and end points of search interval). > Based on the tests I ran, I noticed Binary Search based elimination almost > always performs similar to IntervalTree or out performs IntervalTree based > search. The cost of IntervalTree construction is also substantial and > produces lot of garbage during repairs. > I ran the tests using random intervals to build the tree/lists and another > randomly generated search interval with 5000 iterations. I'm attaching all > the relevant graphs. The x-axis in the graphs is the search interval > coverage. 10p means the search interval covered 10% of the intervals. The > y-axis is the time the search took in nanos. > PS: > # For the purpose of test, I simplified the IntervalTree by removing the data > portion of the interval. Modified the template version (Java generics) to a > specialized version. > # I used the code from Cassandra version _3.11_. > # Time in the graph is in nanos. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15397) IntervalTree performance comparison with Linear Walk and Binary Search based Elimination.
[ https://issues.apache.org/jira/browse/CASSANDRA-15397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974574#comment-16974574 ] Chandrasekhar Thumuluru commented on CASSANDRA-15397: - [~benedict] — * Attached the patch file with my changes [^replace_intervaltree_with_intervallist.patch]. I used trunk for the patch. * Attached the unit test run results [^TESTS-TestSuites.xml.lz4] . * [Link|https://docs.google.com/document/d/1vwo9ArZbtgWUwJcvZGes_69YVh4yiP9c7NQFgI0iynQ/edit?usp=sharing] to google doc with some details about the proposed algorithm. Please review the changes when you get a chance and let me know your feedback. > IntervalTree performance comparison with Linear Walk and Binary Search based > Elimination. > -- > > Key: CASSANDRA-15397 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15397 > Project: Cassandra > Issue Type: Improvement > Components: Local/SSTable >Reporter: Chandrasekhar Thumuluru >Assignee: Chandrasekhar Thumuluru >Priority: Low > Attachments: 95p_1_SSTable_with_5000_Searches.png, > 95p_15000_SSTable_with_5000_Searches.png, > 95p_2_SSTable_with_5000_Searches.png, > 95p_25000_SSTable_with_5000_Searches.png, > 95p_3_SSTable_with_5000_Searches.png, > 95p_5000_SSTable_with_5000_Searches.png, > 99p_1_SSTable_with_5000_Searches.png, > 99p_15000_SSTable_with_5000_Searches.png, > 99p_2_SSTable_with_5000_Searches.png, > 99p_25000_SSTable_with_5000_Searches.png, > 99p_3_SSTable_with_5000_Searches.png, > 99p_5000_SSTable_with_5000_Searches.png, IntervalList.java, > IntervalListWithElimination.java, IntervalTreeSimplified.java, > Mean_1_SSTable_with_5000_Searches.png, > Mean_15000_SSTable_with_5000_Searches.png, > Mean_2_SSTable_with_5000_Searches.png, > Mean_25000_SSTable_with_5000_Searches.png, > Mean_3_SSTable_with_5000_Searches.png, > Mean_5000_SSTable_with_5000_Searches.png, TESTS-TestSuites.xml.lz4, > replace_intervaltree_with_intervallist.patch > > > Cassandra uses IntervalTrees to identify the SSTables that overlap with > search interval. In Cassandra, IntervalTrees are not mutated. They are > recreated each time a mutation is required. This can be an issue during > repairs. In fact we noticed such issues during repair. > Since lists are cache friendly compared to linked lists and trees, I decided > to compare the search performance with: > * Linear Walk. > * Elimination using Binary Search (idea is to eliminate intervals using start > and end points of search interval). > Based on the tests I ran, I noticed Binary Search based elimination almost > always performs similar to IntervalTree or out performs IntervalTree based > search. The cost of IntervalTree construction is also substantial and > produces lot of garbage during repairs. > I ran the tests using random intervals to build the tree/lists and another > randomly generated search interval with 5000 iterations. I'm attaching all > the relevant graphs. The x-axis in the graphs is the search interval > coverage. 10p means the search interval covered 10% of the intervals. The > y-axis is the time the search took in nanos. > PS: > # For the purpose of test, I simplified the IntervalTree by removing the data > portion of the interval. Modified the template version (Java generics) to a > specialized version. > # I used the code from Cassandra version _3.11_. > # Time in the graph is in nanos. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15397) IntervalTree performance comparison with Linear Walk and Binary Search based Elimination.
[ https://issues.apache.org/jira/browse/CASSANDRA-15397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chandrasekhar Thumuluru updated CASSANDRA-15397: Attachment: replace_intervaltree_with_intervallist.patch > IntervalTree performance comparison with Linear Walk and Binary Search based > Elimination. > -- > > Key: CASSANDRA-15397 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15397 > Project: Cassandra > Issue Type: Improvement > Components: Local/SSTable >Reporter: Chandrasekhar Thumuluru >Assignee: Chandrasekhar Thumuluru >Priority: Low > Attachments: 95p_1_SSTable_with_5000_Searches.png, > 95p_15000_SSTable_with_5000_Searches.png, > 95p_2_SSTable_with_5000_Searches.png, > 95p_25000_SSTable_with_5000_Searches.png, > 95p_3_SSTable_with_5000_Searches.png, > 95p_5000_SSTable_with_5000_Searches.png, > 99p_1_SSTable_with_5000_Searches.png, > 99p_15000_SSTable_with_5000_Searches.png, > 99p_2_SSTable_with_5000_Searches.png, > 99p_25000_SSTable_with_5000_Searches.png, > 99p_3_SSTable_with_5000_Searches.png, > 99p_5000_SSTable_with_5000_Searches.png, IntervalList.java, > IntervalListWithElimination.java, IntervalTreeSimplified.java, > Mean_1_SSTable_with_5000_Searches.png, > Mean_15000_SSTable_with_5000_Searches.png, > Mean_2_SSTable_with_5000_Searches.png, > Mean_25000_SSTable_with_5000_Searches.png, > Mean_3_SSTable_with_5000_Searches.png, > Mean_5000_SSTable_with_5000_Searches.png, > replace_intervaltree_with_intervallist.patch > > > Cassandra uses IntervalTrees to identify the SSTables that overlap with > search interval. In Cassandra, IntervalTrees are not mutated. They are > recreated each time a mutation is required. This can be an issue during > repairs. In fact we noticed such issues during repair. > Since lists are cache friendly compared to linked lists and trees, I decided > to compare the search performance with: > * Linear Walk. > * Elimination using Binary Search (idea is to eliminate intervals using start > and end points of search interval). > Based on the tests I ran, I noticed Binary Search based elimination almost > always performs similar to IntervalTree or out performs IntervalTree based > search. The cost of IntervalTree construction is also substantial and > produces lot of garbage during repairs. > I ran the tests using random intervals to build the tree/lists and another > randomly generated search interval with 5000 iterations. I'm attaching all > the relevant graphs. The x-axis in the graphs is the search interval > coverage. 10p means the search interval covered 10% of the intervals. The > y-axis is the time the search took in nanos. > PS: > # For the purpose of test, I simplified the IntervalTree by removing the data > portion of the interval. Modified the template version (Java generics) to a > specialized version. > # I used the code from Cassandra version _3.11_. > # Time in the graph is in nanos. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15407) Hint-dispatcher file-channel not closed, if "open()" fails with OOM
[ https://issues.apache.org/jira/browse/CASSANDRA-15407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974542#comment-16974542 ] Ekaterina Dimitrova commented on CASSANDRA-15407: - Tests completed successfully. Patch ready for review/commit > Hint-dispatcher file-channel not closed, if "open()" fails with OOM > --- > > Key: CASSANDRA-15407 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15407 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Hints >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.x > > > Some places in the code base do not to close the file (some channel-proxy) in > case of errors. We should close the channel-proxy in those cases - at least > to not make the situation (due to that OOM) even worse. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15407) Hint-dispatcher file-channel not closed, if "open()" fails with OOM
[ https://issues.apache.org/jira/browse/CASSANDRA-15407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-15407: Test and Documentation Plan: DTests completed successfully. Patch for version 4 available here at branch CASSANDRA-15407-trunk Status: Patch Available (was: In Progress) > Hint-dispatcher file-channel not closed, if "open()" fails with OOM > --- > > Key: CASSANDRA-15407 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15407 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Hints >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.x > > > Some places in the code base do not to close the file (some channel-proxy) in > case of errors. We should close the channel-proxy in those cases - at least > to not make the situation (due to that OOM) even worse. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15410) Avoid over-allocation of bytes for UTF8 string serialization
[ https://issues.apache.org/jira/browse/CASSANDRA-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974417#comment-16974417 ] Yifan Cai commented on CASSANDRA-15410: --- [~aleksey] thanks for reviewing. Understood the concern here. It assumes the method is/will be only used in the scenarios such as encoding message. We can have a separate method that explicitly takes the argument of reserved size, if encodeSize is a strong constraint and correct for message serialization, so it can be relied on. There is a big performance difference calculating the size and skipping calculation. Especially for the long strings, the time taken of the prior is 2x than the latter one. > Avoid over-allocation of bytes for UTF8 string serialization > - > > Key: CASSANDRA-15410 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15410 > Project: Cassandra > Issue Type: Improvement > Components: Messaging/Client >Reporter: Yifan Cai >Assignee: Yifan Cai >Priority: Normal > Fix For: 4.0 > > > In the current message encoding implementation, it first calculates the > `encodeSize` and allocates the bytebuffer with that size. > However, during encoding, it assumes the worst case of writing UTF8 string to > allocate bytes, i.e. assuming each letter takes 3 bytes. > The over-estimation further leads to resizing the underlying array and data > copy. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15427) 2.2 eclipse-warnings
[ https://issues.apache.org/jira/browse/CASSANDRA-15427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict Elliott Smith updated CASSANDRA-15427: --- Status: Ready to Commit (was: Review In Progress) +1 > 2.2 eclipse-warnings > > > Key: CASSANDRA-15427 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15427 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 2.2.x > > > Cassandra-2.2 artifact builds are failing from eclipse-warnings. > {noformat} > # 11/11/19 2:58:41 PM UTC > # Eclipse Compiler for Java(TM) v20150120-1634, 3.10.2, Copyright IBM Corp > 2000, 2013. All rights reserved. > incorrect classpath: > /home/jenkins/jenkins-slave/workspace/Cassandra-2.2-artifacts/build/cobertura/classes > -- > 1. ERROR in > /home/jenkins/jenkins-slave/workspace/Cassandra-2.2-artifacts/src/java/org/apache/cassandra/db/compaction/CompactionManager.java > (at line 880) > ISSTableScanner scanner = cleanupStrategy.getScanner(sstable, > getRateLimiter()); > ^^^ > Resource 'scanner' should be managed by try-with-resource > -- > -- > 2. ERROR in > /home/jenkins/jenkins-slave/workspace/Cassandra-2.2-artifacts/src/java/org/apache/cassandra/db/compaction/LeveledCompactionStrategy.java > (at line 257) > scanners.add(new LeveledScanner(intersecting, range)); >^^^ > Potential resource leak: '' may not be closed > -- > -- > 3. ERROR in > /home/jenkins/jenkins-slave/workspace/Cassandra-2.2-artifacts/src/java/org/apache/cassandra/tools/SSTableExport.java > (at line 315) > ISSTableScanner scanner = reader.getScanner(); > ^^^ > Resource 'scanner' should be managed by try-with-resource > -- > 3 problems (3 errors) > {noformat} > ref: > https://builds.apache.org/job/Cassandra-2.2-artifacts/180/artifact/build/ecj/eclipse_compiler_checks.txt -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15427) 2.2 eclipse-warnings
[ https://issues.apache.org/jira/browse/CASSANDRA-15427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict Elliott Smith updated CASSANDRA-15427: --- Reviewers: Benedict Elliott Smith, Benedict Elliott Smith (was: Benedict Elliott Smith) Benedict Elliott Smith, Benedict Elliott Smith Status: Review In Progress (was: Patch Available) > 2.2 eclipse-warnings > > > Key: CASSANDRA-15427 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15427 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 2.2.x > > > Cassandra-2.2 artifact builds are failing from eclipse-warnings. > {noformat} > # 11/11/19 2:58:41 PM UTC > # Eclipse Compiler for Java(TM) v20150120-1634, 3.10.2, Copyright IBM Corp > 2000, 2013. All rights reserved. > incorrect classpath: > /home/jenkins/jenkins-slave/workspace/Cassandra-2.2-artifacts/build/cobertura/classes > -- > 1. ERROR in > /home/jenkins/jenkins-slave/workspace/Cassandra-2.2-artifacts/src/java/org/apache/cassandra/db/compaction/CompactionManager.java > (at line 880) > ISSTableScanner scanner = cleanupStrategy.getScanner(sstable, > getRateLimiter()); > ^^^ > Resource 'scanner' should be managed by try-with-resource > -- > -- > 2. ERROR in > /home/jenkins/jenkins-slave/workspace/Cassandra-2.2-artifacts/src/java/org/apache/cassandra/db/compaction/LeveledCompactionStrategy.java > (at line 257) > scanners.add(new LeveledScanner(intersecting, range)); >^^^ > Potential resource leak: '' may not be closed > -- > -- > 3. ERROR in > /home/jenkins/jenkins-slave/workspace/Cassandra-2.2-artifacts/src/java/org/apache/cassandra/tools/SSTableExport.java > (at line 315) > ISSTableScanner scanner = reader.getScanner(); > ^^^ > Resource 'scanner' should be managed by try-with-resource > -- > 3 problems (3 errors) > {noformat} > ref: > https://builds.apache.org/job/Cassandra-2.2-artifacts/180/artifact/build/ecj/eclipse_compiler_checks.txt -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15427) 2.2 eclipse-warnings
[ https://issues.apache.org/jira/browse/CASSANDRA-15427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-15427: --- Test and Documentation Plan: asf jenkins Status: Patch Available (was: Open) > 2.2 eclipse-warnings > > > Key: CASSANDRA-15427 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15427 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 2.2.x > > > Cassandra-2.2 artifact builds are failing from eclipse-warnings. > {noformat} > # 11/11/19 2:58:41 PM UTC > # Eclipse Compiler for Java(TM) v20150120-1634, 3.10.2, Copyright IBM Corp > 2000, 2013. All rights reserved. > incorrect classpath: > /home/jenkins/jenkins-slave/workspace/Cassandra-2.2-artifacts/build/cobertura/classes > -- > 1. ERROR in > /home/jenkins/jenkins-slave/workspace/Cassandra-2.2-artifacts/src/java/org/apache/cassandra/db/compaction/CompactionManager.java > (at line 880) > ISSTableScanner scanner = cleanupStrategy.getScanner(sstable, > getRateLimiter()); > ^^^ > Resource 'scanner' should be managed by try-with-resource > -- > -- > 2. ERROR in > /home/jenkins/jenkins-slave/workspace/Cassandra-2.2-artifacts/src/java/org/apache/cassandra/db/compaction/LeveledCompactionStrategy.java > (at line 257) > scanners.add(new LeveledScanner(intersecting, range)); >^^^ > Potential resource leak: '' may not be closed > -- > -- > 3. ERROR in > /home/jenkins/jenkins-slave/workspace/Cassandra-2.2-artifacts/src/java/org/apache/cassandra/tools/SSTableExport.java > (at line 315) > ISSTableScanner scanner = reader.getScanner(); > ^^^ > Resource 'scanner' should be managed by try-with-resource > -- > 3 problems (3 errors) > {noformat} > ref: > https://builds.apache.org/job/Cassandra-2.2-artifacts/180/artifact/build/ecj/eclipse_compiler_checks.txt -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15427) 2.2 eclipse-warnings
[ https://issues.apache.org/jira/browse/CASSANDRA-15427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-15427: --- Bug Category: Parent values: Code(13163) Complexity: Low Hanging Fruit Discovered By: Unit Test Fix Version/s: 2.2.x Severity: Low Assignee: Michael Semb Wever Status: Open (was: Triage Needed) ||branch||circleci||asf jenkins tests||asf jenkins dtests|| |[cassandra-2.2_15427|https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/cassandra-2.2_15427]|[circleci|https://circleci.com/workflow-run/4fa881cc-e842-45d2-8b4f-bffea7601152]|[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-pipeline/28//badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-pipeline/28/]|[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/702//badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/702]| > 2.2 eclipse-warnings > > > Key: CASSANDRA-15427 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15427 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 2.2.x > > > Cassandra-2.2 artifact builds are failing from eclipse-warnings. > {noformat} > # 11/11/19 2:58:41 PM UTC > # Eclipse Compiler for Java(TM) v20150120-1634, 3.10.2, Copyright IBM Corp > 2000, 2013. All rights reserved. > incorrect classpath: > /home/jenkins/jenkins-slave/workspace/Cassandra-2.2-artifacts/build/cobertura/classes > -- > 1. ERROR in > /home/jenkins/jenkins-slave/workspace/Cassandra-2.2-artifacts/src/java/org/apache/cassandra/db/compaction/CompactionManager.java > (at line 880) > ISSTableScanner scanner = cleanupStrategy.getScanner(sstable, > getRateLimiter()); > ^^^ > Resource 'scanner' should be managed by try-with-resource > -- > -- > 2. ERROR in > /home/jenkins/jenkins-slave/workspace/Cassandra-2.2-artifacts/src/java/org/apache/cassandra/db/compaction/LeveledCompactionStrategy.java > (at line 257) > scanners.add(new LeveledScanner(intersecting, range)); >^^^ > Potential resource leak: '' may not be closed > -- > -- > 3. ERROR in > /home/jenkins/jenkins-slave/workspace/Cassandra-2.2-artifacts/src/java/org/apache/cassandra/tools/SSTableExport.java > (at line 315) > ISSTableScanner scanner = reader.getScanner(); > ^^^ > Resource 'scanner' should be managed by try-with-resource > -- > 3 problems (3 errors) > {noformat} > ref: > https://builds.apache.org/job/Cassandra-2.2-artifacts/180/artifact/build/ecj/eclipse_compiler_checks.txt -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15427) 2.2 eclipse-warnings
Michael Semb Wever created CASSANDRA-15427: -- Summary: 2.2 eclipse-warnings Key: CASSANDRA-15427 URL: https://issues.apache.org/jira/browse/CASSANDRA-15427 Project: Cassandra Issue Type: Bug Components: Build Reporter: Michael Semb Wever Cassandra-2.2 artifact builds are failing from eclipse-warnings. {noformat} # 11/11/19 2:58:41 PM UTC # Eclipse Compiler for Java(TM) v20150120-1634, 3.10.2, Copyright IBM Corp 2000, 2013. All rights reserved. incorrect classpath: /home/jenkins/jenkins-slave/workspace/Cassandra-2.2-artifacts/build/cobertura/classes -- 1. ERROR in /home/jenkins/jenkins-slave/workspace/Cassandra-2.2-artifacts/src/java/org/apache/cassandra/db/compaction/CompactionManager.java (at line 880) ISSTableScanner scanner = cleanupStrategy.getScanner(sstable, getRateLimiter()); ^^^ Resource 'scanner' should be managed by try-with-resource -- -- 2. ERROR in /home/jenkins/jenkins-slave/workspace/Cassandra-2.2-artifacts/src/java/org/apache/cassandra/db/compaction/LeveledCompactionStrategy.java (at line 257) scanners.add(new LeveledScanner(intersecting, range)); ^^^ Potential resource leak: '' may not be closed -- -- 3. ERROR in /home/jenkins/jenkins-slave/workspace/Cassandra-2.2-artifacts/src/java/org/apache/cassandra/tools/SSTableExport.java (at line 315) ISSTableScanner scanner = reader.getScanner(); ^^^ Resource 'scanner' should be managed by try-with-resource -- 3 problems (3 errors) {noformat} ref: https://builds.apache.org/job/Cassandra-2.2-artifacts/180/artifact/build/ecj/eclipse_compiler_checks.txt -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15410) Avoid over-allocation of bytes for UTF8 string serialization
[ https://issues.apache.org/jira/browse/CASSANDRA-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Yeschenko updated CASSANDRA-15410: -- Status: Changes Suggested (was: Review In Progress) > Avoid over-allocation of bytes for UTF8 string serialization > - > > Key: CASSANDRA-15410 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15410 > Project: Cassandra > Issue Type: Improvement > Components: Messaging/Client >Reporter: Yifan Cai >Assignee: Yifan Cai >Priority: Normal > Fix For: 4.0 > > > In the current message encoding implementation, it first calculates the > `encodeSize` and allocates the bytebuffer with that size. > However, during encoding, it assumes the worst case of writing UTF8 string to > allocate bytes, i.e. assuming each letter takes 3 bytes. > The over-estimation further leads to resizing the underlying array and data > copy. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15410) Avoid over-allocation of bytes for UTF8 string serialization
[ https://issues.apache.org/jira/browse/CASSANDRA-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974246#comment-16974246 ] Aleksey Yeschenko commented on CASSANDRA-15410: --- I welcome this change in principle, but it makes me feel a little uneasy. Specifically, it relies implicitly on how the method is used two levels of abstraction up, and feels slightly brittle to me. I wonder if you'd be open instead to a slightly less efficient but, importantly, still resize-avoiding alternative: modify {{CBUtil#writeString()}} (and {{CBUtil#writeLongString()}} while at it, just for consistency sake) to explicitly calculate the precise size of encoded string using {{TypeSizes#encodedUTF8Length()}} method, and then pass that value to {{ByteBufUtil#reserveAndWriteUtf8()}}. This way, yes, you would effectively calculate the size of the string twice, but the abstraction won't leak assumptions, and will still avoid unnecessary resizing. > Avoid over-allocation of bytes for UTF8 string serialization > - > > Key: CASSANDRA-15410 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15410 > Project: Cassandra > Issue Type: Improvement > Components: Messaging/Client >Reporter: Yifan Cai >Assignee: Yifan Cai >Priority: Normal > Fix For: 4.0 > > > In the current message encoding implementation, it first calculates the > `encodeSize` and allocates the bytebuffer with that size. > However, during encoding, it assumes the worst case of writing UTF8 string to > allocate bytes, i.e. assuming each letter takes 3 bytes. > The over-estimation further leads to resizing the underlying array and data > copy. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14781) Log message when mutation passed to CommitLog#add(Mutation) is too large is not descriptive enough
[ https://issues.apache.org/jira/browse/CASSANDRA-14781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Yeschenko updated CASSANDRA-14781: -- Component/s: (was: Legacy/Local Write-Read Paths) Messaging/Client Local/Commit Log Consistency/Hints > Log message when mutation passed to CommitLog#add(Mutation) is too large is > not descriptive enough > -- > > Key: CASSANDRA-14781 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14781 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Hints, Local/Commit Log, Messaging/Client >Reporter: Jordan West >Assignee: Tom Petracca >Priority: Normal > Labels: protocolv5 > Fix For: 4.0-beta > > Attachments: CASSANDRA-14781.patch, CASSANDRA-14781_3.0.patch, > CASSANDRA-14781_3.11.patch > > > When hitting > [https://github.com/apache/cassandra/blob/cassandra-3.0/src/java/org/apache/cassandra/db/commitlog/CommitLog.java#L256-L257], > the log message produced does not help the operator track down what data is > being written. At a minimum the keyspace and cfIds involved would be useful > (and are available) – more detail might not be reasonable to include. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14781) Log message when mutation passed to CommitLog#add(Mutation) is too large is not descriptive enough
[ https://issues.apache.org/jira/browse/CASSANDRA-14781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Yeschenko updated CASSANDRA-14781: -- Labels: protocolv5 (was: ) > Log message when mutation passed to CommitLog#add(Mutation) is too large is > not descriptive enough > -- > > Key: CASSANDRA-14781 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14781 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Local Write-Read Paths >Reporter: Jordan West >Assignee: Tom Petracca >Priority: Normal > Labels: protocolv5 > Fix For: 4.0-beta > > Attachments: CASSANDRA-14781.patch, CASSANDRA-14781_3.0.patch, > CASSANDRA-14781_3.11.patch > > > When hitting > [https://github.com/apache/cassandra/blob/cassandra-3.0/src/java/org/apache/cassandra/db/commitlog/CommitLog.java#L256-L257], > the log message produced does not help the operator track down what data is > being written. At a minimum the keyspace and cfIds involved would be useful > (and are available) – more detail might not be reasonable to include. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14781) Log message when mutation passed to CommitLog#add(Mutation) is too large is not descriptive enough
[ https://issues.apache.org/jira/browse/CASSANDRA-14781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Yeschenko updated CASSANDRA-14781: -- Fix Version/s: (was: 3.11.x) (was: 4.x) (was: 3.0.x) 4.0-beta > Log message when mutation passed to CommitLog#add(Mutation) is too large is > not descriptive enough > -- > > Key: CASSANDRA-14781 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14781 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Local Write-Read Paths >Reporter: Jordan West >Assignee: Tom Petracca >Priority: Normal > Fix For: 4.0-beta > > Attachments: CASSANDRA-14781.patch, CASSANDRA-14781_3.0.patch, > CASSANDRA-14781_3.11.patch > > > When hitting > [https://github.com/apache/cassandra/blob/cassandra-3.0/src/java/org/apache/cassandra/db/commitlog/CommitLog.java#L256-L257], > the log message produced does not help the operator track down what data is > being written. At a minimum the keyspace and cfIds involved would be useful > (and are available) – more detail might not be reasonable to include. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15426) Cassandra 3.11.5 fails to start on Windows
[ https://issues.apache.org/jira/browse/CASSANDRA-15426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974136#comment-16974136 ] Andrew Kostousov edited comment on CASSANDRA-15426 at 11/14/19 10:42 AM: - Seems like the problem was introduced with CASSANDRA-15053 patch. Note that {{NativeLibrary.tryOpenDirectory()}} is not implemented on Windows and always returns -1. was (Author: andrew.kostou...@gmail.com): Seems like the problem was introduced with CASSANDRA-15053 patch. Note that `NativeLibrary.tryOpenDirectory()` is not implemented on Windows and always returns `-1`. > Cassandra 3.11.5 fails to start on Windows > --- > > Key: CASSANDRA-15426 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15426 > Project: Cassandra > Issue Type: Bug >Reporter: Ashish Singh >Priority: Normal > > Cassandra 3.11.5 fails to start on Windows server 2012 R2. with following > error trace. > Cassandra 3.11.4 doesn't fail on Windows 2012 R2. > > org.apache.cassandra.io.FSReadError: java.io.IOException: Invalid folder > descriptor trying to create log replica > C:\Users\Administrator\Downloads\apache-cassandra-3.11.5-bin.tar\apache-cassandra-3.11.5-bin\apache-cassandra-3.11.5\data\data\system\local-7ad54392bcdd35a684174e047860b377 > at org.apache.cassandra.db.lifecycle.LogReplica.create(LogReplica.java:58) > ~[apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.db.lifecycle.LogReplicaSet.maybeCreateReplica(LogReplicaSet.java:86) > ~[apache-cassandra-3.11.5.jar:3.11.5] > at org.apache.cassandra.db.lifecycle.LogFile.makeRecord(LogFile.java:311) > [apache-cassandra-3.11.5.jar:3.11.5] > at org.apache.cassandra.db.lifecycle.LogFile.add(LogFile.java:283) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.db.lifecycle.LogTransaction.trackNew(LogTransaction.java:139) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.db.lifecycle.LifecycleTransaction.trackNew(LifecycleTransaction.java:528) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.io.sstable.format.big.BigTableWriter.(BigTableWriter.java:81) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.io.sstable.format.big.BigFormat$WriterFactory.open(BigFormat.java:92) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.io.sstable.format.SSTableWriter.create(SSTableWriter.java:102) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.io.sstable.SimpleSSTableMultiWriter.create(SimpleSSTableMultiWriter.java:119) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.db.compaction.AbstractCompactionStrategy.createSSTableMultiWriter(AbstractCompactionStrategy.java:588) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.db.compaction.CompactionStrategyManager.createSSTableMultiWriter(CompactionStrategyManager.java:1027) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.db.ColumnFamilyStore.createSSTableMultiWriter(ColumnFamilyStore.java:532) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.db.Memtable$FlushRunnable.createFlushWriter(Memtable.java:504) > [apache-cassandra-3.11.5.jar:3.11.5] > at org.apache.cassandra.db.Memtable$FlushRunnable.(Memtable.java:443) > [apache-cassandra-3.11.5.jar:3.11.5] > at org.apache.cassandra.db.Memtable$FlushRunnable.(Memtable.java:420) > [apache-cassandra-3.11.5.jar:3.11.5] > at org.apache.cassandra.db.Memtable.createFlushRunnables(Memtable.java:307) > [apache-cassandra-3.11.5.jar:3.11.5] > at org.apache.cassandra.db.Memtable.flushRunnables(Memtable.java:298) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.db.ColumnFamilyStore$Flush.flushMemtable(ColumnFamilyStore.java:1153) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.db.ColumnFamilyStore$Flush.run(ColumnFamilyStore.java:1118) > [apache-cassandra-3.11.5.jar:3.11.5] > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > [na:1.8.0_161] > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > [na:1.8.0_161] > at > org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:84) > [apache-cassandra-3.11.5.jar:3.11.5] > at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_161] > Caused by: java.io.IOException: Invalid folder descriptor trying to -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15426) Cassandra 3.11.5 fails to start on Windows
[ https://issues.apache.org/jira/browse/CASSANDRA-15426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974136#comment-16974136 ] Andrew Kostousov commented on CASSANDRA-15426: -- Seems like the problem was introduced with CASSANDRA-15053 patch. Note that `NativeLibrary.tryOpenDirectory()` is not implemented on Windows and always returns `-1`. > Cassandra 3.11.5 fails to start on Windows > --- > > Key: CASSANDRA-15426 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15426 > Project: Cassandra > Issue Type: Bug >Reporter: Ashish Singh >Priority: Normal > > Cassandra 3.11.5 fails to start on Windows server 2012 R2. with following > error trace. > Cassandra 3.11.4 doesn't fail on Windows 2012 R2. > > org.apache.cassandra.io.FSReadError: java.io.IOException: Invalid folder > descriptor trying to create log replica > C:\Users\Administrator\Downloads\apache-cassandra-3.11.5-bin.tar\apache-cassandra-3.11.5-bin\apache-cassandra-3.11.5\data\data\system\local-7ad54392bcdd35a684174e047860b377 > at org.apache.cassandra.db.lifecycle.LogReplica.create(LogReplica.java:58) > ~[apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.db.lifecycle.LogReplicaSet.maybeCreateReplica(LogReplicaSet.java:86) > ~[apache-cassandra-3.11.5.jar:3.11.5] > at org.apache.cassandra.db.lifecycle.LogFile.makeRecord(LogFile.java:311) > [apache-cassandra-3.11.5.jar:3.11.5] > at org.apache.cassandra.db.lifecycle.LogFile.add(LogFile.java:283) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.db.lifecycle.LogTransaction.trackNew(LogTransaction.java:139) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.db.lifecycle.LifecycleTransaction.trackNew(LifecycleTransaction.java:528) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.io.sstable.format.big.BigTableWriter.(BigTableWriter.java:81) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.io.sstable.format.big.BigFormat$WriterFactory.open(BigFormat.java:92) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.io.sstable.format.SSTableWriter.create(SSTableWriter.java:102) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.io.sstable.SimpleSSTableMultiWriter.create(SimpleSSTableMultiWriter.java:119) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.db.compaction.AbstractCompactionStrategy.createSSTableMultiWriter(AbstractCompactionStrategy.java:588) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.db.compaction.CompactionStrategyManager.createSSTableMultiWriter(CompactionStrategyManager.java:1027) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.db.ColumnFamilyStore.createSSTableMultiWriter(ColumnFamilyStore.java:532) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.db.Memtable$FlushRunnable.createFlushWriter(Memtable.java:504) > [apache-cassandra-3.11.5.jar:3.11.5] > at org.apache.cassandra.db.Memtable$FlushRunnable.(Memtable.java:443) > [apache-cassandra-3.11.5.jar:3.11.5] > at org.apache.cassandra.db.Memtable$FlushRunnable.(Memtable.java:420) > [apache-cassandra-3.11.5.jar:3.11.5] > at org.apache.cassandra.db.Memtable.createFlushRunnables(Memtable.java:307) > [apache-cassandra-3.11.5.jar:3.11.5] > at org.apache.cassandra.db.Memtable.flushRunnables(Memtable.java:298) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.db.ColumnFamilyStore$Flush.flushMemtable(ColumnFamilyStore.java:1153) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.db.ColumnFamilyStore$Flush.run(ColumnFamilyStore.java:1118) > [apache-cassandra-3.11.5.jar:3.11.5] > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > [na:1.8.0_161] > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > [na:1.8.0_161] > at > org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:84) > [apache-cassandra-3.11.5.jar:3.11.5] > at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_161] > Caused by: java.io.IOException: Invalid folder descriptor trying to -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15399) Add ability to track state in repair
[ https://issues.apache.org/jira/browse/CASSANDRA-15399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Yeschenko updated CASSANDRA-15399: -- Reviewers: Aleksey Yeschenko > Add ability to track state in repair > > > Key: CASSANDRA-15399 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15399 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Repair >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > To enhance the visibility in repair, we should expose internal state via > virtual tables; the state should include coordinator as well as participant > state (validation, sync, etc.) > I propose the following tables: > repairs - high level summary of the global state of repair; this should be > called on the coordinator. > {code:sql} > CREATE TABLE repairs ( > id uuid, > keyspace_name text, > table_names frozen>, > ranges frozen>, > coordinator text, > participants frozen>, > state text, > progress_percentage float, > last_updated_at_millis bigint, > duration_micro bigint, > failure_cause text, > PRIMARY KEY ( (id) ) > ) > {code} > repair_tasks - represents RepairJob and participants state. This will show > if validations are running on participants and the progress they are making; > this should be called on the coordinator. > {code:sql} > CREATE TABLE repair_tasks ( > id uuid, > session_id uuid, > keyspace_name text, > table_name text, > ranges frozen>, > coordinator text, > participant text, > state text, > state_description text, > progress_percentage float, -- between 0.0 and 100.0 > last_updated_at_millis bigint, > duration_micro bigint, > failure_cause text, > PRIMARY KEY ( (id), session_id, table_name, participant ) > ) > {code} > repair_validations - shows the state of the validation task and updated > periodically while validation is running; this should be called on the > participants. > {code:sql} > CREATE TABLE repair_validations ( > id uuid, > session_id uuid, > ranges frozen>, > keyspace_name text, > table_name text, > initiator text, > state text, > progress_percentage float, > queue_duration_ms bigint, > runtime_duration_ms bigint, > total_duration_ms bigint, > estimated_partitions bigint, > partitions_processed bigint, > estimated_total_bytes bigint, > failure_cause text, > PRIMARY KEY ( (id), session_id, table_name ) > ) > {code} > The main reason for exposing virtual tables rather than exposing through > durable tables is to make sure what is exposed is accurate. In cases of > write failures or node failures, the durable tables could become in-accurate > and could add edge cases where the repair is not running but the tables say > it is; by relying on repair's internal in-memory bookkeeping, these problems > go away. > This jira does not try to solve the following: > 1) repair resiliency - there are edge cases where repair hits an error and > runs forever (at least from nodetool's perspective). > 2) repair stream tracking - I have not learned the streaming side yet and > what I see is multiple implementations exist, so seems like high scope. My > hope is to punt from this jira and tackle separately. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15426) Cassandra 3.11.5 fails to start on Windows
[ https://issues.apache.org/jira/browse/CASSANDRA-15426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kostousov updated CASSANDRA-15426: - Platform: Windows (was: All) > Cassandra 3.11.5 fails to start on Windows > --- > > Key: CASSANDRA-15426 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15426 > Project: Cassandra > Issue Type: Bug >Reporter: Ashish Singh >Priority: Normal > > Cassandra 3.11.5 fails to start on Windows server 2012 R2. with following > error trace. > Cassandra 3.11.4 doesn't fail on Windows 2012 R2. > > org.apache.cassandra.io.FSReadError: java.io.IOException: Invalid folder > descriptor trying to create log replica > C:\Users\Administrator\Downloads\apache-cassandra-3.11.5-bin.tar\apache-cassandra-3.11.5-bin\apache-cassandra-3.11.5\data\data\system\local-7ad54392bcdd35a684174e047860b377 > at org.apache.cassandra.db.lifecycle.LogReplica.create(LogReplica.java:58) > ~[apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.db.lifecycle.LogReplicaSet.maybeCreateReplica(LogReplicaSet.java:86) > ~[apache-cassandra-3.11.5.jar:3.11.5] > at org.apache.cassandra.db.lifecycle.LogFile.makeRecord(LogFile.java:311) > [apache-cassandra-3.11.5.jar:3.11.5] > at org.apache.cassandra.db.lifecycle.LogFile.add(LogFile.java:283) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.db.lifecycle.LogTransaction.trackNew(LogTransaction.java:139) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.db.lifecycle.LifecycleTransaction.trackNew(LifecycleTransaction.java:528) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.io.sstable.format.big.BigTableWriter.(BigTableWriter.java:81) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.io.sstable.format.big.BigFormat$WriterFactory.open(BigFormat.java:92) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.io.sstable.format.SSTableWriter.create(SSTableWriter.java:102) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.io.sstable.SimpleSSTableMultiWriter.create(SimpleSSTableMultiWriter.java:119) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.db.compaction.AbstractCompactionStrategy.createSSTableMultiWriter(AbstractCompactionStrategy.java:588) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.db.compaction.CompactionStrategyManager.createSSTableMultiWriter(CompactionStrategyManager.java:1027) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.db.ColumnFamilyStore.createSSTableMultiWriter(ColumnFamilyStore.java:532) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.db.Memtable$FlushRunnable.createFlushWriter(Memtable.java:504) > [apache-cassandra-3.11.5.jar:3.11.5] > at org.apache.cassandra.db.Memtable$FlushRunnable.(Memtable.java:443) > [apache-cassandra-3.11.5.jar:3.11.5] > at org.apache.cassandra.db.Memtable$FlushRunnable.(Memtable.java:420) > [apache-cassandra-3.11.5.jar:3.11.5] > at org.apache.cassandra.db.Memtable.createFlushRunnables(Memtable.java:307) > [apache-cassandra-3.11.5.jar:3.11.5] > at org.apache.cassandra.db.Memtable.flushRunnables(Memtable.java:298) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.db.ColumnFamilyStore$Flush.flushMemtable(ColumnFamilyStore.java:1153) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.db.ColumnFamilyStore$Flush.run(ColumnFamilyStore.java:1118) > [apache-cassandra-3.11.5.jar:3.11.5] > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > [na:1.8.0_161] > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > [na:1.8.0_161] > at > org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:84) > [apache-cassandra-3.11.5.jar:3.11.5] > at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_161] > Caused by: java.io.IOException: Invalid folder descriptor trying to -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-10726) Read repair inserts should not be blocking
[ https://issues.apache.org/jira/browse/CASSANDRA-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974101#comment-16974101 ] Sanjit Mohanty commented on CASSANDRA-10726: [~isaacreath]: We are using C* version 3.11.4 & quite frequently encountering this situation. It is quite critical for us to get this fixed. Please let me know if you would need any support. I can as well contribute in the back port. > Read repair inserts should not be blocking > -- > > Key: CASSANDRA-10726 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10726 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Coordination >Reporter: Richard Low >Assignee: Blake Eggleston >Priority: Normal > Fix For: 4.0 > > > Today, if there’s a digest mismatch in a foreground read repair, the insert > to update out of date replicas is blocking. This means, if it fails, the read > fails with a timeout. If a node is dropping writes (maybe it is overloaded or > the mutation stage is backed up for some other reason), all reads to a > replica set could fail. Further, replicas dropping writes get more out of > sync so will require more read repair. > The comment on the code for why the writes are blocking is: > {code} > // wait for the repair writes to be acknowledged, to minimize impact on any > replica that's > // behind on writes in case the out-of-sync row is read multiple times in > quick succession > {code} > but the bad side effect is that reads timeout. Either the writes should not > be blocking or we should return success for the read even if the write times > out. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15426) Cassandra 3.11.5 fails to start on Windows
Ashish Singh created CASSANDRA-15426: Summary: Cassandra 3.11.5 fails to start on Windows Key: CASSANDRA-15426 URL: https://issues.apache.org/jira/browse/CASSANDRA-15426 Project: Cassandra Issue Type: Bug Reporter: Ashish Singh Cassandra 3.11.5 fails to start on Windows server 2012 R2. with following error trace. Cassandra 3.11.4 doesn't fail on Windows 2012 R2. org.apache.cassandra.io.FSReadError: java.io.IOException: Invalid folder descriptor trying to create log replica C:\Users\Administrator\Downloads\apache-cassandra-3.11.5-bin.tar\apache-cassandra-3.11.5-bin\apache-cassandra-3.11.5\data\data\system\local-7ad54392bcdd35a684174e047860b377 at org.apache.cassandra.db.lifecycle.LogReplica.create(LogReplica.java:58) ~[apache-cassandra-3.11.5.jar:3.11.5] at org.apache.cassandra.db.lifecycle.LogReplicaSet.maybeCreateReplica(LogReplicaSet.java:86) ~[apache-cassandra-3.11.5.jar:3.11.5] at org.apache.cassandra.db.lifecycle.LogFile.makeRecord(LogFile.java:311) [apache-cassandra-3.11.5.jar:3.11.5] at org.apache.cassandra.db.lifecycle.LogFile.add(LogFile.java:283) [apache-cassandra-3.11.5.jar:3.11.5] at org.apache.cassandra.db.lifecycle.LogTransaction.trackNew(LogTransaction.java:139) [apache-cassandra-3.11.5.jar:3.11.5] at org.apache.cassandra.db.lifecycle.LifecycleTransaction.trackNew(LifecycleTransaction.java:528) [apache-cassandra-3.11.5.jar:3.11.5] at org.apache.cassandra.io.sstable.format.big.BigTableWriter.(BigTableWriter.java:81) [apache-cassandra-3.11.5.jar:3.11.5] at org.apache.cassandra.io.sstable.format.big.BigFormat$WriterFactory.open(BigFormat.java:92) [apache-cassandra-3.11.5.jar:3.11.5] at org.apache.cassandra.io.sstable.format.SSTableWriter.create(SSTableWriter.java:102) [apache-cassandra-3.11.5.jar:3.11.5] at org.apache.cassandra.io.sstable.SimpleSSTableMultiWriter.create(SimpleSSTableMultiWriter.java:119) [apache-cassandra-3.11.5.jar:3.11.5] at org.apache.cassandra.db.compaction.AbstractCompactionStrategy.createSSTableMultiWriter(AbstractCompactionStrategy.java:588) [apache-cassandra-3.11.5.jar:3.11.5] at org.apache.cassandra.db.compaction.CompactionStrategyManager.createSSTableMultiWriter(CompactionStrategyManager.java:1027) [apache-cassandra-3.11.5.jar:3.11.5] at org.apache.cassandra.db.ColumnFamilyStore.createSSTableMultiWriter(ColumnFamilyStore.java:532) [apache-cassandra-3.11.5.jar:3.11.5] at org.apache.cassandra.db.Memtable$FlushRunnable.createFlushWriter(Memtable.java:504) [apache-cassandra-3.11.5.jar:3.11.5] at org.apache.cassandra.db.Memtable$FlushRunnable.(Memtable.java:443) [apache-cassandra-3.11.5.jar:3.11.5] at org.apache.cassandra.db.Memtable$FlushRunnable.(Memtable.java:420) [apache-cassandra-3.11.5.jar:3.11.5] at org.apache.cassandra.db.Memtable.createFlushRunnables(Memtable.java:307) [apache-cassandra-3.11.5.jar:3.11.5] at org.apache.cassandra.db.Memtable.flushRunnables(Memtable.java:298) [apache-cassandra-3.11.5.jar:3.11.5] at org.apache.cassandra.db.ColumnFamilyStore$Flush.flushMemtable(ColumnFamilyStore.java:1153) [apache-cassandra-3.11.5.jar:3.11.5] at org.apache.cassandra.db.ColumnFamilyStore$Flush.run(ColumnFamilyStore.java:1118) [apache-cassandra-3.11.5.jar:3.11.5] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [na:1.8.0_161] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [na:1.8.0_161] at org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:84) [apache-cassandra-3.11.5.jar:3.11.5] at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_161] Caused by: java.io.IOException: Invalid folder descriptor trying to -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org