[jira] [Commented] (CASSANDRA-10190) Python 3 support for cqlsh
[ https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17031332#comment-17031332 ] Jaikiran Pai commented on CASSANDRA-10190: -- Hello [~djoshi] > [~jaikiran] ofcourse. You can clone my branch and build C* and use cqlsh that > is packaged in there. Is there a build instructions page somewhere detailing what commands to use to build the `cqlsh` python package? I have looked in that repository and I could only find instructions to run testsuite on the project. I tried building (by guessing the build steps) it myself but didn't get much far. So just checking if I should follow certain instructions or just wait for this to be officially available as a pip installable version from Apache. > Python 3 support for cqlsh > -- > > Key: CASSANDRA-10190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10190 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Tools >Reporter: Andrew Pennebaker >Assignee: Patrick Bannister >Priority: Normal > Labels: cqlsh, pull-request-available > Fix For: 4.0, 4.0-alpha > > Attachments: > 0001-Fix-issues-from-version-specific-logic-commit.patch, > 0001-Update-six-to-1.12.0.patch, > 0002-Simplify-version-specific-logic-by-using-six.moves-a.patch, > coverage_notes.txt > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Users who operate in a Python 3 environment may have trouble launching cqlsh. > Could we please update cqlsh's syntax to run in Python 3? > As a workaround, users can setup pyenv, and cd to a directory with a > .python-version containing "2.7". But it would be nice if cqlsh supported > modern Python versions out of the box. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15553) Preview repair should include sstables from finalized incremental repair sessions
[ https://issues.apache.org/jira/browse/CASSANDRA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson updated CASSANDRA-15553: Test and Documentation Plan: new in-jvm dtests and cci runs Status: Patch Available (was: Open) [patch|https://github.com/krummas/cassandra/commits/marcuse/previewrepairfix], [cci|https://circleci.com/workflow-run/9ee445fb-8ac7-44e3-b74e-345734b312c3] Patch includes sstables from finalized sessions in the repaired set. Also adds a state change listener interface to `LocalSessions` which preview repair `RepairSession` listens to to fail any intersecting preview repairs. > Preview repair should include sstables from finalized incremental repair > sessions > - > > Key: CASSANDRA-15553 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15553 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 4.0-alpha > > > When running a preview repair we currently grab all repaired sstables, > problem is that we depend on compaction to move the sstables from pending to > repaired so we might have different data marked repaired on different nodes. > Including any sstables from finalized incremental repair sessions as repaired > will solve this. > Another problem is that validations don't start at exactly the same time on > different nodes, so if an incremental repair finishes while the preview > repair is running we might also validate the wrong repaired set. We should > fail the preview repair if an intersecting incremental repair finishes during > the preview repair. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15553) Preview repair should include sstables from finalized incremental repair sessions
[ https://issues.apache.org/jira/browse/CASSANDRA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson updated CASSANDRA-15553: Bug Category: Parent values: Correctness(12982)Level 1 values: Transient Incorrect Response(12987) Complexity: Low Hanging Fruit Discovered By: Adhoc Test Fix Version/s: 4.0-alpha Reviewers: Blake Eggleston Severity: Low Status: Open (was: Triage Needed) > Preview repair should include sstables from finalized incremental repair > sessions > - > > Key: CASSANDRA-15553 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15553 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 4.0-alpha > > > When running a preview repair we currently grab all repaired sstables, > problem is that we depend on compaction to move the sstables from pending to > repaired so we might have different data marked repaired on different nodes. > Including any sstables from finalized incremental repair sessions as repaired > will solve this. > Another problem is that validations don't start at exactly the same time on > different nodes, so if an incremental repair finishes while the preview > repair is running we might also validate the wrong repaired set. We should > fail the preview repair if an intersecting incremental repair finishes during > the preview repair. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15553) Preview repair should include sstables from finalized incremental repair sessions
Marcus Eriksson created CASSANDRA-15553: --- Summary: Preview repair should include sstables from finalized incremental repair sessions Key: CASSANDRA-15553 URL: https://issues.apache.org/jira/browse/CASSANDRA-15553 Project: Cassandra Issue Type: Bug Components: Consistency/Repair Reporter: Marcus Eriksson Assignee: Marcus Eriksson When running a preview repair we currently grab all repaired sstables, problem is that we depend on compaction to move the sstables from pending to repaired so we might have different data marked repaired on different nodes. Including any sstables from finalized incremental repair sessions as repaired will solve this. Another problem is that validations don't start at exactly the same time on different nodes, so if an incremental repair finishes while the preview repair is running we might also validate the wrong repaired set. We should fail the preview repair if an intersecting incremental repair finishes during the preview repair. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15313) Fix flaky - ChecksummingTransformerTest - org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17031282#comment-17031282
]
David Capwell edited comment on CASSANDRA-15313 at 2/6/20 5:18 AM:
---
"it" is the failing case; sorry for the confusion. By lowering the examples we
will need to run the test more before we see the failing case.
bq. I ran at 4G and it still failed at 200 examples (I didn't try any other
sizes though)
This then sounds like the generators produce too much garbage. I took a stab at
fixing it and attaching a hack patch to the JIRA to show; basically move away
from String since that produces a ton of garbage. With the patch and a failing
test case, the test completes in 200ms (900ms if you run in isolation).
[~samt] don't know the test well but when I run it (not patched) in a debugger
with 1000 examples, I see the call
https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/transport/frame/checksum/ChecksummingTransformerTest.java#L118
2 times; so only 2 out of 1k runs hits that check. My patch doesn't hit it
(after a few runs), but could always tweak the bytes to match the expected
input (always throws ProtocolException).
was (Author: dcapwell):
"it" is the failing case; sorry for the confusion. By lowering the examples we
will need to run the test more before we see the failing case.
bq. I ran at 4G and it still failed at 200 examples (I didn't try any other
sizes though)
This then sounds like the generators produce too much garbage. I took a stab at
fixing it and attaching a hack patch to the JIRA to show; basically move away
from String since that produces a ton of garbage. With the patch and a failing
test case, the test completes in 200ms (900ms if you run in isolation).
[~samt] don't know the test well but when I run it (not patched) in a debugger
with 1000 examples, I see the call
https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/transport/frame/checksum/ChecksummingTransformerTest.java#L118
2 times; so only 2 out of 1k runs hits that check. My patch doesn't hit it
(after a few runs), but could always tweak the bytes to match the expected
input.
> Fix flaky - ChecksummingTransformerTest -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> ---
>
> Key: CASSANDRA-15313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15313
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Vinay Chella
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0-alpha
>
> Attachments: CASSANDRA-15313-hack.patch
>
>
> During the recent runs, this test appears to be flaky.
> Example failure:
> [https://circleci.com/gh/vinaykumarchella/cassandra/459#tests/containers/94]
> corruptionCausesFailure-compression -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> {code:java}
> java.lang.OutOfMemoryError: GC overhead limit exceeded
> at java.nio.HeapByteBuffer.(HeapByteBuffer.java:57)
> at java.nio.ByteBuffer.allocate(ByteBuffer.java:335)
> at org.quicktheories.impl.Precursor.(Precursor.java:17)
> at
> org.quicktheories.impl.ConcreteDetachedSource.(ConcreteDetachedSource.java:8)
> at
> org.quicktheories.impl.ConcreteDetachedSource.detach(ConcreteDetachedSource.java:23)
> at org.quicktheories.generators.Retry.generate(CodePoints.java:51)
> at
> org.quicktheories.generators.Generate.lambda$intArrays$10(Generate.java:190)
> at
> org.quicktheories.generators.Generate$$Lambda$17/1847008471.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$mix$10(Gen.java:184)
> at org.quicktheories.core.Gen$$Lambda$45/802243390.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$flatMap$5(Gen.java:93)
> at org.quicktheories.core.Gen$$Lambda$48/363509958.generate(Unknown
> Source)
> at
> org.quicktheories.dsl.TheoryBuilder4.lambda$prgnToTuple$12(TheoryBuilder4.java:188)
> at
> org.quicktheories.dsl.TheoryBuilder4$$Lambda$40/2003496028.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.FilteredGenerator.generate(Gen.java:225)
> at
[jira] [Updated] (CASSANDRA-15313) Fix flaky - ChecksummingTransformerTest - org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-15313:
--
Attachment: CASSANDRA-15313-hack.patch
> Fix flaky - ChecksummingTransformerTest -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> ---
>
> Key: CASSANDRA-15313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15313
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Vinay Chella
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0-alpha
>
> Attachments: CASSANDRA-15313-hack.patch
>
>
> During the recent runs, this test appears to be flaky.
> Example failure:
> [https://circleci.com/gh/vinaykumarchella/cassandra/459#tests/containers/94]
> corruptionCausesFailure-compression -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> {code:java}
> java.lang.OutOfMemoryError: GC overhead limit exceeded
> at java.nio.HeapByteBuffer.(HeapByteBuffer.java:57)
> at java.nio.ByteBuffer.allocate(ByteBuffer.java:335)
> at org.quicktheories.impl.Precursor.(Precursor.java:17)
> at
> org.quicktheories.impl.ConcreteDetachedSource.(ConcreteDetachedSource.java:8)
> at
> org.quicktheories.impl.ConcreteDetachedSource.detach(ConcreteDetachedSource.java:23)
> at org.quicktheories.generators.Retry.generate(CodePoints.java:51)
> at
> org.quicktheories.generators.Generate.lambda$intArrays$10(Generate.java:190)
> at
> org.quicktheories.generators.Generate$$Lambda$17/1847008471.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$mix$10(Gen.java:184)
> at org.quicktheories.core.Gen$$Lambda$45/802243390.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$flatMap$5(Gen.java:93)
> at org.quicktheories.core.Gen$$Lambda$48/363509958.generate(Unknown
> Source)
> at
> org.quicktheories.dsl.TheoryBuilder4.lambda$prgnToTuple$12(TheoryBuilder4.java:188)
> at
> org.quicktheories.dsl.TheoryBuilder4$$Lambda$40/2003496028.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.FilteredGenerator.generate(Gen.java:225)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.impl.Core.generate(Core.java:150)
> at org.quicktheories.impl.Core.shrink(Core.java:103)
> at org.quicktheories.impl.Core.run(Core.java:39)
> at org.quicktheories.impl.TheoryRunner.check(TheoryRunner.java:35)
> at org.quicktheories.dsl.TheoryBuilder4.check(TheoryBuilder4.java:150)
> at
> org.quicktheories.dsl.TheoryBuilder4.checkAssert(TheoryBuilder4.java:162)
> at
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest.corruptionCausesFailure(ChecksummingTransformerTest.java:87)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15313) Fix flaky - ChecksummingTransformerTest - org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17031282#comment-17031282
]
David Capwell commented on CASSANDRA-15313:
---
"it" is the failing case; sorry for the confusion. By lowering the examples we
will need to run the test more before we see the failing case.
bq. I ran at 4G and it still failed at 200 examples (I didn't try any other
sizes though)
This then sounds like the generators produce too much garbage. I took a stab at
fixing it and attaching a hack patch to the JIRA to show; basically move away
from String since that produces a ton of garbage. With the patch and a failing
test case, the test completes in 200ms (900ms if you run in isolation).
[~samt] don't know the test well but when I run it (not patched) in a debugger
with 1000 examples, I see the call
https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/transport/frame/checksum/ChecksummingTransformerTest.java#L118
2 times; so only 2 out of 1k runs hits that check. My patch doesn't hit it
(after a few runs), but could always tweak the bytes to match the expected
input.
> Fix flaky - ChecksummingTransformerTest -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> ---
>
> Key: CASSANDRA-15313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15313
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Vinay Chella
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> During the recent runs, this test appears to be flaky.
> Example failure:
> [https://circleci.com/gh/vinaykumarchella/cassandra/459#tests/containers/94]
> corruptionCausesFailure-compression -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> {code:java}
> java.lang.OutOfMemoryError: GC overhead limit exceeded
> at java.nio.HeapByteBuffer.(HeapByteBuffer.java:57)
> at java.nio.ByteBuffer.allocate(ByteBuffer.java:335)
> at org.quicktheories.impl.Precursor.(Precursor.java:17)
> at
> org.quicktheories.impl.ConcreteDetachedSource.(ConcreteDetachedSource.java:8)
> at
> org.quicktheories.impl.ConcreteDetachedSource.detach(ConcreteDetachedSource.java:23)
> at org.quicktheories.generators.Retry.generate(CodePoints.java:51)
> at
> org.quicktheories.generators.Generate.lambda$intArrays$10(Generate.java:190)
> at
> org.quicktheories.generators.Generate$$Lambda$17/1847008471.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$mix$10(Gen.java:184)
> at org.quicktheories.core.Gen$$Lambda$45/802243390.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$flatMap$5(Gen.java:93)
> at org.quicktheories.core.Gen$$Lambda$48/363509958.generate(Unknown
> Source)
> at
> org.quicktheories.dsl.TheoryBuilder4.lambda$prgnToTuple$12(TheoryBuilder4.java:188)
> at
> org.quicktheories.dsl.TheoryBuilder4$$Lambda$40/2003496028.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.FilteredGenerator.generate(Gen.java:225)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.impl.Core.generate(Core.java:150)
> at org.quicktheories.impl.Core.shrink(Core.java:103)
> at org.quicktheories.impl.Core.run(Core.java:39)
> at org.quicktheories.impl.TheoryRunner.check(TheoryRunner.java:35)
> at org.quicktheories.dsl.TheoryBuilder4.check(TheoryBuilder4.java:150)
> at
> org.quicktheories.dsl.TheoryBuilder4.checkAssert(TheoryBuilder4.java:162)
> at
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest.corruptionCausesFailure(ChecksummingTransformerTest.java:87)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15529) AbstractLocalAwareExecutorService.java exceptions after upgrade from 2.1.16 to 3.11.4
[
https://issues.apache.org/jira/browse/CASSANDRA-15529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17031245#comment-17031245
]
feroz shaik commented on CASSANDRA-15529:
-
[~ifesdjeen] - Let us know if you need any further information. Thanks for the
support.
> AbstractLocalAwareExecutorService.java exceptions after upgrade from 2.1.16
> to 3.11.4
> -
>
> Key: CASSANDRA-15529
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15529
> Project: Cassandra
> Issue Type: Bug
> Components: Cluster/Schema
>Reporter: Pooja Nair
>Priority: Urgent
> Labels: 2.1.16, 3.11.4
> Attachments: sstable_dump.txt
>
>
> Hello Team,
> We have cluster running on cassandra 3.11.4
> Following is the table schema of the tables that is being used in our system.
> {code:java}
> cqlsh> desc KEYSPACE "SAL"
>
> CREATE KEYSPACE "SAL" WITH replication = {'class':
> 'NetworkTopologyStrategy', 'DC_EAST': '3', 'DC_WEST': '3'} AND
> durable_writes = true;
>
> CREATE TABLE "SAL".sal_purge (
> key text,
> column1 text,
> column2 text,
> value text,
> PRIMARY KEY (key, column1, column2)
> ) WITH COMPACT STORAGE
> AND CLUSTERING ORDER BY (column1 ASC, column2 ASC)
> AND bloom_filter_fp_chance = 0.1
> AND caching = '{"keys":"NONE", "rows_per_partition":"NONE"}'
> AND comment = 'Holds items to be removed as
> [shardid][salid][timestamp]. The table records SALIDs to be deleted along
> with their deletion times (which may be modified)'
> AND compaction = {'class':
> 'org.apache.cassandra.db.compaction.LeveledCompactionStrategy'}
> AND compression = {'chunk_length_kb': '64', 'sstable_compression':
> 'org.apache.cassandra.io.compress.SnappyCompressor'}
> AND dclocal_read_repair_chance = 0.0
> AND default_time_to_live = 0
> AND gc_grace_seconds = 864000
> AND max_index_interval = 2048
> AND memtable_flush_period_in_ms = 0
> AND min_index_interval = 128
> AND read_repair_chance = 0.1
> AND speculative_retry = '99.0PERCENTILE';
>
> CREATE TABLE "SAL".sal_ref (
> key text,
> column1 text,
> column2 text,
> value text,
> PRIMARY KEY (key, column1, column2)
> ) WITH COMPACT STORAGE
> AND CLUSTERING ORDER BY (column1 ASC, column2 ASC)
> AND bloom_filter_fp_chance = 0.025
> AND caching = '{"keys":"ALL", "rows_per_partition":"NONE"}'
> AND comment = 'Holds owner references to content as [salid][lcid/opid]'
> AND compaction = {'sstable_size_in_mb': '180', 'class':
> 'org.apache.cassandra.db.compaction.LeveledCompactionStrategy'}
> AND compression = {'chunk_length_kb': '64', 'sstable_compression':
> 'org.apache.cassandra.io.compress.SnappyCompressor'}
> AND dclocal_read_repair_chance = 0.0
> AND default_time_to_live = 0
> AND gc_grace_seconds = 864000
> AND max_index_interval = 2048
> AND memtable_flush_period_in_ms = 0
> AND min_index_interval = 128
> AND read_repair_chance = 0.0
> AND speculative_retry = '99.0PERCENTILE';
> {code}
> Things to note:
> # The column2 is always passed a null value during insertion
> # column2 is a part of primary key
> # Range select and Range delete is done through our app.
> Iniatally the cluster was on casssandra version 2.1.16 and have been
> recently upgraded to 3.11.4 post the upgrade, we see that the nodes are going
> down, and log the below exceptions during startup and even after node is up.
> This one node is causing the whole cluster to behave improperly.
> {code:java}
> WARN [Native-Transport-Requests-47] 2020-01-29 13:49:05,190
> AbstractLocalAwareExecutorService.java:167 - Uncaught exception on thread
> Thread[Native-Transport-Requests-47,5,main]: {} java.lang.RuntimeException:
> java.lang.IllegalStateException: UnfilteredRowIterator for SAL.sal_purge has
> an open RT bound as its last item at
> org.apache.cassandra.service.StorageProxy$DroppableRunnable.run(StorageProxy.java:2588)
> ~[apache-cassandra-3.11.4.jar:3.11.4] at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> [na:1.8.0-internal] at
> org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$FutureTask.run(AbstractLocalAwareExecutorService.java:162)
> [apache-cassandra-3.11.4.jar:3.11.4] at
> org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$LocalSessionFutureTask.run(AbstractLocalAwareExecutorService.java:134)
> [apache-cassandra-3.11.4.jar:3.11.4] at
> org.apache.cassandra.concurrent.SEPExecutor.maybeExecuteImmediately(SEPExecutor.java:194)
> [apache-cassandra-3.11.4.jar:3.11.4] at
>
[jira] [Commented] (CASSANDRA-15313) Fix flaky - ChecksummingTransformerTest - org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17031189#comment-17031189
]
Brandon Williams commented on CASSANDRA-15313:
--
bq. Lowering the examples means we need more runs to see it.
Sorry, what is 'it' here?
bq. If you run the test with 2-4 does it still fail?
I ran at 4G and it still failed at 200 examples (I didn't try any other sizes
though)
> Fix flaky - ChecksummingTransformerTest -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> ---
>
> Key: CASSANDRA-15313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15313
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Vinay Chella
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> During the recent runs, this test appears to be flaky.
> Example failure:
> [https://circleci.com/gh/vinaykumarchella/cassandra/459#tests/containers/94]
> corruptionCausesFailure-compression -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> {code:java}
> java.lang.OutOfMemoryError: GC overhead limit exceeded
> at java.nio.HeapByteBuffer.(HeapByteBuffer.java:57)
> at java.nio.ByteBuffer.allocate(ByteBuffer.java:335)
> at org.quicktheories.impl.Precursor.(Precursor.java:17)
> at
> org.quicktheories.impl.ConcreteDetachedSource.(ConcreteDetachedSource.java:8)
> at
> org.quicktheories.impl.ConcreteDetachedSource.detach(ConcreteDetachedSource.java:23)
> at org.quicktheories.generators.Retry.generate(CodePoints.java:51)
> at
> org.quicktheories.generators.Generate.lambda$intArrays$10(Generate.java:190)
> at
> org.quicktheories.generators.Generate$$Lambda$17/1847008471.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$mix$10(Gen.java:184)
> at org.quicktheories.core.Gen$$Lambda$45/802243390.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$flatMap$5(Gen.java:93)
> at org.quicktheories.core.Gen$$Lambda$48/363509958.generate(Unknown
> Source)
> at
> org.quicktheories.dsl.TheoryBuilder4.lambda$prgnToTuple$12(TheoryBuilder4.java:188)
> at
> org.quicktheories.dsl.TheoryBuilder4$$Lambda$40/2003496028.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.FilteredGenerator.generate(Gen.java:225)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.impl.Core.generate(Core.java:150)
> at org.quicktheories.impl.Core.shrink(Core.java:103)
> at org.quicktheories.impl.Core.run(Core.java:39)
> at org.quicktheories.impl.TheoryRunner.check(TheoryRunner.java:35)
> at org.quicktheories.dsl.TheoryBuilder4.check(TheoryBuilder4.java:150)
> at
> org.quicktheories.dsl.TheoryBuilder4.checkAssert(TheoryBuilder4.java:162)
> at
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest.corruptionCausesFailure(ChecksummingTransformerTest.java:87)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15527) Fix flakey test - org.apache.cassandra.index.sasi.SASIIndexTest testCrossSSTableQueries
[
https://issues.apache.org/jira/browse/CASSANDRA-15527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17031155#comment-17031155
]
David Capwell commented on CASSANDRA-15527:
---
So you don't see any test fail I take it? [~jrwest] is looking at the other
ticket and just reported he was able to reproduce
https://issues.apache.org/jira/browse/CASSANDRA-15526?focusedCommentId=1703=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-1703
Fun...
> Fix flakey test - org.apache.cassandra.index.sasi.SASIIndexTest
> testCrossSSTableQueries
> ---
>
> Key: CASSANDRA-15527
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15527
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: David Capwell
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-alpha
>
> Attachments: CASSANDRA-15527.txt
>
>
> {code}
> junit.framework.AssertionFailedError: [key13, key2977, key2978, key2979,
> key2980, key2982, key2983, key2984, key2985, key6]
> at
> org.apache.cassandra.index.sasi.SASIIndexTest.testCrossSSTableQueries(SASIIndexTest.java:340)
> at
> org.apache.cassandra.index.sasi.SASIIndexTest.testCrossSSTableQueries(SASIIndexTest.java:286)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-10190) Python 3 support for cqlsh
[ https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17031152#comment-17031152 ] David Capwell commented on CASSANDRA-10190: --- tried to look at the build changes and see config-2.2.yml isn't modified. config.yml* are auto generated from that file so changes need to be there. > Python 3 support for cqlsh > -- > > Key: CASSANDRA-10190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10190 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Tools >Reporter: Andrew Pennebaker >Assignee: Patrick Bannister >Priority: Normal > Labels: cqlsh, pull-request-available > Fix For: 4.0, 4.0-alpha > > Attachments: > 0001-Fix-issues-from-version-specific-logic-commit.patch, > 0001-Update-six-to-1.12.0.patch, > 0002-Simplify-version-specific-logic-by-using-six.moves-a.patch, > coverage_notes.txt > > Time Spent: 20m > Remaining Estimate: 0h > > Users who operate in a Python 3 environment may have trouble launching cqlsh. > Could we please update cqlsh's syntax to run in Python 3? > As a workaround, users can setup pyenv, and cd to a directory with a > .python-version containing "2.7". But it would be nice if cqlsh supported > modern Python versions out of the box. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15527) Fix flakey test - org.apache.cassandra.index.sasi.SASIIndexTest testCrossSSTableQueries
[
https://issues.apache.org/jira/browse/CASSANDRA-15527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17031148#comment-17031148
]
Ekaterina Dimitrova commented on CASSANDRA-15527:
-
I left it running in the background , just checked again. still no failures
after three hours running.
> Fix flakey test - org.apache.cassandra.index.sasi.SASIIndexTest
> testCrossSSTableQueries
> ---
>
> Key: CASSANDRA-15527
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15527
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: David Capwell
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-alpha
>
> Attachments: CASSANDRA-15527.txt
>
>
> {code}
> junit.framework.AssertionFailedError: [key13, key2977, key2978, key2979,
> key2980, key2982, key2983, key2984, key2985, key6]
> at
> org.apache.cassandra.index.sasi.SASIIndexTest.testCrossSSTableQueries(SASIIndexTest.java:340)
> at
> org.apache.cassandra.index.sasi.SASIIndexTest.testCrossSSTableQueries(SASIIndexTest.java:286)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15548) Add a warning when RF > N
[ https://issues.apache.org/jira/browse/CASSANDRA-15548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-15548: - Summary: Add a warning when RF > N (was: Keyspace creation succeeds even though not enough nodes are up) > Add a warning when RF > N > - > > Key: CASSANDRA-15548 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15548 > Project: Cassandra > Issue Type: Bug > Components: Cluster/Schema >Reporter: YCozy >Priority: Normal > > When testing Cassandra with network partitions, we find that keyspace > creation can succeed without any warning even if there are not enough nodes > to support the replication factor. Here are the steps to reproduce: > # Start a cluster w/ two nodes. > # Create a keyspace with replication factor of three. > # Notice that the creation succeeds without any warning. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15548) Add a warning when RF > N
[ https://issues.apache.org/jira/browse/CASSANDRA-15548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17031145#comment-17031145 ] Brandon Williams commented on CASSANDRA-15548: -- A warning seems reasonable here. > Add a warning when RF > N > - > > Key: CASSANDRA-15548 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15548 > Project: Cassandra > Issue Type: Bug > Components: Cluster/Schema >Reporter: YCozy >Priority: Normal > > When testing Cassandra with network partitions, we find that keyspace > creation can succeed without any warning even if there are not enough nodes > to support the replication factor. Here are the steps to reproduce: > # Start a cluster w/ two nodes. > # Create a keyspace with replication factor of three. > # Notice that the creation succeeds without any warning. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15526) Fix flakey test - org.apache.cassandra.index.sasi.SASIIndexTest testConcurrentMemtableReadsAndWrites
[
https://issues.apache.org/jira/browse/CASSANDRA-15526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1703#comment-1703
]
Jordan West commented on CASSANDRA-15526:
-
I was able to reproduce locally and added a message to the assertion to get a
bit more insight. When the {{TrieMemIndex}} is instantiated the map has a first
and last key (it looks like a single key in this case) but size is returning 0.
{code:java}
junit.framework.AssertionFailedError: min = -7787472368264638040, max =
-7787472368264638040, count = 0 {code}
> Fix flakey test - org.apache.cassandra.index.sasi.SASIIndexTest
> testConcurrentMemtableReadsAndWrites
>
>
> Key: CASSANDRA-15526
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15526
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: David Capwell
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> {code}
> junit.framework.AssertionFailedError
> at
> org.apache.cassandra.index.sasi.utils.RangeIterator.(RangeIterator.java:46)
> at
> org.apache.cassandra.index.sasi.memory.KeyRangeIterator.(KeyRangeIterator.java:42)
> at
> org.apache.cassandra.index.sasi.memory.TrieMemIndex$ConcurrentTrie.search(TrieMemIndex.java:150)
> at
> org.apache.cassandra.index.sasi.memory.TrieMemIndex.search(TrieMemIndex.java:102)
> at
> org.apache.cassandra.index.sasi.memory.IndexMemtable.search(IndexMemtable.java:70)
> at
> org.apache.cassandra.index.sasi.conf.ColumnIndex.searchMemtable(ColumnIndex.java:138)
> at org.apache.cassandra.index.sasi.TermIterator.build(TermIterator.java:91)
> at
> org.apache.cassandra.index.sasi.plan.QueryController.getIndexes(QueryController.java:145)
> at
> org.apache.cassandra.index.sasi.plan.Operation$Builder.complete(Operation.java:434)
> at org.apache.cassandra.index.sasi.plan.QueryPlan.analyze(QueryPlan.java:57)
> at org.apache.cassandra.index.sasi.plan.QueryPlan.execute(QueryPlan.java:68)
> at
> org.apache.cassandra.index.sasi.SASIIndex.lambda$searcherFor$2(SASIIndex.java:301)
> at org.apache.cassandra.db.ReadCommand.executeLocally(ReadCommand.java:455)
> at
> org.apache.cassandra.index.sasi.SASIIndexTest.getIndexed(SASIIndexTest.java:2576)
> at
> org.apache.cassandra.index.sasi.SASIIndexTest.getPaged(SASIIndexTest.java:2537)
> at
> org.apache.cassandra.index.sasi.SASIIndexTest.testConcurrentMemtableReadsAndWrites(SASIIndexTest.java:1108)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-10190) Python 3 support for cqlsh
[ https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17031093#comment-17031093 ] Dinesh Joshi commented on CASSANDRA-10190: -- Hi [~dcapwell], thanks for the feedback. I have created a PR for [cassandra|https://github.com/apache/cassandra/pull/438] and [cassandra-dtest|https://github.com/apache/cassandra-dtest/pull/57]. I already have defined build/test pipelines for testing with Python 2 & 3 with [Java 8|https://circleci.com/workflow-run/5dded0dc-59d6-47be-9c3b-e0a2b4074b51] and [11|https://circleci.com/workflow-run/5dded0dc-59d6-47be-9c3b-e0a2b4074b51]. > Python 3 support for cqlsh > -- > > Key: CASSANDRA-10190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10190 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Tools >Reporter: Andrew Pennebaker >Assignee: Patrick Bannister >Priority: Normal > Labels: cqlsh, pull-request-available > Fix For: 4.0, 4.0-alpha > > Attachments: > 0001-Fix-issues-from-version-specific-logic-commit.patch, > 0001-Update-six-to-1.12.0.patch, > 0002-Simplify-version-specific-logic-by-using-six.moves-a.patch, > coverage_notes.txt > > Time Spent: 20m > Remaining Estimate: 0h > > Users who operate in a Python 3 environment may have trouble launching cqlsh. > Could we please update cqlsh's syntax to run in Python 3? > As a workaround, users can setup pyenv, and cd to a directory with a > .python-version containing "2.7". But it would be nice if cqlsh supported > modern Python versions out of the box. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15527) Fix flakey test - org.apache.cassandra.index.sasi.SASIIndexTest testCrossSSTableQueries
[
https://issues.apache.org/jira/browse/CASSANDRA-15527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17031088#comment-17031088
]
Ekaterina Dimitrova commented on CASSANDRA-15527:
-
Pretty weird, I run it already 40-50 minutes the same way as you 1:1 and there
are still no failures
One run takes around 20 seconds so this means around 150 successful runs of all
the tests in the class
> Fix flakey test - org.apache.cassandra.index.sasi.SASIIndexTest
> testCrossSSTableQueries
> ---
>
> Key: CASSANDRA-15527
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15527
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: David Capwell
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-alpha
>
> Attachments: CASSANDRA-15527.txt
>
>
> {code}
> junit.framework.AssertionFailedError: [key13, key2977, key2978, key2979,
> key2980, key2982, key2983, key2984, key2985, key6]
> at
> org.apache.cassandra.index.sasi.SASIIndexTest.testCrossSSTableQueries(SASIIndexTest.java:340)
> at
> org.apache.cassandra.index.sasi.SASIIndexTest.testCrossSSTableQueries(SASIIndexTest.java:286)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15548) Keyspace creation succeeds even though not enough nodes are up
[ https://issues.apache.org/jira/browse/CASSANDRA-15548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17031087#comment-17031087 ] YCozy commented on CASSANDRA-15548: --- [~brandon.williams] Thanks for checking in. It will be great if we can at least have some warnings. Since we ask users to specify the RF during keyspace creation, a success without any warnings hints that users can store data up to the configured RF, which is not the case here. > Keyspace creation succeeds even though not enough nodes are up > -- > > Key: CASSANDRA-15548 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15548 > Project: Cassandra > Issue Type: Bug > Components: Cluster/Schema >Reporter: YCozy >Priority: Normal > > When testing Cassandra with network partitions, we find that keyspace > creation can succeed without any warning even if there are not enough nodes > to support the replication factor. Here are the steps to reproduce: > # Start a cluster w/ two nodes. > # Create a keyspace with replication factor of three. > # Notice that the creation succeeds without any warning. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15527) Fix flakey test - org.apache.cassandra.index.sasi.SASIIndexTest testCrossSSTableQueries
[
https://issues.apache.org/jira/browse/CASSANDRA-15527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17031057#comment-17031057
]
Ekaterina Dimitrova commented on CASSANDRA-15527:
-
Good point, I was running just the single test locally on my Mac.
Thanks
> Fix flakey test - org.apache.cassandra.index.sasi.SASIIndexTest
> testCrossSSTableQueries
> ---
>
> Key: CASSANDRA-15527
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15527
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: David Capwell
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-alpha
>
> Attachments: CASSANDRA-15527.txt
>
>
> {code}
> junit.framework.AssertionFailedError: [key13, key2977, key2978, key2979,
> key2980, key2982, key2983, key2984, key2985, key6]
> at
> org.apache.cassandra.index.sasi.SASIIndexTest.testCrossSSTableQueries(SASIIndexTest.java:340)
> at
> org.apache.cassandra.index.sasi.SASIIndexTest.testCrossSSTableQueries(SASIIndexTest.java:286)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15527) Fix flakey test - org.apache.cassandra.index.sasi.SASIIndexTest testCrossSSTableQueries
[
https://issues.apache.org/jira/browse/CASSANDRA-15527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17031027#comment-17031027
]
David Capwell commented on CASSANDRA-15527:
---
Linked the 2 other JIRAs for this class. Looking at the history all 3 fail
together but out of a hand full of runs on my laptop only
testConcurrentMemtableReadsAndWrites failed; it may be possible that
testConcurrentMemtableReadsAndWrites is flaky and corrupts the other two some
times?
> Fix flakey test - org.apache.cassandra.index.sasi.SASIIndexTest
> testCrossSSTableQueries
> ---
>
> Key: CASSANDRA-15527
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15527
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: David Capwell
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-alpha
>
> Attachments: CASSANDRA-15527.txt
>
>
> {code}
> junit.framework.AssertionFailedError: [key13, key2977, key2978, key2979,
> key2980, key2982, key2983, key2984, key2985, key6]
> at
> org.apache.cassandra.index.sasi.SASIIndexTest.testCrossSSTableQueries(SASIIndexTest.java:340)
> at
> org.apache.cassandra.index.sasi.SASIIndexTest.testCrossSSTableQueries(SASIIndexTest.java:286)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15469) IndexInfo/ColumnIndex Refactors & Cleanup
[ https://issues.apache.org/jira/browse/CASSANDRA-15469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17031021#comment-17031021 ] Jordan West commented on CASSANDRA-15469: - Thanks Dinesh! > IndexInfo/ColumnIndex Refactors & Cleanup > - > > Key: CASSANDRA-15469 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15469 > Project: Cassandra > Issue Type: Improvement > Components: Local/SSTable >Reporter: Jordan West >Assignee: Jordan West >Priority: Normal > Fix For: 4.0-alpha > > > Changes determined by audit of IndexInfo and ColumnIndex changes for > Cassandra 4.0 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15527) Fix flakey test - org.apache.cassandra.index.sasi.SASIIndexTest testCrossSSTableQueries
[
https://issues.apache.org/jira/browse/CASSANDRA-15527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17031019#comment-17031019
]
David Capwell commented on CASSANDRA-15527:
---
do you run the single test or the whole class?
Best way to simulate CI is as follows
{code}
CASSANDRA_USE_JDK11=true ant testclasslist -Dtest.classlistfile=<(echo
org/apache/cassandra/index/sasi/SASIIndexTest.java) -Dtest.classlistprefix=unit
{code}
I ran the following and got a failure locally on my Mac (different test case,
same class)
{code}
$ while true; do CASSANDRA_USE_JDK11=true ant testclasslist
-Dtest.classlistfile=<(echo org/apache/cassandra/index/sasi/SASIIndexTest.java)
-Dtest.classlistprefix=unit; done;
...
[junit-timeout] Testsuite: org.apache.cassandra.index.sasi.SASIIndexTest
[junit-timeout] Testsuite: org.apache.cassandra.index.sasi.SASIIndexTest Tests
run: 32, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 11.27 sec
[junit-timeout]
[junit-timeout] Testcase:
testConcurrentMemtableReadsAndWrites(org.apache.cassandra.index.sasi.SASIIndexTest):
FAILED
[junit-timeout] null
[junit-timeout] junit.framework.AssertionFailedError
[junit-timeout] at
org.apache.cassandra.index.sasi.utils.RangeIterator.(RangeIterator.java:46)
[junit-timeout] at
org.apache.cassandra.index.sasi.memory.KeyRangeIterator.(KeyRangeIterator.java:42)
[junit-timeout] at
org.apache.cassandra.index.sasi.memory.TrieMemIndex$ConcurrentTrie.search(TrieMemIndex.java:150)
[junit-timeout] at
org.apache.cassandra.index.sasi.memory.TrieMemIndex.search(TrieMemIndex.java:102)
[junit-timeout] at
org.apache.cassandra.index.sasi.memory.IndexMemtable.search(IndexMemtable.java:70)
[junit-timeout] at
org.apache.cassandra.index.sasi.conf.ColumnIndex.searchMemtable(ColumnIndex.java:138)
[junit-timeout] at
org.apache.cassandra.index.sasi.TermIterator.build(TermIterator.java:91)
[junit-timeout] at
org.apache.cassandra.index.sasi.plan.QueryController.getIndexes(QueryController.java:145)
[junit-timeout] at
org.apache.cassandra.index.sasi.plan.Operation$Builder.complete(Operation.java:434)
[junit-timeout] at
org.apache.cassandra.index.sasi.plan.QueryPlan.analyze(QueryPlan.java:57)
[junit-timeout] at
org.apache.cassandra.index.sasi.plan.QueryPlan.execute(QueryPlan.java:68)
[junit-timeout] at
org.apache.cassandra.index.sasi.SASIIndex.lambda$searcherFor$2(SASIIndex.java:301)
[junit-timeout] at
org.apache.cassandra.db.ReadCommand.executeLocally(ReadCommand.java:455)
[junit-timeout] at
org.apache.cassandra.index.sasi.SASIIndexTest.getIndexed(SASIIndexTest.java:2576)
[junit-timeout] at
org.apache.cassandra.index.sasi.SASIIndexTest.getPaged(SASIIndexTest.java:2537)
[junit-timeout] at
org.apache.cassandra.index.sasi.SASIIndexTest.testConcurrentMemtableReadsAndWrites(SASIIndexTest.java:1108)
[junit-timeout] at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[junit-timeout] at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[junit-timeout] at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[junit-timeout]
[junit-timeout]
[junit-timeout] Test org.apache.cassandra.index.sasi.SASIIndexTest FAILED
{code}
May be possible that one test is flaky and corrupts the other tests
> Fix flakey test - org.apache.cassandra.index.sasi.SASIIndexTest
> testCrossSSTableQueries
> ---
>
> Key: CASSANDRA-15527
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15527
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: David Capwell
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-alpha
>
> Attachments: CASSANDRA-15527.txt
>
>
> {code}
> junit.framework.AssertionFailedError: [key13, key2977, key2978, key2979,
> key2980, key2982, key2983, key2984, key2985, key6]
> at
> org.apache.cassandra.index.sasi.SASIIndexTest.testCrossSSTableQueries(SASIIndexTest.java:340)
> at
> org.apache.cassandra.index.sasi.SASIIndexTest.testCrossSSTableQueries(SASIIndexTest.java:286)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15527) Fix flakey test - org.apache.cassandra.index.sasi.SASIIndexTest testCrossSSTableQueries
[
https://issues.apache.org/jira/browse/CASSANDRA-15527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-15527:
Attachment: CASSANDRA-15527.txt
> Fix flakey test - org.apache.cassandra.index.sasi.SASIIndexTest
> testCrossSSTableQueries
> ---
>
> Key: CASSANDRA-15527
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15527
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: David Capwell
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-alpha
>
> Attachments: CASSANDRA-15527.txt
>
>
> {code}
> junit.framework.AssertionFailedError: [key13, key2977, key2978, key2979,
> key2980, key2982, key2983, key2984, key2985, key6]
> at
> org.apache.cassandra.index.sasi.SASIIndexTest.testCrossSSTableQueries(SASIIndexTest.java:340)
> at
> org.apache.cassandra.index.sasi.SASIIndexTest.testCrossSSTableQueries(SASIIndexTest.java:286)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15527) Fix flakey test - org.apache.cassandra.index.sasi.SASIIndexTest testCrossSSTableQueries
[
https://issues.apache.org/jira/browse/CASSANDRA-15527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17031011#comment-17031011
]
Ekaterina Dimitrova commented on CASSANDRA-15527:
-
100 times it passed successfully so I am not really able to reproduce the issue
easily and go through everything with the debugger... Attaching the log.
> Fix flakey test - org.apache.cassandra.index.sasi.SASIIndexTest
> testCrossSSTableQueries
> ---
>
> Key: CASSANDRA-15527
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15527
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: David Capwell
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> {code}
> junit.framework.AssertionFailedError: [key13, key2977, key2978, key2979,
> key2980, key2982, key2983, key2984, key2985, key6]
> at
> org.apache.cassandra.index.sasi.SASIIndexTest.testCrossSSTableQueries(SASIIndexTest.java:340)
> at
> org.apache.cassandra.index.sasi.SASIIndexTest.testCrossSSTableQueries(SASIIndexTest.java:286)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15469) IndexInfo/ColumnIndex Refactors & Cleanup
[ https://issues.apache.org/jira/browse/CASSANDRA-15469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRA-15469: - Fix Version/s: (was: 4.0-beta) 4.0-alpha Source Control Link: https://github.com/apache/cassandra/commit/c0c756d201fa23fb29bf96c97b197ab4c2543326 Resolution: Fixed Status: Resolved (was: Ready to Commit) Committed, thanks for the patch [~jrwest]! > IndexInfo/ColumnIndex Refactors & Cleanup > - > > Key: CASSANDRA-15469 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15469 > Project: Cassandra > Issue Type: Improvement > Components: Local/SSTable >Reporter: Jordan West >Assignee: Jordan West >Priority: Normal > Fix For: 4.0-alpha > > > Changes determined by audit of IndexInfo and ColumnIndex changes for > Cassandra 4.0 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (a0c55b1 -> c0c756d)
This is an automated email from the ASF dual-hosted git repository. djoshi pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from a0c55b1 Ninja Fix: Update CHANGES.txt for 15470 add c0c756d Cleanup and improvements to IndexInfo/ColumnIndex No new revisions were added by this update. Summary of changes: CHANGES.txt| 1 + src/java/org/apache/cassandra/config/Config.java | 2 +- .../cassandra/config/DatabaseDescriptor.java | 6 +- src/java/org/apache/cassandra/db/ColumnIndex.java | 15 ++-- .../org/apache/cassandra/db/RowIndexEntry.java | 85 -- .../cassandra/io/sstable/format/SSTableReader.java | 2 +- .../io/sstable/format/big/BigTableReader.java | 2 +- .../io/sstable/format/big/BigTableScanner.java | 4 +- .../apache/cassandra/service/StorageService.java | 11 +++ .../cassandra/service/StorageServiceMBean.java | 5 ++ 10 files changed, 84 insertions(+), 49 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (7b637d5 -> a0c55b1)
This is an automated email from the ASF dual-hosted git repository. djoshi pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 7b637d5 Potential Overflow in DatabaseDescriptor Functions That Convert Between KB/MB & Bytes add a0c55b1 Ninja Fix: Update CHANGES.txt for 15470 No new revisions were added by this update. Summary of changes: CHANGES.txt | 2 ++ 1 file changed, 2 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15470) Potential Overflow in DatabaseDescriptor Functions That Convert Between KB/MB & Bytes
[
https://issues.apache.org/jira/browse/CASSANDRA-15470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dinesh Joshi updated CASSANDRA-15470:
-
Since Version: 4.x
Source Control Link:
https://github.com/apache/cassandra/commit/7b637d5c2dbfcb387fc24d4d7145f6eb1e2f2052
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
Committed. Thanks, [~mallika] and [~jrwest].
> Potential Overflow in DatabaseDescriptor Functions That Convert Between KB/MB
> & Bytes
> -
>
> Key: CASSANDRA-15470
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15470
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
>Reporter: Jordan West
>Assignee: Mallika Kulkarni
>Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0-rc
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{DatabaseDescriptor}} has several functions that convert between user
> supplied sizes in KB/MB and bytes. These are implemented without much
> consistency and, while unlikely, several have the potential to overflow since
> validation on the input is missing. Meanwhile, some widen the number to a
> long correctly. Options include: widening in all places or simply doing
> better validation on start up — currently only the lower bound of the valid
> range is checked for many of these fields.
> List of Affected {{DatabaseDescriptor}} Methods:
> * {{getColumnIndexSize}}
> * {{getColumnIndexCacheSize}}
> * {{getBatchSizeWarnThreshold}}
> * {{getNativeTransportFrameBlockSize}}
> * {{getRepairSessionSpaceInMegabytes}}
> * {{getNativeTransportMaxFrameSize}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (1b0f192 -> 7b637d5)
This is an automated email from the ASF dual-hosted git repository. djoshi pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 1b0f192 Reduce example size to stabilize ChecksummingTransformerTest add 7b637d5 Potential Overflow in DatabaseDescriptor Functions That Convert Between KB/MB & Bytes No new revisions were added by this update. Summary of changes: .../cassandra/config/DatabaseDescriptor.java | 91 ++ .../config/DatabaseDescriptorRefTest.java | 1 + .../cassandra/config/DatabaseDescriptorTest.java | 51 .../db/compaction/CompactionsCQLTest.java | 8 +- 4 files changed, 131 insertions(+), 20 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-10190) Python 3 support for cqlsh
[
https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030953#comment-17030953
]
David Capwell commented on CASSANDRA-10190:
---
https://github.com/apache/cassandra/compare/trunk...dineshjoshi:10190-trunk-review#diff-6469b081699ab92c53e0513a499ca5ebR58.
could simplify to return 0 or 1, then the branch could be
{code}
if is_supported_version "$version"; then
{code}
https://github.com/apache/cassandra/compare/trunk...dineshjoshi:10190-trunk-review#diff-6469b081699ab92c53e0513a499ca5ebR75
Should propagate the return code
https://github.com/apache/cassandra/compare/trunk...dineshjoshi:10190-trunk-review#diff-6469b081699ab92c53e0513a499ca5ebR83
When disabling can you leave a comment so future maintainers know why?
script LGTM, will start testing after lunch.
I plan to do the following test
1) don't define CQLSH_PYTHON - run python dtests (circle ci is already doing
this)
2) define CQLSH_PYTHON pointing to 2.7 - run python dtests
3) define CQLSH_PYTHON pointing to 3.6 - run Python dtests
> Python 3 support for cqlsh
> --
>
> Key: CASSANDRA-10190
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10190
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Tools
>Reporter: Andrew Pennebaker
>Assignee: Patrick Bannister
>Priority: Normal
> Labels: cqlsh, pull-request-available
> Fix For: 4.0, 4.0-alpha
>
> Attachments:
> 0001-Fix-issues-from-version-specific-logic-commit.patch,
> 0001-Update-six-to-1.12.0.patch,
> 0002-Simplify-version-specific-logic-by-using-six.moves-a.patch,
> coverage_notes.txt
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Users who operate in a Python 3 environment may have trouble launching cqlsh.
> Could we please update cqlsh's syntax to run in Python 3?
> As a workaround, users can setup pyenv, and cd to a directory with a
> .python-version containing "2.7". But it would be nice if cqlsh supported
> modern Python versions out of the box.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15552) Fix flaky test org.apache.cassandra.db.repair.PendingAntiCompactionBytemanTest.testExceptionAnticompaction
[
https://issues.apache.org/jira/browse/CASSANDRA-15552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-15552:
--
Bug Category: Parent values: Correctness(12982)Level 1 values: Test
Failure(12990)
Complexity: Normal
Discovered By: Unit Test
Fix Version/s: 4.0-alpha
Severity: Normal
Status: Open (was: Triage Needed)
> Fix flaky test
> org.apache.cassandra.db.repair.PendingAntiCompactionBytemanTest.testExceptionAnticompaction
> --
>
> Key: CASSANDRA-15552
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15552
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: David Capwell
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> {code}
> junit.framework.AssertionFailedError
> at
> org.apache.cassandra.db.repair.PendingAntiCompactionBytemanTest.testExceptionAnticompaction(PendingAntiCompactionBytemanTest.java:80)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at
> org.jboss.byteman.contrib.bmunit.BMUnitRunner$9.evaluate(BMUnitRunner.java:364)
> at
> org.jboss.byteman.contrib.bmunit.BMUnitRunner$6.evaluate(BMUnitRunner.java:263)
> at
> org.jboss.byteman.contrib.bmunit.BMUnitRunner$1.evaluate(BMUnitRunner.java:97)
> {code}
> Failure was on java 11
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15552) Fix flaky test org.apache.cassandra.db.repair.PendingAntiCompactionBytemanTest.testExceptionAnticompaction
David Capwell created CASSANDRA-15552:
-
Summary: Fix flaky test
org.apache.cassandra.db.repair.PendingAntiCompactionBytemanTest.testExceptionAnticompaction
Key: CASSANDRA-15552
URL: https://issues.apache.org/jira/browse/CASSANDRA-15552
Project: Cassandra
Issue Type: Bug
Components: Test/unit
Reporter: David Capwell
{code}
junit.framework.AssertionFailedError
at
org.apache.cassandra.db.repair.PendingAntiCompactionBytemanTest.testExceptionAnticompaction(PendingAntiCompactionBytemanTest.java:80)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at
org.jboss.byteman.contrib.bmunit.BMUnitRunner$9.evaluate(BMUnitRunner.java:364)
at
org.jboss.byteman.contrib.bmunit.BMUnitRunner$6.evaluate(BMUnitRunner.java:263)
at
org.jboss.byteman.contrib.bmunit.BMUnitRunner$1.evaluate(BMUnitRunner.java:97)
{code}
Failure was on java 11
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15551) Fix flaky tests org.apache.cassandra.service.MoveTest testStateJumpToNormal and testMoveWithPendingRangesNetworkStrategyRackAwareThirtyNodes
[
https://issues.apache.org/jira/browse/CASSANDRA-15551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-15551:
--
Summary: Fix flaky tests org.apache.cassandra.service.MoveTest
testStateJumpToNormal and
testMoveWithPendingRangesNetworkStrategyRackAwareThirtyNodes (was:
org.apache.cassandra.service.MoveTest testStateJumpToNormal and
testMoveWithPendingRangesNetworkStrategyRackAwareThirtyNodes)
> Fix flaky tests org.apache.cassandra.service.MoveTest testStateJumpToNormal
> and testMoveWithPendingRangesNetworkStrategyRackAwareThirtyNodes
>
>
> Key: CASSANDRA-15551
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15551
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: David Capwell
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> testStateJumpToNormal failure was on java 11
> {code}
> java.lang.NullPointerException
> at org.apache.cassandra.gms.Gossiper.getHostId(Gossiper.java:1028)
> at org.apache.cassandra.gms.Gossiper.getHostId(Gossiper.java:1023)
> at
> org.apache.cassandra.service.StorageService.handleStateNormal(StorageService.java:2513)
> at
> org.apache.cassandra.service.StorageService.onChange(StorageService.java:2055)
> at org.apache.cassandra.Util.createInitialRing(Util.java:225)
> at
> org.apache.cassandra.service.MoveTest.testStateJumpToNormal(MoveTest.java:935)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
> testMoveWithPendingRangesNetworkStrategyRackAwareThirtyNodes failure was on
> java 8
> {code}
> java.lang.NullPointerException
> at
> org.apache.cassandra.service.StorageService.updatePeerInfo(StorageService.java:2174)
> at
> org.apache.cassandra.service.StorageService.handleStateNormal(StorageService.java:2511)
> at
> org.apache.cassandra.service.StorageService.onChange(StorageService.java:2055)
> at org.apache.cassandra.Util.createInitialRing(Util.java:225)
> at
> org.apache.cassandra.service.MoveTest.testMoveWithPendingRangesNetworkStrategyRackAwareThirtyNodes(MoveTest.java:199)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15551) org.apache.cassandra.service.MoveTest testStateJumpToNormal and testMoveWithPendingRangesNetworkStrategyRackAwareThirtyNodes
[
https://issues.apache.org/jira/browse/CASSANDRA-15551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-15551:
--
Bug Category: Parent values: Correctness(12982)Level 1 values: Test
Failure(12990)
Complexity: Normal
Discovered By: Unit Test
Fix Version/s: 4.0-alpha
Severity: Normal
Status: Open (was: Triage Needed)
> org.apache.cassandra.service.MoveTest testStateJumpToNormal and
> testMoveWithPendingRangesNetworkStrategyRackAwareThirtyNodes
>
>
> Key: CASSANDRA-15551
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15551
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: David Capwell
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> testStateJumpToNormal failure was on java 11
> {code}
> java.lang.NullPointerException
> at org.apache.cassandra.gms.Gossiper.getHostId(Gossiper.java:1028)
> at org.apache.cassandra.gms.Gossiper.getHostId(Gossiper.java:1023)
> at
> org.apache.cassandra.service.StorageService.handleStateNormal(StorageService.java:2513)
> at
> org.apache.cassandra.service.StorageService.onChange(StorageService.java:2055)
> at org.apache.cassandra.Util.createInitialRing(Util.java:225)
> at
> org.apache.cassandra.service.MoveTest.testStateJumpToNormal(MoveTest.java:935)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
> testMoveWithPendingRangesNetworkStrategyRackAwareThirtyNodes failure was on
> java 8
> {code}
> java.lang.NullPointerException
> at
> org.apache.cassandra.service.StorageService.updatePeerInfo(StorageService.java:2174)
> at
> org.apache.cassandra.service.StorageService.handleStateNormal(StorageService.java:2511)
> at
> org.apache.cassandra.service.StorageService.onChange(StorageService.java:2055)
> at org.apache.cassandra.Util.createInitialRing(Util.java:225)
> at
> org.apache.cassandra.service.MoveTest.testMoveWithPendingRangesNetworkStrategyRackAwareThirtyNodes(MoveTest.java:199)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15550) Fix flaky test org.apache.cassandra.streaming.StreamTransferTaskTest testFailSessionDuringTransferShouldNotReleaseReferences
[
https://issues.apache.org/jira/browse/CASSANDRA-15550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-15550:
--
Description:
{code}
junit.framework.AssertionFailedError: expected:<0> but was:<1>
at
org.apache.cassandra.streaming.StreamTransferTaskTest.testFailSessionDuringTransferShouldNotReleaseReferences(StreamTransferTaskTest.java:181)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
{code}
Failure was on java 11
was:
junit.framework.AssertionFailedError: expected:<0> but was:<1>
at
org.apache.cassandra.streaming.StreamTransferTaskTest.testFailSessionDuringTransferShouldNotReleaseReferences(StreamTransferTaskTest.java:181)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
Failure was on java 11
> Fix flaky test org.apache.cassandra.streaming.StreamTransferTaskTest
> testFailSessionDuringTransferShouldNotReleaseReferences
>
>
> Key: CASSANDRA-15550
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15550
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: David Capwell
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> {code}
> junit.framework.AssertionFailedError: expected:<0> but was:<1>
> at
> org.apache.cassandra.streaming.StreamTransferTaskTest.testFailSessionDuringTransferShouldNotReleaseReferences(StreamTransferTaskTest.java:181)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
> Failure was on java 11
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15551) org.apache.cassandra.service.MoveTest testStateJumpToNormal and testMoveWithPendingRangesNetworkStrategyRackAwareThirtyNodes
David Capwell created CASSANDRA-15551: - Summary: org.apache.cassandra.service.MoveTest testStateJumpToNormal and testMoveWithPendingRangesNetworkStrategyRackAwareThirtyNodes Key: CASSANDRA-15551 URL: https://issues.apache.org/jira/browse/CASSANDRA-15551 Project: Cassandra Issue Type: Bug Components: Test/unit Reporter: David Capwell testStateJumpToNormal failure was on java 11 java.lang.NullPointerException at org.apache.cassandra.gms.Gossiper.getHostId(Gossiper.java:1028) at org.apache.cassandra.gms.Gossiper.getHostId(Gossiper.java:1023) at org.apache.cassandra.service.StorageService.handleStateNormal(StorageService.java:2513) at org.apache.cassandra.service.StorageService.onChange(StorageService.java:2055) at org.apache.cassandra.Util.createInitialRing(Util.java:225) at org.apache.cassandra.service.MoveTest.testStateJumpToNormal(MoveTest.java:935) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) testMoveWithPendingRangesNetworkStrategyRackAwareThirtyNodes failure was on java 8 java.lang.NullPointerException at org.apache.cassandra.service.StorageService.updatePeerInfo(StorageService.java:2174) at org.apache.cassandra.service.StorageService.handleStateNormal(StorageService.java:2511) at org.apache.cassandra.service.StorageService.onChange(StorageService.java:2055) at org.apache.cassandra.Util.createInitialRing(Util.java:225) at org.apache.cassandra.service.MoveTest.testMoveWithPendingRangesNetworkStrategyRackAwareThirtyNodes(MoveTest.java:199) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15551) org.apache.cassandra.service.MoveTest testStateJumpToNormal and testMoveWithPendingRangesNetworkStrategyRackAwareThirtyNodes
[
https://issues.apache.org/jira/browse/CASSANDRA-15551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-15551:
--
Description:
testStateJumpToNormal failure was on java 11
{code}
java.lang.NullPointerException
at org.apache.cassandra.gms.Gossiper.getHostId(Gossiper.java:1028)
at org.apache.cassandra.gms.Gossiper.getHostId(Gossiper.java:1023)
at
org.apache.cassandra.service.StorageService.handleStateNormal(StorageService.java:2513)
at
org.apache.cassandra.service.StorageService.onChange(StorageService.java:2055)
at org.apache.cassandra.Util.createInitialRing(Util.java:225)
at
org.apache.cassandra.service.MoveTest.testStateJumpToNormal(MoveTest.java:935)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
{code}
testMoveWithPendingRangesNetworkStrategyRackAwareThirtyNodes failure was on
java 8
{code}
java.lang.NullPointerException
at
org.apache.cassandra.service.StorageService.updatePeerInfo(StorageService.java:2174)
at
org.apache.cassandra.service.StorageService.handleStateNormal(StorageService.java:2511)
at
org.apache.cassandra.service.StorageService.onChange(StorageService.java:2055)
at org.apache.cassandra.Util.createInitialRing(Util.java:225)
at
org.apache.cassandra.service.MoveTest.testMoveWithPendingRangesNetworkStrategyRackAwareThirtyNodes(MoveTest.java:199)
{code}
was:
testStateJumpToNormal failure was on java 11
java.lang.NullPointerException
at org.apache.cassandra.gms.Gossiper.getHostId(Gossiper.java:1028)
at org.apache.cassandra.gms.Gossiper.getHostId(Gossiper.java:1023)
at
org.apache.cassandra.service.StorageService.handleStateNormal(StorageService.java:2513)
at
org.apache.cassandra.service.StorageService.onChange(StorageService.java:2055)
at org.apache.cassandra.Util.createInitialRing(Util.java:225)
at
org.apache.cassandra.service.MoveTest.testStateJumpToNormal(MoveTest.java:935)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
testMoveWithPendingRangesNetworkStrategyRackAwareThirtyNodes failure was on
java 8
java.lang.NullPointerException
at
org.apache.cassandra.service.StorageService.updatePeerInfo(StorageService.java:2174)
at
org.apache.cassandra.service.StorageService.handleStateNormal(StorageService.java:2511)
at
org.apache.cassandra.service.StorageService.onChange(StorageService.java:2055)
at org.apache.cassandra.Util.createInitialRing(Util.java:225)
at
org.apache.cassandra.service.MoveTest.testMoveWithPendingRangesNetworkStrategyRackAwareThirtyNodes(MoveTest.java:199)
> org.apache.cassandra.service.MoveTest testStateJumpToNormal and
> testMoveWithPendingRangesNetworkStrategyRackAwareThirtyNodes
>
>
> Key: CASSANDRA-15551
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15551
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: David Capwell
>Priority: Normal
>
> testStateJumpToNormal failure was on java 11
> {code}
> java.lang.NullPointerException
> at org.apache.cassandra.gms.Gossiper.getHostId(Gossiper.java:1028)
> at org.apache.cassandra.gms.Gossiper.getHostId(Gossiper.java:1023)
> at
> org.apache.cassandra.service.StorageService.handleStateNormal(StorageService.java:2513)
> at
> org.apache.cassandra.service.StorageService.onChange(StorageService.java:2055)
> at org.apache.cassandra.Util.createInitialRing(Util.java:225)
> at
> org.apache.cassandra.service.MoveTest.testStateJumpToNormal(MoveTest.java:935)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
> testMoveWithPendingRangesNetworkStrategyRackAwareThirtyNodes failure was on
> java 8
> {code}
> java.lang.NullPointerException
> at
> org.apache.cassandra.service.StorageService.updatePeerInfo(StorageService.java:2174)
> at
>
[jira] [Updated] (CASSANDRA-15550) Fix flaky test org.apache.cassandra.streaming.StreamTransferTaskTest testFailSessionDuringTransferShouldNotReleaseReferences
[ https://issues.apache.org/jira/browse/CASSANDRA-15550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15550: -- Bug Category: Parent values: Correctness(12982)Level 1 values: Test Failure(12990) Complexity: Normal Discovered By: Unit Test Fix Version/s: 4.0-alpha Severity: Normal Status: Open (was: Triage Needed) > Fix flaky test org.apache.cassandra.streaming.StreamTransferTaskTest > testFailSessionDuringTransferShouldNotReleaseReferences > > > Key: CASSANDRA-15550 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15550 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: David Capwell >Priority: Normal > Fix For: 4.0-alpha > > > junit.framework.AssertionFailedError: expected:<0> but was:<1> > at > org.apache.cassandra.streaming.StreamTransferTaskTest.testFailSessionDuringTransferShouldNotReleaseReferences(StreamTransferTaskTest.java:181) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > Failure was on java 11 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15550) Fix flaky test org.apache.cassandra.streaming.StreamTransferTaskTest testFailSessionDuringTransferShouldNotReleaseReferences
David Capwell created CASSANDRA-15550: - Summary: Fix flaky test org.apache.cassandra.streaming.StreamTransferTaskTest testFailSessionDuringTransferShouldNotReleaseReferences Key: CASSANDRA-15550 URL: https://issues.apache.org/jira/browse/CASSANDRA-15550 Project: Cassandra Issue Type: Bug Components: Test/unit Reporter: David Capwell junit.framework.AssertionFailedError: expected:<0> but was:<1> at org.apache.cassandra.streaming.StreamTransferTaskTest.testFailSessionDuringTransferShouldNotReleaseReferences(StreamTransferTaskTest.java:181) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) Failure was on java 11 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15548) Keyspace creation succeeds even though not enough nodes are up
[ https://issues.apache.org/jira/browse/CASSANDRA-15548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030912#comment-17030912 ] Brandon Williams commented on CASSANDRA-15548: -- Schema isn't bound to RF, this is perfectly normal. > Keyspace creation succeeds even though not enough nodes are up > -- > > Key: CASSANDRA-15548 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15548 > Project: Cassandra > Issue Type: Bug > Components: Cluster/Schema >Reporter: YCozy >Priority: Normal > > When testing Cassandra with network partitions, we find that keyspace > creation can succeed without any warning even if there are not enough nodes > to support the replication factor. Here are the steps to reproduce: > # Start a cluster w/ two nodes. > # Create a keyspace with replication factor of three. > # Notice that the creation succeeds without any warning. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15539) Extract in-jvm API and tests out of Cassandra and into a separate repository
[ https://issues.apache.org/jira/browse/CASSANDRA-15539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030909#comment-17030909 ] David Capwell commented on CASSANDRA-15539: --- Patch mostly LGTM, the main concern I have is with the rollout; we should plan for how to get from now to the desired state without impacting builds/CI. [~ifesdjeen] can you propose a way to do this? > Extract in-jvm API and tests out of Cassandra and into a separate repository > > > Key: CASSANDRA-15539 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15539 > Project: Cassandra > Issue Type: Task > Components: Test/dtest >Reporter: Alex Petrov >Assignee: Alex Petrov >Priority: Normal > > Extract in-jvm DTest _API_ and tests into a separate repository that is > shared between Cassandra branches. Tests themselves should be buildable using > just API, which is not the case now, since cluster creation relies on impl > package, since we do not have factories / constructors in API. > Main goals we’re trying to achieve: > 1. We should be able to fail a build on API incompatibility between versions > 2. Make it as easy as possible to detect break APIs between versions. > 3. Make development of _tests_ based on in-jvm framework simpler > 4. Reduce surface area of impact when making modifications to tests > Potentially, we’d also like to use a plugin to detect API incompatibilities > between in-jvm DTest API and in-branch implementations, and start running > tests using shared in-jvm test repository with each existing implementation > in the branch. This entails both running tests for all branches whenever > there’s a change in tests jar and running tests for a specific branch > whenever the branch has changed. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-10190) Python 3 support for cqlsh
[ https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CASSANDRA-10190: --- Labels: cqlsh pull-request-available (was: cqlsh) > Python 3 support for cqlsh > -- > > Key: CASSANDRA-10190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10190 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Tools >Reporter: Andrew Pennebaker >Assignee: Patrick Bannister >Priority: Normal > Labels: cqlsh, pull-request-available > Fix For: 4.0, 4.0-alpha > > Attachments: > 0001-Fix-issues-from-version-specific-logic-commit.patch, > 0001-Update-six-to-1.12.0.patch, > 0002-Simplify-version-specific-logic-by-using-six.moves-a.patch, > coverage_notes.txt > > > Users who operate in a Python 3 environment may have trouble launching cqlsh. > Could we please update cqlsh's syntax to run in Python 3? > As a workaround, users can setup pyenv, and cd to a directory with a > .python-version containing "2.7". But it would be nice if cqlsh supported > modern Python versions out of the box. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15549) Remove all recommendations to run Cassandra as root
[ https://issues.apache.org/jira/browse/CASSANDRA-15549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15549: -- Change Category: Operability Complexity: Low Hanging Fruit Fix Version/s: 4.0-alpha Status: Open (was: Triage Needed) > Remove all recommendations to run Cassandra as root > --- > > Key: CASSANDRA-15549 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15549 > Project: Cassandra > Issue Type: Improvement > Components: Local/Other >Reporter: David Capwell >Priority: Normal > Fix For: 4.0-alpha > > > There are several exceptions/logs in the code which recommend users to run > Cassandra as root, should remove these since users really shouldn’t be > running Cassandra as root. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15549) Remove all recommendations to run Cassandra as root
David Capwell created CASSANDRA-15549: - Summary: Remove all recommendations to run Cassandra as root Key: CASSANDRA-15549 URL: https://issues.apache.org/jira/browse/CASSANDRA-15549 Project: Cassandra Issue Type: Improvement Components: Local/Other Reporter: David Capwell There are several exceptions/logs in the code which recommend users to run Cassandra as root, should remove these since users really shouldn’t be running Cassandra as root. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15313) Fix flaky - ChecksummingTransformerTest - org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030845#comment-17030845
]
David Capwell commented on CASSANDRA-15313:
---
Lowering the examples means we need more runs to see it. Looking at the JVM we
spin up I see its -Xmx1024m so we have 1g of heap; If you run the test with 2-4
does it still fail?
CI runs the test with the following
{code}
ant testclasslist -Dtest.classlistfile=<(echo
org/apache/cassandra/transport/frame/checksum/ChecksummingTransformerTest.java)
-Dtest.classlistprefix=unit
{code}
Quickly looking at the code it transfers Strings as a wrapper for byte[]. This
is more garbage to generate and toss so could also be reduced by using byte[]
instead.
Do we have a heap dump of the test so we know what the top memory was from?
500 isn't a large example size, so this sounds more like we could improve the
generators.
> Fix flaky - ChecksummingTransformerTest -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> ---
>
> Key: CASSANDRA-15313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15313
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Vinay Chella
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> During the recent runs, this test appears to be flaky.
> Example failure:
> [https://circleci.com/gh/vinaykumarchella/cassandra/459#tests/containers/94]
> corruptionCausesFailure-compression -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> {code:java}
> java.lang.OutOfMemoryError: GC overhead limit exceeded
> at java.nio.HeapByteBuffer.(HeapByteBuffer.java:57)
> at java.nio.ByteBuffer.allocate(ByteBuffer.java:335)
> at org.quicktheories.impl.Precursor.(Precursor.java:17)
> at
> org.quicktheories.impl.ConcreteDetachedSource.(ConcreteDetachedSource.java:8)
> at
> org.quicktheories.impl.ConcreteDetachedSource.detach(ConcreteDetachedSource.java:23)
> at org.quicktheories.generators.Retry.generate(CodePoints.java:51)
> at
> org.quicktheories.generators.Generate.lambda$intArrays$10(Generate.java:190)
> at
> org.quicktheories.generators.Generate$$Lambda$17/1847008471.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$mix$10(Gen.java:184)
> at org.quicktheories.core.Gen$$Lambda$45/802243390.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$flatMap$5(Gen.java:93)
> at org.quicktheories.core.Gen$$Lambda$48/363509958.generate(Unknown
> Source)
> at
> org.quicktheories.dsl.TheoryBuilder4.lambda$prgnToTuple$12(TheoryBuilder4.java:188)
> at
> org.quicktheories.dsl.TheoryBuilder4$$Lambda$40/2003496028.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.FilteredGenerator.generate(Gen.java:225)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.impl.Core.generate(Core.java:150)
> at org.quicktheories.impl.Core.shrink(Core.java:103)
> at org.quicktheories.impl.Core.run(Core.java:39)
> at org.quicktheories.impl.TheoryRunner.check(TheoryRunner.java:35)
> at org.quicktheories.dsl.TheoryBuilder4.check(TheoryBuilder4.java:150)
> at
> org.quicktheories.dsl.TheoryBuilder4.checkAssert(TheoryBuilder4.java:162)
> at
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest.corruptionCausesFailure(ChecksummingTransformerTest.java:87)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15313) Fix flaky - ChecksummingTransformerTest - org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030836#comment-17030836
]
Brandon Williams commented on CASSANDRA-15313:
--
bq. I do see the timeout on linux with lz4 1.7.1, although I didn't manage to
trigger the crash
You probably need to override the test timeout so it can complete.
bq. +1 on lowering the number of examples to stabilise the test.
I committed the reduction to 35 examples.
> Fix flaky - ChecksummingTransformerTest -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> ---
>
> Key: CASSANDRA-15313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15313
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Vinay Chella
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> During the recent runs, this test appears to be flaky.
> Example failure:
> [https://circleci.com/gh/vinaykumarchella/cassandra/459#tests/containers/94]
> corruptionCausesFailure-compression -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> {code:java}
> java.lang.OutOfMemoryError: GC overhead limit exceeded
> at java.nio.HeapByteBuffer.(HeapByteBuffer.java:57)
> at java.nio.ByteBuffer.allocate(ByteBuffer.java:335)
> at org.quicktheories.impl.Precursor.(Precursor.java:17)
> at
> org.quicktheories.impl.ConcreteDetachedSource.(ConcreteDetachedSource.java:8)
> at
> org.quicktheories.impl.ConcreteDetachedSource.detach(ConcreteDetachedSource.java:23)
> at org.quicktheories.generators.Retry.generate(CodePoints.java:51)
> at
> org.quicktheories.generators.Generate.lambda$intArrays$10(Generate.java:190)
> at
> org.quicktheories.generators.Generate$$Lambda$17/1847008471.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$mix$10(Gen.java:184)
> at org.quicktheories.core.Gen$$Lambda$45/802243390.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$flatMap$5(Gen.java:93)
> at org.quicktheories.core.Gen$$Lambda$48/363509958.generate(Unknown
> Source)
> at
> org.quicktheories.dsl.TheoryBuilder4.lambda$prgnToTuple$12(TheoryBuilder4.java:188)
> at
> org.quicktheories.dsl.TheoryBuilder4$$Lambda$40/2003496028.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.FilteredGenerator.generate(Gen.java:225)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.impl.Core.generate(Core.java:150)
> at org.quicktheories.impl.Core.shrink(Core.java:103)
> at org.quicktheories.impl.Core.run(Core.java:39)
> at org.quicktheories.impl.TheoryRunner.check(TheoryRunner.java:35)
> at org.quicktheories.dsl.TheoryBuilder4.check(TheoryBuilder4.java:150)
> at
> org.quicktheories.dsl.TheoryBuilder4.checkAssert(TheoryBuilder4.java:162)
> at
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest.corruptionCausesFailure(ChecksummingTransformerTest.java:87)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15519) Make native_transport_max_concurrent_requests_in_bytes(_per_ip) changeable at runtime
[ https://issues.apache.org/jira/browse/CASSANDRA-15519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lohfink updated CASSANDRA-15519: -- Reviewers: Chris Lohfink, Sumanth Pasupuleti (was: Sumanth Pasupuleti) > Make native_transport_max_concurrent_requests_in_bytes(_per_ip) changeable at > runtime > - > > Key: CASSANDRA-15519 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15519 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config, Messaging/Client >Reporter: Jordan West >Assignee: Jordan West >Priority: Normal > Labels: pull-request-available > Fix For: 4.0-beta > > Time Spent: 10m > Remaining Estimate: 0h > > CASSANDRA-15013 added configurable global and per endpoint limits on the > number of in flight requests, measured in bytes. During times when the > cluster is overloaded, it can be useful to change this setting without having > to restart the Cassandra process. Changing the limits should affect all > existing and new connections. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: Reduce example size to stabilize ChecksummingTransformerTest
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/trunk by this push:
new 1b0f192 Reduce example size to stabilize ChecksummingTransformerTest
1b0f192 is described below
commit 1b0f1925ca20928344809813b40b20eaa5e3b514
Author: Brandon Williams
AuthorDate: Wed Feb 5 11:14:45 2020 -0600
Reduce example size to stabilize ChecksummingTransformerTest
Patch by brandonwilliams reviewed by Sam Tunnicliffe for CASSANDRA-15313
---
.../transport/frame/checksum/ChecksummingTransformerTest.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
a/test/unit/org/apache/cassandra/transport/frame/checksum/ChecksummingTransformerTest.java
b/test/unit/org/apache/cassandra/transport/frame/checksum/ChecksummingTransformerTest.java
index 82401b0..b905d4b 100644
---
a/test/unit/org/apache/cassandra/transport/frame/checksum/ChecksummingTransformerTest.java
+++
b/test/unit/org/apache/cassandra/transport/frame/checksum/ChecksummingTransformerTest.java
@@ -57,7 +57,7 @@ public class ChecksummingTransformerTest
@Test
public void roundTripSafetyProperty()
{
-qt().withExamples(500)
+qt().withExamples(35)
.forAll(inputs(),
compressors(),
checksumTypes(),
@@ -79,7 +79,7 @@ public class ChecksummingTransformerTest
@Test
public void corruptionCausesFailure()
{
-qt().withExamples(500)
+qt().withExamples(35)
.forAll(inputWithCorruptablePosition(),
integers().between(0,
Byte.MAX_VALUE).map(Integer::byteValue),
compressors(),
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15519) Make native_transport_max_concurrent_requests_in_bytes(_per_ip) changeable at runtime
[ https://issues.apache.org/jira/browse/CASSANDRA-15519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030828#comment-17030828 ] Chris Lohfink commented on CASSANDRA-15519: --- +1 lgtm > Make native_transport_max_concurrent_requests_in_bytes(_per_ip) changeable at > runtime > - > > Key: CASSANDRA-15519 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15519 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config, Messaging/Client >Reporter: Jordan West >Assignee: Jordan West >Priority: Normal > Labels: pull-request-available > Fix For: 4.0-beta > > Time Spent: 10m > Remaining Estimate: 0h > > CASSANDRA-15013 added configurable global and per endpoint limits on the > number of in flight requests, measured in bytes. During times when the > cluster is overloaded, it can be useful to change this setting without having > to restart the Cassandra process. Changing the limits should affect all > existing and new connections. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15539) Extract in-jvm API and tests out of Cassandra and into a separate repository
[
https://issues.apache.org/jira/browse/CASSANDRA-15539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027464#comment-17027464
]
Alex Petrov edited comment on CASSANDRA-15539 at 2/5/20 4:47 PM:
-
Posting a simplified version of the patch for review/preview:
|[patch|https://github.com/apache/cassandra/pull/437]|[ci|https://circleci.com/gh/ifesdjeen/cassandra/tree/CASSANDRA-15539-trunk-oss]|
A small review guide / what will be different "in real life":
1. To simplify (p)review, {{api}} and {{shared}} packages are still in
Cassanrda repository. In future they will be outside, since this is the whole
point of the patch. I've tried to come up with a guide where one would compile
two repos locally against each other, but that wasn't very friendly, so here we
are.
2. {{migrated}} package contains migrated tests. By the time the patch is
ready, all tests that can be shared between the versions, will be migrated, but
since changes required for migration are mosly mechanical, I thought we can
start before the rest of them are there.
cc [~dcapwell] [~djoshi] [~drohrer] [~mck]
was (Author: ifesdjeen):
cc [~dcapwell] [~djoshi] [~drohrer] [~mck]
> Extract in-jvm API and tests out of Cassandra and into a separate repository
>
>
> Key: CASSANDRA-15539
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15539
> Project: Cassandra
> Issue Type: Task
> Components: Test/dtest
>Reporter: Alex Petrov
>Assignee: Alex Petrov
>Priority: Normal
>
> Extract in-jvm DTest _API_ and tests into a separate repository that is
> shared between Cassandra branches. Tests themselves should be buildable using
> just API, which is not the case now, since cluster creation relies on impl
> package, since we do not have factories / constructors in API.
> Main goals we’re trying to achieve:
> 1. We should be able to fail a build on API incompatibility between versions
> 2. Make it as easy as possible to detect break APIs between versions.
> 3. Make development of _tests_ based on in-jvm framework simpler
> 4. Reduce surface area of impact when making modifications to tests
> Potentially, we’d also like to use a plugin to detect API incompatibilities
> between in-jvm DTest API and in-branch implementations, and start running
> tests using shared in-jvm test repository with each existing implementation
> in the branch. This entails both running tests for all branches whenever
> there’s a change in tests jar and running tests for a specific branch
> whenever the branch has changed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15313) Fix flaky - ChecksummingTransformerTest - org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030735#comment-17030735
]
Sam Tunnicliffe commented on CASSANDRA-15313:
-
Probably not a surprise, but it doesn't seem to repro on mac or in circle. I do
see the timeout on linux with lz4 1.7.1, although I didn't manage to trigger
the crash. I agree looks like maybe a bug in lz4, I don't have time right now,
but when I do I'll pull out a minimal repro and submit it to the lz4 project.
+1 on lowering the number of examples to stabilise the test.
> Fix flaky - ChecksummingTransformerTest -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> ---
>
> Key: CASSANDRA-15313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15313
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Vinay Chella
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> During the recent runs, this test appears to be flaky.
> Example failure:
> [https://circleci.com/gh/vinaykumarchella/cassandra/459#tests/containers/94]
> corruptionCausesFailure-compression -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> {code:java}
> java.lang.OutOfMemoryError: GC overhead limit exceeded
> at java.nio.HeapByteBuffer.(HeapByteBuffer.java:57)
> at java.nio.ByteBuffer.allocate(ByteBuffer.java:335)
> at org.quicktheories.impl.Precursor.(Precursor.java:17)
> at
> org.quicktheories.impl.ConcreteDetachedSource.(ConcreteDetachedSource.java:8)
> at
> org.quicktheories.impl.ConcreteDetachedSource.detach(ConcreteDetachedSource.java:23)
> at org.quicktheories.generators.Retry.generate(CodePoints.java:51)
> at
> org.quicktheories.generators.Generate.lambda$intArrays$10(Generate.java:190)
> at
> org.quicktheories.generators.Generate$$Lambda$17/1847008471.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$mix$10(Gen.java:184)
> at org.quicktheories.core.Gen$$Lambda$45/802243390.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$flatMap$5(Gen.java:93)
> at org.quicktheories.core.Gen$$Lambda$48/363509958.generate(Unknown
> Source)
> at
> org.quicktheories.dsl.TheoryBuilder4.lambda$prgnToTuple$12(TheoryBuilder4.java:188)
> at
> org.quicktheories.dsl.TheoryBuilder4$$Lambda$40/2003496028.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.FilteredGenerator.generate(Gen.java:225)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.impl.Core.generate(Core.java:150)
> at org.quicktheories.impl.Core.shrink(Core.java:103)
> at org.quicktheories.impl.Core.run(Core.java:39)
> at org.quicktheories.impl.TheoryRunner.check(TheoryRunner.java:35)
> at org.quicktheories.dsl.TheoryBuilder4.check(TheoryBuilder4.java:150)
> at
> org.quicktheories.dsl.TheoryBuilder4.checkAssert(TheoryBuilder4.java:162)
> at
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest.corruptionCausesFailure(ChecksummingTransformerTest.java:87)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15548) Keyspace creation succeeds even though not enough nodes are up
[ https://issues.apache.org/jira/browse/CASSANDRA-15548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] YCozy updated CASSANDRA-15548: -- Summary: Keyspace creation succeeds even though not enough nodes are up (was: Keyspace creation suceeds even though not enough nodes are up) > Keyspace creation succeeds even though not enough nodes are up > -- > > Key: CASSANDRA-15548 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15548 > Project: Cassandra > Issue Type: Bug > Components: Cluster/Schema >Reporter: YCozy >Priority: Normal > > When testing Cassandra with network partitions, we find that keyspace > creation can succeed without any warning even if there are not enough nodes > to support the replication factor. Here are the steps to reproduce: > # Start a cluster w/ two nodes. > # Create a keyspace with replication factor of three. > # Notice that the creation succeeds without any warning. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15548) Keyspace creation suceeds even though not enough nodes are up
YCozy created CASSANDRA-15548: - Summary: Keyspace creation suceeds even though not enough nodes are up Key: CASSANDRA-15548 URL: https://issues.apache.org/jira/browse/CASSANDRA-15548 Project: Cassandra Issue Type: Bug Components: Cluster/Schema Reporter: YCozy When testing Cassandra with network partitions, we find that keyspace creation can succeed without any warning even if there are not enough nodes to support the replication factor. Here are the steps to reproduce: # Start a cluster w/ two nodes. # Create a keyspace with replication factor of three. # Notice that the creation succeeds without any warning. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15547) commit logs fill up disk space
chongsheng yu created CASSANDRA-15547: - Summary: commit logs fill up disk space Key: CASSANDRA-15547 URL: https://issues.apache.org/jira/browse/CASSANDRA-15547 Project: Cassandra Issue Type: Bug Components: Local/Commit Log Reporter: chongsheng yu We have a three-nodes Cassandra cluster with version 3.11.3 in our production environment and the configuration 'commitlog_total_space_in_mb' is set to 8192. After tens of days running, commit logs at the third node grow upto about 300G and run out of disk space finally. The amount of commitlog files is about 10K. We have to remove all commitlog files at this node and restart Cassandra to repair it. I wonder if there any reason or bug could result in the size of commitlog exceed commitlog_total_space_in_mb ? In our other production environment with the same configurations, Cassandra cluster works well. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15497) Implement node bootstrap in in-JVM tests
[ https://issues.apache.org/jira/browse/CASSANDRA-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Petrov updated CASSANDRA-15497: Fix Version/s: 4.0 3.11.6 3.0.20 2.2.16 Source Control Link: https://github.com/apache/cassandra/commit/9705d823cddfe24356ba4f3f083b9371cdbdeb4d Resolution: Fixed Status: Resolved (was: Ready to Commit) > Implement node bootstrap in in-JVM tests > > > Key: CASSANDRA-15497 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15497 > Project: Cassandra > Issue Type: New Feature > Components: Test/dtest >Reporter: Alex Petrov >Assignee: Alex Petrov >Priority: High > Fix For: 2.2.16, 3.0.20, 3.11.6, 4.0 > > > Currently, we do not have an ability to add nodes to the running in-jvm > cluster, either by bootstrap or replacement process. We need to add an > ability to add nodes in inactive state, start them up, and bootstrap to test > streaming, range movements, and operations that occur during these processes. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15497) Implement node bootstrap in in-JVM tests
[ https://issues.apache.org/jira/browse/CASSANDRA-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030567#comment-17030567 ] Alex Petrov commented on CASSANDRA-15497: - Thank you! Committed to 2.2 with [9705d823cddfe24356ba4f3f083b9371cdbdeb4d|https://github.com/apache/cassandra/commit/9705d823cddfe24356ba4f3f083b9371cdbdeb4d] and merged up to [3.0|https://github.com/apache/cassandra/commit/3320f08269eaedd06418d0b8b8fdd2be6f467b51], [3.11|https://github.com/apache/cassandra/commit/c09e709dccf797f3c65592cbbc530979310dafab] and [trunk|https://github.com/apache/cassandra/commit/a041b53d2996cb076f615bbe3dfc048ed77372d4]. > Implement node bootstrap in in-JVM tests > > > Key: CASSANDRA-15497 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15497 > Project: Cassandra > Issue Type: New Feature > Components: Test/dtest >Reporter: Alex Petrov >Assignee: Alex Petrov >Priority: High > > Currently, we do not have an ability to add nodes to the running in-jvm > cluster, either by bootstrap or replacement process. We need to add an > ability to add nodes in inactive state, start them up, and bootstrap to test > streaming, range movements, and operations that occur during these processes. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.11 updated (b33a11c -> c09e709)
This is an automated email from the ASF dual-hosted git repository. ifesdjeen pushed a change to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from b33a11c Make sure that the passed node probe factory is used in nodetool, like in other branches. new 9705d82 Add an ability to run bootstrap / streaming tests with in-JVM dtest framework. new 3320f08 Merge branch 'cassandra-2.2' into cassandra-3.0 new c09e709 Merge branch 'cassandra-3.0' into cassandra-3.11 The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../org/apache/cassandra/service/GCInspector.java | 3 +- .../cassandra/distributed/api/IInstanceConfig.java | 4 + .../distributed/impl/AbstractCluster.java | 170 +++-- .../distributed/impl/DistributedTestSnitch.java| 60 +++- .../cassandra/distributed/impl/InstanceConfig.java | 10 +- .../distributed/impl/NetworkTopology.java | 60 +++- .../cassandra/distributed/test/BootstrapTest.java | 104 + .../distributed/test/DistributedTestBase.java | 1 + .../distributed/test/NetworkTopologyTest.java | 5 +- 9 files changed, 357 insertions(+), 60 deletions(-) create mode 100644 test/distributed/org/apache/cassandra/distributed/test/BootstrapTest.java - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (342d160 -> a041b53)
This is an automated email from the ASF dual-hosted git repository. ifesdjeen pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 342d160 Merge branch 'cassandra-3.11' into trunk new 9705d82 Add an ability to run bootstrap / streaming tests with in-JVM dtest framework. new 3320f08 Merge branch 'cassandra-2.2' into cassandra-3.0 new c09e709 Merge branch 'cassandra-3.0' into cassandra-3.11 new a041b53 Merge branch 'cassandra-3.11' into trunk The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../org/apache/cassandra/service/GCInspector.java | 6 +- .../cassandra/distributed/api/IInstanceConfig.java | 4 + .../distributed/impl/AbstractCluster.java | 172 +++-- .../distributed/impl/DistributedTestSnitch.java| 52 ++- .../cassandra/distributed/impl/InstanceConfig.java | 10 +- .../distributed/impl/NetworkTopology.java | 60 ++- .../cassandra/distributed/test/BootstrapTest.java | 104 + .../distributed/test/DistributedTestBase.java | 1 + .../distributed/test/NetworkTopologyTest.java | 5 +- .../cassandra/service/LeaveAndBootstrapTest.java | 27 ++-- 10 files changed, 363 insertions(+), 78 deletions(-) create mode 100644 test/distributed/org/apache/cassandra/distributed/test/BootstrapTest.java - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.0' into cassandra-3.11
This is an automated email from the ASF dual-hosted git repository. ifesdjeen pushed a commit to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit c09e709dccf797f3c65592cbbc530979310dafab Merge: b33a11c 3320f08 Author: Alex Petrov AuthorDate: Wed Feb 5 11:51:17 2020 +0100 Merge branch 'cassandra-3.0' into cassandra-3.11 .../org/apache/cassandra/service/GCInspector.java | 3 +- .../cassandra/distributed/api/IInstanceConfig.java | 4 + .../distributed/impl/AbstractCluster.java | 170 +++-- .../distributed/impl/DistributedTestSnitch.java| 60 +++- .../cassandra/distributed/impl/InstanceConfig.java | 10 +- .../distributed/impl/NetworkTopology.java | 60 +++- .../cassandra/distributed/test/BootstrapTest.java | 104 + .../distributed/test/DistributedTestBase.java | 1 + .../distributed/test/NetworkTopologyTest.java | 5 +- 9 files changed, 357 insertions(+), 60 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.11' into trunk
This is an automated email from the ASF dual-hosted git repository.
ifesdjeen pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit a041b53d2996cb076f615bbe3dfc048ed77372d4
Merge: 342d160 c09e709
Author: Alex Petrov
AuthorDate: Wed Feb 5 11:55:18 2020 +0100
Merge branch 'cassandra-3.11' into trunk
.../org/apache/cassandra/service/GCInspector.java | 6 +-
.../cassandra/distributed/api/IInstanceConfig.java | 4 +
.../distributed/impl/AbstractCluster.java | 172 +++--
.../distributed/impl/DistributedTestSnitch.java| 52 ++-
.../cassandra/distributed/impl/InstanceConfig.java | 10 +-
.../distributed/impl/NetworkTopology.java | 60 ++-
.../cassandra/distributed/test/BootstrapTest.java | 104 +
.../distributed/test/DistributedTestBase.java | 1 +
.../distributed/test/NetworkTopologyTest.java | 5 +-
.../cassandra/service/LeaveAndBootstrapTest.java | 27 ++--
10 files changed, 363 insertions(+), 78 deletions(-)
diff --cc src/java/org/apache/cassandra/service/GCInspector.java
index e0a935d,787d79a..02fd720
--- a/src/java/org/apache/cassandra/service/GCInspector.java
+++ b/src/java/org/apache/cassandra/service/GCInspector.java
@@@ -160,12 -147,10 +161,11 @@@ public class GCInspector implements Not
GarbageCollectorMXBean gc =
ManagementFactory.newPlatformMXBeanProxy(mbs, name.getCanonicalName(),
GarbageCollectorMXBean.class);
gcStates.put(gc.getName(), new GCState(gc,
assumeGCIsPartiallyConcurrent(gc), assumeGCIsOldGen(gc)));
}
-
-MBeanWrapper.instance.registerMBean(this, new
ObjectName(MBEAN_NAME));
+ObjectName me = new ObjectName(MBEAN_NAME);
+if (!mbs.isRegistered(me))
- mbs.registerMBean(this, new ObjectName(MBEAN_NAME));
++MBeanWrapper.instance.registerMBean(this, new
ObjectName(MBEAN_NAME));
}
- catch (RuntimeException | InstanceAlreadyExistsException |
MBeanRegistrationException |
- NotCompliantMBeanException | MalformedObjectNameException |
IOException e)
-catch (Exception e)
++catch (MalformedObjectNameException | IOException e)
{
throw new RuntimeException(e);
}
diff --cc
test/distributed/org/apache/cassandra/distributed/impl/AbstractCluster.java
index d487c14,400637d..f03bae0
---
a/test/distributed/org/apache/cassandra/distributed/impl/AbstractCluster.java
+++
b/test/distributed/org/apache/cassandra/distributed/impl/AbstractCluster.java
@@@ -58,9 -57,8 +58,8 @@@ import org.apache.cassandra.distributed
import org.apache.cassandra.distributed.api.IMessageFilters;
import org.apache.cassandra.io.util.FileUtils;
import org.apache.cassandra.locator.InetAddressAndPort;
-import org.apache.cassandra.net.MessagingService;
+import org.apache.cassandra.net.Verb;
import org.apache.cassandra.utils.FBUtilities;
- import org.apache.cassandra.utils.Pair;
import org.apache.cassandra.utils.concurrent.SimpleCondition;
/**
@@@ -102,9 -100,10 +101,11 @@@ public abstract class AbstractCluster<
private final List instances;
private final Map instanceMap;
+ private final Versions.Version initialVersion;
+
// mutated by user-facing API
private final MessageFilters filters;
+private volatile Thread.UncaughtExceptionHandler previousHandler = null;
protected class Wrapper extends DelegatingInvokableInstance implements
IUpgradeableInstance
{
@@@ -133,8 -132,8 +134,8 @@@
private IInvokableInstance newInstance(int generation)
{
ClassLoader classLoader = new InstanceClassLoader(generation,
config.num, version.classpath, sharedClassLoader);
- return
Instance.transferAdhoc((SerializableBiFunction)Instance::new, classLoader)
-
.apply(config.forVersion(version.major), classLoader);
+ return
Instance.transferAdhoc((SerializableBiFunction) Instance::new, classLoader)
- .apply(config, classLoader);
++ .apply(config.forVersion(version.major),
classLoader);
}
public IInstanceConfig config()
@@@ -218,18 -208,9 +219,18 @@@
delegate = null;
}
}
+
+public void uncaughtException(Thread thread, Throwable throwable)
+{
+IInvokableInstance delegate = this.delegate;
+if (delegate != null)
+delegate.uncaughtException(thread, throwable);
+else
+logger.error("uncaught exception in thread {}", thread,
throwable);
+}
}
- protected AbstractCluster(File root, Versions.Version version,
List configs,
+ protected AbstractCluster(File root, Versions.Version initialVersion,
List configs,
[cassandra] branch cassandra-2.2 updated: Add an ability to run bootstrap / streaming tests with in-JVM dtest framework.
This is an automated email from the ASF dual-hosted git repository.
ifesdjeen pushed a commit to branch cassandra-2.2
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-2.2 by this push:
new 9705d82 Add an ability to run bootstrap / streaming tests with in-JVM
dtest framework.
9705d82 is described below
commit 9705d823cddfe24356ba4f3f083b9371cdbdeb4d
Author: Alex Petrov
AuthorDate: Tue Jan 14 15:56:59 2020 +0100
Add an ability to run bootstrap / streaming tests with in-JVM dtest
framework.
Patch by Alex Petrov; reviewed by Marcus Eriksson for CASSANDRA-15497.
---
.../org/apache/cassandra/service/GCInspector.java | 3 +-
.../cassandra/distributed/api/IInstanceConfig.java | 4 +
.../distributed/impl/AbstractCluster.java | 170 +++--
.../distributed/impl/DistributedTestSnitch.java| 60 +++-
.../cassandra/distributed/impl/InstanceConfig.java | 10 +-
.../distributed/impl/NetworkTopology.java | 60 +++-
.../cassandra/distributed/test/BootstrapTest.java | 104 +
.../distributed/test/DistributedTestBase.java | 1 +
.../distributed/test/NetworkTopologyTest.java | 5 +-
9 files changed, 357 insertions(+), 60 deletions(-)
diff --git a/src/java/org/apache/cassandra/service/GCInspector.java
b/src/java/org/apache/cassandra/service/GCInspector.java
index 31de151..4f93097 100644
--- a/src/java/org/apache/cassandra/service/GCInspector.java
+++ b/src/java/org/apache/cassandra/service/GCInspector.java
@@ -42,6 +42,7 @@ import org.slf4j.LoggerFactory;
import org.apache.cassandra.config.DatabaseDescriptor;
import org.apache.cassandra.io.sstable.SSTableDeletingTask;
+import org.apache.cassandra.utils.MBeanWrapper;
import org.apache.cassandra.utils.StatusLogger;
public class GCInspector implements NotificationListener, GCInspectorMXBean
@@ -147,7 +148,7 @@ public class GCInspector implements NotificationListener,
GCInspectorMXBean
gcStates.put(gc.getName(), new GCState(gc,
assumeGCIsPartiallyConcurrent(gc), assumeGCIsOldGen(gc)));
}
-mbs.registerMBean(this, new ObjectName(MBEAN_NAME));
+MBeanWrapper.instance.registerMBean(this, new
ObjectName(MBEAN_NAME));
}
catch (Exception e)
{
diff --git
a/test/distributed/org/apache/cassandra/distributed/api/IInstanceConfig.java
b/test/distributed/org/apache/cassandra/distributed/api/IInstanceConfig.java
index dd21b96..d2804c2 100644
--- a/test/distributed/org/apache/cassandra/distributed/api/IInstanceConfig.java
+++ b/test/distributed/org/apache/cassandra/distributed/api/IInstanceConfig.java
@@ -47,6 +47,10 @@ public interface IInstanceConfig
*/
void propagate(Object writeToConfig);
+/**
+ * Validates whether the config properties are within range of accepted
values.
+ */
+void validate();
Object get(String fieldName);
String getString(String fieldName);
int getInt(String fieldName);
diff --git
a/test/distributed/org/apache/cassandra/distributed/impl/AbstractCluster.java
b/test/distributed/org/apache/cassandra/distributed/impl/AbstractCluster.java
index 1ee0c14..474ade8 100644
---
a/test/distributed/org/apache/cassandra/distributed/impl/AbstractCluster.java
+++
b/test/distributed/org/apache/cassandra/distributed/impl/AbstractCluster.java
@@ -59,7 +59,6 @@ import org.apache.cassandra.io.util.FileUtils;
import org.apache.cassandra.locator.InetAddressAndPort;
import org.apache.cassandra.net.MessagingService;
import org.apache.cassandra.utils.FBUtilities;
-import org.apache.cassandra.utils.Pair;
import org.apache.cassandra.utils.concurrent.SimpleCondition;
/**
@@ -101,6 +100,8 @@ public abstract class AbstractCluster
implements ICluster,
private final List instances;
private final Map instanceMap;
+private final Versions.Version initialVersion;
+
// mutated by user-facing API
private final MessageFilters filters;
@@ -131,7 +132,7 @@ public abstract class AbstractCluster
implements ICluster,
private IInvokableInstance newInstance(int generation)
{
ClassLoader classLoader = new InstanceClassLoader(generation,
config.num, version.classpath, sharedClassLoader);
-return
Instance.transferAdhoc((SerializableBiFunction)Instance::new, classLoader)
+return
Instance.transferAdhoc((SerializableBiFunction) Instance::new, classLoader)
.apply(config, classLoader);
}
@@ -210,18 +211,19 @@ public abstract class AbstractCluster implements ICluster,
}
}
-protected AbstractCluster(File root, Versions.Version version,
List configs,
+protected AbstractCluster(File root, Versions.Version initialVersion,
List configs,
ClassLoader sharedClassLoader)
{
this.root = root;
[cassandra] 01/01: Merge branch 'cassandra-2.2' into cassandra-3.0
This is an automated email from the ASF dual-hosted git repository.
ifesdjeen pushed a commit to branch cassandra-3.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit 3320f08269eaedd06418d0b8b8fdd2be6f467b51
Merge: 09fd7e8 9705d82
Author: Alex Petrov
AuthorDate: Wed Feb 5 11:51:02 2020 +0100
Merge branch 'cassandra-2.2' into cassandra-3.0
.../org/apache/cassandra/service/GCInspector.java | 3 +-
.../cassandra/distributed/api/IInstanceConfig.java | 4 +
.../distributed/impl/AbstractCluster.java | 170 +++--
.../distributed/impl/DistributedTestSnitch.java| 60 +++-
.../cassandra/distributed/impl/InstanceConfig.java | 10 +-
.../distributed/impl/NetworkTopology.java | 60 +++-
.../cassandra/distributed/test/BootstrapTest.java | 104 +
.../distributed/test/DistributedTestBase.java | 1 +
.../distributed/test/NetworkTopologyTest.java | 5 +-
9 files changed, 357 insertions(+), 60 deletions(-)
diff --cc src/java/org/apache/cassandra/service/GCInspector.java
index e7cfcd0,4f93097..787d79a
--- a/src/java/org/apache/cassandra/service/GCInspector.java
+++ b/src/java/org/apache/cassandra/service/GCInspector.java
@@@ -41,7 -41,8 +41,8 @@@ import org.slf4j.LoggerFactory
import org.apache.cassandra.config.DatabaseDescriptor;
-import org.apache.cassandra.io.sstable.SSTableDeletingTask;
+import org.apache.cassandra.db.lifecycle.LifecycleTransaction;
+ import org.apache.cassandra.utils.MBeanWrapper;
import org.apache.cassandra.utils.StatusLogger;
public class GCInspector implements NotificationListener, GCInspectorMXBean
diff --cc
test/distributed/org/apache/cassandra/distributed/impl/DistributedTestSnitch.java
index 35e2903,f8f157a..9147169
---
a/test/distributed/org/apache/cassandra/distributed/impl/DistributedTestSnitch.java
+++
b/test/distributed/org/apache/cassandra/distributed/impl/DistributedTestSnitch.java
@@@ -51,11 -61,49 +61,49 @@@ public class DistributedTestSnitch exte
public String getDatacenter(InetAddressAndPort endpoint)
{
assert mapping != null : "network topology must be assigned before
using snitch";
- return mapping.localDC(endpoint);
+ return maybeGetFromEndpointState(mapping.localDC(endpoint), endpoint,
ApplicationState.DC, DEFAULT_DC);
+ }
+
+ // Here, the logic is slightly different from what we have in
GossipingPropertyFileSnitch since we have a different
+ // goal. Passed argument (topology that was set on the node) overrides
anything that is passed elsewhere.
+ private String maybeGetFromEndpointState(String current,
InetAddressAndPort endpoint, ApplicationState state, String defaultValue)
+ {
+ if (current != null)
+ return current;
+
+ EndpointState epState =
Gossiper.instance.getEndpointStateForEndpoint(endpoint.address);
+ if (epState == null || epState.getApplicationState(state) == null)
+ {
+ if (savedEndpoints == null)
+ {
+ savedEndpoints = new HashMap<>();
+ int storage_port =
Config.getOverrideLoadConfig().get().storage_port;
+ for (Map.Entry> entry :
SystemKeyspace.loadDcRackInfo().entrySet())
+ {
+
savedEndpoints.put(InetAddressAndPort.getByAddressOverrideDefaults(endpoint.address,
storage_port),
+entry.getValue());
+ }
+ }
-
+ if (savedEndpoints.containsKey(endpoint))
+ return savedEndpoints.get(endpoint).get("data_center");
+
+ return defaultValue;
+ }
+
+ return epState.getApplicationState(state).value;
}
static void assign(NetworkTopology newMapping)
{
mapping = new NetworkTopology(newMapping);
}
+
+ public void gossiperStarting()
+ {
+ super.gossiperStarting();
+
++
+
Gossiper.instance.addLocalApplicationState(ApplicationState.INTERNAL_IP,
+
StorageService.instance.valueFactory.internalIP(FBUtilities.getLocalAddress().getHostAddress()));
+ }
}
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.0 updated (09fd7e8 -> 3320f08)
This is an automated email from the ASF dual-hosted git repository. ifesdjeen pushed a change to branch cassandra-3.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 09fd7e8 Merge branch 'cassandra-2.2' into cassandra-3.0 new 9705d82 Add an ability to run bootstrap / streaming tests with in-JVM dtest framework. new 3320f08 Merge branch 'cassandra-2.2' into cassandra-3.0 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../org/apache/cassandra/service/GCInspector.java | 3 +- .../cassandra/distributed/api/IInstanceConfig.java | 4 + .../distributed/impl/AbstractCluster.java | 170 +++-- .../distributed/impl/DistributedTestSnitch.java| 60 +++- .../cassandra/distributed/impl/InstanceConfig.java | 10 +- .../distributed/impl/NetworkTopology.java | 60 +++- .../cassandra/distributed/test/BootstrapTest.java | 104 + .../distributed/test/DistributedTestBase.java | 1 + .../distributed/test/NetworkTopologyTest.java | 5 +- 9 files changed, 357 insertions(+), 60 deletions(-) create mode 100644 test/distributed/org/apache/cassandra/distributed/test/BootstrapTest.java - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15429) Support NodeTool for in-jvm dtest
[ https://issues.apache.org/jira/browse/CASSANDRA-15429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Petrov updated CASSANDRA-15429: Status: Resolved (was: Open) > Support NodeTool for in-jvm dtest > - > > Key: CASSANDRA-15429 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15429 > Project: Cassandra > Issue Type: New Feature > Components: Test/dtest >Reporter: Yifan Cai >Assignee: Yifan Cai >Priority: Normal > Labels: pull-request-available > Fix For: 4.0 > > Time Spent: 5h 20m > Remaining Estimate: 0h > > In-JVM dtest framework does not support nodetool as of now. This > functionality is wanted in some tests, e.g. constructing an end-to-end test > scenario that uses nodetool. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15429) Support NodeTool for in-jvm dtest
[ https://issues.apache.org/jira/browse/CASSANDRA-15429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030518#comment-17030518 ] Alex Petrov edited comment on CASSANDRA-15429 at 2/5/20 10:39 AM: -- [~dcapwell] the [last build|https://circleci.com/gh/ifesdjeen/cassandra/tree/CASSANDRA-15429-3.11-followup] is green. Committed the test change to [2.2|https://github.com/apache/cassandra/commit/75d14b629da9360a8f2acd0153938b505c7c0714] and merged it all the way up to trunk, and committed the actual fix to [3.11|https://github.com/apache/cassandra/commit/b33a11ca4219b2317d35e48e1fb6f8a76b697e3e] and up to trunk, but w/ no-op. was (Author: ifesdjeen): [~dcapwell] the [last build|https://circleci.com/gh/ifesdjeen/cassandra/tree/CASSANDRA-15429-3.11-followup] is green. > Support NodeTool for in-jvm dtest > - > > Key: CASSANDRA-15429 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15429 > Project: Cassandra > Issue Type: New Feature > Components: Test/dtest >Reporter: Yifan Cai >Assignee: Yifan Cai >Priority: Normal > Labels: pull-request-available > Fix For: 4.0 > > Time Spent: 5h 20m > Remaining Estimate: 0h > > In-JVM dtest framework does not support nodetool as of now. This > functionality is wanted in some tests, e.g. constructing an end-to-end test > scenario that uses nodetool. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.0 updated (1710fa0 -> 09fd7e8)
This is an automated email from the ASF dual-hosted git repository. ifesdjeen pushed a change to branch cassandra-3.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 1710fa0 Merge branch 'cassandra-2.2' into cassandra-3.0 new 75d14b6 Add a test for a "real" nodetool command, not only "help" new 09fd7e8 Merge branch 'cassandra-2.2' into cassandra-3.0 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: test/distributed/org/apache/cassandra/distributed/test/NodeToolTest.java | 1 + 1 file changed, 1 insertion(+) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/02: Merge branch 'cassandra-3.0' into cassandra-3.11
This is an automated email from the ASF dual-hosted git repository. ifesdjeen pushed a commit to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 7707e261c523a68b04450f97793f7414f3accae5 Merge: e4ca96a 09fd7e8 Author: Alex Petrov AuthorDate: Wed Feb 5 11:32:58 2020 +0100 Merge branch 'cassandra-3.0' into cassandra-3.11 test/distributed/org/apache/cassandra/distributed/test/NodeToolTest.java | 1 + 1 file changed, 1 insertion(+) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-2.2' into cassandra-3.0
This is an automated email from the ASF dual-hosted git repository. ifesdjeen pushed a commit to branch cassandra-3.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 09fd7e849b858e9d94e2f79e567ff929ca6c5513 Merge: 1710fa0 75d14b6 Author: Alex Petrov AuthorDate: Wed Feb 5 11:22:29 2020 +0100 Merge branch 'cassandra-2.2' into cassandra-3.0 test/distributed/org/apache/cassandra/distributed/test/NodeToolTest.java | 1 + 1 file changed, 1 insertion(+) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (2f5db64 -> 342d160)
This is an automated email from the ASF dual-hosted git repository. ifesdjeen pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 2f5db64 Update nodetool repair help command to clarify token ranges new 75d14b6 Add a test for a "real" nodetool command, not only "help" new 09fd7e8 Merge branch 'cassandra-2.2' into cassandra-3.0 new 7707e26 Merge branch 'cassandra-3.0' into cassandra-3.11 new d7e9da3 Merge branch 'cassandra-3.11' into trunk new b33a11c Make sure that the passed node probe factory is used in nodetool, like in other branches. new 342d160 Merge branch 'cassandra-3.11' into trunk The 6 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: test/distributed/org/apache/cassandra/distributed/test/NodeToolTest.java | 1 + 1 file changed, 1 insertion(+) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 02/02: Merge branch 'cassandra-3.11' into trunk
This is an automated email from the ASF dual-hosted git repository. ifesdjeen pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 342d160c8ecce0f673a4b53404e552ccf4a22f4c Merge: d7e9da3 b33a11c Author: Alex Petrov AuthorDate: Wed Feb 5 11:33:45 2020 +0100 Merge branch 'cassandra-3.11' into trunk - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-2.2 updated: Add a test for a "real" nodetool command, not only "help"
This is an automated email from the ASF dual-hosted git repository.
ifesdjeen pushed a commit to branch cassandra-2.2
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-2.2 by this push:
new 75d14b6 Add a test for a "real" nodetool command, not only "help"
75d14b6 is described below
commit 75d14b629da9360a8f2acd0153938b505c7c0714
Author: Alex Petrov
AuthorDate: Tue Feb 4 17:33:11 2020 +0100
Add a test for a "real" nodetool command, not only "help"
Patch by Alex Petrov; reviewed by Yifan Cai for CASSANDRA-15429
---
test/distributed/org/apache/cassandra/distributed/test/NodeToolTest.java | 1 +
1 file changed, 1 insertion(+)
diff --git
a/test/distributed/org/apache/cassandra/distributed/test/NodeToolTest.java
b/test/distributed/org/apache/cassandra/distributed/test/NodeToolTest.java
index d2d4bb9..e209d1d 100644
--- a/test/distributed/org/apache/cassandra/distributed/test/NodeToolTest.java
+++ b/test/distributed/org/apache/cassandra/distributed/test/NodeToolTest.java
@@ -32,6 +32,7 @@ public class NodeToolTest extends DistributedTestBase
try (Cluster cluster = init(Cluster.create(1)))
{
assertEquals(0, cluster.get(1).nodetool("help"));
+assertEquals(0, cluster.get(1).nodetool("flush"));
assertEquals(1, cluster.get(1).nodetool("not_a_legal_command"));
}
}
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/02: Merge branch 'cassandra-3.11' into trunk
This is an automated email from the ASF dual-hosted git repository. ifesdjeen pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit d7e9da337a32add6b3bfb60b0634a0349e267bcc Merge: 2f5db64 7707e26 Author: Alex Petrov AuthorDate: Wed Feb 5 11:33:06 2020 +0100 Merge branch 'cassandra-3.11' into trunk test/distributed/org/apache/cassandra/distributed/test/NodeToolTest.java | 1 + 1 file changed, 1 insertion(+) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 02/02: Make sure that the passed node probe factory is used in nodetool, like in other branches.
This is an automated email from the ASF dual-hosted git repository.
ifesdjeen pushed a commit to branch cassandra-3.11
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit b33a11ca4219b2317d35e48e1fb6f8a76b697e3e
Author: Alex Petrov
AuthorDate: Tue Feb 4 17:33:11 2020 +0100
Make sure that the passed node probe factory is used in nodetool, like in
other branches.
Patch by Alex Petrov; reviewed by Yifan Cai for CASSANDRA-15429
---
src/java/org/apache/cassandra/tools/NodeTool.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/java/org/apache/cassandra/tools/NodeTool.java
b/src/java/org/apache/cassandra/tools/NodeTool.java
index c28ec09..9b47eca 100644
--- a/src/java/org/apache/cassandra/tools/NodeTool.java
+++ b/src/java/org/apache/cassandra/tools/NodeTool.java
@@ -338,9 +338,9 @@ public class NodeTool
try
{
if (username.isEmpty())
-nodeClient = new NodeProbe(host, parseInt(port));
+nodeClient = nodeProbeFactory.create(host, parseInt(port));
else
-nodeClient = new NodeProbe(host, parseInt(port), username,
password);
+nodeClient = nodeProbeFactory.create(host, parseInt(port),
username, password);
} catch (IOException | SecurityException e)
{
Throwable rootCause = Throwables.getRootCause(e);
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.11 updated (e4ca96a -> b33a11c)
This is an automated email from the ASF dual-hosted git repository. ifesdjeen pushed a change to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from e4ca96a Merge branch 'cassandra-3.0' into cassandra-3.11 new 75d14b6 Add a test for a "real" nodetool command, not only "help" new 09fd7e8 Merge branch 'cassandra-2.2' into cassandra-3.0 new 7707e26 Merge branch 'cassandra-3.0' into cassandra-3.11 new b33a11c Make sure that the passed node probe factory is used in nodetool, like in other branches. The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: src/java/org/apache/cassandra/tools/NodeTool.java | 4 ++-- .../org/apache/cassandra/distributed/test/NodeToolTest.java | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15497) Implement node bootstrap in in-JVM tests
[ https://issues.apache.org/jira/browse/CASSANDRA-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson updated CASSANDRA-15497: Status: Ready to Commit (was: Review In Progress) +1 > Implement node bootstrap in in-JVM tests > > > Key: CASSANDRA-15497 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15497 > Project: Cassandra > Issue Type: New Feature > Components: Test/dtest >Reporter: Alex Petrov >Assignee: Alex Petrov >Priority: High > > Currently, we do not have an ability to add nodes to the running in-jvm > cluster, either by bootstrap or replacement process. We need to add an > ability to add nodes in inactive state, start them up, and bootstrap to test > streaming, range movements, and operations that occur during these processes. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15429) Support NodeTool for in-jvm dtest
[ https://issues.apache.org/jira/browse/CASSANDRA-15429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030518#comment-17030518 ] Alex Petrov commented on CASSANDRA-15429: - [~dcapwell] the [last build|https://circleci.com/gh/ifesdjeen/cassandra/tree/CASSANDRA-15429-3.11-followup] is green. > Support NodeTool for in-jvm dtest > - > > Key: CASSANDRA-15429 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15429 > Project: Cassandra > Issue Type: New Feature > Components: Test/dtest >Reporter: Yifan Cai >Assignee: Yifan Cai >Priority: Normal > Labels: pull-request-available > Fix For: 4.0 > > Time Spent: 5h 20m > Remaining Estimate: 0h > > In-JVM dtest framework does not support nodetool as of now. This > functionality is wanted in some tests, e.g. constructing an end-to-end test > scenario that uses nodetool. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14737) Limit the dependencies used by UDFs/UDAs
[
https://issues.apache.org/jira/browse/CASSANDRA-14737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030509#comment-17030509
]
Ryan Svihla commented on CASSANDRA-14737:
-
+1
I applied the patch to a recent trunk and the builds are passing locally with
the exception of some of the dtests but those have all been flakey.
I can't see any downside to applying the patch and it'd be nice to separate
this out.
> Limit the dependencies used by UDFs/UDAs
>
>
> Key: CASSANDRA-14737
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14737
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/CQL
>Reporter: Robert Stupp
>Assignee: Robert Stupp
>Priority: Low
> Labels: UDF
> Fix For: 4.0
>
>
> In an effort to clean up our hygiene and limit the dependencies used by
> UDFs/UDAs, I think we should refactor the UDF code parts and remove the
> dependency to the Java Driver in that area without breaking existing
> UDFs/UDAs.
>
> The patch is in [this
> branch|https://github.com/snazy/cassandra/tree/feature/remove-udf-driver-dep-trunk].
> The changes are rather trivial and provide 100% backwards compatibility for
> existing UDFs.
>
> The prototype copies the necessary parts from the Java Driver into the C*
> source tree to {{org.apache.cassandra.cql3.functions.types}} and adopts its
> usages - i.e. UDF/UDA code plus {{CQLSSTableWriter}} +
> {{StressCQLSSTableWriter}}. The latter two classes have a reference to UDF's
> {{UDHelper}} and had to be changed as well.
>
> Some functionality, like type parsing & handling, is duplicated in the code
> base with this prototype - once in the "current" source tree and once for
> UDFs. However, unifying the code paths is not trivial, since the UDF sandbox
> prohibits the use of internal classes (direct and likely indirect
> dependencies).
>
> /cc [~jbellis]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
