[jira] [Commented] (CASSANDRA-15556) When a LZ4 stream is corrupted it could cause the JVM to crash
[
https://issues.apache.org/jira/browse/CASSANDRA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032125#comment-17032125
]
David Capwell commented on CASSANDRA-15556:
---
[~samt] [~brandon.williams] can you review?
I upgraded to latest lz4 library, switched from "fast" to "safe" (main reason
the JVM no longer crashes), and added test which crashes without the patch.
I also created a simple benchmark to show before/after are not noticeably
different.
Seeing as the compressor code isn't shared with the disk layer, I didn't test
sstable compression and relied on dtests.
> When a LZ4 stream is corrupted it could cause the JVM to crash
> --
>
> Key: CASSANDRA-15556
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15556
> Project: Cassandra
> Issue Type: Sub-task
> Components: Messaging/Client
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0-alpha
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This is a spin off of CASSANDRA-15313 and CASSANDRA-15299
> This was found when lz4 sees compressed data (not all, but happens) which is
> corrupted; in some cases the JVM crashes producing the following
> {code}
> #
> # A fatal error has been detected by the Java Runtime Environment:
> #
> # SIGBUS (0xa) at pc=0x000110d46ad1, pid=86555, tid=0x1103
> #
> # JRE version: OpenJDK Runtime Environment (8.0_222-b10) (build 1.8.0_222-b10)
> # Java VM: OpenJDK 64-Bit Server VM (25.222-b10 mixed mode bsd-amd64
> compressed oops)
> # Problematic frame:
> # C [liblz4-java2766366422904460658.dylib+0x3ad1] LZ4_decompress_fast+0xf1
> #
> # Failed to write core dump. Core dumps have been disabled. To enable core
> dumping, try "ulimit -c unlimited" before starting Java again
> #
> # An error report file with more information is saved as:
> # /Users/davidcapwell/src/github/apache/cassandra/hs_err_pid86555.log
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15556) When a LZ4 stream is corrupted it could cause the JVM to crash
[
https://issues.apache.org/jira/browse/CASSANDRA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032118#comment-17032118
]
David Capwell edited comment on CASSANDRA-15556 at 2/7/20 6:04 AM:
---
[Circle
CI|https://circleci.com/workflow-run/e3e833e9-d752-48fa-92cd-4dd357f9ca41]
was (Author: dcapwell):
[Circle
CI|https://circleci.com/gh/dcapwell/cassandra/tree/testWhichCrashesWithLz4]
> When a LZ4 stream is corrupted it could cause the JVM to crash
> --
>
> Key: CASSANDRA-15556
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15556
> Project: Cassandra
> Issue Type: Sub-task
> Components: Messaging/Client
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0-alpha
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This is a spin off of CASSANDRA-15313 and CASSANDRA-15299
> This was found when lz4 sees compressed data (not all, but happens) which is
> corrupted; in some cases the JVM crashes producing the following
> {code}
> #
> # A fatal error has been detected by the Java Runtime Environment:
> #
> # SIGBUS (0xa) at pc=0x000110d46ad1, pid=86555, tid=0x1103
> #
> # JRE version: OpenJDK Runtime Environment (8.0_222-b10) (build 1.8.0_222-b10)
> # Java VM: OpenJDK 64-Bit Server VM (25.222-b10 mixed mode bsd-amd64
> compressed oops)
> # Problematic frame:
> # C [liblz4-java2766366422904460658.dylib+0x3ad1] LZ4_decompress_fast+0xf1
> #
> # Failed to write core dump. Core dumps have been disabled. To enable core
> dumping, try "ulimit -c unlimited" before starting Java again
> #
> # An error report file with more information is saved as:
> # /Users/davidcapwell/src/github/apache/cassandra/hs_err_pid86555.log
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15557) Fix flaky test org.apache.cassandra.cql3.validation.operations.AlterTest testDropListAndAddListWithSameName
David Capwell created CASSANDRA-15557:
-
Summary: Fix flaky test
org.apache.cassandra.cql3.validation.operations.AlterTest
testDropListAndAddListWithSameName
Key: CASSANDRA-15557
URL: https://issues.apache.org/jira/browse/CASSANDRA-15557
Project: Cassandra
Issue Type: Bug
Components: Test/unit
Reporter: David Capwell
https://app.circleci.com/jobs/github/dcapwell/cassandra/482/tests
{code}
junit.framework.AssertionFailedError: Invalid value for row 0 column 2
(mycollection of type list), expected but got <[first element]>
at org.apache.cassandra.cql3.CQLTester.assertRows(CQLTester.java:1070)
at
org.apache.cassandra.cql3.validation.operations.AlterTest.testDropListAndAddListWithSameName(AlterTest.java:91)
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15557) Fix flaky test org.apache.cassandra.cql3.validation.operations.AlterTest testDropListAndAddListWithSameName
[
https://issues.apache.org/jira/browse/CASSANDRA-15557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-15557:
--
Bug Category: Parent values: Correctness(12982)Level 1 values: Test
Failure(12990)
Complexity: Normal
Discovered By: Unit Test
Fix Version/s: 4.0-alpha
Severity: Normal
Status: Open (was: Triage Needed)
> Fix flaky test org.apache.cassandra.cql3.validation.operations.AlterTest
> testDropListAndAddListWithSameName
> ---
>
> Key: CASSANDRA-15557
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15557
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: David Capwell
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> https://app.circleci.com/jobs/github/dcapwell/cassandra/482/tests
> {code}
> junit.framework.AssertionFailedError: Invalid value for row 0 column 2
> (mycollection of type list), expected but got <[first element]>
> at org.apache.cassandra.cql3.CQLTester.assertRows(CQLTester.java:1070)
> at
> org.apache.cassandra.cql3.validation.operations.AlterTest.testDropListAndAddListWithSameName(AlterTest.java:91)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15556) When a LZ4 stream is corrupted it could cause the JVM to crash
[
https://issues.apache.org/jira/browse/CASSANDRA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-15556:
--
Test and Documentation Plan: unit test, added jmh to show no regression.
Status: Patch Available (was: Open)
> When a LZ4 stream is corrupted it could cause the JVM to crash
> --
>
> Key: CASSANDRA-15556
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15556
> Project: Cassandra
> Issue Type: Sub-task
> Components: Messaging/Client
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0-alpha
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This is a spin off of CASSANDRA-15313 and CASSANDRA-15299
> This was found when lz4 sees compressed data (not all, but happens) which is
> corrupted; in some cases the JVM crashes producing the following
> {code}
> #
> # A fatal error has been detected by the Java Runtime Environment:
> #
> # SIGBUS (0xa) at pc=0x000110d46ad1, pid=86555, tid=0x1103
> #
> # JRE version: OpenJDK Runtime Environment (8.0_222-b10) (build 1.8.0_222-b10)
> # Java VM: OpenJDK 64-Bit Server VM (25.222-b10 mixed mode bsd-amd64
> compressed oops)
> # Problematic frame:
> # C [liblz4-java2766366422904460658.dylib+0x3ad1] LZ4_decompress_fast+0xf1
> #
> # Failed to write core dump. Core dumps have been disabled. To enable core
> dumping, try "ulimit -c unlimited" before starting Java again
> #
> # An error report file with more information is saved as:
> # /Users/davidcapwell/src/github/apache/cassandra/hs_err_pid86555.log
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15313) Fix flaky - ChecksummingTransformerTest - org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032120#comment-17032120
]
David Capwell edited comment on CASSANDRA-15313 at 2/7/20 5:44 AM:
---
Sent patch for CASSANDRA-15556 which makes it so the JVM doesn't crash anymore;
with that in the only remaining issue I know of is
{code}
transformInbound(transformOutbound(input)) != input
{code}
[~samt] would it be possible for you to take a look? I provided a set of seeds
which fail, so can rerun the test with that seed to reproduce the failure.
was (Author: dcapwell):
Sent patch for CASSANDRA-15556 which makes it so the JVM doesn't crash anymore;
with that in the only remaining issue I know of is
{code}
transformInbound(transformOutboun(input)) != input
{code}
[~samt] would it be possible for you to take a look? I provided a set of seeds
which fail, so can rerun the test with that seed to reproduce the failure.
> Fix flaky - ChecksummingTransformerTest -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> ---
>
> Key: CASSANDRA-15313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15313
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Vinay Chella
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0-alpha
>
> Attachments: CASSANDRA-15313-hack.patch
>
>
> During the recent runs, this test appears to be flaky.
> Example failure:
> [https://circleci.com/gh/vinaykumarchella/cassandra/459#tests/containers/94]
> corruptionCausesFailure-compression -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> {code:java}
> java.lang.OutOfMemoryError: GC overhead limit exceeded
> at java.nio.HeapByteBuffer.(HeapByteBuffer.java:57)
> at java.nio.ByteBuffer.allocate(ByteBuffer.java:335)
> at org.quicktheories.impl.Precursor.(Precursor.java:17)
> at
> org.quicktheories.impl.ConcreteDetachedSource.(ConcreteDetachedSource.java:8)
> at
> org.quicktheories.impl.ConcreteDetachedSource.detach(ConcreteDetachedSource.java:23)
> at org.quicktheories.generators.Retry.generate(CodePoints.java:51)
> at
> org.quicktheories.generators.Generate.lambda$intArrays$10(Generate.java:190)
> at
> org.quicktheories.generators.Generate$$Lambda$17/1847008471.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$mix$10(Gen.java:184)
> at org.quicktheories.core.Gen$$Lambda$45/802243390.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$flatMap$5(Gen.java:93)
> at org.quicktheories.core.Gen$$Lambda$48/363509958.generate(Unknown
> Source)
> at
> org.quicktheories.dsl.TheoryBuilder4.lambda$prgnToTuple$12(TheoryBuilder4.java:188)
> at
> org.quicktheories.dsl.TheoryBuilder4$$Lambda$40/2003496028.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.FilteredGenerator.generate(Gen.java:225)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.impl.Core.generate(Core.java:150)
> at org.quicktheories.impl.Core.shrink(Core.java:103)
> at org.quicktheories.impl.Core.run(Core.java:39)
> at org.quicktheories.impl.TheoryRunner.check(TheoryRunner.java:35)
> at org.quicktheories.dsl.TheoryBuilder4.check(TheoryBuilder4.java:150)
> at
> org.quicktheories.dsl.TheoryBuilder4.checkAssert(TheoryBuilder4.java:162)
> at
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest.corruptionCausesFailure(ChecksummingTransformerTest.java:87)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15556) When a LZ4 stream is corrupted it could cause the JVM to crash
[
https://issues.apache.org/jira/browse/CASSANDRA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-15556:
--
Parent: CASSANDRA-15313
Workflow: Cassandra Default Workflow (was: Cassandra Bug Workflow)
Issue Type: Sub-task (was: Bug)
> When a LZ4 stream is corrupted it could cause the JVM to crash
> --
>
> Key: CASSANDRA-15556
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15556
> Project: Cassandra
> Issue Type: Sub-task
> Components: Messaging/Client
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0-alpha
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This is a spin off of CASSANDRA-15313 and CASSANDRA-15299
> This was found when lz4 sees compressed data (not all, but happens) which is
> corrupted; in some cases the JVM crashes producing the following
> {code}
> #
> # A fatal error has been detected by the Java Runtime Environment:
> #
> # SIGBUS (0xa) at pc=0x000110d46ad1, pid=86555, tid=0x1103
> #
> # JRE version: OpenJDK Runtime Environment (8.0_222-b10) (build 1.8.0_222-b10)
> # Java VM: OpenJDK 64-Bit Server VM (25.222-b10 mixed mode bsd-amd64
> compressed oops)
> # Problematic frame:
> # C [liblz4-java2766366422904460658.dylib+0x3ad1] LZ4_decompress_fast+0xf1
> #
> # Failed to write core dump. Core dumps have been disabled. To enable core
> dumping, try "ulimit -c unlimited" before starting Java again
> #
> # An error report file with more information is saved as:
> # /Users/davidcapwell/src/github/apache/cassandra/hs_err_pid86555.log
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15313) Fix flaky - ChecksummingTransformerTest - org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032120#comment-17032120
]
David Capwell commented on CASSANDRA-15313:
---
Sent patch for CASSANDRA-15556 which makes it so the JVM doesn't crash anymore;
with that in the only remaining issue I know of is
{code}
transformInbound(transformOutboun(input)) != input
{code}
[~samt] would it be possible for you to take a look? I provided a set of seeds
which fail, so can rerun the test with that seed to reproduce the failure.
> Fix flaky - ChecksummingTransformerTest -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> ---
>
> Key: CASSANDRA-15313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15313
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Vinay Chella
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0-alpha
>
> Attachments: CASSANDRA-15313-hack.patch
>
>
> During the recent runs, this test appears to be flaky.
> Example failure:
> [https://circleci.com/gh/vinaykumarchella/cassandra/459#tests/containers/94]
> corruptionCausesFailure-compression -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> {code:java}
> java.lang.OutOfMemoryError: GC overhead limit exceeded
> at java.nio.HeapByteBuffer.(HeapByteBuffer.java:57)
> at java.nio.ByteBuffer.allocate(ByteBuffer.java:335)
> at org.quicktheories.impl.Precursor.(Precursor.java:17)
> at
> org.quicktheories.impl.ConcreteDetachedSource.(ConcreteDetachedSource.java:8)
> at
> org.quicktheories.impl.ConcreteDetachedSource.detach(ConcreteDetachedSource.java:23)
> at org.quicktheories.generators.Retry.generate(CodePoints.java:51)
> at
> org.quicktheories.generators.Generate.lambda$intArrays$10(Generate.java:190)
> at
> org.quicktheories.generators.Generate$$Lambda$17/1847008471.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$mix$10(Gen.java:184)
> at org.quicktheories.core.Gen$$Lambda$45/802243390.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$flatMap$5(Gen.java:93)
> at org.quicktheories.core.Gen$$Lambda$48/363509958.generate(Unknown
> Source)
> at
> org.quicktheories.dsl.TheoryBuilder4.lambda$prgnToTuple$12(TheoryBuilder4.java:188)
> at
> org.quicktheories.dsl.TheoryBuilder4$$Lambda$40/2003496028.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.FilteredGenerator.generate(Gen.java:225)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.impl.Core.generate(Core.java:150)
> at org.quicktheories.impl.Core.shrink(Core.java:103)
> at org.quicktheories.impl.Core.run(Core.java:39)
> at org.quicktheories.impl.TheoryRunner.check(TheoryRunner.java:35)
> at org.quicktheories.dsl.TheoryBuilder4.check(TheoryBuilder4.java:150)
> at
> org.quicktheories.dsl.TheoryBuilder4.checkAssert(TheoryBuilder4.java:162)
> at
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest.corruptionCausesFailure(ChecksummingTransformerTest.java:87)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15556) When a LZ4 stream is corrupted it could cause the JVM to crash
[
https://issues.apache.org/jira/browse/CASSANDRA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032118#comment-17032118
]
David Capwell commented on CASSANDRA-15556:
---
[Circle
CI|https://circleci.com/gh/dcapwell/cassandra/tree/testWhichCrashesWithLz4]
> When a LZ4 stream is corrupted it could cause the JVM to crash
> --
>
> Key: CASSANDRA-15556
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15556
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Client
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0-alpha
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This is a spin off of CASSANDRA-15313 and CASSANDRA-15299
> This was found when lz4 sees compressed data (not all, but happens) which is
> corrupted; in some cases the JVM crashes producing the following
> {code}
> #
> # A fatal error has been detected by the Java Runtime Environment:
> #
> # SIGBUS (0xa) at pc=0x000110d46ad1, pid=86555, tid=0x1103
> #
> # JRE version: OpenJDK Runtime Environment (8.0_222-b10) (build 1.8.0_222-b10)
> # Java VM: OpenJDK 64-Bit Server VM (25.222-b10 mixed mode bsd-amd64
> compressed oops)
> # Problematic frame:
> # C [liblz4-java2766366422904460658.dylib+0x3ad1] LZ4_decompress_fast+0xf1
> #
> # Failed to write core dump. Core dumps have been disabled. To enable core
> dumping, try "ulimit -c unlimited" before starting Java again
> #
> # An error report file with more information is saved as:
> # /Users/davidcapwell/src/github/apache/cassandra/hs_err_pid86555.log
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15556) When a LZ4 stream is corrupted it could cause the JVM to crash
[
https://issues.apache.org/jira/browse/CASSANDRA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032117#comment-17032117
]
David Capwell commented on CASSANDRA-15556:
---
With the patch
{code}
BenchmarkMode Cnt
ScoreError Units
ChecksummingTransformerLz4.decompresLargeBlob thrpt 16
3033.525 ± 46.975 ops/s
ChecksummingTransformerLz4.decompresSsmallEnglishASCII thrpt 16
10,349,596.715 ± 904,951.399 ops/s
ChecksummingTransformerLz4.decompresSsmallEnglishUtf8 thrpt 16
10,687,989.427 ± 595,770.939 ops/s
{code}
Without the patch
{code}
BenchmarkMode Cnt
ScoreError Units
ChecksummingTransformerLz4.decompresLargeBlob thrpt 16
2960.954 ±149.584 ops/s
ChecksummingTransformerLz4.decompresSsmallEnglishASCII thrpt 16
10,273,136.182 ± 436,391.068 ops/s
ChecksummingTransformerLz4.decompresSsmallEnglishUtf8 thrpt 16
10,692,302.907 ± 337,789.609 ops/s
{code}
At least with the samples I created, there isn't a real difference between this
patch (which doesn't crash) and previous
> When a LZ4 stream is corrupted it could cause the JVM to crash
> --
>
> Key: CASSANDRA-15556
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15556
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Client
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0-alpha
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This is a spin off of CASSANDRA-15313 and CASSANDRA-15299
> This was found when lz4 sees compressed data (not all, but happens) which is
> corrupted; in some cases the JVM crashes producing the following
> {code}
> #
> # A fatal error has been detected by the Java Runtime Environment:
> #
> # SIGBUS (0xa) at pc=0x000110d46ad1, pid=86555, tid=0x1103
> #
> # JRE version: OpenJDK Runtime Environment (8.0_222-b10) (build 1.8.0_222-b10)
> # Java VM: OpenJDK 64-Bit Server VM (25.222-b10 mixed mode bsd-amd64
> compressed oops)
> # Problematic frame:
> # C [liblz4-java2766366422904460658.dylib+0x3ad1] LZ4_decompress_fast+0xf1
> #
> # Failed to write core dump. Core dumps have been disabled. To enable core
> dumping, try "ulimit -c unlimited" before starting Java again
> #
> # An error report file with more information is saved as:
> # /Users/davidcapwell/src/github/apache/cassandra/hs_err_pid86555.log
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15556) When a LZ4 stream is corrupted it could cause the JVM to crash
[
https://issues.apache.org/jira/browse/CASSANDRA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-15556:
--
Description:
This is a spin off of CASSANDRA-15313 and CASSANDRA-15299
This was found when lz4 sees compressed data (not all, but happens) which is
corrupted; in some cases the JVM crashes producing the following
{code}
#
# A fatal error has been detected by the Java Runtime Environment:
#
# SIGBUS (0xa) at pc=0x000110d46ad1, pid=86555, tid=0x1103
#
# JRE version: OpenJDK Runtime Environment (8.0_222-b10) (build 1.8.0_222-b10)
# Java VM: OpenJDK 64-Bit Server VM (25.222-b10 mixed mode bsd-amd64 compressed
oops)
# Problematic frame:
# C [liblz4-java2766366422904460658.dylib+0x3ad1] LZ4_decompress_fast+0xf1
#
# Failed to write core dump. Core dumps have been disabled. To enable core
dumping, try "ulimit -c unlimited" before starting Java again
#
# An error report file with more information is saved as:
# /Users/davidcapwell/src/github/apache/cassandra/hs_err_pid86555.log
{code}
was:
This is a spin off of CASSANDRA-15313 and CASSANDRA-15299
This was found when lz4 sees compressed data (not all, but happens) which is
corrupted; in some cases the JVM crashes producing the following
{code}
#
# A fatal error has been detected by the Java Runtime Environment:
#
# SIGBUS (0xa) at pc=0x000110d46ad1, pid=86555, tid=0x1103
#
# JRE version: OpenJDK Runtime Environment (8.0_222-b10) (build 1.8.0_222-b10)
# Java VM: OpenJDK 64-Bit Server VM (25.222-b10 mixed mode bsd-amd64 compressed
oops)
# Problematic frame:
# C [liblz4-java2766366422904460658.dylib+0x3ad1] LZ4_decompress_fast+0xf1
#
# Failed to write core dump. Core dumps have been disabled. To enable core
dumping, try "ulimit -c unlimited" before starting Java again
#
# An error report file with more information is saved as:
# /Users/davidcapwell/src/github/apache/cassandra/hs_err_pid86555.log
# {code}
> When a LZ4 stream is corrupted it could cause the JVM to crash
> --
>
> Key: CASSANDRA-15556
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15556
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Client
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0-alpha
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This is a spin off of CASSANDRA-15313 and CASSANDRA-15299
> This was found when lz4 sees compressed data (not all, but happens) which is
> corrupted; in some cases the JVM crashes producing the following
> {code}
> #
> # A fatal error has been detected by the Java Runtime Environment:
> #
> # SIGBUS (0xa) at pc=0x000110d46ad1, pid=86555, tid=0x1103
> #
> # JRE version: OpenJDK Runtime Environment (8.0_222-b10) (build 1.8.0_222-b10)
> # Java VM: OpenJDK 64-Bit Server VM (25.222-b10 mixed mode bsd-amd64
> compressed oops)
> # Problematic frame:
> # C [liblz4-java2766366422904460658.dylib+0x3ad1] LZ4_decompress_fast+0xf1
> #
> # Failed to write core dump. Core dumps have been disabled. To enable core
> dumping, try "ulimit -c unlimited" before starting Java again
> #
> # An error report file with more information is saved as:
> # /Users/davidcapwell/src/github/apache/cassandra/hs_err_pid86555.log
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15556) When a LZ4 stream is corrupted it could cause the JVM to crash
[
https://issues.apache.org/jira/browse/CASSANDRA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032116#comment-17032116
]
David Capwell commented on CASSANDRA-15556:
---
This patch depends on CASSANDRA-1
> When a LZ4 stream is corrupted it could cause the JVM to crash
> --
>
> Key: CASSANDRA-15556
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15556
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Client
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0-alpha
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This is a spin off of CASSANDRA-15313 and CASSANDRA-15299
> This was found when lz4 sees compressed data (not all, but happens) which is
> corrupted; in some cases the JVM crashes producing the following
> {code}
> #
> # A fatal error has been detected by the Java Runtime Environment:
> #
> # SIGBUS (0xa) at pc=0x000110d46ad1, pid=86555, tid=0x1103
> #
> # JRE version: OpenJDK Runtime Environment (8.0_222-b10) (build 1.8.0_222-b10)
> # Java VM: OpenJDK 64-Bit Server VM (25.222-b10 mixed mode bsd-amd64
> compressed oops)
> # Problematic frame:
> # C [liblz4-java2766366422904460658.dylib+0x3ad1] LZ4_decompress_fast+0xf1
> #
> # Failed to write core dump. Core dumps have been disabled. To enable core
> dumping, try "ulimit -c unlimited" before starting Java again
> #
> # An error report file with more information is saved as:
> # /Users/davidcapwell/src/github/apache/cassandra/hs_err_pid86555.log
> # {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15556) When a LZ4 stream is corrupted it could cause the JVM to crash
[
https://issues.apache.org/jira/browse/CASSANDRA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated CASSANDRA-15556:
---
Labels: pull-request-available (was: )
> When a LZ4 stream is corrupted it could cause the JVM to crash
> --
>
> Key: CASSANDRA-15556
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15556
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Client
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0-alpha
>
>
> This is a spin off of CASSANDRA-15313 and CASSANDRA-15299
> This was found when lz4 sees compressed data (not all, but happens) which is
> corrupted; in some cases the JVM crashes producing the following
> {code}
> #
> # A fatal error has been detected by the Java Runtime Environment:
> #
> # SIGBUS (0xa) at pc=0x000110d46ad1, pid=86555, tid=0x1103
> #
> # JRE version: OpenJDK Runtime Environment (8.0_222-b10) (build 1.8.0_222-b10)
> # Java VM: OpenJDK 64-Bit Server VM (25.222-b10 mixed mode bsd-amd64
> compressed oops)
> # Problematic frame:
> # C [liblz4-java2766366422904460658.dylib+0x3ad1] LZ4_decompress_fast+0xf1
> #
> # Failed to write core dump. Core dumps have been disabled. To enable core
> dumping, try "ulimit -c unlimited" before starting Java again
> #
> # An error report file with more information is saved as:
> # /Users/davidcapwell/src/github/apache/cassandra/hs_err_pid86555.log
> # {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15555) Lower the amount of garbage ChecksummingTransformerTest generates by reusing memory
[ https://issues.apache.org/jira/browse/CASSANDRA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-1: -- Description: When the test finds a issue and attempts to shrink, a ton of garbage is generated which cause the test to then fail with GC issues. Since the test is a quick theories test, we can rewrite the generates to reuse memory rather than creating new objects for each iteration. This will also let us move away from String which requires multiple copies in the test and gets rid of the getBytes() call which is dependent on the system its called on. |[Circle CI|https://circleci.com/gh/dcapwell/cassandra/tree/quickTheoryMemory]| was:When the test finds a issue and attempts to shrink, a ton of garbage is generated which cause the test to then fail with GC issues. Since the test is a quick theories test, we can rewrite the generates to reuse memory rather than creating new objects for each iteration. This will also let us move away from String which requires multiple copies in the test and gets rid of the getBytes() call which is dependent on the system its called on. > Lower the amount of garbage ChecksummingTransformerTest generates by reusing > memory > --- > > Key: CASSANDRA-1 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1 > Project: Cassandra > Issue Type: Sub-task > Components: Test/unit >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Fix For: 4.0-alpha > > Time Spent: 10m > Remaining Estimate: 0h > > When the test finds a issue and attempts to shrink, a ton of garbage is > generated which cause the test to then fail with GC issues. Since the test > is a quick theories test, we can rewrite the generates to reuse memory rather > than creating new objects for each iteration. This will also let us move > away from String which requires multiple copies in the test and gets rid of > the getBytes() call which is dependent on the system its called on. > |[Circle > CI|https://circleci.com/gh/dcapwell/cassandra/tree/quickTheoryMemory]| -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15555) Lower the amount of garbage ChecksummingTransformerTest generates by reusing memory
[ https://issues.apache.org/jira/browse/CASSANDRA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-1: -- Test and Documentation Plan: tested in ant to reproduce all 4 modes. (was: tested in ant to reproduce all 4 modes. |[Circle CI|https://circleci.com/gh/dcapwell/cassandra/tree/quickTheoryMemory]|) > Lower the amount of garbage ChecksummingTransformerTest generates by reusing > memory > --- > > Key: CASSANDRA-1 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1 > Project: Cassandra > Issue Type: Sub-task > Components: Test/unit >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Fix For: 4.0-alpha > > Time Spent: 10m > Remaining Estimate: 0h > > When the test finds a issue and attempts to shrink, a ton of garbage is > generated which cause the test to then fail with GC issues. Since the test > is a quick theories test, we can rewrite the generates to reuse memory rather > than creating new objects for each iteration. This will also let us move > away from String which requires multiple copies in the test and gets rid of > the getBytes() call which is dependent on the system its called on. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15556) When a LZ4 stream is corrupted it could cause the JVM to crash
[
https://issues.apache.org/jira/browse/CASSANDRA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-15556:
--
Fix Version/s: 4.0-alpha
> When a LZ4 stream is corrupted it could cause the JVM to crash
> --
>
> Key: CASSANDRA-15556
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15556
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Client
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> This is a spin off of CASSANDRA-15313 and CASSANDRA-15299
> This was found when lz4 sees compressed data (not all, but happens) which is
> corrupted; in some cases the JVM crashes producing the following
> {code}
> #
> # A fatal error has been detected by the Java Runtime Environment:
> #
> # SIGBUS (0xa) at pc=0x000110d46ad1, pid=86555, tid=0x1103
> #
> # JRE version: OpenJDK Runtime Environment (8.0_222-b10) (build 1.8.0_222-b10)
> # Java VM: OpenJDK 64-Bit Server VM (25.222-b10 mixed mode bsd-amd64
> compressed oops)
> # Problematic frame:
> # C [liblz4-java2766366422904460658.dylib+0x3ad1] LZ4_decompress_fast+0xf1
> #
> # Failed to write core dump. Core dumps have been disabled. To enable core
> dumping, try "ulimit -c unlimited" before starting Java again
> #
> # An error report file with more information is saved as:
> # /Users/davidcapwell/src/github/apache/cassandra/hs_err_pid86555.log
> # {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15555) Lower the amount of garbage ChecksummingTransformerTest generates by reusing memory
[ https://issues.apache.org/jira/browse/CASSANDRA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-1: - Source Control Link: https://github.com/apache/cassandra/commit/ea3a3c47f992bd4812415ee6762875d1e3f43ebc Resolution: Fixed Status: Resolved (was: Ready to Commit) Committed, thanks! > Lower the amount of garbage ChecksummingTransformerTest generates by reusing > memory > --- > > Key: CASSANDRA-1 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1 > Project: Cassandra > Issue Type: Sub-task > Components: Test/unit >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Fix For: 4.0-alpha > > Time Spent: 10m > Remaining Estimate: 0h > > When the test finds a issue and attempts to shrink, a ton of garbage is > generated which cause the test to then fail with GC issues. Since the test > is a quick theories test, we can rewrite the generates to reuse memory rather > than creating new objects for each iteration. This will also let us move > away from String which requires multiple copies in the test and gets rid of > the getBytes() call which is dependent on the system its called on. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15555) Lower the amount of garbage ChecksummingTransformerTest generates by reusing memory
[ https://issues.apache.org/jira/browse/CASSANDRA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-1: - Status: Ready to Commit (was: Review In Progress) > Lower the amount of garbage ChecksummingTransformerTest generates by reusing > memory > --- > > Key: CASSANDRA-1 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1 > Project: Cassandra > Issue Type: Sub-task > Components: Test/unit >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Fix For: 4.0-alpha > > Time Spent: 10m > Remaining Estimate: 0h > > When the test finds a issue and attempts to shrink, a ton of garbage is > generated which cause the test to then fail with GC issues. Since the test > is a quick theories test, we can rewrite the generates to reuse memory rather > than creating new objects for each iteration. This will also let us move > away from String which requires multiple copies in the test and gets rid of > the getBytes() call which is dependent on the system its called on. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: Lower the amount of garbage ChecksummingTransformerTest generates by reusing memory
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/trunk by this push:
new ea3a3c4 Lower the amount of garbage ChecksummingTransformerTest
generates by reusing memory
ea3a3c4 is described below
commit ea3a3c47f992bd4812415ee6762875d1e3f43ebc
Author: David Capwell
AuthorDate: Thu Feb 6 11:37:06 2020 -0800
Lower the amount of garbage ChecksummingTransformerTest generates by
reusing memory
Patch by David Capwell, reviewed by brandonwilliams and Jordan West for
CASSANDRA-1
---
.../checksum/ChecksummingTransformerTest.java | 51 +
.../transport/frame/checksum/ReusableBuffer.java | 52 ++
2 files changed, 85 insertions(+), 18 deletions(-)
diff --git
a/test/unit/org/apache/cassandra/transport/frame/checksum/ChecksummingTransformerTest.java
b/test/unit/org/apache/cassandra/transport/frame/checksum/ChecksummingTransformerTest.java
index b905d4b..d678044 100644
---
a/test/unit/org/apache/cassandra/transport/frame/checksum/ChecksummingTransformerTest.java
+++
b/test/unit/org/apache/cassandra/transport/frame/checksum/ChecksummingTransformerTest.java
@@ -37,9 +37,11 @@ import
org.apache.cassandra.transport.frame.compress.SnappyCompressor;
import org.apache.cassandra.utils.ChecksumType;
import org.apache.cassandra.utils.Pair;
import org.quicktheories.core.Gen;
+import org.quicktheories.impl.Constraint;
import static org.quicktheories.QuickTheory.qt;
-import static org.quicktheories.generators.SourceDSL.*;
+import static org.quicktheories.generators.SourceDSL.arbitrary;
+import static org.quicktheories.generators.SourceDSL.integers;
public class ChecksummingTransformerTest
{
@@ -57,7 +59,7 @@ public class ChecksummingTransformerTest
@Test
public void roundTripSafetyProperty()
{
-qt().withExamples(35)
+qt()
.forAll(inputs(),
compressors(),
checksumTypes(),
@@ -68,7 +70,7 @@ public class ChecksummingTransformerTest
@Test
public void roundTripZeroLengthInput()
{
-qt().withExamples(20)
+qt()
.forAll(zeroLengthInputs(),
compressors(),
checksumTypes(),
@@ -79,7 +81,7 @@ public class ChecksummingTransformerTest
@Test
public void corruptionCausesFailure()
{
-qt().withExamples(35)
+qt()
.forAll(inputWithCorruptablePosition(),
integers().between(0,
Byte.MAX_VALUE).map(Integer::byteValue),
compressors(),
@@ -87,13 +89,13 @@ public class ChecksummingTransformerTest
.checkAssert(this::roundTripWithCorruption);
}
-private void roundTripWithCorruption(Pair
inputAndCorruptablePosition,
+private void roundTripWithCorruption(Pair
inputAndCorruptablePosition,
byte corruptionValue,
Compressor compressor,
ChecksumType checksum)
{
-String input = inputAndCorruptablePosition.left;
-ByteBuf expectedBuf = Unpooled.wrappedBuffer(input.getBytes());
+ReusableBuffer input = inputAndCorruptablePosition.left;
+ByteBuf expectedBuf = input.toByteBuf();
int byteToCorrupt = inputAndCorruptablePosition.right;
ChecksummingTransformer transformer = new
ChecksummingTransformer(checksum, DEFAULT_BLOCK_SIZE, compressor);
ByteBuf outbound = transformer.transformOutbound(expectedBuf);
@@ -173,11 +175,10 @@ public class ChecksummingTransformerTest
Assert.assertEquals(expectedBuf, inbound);
}
-private void roundTrip(String input, Compressor compressor, ChecksumType
checksum, int blockSize)
+private void roundTrip(ReusableBuffer input, Compressor compressor,
ChecksumType checksum, int blockSize)
{
ChecksummingTransformer transformer = new
ChecksummingTransformer(checksum, blockSize, compressor);
-byte[] expectedBytes = input.getBytes();
-ByteBuf expectedBuf = Unpooled.wrappedBuffer(expectedBytes);
+ByteBuf expectedBuf = input.toByteBuf();
ByteBuf outbound = transformer.transformOutbound(expectedBuf);
ByteBuf inbound = transformer.transformInbound(outbound, FLAGS);
@@ -187,23 +188,38 @@ public class ChecksummingTransformerTest
Assert.assertEquals(expectedBuf, inbound);
}
-private Gen> inputWithCorruptablePosition()
+private Gen> inputWithCorruptablePosition()
{
// we only generate corruption for byte 2 onward. This is to skip
introducing corruption in the number
// of chunks (which isn't checksummed
-return inputs().flatMap(s -> integers().between(2, s.length() +
2).map(i -> Pair.crea
[jira] [Updated] (CASSANDRA-15555) Lower the amount of garbage ChecksummingTransformerTest generates by reusing memory
[ https://issues.apache.org/jira/browse/CASSANDRA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan West updated CASSANDRA-1: Reviewers: Brandon Williams, Jordan West (was: Brandon Williams, David Capwell) > Lower the amount of garbage ChecksummingTransformerTest generates by reusing > memory > --- > > Key: CASSANDRA-1 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1 > Project: Cassandra > Issue Type: Sub-task > Components: Test/unit >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Fix For: 4.0-alpha > > Time Spent: 10m > Remaining Estimate: 0h > > When the test finds a issue and attempts to shrink, a ton of garbage is > generated which cause the test to then fail with GC issues. Since the test > is a quick theories test, we can rewrite the generates to reuse memory rather > than creating new objects for each iteration. This will also let us move > away from String which requires multiple copies in the test and gets rid of > the getBytes() call which is dependent on the system its called on. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15555) Lower the amount of garbage ChecksummingTransformerTest generates by reusing memory
[ https://issues.apache.org/jira/browse/CASSANDRA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032060#comment-17032060 ] Jordan West commented on CASSANDRA-1: - LGTM. +1. Thanks David. > Lower the amount of garbage ChecksummingTransformerTest generates by reusing > memory > --- > > Key: CASSANDRA-1 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1 > Project: Cassandra > Issue Type: Sub-task > Components: Test/unit >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Fix For: 4.0-alpha > > Time Spent: 10m > Remaining Estimate: 0h > > When the test finds a issue and attempts to shrink, a ton of garbage is > generated which cause the test to then fail with GC issues. Since the test > is a quick theories test, we can rewrite the generates to reuse memory rather > than creating new objects for each iteration. This will also let us move > away from String which requires multiple copies in the test and gets rid of > the getBytes() call which is dependent on the system its called on. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Issue Comment Deleted] (CASSANDRA-15313) Fix flaky - ChecksummingTransformerTest - org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jordan West updated CASSANDRA-15313:
Comment: was deleted
(was: LGTM. +1. Thanks David! )
> Fix flaky - ChecksummingTransformerTest -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> ---
>
> Key: CASSANDRA-15313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15313
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Vinay Chella
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0-alpha
>
> Attachments: CASSANDRA-15313-hack.patch
>
>
> During the recent runs, this test appears to be flaky.
> Example failure:
> [https://circleci.com/gh/vinaykumarchella/cassandra/459#tests/containers/94]
> corruptionCausesFailure-compression -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> {code:java}
> java.lang.OutOfMemoryError: GC overhead limit exceeded
> at java.nio.HeapByteBuffer.(HeapByteBuffer.java:57)
> at java.nio.ByteBuffer.allocate(ByteBuffer.java:335)
> at org.quicktheories.impl.Precursor.(Precursor.java:17)
> at
> org.quicktheories.impl.ConcreteDetachedSource.(ConcreteDetachedSource.java:8)
> at
> org.quicktheories.impl.ConcreteDetachedSource.detach(ConcreteDetachedSource.java:23)
> at org.quicktheories.generators.Retry.generate(CodePoints.java:51)
> at
> org.quicktheories.generators.Generate.lambda$intArrays$10(Generate.java:190)
> at
> org.quicktheories.generators.Generate$$Lambda$17/1847008471.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$mix$10(Gen.java:184)
> at org.quicktheories.core.Gen$$Lambda$45/802243390.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$flatMap$5(Gen.java:93)
> at org.quicktheories.core.Gen$$Lambda$48/363509958.generate(Unknown
> Source)
> at
> org.quicktheories.dsl.TheoryBuilder4.lambda$prgnToTuple$12(TheoryBuilder4.java:188)
> at
> org.quicktheories.dsl.TheoryBuilder4$$Lambda$40/2003496028.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.FilteredGenerator.generate(Gen.java:225)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.impl.Core.generate(Core.java:150)
> at org.quicktheories.impl.Core.shrink(Core.java:103)
> at org.quicktheories.impl.Core.run(Core.java:39)
> at org.quicktheories.impl.TheoryRunner.check(TheoryRunner.java:35)
> at org.quicktheories.dsl.TheoryBuilder4.check(TheoryBuilder4.java:150)
> at
> org.quicktheories.dsl.TheoryBuilder4.checkAssert(TheoryBuilder4.java:162)
> at
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest.corruptionCausesFailure(ChecksummingTransformerTest.java:87)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15313) Fix flaky - ChecksummingTransformerTest - org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032059#comment-17032059
]
Jordan West commented on CASSANDRA-15313:
-
LGTM. +1. Thanks David!
> Fix flaky - ChecksummingTransformerTest -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> ---
>
> Key: CASSANDRA-15313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15313
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Vinay Chella
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0-alpha
>
> Attachments: CASSANDRA-15313-hack.patch
>
>
> During the recent runs, this test appears to be flaky.
> Example failure:
> [https://circleci.com/gh/vinaykumarchella/cassandra/459#tests/containers/94]
> corruptionCausesFailure-compression -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> {code:java}
> java.lang.OutOfMemoryError: GC overhead limit exceeded
> at java.nio.HeapByteBuffer.(HeapByteBuffer.java:57)
> at java.nio.ByteBuffer.allocate(ByteBuffer.java:335)
> at org.quicktheories.impl.Precursor.(Precursor.java:17)
> at
> org.quicktheories.impl.ConcreteDetachedSource.(ConcreteDetachedSource.java:8)
> at
> org.quicktheories.impl.ConcreteDetachedSource.detach(ConcreteDetachedSource.java:23)
> at org.quicktheories.generators.Retry.generate(CodePoints.java:51)
> at
> org.quicktheories.generators.Generate.lambda$intArrays$10(Generate.java:190)
> at
> org.quicktheories.generators.Generate$$Lambda$17/1847008471.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$mix$10(Gen.java:184)
> at org.quicktheories.core.Gen$$Lambda$45/802243390.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$flatMap$5(Gen.java:93)
> at org.quicktheories.core.Gen$$Lambda$48/363509958.generate(Unknown
> Source)
> at
> org.quicktheories.dsl.TheoryBuilder4.lambda$prgnToTuple$12(TheoryBuilder4.java:188)
> at
> org.quicktheories.dsl.TheoryBuilder4$$Lambda$40/2003496028.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.FilteredGenerator.generate(Gen.java:225)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.impl.Core.generate(Core.java:150)
> at org.quicktheories.impl.Core.shrink(Core.java:103)
> at org.quicktheories.impl.Core.run(Core.java:39)
> at org.quicktheories.impl.TheoryRunner.check(TheoryRunner.java:35)
> at org.quicktheories.dsl.TheoryBuilder4.check(TheoryBuilder4.java:150)
> at
> org.quicktheories.dsl.TheoryBuilder4.checkAssert(TheoryBuilder4.java:162)
> at
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest.corruptionCausesFailure(ChecksummingTransformerTest.java:87)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15556) When a LZ4 stream is corrupted it could cause the JVM to crash
[
https://issues.apache.org/jira/browse/CASSANDRA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-15556:
--
Description:
This is a spin off of CASSANDRA-15313 and CASSANDRA-15299
This was found when lz4 sees compressed data (not all, but happens) which is
corrupted; in some cases the JVM crashes producing the following
{code}
#
# A fatal error has been detected by the Java Runtime Environment:
#
# SIGBUS (0xa) at pc=0x000110d46ad1, pid=86555, tid=0x1103
#
# JRE version: OpenJDK Runtime Environment (8.0_222-b10) (build 1.8.0_222-b10)
# Java VM: OpenJDK 64-Bit Server VM (25.222-b10 mixed mode bsd-amd64 compressed
oops)
# Problematic frame:
# C [liblz4-java2766366422904460658.dylib+0x3ad1] LZ4_decompress_fast+0xf1
#
# Failed to write core dump. Core dumps have been disabled. To enable core
dumping, try "ulimit -c unlimited" before starting Java again
#
# An error report file with more information is saved as:
# /Users/davidcapwell/src/github/apache/cassandra/hs_err_pid86555.log
# {code}
was:
This is a spin off of CASSANDRA-15313 and CASSANDRA-15539
This was found when lz4 sees compressed data (not all, but happens) which is
corrupted; in some cases the JVM crashes producing the following
{code}
#
# A fatal error has been detected by the Java Runtime Environment:
#
# SIGBUS (0xa) at pc=0x000110d46ad1, pid=86555, tid=0x1103
#
# JRE version: OpenJDK Runtime Environment (8.0_222-b10) (build 1.8.0_222-b10)
# Java VM: OpenJDK 64-Bit Server VM (25.222-b10 mixed mode bsd-amd64 compressed
oops)
# Problematic frame:
# C [liblz4-java2766366422904460658.dylib+0x3ad1] LZ4_decompress_fast+0xf1
#
# Failed to write core dump. Core dumps have been disabled. To enable core
dumping, try "ulimit -c unlimited" before starting Java again
#
# An error report file with more information is saved as:
# /Users/davidcapwell/src/github/apache/cassandra/hs_err_pid86555.log
# {code}
> When a LZ4 stream is corrupted it could cause the JVM to crash
> --
>
> Key: CASSANDRA-15556
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15556
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Client
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
>
> This is a spin off of CASSANDRA-15313 and CASSANDRA-15299
> This was found when lz4 sees compressed data (not all, but happens) which is
> corrupted; in some cases the JVM crashes producing the following
> {code}
> #
> # A fatal error has been detected by the Java Runtime Environment:
> #
> # SIGBUS (0xa) at pc=0x000110d46ad1, pid=86555, tid=0x1103
> #
> # JRE version: OpenJDK Runtime Environment (8.0_222-b10) (build 1.8.0_222-b10)
> # Java VM: OpenJDK 64-Bit Server VM (25.222-b10 mixed mode bsd-amd64
> compressed oops)
> # Problematic frame:
> # C [liblz4-java2766366422904460658.dylib+0x3ad1] LZ4_decompress_fast+0xf1
> #
> # Failed to write core dump. Core dumps have been disabled. To enable core
> dumping, try "ulimit -c unlimited" before starting Java again
> #
> # An error report file with more information is saved as:
> # /Users/davidcapwell/src/github/apache/cassandra/hs_err_pid86555.log
> # {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15556) When a LZ4 stream is corrupted it could cause the JVM to crash
[
https://issues.apache.org/jira/browse/CASSANDRA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032053#comment-17032053
]
David Capwell commented on CASSANDRA-15556:
---
[~cscotta] noticed that this is happening in the "fast" function so we tried
the safe version; can't reproduce anymore. As of 1.9.0 the "fast" function is
deprecated in favor of safe https://github.com/lz4/lz4/releases/tag/v1.9.0
> When a LZ4 stream is corrupted it could cause the JVM to crash
> --
>
> Key: CASSANDRA-15556
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15556
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Client
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
>
> This is a spin off of CASSANDRA-15313 and CASSANDRA-15539
> This was found when lz4 sees compressed data (not all, but happens) which is
> corrupted; in some cases the JVM crashes producing the following
> {code}
> #
> # A fatal error has been detected by the Java Runtime Environment:
> #
> # SIGBUS (0xa) at pc=0x000110d46ad1, pid=86555, tid=0x1103
> #
> # JRE version: OpenJDK Runtime Environment (8.0_222-b10) (build 1.8.0_222-b10)
> # Java VM: OpenJDK 64-Bit Server VM (25.222-b10 mixed mode bsd-amd64
> compressed oops)
> # Problematic frame:
> # C [liblz4-java2766366422904460658.dylib+0x3ad1] LZ4_decompress_fast+0xf1
> #
> # Failed to write core dump. Core dumps have been disabled. To enable core
> dumping, try "ulimit -c unlimited" before starting Java again
> #
> # An error report file with more information is saved as:
> # /Users/davidcapwell/src/github/apache/cassandra/hs_err_pid86555.log
> # {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15556) When a LZ4 stream is corrupted it could cause the JVM to crash
[
https://issues.apache.org/jira/browse/CASSANDRA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032052#comment-17032052
]
David Capwell commented on CASSANDRA-15556:
---
Here is a test case which causes the crash when using our checksum logic
https://github.com/dcapwell/cassandra/commit/355b3299ba77f91d418850eb75908b5d6461e6a8
> When a LZ4 stream is corrupted it could cause the JVM to crash
> --
>
> Key: CASSANDRA-15556
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15556
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Client
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
>
> This is a spin off of CASSANDRA-15313 and CASSANDRA-15539
> This was found when lz4 sees compressed data (not all, but happens) which is
> corrupted; in some cases the JVM crashes producing the following
> {code}
> #
> # A fatal error has been detected by the Java Runtime Environment:
> #
> # SIGBUS (0xa) at pc=0x000110d46ad1, pid=86555, tid=0x1103
> #
> # JRE version: OpenJDK Runtime Environment (8.0_222-b10) (build 1.8.0_222-b10)
> # Java VM: OpenJDK 64-Bit Server VM (25.222-b10 mixed mode bsd-amd64
> compressed oops)
> # Problematic frame:
> # C [liblz4-java2766366422904460658.dylib+0x3ad1] LZ4_decompress_fast+0xf1
> #
> # Failed to write core dump. Core dumps have been disabled. To enable core
> dumping, try "ulimit -c unlimited" before starting Java again
> #
> # An error report file with more information is saved as:
> # /Users/davidcapwell/src/github/apache/cassandra/hs_err_pid86555.log
> # {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15556) When a LZ4 stream is corrupted it could cause the JVM to crash
[
https://issues.apache.org/jira/browse/CASSANDRA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032051#comment-17032051
]
David Capwell commented on CASSANDRA-15556:
---
This is localized to the client protocol since it has been fixed already for
sstables it seems.
> When a LZ4 stream is corrupted it could cause the JVM to crash
> --
>
> Key: CASSANDRA-15556
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15556
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Client
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
>
> This is a spin off of CASSANDRA-15313 and CASSANDRA-15539
> This was found when lz4 sees compressed data (not all, but happens) which is
> corrupted; in some cases the JVM crashes producing the following
> {code}
> #
> # A fatal error has been detected by the Java Runtime Environment:
> #
> # SIGBUS (0xa) at pc=0x000110d46ad1, pid=86555, tid=0x1103
> #
> # JRE version: OpenJDK Runtime Environment (8.0_222-b10) (build 1.8.0_222-b10)
> # Java VM: OpenJDK 64-Bit Server VM (25.222-b10 mixed mode bsd-amd64
> compressed oops)
> # Problematic frame:
> # C [liblz4-java2766366422904460658.dylib+0x3ad1] LZ4_decompress_fast+0xf1
> #
> # Failed to write core dump. Core dumps have been disabled. To enable core
> dumping, try "ulimit -c unlimited" before starting Java again
> #
> # An error report file with more information is saved as:
> # /Users/davidcapwell/src/github/apache/cassandra/hs_err_pid86555.log
> # {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15556) When a LZ4 stream is corrupted it could cause the JVM to crash
David Capwell created CASSANDRA-15556:
-
Summary: When a LZ4 stream is corrupted it could cause the JVM to
crash
Key: CASSANDRA-15556
URL: https://issues.apache.org/jira/browse/CASSANDRA-15556
Project: Cassandra
Issue Type: Bug
Components: Messaging/Client
Reporter: David Capwell
Assignee: David Capwell
This is a spin off of CASSANDRA-15313 and CASSANDRA-15539
This was found when lz4 sees compressed data (not all, but happens) which is
corrupted; in some cases the JVM crashes producing the following
{code}
#
# A fatal error has been detected by the Java Runtime Environment:
#
# SIGBUS (0xa) at pc=0x000110d46ad1, pid=86555, tid=0x1103
#
# JRE version: OpenJDK Runtime Environment (8.0_222-b10) (build 1.8.0_222-b10)
# Java VM: OpenJDK 64-Bit Server VM (25.222-b10 mixed mode bsd-amd64 compressed
oops)
# Problematic frame:
# C [liblz4-java2766366422904460658.dylib+0x3ad1] LZ4_decompress_fast+0xf1
#
# Failed to write core dump. Core dumps have been disabled. To enable core
dumping, try "ulimit -c unlimited" before starting Java again
#
# An error report file with more information is saved as:
# /Users/davidcapwell/src/github/apache/cassandra/hs_err_pid86555.log
# {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15556) When a LZ4 stream is corrupted it could cause the JVM to crash
[
https://issues.apache.org/jira/browse/CASSANDRA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-15556:
--
Bug Category: Parent values: Availability(12983)Level 1 values: Process
Crash(12992)
Complexity: Low Hanging Fruit
Discovered By: Unit Test
Severity: Low
Status: Open (was: Triage Needed)
> When a LZ4 stream is corrupted it could cause the JVM to crash
> --
>
> Key: CASSANDRA-15556
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15556
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Client
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
>
> This is a spin off of CASSANDRA-15313 and CASSANDRA-15539
> This was found when lz4 sees compressed data (not all, but happens) which is
> corrupted; in some cases the JVM crashes producing the following
> {code}
> #
> # A fatal error has been detected by the Java Runtime Environment:
> #
> # SIGBUS (0xa) at pc=0x000110d46ad1, pid=86555, tid=0x1103
> #
> # JRE version: OpenJDK Runtime Environment (8.0_222-b10) (build 1.8.0_222-b10)
> # Java VM: OpenJDK 64-Bit Server VM (25.222-b10 mixed mode bsd-amd64
> compressed oops)
> # Problematic frame:
> # C [liblz4-java2766366422904460658.dylib+0x3ad1] LZ4_decompress_fast+0xf1
> #
> # Failed to write core dump. Core dumps have been disabled. To enable core
> dumping, try "ulimit -c unlimited" before starting Java again
> #
> # An error report file with more information is saved as:
> # /Users/davidcapwell/src/github/apache/cassandra/hs_err_pid86555.log
> # {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15539) Extract in-jvm API and tests out of Cassandra and into a separate repository
[ https://issues.apache.org/jira/browse/CASSANDRA-15539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032028#comment-17032028 ] David Capwell commented on CASSANDRA-15539: --- bq. I would say we should split the process in two tree logical parts: first one is to commit API extraction, while leaving all the tests in-tree, then committing tests to a separate repo, and finally removing the tests. This allows us to work around the chicken-and-egg problem of two repositories sort of depending on each other. Makes sense. Between each phase we will need to update Jenkins and CircleCI. bq. I'm also thinking about how to make it fully frictionless for PR builds that change both the library and tests, especially with snapshot builds. This means that we might end up with tests relying not on the latest (SNAPSHOT) version of the API, but rather relying on the latest published (RELEASE) version of the API. Let's say we have published in-jvm-dtest-api of version 0.0.2 and started using it in Cassandra. If we first commit the part that runs in-jvm dtests out of tree, it will try to run tests for all branches against 0.0.2, even though Cassandra with 0.0.2 couldn't have been built by then, since 0.0.2 wasn't published yet. So we will have to first commit the API changes, then bump version of API dep in Cassandra, and only then bump the version of API dep in the library that runs in-jvm-tests out of tree. Thats one of the reasons I wanted the implementation in the new repo =D I think the better we get at having low level primitives in the core API the easier it will be to not require changes in the API; simple example is your recent interceptor patch, the existing filters can be based off that and we can build more on it, so wouldn't require updating the implementation. > Extract in-jvm API and tests out of Cassandra and into a separate repository > > > Key: CASSANDRA-15539 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15539 > Project: Cassandra > Issue Type: Task > Components: Test/dtest >Reporter: Alex Petrov >Assignee: Alex Petrov >Priority: Normal > > Extract in-jvm DTest _API_ and tests into a separate repository that is > shared between Cassandra branches. Tests themselves should be buildable using > just API, which is not the case now, since cluster creation relies on impl > package, since we do not have factories / constructors in API. > Main goals we’re trying to achieve: > 1. We should be able to fail a build on API incompatibility between versions > 2. Make it as easy as possible to detect break APIs between versions. > 3. Make development of _tests_ based on in-jvm framework simpler > 4. Reduce surface area of impact when making modifications to tests > Potentially, we’d also like to use a plugin to detect API incompatibilities > between in-jvm DTest API and in-branch implementations, and start running > tests using shared in-jvm test repository with each existing implementation > in the branch. This entails both running tests for all branches whenever > there’s a change in tests jar and running tests for a specific branch > whenever the branch has changed. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15555) Lower the amount of garbage ChecksummingTransformerTest generates by reusing memory
[ https://issues.apache.org/jira/browse/CASSANDRA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-1: -- Reviewers: Brandon Williams, David Capwell Status: Review In Progress (was: Patch Available) > Lower the amount of garbage ChecksummingTransformerTest generates by reusing > memory > --- > > Key: CASSANDRA-1 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1 > Project: Cassandra > Issue Type: Sub-task > Components: Test/unit >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Fix For: 4.0-alpha > > Time Spent: 10m > Remaining Estimate: 0h > > When the test finds a issue and attempts to shrink, a ton of garbage is > generated which cause the test to then fail with GC issues. Since the test > is a quick theories test, we can rewrite the generates to reuse memory rather > than creating new objects for each iteration. This will also let us move > away from String which requires multiple copies in the test and gets rid of > the getBytes() call which is dependent on the system its called on. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-10190) Python 3 support for cqlsh
[ https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032024#comment-17032024 ] David Capwell commented on CASSANDRA-10190: --- For the C* changes: build looks good, the cqlsh bash command looks good, so +1 with that. I didn't review the python changes since I don't know it well enough to comment. I ran dtests against this branch and they were fine, so this doesn't regress the existing stuff. the dtest PR looks unrelated filled with style changes and dead code; nothing stood out as needed for this and saw test cases for other JIRAs. +1 to cassandra changes I leave it to your judgement on dtest > Python 3 support for cqlsh > -- > > Key: CASSANDRA-10190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10190 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Tools >Reporter: Andrew Pennebaker >Assignee: Patrick Bannister >Priority: Normal > Labels: cqlsh, pull-request-available > Fix For: 4.0, 4.0-alpha > > Attachments: > 0001-Fix-issues-from-version-specific-logic-commit.patch, > 0001-Update-six-to-1.12.0.patch, > 0002-Simplify-version-specific-logic-by-using-six.moves-a.patch, > coverage_notes.txt > > Time Spent: 1.5h > Remaining Estimate: 0h > > Users who operate in a Python 3 environment may have trouble launching cqlsh. > Could we please update cqlsh's syntax to run in Python 3? > As a workaround, users can setup pyenv, and cd to a directory with a > .python-version containing "2.7". But it would be nice if cqlsh supported > modern Python versions out of the box. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15555) Lower the amount of garbage ChecksummingTransformerTest generates by reusing memory
[ https://issues.apache.org/jira/browse/CASSANDRA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032014#comment-17032014 ] Brandon Williams commented on CASSANDRA-1: -- LGTM, +1. Far less GC as 500 examples couldn't pass before and now the default of 1k is not a problem. > Lower the amount of garbage ChecksummingTransformerTest generates by reusing > memory > --- > > Key: CASSANDRA-1 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1 > Project: Cassandra > Issue Type: Sub-task > Components: Test/unit >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Fix For: 4.0-alpha > > Time Spent: 10m > Remaining Estimate: 0h > > When the test finds a issue and attempts to shrink, a ton of garbage is > generated which cause the test to then fail with GC issues. Since the test > is a quick theories test, we can rewrite the generates to reuse memory rather > than creating new objects for each iteration. This will also let us move > away from String which requires multiple copies in the test and gets rid of > the getBytes() call which is dependent on the system its called on. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15555) Lower the amount of garbage ChecksummingTransformerTest generates by reusing memory
[
https://issues.apache.org/jira/browse/CASSANDRA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032003#comment-17032003
]
David Capwell commented on CASSANDRA-1:
---
All examples above were called by running the following
{code}
ant testclasslist -Dtest.classlistfile=<(echo
org/apache/cassandra/transport/frame/checksum/ChecksummingTransformerTest.java)
-Dtest.classlistprefix=unit
{code}
In order to not timeout, I added -Dtest.timeout=6000
> Lower the amount of garbage ChecksummingTransformerTest generates by reusing
> memory
> ---
>
> Key: CASSANDRA-1
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1
> Project: Cassandra
> Issue Type: Sub-task
> Components: Test/unit
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0-alpha
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When the test finds a issue and attempts to shrink, a ton of garbage is
> generated which cause the test to then fail with GC issues. Since the test
> is a quick theories test, we can rewrite the generates to reuse memory rather
> than creating new objects for each iteration. This will also let us move
> away from String which requires multiple copies in the test and gets rid of
> the getBytes() call which is dependent on the system its called on.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15555) Lower the amount of garbage ChecksummingTransformerTest generates by reusing memory
[ https://issues.apache.org/jira/browse/CASSANDRA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-1: -- Test and Documentation Plan: tested in ant to reproduce all 4 modes. |[Circle CI|https://circleci.com/gh/dcapwell/cassandra/tree/quickTheoryMemory]| was:tested in ant to reproduce all 4 modes. > Lower the amount of garbage ChecksummingTransformerTest generates by reusing > memory > --- > > Key: CASSANDRA-1 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1 > Project: Cassandra > Issue Type: Sub-task > Components: Test/unit >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Fix For: 4.0-alpha > > Time Spent: 10m > Remaining Estimate: 0h > > When the test finds a issue and attempts to shrink, a ton of garbage is > generated which cause the test to then fail with GC issues. Since the test > is a quick theories test, we can rewrite the generates to reuse memory rather > than creating new objects for each iteration. This will also let us move > away from String which requires multiple copies in the test and gets rid of > the getBytes() call which is dependent on the system its called on. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15313) Fix flaky - ChecksummingTransformerTest - org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032001#comment-17032001
]
David Capwell commented on CASSANDRA-15313:
---
Created a different JIRA for the memory issue since I didn't make the test not
flaky, I just made it so it doesn't GC anymore.
I published the test which causes the JVM to crash here
https://github.com/dcapwell/cassandra/commit/355b3299ba77f91d418850eb75908b5d6461e6a8
> Fix flaky - ChecksummingTransformerTest -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> ---
>
> Key: CASSANDRA-15313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15313
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Vinay Chella
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0-alpha
>
> Attachments: CASSANDRA-15313-hack.patch
>
>
> During the recent runs, this test appears to be flaky.
> Example failure:
> [https://circleci.com/gh/vinaykumarchella/cassandra/459#tests/containers/94]
> corruptionCausesFailure-compression -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> {code:java}
> java.lang.OutOfMemoryError: GC overhead limit exceeded
> at java.nio.HeapByteBuffer.(HeapByteBuffer.java:57)
> at java.nio.ByteBuffer.allocate(ByteBuffer.java:335)
> at org.quicktheories.impl.Precursor.(Precursor.java:17)
> at
> org.quicktheories.impl.ConcreteDetachedSource.(ConcreteDetachedSource.java:8)
> at
> org.quicktheories.impl.ConcreteDetachedSource.detach(ConcreteDetachedSource.java:23)
> at org.quicktheories.generators.Retry.generate(CodePoints.java:51)
> at
> org.quicktheories.generators.Generate.lambda$intArrays$10(Generate.java:190)
> at
> org.quicktheories.generators.Generate$$Lambda$17/1847008471.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$mix$10(Gen.java:184)
> at org.quicktheories.core.Gen$$Lambda$45/802243390.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$flatMap$5(Gen.java:93)
> at org.quicktheories.core.Gen$$Lambda$48/363509958.generate(Unknown
> Source)
> at
> org.quicktheories.dsl.TheoryBuilder4.lambda$prgnToTuple$12(TheoryBuilder4.java:188)
> at
> org.quicktheories.dsl.TheoryBuilder4$$Lambda$40/2003496028.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.FilteredGenerator.generate(Gen.java:225)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.impl.Core.generate(Core.java:150)
> at org.quicktheories.impl.Core.shrink(Core.java:103)
> at org.quicktheories.impl.Core.run(Core.java:39)
> at org.quicktheories.impl.TheoryRunner.check(TheoryRunner.java:35)
> at org.quicktheories.dsl.TheoryBuilder4.check(TheoryBuilder4.java:150)
> at
> org.quicktheories.dsl.TheoryBuilder4.checkAssert(TheoryBuilder4.java:162)
> at
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest.corruptionCausesFailure(ChecksummingTransformerTest.java:87)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15554) Set QT_SHRINKS=0 project wide
[ https://issues.apache.org/jira/browse/CASSANDRA-15554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-15554: - Fix Version/s: 4.0-beta Source Control Link: https://github.com/apache/cassandra/commit/0f102c86708ab7320f1d942bbf5fafebd9f00ed9 Resolution: Fixed Status: Resolved (was: Ready to Commit) > Set QT_SHRINKS=0 project wide > - > > Key: CASSANDRA-15554 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15554 > Project: Cassandra > Issue Type: Improvement > Components: Test/unit >Reporter: Jordan West >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.0-beta > > > For many of our tests QuickTheories shrinker is not sufficient and costs > time and memory when shrinking large problem spaces. Disable it by default. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: disable shrinks in quicktheories
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/trunk by this push: new 0f102c8 disable shrinks in quicktheories 0f102c8 is described below commit 0f102c86708ab7320f1d942bbf5fafebd9f00ed9 Author: Brandon Williams AuthorDate: Thu Feb 6 14:36:08 2020 -0600 disable shrinks in quicktheories Patch by brandonwilliams, reviewed by Jordan West and David Capwell for CASSANDRA-15554 --- build.xml | 2 ++ ide/idea/workspace.xml | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/build.xml b/build.xml index 7997231..1f782e8 100644 --- a/build.xml +++ b/build.xml @@ -1392,6 +1392,8 @@ + +
[jira] [Comment Edited] (CASSANDRA-15554) Set QT_SHRINKS=0 project wide
[ https://issues.apache.org/jira/browse/CASSANDRA-15554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031999#comment-17031999 ] David Capwell edited comment on CASSANDRA-15554 at 2/6/20 10:40 PM: tested this against CASSANDRA-1 and saw that shrinking did not happen anymore +1 was (Author: dcapwell): tested this against CASSANDRA-1 and saw that shrinking did not happen anymore > Set QT_SHRINKS=0 project wide > - > > Key: CASSANDRA-15554 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15554 > Project: Cassandra > Issue Type: Improvement > Components: Test/unit >Reporter: Jordan West >Assignee: Brandon Williams >Priority: Normal > > For many of our tests QuickTheories shrinker is not sufficient and costs > time and memory when shrinking large problem spaces. Disable it by default. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15554) Set QT_SHRINKS=0 project wide
[ https://issues.apache.org/jira/browse/CASSANDRA-15554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15554: -- Status: Ready to Commit (was: Review In Progress) tested this against CASSANDRA-1 and saw that shrinking did not happen anymore > Set QT_SHRINKS=0 project wide > - > > Key: CASSANDRA-15554 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15554 > Project: Cassandra > Issue Type: Improvement > Components: Test/unit >Reporter: Jordan West >Assignee: Brandon Williams >Priority: Normal > > For many of our tests QuickTheories shrinker is not sufficient and costs > time and memory when shrinking large problem spaces. Disable it by default. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15555) Lower the amount of garbage ChecksummingTransformerTest generates by reusing memory
[ https://issues.apache.org/jira/browse/CASSANDRA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031998#comment-17031998 ] David Capwell commented on CASSANDRA-1: --- I made sure to replicate the four different modes: success, timeout, failure, crash; samples are shown below. I also monitored the JVM's memory during the test and see that it grows very slowly; old gen grows 1% every 10 seconds so takes a while to get a stop the world GC, once that happens we drop all the way back down to 27%. # Success testclasslist: [echo] Number of test runners: 1 [junit-timeout] Picked up _JAVA_OPTIONS: -Djava.net.preferIPv4Stack=true [junit-timeout] Testsuite: org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest [junit-timeout] Testsuite: org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.988 sec [junit-timeout] [junitreport] Processing /Users/davidcapwell/src/github/apache/cassandra/build/test/TESTS-TestSuites.xml to /var/folders/cm/08cddl2s25j7fq3jdb76gh4rgn/T/null80285074 [junitreport] Loading stylesheet jar:file:/usr/local/Cellar/ant/1.10.7/libexec/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl [junitreport] Transform time: 224ms [junitreport] Deleting: /var/folders/cm/08cddl2s25j7fq3jdb76gh4rgn/T/null80285074 # Failure (timeout) [junit-timeout] Testsuite: org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest [junit-timeout] Testsuite: org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 sec [junit-timeout] [junit-timeout] Testcase: org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest:corruptionCausesFailure: Caused an ERROR [junit-timeout] Timeout occurred. Please note the time in the report does not reflect the time until the timeout. [junit-timeout] junit.framework.AssertionFailedError: Timeout occurred. Please note the time in the report does not reflect the time until the timeout. [junit-timeout] at java.util.Vector.forEach(Vector.java:1275) [junit-timeout] at java.util.Vector.forEach(Vector.java:1275) [junit-timeout] at java.lang.Thread.run(Thread.java:748) [junit-timeout] [junit-timeout] [junit-timeout] Test org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest FAILED (timeout) # Failure ... (way too much output to show here) [junit-timeout] Seed was 121866756470991 [junit-timeout] at org.quicktheories.core.ExceptionReporter.falsify(ExceptionReporter.java:43) [junit-timeout] at org.quicktheories.core.ExceptionReporter.falisification(ExceptionReporter.java:37) [junit-timeout] at org.quicktheories.impl.TheoryRunner.reportFalsification(TheoryRunner.java:48) [junit-timeout] at org.quicktheories.impl.TheoryRunner.check(TheoryRunner.java:37) [junit-timeout] at org.quicktheories.dsl.TheoryBuilder4.check(TheoryBuilder4.java:150) [junit-timeout] at org.quicktheories.dsl.TheoryBuilder4.checkAssert(TheoryBuilder4.java:162) [junit-timeout] at org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest.corruptionCausesFailure(ChecksummingTransformerTest.java:89) [junit-timeout] [junit-timeout] [junit-timeout] Test org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest FAILED [junitreport] Processing /Users/davidcapwell/src/github/apache/cassandra/build/test/TESTS-TestSuites.xml to /var/folders/cm/08cddl2s25j7fq3jdb76gh4rgn/T/null958014975 [junitreport] Loading stylesheet jar:file:/usr/local/Cellar/ant/1.10.7/libexec/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl [junitreport] Transform time: 987ms [junitreport] Deleting: /var/folders/cm/08cddl2s25j7fq3jdb76gh4rgn/T/null958014975 BUILD FAILED # Failure with Jvm Crash testclasslist: [echo] Number of test runners: 1 [mkdir] Created dir: /Users/davidcapwell/src/github/apache/cassandra/build/test/cassandra [mkdir] Created dir: /Users/davidcapwell/src/github/apache/cassandra/build/test/output [junit-timeout] Picked up _JAVA_OPTIONS: -Djava.net.preferIPv4Stack=true [junit-timeout] Testsuite: org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest [junit-timeout] # [junit-timeout] # A fatal error has been detected by the Java Runtime Environment: [junit-timeout] # [junit-timeout] # SIGBUS (0xa) at pc=0x00010a7e0ad1, pid=94921, tid=0x1103 [junit-timeout] # [junit-timeout] # JRE version: OpenJDK Runtime Environment (8.0_222-b10) (build 1.8.0_222-b10) [junit-timeout] # Java VM: OpenJDK 64-Bit Server VM (25.222-b10 mixed mode bsd-amd64 compressed oops) [junit-timeout] # Problematic frame: [junit-timeout] # C [liblz4-java8893
[jira] [Comment Edited] (CASSANDRA-15555) Lower the amount of garbage ChecksummingTransformerTest generates by reusing memory
[
https://issues.apache.org/jira/browse/CASSANDRA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031998#comment-17031998
]
David Capwell edited comment on CASSANDRA-1 at 2/6/20 10:37 PM:
I made sure to replicate the four different modes: success, timeout, failure,
crash; samples are shown below.
I also monitored the JVM's memory during the test and see that it grows very
slowly; old gen grows 1% every 10 seconds so takes a while to get a stop the
world GC, once that happens we drop all the way back down to 27%.
# Success
{code}
testclasslist:
[echo] Number of test runners: 1
[junit-timeout] Picked up _JAVA_OPTIONS: -Djava.net.preferIPv4Stack=true
[junit-timeout] Testsuite:
org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
[junit-timeout] Testsuite:
org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest Tests
run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.988 sec
[junit-timeout]
[junitreport] Processing
/Users/davidcapwell/src/github/apache/cassandra/build/test/TESTS-TestSuites.xml
to /var/folders/cm/08cddl2s25j7fq3jdb76gh4rgn/T/null80285074
[junitreport] Loading stylesheet
jar:file:/usr/local/Cellar/ant/1.10.7/libexec/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl
[junitreport] Transform time: 224ms
[junitreport] Deleting:
/var/folders/cm/08cddl2s25j7fq3jdb76gh4rgn/T/null80285074
{code}
# Failure (timeout)
{code}
[junit-timeout] Testsuite:
org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
[junit-timeout] Testsuite:
org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest Tests
run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 sec
[junit-timeout]
[junit-timeout] Testcase:
org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest:corruptionCausesFailure:
Caused an ERROR
[junit-timeout] Timeout occurred. Please note the time in the report does not
reflect the time until the timeout.
[junit-timeout] junit.framework.AssertionFailedError: Timeout occurred. Please
note the time in the report does not reflect the time until the timeout.
[junit-timeout] at java.util.Vector.forEach(Vector.java:1275)
[junit-timeout] at java.util.Vector.forEach(Vector.java:1275)
[junit-timeout] at java.lang.Thread.run(Thread.java:748)
[junit-timeout]
[junit-timeout]
[junit-timeout] Test
org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
FAILED (timeout)
{code}
# Failure
{code}
... (way too much output to show here)
[junit-timeout] Seed was 121866756470991
[junit-timeout] at
org.quicktheories.core.ExceptionReporter.falsify(ExceptionReporter.java:43)
[junit-timeout] at
org.quicktheories.core.ExceptionReporter.falisification(ExceptionReporter.java:37)
[junit-timeout] at
org.quicktheories.impl.TheoryRunner.reportFalsification(TheoryRunner.java:48)
[junit-timeout] at
org.quicktheories.impl.TheoryRunner.check(TheoryRunner.java:37)
[junit-timeout] at
org.quicktheories.dsl.TheoryBuilder4.check(TheoryBuilder4.java:150)
[junit-timeout] at
org.quicktheories.dsl.TheoryBuilder4.checkAssert(TheoryBuilder4.java:162)
[junit-timeout] at
org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest.corruptionCausesFailure(ChecksummingTransformerTest.java:89)
[junit-timeout]
[junit-timeout]
[junit-timeout] Test
org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest FAILED
[junitreport] Processing
/Users/davidcapwell/src/github/apache/cassandra/build/test/TESTS-TestSuites.xml
to /var/folders/cm/08cddl2s25j7fq3jdb76gh4rgn/T/null958014975
[junitreport] Loading stylesheet
jar:file:/usr/local/Cellar/ant/1.10.7/libexec/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl
[junitreport] Transform time: 987ms
[junitreport] Deleting:
/var/folders/cm/08cddl2s25j7fq3jdb76gh4rgn/T/null958014975
BUILD FAILED
{code}
# Failure with Jvm Crash
{code}
testclasslist:
[echo] Number of test runners: 1
[mkdir] Created dir:
/Users/davidcapwell/src/github/apache/cassandra/build/test/cassandra
[mkdir] Created dir:
/Users/davidcapwell/src/github/apache/cassandra/build/test/output
[junit-timeout] Picked up _JAVA_OPTIONS: -Djava.net.preferIPv4Stack=true
[junit-timeout] Testsuite:
org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
[junit-timeout] #
[junit-timeout] # A fatal error has been detected by the Java Runtime
Environment:
[junit-timeout] #
[junit-timeout] # SIGBUS (0xa) at pc=0x00010a7e0ad1, pid=94921,
tid=0x1103
[junit-timeout] #
[junit-timeout] # JRE version: OpenJDK Runtime Environment (8.0_222-b10) (build
1.8.0_222-b10)
[junit-timeout] # Java VM: OpenJDK 64-Bit Server VM (25.222-b10 mixed mode
bsd
[jira] [Updated] (CASSANDRA-15555) Lower the amount of garbage ChecksummingTransformerTest generates by reusing memory
[ https://issues.apache.org/jira/browse/CASSANDRA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CASSANDRA-1: --- Labels: pull-request-available (was: ) > Lower the amount of garbage ChecksummingTransformerTest generates by reusing > memory > --- > > Key: CASSANDRA-1 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1 > Project: Cassandra > Issue Type: Sub-task > Components: Test/unit >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Fix For: 4.0-alpha > > > When the test finds a issue and attempts to shrink, a ton of garbage is > generated which cause the test to then fail with GC issues. Since the test > is a quick theories test, we can rewrite the generates to reuse memory rather > than creating new objects for each iteration. This will also let us move > away from String which requires multiple copies in the test and gets rid of > the getBytes() call which is dependent on the system its called on. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15555) Lower the amount of garbage ChecksummingTransformerTest generates by reusing memory
[ https://issues.apache.org/jira/browse/CASSANDRA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-1: -- Test and Documentation Plan: tested in ant to reproduce all 4 modes. Status: Patch Available (was: Open) > Lower the amount of garbage ChecksummingTransformerTest generates by reusing > memory > --- > > Key: CASSANDRA-1 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1 > Project: Cassandra > Issue Type: Sub-task > Components: Test/unit >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Fix For: 4.0-alpha > > Time Spent: 10m > Remaining Estimate: 0h > > When the test finds a issue and attempts to shrink, a ton of garbage is > generated which cause the test to then fail with GC issues. Since the test > is a quick theories test, we can rewrite the generates to reuse memory rather > than creating new objects for each iteration. This will also let us move > away from String which requires multiple copies in the test and gets rid of > the getBytes() call which is dependent on the system its called on. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15555) Lower the amount of garbage ChecksummingTransformerTest generates by reusing memory
[ https://issues.apache.org/jira/browse/CASSANDRA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-1: -- Change Category: Quality Assurance Complexity: Low Hanging Fruit Fix Version/s: 4.0-alpha Status: Open (was: Triage Needed) > Lower the amount of garbage ChecksummingTransformerTest generates by reusing > memory > --- > > Key: CASSANDRA-1 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1 > Project: Cassandra > Issue Type: Sub-task > Components: Test/unit >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.0-alpha > > > When the test finds a issue and attempts to shrink, a ton of garbage is > generated which cause the test to then fail with GC issues. Since the test > is a quick theories test, we can rewrite the generates to reuse memory rather > than creating new objects for each iteration. This will also let us move > away from String which requires multiple copies in the test and gets rid of > the getBytes() call which is dependent on the system its called on. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15554) Set QT_SHRINKS=0 project wide
[ https://issues.apache.org/jira/browse/CASSANDRA-15554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031995#comment-17031995 ] Jordan West commented on CASSANDRA-15554: - +1. Thanks! > Set QT_SHRINKS=0 project wide > - > > Key: CASSANDRA-15554 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15554 > Project: Cassandra > Issue Type: Improvement > Components: Test/unit >Reporter: Jordan West >Assignee: Brandon Williams >Priority: Normal > > For many of our tests QuickTheories shrinker is not sufficient and costs > time and memory when shrinking large problem spaces. Disable it by default. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15555) Lower the amount of garbage ChecksummingTransformerTest generates by reusing memory
David Capwell created CASSANDRA-1: - Summary: Lower the amount of garbage ChecksummingTransformerTest generates by reusing memory Key: CASSANDRA-1 URL: https://issues.apache.org/jira/browse/CASSANDRA-1 Project: Cassandra Issue Type: Sub-task Components: Test/unit Reporter: David Capwell Assignee: David Capwell When the test finds a issue and attempts to shrink, a ton of garbage is generated which cause the test to then fail with GC issues. Since the test is a quick theories test, we can rewrite the generates to reuse memory rather than creating new objects for each iteration. This will also let us move away from String which requires multiple copies in the test and gets rid of the getBytes() call which is dependent on the system its called on. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
svn commit: r37910 - /release/cassandra/4.0-alpha3/debian/
Author: mshuler Date: Thu Feb 6 22:15:33 2020 New Revision: 37910 Log: Drop debian dir down in 4.0-alpha3 Removed: release/cassandra/4.0-alpha3/debian/ - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15554) Set QT_SHRINKS=0 project wide
[ https://issues.apache.org/jira/browse/CASSANDRA-15554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031990#comment-17031990 ] Brandon Williams commented on CASSANDRA-15554: -- I don't see any possible harm in doing so; added that and pushed. > Set QT_SHRINKS=0 project wide > - > > Key: CASSANDRA-15554 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15554 > Project: Cassandra > Issue Type: Improvement > Components: Test/unit >Reporter: Jordan West >Assignee: Brandon Williams >Priority: Normal > > For many of our tests QuickTheories shrinker is not sufficient and costs > time and memory when shrinking large problem spaces. Disable it by default. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15554) Set QT_SHRINKS=0 project wide
[ https://issues.apache.org/jira/browse/CASSANDRA-15554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan West updated CASSANDRA-15554: Reviewers: David Capwell, Jordan West (was: David Capwell) > Set QT_SHRINKS=0 project wide > - > > Key: CASSANDRA-15554 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15554 > Project: Cassandra > Issue Type: Improvement > Components: Test/unit >Reporter: Jordan West >Assignee: Brandon Williams >Priority: Normal > > For many of our tests QuickTheories shrinker is not sufficient and costs > time and memory when shrinking large problem spaces. Disable it by default. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15554) Set QT_SHRINKS=0 project wide
[ https://issues.apache.org/jira/browse/CASSANDRA-15554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031983#comment-17031983 ] Jordan West commented on CASSANDRA-15554: - Noticed there was a minor whitespace issue when I pulled it down. Should we also update [https://github.com/apache/cassandra/blob/trunk/ide/idea/workspace.xml#L170] so its picked up in IntelliJ? > Set QT_SHRINKS=0 project wide > - > > Key: CASSANDRA-15554 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15554 > Project: Cassandra > Issue Type: Improvement > Components: Test/unit >Reporter: Jordan West >Assignee: Brandon Williams >Priority: Normal > > For many of our tests QuickTheories shrinker is not sufficient and costs > time and memory when shrinking large problem spaces. Disable it by default. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15306) Investigate why we are allocating 8MiB chunks and reaching the maximum BufferPool size
[
https://issues.apache.org/jira/browse/CASSANDRA-15306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031984#comment-17031984
]
Brandon Williams commented on CASSANDRA-15306:
--
I was not able to reproduce this. If you still see it on trunk, can you give
more details?
> Investigate why we are allocating 8MiB chunks and reaching the maximum
> BufferPool size
> --
>
> Key: CASSANDRA-15306
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15306
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/Logging, Test/benchmark
>Reporter: Joey Lynch
>Priority: Normal
> Fix For: 4.0-beta
>
>
> While throwing some light traffic at {{4.0-alpha1}} I saw a lot of the
> following in the logs
> {noformat}
> INFO [CompactionExecutor:8] 2019-09-06 11:40:31,419 NoSpamLogger.java:91 -
> Maximum memory usage reached (512.000MiB), cannot allocate chunk of 8.000MiB
> INFO [CompactionExecutor:8] 2019-09-06 11:55:31,419 NoSpamLogger.java:91 -
> Maximum memory usage reached (512.000MiB), cannot allocate chunk of 8.000MiB
> INFO [CompactionExecutor:15] 2019-09-06 12:10:31,419 NoSpamLogger.java:91 -
> Maximum memory usage reached (512.000MiB), cannot allocate chunk of 8.000MiB
> INFO [CompactionExecutor:18] 2019-09-06 12:25:31,421 NoSpamLogger.java:91 -
> Maximum memory usage reached (512.000MiB), cannot allocate chunk of 8.000MiB
> {noformat}
> This was with about 150 WPS against a LCS table containing 4kib partitions.
> It seemed that compaction proceeded just fine but I don't remember seeing
> this in previous testing runs and I'd like to make sure it's not a bug
> (otherwise we may want to reduce the logging).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15213) DecayingEstimatedHistogramReservoir Inefficiencies
[
https://issues.apache.org/jira/browse/CASSANDRA-15213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031972#comment-17031972
]
Jordan West edited comment on CASSANDRA-15213 at 2/6/20 9:57 PM:
-
Was asked to run tlp-stress against this branch. After several runs I think at
the cluster level its pretty much a wash between this branch and trunk (except
the memory savings of this branch ofc). Added the output from one of the runs
if folks want to look closer. Its worth noting: this was pretty small / limited
hardware.
Workload:
{code}
./bin/tlp-stress run KeyValue --populate 500k --partitions 1m --threads 4 \
--replication "{'class': 'NetworkTopologyStrategy', 'DC1': 3 }" \
--duration 1h --username $CUSER --password $CPASS \
--host $HOST
{code}
was (Author: jrwest):
Was asked to run tlp-stress against this branch. After several runs I think at
the cluster level its pretty much a wash between this branch and trunk (except
the memory savings of this branch ofc). Added the output from one of the runs
if folks want to look closer. Its worth noting: this was pretty small / limited
hardware.
> DecayingEstimatedHistogramReservoir Inefficiencies
> --
>
> Key: CASSANDRA-15213
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15213
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/Metrics
>Reporter: Benedict Elliott Smith
>Assignee: Jordan West
>Priority: Normal
> Fix For: 4.0-beta
>
> Attachments: 15213-perf-branch, 15213-perf-trunk
>
>
> * {{LongAdder}} introduced to trunk consumes 9MiB of heap without user
> schemas, and this will grow significantly under contention and user schemas
> with many tables. This is because {{LongAdder}} is a very heavy class
> designed for single contended values.
> ** This can likely be improved significantly, without significant loss of
> performance in the contended case, by simply increasing the size of our
> primitive backing array and providing multiple buckets, with each thread
> picking a bucket to increment, or simply multiple backing arrays. Probably a
> better way still to do this would be to introduce some competition detection
> to the update, much like {{LongAdder}} utilises, that increases the number of
> backing arrays under competition.
> ** To save memory this approach could partition the space into chunks that
> are likely to be updated together, so that we do not need to duplicate the
> entire array under competition.
> * Similarly, binary search is costly and a measurable cost as a share of the
> new networking work (without filtering it was > 10% of the CPU used overall).
> We can compute an approximation floor(log2 n / log2 1.2) extremely cheaply,
> to save the random memory access costs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15213) DecayingEstimatedHistogramReservoir Inefficiencies
[
https://issues.apache.org/jira/browse/CASSANDRA-15213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031972#comment-17031972
]
Jordan West commented on CASSANDRA-15213:
-
Was asked to run tlp-stress against this branch. After several runs I think at
the cluster level its pretty much a wash between this branch and trunk (except
the memory savings of this branch ofc). Added the output from one of the runs
if folks want to look closer. Its worth noting: this was pretty small / limited
hardware.
> DecayingEstimatedHistogramReservoir Inefficiencies
> --
>
> Key: CASSANDRA-15213
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15213
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/Metrics
>Reporter: Benedict Elliott Smith
>Assignee: Jordan West
>Priority: Normal
> Fix For: 4.0-beta
>
> Attachments: 15213-perf-branch, 15213-perf-trunk
>
>
> * {{LongAdder}} introduced to trunk consumes 9MiB of heap without user
> schemas, and this will grow significantly under contention and user schemas
> with many tables. This is because {{LongAdder}} is a very heavy class
> designed for single contended values.
> ** This can likely be improved significantly, without significant loss of
> performance in the contended case, by simply increasing the size of our
> primitive backing array and providing multiple buckets, with each thread
> picking a bucket to increment, or simply multiple backing arrays. Probably a
> better way still to do this would be to introduce some competition detection
> to the update, much like {{LongAdder}} utilises, that increases the number of
> backing arrays under competition.
> ** To save memory this approach could partition the space into chunks that
> are likely to be updated together, so that we do not need to duplicate the
> entire array under competition.
> * Similarly, binary search is costly and a measurable cost as a share of the
> new networking work (without filtering it was > 10% of the CPU used overall).
> We can compute an approximation floor(log2 n / log2 1.2) extremely cheaply,
> to save the random memory access costs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15213) DecayingEstimatedHistogramReservoir Inefficiencies
[
https://issues.apache.org/jira/browse/CASSANDRA-15213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jordan West updated CASSANDRA-15213:
Attachment: 15213-perf-trunk
15213-perf-branch
> DecayingEstimatedHistogramReservoir Inefficiencies
> --
>
> Key: CASSANDRA-15213
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15213
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/Metrics
>Reporter: Benedict Elliott Smith
>Assignee: Jordan West
>Priority: Normal
> Fix For: 4.0-beta
>
> Attachments: 15213-perf-branch, 15213-perf-trunk
>
>
> * {{LongAdder}} introduced to trunk consumes 9MiB of heap without user
> schemas, and this will grow significantly under contention and user schemas
> with many tables. This is because {{LongAdder}} is a very heavy class
> designed for single contended values.
> ** This can likely be improved significantly, without significant loss of
> performance in the contended case, by simply increasing the size of our
> primitive backing array and providing multiple buckets, with each thread
> picking a bucket to increment, or simply multiple backing arrays. Probably a
> better way still to do this would be to introduce some competition detection
> to the update, much like {{LongAdder}} utilises, that increases the number of
> backing arrays under competition.
> ** To save memory this approach could partition the space into chunks that
> are likely to be updated together, so that we do not need to duplicate the
> entire array under competition.
> * Similarly, binary search is costly and a measurable cost as a share of the
> new networking work (without filtering it was > 10% of the CPU used overall).
> We can compute an approximation floor(log2 n / log2 1.2) extremely cheaply,
> to save the random memory access costs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
svn commit: r37909 - in /release/cassandra: 4.0-alpha2/ debian/pool/main/c/cassandra/
Author: mshuler Date: Thu Feb 6 21:51:10 2020 New Revision: 37909 Log: Remove 4.0-alpha2 version to clean up Removed: release/cassandra/4.0-alpha2/ release/cassandra/debian/pool/main/c/cassandra/cassandra-tools_4.0~alpha2_all.deb release/cassandra/debian/pool/main/c/cassandra/cassandra_4.0~alpha2.diff.gz release/cassandra/debian/pool/main/c/cassandra/cassandra_4.0~alpha2.dsc release/cassandra/debian/pool/main/c/cassandra/cassandra_4.0~alpha2.orig.tar.gz release/cassandra/debian/pool/main/c/cassandra/cassandra_4.0~alpha2.orig.tar.gz.asc release/cassandra/debian/pool/main/c/cassandra/cassandra_4.0~alpha2.orig.tar.gz.sha256 release/cassandra/debian/pool/main/c/cassandra/cassandra_4.0~alpha2.orig.tar.gz.sha512 release/cassandra/debian/pool/main/c/cassandra/cassandra_4.0~alpha2_all.deb - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
svn commit: r37908 - in /release/cassandra/debian: dists/40x/ dists/40x/main/ pool/main/c/cassandra/
Author: mshuler Date: Thu Feb 6 21:48:47 2020 New Revision: 37908 Log: Apache Cassandra 4.0-alpha3 debian artifacts take2 Added: release/cassandra/debian/dists/40x/InRelease - copied unchanged from r37907, release/cassandra/4.0-alpha3/debian/dists/40x/InRelease release/cassandra/debian/dists/40x/Release - copied unchanged from r37907, release/cassandra/4.0-alpha3/debian/dists/40x/Release release/cassandra/debian/dists/40x/Release.gpg - copied unchanged from r37907, release/cassandra/4.0-alpha3/debian/dists/40x/Release.gpg release/cassandra/debian/dists/40x/main/ - copied from r37907, release/cassandra/4.0-alpha3/debian/dists/40x/main/ release/cassandra/debian/pool/main/c/cassandra/cassandra-tools_4.0~alpha3_all.deb - copied unchanged from r37907, release/cassandra/4.0-alpha3/debian/pool/main/c/cassandra/cassandra-tools_4.0~alpha3_all.deb release/cassandra/debian/pool/main/c/cassandra/cassandra_4.0~alpha3.dsc - copied unchanged from r37907, release/cassandra/4.0-alpha3/debian/pool/main/c/cassandra/cassandra_4.0~alpha3.dsc release/cassandra/debian/pool/main/c/cassandra/cassandra_4.0~alpha3.tar.gz - copied unchanged from r37907, release/cassandra/4.0-alpha3/debian/pool/main/c/cassandra/cassandra_4.0~alpha3.tar.gz release/cassandra/debian/pool/main/c/cassandra/cassandra_4.0~alpha3_all.deb - copied unchanged from r37907, release/cassandra/4.0-alpha3/debian/pool/main/c/cassandra/cassandra_4.0~alpha3_all.deb - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15313) Fix flaky - ChecksummingTransformerTest - org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031849#comment-17031849
]
David Capwell edited comment on CASSANDRA-15313 at 2/6/20 9:46 PM:
---
With my new patch I get the following failure
{code}
java.lang.AssertionError: Property falsified after 4675 example(s)
Smallest found falsifying value(s) :-
{(6364636563646464636365656365636565636564656463636565636464656563656565646364646363646563646363646363656464636465656364636365656564636365636565636463646565636463636364656365646363656563656365636464646464646464646363646464656463636463646564636464646363656464636364646363646365636365646463656465636565646465656464636364646364646565636564656563656563646563636565646563636563646565636363636563656364646363656564656364646463636364646565656363656464636564646463656463656363636565656563646364656363636565636363656363636563636464636364636464636363646564646563646465636564636464636365646465636565636363646564656463646565646364636565636464636365656463636464656364646564636464636465636563656365636563646464646563646564646564656463646563636465656364646565646465656363636363636563656363656563636364646363646464656564656364646364636563656465636563646463646364656365636464656364636564646465646465646564656363656464656563636565646564646565656363636465646463656463646365656463636363646563656365656363636563646465636563636464636363636363656364646365656363636365646364656364636565646363646564656363656464656563656465636365636465656364656364656564636465646464646464646365636365646465646463656363636465636464656564646464646464636464636363646564646365656565636564646564636364636363656565636365656465636363646363656564636563656363636365646564656564646463636364656463636364636464636464646565656463656365636565636363636564636564656463656363646365636363646465646464636464636564636563646463646363646364656364636365646363656465636365646465646563636463646363636465646465646463636463646364646463636464656363636464656565656365656364646565656564636563636565636465636363636364646465646363646463646564646465656464636563636363636363656365656563656365656363656563646364646365636364636463646464646565646463646465656364646463656463646364636465636463656363646364636463656365636364636363636364636365636364646364646465636365646465656463636<...>636364646363636565646365646463636363636563646363656464646364646364636364656363646363656463636363656363636563646563636563656363656363646363636363636363646363646563636363646365636363636465656463636363646363636563636463656363636365656363656364646363646365636463646363636363646363646463636463636363636365636363636363646363636363636363636365636464646363636565636363646363636363636363636364636365656364656363636463636363636363636365636463656563656364646365636564636364656364646363636364636463656463636363636365646364636565656363636363636365636563646363656365636364656364646363636363646564636563636464636363656363646363636363636364636563636363636563636363656463636363636363636363656363636363636463636365656363636364636464656463646363646364636463636363636363636363636465646464636363646363636363646563636463636563636563636463646563656463636463636463636565646363646363636463636363636563636363636463656463656364646363636365636363636364636364636563656364646463646363646363636563636363646364646563636365636364636365636363636565636364646465636363636364646363636365656363656464646363636363646463636464636364656363636464656363636563636364646363636363636463646364636365636363646363646363636463656463646564636364646363636463636463636363636363636364636564636464656363636463646363636364636363636363646363646464636363646363636464636464636363636365646364646563656563656363646563636364636363636364646365636363656463646363636363636364636363646363636365646365646363646364646363636363636565656463646363656363646364636363636365636363646365646363636363636363636564636565646463636563646465646463636463636363656365646364636465636463646563636364646363636463636563646363646365646364646363636363656365636363636363636364636563636363656364656463646363636463636363636563636463656365636363636363646364656363636363636365636563636364646363636463636465636463656464646563646363656564656463646563656363636463656464636364636563,72535),
14, org.apache.cassandra.transport.frame.compress.SnappyCompressor@4b41dd5c,
ADLER32}
Seed was 113149736037976
{code}
and
{code}
java.lang.AssertionError: Property falsified after 21514 example(s)
Smallest found falsifying value(s) :-
{(6364636564656464636364656365636563646465636563646464656563636564656464656563646563636464656363636465636363656365636365636364636564636363636465656364636363646563656363656465656563646565646564646564636565636565656464636564656563646565646364636364656564646363636465646365636463636465656563646364646565646365636363636363636464656564636565646464636363656563636363636563636365656465636563646563656565646465656365656363646363656464636565646563636564646564646463636363656464656563636565636
[jira] [Comment Edited] (CASSANDRA-10190) Python 3 support for cqlsh
[ https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031896#comment-17031896 ] Dinesh Joshi edited comment on CASSANDRA-10190 at 2/6/20 9:41 PM: -- [~ptbannister] and [~dcapwell] I have addressed your review comments. I also removed the Python 2 specific code from cassandra-dtests as dtests themselves are expected to be Python 3 only. I have added the circleci changes to this patch so can get this in trunk. However, we would need to backport it to other branches or Python 2.7 only. Latest test runs are [here|https://circleci.com/workflow-run/d49608a5-f630-478c-947a-55a96048f5a1]. Please ignore the flakey unit test failure. was (Author: djoshi3): [~ptbannister] and [~dcapwell] I have addressed your review comments. I also removed the Python 2 specific code from cassandra-dtests as dtests themselves are expected to be Python 3 only. I have added the circleci changes to this patch so can get this in trunk. However, we would need to backport it to other branches or Python 2.7 only. > Python 3 support for cqlsh > -- > > Key: CASSANDRA-10190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10190 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Tools >Reporter: Andrew Pennebaker >Assignee: Patrick Bannister >Priority: Normal > Labels: cqlsh, pull-request-available > Fix For: 4.0, 4.0-alpha > > Attachments: > 0001-Fix-issues-from-version-specific-logic-commit.patch, > 0001-Update-six-to-1.12.0.patch, > 0002-Simplify-version-specific-logic-by-using-six.moves-a.patch, > coverage_notes.txt > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Users who operate in a Python 3 environment may have trouble launching cqlsh. > Could we please update cqlsh's syntax to run in Python 3? > As a workaround, users can setup pyenv, and cd to a directory with a > .python-version containing "2.7". But it would be nice if cqlsh supported > modern Python versions out of the box. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15554) Set QT_SHRINKS=0 project wide
[ https://issues.apache.org/jira/browse/CASSANDRA-15554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15554: -- Reviewers: David Capwell, David Capwell (was: David Capwell) David Capwell, David Capwell Status: Review In Progress (was: Patch Available) > Set QT_SHRINKS=0 project wide > - > > Key: CASSANDRA-15554 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15554 > Project: Cassandra > Issue Type: Improvement > Components: Test/unit >Reporter: Jordan West >Assignee: Brandon Williams >Priority: Normal > > For many of our tests QuickTheories shrinker is not sufficient and costs > time and memory when shrinking large problem spaces. Disable it by default. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15554) Set QT_SHRINKS=0 project wide
[ https://issues.apache.org/jira/browse/CASSANDRA-15554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031959#comment-17031959 ] David Capwell commented on CASSANDRA-15554: --- patch LGTM; finishing off my patch for qt memory and will test it with this patch > Set QT_SHRINKS=0 project wide > - > > Key: CASSANDRA-15554 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15554 > Project: Cassandra > Issue Type: Improvement > Components: Test/unit >Reporter: Jordan West >Assignee: Brandon Williams >Priority: Normal > > For many of our tests QuickTheories shrinker is not sufficient and costs > time and memory when shrinking large problem spaces. Disable it by default. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-10190) Python 3 support for cqlsh
[ https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031896#comment-17031896 ] Dinesh Joshi edited comment on CASSANDRA-10190 at 2/6/20 9:34 PM: -- [~ptbannister] and [~dcapwell] I have addressed your review comments. I also removed the Python 2 specific code from cassandra-dtests as dtests themselves are expected to be Python 3 only. I have added the circleci changes to this patch so can get this in trunk. However, we would need to backport it to other branches or Python 2.7 only. was (Author: djoshi3): [~ptbannister] and [~dcapwell] I have addressed your review comments except build related changes. I also removed the Python 2 specific code from cassandra-dtests as dtests themselves are expected to be Python 3 only. > Python 3 support for cqlsh > -- > > Key: CASSANDRA-10190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10190 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Tools >Reporter: Andrew Pennebaker >Assignee: Patrick Bannister >Priority: Normal > Labels: cqlsh, pull-request-available > Fix For: 4.0, 4.0-alpha > > Attachments: > 0001-Fix-issues-from-version-specific-logic-commit.patch, > 0001-Update-six-to-1.12.0.patch, > 0002-Simplify-version-specific-logic-by-using-six.moves-a.patch, > coverage_notes.txt > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Users who operate in a Python 3 environment may have trouble launching cqlsh. > Could we please update cqlsh's syntax to run in Python 3? > As a workaround, users can setup pyenv, and cd to a directory with a > .python-version containing "2.7". But it would be nice if cqlsh supported > modern Python versions out of the box. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15554) Set QT_SHRINKS=0 project wide
[ https://issues.apache.org/jira/browse/CASSANDRA-15554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-15554: - Status: Patch Available (was: Open) https://github.com/driftx/cassandra/tree/CASSANDRA-15554 > Set QT_SHRINKS=0 project wide > - > > Key: CASSANDRA-15554 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15554 > Project: Cassandra > Issue Type: Improvement > Components: Test/unit >Reporter: Jordan West >Assignee: Brandon Williams >Priority: Normal > > For many of our tests QuickTheories shrinker is not sufficient and costs > time and memory when shrinking large problem spaces. Disable it by default. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
svn commit: r37907 - in /release/cassandra/redhat/40x: ./ repodata/
Author: mshuler Date: Thu Feb 6 21:27:47 2020 New Revision: 37907 Log: Apache Cassandra 4.0-alpha3 redhat artifacts Added: release/cassandra/redhat/40x/cassandra-4.0~alpha3-1.noarch.rpm - copied unchanged from r37906, release/cassandra/4.0-alpha3/cassandra-4.0~alpha3-1.noarch.rpm release/cassandra/redhat/40x/cassandra-4.0~alpha3-1.src.rpm - copied unchanged from r37906, release/cassandra/4.0-alpha3/cassandra-4.0~alpha3-1.src.rpm release/cassandra/redhat/40x/cassandra-tools-4.0~alpha3-1.noarch.rpm - copied unchanged from r37906, release/cassandra/4.0-alpha3/cassandra-tools-4.0~alpha3-1.noarch.rpm release/cassandra/redhat/40x/repodata/01aab27d40e98b0aed6ffe0935f7f03cdc2e33eeb5d071ee3edca26284fec4af-other.xml.gz (with props) release/cassandra/redhat/40x/repodata/029fa8875a9a72ddb6ec33af0414ed693d4dce816d31a55856d24e5c04515993-filelists.sqlite.bz2 (with props) release/cassandra/redhat/40x/repodata/577dddbfab24ee9b8abcfe01f896e8e84cb7da89bcfbe631ecdf30ee30b281e4-filelists.xml.gz (with props) release/cassandra/redhat/40x/repodata/9f60fbe12a1615858d157d496a140a1c8c154f6ae4e5907c4f07e2686cc20d56-primary.xml.gz (with props) release/cassandra/redhat/40x/repodata/b318ec13311e87898ec973f522f825a8206dd6f4d9444ce5c557c6bf696d08db-primary.sqlite.bz2 (with props) release/cassandra/redhat/40x/repodata/e797ca46ae74a09a10975f7784e4ec94f39e9becde2aab731efbd094852308b3-other.sqlite.bz2 (with props) Removed: release/cassandra/redhat/40x/cassandra-4.0~alpha2-1.noarch.rpm release/cassandra/redhat/40x/cassandra-4.0~alpha2-1.src.rpm release/cassandra/redhat/40x/cassandra-tools-4.0~alpha2-1.noarch.rpm release/cassandra/redhat/40x/repodata/2abbda53f729431faea65e9eef3331268dffc2aaa2786f1521b1d29f070c4ca5-other.sqlite.bz2 release/cassandra/redhat/40x/repodata/2abbda53f729431faea65e9eef3331268dffc2aaa2786f1521b1d29f070c4ca5-other.sqlite.bz2.asc release/cassandra/redhat/40x/repodata/2abbda53f729431faea65e9eef3331268dffc2aaa2786f1521b1d29f070c4ca5-other.sqlite.bz2.sha256 release/cassandra/redhat/40x/repodata/2abbda53f729431faea65e9eef3331268dffc2aaa2786f1521b1d29f070c4ca5-other.sqlite.bz2.sha512 release/cassandra/redhat/40x/repodata/4d311ddb803a34c9a08a1eba0f040beb3a0beca4e3c3dad489f9b90c8b2809b1-other.xml.gz release/cassandra/redhat/40x/repodata/4f0f3cd2e748bdfcb2603b223bd8f6a8551df126e53346beb49d939fefbf302e-filelists.xml.gz release/cassandra/redhat/40x/repodata/9a2f16583d9dba802df7052ce6648ab932dad753f4098cc7c317a78d16611cf3-primary.xml.gz release/cassandra/redhat/40x/repodata/adb0d81bb8048c6e7f33113dee6315afbd390eeb73af6a8d3543df360e8ef740-primary.sqlite.bz2 release/cassandra/redhat/40x/repodata/adb0d81bb8048c6e7f33113dee6315afbd390eeb73af6a8d3543df360e8ef740-primary.sqlite.bz2.asc release/cassandra/redhat/40x/repodata/adb0d81bb8048c6e7f33113dee6315afbd390eeb73af6a8d3543df360e8ef740-primary.sqlite.bz2.sha256 release/cassandra/redhat/40x/repodata/adb0d81bb8048c6e7f33113dee6315afbd390eeb73af6a8d3543df360e8ef740-primary.sqlite.bz2.sha512 release/cassandra/redhat/40x/repodata/d85b1b7fc437a770ea18609b2c7ef0d43fd4e239b27b5a841e75faed3c27d2b7-filelists.sqlite.bz2 release/cassandra/redhat/40x/repodata/d85b1b7fc437a770ea18609b2c7ef0d43fd4e239b27b5a841e75faed3c27d2b7-filelists.sqlite.bz2.asc release/cassandra/redhat/40x/repodata/d85b1b7fc437a770ea18609b2c7ef0d43fd4e239b27b5a841e75faed3c27d2b7-filelists.sqlite.bz2.sha256 release/cassandra/redhat/40x/repodata/d85b1b7fc437a770ea18609b2c7ef0d43fd4e239b27b5a841e75faed3c27d2b7-filelists.sqlite.bz2.sha512 Modified: release/cassandra/redhat/40x/repodata/repomd.xml release/cassandra/redhat/40x/repodata/repomd.xml.asc Added: release/cassandra/redhat/40x/repodata/01aab27d40e98b0aed6ffe0935f7f03cdc2e33eeb5d071ee3edca26284fec4af-other.xml.gz == Binary file - no diff available. Propchange: release/cassandra/redhat/40x/repodata/01aab27d40e98b0aed6ffe0935f7f03cdc2e33eeb5d071ee3edca26284fec4af-other.xml.gz -- svn:mime-type = application/octet-stream Added: release/cassandra/redhat/40x/repodata/029fa8875a9a72ddb6ec33af0414ed693d4dce816d31a55856d24e5c04515993-filelists.sqlite.bz2 == Binary file - no diff available. Propchange: release/cassandra/redhat/40x/repodata/029fa8875a9a72ddb6ec33af0414ed693d4dce816d31a55856d24e5c04515993-filelists.sqlite.bz2 -- svn:mime-type = application/octet-stream Added: release/cassandra/redhat/40x/repodata/577dddbfab24ee9b8abcfe01f896e8e84cb7da89bcfbe631ecdf30ee30b281e4-filelists.xml.gz == Binary file - no diff availa
[jira] [Issue Comment Deleted] (CASSANDRA-15554) Set QT_SHRINKS=0 project wide
[ https://issues.apache.org/jira/browse/CASSANDRA-15554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-15554: - Comment: was deleted (was: https://github.com/driftx/cassandra/tree/CASSANDRA-15554) > Set QT_SHRINKS=0 project wide > - > > Key: CASSANDRA-15554 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15554 > Project: Cassandra > Issue Type: Improvement > Components: Test/unit >Reporter: Jordan West >Assignee: Brandon Williams >Priority: Normal > > For many of our tests QuickTheories shrinker is not sufficient and costs > time and memory when shrinking large problem spaces. Disable it by default. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15554) Set QT_SHRINKS=0 project wide
[ https://issues.apache.org/jira/browse/CASSANDRA-15554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-15554: - Status: Open (was: Patch Available) > Set QT_SHRINKS=0 project wide > - > > Key: CASSANDRA-15554 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15554 > Project: Cassandra > Issue Type: Improvement > Components: Test/unit >Reporter: Jordan West >Assignee: Brandon Williams >Priority: Normal > > For many of our tests QuickTheories shrinker is not sufficient and costs > time and memory when shrinking large problem spaces. Disable it by default. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
svn commit: r37906 - in /release/cassandra/4.0-alpha3/debian: ./ dists/ dists/40x/ dists/40x/main/ dists/40x/main/binary-amd64/ dists/40x/main/binary-i386/ dists/40x/main/source/ pool/ pool/main/ pool
Author: mshuler Date: Thu Feb 6 21:05:33 2020 New Revision: 37906 Log: Apache Cassandra 4.0-alpha3 debian artifacts Added: release/cassandra/4.0-alpha3/debian/ release/cassandra/4.0-alpha3/debian/dists/ release/cassandra/4.0-alpha3/debian/dists/40x/ release/cassandra/4.0-alpha3/debian/dists/40x/InRelease release/cassandra/4.0-alpha3/debian/dists/40x/Release release/cassandra/4.0-alpha3/debian/dists/40x/Release.gpg release/cassandra/4.0-alpha3/debian/dists/40x/main/ release/cassandra/4.0-alpha3/debian/dists/40x/main/binary-amd64/ release/cassandra/4.0-alpha3/debian/dists/40x/main/binary-amd64/Packages release/cassandra/4.0-alpha3/debian/dists/40x/main/binary-amd64/Packages.gz (with props) release/cassandra/4.0-alpha3/debian/dists/40x/main/binary-amd64/Release release/cassandra/4.0-alpha3/debian/dists/40x/main/binary-i386/ release/cassandra/4.0-alpha3/debian/dists/40x/main/binary-i386/Packages release/cassandra/4.0-alpha3/debian/dists/40x/main/binary-i386/Packages.gz (with props) release/cassandra/4.0-alpha3/debian/dists/40x/main/binary-i386/Release release/cassandra/4.0-alpha3/debian/dists/40x/main/source/ release/cassandra/4.0-alpha3/debian/dists/40x/main/source/Release release/cassandra/4.0-alpha3/debian/dists/40x/main/source/Sources.gz (with props) release/cassandra/4.0-alpha3/debian/pool/ release/cassandra/4.0-alpha3/debian/pool/main/ release/cassandra/4.0-alpha3/debian/pool/main/c/ release/cassandra/4.0-alpha3/debian/pool/main/c/cassandra/ release/cassandra/4.0-alpha3/debian/pool/main/c/cassandra/cassandra-tools_4.0~alpha3_all.deb (with props) release/cassandra/4.0-alpha3/debian/pool/main/c/cassandra/cassandra_4.0~alpha3.dsc release/cassandra/4.0-alpha3/debian/pool/main/c/cassandra/cassandra_4.0~alpha3.tar.gz (with props) release/cassandra/4.0-alpha3/debian/pool/main/c/cassandra/cassandra_4.0~alpha3_all.deb (with props) Added: release/cassandra/4.0-alpha3/debian/dists/40x/InRelease == --- release/cassandra/4.0-alpha3/debian/dists/40x/InRelease (added) +++ release/cassandra/4.0-alpha3/debian/dists/40x/InRelease Thu Feb 6 21:05:33 2020 @@ -0,0 +1,56 @@ +-BEGIN PGP SIGNED MESSAGE- +Hash: SHA256 + +Origin: Apache Cassandra Packages +Label: Apache Cassandra Packages +Codename: 40x +Date: Thu, 06 Feb 2020 20:59:05 UTC +Architectures: i386 amd64 +Components: main +Description: Apache Cassandra APT Repository +MD5Sum: + f4bd61d939236a7c2e103108f25563a1 1499 main/binary-i386/Packages + 443f6d92175916755246a1ae65d4fb67 691 main/binary-i386/Packages.gz + 5a11be413d0d0957e421046e689a2a37 147 main/binary-i386/Release + f4bd61d939236a7c2e103108f25563a1 1499 main/binary-amd64/Packages + 443f6d92175916755246a1ae65d4fb67 691 main/binary-amd64/Packages.gz + b9fd60418097579ba5c9bea9691e871b 148 main/binary-amd64/Release + 24b9990206bd990afe78ce3af151c9c2 1220 main/source/Sources + 4af63fdca75bd90313968481fe7cd5a2 652 main/source/Sources.gz + 6591d941521706dde51f43793dccda6d 149 main/source/Release +SHA1: + 5ff803c42f4d47b39f22a0c01bd6b2bdbd5b7218 1499 main/binary-i386/Packages + 5bec7866d7481068a50418ee3932ce2d5f573fab 691 main/binary-i386/Packages.gz + 6cda7279b207ad1248302413d8bba216d0d1d7ae 147 main/binary-i386/Release + 5ff803c42f4d47b39f22a0c01bd6b2bdbd5b7218 1499 main/binary-amd64/Packages + 5bec7866d7481068a50418ee3932ce2d5f573fab 691 main/binary-amd64/Packages.gz + e49b7700fd1544db344527b3c941dd41805b699e 148 main/binary-amd64/Release + da201ecef2882ff6a779768106a1fc184ca0fc36 1220 main/source/Sources + a0b3c3dbeb58321e1dbacbd3ff258ce6f91d8913 652 main/source/Sources.gz + a9835b8d5fb9c1911926a165525a7ef7c28112f1 149 main/source/Release +SHA256: + 5a7e7990171875d55b1fb4a5a0e5e542d461ba389f812d9c0ff0d6ab33544227 1499 main/binary-i386/Packages + b64e8b1682f1dc656a4182745aa0e6558973740d35da87685736da5616106840 691 main/binary-i386/Packages.gz + 3fe9f61f16278c2d8daf858df37dcc16ce3e41bb0b6dc836e9b500623cf5763f 147 main/binary-i386/Release + 5a7e7990171875d55b1fb4a5a0e5e542d461ba389f812d9c0ff0d6ab33544227 1499 main/binary-amd64/Packages + b64e8b1682f1dc656a4182745aa0e6558973740d35da87685736da5616106840 691 main/binary-amd64/Packages.gz + b06d70a257359e63ed69f69660bbbf1959437025c622ae02eaff112b966a9699 148 main/binary-amd64/Release + 19811b1ae685b5c4392038aef742dcb94d93ddd53627a614c08b4cd0b1ea8171 1220 main/source/Sources + b8e86e3c4f0b3bc383ae64f1fe60482a9a2786bb9e7b7e6e19519d4a0066b65c 652 main/source/Sources.gz + 07d08faa347d925afe40cecd1e18306528c7d9acee38682845ce62fc2cea3507 149 main/source/Release +-BEGIN PGP SIGNATURE- + +iQIzBAEBCAAdFiEEom5SiycfGbnl2OGeoni3gf5LK9oFAl48fh4ACgkQoni3gf5L +K9r1hRAAns3Bq+KDkz+UjpFIxJOgtY2WdKk/Cu25amp8zBg7ewKXuikzXLL5dy7Y +WRBqkRDzBvD7QTSY1pugb8NHAhhazgxTSdGX68ktt6NRR/FRv2Cqz6+awlfFSTIm +9PajiaSB74JOrcjw/ksWfH+CwCRM+NaL+t6OM8rCbCj4tAHlcoFhRiM22AE1ee1W +zAT3
svn commit: r37905 - /dev/cassandra/4.0-alpha3/ /release/cassandra/4.0-alpha3/
Author: mshuler Date: Thu Feb 6 20:51:32 2020 New Revision: 37905 Log: svn mv dev2dist Added: release/cassandra/4.0-alpha3/ - copied from r37904, dev/cassandra/4.0-alpha3/ Removed: dev/cassandra/4.0-alpha3/ - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] annotated tag cassandra-4.0-alpha3 created (now 58a29a8)
This is an automated email from the ASF dual-hosted git repository. mshuler pushed a change to annotated tag cassandra-4.0-alpha3 in repository https://gitbox.apache.org/repos/asf/cassandra.git. at 58a29a8 (tag) tagging 5f7c88601c65cdf14ee68387ed68203f2603fc29 (commit) replaces cassandra-4.0-alpha2 by Michael Shuler on Thu Feb 6 14:50:52 2020 -0600 - Log - Apache Cassandra 4.0-alpha3 release --- No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] tag 4.0-alpha3-tentative deleted (was 5f7c886)
This is an automated email from the ASF dual-hosted git repository. mshuler pushed a change to tag 4.0-alpha3-tentative in repository https://gitbox.apache.org/repos/asf/cassandra.git. *** WARNING: tag 4.0-alpha3-tentative was deleted! *** was 5f7c886 Merge branch 'cassandra-3.11' into trunk The revisions that were on this tag are still contained in other references; therefore, this change does not discard any commits from the repository. - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-15554) Set QT_SHRINKS=0 project wide
[ https://issues.apache.org/jira/browse/CASSANDRA-15554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams reassigned CASSANDRA-15554: Assignee: Brandon Williams > Set QT_SHRINKS=0 project wide > - > > Key: CASSANDRA-15554 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15554 > Project: Cassandra > Issue Type: Improvement > Components: Test/unit >Reporter: Jordan West >Assignee: Brandon Williams >Priority: Normal > > For many of our tests QuickTheories shrinker is not sufficient and costs > time and memory when shrinking large problem spaces. Disable it by default. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15554) Set QT_SHRINKS=0 project wide
[ https://issues.apache.org/jira/browse/CASSANDRA-15554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-15554: - Authors: Brandon Williams Test and Documentation Plan: None Status: Patch Available (was: Open) https://github.com/driftx/cassandra/tree/CASSANDRA-15554 > Set QT_SHRINKS=0 project wide > - > > Key: CASSANDRA-15554 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15554 > Project: Cassandra > Issue Type: Improvement > Components: Test/unit >Reporter: Jordan West >Priority: Normal > > For many of our tests QuickTheories shrinker is not sufficient and costs > time and memory when shrinking large problem spaces. Disable it by default. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-10190) Python 3 support for cqlsh
[ https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031896#comment-17031896 ] Dinesh Joshi edited comment on CASSANDRA-10190 at 2/6/20 8:25 PM: -- [~ptbannister] and [~dcapwell] I have addressed your review comments except build related changes. I also removed the Python 2 specific code from cassandra-dtests as dtests themselves are expected to be Python 3 only. was (Author: djoshi3): [~ptbannister] and [~dcapwell] I have addressed your review comments. I also removed the Python 2 specific code from cassandra-dtests as dtests themselves are expected to be Python 3 only. > Python 3 support for cqlsh > -- > > Key: CASSANDRA-10190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10190 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Tools >Reporter: Andrew Pennebaker >Assignee: Patrick Bannister >Priority: Normal > Labels: cqlsh, pull-request-available > Fix For: 4.0, 4.0-alpha > > Attachments: > 0001-Fix-issues-from-version-specific-logic-commit.patch, > 0001-Update-six-to-1.12.0.patch, > 0002-Simplify-version-specific-logic-by-using-six.moves-a.patch, > coverage_notes.txt > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Users who operate in a Python 3 environment may have trouble launching cqlsh. > Could we please update cqlsh's syntax to run in Python 3? > As a workaround, users can setup pyenv, and cd to a directory with a > .python-version containing "2.7". But it would be nice if cqlsh supported > modern Python versions out of the box. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-10190) Python 3 support for cqlsh
[ https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031896#comment-17031896 ] Dinesh Joshi commented on CASSANDRA-10190: -- [~ptbannister] and [~dcapwell] I have addressed your review comments. I also removed the Python 2 specific code from cassandra-dtests as dtests themselves are expected to be Python 3 only. > Python 3 support for cqlsh > -- > > Key: CASSANDRA-10190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10190 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Tools >Reporter: Andrew Pennebaker >Assignee: Patrick Bannister >Priority: Normal > Labels: cqlsh, pull-request-available > Fix For: 4.0, 4.0-alpha > > Attachments: > 0001-Fix-issues-from-version-specific-logic-commit.patch, > 0001-Update-six-to-1.12.0.patch, > 0002-Simplify-version-specific-logic-by-using-six.moves-a.patch, > coverage_notes.txt > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Users who operate in a Python 3 environment may have trouble launching cqlsh. > Could we please update cqlsh's syntax to run in Python 3? > As a workaround, users can setup pyenv, and cd to a directory with a > .python-version containing "2.7". But it would be nice if cqlsh supported > modern Python versions out of the box. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15554) Set QT_SHRINKS=0 project wide
[ https://issues.apache.org/jira/browse/CASSANDRA-15554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan West updated CASSANDRA-15554: Change Category: Performance Complexity: Low Hanging Fruit Component/s: Test/unit Status: Open (was: Triage Needed) > Set QT_SHRINKS=0 project wide > - > > Key: CASSANDRA-15554 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15554 > Project: Cassandra > Issue Type: Improvement > Components: Test/unit >Reporter: Jordan West >Priority: Normal > > For many of our tests QuickTheories shrinker is not sufficient and costs > time and memory when shrinking large problem spaces. Disable it by default. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15554) Set QT_SHRINKS=0 project wide
Jordan West created CASSANDRA-15554: --- Summary: Set QT_SHRINKS=0 project wide Key: CASSANDRA-15554 URL: https://issues.apache.org/jira/browse/CASSANDRA-15554 Project: Cassandra Issue Type: Improvement Reporter: Jordan West For many of our tests QuickTheories shrinker is not sufficient and costs time and memory when shrinking large problem spaces. Disable it by default. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15313) Fix flaky - ChecksummingTransformerTest - org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031849#comment-17031849
]
David Capwell edited comment on CASSANDRA-15313 at 2/6/20 6:59 PM:
---
With my new patch I get the following failure
{code}
java.lang.AssertionError: Property falsified after 4675 example(s)
Smallest found falsifying value(s) :-
{(6364636563646464636365656365636565636564656463636565636464656563656565646364646363646563646363646363656464636465656364636365656564636365636565636463646565636463636364656365646363656563656365636464646464646464646363646464656463636463646564636464646363656464636364646363646365636365646463656465636565646465656464636364646364646565636564656563656563646563636565646563636563646565636363636563656364646363656564656364646463636364646565656363656464636564646463656463656363636565656563646364656363636565636363656363636563636464636364636464636363646564646563646465636564636464636365646465636565636363646564656463646565646364636565636464636365656463636464656364646564636464636465636563656365636563646464646563646564646564656463646563636465656364646565646465656363636363636563656363656563636364646363646464656564656364646364636563656465636563646463646364656365636464656364636564646465646465646564656363656464656563636565646564646565656363636465646463656463646365656463636363646563656365656363636563646465636563636464636363636363656364646365656363636365646364656364636565646363646564656363656464656563656465636365636465656364656364656564636465646464646464646365636365646465646463656363636465636464656564646464646464636464636363646564646365656565636564646564636364636363656565636365656465636363646363656564636563656363636365646564656564646463636364656463636364636464636464646565656463656365636565636363636564636564656463656363646365636363646465646464636464636564636563646463646363646364656364636365646363656465636365646465646563636463646363636465646465646463636463646364646463636464656363636464656565656365656364646565656564636563636565636465636363636364646465646363646463646564646465656464636563636363636363656365656563656365656363656563646364646365636364636463646464646565646463646465656364646463656463646364636465636463656363646364636463656365636364636363636364636365636364646364646465636365646465656463636<...>636364646363636565646365646463636363636563646363656464646364646364636364656363646363656463636363656363636563646563636563656363656363646363636363636363646363646563636363646365636363636465656463636363646363636563636463656363636365656363656364646363646365636463646363636363646363646463636463636363636365636363636363646363636363636363636365636464646363636565636363646363636363636363636364636365656364656363636463636363636363636365636463656563656364646365636564636364656364646363636364636463656463636363636365646364636565656363636363636365636563646363656365636364656364646363636363646564636563636464636363656363646363636363636364636563636363636563636363656463636363636363636363656363636363636463636365656363636364636464656463646363646364636463636363636363636363636465646464636363646363636363646563636463636563636563636463646563656463636463636463636565646363646363636463636363636563636363636463656463656364646363636365636363636364636364636563656364646463646363646363636563636363646364646563636365636364636365636363636565636364646465636363636364646363636365656363656464646363636363646463636464636364656363636464656363636563636364646363636363636463646364636365636363646363646363636463656463646564636364646363636463636463636363636363636364636564636464656363636463646363636364636363636363646363646464636363646363636464636464636363636365646364646563656563656363646563636364636363636364646365636363656463646363636363636364636363646363636365646365646363646364646363636363636565656463646363656363646364636363636365636363646365646363636363636363636564636565646463636563646465646463636463636363656365646364636465636463646563636364646363636463636563646363646365646364646363636363656365636363636363636364636563636363656364656463646363636463636363636563636463656365636363636363646364656363636363636365636563636364646363636463636465636463656464646563646363656564656463646563656363636463656464636364636563,72535),
14, org.apache.cassandra.transport.frame.compress.SnappyCompressor@4b41dd5c,
ADLER32}
Seed was 113149736037976
{code}
and
{code}
java.lang.AssertionError: Property falsified after 21514 example(s)
Smallest found falsifying value(s) :-
{(6364636564656464636364656365636563646465636563646464656563636564656464656563646563636464656363636465636363656365636365636364636564636363636465656364636363646563656363656465656563646565646564646564636565636565656464636564656563646565646364636364656564646363636465646365636463636465656563646364646565646365636363636363636464656564636565646464636363656563636363636563636365656465636563646563656565646465656365656363646363656464636565646563636564646564646463636363656464656563636565636
[jira] [Comment Edited] (CASSANDRA-15313) Fix flaky - ChecksummingTransformerTest - org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031849#comment-17031849
]
David Capwell edited comment on CASSANDRA-15313 at 2/6/20 6:54 PM:
---
With my new patch I get the following failure
{code}
java.lang.AssertionError: Property falsified after 4675 example(s)
Smallest found falsifying value(s) :-
{(6364636563646464636365656365636565636564656463636565636464656563656565646364646363646563646363646363656464636465656364636365656564636365636565636463646565636463636364656365646363656563656365636464646464646464646363646464656463636463646564636464646363656464636364646363646365636365646463656465636565646465656464636364646364646565636564656563656563646563636565646563636563646565636363636563656364646363656564656364646463636364646565656363656464636564646463656463656363636565656563646364656363636565636363656363636563636464636364636464636363646564646563646465636564636464636365646465636565636363646564656463646565646364636565636464636365656463636464656364646564636464636465636563656365636563646464646563646564646564656463646563636465656364646565646465656363636363636563656363656563636364646363646464656564656364646364636563656465636563646463646364656365636464656364636564646465646465646564656363656464656563636565646564646565656363636465646463656463646365656463636363646563656365656363636563646465636563636464636363636363656364646365656363636365646364656364636565646363646564656363656464656563656465636365636465656364656364656564636465646464646464646365636365646465646463656363636465636464656564646464646464636464636363646564646365656565636564646564636364636363656565636365656465636363646363656564636563656363636365646564656564646463636364656463636364636464636464646565656463656365636565636363636564636564656463656363646365636363646465646464636464636564636563646463646363646364656364636365646363656465636365646465646563636463646363636465646465646463636463646364646463636464656363636464656565656365656364646565656564636563636565636465636363636364646465646363646463646564646465656464636563636363636363656365656563656365656363656563646364646365636364636463646464646565646463646465656364646463656463646364636465636463656363646364636463656365636364636363636364636365636364646364646465636365646465656463636<...>636364646363636565646365646463636363636563646363656464646364646364636364656363646363656463636363656363636563646563636563656363656363646363636363636363646363646563636363646365636363636465656463636363646363636563636463656363636365656363656364646363646365636463646363636363646363646463636463636363636365636363636363646363636363636363636365636464646363636565636363646363636363636363636364636365656364656363636463636363636363636365636463656563656364646365636564636364656364646363636364636463656463636363636365646364636565656363636363636365636563646363656365636364656364646363636363646564636563636464636363656363646363636363636364636563636363636563636363656463636363636363636363656363636363636463636365656363636364636464656463646363646364636463636363636363636363636465646464636363646363636363646563636463636563636563636463646563656463636463636463636565646363646363636463636363636563636363636463656463656364646363636365636363636364636364636563656364646463646363646363636563636363646364646563636365636364636365636363636565636364646465636363636364646363636365656363656464646363636363646463636464636364656363636464656363636563636364646363636363636463646364636365636363646363646363636463656463646564636364646363636463636463636363636363636364636564636464656363636463646363636364636363636363646363646464636363646363636464636464636363636365646364646563656563656363646563636364636363636364646365636363656463646363636363636364636363646363636365646365646363646364646363636363636565656463646363656363646364636363636365636363646365646363636363636363636564636565646463636563646465646463636463636363656365646364636465636463646563636364646363636463636563646363646365646364646363636363656365636363636363636364636563636363656364656463646363636463636363636563636463656365636363636363646364656363636363636365636563636364646363636463636465636463656464646563646363656564656463646563656363636463656464636364636563,72535),
14, org.apache.cassandra.transport.frame.compress.SnappyCompressor@4b41dd5c,
ADLER32}
Seed was 113149736037976
{code}
and
{code}
java.lang.AssertionError: Property falsified after 21514 example(s)
Smallest found falsifying value(s) :-
{(6364636564656464636364656365636563646465636563646464656563636564656464656563646563636464656363636465636363656365636365636364636564636363636465656364636363646563656363656465656563646565646564646564636565636565656464636564656563646565646364636364656564646363636465646365636463636465656563646364646565646365636363636363636464656564636565646464636363656563636363636563636365656465636563646563656565646465656365656363646363656464636565646563636564646564646463636363656464656563636565636
[jira] [Commented] (CASSANDRA-10190) Python 3 support for cqlsh
[ https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031857#comment-17031857 ] Dinesh Joshi commented on CASSANDRA-10190: -- [~jaikiran], http://cassandra.apache.org/doc/latest/development/ide.html#building-from-source > Python 3 support for cqlsh > -- > > Key: CASSANDRA-10190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10190 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Tools >Reporter: Andrew Pennebaker >Assignee: Patrick Bannister >Priority: Normal > Labels: cqlsh, pull-request-available > Fix For: 4.0, 4.0-alpha > > Attachments: > 0001-Fix-issues-from-version-specific-logic-commit.patch, > 0001-Update-six-to-1.12.0.patch, > 0002-Simplify-version-specific-logic-by-using-six.moves-a.patch, > coverage_notes.txt > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Users who operate in a Python 3 environment may have trouble launching cqlsh. > Could we please update cqlsh's syntax to run in Python 3? > As a workaround, users can setup pyenv, and cd to a directory with a > .python-version containing "2.7". But it would be nice if cqlsh supported > modern Python versions out of the box. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15313) Fix flaky - ChecksummingTransformerTest - org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031849#comment-17031849
]
David Capwell commented on CASSANDRA-15313:
---
With my new patch I get the following failure
{code}
java.lang.AssertionError: Property falsified after 4675 example(s)
Smallest found falsifying value(s) :-
{(6364636563646464636365656365636565636564656463636565636464656563656565646364646363646563646363646363656464636465656364636365656564636365636565636463646565636463636364656365646363656563656365636464646464646464646363646464656463636463646564636464646363656464636364646363646365636365646463656465636565646465656464636364646364646565636564656563656563646563636565646563636563646565636363636563656364646363656564656364646463636364646565656363656464636564646463656463656363636565656563646364656363636565636363656363636563636464636364636464636363646564646563646465636564636464636365646465636565636363646564656463646565646364636565636464636365656463636464656364646564636464636465636563656365636563646464646563646564646564656463646563636465656364646565646465656363636363636563656363656563636364646363646464656564656364646364636563656465636563646463646364656365636464656364636564646465646465646564656363656464656563636565646564646565656363636465646463656463646365656463636363646563656365656363636563646465636563636464636363636363656364646365656363636365646364656364636565646363646564656363656464656563656465636365636465656364656364656564636465646464646464646365636365646465646463656363636465636464656564646464646464636464636363646564646365656565636564646564636364636363656565636365656465636363646363656564636563656363636365646564656564646463636364656463636364636464636464646565656463656365636565636363636564636564656463656363646365636363646465646464636464636564636563646463646363646364656364636365646363656465636365646465646563636463646363636465646465646463636463646364646463636464656363636464656565656365656364646565656564636563636565636465636363636364646465646363646463646564646465656464636563636363636363656365656563656365656363656563646364646365636364636463646464646565646463646465656364646463656463646364636465636463656363646364636463656365636364636363636364636365636364646364646465636365646465656463636<...>636364646363636565646365646463636363636563646363656464646364646364636364656363646363656463636363656363636563646563636563656363656363646363636363636363646363646563636363646365636363636465656463636363646363636563636463656363636365656363656364646363646365636463646363636363646363646463636463636363636365636363636363646363636363636363636365636464646363636565636363646363636363636363636364636365656364656363636463636363636363636365636463656563656364646365636564636364656364646363636364636463656463636363636365646364636565656363636363636365636563646363656365636364656364646363636363646564636563636464636363656363646363636363636364636563636363636563636363656463636363636363636363656363636363636463636365656363636364636464656463646363646364636463636363636363636363636465646464636363646363636363646563636463636563636563636463646563656463636463636463636565646363646363636463636363636563636363636463656463656364646363636365636363636364636364636563656364646463646363646363636563636363646364646563636365636364636365636363636565636364646465636363636364646363636365656363656464646363636363646463636464636364656363636464656363636563636364646363636363636463646364636365636363646363646363636463656463646564636364646363636463636463636363636363636364636564636464656363636463646363636364636363636363646363646464636363646363636464636464636363636365646364646563656563656363646563636364636363636364646365636363656463646363636363636364636363646363636365646365646363646364646363636363636565656463646363656363646364636363636365636363646365646363636363636363636564636565646463636563646465646463636463636363656365646364636465636463646563636364646363636463636563646363646365646364646363636363656365636363636363636364636563636363656364656463646363636463636363636563636463656365636363636363646364656363636363636365636563636364646363636463636465636463656464646563646363656564656463646563656363636463656464636364636563,72535),
14, org.apache.cassandra.transport.frame.compress.SnappyCompressor@4b41dd5c,
ADLER32}
Seed was 113149736037976
{code}
Im trying to get the data for the core dump, but made the test stop having GC
issues (didn't fix the fact the test is finding failures)
> Fix flaky - ChecksummingTransformerTest -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> ---
>
> Key: CASSANDRA-15313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15313
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Vinay Chella
>Assignee: B
[jira] [Commented] (CASSANDRA-15313) Fix flaky - ChecksummingTransformerTest - org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031819#comment-17031819
]
David Capwell commented on CASSANDRA-15313:
---
The root change was that I didn't follow the style of
{code}
private Gen inputs()
{
Gen randomStrings =
strings().basicMultilingualPlaneAlphabet().ofLengthBetween(0, MAX_INPUT_SIZE);
Gen highlyCompressable = strings().betweenCodePoints('c',
'e').ofLengthBetween(1, MAX_INPUT_SIZE);
return randomStrings.mix(highlyCompressable, 50);
}
{code}
instead my first patch was basically the same as randomStrings. If you run
with just randomStrings you don't see this after a ton of runs. If you run
with highlyCompressable you will eventually see this.
After changing the byte generator to follow this range of bytes I was able to
hit it every run...
> Fix flaky - ChecksummingTransformerTest -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> ---
>
> Key: CASSANDRA-15313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15313
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Vinay Chella
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0-alpha
>
> Attachments: CASSANDRA-15313-hack.patch
>
>
> During the recent runs, this test appears to be flaky.
> Example failure:
> [https://circleci.com/gh/vinaykumarchella/cassandra/459#tests/containers/94]
> corruptionCausesFailure-compression -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> {code:java}
> java.lang.OutOfMemoryError: GC overhead limit exceeded
> at java.nio.HeapByteBuffer.(HeapByteBuffer.java:57)
> at java.nio.ByteBuffer.allocate(ByteBuffer.java:335)
> at org.quicktheories.impl.Precursor.(Precursor.java:17)
> at
> org.quicktheories.impl.ConcreteDetachedSource.(ConcreteDetachedSource.java:8)
> at
> org.quicktheories.impl.ConcreteDetachedSource.detach(ConcreteDetachedSource.java:23)
> at org.quicktheories.generators.Retry.generate(CodePoints.java:51)
> at
> org.quicktheories.generators.Generate.lambda$intArrays$10(Generate.java:190)
> at
> org.quicktheories.generators.Generate$$Lambda$17/1847008471.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$mix$10(Gen.java:184)
> at org.quicktheories.core.Gen$$Lambda$45/802243390.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$flatMap$5(Gen.java:93)
> at org.quicktheories.core.Gen$$Lambda$48/363509958.generate(Unknown
> Source)
> at
> org.quicktheories.dsl.TheoryBuilder4.lambda$prgnToTuple$12(TheoryBuilder4.java:188)
> at
> org.quicktheories.dsl.TheoryBuilder4$$Lambda$40/2003496028.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.FilteredGenerator.generate(Gen.java:225)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.impl.Core.generate(Core.java:150)
> at org.quicktheories.impl.Core.shrink(Core.java:103)
> at org.quicktheories.impl.Core.run(Core.java:39)
> at org.quicktheories.impl.TheoryRunner.check(TheoryRunner.java:35)
> at org.quicktheories.dsl.TheoryBuilder4.check(TheoryBuilder4.java:150)
> at
> org.quicktheories.dsl.TheoryBuilder4.checkAssert(TheoryBuilder4.java:162)
> at
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest.corruptionCausesFailure(ChecksummingTransformerTest.java:87)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15313) Fix flaky - ChecksummingTransformerTest - org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031818#comment-17031818
]
David Capwell commented on CASSANDRA-15313:
---
ok, have a new version of the patch which is able to hit the failure case, but
we went from "flaky" to "every single run"... progress? =D
> Fix flaky - ChecksummingTransformerTest -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> ---
>
> Key: CASSANDRA-15313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15313
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Vinay Chella
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0-alpha
>
> Attachments: CASSANDRA-15313-hack.patch
>
>
> During the recent runs, this test appears to be flaky.
> Example failure:
> [https://circleci.com/gh/vinaykumarchella/cassandra/459#tests/containers/94]
> corruptionCausesFailure-compression -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> {code:java}
> java.lang.OutOfMemoryError: GC overhead limit exceeded
> at java.nio.HeapByteBuffer.(HeapByteBuffer.java:57)
> at java.nio.ByteBuffer.allocate(ByteBuffer.java:335)
> at org.quicktheories.impl.Precursor.(Precursor.java:17)
> at
> org.quicktheories.impl.ConcreteDetachedSource.(ConcreteDetachedSource.java:8)
> at
> org.quicktheories.impl.ConcreteDetachedSource.detach(ConcreteDetachedSource.java:23)
> at org.quicktheories.generators.Retry.generate(CodePoints.java:51)
> at
> org.quicktheories.generators.Generate.lambda$intArrays$10(Generate.java:190)
> at
> org.quicktheories.generators.Generate$$Lambda$17/1847008471.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$mix$10(Gen.java:184)
> at org.quicktheories.core.Gen$$Lambda$45/802243390.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$flatMap$5(Gen.java:93)
> at org.quicktheories.core.Gen$$Lambda$48/363509958.generate(Unknown
> Source)
> at
> org.quicktheories.dsl.TheoryBuilder4.lambda$prgnToTuple$12(TheoryBuilder4.java:188)
> at
> org.quicktheories.dsl.TheoryBuilder4$$Lambda$40/2003496028.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.FilteredGenerator.generate(Gen.java:225)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.impl.Core.generate(Core.java:150)
> at org.quicktheories.impl.Core.shrink(Core.java:103)
> at org.quicktheories.impl.Core.run(Core.java:39)
> at org.quicktheories.impl.TheoryRunner.check(TheoryRunner.java:35)
> at org.quicktheories.dsl.TheoryBuilder4.check(TheoryBuilder4.java:150)
> at
> org.quicktheories.dsl.TheoryBuilder4.checkAssert(TheoryBuilder4.java:162)
> at
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest.corruptionCausesFailure(ChecksummingTransformerTest.java:87)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15313) Fix flaky - ChecksummingTransformerTest - org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031783#comment-17031783
]
Brandon Williams commented on CASSANDRA-15313:
--
bq. Is this your finding?
Yes, that matches what I see (or sometimes the jvm segfaults in LZ4). Your
patch with 500 examples added back in corruptionCausesFailure passes
consistently.
> Fix flaky - ChecksummingTransformerTest -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> ---
>
> Key: CASSANDRA-15313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15313
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Vinay Chella
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0-alpha
>
> Attachments: CASSANDRA-15313-hack.patch
>
>
> During the recent runs, this test appears to be flaky.
> Example failure:
> [https://circleci.com/gh/vinaykumarchella/cassandra/459#tests/containers/94]
> corruptionCausesFailure-compression -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> {code:java}
> java.lang.OutOfMemoryError: GC overhead limit exceeded
> at java.nio.HeapByteBuffer.(HeapByteBuffer.java:57)
> at java.nio.ByteBuffer.allocate(ByteBuffer.java:335)
> at org.quicktheories.impl.Precursor.(Precursor.java:17)
> at
> org.quicktheories.impl.ConcreteDetachedSource.(ConcreteDetachedSource.java:8)
> at
> org.quicktheories.impl.ConcreteDetachedSource.detach(ConcreteDetachedSource.java:23)
> at org.quicktheories.generators.Retry.generate(CodePoints.java:51)
> at
> org.quicktheories.generators.Generate.lambda$intArrays$10(Generate.java:190)
> at
> org.quicktheories.generators.Generate$$Lambda$17/1847008471.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$mix$10(Gen.java:184)
> at org.quicktheories.core.Gen$$Lambda$45/802243390.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$flatMap$5(Gen.java:93)
> at org.quicktheories.core.Gen$$Lambda$48/363509958.generate(Unknown
> Source)
> at
> org.quicktheories.dsl.TheoryBuilder4.lambda$prgnToTuple$12(TheoryBuilder4.java:188)
> at
> org.quicktheories.dsl.TheoryBuilder4$$Lambda$40/2003496028.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.FilteredGenerator.generate(Gen.java:225)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.impl.Core.generate(Core.java:150)
> at org.quicktheories.impl.Core.shrink(Core.java:103)
> at org.quicktheories.impl.Core.run(Core.java:39)
> at org.quicktheories.impl.TheoryRunner.check(TheoryRunner.java:35)
> at org.quicktheories.dsl.TheoryBuilder4.check(TheoryBuilder4.java:150)
> at
> org.quicktheories.dsl.TheoryBuilder4.checkAssert(TheoryBuilder4.java:162)
> at
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest.corruptionCausesFailure(ChecksummingTransformerTest.java:87)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15313) Fix flaky - ChecksummingTransformerTest - org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031775#comment-17031775
]
David Capwell commented on CASSANDRA-15313:
---
In slack [~aleksey] pointed out that this is a known issue and called out in
CASSANDRA-15299
> Fix flaky - ChecksummingTransformerTest -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> ---
>
> Key: CASSANDRA-15313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15313
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Vinay Chella
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0-alpha
>
> Attachments: CASSANDRA-15313-hack.patch
>
>
> During the recent runs, this test appears to be flaky.
> Example failure:
> [https://circleci.com/gh/vinaykumarchella/cassandra/459#tests/containers/94]
> corruptionCausesFailure-compression -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> {code:java}
> java.lang.OutOfMemoryError: GC overhead limit exceeded
> at java.nio.HeapByteBuffer.(HeapByteBuffer.java:57)
> at java.nio.ByteBuffer.allocate(ByteBuffer.java:335)
> at org.quicktheories.impl.Precursor.(Precursor.java:17)
> at
> org.quicktheories.impl.ConcreteDetachedSource.(ConcreteDetachedSource.java:8)
> at
> org.quicktheories.impl.ConcreteDetachedSource.detach(ConcreteDetachedSource.java:23)
> at org.quicktheories.generators.Retry.generate(CodePoints.java:51)
> at
> org.quicktheories.generators.Generate.lambda$intArrays$10(Generate.java:190)
> at
> org.quicktheories.generators.Generate$$Lambda$17/1847008471.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$mix$10(Gen.java:184)
> at org.quicktheories.core.Gen$$Lambda$45/802243390.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$flatMap$5(Gen.java:93)
> at org.quicktheories.core.Gen$$Lambda$48/363509958.generate(Unknown
> Source)
> at
> org.quicktheories.dsl.TheoryBuilder4.lambda$prgnToTuple$12(TheoryBuilder4.java:188)
> at
> org.quicktheories.dsl.TheoryBuilder4$$Lambda$40/2003496028.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.FilteredGenerator.generate(Gen.java:225)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.impl.Core.generate(Core.java:150)
> at org.quicktheories.impl.Core.shrink(Core.java:103)
> at org.quicktheories.impl.Core.run(Core.java:39)
> at org.quicktheories.impl.TheoryRunner.check(TheoryRunner.java:35)
> at org.quicktheories.dsl.TheoryBuilder4.check(TheoryBuilder4.java:150)
> at
> org.quicktheories.dsl.TheoryBuilder4.checkAssert(TheoryBuilder4.java:162)
> at
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest.corruptionCausesFailure(ChecksummingTransformerTest.java:87)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15494) Support additional Jar url scheme
[
https://issues.apache.org/jira/browse/CASSANDRA-15494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031773#comment-17031773
]
Brandon Williams commented on CASSANDRA-15494:
--
I don't see any reason not to use the second version.
> Support additional Jar url scheme
> -
>
> Key: CASSANDRA-15494
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15494
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Other
>Reporter: Gus Heck
>Assignee: Gus Heck
>Priority: Normal
> Attachments: CASSANDRA-15494.patch, CASSANDRA-15494.patch
>
>
> This code in ThreadAwareSecurityManager causes issues for embedded cassandra
> launched from a one-jar or uno-jar.
> {code:java}
> switch (codesource.getLocation().getProtocol())
> {
> case "file":
> // All JARs and class files reside on the file system
> - we can safely
> // assume that these classes are "good".
> return true;
> }
> {code}
> Attaching patch to support protocol of 'jar' as well. AFAICT this won't
> introduce any added risk for UDF's discussed in CASSANDRA-9402 since a jar
> (or one/uno jar) must also be on the filesystem.
> New code would be (in 2 places):
> {code:java}
> switch (codesource.getLocation().getProtocol())
> {
> case "jar":
> case "file":
> // All JARs and class files reside on the file system
> - we can safely
> // assume that these classes are "good".
> return true;
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15313) Fix flaky - ChecksummingTransformerTest - org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031759#comment-17031759
]
David Capwell edited comment on CASSANDRA-15313 at 2/6/20 5:00 PM:
---
The output from quick theories doesn't work in isolation; the way the string is
generated then converted to bytes ins't reproducible without relying on the
seed to create the same string. I changed the text to print out the hex of the
bytes and when you run with those bytes the test fails
Here is the hex for the bytes failing
{code}
646365636465636364636463636564636564636465646463636363656465656464656565646365636465656463646565636563636365636565656363646365636564646565656465636465636563646465636465646563636363636564636564636463636363636564646563636465636465636563646464636365646463646565636363636364646364656463646564636464656365636365656565646465646465636365646565646564646364646464656365636364636364656565646363646565636563656563636365646463646464656463646464636465656464646463646364646563646564656364656465636564636465646463656365646565646465636464636363636564636464646463646363656564636565656363636565646564636565646463656463646463646464636463636465646565656563656465636564656564636563636565646463656363636365656365636464636463656465646564656564636565646363646565636464636563636364636365646565646563656365646363646565656365646563656565656465636563646565636564636363636563636564636464646463656363636365636463636365636364636565646564646565636565656463656363656363636563636564656564646364636464646365636365646364646564646565646364636563646463636464646364656564636364636563656365646365646564636463646465646364646364636464646363646565636565636463656565636564636563646365646465646463646363646463636565636464656365646365656463646565636464636364646464656364656463656463636563656463646465646463636563646463636364656363646363646365646364646563646563636463656365636465656564646563646464636564636465656563636365646364656464656464646364646565636565636365656465656363646463636363636563646563646363636363636364656363646463656363646365656563646463656565646465656365636465636563646365646465636365636465656565646464646365646365646463656565656365656465656464656364646465656565646565636363646563636364646465646465646365656465646564646365636364636564656364656363636365636365636463636363636465636565656565656463656463646465646464656464636465646565656364656564656464656464646365656465646364636465656465636464636364646464636465646365646563646365656565656464646464636565636563636464636364646463646563656564646564656564646465656463636463656463656364636563646465636564656563636464636465636465646365646565656465656365656565646465636563636563656565636563656364656364646364636564656563656565656365636565636365656463636464646564646565636465646364646464646565646465646365636465646365656363636565636464646464636463646564636563656564656564656363646464656464646465656364636363656565646463656563656464656563636563636363656563636463656363636463656365656565636465656363646464646564656463656565656465656564656463656564646463646364646563646365636365636563636563656564636364636563646465646363656464656364646564656565656563656463656565656563646563636465636364656363636565636363646465636363646463646364656465656564646563646463636564646363636364636564656363636364646563656564636565636463646565646563656364636463646565646565636464656465636465646364636463636363656563656364656565656364646564636363656363636364636465636464636365636363646563646565636464636465646363636463636365636464646365646363636465636463636365636363656564636564636465656363656563636364636364656463656563656564656565636463656463646463636364636563646564656465636364636564646364646465646365656465646463646564636465656363656364646364646363646464646364636465656363636564656365636365636365656565656565646365636564656463656364646463656363636563656363646463656365636464636364656364656365636363646564636463646465636563646364646463656463646465636564636564656464656464646564656465656465636565636565636565646363636465656464656564646563636565636464636363646565646463656364656563656563646565656463646363646565636464656464636564646565646565656363636365656563646563656564646365646465636563646464656565656363656564656364656365656464646565636564646364656363636465646564646365646365656464656563636465636565656364646564646563646564656565636364646465646463656563646564646565656365646463656564656463646365656463656563646365636365646563656465636564646464656465636564646564656463656365646464646463656465646465646464636465646464656563656564636463636564656364646564656364646365656464636563656564646464656463646363656363646463646563646465636564636463656364646564646565646465646565646565656363656464636364656563646565646365636465636365656363646365636364636364646565646463636563646364656365636564646465636463656465636363636463636463656564656564656364656365646565656563636465636365656365656563636463636464656563656364656464636464636364636565656464636564646563646464646464636
[jira] [Commented] (CASSANDRA-15313) Fix flaky - ChecksummingTransformerTest - org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031759#comment-17031759
]
David Capwell commented on CASSANDRA-15313:
---
The output from quick theories doesn't work in isolation; the way the string is
generated then converted to bytes ins't reproducible without relying on the
seed to create the same string. I changed the text to print out the hex of the
bytes and when you run with those bytes the test fails
Here is the hex for the bytes failing
{code}
64636563646563636463646363656463656463646564646363636365646565646465656564636563646565646364656563656363636563656565636364636563656464656565646563646563656364646563646564656363636363656463656463646363636363656464656363646563646563656364646463636564646364656563636363636464636465646364656463646465636563636565656564646564646563636564656564656464636464646465636563636463636465656564636364656563656365656363636564646364646465646364646463646565646464646364636464656364656465636465646563656463646564646365636564656564646563646463636363656463646464646364636365656463656565636363656564656463656564646365646364646364646463646363646564656565656365646563656465656463656363656564646365636363636565636563646463646365646564656465656463656564636364656563646463656363636463636564656564656365636564636364656565636564656365656565646563656364656563656463636363656363656463646464646365636363636563646363636563636463656564656464656563656565646365636365636363656363656465656464636463646464636563636564636464656464656564636463656364646363646464636465656463636463656365636564636564656463646364646564636464636463646464636364656563656563646365656563656463656364636564646564646364636364646363656563646465636564636565646364656563646463636464646465636465646365646363656365646364646564646363656364646363636465636364636364636564636464656364656363646365636563646565656464656364646463656463646565656363636564636465646465646464636464656563656563636565646565636364646363636363656364656364636363636363636465636364646365636364636565656364646365656564646565636563646563656364636564646563636563646565656564646464636564636564646365656565636565646565646465636464646565656564656563636364656363636464646564646564636565646564656464636563636463656465636465636363636563636563646363636363646563656565656565646365646364646564646465646463646564656565636465656465646465646464636565646564636463646565646563646463636464646463646564636564656364636565656565646464646463656563656363646463636464646364656365656464656465656464646565646363646365646365636463656364646563656465656363646463646563646564636564656565646565636565656564646563656363656365656563656365636465636464636463656465656365656565636563656563636565646363646464656464656563646564636464646464656564646564636563646564636565636363656563646464646463646364656463656365656465656465636364646465646464646565636463636365656564646365656365646465656363656363636365656363646365636363646365636565656563646565636364646464656465646365656565646565656465646365656464646364636464656364636563636563656363656365656463636463656364646564636365646465636464656465656565656365646365656565656364656363646563636465636363656563636364646563636364646364636465646565656464656364646363656464636363636463656465636363636464656365656463656563646364656564656365636463646364656564656563646465646563646564636463646363636365656365636465656565636464656463636365636363636463646563646463636563636364656364656563646463646564636363646363636563646464636564636363646563646363636563636365656463656463646565636365656363636463636465646365656365656465656563646365646364646363636463656364656465646563636463656464636464646564636565646564646364656463646565636365636464636464636364646464636463646565636363656465636563636563636565656565656564636563656465646365636464646365636363656365636364646365636563646463636465636465636563636364656463646364646563656364636464646365646364646563656463656465646465646464656465646565646563656563656563656564636363646565646465656464656363656563646463636364656564646365636465656365656364656565646364636364656563646465646463656464656564656565636363636565656364656365656464636564646563656364646465656565636365656465636465636565646464656563656464636465636363646564656464636564636565646465656363646563656565636464656464656364656465656563636464646564646365656364656464656565636564646365656465646364636565646365656364636563636564656365646563656464646465646563656464656465646365636564646464646365646564646564646463646564646465656365656463646363656465636464656465636464636565646463656365656464646465646364636365636364646364656364646563656463646365636464656464656564646564656564656565636365646463636465656364656564636563646563636565636364636563636463636464656564646363656364636465636563656464646563646365646563636363646363646365656465656465636465636564656565656363646563636565636565656363646363646465656365636465646463646463636463656565646463656464656364646464646463636364656565646565656364656463636363656365656363
[jira] [Commented] (CASSANDRA-15494) Support additional Jar url scheme
[
https://issues.apache.org/jira/browse/CASSANDRA-15494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031742#comment-17031742
]
Gus Heck commented on CASSANDRA-15494:
--
Sorry just noticed I uploaded the wrong patch last time, now switched it out.
> Support additional Jar url scheme
> -
>
> Key: CASSANDRA-15494
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15494
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Other
>Reporter: Gus Heck
>Assignee: Gus Heck
>Priority: Normal
> Attachments: CASSANDRA-15494.patch, CASSANDRA-15494.patch
>
>
> This code in ThreadAwareSecurityManager causes issues for embedded cassandra
> launched from a one-jar or uno-jar.
> {code:java}
> switch (codesource.getLocation().getProtocol())
> {
> case "file":
> // All JARs and class files reside on the file system
> - we can safely
> // assume that these classes are "good".
> return true;
> }
> {code}
> Attaching patch to support protocol of 'jar' as well. AFAICT this won't
> introduce any added risk for UDF's discussed in CASSANDRA-9402 since a jar
> (or one/uno jar) must also be on the filesystem.
> New code would be (in 2 places):
> {code:java}
> switch (codesource.getLocation().getProtocol())
> {
> case "jar":
> case "file":
> // All JARs and class files reside on the file system
> - we can safely
> // assume that these classes are "good".
> return true;
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15494) Support additional Jar url scheme
[
https://issues.apache.org/jira/browse/CASSANDRA-15494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gus Heck updated CASSANDRA-15494:
-
Attachment: CASSANDRA-15494.patch
> Support additional Jar url scheme
> -
>
> Key: CASSANDRA-15494
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15494
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Other
>Reporter: Gus Heck
>Assignee: Gus Heck
>Priority: Normal
> Attachments: CASSANDRA-15494.patch, CASSANDRA-15494.patch
>
>
> This code in ThreadAwareSecurityManager causes issues for embedded cassandra
> launched from a one-jar or uno-jar.
> {code:java}
> switch (codesource.getLocation().getProtocol())
> {
> case "file":
> // All JARs and class files reside on the file system
> - we can safely
> // assume that these classes are "good".
> return true;
> }
> {code}
> Attaching patch to support protocol of 'jar' as well. AFAICT this won't
> introduce any added risk for UDF's discussed in CASSANDRA-9402 since a jar
> (or one/uno jar) must also be on the filesystem.
> New code would be (in 2 places):
> {code:java}
> switch (codesource.getLocation().getProtocol())
> {
> case "jar":
> case "file":
> // All JARs and class files reside on the file system
> - we can safely
> // assume that these classes are "good".
> return true;
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15494) Support additional Jar url scheme
[
https://issues.apache.org/jira/browse/CASSANDRA-15494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gus Heck updated CASSANDRA-15494:
-
Attachment: (was: CASSANDRA-15494.patch)
> Support additional Jar url scheme
> -
>
> Key: CASSANDRA-15494
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15494
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Other
>Reporter: Gus Heck
>Assignee: Gus Heck
>Priority: Normal
> Attachments: CASSANDRA-15494.patch
>
>
> This code in ThreadAwareSecurityManager causes issues for embedded cassandra
> launched from a one-jar or uno-jar.
> {code:java}
> switch (codesource.getLocation().getProtocol())
> {
> case "file":
> // All JARs and class files reside on the file system
> - we can safely
> // assume that these classes are "good".
> return true;
> }
> {code}
> Attaching patch to support protocol of 'jar' as well. AFAICT this won't
> introduce any added risk for UDF's discussed in CASSANDRA-9402 since a jar
> (or one/uno jar) must also be on the filesystem.
> New code would be (in 2 places):
> {code:java}
> switch (codesource.getLocation().getProtocol())
> {
> case "jar":
> case "file":
> // All JARs and class files reside on the file system
> - we can safely
> // assume that these classes are "good".
> return true;
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15494) Support additional Jar url scheme
[
https://issues.apache.org/jira/browse/CASSANDRA-15494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031741#comment-17031741
]
Gus Heck commented on CASSANDRA-15494:
--
[~brandon.williams] ok will open PR shortly, which version is preferable?
> Support additional Jar url scheme
> -
>
> Key: CASSANDRA-15494
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15494
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Other
>Reporter: Gus Heck
>Assignee: Gus Heck
>Priority: Normal
> Attachments: CASSANDRA-15494.patch, CASSANDRA-15494.patch
>
>
> This code in ThreadAwareSecurityManager causes issues for embedded cassandra
> launched from a one-jar or uno-jar.
> {code:java}
> switch (codesource.getLocation().getProtocol())
> {
> case "file":
> // All JARs and class files reside on the file system
> - we can safely
> // assume that these classes are "good".
> return true;
> }
> {code}
> Attaching patch to support protocol of 'jar' as well. AFAICT this won't
> introduce any added risk for UDF's discussed in CASSANDRA-9402 since a jar
> (or one/uno jar) must also be on the filesystem.
> New code would be (in 2 places):
> {code:java}
> switch (codesource.getLocation().getProtocol())
> {
> case "jar":
> case "file":
> // All JARs and class files reside on the file system
> - we can safely
> // assume that these classes are "good".
> return true;
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15494) Support additional Jar url scheme
[
https://issues.apache.org/jira/browse/CASSANDRA-15494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031738#comment-17031738
]
Gus Heck commented on CASSANDRA-15494:
--
Added a slightly more conservative patch in case that helps. Either one works.
> Support additional Jar url scheme
> -
>
> Key: CASSANDRA-15494
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15494
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Other
>Reporter: Gus Heck
>Assignee: Gus Heck
>Priority: Normal
> Attachments: CASSANDRA-15494.patch, CASSANDRA-15494.patch
>
>
> This code in ThreadAwareSecurityManager causes issues for embedded cassandra
> launched from a one-jar or uno-jar.
> {code:java}
> switch (codesource.getLocation().getProtocol())
> {
> case "file":
> // All JARs and class files reside on the file system
> - we can safely
> // assume that these classes are "good".
> return true;
> }
> {code}
> Attaching patch to support protocol of 'jar' as well. AFAICT this won't
> introduce any added risk for UDF's discussed in CASSANDRA-9402 since a jar
> (or one/uno jar) must also be on the filesystem.
> New code would be (in 2 places):
> {code:java}
> switch (codesource.getLocation().getProtocol())
> {
> case "jar":
> case "file":
> // All JARs and class files reside on the file system
> - we can safely
> // assume that these classes are "good".
> return true;
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15494) Support additional Jar url scheme
[
https://issues.apache.org/jira/browse/CASSANDRA-15494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gus Heck updated CASSANDRA-15494:
-
Attachment: CASSANDRA-15494.patch
> Support additional Jar url scheme
> -
>
> Key: CASSANDRA-15494
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15494
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Other
>Reporter: Gus Heck
>Assignee: Gus Heck
>Priority: Normal
> Attachments: CASSANDRA-15494.patch, CASSANDRA-15494.patch
>
>
> This code in ThreadAwareSecurityManager causes issues for embedded cassandra
> launched from a one-jar or uno-jar.
> {code:java}
> switch (codesource.getLocation().getProtocol())
> {
> case "file":
> // All JARs and class files reside on the file system
> - we can safely
> // assume that these classes are "good".
> return true;
> }
> {code}
> Attaching patch to support protocol of 'jar' as well. AFAICT this won't
> introduce any added risk for UDF's discussed in CASSANDRA-9402 since a jar
> (or one/uno jar) must also be on the filesystem.
> New code would be (in 2 places):
> {code:java}
> switch (codesource.getLocation().getProtocol())
> {
> case "jar":
> case "file":
> // All JARs and class files reside on the file system
> - we can safely
> // assume that these classes are "good".
> return true;
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15313) Fix flaky - ChecksummingTransformerTest - org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031734#comment-17031734
]
David Capwell commented on CASSANDRA-15313:
---
bq. I'm not suggesting that, I only kept it to demonstrate the failure that is
possibly an LZ4 bug.
ok, sounds like we are on the same page =)
> Fix flaky - ChecksummingTransformerTest -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> ---
>
> Key: CASSANDRA-15313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15313
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Vinay Chella
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0-alpha
>
> Attachments: CASSANDRA-15313-hack.patch
>
>
> During the recent runs, this test appears to be flaky.
> Example failure:
> [https://circleci.com/gh/vinaykumarchella/cassandra/459#tests/containers/94]
> corruptionCausesFailure-compression -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> {code:java}
> java.lang.OutOfMemoryError: GC overhead limit exceeded
> at java.nio.HeapByteBuffer.(HeapByteBuffer.java:57)
> at java.nio.ByteBuffer.allocate(ByteBuffer.java:335)
> at org.quicktheories.impl.Precursor.(Precursor.java:17)
> at
> org.quicktheories.impl.ConcreteDetachedSource.(ConcreteDetachedSource.java:8)
> at
> org.quicktheories.impl.ConcreteDetachedSource.detach(ConcreteDetachedSource.java:23)
> at org.quicktheories.generators.Retry.generate(CodePoints.java:51)
> at
> org.quicktheories.generators.Generate.lambda$intArrays$10(Generate.java:190)
> at
> org.quicktheories.generators.Generate$$Lambda$17/1847008471.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$mix$10(Gen.java:184)
> at org.quicktheories.core.Gen$$Lambda$45/802243390.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$flatMap$5(Gen.java:93)
> at org.quicktheories.core.Gen$$Lambda$48/363509958.generate(Unknown
> Source)
> at
> org.quicktheories.dsl.TheoryBuilder4.lambda$prgnToTuple$12(TheoryBuilder4.java:188)
> at
> org.quicktheories.dsl.TheoryBuilder4$$Lambda$40/2003496028.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.FilteredGenerator.generate(Gen.java:225)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.impl.Core.generate(Core.java:150)
> at org.quicktheories.impl.Core.shrink(Core.java:103)
> at org.quicktheories.impl.Core.run(Core.java:39)
> at org.quicktheories.impl.TheoryRunner.check(TheoryRunner.java:35)
> at org.quicktheories.dsl.TheoryBuilder4.check(TheoryBuilder4.java:150)
> at
> org.quicktheories.dsl.TheoryBuilder4.checkAssert(TheoryBuilder4.java:162)
> at
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest.corruptionCausesFailure(ChecksummingTransformerTest.java:87)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15313) Fix flaky - ChecksummingTransformerTest - org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031721#comment-17031721
]
Brandon Williams commented on CASSANDRA-15313:
--
bq. Not a huge fan of fixing the seed.
I'm not suggesting that, I only kept it so demonstrate the failure that is
possibly an LZ4 bug.
> Fix flaky - ChecksummingTransformerTest -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> ---
>
> Key: CASSANDRA-15313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15313
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Vinay Chella
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0-alpha
>
> Attachments: CASSANDRA-15313-hack.patch
>
>
> During the recent runs, this test appears to be flaky.
> Example failure:
> [https://circleci.com/gh/vinaykumarchella/cassandra/459#tests/containers/94]
> corruptionCausesFailure-compression -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> {code:java}
> java.lang.OutOfMemoryError: GC overhead limit exceeded
> at java.nio.HeapByteBuffer.(HeapByteBuffer.java:57)
> at java.nio.ByteBuffer.allocate(ByteBuffer.java:335)
> at org.quicktheories.impl.Precursor.(Precursor.java:17)
> at
> org.quicktheories.impl.ConcreteDetachedSource.(ConcreteDetachedSource.java:8)
> at
> org.quicktheories.impl.ConcreteDetachedSource.detach(ConcreteDetachedSource.java:23)
> at org.quicktheories.generators.Retry.generate(CodePoints.java:51)
> at
> org.quicktheories.generators.Generate.lambda$intArrays$10(Generate.java:190)
> at
> org.quicktheories.generators.Generate$$Lambda$17/1847008471.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$mix$10(Gen.java:184)
> at org.quicktheories.core.Gen$$Lambda$45/802243390.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$flatMap$5(Gen.java:93)
> at org.quicktheories.core.Gen$$Lambda$48/363509958.generate(Unknown
> Source)
> at
> org.quicktheories.dsl.TheoryBuilder4.lambda$prgnToTuple$12(TheoryBuilder4.java:188)
> at
> org.quicktheories.dsl.TheoryBuilder4$$Lambda$40/2003496028.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.FilteredGenerator.generate(Gen.java:225)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.impl.Core.generate(Core.java:150)
> at org.quicktheories.impl.Core.shrink(Core.java:103)
> at org.quicktheories.impl.Core.run(Core.java:39)
> at org.quicktheories.impl.TheoryRunner.check(TheoryRunner.java:35)
> at org.quicktheories.dsl.TheoryBuilder4.check(TheoryBuilder4.java:150)
> at
> org.quicktheories.dsl.TheoryBuilder4.checkAssert(TheoryBuilder4.java:162)
> at
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest.corruptionCausesFailure(ChecksummingTransformerTest.java:87)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15313) Fix flaky - ChecksummingTransformerTest - org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031723#comment-17031723
]
Jordan West commented on CASSANDRA-15313:
-
Ah sorry misunderstood. Definitely good to keep that around.
> Fix flaky - ChecksummingTransformerTest -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> ---
>
> Key: CASSANDRA-15313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15313
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Vinay Chella
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0-alpha
>
> Attachments: CASSANDRA-15313-hack.patch
>
>
> During the recent runs, this test appears to be flaky.
> Example failure:
> [https://circleci.com/gh/vinaykumarchella/cassandra/459#tests/containers/94]
> corruptionCausesFailure-compression -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> {code:java}
> java.lang.OutOfMemoryError: GC overhead limit exceeded
> at java.nio.HeapByteBuffer.(HeapByteBuffer.java:57)
> at java.nio.ByteBuffer.allocate(ByteBuffer.java:335)
> at org.quicktheories.impl.Precursor.(Precursor.java:17)
> at
> org.quicktheories.impl.ConcreteDetachedSource.(ConcreteDetachedSource.java:8)
> at
> org.quicktheories.impl.ConcreteDetachedSource.detach(ConcreteDetachedSource.java:23)
> at org.quicktheories.generators.Retry.generate(CodePoints.java:51)
> at
> org.quicktheories.generators.Generate.lambda$intArrays$10(Generate.java:190)
> at
> org.quicktheories.generators.Generate$$Lambda$17/1847008471.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$mix$10(Gen.java:184)
> at org.quicktheories.core.Gen$$Lambda$45/802243390.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$flatMap$5(Gen.java:93)
> at org.quicktheories.core.Gen$$Lambda$48/363509958.generate(Unknown
> Source)
> at
> org.quicktheories.dsl.TheoryBuilder4.lambda$prgnToTuple$12(TheoryBuilder4.java:188)
> at
> org.quicktheories.dsl.TheoryBuilder4$$Lambda$40/2003496028.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.FilteredGenerator.generate(Gen.java:225)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.impl.Core.generate(Core.java:150)
> at org.quicktheories.impl.Core.shrink(Core.java:103)
> at org.quicktheories.impl.Core.run(Core.java:39)
> at org.quicktheories.impl.TheoryRunner.check(TheoryRunner.java:35)
> at org.quicktheories.dsl.TheoryBuilder4.check(TheoryBuilder4.java:150)
> at
> org.quicktheories.dsl.TheoryBuilder4.checkAssert(TheoryBuilder4.java:162)
> at
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest.corruptionCausesFailure(ChecksummingTransformerTest.java:87)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15313) Fix flaky - ChecksummingTransformerTest - org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031721#comment-17031721
]
Brandon Williams edited comment on CASSANDRA-15313 at 2/6/20 4:21 PM:
--
bq. Not a huge fan of fixing the seed.
I'm not suggesting that, I only kept it to demonstrate the failure that is
possibly an LZ4 bug.
was (Author: brandon.williams):
bq. Not a huge fan of fixing the seed.
I'm not suggesting that, I only kept it so demonstrate the failure that is
possibly an LZ4 bug.
> Fix flaky - ChecksummingTransformerTest -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> ---
>
> Key: CASSANDRA-15313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15313
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Vinay Chella
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0-alpha
>
> Attachments: CASSANDRA-15313-hack.patch
>
>
> During the recent runs, this test appears to be flaky.
> Example failure:
> [https://circleci.com/gh/vinaykumarchella/cassandra/459#tests/containers/94]
> corruptionCausesFailure-compression -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> {code:java}
> java.lang.OutOfMemoryError: GC overhead limit exceeded
> at java.nio.HeapByteBuffer.(HeapByteBuffer.java:57)
> at java.nio.ByteBuffer.allocate(ByteBuffer.java:335)
> at org.quicktheories.impl.Precursor.(Precursor.java:17)
> at
> org.quicktheories.impl.ConcreteDetachedSource.(ConcreteDetachedSource.java:8)
> at
> org.quicktheories.impl.ConcreteDetachedSource.detach(ConcreteDetachedSource.java:23)
> at org.quicktheories.generators.Retry.generate(CodePoints.java:51)
> at
> org.quicktheories.generators.Generate.lambda$intArrays$10(Generate.java:190)
> at
> org.quicktheories.generators.Generate$$Lambda$17/1847008471.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$mix$10(Gen.java:184)
> at org.quicktheories.core.Gen$$Lambda$45/802243390.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$flatMap$5(Gen.java:93)
> at org.quicktheories.core.Gen$$Lambda$48/363509958.generate(Unknown
> Source)
> at
> org.quicktheories.dsl.TheoryBuilder4.lambda$prgnToTuple$12(TheoryBuilder4.java:188)
> at
> org.quicktheories.dsl.TheoryBuilder4$$Lambda$40/2003496028.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.FilteredGenerator.generate(Gen.java:225)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.impl.Core.generate(Core.java:150)
> at org.quicktheories.impl.Core.shrink(Core.java:103)
> at org.quicktheories.impl.Core.run(Core.java:39)
> at org.quicktheories.impl.TheoryRunner.check(TheoryRunner.java:35)
> at org.quicktheories.dsl.TheoryBuilder4.check(TheoryBuilder4.java:150)
> at
> org.quicktheories.dsl.TheoryBuilder4.checkAssert(TheoryBuilder4.java:162)
> at
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest.corruptionCausesFailure(ChecksummingTransformerTest.java:87)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15313) Fix flaky - ChecksummingTransformerTest - org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031719#comment-17031719
]
Jordan West commented on CASSANDRA-15313:
-
Not a huge fan of fixing the seed. The intention is for the test to search
different permutations each time its run, not a fixed set (the seed is meant to
help debug once you find that failure -- assuming its deterministic). One seed
may find the original bug this test found but not other/future bugs.
Ideally we'd keep the example count high but balancing that against memory
usage and runtime goals/constraints so we don't make the suites unnecessarily
long for code that hasn't changed.
> Fix flaky - ChecksummingTransformerTest -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> ---
>
> Key: CASSANDRA-15313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15313
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Vinay Chella
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0-alpha
>
> Attachments: CASSANDRA-15313-hack.patch
>
>
> During the recent runs, this test appears to be flaky.
> Example failure:
> [https://circleci.com/gh/vinaykumarchella/cassandra/459#tests/containers/94]
> corruptionCausesFailure-compression -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> {code:java}
> java.lang.OutOfMemoryError: GC overhead limit exceeded
> at java.nio.HeapByteBuffer.(HeapByteBuffer.java:57)
> at java.nio.ByteBuffer.allocate(ByteBuffer.java:335)
> at org.quicktheories.impl.Precursor.(Precursor.java:17)
> at
> org.quicktheories.impl.ConcreteDetachedSource.(ConcreteDetachedSource.java:8)
> at
> org.quicktheories.impl.ConcreteDetachedSource.detach(ConcreteDetachedSource.java:23)
> at org.quicktheories.generators.Retry.generate(CodePoints.java:51)
> at
> org.quicktheories.generators.Generate.lambda$intArrays$10(Generate.java:190)
> at
> org.quicktheories.generators.Generate$$Lambda$17/1847008471.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$mix$10(Gen.java:184)
> at org.quicktheories.core.Gen$$Lambda$45/802243390.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$flatMap$5(Gen.java:93)
> at org.quicktheories.core.Gen$$Lambda$48/363509958.generate(Unknown
> Source)
> at
> org.quicktheories.dsl.TheoryBuilder4.lambda$prgnToTuple$12(TheoryBuilder4.java:188)
> at
> org.quicktheories.dsl.TheoryBuilder4$$Lambda$40/2003496028.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.FilteredGenerator.generate(Gen.java:225)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.impl.Core.generate(Core.java:150)
> at org.quicktheories.impl.Core.shrink(Core.java:103)
> at org.quicktheories.impl.Core.run(Core.java:39)
> at org.quicktheories.impl.TheoryRunner.check(TheoryRunner.java:35)
> at org.quicktheories.dsl.TheoryBuilder4.check(TheoryBuilder4.java:150)
> at
> org.quicktheories.dsl.TheoryBuilder4.checkAssert(TheoryBuilder4.java:162)
> at
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest.corruptionCausesFailure(ChecksummingTransformerTest.java:87)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15313) Fix flaky - ChecksummingTransformerTest - org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
[
https://issues.apache.org/jira/browse/CASSANDRA-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031710#comment-17031710
]
Brandon Williams commented on CASSANDRA-15313:
--
bq. "it" is the failing case; sorry for the confusion. By lowering the examples
we will need to run the test more before we see the failing case.
That is not true, though. The key to reproducing the failing case is defining
the seed that makes it fail, which can then reproduce it with only 20 examples
(I updated my branch to reflect this, and isolated it to the
corruptionCausesFailure test. You still need to override the timeout to be
long enough for it to fail, I use -Dtest.timeout=6000) I probably did a
few thousand runs before I came across that seed, though.
bq. I took a stab at fixing it and attaching a hack patch to the JIRA to show;
This looks good but you also removed the examples from corruptionCausesFailure.
With them added back everything seems to pass fine at 200 examples. I'll try
another run with 500 and report back.
> Fix flaky - ChecksummingTransformerTest -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> ---
>
> Key: CASSANDRA-15313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15313
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
>Reporter: Vinay Chella
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.0-alpha
>
> Attachments: CASSANDRA-15313-hack.patch
>
>
> During the recent runs, this test appears to be flaky.
> Example failure:
> [https://circleci.com/gh/vinaykumarchella/cassandra/459#tests/containers/94]
> corruptionCausesFailure-compression -
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest
> {code:java}
> java.lang.OutOfMemoryError: GC overhead limit exceeded
> at java.nio.HeapByteBuffer.(HeapByteBuffer.java:57)
> at java.nio.ByteBuffer.allocate(ByteBuffer.java:335)
> at org.quicktheories.impl.Precursor.(Precursor.java:17)
> at
> org.quicktheories.impl.ConcreteDetachedSource.(ConcreteDetachedSource.java:8)
> at
> org.quicktheories.impl.ConcreteDetachedSource.detach(ConcreteDetachedSource.java:23)
> at org.quicktheories.generators.Retry.generate(CodePoints.java:51)
> at
> org.quicktheories.generators.Generate.lambda$intArrays$10(Generate.java:190)
> at
> org.quicktheories.generators.Generate$$Lambda$17/1847008471.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$mix$10(Gen.java:184)
> at org.quicktheories.core.Gen$$Lambda$45/802243390.generate(Unknown
> Source)
> at org.quicktheories.core.Gen.lambda$flatMap$5(Gen.java:93)
> at org.quicktheories.core.Gen$$Lambda$48/363509958.generate(Unknown
> Source)
> at
> org.quicktheories.dsl.TheoryBuilder4.lambda$prgnToTuple$12(TheoryBuilder4.java:188)
> at
> org.quicktheories.dsl.TheoryBuilder4$$Lambda$40/2003496028.generate(Unknown
> Source)
> at org.quicktheories.core.DescribingGenerator.generate(Gen.java:255)
> at org.quicktheories.core.FilteredGenerator.generate(Gen.java:225)
> at org.quicktheories.core.Gen.lambda$map$0(Gen.java:36)
> at org.quicktheories.core.Gen$$Lambda$20/71399214.generate(Unknown
> Source)
> at org.quicktheories.impl.Core.generate(Core.java:150)
> at org.quicktheories.impl.Core.shrink(Core.java:103)
> at org.quicktheories.impl.Core.run(Core.java:39)
> at org.quicktheories.impl.TheoryRunner.check(TheoryRunner.java:35)
> at org.quicktheories.dsl.TheoryBuilder4.check(TheoryBuilder4.java:150)
> at
> org.quicktheories.dsl.TheoryBuilder4.checkAssert(TheoryBuilder4.java:162)
> at
> org.apache.cassandra.transport.frame.checksum.ChecksummingTransformerTest.corruptionCausesFailure(ChecksummingTransformerTest.java:87)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15527) Fix flakey test - org.apache.cassandra.index.sasi.SASIIndexTest testCrossSSTableQueries
[
https://issues.apache.org/jira/browse/CASSANDRA-15527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031708#comment-17031708
]
Ekaterina Dimitrova commented on CASSANDRA-15527:
-
Weird, I ran it for three hours, the same command he shared. This is around
180*3 runs, if we consider every run 20 seconds. No failures.
> Fix flakey test - org.apache.cassandra.index.sasi.SASIIndexTest
> testCrossSSTableQueries
> ---
>
> Key: CASSANDRA-15527
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15527
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: David Capwell
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.0-alpha
>
> Attachments: CASSANDRA-15527.txt
>
>
> {code}
> junit.framework.AssertionFailedError: [key13, key2977, key2978, key2979,
> key2980, key2982, key2983, key2984, key2985, key6]
> at
> org.apache.cassandra.index.sasi.SASIIndexTest.testCrossSSTableQueries(SASIIndexTest.java:340)
> at
> org.apache.cassandra.index.sasi.SASIIndexTest.testCrossSSTableQueries(SASIIndexTest.java:286)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
