[jira] [Commented] (CASSANDRA-14875) Explicitly initialize StageManager early in startup
[
https://issues.apache.org/jira/browse/CASSANDRA-14875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046128#comment-17046128
]
Ekaterina Dimitrova commented on CASSANDRA-14875:
-
According to CASSANDRA-15227 StageManager was removed and embedded in the Stage
enum.
> Explicitly initialize StageManager early in startup
> ---
>
> Key: CASSANDRA-14875
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14875
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Startup and Shutdown
>Reporter: Aleksandr Sorokoumov
>Assignee: Aleksandr Sorokoumov
>Priority: Low
> Fix For: 4.x
>
>
> {{StageManager}} initializes itself through a static block and sets up every
> {{Stage}}, including pre-starting their threads. This initizalization can
> take a few hundred milliseconds. This timing impact is unpredictable and hard
> to reason about; it looks like it usually gets hit when creating new
> Keyspaces on start-up and announcing them through migrations.
> While these processes are resilient to these delays, it is dramatically
> easier to reason about over time if this initialization happens explicitly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14875) Explicitly initialize StageManager early in startup
[
https://issues.apache.org/jira/browse/CASSANDRA-14875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-14875:
Reviewers: Ekaterina Dimitrova, Ekaterina Dimitrova (was: Ekaterina
Dimitrova)
Ekaterina Dimitrova, Ekaterina Dimitrova
Status: Review In Progress (was: Patch Available)
> Explicitly initialize StageManager early in startup
> ---
>
> Key: CASSANDRA-14875
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14875
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Startup and Shutdown
>Reporter: Aleksandr Sorokoumov
>Assignee: Aleksandr Sorokoumov
>Priority: Low
> Fix For: 4.x
>
>
> {{StageManager}} initializes itself through a static block and sets up every
> {{Stage}}, including pre-starting their threads. This initizalization can
> take a few hundred milliseconds. This timing impact is unpredictable and hard
> to reason about; it looks like it usually gets hit when creating new
> Keyspaces on start-up and announcing them through migrations.
> While these processes are resilient to these delays, it is dramatically
> easier to reason about over time if this initialization happens explicitly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14906) FastByteOperations.UnsafeOperations fails to handle read only byte buffers correctly
[ https://issues.apache.org/jira/browse/CASSANDRA-14906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046126#comment-17046126 ] Ekaterina Dimitrova commented on CASSANDRA-14906: - Rebase done but there is a bunch of conflicts to be reconsidered. > FastByteOperations.UnsafeOperations fails to handle read only byte buffers > correctly > > > Key: CASSANDRA-14906 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14906 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core >Reporter: Aleksandr Sorokoumov >Assignee: Aleksandr Sorokoumov >Priority: Low > Fix For: 4.x > > Attachments: 14906-dtest.png, 14906-testall.png > > > If a buffer is read only it reports having no array, though it may well be > backed by an array. Code in UnsafeOperation works under the impression that a > buffer for which hasArray() == false is necessarily a direct buffer. Which is > not the case. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14906) FastByteOperations.UnsafeOperations fails to handle read only byte buffers correctly
[ https://issues.apache.org/jira/browse/CASSANDRA-14906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-14906: Reviewers: Ekaterina Dimitrova, Ekaterina Dimitrova (was: Ekaterina Dimitrova) Ekaterina Dimitrova, Ekaterina Dimitrova Status: Review In Progress (was: Patch Available) > FastByteOperations.UnsafeOperations fails to handle read only byte buffers > correctly > > > Key: CASSANDRA-14906 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14906 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core >Reporter: Aleksandr Sorokoumov >Assignee: Aleksandr Sorokoumov >Priority: Low > Fix For: 4.x > > Attachments: 14906-dtest.png, 14906-testall.png > > > If a buffer is read only it reports having no array, though it may well be > backed by an array. Code in UnsafeOperation works under the impression that a > buffer for which hasArray() == false is necessarily a direct buffer. Which is > not the case. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-15593) seems reading repair bug
[
https://issues.apache.org/jira/browse/CASSANDRA-15593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams reassigned CASSANDRA-15593:
Assignee: (was: Brandon Williams)
> seems reading repair bug
>
>
> Key: CASSANDRA-15593
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15593
> Project: Cassandra
> Issue Type: Bug
>Reporter: Antonio
>Priority: Normal
>
> cassandra version：2.1.15
> i have one dc and 3nodes
> 1. create KEYSPACE test WITH replication = \{'class':
> 'NetworkTopologyStrategy', 'DC1':'3' } and durable_writes = 'true';
> 2. create table test(a int , b int , c int , primary key(a)) with
> dclocal_read_repair_chance = 1.0;
> 3. insert one row into table test，instert into test(a, b, c) values (1, 1,
> 1); and remove sstable on two nodes and result below：
> node1：have correct row 1 1 1
> node2：doesn't have rf
> node3：doesn't have rf
> 4. and i use local_one select one by one like this:
> node1 un，node2 dn，node3 dn：return 1 1 1
> node1 dn，node2 un，node3 dn：return null
> node1 dn，node2 dn，node3 dn：return null
> this prove node1 have correct rf
> 5. and i let all node un，user local_quarum to select , select * from test
> where a = 1;
> but the read repair does't work every time(i test many times)，that's the
> problem(same in 3.0.15)
>
> i hope if i set dclocal_read_repair_chance = 1.0，every time i read by
> local_quarum， if any rf digest does't match，read repair will work，and repair
> all nodes
>
> i.m not sure does's the problem happends in this code()
> wish for your reply，thanks
> public void response(MessageIn message)
> {
> resolver.preprocess(message);int n = waitingFor(message)
> ? recievedUpdater.incrementAndGet(this)
> : received;if (n >= blockfor &&
> resolver.isDataPresent())
> {
> this mean if return responses >= rf/2 +1 and a data response
> return，it start compare，does't all response
> condition.signalAll();// kick off a background digest
> comparison if this is a result that (may have) arrived after//
> the original resolve that get() kicks off as soon as the condition is
> signaledif (blockfor < endpoints.size() && n == endpoints.size())
> {
> TraceState traceState = Tracing.instance.get();
> if (traceState != null)
> traceState.trace("Initiating read-repair");
> StageManager.getStage(Stage.READ_REPAIR).execute(new
> AsyncRepairRunner(traceState));
> }
> }
> }
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-15593) seems reading repair bug
[
https://issues.apache.org/jira/browse/CASSANDRA-15593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Antonio reassigned CASSANDRA-15593:
---
Assignee: Brandon Williams
> seems reading repair bug
>
>
> Key: CASSANDRA-15593
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15593
> Project: Cassandra
> Issue Type: Bug
>Reporter: Antonio
>Assignee: Brandon Williams
>Priority: Normal
>
> cassandra version：2.1.15
> i have one dc and 3nodes
> 1. create KEYSPACE test WITH replication = \{'class':
> 'NetworkTopologyStrategy', 'DC1':'3' } and durable_writes = 'true';
> 2. create table test(a int , b int , c int , primary key(a)) with
> dclocal_read_repair_chance = 1.0;
> 3. insert one row into table test，instert into test(a, b, c) values (1, 1,
> 1); and remove sstable on two nodes and result below：
> node1：have correct row 1 1 1
> node2：doesn't have rf
> node3：doesn't have rf
> 4. and i use local_one select one by one like this:
> node1 un，node2 dn，node3 dn：return 1 1 1
> node1 dn，node2 un，node3 dn：return null
> node1 dn，node2 dn，node3 dn：return null
> this prove node1 have correct rf
> 5. and i let all node un，user local_quarum to select , select * from test
> where a = 1;
> but the read repair does't work every time(i test many times)，that's the
> problem(same in 3.0.15)
>
> i hope if i set dclocal_read_repair_chance = 1.0，every time i read by
> local_quarum， if any rf digest does't match，read repair will work，and repair
> all nodes
>
> i.m not sure does's the problem happends in this code()
> wish for your reply，thanks
> public void response(MessageIn message)
> {
> resolver.preprocess(message);int n = waitingFor(message)
> ? recievedUpdater.incrementAndGet(this)
> : received;if (n >= blockfor &&
> resolver.isDataPresent())
> {
> this mean if return responses >= rf/2 +1 and a data response
> return，it start compare，does't all response
> condition.signalAll();// kick off a background digest
> comparison if this is a result that (may have) arrived after//
> the original resolve that get() kicks off as soon as the condition is
> signaledif (blockfor < endpoints.size() && n == endpoints.size())
> {
> TraceState traceState = Tracing.instance.get();
> if (traceState != null)
> traceState.trace("Initiating read-repair");
> StageManager.getStage(Stage.READ_REPAIR).execute(new
> AsyncRepairRunner(traceState));
> }
> }
> }
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.11' into trunk
This is an automated email from the ASF dual-hosted git repository. mshuler pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 4b855aeb8ae5a59982340ed3def97eeb60b64818 Merge: 9729e3f ef7e171 Author: Michael Shuler AuthorDate: Wed Feb 26 17:13:59 2020 -0600 Merge branch 'cassandra-3.11' into trunk - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.11 updated (1b29401 -> ef7e171)
This is an automated email from the ASF dual-hosted git repository. mshuler pushed a change to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 1b29401 Merge branch 'cassandra-3.0' into cassandra-3.11 new e37f77d Fix CHANGES merged from notes new afc1ba3 Merge branch 'cassandra-3.0' into cassandra-3.11 new ef7e171 Fix CHANGES merged from notes The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.0 updated: Fix CHANGES merged from notes
This is an automated email from the ASF dual-hosted git repository. mshuler pushed a commit to branch cassandra-3.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/cassandra-3.0 by this push: new e37f77d Fix CHANGES merged from notes e37f77d is described below commit e37f77d41b42344905d1f3e27bee963fa417fa68 Author: Michael Shuler AuthorDate: Wed Feb 26 17:11:42 2020 -0600 Fix CHANGES merged from notes --- CHANGES.txt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/CHANGES.txt b/CHANGES.txt index aa00edd..9adc461 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,6 +1,6 @@ 3.0.21 * Run evictFromMembership in GossipStage (CASSANDRA-15592) -Merged from 2.2 +Merged from 2.2: * Allow EXTRA_CLASSPATH to work on tar/source installations (CASSANDRA-15567) 3.0.20 @@ -22,8 +22,7 @@ Merged from 2.2 * Ensure legacy rows have primary key livenessinfo when they contain illegal cells (CASSANDRA-15365) * Fix race condition when setting bootstrap flags (CASSANDRA-14878) * Fix NativeLibrary.tryOpenDirectory callers for Windows (CASSANDRA-15426) - -2.2.16 +Merged from 2.2: * Fix SELECT JSON output for empty blobs (CASSANDRA-15435) * In-JVM DTest: Set correct internode message version for upgrade test (CASSANDRA-15371) * In-JVM DTest: Support NodeTool in dtest (CASSANDRA-15429) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/02: Merge branch 'cassandra-3.0' into cassandra-3.11
This is an automated email from the ASF dual-hosted git repository. mshuler pushed a commit to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit afc1ba3f1d47bb399e16cf61fe4e7092d994a791 Merge: 1b29401 e37f77d Author: Michael Shuler AuthorDate: Wed Feb 26 17:12:03 2020 -0600 Merge branch 'cassandra-3.0' into cassandra-3.11 CHANGES.txt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --cc CHANGES.txt index a4a6c12,9adc461..0261e4f --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,17 -1,9 +1,17 @@@ -3.0.21 +3.11.7 +Merged from 3.0: * Run evictFromMembership in GossipStage (CASSANDRA-15592) - Merged from 2.2 + Merged from 2.2: * Allow EXTRA_CLASSPATH to work on tar/source installations (CASSANDRA-15567) -3.0.20 + +3.11.6 + * Fix bad UDT sstable metadata serialization headers written by C* 3.0 on upgrade and in sstablescrub (CASSANDRA-15035) + * Fix nodetool compactionstats showing extra pending task for TWCS - patch implemented (CASSANDRA-15409) + * Fix SELECT JSON formatting for the "duration" type (CASSANDRA-15075) + * Fix LegacyLayout to have same behavior as 2.x when handling unknown column names (CASSANDRA-15081) + * Update nodetool help stop output (CASSANDRA-15401) +Merged from 3.0: * Run in-jvm upgrade dtests in circleci (CASSANDRA-15506) * Include updates to static column in mutation size calculations (CASSANDRA-15293) * Fix point-in-time recoevery ignoring timestamp of updates to static columns (CASSANDRA-15292) @@@ -29,10 -21,8 +29,9 @@@ * Make sure index summary redistribution does not start when compactions are paused (CASSANDRA-15265) * Ensure legacy rows have primary key livenessinfo when they contain illegal cells (CASSANDRA-15365) * Fix race condition when setting bootstrap flags (CASSANDRA-14878) +Merged from 2.2: * Fix NativeLibrary.tryOpenDirectory callers for Windows (CASSANDRA-15426) - - 2.2.16 + Merged from 2.2: * Fix SELECT JSON output for empty blobs (CASSANDRA-15435) * In-JVM DTest: Set correct internode message version for upgrade test (CASSANDRA-15371) * In-JVM DTest: Support NodeTool in dtest (CASSANDRA-15429) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (9729e3f -> 4b855ae)
This is an automated email from the ASF dual-hosted git repository. mshuler pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 9729e3f Allow overriding Gossiper.aVeryLongTime new e37f77d Fix CHANGES merged from notes new afc1ba3 Merge branch 'cassandra-3.0' into cassandra-3.11 new ef7e171 Fix CHANGES merged from notes new 4b855ae Merge branch 'cassandra-3.11' into trunk The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 02/02: Fix CHANGES merged from notes
This is an automated email from the ASF dual-hosted git repository. mshuler pushed a commit to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit ef7e171f0a74f31f6a7a518cd4a9a1133f32c7e5 Author: Michael Shuler AuthorDate: Wed Feb 26 17:12:50 2020 -0600 Fix CHANGES merged from notes --- CHANGES.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/CHANGES.txt b/CHANGES.txt index 0261e4f..7224b24 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -29,7 +29,6 @@ Merged from 3.0: * Make sure index summary redistribution does not start when compactions are paused (CASSANDRA-15265) * Ensure legacy rows have primary key livenessinfo when they contain illegal cells (CASSANDRA-15365) * Fix race condition when setting bootstrap flags (CASSANDRA-14878) -Merged from 2.2: * Fix NativeLibrary.tryOpenDirectory callers for Windows (CASSANDRA-15426) Merged from 2.2: * Fix SELECT JSON output for empty blobs (CASSANDRA-15435) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15426) Cassandra 3.11.5 fails to start on Windows
[ https://issues.apache.org/jira/browse/CASSANDRA-15426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Shuler updated CASSANDRA-15426: --- Fix Version/s: (was: 3.11.x) (was: 3.0.x) 3.0.20 3.11.6 > Cassandra 3.11.5 fails to start on Windows > --- > > Key: CASSANDRA-15426 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15426 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Hints >Reporter: Ashish Singh >Assignee: Jeff Jirsa >Priority: Normal > Fix For: 3.0.20, 3.11.6, 4.0 > > > Cassandra 3.11.5 fails to start on Windows server 2012 R2. with following > error trace. > Cassandra 3.11.4 doesn't fail on Windows 2012 R2. > > org.apache.cassandra.io.FSReadError: java.io.IOException: Invalid folder > descriptor trying to create log replica > C:\Users\Administrator\Downloads\apache-cassandra-3.11.5-bin.tar\apache-cassandra-3.11.5-bin\apache-cassandra-3.11.5\data\data\system\local-7ad54392bcdd35a684174e047860b377 > at org.apache.cassandra.db.lifecycle.LogReplica.create(LogReplica.java:58) > ~[apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.db.lifecycle.LogReplicaSet.maybeCreateReplica(LogReplicaSet.java:86) > ~[apache-cassandra-3.11.5.jar:3.11.5] > at org.apache.cassandra.db.lifecycle.LogFile.makeRecord(LogFile.java:311) > [apache-cassandra-3.11.5.jar:3.11.5] > at org.apache.cassandra.db.lifecycle.LogFile.add(LogFile.java:283) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.db.lifecycle.LogTransaction.trackNew(LogTransaction.java:139) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.db.lifecycle.LifecycleTransaction.trackNew(LifecycleTransaction.java:528) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.io.sstable.format.big.BigTableWriter.(BigTableWriter.java:81) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.io.sstable.format.big.BigFormat$WriterFactory.open(BigFormat.java:92) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.io.sstable.format.SSTableWriter.create(SSTableWriter.java:102) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.io.sstable.SimpleSSTableMultiWriter.create(SimpleSSTableMultiWriter.java:119) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.db.compaction.AbstractCompactionStrategy.createSSTableMultiWriter(AbstractCompactionStrategy.java:588) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.db.compaction.CompactionStrategyManager.createSSTableMultiWriter(CompactionStrategyManager.java:1027) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.db.ColumnFamilyStore.createSSTableMultiWriter(ColumnFamilyStore.java:532) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.db.Memtable$FlushRunnable.createFlushWriter(Memtable.java:504) > [apache-cassandra-3.11.5.jar:3.11.5] > at org.apache.cassandra.db.Memtable$FlushRunnable.(Memtable.java:443) > [apache-cassandra-3.11.5.jar:3.11.5] > at org.apache.cassandra.db.Memtable$FlushRunnable.(Memtable.java:420) > [apache-cassandra-3.11.5.jar:3.11.5] > at org.apache.cassandra.db.Memtable.createFlushRunnables(Memtable.java:307) > [apache-cassandra-3.11.5.jar:3.11.5] > at org.apache.cassandra.db.Memtable.flushRunnables(Memtable.java:298) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.db.ColumnFamilyStore$Flush.flushMemtable(ColumnFamilyStore.java:1153) > [apache-cassandra-3.11.5.jar:3.11.5] > at > org.apache.cassandra.db.ColumnFamilyStore$Flush.run(ColumnFamilyStore.java:1118) > [apache-cassandra-3.11.5.jar:3.11.5] > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > [na:1.8.0_161] > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > [na:1.8.0_161] > at > org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:84) > [apache-cassandra-3.11.5.jar:3.11.5] > at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_161] > Caused by: java.io.IOException: Invalid folder descriptor trying to -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15604) Remove obsolete table/MV options from schema tables
[
https://issues.apache.org/jira/browse/CASSANDRA-15604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olivier Michallat updated CASSANDRA-15604:
--
Description:
CASSANDRA-13910 removed the {{read_repair_chance}} and
{{dclocal_read_repair_chance}} options for tables and materialized views.
CASSANDRA-12868 made {{default_time_to_live}} illegal for materialized views.
However the corresponding columns still exist in {{system_schema.tables}} and
{{system_schema.views}}. Maybe it would make sense to remove them in Cassandra
4. Historically, obsolete options have been removed in similar cases, for
example {{compaction_strategy_class}}, {{compaction_strategy_options}} and
{{compression_parameters}} were present in 2.2 but removed in 3.0 (arguably
there was also a major refactoring of schema tables during that transition).
This is not a huge deal, but it would make things a bit easier for the Java
driver (our metadata exposes a "client-side describe" feature, and currently we
assume that any column in the schema table must be added to the CREATE TABLE
statement).
was:
CASSANDRA-13910 removed the {{read_repair_chance}} and
{{dclocal_read_repair_chance}} options for tables and materialized views.
CASSANDRA-12868 made {{default_time_to_live}} illegal for materialized views.
However the corresponding columns still exist in {{system_schema.tables}} and
{{system_schema.views}}. Maybe it would make sense to remove them in Cassandra
4. Historically, obsolete options have been removed in similar cases, for
example {{compaction_strategy_class}}, {{compaction_strategy_options}} and
{{compression_parameters}} in Cassandra 2.2 => 3 (arguably there was also a
major refactoring of schema tables during that transition).
This is not a huge deal, but it would make things a bit easier for the Java
driver (our metadata exposes a "client-side describe" feature, and currently we
assume that any column in the schema table must be added to the CREATE TABLE
statement).
> Remove obsolete table/MV options from schema tables
> ---
>
> Key: CASSANDRA-15604
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15604
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Olivier Michallat
>Priority: Normal
>
> CASSANDRA-13910 removed the {{read_repair_chance}} and
> {{dclocal_read_repair_chance}} options for tables and materialized views.
> CASSANDRA-12868 made {{default_time_to_live}} illegal for materialized views.
> However the corresponding columns still exist in {{system_schema.tables}} and
> {{system_schema.views}}. Maybe it would make sense to remove them in
> Cassandra 4. Historically, obsolete options have been removed in similar
> cases, for example {{compaction_strategy_class}},
> {{compaction_strategy_options}} and {{compression_parameters}} were present
> in 2.2 but removed in 3.0 (arguably there was also a major refactoring of
> schema tables during that transition).
> This is not a huge deal, but it would make things a bit easier for the Java
> driver (our metadata exposes a "client-side describe" feature, and currently
> we assume that any column in the schema table must be added to the CREATE
> TABLE statement).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15256) Clean up redundant nodetool commands added in 4.0
[
https://issues.apache.org/jira/browse/CASSANDRA-15256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jordan West updated CASSANDRA-15256:
Status: Ready to Commit (was: Review In Progress)
LGTM. +1. Some notes for future readers:
{{getReplicas}}:
- Was added as part of Transient Replication patch (CASSANDRA-14404)
- Eventually calls {{getNaturalReplicasForToken(String, ByteBuffer)}}
function just like {{getNaturalEndpoints}} does but with an additional check
that the table exists (although it uses no metadata from this table)
- Does not include ports like {{getendpoints}} does. Although
{{getendpoints}} uses the deprecated method {{getNaturalEndpoints}} it has an
option to use the replacement {{getNaturalEndpointsWithPort}}
Other Changes:
- HandoffWindow (added in CASSANDRA-13728) was duplicate of GetMaxHintWindow
(added in CASSANDRA-11720) which is more conventional naming
- Removes duplicate DisableAuditLog listing
> Clean up redundant nodetool commands added in 4.0
> -
>
> Key: CASSANDRA-15256
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15256
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/nodetool
>Reporter: Chris Lohfink
>Assignee: Chris Lohfink
>Priority: Low
> Fix For: 4.0
>
>
> Both hintedhandoff and getendpoints had a 2nd command added that does the
> exact thing but rewritten (and in getReplicas not as well) not just aliased
> (like cf->tablestats). Also a minor cleanup is same command added multiple
> times to nodetool command list. We should clean this up before 4.0 release
> before people become reliant on the newly introduced command name. If we want
> them renamed as that we should rename and link with alias like we do with
> cf->table others.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15256) Clean up redundant nodetool commands added in 4.0
[ https://issues.apache.org/jira/browse/CASSANDRA-15256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jordan West updated CASSANDRA-15256: Reviewers: Jordan West, Jordan West (was: Jordan West) Jordan West, Jordan West Status: Review In Progress (was: Patch Available) > Clean up redundant nodetool commands added in 4.0 > - > > Key: CASSANDRA-15256 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15256 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: Chris Lohfink >Assignee: Chris Lohfink >Priority: Low > Fix For: 4.0 > > > Both hintedhandoff and getendpoints had a 2nd command added that does the > exact thing but rewritten (and in getReplicas not as well) not just aliased > (like cf->tablestats). Also a minor cleanup is same command added multiple > times to nodetool command list. We should clean this up before 4.0 release > before people become reliant on the newly introduced command name. If we want > them renamed as that we should rename and link with alias like we do with > cf->table others. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15553) Preview repair should include sstables from finalized incremental repair sessions
[ https://issues.apache.org/jira/browse/CASSANDRA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045933#comment-17045933 ] David Capwell commented on CASSANDRA-15553: --- I like the use of blocking filters, glad we don't transfer them =D Some of the tests make assumptions about time using thread.sleep; this could make them flaky. With CASSANDRA-15564 I setup utilities for querying repair state, so if that does end up happening we can always block waiting until the repair table is updating. I made the comment that the tests only pass because we look at the notifications, but with CASSANDRA-15564 that will be fixed so can ignore that comment. A test that would be good to add would be 1) run preview 2) delay the merle tree so the coordinator doesn't see it yet 3) run IR, wait for it to complete 4) unblock merle tree's If I am reading this correctly, the preview will fail even though the validation wouldn't. I am +1 > Preview repair should include sstables from finalized incremental repair > sessions > - > > Key: CASSANDRA-15553 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15553 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 4.0-alpha > > > When running a preview repair we currently grab all repaired sstables, > problem is that we depend on compaction to move the sstables from pending to > repaired so we might have different data marked repaired on different nodes. > Including any sstables from finalized incremental repair sessions as repaired > will solve this. > Another problem is that validations don't start at exactly the same time on > different nodes, so if an incremental repair finishes while the preview > repair is running we might also validate the wrong repaired set. We should > fail the preview repair if an intersecting incremental repair finishes during > the preview repair. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15564) Refactor repair coordinator so errors are consistent
[ https://issues.apache.org/jira/browse/CASSANDRA-15564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Eggleston updated CASSANDRA-15564: Reviewers: Alex Petrov, Blake Eggleston, Dinesh Joshi, Blake Eggleston (was: Alex Petrov, Blake Eggleston, Dinesh Joshi) Alex Petrov, Blake Eggleston, Dinesh Joshi, Blake Eggleston (was: Alex Petrov, Blake Eggleston, Dinesh Joshi) Status: Review In Progress (was: Patch Available) > Refactor repair coordinator so errors are consistent > > > Key: CASSANDRA-15564 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15564 > Project: Cassandra > Issue Type: Sub-task > Components: Consistency/Repair >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Time Spent: 10.5h > Remaining Estimate: 0h > > This is to split the change in CASSANDRA-15399 so the refactor is isolated > out. > Currently the repair coordinator special cases the exit cases at each call > site; this makes it so that errors can be inconsistent and there are cases > where proper complete isn't done (proper notifications, and forgetting to > update ActiveRepairService). > [Circle > CI|https://circleci.com/gh/dcapwell/cassandra/tree/bug%2FrepairCoordinatorJmxConsistency] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15596) Make Gossiper.aVeryLongTime configurable
[ https://issues.apache.org/jira/browse/CASSANDRA-15596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-15596: - Fix Version/s: 4.0-alpha Source Control Link: https://github.com/apache/cassandra/commit/9729e3f987f1b3dea6a57cc93ba10b75930850c9 Resolution: Fixed Status: Resolved (was: Ready to Commit) I don't disagree, but we aren't doing that in other places (eg, cassandra.ring_delay_ms) Committed. > Make Gossiper.aVeryLongTime configurable > - > > Key: CASSANDRA-15596 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15596 > Project: Cassandra > Issue Type: Improvement > Components: Cluster/Gossip >Reporter: Jordan West >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.0-alpha > > > This is useful for testing primarily and operator control maybe -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15596) Make Gossiper.aVeryLongTime configurable
[ https://issues.apache.org/jira/browse/CASSANDRA-15596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-15596: - Status: Ready to Commit (was: Review In Progress) > Make Gossiper.aVeryLongTime configurable > - > > Key: CASSANDRA-15596 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15596 > Project: Cassandra > Issue Type: Improvement > Components: Cluster/Gossip >Reporter: Jordan West >Assignee: Brandon Williams >Priority: Normal > > This is useful for testing primarily and operator control maybe -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: Allow overriding Gossiper.aVeryLongTime
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/trunk by this push:
new 9729e3f Allow overriding Gossiper.aVeryLongTime
9729e3f is described below
commit 9729e3f987f1b3dea6a57cc93ba10b75930850c9
Author: Brandon Williams
AuthorDate: Wed Feb 26 15:04:06 2020 -0600
Allow overriding Gossiper.aVeryLongTime
Patch by brandonwilliams, reviewed by David Capwell for CASSANDRA-15569
---
src/java/org/apache/cassandra/gms/Gossiper.java | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/src/java/org/apache/cassandra/gms/Gossiper.java
b/src/java/org/apache/cassandra/gms/Gossiper.java
index ef7b093..f276fbd 100644
--- a/src/java/org/apache/cassandra/gms/Gossiper.java
+++ b/src/java/org/apache/cassandra/gms/Gossiper.java
@@ -114,7 +114,7 @@ public class Gossiper implements
IFailureDetectionEventListener, GossiperMBean
// Timestamp to prevent processing any in-flight messages for we've not
send any SYN yet, see CASSANDRA-12653.
volatile long firstSynSendAt = 0L;
-public static final long aVeryLongTime = 259200 * 1000; // 3 days
+public static final long aVeryLongTime = getVeryLongTime();
// Maximimum difference between generation value and local time we are
willing to accept about a peer
static final int MAX_GENERATION_DIFFERENCE = 86400 * 365;
@@ -189,6 +189,17 @@ public class Gossiper implements
IFailureDetectionEventListener, GossiperMBean
private static final boolean disableThreadValidation =
Boolean.getBoolean(Props.DISABLE_THREAD_VALIDATION);
+private static long getVeryLongTime()
+{
+String newVLT = System.getProperty("cassandra.very_long_time_ms");
+if (newVLT != null)
+{
+logger.info("Overriding aVeryLongTime to {}ms", newVLT);
+return Long.parseLong(newVLT);
+}
+return 259200 * 1000; // 3 days
+}
+
private static boolean isInGossipStage()
{
return ((JMXEnabledSingleThreadExecutor)
Stage.GOSSIP.executor()).isExecutedBy(Thread.currentThread());
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15596) Make Gossiper.aVeryLongTime configurable
[ https://issues.apache.org/jira/browse/CASSANDRA-15596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15596: -- Reviewers: David Capwell, David Capwell (was: David Capwell) David Capwell, David Capwell Status: Review In Progress (was: Patch Available) LGTM +1. It would be good to prefix (after cassandra.) saying that this is localized to gossip > Make Gossiper.aVeryLongTime configurable > - > > Key: CASSANDRA-15596 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15596 > Project: Cassandra > Issue Type: Improvement > Components: Cluster/Gossip >Reporter: Jordan West >Assignee: Brandon Williams >Priority: Normal > > This is useful for testing primarily and operator control maybe -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15596) Make Gossiper.aVeryLongTime configurable
[ https://issues.apache.org/jira/browse/CASSANDRA-15596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045899#comment-17045899 ] Brandon Williams commented on CASSANDRA-15596: -- Pushed a branch for this here: https://github.com/driftx/cassandra/tree/CASSANDRA-15569 > Make Gossiper.aVeryLongTime configurable > - > > Key: CASSANDRA-15596 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15596 > Project: Cassandra > Issue Type: Improvement > Components: Cluster/Gossip >Reporter: Jordan West >Assignee: Brandon Williams >Priority: Normal > > This is useful for testing primarily and operator control maybe -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15596) Make Gossiper.aVeryLongTime configurable
[ https://issues.apache.org/jira/browse/CASSANDRA-15596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-15596: - Test and Documentation Plan: none needed Status: Patch Available (was: Open) > Make Gossiper.aVeryLongTime configurable > - > > Key: CASSANDRA-15596 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15596 > Project: Cassandra > Issue Type: Improvement > Components: Cluster/Gossip >Reporter: Jordan West >Assignee: Brandon Williams >Priority: Normal > > This is useful for testing primarily and operator control maybe -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch CASSANDRA-15569 deleted (was f0775f1)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch CASSANDRA-15569 in repository https://gitbox.apache.org/repos/asf/cassandra.git. was f0775f1 Allow overriding Gossiper.aVeryLongTime This change permanently discards the following revisions: discard f0775f1 Allow overriding Gossiper.aVeryLongTime - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch CASSANDRA-15569 created (now f0775f1)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch CASSANDRA-15569 in repository https://gitbox.apache.org/repos/asf/cassandra.git. at f0775f1 Allow overriding Gossiper.aVeryLongTime This branch includes the following new commits: new f0775f1 Allow overriding Gossiper.aVeryLongTime The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Allow overriding Gossiper.aVeryLongTime
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch CASSANDRA-15569
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit f0775f1db1c9404a1cf81080a609c5465b407344
Author: Brandon Williams
AuthorDate: Wed Feb 26 15:04:06 2020 -0600
Allow overriding Gossiper.aVeryLongTime
Patch by brandonwilliams for CASSANDRA-15569
---
src/java/org/apache/cassandra/gms/Gossiper.java | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/src/java/org/apache/cassandra/gms/Gossiper.java
b/src/java/org/apache/cassandra/gms/Gossiper.java
index ef7b093..f276fbd 100644
--- a/src/java/org/apache/cassandra/gms/Gossiper.java
+++ b/src/java/org/apache/cassandra/gms/Gossiper.java
@@ -114,7 +114,7 @@ public class Gossiper implements
IFailureDetectionEventListener, GossiperMBean
// Timestamp to prevent processing any in-flight messages for we've not
send any SYN yet, see CASSANDRA-12653.
volatile long firstSynSendAt = 0L;
-public static final long aVeryLongTime = 259200 * 1000; // 3 days
+public static final long aVeryLongTime = getVeryLongTime();
// Maximimum difference between generation value and local time we are
willing to accept about a peer
static final int MAX_GENERATION_DIFFERENCE = 86400 * 365;
@@ -189,6 +189,17 @@ public class Gossiper implements
IFailureDetectionEventListener, GossiperMBean
private static final boolean disableThreadValidation =
Boolean.getBoolean(Props.DISABLE_THREAD_VALIDATION);
+private static long getVeryLongTime()
+{
+String newVLT = System.getProperty("cassandra.very_long_time_ms");
+if (newVLT != null)
+{
+logger.info("Overriding aVeryLongTime to {}ms", newVLT);
+return Long.parseLong(newVLT);
+}
+return 259200 * 1000; // 3 days
+}
+
private static boolean isInGossipStage()
{
return ((JMXEnabledSingleThreadExecutor)
Stage.GOSSIP.executor()).isExecutedBy(Thread.currentThread());
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15476) Transient Replication - New Feature
[ https://issues.apache.org/jira/browse/CASSANDRA-15476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045885#comment-17045885 ] DeepakVohra commented on CASSANDRA-15476: - [~rustyrazorblade]. I have also added a Note at the start regarding the feature being experimental, only to be used if a user has expert knowledge. > Transient Replication - New Feature > --- > > Key: CASSANDRA-15476 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15476 > Project: Cassandra > Issue Type: Sub-task > Components: Documentation/Website >Reporter: DeepakVohra >Assignee: DeepakVohra >Priority: Normal > > Added a page on transient replication, a new feature. > https://github.com/apache/cassandra/pull/405 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15476) Transient Replication - New Feature
[ https://issues.apache.org/jira/browse/CASSANDRA-15476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045877#comment-17045877 ] Jon Haddad commented on CASSANDRA-15476: I'm going to need to spend a little more time on this review than some of the others due to how new this feature is. Hoping to get the doc merged by end of week. > Transient Replication - New Feature > --- > > Key: CASSANDRA-15476 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15476 > Project: Cassandra > Issue Type: Sub-task > Components: Documentation/Website >Reporter: DeepakVohra >Assignee: DeepakVohra >Priority: Normal > > Added a page on transient replication, a new feature. > https://github.com/apache/cassandra/pull/405 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15549) NativeLibrary recommends to run Cassandra as root but users should not
[ https://issues.apache.org/jira/browse/CASSANDRA-15549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045851#comment-17045851 ] Ekaterina Dimitrova commented on CASSANDRA-15549: - Thanks, good to know! > NativeLibrary recommends to run Cassandra as root but users should not > -- > > Key: CASSANDRA-15549 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15549 > Project: Cassandra > Issue Type: Improvement > Components: Local/Other >Reporter: David Capwell >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-alpha > > > NativeLibrary recommends users to run Cassandra as root, should remove that > since users really shouldn’t be running Cassandra as root. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15271) CASSANDRA-13426 changed the behavior of "CLUSTERING ORDER" on "CREATE TABLE"
[ https://issues.apache.org/jira/browse/CASSANDRA-15271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-15271: Test and Documentation Plan: [Branch|https://github.com/ekaterinadimitrova2/cassandra/tree/CASSANDRA-15271] Status: Patch Available (was: In Progress) > CASSANDRA-13426 changed the behavior of "CLUSTERING ORDER" on "CREATE TABLE" > > > Key: CASSANDRA-15271 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15271 > Project: Cassandra > Issue Type: Bug > Components: CQL/Syntax >Reporter: Jeremiah Jordan >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0 > > Attachments: CASSANDRA-15271-testall.txt, CASSANDRA-15271.zip, Screen > Shot 2020-02-26 at 11.25.29 AM.png > > > CASSANDRA-13426 changed the behavior of "CLUSTERING ORDER" on "CREATE TABLE", > it now complains if you don't specify all the columns. > It was nice that previously you could just specify to make the first > clustering DESC and leave the rest ASC without needing to specify them. Also > it would be nice I think to avoid breaking changes to the CREATE TABLE syntax. > We should either update NEWS.txt to call out the breaking change there, or > update the new code to be able to default the columns which were not > mentioned. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15271) CASSANDRA-13426 changed the behavior of "CLUSTERING ORDER" on "CREATE TABLE"
[ https://issues.apache.org/jira/browse/CASSANDRA-15271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045847#comment-17045847 ] Ekaterina Dimitrova commented on CASSANDRA-15271: - Attached are the results from CI. I didn't find any newly introduced issues > CASSANDRA-13426 changed the behavior of "CLUSTERING ORDER" on "CREATE TABLE" > > > Key: CASSANDRA-15271 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15271 > Project: Cassandra > Issue Type: Bug > Components: CQL/Syntax >Reporter: Jeremiah Jordan >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0 > > Attachments: CASSANDRA-15271-testall.txt, CASSANDRA-15271.zip, Screen > Shot 2020-02-26 at 11.25.29 AM.png > > > CASSANDRA-13426 changed the behavior of "CLUSTERING ORDER" on "CREATE TABLE", > it now complains if you don't specify all the columns. > It was nice that previously you could just specify to make the first > clustering DESC and leave the rest ASC without needing to specify them. Also > it would be nice I think to avoid breaking changes to the CREATE TABLE syntax. > We should either update NEWS.txt to call out the breaking change there, or > update the new code to be able to default the columns which were not > mentioned. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15271) CASSANDRA-13426 changed the behavior of "CLUSTERING ORDER" on "CREATE TABLE"
[ https://issues.apache.org/jira/browse/CASSANDRA-15271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045846#comment-17045846 ] Ekaterina Dimitrova commented on CASSANDRA-15271: - [Branch|https://github.com/ekaterinadimitrova2/cassandra/tree/CASSANDRA-15271] [Pull Request|https://github.com/apache/cassandra/pull/455] [~aleksey] , [~jjordan] - please let me know if you have any concerns. > CASSANDRA-13426 changed the behavior of "CLUSTERING ORDER" on "CREATE TABLE" > > > Key: CASSANDRA-15271 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15271 > Project: Cassandra > Issue Type: Bug > Components: CQL/Syntax >Reporter: Jeremiah Jordan >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0 > > Attachments: CASSANDRA-15271-testall.txt, CASSANDRA-15271.zip, Screen > Shot 2020-02-26 at 11.25.29 AM.png > > > CASSANDRA-13426 changed the behavior of "CLUSTERING ORDER" on "CREATE TABLE", > it now complains if you don't specify all the columns. > It was nice that previously you could just specify to make the first > clustering DESC and leave the rest ASC without needing to specify them. Also > it would be nice I think to avoid breaking changes to the CREATE TABLE syntax. > We should either update NEWS.txt to call out the breaking change there, or > update the new code to be able to default the columns which were not > mentioned. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15271) CASSANDRA-13426 changed the behavior of "CLUSTERING ORDER" on "CREATE TABLE"
[ https://issues.apache.org/jira/browse/CASSANDRA-15271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-15271: Attachment: CASSANDRA-15271.zip > CASSANDRA-13426 changed the behavior of "CLUSTERING ORDER" on "CREATE TABLE" > > > Key: CASSANDRA-15271 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15271 > Project: Cassandra > Issue Type: Bug > Components: CQL/Syntax >Reporter: Jeremiah Jordan >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0 > > Attachments: CASSANDRA-15271-testall.txt, CASSANDRA-15271.zip, Screen > Shot 2020-02-26 at 11.25.29 AM.png > > > CASSANDRA-13426 changed the behavior of "CLUSTERING ORDER" on "CREATE TABLE", > it now complains if you don't specify all the columns. > It was nice that previously you could just specify to make the first > clustering DESC and leave the rest ASC without needing to specify them. Also > it would be nice I think to avoid breaking changes to the CREATE TABLE syntax. > We should either update NEWS.txt to call out the breaking change there, or > update the new code to be able to default the columns which were not > mentioned. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15271) CASSANDRA-13426 changed the behavior of "CLUSTERING ORDER" on "CREATE TABLE"
[ https://issues.apache.org/jira/browse/CASSANDRA-15271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-15271: Attachment: Screen Shot 2020-02-26 at 11.25.29 AM.png CASSANDRA-15271-testall.txt > CASSANDRA-13426 changed the behavior of "CLUSTERING ORDER" on "CREATE TABLE" > > > Key: CASSANDRA-15271 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15271 > Project: Cassandra > Issue Type: Bug > Components: CQL/Syntax >Reporter: Jeremiah Jordan >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0 > > Attachments: CASSANDRA-15271-testall.txt, Screen Shot 2020-02-26 at > 11.25.29 AM.png > > > CASSANDRA-13426 changed the behavior of "CLUSTERING ORDER" on "CREATE TABLE", > it now complains if you don't specify all the columns. > It was nice that previously you could just specify to make the first > clustering DESC and leave the rest ASC without needing to specify them. Also > it would be nice I think to avoid breaking changes to the CREATE TABLE syntax. > We should either update NEWS.txt to call out the breaking change there, or > update the new code to be able to default the columns which were not > mentioned. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15549) NativeLibrary recommends to run Cassandra as root but users should not
[ https://issues.apache.org/jira/browse/CASSANDRA-15549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045830#comment-17045830 ] David Capwell commented on CASSANDRA-15549: --- thanks Brandon (not a committer ether ^_^). bq. The thing is we don't open pull requests directly to the apache repo for now. Directly no, but what I do is 1) commit message has jira id (eg. CASSANDRA-15549) 2) git push gives link to open PR 3) follow link and open PR That is enough to get GitHub and jira to get in-sync; mostly step #1 > NativeLibrary recommends to run Cassandra as root but users should not > -- > > Key: CASSANDRA-15549 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15549 > Project: Cassandra > Issue Type: Improvement > Components: Local/Other >Reporter: David Capwell >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-alpha > > > NativeLibrary recommends users to run Cassandra as root, should remove that > since users really shouldn’t be running Cassandra as root. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15539) Extract in-jvm API and tests out of Cassandra and into a separate repository
[ https://issues.apache.org/jira/browse/CASSANDRA-15539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045822#comment-17045822 ] David Capwell commented on CASSANDRA-15539: --- I reviewed the new repo and trunk (left comments, main ones are here), and what I am seeing is that your branches are stale which look to cause you to revert all changes since you started. Looking at the changes I see a group of changes 1) refactor to lower the dependency on Cassandra 2) general refactors to API for reasons (.verbs to .filters, etc., not clear if this is caused by being stale) 3) tests getting deleted (please don't delete tests) 4) shuffle files from one location to the next. Given what you are trying to do here, I personally feel you will go faster if you break this into sub tasks and commit each in isolation. For example, #1 and #2 could be committed quickly, followed by #4. #4 causes issues the longer the branch lives which is why I think #3 is happening. > Extract in-jvm API and tests out of Cassandra and into a separate repository > > > Key: CASSANDRA-15539 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15539 > Project: Cassandra > Issue Type: Task > Components: Test/dtest >Reporter: Alex Petrov >Assignee: Alex Petrov >Priority: Normal > Labels: pull-request-available > Time Spent: 1h 50m > Remaining Estimate: 0h > > Extract in-jvm DTest _API_ and tests into a separate repository that is > shared between Cassandra branches. Tests themselves should be buildable using > just API, which is not the case now, since cluster creation relies on impl > package, since we do not have factories / constructors in API. > Main goals we’re trying to achieve: > 1. We should be able to fail a build on API incompatibility between versions > 2. Make it as easy as possible to detect break APIs between versions. > 3. Make development of _tests_ based on in-jvm framework simpler > 4. Reduce surface area of impact when making modifications to tests > Potentially, we’d also like to use a plugin to detect API incompatibilities > between in-jvm DTest API and in-branch implementations, and start running > tests using shared in-jvm test repository with each existing implementation > in the branch. This entails both running tests for all branches whenever > there’s a change in tests jar and running tests for a specific branch > whenever the branch has changed. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15476) Transient Replication - New Feature
[ https://issues.apache.org/jira/browse/CASSANDRA-15476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Haddad updated CASSANDRA-15476: --- Reviewers: Jon Haddad (was: Blake Eggleston) > Transient Replication - New Feature > --- > > Key: CASSANDRA-15476 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15476 > Project: Cassandra > Issue Type: Sub-task > Components: Documentation/Website >Reporter: DeepakVohra >Assignee: DeepakVohra >Priority: Normal > > Added a page on transient replication, a new feature. > https://github.com/apache/cassandra/pull/405 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15604) Remove obsolete table/MV options from schema tables
Olivier Michallat created CASSANDRA-15604:
-
Summary: Remove obsolete table/MV options from schema tables
Key: CASSANDRA-15604
URL: https://issues.apache.org/jira/browse/CASSANDRA-15604
Project: Cassandra
Issue Type: Improvement
Reporter: Olivier Michallat
CASSANDRA-13910 removed the {{read_repair_chance}} and
{{dclocal_read_repair_chance}} options for tables and materialized views.
CASSANDRA-12868 made {{default_time_to_live}} illegal for materialized views.
However the corresponding columns still exist in {{system_schema.tables}} and
{{system_schema.views}}. Maybe it would make sense to remove them in Cassandra
4. Historically, obsolete options have been removed in similar cases, for
example {{compaction_strategy_class}}, {{compaction_strategy_options}} and
{{compression_parameters}} in Cassandra 2.2 => 3 (arguably there was also a
major refactoring of schema tables during that transition).
This is not a huge deal, but it would make things a bit easier for the Java
driver (our metadata exposes a "client-side describe" feature, and currently we
assume that any column in the schema table must be added to the CREATE TABLE
statement).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15553) Preview repair should include sstables from finalized incremental repair sessions
[ https://issues.apache.org/jira/browse/CASSANDRA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045773#comment-17045773 ] Blake Eggleston commented on CASSANDRA-15553: - +1, and thanks for addressing each point in it's own commit. Makes it way easier to review the changes > Preview repair should include sstables from finalized incremental repair > sessions > - > > Key: CASSANDRA-15553 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15553 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 4.0-alpha > > > When running a preview repair we currently grab all repaired sstables, > problem is that we depend on compaction to move the sstables from pending to > repaired so we might have different data marked repaired on different nodes. > Including any sstables from finalized incremental repair sessions as repaired > will solve this. > Another problem is that validations don't start at exactly the same time on > different nodes, so if an incremental repair finishes while the preview > repair is running we might also validate the wrong repaired set. We should > fail the preview repair if an intersecting incremental repair finishes during > the preview repair. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15595) Many errors of "java.lang.AssertionError: Illegal bounds"
[
https://issues.apache.org/jira/browse/CASSANDRA-15595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045772#comment-17045772
]
Brandon Williams commented on CASSANDRA-15595:
--
I didn't mean TRACE, but probabilistic tracing, as in `nodetool
settraceprobability` to capture the queries.
> Many errors of "java.lang.AssertionError: Illegal bounds"
> -
>
> Key: CASSANDRA-15595
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15595
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Caching
>Reporter: Yakir Gibraltar
>Priority: Normal
> Fix For: 3.11.7
>
>
> Hi, i'm running cassandra 3.11.6 and getting on all hosts many errors of:
> {code}
> ERROR [ReadStage-6] 2020-02-24 13:53:34,528
> AbstractLocalAwareExecutorService.java:169 - Uncaught exception on thread
> Thread[ReadStage-6,5,main]
> java.lang.AssertionError: Illegal bounds [-2102982480..-2102982472); size:
> 2761628520
> at org.apache.cassandra.io.util.Memory.checkBounds(Memory.java:345)
> ~[apache-cassandra-3.11.6.jar:3.11.6]
> at org.apache.cassandra.io.util.Memory.getLong(Memory.java:254)
> ~[apache-cassandra-3.11.6.jar:3.11.6]
> at
> org.apache.cassandra.io.compress.CompressionMetadata.chunkFor(CompressionMetadata.java:234)
> ~[apache-cassandra-3.11.6.jar:3.11.6]
> at
> org.apache.cassandra.io.util.CompressedChunkReader$Standard.readChunk(CompressedChunkReader.java:114)
> ~[apache-cassandra-3.11.6.ja
> r:3.11.6]
> at org.apache.cassandra.cache.ChunkCache.load(ChunkCache.java:158)
> ~[apache-cassandra-3.11.6.jar:3.11.6]
> at org.apache.cassandra.cache.ChunkCache.load(ChunkCache.java:39)
> ~[apache-cassandra-3.11.6.jar:3.11.6]
> at
> com.github.benmanes.caffeine.cache.BoundedLocalCache$BoundedLocalLoadingCache.lambda$new$0(BoundedLocalCache.java:2949)
> ~[caffeine-2.2.6.jar:na]
> at
> com.github.benmanes.caffeine.cache.BoundedLocalCache.lambda$doComputeIfAbsent$15(BoundedLocalCache.java:1807)
> ~[caffeine-2.2.6.jar:na]
> at
> java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1853)
> ~[na:1.8.0-zing_19.12.102.0]
> at
> com.github.benmanes.caffeine.cache.BoundedLocalCache.doComputeIfAbsent(BoundedLocalCache.java:1805)
> ~[caffeine-2.2.6.jar:na]
> at
> com.github.benmanes.caffeine.cache.BoundedLocalCache.computeIfAbsent(BoundedLocalCache.java:1788)
> ~[caffeine-2.2.6.jar:na]
> at
> com.github.benmanes.caffeine.cache.LocalCache.computeIfAbsent(LocalCache.java:97)
> ~[caffeine-2.2.6.jar:na]
> at
> com.github.benmanes.caffeine.cache.LocalLoadingCache.get(LocalLoadingCache.java:66)
> ~[caffeine-2.2.6.jar:na]
> at
> org.apache.cassandra.cache.ChunkCache$CachingRebufferer.rebuffer(ChunkCache.java:236)
> ~[apache-cassandra-3.11.6.jar:3.11.6]
> at
> org.apache.cassandra.cache.ChunkCache$CachingRebufferer.rebuffer(ChunkCache.java:214)
> ~[apache-cassandra-3.11.6.jar:3.11.6]
> at
> org.apache.cassandra.io.util.RandomAccessReader.reBufferAt(RandomAccessReader.java:65)
> ~[apache-cassandra-3.11.6.jar:3.11.6]
> at
> org.apache.cassandra.io.util.RandomAccessReader.seek(RandomAccessReader.java:207)
> ~[apache-cassandra-3.11.6.jar:3.11.6]
> at
> org.apache.cassandra.io.util.FileHandle.createReader(FileHandle.java:150)
> ~[apache-cassandra-3.11.6.jar:3.11.6]
> at
> org.apache.cassandra.io.sstable.format.SSTableReader.getFileDataInput(SSTableReader.java:1807)
> ~[apache-cassandra-3.11.6.jar:3.11.6]
> at
> org.apache.cassandra.db.columniterator.AbstractSSTableIterator.(AbstractSSTableIterator.java:103)
> ~[apache-cassandra-3.11.6.jar:3.11.6]
> at
> org.apache.cassandra.db.columniterator.SSTableIterator.(SSTableIterator.java:49)
> ~[apache-cassandra-3.11.6.jar:3.11.6]
> at
> org.apache.cassandra.io.sstable.format.big.BigTableReader.iterator(BigTableReader.java:72)
> ~[apache-cassandra-3.11.6.jar:3.11.6]
> at
> org.apache.cassandra.io.sstable.format.big.BigTableReader.iterator(BigTableReader.java:65)
> ~[apache-cassandra-3.11.6.jar:3.11.6]
> at
> org.apache.cassandra.db.StorageHook$1.makeRowIterator(StorageHook.java:100)
> ~[apache-cassandra-3.11.6.jar:3.11.6]
> at
> org.apache.cassandra.db.SinglePartitionReadCommand.queryMemtableAndSSTablesInTimestampOrder(SinglePartitionReadCommand.java:982)
> ~[apache-cassandra-3.11.6.jar:3.11.6]
> at
> org.apache.cassandra.db.SinglePartitionReadCommand.queryMemtableAndDiskInternal(SinglePartitionReadCommand.java:693)
> ~[apache-cassandra-3.11.6.jar:3.11.6]
> at
> org.apache.cassandra.db.SinglePartitionReadCommand.queryMemtableAndDisk(SinglePartitionReadCommand.java:670)
> ~[apache-cassandra-3.11.6.jar:3.11.6]
[jira] [Updated] (CASSANDRA-15567) Allow EXTRA_CLASSPATH to work in tarball/source installations
[ https://issues.apache.org/jira/browse/CASSANDRA-15567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-15567: - Fix Version/s: (was: 4.0-beta) (was: 3.11.x) (was: 3.0.x) (was: 2.2.x) 4.0-alpha 3.11.7 3.0.21 2.2.17 Source Control Link: https://github.com/apache/cassandra/commit/324267b3c0676ad31bd4f2fac0e2e673a9257a37 Resolution: Fixed Status: Resolved (was: Ready to Commit) Committed w/your version for trunk. > Allow EXTRA_CLASSPATH to work in tarball/source installations > - > > Key: CASSANDRA-15567 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15567 > Project: Cassandra > Issue Type: Improvement > Components: Local/Scripts >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 2.2.17, 3.0.21, 3.11.7, 4.0-alpha > > > Both the debian and redhat packaging modify cassandra.in.sh to support the > EXTRA_CLASSPATH variable. It would be nice to just put this in > cassandra.in.sh proper so people without a package installation can use it as > well. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.0' into cassandra-3.11
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 1b29401e2a7c822e32567c5b062032f7e9f85484 Merge: aaef02e 461ae2b Author: Brandon Williams AuthorDate: Wed Feb 26 11:48:10 2020 -0600 Merge branch 'cassandra-3.0' into cassandra-3.11 CHANGES.txt | 5 + bin/cassandra | 1 + bin/cassandra.in.sh | 3 +++ 3 files changed, 9 insertions(+) diff --cc CHANGES.txt index a8baa44,aa00edd..a4a6c12 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,15 -1,9 +1,17 @@@ -3.0.21 +3.11.7 +Merged from 3.0: * Run evictFromMembership in GossipStage (CASSANDRA-15592) + Merged from 2.2 + * Allow EXTRA_CLASSPATH to work on tar/source installations (CASSANDRA-15567) -3.0.20 + +3.11.6 + * Fix bad UDT sstable metadata serialization headers written by C* 3.0 on upgrade and in sstablescrub (CASSANDRA-15035) + * Fix nodetool compactionstats showing extra pending task for TWCS - patch implemented (CASSANDRA-15409) + * Fix SELECT JSON formatting for the "duration" type (CASSANDRA-15075) + * Fix LegacyLayout to have same behavior as 2.x when handling unknown column names (CASSANDRA-15081) + * Update nodetool help stop output (CASSANDRA-15401) +Merged from 3.0: * Run in-jvm upgrade dtests in circleci (CASSANDRA-15506) * Include updates to static column in mutation size calculations (CASSANDRA-15293) * Fix point-in-time recoevery ignoring timestamp of updates to static columns (CASSANDRA-15292) @@@ -27,7 -21,9 +29,10 @@@ * Make sure index summary redistribution does not start when compactions are paused (CASSANDRA-15265) * Ensure legacy rows have primary key livenessinfo when they contain illegal cells (CASSANDRA-15365) * Fix race condition when setting bootstrap flags (CASSANDRA-14878) +Merged from 2.2: + * Fix NativeLibrary.tryOpenDirectory callers for Windows (CASSANDRA-15426) + + 2.2.16 * Fix SELECT JSON output for empty blobs (CASSANDRA-15435) * In-JVM DTest: Set correct internode message version for upgrade test (CASSANDRA-15371) * In-JVM DTest: Support NodeTool in dtest (CASSANDRA-15429) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-2.2' into cassandra-3.0
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch cassandra-3.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 461ae2b2cabfcd94076b4ad1f97f8257e3a8b364 Merge: 95197ce b2b1b46 Author: Brandon Williams AuthorDate: Wed Feb 26 11:47:26 2020 -0600 Merge branch 'cassandra-2.2' into cassandra-3.0 CHANGES.txt | 5 - bin/cassandra | 1 + bin/cassandra.in.sh | 3 +++ 3 files changed, 8 insertions(+), 1 deletion(-) diff --cc CHANGES.txt index e2614ec,9ecfcb4..aa00edd --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,65 -1,15 +1,68 @@@ -2.2.17 +3.0.21 + * Run evictFromMembership in GossipStage (CASSANDRA-15592) ++Merged from 2.2 + * Allow EXTRA_CLASSPATH to work on tar/source installations (CASSANDRA-15567) +3.0.20 + * Run in-jvm upgrade dtests in circleci (CASSANDRA-15506) + * Include updates to static column in mutation size calculations (CASSANDRA-15293) + * Fix point-in-time recoevery ignoring timestamp of updates to static columns (CASSANDRA-15292) + * GC logs are also put under $CASSANDRA_LOG_DIR (CASSANDRA-14306) + * Fix sstabledump's position key value when partitions have multiple rows (CASSANDRA-14721) + * Avoid over-scanning data directories in LogFile.verify() (CASSANDRA-15364) + * Bump generations and document changes to system_distributed and system_traces in 3.0, 3.11 + (CASSANDRA-15441) + * Fix system_traces creation timestamp; optimise system keyspace upgrades (CASSANDRA-15398) + * Fix various data directory prefix matching issues (CASSANDRA-13974) + * Minimize clustering values in metadata collector (CASSANDRA-15400) + * Avoid over-trimming of results in mixed mode clusters (CASSANDRA-15405) + * validate value sizes in LegacyLayout (CASSANDRA-15373) + * Ensure that tracing doesn't break connections in 3.x/4.0 mixed mode by default (CASSANDRA-15385) + * Make sure index summary redistribution does not start when compactions are paused (CASSANDRA-15265) + * Ensure legacy rows have primary key livenessinfo when they contain illegal cells (CASSANDRA-15365) + * Fix race condition when setting bootstrap flags (CASSANDRA-14878) + * Fix NativeLibrary.tryOpenDirectory callers for Windows (CASSANDRA-15426) - Merged from 2.2 ++ + 2.2.16 * Fix SELECT JSON output for empty blobs (CASSANDRA-15435) * In-JVM DTest: Set correct internode message version for upgrade test (CASSANDRA-15371) - * In-JVM DTest: Support NodeTool in dtest + * In-JVM DTest: Support NodeTool in dtest (CASSANDRA-15429) -2.2.15 +3.0.19 + * Add ability to cap max negotiable protocol version (CASSANDRA-15193) + * Gossip tokens on startup if available (CASSANDRA-15335) + * Fix resource leak in CompressedSequentialWriter (CASSANDRA-15340) + * Fix merge which reverted CASSANDRA-14993 (CASSANDRA-15289) + * Fix LegacyLayout RangeTombstoneList IndexOutOfBoundsException when upgrading and RangeTombstone bounds are asymmetric (CASSANDRA-15172) + * Fix NPE when using allocate_tokens_for_keyspace on new DC/rack (CASSANDRA-14952) + * Filter sstables earlier when running cleanup (CASSANDRA-15100) + * Use mean row count instead of mean column count for index selectivity calculation (CASSANDRA-15259) + * Avoid updating unchanged gossip states (CASSANDRA-15097) + * Prevent recreation of previously dropped columns with a different kind (CASSANDRA-14948) + * Prevent client requests from blocking on executor task queue (CASSANDRA-15013) + * Toughen up column drop/recreate type validations (CASSANDRA-15204) + * LegacyLayout should handle paging states that cross a collection column (CASSANDRA-15201) + * Prevent RuntimeException when username or password is empty/null (CASSANDRA-15198) + * Multiget thrift query returns null records after digest mismatch (CASSANDRA-14812) + * Skipping illegal legacy cells can break reverse iteration of indexed partitions (CASSANDRA-15178) + * Handle paging states serialized with a different version than the session's (CASSANDRA-15176) + * Throw IOE instead of asserting on unsupporter peer versions (CASSANDRA-15066) + * Update token metadata when handling MOVING/REMOVING_TOKEN events (CASSANDRA-15120) + * Add ability to customize cassandra log directory using $CASSANDRA_LOG_DIR (CASSANDRA-15090) + * Skip cells with illegal column names when reading legacy sstables (CASSANDRA-15086) + * Fix assorted gossip races and add related runtime checks (CASSANDRA-15059) + * Fix mixed mode partition range scans with limit (CASSANDRA-15072) + * cassandra-stress works with frozen collections: list and set (CASSANDRA-14907) + * For nodetool listsnapshots output, put spaces between columns, and increase snapshot padding (CASSANDRA-14876) + * Fix handling FS errors on writing and reading flat files - LogTransaction and hints (CASSANDRA-15053) + * Avoid double closing the iterator to avoid overcounting the number of requests (CASSANDRA-15058) + * Improve
[cassandra] branch cassandra-3.0 updated (95197ce -> 461ae2b)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch cassandra-3.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 95197ce Run evictFromMembership in GossipStage new b2b1b46 Allow EXTRA_CLASSPATH to work on tar/source installations new 461ae2b Merge branch 'cassandra-2.2' into cassandra-3.0 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt | 5 - bin/cassandra | 1 + bin/cassandra.in.sh | 3 +++ 3 files changed, 8 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-2.2 updated: Allow EXTRA_CLASSPATH to work on tar/source installations
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch cassandra-2.2 in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/cassandra-2.2 by this push: new b2b1b46 Allow EXTRA_CLASSPATH to work on tar/source installations b2b1b46 is described below commit b2b1b46486ac0f9c3e5293aa1f6a3dd821278f8f Author: Brandon Williams AuthorDate: Fri Feb 14 13:16:45 2020 -0600 Allow EXTRA_CLASSPATH to work on tar/source installations Patch by brandonwillams, reviewed by David Capwell for CASSANDRA-15567 --- CHANGES.txt | 2 +- bin/cassandra | 1 + bin/cassandra.in.sh | 3 +++ 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGES.txt b/CHANGES.txt index 27c2f5b..9ecfcb4 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,5 +1,5 @@ 2.2.17 - * + * Allow EXTRA_CLASSPATH to work on tar/source installations (CASSANDRA-15567) 2.2.16 * Fix SELECT JSON output for empty blobs (CASSANDRA-15435) diff --git a/bin/cassandra b/bin/cassandra index 0e337e8..7a1dcbd 100755 --- a/bin/cassandra +++ b/bin/cassandra @@ -27,6 +27,7 @@ # behavior, those variables are: # # CLASSPATH -- A Java classpath containing everything necessary to run. +# EXTRA_CLASSPATH -- A Java classpath with anything to be appended to CLASSPATH # JVM_OPTS -- Additional arguments to the JVM for heap size, etc # JVM_ON_OUT_OF_MEMORY_ERROR_OPT -- The OnOutOfMemoryError JVM option if specified # CASSANDRA_CONF -- Directory containing Cassandra configuration files. diff --git a/bin/cassandra.in.sh b/bin/cassandra.in.sh index 92f79c7..13b1291 100644 --- a/bin/cassandra.in.sh +++ b/bin/cassandra.in.sh @@ -48,6 +48,9 @@ done for jsr223jar in "$CASSANDRA_HOME"/lib/jsr223/*/*.jar; do CLASSPATH="$CLASSPATH:$jsr223jar" done + +CLASSPATH="$CLASSPATH:$EXTRA_CLASSPATH" + # JSR223/JRuby - set ruby lib directory if [ -d "$CASSANDRA_HOME"/lib/jsr223/jruby/ruby ] ; then export JVM_OPTS="$JVM_OPTS -Djruby.lib=$CASSANDRA_HOME/lib/jsr223/jruby" - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.11' into trunk
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 324267b3c0676ad31bd4f2fac0e2e673a9257a37 Merge: 958aa79 1b29401 Author: Brandon Williams AuthorDate: Wed Feb 26 11:48:29 2020 -0600 Merge branch 'cassandra-3.11' into trunk CHANGES.txt | 2 ++ bin/cassandra| 1 + bin/cassandra.in.sh | 3 +++ debian/patches/cassandra_in.sh_dirs.diff | 11 --- 4 files changed, 10 insertions(+), 7 deletions(-) diff --cc CHANGES.txt index a7f3e89,a4a6c12..ab91023 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,63 -1,11 +1,65 @@@ -3.11.7 +4.0-alpha4 + * Correct inaccurate logging message (CASSANDRA-15549) + * Add documentation of dynamo (CASSANDRA-15486) + * Added documentation for Guarantees (CASSANDRA-15482) + * Added documentation for audit logging (CASSANDRA-15474) + * Unset GREP_OPTIONS (CASSANDRA-14487) + * Added streaming documentation (CASSANDRA-15477) + * Update to Python driver 3.21 for cqlsh (CASSANDRA-14872) + * Added bulk loading documentation (CASSANDRA-15480) + * Updated overview documentation (CASSANDRA-15483) + * Added CDC and speculative retry documentation to DDL section (CASSANDRA-15492) + * Fix missing Keyspaces in cqlsh describe output (CASSANDRA-15576) + * Fix multi DC nodetool status output (CASSANDRA-15305) + * Added documentation covering new Netty based internode messaging (CASSANDRA-15478) + * Add documentation of hints (CASSANDRA-15491) + * updateCoordinatorWriteLatencyTableMetric can produce misleading metrics (CASSANDRA-15569) + * Added documentation for read repair and an example of full repair (CASSANDRA-15485) + * Make cqlsh and cqlshlib Python 2 & 3 compatible (CASSANDRA-10190) + * Added documentation for Full Query Logging (CASSANDRA-15475) + * Added documentation for backups (CASSANDRA-15479) + * Documentation gives the wrong instruction to activate remote jmx (CASSANDRA-15535) + * Improve the description of nodetool listsnapshots command (CASSANDRA-14587) + * allow embedded cassandra launched from a one-jar or uno-jar (CASSANDRA-15494) + * Update hppc library to version 0.8.1 (CASSANDRA-12995) + * Limit the dependencies used by UDFs/UDAs (CASSANDRA-14737) + * Make native_transport_max_concurrent_requests_in_bytes updatable (CASSANDRA-15519) + * Cleanup and improvements to IndexInfo/ColumnIndex (CASSANDRA-15469) + * Potential Overflow in DatabaseDescriptor Functions That Convert Between KB/MB & Bytes (CASSANDRA-15470) Merged from 3.0: - * Run evictFromMembership in GossipStage (CASSANDRA-15592) -Merged from 2.2 - * Allow EXTRA_CLASSPATH to work on tar/source installations (CASSANDRA-15567) - +* Run evictFromMembership in GossipStage (CASSANDRA-15592) ++Merged from 2.2: ++* Allow EXTRA_CLASSPATH to work on tar/source installations (CASSANDRA-15567) -3.11.6 +4.0-alpha3 + * Restore monotonic read consistency guarantees for blocking read repair (CASSANDRA-14740) + * Separate exceptions for CAS write timeout exceptions caused by contention and unkown result (CASSANDRA-15350) + * Fix in-jvm dtest java 11 compatibility (CASSANDRA-15463) + * Remove joda time dependency (CASSANDRA-15257) + * Exclude purgeable tombstones from repaired data tracking (CASSANDRA-15462) + * Exclude legacy counter shards from repaired data tracking (CASSANDRA-15461) + * Make it easier to add trace headers to messages (CASSANDRA-15499) + * Fix and optimise partial compressed sstable streaming (CASSANDRA-13938) + * Improve error when JVM 11 can't access required modules (CASSANDRA-15468) + * Better handling of file deletion failures by DiskFailurePolicy (CASSANDRA-15143) + * Prevent read repair mutations from increasing read timeout (CASSANDRA-15442) + * Document 4.0 system keyspace changes, bump generations (CASSANDRA-15454) + * Make it possible to disable STCS-in-L0 during runtime (CASSANDRA-15445) + * Removed obsolete OldNetworkTopologyStrategy (CASSANDRA-13990) + * Align record header of FQL and audit binary log (CASSANDRA-15076) + * Shuffle forwarding replica for messages to non-local DC (CASSANDRA-15318) + * Optimise native protocol ASCII string encoding (CASSANDRA-15410) + * Make sure all exceptions are propagated in DebuggableThreadPoolExecutor (CASSANDRA-15332) + * Make it possible to resize concurrent read / write thread pools at runtime (CASSANDRA-15277) + * Close channels on error (CASSANDRA-15407) + * Add documentation for Java 11 support in Cassandra (CASSANDRA-15428) + * Integrate SJK into nodetool (CASSANDRA-12197) + * Ensure that empty clusterings with kind==CLUSTERING are Clustering.EMPTY (CASSANDRA-15498) + * The flag 'cross_node_timeout' has been set as true by default. This change + is done under the assumption that users have setup NTP on their clusters or + otherwise synchronize their
[cassandra] branch trunk updated (958aa79 -> 324267b)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 958aa79 Correct inaccurate logging message about running as root. new b2b1b46 Allow EXTRA_CLASSPATH to work on tar/source installations new 461ae2b Merge branch 'cassandra-2.2' into cassandra-3.0 new 1b29401 Merge branch 'cassandra-3.0' into cassandra-3.11 new 324267b Merge branch 'cassandra-3.11' into trunk The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt | 2 ++ bin/cassandra| 1 + bin/cassandra.in.sh | 3 +++ debian/patches/cassandra_in.sh_dirs.diff | 11 --- 4 files changed, 10 insertions(+), 7 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.11 updated (aaef02e -> 1b29401)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from aaef02e Merge branch 'cassandra-3.0' into cassandra-3.11 new b2b1b46 Allow EXTRA_CLASSPATH to work on tar/source installations new 461ae2b Merge branch 'cassandra-2.2' into cassandra-3.0 new 1b29401 Merge branch 'cassandra-3.0' into cassandra-3.11 The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt | 5 + bin/cassandra | 1 + bin/cassandra.in.sh | 3 +++ 3 files changed, 9 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15567) Allow EXTRA_CLASSPATH to work in tarball/source installations
[ https://issues.apache.org/jira/browse/CASSANDRA-15567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15567: -- Reviewers: David Capwell, David Capwell (was: David Capwell) David Capwell, David Capwell (was: David Capwell) Status: Review In Progress (was: Patch Available) > Allow EXTRA_CLASSPATH to work in tarball/source installations > - > > Key: CASSANDRA-15567 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15567 > Project: Cassandra > Issue Type: Improvement > Components: Local/Scripts >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta > > > Both the debian and redhat packaging modify cassandra.in.sh to support the > EXTRA_CLASSPATH variable. It would be nice to just put this in > cassandra.in.sh proper so people without a package installation can use it as > well. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15567) Allow EXTRA_CLASSPATH to work in tarball/source installations
[
https://issues.apache.org/jira/browse/CASSANDRA-15567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045740#comment-17045740
]
David Capwell commented on CASSANDRA-15567:
---
bq. I noticed on trunk that it was repeating the jar additions for some reason
(which is probably why you thought I was putting it before),
If I run without your patch I get
{code}
for jar in "$CASSANDRA_HOME"/lib/*.jar; do
CLASSPATH="$CLASSPATH:$jar"
done
for jar in "$CASSANDRA_HOME"/*.jar; do
CLASSPATH="$CLASSPATH:$jar"
done
# Include EXTRA_CLASSPATH from /etc/default/cassandra
CLASSPATH="$CLASSPATH:$EXTRA_CLASSPATH"
# JSR223 - collect all JSR223 engines' jars
for jsr223jar in "$CASSANDRA_HOME"/lib/jsr223/*/*.jar; do
CLASSPATH="$CLASSPATH:$jsr223jar"
done
{code}
With your patch
{code}
for jar in "$CASSANDRA_HOME"/lib/*.jar; do
CLASSPATH="$CLASSPATH:$jar"
done
CLASSPATH="$CLASSPATH:$EXTRA_CLASSPATH"
# JSR223 - collect all JSR223 engines' jars
for jsr223jar in "$CASSANDRA_HOME"/lib/jsr223/*/*.jar; do
CLASSPATH="$CLASSPATH:$jsr223jar"
done
{code}
So the "$CASSANDRA_HOME"/*.jar; pattern is getting dropped (removed from the
diff). This was added in CASSANDRA-14710 and I don't know why HOME would have
jars (I need to figure out how to build the packages... created CASSANDRA-15603
to get Circle CI to at least build them) so I can't say if its ok to drop or
not.
I am +1 if you add back the other jar loop.
Here is the patch file which works for me
{code}
$ cat debian/patches/cassandra_in.sh_dirs.diff
--- a/bin/cassandra.in.sh
+++ b/bin/cassandra.in.sh
@@ -14,17 +14,17 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-if [ "x$CASSANDRA_HOME" = "x" ]; then
-CASSANDRA_HOME="`dirname "$0"`/.."
-fi
+CASSANDRA_HOME=/usr/share/cassandra
# The directory where Cassandra's configs live (required)
-if [ "x$CASSANDRA_CONF" = "x" ]; then
-CASSANDRA_CONF="$CASSANDRA_HOME/conf"
-fi
+CASSANDRA_CONF=/etc/cassandra
# The java classpath (required)
-CLASSPATH="$CASSANDRA_CONF"
+if [ -n "$CLASSPATH" ]; then
+CLASSPATH=$CLASSPATH:$CASSANDRA_CONF
+else
+CLASSPATH="$CASSANDRA_CONF"
+fi
# This can be the path to a jar file, or a directory containing the
# compiled classes. NOTE: This isn't needed by the startup script,
@@ -38,7 +38,7 @@ fi
# the default location for commitlogs, sstables, and saved caches
# if not set in cassandra.yaml
-cassandra_storagedir="$CASSANDRA_HOME/data"
+cassandra_storagedir=/var/lib/cassandra
# JAVA_HOME can optionally be set here
#JAVA_HOME=/usr/local/jdk6
@@ -47,6 +47,10 @@ for jar in "$CASSANDRA_HOME"/lib/*.jar; do
CLASSPATH="$CLASSPATH:$jar"
done
+for jar in "$CASSANDRA_HOME"/*.jar; do
+CLASSPATH="$CLASSPATH:$jar"
+done
+
CLASSPATH="$CLASSPATH:$EXTRA_CLASSPATH"
# JSR223 - collect all JSR223 engines' jars
{code}
> Allow EXTRA_CLASSPATH to work in tarball/source installations
> -
>
> Key: CASSANDRA-15567
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15567
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Scripts
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta
>
>
> Both the debian and redhat packaging modify cassandra.in.sh to support the
> EXTRA_CLASSPATH variable. It would be nice to just put this in
> cassandra.in.sh proper so people without a package installation can use it as
> well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15567) Allow EXTRA_CLASSPATH to work in tarball/source installations
[ https://issues.apache.org/jira/browse/CASSANDRA-15567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15567: -- Status: Ready to Commit (was: Review In Progress) > Allow EXTRA_CLASSPATH to work in tarball/source installations > - > > Key: CASSANDRA-15567 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15567 > Project: Cassandra > Issue Type: Improvement > Components: Local/Scripts >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta > > > Both the debian and redhat packaging modify cassandra.in.sh to support the > EXTRA_CLASSPATH variable. It would be nice to just put this in > cassandra.in.sh proper so people without a package installation can use it as > well. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15595) Many errors of "java.lang.AssertionError: Illegal bounds"
[
https://issues.apache.org/jira/browse/CASSANDRA-15595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045735#comment-17045735
]
Yakir Gibraltar commented on CASSANDRA-15595:
-
I see the errors only in C* logs, example of logs with TRACE:
{code}
TRACE [Native-Transport-Requests-106] 2020-02-26 12:19:47,836
DigestResolver.java:96 - resolve: 0 ms.
TRACE [Native-Transport-Requests-207] 2020-02-26 12:19:47,836 Message.java:685
- Received: QUERY INSERT INTO ud.i_s (user_id,data) VALUES (?,?) USING TTL
7776000;[pageSize = 1000], v=4/v4
TRACE [Native-Transport-Requests-210] 2020-02-26 12:19:47,833
MessagingService.java:942 - /1.2.3.5 sending READ to -946659607@/1.2.3.15
TRACE [Native-Transport-Requests-44] 2020-02-26 12:19:47,834
StorageProxy.java:1352 - Adding FWD message to -946659552@/1.2.3.22
TRACE [Native-Transport-Requests-28] 2020-02-26 12:19:47,836
ReadCallback.java:101 - Blockfor is 2; setting up requests to /1.2.3.3,/1.2.3.14
TRACE [Native-Transport-Requests-118] 2020-02-26 12:19:47,833
ReadCallback.java:101 - Blockfor is 2; setting up requests to
/1.2.3.24,/1.2.3.23
TRACE [Native-Transport-Requests-18] 2020-02-26 12:19:47,833
StorageProxy.java:1357 - Sending message to -946659650@/1.2.3.25
TRACE [Native-Transport-Requests-127] 2020-02-26 12:19:47,824
StorageProxy.java:1352 - Adding FWD message to -946659949@/1.2.3.26
TRACE [Native-Transport-Requests-44] 2020-02-26 12:19:47,836
StorageProxy.java:1352 - Adding FWD message to -946659505@/1.2.3.27
TRACE [Native-Transport-Requests-28] 2020-02-26 12:19:47,836
AbstractReadExecutor.java:108 - reading data from /1.2.3.3
TRACE [Native-Transport-Requests-29] 2020-02-26 12:19:47,833 Message.java:704 -
Responding: EMPTY RESULT, v=4/v4
TRACE [Native-Transport-Requests-18] 2020-02-26 12:19:47,836
StorageProxy.java:1352 - Adding FWD message to -946659504@/1.2.3.37
TRACE [Native-Transport-Requests-22] 2020-02-26 12:19:47,834
ReadCallback.java:101 - Blockfor is 2; setting up requests to
/1.2.3.24,/1.2.3.12
TRACE [Native-Transport-Requests-44] 2020-02-26 12:19:47,836
MessagingService.java:942 - /1.2.3.5 sending MUTATION to -946659502@/1.2.3.28
TRACE [Native-Transport-Requests-62] 2020-02-26 12:19:47,833
StorageProxy.java:1357 - Sending message to -946659698@/1.2.3.37
TRACE [MutationStage-87] 2020-02-26 12:19:47,834 MessagingService.java:942 -
/1.2.3.5 sending REQUEST_RESPONSE to -946659658@/1.2.3.5
TRACE [Native-Transport-Requests-118] 2020-02-26 12:19:47,836
AbstractReadExecutor.java:108 - reading data from /1.2.3.24
TRACE [Native-Transport-Requests-5] 2020-02-26 12:19:47,834
MessagingService.java:942 - /1.2.3.5 sending MUTATION to -946659548@/1.2.3.29
TRACE [Native-Transport-Requests-64] 2020-02-26 12:19:47,833
MessagingService.java:942 - /1.2.3.5 sending MUTATION to -946659602@/1.2.3.30
TRACE [Native-Transport-Requests-3] 2020-02-26 12:19:47,833
MessagingService.java:942 - /1.2.3.5 sending READ to -946659600@/1.2.3.17
ERROR [ReadStage-110] 2020-02-26 12:19:47,836
AbstractLocalAwareExecutorService.java:169 - Uncaught exception on thread
Thread[ReadStage-110,5,main]
java.lang.AssertionError: Illegal bounds [-1777439288..-1777439280); size:
2761628520
at org.apache.cassandra.io.util.Memory.checkBounds(Memory.java:345)
~[apache-cassandra-3.11.6.jar:3.11.6]
at org.apache.cassandra.io.util.Memory.getLong(Memory.java:254)
~[apache-cassandra-3.11.6.jar:3.11.6]
at
org.apache.cassandra.io.compress.CompressionMetadata.chunkFor(CompressionMetadata.java:234)
~[apache-cassandra-3.11.6.jar:3.11.6]
at
org.apache.cassandra.io.util.CompressedChunkReader$Standard.readChunk(CompressedChunkReader.java:114)
~[apache-cassandra-3.11.6.jar:3.11.6]
at org.apache.cassandra.cache.ChunkCache.load(ChunkCache.java:158)
~[apache-cassandra-3.11.6.jar:3.11.6]
at org.apache.cassandra.cache.ChunkCache.load(ChunkCache.java:39)
~[apache-cassandra-3.11.6.jar:3.11.6]
at
com.github.benmanes.caffeine.cache.BoundedLocalCache$BoundedLocalLoadingCache.lambda$new$0(BoundedLocalCache.java:2949)
~[caffeine-2.2.6.jar:na]
at
com.github.benmanes.caffeine.cache.BoundedLocalCache.lambda$doComputeIfAbsent$15(BoundedLocalCache.java:1807)
~[caffeine-2.2.6.jar:na]
at
java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1853)
~[na:1.8.0-zing_19.12.102.0]
at
com.github.benmanes.caffeine.cache.BoundedLocalCache.doComputeIfAbsent(BoundedLocalCache.java:1805)
~[caffeine-2.2.6.jar:na]
at
com.github.benmanes.caffeine.cache.BoundedLocalCache.computeIfAbsent(BoundedLocalCache.java:1788)
~[caffeine-2.2.6.jar:na]
at
com.github.benmanes.caffeine.cache.LocalCache.computeIfAbsent(LocalCache.java:97)
~[caffeine-2.2.6.jar:na]
at
com.github.benmanes.caffeine.cache.LocalLoadingCache.get(LocalLoadingCache.java:66)
~[caffeine-2.2.6.jar:na]
at
[jira] [Commented] (CASSANDRA-15567) Allow EXTRA_CLASSPATH to work in tarball/source installations
[ https://issues.apache.org/jira/browse/CASSANDRA-15567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045726#comment-17045726 ] Brandon Williams commented on CASSANDRA-15567: -- Hmm, the redhat version doesn't even have the jsr223 stuff. Maybe it needs updating too. I think having EXTRA_CLASSPATH last makes the most sense, so I'll do that on commit if you're good with the trunk patch. > Allow EXTRA_CLASSPATH to work in tarball/source installations > - > > Key: CASSANDRA-15567 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15567 > Project: Cassandra > Issue Type: Improvement > Components: Local/Scripts >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta > > > Both the debian and redhat packaging modify cassandra.in.sh to support the > EXTRA_CLASSPATH variable. It would be nice to just put this in > cassandra.in.sh proper so people without a package installation can use it as > well. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15567) Allow EXTRA_CLASSPATH to work in tarball/source installations
[ https://issues.apache.org/jira/browse/CASSANDRA-15567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045722#comment-17045722 ] David Capwell commented on CASSANDRA-15567: --- bq. It puts it after the normal CP stuff, but before the jsr223 stuff, which is what I did (I actually used it as a guide.) I'm not opposed to putting it after, though. I was looking at redhat which looks after, but Debian looks like your version; since they are in-consistent I am fine with either. > Allow EXTRA_CLASSPATH to work in tarball/source installations > - > > Key: CASSANDRA-15567 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15567 > Project: Cassandra > Issue Type: Improvement > Components: Local/Scripts >Reporter: Brandon Williams >Assignee: David Capwell >Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta > > > Both the debian and redhat packaging modify cassandra.in.sh to support the > EXTRA_CLASSPATH variable. It would be nice to just put this in > cassandra.in.sh proper so people without a package installation can use it as > well. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-15567) Allow EXTRA_CLASSPATH to work in tarball/source installations
[ https://issues.apache.org/jira/browse/CASSANDRA-15567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell reassigned CASSANDRA-15567: - Assignee: Brandon Williams (was: David Capwell) > Allow EXTRA_CLASSPATH to work in tarball/source installations > - > > Key: CASSANDRA-15567 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15567 > Project: Cassandra > Issue Type: Improvement > Components: Local/Scripts >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta > > > Both the debian and redhat packaging modify cassandra.in.sh to support the > EXTRA_CLASSPATH variable. It would be nice to just put this in > cassandra.in.sh proper so people without a package installation can use it as > well. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-15567) Allow EXTRA_CLASSPATH to work in tarball/source installations
[ https://issues.apache.org/jira/browse/CASSANDRA-15567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell reassigned CASSANDRA-15567: - Assignee: David Capwell (was: Brandon Williams) > Allow EXTRA_CLASSPATH to work in tarball/source installations > - > > Key: CASSANDRA-15567 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15567 > Project: Cassandra > Issue Type: Improvement > Components: Local/Scripts >Reporter: Brandon Williams >Assignee: David Capwell >Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta > > > Both the debian and redhat packaging modify cassandra.in.sh to support the > EXTRA_CLASSPATH variable. It would be nice to just put this in > cassandra.in.sh proper so people without a package installation can use it as > well. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15564) Refactor repair coordinator so errors are consistent
[ https://issues.apache.org/jira/browse/CASSANDRA-15564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045706#comment-17045706 ] David Capwell edited comment on CASSANDRA-15564 at 2/26/20 5:06 PM: [~ifesdjeen] [~cnlwsu] [~djoshi] I have fixed or replied to all comments; please review. [~bdeggleston] can you also review? Would appreciate your feedback here. was (Author: dcapwell): [~ifesdjeen][~cnlwsu] [~djoshi] I have fixed or replied to all comments; please review. [~bdeggleston] can you also review? Would appreciate your feedback here. > Refactor repair coordinator so errors are consistent > > > Key: CASSANDRA-15564 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15564 > Project: Cassandra > Issue Type: Sub-task > Components: Consistency/Repair >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Time Spent: 10.5h > Remaining Estimate: 0h > > This is to split the change in CASSANDRA-15399 so the refactor is isolated > out. > Currently the repair coordinator special cases the exit cases at each call > site; this makes it so that errors can be inconsistent and there are cases > where proper complete isn't done (proper notifications, and forgetting to > update ActiveRepairService). > [Circle > CI|https://circleci.com/gh/dcapwell/cassandra/tree/bug%2FrepairCoordinatorJmxConsistency] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15564) Refactor repair coordinator so errors are consistent
[ https://issues.apache.org/jira/browse/CASSANDRA-15564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045706#comment-17045706 ] David Capwell commented on CASSANDRA-15564: --- [~ifesdjeen][~cnlwsu] [~djoshi] I have fixed or replied to all comments; please review. [~bdeggleston] can you also review? Would appreciate your feedback here. > Refactor repair coordinator so errors are consistent > > > Key: CASSANDRA-15564 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15564 > Project: Cassandra > Issue Type: Sub-task > Components: Consistency/Repair >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Time Spent: 10.5h > Remaining Estimate: 0h > > This is to split the change in CASSANDRA-15399 so the refactor is isolated > out. > Currently the repair coordinator special cases the exit cases at each call > site; this makes it so that errors can be inconsistent and there are cases > where proper complete isn't done (proper notifications, and forgetting to > update ActiveRepairService). > [Circle > CI|https://circleci.com/gh/dcapwell/cassandra/tree/bug%2FrepairCoordinatorJmxConsistency] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15603) Update Circle CI to build RPM and DEB packages
[ https://issues.apache.org/jira/browse/CASSANDRA-15603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15603: -- Change Category: Quality Assurance Complexity: Low Hanging Fruit Status: Open (was: Triage Needed) > Update Circle CI to build RPM and DEB packages > -- > > Key: CASSANDRA-15603 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15603 > Project: Cassandra > Issue Type: Improvement > Components: Packaging >Reporter: David Capwell >Priority: Normal > > To make sure we do not break RPM or DEB packages in a commit, we should build > them as part of normal builds. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15603) Update Circle CI to build RPM and DEB packages
David Capwell created CASSANDRA-15603: - Summary: Update Circle CI to build RPM and DEB packages Key: CASSANDRA-15603 URL: https://issues.apache.org/jira/browse/CASSANDRA-15603 Project: Cassandra Issue Type: Improvement Components: Packaging Reporter: David Capwell To make sure we do not break RPM or DEB packages in a commit, we should build them as part of normal builds. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15602) Separate dtest user API from cluster implementation API
[ https://issues.apache.org/jira/browse/CASSANDRA-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15602: -- Change Category: Quality Assurance Complexity: Low Hanging Fruit Status: Open (was: Triage Needed) > Separate dtest user API from cluster implementation API > --- > > Key: CASSANDRA-15602 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15602 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest >Reporter: David Capwell >Priority: Normal > > The Cluster and Instance interfaces are shared by the implementation and the > users, this leads to situations where methods like Instance.startup(Cluster) > should not be called by users. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15602) Separate dtest user API from cluster implementation API
David Capwell created CASSANDRA-15602: - Summary: Separate dtest user API from cluster implementation API Key: CASSANDRA-15602 URL: https://issues.apache.org/jira/browse/CASSANDRA-15602 Project: Cassandra Issue Type: Improvement Components: Test/dtest Reporter: David Capwell The Cluster and Instance interfaces are shared by the implementation and the users, this leads to situations where methods like Instance.startup(Cluster) should not be called by users. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15567) Allow EXTRA_CLASSPATH to work in tarball/source installations
[ https://issues.apache.org/jira/browse/CASSANDRA-15567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-15567: - Status: In Progress (was: Changes Suggested) > Allow EXTRA_CLASSPATH to work in tarball/source installations > - > > Key: CASSANDRA-15567 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15567 > Project: Cassandra > Issue Type: Improvement > Components: Local/Scripts >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta > > > Both the debian and redhat packaging modify cassandra.in.sh to support the > EXTRA_CLASSPATH variable. It would be nice to just put this in > cassandra.in.sh proper so people without a package installation can use it as > well. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15567) Allow EXTRA_CLASSPATH to work in tarball/source installations
[ https://issues.apache.org/jira/browse/CASSANDRA-15567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-15567: - Status: Patch Available (was: In Progress) > Allow EXTRA_CLASSPATH to work in tarball/source installations > - > > Key: CASSANDRA-15567 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15567 > Project: Cassandra > Issue Type: Improvement > Components: Local/Scripts >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta > > > Both the debian and redhat packaging modify cassandra.in.sh to support the > EXTRA_CLASSPATH variable. It would be nice to just put this in > cassandra.in.sh proper so people without a package installation can use it as > well. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14900) DigestMismatchException log messages should be at TRACE
[
https://issues.apache.org/jira/browse/CASSANDRA-14900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-14900:
-
Status: Patch Available (was: Ready to Commit)
> DigestMismatchException log messages should be at TRACE
> ---
>
> Key: CASSANDRA-14900
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14900
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Observability, Local/Config
>Reporter: Aleksandr Sorokoumov
>Assignee: Aleksandr Sorokoumov
>Priority: Low
> Fix For: 3.0.x, 3.11.x
>
>
> DigestMismatchException log messages should probably be at TRACE. These log
> messages about normal digest mismatches that include scary stacktraces:
> {noformat}
> DEBUG [ReadRepairStage:40] 2017-10-24 19:45:50,349 ReadCallback.java:242 -
> Digest mismatch:
> org.apache.cassandra.service.DigestMismatchException: Mismatch for key
> DecoratedKey(-786225366477494582,
> 31302e33322e37382e31332d6765744469736b5574696c50657263656e742d736463)
> (943070f62d72259e3c25be0c6f76e489 vs f4c7c7675c803e0028992e11e0bbc5a0)
> at
> org.apache.cassandra.service.DigestResolver.compareResponses(DigestResolver.java:92)
> ~[cassandra-all-3.11.0.1855.jar:3.11.0.1855]
> at
> org.apache.cassandra.service.ReadCallback$AsyncRepairRunner.run(ReadCallback.java:233)
> ~[cassandra-all-3.11.0.1855.jar:3.11.0.1855]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> [na:1.8.0_121]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> [na:1.8.0_121]
> at
> org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:81)
> [cassandra-all-3.11.0.1855.jar:3.11.0.1855]
> at java.lang.Thread.run(Thread.java:745) ~[na:1.8.0_121]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15549) NativeLibrary recommends to run Cassandra as root but users should not
[ https://issues.apache.org/jira/browse/CASSANDRA-15549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-15549: - Source Control Link: https://github.com/apache/cassandra/commit/958aa790ecfc36927f213325918099f822d38b00 Resolution: Fixed Status: Resolved (was: Ready to Commit) Committed, thanks. > NativeLibrary recommends to run Cassandra as root but users should not > -- > > Key: CASSANDRA-15549 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15549 > Project: Cassandra > Issue Type: Improvement > Components: Local/Other >Reporter: David Capwell >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-alpha > > > NativeLibrary recommends users to run Cassandra as root, should remove that > since users really shouldn’t be running Cassandra as root. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: Correct inaccurate logging message about running as root.
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/trunk by this push:
new 958aa79 Correct inaccurate logging message about running as root.
958aa79 is described below
commit 958aa790ecfc36927f213325918099f822d38b00
Author: Ekaterina Dimitrova
AuthorDate: Wed Feb 26 09:27:14 2020 -0500
Correct inaccurate logging message about running as root.
Patch by Ekaterina Dimitrova, reviewed by David Capwell for
CASSANDRA-15549
---
CHANGES.txt| 1 +
src/java/org/apache/cassandra/utils/NativeLibrary.java | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index 0730bff..a7f3e89 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
4.0-alpha4
+ * Correct inaccurate logging message (CASSANDRA-15549)
* Add documentation of dynamo (CASSANDRA-15486)
* Added documentation for Guarantees (CASSANDRA-15482)
* Added documentation for audit logging (CASSANDRA-15474)
diff --git a/src/java/org/apache/cassandra/utils/NativeLibrary.java
b/src/java/org/apache/cassandra/utils/NativeLibrary.java
index 4b04bbc..8bcd6f6 100644
--- a/src/java/org/apache/cassandra/utils/NativeLibrary.java
+++ b/src/java/org/apache/cassandra/utils/NativeLibrary.java
@@ -198,7 +198,7 @@ public final class NativeLibrary
{
logger.warn("Unable to lock JVM memory (ENOMEM)."
+ " This can result in part of the JVM being swapped
out, especially with mmapped I/O enabled."
-+ " Increase RLIMIT_MEMLOCK or run Cassandra as
root.");
++ " Increase RLIMIT_MEMLOCK.");
}
else if (osType != MAC)
{
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15567) Allow EXTRA_CLASSPATH to work in tarball/source installations
[ https://issues.apache.org/jira/browse/CASSANDRA-15567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045678#comment-17045678 ] Brandon Williams commented on CASSANDRA-15567: -- bq. Yep, confirmed our packaging puts this at the end It puts it after the normal CP stuff, but before the jsr223 stuff, which is what I did (I actually used it as a guide.) I'm not opposed to putting it after, though. I noticed on trunk that it was repeating the jar additions for some reason (which is probably why you thought I was putting it before), so in addition to fixing the diff to not add EXTRA_CLASSPATH, I also removed the jar duplication here: https://github.com/driftx/cassandra/tree/CASSANDRA-15567-trunk > Allow EXTRA_CLASSPATH to work in tarball/source installations > - > > Key: CASSANDRA-15567 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15567 > Project: Cassandra > Issue Type: Improvement > Components: Local/Scripts >Reporter: Brandon Williams >Assignee: Brandon Williams >Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta > > > Both the debian and redhat packaging modify cassandra.in.sh to support the > EXTRA_CLASSPATH variable. It would be nice to just put this in > cassandra.in.sh proper so people without a package installation can use it as > well. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14900) DigestMismatchException log messages should be at TRACE
[
https://issues.apache.org/jira/browse/CASSANDRA-14900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045662#comment-17045662
]
Aleksandr Sorokoumov commented on CASSANDRA-14900:
--
You are right! {{logger.trace}} was redundant there as {{traceState.trace}} was
invoked right before it. I updated the patch, it only removes debug stack trace
statement now.
> DigestMismatchException log messages should be at TRACE
> ---
>
> Key: CASSANDRA-14900
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14900
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Observability, Local/Config
>Reporter: Aleksandr Sorokoumov
>Assignee: Aleksandr Sorokoumov
>Priority: Low
> Fix For: 3.0.x, 3.11.x
>
>
> DigestMismatchException log messages should probably be at TRACE. These log
> messages about normal digest mismatches that include scary stacktraces:
> {noformat}
> DEBUG [ReadRepairStage:40] 2017-10-24 19:45:50,349 ReadCallback.java:242 -
> Digest mismatch:
> org.apache.cassandra.service.DigestMismatchException: Mismatch for key
> DecoratedKey(-786225366477494582,
> 31302e33322e37382e31332d6765744469736b5574696c50657263656e742d736463)
> (943070f62d72259e3c25be0c6f76e489 vs f4c7c7675c803e0028992e11e0bbc5a0)
> at
> org.apache.cassandra.service.DigestResolver.compareResponses(DigestResolver.java:92)
> ~[cassandra-all-3.11.0.1855.jar:3.11.0.1855]
> at
> org.apache.cassandra.service.ReadCallback$AsyncRepairRunner.run(ReadCallback.java:233)
> ~[cassandra-all-3.11.0.1855.jar:3.11.0.1855]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> [na:1.8.0_121]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> [na:1.8.0_121]
> at
> org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:81)
> [cassandra-all-3.11.0.1855.jar:3.11.0.1855]
> at java.lang.Thread.run(Thread.java:745) ~[na:1.8.0_121]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15549) NativeLibrary recommends to run Cassandra as root but users should not
[ https://issues.apache.org/jira/browse/CASSANDRA-15549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045661#comment-17045661 ] Ekaterina Dimitrova commented on CASSANDRA-15549: - Great! Thanks! The thing is we don't open pull requests directly to the apache repo for now. Can you commit or we should ask [~brandon.williams] I am not a committer for now > NativeLibrary recommends to run Cassandra as root but users should not > -- > > Key: CASSANDRA-15549 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15549 > Project: Cassandra > Issue Type: Improvement > Components: Local/Other >Reporter: David Capwell >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-alpha > > > NativeLibrary recommends users to run Cassandra as root, should remove that > since users really shouldn’t be running Cassandra as root. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15549) NativeLibrary recommends to run Cassandra as root but users should not
[ https://issues.apache.org/jira/browse/CASSANDRA-15549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15549: -- Status: Ready to Commit (was: Review In Progress) > NativeLibrary recommends to run Cassandra as root but users should not > -- > > Key: CASSANDRA-15549 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15549 > Project: Cassandra > Issue Type: Improvement > Components: Local/Other >Reporter: David Capwell >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-alpha > > > NativeLibrary recommends users to run Cassandra as root, should remove that > since users really shouldn’t be running Cassandra as root. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15549) NativeLibrary recommends to run Cassandra as root but users should not
[ https://issues.apache.org/jira/browse/CASSANDRA-15549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15549: -- Reviewers: David Capwell, David Capwell (was: David Capwell) David Capwell, David Capwell Status: Review In Progress (was: Patch Available) > NativeLibrary recommends to run Cassandra as root but users should not > -- > > Key: CASSANDRA-15549 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15549 > Project: Cassandra > Issue Type: Improvement > Components: Local/Other >Reporter: David Capwell >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-alpha > > > NativeLibrary recommends users to run Cassandra as root, should remove that > since users really shouldn’t be running Cassandra as root. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15549) NativeLibrary recommends to run Cassandra as root but users should not
[ https://issues.apache.org/jira/browse/CASSANDRA-15549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-15549: -- Test and Documentation Plan: Unit Status: Patch Available (was: In Progress) > NativeLibrary recommends to run Cassandra as root but users should not > -- > > Key: CASSANDRA-15549 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15549 > Project: Cassandra > Issue Type: Improvement > Components: Local/Other >Reporter: David Capwell >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-alpha > > > NativeLibrary recommends users to run Cassandra as root, should remove that > since users really shouldn’t be running Cassandra as root. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15549) NativeLibrary recommends to run Cassandra as root but users should not
[ https://issues.apache.org/jira/browse/CASSANDRA-15549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045626#comment-17045626 ] David Capwell commented on CASSANDRA-15549: --- +1. Patch LGTM If your commit has the Jira in the comment Jira will link for you when you open the pull request > NativeLibrary recommends to run Cassandra as root but users should not > -- > > Key: CASSANDRA-15549 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15549 > Project: Cassandra > Issue Type: Improvement > Components: Local/Other >Reporter: David Capwell >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-alpha > > > NativeLibrary recommends users to run Cassandra as root, should remove that > since users really shouldn’t be running Cassandra as root. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14875) Explicitly initialize StageManager early in startup
[
https://issues.apache.org/jira/browse/CASSANDRA-14875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045623#comment-17045623
]
Aleksandr Sorokoumov commented on CASSANDRA-14875:
--
[~e.dimitrova] It is ready for review.
> Explicitly initialize StageManager early in startup
> ---
>
> Key: CASSANDRA-14875
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14875
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Startup and Shutdown
>Reporter: Aleksandr Sorokoumov
>Assignee: Aleksandr Sorokoumov
>Priority: Low
> Fix For: 4.x
>
>
> {{StageManager}} initializes itself through a static block and sets up every
> {{Stage}}, including pre-starting their threads. This initizalization can
> take a few hundred milliseconds. This timing impact is unpredictable and hard
> to reason about; it looks like it usually gets hit when creating new
> Keyspaces on start-up and announcing them through migrations.
> While these processes are resilient to these delays, it is dramatically
> easier to reason about over time if this initialization happens explicitly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15601) Ensure repaired data tracking reads a consistent amount of data across replicas
[
https://issues.apache.org/jira/browse/CASSANDRA-15601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sam Tunnicliffe updated CASSANDRA-15601:
Bug Category: Parent values: Correctness(12982)Level 1 values: Transient
Incorrect Response(12987)
Complexity: Normal
Discovered By: Code Inspection
Fix Version/s: 4.0-alpha
Severity: Normal
Status: Open (was: Triage Needed)
> Ensure repaired data tracking reads a consistent amount of data across
> replicas
> ---
>
> Key: CASSANDRA-15601
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15601
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Repair
>Reporter: Sam Tunnicliffe
>Assignee: Sam Tunnicliffe
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> When generating a digest for repaired data tracking, the amount of repaired
> data that needs to be read may depend on the unrepaired data on the replica.
> As this may vary between replicas, digest mismatches can be reported even
> though the repaired data may actually be in sync.
> For example, two replicas, A & B and a table like
> {code}
> CREATE TABLE t (pk int, ck int, PRIMARY KEY (pk, ck)) WITH CLUSTERING ORDER
> BY ck DESC;
> Unrepaired
> ===
> Instance A
> (0, 5)
> Instance B
> (0, 6)
> (0, 5)
> Repaired (Both A & B)
> =
> (0, 4)
> (0, 3)
> (0, 2)
> (0, 1)
> (0, 0)
> SELECT * FROM tbl WHERE pk = 0 LIMIT 3;
> {code}
> Instance A would read (0, 5) from the unrepaired set and (0, 4) (0, 3) from
> the repaired set.
> Instance B would read (0, 6) (0, 5) from its unrepaired set and just (0, 4)
> from repaired data.
> Unrepaired row/range/partition tombstones shadowing repaired data and present
> on some replicas but not others will have the opposite effect, with more
> repaired data being read in comparison.
> To fix this, when repaired data tracking is in effect each replica needs to
> overread during a full data read. Replicas should read up to {{LIMIT}} (i.e.
> the {{DataLimit}} of the {{ReadCommand}}) from the repaired set, regardless
> of how much is read from the unrepaired data. At the point where that amount
> of repaired data has been read, replica should stop updating the digest. So
> if unrepaired tombstones cause more than {{LIMIT}} repaired data to be read,
> the digest is only calculated over the first {{LIMIT}}-worth of repaired data.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15601) Ensure repaired data tracking reads a consistent amount of data across replicas
Sam Tunnicliffe created CASSANDRA-15601:
---
Summary: Ensure repaired data tracking reads a consistent amount
of data across replicas
Key: CASSANDRA-15601
URL: https://issues.apache.org/jira/browse/CASSANDRA-15601
Project: Cassandra
Issue Type: Bug
Components: Consistency/Repair
Reporter: Sam Tunnicliffe
Assignee: Sam Tunnicliffe
When generating a digest for repaired data tracking, the amount of repaired
data that needs to be read may depend on the unrepaired data on the replica. As
this may vary between replicas, digest mismatches can be reported even though
the repaired data may actually be in sync.
For example, two replicas, A & B and a table like
{code}
CREATE TABLE t (pk int, ck int, PRIMARY KEY (pk, ck)) WITH CLUSTERING ORDER BY
ck DESC;
Unrepaired
===
Instance A
(0, 5)
Instance B
(0, 6)
(0, 5)
Repaired (Both A & B)
=
(0, 4)
(0, 3)
(0, 2)
(0, 1)
(0, 0)
SELECT * FROM tbl WHERE pk = 0 LIMIT 3;
{code}
Instance A would read (0, 5) from the unrepaired set and (0, 4) (0, 3) from the
repaired set.
Instance B would read (0, 6) (0, 5) from its unrepaired set and just (0, 4)
from repaired data.
Unrepaired row/range/partition tombstones shadowing repaired data and present
on some replicas but not others will have the opposite effect, with more
repaired data being read in comparison.
To fix this, when repaired data tracking is in effect each replica needs to
overread during a full data read. Replicas should read up to {{LIMIT}} (i.e.
the {{DataLimit}} of the {{ReadCommand}}) from the repaired set, regardless of
how much is read from the unrepaired data. At the point where that amount of
repaired data has been read, replica should stop updating the digest. So if
unrepaired tombstones cause more than {{LIMIT}} repaired data to be read, the
digest is only calculated over the first {{LIMIT}}-worth of repaired data.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15549) NativeLibrary recommends to run Cassandra as root but users should not
[ https://issues.apache.org/jira/browse/CASSANDRA-15549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045591#comment-17045591 ] Ekaterina Dimitrova edited comment on CASSANDRA-15549 at 2/26/20 2:39 PM: -- Sorry about the format, for some weird reason Jira doesn't like my external links and doesn't format them as expected today was (Author: e.dimitrova): Sorry about the format, for some weird reason Jira doesn't like my external links and don't format them as expected today > NativeLibrary recommends to run Cassandra as root but users should not > -- > > Key: CASSANDRA-15549 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15549 > Project: Cassandra > Issue Type: Improvement > Components: Local/Other >Reporter: David Capwell >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-alpha > > > NativeLibrary recommends users to run Cassandra as root, should remove that > since users really shouldn’t be running Cassandra as root. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15549) NativeLibrary recommends to run Cassandra as root but users should not
[ https://issues.apache.org/jira/browse/CASSANDRA-15549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045591#comment-17045591 ] Ekaterina Dimitrova commented on CASSANDRA-15549: - Sorry about the format, for some weird reason Jira doesn't like my external links and don't format them as expected today > NativeLibrary recommends to run Cassandra as root but users should not > -- > > Key: CASSANDRA-15549 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15549 > Project: Cassandra > Issue Type: Improvement > Components: Local/Other >Reporter: David Capwell >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-alpha > > > NativeLibrary recommends users to run Cassandra as root, should remove that > since users really shouldn’t be running Cassandra as root. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15549) NativeLibrary recommends to run Cassandra as root but users should not
[ https://issues.apache.org/jira/browse/CASSANDRA-15549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045587#comment-17045587 ] Ekaterina Dimitrova commented on CASSANDRA-15549: - [Pull request | [https://github.com/ekaterinadimitrova2/cassandra/pull/19]] [trunk branch | https://github.com/ekaterinadimitrova2/cassandra/tree/CASSANDRA-15549] > NativeLibrary recommends to run Cassandra as root but users should not > -- > > Key: CASSANDRA-15549 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15549 > Project: Cassandra > Issue Type: Improvement > Components: Local/Other >Reporter: David Capwell >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-alpha > > > NativeLibrary recommends users to run Cassandra as root, should remove that > since users really shouldn’t be running Cassandra as root. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-15549) NativeLibrary recommends to run Cassandra as root but users should not
[ https://issues.apache.org/jira/browse/CASSANDRA-15549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova reassigned CASSANDRA-15549: --- Assignee: Ekaterina Dimitrova > NativeLibrary recommends to run Cassandra as root but users should not > -- > > Key: CASSANDRA-15549 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15549 > Project: Cassandra > Issue Type: Improvement > Components: Local/Other >Reporter: David Capwell >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-alpha > > > NativeLibrary recommends users to run Cassandra as root, should remove that > since users really shouldn’t be running Cassandra as root. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15599) Improve logging around incremental repair
[
https://issues.apache.org/jira/browse/CASSANDRA-15599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045566#comment-17045566
]
Sam Tunnicliffe edited comment on CASSANDRA-15599 at 2/26/20 2:07 PM:
--
LGTM, pushed a couple of additional minor changes
[here|https://github.com/beobal/cassandra/tree/marcuse/15599] including
removing an assert from {{CoordinatorMessagingTest}} which is somewhat racy and
so causes intermittent test failures.
was (Author: beobal):
LGTM, pushed a couple of additional minor changes [here:
[https://github.com/beobal/cassandra/tree/marcuse/15599],] including removing
an assert from {{CoordinatorMessagingTest}} which is somewhat racy and so
causes intermittent test failures.
> Improve logging around incremental repair
> -
>
> Key: CASSANDRA-15599
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15599
> Project: Cassandra
> Issue Type: Improvement
> Components: Consistency/Repair
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> Some repair logging messages omit the parent session id and we don't log
> which sstables are created by anticompaction.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15599) Improve logging around incremental repair
[
https://issues.apache.org/jira/browse/CASSANDRA-15599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045566#comment-17045566
]
Sam Tunnicliffe commented on CASSANDRA-15599:
-
LGTM, pushed a couple of additional minor changes [here:
[https://github.com/beobal/cassandra/tree/marcuse/15599],] including removing
an assert from {{CoordinatorMessagingTest}} which is somewhat racy and so
causes intermittent test failures.
> Improve logging around incremental repair
> -
>
> Key: CASSANDRA-15599
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15599
> Project: Cassandra
> Issue Type: Improvement
> Components: Consistency/Repair
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> Some repair logging messages omit the parent session id and we don't log
> which sstables are created by anticompaction.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15599) Improve logging around incremental repair
[ https://issues.apache.org/jira/browse/CASSANDRA-15599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Tunnicliffe updated CASSANDRA-15599: Reviewers: Blake Eggleston, Sam Tunnicliffe, Sam Tunnicliffe (was: Blake Eggleston, Sam Tunnicliffe) Blake Eggleston, Sam Tunnicliffe, Sam Tunnicliffe (was: Blake Eggleston, Sam Tunnicliffe) Status: Review In Progress (was: Patch Available) > Improve logging around incremental repair > - > > Key: CASSANDRA-15599 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15599 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Repair >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 4.0-alpha > > > Some repair logging messages omit the parent session id and we don't log > which sstables are created by anticompaction. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-15593) seems reading repair bug
[
https://issues.apache.org/jira/browse/CASSANDRA-15593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams reassigned CASSANDRA-15593:
Assignee: (was: Brandon Williams)
> seems reading repair bug
>
>
> Key: CASSANDRA-15593
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15593
> Project: Cassandra
> Issue Type: Bug
>Reporter: Antonio
>Priority: Normal
>
> cassandra version：2.1.15
> i have one dc and 3nodes
> 1. create KEYSPACE test WITH replication = \{'class':
> 'NetworkTopologyStrategy', 'DC1':'3' } and durable_writes = 'true';
> 2. create table test(a int , b int , c int , primary key(a)) with
> dclocal_read_repair_chance = 1.0;
> 3. insert one row into table test，instert into test(a, b, c) values (1, 1,
> 1); and remove sstable on two nodes and result below：
> node1：have correct row 1 1 1
> node2：doesn't have rf
> node3：doesn't have rf
> 4. and i use local_one select one by one like this:
> node1 un，node2 dn，node3 dn：return 1 1 1
> node1 dn，node2 un，node3 dn：return null
> node1 dn，node2 dn，node3 dn：return null
> this prove node1 have correct rf
> 5. and i let all node un，user local_quarum to select , select * from test
> where a = 1;
> but the read repair does't work every time(i test many times)，that's the
> problem(same in 3.0.15)
>
> i hope if i set dclocal_read_repair_chance = 1.0，every time i read by
> local_quarum， if any rf digest does't match，read repair will work，and repair
> all nodes
>
> i.m not sure does's the problem happends in this code()
> wish for your reply，thanks
> public void response(MessageIn message)
> {
> resolver.preprocess(message);int n = waitingFor(message)
> ? recievedUpdater.incrementAndGet(this)
> : received;if (n >= blockfor &&
> resolver.isDataPresent())
> {
> this mean if return responses >= rf/2 +1 and a data response
> return，it start compare，does't all response
> condition.signalAll();// kick off a background digest
> comparison if this is a result that (may have) arrived after//
> the original resolve that get() kicks off as soon as the condition is
> signaledif (blockfor < endpoints.size() && n == endpoints.size())
> {
> TraceState traceState = Tracing.instance.get();
> if (traceState != null)
> traceState.trace("Initiating read-repair");
> StageManager.getStage(Stage.READ_REPAIR).execute(new
> AsyncRepairRunner(traceState));
> }
> }
> }
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15352) Replica failure propagation to coordinator and client
[ https://issues.apache.org/jira/browse/CASSANDRA-15352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Petrov updated CASSANDRA-15352: Description: We should add early reporting of replica-side errors, since currently we just time-out requests. On normal read-write path this is not that important, but this is a protocol change we will need to improve rapid write protection for transient replication. This might have potential positive impact for regular read-write path, since we’ll be aborting queries early instead of timing them out. Can be useful for failing / going away nodes (which is also one of the changes we’re planning to implement). We do have means for propagating error both in client protocol through and in internode through FAILURE_RSP, which is true and we do not have to extend the protocol to implement this change, but this is still a change in protocol behavior, since we’ll be sending a message where we would usually silently timeout. was: We should add early reporting of replica-side errors, since currently we just time-out requests. On normal read-write path this is not that important, but this is a protocol change we will need to improve cheap quorums for transient replication. This might have potential positive impact for regular read-write path, since we’ll be aborting queries early instead of timing them out. Can be useful for failing / going away nodes (which is also one of the changes we’re planning to implement). We do have means for propagating error both in client protocol through and in internode through FAILURE_RSP, which is true and we do not have to extend the protocol to implement this change, but this is still a change in protocol behavior, since we’ll be sending a message where we would usually silently timeout. > Replica failure propagation to coordinator and client > - > > Key: CASSANDRA-15352 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15352 > Project: Cassandra > Issue Type: New Feature > Components: Messaging/Internode >Reporter: Alex Petrov >Priority: Normal > > We should add early reporting of replica-side errors, since currently we just > time-out requests. On normal read-write path this is not that important, but > this is a protocol change we will need to improve rapid write protection for > transient replication. This might have potential positive impact for regular > read-write path, since we’ll be aborting queries early instead of timing them > out. Can be useful for failing / going away nodes (which is also one of the > changes we’re planning to implement). > We do have means for propagating error both in client protocol through > and in internode through FAILURE_RSP, which is true and we do not > have to extend the protocol to implement this change, but this is still a > change in protocol behavior, since we’ll be sending a message where we would > usually silently timeout. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15352) Replica failure propagation to coordinator and client
[ https://issues.apache.org/jira/browse/CASSANDRA-15352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045523#comment-17045523 ] Alex Petrov commented on CASSANDRA-15352: - [~jjirsa] Right now, if there's an exception on the replica side, there's no mechanism that would: a) propagate the details of this failure/error from replica to coordinator and, subsequently, client b) help avoid waiting for enough replicas to respond before we can time out / fail the request on the coordinator side c) in transient replication, trigger rapid write protection as soon as replica fails I think a) is good for usability/visibility, since it makes it clear why exactly query has failed. Thinking behind b) was that it can reduce coordinator load since coordinator doesn't have to wait for the replicas that have failed, but I admit this might be such a rare condition that it is likely not to matter. c) is good because we can trigger rapid write protection and make a write to the transient replica whenever coordinator learns about the exception on the replica instead of waiting for a timeout. [~benedict] you're right; not sure why I called it "cheap quorums". What I meant was "rapid write protection". Right now, when replica doesn't respond during the write, we'll trigger a write to transient replica. Even if write request has failed on the full replica with an exception, information about this won't be propagated to the coordinator. If we can notify the coordinator about the exception on the full replica, we can trigger a write to a transient replica potentially earlier. > Replica failure propagation to coordinator and client > - > > Key: CASSANDRA-15352 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15352 > Project: Cassandra > Issue Type: New Feature > Components: Messaging/Internode >Reporter: Alex Petrov >Priority: Normal > > We should add early reporting of replica-side errors, since currently we just > time-out requests. On normal read-write path this is not that important, but > this is a protocol change we will need to improve cheap quorums for transient > replication. This might have potential positive impact for regular read-write > path, since we’ll be aborting queries early instead of timing them out. Can > be useful for failing / going away nodes (which is also one of the changes > we’re planning to implement). > We do have means for propagating error both in client protocol through > and in internode through FAILURE_RSP, which is true and we do not > have to extend the protocol to implement this change, but this is still a > change in protocol behavior, since we’ll be sending a message where we would > usually silently timeout. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15539) Extract in-jvm API and tests out of Cassandra and into a separate repository
[ https://issues.apache.org/jira/browse/CASSANDRA-15539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044276#comment-17044276 ] Alex Petrov edited comment on CASSANDRA-15539 at 2/26/20 12:43 PM: --- What was done so far: 1. Create a new library that publishes a new in-jvm-dtest API out-of-tree. 2. Publish artifact for a version 0.0.1-SNAPSHOT of API library 3. Bring API library to be used in Cassandra, without migrating the tests out 4. Create a patch that migrates tests out of tree, that uses 1.0.0 version of the API library I did run tests out of tree on all branches locally, too. Now we only have to set up CI to run it. Patches for all branches: |2.2|[patch|https://github.com/apache/cassandra/pull/454]|[branch|https://github.com/ifesdjeen/cassandra/tree/CASSANDRA-15539-2.2-oss]|[CI|https://circleci.com/gh/ifesdjeen/cassandra/tree/CASSANDRA-15539-2.2-oss]| |3.0|[patch|https://github.com/apache/cassandra/pull/452]|[branch|https://github.com/ifesdjeen/cassandra/tree/CASSANDRA-15539-3.0-oss]|[CI|https://circleci.com/gh/ifesdjeen/cassandra/tree/CASSANDRA-15539-3.0-oss]| |3.11|[patch|https://github.com/apache/cassandra/pull/453]|[branch|https://github.com/ifesdjeen/cassandra/tree/CASSANDRA-15539-3.11-oss]|[CI|https://circleci.com/gh/ifesdjeen/cassandra/tree/CASSANDRA-15539-3.11-oss]| |trunk|[patch|https://github.com/apache/cassandra/pull/437]|[branch|https://github.com/ifesdjeen/cassandra/tree/CASSANDRA-15539-trunk-oss]|[CI|https://circleci.com/gh/ifesdjeen/cassandra/tree/CASSANDRA-15539-trunk-oss]| CI is green. New repo patch: https://github.com/apache/cassandra-in-jvm-dtest-api/pull/1 was (Author: ifesdjeen): What was done so far: 1. Create a new library that publishes a new in-jvm-dtest API out-of-tree. 2. Publish artifact for a version 0.0.1-SNAPSHOT of API library 3. Bring API library to be used in Cassandra, without migrating the tests out 4. Create a patch that migrates tests out of tree, that uses 1.0.0 version of the API library I did run tests out of tree on all branches locally, too. Now we only have to set up CI to run it. Patches for all branches: |2.2|[patch|https://github.com/apache/cassandra/pull/454]|[branch|https://github.com/ifesdjeen/cassandra/tree/CASSANDRA-15539-2.2-oss]|[CI|https://circleci.com/gh/ifesdjeen/cassandra/tree/CASSANDRA-15539-2.2-oss]| |3.0|[patch|https://github.com/apache/cassandra/pull/452]|[branch|https://github.com/ifesdjeen/cassandra/tree/CASSANDRA-15539-3.0-oss]|[CI|https://circleci.com/gh/ifesdjeen/cassandra/tree/CASSANDRA-15539-3.0-oss]| |3.11|[patch|https://github.com/apache/cassandra/pull/453]|[branch|https://github.com/ifesdjeen/cassandra/tree/CASSANDRA-15539-3.11-oss]|[CI|https://circleci.com/gh/ifesdjeen/cassandra/tree/CASSANDRA-15539-3.11-oss]| |trunk|[patch|https://github.com/apache/cassandra/pull/437]|[branch|https://github.com/ifesdjeen/cassandra/tree/CASSANDRA-15539-trunk-oss]|[CI|https://circleci.com/gh/ifesdjeen/cassandra/tree/CASSANDRA-15539-trunk-oss]| New repo patch: https://github.com/apache/cassandra-in-jvm-dtest-api/pull/1 > Extract in-jvm API and tests out of Cassandra and into a separate repository > > > Key: CASSANDRA-15539 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15539 > Project: Cassandra > Issue Type: Task > Components: Test/dtest >Reporter: Alex Petrov >Assignee: Alex Petrov >Priority: Normal > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > Extract in-jvm DTest _API_ and tests into a separate repository that is > shared between Cassandra branches. Tests themselves should be buildable using > just API, which is not the case now, since cluster creation relies on impl > package, since we do not have factories / constructors in API. > Main goals we’re trying to achieve: > 1. We should be able to fail a build on API incompatibility between versions > 2. Make it as easy as possible to detect break APIs between versions. > 3. Make development of _tests_ based on in-jvm framework simpler > 4. Reduce surface area of impact when making modifications to tests > Potentially, we’d also like to use a plugin to detect API incompatibilities > between in-jvm DTest API and in-branch implementations, and start running > tests using shared in-jvm test repository with each existing implementation > in the branch. This entails both running tests for all branches whenever > there’s a change in tests jar and running tests for a specific branch > whenever the branch has changed. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional
[jira] [Comment Edited] (CASSANDRA-15539) Extract in-jvm API and tests out of Cassandra and into a separate repository
[ https://issues.apache.org/jira/browse/CASSANDRA-15539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044276#comment-17044276 ] Alex Petrov edited comment on CASSANDRA-15539 at 2/26/20 12:42 PM: --- What was done so far: 1. Create a new library that publishes a new in-jvm-dtest API out-of-tree. 2. Publish artifact for a version 0.0.1-SNAPSHOT of API library 3. Bring API library to be used in Cassandra, without migrating the tests out 4. Create a patch that migrates tests out of tree, that uses 1.0.0 version of the API library I did run tests out of tree on all branches locally, too. Now we only have to set up CI to run it. Patches for all branches: |2.2|[patch|https://github.com/apache/cassandra/pull/454]|[branch|https://github.com/ifesdjeen/cassandra/tree/CASSANDRA-15539-2.2-oss]|[CI|https://circleci.com/gh/ifesdjeen/cassandra/tree/CASSANDRA-15539-2.2-oss]| |3.0|[patch|https://github.com/apache/cassandra/pull/452]|[branch|https://github.com/ifesdjeen/cassandra/tree/CASSANDRA-15539-3.0-oss]|[CI|https://circleci.com/gh/ifesdjeen/cassandra/tree/CASSANDRA-15539-3.0-oss]| |3.11|[patch|https://github.com/apache/cassandra/pull/453]|[branch|https://github.com/ifesdjeen/cassandra/tree/CASSANDRA-15539-3.11-oss]|[CI|https://circleci.com/gh/ifesdjeen/cassandra/tree/CASSANDRA-15539-3.11-oss]| |trunk|[patch|https://github.com/apache/cassandra/pull/437]|[branch|https://github.com/ifesdjeen/cassandra/tree/CASSANDRA-15539-trunk-oss]|[CI|https://circleci.com/gh/ifesdjeen/cassandra/tree/CASSANDRA-15539-trunk-oss]| New repo patch: https://github.com/apache/cassandra-in-jvm-dtest-api/pull/1 was (Author: ifesdjeen): What was done so far: 1. Create a new library that publishes a new in-jvm-dtest API out-of-tree. 2. Publish artifact for a version 0.0.1-SNAPSHOT of API library 3. Bring API library to be used in Cassandra, without migrating the tests out 4. Create a patch that migrates tests out of tree, that uses 1.0.0 version of the API library I did run tests out of tree on all branches locally, too. Now we only have to set up CI to run it. Patches for all branches: |2.2|[patch|https://github.com/ifesdjeen/cassandra/tree/CASSANDRA-15539-2.2-oss]|[CI|https://circleci.com/gh/ifesdjeen/cassandra/tree/CASSANDRA-15539-2.2-oss]| |3.0|[patch|https://github.com/ifesdjeen/cassandra/tree/CASSANDRA-15539-3.0-oss]|[CI|https://circleci.com/gh/ifesdjeen/cassandra/tree/CASSANDRA-15539-3.0-oss]| |3.11|[patch|https://github.com/ifesdjeen/cassandra/tree/CASSANDRA-15539-3.11-oss]|[CI|https://circleci.com/gh/ifesdjeen/cassandra/tree/CASSANDRA-15539-3.11-oss]| |trunk|[patch|https://github.com/ifesdjeen/cassandra/tree/CASSANDRA-15539-trunk-oss]|[CI|https://circleci.com/gh/ifesdjeen/cassandra/tree/CASSANDRA-15539-trunk-oss]| New repo patch: https://github.com/apache/cassandra-in-jvm-dtest-api/pull/1 > Extract in-jvm API and tests out of Cassandra and into a separate repository > > > Key: CASSANDRA-15539 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15539 > Project: Cassandra > Issue Type: Task > Components: Test/dtest >Reporter: Alex Petrov >Assignee: Alex Petrov >Priority: Normal > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > Extract in-jvm DTest _API_ and tests into a separate repository that is > shared between Cassandra branches. Tests themselves should be buildable using > just API, which is not the case now, since cluster creation relies on impl > package, since we do not have factories / constructors in API. > Main goals we’re trying to achieve: > 1. We should be able to fail a build on API incompatibility between versions > 2. Make it as easy as possible to detect break APIs between versions. > 3. Make development of _tests_ based on in-jvm framework simpler > 4. Reduce surface area of impact when making modifications to tests > Potentially, we’d also like to use a plugin to detect API incompatibilities > between in-jvm DTest API and in-branch implementations, and start running > tests using shared in-jvm test repository with each existing implementation > in the branch. This entails both running tests for all branches whenever > there’s a change in tests jar and running tests for a specific branch > whenever the branch has changed. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15539) Extract in-jvm API and tests out of Cassandra and into a separate repository
[ https://issues.apache.org/jira/browse/CASSANDRA-15539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CASSANDRA-15539: --- Labels: pull-request-available (was: ) > Extract in-jvm API and tests out of Cassandra and into a separate repository > > > Key: CASSANDRA-15539 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15539 > Project: Cassandra > Issue Type: Task > Components: Test/dtest >Reporter: Alex Petrov >Assignee: Alex Petrov >Priority: Normal > Labels: pull-request-available > > Extract in-jvm DTest _API_ and tests into a separate repository that is > shared between Cassandra branches. Tests themselves should be buildable using > just API, which is not the case now, since cluster creation relies on impl > package, since we do not have factories / constructors in API. > Main goals we’re trying to achieve: > 1. We should be able to fail a build on API incompatibility between versions > 2. Make it as easy as possible to detect break APIs between versions. > 3. Make development of _tests_ based on in-jvm framework simpler > 4. Reduce surface area of impact when making modifications to tests > Potentially, we’d also like to use a plugin to detect API incompatibilities > between in-jvm DTest API and in-branch implementations, and start running > tests using shared in-jvm test repository with each existing implementation > in the branch. This entails both running tests for all branches whenever > there’s a change in tests jar and running tests for a specific branch > whenever the branch has changed. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
