[jira] [Comment Edited] (CASSANDRA-15733) jvm dtest builder should be provided to the factory and expose state
[ https://issues.apache.org/jira/browse/CASSANDRA-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097102#comment-17097102 ] David Capwell edited comment on CASSANDRA-15733 at 5/1/20, 1:27 AM: | Branch | Build | Results | | trunk | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733] | UNKNOWN | | 3.11 | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733-3.11] | UNKNOWN | | 3.0 | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733-3.0] | UNKNOWN | | 2.2 | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733-2.2] | UNKNOWN | was (Author: dcapwell): | Branch | Build | Results | | trunk | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733] | UNKNOWN | | 3.11 | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733-3.11] | UNKNOWN | | 3.0 | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733-3.0] | UNKNOWN | > jvm dtest builder should be provided to the factory and expose state > > > Key: CASSANDRA-15733 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15733 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Time Spent: 3h > Remaining Estimate: 0h > > Currently the builder is rather heavy and creates configs plus call the > factory with specific fields only, this isn’t that flexible and makes it > harder to have custom cluster definitions which require additional fields to > be defined. To solve this we should make the builder be sent to the factory > and expose the state so the factory can get all the fields it needs, the > factory should also be in charge of creating the configs -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15733) jvm dtest builder should be provided to the factory and expose state
[ https://issues.apache.org/jira/browse/CASSANDRA-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097102#comment-17097102 ] David Capwell edited comment on CASSANDRA-15733 at 5/1/20, 1:25 AM: | Branch | Build | Results | | trunk | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733] | UNKNOWN | | 3.11 | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733-3.11] | UNKNOWN | | 3.0 | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733-3.0] | UNKNOWN | was (Author: dcapwell): | Branch | Build | Results | | trunk | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733] | UNKNOWN | | 3.11 | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733-3.11] | UNKNOWN | > jvm dtest builder should be provided to the factory and expose state > > > Key: CASSANDRA-15733 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15733 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Time Spent: 3h > Remaining Estimate: 0h > > Currently the builder is rather heavy and creates configs plus call the > factory with specific fields only, this isn’t that flexible and makes it > harder to have custom cluster definitions which require additional fields to > be defined. To solve this we should make the builder be sent to the factory > and expose the state so the factory can get all the fields it needs, the > factory should also be in charge of creating the configs -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15733) jvm dtest builder should be provided to the factory and expose state
[ https://issues.apache.org/jira/browse/CASSANDRA-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097102#comment-17097102 ] David Capwell edited comment on CASSANDRA-15733 at 5/1/20, 1:23 AM: | Branch | Build | Results | | trunk | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733] | UNKNOWN | | 3.11 | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733-3.11] | UNKNOWN | was (Author: dcapwell): | Branch | Build | Results | | trunk | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733] | UNKNOWN | > jvm dtest builder should be provided to the factory and expose state > > > Key: CASSANDRA-15733 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15733 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Time Spent: 3h > Remaining Estimate: 0h > > Currently the builder is rather heavy and creates configs plus call the > factory with specific fields only, this isn’t that flexible and makes it > harder to have custom cluster definitions which require additional fields to > be defined. To solve this we should make the builder be sent to the factory > and expose the state so the factory can get all the fields it needs, the > factory should also be in charge of creating the configs -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15733) jvm dtest builder should be provided to the factory and expose state
[ https://issues.apache.org/jira/browse/CASSANDRA-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097102#comment-17097102 ] David Capwell commented on CASSANDRA-15733: --- | Branch | Build | Results | | trunk | [Circle CI|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=feature%2FCASSANDRA-15733] | UNKNOWN | > jvm dtest builder should be provided to the factory and expose state > > > Key: CASSANDRA-15733 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15733 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Time Spent: 3h > Remaining Estimate: 0h > > Currently the builder is rather heavy and creates configs plus call the > factory with specific fields only, this isn’t that flexible and makes it > harder to have custom cluster definitions which require additional fields to > be defined. To solve this we should make the builder be sent to the factory > and expose the state so the factory can get all the fields it needs, the > factory should also be in charge of creating the configs -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15733) jvm dtest builder should be provided to the factory and expose state
[ https://issues.apache.org/jira/browse/CASSANDRA-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097090#comment-17097090 ] David Capwell commented on CASSANDRA-15733: --- .2 was released, fixing branches to use and will update here again. > jvm dtest builder should be provided to the factory and expose state > > > Key: CASSANDRA-15733 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15733 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Labels: pull-request-available > Time Spent: 3h > Remaining Estimate: 0h > > Currently the builder is rather heavy and creates configs plus call the > factory with specific fields only, this isn’t that flexible and makes it > harder to have custom cluster definitions which require additional fields to > be defined. To solve this we should make the builder be sent to the factory > and expose the state so the factory can get all the fields it needs, the > factory should also be in charge of creating the configs -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15729) Jenkins Test Results Report in plaintext for ASF ML
[ https://issues.apache.org/jira/browse/CASSANDRA-15729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097052#comment-17097052 ] Michael Semb Wever edited comment on CASSANDRA-15729 at 4/30/20, 11:24 PM: --- Have tested the dockerised cassandra-test-report.sh script on my local jenkins. !.Screenshot 2020-05-01 at 01.12.28.png|width=500! was (Author: michaelsembwever): Have tested the dockerised cassandra-test-report.sh script on my local jenkins. !.Screenshot 2020-05-01 at 01.12.28.png|width=250! > Jenkins Test Results Report in plaintext for ASF ML > --- > > Key: CASSANDRA-15729 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15729 > Project: Cassandra > Issue Type: Task > Components: Build, CI >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Labels: Jenkins > Fix For: 4.0-beta > > Attachments: .Screenshot 2020-05-01 at 01.12.28.png > > > The Jenkins pipeline builds now aggregate all test reports. > For example: > - https://ci-cassandra.apache.org/job/Cassandra-trunk/68/testReport/ > - > https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-trunk/detail/Cassandra-trunk/68/tests > But Jenkins can only keep a limited amount of build history, so those links > are not permanent, can't be used as references, and don't help for bisecting > and blame on regressions (and flakey tests) over a longer period of time. > The builds@ ML can provide a permanent record of test results. > This was first brought up in these two threads: > - > https://lists.apache.org/thread.html/re8122e4fdd8629e7fbca2abf27d72054b3bc0e3690ece8b8e66f618b%40%3Cdev.cassandra.apache.org%3E > - > https://lists.apache.org/thread.html/ra5f6aeea89546825fe7ccc4a80898c62f8ed57decabf709d81d9c720%40%3Cdev.cassandra.apache.org%3E > An example plaintext report, to demonstrate feasibility, is available here: > https://lists.apache.org/thread.html/r80d13f7af706bf8dfbf2387fab46004c1fbd3917b7bc339c49e69aa8%40%3Cbuilds.cassandra.apache.org%3E > Hurdles: > - the ASF mailing lists won't accept html, attachments, or any message body > over 1MB. > - packages are used as a differentiator in the final aggregated report. The > cqlsh and dtests currently don't specify it. It needs to be added as a > "dot-separated" prefix to the testsuite and testcase name. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15729) Jenkins Test Results Report in plaintext for ASF ML
[ https://issues.apache.org/jira/browse/CASSANDRA-15729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097052#comment-17097052 ] Michael Semb Wever edited comment on CASSANDRA-15729 at 4/30/20, 11:23 PM: --- Have tested the dockerised cassandra-test-report.sh script on my local jenkins. !.Screenshot 2020-05-01 at 01.12.28.png|width=250! was (Author: michaelsembwever): Have tested the dockerised cassandra-test-report.sh script on my local jenkins. !.Screenshot 2020-05-01 at 01.12.28.png! > Jenkins Test Results Report in plaintext for ASF ML > --- > > Key: CASSANDRA-15729 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15729 > Project: Cassandra > Issue Type: Task > Components: Build, CI >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Labels: Jenkins > Fix For: 4.0-beta > > Attachments: .Screenshot 2020-05-01 at 01.12.28.png > > > The Jenkins pipeline builds now aggregate all test reports. > For example: > - https://ci-cassandra.apache.org/job/Cassandra-trunk/68/testReport/ > - > https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-trunk/detail/Cassandra-trunk/68/tests > But Jenkins can only keep a limited amount of build history, so those links > are not permanent, can't be used as references, and don't help for bisecting > and blame on regressions (and flakey tests) over a longer period of time. > The builds@ ML can provide a permanent record of test results. > This was first brought up in these two threads: > - > https://lists.apache.org/thread.html/re8122e4fdd8629e7fbca2abf27d72054b3bc0e3690ece8b8e66f618b%40%3Cdev.cassandra.apache.org%3E > - > https://lists.apache.org/thread.html/ra5f6aeea89546825fe7ccc4a80898c62f8ed57decabf709d81d9c720%40%3Cdev.cassandra.apache.org%3E > An example plaintext report, to demonstrate feasibility, is available here: > https://lists.apache.org/thread.html/r80d13f7af706bf8dfbf2387fab46004c1fbd3917b7bc339c49e69aa8%40%3Cbuilds.cassandra.apache.org%3E > Hurdles: > - the ASF mailing lists won't accept html, attachments, or any message body > over 1MB. > - packages are used as a differentiator in the final aggregated report. The > cqlsh and dtests currently don't specify it. It needs to be added as a > "dot-separated" prefix to the testsuite and testcase name. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15729) Jenkins Test Results Report in plaintext for ASF ML
[ https://issues.apache.org/jira/browse/CASSANDRA-15729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097052#comment-17097052 ] Michael Semb Wever commented on CASSANDRA-15729: Have tested the dockerised cassandra-test-report.sh script on my local jenkins. !.Screenshot 2020-05-01 at 01.12.28.png! > Jenkins Test Results Report in plaintext for ASF ML > --- > > Key: CASSANDRA-15729 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15729 > Project: Cassandra > Issue Type: Task > Components: Build, CI >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Labels: Jenkins > Fix For: 4.0-beta > > Attachments: .Screenshot 2020-05-01 at 01.12.28.png > > > The Jenkins pipeline builds now aggregate all test reports. > For example: > - https://ci-cassandra.apache.org/job/Cassandra-trunk/68/testReport/ > - > https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-trunk/detail/Cassandra-trunk/68/tests > But Jenkins can only keep a limited amount of build history, so those links > are not permanent, can't be used as references, and don't help for bisecting > and blame on regressions (and flakey tests) over a longer period of time. > The builds@ ML can provide a permanent record of test results. > This was first brought up in these two threads: > - > https://lists.apache.org/thread.html/re8122e4fdd8629e7fbca2abf27d72054b3bc0e3690ece8b8e66f618b%40%3Cdev.cassandra.apache.org%3E > - > https://lists.apache.org/thread.html/ra5f6aeea89546825fe7ccc4a80898c62f8ed57decabf709d81d9c720%40%3Cdev.cassandra.apache.org%3E > An example plaintext report, to demonstrate feasibility, is available here: > https://lists.apache.org/thread.html/r80d13f7af706bf8dfbf2387fab46004c1fbd3917b7bc339c49e69aa8%40%3Cbuilds.cassandra.apache.org%3E > Hurdles: > - the ASF mailing lists won't accept html, attachments, or any message body > over 1MB. > - packages are used as a differentiator in the final aggregated report. The > cqlsh and dtests currently don't specify it. It needs to be added as a > "dot-separated" prefix to the testsuite and testcase name. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15729) Jenkins Test Results Report in plaintext for ASF ML
[ https://issues.apache.org/jira/browse/CASSANDRA-15729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-15729: --- Attachment: .Screenshot 2020-05-01 at 01.12.28.png > Jenkins Test Results Report in plaintext for ASF ML > --- > > Key: CASSANDRA-15729 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15729 > Project: Cassandra > Issue Type: Task > Components: Build, CI >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Labels: Jenkins > Fix For: 4.0-beta > > Attachments: .Screenshot 2020-05-01 at 01.12.28.png > > > The Jenkins pipeline builds now aggregate all test reports. > For example: > - https://ci-cassandra.apache.org/job/Cassandra-trunk/68/testReport/ > - > https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-trunk/detail/Cassandra-trunk/68/tests > But Jenkins can only keep a limited amount of build history, so those links > are not permanent, can't be used as references, and don't help for bisecting > and blame on regressions (and flakey tests) over a longer period of time. > The builds@ ML can provide a permanent record of test results. > This was first brought up in these two threads: > - > https://lists.apache.org/thread.html/re8122e4fdd8629e7fbca2abf27d72054b3bc0e3690ece8b8e66f618b%40%3Cdev.cassandra.apache.org%3E > - > https://lists.apache.org/thread.html/ra5f6aeea89546825fe7ccc4a80898c62f8ed57decabf709d81d9c720%40%3Cdev.cassandra.apache.org%3E > An example plaintext report, to demonstrate feasibility, is available here: > https://lists.apache.org/thread.html/r80d13f7af706bf8dfbf2387fab46004c1fbd3917b7bc339c49e69aa8%40%3Cbuilds.cassandra.apache.org%3E > Hurdles: > - the ASF mailing lists won't accept html, attachments, or any message body > over 1MB. > - packages are used as a differentiator in the final aggregated report. The > cqlsh and dtests currently don't specify it. It needs to be added as a > "dot-separated" prefix to the testsuite and testcase name. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-22) RESTEasy integration for Cassandra Sidecar
[ https://issues.apache.org/jira/browse/CASSANDRASC-22?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRASC-22: Fix Version/s: 1.0 Source Control Link: https://github.com/apache/cassandra-sidecar/commit/2265e614d36198cb78134dd7463c6aa3799481ce Resolution: Fixed Status: Resolved (was: Ready to Commit) Committed. Thanks for the review [~rustyrazorblade] and [~yifanc]! > RESTEasy integration for Cassandra Sidecar > -- > > Key: CASSANDRASC-22 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-22 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Dinesh Joshi >Assignee: Dinesh Joshi >Priority: Normal > Fix For: 1.0 > > Attachments: image-2020-04-27-22-59-40-060.png, > image-2020-04-29-01-14-11-756.png, image-2020-04-29-10-33-37-196.png, > image-2020-04-29-13-33-13-467.png, image-2020-04-29-13-33-43-069.png, > image-2020-04-29-13-35-17-071.png, image-2020-04-29-13-35-29-981.png > > > Add support for JAX-RS based routing via RESTEasy to Cassandra Sidecar. This > also dynamically generates swagger documentation and adds the swagger UI. > [Branch|https://github.com/dineshjoshi/cassandra-sidecar/tree/resteasy-swagger] > [Tests|https://circleci.com/workflow-run/a7888146-a22d-45af-983a-8833b77eef59] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-22) RESTEasy integration for Cassandra Sidecar
[ https://issues.apache.org/jira/browse/CASSANDRASC-22?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRASC-22: Status: Ready to Commit (was: Review In Progress) > RESTEasy integration for Cassandra Sidecar > -- > > Key: CASSANDRASC-22 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-22 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Dinesh Joshi >Assignee: Dinesh Joshi >Priority: Normal > Attachments: image-2020-04-27-22-59-40-060.png, > image-2020-04-29-01-14-11-756.png, image-2020-04-29-10-33-37-196.png, > image-2020-04-29-13-33-13-467.png, image-2020-04-29-13-33-43-069.png, > image-2020-04-29-13-35-17-071.png, image-2020-04-29-13-35-29-981.png > > > Add support for JAX-RS based routing via RESTEasy to Cassandra Sidecar. This > also dynamically generates swagger documentation and adds the swagger UI. > [Branch|https://github.com/dineshjoshi/cassandra-sidecar/tree/resteasy-swagger] > [Tests|https://circleci.com/workflow-run/a7888146-a22d-45af-983a-8833b77eef59] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-sidecar] branch master updated: Ninja-Fix: CHANGES.txt for CASSANDRASC-22
This is an automated email from the ASF dual-hosted git repository. djoshi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cassandra-sidecar.git The following commit(s) were added to refs/heads/master by this push: new c9da4b2 Ninja-Fix: CHANGES.txt for CASSANDRASC-22 c9da4b2 is described below commit c9da4b213946fc6dbe8cdcbbc2445348f14a89af Author: Dinesh A. Joshi AuthorDate: Thu Apr 30 11:34:52 2020 -0700 Ninja-Fix: CHANGES.txt for CASSANDRASC-22 --- CHANGES.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGES.txt b/CHANGES.txt index f2f3517..899e4f2 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,5 +1,6 @@ 1.0.0 - + * RESTEasy integration with dynamically generated Swagger OpenAPI, Swagger UI and JAX-RS (CASSANDRASC-22) * Set up asciidoc based documentation (CASSANDRASC-15) * Gradle can now generate Deb packages, RPMs and Docker containers (CASSANDRASC-14) * Security patch to fix incorrect usage of yaml configuration (CASSANDRASC-12) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-22) RESTEasy integration for Cassandra Sidecar
[ https://issues.apache.org/jira/browse/CASSANDRASC-22?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17096865#comment-17096865 ] ASF subversion and git services commented on CASSANDRASC-22: Commit c9da4b213946fc6dbe8cdcbbc2445348f14a89af in cassandra-sidecar's branch refs/heads/master from Dinesh A. Joshi [ https://gitbox.apache.org/repos/asf?p=cassandra-sidecar.git;h=c9da4b2 ] Ninja-Fix: CHANGES.txt for CASSANDRASC-22 > RESTEasy integration for Cassandra Sidecar > -- > > Key: CASSANDRASC-22 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-22 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Dinesh Joshi >Assignee: Dinesh Joshi >Priority: Normal > Attachments: image-2020-04-27-22-59-40-060.png, > image-2020-04-29-01-14-11-756.png, image-2020-04-29-10-33-37-196.png, > image-2020-04-29-13-33-13-467.png, image-2020-04-29-13-33-43-069.png, > image-2020-04-29-13-35-17-071.png, image-2020-04-29-13-35-29-981.png > > > Add support for JAX-RS based routing via RESTEasy to Cassandra Sidecar. This > also dynamically generates swagger documentation and adds the swagger UI. > [Branch|https://github.com/dineshjoshi/cassandra-sidecar/tree/resteasy-swagger] > [Tests|https://circleci.com/workflow-run/a7888146-a22d-45af-983a-8833b77eef59] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRASC-22) RESTEasy integration for Cassandra Sidecar
[ https://issues.apache.org/jira/browse/CASSANDRASC-22?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17096860#comment-17096860 ] ASF subversion and git services commented on CASSANDRASC-22: Commit 2265e614d36198cb78134dd7463c6aa3799481ce in cassandra-sidecar's branch refs/heads/master from Dinesh A. Joshi [ https://gitbox.apache.org/repos/asf?p=cassandra-sidecar.git;h=2265e61 ] RESTEasy integration with dynamically generated Swagger OpenAPI, Swagger UI and JAX-RS. This patch introduces JAX-RS based annotation for defining APIs. It removes the manually created api.yaml (OpenAPI spec) of the API definitions in favor of the dynamically generated spec based on JAX-RS annotations. It also introduces Swagger UI to browse the Sidecar APIs and to experiment with them. Finally, it updates the CircleCI workflows such that the builds are run across both Docker and Machine images. We also gate packaging builds on success of the compile and test builds. The rationale for running the builds across both Docker and Machine images is that running the build on a Machine image exposed a race condition. Patch by Dinesh Joshi; Reviewed by Jon Haddad and Yifan Cai for CASSANDRASC-22 > RESTEasy integration for Cassandra Sidecar > -- > > Key: CASSANDRASC-22 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-22 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Rest API >Reporter: Dinesh Joshi >Assignee: Dinesh Joshi >Priority: Normal > Attachments: image-2020-04-27-22-59-40-060.png, > image-2020-04-29-01-14-11-756.png, image-2020-04-29-10-33-37-196.png, > image-2020-04-29-13-33-13-467.png, image-2020-04-29-13-33-43-069.png, > image-2020-04-29-13-35-17-071.png, image-2020-04-29-13-35-29-981.png > > > Add support for JAX-RS based routing via RESTEasy to Cassandra Sidecar. This > also dynamically generates swagger documentation and adds the swagger UI. > [Branch|https://github.com/dineshjoshi/cassandra-sidecar/tree/resteasy-swagger] > [Tests|https://circleci.com/workflow-run/a7888146-a22d-45af-983a-8833b77eef59] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-sidecar] branch master updated: RESTEasy integration with dynamically generated Swagger OpenAPI, Swagger UI and JAX-RS.
This is an automated email from the ASF dual-hosted git repository. djoshi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cassandra-sidecar.git The following commit(s) were added to refs/heads/master by this push: new 2265e61 RESTEasy integration with dynamically generated Swagger OpenAPI, Swagger UI and JAX-RS. 2265e61 is described below commit 2265e614d36198cb78134dd7463c6aa3799481ce Author: Dinesh A. Joshi AuthorDate: Sun Nov 24 20:37:46 2019 -0800 RESTEasy integration with dynamically generated Swagger OpenAPI, Swagger UI and JAX-RS. This patch introduces JAX-RS based annotation for defining APIs. It removes the manually created api.yaml (OpenAPI spec) of the API definitions in favor of the dynamically generated spec based on JAX-RS annotations. It also introduces Swagger UI to browse the Sidecar APIs and to experiment with them. Finally, it updates the CircleCI workflows such that the builds are run across both Docker and Machine images. We also gate packaging builds on success of the compile and test builds. The rationale for running the builds across both Docker and Machine images is that running the build on a Machine image exposed a race condition. Patch by Dinesh Joshi; Reviewed by Jon Haddad and Yifan Cai for CASSANDRASC-22 --- .circleci/config.yml | 99 ++--- .gitignore | 2 - api.yaml | 57 -- build.gradle | 33 +-- .../sidecar/HealthServiceIntegrationTest.java | 226 ++--- .../apache/cassandra/sidecar/Configuration.java| 2 + .../org/apache/cassandra/sidecar/MainModule.java | 53 +++-- .../cassandra/sidecar/routes/HealthService.java| 38 ++-- .../sidecar/routes/SwaggerOpenApiResource.java | 60 ++ src/main/resources/docs/index.html | 95 + .../sidecar/AbstractHealthServiceTest.java | 28 ++- .../cassandra/sidecar/HealthServiceSslTest.java| 8 - .../cassandra/sidecar/HealthServiceTest.java | 8 - .../org/apache/cassandra/sidecar/TestModule.java | 44 .../apache/cassandra/sidecar/TestSslModule.java| 7 - 15 files changed, 486 insertions(+), 274 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 8712204..893c9bc 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -40,6 +40,21 @@ commands: - run: sudo apt-get install apt-transport-https ca-certificates curl gnupg-agent software-properties-common jobs: + java8_docker: +docker: + - image: circleci/openjdk:8-jdk-stretch +steps: + - checkout + + - run: ./gradlew -i clean build --stacktrace + + - store_artifacts: + path: build/reports + destination: test-reports + + - store_test_results: + path: ~/repo/build/test-results/ + java8: <<: *base_job @@ -53,7 +68,22 @@ jobs: - run: sudo update-java-alternatives -s adoptopenjdk-8-hotspot-amd64 && java -version # make sure it builds with build steps like swagger docs and dist - - run: ./gradlew build --stacktrace + - run: ./gradlew -i clean build --stacktrace + + - store_artifacts: + path: build/reports + destination: test-reports + + - store_test_results: + path: ~/repo/build/test-results/ + + java11_docker: +docker: + - image: circleci/openjdk:11-jdk-stretch +steps: + - checkout + + - run: ./gradlew -i clean build --stacktrace - store_artifacts: path: build/reports @@ -73,7 +103,7 @@ jobs: - run: sudo update-java-alternatives -s adoptopenjdk-11-hotspot-amd64 && java -version - - run: ./gradlew build --stacktrace + - run: ./gradlew -i clean build --stacktrace - store_artifacts: path: build/reports @@ -84,13 +114,11 @@ jobs: # ensures we can build and install deb packages deb_build_install: -<<: *base_job +docker: + - image: circleci/openjdk:11-jdk-stretch steps: - checkout - - install_common - - install_java: - version: adoptopenjdk-11-hotspot - - run: ./gradlew buildDeb + - run: ./gradlew -i clean buildDeb - run: DEBIAN_FRONTEND=noninteractive sudo apt install -y ./build/distributions/cassandra-sidecar*.deb - run: test -f /opt/cassandra-sidecar/bin/cassandra-sidecar @@ -100,7 +128,7 @@ jobs: steps: - checkout - run: yum install -y java-11-openjdk-devel # the image uses root by default, no need for sudo - - run: JAVA_HOME=/usr/lib/jvm/java-11-openjdk ./gradlew buildRpm + - run: JAVA_HOME=/usr/lib/jvm/java-11-openjdk ./gradlew -i buildRpm - run: yum install -y ./build/distributions/cassandra-sidecar*.rpm - run: test -f
[jira] [Comment Edited] (CASSANDRA-15777) All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
[
https://issues.apache.org/jira/browse/CASSANDRA-15777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17096459#comment-17096459
]
Michael Semb Wever edited comment on CASSANDRA-15777 at 4/30/20, 6:22 PM:
--
||branch||circleci||jenkins||
|[cassandra_2.2_15777|https://github.com/apache/cassandra/compare/cassandra-2.2...thelastpickle:mck/cassandra-2.2_15777]|[circleci|https://circleci.com/gh/thelastpickle/workflows/cassandra/tree/mck%2Fcassandra-2.2_15777]|[!https://ci-cassandra.apache.org/job/Cassandra-devbranch-test/69/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch-test/69]|
|[cassandra_3.0_15777|https://github.com/apache/cassandra/compare/cassandra-3.0...thelastpickle:mck/cassandra-3.0_15777]|[circleci|https://circleci.com/gh/thelastpickle/workflows/cassandra/tree/mck%2Fcassandra-3.0_15777]|[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/78/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/78]|
|[cassandra_3.11_15777|https://github.com/apache/cassandra/compare/cassandra-3.11...thelastpickle:mck/cassandra-3.11_15777]|[circleci|https://circleci.com/gh/thelastpickle/workflows/cassandra/tree/mck%2Fcassandra-3.11_15777]|[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/79/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/79]|
|[trunk_15777|https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/trunk_15777]|[circleci|https://circleci.com/gh/thelastpickle/workflows/cassandra/tree/mck%2Ftrunk_15777]|[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/80/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/80]|
was (Author: michaelsembwever):
||branch||circleci||jenkins||
|[cassandra_2.2_15777|https://github.com/apache/cassandra/compare/cassandra-2.2...thelastpickle:mck/cassandra-2.2_15777]|[circleci|https://circleci.com/gh/thelastpickle/workflows/cassandra/tree/mck%2Fcassandra-2.2_15777]|[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/77/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/77]|
|[cassandra_3.0_15777|https://github.com/apache/cassandra/compare/cassandra-3.0...thelastpickle:mck/cassandra-3.0_15777]|[circleci|https://circleci.com/gh/thelastpickle/workflows/cassandra/tree/mck%2Fcassandra-3.0_15777]|[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/78/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/78]|
|[cassandra_3.11_15777|https://github.com/apache/cassandra/compare/cassandra-3.11...thelastpickle:mck/cassandra-3.11_15777]|[circleci|https://circleci.com/gh/thelastpickle/workflows/cassandra/tree/mck%2Fcassandra-3.11_15777]|[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/79/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/79]|
|[trunk_15777|https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/trunk_15777]|[circleci|https://circleci.com/gh/thelastpickle/workflows/cassandra/tree/mck%2Ftrunk_15777]|[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/80/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/80]|
> All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
>
>
> Key: CASSANDRA-15777
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15777
> Project: Cassandra
> Issue Type: Bug
> Components: Build, Test/unit
>Reporter: Michael Semb Wever
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 2.2.17, 3.0.21, 3.11.7, 4.0-alpha
>
>
> Make all test targets declare the temp directory (java.io.tmpdir) as defined
> by tmp.dir
> This was originally done in CASSANDRA-7712 but has been eroded over time as
> the test targets evolved.
> The attached patch moves the
> {code}{code}
> into the {{testmacrohelper}} macrodef.
> Like CASSANDRA-7712, jenkins agents are filling up their root volumes because
> of what's left behind under {{"/tmp"}}
> The build scripts have already been configured to define the temp directory
> to be within the jenkins job's workspace:
> https://github.com/apache/cassandra-builds/commit/33ba1e30ea196180f7d70f8e6ec47fdf6844f3f6#diff-91876f5f158ec50dab9a70cc06c06922
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail:
[jira] [Updated] (CASSANDRA-15777) All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
[
https://issues.apache.org/jira/browse/CASSANDRA-15777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Semb Wever updated CASSANDRA-15777:
---
Fix Version/s: (was: 3.11.x)
(was: 3.0.x)
(was: 2.2.x)
3.11.7
3.0.21
2.2.17
Since Version: 2.1 rc3
Source Control Link:
https://github.com/apache/cassandra/commit/b44a2140f88e49ac533bb1cfe3db4308929a33ea
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
Committed as b44a2140f88e49ac533bb1cfe3db4308929a33ea
> All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
>
>
> Key: CASSANDRA-15777
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15777
> Project: Cassandra
> Issue Type: Bug
> Components: Build, Test/unit
>Reporter: Michael Semb Wever
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 2.2.17, 3.0.21, 3.11.7, 4.0-alpha
>
>
> Make all test targets declare the temp directory (java.io.tmpdir) as defined
> by tmp.dir
> This was originally done in CASSANDRA-7712 but has been eroded over time as
> the test targets evolved.
> The attached patch moves the
> {code}{code}
> into the {{testmacrohelper}} macrodef.
> Like CASSANDRA-7712, jenkins agents are filling up their root volumes because
> of what's left behind under {{"/tmp"}}
> The build scripts have already been configured to define the temp directory
> to be within the jenkins job's workspace:
> https://github.com/apache/cassandra-builds/commit/33ba1e30ea196180f7d70f8e6ec47fdf6844f3f6#diff-91876f5f158ec50dab9a70cc06c06922
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-14781) Log message when mutation passed to CommitLog#add(Mutation) is too large is not descriptive enough
[
https://issues.apache.org/jira/browse/CASSANDRA-14781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17096595#comment-17096595
]
Jordan West edited comment on CASSANDRA-14781 at 4/30/20, 5:46 PM:
---
Hi [~n.v.harikrishna]. I've picked this back up and am getting it ready to
commit. Thanks for your patience.
I've squashed your branch here:
[https://github.com/jrwest/cassandra/commits/14781-trunk.] I made a few minor
changes along the way (I also re-reviewed since it had been a little bit since
I had read the patch):
* Modified {{CHANGES.txt}}
* Modified {{IMutation#validateSize}} javadoc
* Moved call to {{Keyspace.open}} into the catch block of
{{BlockingReadRepairs#createRepairMutation}}. It was only used if we reached
that block anyways.
* Fixed whitespace formatting in
{{MutationExceededMaxSizeException#prepareMessage}}
I ran a build prior to these changes. The build looked good (better than trunk
actually) and any failures do not seem related:
[https://app.circleci.com/pipelines/github/jrwest/cassandra/4/workflows/e43918eb-40d2-45ad-80c3-dbeaa5ee186b]
I've kicked off a new build with the changes above and with the squash
performed:
[https://app.circleci.com/pipelines/github/jrwest/cassandra/6/workflows/3c3f674e-db89-488a-bbd5-98f04de4fd0d]
EDIT:
I was slightly concerned about the failure in {{read_repair_test.py}}'s
{{test_speculative_data_request}}. Looking closer at the test runs, its flaky
and doesn't look like that flakiness could be related to the changes here
(since the mutation sizes are static).
I've also kicked off a Jenkins build for good measure:
https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/81/
was (Author: jrwest):
Hi [~n.v.harikrishna]. I've picked this back up and am getting it ready to
commit. Thanks for your patience.
I've squashed your branch here:
[https://github.com/jrwest/cassandra/commits/14781-trunk.] I made a few minor
changes along the way (I also re-reviewed since it had been a little bit since
I had read the patch):
* Modified {{CHANGES.txt}}
* Modified {{IMutation#validateSize}} javadoc
* Moved call to {{Keyspace.open}} into the catch block of
{{BlockingReadRepairs#createRepairMutation}}. It was only used if we reached
that block anyways.
* Fixed whitespace formatting in
{{MutationExceededMaxSizeException#prepareMessage}}
I ran a build prior to these changes. The build looked good (better than trunk
actually) and any failures do not seem related:
[https://app.circleci.com/pipelines/github/jrwest/cassandra/4/workflows/e43918eb-40d2-45ad-80c3-dbeaa5ee186b]
I've kicked off a new build with the changes above and with the squash
performed:
[https://app.circleci.com/pipelines/github/jrwest/cassandra/6/workflows/3c3f674e-db89-488a-bbd5-98f04de4fd0d]
> Log message when mutation passed to CommitLog#add(Mutation) is too large is
> not descriptive enough
> --
>
> Key: CASSANDRA-14781
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14781
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Hints, Local/Commit Log, Messaging/Client
>Reporter: Jordan West
>Assignee: Venkata Harikrishna Nukala
>Priority: Normal
> Labels: protocolv5
> Fix For: 4.0-beta
>
> Attachments: CASSANDRA-14781.patch, CASSANDRA-14781_3.0.patch,
> CASSANDRA-14781_3.11.patch
>
>
> When hitting
> [https://github.com/apache/cassandra/blob/cassandra-3.0/src/java/org/apache/cassandra/db/commitlog/CommitLog.java#L256-L257],
> the log message produced does not help the operator track down what data is
> being written. At a minimum the keyspace and cfIds involved would be useful
> (and are available) – more detail might not be reasonable to include.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-2.2 updated: Make all test targets declare the temp directory (java.io.tmpdir) as defined by tmp.dir
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch cassandra-2.2 in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/cassandra-2.2 by this push: new b44a214 Make all test targets declare the temp directory (java.io.tmpdir) as defined by tmp.dir b44a214 is described below commit b44a2140f88e49ac533bb1cfe3db4308929a33ea Author: Mick Semb Wever AuthorDate: Thu Apr 30 13:28:31 2020 +0200 Make all test targets declare the temp directory (java.io.tmpdir) as defined by tmp.dir patch by Mick Semb Wever; reviewed by Berenguer Blasi, Ekaterina Dimitrova for CASSANDRA-15777 --- build.xml | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/build.xml b/build.xml index ed9c1a2..6bef406 100644 --- a/build.xml +++ b/build.xml @@ -1269,6 +1269,7 @@ +
[cassandra] 01/01: Merge branch 'cassandra-3.11' into trunk
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 03c9bd316349b0cea930d688af3955507d12f2b3 Merge: 6a42c21 4801fef Author: Mick Semb Wever AuthorDate: Thu Apr 30 19:36:25 2020 +0200 Merge branch 'cassandra-3.11' into trunk build.xml | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --cc build.xml index 318947a,060aa1d..3cc4f1b --- a/build.xml +++ b/build.xml @@@ -1398,8 -1270,9 +1398,9 @@@ - + +
[cassandra] branch cassandra-3.0 updated (ed62641 -> 0fd9b5b)
This is an automated email from the ASF dual-hosted git repository. mck pushed a change to branch cassandra-3.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from ed62641 Use different package names for the cqlsh-tests matrix values, so final aggregated test reports are distinguished new b44a214 Make all test targets declare the temp directory (java.io.tmpdir) as defined by tmp.dir new 0fd9b5b Merge branch 'cassandra-2.2' into cassandra-3.0 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: build.xml | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.0' into cassandra-3.11
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 4801fef22aa43baa5c24ae2e4c8fbb4bf828e2c2 Merge: 8a4e2ed 0fd9b5b Author: Mick Semb Wever AuthorDate: Thu Apr 30 19:35:05 2020 +0200 Merge branch 'cassandra-3.0' into cassandra-3.11 build.xml | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.11 updated (8a4e2ed -> 4801fef)
This is an automated email from the ASF dual-hosted git repository. mck pushed a change to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 8a4e2ed Merge branch 'cassandra-3.0' into cassandra-3.11 new b44a214 Make all test targets declare the temp directory (java.io.tmpdir) as defined by tmp.dir new 0fd9b5b Merge branch 'cassandra-2.2' into cassandra-3.0 new 4801fef Merge branch 'cassandra-3.0' into cassandra-3.11 The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: build.xml | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-2.2' into cassandra-3.0
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch cassandra-3.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 0fd9b5bd6fe45ccd61ed2e194f4991aab4ea71c5 Merge: ed62641 b44a214 Author: Mick Semb Wever AuthorDate: Thu Apr 30 19:30:59 2020 +0200 Merge branch 'cassandra-2.2' into cassandra-3.0 build.xml | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --cc build.xml index 2527883,6bef406..664e98c --- a/build.xml +++ b/build.xml @@@ -1309,12 -1357,14 +1310,11 @@@ - - - - + - + @@@ -1819,39 -1872,6 +1818,38 @@@ + + + + + + + + + + + + + + + + + + + + + + + + + + + - + + + + + - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (6a42c21 -> 03c9bd3)
This is an automated email from the ASF dual-hosted git repository. mck pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 6a42c21 replace LZ4FastDecompressor with LZ4SafeDecompressor new b44a214 Make all test targets declare the temp directory (java.io.tmpdir) as defined by tmp.dir new 0fd9b5b Merge branch 'cassandra-2.2' into cassandra-3.0 new 4801fef Merge branch 'cassandra-3.0' into cassandra-3.11 new 03c9bd3 Merge branch 'cassandra-3.11' into trunk The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: build.xml | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15777) All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
[
https://issues.apache.org/jira/browse/CASSANDRA-15777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17096806#comment-17096806
]
Michael Semb Wever commented on CASSANDRA-15777:
Thanks [~dcapwell].
> All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
>
>
> Key: CASSANDRA-15777
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15777
> Project: Cassandra
> Issue Type: Bug
> Components: Build, Test/unit
>Reporter: Michael Semb Wever
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-alpha
>
>
> Make all test targets declare the temp directory (java.io.tmpdir) as defined
> by tmp.dir
> This was originally done in CASSANDRA-7712 but has been eroded over time as
> the test targets evolved.
> The attached patch moves the
> {code}{code}
> into the {{testmacrohelper}} macrodef.
> Like CASSANDRA-7712, jenkins agents are filling up their root volumes because
> of what's left behind under {{"/tmp"}}
> The build scripts have already been configured to define the temp directory
> to be within the jenkins job's workspace:
> https://github.com/apache/cassandra-builds/commit/33ba1e30ea196180f7d70f8e6ec47fdf6844f3f6#diff-91876f5f158ec50dab9a70cc06c06922
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15777) All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
[
https://issues.apache.org/jira/browse/CASSANDRA-15777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17096787#comment-17096787
]
David Capwell commented on CASSANDRA-15777:
---
testclasslist -> testlist -> testmacrohelper
testmacro -> testmacrohelper
The cassandra patch LGTM +1.
For the build, you can also do the below; mostly calling out as this lets you
override more without having to change every ant call site (not asking to
change though).
{code}
cat < build.properties
tmp.dir: $PWD/tmp
EOF
{code}
> All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
>
>
> Key: CASSANDRA-15777
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15777
> Project: Cassandra
> Issue Type: Bug
> Components: Build, Test/unit
>Reporter: Michael Semb Wever
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-alpha
>
>
> Make all test targets declare the temp directory (java.io.tmpdir) as defined
> by tmp.dir
> This was originally done in CASSANDRA-7712 but has been eroded over time as
> the test targets evolved.
> The attached patch moves the
> {code}{code}
> into the {{testmacrohelper}} macrodef.
> Like CASSANDRA-7712, jenkins agents are filling up their root volumes because
> of what's left behind under {{"/tmp"}}
> The build scripts have already been configured to define the temp directory
> to be within the jenkins job's workspace:
> https://github.com/apache/cassandra-builds/commit/33ba1e30ea196180f7d70f8e6ec47fdf6844f3f6#diff-91876f5f158ec50dab9a70cc06c06922
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15729) Jenkins Test Results Report in plaintext for ASF ML
[ https://issues.apache.org/jira/browse/CASSANDRA-15729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17096715#comment-17096715 ] Michael Semb Wever commented on CASSANDRA-15729: bq. dockerise the cassandra-test-report.sh script (cassandra-builds) This is at https://github.com/apache/cassandra-builds/compare/master...thelastpickle:mck/jenkins-test-report-format I'm unsure about what the file and tag name should be for the docker image. > Jenkins Test Results Report in plaintext for ASF ML > --- > > Key: CASSANDRA-15729 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15729 > Project: Cassandra > Issue Type: Task > Components: Build, CI >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Labels: Jenkins > Fix For: 4.0-beta > > > The Jenkins pipeline builds now aggregate all test reports. > For example: > - https://ci-cassandra.apache.org/job/Cassandra-trunk/68/testReport/ > - > https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-trunk/detail/Cassandra-trunk/68/tests > But Jenkins can only keep a limited amount of build history, so those links > are not permanent, can't be used as references, and don't help for bisecting > and blame on regressions (and flakey tests) over a longer period of time. > The builds@ ML can provide a permanent record of test results. > This was first brought up in these two threads: > - > https://lists.apache.org/thread.html/re8122e4fdd8629e7fbca2abf27d72054b3bc0e3690ece8b8e66f618b%40%3Cdev.cassandra.apache.org%3E > - > https://lists.apache.org/thread.html/ra5f6aeea89546825fe7ccc4a80898c62f8ed57decabf709d81d9c720%40%3Cdev.cassandra.apache.org%3E > An example plaintext report, to demonstrate feasibility, is available here: > https://lists.apache.org/thread.html/r80d13f7af706bf8dfbf2387fab46004c1fbd3917b7bc339c49e69aa8%40%3Cbuilds.cassandra.apache.org%3E > Hurdles: > - the ASF mailing lists won't accept html, attachments, or any message body > over 1MB. > - packages are used as a differentiator in the final aggregated report. The > cqlsh and dtests currently don't specify it. It needs to be added as a > "dot-separated" prefix to the testsuite and testcase name. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15777) All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
[
https://issues.apache.org/jira/browse/CASSANDRA-15777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-15777:
Status: Ready to Commit (was: Review In Progress)
> All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
>
>
> Key: CASSANDRA-15777
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15777
> Project: Cassandra
> Issue Type: Bug
> Components: Build, Test/unit
>Reporter: Michael Semb Wever
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-alpha
>
>
> Make all test targets declare the temp directory (java.io.tmpdir) as defined
> by tmp.dir
> This was originally done in CASSANDRA-7712 but has been eroded over time as
> the test targets evolved.
> The attached patch moves the
> {code}{code}
> into the {{testmacrohelper}} macrodef.
> Like CASSANDRA-7712, jenkins agents are filling up their root volumes because
> of what's left behind under {{"/tmp"}}
> The build scripts have already been configured to define the temp directory
> to be within the jenkins job's workspace:
> https://github.com/apache/cassandra-builds/commit/33ba1e30ea196180f7d70f8e6ec47fdf6844f3f6#diff-91876f5f158ec50dab9a70cc06c06922
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15777) All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
[
https://issues.apache.org/jira/browse/CASSANDRA-15777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17096709#comment-17096709
]
Ekaterina Dimitrova commented on CASSANDRA-15777:
-
Moved in Ready to commit but I am not a committer. :-) Please commit
> All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
>
>
> Key: CASSANDRA-15777
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15777
> Project: Cassandra
> Issue Type: Bug
> Components: Build, Test/unit
>Reporter: Michael Semb Wever
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-alpha
>
>
> Make all test targets declare the temp directory (java.io.tmpdir) as defined
> by tmp.dir
> This was originally done in CASSANDRA-7712 but has been eroded over time as
> the test targets evolved.
> The attached patch moves the
> {code}{code}
> into the {{testmacrohelper}} macrodef.
> Like CASSANDRA-7712, jenkins agents are filling up their root volumes because
> of what's left behind under {{"/tmp"}}
> The build scripts have already been configured to define the temp directory
> to be within the jenkins job's workspace:
> https://github.com/apache/cassandra-builds/commit/33ba1e30ea196180f7d70f8e6ec47fdf6844f3f6#diff-91876f5f158ec50dab9a70cc06c06922
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15777) All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
[
https://issues.apache.org/jira/browse/CASSANDRA-15777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17096680#comment-17096680
]
Michael Semb Wever edited comment on CASSANDRA-15777 at 4/30/20, 3:48 PM:
--
Verified in CI with the following output from
https://ci-cassandra.apache.org/job/Cassandra-devbranch-test/70/console which
shows the tmp directory in the build workspace is being used.
{noformat}
14:47:52 + find . -maxdepth 2 -type d -exec du -hs {} ;
14:47:52 483M .
14:47:52 365M ./.git
14:47:52 48K./.git/hooks
14:47:52 4.0K ./.git/info
14:47:52 0 ./.git/branches
14:47:52 3.7M ./.git/refs
14:47:52 359M ./.git/objects
14:47:52 2.2M ./.git/logs
14:47:52 140K ./.circleci
14:47:52 12K./.jenkins
14:47:52 240K ./bin
14:47:52 144K ./conf
14:47:52 4.0K ./conf/triggers
14:47:52 104K ./debian
14:47:52 12K./debian/patches
14:47:52 408K ./doc
14:47:52 296K ./doc/cql3
14:47:52 76K./examples
14:47:52 16K./examples/triggers
14:47:52 60K./examples/hadoop_cql3_word_count
14:47:52 76K./ide
14:47:52 72K./ide/idea
14:47:52 25M./lib
14:47:52 460K ./lib/licenses
14:47:52 6.7M ./lib/sigar-bin
14:47:52 460K ./pylib
14:47:52 448K ./pylib/cqlshlib
14:47:52 28K./redhat
14:47:52 13M./src
14:47:52 13M./src/java
14:47:52 4.0K ./src/resources
14:47:52 4.0K ./src/jdkoverride
14:47:52 70M./test
14:47:52 92K./test/burn
14:47:52 40K./test/conf
14:47:52 64M./test/data
14:47:52 292K ./test/distributed
14:47:52 144K ./test/long
14:47:52 36K./test/microbench
14:47:52 48K./test/resources
14:47:52 6.2M ./test/unit
14:47:52 892K ./tools
14:47:52 80K./tools/bin
14:47:52 800K ./tools/stress
14:47:52 460K ./cassandra-builds
14:47:52 236K ./cassandra-builds/.git
14:47:52 48K./cassandra-builds/build-scripts
14:47:52 32K./cassandra-builds/cassandra-release
14:47:52 0 ./cassandra-builds/dist
14:47:52 68K./cassandra-builds/docker
14:47:52 44K./cassandra-builds/jenkins-dsl
14:47:52 4.2M ./tmp
14:47:52 0 ./tmp/jna--1712433994
14:47:52 0 ./tmp/something6875525018590718980
14:47:52 0 ./tmp/Keyspace1
14:47:52 200K ./tmp/1588249903123-0
14:47:52 8.0K ./tmp/5486536555493548056
14:47:52 36K./tmp/1588250143825-0
14:47:52 36K./tmp/1588250143992-0
14:47:52 4.0K ./tmp/1588250402390-0
14:47:52 4.0K ./tmp/1588250422866-0
14:47:52 8.0K ./tmp/1588249509129-0
14:47:52 36K./tmp/8965738820013814910
14:47:52 0 ./tmp/6451432372843992708
14:47:52 256K ./tmp/1588249901385-0
14:47:52 8.0K ./tmp/1588249904898-0
14:47:52 8.0K ./tmp/2626815944938445495
14:47:52 164K ./tmp/840198530903671919
14:47:52 2.3M ./tmp/1588250142889-0
14:47:52 36K./tmp/1588250143947-0
14:47:52 4.0K ./tmp/1588250402383-0
14:47:52 0 ./tmp/subdir
14:47:52 4.0K ./tmp/1588250422859-0
14:47:52 8.0K ./tmp/1588249514052-0
14:47:52 264K ./tmp/1588249902435-0
14:47:52 4.0K ./tmp/1588250134087-0
14:47:52 4.0K ./tmp/1588250134186-0
14:47:52 84K./tmp/1588250142861-0
14:47:52 0 ./tmp/1588250143941-0
14:47:52 184K ./tmp/1588250144036-0
14:47:52 8.0K ./tmp/1588249518823-0
14:47:52 8.0K ./tmp/1588249523701-0
14:47:52 3.0M ./interface
14:47:52 2.9M ./interface/thrift
{noformat}
was (Author: michaelsembwever):
Verified in CI with the following output from
https://ci-cassandra.apache.org/job/Cassandra-devbranch-test/70/console which
shows the tmp directory in the build workspace is being used.
{noformat}
14:47:52 + find . -maxdepth 2 -type d -exec du -hs {} ;
14:47:52 483M .
14:47:52 365M ./.git
14:47:52 48K./.git/hooks
14:47:52 4.0K ./.git/info
14:47:52 0 ./.git/branches
14:47:52 3.7M ./.git/refs
14:47:52 359M ./.git/objects
14:47:52 2.2M ./.git/logs
14:47:52 140K ./.circleci
14:47:52 12K./.jenkins
14:47:52 240K ./bin
14:47:52 144K ./conf
14:47:52 4.0K ./conf/triggers
14:47:52 104K ./debian
14:47:52 12K./debian/patches
14:47:52 408K ./doc
14:47:52 296K ./doc/cql3
14:47:52 76K./examples
14:47:52 16K./examples/triggers
14:47:52 60K./examples/hadoop_cql3_word_count
14:47:52 76K./ide
14:47:52 72K./ide/idea
14:47:52 25M./lib
14:47:52 460K ./lib/licenses
14:47:52 6.7M ./lib/sigar-bin
14:47:52 460K ./pylib
14:47:52 448K ./pylib/cqlshlib
14:47:52 28K./redhat
14:47:52 13M./src
14:47:52 13M./src/java
14:47:52 4.0K ./src/resources
14:47:52 4.0K ./src/jdkoverride
14:47:52 70M./test
14:47:52 92K./test/burn
14:47:52 40K./test/conf
14:47:52 64M./test/data
14:47:52 292K ./test/distributed
14:47:52 144K ./test/long
14:47:52 36K./test/microbench
14:47:52 48K./test/resources
14:47:52 6.2M ./test/unit
14:47:52 892K ./tools
14:47:52 80K./tools/bin
14:47:52 800K ./tools/stress
14:47:52 460K ./cassandra-builds
14:47:52 236K ./cassandra-builds/.git
14:47:52
[jira] [Commented] (CASSANDRA-15777) All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
[
https://issues.apache.org/jira/browse/CASSANDRA-15777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17096680#comment-17096680
]
Michael Semb Wever commented on CASSANDRA-15777:
Verified in CI with the following output from
https://ci-cassandra.apache.org/job/Cassandra-devbranch-test/70/console which
shows the tmp directory in the build workspace is being used.
{noformat}
14:47:52 + find . -maxdepth 2 -type d -exec du -hs {} ;
14:47:52 483M .
14:47:52 365M ./.git
14:47:52 48K./.git/hooks
14:47:52 4.0K ./.git/info
14:47:52 0 ./.git/branches
14:47:52 3.7M ./.git/refs
14:47:52 359M ./.git/objects
14:47:52 2.2M ./.git/logs
14:47:52 140K ./.circleci
14:47:52 12K./.jenkins
14:47:52 240K ./bin
14:47:52 144K ./conf
14:47:52 4.0K ./conf/triggers
14:47:52 104K ./debian
14:47:52 12K./debian/patches
14:47:52 408K ./doc
14:47:52 296K ./doc/cql3
14:47:52 76K./examples
14:47:52 16K./examples/triggers
14:47:52 60K./examples/hadoop_cql3_word_count
14:47:52 76K./ide
14:47:52 72K./ide/idea
14:47:52 25M./lib
14:47:52 460K ./lib/licenses
14:47:52 6.7M ./lib/sigar-bin
14:47:52 460K ./pylib
14:47:52 448K ./pylib/cqlshlib
14:47:52 28K./redhat
14:47:52 13M./src
14:47:52 13M./src/java
14:47:52 4.0K ./src/resources
14:47:52 4.0K ./src/jdkoverride
14:47:52 70M./test
14:47:52 92K./test/burn
14:47:52 40K./test/conf
14:47:52 64M./test/data
14:47:52 292K ./test/distributed
14:47:52 144K ./test/long
14:47:52 36K./test/microbench
14:47:52 48K./test/resources
14:47:52 6.2M ./test/unit
14:47:52 892K ./tools
14:47:52 80K./tools/bin
14:47:52 800K ./tools/stress
14:47:52 460K ./cassandra-builds
14:47:52 236K ./cassandra-builds/.git
14:47:52 48K./cassandra-builds/build-scripts
14:47:52 32K./cassandra-builds/cassandra-release
14:47:52 0 ./cassandra-builds/dist
14:47:52 68K./cassandra-builds/docker
14:47:52 44K./cassandra-builds/jenkins-dsl
14:47:52 4.2M ./tmp
14:47:52 0 ./tmp/jna--1712433994
14:47:52 0 ./tmp/something6875525018590718980
14:47:52 0 ./tmp/Keyspace1
14:47:52 200K ./tmp/1588249903123-0
14:47:52 8.0K ./tmp/5486536555493548056
14:47:52 36K./tmp/1588250143825-0
14:47:52 36K./tmp/1588250143992-0
14:47:52 4.0K ./tmp/1588250402390-0
14:47:52 4.0K ./tmp/1588250422866-0
14:47:52 8.0K ./tmp/1588249509129-0
14:47:52 36K./tmp/8965738820013814910
14:47:52 0 ./tmp/6451432372843992708
14:47:52 256K ./tmp/1588249901385-0
14:47:52 8.0K ./tmp/1588249904898-0
14:47:52 8.0K ./tmp/2626815944938445495
14:47:52 164K ./tmp/840198530903671919
14:47:52 2.3M ./tmp/1588250142889-0
14:47:52 36K./tmp/1588250143947-0
14:47:52 4.0K ./tmp/1588250402383-0
14:47:52 0 ./tmp/subdir
14:47:52 4.0K ./tmp/1588250422859-0
14:47:52 8.0K ./tmp/1588249514052-0
14:47:52 264K ./tmp/1588249902435-0
14:47:52 4.0K ./tmp/1588250134087-0
14:47:52 4.0K ./tmp/1588250134186-0
14:47:52 84K./tmp/1588250142861-0
14:47:52 0 ./tmp/1588250143941-0
14:47:52 184K ./tmp/1588250144036-0
14:47:52 8.0K ./tmp/1588249518823-0
14:47:52 8.0K ./tmp/1588249523701-0
14:47:52 3.0M ./interface
14:47:52 2.9M ./interface/thrift
14:47:52 + du -hs ../Cassandra-2.2-dtest-offheap
../Cassandra-3.0-test-compression ../Cassandra-3.11 ../Cassandra-devbranch
../Cassandra-devbranch-dtest ../Cassandra-devbranch-test
../Cassandra-devbranch-test@2 ../Cassandra-devbranch@2
../Cassandra-trunk-fqltool-test
14:47:52 305M ../Cassandra-2.2-dtest-offheap
14:47:52 302M ../Cassandra-3.0-test-compression
14:47:52 9.0M ../Cassandra-3.11
14:47:52 420K ../Cassandra-devbranch
14:47:52 442M ../Cassandra-devbranch-dtest
14:47:52 504M ../Cassandra-devbranch-test
14:47:52 483M ../Cassandra-devbranch-test@2
14:47:52 971M ../Cassandra-devbranch@2
14:47:52 321M ../Cassandra-trunk-fqltool-test
{noformat}
> All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
>
>
> Key: CASSANDRA-15777
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15777
> Project: Cassandra
> Issue Type: Bug
> Components: Build, Test/unit
>Reporter: Michael Semb Wever
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-alpha
>
>
> Make all test targets declare the temp directory (java.io.tmpdir) as defined
> by tmp.dir
> This was originally done in CASSANDRA-7712 but has been eroded over time as
> the test targets evolved.
> The attached patch moves the
> {code}{code}
> into the {{testmacrohelper}} macrodef.
> Like CASSANDRA-7712, jenkins agents are filling up their root volumes because
> of what's left behind under {{"/tmp"}}
> The build scripts have already been configured to
[jira] [Updated] (CASSANDRA-15560) Change io.compressor.LZ4Compressor to LZ4SafeDecompressor
[ https://issues.apache.org/jira/browse/CASSANDRA-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-15560: - Source Control Link: https://github.com/apache/cassandra/commit/6a42c21cb3e357caf4d7b2e8328f0f8f46f5269b Resolution: Fixed Status: Resolved (was: Ready to Commit) Nice detective work! I think you're right, and since that's the only problem I found, I committed this. Thanks! > Change io.compressor.LZ4Compressor to LZ4SafeDecompressor > - > > Key: CASSANDRA-15560 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15560 > Project: Cassandra > Issue Type: Improvement > Components: Feature/Compression >Reporter: Jordan West >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0, 4.0-rc > > Time Spent: 0.5h > Remaining Estimate: 0h > > CASSANDRA-15556 and related tickets showed that LZ4FastDecompressor can crash > the JVM and that LZ4SafeDecompressor performs better w/o the crash risk — its > also not deprecated. While we protect ourselves by checksumming the > compressed data but that doesn’t mean we should leave deprecated code that > can segfault the jvm (providing a potential DDOS vector among other things) > in crucial places like io.compress. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15560) Change io.compressor.LZ4Compressor to LZ4SafeDecompressor
[ https://issues.apache.org/jira/browse/CASSANDRA-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-15560: - Status: Ready to Commit (was: Review In Progress) > Change io.compressor.LZ4Compressor to LZ4SafeDecompressor > - > > Key: CASSANDRA-15560 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15560 > Project: Cassandra > Issue Type: Improvement > Components: Feature/Compression >Reporter: Jordan West >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0, 4.0-rc > > Time Spent: 0.5h > Remaining Estimate: 0h > > CASSANDRA-15556 and related tickets showed that LZ4FastDecompressor can crash > the JVM and that LZ4SafeDecompressor performs better w/o the crash risk — its > also not deprecated. While we protect ourselves by checksumming the > compressed data but that doesn’t mean we should leave deprecated code that > can segfault the jvm (providing a potential DDOS vector among other things) > in crucial places like io.compress. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: replace LZ4FastDecompressor with LZ4SafeDecompressor
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/trunk by this push:
new 6a42c21 replace LZ4FastDecompressor with LZ4SafeDecompressor
6a42c21 is described below
commit 6a42c21cb3e357caf4d7b2e8328f0f8f46f5269b
Author: Bereng
AuthorDate: Mon Apr 20 13:40:43 2020 +0200
replace LZ4FastDecompressor with LZ4SafeDecompressor
Patch by Berenguer Blasi, reviewed by brandonwilliams for CASSANDRA-15560
---
CHANGES.txt | 1 +
.../apache/cassandra/io/compress/LZ4Compressor.java | 21 +
.../org/apache/cassandra/net/FrameDecoderLZ4.java | 11 ++-
.../apache/cassandra/net/FrameDecoderLegacyLZ4.java | 9 +
.../async/StreamCompressionSerializer.java | 4 ++--
.../compress/StreamCompressionInputStream.java | 6 +++---
.../apache/cassandra/test/microbench/Sample.java| 4 ++--
.../async/StreamCompressionSerializerTest.java | 4 ++--
8 files changed, 34 insertions(+), 26 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index a1bf2fc..89c8d7d 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
4.0-alpha5
+ * replace LZ4FastDecompressor with LZ4SafeDecompressor (CASSANDRA-15560)
* Fix buffer pool NPE with concurrent release due to in-progress tiny pool
eviction (CASSANDRA-15726)
* Avoid race condition when completing stream sessions (CASSANDRA-15666)
* Flush with fast compressors by default (CASSANDRA-15379)
diff --git a/src/java/org/apache/cassandra/io/compress/LZ4Compressor.java
b/src/java/org/apache/cassandra/io/compress/LZ4Compressor.java
index 30ec8ba..6c333b7 100644
--- a/src/java/org/apache/cassandra/io/compress/LZ4Compressor.java
+++ b/src/java/org/apache/cassandra/io/compress/LZ4Compressor.java
@@ -78,7 +78,7 @@ public class LZ4Compressor implements ICompressor
}
private final net.jpountz.lz4.LZ4Compressor compressor;
-private final net.jpountz.lz4.LZ4FastDecompressor decompressor;
+private final net.jpountz.lz4.LZ4SafeDecompressor decompressor;
@VisibleForTesting
final String compressorType;
@VisibleForTesting
@@ -107,7 +107,7 @@ public class LZ4Compressor implements ICompressor
}
}
-decompressor = lz4Factory.fastDecompressor();
+decompressor = lz4Factory.safeDecompressor();
}
public int initialCompressedBufferLength(int chunkLength)
@@ -141,20 +141,24 @@ public class LZ4Compressor implements ICompressor
| ((input[inputOffset + 2] & 0xFF) << 16)
| ((input[inputOffset + 3] & 0xFF) << 24);
-final int compressedLength;
+final int writtenLength;
try
{
-compressedLength = decompressor.decompress(input, inputOffset +
INTEGER_BYTES,
- output, outputOffset,
decompressedLength);
+writtenLength = decompressor.decompress(input,
+inputOffset +
INTEGER_BYTES,
+inputLength -
INTEGER_BYTES,
+output,
+outputOffset,
+decompressedLength);
}
catch (LZ4Exception e)
{
throw new IOException(e);
}
-if (compressedLength != inputLength - INTEGER_BYTES)
+if (writtenLength != decompressedLength)
{
-throw new IOException("Compressed lengths mismatch");
+throw new IOException("Decompressed lengths mismatch");
}
return decompressedLength;
@@ -169,7 +173,8 @@ public class LZ4Compressor implements ICompressor
try
{
-int compressedLength = decompressor.decompress(input,
input.position(), output, output.position(), decompressedLength);
+int compressedLength = input.remaining();
+decompressor.decompress(input, input.position(),
input.remaining(), output, output.position(), decompressedLength);
input.position(input.position() + compressedLength);
output.position(output.position() + decompressedLength);
}
diff --git a/src/java/org/apache/cassandra/net/FrameDecoderLZ4.java
b/src/java/org/apache/cassandra/net/FrameDecoderLZ4.java
index 941139a..2b32d18 100644
--- a/src/java/org/apache/cassandra/net/FrameDecoderLZ4.java
+++ b/src/java/org/apache/cassandra/net/FrameDecoderLZ4.java
@@ -24,7 +24,7 @@ import java.util.zip.CRC32;
import io.netty.channel.ChannelPipeline;
import net.jpountz.lz4.LZ4Factory;
-import net.jpountz.lz4.LZ4FastDecompressor;
+import net.jpountz.lz4.LZ4SafeDecompressor;
import static
[jira] [Commented] (CASSANDRA-15262) server_encryption_options is not backwards compatible with 3.11
[
https://issues.apache.org/jira/browse/CASSANDRA-15262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17096639#comment-17096639
]
Ekaterina Dimitrova commented on CASSANDRA-15262:
-
I found CASSANDRA-15146 which is supposed to remove *enabled* completely in
beta. Is it worth it to keep on digging on this issue then, considering this is
the last alpha ticket?
> server_encryption_options is not backwards compatible with 3.11
> ---
>
> Key: CASSANDRA-15262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15262
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
>Reporter: Joey Lynch
>Assignee: Joey Lynch
>Priority: Normal
> Fix For: 4.0, 4.0-alpha
>
>
> The current `server_encryption_options` configuration options are as follows:
> {noformat}
> server_encryption_options:
> # set to true for allowing secure incoming connections
> enabled: false
> # If enabled and optional are both set to true, encrypted and unencrypted
> connections are handled on the storage_port
> optional: false
> # if enabled, will open up an encrypted listening socket on
> ssl_storage_port. Should be used
> # during upgrade to 4.0; otherwise, set to false.
> enable_legacy_ssl_storage_port: false
> # on outbound connections, determine which type of peers to securely
> connect to. 'enabled' must be set to true.
> internode_encryption: none
> keystore: conf/.keystore
> keystore_password: cassandra
> truststore: conf/.truststore
> truststore_password: cassandra
> # More advanced defaults below:
> # protocol: TLS
> # store_type: JKS
> # cipher_suites:
> [TLS_RSA_WITH_AES_128_CBC_SHA,TLS_RSA_WITH_AES_256_CBC_SHA,TLS_DHE_RSA_WITH_AES_128_CBC_SHA,TLS_DHE_RSA_WITH_AES_256_CBC_SHA,TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA,TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA]
> # require_client_auth: false
> # require_endpoint_verification: false
> {noformat}
> A couple of issues here:
> 1. optional defaults to false, which will break existing TLS configurations
> for (from what I can tell) no particularly good reason
> 2. The provided protocol and cipher suites are not good ideas (in particular
> encouraging anyone to use CBC ciphers is a bad plan
> I propose that before the 4.0 cut we fixup server_encryption_options and even
> client_encryption_options :
> # Change the default {{optional}} setting to true. As the new Netty code
> intelligently decides to open a TLS connection or not this is the more
> sensible default (saves operators a step while transitioning to TLS as well)
> # Update the defaults to what netty actually defaults to
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-15777) All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
[
https://issues.apache.org/jira/browse/CASSANDRA-15777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova reassigned CASSANDRA-15777:
---
Assignee: Ekaterina Dimitrova (was: Michael Semb Wever)
> All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
>
>
> Key: CASSANDRA-15777
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15777
> Project: Cassandra
> Issue Type: Bug
> Components: Build, Test/unit
>Reporter: Michael Semb Wever
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-alpha
>
>
> Make all test targets declare the temp directory (java.io.tmpdir) as defined
> by tmp.dir
> This was originally done in CASSANDRA-7712 but has been eroded over time as
> the test targets evolved.
> The attached patch moves the
> {code}{code}
> into the {{testmacrohelper}} macrodef.
> Like CASSANDRA-7712, jenkins agents are filling up their root volumes because
> of what's left behind under {{"/tmp"}}
> The build scripts have already been configured to define the temp directory
> to be within the jenkins job's workspace:
> https://github.com/apache/cassandra-builds/commit/33ba1e30ea196180f7d70f8e6ec47fdf6844f3f6#diff-91876f5f158ec50dab9a70cc06c06922
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14781) Log message when mutation passed to CommitLog#add(Mutation) is too large is not descriptive enough
[
https://issues.apache.org/jira/browse/CASSANDRA-14781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17096595#comment-17096595
]
Jordan West commented on CASSANDRA-14781:
-
Hi [~n.v.harikrishna]. I've picked this back up and am getting it ready to
commit. Thanks for your patience.
I've squashed your branch here:
[https://github.com/jrwest/cassandra/commits/14781-trunk.] I made a few minor
changes along the way (I also re-reviewed since it had been a little bit since
I had read the patch):
* Modified {{CHANGES.txt}}
* Modified {{IMutation#validateSize}} javadoc
* Moved call to {{Keyspace.open}} into the catch block of
{{BlockingReadRepairs#createRepairMutation}}. It was only used if we reached
that block anyways.
* Fixed whitespace formatting in
{{MutationExceededMaxSizeException#prepareMessage}}
I ran a build prior to these changes. The build looked good (better than trunk
actually) and any failures do not seem related:
[https://app.circleci.com/pipelines/github/jrwest/cassandra/4/workflows/e43918eb-40d2-45ad-80c3-dbeaa5ee186b]
I've kicked off a new build with the changes above and with the squash
performed:
[https://app.circleci.com/pipelines/github/jrwest/cassandra/6/workflows/3c3f674e-db89-488a-bbd5-98f04de4fd0d]
> Log message when mutation passed to CommitLog#add(Mutation) is too large is
> not descriptive enough
> --
>
> Key: CASSANDRA-14781
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14781
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Hints, Local/Commit Log, Messaging/Client
>Reporter: Jordan West
>Assignee: Venkata Harikrishna Nukala
>Priority: Normal
> Labels: protocolv5
> Fix For: 4.0-beta
>
> Attachments: CASSANDRA-14781.patch, CASSANDRA-14781_3.0.patch,
> CASSANDRA-14781_3.11.patch
>
>
> When hitting
> [https://github.com/apache/cassandra/blob/cassandra-3.0/src/java/org/apache/cassandra/db/commitlog/CommitLog.java#L256-L257],
> the log message produced does not help the operator track down what data is
> being written. At a minimum the keyspace and cfIds involved would be useful
> (and are available) – more detail might not be reasonable to include.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15777) All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
[
https://issues.apache.org/jira/browse/CASSANDRA-15777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-15777:
Reviewers: Berenguer Blasi, Ekaterina Dimitrova (was: Ekaterina Dimitrova)
> All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
>
>
> Key: CASSANDRA-15777
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15777
> Project: Cassandra
> Issue Type: Bug
> Components: Build, Test/unit
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-alpha
>
>
> Make all test targets declare the temp directory (java.io.tmpdir) as defined
> by tmp.dir
> This was originally done in CASSANDRA-7712 but has been eroded over time as
> the test targets evolved.
> The attached patch moves the
> {code}{code}
> into the {{testmacrohelper}} macrodef.
> Like CASSANDRA-7712, jenkins agents are filling up their root volumes because
> of what's left behind under {{"/tmp"}}
> The build scripts have already been configured to define the temp directory
> to be within the jenkins job's workspace:
> https://github.com/apache/cassandra-builds/commit/33ba1e30ea196180f7d70f8e6ec47fdf6844f3f6#diff-91876f5f158ec50dab9a70cc06c06922
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15777) All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
[
https://issues.apache.org/jira/browse/CASSANDRA-15777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17096573#comment-17096573
]
Ekaterina Dimitrova commented on CASSANDRA-15777:
-
LGTM, trunk circleci tests and Jenkins tests still running but if they don't
indicate anything (which I doubt will be the case) +1 from me. Thanks
> All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
>
>
> Key: CASSANDRA-15777
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15777
> Project: Cassandra
> Issue Type: Bug
> Components: Build, Test/unit
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-alpha
>
>
> Make all test targets declare the temp directory (java.io.tmpdir) as defined
> by tmp.dir
> This was originally done in CASSANDRA-7712 but has been eroded over time as
> the test targets evolved.
> The attached patch moves the
> {code}{code}
> into the {{testmacrohelper}} macrodef.
> Like CASSANDRA-7712, jenkins agents are filling up their root volumes because
> of what's left behind under {{"/tmp"}}
> The build scripts have already been configured to define the temp directory
> to be within the jenkins job's workspace:
> https://github.com/apache/cassandra-builds/commit/33ba1e30ea196180f7d70f8e6ec47fdf6844f3f6#diff-91876f5f158ec50dab9a70cc06c06922
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15777) All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
[
https://issues.apache.org/jira/browse/CASSANDRA-15777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-15777:
Reviewers: Ekaterina Dimitrova, Ekaterina Dimitrova (was: Ekaterina
Dimitrova)
Ekaterina Dimitrova, Ekaterina Dimitrova (was: Ekaterina
Dimitrova)
Status: Review In Progress (was: Patch Available)
> All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
>
>
> Key: CASSANDRA-15777
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15777
> Project: Cassandra
> Issue Type: Bug
> Components: Build, Test/unit
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-alpha
>
>
> Make all test targets declare the temp directory (java.io.tmpdir) as defined
> by tmp.dir
> This was originally done in CASSANDRA-7712 but has been eroded over time as
> the test targets evolved.
> The attached patch moves the
> {code}{code}
> into the {{testmacrohelper}} macrodef.
> Like CASSANDRA-7712, jenkins agents are filling up their root volumes because
> of what's left behind under {{"/tmp"}}
> The build scripts have already been configured to define the temp directory
> to be within the jenkins job's workspace:
> https://github.com/apache/cassandra-builds/commit/33ba1e30ea196180f7d70f8e6ec47fdf6844f3f6#diff-91876f5f158ec50dab9a70cc06c06922
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15777) All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
[
https://issues.apache.org/jira/browse/CASSANDRA-15777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-15777:
Reviewers: Ekaterina Dimitrova
> All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
>
>
> Key: CASSANDRA-15777
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15777
> Project: Cassandra
> Issue Type: Bug
> Components: Build, Test/unit
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-alpha
>
>
> Make all test targets declare the temp directory (java.io.tmpdir) as defined
> by tmp.dir
> This was originally done in CASSANDRA-7712 but has been eroded over time as
> the test targets evolved.
> The attached patch moves the
> {code}{code}
> into the {{testmacrohelper}} macrodef.
> Like CASSANDRA-7712, jenkins agents are filling up their root volumes because
> of what's left behind under {{"/tmp"}}
> The build scripts have already been configured to define the temp directory
> to be within the jenkins job's workspace:
> https://github.com/apache/cassandra-builds/commit/33ba1e30ea196180f7d70f8e6ec47fdf6844f3f6#diff-91876f5f158ec50dab9a70cc06c06922
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15777) All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
[
https://issues.apache.org/jira/browse/CASSANDRA-15777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17096565#comment-17096565
]
Michael Semb Wever edited comment on CASSANDRA-15777 at 4/30/20, 2:07 PM:
--
[~Bereng], if by "having TPMDIR variable just like the other scripts" you mean
[this|https://github.com/apache/cassandra-builds/blob/master/build-scripts/cassandra-dtest-pytest.sh#L23],
then that's for python processes. Anything java needs the
{{-Djava.io.tmpdir=…}} argument (which can be specified as as {{-Dtmp.dir=…}}
in our ant build script).
was (Author: michaelsembwever):
[~Bereng], if by "having TPMDIR variable just like the other scripts" you mean
[this|https://github.com/apache/cassandra-builds/blob/master/build-scripts/cassandra-dtest-pytest.sh#L23],
then that's for python processes. Anything java needs the
{{-Djava.io.tmpdir=…}} argument.
> All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
>
>
> Key: CASSANDRA-15777
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15777
> Project: Cassandra
> Issue Type: Bug
> Components: Build, Test/unit
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-alpha
>
>
> Make all test targets declare the temp directory (java.io.tmpdir) as defined
> by tmp.dir
> This was originally done in CASSANDRA-7712 but has been eroded over time as
> the test targets evolved.
> The attached patch moves the
> {code}{code}
> into the {{testmacrohelper}} macrodef.
> Like CASSANDRA-7712, jenkins agents are filling up their root volumes because
> of what's left behind under {{"/tmp"}}
> The build scripts have already been configured to define the temp directory
> to be within the jenkins job's workspace:
> https://github.com/apache/cassandra-builds/commit/33ba1e30ea196180f7d70f8e6ec47fdf6844f3f6#diff-91876f5f158ec50dab9a70cc06c06922
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15777) All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
[
https://issues.apache.org/jira/browse/CASSANDRA-15777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17096565#comment-17096565
]
Michael Semb Wever commented on CASSANDRA-15777:
[~Bereng], if by "having TPMDIR variable just like the other scripts" you mean
[this|https://github.com/apache/cassandra-builds/blob/master/build-scripts/cassandra-dtest-pytest.sh#L23],
then that's for python processes. Anything java needs the
{{-Djava.io.tmpdir=…}} argument.
> All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
>
>
> Key: CASSANDRA-15777
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15777
> Project: Cassandra
> Issue Type: Bug
> Components: Build, Test/unit
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-alpha
>
>
> Make all test targets declare the temp directory (java.io.tmpdir) as defined
> by tmp.dir
> This was originally done in CASSANDRA-7712 but has been eroded over time as
> the test targets evolved.
> The attached patch moves the
> {code}{code}
> into the {{testmacrohelper}} macrodef.
> Like CASSANDRA-7712, jenkins agents are filling up their root volumes because
> of what's left behind under {{"/tmp"}}
> The build scripts have already been configured to define the temp directory
> to be within the jenkins job's workspace:
> https://github.com/apache/cassandra-builds/commit/33ba1e30ea196180f7d70f8e6ec47fdf6844f3f6#diff-91876f5f158ec50dab9a70cc06c06922
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15777) All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
[
https://issues.apache.org/jira/browse/CASSANDRA-15777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17096521#comment-17096521
]
Berenguer Blasi commented on CASSANDRA-15777:
-
I did take a cursory look at the changes and I am only wondering if
cassandra-test.sh could benefit from having {{TPMDIR}} variable just like the
other scripts, instead of having it hardcoded?
> All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
>
>
> Key: CASSANDRA-15777
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15777
> Project: Cassandra
> Issue Type: Bug
> Components: Build, Test/unit
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-alpha
>
>
> Make all test targets declare the temp directory (java.io.tmpdir) as defined
> by tmp.dir
> This was originally done in CASSANDRA-7712 but has been eroded over time as
> the test targets evolved.
> The attached patch moves the
> {code}{code}
> into the {{testmacrohelper}} macrodef.
> Like CASSANDRA-7712, jenkins agents are filling up their root volumes because
> of what's left behind under {{"/tmp"}}
> The build scripts have already been configured to define the temp directory
> to be within the jenkins job's workspace:
> https://github.com/apache/cassandra-builds/commit/33ba1e30ea196180f7d70f8e6ec47fdf6844f3f6#diff-91876f5f158ec50dab9a70cc06c06922
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15777) All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
[
https://issues.apache.org/jira/browse/CASSANDRA-15777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Semb Wever updated CASSANDRA-15777:
---
Test and Documentation Plan: ASF CI
Status: Patch Available (was: Open)
> All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
>
>
> Key: CASSANDRA-15777
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15777
> Project: Cassandra
> Issue Type: Bug
> Components: Build, Test/unit
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-alpha
>
>
> Make all test targets declare the temp directory (java.io.tmpdir) as defined
> by tmp.dir
> This was originally done in CASSANDRA-7712 but has been eroded over time as
> the test targets evolved.
> The attached patch moves the
> {code}{code}
> into the {{testmacrohelper}} macrodef.
> Like CASSANDRA-7712, jenkins agents are filling up their root volumes because
> of what's left behind under {{"/tmp"}}
> The build scripts have already been configured to define the temp directory
> to be within the jenkins job's workspace:
> https://github.com/apache/cassandra-builds/commit/33ba1e30ea196180f7d70f8e6ec47fdf6844f3f6#diff-91876f5f158ec50dab9a70cc06c06922
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15777) All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
[
https://issues.apache.org/jira/browse/CASSANDRA-15777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17096459#comment-17096459
]
Michael Semb Wever commented on CASSANDRA-15777:
||branch||circleci||jenkins||
|[cassandra_2.2_15777|https://github.com/apache/cassandra/compare/cassandra-2.2...thelastpickle:mck/cassandra-2.2_15777]|[circleci|https://circleci.com/gh/thelastpickle/workflows/cassandra/tree/mck%2Fcassandra-2.2_15777]|[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/77/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/77]|
|[cassandra_3.0_15777|https://github.com/apache/cassandra/compare/cassandra-3.0...thelastpickle:mck/cassandra-3.0_15777]|[circleci|https://circleci.com/gh/thelastpickle/workflows/cassandra/tree/mck%2Fcassandra-3.0_15777]|[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/78/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/78]|
|[cassandra_3.11_15777|https://github.com/apache/cassandra/compare/cassandra-3.11...thelastpickle:mck/cassandra-3.11_15777]|[circleci|https://circleci.com/gh/thelastpickle/workflows/cassandra/tree/mck%2Fcassandra-3.11_15777]|[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/79/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/79]|
|[trunk_15777|https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/trunk_15777]|[circleci|https://circleci.com/gh/thelastpickle/workflows/cassandra/tree/mck%2Ftrunk_15777]|[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/80/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/80]|
> All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
>
>
> Key: CASSANDRA-15777
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15777
> Project: Cassandra
> Issue Type: Bug
> Components: Build, Test/unit
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-alpha
>
>
> Make all test targets declare the temp directory (java.io.tmpdir) as defined
> by tmp.dir
> This was originally done in CASSANDRA-7712 but has been eroded over time as
> the test targets evolved.
> The attached patch moves the
> {code}{code}
> into the {{testmacrohelper}} macrodef.
> Like CASSANDRA-7712, jenkins agents are filling up their root volumes because
> of what's left behind under {{"/tmp"}}
> The build scripts have already been configured to define the temp directory
> to be within the jenkins job's workspace:
> https://github.com/apache/cassandra-builds/commit/33ba1e30ea196180f7d70f8e6ec47fdf6844f3f6#diff-91876f5f158ec50dab9a70cc06c06922
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15777) All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
[
https://issues.apache.org/jira/browse/CASSANDRA-15777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Semb Wever updated CASSANDRA-15777:
---
Fix Version/s: 3.11.x
3.0.x
2.2.x
> All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
>
>
> Key: CASSANDRA-15777
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15777
> Project: Cassandra
> Issue Type: Bug
> Components: Build, Test/unit
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-alpha
>
>
> Make all test targets declare the temp directory (java.io.tmpdir) as defined
> by tmp.dir
> This was originally done in CASSANDRA-7712 but has been eroded over time as
> the test targets evolved.
> The attached patch moves the
> {code}{code}
> into the {{testmacrohelper}} macrodef.
> Like CASSANDRA-7712, jenkins agents are filling up their root volumes because
> of what's left behind under {{"/tmp"}}
> The build scripts have already been configured to define the temp directory
> to be within the jenkins job's workspace:
> https://github.com/apache/cassandra-builds/commit/33ba1e30ea196180f7d70f8e6ec47fdf6844f3f6#diff-91876f5f158ec50dab9a70cc06c06922
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15777) All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
[
https://issues.apache.org/jira/browse/CASSANDRA-15777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Semb Wever updated CASSANDRA-15777:
---
Bug Category: Parent values: Degradation(12984)Level 1 values: Resource
Management(12995)
Complexity: Low Hanging Fruit
Discovered By: Unit Test
Fix Version/s: 4.0-alpha
Severity: Normal
Status: Open (was: Triage Needed)
> All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
>
>
> Key: CASSANDRA-15777
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15777
> Project: Cassandra
> Issue Type: Bug
> Components: Build, Test/unit
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 4.0-alpha
>
>
> Make all test targets declare the temp directory (java.io.tmpdir) as defined
> by tmp.dir
> This was originally done in CASSANDRA-7712 but has been eroded over time as
> the test targets evolved.
> The attached patch moves the
> {code}{code}
> into the {{testmacrohelper}} macrodef.
> Like CASSANDRA-7712, jenkins agents are filling up their root volumes because
> of what's left behind under {{"/tmp"}}
> The build scripts have already been configured to define the temp directory
> to be within the jenkins job's workspace:
> https://github.com/apache/cassandra-builds/commit/33ba1e30ea196180f7d70f8e6ec47fdf6844f3f6#diff-91876f5f158ec50dab9a70cc06c06922
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-15777) All test targets to set jvm arg "java.io.tmpdir" according to ${tmp.dir}
Michael Semb Wever created CASSANDRA-15777:
--
Summary: All test targets to set jvm arg "java.io.tmpdir"
according to ${tmp.dir}
Key: CASSANDRA-15777
URL: https://issues.apache.org/jira/browse/CASSANDRA-15777
Project: Cassandra
Issue Type: Bug
Components: Build, Test/unit
Reporter: Michael Semb Wever
Assignee: Michael Semb Wever
Make all test targets declare the temp directory (java.io.tmpdir) as defined by
tmp.dir
This was originally done in CASSANDRA-7712 but has been eroded over time as the
test targets evolved.
The attached patch moves the
{code}{code}
into the {{testmacrohelper}} macrodef.
Like CASSANDRA-7712, jenkins agents are filling up their root volumes because
of what's left behind under {{"/tmp"}}
The build scripts have already been configured to define the temp directory to
be within the jenkins job's workspace:
https://github.com/apache/cassandra-builds/commit/33ba1e30ea196180f7d70f8e6ec47fdf6844f3f6#diff-91876f5f158ec50dab9a70cc06c06922
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15560) Change io.compressor.LZ4Compressor to LZ4SafeDecompressor
[ https://issues.apache.org/jira/browse/CASSANDRA-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-15560: Status: Review In Progress (was: Changes Suggested) > Change io.compressor.LZ4Compressor to LZ4SafeDecompressor > - > > Key: CASSANDRA-15560 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15560 > Project: Cassandra > Issue Type: Improvement > Components: Feature/Compression >Reporter: Jordan West >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0, 4.0-rc > > Time Spent: 0.5h > Remaining Estimate: 0h > > CASSANDRA-15556 and related tickets showed that LZ4FastDecompressor can crash > the JVM and that LZ4SafeDecompressor performs better w/o the crash risk — its > also not deprecated. While we protect ourselves by checksumming the > compressed data but that doesn’t mean we should leave deprecated code that > can segfault the jvm (providing a potential DDOS vector among other things) > in crucial places like io.compress. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15729) Jenkins Test Results Report in plaintext for ASF ML
[ https://issues.apache.org/jira/browse/CASSANDRA-15729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095846#comment-17095846 ] Michael Semb Wever edited comment on CASSANDRA-15729 at 4/30/20, 9:17 AM: -- Example cqlshlib test reports: - https://ci-cassandra.apache.org/job/Cassandra-3.0-cqlsh-tests/19/testReport/ - https://ci-cassandra.apache.org/job/Cassandra-3.11-cqlsh-tests/22/testReport/ - https://ci-cassandra.apache.org/job/Cassandra-trunk-cqlsh-tests/102/testReport/ was (Author: michaelsembwever): Example cqlshlib test reports: - https://ci-cassandra.apache.org/job/Cassandra-3.0-cqlsh-tests/19/testReport/ - https://ci-cassandra.apache.org/job/Cassandra-3.11-cqlsh-tests/22/testReport/ - https://ci-cassandra.apache.org/job/Cassandra-trunk-cqlsh-tests/101/testReport/ > Jenkins Test Results Report in plaintext for ASF ML > --- > > Key: CASSANDRA-15729 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15729 > Project: Cassandra > Issue Type: Task > Components: Build, CI >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Labels: Jenkins > Fix For: 4.0-beta > > > The Jenkins pipeline builds now aggregate all test reports. > For example: > - https://ci-cassandra.apache.org/job/Cassandra-trunk/68/testReport/ > - > https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-trunk/detail/Cassandra-trunk/68/tests > But Jenkins can only keep a limited amount of build history, so those links > are not permanent, can't be used as references, and don't help for bisecting > and blame on regressions (and flakey tests) over a longer period of time. > The builds@ ML can provide a permanent record of test results. > This was first brought up in these two threads: > - > https://lists.apache.org/thread.html/re8122e4fdd8629e7fbca2abf27d72054b3bc0e3690ece8b8e66f618b%40%3Cdev.cassandra.apache.org%3E > - > https://lists.apache.org/thread.html/ra5f6aeea89546825fe7ccc4a80898c62f8ed57decabf709d81d9c720%40%3Cdev.cassandra.apache.org%3E > An example plaintext report, to demonstrate feasibility, is available here: > https://lists.apache.org/thread.html/r80d13f7af706bf8dfbf2387fab46004c1fbd3917b7bc339c49e69aa8%40%3Cbuilds.cassandra.apache.org%3E > Hurdles: > - the ASF mailing lists won't accept html, attachments, or any message body > over 1MB. > - packages are used as a differentiator in the final aggregated report. The > cqlsh and dtests currently don't specify it. It needs to be added as a > "dot-separated" prefix to the testsuite and testcase name. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15729) Jenkins Test Results Report in plaintext for ASF ML
[
https://issues.apache.org/jira/browse/CASSANDRA-15729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17096328#comment-17096328
]
Michael Semb Wever commented on CASSANDRA-15729:
I've committed a chunk of the
[casssandra-builds|https://github.com/apache/cassandra-builds/commit/41c7b9402669f733a5b80118689a981396f47c11]
work here.
This is preliminary to validate and help test moving forward.
Remaining work is to
- dockerise the {{cassandra-test-report.sh}} script (cassandra-builds)
- update the in-tree jenkins files (cassandra)
> Jenkins Test Results Report in plaintext for ASF ML
> ---
>
> Key: CASSANDRA-15729
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15729
> Project: Cassandra
> Issue Type: Task
> Components: Build, CI
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Labels: Jenkins
> Fix For: 4.0-beta
>
>
> The Jenkins pipeline builds now aggregate all test reports.
> For example:
> - https://ci-cassandra.apache.org/job/Cassandra-trunk/68/testReport/
> -
> https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-trunk/detail/Cassandra-trunk/68/tests
> But Jenkins can only keep a limited amount of build history, so those links
> are not permanent, can't be used as references, and don't help for bisecting
> and blame on regressions (and flakey tests) over a longer period of time.
> The builds@ ML can provide a permanent record of test results.
> This was first brought up in these two threads:
> -
> https://lists.apache.org/thread.html/re8122e4fdd8629e7fbca2abf27d72054b3bc0e3690ece8b8e66f618b%40%3Cdev.cassandra.apache.org%3E
> -
> https://lists.apache.org/thread.html/ra5f6aeea89546825fe7ccc4a80898c62f8ed57decabf709d81d9c720%40%3Cdev.cassandra.apache.org%3E
> An example plaintext report, to demonstrate feasibility, is available here:
> https://lists.apache.org/thread.html/r80d13f7af706bf8dfbf2387fab46004c1fbd3917b7bc339c49e69aa8%40%3Cbuilds.cassandra.apache.org%3E
> Hurdles:
> - the ASF mailing lists won't accept html, attachments, or any message body
> over 1MB.
> - packages are used as a differentiator in the final aggregated report. The
> cqlsh and dtests currently don't specify it. It needs to be added as a
> "dot-separated" prefix to the testsuite and testcase name.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-builds] branch master updated (0bdc460 -> ff12f29)
This is an automated email from the ASF dual-hosted git repository. mck pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cassandra-builds.git. from 0bdc460 Source and build artifacts are published with sha512 checksums new 41c7b94 Jenkins improvements for CASSANDRA-15729 - aggregate test reports from the pipeline into one TESTS-TestSuites.xml - remove jenkins owned tmp files older than two days - remove cassandra-dtest.sh, only cassandra-dtest-pytest.sh is used - dtest-large is to use the new `--only-resource-intensive-tests` flag (as it does not need to re-run non-large dtests) new ff12f29 In jenkins builds add the 'Add timestamps to the Console Output' option to each job, for INFRA-20107 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: build-scripts/cassandra-dtest-pytest.sh | 8 +- build-scripts/cassandra-dtest.sh | 79 build-scripts/cassandra-test-report.sh| 26 +++ build-scripts/cassandra-test-report.xml | 9 + build-scripts/cassandra-test-report.xsl | 325 ++ jenkins-dsl/cassandra_job_dsl_seed.groovy | 22 +- jenkins-dsl/cassandra_pipeline.groovy | 4 +- 7 files changed, 382 insertions(+), 91 deletions(-) delete mode 100755 build-scripts/cassandra-dtest.sh create mode 100644 build-scripts/cassandra-test-report.sh create mode 100644 build-scripts/cassandra-test-report.xml create mode 100644 build-scripts/cassandra-test-report.xsl - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-builds] 01/02: Jenkins improvements for CASSANDRA-15729 - aggregate test reports from the pipeline into one TESTS-TestSuites.xml - remove jenkins owned tmp files older than two days - remov
This is an automated email from the ASF dual-hosted git repository.
mck pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cassandra-builds.git
commit 41c7b9402669f733a5b80118689a981396f47c11
Author: mck
AuthorDate: Mon Apr 13 23:14:14 2020 +0200
Jenkins improvements for CASSANDRA-15729
- aggregate test reports from the pipeline into one TESTS-TestSuites.xml
- remove jenkins owned tmp files older than two days
- remove cassandra-dtest.sh, only cassandra-dtest-pytest.sh is used
- dtest-large is to use the new `--only-resource-intensive-tests` flag (as
it does not need to re-run non-large dtests)
---
build-scripts/cassandra-dtest-pytest.sh | 8 +-
build-scripts/cassandra-dtest.sh | 79
build-scripts/cassandra-test-report.sh| 26 +++
build-scripts/cassandra-test-report.xml | 9 +
build-scripts/cassandra-test-report.xsl | 325 ++
jenkins-dsl/cassandra_job_dsl_seed.groovy | 14 +-
jenkins-dsl/cassandra_pipeline.groovy | 4 +-
7 files changed, 374 insertions(+), 91 deletions(-)
diff --git a/build-scripts/cassandra-dtest-pytest.sh
b/build-scripts/cassandra-dtest-pytest.sh
index 271c8f6..c70ed5a 100755
--- a/build-scripts/cassandra-dtest-pytest.sh
+++ b/build-scripts/cassandra-dtest-pytest.sh
@@ -66,13 +66,13 @@ rm -r upgrade_tests/ # TEMP: remove upgrade_tests - we have
no dual JDK installa
mkdir -p ${TMPDIR}
set +e # disable immediate exit from this point
if [ "${DTEST_TARGET}" = "dtest" ]; then
-pytest -vv --log-level="INFO" --use-vnodes --num-tokens=32
--junit-xml=nosetests.xml -s --cassandra-dir=$CASSANDRA_DIR
--skip-resource-intensive-tests 2>&1 | tee -a ${WORKSPACE}/test_stdout.txt
+pytest -vv --log-level="INFO" --use-vnodes --num-tokens=32
--junit-xml=nosetests.xml --junit-prefix=${DTEST_TARGET} -s
--cassandra-dir=$CASSANDRA_DIR --skip-resource-intensive-tests 2>&1 | tee -a
${WORKSPACE}/test_stdout.txt
elif [ "${DTEST_TARGET}" = "dtest-novnode" ]; then
-pytest -vv --log-level="INFO" --junit-xml=nosetests.xml -s
--cassandra-dir=$CASSANDRA_DIR --skip-resource-intensive-tests 2>&1 | tee -a
${WORKSPACE}/test_stdout.txt
+pytest -vv --log-level="INFO" --junit-xml=nosetests.xml
--junit-prefix=${DTEST_TARGET} -s --cassandra-dir=$CASSANDRA_DIR
--skip-resource-intensive-tests 2>&1 | tee -a ${WORKSPACE}/test_stdout.txt
elif [ "${DTEST_TARGET}" = "dtest-offheap" ]; then
-pytest -vv --log-level="INFO" --use-vnodes --num-tokens=32
--use-off-heap-memtables --junit-xml=nosetests.xml -s
--cassandra-dir=$CASSANDRA_DIR --skip-resource-intensive-tests 2>&1 | tee -a
${WORKSPACE}/test_stdout.txt
+pytest -vv --log-level="INFO" --use-vnodes --num-tokens=32
--use-off-heap-memtables --junit-xml=nosetests.xml
--junit-prefix=${DTEST_TARGET} -s --cassandra-dir=$CASSANDRA_DIR
--skip-resource-intensive-tests 2>&1 | tee -a ${WORKSPACE}/test_stdout.txt
elif [ "${DTEST_TARGET}" = "dtest-large" ]; then
-pytest -vv --log-level="INFO" --use-vnodes --num-tokens=32
--junit-xml=nosetests.xml -s --cassandra-dir=$CASSANDRA_DIR
--force-resource-intensive-tests 2>&1 | tee -a ${WORKSPACE}/test_stdout.txt
+pytest -vv --log-level="INFO" --use-vnodes --num-tokens=32
--junit-xml=nosetests.xml --junit-prefix=${DTEST_TARGET} -s
--cassandra-dir=$CASSANDRA_DIR --only-resource-intensive-tests 2>&1 | tee -a
${WORKSPACE}/test_stdout.txt
else
echo "Unknown dtest target: ${DTEST_TARGET}"
exit 1
diff --git a/build-scripts/cassandra-dtest.sh b/build-scripts/cassandra-dtest.sh
deleted file mode 100755
index a7a33a0..000
--- a/build-scripts/cassandra-dtest.sh
+++ /dev/null
@@ -1,79 +0,0 @@
-#!/bin/bash -x
-
-
-#
-# Prep
-#
-
-
-# Pass in target to run, default to base dtest
-DTEST_TARGET="${1:-dtest}"
-
-export PYTHONIOENCODING="utf-8"
-export PYTHONUNBUFFERED=true
-export CASS_DRIVER_NO_EXTENSIONS=true
-export CASS_DRIVER_NO_CYTHON=true
-export CCM_MAX_HEAP_SIZE="2048M"
-export CCM_HEAP_NEWSIZE="200M"
-export CCM_CONFIG_DIR=${WORKSPACE}/.ccm
-export NUM_TOKENS="32"
-export CASSANDRA_DIR=${WORKSPACE}
-export TMPDIR="./tmp"
-
-# Loop to prevent failure due to maven-ant-tasks not downloading a jar..
-for x in $(seq 1 3); do
-ant clean jar
-RETURN="$?"
-if [ "${RETURN}" -eq "0" ]; then
-break
-fi
-done
-# Exit, if we didn't build successfully
-if [ "${RETURN}" -ne "0" ]; then
-echo "Build failed with exit code: ${RETURN}"
-exit ${RETURN}
-fi
-
-# Set up venv with dtest dependencies
-set -e # enable immediate exit if venv setup fails
-virtualenv --python=python2 venv
-source venv/bin/activate
-pip install -r cassandra-dtest/requirements.txt
-pip freeze
-
-
-#
-# Main
-#
-
-
-cd cassandra-dtest/
-rm -r upgrade_tests/ # TEMP: remove upgrade_tests - we have no dual JDK
installation
-mkdir -p ${TMPDIR}
-set +e #
[cassandra-builds] 02/02: In jenkins builds add the 'Add timestamps to the Console Output' option to each job, for INFRA-20107
This is an automated email from the ASF dual-hosted git repository.
mck pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cassandra-builds.git
commit ff12f29971213d5d6d602e72db80e94fe181a2df
Author: mck
AuthorDate: Thu Apr 30 09:38:42 2020 +0200
In jenkins builds add the 'Add timestamps to the Console Output' option to
each job, for INFRA-20107
---
jenkins-dsl/cassandra_job_dsl_seed.groovy | 8
1 file changed, 8 insertions(+)
diff --git a/jenkins-dsl/cassandra_job_dsl_seed.groovy
b/jenkins-dsl/cassandra_job_dsl_seed.groovy
index 5c618e1..f862136 100644
--- a/jenkins-dsl/cassandra_job_dsl_seed.groovy
+++ b/jenkins-dsl/cassandra_job_dsl_seed.groovy
@@ -85,6 +85,7 @@ job('Cassandra-template-artifacts') {
timeout {
noActivity(300)
}
+timestamps()
}
scm {
git {
@@ -158,6 +159,7 @@ job('Cassandra-template-test') {
timeout {
noActivity(1200)
}
+timestamps()
}
throttleConcurrentBuilds {
categories(['Cassandra'])
@@ -219,6 +221,7 @@ job('Cassandra-template-dtest') {
timeout {
noActivity(1200)
}
+timestamps()
}
throttleConcurrentBuilds {
categories(['Cassandra'])
@@ -278,6 +281,7 @@ matrixJob('Cassandra-template-cqlsh-tests') {
timeout {
noActivity(1200)
}
+timestamps()
}
throttleConcurrentBuilds {
categories(['Cassandra'])
@@ -483,6 +487,7 @@ job('Cassandra-devbranch-artifacts') {
timeout {
noActivity(300)
}
+timestamps()
}
throttleConcurrentBuilds {
categories(['Cassandra'])
@@ -541,6 +546,7 @@ testTargets.each {
timeout {
noActivity(1200)
}
+timestamps()
}
throttleConcurrentBuilds {
categories(['Cassandra'])
@@ -608,6 +614,7 @@ job('Cassandra-devbranch-dtest') {
timeout {
noActivity(2400)
}
+timestamps()
}
throttleConcurrentBuilds {
categories(['Cassandra'])
@@ -676,6 +683,7 @@ matrixJob('Cassandra-devbranch-cqlsh-tests') {
timeout {
noActivity(1200)
}
+timestamps()
}
throttleConcurrentBuilds {
categories(['Cassandra'])
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15560) Change io.compressor.LZ4Compressor to LZ4SafeDecompressor
[
https://issues.apache.org/jira/browse/CASSANDRA-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17096295#comment-17096295
]
Berenguer Blasi commented on CASSANDRA-15560:
-
[~brandon.williams] thank you for reviewing this. Indeed the dtests were very
noisy and I was worried about it so any guidance is welcomed. That particular
test I ran locally and it passed before I pushed. I tested again and it passes
in my branch:
{quote}git branch
* CASSANDRA-15560-4.0
trunk
===Flaky Test Report===
test_disable_compression_cql passed 1 out of the required 1 times. Success!
test_compression_cql_options passed 1 out of the required 1 times. Success!
test_compression_cql_disabled_with_alter passed 1 out of the required 1 times.
Success!
test_compression_cql_enabled_with_alter passed 1 out of the required 1 times.
Success!
===End Flaky Test Report===
{quote}
but fails on your branch and even the commit before mine
{quote}git branch
* (HEAD detached at f0526fa368)
CASSANDRA-15560-4.0
trunk
===Flaky Test Report===
test_disable_compression_cql passed 1 out of the required 1 times. Success!
test_compression_cql_options failed and was not selected for rerun.
assert 'DEFLATE' == 'UNKNOWN'
- DEFLATE
+ UNKNOWN
[]
test_compression_cql_disabled_with_alter passed 1 out of the required 1 times.
Success!
test_compression_cql_enabled_with_alter passed 1 out of the required 1 times.
Success!{quote}
I bisected it to
[9c1bbf3ac913f9bdf7a0e0922106804af42d2c1e|https://github.com/apache/cassandra/commit/9c1bbf3ac913f9bdf7a0e0922106804af42d2c1e]
CASSANDRA-15379. The dtests in there, if I managed to make myself around
circleci correctly, don't seem to have ran the compression test.
Also I looked at your CI results and tried to match them to
[jenkins|https://ci-cassandra.apache.org/job/Cassandra-trunk-dtest-novnode/]
but the latest runs seem to have failed. I did run locally some of the failing
tests against trunck and they also failed. I _think_ we're safe to merge this
PR and open a new ticket for the compression test failure due to 15379. But my
circleci/dtests reasonable failures knowledge is very limited. Wdyt?
> Change io.compressor.LZ4Compressor to LZ4SafeDecompressor
> -
>
> Key: CASSANDRA-15560
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15560
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/Compression
>Reporter: Jordan West
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0, 4.0-rc
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> CASSANDRA-15556 and related tickets showed that LZ4FastDecompressor can crash
> the JVM and that LZ4SafeDecompressor performs better w/o the crash risk — its
> also not deprecated. While we protect ourselves by checksumming the
> compressed data but that doesn’t mean we should leave deprecated code that
> can segfault the jvm (providing a potential DDOS vector among other things)
> in crucial places like io.compress.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15533) Don't allocate unneeded MergeIterator in OnDiskToken#iterator
[ https://issues.apache.org/jira/browse/CASSANDRA-15533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17096165#comment-17096165 ] Berenguer Blasi commented on CASSANDRA-15533: - +1 to shipping it in 4.0 imho. > Don't allocate unneeded MergeIterator in OnDiskToken#iterator > -- > > Key: CASSANDRA-15533 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15533 > Project: Cassandra > Issue Type: Improvement > Components: Feature/SASI >Reporter: Jordan West >Assignee: Jordan West >Priority: Normal > Fix For: 4.0, 4.0-rc > > > When reviewing CASSANDRA-15392 it became apparent that the MergeIterator > allocated by OnDiskToken#iterator is rarely necessary and so we should avoid > allocating one when not needed and skip the MergeIterator pool when needed > because its unlikely to be sized correctly. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
