[jira] [Comment Edited] (CASSANDRA-16205) Offline token allocation strategy generator tool
[
https://issues.apache.org/jira/browse/CASSANDRA-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239419#comment-17239419
]
Michael Semb Wever edited comment on CASSANDRA-16205 at 11/27/20, 7:50 AM:
---
Further additions and reviews
[here|https://github.com/apache/cassandra/commit/2a771c3bca21194feea2e9cc70e321f3a9ead5fa#r44574475].
was (Author: michaelsembwever):
Further additions and reviews
[here|https://github.com/apache/cassandra/commit/2a771c3bca21194feea2e9cc70e321f3a9ead5fa#commitcomment-44574475].
> Offline token allocation strategy generator tool
>
>
> Key: CASSANDRA-16205
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16205
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config, Local/Scripts
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
>
> A command line tool to generate tokens (using the
> allocate_tokens_for_local_replication_factor algorithm) for pre-configuration
> of {{initial_tokens}} in cassandra.yaml.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16304) Consider implementing ClusteringComparator without a lambda
Adrian Cole created CASSANDRA-16304:
---
Summary: Consider implementing ClusteringComparator without a
lambda
Key: CASSANDRA-16304
URL: https://issues.apache.org/jira/browse/CASSANDRA-16304
Project: Cassandra
Issue Type: Improvement
Reporter: Adrian Cole
Using lambdas forces jamm to do things that can easily break. It might be safer
to implement things like ClusteringComparator directly as classes or as an enum
{noformat}
Unexpected exception during request
(org.apache.cassandra.transport.messages.ErrorMessage)
java.lang.UnsupportedOperationException: can't get field offset on a hidden
class: private final org.apache.cassandra.db.ClusteringComparator
org.apache.cassandra.db.ClusteringComparator$$Lambda$165/0x00010028ab60.arg$1
at jdk.unsupported/sun.misc.Unsafe.objectFieldOffset(Unknown Source)
at
org.github.jamm.MemoryLayoutSpecification.sizeOfInstanceWithUnsafe(MemoryLayoutSpecification.java:108)
at
org.github.jamm.MemoryLayoutSpecification.sizeOfWithUnsafe(MemoryLayoutSpecification.java:89)
at org.github.jamm.MemoryMeter.measure(MemoryMeter.java:217)
at org.github.jamm.MemoryMeter.measureDeep(MemoryMeter.java:259)
at
org.apache.cassandra.utils.ObjectSizes.measureDeep(ObjectSizes.java:155)
at
org.apache.cassandra.cql3.QueryProcessor.storePreparedStatement(QueryProcessor.java:454)
at
org.apache.cassandra.cql3.QueryProcessor.prepare(QueryProcessor.java:424)
at
org.apache.cassandra.cql3.QueryProcessor.prepare(QueryProcessor.java:408)
at
org.apache.cassandra.transport.messages.PrepareMessage.execute(PrepareMessage.java:114)
at
org.apache.cassandra.transport.Message$Request.execute(Message.java:253)
at
org.apache.cassandra.transport.Message$Dispatcher.processRequest(Message.java:725)
at
org.apache.cassandra.transport.Message$Dispatcher.lambda$channelRead0$0(Message.java:630)
at
java.base/java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
at
org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$FutureTask.run(AbstractLocalAwareExecutorService.java:162)
at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:119)
at
io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.base/java.lang.Thread.run(Unknown Source)
{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16303) ClassNotFoundException: com.googlecode.concurrenttrees.radix.node.NodeFactory
Adrian Cole created CASSANDRA-16303: --- Summary: ClassNotFoundException: com.googlecode.concurrenttrees.radix.node.NodeFactory Key: CASSANDRA-16303 URL: https://issues.apache.org/jira/browse/CASSANDRA-16303 Project: Cassandra Issue Type: Bug Components: Dependencies Reporter: Adrian Cole If you look at the pom for cassandra-all 4.0.0-beta-3, you'll notice that concurrent-trees is in dependencyManagement, but not dependencies. This might be going unnoticed as sasi is disabled by default now, but it can lead to a ClassNotFoundException. I presume this was accidental -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16205) Offline token allocation strategy generator tool
[
https://issues.apache.org/jira/browse/CASSANDRA-16205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239419#comment-17239419
]
Michael Semb Wever commented on CASSANDRA-16205:
Further additions and reviews
[here|https://github.com/apache/cassandra/commit/2a771c3bca21194feea2e9cc70e321f3a9ead5fa#commitcomment-44574475].
> Offline token allocation strategy generator tool
>
>
> Key: CASSANDRA-16205
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16205
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config, Local/Scripts
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
>
> A command line tool to generate tokens (using the
> allocate_tokens_for_local_replication_factor algorithm) for pre-configuration
> of {{initial_tokens}} in cassandra.yaml.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15299) CASSANDRA-13304 follow-up: improve checksumming and compression in protocol v5-beta
[
https://issues.apache.org/jira/browse/CASSANDRA-15299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239313#comment-17239313
]
Alex Petrov commented on CASSANDRA-15299:
-
[~beobal] I've reviewed the latest changes (renaming and addressing comments)
and the patch looks good to me with a single discardable comment in the patch
(disambiguate Compressor/Decompressor class names), please feel free to ignore
it. +1, LGTM and thank you for the patch!
> CASSANDRA-13304 follow-up: improve checksumming and compression in protocol
> v5-beta
> ---
>
> Key: CASSANDRA-15299
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15299
> Project: Cassandra
> Issue Type: Improvement
> Components: Messaging/Client
>Reporter: Aleksey Yeschenko
>Assignee: Sam Tunnicliffe
>Priority: Normal
> Labels: protocolv5
> Fix For: 4.0-alpha
>
> Attachments: Process CQL Frame.png, V5 Flow Chart.png
>
>
> CASSANDRA-13304 made an important improvement to our native protocol: it
> introduced checksumming/CRC32 to request and response bodies. It’s an
> important step forward, but it doesn’t cover the entire stream. In
> particular, the message header is not covered by a checksum or a crc, which
> poses a correctness issue if, for example, {{streamId}} gets corrupted.
> Additionally, we aren’t quite using CRC32 correctly, in two ways:
> 1. We are calculating the CRC32 of the *decompressed* value instead of
> computing the CRC32 on the bytes written on the wire - losing the properties
> of the CRC32. In some cases, due to this sequencing, attempting to decompress
> a corrupt stream can cause a segfault by LZ4.
> 2. When using CRC32, the CRC32 value is written in the incorrect byte order,
> also losing some of the protections.
> See https://users.ece.cmu.edu/~koopman/pubs/KoopmanCRCWebinar9May2012.pdf for
> explanation for the two points above.
> Separately, there are some long-standing issues with the protocol - since
> *way* before CASSANDRA-13304. Importantly, both checksumming and compression
> operate on individual message bodies rather than frames of multiple complete
> messages. In reality, this has several important additional downsides. To
> name a couple:
> # For compression, we are getting poor compression ratios for smaller
> messages - when operating on tiny sequences of bytes. In reality, for most
> small requests and responses we are discarding the compressed value as it’d
> be smaller than the uncompressed one - incurring both redundant allocations
> and compressions.
> # For checksumming and CRC32 we pay a high overhead price for small messages.
> 4 bytes extra is *a lot* for an empty write response, for example.
> To address the correctness issue of {{streamId}} not being covered by the
> checksum/CRC32 and the inefficiency in compression and checksumming/CRC32, we
> should switch to a framing protocol with multiple messages in a single frame.
> I suggest we reuse the framing protocol recently implemented for internode
> messaging in CASSANDRA-15066 to the extent that its logic can be borrowed,
> and that we do it before native protocol v5 graduates from beta. See
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/net/FrameDecoderCrc.java
> and
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/net/FrameDecoderLZ4.java.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14793) Improve system table handling when losing a disk when using JBOD
[ https://issues.apache.org/jira/browse/CASSANDRA-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andres de la Peña updated CASSANDRA-14793: -- Reviewers: Andres de la Peña, Marcus Eriksson (was: Marcus Eriksson) > Improve system table handling when losing a disk when using JBOD > > > Key: CASSANDRA-14793 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14793 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core >Reporter: Marcus Eriksson >Assignee: Benjamin Lerer >Priority: Normal > Fix For: 4.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > We should improve the way we handle disk failures when losing a disk in a > JBOD setup > One way could be to pin the system tables to a special data directory. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14793) Improve system table handling when losing a disk when using JBOD
[ https://issues.apache.org/jira/browse/CASSANDRA-14793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eriksson updated CASSANDRA-14793: Reviewers: Marcus Eriksson > Improve system table handling when losing a disk when using JBOD > > > Key: CASSANDRA-14793 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14793 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core >Reporter: Marcus Eriksson >Assignee: Benjamin Lerer >Priority: Normal > Fix For: 4.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > We should improve the way we handle disk failures when losing a disk in a > JBOD setup > One way could be to pin the system tables to a special data directory. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: ninja fixing wrongly committed circle-ci
This is an automated email from the ASF dual-hosted git repository. blerer pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/trunk by this push: new c26269b ninja fixing wrongly committed circle-ci c26269b is described below commit c26269bc54115958cb2d32c13cf99131ef118592 Author: Benjamin Lerer AuthorDate: Thu Nov 26 14:38:47 2020 +0100 ninja fixing wrongly committed circle-ci --- .circleci/config.yml | 82 ++-- 1 file changed, 41 insertions(+), 41 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 4af9e7d..1bffa2a 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -3,10 +3,10 @@ jobs: j8_jvm_upgrade_dtests: docker: - image: nastra/cassandra-testing-ubuntu1910-java11-w-dependencies:20200603 -resource_class: large +resource_class: medium working_directory: ~/ shell: /bin/bash -eo pipefail -l -parallelism: 4 +parallelism: 1 steps: - attach_workspace: at: /home/cassandra @@ -94,10 +94,10 @@ jobs: j8_cqlsh-dtests-py2-with-vnodes: docker: - image: nastra/cassandra-testing-ubuntu1910-java11-w-dependencies:20200603 -resource_class: large +resource_class: medium working_directory: ~/ shell: /bin/bash -eo pipefail -l -parallelism: 50 +parallelism: 4 steps: - attach_workspace: at: /home/cassandra @@ -174,7 +174,7 @@ jobs: resource_class: medium working_directory: ~/ shell: /bin/bash -eo pipefail -l -parallelism: 25 +parallelism: 4 steps: - attach_workspace: at: /home/cassandra @@ -263,10 +263,10 @@ jobs: j8_cqlsh-dtests-py38-no-vnodes: docker: - image: nastra/cassandra-testing-ubuntu1910-java11-w-dependencies:20200603 -resource_class: large +resource_class: medium working_directory: ~/ shell: /bin/bash -eo pipefail -l -parallelism: 50 +parallelism: 4 steps: - attach_workspace: at: /home/cassandra @@ -340,10 +340,10 @@ jobs: j11_cqlsh-dtests-py3-with-vnodes: docker: - image: nastra/cassandra-testing-ubuntu1910-java11:20200603 -resource_class: large +resource_class: medium working_directory: ~/ shell: /bin/bash -eo pipefail -l -parallelism: 50 +parallelism: 4 steps: - attach_workspace: at: /home/cassandra @@ -418,10 +418,10 @@ jobs: j11_cqlsh-dtests-py3-no-vnodes: docker: - image: nastra/cassandra-testing-ubuntu1910-java11:20200603 -resource_class: large +resource_class: medium working_directory: ~/ shell: /bin/bash -eo pipefail -l -parallelism: 50 +parallelism: 4 steps: - attach_workspace: at: /home/cassandra @@ -496,10 +496,10 @@ jobs: j11_cqlsh-dtests-py38-with-vnodes: docker: - image: nastra/cassandra-testing-ubuntu1910-java11:20200603 -resource_class: large +resource_class: medium working_directory: ~/ shell: /bin/bash -eo pipefail -l -parallelism: 50 +parallelism: 4 steps: - attach_workspace: at: /home/cassandra @@ -574,10 +574,10 @@ jobs: j8_cqlsh-dtests-py3-with-vnodes: docker: - image: nastra/cassandra-testing-ubuntu1910-java11-w-dependencies:20200603 -resource_class: large +resource_class: medium working_directory: ~/ shell: /bin/bash -eo pipefail -l -parallelism: 50 +parallelism: 4 steps: - attach_workspace: at: /home/cassandra @@ -651,10 +651,10 @@ jobs: j8_cqlsh-dtests-py2-no-vnodes: docker: - image: nastra/cassandra-testing-ubuntu1910-java11-w-dependencies:20200603 -resource_class: large +resource_class: medium working_directory: ~/ shell: /bin/bash -eo pipefail -l -parallelism: 50 +parallelism: 4 steps: - attach_workspace: at: /home/cassandra @@ -728,10 +728,10 @@ jobs: j11_cqlsh-dtests-py2-with-vnodes: docker: - image: nastra/cassandra-testing-ubuntu1910-java11:20200603 -resource_class: large +resource_class: medium working_directory: ~/ shell: /bin/bash -eo pipefail -l -parallelism: 50 +parallelism: 4 steps: - attach_workspace: at: /home/cassandra @@ -806,10 +806,10 @@ jobs: j11_dtests-with-vnodes: docker: - image: nastra/cassandra-testing-ubuntu1910-java11:20200603 -resource_class: large +resource_class: medium working_directory: ~/ shell: /bin/bash -eo pipefail -l -parallelism: 50 +parallelism: 4 steps: - attach_workspace: at: /home/cassandra @@ -887,10 +887,10 @@ jobs: j8_dtests-no-vnodes: docker: - image: nastra/cassandra-testing-ubuntu1910-java11-w-dependencies:20200603 -resource_class: large +resource_class: medium working_directory: ~/ shell: /bin/bash -eo
[jira] [Updated] (CASSANDRA-16302) HintsWriteThenReadTest & LongStreamingTest flaky
[ https://issues.apache.org/jira/browse/CASSANDRA-16302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Lerer updated CASSANDRA-16302: --- Reviewers: Benjamin Lerer, Benjamin Lerer (was: Benjamin Lerer) Benjamin Lerer, Benjamin Lerer (was: Benjamin Lerer) Status: Review In Progress (was: Patch Available) > HintsWriteThenReadTest & LongStreamingTest flaky > > > Key: CASSANDRA-16302 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16302 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Flaky tests for the last > [100%|https://ci-cassandra.apache.org/job/Cassandra-trunk/167/#showFailuresLink] > runs -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16259) tablehistograms cause ArrayIndexOutOfBoundsException
[
https://issues.apache.org/jira/browse/CASSANDRA-16259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239181#comment-17239181
]
Benjamin Lerer edited comment on CASSANDRA-16259 at 11/26/20, 1:10 PM:
---
While working on a fix for this bug I hit another issue that impact the 3.0,
3.X and 4.0 versions. On some scenario the number of cells for a row is counted
twice.
We count the number of cells per partition using the
{{BigTableWriter.StatsCollector}} which will increment the number of cells when
{{onPartitionClose}} is called. {{onPartitionClose}} is called when the
transformed {{UnfilteredRowIterator}} is closed by the {{try-with-resources}}
in
[BigTableWriter.append|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/io/sstable/format/big/BigTableWriter.java#L214].
Unfortunately, If the {{UnfilteredRowIterator}} is an instance of
{{UnfilteredRows}}
[Transformation.apply|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/transform/Transformation.java#L138]
will not create a wrapper around the {{UnfilteredRowIterator}} but will simply
add the {{Transformation}} to the list of transformations associated to that
iterator.
When a memtable is flush the {{UnfilteredRowIterator}} is opened in a
{{try-with-resources}} in
[FlushRunnable:writeSortedContent|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/Memtable.java#L473]
before being passed to {{BigTableWriter|append}}. If the
{{UnfilteredRowIterator}} is an instance of {{UnfilteredRows}},
{{StatsCollector#onPartitionClose}} will be called twice and the cells for the
row will be counted twice.
The patch contains a change that ensure that we do not hit that problem by
ensuring that if we call {{close}} on a class inheriting from {{BaseIterator}}
only the first close will be processed and the following one will be ignored.
|| Branches || Test results ||
| [trunk|https://github.com/apache/cassandra/pull/835] |
[j8|https://app.circleci.com/pipelines/github/blerer/cassandra/72/workflows/77c51c04-5a76-4530-99bd-cb1604f58931],
[j11|https://app.circleci.com/pipelines/github/blerer/cassandra/72/workflows/ab7be933-239c-41fb-a907-fa76a859ed99]
|
| [3.11|https://github.com/apache/cassandra/pull/836] |
[j8|https://app.circleci.com/pipelines/github/blerer/cassandra/69/workflows/9fb4aca3-3b41-4798-a921-07b4c7026b7e]
|
| [3.0|https://github.com/apache/cassandra/pull/837] |
[j8|https://app.circleci.com/pipelines/github/blerer/cassandra/70/workflows/b0ef5b25-0a4f-4ddb-92cd-b4c76f7908ea]
|
| [2.2|https://github.com/apache/cassandra/pull/838] |
[j8|https://app.circleci.com/pipelines/github/blerer/cassandra/71/workflows/d24c6595-9c8c-4893-86e0-ef3b15966f02]
|
was (Author: blerer):
While working on a fix for this bug I hit another issue that impact the 3.0,
3.X and 4.0 versions. On some scenario the number of cells for a row is counted
twice.
We count the number of cells per partition using the
{{BigTableWriter.StatsCollector}} which will increment the number of cells when
{{onPartitionClose}} is called. {{onPartitionClose}} is called when the
transformed {{UnfilteredRowIterator}} is closed by the {{try-with-resources}}
in
[BigTableWriter.append|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/io/sstable/format/big/BigTableWriter.java#L214].
Unfortunately, If the {{UnfilteredRowIterator}} is an instance of
{{UnfilteredRows}}
[Transformation.apply|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/transform/Transformation.java#L138]
will not create a wrapper around the {{UnfilteredRowIterator}} but will simply
add the {{Transformation}} to the list of transformations associated to that
iterator.
When a memtable is flush the {{UnfilteredRowIterator}} is opened in a
{{try-with-resources}} in
[FlushRunnable:writeSortedContent|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/Memtable.java#L473]
before being passed to {{BigTableWriter|append}}. If the
{{UnfilteredRowIterator}} is an instance of {{UnfilteredRows}},
{{StatsCollector#onPartitionClose}} will be called twice and the cells for the
row will be counted twice.
The patch contains a change that ensure that we do not hit that problem by
ensuring that if we call {{close}} on a class inheriting from {{BaseIterator}}
only the first close will be processed and the following one will be ignored.
|| Branches || Test results ||
| [trunk|https://github.com/apache/cassandra/pull/835] |
[j8|https://app.circleci.com/pipelines/github/blerer/cassandra/72/workflows/77c51c04-5a76-4530-99bd-cb1604f5893],
[j11|https://app.circleci.com/pipelines/github/blerer/cassandra/72/workflows/ab7be933-239c-41fb-a907-fa76a859ed99]
|
| [3.11|https://github.com/apache/cassandra/pull/836] |
[jira] [Updated] (CASSANDRA-16301) upgrade from C* 3.11.9 to 4.0-beta3 fails if 3.11.9 is configured with OldNetworkTopologyStrategy
[
https://issues.apache.org/jira/browse/CASSANDRA-16301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Lerer updated CASSANDRA-16301:
---
Fix Version/s: 4.0-beta4
Since Version: 4.0-alpha3
Source Control Link:
https://github.com/apache/cassandra/commit/47278ae3765fcf1532f20b0ade3f36f08a089630
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
Committed into trunk at 47278ae3765fcf1532f20b0ade3f36f08a089630
> upgrade from C* 3.11.9 to 4.0-beta3 fails if 3.11.9 is configured with
> OldNetworkTopologyStrategy
> -
>
> Key: CASSANDRA-16301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16301
> Project: Cassandra
> Issue Type: Bug
>Reporter: Yongle Zhang
>Assignee: Benjamin Lerer
>Priority: Normal
> Fix For: 4.0-beta4
>
>
> When we upgrade Cassandra from 3.11.9 to 4.0-beta3, if the old cluster
> (3.11.9) is configured with OldNetworkTopologyStrategy, 4.0-beta3 Cassandra
> fails to start with the following exception:
>
> {code:java}
> ERROR [main] 2020-11-24 22:49:33,423 CassandraDaemon.java:278 - Error while
> loading schema:
> org.apache.cassandra.exceptions.ConfigurationException: Unable to find
> replication strategy class
> 'org.apache.cassandra.locator.OldNetworkTopologyStrategy'
> at
> org.apache.cassandra.utils.FBUtilities.classForName(FBUtilities.java:720)
> at
> org.apache.cassandra.locator.AbstractReplicationStrategy.getClass(AbstractReplicationStrategy.java:422)
> at
> org.apache.cassandra.schema.ReplicationParams.fromMapWithDefaults(ReplicationParams.java:90)
> at
> org.apache.cassandra.schema.ReplicationParams.fromMap(ReplicationParams.java:82)
> at
> org.apache.cassandra.schema.KeyspaceParams.create(KeyspaceParams.java:64)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspaceParams(SchemaKeyspace.java:971)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspace(SchemaKeyspace.java:956)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspacesWithout(SchemaKeyspace.java:949)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchNonSystemKeyspaces(SchemaKeyspace.java:859)
> at org.apache.cassandra.schema.Schema.loadFromDisk(Schema.java:100)
> at org.apache.cassandra.schema.Schema.loadFromDisk(Schema.java:89)
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:274)
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:671)
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:795)
> Caused by: java.lang.ClassNotFoundException:
> org.apache.cassandra.locator.OldNetworkTopologyStrategy
> at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
> at java.lang.Class.forName0(Native Method)
> at java.lang.Class.forName(Class.java:264)
> at
> org.apache.cassandra.utils.FBUtilities.classForName(FBUtilities.java:716)
> ... 13 common frames omitted
> Exception (org.apache.cassandra.exceptions.ConfigurationException)
> encountered during startup: Unable to find replication strategy class
> 'org.apache.cassandra.locator.OldNetworkTopologyStrategy'{code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: Use a more informative message when rejecting OldNetworkTopologyStrategy
This is an automated email from the ASF dual-hosted git repository. blerer pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/trunk by this push: new 47278ae Use a more informative message when rejecting OldNetworkTopologyStrategy 47278ae is described below commit 47278ae3765fcf1532f20b0ade3f36f08a089630 Author: Benjamin Lerer AuthorDate: Thu Nov 26 10:37:55 2020 +0100 Use a more informative message when rejecting OldNetworkTopologyStrategy patch by Benjamin Lerer; reviewed by Erick Ramirez for CASSANDRA-16301 The patch also add an entry to NEWS.txt in the upgrade section to warn people using the OldNetworkTopologyStrategy --- .circleci/config.yml | 82 +++--- NEWS.txt | 2 + .../locator/AbstractReplicationStrategy.java | 4 ++ 3 files changed, 47 insertions(+), 41 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 1bffa2a..4af9e7d 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -3,10 +3,10 @@ jobs: j8_jvm_upgrade_dtests: docker: - image: nastra/cassandra-testing-ubuntu1910-java11-w-dependencies:20200603 -resource_class: medium +resource_class: large working_directory: ~/ shell: /bin/bash -eo pipefail -l -parallelism: 1 +parallelism: 4 steps: - attach_workspace: at: /home/cassandra @@ -94,10 +94,10 @@ jobs: j8_cqlsh-dtests-py2-with-vnodes: docker: - image: nastra/cassandra-testing-ubuntu1910-java11-w-dependencies:20200603 -resource_class: medium +resource_class: large working_directory: ~/ shell: /bin/bash -eo pipefail -l -parallelism: 4 +parallelism: 50 steps: - attach_workspace: at: /home/cassandra @@ -174,7 +174,7 @@ jobs: resource_class: medium working_directory: ~/ shell: /bin/bash -eo pipefail -l -parallelism: 4 +parallelism: 25 steps: - attach_workspace: at: /home/cassandra @@ -263,10 +263,10 @@ jobs: j8_cqlsh-dtests-py38-no-vnodes: docker: - image: nastra/cassandra-testing-ubuntu1910-java11-w-dependencies:20200603 -resource_class: medium +resource_class: large working_directory: ~/ shell: /bin/bash -eo pipefail -l -parallelism: 4 +parallelism: 50 steps: - attach_workspace: at: /home/cassandra @@ -340,10 +340,10 @@ jobs: j11_cqlsh-dtests-py3-with-vnodes: docker: - image: nastra/cassandra-testing-ubuntu1910-java11:20200603 -resource_class: medium +resource_class: large working_directory: ~/ shell: /bin/bash -eo pipefail -l -parallelism: 4 +parallelism: 50 steps: - attach_workspace: at: /home/cassandra @@ -418,10 +418,10 @@ jobs: j11_cqlsh-dtests-py3-no-vnodes: docker: - image: nastra/cassandra-testing-ubuntu1910-java11:20200603 -resource_class: medium +resource_class: large working_directory: ~/ shell: /bin/bash -eo pipefail -l -parallelism: 4 +parallelism: 50 steps: - attach_workspace: at: /home/cassandra @@ -496,10 +496,10 @@ jobs: j11_cqlsh-dtests-py38-with-vnodes: docker: - image: nastra/cassandra-testing-ubuntu1910-java11:20200603 -resource_class: medium +resource_class: large working_directory: ~/ shell: /bin/bash -eo pipefail -l -parallelism: 4 +parallelism: 50 steps: - attach_workspace: at: /home/cassandra @@ -574,10 +574,10 @@ jobs: j8_cqlsh-dtests-py3-with-vnodes: docker: - image: nastra/cassandra-testing-ubuntu1910-java11-w-dependencies:20200603 -resource_class: medium +resource_class: large working_directory: ~/ shell: /bin/bash -eo pipefail -l -parallelism: 4 +parallelism: 50 steps: - attach_workspace: at: /home/cassandra @@ -651,10 +651,10 @@ jobs: j8_cqlsh-dtests-py2-no-vnodes: docker: - image: nastra/cassandra-testing-ubuntu1910-java11-w-dependencies:20200603 -resource_class: medium +resource_class: large working_directory: ~/ shell: /bin/bash -eo pipefail -l -parallelism: 4 +parallelism: 50 steps: - attach_workspace: at: /home/cassandra @@ -728,10 +728,10 @@ jobs: j11_cqlsh-dtests-py2-with-vnodes: docker: - image: nastra/cassandra-testing-ubuntu1910-java11:20200603 -resource_class: medium +resource_class: large working_directory: ~/ shell: /bin/bash -eo pipefail -l -parallelism: 4 +parallelism: 50 steps: - attach_workspace: at: /home/cassandra @@ -806,10 +806,10 @@ jobs: j11_dtests-with-vnodes: docker: - image: nastra/cassandra-testing-ubuntu1910-java11:20200603 -resource_class: medium +resource_class: large working_directory: ~/
[jira] [Updated] (CASSANDRA-16301) upgrade from C* 3.11.9 to 4.0-beta3 fails if 3.11.9 is configured with OldNetworkTopologyStrategy
[
https://issues.apache.org/jira/browse/CASSANDRA-16301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Lerer updated CASSANDRA-16301:
---
Reviewers: Erick Ramirez (was: Benjamin Lerer, Erick Ramirez)
> upgrade from C* 3.11.9 to 4.0-beta3 fails if 3.11.9 is configured with
> OldNetworkTopologyStrategy
> -
>
> Key: CASSANDRA-16301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16301
> Project: Cassandra
> Issue Type: Bug
>Reporter: Yongle Zhang
>Assignee: Benjamin Lerer
>Priority: Normal
>
> When we upgrade Cassandra from 3.11.9 to 4.0-beta3, if the old cluster
> (3.11.9) is configured with OldNetworkTopologyStrategy, 4.0-beta3 Cassandra
> fails to start with the following exception:
>
> {code:java}
> ERROR [main] 2020-11-24 22:49:33,423 CassandraDaemon.java:278 - Error while
> loading schema:
> org.apache.cassandra.exceptions.ConfigurationException: Unable to find
> replication strategy class
> 'org.apache.cassandra.locator.OldNetworkTopologyStrategy'
> at
> org.apache.cassandra.utils.FBUtilities.classForName(FBUtilities.java:720)
> at
> org.apache.cassandra.locator.AbstractReplicationStrategy.getClass(AbstractReplicationStrategy.java:422)
> at
> org.apache.cassandra.schema.ReplicationParams.fromMapWithDefaults(ReplicationParams.java:90)
> at
> org.apache.cassandra.schema.ReplicationParams.fromMap(ReplicationParams.java:82)
> at
> org.apache.cassandra.schema.KeyspaceParams.create(KeyspaceParams.java:64)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspaceParams(SchemaKeyspace.java:971)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspace(SchemaKeyspace.java:956)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspacesWithout(SchemaKeyspace.java:949)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchNonSystemKeyspaces(SchemaKeyspace.java:859)
> at org.apache.cassandra.schema.Schema.loadFromDisk(Schema.java:100)
> at org.apache.cassandra.schema.Schema.loadFromDisk(Schema.java:89)
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:274)
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:671)
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:795)
> Caused by: java.lang.ClassNotFoundException:
> org.apache.cassandra.locator.OldNetworkTopologyStrategy
> at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
> at java.lang.Class.forName0(Native Method)
> at java.lang.Class.forName(Class.java:264)
> at
> org.apache.cassandra.utils.FBUtilities.classForName(FBUtilities.java:716)
> ... 13 common frames omitted
> Exception (org.apache.cassandra.exceptions.ConfigurationException)
> encountered during startup: Unable to find replication strategy class
> 'org.apache.cassandra.locator.OldNetworkTopologyStrategy'{code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16301) upgrade from C* 3.11.9 to 4.0-beta3 fails if 3.11.9 is configured with OldNetworkTopologyStrategy
[
https://issues.apache.org/jira/browse/CASSANDRA-16301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Lerer updated CASSANDRA-16301:
---
Reviewers: Erick Ramirez, Benjamin Lerer (was: Benjamin Lerer, Erick
Ramirez)
Erick Ramirez, Benjamin Lerer
Status: Review In Progress (was: Patch Available)
> upgrade from C* 3.11.9 to 4.0-beta3 fails if 3.11.9 is configured with
> OldNetworkTopologyStrategy
> -
>
> Key: CASSANDRA-16301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16301
> Project: Cassandra
> Issue Type: Bug
>Reporter: Yongle Zhang
>Assignee: Benjamin Lerer
>Priority: Normal
>
> When we upgrade Cassandra from 3.11.9 to 4.0-beta3, if the old cluster
> (3.11.9) is configured with OldNetworkTopologyStrategy, 4.0-beta3 Cassandra
> fails to start with the following exception:
>
> {code:java}
> ERROR [main] 2020-11-24 22:49:33,423 CassandraDaemon.java:278 - Error while
> loading schema:
> org.apache.cassandra.exceptions.ConfigurationException: Unable to find
> replication strategy class
> 'org.apache.cassandra.locator.OldNetworkTopologyStrategy'
> at
> org.apache.cassandra.utils.FBUtilities.classForName(FBUtilities.java:720)
> at
> org.apache.cassandra.locator.AbstractReplicationStrategy.getClass(AbstractReplicationStrategy.java:422)
> at
> org.apache.cassandra.schema.ReplicationParams.fromMapWithDefaults(ReplicationParams.java:90)
> at
> org.apache.cassandra.schema.ReplicationParams.fromMap(ReplicationParams.java:82)
> at
> org.apache.cassandra.schema.KeyspaceParams.create(KeyspaceParams.java:64)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspaceParams(SchemaKeyspace.java:971)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspace(SchemaKeyspace.java:956)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspacesWithout(SchemaKeyspace.java:949)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchNonSystemKeyspaces(SchemaKeyspace.java:859)
> at org.apache.cassandra.schema.Schema.loadFromDisk(Schema.java:100)
> at org.apache.cassandra.schema.Schema.loadFromDisk(Schema.java:89)
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:274)
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:671)
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:795)
> Caused by: java.lang.ClassNotFoundException:
> org.apache.cassandra.locator.OldNetworkTopologyStrategy
> at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
> at java.lang.Class.forName0(Native Method)
> at java.lang.Class.forName(Class.java:264)
> at
> org.apache.cassandra.utils.FBUtilities.classForName(FBUtilities.java:716)
> ... 13 common frames omitted
> Exception (org.apache.cassandra.exceptions.ConfigurationException)
> encountered during startup: Unable to find replication strategy class
> 'org.apache.cassandra.locator.OldNetworkTopologyStrategy'{code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16301) upgrade from C* 3.11.9 to 4.0-beta3 fails if 3.11.9 is configured with OldNetworkTopologyStrategy
[
https://issues.apache.org/jira/browse/CASSANDRA-16301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Lerer updated CASSANDRA-16301:
---
Status: Ready to Commit (was: Review In Progress)
> upgrade from C* 3.11.9 to 4.0-beta3 fails if 3.11.9 is configured with
> OldNetworkTopologyStrategy
> -
>
> Key: CASSANDRA-16301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16301
> Project: Cassandra
> Issue Type: Bug
>Reporter: Yongle Zhang
>Assignee: Benjamin Lerer
>Priority: Normal
>
> When we upgrade Cassandra from 3.11.9 to 4.0-beta3, if the old cluster
> (3.11.9) is configured with OldNetworkTopologyStrategy, 4.0-beta3 Cassandra
> fails to start with the following exception:
>
> {code:java}
> ERROR [main] 2020-11-24 22:49:33,423 CassandraDaemon.java:278 - Error while
> loading schema:
> org.apache.cassandra.exceptions.ConfigurationException: Unable to find
> replication strategy class
> 'org.apache.cassandra.locator.OldNetworkTopologyStrategy'
> at
> org.apache.cassandra.utils.FBUtilities.classForName(FBUtilities.java:720)
> at
> org.apache.cassandra.locator.AbstractReplicationStrategy.getClass(AbstractReplicationStrategy.java:422)
> at
> org.apache.cassandra.schema.ReplicationParams.fromMapWithDefaults(ReplicationParams.java:90)
> at
> org.apache.cassandra.schema.ReplicationParams.fromMap(ReplicationParams.java:82)
> at
> org.apache.cassandra.schema.KeyspaceParams.create(KeyspaceParams.java:64)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspaceParams(SchemaKeyspace.java:971)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspace(SchemaKeyspace.java:956)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspacesWithout(SchemaKeyspace.java:949)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchNonSystemKeyspaces(SchemaKeyspace.java:859)
> at org.apache.cassandra.schema.Schema.loadFromDisk(Schema.java:100)
> at org.apache.cassandra.schema.Schema.loadFromDisk(Schema.java:89)
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:274)
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:671)
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:795)
> Caused by: java.lang.ClassNotFoundException:
> org.apache.cassandra.locator.OldNetworkTopologyStrategy
> at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
> at java.lang.Class.forName0(Native Method)
> at java.lang.Class.forName(Class.java:264)
> at
> org.apache.cassandra.utils.FBUtilities.classForName(FBUtilities.java:716)
> ... 13 common frames omitted
> Exception (org.apache.cassandra.exceptions.ConfigurationException)
> encountered during startup: Unable to find replication strategy class
> 'org.apache.cassandra.locator.OldNetworkTopologyStrategy'{code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16301) upgrade from C* 3.11.9 to 4.0-beta3 fails if 3.11.9 is configured with OldNetworkTopologyStrategy
[
https://issues.apache.org/jira/browse/CASSANDRA-16301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239247#comment-17239247
]
Benjamin Lerer commented on CASSANDRA-16301:
I added your suggestions. Thanks for the review. :-)
> upgrade from C* 3.11.9 to 4.0-beta3 fails if 3.11.9 is configured with
> OldNetworkTopologyStrategy
> -
>
> Key: CASSANDRA-16301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16301
> Project: Cassandra
> Issue Type: Bug
>Reporter: Yongle Zhang
>Assignee: Benjamin Lerer
>Priority: Normal
>
> When we upgrade Cassandra from 3.11.9 to 4.0-beta3, if the old cluster
> (3.11.9) is configured with OldNetworkTopologyStrategy, 4.0-beta3 Cassandra
> fails to start with the following exception:
>
> {code:java}
> ERROR [main] 2020-11-24 22:49:33,423 CassandraDaemon.java:278 - Error while
> loading schema:
> org.apache.cassandra.exceptions.ConfigurationException: Unable to find
> replication strategy class
> 'org.apache.cassandra.locator.OldNetworkTopologyStrategy'
> at
> org.apache.cassandra.utils.FBUtilities.classForName(FBUtilities.java:720)
> at
> org.apache.cassandra.locator.AbstractReplicationStrategy.getClass(AbstractReplicationStrategy.java:422)
> at
> org.apache.cassandra.schema.ReplicationParams.fromMapWithDefaults(ReplicationParams.java:90)
> at
> org.apache.cassandra.schema.ReplicationParams.fromMap(ReplicationParams.java:82)
> at
> org.apache.cassandra.schema.KeyspaceParams.create(KeyspaceParams.java:64)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspaceParams(SchemaKeyspace.java:971)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspace(SchemaKeyspace.java:956)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspacesWithout(SchemaKeyspace.java:949)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchNonSystemKeyspaces(SchemaKeyspace.java:859)
> at org.apache.cassandra.schema.Schema.loadFromDisk(Schema.java:100)
> at org.apache.cassandra.schema.Schema.loadFromDisk(Schema.java:89)
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:274)
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:671)
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:795)
> Caused by: java.lang.ClassNotFoundException:
> org.apache.cassandra.locator.OldNetworkTopologyStrategy
> at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
> at java.lang.Class.forName0(Native Method)
> at java.lang.Class.forName(Class.java:264)
> at
> org.apache.cassandra.utils.FBUtilities.classForName(FBUtilities.java:716)
> ... 13 common frames omitted
> Exception (org.apache.cassandra.exceptions.ConfigurationException)
> encountered during startup: Unable to find replication strategy class
> 'org.apache.cassandra.locator.OldNetworkTopologyStrategy'{code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16301) upgrade from C* 3.11.9 to 4.0-beta3 fails if 3.11.9 is configured with OldNetworkTopologyStrategy
[
https://issues.apache.org/jira/browse/CASSANDRA-16301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Lerer updated CASSANDRA-16301:
---
Test and Documentation Plan: The changes do not require additional tests.
Status: Patch Available (was: In Progress)
> upgrade from C* 3.11.9 to 4.0-beta3 fails if 3.11.9 is configured with
> OldNetworkTopologyStrategy
> -
>
> Key: CASSANDRA-16301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16301
> Project: Cassandra
> Issue Type: Bug
>Reporter: Yongle Zhang
>Assignee: Benjamin Lerer
>Priority: Normal
>
> When we upgrade Cassandra from 3.11.9 to 4.0-beta3, if the old cluster
> (3.11.9) is configured with OldNetworkTopologyStrategy, 4.0-beta3 Cassandra
> fails to start with the following exception:
>
> {code:java}
> ERROR [main] 2020-11-24 22:49:33,423 CassandraDaemon.java:278 - Error while
> loading schema:
> org.apache.cassandra.exceptions.ConfigurationException: Unable to find
> replication strategy class
> 'org.apache.cassandra.locator.OldNetworkTopologyStrategy'
> at
> org.apache.cassandra.utils.FBUtilities.classForName(FBUtilities.java:720)
> at
> org.apache.cassandra.locator.AbstractReplicationStrategy.getClass(AbstractReplicationStrategy.java:422)
> at
> org.apache.cassandra.schema.ReplicationParams.fromMapWithDefaults(ReplicationParams.java:90)
> at
> org.apache.cassandra.schema.ReplicationParams.fromMap(ReplicationParams.java:82)
> at
> org.apache.cassandra.schema.KeyspaceParams.create(KeyspaceParams.java:64)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspaceParams(SchemaKeyspace.java:971)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspace(SchemaKeyspace.java:956)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspacesWithout(SchemaKeyspace.java:949)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchNonSystemKeyspaces(SchemaKeyspace.java:859)
> at org.apache.cassandra.schema.Schema.loadFromDisk(Schema.java:100)
> at org.apache.cassandra.schema.Schema.loadFromDisk(Schema.java:89)
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:274)
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:671)
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:795)
> Caused by: java.lang.ClassNotFoundException:
> org.apache.cassandra.locator.OldNetworkTopologyStrategy
> at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
> at java.lang.Class.forName0(Native Method)
> at java.lang.Class.forName(Class.java:264)
> at
> org.apache.cassandra.utils.FBUtilities.classForName(FBUtilities.java:716)
> ... 13 common frames omitted
> Exception (org.apache.cassandra.exceptions.ConfigurationException)
> encountered during startup: Unable to find replication strategy class
> 'org.apache.cassandra.locator.OldNetworkTopologyStrategy'{code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16259) tablehistograms cause ArrayIndexOutOfBoundsException
[
https://issues.apache.org/jira/browse/CASSANDRA-16259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-16259:
Reviewers: Berenguer Blasi
> tablehistograms cause ArrayIndexOutOfBoundsException
>
>
> Key: CASSANDRA-16259
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16259
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/Metrics
>Reporter: Justin Montgomery
>Assignee: Benjamin Lerer
>Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta
>
>
> After upgrading some nodes in our cluster from 3.11.8 to 3.11.9 an error
> appeared on the upgraded nodes when trying to access *tablehistograms*. The
> same command run on our .8 nodes return as expected, only the upgraded .9
> nodes fail. Not all tables fail when queried, but about 90% of them do.
> We use Datastax MCAC which appears to query histograms every 30 seconds, this
> outputs to the system.log:
> {noformat}
> WARN [insights-3-1] 2020-11-09 01:11:22,331 UnixSocketClient.java:830 -
> Error reporting:
> java.lang.ArrayIndexOutOfBoundsException: 115
> at
> org.apache.cassandra.metrics.TableMetrics.combineHistograms(TableMetrics.java:261)
> ~[apache-cassandra-3.11.9.jar:3.11.9]
> at
> org.apache.cassandra.metrics.TableMetrics.access$000(TableMetrics.java:48)
> ~[apache-cassandra-3.11.9.jar:3.11.9]
> at
> org.apache.cassandra.metrics.TableMetrics$11.getValue(TableMetrics.java:376)
> ~[apache-cassandra-3.11.9.jar:3.11.9]
> at
> org.apache.cassandra.metrics.TableMetrics$11.getValue(TableMetrics.java:373)
> ~[apache-cassandra-3.11.9.jar:3.11.9]
> at
> com.datastax.mcac.UnixSocketClient.writeMetric(UnixSocketClient.java:839)
> [datastax-mcac-agent.jar:na]
> at
> com.datastax.mcac.UnixSocketClient.access$700(UnixSocketClient.java:78)
> [datastax-mcac-agent.jar:na]
> at
> com.datastax.mcac.UnixSocketClient$2.lambda$onGaugeAdded$0(UnixSocketClient.java:626)
> ~[datastax-mcac-agent.jar:na]
> at
> com.datastax.mcac.UnixSocketClient.writeGroup(UnixSocketClient.java:819)
> [datastax-mcac-agent.jar:na]
> at
> com.datastax.mcac.UnixSocketClient.lambda$restartMetricReporting$2(UnixSocketClient.java:798)
> [datastax-mcac-agent.jar:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[na:1.8.0_272]
> at
> io.netty.util.concurrent.ScheduledFutureTask.run(ScheduledFutureTask.java:126)
> ~[netty-all-4.0.44.Final.jar:4.0.44.Final]
> at
> io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:399)
> ~[netty-all-4.0.44.Final.jar:4.0.44.Final]
> at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:307)
> ~[netty-all-4.0.44.Final.jar:4.0.44.Final]
> at
> io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:131)
> ~[netty-all-4.0.44.Final.jar:4.0.44.Final]
> at
> io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:144)
> ~[netty-all-4.0.44.Final.jar:4.0.44.Final]
> at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_272]{noformat}
> Manually trying a histogram from the CLI:
> {noformat}
> $ nodetool tablehistograms logdata log_height_index
> error: 115
> -- StackTrace --
> java.lang.ArrayIndexOutOfBoundsException: 115
> at
> org.apache.cassandra.metrics.TableMetrics.combineHistograms(TableMetrics.java:261)
> at
> org.apache.cassandra.metrics.TableMetrics.access$000(TableMetrics.java:48)
> at
> org.apache.cassandra.metrics.TableMetrics$11.getValue(TableMetrics.java:376)
> at
> org.apache.cassandra.metrics.TableMetrics$11.getValue(TableMetrics.java:373)
> at
> org.apache.cassandra.metrics.CassandraMetricsRegistry$JmxGauge.getValue(CassandraMetricsRegistry.java:250)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at sun.reflect.misc.Trampoline.invoke(MethodUtil.java:72)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at sun.reflect.misc.MethodUtil.invoke(MethodUtil.java:276)
> at
> com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:112)
> at
>
[jira] [Assigned] (CASSANDRA-16301) upgrade from C* 3.11.9 to 4.0-beta3 fails if 3.11.9 is configured with OldNetworkTopologyStrategy
[
https://issues.apache.org/jira/browse/CASSANDRA-16301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Ramirez reassigned CASSANDRA-16301:
-
Assignee: Benjamin Lerer (was: Erick Ramirez)
> upgrade from C* 3.11.9 to 4.0-beta3 fails if 3.11.9 is configured with
> OldNetworkTopologyStrategy
> -
>
> Key: CASSANDRA-16301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16301
> Project: Cassandra
> Issue Type: Bug
>Reporter: Yongle Zhang
>Assignee: Benjamin Lerer
>Priority: Normal
>
> When we upgrade Cassandra from 3.11.9 to 4.0-beta3, if the old cluster
> (3.11.9) is configured with OldNetworkTopologyStrategy, 4.0-beta3 Cassandra
> fails to start with the following exception:
>
> {code:java}
> ERROR [main] 2020-11-24 22:49:33,423 CassandraDaemon.java:278 - Error while
> loading schema:
> org.apache.cassandra.exceptions.ConfigurationException: Unable to find
> replication strategy class
> 'org.apache.cassandra.locator.OldNetworkTopologyStrategy'
> at
> org.apache.cassandra.utils.FBUtilities.classForName(FBUtilities.java:720)
> at
> org.apache.cassandra.locator.AbstractReplicationStrategy.getClass(AbstractReplicationStrategy.java:422)
> at
> org.apache.cassandra.schema.ReplicationParams.fromMapWithDefaults(ReplicationParams.java:90)
> at
> org.apache.cassandra.schema.ReplicationParams.fromMap(ReplicationParams.java:82)
> at
> org.apache.cassandra.schema.KeyspaceParams.create(KeyspaceParams.java:64)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspaceParams(SchemaKeyspace.java:971)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspace(SchemaKeyspace.java:956)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspacesWithout(SchemaKeyspace.java:949)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchNonSystemKeyspaces(SchemaKeyspace.java:859)
> at org.apache.cassandra.schema.Schema.loadFromDisk(Schema.java:100)
> at org.apache.cassandra.schema.Schema.loadFromDisk(Schema.java:89)
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:274)
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:671)
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:795)
> Caused by: java.lang.ClassNotFoundException:
> org.apache.cassandra.locator.OldNetworkTopologyStrategy
> at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
> at java.lang.Class.forName0(Native Method)
> at java.lang.Class.forName(Class.java:264)
> at
> org.apache.cassandra.utils.FBUtilities.classForName(FBUtilities.java:716)
> ... 13 common frames omitted
> Exception (org.apache.cassandra.exceptions.ConfigurationException)
> encountered during startup: Unable to find replication strategy class
> 'org.apache.cassandra.locator.OldNetworkTopologyStrategy'{code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16301) upgrade from C* 3.11.9 to 4.0-beta3 fails if 3.11.9 is configured with OldNetworkTopologyStrategy
[
https://issues.apache.org/jira/browse/CASSANDRA-16301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239185#comment-17239185
]
Erick Ramirez commented on CASSANDRA-16301:
---
[~blerer] excellent suggestions and thanks for getting to them really quickly.
I was about to do them but it's awesome that you already did.
If I may suggest adding {{CASSANDRA-13999}} to the {{NEWS.txt}} entry.
And what do you think about also adding the ticket in the exception message of
{{AbstractReplicationStrategy}}? If not, maybe even as a comment. Cheers!
> upgrade from C* 3.11.9 to 4.0-beta3 fails if 3.11.9 is configured with
> OldNetworkTopologyStrategy
> -
>
> Key: CASSANDRA-16301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16301
> Project: Cassandra
> Issue Type: Bug
>Reporter: Yongle Zhang
>Assignee: Erick Ramirez
>Priority: Normal
>
> When we upgrade Cassandra from 3.11.9 to 4.0-beta3, if the old cluster
> (3.11.9) is configured with OldNetworkTopologyStrategy, 4.0-beta3 Cassandra
> fails to start with the following exception:
>
> {code:java}
> ERROR [main] 2020-11-24 22:49:33,423 CassandraDaemon.java:278 - Error while
> loading schema:
> org.apache.cassandra.exceptions.ConfigurationException: Unable to find
> replication strategy class
> 'org.apache.cassandra.locator.OldNetworkTopologyStrategy'
> at
> org.apache.cassandra.utils.FBUtilities.classForName(FBUtilities.java:720)
> at
> org.apache.cassandra.locator.AbstractReplicationStrategy.getClass(AbstractReplicationStrategy.java:422)
> at
> org.apache.cassandra.schema.ReplicationParams.fromMapWithDefaults(ReplicationParams.java:90)
> at
> org.apache.cassandra.schema.ReplicationParams.fromMap(ReplicationParams.java:82)
> at
> org.apache.cassandra.schema.KeyspaceParams.create(KeyspaceParams.java:64)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspaceParams(SchemaKeyspace.java:971)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspace(SchemaKeyspace.java:956)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspacesWithout(SchemaKeyspace.java:949)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchNonSystemKeyspaces(SchemaKeyspace.java:859)
> at org.apache.cassandra.schema.Schema.loadFromDisk(Schema.java:100)
> at org.apache.cassandra.schema.Schema.loadFromDisk(Schema.java:89)
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:274)
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:671)
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:795)
> Caused by: java.lang.ClassNotFoundException:
> org.apache.cassandra.locator.OldNetworkTopologyStrategy
> at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
> at java.lang.Class.forName0(Native Method)
> at java.lang.Class.forName(Class.java:264)
> at
> org.apache.cassandra.utils.FBUtilities.classForName(FBUtilities.java:716)
> ... 13 common frames omitted
> Exception (org.apache.cassandra.exceptions.ConfigurationException)
> encountered during startup: Unable to find replication strategy class
> 'org.apache.cassandra.locator.OldNetworkTopologyStrategy'{code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16259) tablehistograms cause ArrayIndexOutOfBoundsException
[
https://issues.apache.org/jira/browse/CASSANDRA-16259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Lerer updated CASSANDRA-16259:
---
Test and Documentation Plan:
The patch add some new unit tests to TableMetricsTest to check that the merging
of histogram is working properly and that the metrics using that mechanism are
returning the correct numbers.
Status: Patch Available (was: In Progress)
> tablehistograms cause ArrayIndexOutOfBoundsException
>
>
> Key: CASSANDRA-16259
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16259
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/Metrics
>Reporter: Justin Montgomery
>Assignee: Benjamin Lerer
>Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta
>
>
> After upgrading some nodes in our cluster from 3.11.8 to 3.11.9 an error
> appeared on the upgraded nodes when trying to access *tablehistograms*. The
> same command run on our .8 nodes return as expected, only the upgraded .9
> nodes fail. Not all tables fail when queried, but about 90% of them do.
> We use Datastax MCAC which appears to query histograms every 30 seconds, this
> outputs to the system.log:
> {noformat}
> WARN [insights-3-1] 2020-11-09 01:11:22,331 UnixSocketClient.java:830 -
> Error reporting:
> java.lang.ArrayIndexOutOfBoundsException: 115
> at
> org.apache.cassandra.metrics.TableMetrics.combineHistograms(TableMetrics.java:261)
> ~[apache-cassandra-3.11.9.jar:3.11.9]
> at
> org.apache.cassandra.metrics.TableMetrics.access$000(TableMetrics.java:48)
> ~[apache-cassandra-3.11.9.jar:3.11.9]
> at
> org.apache.cassandra.metrics.TableMetrics$11.getValue(TableMetrics.java:376)
> ~[apache-cassandra-3.11.9.jar:3.11.9]
> at
> org.apache.cassandra.metrics.TableMetrics$11.getValue(TableMetrics.java:373)
> ~[apache-cassandra-3.11.9.jar:3.11.9]
> at
> com.datastax.mcac.UnixSocketClient.writeMetric(UnixSocketClient.java:839)
> [datastax-mcac-agent.jar:na]
> at
> com.datastax.mcac.UnixSocketClient.access$700(UnixSocketClient.java:78)
> [datastax-mcac-agent.jar:na]
> at
> com.datastax.mcac.UnixSocketClient$2.lambda$onGaugeAdded$0(UnixSocketClient.java:626)
> ~[datastax-mcac-agent.jar:na]
> at
> com.datastax.mcac.UnixSocketClient.writeGroup(UnixSocketClient.java:819)
> [datastax-mcac-agent.jar:na]
> at
> com.datastax.mcac.UnixSocketClient.lambda$restartMetricReporting$2(UnixSocketClient.java:798)
> [datastax-mcac-agent.jar:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[na:1.8.0_272]
> at
> io.netty.util.concurrent.ScheduledFutureTask.run(ScheduledFutureTask.java:126)
> ~[netty-all-4.0.44.Final.jar:4.0.44.Final]
> at
> io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:399)
> ~[netty-all-4.0.44.Final.jar:4.0.44.Final]
> at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:307)
> ~[netty-all-4.0.44.Final.jar:4.0.44.Final]
> at
> io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:131)
> ~[netty-all-4.0.44.Final.jar:4.0.44.Final]
> at
> io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:144)
> ~[netty-all-4.0.44.Final.jar:4.0.44.Final]
> at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_272]{noformat}
> Manually trying a histogram from the CLI:
> {noformat}
> $ nodetool tablehistograms logdata log_height_index
> error: 115
> -- StackTrace --
> java.lang.ArrayIndexOutOfBoundsException: 115
> at
> org.apache.cassandra.metrics.TableMetrics.combineHistograms(TableMetrics.java:261)
> at
> org.apache.cassandra.metrics.TableMetrics.access$000(TableMetrics.java:48)
> at
> org.apache.cassandra.metrics.TableMetrics$11.getValue(TableMetrics.java:376)
> at
> org.apache.cassandra.metrics.TableMetrics$11.getValue(TableMetrics.java:373)
> at
> org.apache.cassandra.metrics.CassandraMetricsRegistry$JmxGauge.getValue(CassandraMetricsRegistry.java:250)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at sun.reflect.misc.Trampoline.invoke(MethodUtil.java:72)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at
[jira] [Commented] (CASSANDRA-16259) tablehistograms cause ArrayIndexOutOfBoundsException
[
https://issues.apache.org/jira/browse/CASSANDRA-16259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239181#comment-17239181
]
Benjamin Lerer commented on CASSANDRA-16259:
While working on a fix for this bug I hit another issue that impact the 3.0,
3.X and 4.0 versions. On some scenario the number of cells for a row is counted
twice.
We count the number of cells per partition using the
{{BigTableWriter.StatsCollector}} which will increment the number of cells when
{{onPartitionClose}} is called. {{onPartitionClose}} is called when the
transformed {{UnfilteredRowIterator}} is closed by the {{try-with-resources}}
in
[BigTableWriter.append|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/io/sstable/format/big/BigTableWriter.java#L214].
Unfortunately, If the {{UnfilteredRowIterator}} is an instance of
{{UnfilteredRows}}
[Transformation.apply|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/transform/Transformation.java#L138]
will not create a wrapper around the {{UnfilteredRowIterator}} but will simply
add the {{Transformation}} to the list of transformations associated to that
iterator.
When a memtable is flush the {{UnfilteredRowIterator}} is opened in a
{{try-with-resources}} in
[FlushRunnable:writeSortedContent|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/Memtable.java#L473]
before being passed to {{BigTableWriter|append}}. If the
{{UnfilteredRowIterator}} is an instance of {{UnfilteredRows}},
{{StatsCollector#onPartitionClose}} will be called twice and the cells for the
row will be counted twice.
The patch contains a change that ensure that we do not hit that problem by
ensuring that if we call {{close}} on a class inheriting from {{BaseIterator}}
only the first close will be processed and the following one will be ignored.
|| Branches || Test results ||
| [trunk|https://github.com/apache/cassandra/pull/835] |
[j8|https://app.circleci.com/pipelines/github/blerer/cassandra/72/workflows/77c51c04-5a76-4530-99bd-cb1604f5893],
[j11|https://app.circleci.com/pipelines/github/blerer/cassandra/72/workflows/ab7be933-239c-41fb-a907-fa76a859ed99]
|
| [3.11|https://github.com/apache/cassandra/pull/836] |
[j8|https://app.circleci.com/pipelines/github/blerer/cassandra/69/workflows/9fb4aca3-3b41-4798-a921-07b4c7026b7e]
|
| [3.0|https://github.com/apache/cassandra/pull/837] |
[j8|https://app.circleci.com/pipelines/github/blerer/cassandra/70/workflows/b0ef5b25-0a4f-4ddb-92cd-b4c76f7908ea]
|
| [2.2|https://github.com/apache/cassandra/pull/838] |
[j8|https://app.circleci.com/pipelines/github/blerer/cassandra/71/workflows/d24c6595-9c8c-4893-86e0-ef3b15966f02]
|
> tablehistograms cause ArrayIndexOutOfBoundsException
>
>
> Key: CASSANDRA-16259
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16259
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/Metrics
>Reporter: Justin Montgomery
>Assignee: Benjamin Lerer
>Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta
>
>
> After upgrading some nodes in our cluster from 3.11.8 to 3.11.9 an error
> appeared on the upgraded nodes when trying to access *tablehistograms*. The
> same command run on our .8 nodes return as expected, only the upgraded .9
> nodes fail. Not all tables fail when queried, but about 90% of them do.
> We use Datastax MCAC which appears to query histograms every 30 seconds, this
> outputs to the system.log:
> {noformat}
> WARN [insights-3-1] 2020-11-09 01:11:22,331 UnixSocketClient.java:830 -
> Error reporting:
> java.lang.ArrayIndexOutOfBoundsException: 115
> at
> org.apache.cassandra.metrics.TableMetrics.combineHistograms(TableMetrics.java:261)
> ~[apache-cassandra-3.11.9.jar:3.11.9]
> at
> org.apache.cassandra.metrics.TableMetrics.access$000(TableMetrics.java:48)
> ~[apache-cassandra-3.11.9.jar:3.11.9]
> at
> org.apache.cassandra.metrics.TableMetrics$11.getValue(TableMetrics.java:376)
> ~[apache-cassandra-3.11.9.jar:3.11.9]
> at
> org.apache.cassandra.metrics.TableMetrics$11.getValue(TableMetrics.java:373)
> ~[apache-cassandra-3.11.9.jar:3.11.9]
> at
> com.datastax.mcac.UnixSocketClient.writeMetric(UnixSocketClient.java:839)
> [datastax-mcac-agent.jar:na]
> at
> com.datastax.mcac.UnixSocketClient.access$700(UnixSocketClient.java:78)
> [datastax-mcac-agent.jar:na]
> at
> com.datastax.mcac.UnixSocketClient$2.lambda$onGaugeAdded$0(UnixSocketClient.java:626)
> ~[datastax-mcac-agent.jar:na]
> at
> com.datastax.mcac.UnixSocketClient.writeGroup(UnixSocketClient.java:819)
> [datastax-mcac-agent.jar:na]
> at
> com.datastax.mcac.UnixSocketClient.lambda$restartMetricReporting$2(UnixSocketClient.java:798)
>
[jira] [Comment Edited] (CASSANDRA-16259) tablehistograms cause ArrayIndexOutOfBoundsException
[
https://issues.apache.org/jira/browse/CASSANDRA-16259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239159#comment-17239159
]
Benjamin Lerer edited comment on CASSANDRA-16259 at 11/26/20, 9:57 AM:
---
[~rtib] Sorry, my brain was not working properly. :-(
was (Author: blerer):
@ Tibor Sorry, my brain was not working properly. :-(
> tablehistograms cause ArrayIndexOutOfBoundsException
>
>
> Key: CASSANDRA-16259
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16259
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/Metrics
>Reporter: Justin Montgomery
>Assignee: Benjamin Lerer
>Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta
>
>
> After upgrading some nodes in our cluster from 3.11.8 to 3.11.9 an error
> appeared on the upgraded nodes when trying to access *tablehistograms*. The
> same command run on our .8 nodes return as expected, only the upgraded .9
> nodes fail. Not all tables fail when queried, but about 90% of them do.
> We use Datastax MCAC which appears to query histograms every 30 seconds, this
> outputs to the system.log:
> {noformat}
> WARN [insights-3-1] 2020-11-09 01:11:22,331 UnixSocketClient.java:830 -
> Error reporting:
> java.lang.ArrayIndexOutOfBoundsException: 115
> at
> org.apache.cassandra.metrics.TableMetrics.combineHistograms(TableMetrics.java:261)
> ~[apache-cassandra-3.11.9.jar:3.11.9]
> at
> org.apache.cassandra.metrics.TableMetrics.access$000(TableMetrics.java:48)
> ~[apache-cassandra-3.11.9.jar:3.11.9]
> at
> org.apache.cassandra.metrics.TableMetrics$11.getValue(TableMetrics.java:376)
> ~[apache-cassandra-3.11.9.jar:3.11.9]
> at
> org.apache.cassandra.metrics.TableMetrics$11.getValue(TableMetrics.java:373)
> ~[apache-cassandra-3.11.9.jar:3.11.9]
> at
> com.datastax.mcac.UnixSocketClient.writeMetric(UnixSocketClient.java:839)
> [datastax-mcac-agent.jar:na]
> at
> com.datastax.mcac.UnixSocketClient.access$700(UnixSocketClient.java:78)
> [datastax-mcac-agent.jar:na]
> at
> com.datastax.mcac.UnixSocketClient$2.lambda$onGaugeAdded$0(UnixSocketClient.java:626)
> ~[datastax-mcac-agent.jar:na]
> at
> com.datastax.mcac.UnixSocketClient.writeGroup(UnixSocketClient.java:819)
> [datastax-mcac-agent.jar:na]
> at
> com.datastax.mcac.UnixSocketClient.lambda$restartMetricReporting$2(UnixSocketClient.java:798)
> [datastax-mcac-agent.jar:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[na:1.8.0_272]
> at
> io.netty.util.concurrent.ScheduledFutureTask.run(ScheduledFutureTask.java:126)
> ~[netty-all-4.0.44.Final.jar:4.0.44.Final]
> at
> io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:399)
> ~[netty-all-4.0.44.Final.jar:4.0.44.Final]
> at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:307)
> ~[netty-all-4.0.44.Final.jar:4.0.44.Final]
> at
> io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:131)
> ~[netty-all-4.0.44.Final.jar:4.0.44.Final]
> at
> io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:144)
> ~[netty-all-4.0.44.Final.jar:4.0.44.Final]
> at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_272]{noformat}
> Manually trying a histogram from the CLI:
> {noformat}
> $ nodetool tablehistograms logdata log_height_index
> error: 115
> -- StackTrace --
> java.lang.ArrayIndexOutOfBoundsException: 115
> at
> org.apache.cassandra.metrics.TableMetrics.combineHistograms(TableMetrics.java:261)
> at
> org.apache.cassandra.metrics.TableMetrics.access$000(TableMetrics.java:48)
> at
> org.apache.cassandra.metrics.TableMetrics$11.getValue(TableMetrics.java:376)
> at
> org.apache.cassandra.metrics.TableMetrics$11.getValue(TableMetrics.java:373)
> at
> org.apache.cassandra.metrics.CassandraMetricsRegistry$JmxGauge.getValue(CassandraMetricsRegistry.java:250)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at sun.reflect.misc.Trampoline.invoke(MethodUtil.java:72)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
[jira] [Commented] (CASSANDRA-16259) tablehistograms cause ArrayIndexOutOfBoundsException
[
https://issues.apache.org/jira/browse/CASSANDRA-16259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239159#comment-17239159
]
Benjamin Lerer commented on CASSANDRA-16259:
@ Tibor Sorry, my brain was not working properly. :-(
> tablehistograms cause ArrayIndexOutOfBoundsException
>
>
> Key: CASSANDRA-16259
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16259
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/Metrics
>Reporter: Justin Montgomery
>Assignee: Benjamin Lerer
>Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta
>
>
> After upgrading some nodes in our cluster from 3.11.8 to 3.11.9 an error
> appeared on the upgraded nodes when trying to access *tablehistograms*. The
> same command run on our .8 nodes return as expected, only the upgraded .9
> nodes fail. Not all tables fail when queried, but about 90% of them do.
> We use Datastax MCAC which appears to query histograms every 30 seconds, this
> outputs to the system.log:
> {noformat}
> WARN [insights-3-1] 2020-11-09 01:11:22,331 UnixSocketClient.java:830 -
> Error reporting:
> java.lang.ArrayIndexOutOfBoundsException: 115
> at
> org.apache.cassandra.metrics.TableMetrics.combineHistograms(TableMetrics.java:261)
> ~[apache-cassandra-3.11.9.jar:3.11.9]
> at
> org.apache.cassandra.metrics.TableMetrics.access$000(TableMetrics.java:48)
> ~[apache-cassandra-3.11.9.jar:3.11.9]
> at
> org.apache.cassandra.metrics.TableMetrics$11.getValue(TableMetrics.java:376)
> ~[apache-cassandra-3.11.9.jar:3.11.9]
> at
> org.apache.cassandra.metrics.TableMetrics$11.getValue(TableMetrics.java:373)
> ~[apache-cassandra-3.11.9.jar:3.11.9]
> at
> com.datastax.mcac.UnixSocketClient.writeMetric(UnixSocketClient.java:839)
> [datastax-mcac-agent.jar:na]
> at
> com.datastax.mcac.UnixSocketClient.access$700(UnixSocketClient.java:78)
> [datastax-mcac-agent.jar:na]
> at
> com.datastax.mcac.UnixSocketClient$2.lambda$onGaugeAdded$0(UnixSocketClient.java:626)
> ~[datastax-mcac-agent.jar:na]
> at
> com.datastax.mcac.UnixSocketClient.writeGroup(UnixSocketClient.java:819)
> [datastax-mcac-agent.jar:na]
> at
> com.datastax.mcac.UnixSocketClient.lambda$restartMetricReporting$2(UnixSocketClient.java:798)
> [datastax-mcac-agent.jar:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[na:1.8.0_272]
> at
> io.netty.util.concurrent.ScheduledFutureTask.run(ScheduledFutureTask.java:126)
> ~[netty-all-4.0.44.Final.jar:4.0.44.Final]
> at
> io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:399)
> ~[netty-all-4.0.44.Final.jar:4.0.44.Final]
> at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:307)
> ~[netty-all-4.0.44.Final.jar:4.0.44.Final]
> at
> io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:131)
> ~[netty-all-4.0.44.Final.jar:4.0.44.Final]
> at
> io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:144)
> ~[netty-all-4.0.44.Final.jar:4.0.44.Final]
> at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_272]{noformat}
> Manually trying a histogram from the CLI:
> {noformat}
> $ nodetool tablehistograms logdata log_height_index
> error: 115
> -- StackTrace --
> java.lang.ArrayIndexOutOfBoundsException: 115
> at
> org.apache.cassandra.metrics.TableMetrics.combineHistograms(TableMetrics.java:261)
> at
> org.apache.cassandra.metrics.TableMetrics.access$000(TableMetrics.java:48)
> at
> org.apache.cassandra.metrics.TableMetrics$11.getValue(TableMetrics.java:376)
> at
> org.apache.cassandra.metrics.TableMetrics$11.getValue(TableMetrics.java:373)
> at
> org.apache.cassandra.metrics.CassandraMetricsRegistry$JmxGauge.getValue(CassandraMetricsRegistry.java:250)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at sun.reflect.misc.Trampoline.invoke(MethodUtil.java:72)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at sun.reflect.misc.MethodUtil.invoke(MethodUtil.java:276)
> at
>
[jira] [Assigned] (CASSANDRA-16299) org.apache.cassandra.streaming.LongStreamingTest fail with NPE
[
https://issues.apache.org/jira/browse/CASSANDRA-16299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Lerer reassigned CASSANDRA-16299:
--
Assignee: (was: Benjamin Lerer)
> org.apache.cassandra.streaming.LongStreamingTest fail with NPE
> --
>
> Key: CASSANDRA-16299
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16299
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Commit Log
>Reporter: Benjamin Lerer
>Priority: Normal
>
> {code}
> java.lang.NullPointerException
> at
> org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager.awaitTermination(AbstractCommitLogSegmentManager.java:509)
> at
> org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager.stopUnsafe(AbstractCommitLogSegmentManager.java:427)
> at
> org.apache.cassandra.db.commitlog.CommitLog.stopUnsafe(CommitLog.java:467)
> at
> org.apache.cassandra.SchemaLoader.cleanupAndLeaveDirs(SchemaLoader.java:731)
> at
> org.apache.cassandra.streaming.LongStreamingTest.setup(LongStreamingTest.java:56)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16299) org.apache.cassandra.streaming.LongStreamingTest fail with NPE
[
https://issues.apache.org/jira/browse/CASSANDRA-16299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Lerer updated CASSANDRA-16299:
---
Resolution: Duplicate
Status: Resolved (was: Triage Needed)
> org.apache.cassandra.streaming.LongStreamingTest fail with NPE
> --
>
> Key: CASSANDRA-16299
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16299
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Commit Log
>Reporter: Benjamin Lerer
>Assignee: Benjamin Lerer
>Priority: Normal
>
> {code}
> java.lang.NullPointerException
> at
> org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager.awaitTermination(AbstractCommitLogSegmentManager.java:509)
> at
> org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager.stopUnsafe(AbstractCommitLogSegmentManager.java:427)
> at
> org.apache.cassandra.db.commitlog.CommitLog.stopUnsafe(CommitLog.java:467)
> at
> org.apache.cassandra.SchemaLoader.cleanupAndLeaveDirs(SchemaLoader.java:731)
> at
> org.apache.cassandra.streaming.LongStreamingTest.setup(LongStreamingTest.java:56)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16301) upgrade from C* 3.11.9 to 4.0-beta3 fails if 3.11.9 is configured with OldNetworkTopologyStrategy
[
https://issues.apache.org/jira/browse/CASSANDRA-16301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239153#comment-17239153
]
Benjamin Lerer commented on CASSANDRA-16301:
I pushed a patch to fix those things
[here|https://github.com/apache/cassandra/pull/834] (CI results are
[here|https://app.circleci.com/pipelines/github/blerer/cassandra/73/workflows/f92486d6-a133-4829-b05c-65eb359cad4e].
[~flightc] Tell me if it looks good to you.
> upgrade from C* 3.11.9 to 4.0-beta3 fails if 3.11.9 is configured with
> OldNetworkTopologyStrategy
> -
>
> Key: CASSANDRA-16301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16301
> Project: Cassandra
> Issue Type: Bug
>Reporter: Yongle Zhang
>Assignee: Erick Ramirez
>Priority: Normal
>
> When we upgrade Cassandra from 3.11.9 to 4.0-beta3, if the old cluster
> (3.11.9) is configured with OldNetworkTopologyStrategy, 4.0-beta3 Cassandra
> fails to start with the following exception:
>
> {code:java}
> ERROR [main] 2020-11-24 22:49:33,423 CassandraDaemon.java:278 - Error while
> loading schema:
> org.apache.cassandra.exceptions.ConfigurationException: Unable to find
> replication strategy class
> 'org.apache.cassandra.locator.OldNetworkTopologyStrategy'
> at
> org.apache.cassandra.utils.FBUtilities.classForName(FBUtilities.java:720)
> at
> org.apache.cassandra.locator.AbstractReplicationStrategy.getClass(AbstractReplicationStrategy.java:422)
> at
> org.apache.cassandra.schema.ReplicationParams.fromMapWithDefaults(ReplicationParams.java:90)
> at
> org.apache.cassandra.schema.ReplicationParams.fromMap(ReplicationParams.java:82)
> at
> org.apache.cassandra.schema.KeyspaceParams.create(KeyspaceParams.java:64)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspaceParams(SchemaKeyspace.java:971)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspace(SchemaKeyspace.java:956)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspacesWithout(SchemaKeyspace.java:949)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchNonSystemKeyspaces(SchemaKeyspace.java:859)
> at org.apache.cassandra.schema.Schema.loadFromDisk(Schema.java:100)
> at org.apache.cassandra.schema.Schema.loadFromDisk(Schema.java:89)
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:274)
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:671)
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:795)
> Caused by: java.lang.ClassNotFoundException:
> org.apache.cassandra.locator.OldNetworkTopologyStrategy
> at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
> at java.lang.Class.forName0(Native Method)
> at java.lang.Class.forName(Class.java:264)
> at
> org.apache.cassandra.utils.FBUtilities.classForName(FBUtilities.java:716)
> ... 13 common frames omitted
> Exception (org.apache.cassandra.exceptions.ConfigurationException)
> encountered during startup: Unable to find replication strategy class
> 'org.apache.cassandra.locator.OldNetworkTopologyStrategy'{code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16301) upgrade from C* 3.11.9 to 4.0-beta3 fails if 3.11.9 is configured with OldNetworkTopologyStrategy
[
https://issues.apache.org/jira/browse/CASSANDRA-16301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Lerer updated CASSANDRA-16301:
---
Resolution: (was: Not A Problem)
Status: Open (was: Resolved)
> upgrade from C* 3.11.9 to 4.0-beta3 fails if 3.11.9 is configured with
> OldNetworkTopologyStrategy
> -
>
> Key: CASSANDRA-16301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16301
> Project: Cassandra
> Issue Type: Bug
>Reporter: Yongle Zhang
>Assignee: Erick Ramirez
>Priority: Normal
>
> When we upgrade Cassandra from 3.11.9 to 4.0-beta3, if the old cluster
> (3.11.9) is configured with OldNetworkTopologyStrategy, 4.0-beta3 Cassandra
> fails to start with the following exception:
>
> {code:java}
> ERROR [main] 2020-11-24 22:49:33,423 CassandraDaemon.java:278 - Error while
> loading schema:
> org.apache.cassandra.exceptions.ConfigurationException: Unable to find
> replication strategy class
> 'org.apache.cassandra.locator.OldNetworkTopologyStrategy'
> at
> org.apache.cassandra.utils.FBUtilities.classForName(FBUtilities.java:720)
> at
> org.apache.cassandra.locator.AbstractReplicationStrategy.getClass(AbstractReplicationStrategy.java:422)
> at
> org.apache.cassandra.schema.ReplicationParams.fromMapWithDefaults(ReplicationParams.java:90)
> at
> org.apache.cassandra.schema.ReplicationParams.fromMap(ReplicationParams.java:82)
> at
> org.apache.cassandra.schema.KeyspaceParams.create(KeyspaceParams.java:64)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspaceParams(SchemaKeyspace.java:971)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspace(SchemaKeyspace.java:956)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspacesWithout(SchemaKeyspace.java:949)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchNonSystemKeyspaces(SchemaKeyspace.java:859)
> at org.apache.cassandra.schema.Schema.loadFromDisk(Schema.java:100)
> at org.apache.cassandra.schema.Schema.loadFromDisk(Schema.java:89)
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:274)
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:671)
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:795)
> Caused by: java.lang.ClassNotFoundException:
> org.apache.cassandra.locator.OldNetworkTopologyStrategy
> at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
> at java.lang.Class.forName0(Native Method)
> at java.lang.Class.forName(Class.java:264)
> at
> org.apache.cassandra.utils.FBUtilities.classForName(FBUtilities.java:716)
> ... 13 common frames omitted
> Exception (org.apache.cassandra.exceptions.ConfigurationException)
> encountered during startup: Unable to find replication strategy class
> 'org.apache.cassandra.locator.OldNetworkTopologyStrategy'{code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16301) upgrade from C* 3.11.9 to 4.0-beta3 fails if 3.11.9 is configured with OldNetworkTopologyStrategy
[
https://issues.apache.org/jira/browse/CASSANDRA-16301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239138#comment-17239138
]
Benjamin Lerer commented on CASSANDRA-16301:
[~flightc] I had a quick look to CASSANDRA-13990. It does not seems that we
mention anything in the NEWS.txt in the upgrade section. We could also provide
an error message which is more user friendly.
> upgrade from C* 3.11.9 to 4.0-beta3 fails if 3.11.9 is configured with
> OldNetworkTopologyStrategy
> -
>
> Key: CASSANDRA-16301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16301
> Project: Cassandra
> Issue Type: Bug
>Reporter: Yongle Zhang
>Assignee: Erick Ramirez
>Priority: Normal
>
> When we upgrade Cassandra from 3.11.9 to 4.0-beta3, if the old cluster
> (3.11.9) is configured with OldNetworkTopologyStrategy, 4.0-beta3 Cassandra
> fails to start with the following exception:
>
> {code:java}
> ERROR [main] 2020-11-24 22:49:33,423 CassandraDaemon.java:278 - Error while
> loading schema:
> org.apache.cassandra.exceptions.ConfigurationException: Unable to find
> replication strategy class
> 'org.apache.cassandra.locator.OldNetworkTopologyStrategy'
> at
> org.apache.cassandra.utils.FBUtilities.classForName(FBUtilities.java:720)
> at
> org.apache.cassandra.locator.AbstractReplicationStrategy.getClass(AbstractReplicationStrategy.java:422)
> at
> org.apache.cassandra.schema.ReplicationParams.fromMapWithDefaults(ReplicationParams.java:90)
> at
> org.apache.cassandra.schema.ReplicationParams.fromMap(ReplicationParams.java:82)
> at
> org.apache.cassandra.schema.KeyspaceParams.create(KeyspaceParams.java:64)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspaceParams(SchemaKeyspace.java:971)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspace(SchemaKeyspace.java:956)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchKeyspacesWithout(SchemaKeyspace.java:949)
> at
> org.apache.cassandra.schema.SchemaKeyspace.fetchNonSystemKeyspaces(SchemaKeyspace.java:859)
> at org.apache.cassandra.schema.Schema.loadFromDisk(Schema.java:100)
> at org.apache.cassandra.schema.Schema.loadFromDisk(Schema.java:89)
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:274)
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:671)
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:795)
> Caused by: java.lang.ClassNotFoundException:
> org.apache.cassandra.locator.OldNetworkTopologyStrategy
> at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
> at java.lang.Class.forName0(Native Method)
> at java.lang.Class.forName(Class.java:264)
> at
> org.apache.cassandra.utils.FBUtilities.classForName(FBUtilities.java:716)
> ... 13 common frames omitted
> Exception (org.apache.cassandra.exceptions.ConfigurationException)
> encountered during startup: Unable to find replication strategy class
> 'org.apache.cassandra.locator.OldNetworkTopologyStrategy'{code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
