[jira] [Created] (CASSANDRA-16907) Fix ivm-upgrade test org.apache.cassandra.distributed.upgrade.CompactStorageUpgradeTest: compactStorageHiddenColumnTest
David Capwell created CASSANDRA-16907: - Summary: Fix ivm-upgrade test org.apache.cassandra.distributed.upgrade.CompactStorageUpgradeTest: compactStorageHiddenColumnTest Key: CASSANDRA-16907 URL: https://issues.apache.org/jira/browse/CASSANDRA-16907 Project: Cassandra Issue Type: Bug Components: Test/dtest/java Reporter: David Capwell https://app.circleci.com/pipelines/github/dcapwell/cassandra/1017/workflows/3a1caaca-b213-4841-b010-cdcdde73df0b/jobs/6450 This test has been failing for a while -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16907) Fix ivm-upgrade test org.apache.cassandra.distributed.upgrade.CompactStorageUpgradeTest: compactStorageHiddenColumnTest
[ https://issues.apache.org/jira/browse/CASSANDRA-16907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-16907: -- Bug Category: Parent values: Correctness(12982)Level 1 values: Test Failure(12990) Complexity: Low Hanging Fruit Discovered By: Unit Test Fix Version/s: 4.1 Severity: Normal Status: Open (was: Triage Needed) > Fix ivm-upgrade test > org.apache.cassandra.distributed.upgrade.CompactStorageUpgradeTest: > compactStorageHiddenColumnTest > --- > > Key: CASSANDRA-16907 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16907 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/java >Reporter: David Capwell >Priority: Normal > Fix For: 4.1 > > > https://app.circleci.com/pipelines/github/dcapwell/cassandra/1017/workflows/3a1caaca-b213-4841-b010-cdcdde73df0b/jobs/6450 > This test has been failing for a while -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16896) Add soft/hard limits to local reads to protect against reading too much data in a single query
[ https://issues.apache.org/jira/browse/CASSANDRA-16896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407726#comment-17407726 ] David Capwell commented on CASSANDRA-16896: --- good amount of red tests, but sadly those are known issues tests are passing > Add soft/hard limits to local reads to protect against reading too much data > in a single query > -- > > Key: CASSANDRA-16896 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16896 > Project: Cassandra > Issue Type: New Feature > Components: Legacy/Local Write-Read Paths >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.1 > > > Add soft/hard limits to local reads to protect against reading too much data > in a single query. > This is an extension of the existing work to add warnings/aborts to large > partitions (CASSANDRA-16850), with the core difference is that this applies > locally rather than at the coordinator. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16175) Avoid removing batch when it's not created during view replication
[ https://issues.apache.org/jira/browse/CASSANDRA-16175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-16175: Test and Documentation Plan: https://issues.apache.org/jira/browse/CASSANDRA-16175?focusedCommentId=17407713=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17407713 Status: Patch Available (was: In Progress) > Avoid removing batch when it's not created during view replication > -- > > Key: CASSANDRA-16175 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16175 > Project: Cassandra > Issue Type: Bug > Components: Feature/Materialized Views >Reporter: Zhao Yang >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.x > > > When the base replica is also a view replica we don't write a local batchlog, > but they are unnecessarily removed when the view write is successful, what > creates (and persists) a tombstone into the system.batches table. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16175) Avoid removing batch when it's not created during view replication
[ https://issues.apache.org/jira/browse/CASSANDRA-16175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407713#comment-17407713 ] Ekaterina Dimitrova commented on CASSANDRA-16175: - The issue was initially raised to be fixed for 4.x and I ported below a patch from [~jasonstack], CI started ||Patch||CI|| | [trunk|https://github.com/apache/cassandra/compare/trunk...ekaterinadimitrova2:16175-trunk?expand=1] | [Jenkins dev run | https://jenkins-cm4.apache.org/job/Cassandra-devbranch/1089/] | I personally think we can port the patch also to 3.0, 3.11 and 4.0 so I did it. CI can be run for all branches pre-commit when we confirm the versions which will be fixed. ||Patch|| |[3.0|https://github.com/ekaterinadimitrova2/cassandra/pull/new/16175-3.0]| |[3.11|https://github.com/ekaterinadimitrova2/cassandra/pull/new/16175-3.11]| |[4.0|https://github.com/ekaterinadimitrova2/cassandra/pull/new/16175-4.0]| > Avoid removing batch when it's not created during view replication > -- > > Key: CASSANDRA-16175 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16175 > Project: Cassandra > Issue Type: Bug > Components: Feature/Materialized Views >Reporter: Zhao Yang >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.x > > > When the base replica is also a view replica we don't write a local batchlog, > but they are unnecessarily removed when the view write is successful, what > creates (and persists) a tombstone into the system.batches table. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16883) Weak visibility guarantees of Accumulator can lead to failure to recognize digest mismatches
[
https://issues.apache.org/jira/browse/CASSANDRA-16883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-16883:
Since Version: 3.0.0
Source Control Link:
https://github.com/apache/cassandra/commit/f9d41ff83655ead37ac6083d7ee43f2c35a346da
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
Committed as
https://github.com/apache/cassandra/commit/f9d41ff83655ead37ac6083d7ee43f2c35a346da
to {{cassandra-3.0}}.
> Weak visibility guarantees of Accumulator can lead to failure to recognize
> digest mismatches
>
>
> Key: CASSANDRA-16883
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16883
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Coordination
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 3.0.26, 3.11.12
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The context for this problem is largely the same as CASSANDRA-16807. The
> difference is that for 4.0+, CASSANDRA-16097 added an assertion to
> {{DigestResolver#responseMatch()}} that ensures the responses snapshot has at
> least one visible element (although of course only one element trivially
> cannot generate a mismatch and short-circuits immediately). In 3.0 and 3.11,
> this assertion does not exist, and when the underlying problem occurs (i.e.
> zero responses are visible on {{Accumulator}} when there should be 2), we can
> silently avoid the digest matching entirely. This seems like it would make it
> both impossible to do a potentially necessary full data read to resolve the
> correct response and prevent repair.
> The fix here should be similar to the one in CASSANDRA-16807, although there
> might be some test infrastructure that needs porting in order to make that
> work.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.11' into cassandra-4.0
This is an automated email from the ASF dual-hosted git repository. maedhroz pushed a commit to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 46a740cf61204e481a175db9057a4e0e3168aad4 Merge: ca4f6b8 e562118 Author: Caleb Rackliffe AuthorDate: Tue Aug 31 16:34:30 2021 -0500 Merge branch 'cassandra-3.11' into cassandra-4.0 - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.0 updated: Avoid signaling DigestResolver until the minimum number of responses are guaranteed to be visible
This is an automated email from the ASF dual-hosted git repository.
maedhroz pushed a commit to branch cassandra-3.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-3.0 by this push:
new f9d41ff Avoid signaling DigestResolver until the minimum number of
responses are guaranteed to be visible
f9d41ff is described below
commit f9d41ff83655ead37ac6083d7ee43f2c35a346da
Author: Caleb Rackliffe
AuthorDate: Tue Aug 24 14:42:24 2021 -0500
Avoid signaling DigestResolver until the minimum number of responses are
guaranteed to be visible
patch by Caleb Rackliffe; reviewed by Jon Meredith for CASSANDRA-16883
---
CHANGES.txt| 1 +
.../apache/cassandra/service/DigestResolver.java | 8 +-
.../org/apache/cassandra/service/ReadCallback.java | 13 +-
.../service/reads/DigestResolverTest.java | 164 +
4 files changed, 180 insertions(+), 6 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index 9089836..434c1d2 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
3.0.26:
+ * Avoid signaling DigestResolver until the minimum number of responses are
guaranteed to be visible (CASSANDRA-16883)
* Fix secondary indexes on primary key columns skipping some writes
(CASSANDRA-16868)
* Fix incorrect error message in LegacyLayout (CASSANDRA-15136)
* Use JMX to validate nodetool --jobs parameter (CASSANDRA-16104)
diff --git a/src/java/org/apache/cassandra/service/DigestResolver.java
b/src/java/org/apache/cassandra/service/DigestResolver.java
index 6a528e9..21db1ce 100644
--- a/src/java/org/apache/cassandra/service/DigestResolver.java
+++ b/src/java/org/apache/cassandra/service/DigestResolver.java
@@ -63,11 +63,15 @@ public class DigestResolver extends ResponseResolver
*/
public PartitionIterator resolve() throws DigestMismatchException
{
-if (responses.size() == 1)
+int responseCount = responses.size();
+
+assert responseCount > 0 : "Attempted response match comparison while
no responses have been received.";
+
+if (responseCount == 1)
return getData();
if (logger.isTraceEnabled())
-logger.trace("resolving {} responses", responses.size());
+logger.trace("resolving {} responses", responseCount);
compareResponses();
diff --git a/src/java/org/apache/cassandra/service/ReadCallback.java
b/src/java/org/apache/cassandra/service/ReadCallback.java
index 837ab5e..4dc7b8d 100644
--- a/src/java/org/apache/cassandra/service/ReadCallback.java
+++ b/src/java/org/apache/cassandra/service/ReadCallback.java
@@ -158,7 +158,14 @@ public class ReadCallback implements
IAsyncCallbackWithFailure
int n = waitingFor(message.from)
? recievedUpdater.incrementAndGet(this)
: received;
-if (n >= blockfor && resolver.isDataPresent())
+
+/*
+ * Ensure that data is present and the response accumulator has
properly published the
+ * responses it has received. This may result in not signaling
immediately when we receive
+ * the minimum number of required results, but it guarantees at least
the minimum will
+ * be accessible when we do signal. (see rdar://77320313)
+ */
+if (n >= blockfor && resolver.responses.size() >= blockfor &&
resolver.isDataPresent())
{
condition.signalAll();
// kick off a background digest comparison if this is a result
that (may have) arrived after
@@ -178,9 +185,7 @@ public class ReadCallback implements
IAsyncCallbackWithFailure
*/
private boolean waitingFor(InetAddress from)
{
-return consistencyLevel.isDatacenterLocal()
- ?
DatabaseDescriptor.getLocalDataCenter().equals(DatabaseDescriptor.getEndpointSnitch().getDatacenter(from))
- : true;
+return !consistencyLevel.isDatacenterLocal() ||
DatabaseDescriptor.getLocalDataCenter().equals(DatabaseDescriptor.getEndpointSnitch().getDatacenter(from));
}
/**
diff --git
a/test/unit/org/apache/cassandra/service/reads/DigestResolverTest.java
b/test/unit/org/apache/cassandra/service/reads/DigestResolverTest.java
new file mode 100644
index 000..d246a83
--- /dev/null
+++ b/test/unit/org/apache/cassandra/service/reads/DigestResolverTest.java
@@ -0,0 +1,164 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable
[cassandra] branch cassandra-3.11 updated (1038f44 -> e562118)
This is an automated email from the ASF dual-hosted git repository. maedhroz pushed a change to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 1038f44 Remove duplicate 'lib.download.sha' entries in build-resolver.xml new f9d41ff Avoid signaling DigestResolver until the minimum number of responses are guaranteed to be visible new e562118 Merge branch 'cassandra-3.0' into cassandra-3.11 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + .../apache/cassandra/service/DigestResolver.java | 8 +- .../org/apache/cassandra/service/ReadCallback.java | 13 +- .../service/reads/DigestResolverTest.java | 164 + 4 files changed, 180 insertions(+), 6 deletions(-) create mode 100644 test/unit/org/apache/cassandra/service/reads/DigestResolverTest.java - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (4e0d8e0 -> a74b44a)
This is an automated email from the ASF dual-hosted git repository. maedhroz pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 4e0d8e0 Merge branch 'cassandra-4.0' into trunk new f9d41ff Avoid signaling DigestResolver until the minimum number of responses are guaranteed to be visible new e562118 Merge branch 'cassandra-3.0' into cassandra-3.11 new 46a740c Merge branch 'cassandra-3.11' into cassandra-4.0 new a74b44a Merge branch 'cassandra-4.0' into trunk The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.0' into trunk
This is an automated email from the ASF dual-hosted git repository. maedhroz pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit a74b44ac8abab045ee0615db7acd6bc229bbe6b7 Merge: 4e0d8e0 46a740c Author: Caleb Rackliffe AuthorDate: Tue Aug 31 16:38:48 2021 -0500 Merge branch 'cassandra-4.0' into trunk - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0 updated (ca4f6b8 -> 46a740c)
This is an automated email from the ASF dual-hosted git repository. maedhroz pushed a change to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from ca4f6b8 org.apache.cassandra.db.rows.ArrayCell#unsharedHeapSizeExcludingData includes data twice new f9d41ff Avoid signaling DigestResolver until the minimum number of responses are guaranteed to be visible new e562118 Merge branch 'cassandra-3.0' into cassandra-3.11 new 46a740c Merge branch 'cassandra-3.11' into cassandra-4.0 The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.0' into cassandra-3.11
This is an automated email from the ASF dual-hosted git repository.
maedhroz pushed a commit to branch cassandra-3.11
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit e5621184d86ac0c8d0c9870786c44baaadfb446a
Merge: 1038f44 f9d41ff
Author: Caleb Rackliffe
AuthorDate: Tue Aug 31 16:24:27 2021 -0500
Merge branch 'cassandra-3.0' into cassandra-3.11
CHANGES.txt| 1 +
.../apache/cassandra/service/DigestResolver.java | 8 +-
.../org/apache/cassandra/service/ReadCallback.java | 13 +-
.../service/reads/DigestResolverTest.java | 164 +
4 files changed, 180 insertions(+), 6 deletions(-)
diff --cc CHANGES.txt
index aa0ad38,434c1d2..3f7c23a
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,11 -1,5 +1,12 @@@
-3.0.26:
+3.11.12
+ * Exclude Jackson 1.x transitive dependency of hadoop* provided dependencies
(CASSANDRA-16854)
+ * Validate SASI tokenizer options before adding index to schema
(CASSANDRA-15135)
+ * Fixup scrub output when no data post-scrub and clear up old use of row,
which really means partition (CASSANDRA-16835)
+ * Fix ant-junit dependency issue (CASSANDRA-16827)
+ * Reduce thread contention in CommitLogSegment and HintsBuffer
(CASSANDRA-16072)
+ * Avoid sending CDC column if not enabled (CASSANDRA-16770)
+Merged from 3.0:
+ * Avoid signaling DigestResolver until the minimum number of responses are
guaranteed to be visible (CASSANDRA-16883)
* Fix secondary indexes on primary key columns skipping some writes
(CASSANDRA-16868)
* Fix incorrect error message in LegacyLayout (CASSANDRA-15136)
* Use JMX to validate nodetool --jobs parameter (CASSANDRA-16104)
diff --cc test/unit/org/apache/cassandra/service/reads/DigestResolverTest.java
index 000,d246a83..dd97aaa
mode 00,100644..100644
--- a/test/unit/org/apache/cassandra/service/reads/DigestResolverTest.java
+++ b/test/unit/org/apache/cassandra/service/reads/DigestResolverTest.java
@@@ -1,0 -1,164 +1,164 @@@
+ /*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+ package org.apache.cassandra.service.reads;
+
+ import java.net.UnknownHostException;
+ import java.util.concurrent.CountDownLatch;
+ import java.util.concurrent.ExecutorService;
+ import java.util.concurrent.Executors;
+ import java.util.concurrent.TimeUnit;
+
+ import com.google.common.collect.ImmutableList;
+ import org.junit.BeforeClass;
+ import org.junit.Test;
+
+ import org.apache.cassandra.SchemaLoader;
+ import org.apache.cassandra.Util;
+ import org.apache.cassandra.config.CFMetaData;
+ import org.apache.cassandra.config.DatabaseDescriptor;
+ import org.apache.cassandra.db.*;
+ import org.apache.cassandra.db.marshal.AsciiType;
+ import org.apache.cassandra.db.marshal.BytesType;
+ import org.apache.cassandra.db.partitions.PartitionIterator;
+ import org.apache.cassandra.db.partitions.PartitionUpdate;
+ import
org.apache.cassandra.db.partitions.SingletonUnfilteredPartitionIterator;
+ import org.apache.cassandra.db.partitions.UnfilteredPartitionIterator;
+ import org.apache.cassandra.db.rows.*;
+ import org.apache.cassandra.dht.Murmur3Partitioner;
+ import org.apache.cassandra.locator.InetAddressAndPort;
+ import org.apache.cassandra.schema.KeyspaceParams;
+ import org.apache.cassandra.service.DigestMismatchException;
+ import org.apache.cassandra.service.DigestResolver;
+ import org.apache.cassandra.service.ReadCallback;
+ import org.apache.cassandra.utils.FBUtilities;
+
+ import static org.apache.cassandra.utils.ByteBufferUtil.bytes;
+ import static org.junit.Assert.assertTrue;
+
+ public class DigestResolverTest
+ {
+ public static final String KEYSPACE1 = "DigestResolverTest";
+ public static final String CF_STANDARD = "Standard1";
+
+ private static Keyspace ks;
+ private static CFMetaData cfm;
+
+ private static final InetAddressAndPort EP1;
+ private static final InetAddressAndPort EP2;
+
+ static
+ {
+ try
+ {
+ EP1 = InetAddressAndPort.getByName("127.0.0.1");
+ EP2 = InetAddressAndPort.getByName("127.0.0.2");
+ }
+ catch (UnknownHostException e)
+ {
+ throw new
[jira] [Updated] (CASSANDRA-16883) Weak visibility guarantees of Accumulator can lead to failure to recognize digest mismatches
[
https://issues.apache.org/jira/browse/CASSANDRA-16883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-16883:
Fix Version/s: (was: 3.11.x)
(was: 3.0.x)
3.11.12
3.0.26
> Weak visibility guarantees of Accumulator can lead to failure to recognize
> digest mismatches
>
>
> Key: CASSANDRA-16883
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16883
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Coordination
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 3.0.26, 3.11.12
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The context for this problem is largely the same as CASSANDRA-16807. The
> difference is that for 4.0+, CASSANDRA-16097 added an assertion to
> {{DigestResolver#responseMatch()}} that ensures the responses snapshot has at
> least one visible element (although of course only one element trivially
> cannot generate a mismatch and short-circuits immediately). In 3.0 and 3.11,
> this assertion does not exist, and when the underlying problem occurs (i.e.
> zero responses are visible on {{Accumulator}} when there should be 2), we can
> silently avoid the digest matching entirely. This seems like it would make it
> both impossible to do a potentially necessary full data read to resolve the
> correct response and prevent repair.
> The fix here should be similar to the one in CASSANDRA-16807, although there
> might be some test infrastructure that needs porting in order to make that
> work.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16896) Add soft/hard limits to local reads to protect against reading too much data in a single query
[ https://issues.apache.org/jira/browse/CASSANDRA-16896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caleb Rackliffe updated CASSANDRA-16896: Reviewers: Caleb Rackliffe Status: Review In Progress (was: Patch Available) > Add soft/hard limits to local reads to protect against reading too much data > in a single query > -- > > Key: CASSANDRA-16896 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16896 > Project: Cassandra > Issue Type: New Feature > Components: Legacy/Local Write-Read Paths >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.1 > > > Add soft/hard limits to local reads to protect against reading too much data > in a single query. > This is an extension of the existing work to add warnings/aborts to large > partitions (CASSANDRA-16850), with the core difference is that this applies > locally rather than at the coordinator. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14309) Make hint window persistent across restarts
[
https://issues.apache.org/jira/browse/CASSANDRA-14309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407654#comment-17407654
]
Stefan Miklosovic commented on CASSANDRA-14309:
---
I have incorporated the above-mentioned logic into the same branch.
PR: https://github.com/instaclustr/cassandra/tree/CASSANDRA-14309
build:
[https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/1086]
There is one not-so-obvious modification of the code I did upon Mick's review.
The problem was that the map of the earliest hints for hosts in HintBuffer was
growing without any boundary because this buffer (buffers) is/are reused but we
have never removed anything from there.
I am removing these entries after HintStore is closed upon flushing. I would
advice a reader to dig deeper in the logic of hints to understand the problem
presented and its solution I provide.
> Make hint window persistent across restarts
> ---
>
> Key: CASSANDRA-14309
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14309
> Project: Cassandra
> Issue Type: Improvement
> Components: Consistency/Hints
>Reporter: Kurt Greaves
>Assignee: Stefan Miklosovic
>Priority: Low
> Fix For: 4.1
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The current hint system stores a window of hints as defined by
> {{max_hint_window_in_ms}}, however this window is not persistent across
> restarts.
> Examples (cluster with RF=3 and 3 nodes, A, B, and C):
> # A goes down
> # X ms of hints are stored for A on B and C
> # A is restarted
> # A goes down again without hints replaying from B and C
> # B and C will store up to another {{max_hint_window_in_ms}} of hints for A
>
> # A goes down
> # X ms of hints are stored for A on B and C
> # B is restarted
> # B will store up to another {{max_hint_window_in_ms}} of hints for A
>
> Note that in both these scenarios they can continue forever. If A or B keeps
> getting restarted hints will continue to pile up.
>
> Idea of this ticket is to stop this behaviour from happening and only ever
> store up to {{max_hint_window_in_ms}} of hints for a particular node.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16851) Update from Jackson 2.9 to 2.12
[ https://issues.apache.org/jira/browse/CASSANDRA-16851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-16851: - Reviewers: Brandon Williams, Ekaterina Dimitrova, Michael Semb Wever (was: Ekaterina Dimitrova, Michael Semb Wever) > Update from Jackson 2.9 to 2.12 > --- > > Key: CASSANDRA-16851 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16851 > Project: Cassandra > Issue Type: Improvement > Components: Dependencies >Reporter: Tatu Saloranta >Assignee: Tatu Saloranta >Priority: Normal > Time Spent: 3h 40m > Remaining Estimate: 0h > > Given that Jackson 2.9 support has ended, it would be good to move at least > to the next minor version (2.10, patch 2.10.5) or later – latest stable being > 2.12.4. > I can test to see if anything breaks, but looking at existing Jackson usage > there shouldn't be many issues. > Assuming upgrade is acceptable there's the question of which branches to > apply it to; I will first test it against 4.0. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16851) Update from Jackson 2.9 to 2.12
[ https://issues.apache.org/jira/browse/CASSANDRA-16851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407645#comment-17407645 ] Tatu Saloranta commented on CASSANDRA-16851: Ok good, this makes sense. > Update from Jackson 2.9 to 2.12 > --- > > Key: CASSANDRA-16851 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16851 > Project: Cassandra > Issue Type: Improvement > Components: Dependencies >Reporter: Tatu Saloranta >Assignee: Tatu Saloranta >Priority: Normal > Time Spent: 3h 40m > Remaining Estimate: 0h > > Given that Jackson 2.9 support has ended, it would be good to move at least > to the next minor version (2.10, patch 2.10.5) or later – latest stable being > 2.12.4. > I can test to see if anything breaks, but looking at existing Jackson usage > there shouldn't be many issues. > Assuming upgrade is acceptable there's the question of which branches to > apply it to; I will first test it against 4.0. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16851) Update from Jackson 2.9 to 2.12
[ https://issues.apache.org/jira/browse/CASSANDRA-16851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-16851: Status: Review In Progress (was: Needs Committer) > Update from Jackson 2.9 to 2.12 > --- > > Key: CASSANDRA-16851 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16851 > Project: Cassandra > Issue Type: Improvement > Components: Dependencies >Reporter: Tatu Saloranta >Assignee: Tatu Saloranta >Priority: Normal > Time Spent: 3h 40m > Remaining Estimate: 0h > > Given that Jackson 2.9 support has ended, it would be good to move at least > to the next minor version (2.10, patch 2.10.5) or later – latest stable being > 2.12.4. > I can test to see if anything breaks, but looking at existing Jackson usage > there shouldn't be many issues. > Assuming upgrade is acceptable there's the question of which branches to > apply it to; I will first test it against 4.0. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16851) Update from Jackson 2.9 to 2.12
[ https://issues.apache.org/jira/browse/CASSANDRA-16851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407639#comment-17407639 ] Ekaterina Dimitrova commented on CASSANDRA-16851: - In general that is what it means but also we need to compare with the recent post-commit builds; this comparison is to the recent dev builds which sometimes can be confusing if someone was testing patch in progress. That is not the case here though. I am also +1 > Update from Jackson 2.9 to 2.12 > --- > > Key: CASSANDRA-16851 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16851 > Project: Cassandra > Issue Type: Improvement > Components: Dependencies >Reporter: Tatu Saloranta >Assignee: Tatu Saloranta >Priority: Normal > Time Spent: 3h 40m > Remaining Estimate: 0h > > Given that Jackson 2.9 support has ended, it would be good to move at least > to the next minor version (2.10, patch 2.10.5) or later – latest stable being > 2.12.4. > I can test to see if anything breaks, but looking at existing Jackson usage > there shouldn't be many issues. > Assuming upgrade is acceptable there's the question of which branches to > apply it to; I will first test it against 4.0. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16851) Update from Jackson 2.9 to 2.12
[ https://issues.apache.org/jira/browse/CASSANDRA-16851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407632#comment-17407632 ] Brandon Williams commented on CASSANDRA-16851: -- The '-1' is the only thing to be concerned with, one less test failed on your run than others...if it's positive, that's bad. The failing tests all look to be known existing issues, so +1. > Update from Jackson 2.9 to 2.12 > --- > > Key: CASSANDRA-16851 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16851 > Project: Cassandra > Issue Type: Improvement > Components: Dependencies >Reporter: Tatu Saloranta >Assignee: Tatu Saloranta >Priority: Normal > Time Spent: 3h 40m > Remaining Estimate: 0h > > Given that Jackson 2.9 support has ended, it would be good to move at least > to the next minor version (2.10, patch 2.10.5) or later – latest stable being > 2.12.4. > I can test to see if anything breaks, but looking at existing Jackson usage > there shouldn't be many issues. > Assuming upgrade is acceptable there's the question of which branches to > apply it to; I will first test it against 4.0. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16851) Update from Jackson 2.9 to 2.12
[ https://issues.apache.org/jira/browse/CASSANDRA-16851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407621#comment-17407621 ] Tatu Saloranta commented on CASSANDRA-16851: Looks like above test summary says: "[Test Result|https://ci-cassandra.apache.org/job/Cassandra-devbranch/1082/testReport/] (7 failures / -1)". Not 100% sure if it means that there is one less failure from baseline (recent runs), or something else. Failed tests: !https://ci-cassandra.apache.org/static/c0f8b409/images/16x16/document_add.png! [org.apache.cassandra.distributed.upgrade.CompactStorageUpgradeTest.compactStorageUpgradeTest|https://ci-cassandra.apache.org/job/Cassandra-devbranch/1082/testReport/org.apache.cassandra.distributed.upgrade/CompactStorageUpgradeTest/compactStorageUpgradeTest/] 6.9 sec [1|https://ci-cassandra.apache.org/job/Cassandra-devbranch/1082/] !https://ci-cassandra.apache.org/static/c0f8b409/images/16x16/document_add.png! [org.apache.cassandra.distributed.test.OptimiseStreamsRepairTest.randomTest|https://ci-cassandra.apache.org/job/Cassandra-devbranch/1082/testReport/org.apache.cassandra.distributed.test/OptimiseStreamsRepairTest/randomTest/] 37 sec [1|https://ci-cassandra.apache.org/job/Cassandra-devbranch/1082/] !https://ci-cassandra.apache.org/static/c0f8b409/images/16x16/document_add.png! [org.apache.cassandra.metrics.TableMetricsTest.testLoggedPartitionsPerBatch-compression|https://ci-cassandra.apache.org/job/Cassandra-devbranch/1082/testReport/org.apache.cassandra.metrics/TableMetricsTest/testLoggedPartitionsPerBatch_compression/] 3.1 sec [1|https://ci-cassandra.apache.org/job/Cassandra-devbranch/1082/] !https://ci-cassandra.apache.org/static/c0f8b409/images/16x16/document_add.png! [org.apache.cassandra.distributed.upgrade.CompactStorageUpgradeTest.compactStorageHiddenColumnTest|https://ci-cassandra.apache.org/job/Cassandra-devbranch/1082/testReport/org.apache.cassandra.distributed.upgrade/CompactStorageUpgradeTest/compactStorageHiddenColumnTest/] 1 min 13 sec [2|https://ci-cassandra.apache.org/job/Cassandra-devbranch/1081/] !https://ci-cassandra.apache.org/static/c0f8b409/images/16x16/document_add.png! [org.apache.cassandra.distributed.upgrade.MixedModeReadTest.mixedModeReadColumnSubsetDigestCheck|https://ci-cassandra.apache.org/job/Cassandra-devbranch/1082/testReport/org.apache.cassandra.distributed.upgrade/MixedModeReadTest/mixedModeReadColumnSubsetDigestCheck/] 26 sec [4|https://ci-cassandra.apache.org/job/Cassandra-devbranch/1079/] !https://ci-cassandra.apache.org/static/c0f8b409/images/16x16/document_add.png! [org.apache.cassandra.distributed.upgrade.MixedModeReadTest.mixedModeReadColumnSubsetDigestCheck|https://ci-cassandra.apache.org/job/Cassandra-devbranch/1082/testReport/org.apache.cassandra.distributed.upgrade/MixedModeReadTest/mixedModeReadColumnSubsetDigestCheck_2/] 25 sec [4|https://ci-cassandra.apache.org/job/Cassandra-devbranch/1079/] !https://ci-cassandra.apache.org/static/c0f8b409/images/16x16/document_add.png! [org.apache.cassandra.distributed.upgrade.MixedModeReadTest.mixedModeReadColumnSubsetDigestCheck|https://ci-cassandra.apache.org/job/Cassandra-devbranch/1082/testReport/org.apache.cassandra.distributed.upgrade/MixedModeReadTest/mixedModeReadColumnSubsetDigestCheck_3/] 29 sec [4|https://ci-cassandra.apache.org/job/Cassandra-devbranch/1079/] > Update from Jackson 2.9 to 2.12 > --- > > Key: CASSANDRA-16851 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16851 > Project: Cassandra > Issue Type: Improvement > Components: Dependencies >Reporter: Tatu Saloranta >Assignee: Tatu Saloranta >Priority: Normal > Time Spent: 3h 40m > Remaining Estimate: 0h > > Given that Jackson 2.9 support has ended, it would be good to move at least > to the next minor version (2.10, patch 2.10.5) or later – latest stable being > 2.12.4. > I can test to see if anything breaks, but looking at existing Jackson usage > there shouldn't be many issues. > Assuming upgrade is acceptable there's the question of which branches to > apply it to; I will first test it against 4.0. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15804) system_schema keyspace complain of schema mismatch during upgrade
[
https://issues.apache.org/jira/browse/CASSANDRA-15804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-15804:
-
Resolution: Cannot Reproduce
Status: Resolved (was: Open)
We're long past 3.6 now, please reopen if this returns.
> system_schema keyspace complain of schema mismatch during upgrade
> -
>
> Key: CASSANDRA-15804
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15804
> Project: Cassandra
> Issue Type: Bug
> Components: Cluster/Schema
>Reporter: Pedro Gordo
>Priority: Low
> Fix For: 3.11.x, 4.0.x
>
>
> When upgrading from 3.11.4 to 3.11.6, we got the following error:
> {code:Plain Text}
> ERROR [MessagingService-Incoming-/10.20.11.59] 2020-05-07 13:53:52,627
> CassandraDaemon.java:228 - Exception in thread
> Thread[MessagingService-Incoming-/10.20.11.59,5,main]
> java.lang.RuntimeException: Unknown column kind during deserialization
> at
> org.apache.cassandra.db.Columns$Serializer.deserialize(Columns.java:464)
> ~[apache-cassandra-3.11.4.jar:3.11.4]
> at
> org.apache.cassandra.db.SerializationHeader$Serializer.deserializeForMessaging(SerializationHeader.java:419)
> ~[apache-cassandra-3.11.4.jar:3.11.4]
> at
> org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.deserializeHeader(UnfilteredRowIteratorSerializer.java:195)
> ~[apache-cassandra-3.11.4.jar:3.11.4]
> at
> org.apache.cassandra.db.partitions.PartitionUpdate$PartitionUpdateSerializer.deserialize30(PartitionUpdate.java:851)
> ~[apache-cassandra-3.11.4.jar:3.11.4]
> at
> org.apache.cassandra.db.partitions.PartitionUpdate$PartitionUpdateSerializer.deserialize(PartitionUpdate.java:839)
> ~[apache-cassandra-3.11.4.jar:3.11.4]
> at
> org.apache.cassandra.db.Mutation$MutationSerializer.deserialize(Mutation.java:425)
> ~[apache-cassandra-3.11.4.jar:3.11.4]
> at
> org.apache.cassandra.db.Mutation$MutationSerializer.deserialize(Mutation.java:434)
> ~[apache-cassandra-3.11.4.jar:3.11.4]
> at
> org.apache.cassandra.service.MigrationManager$MigrationsSerializer.deserialize(MigrationManager.java:675)
> ~[apache-cassandra-3.11.4.jar:3.11.4]
> at
> org.apache.cassandra.service.MigrationManager$MigrationsSerializer.deserialize(MigrationManager.java:658)
> ~[apache-cassandra-3.11.4.jar:3.11.4]
> at org.apache.cassandra.net.MessageIn.read(MessageIn.java:123)
> ~[apache-cassandra-3.11.4.jar:3.11.4]
> at
> org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:192)
> ~[apache-cassandra-3.11.4.jar:3.11.4]
> at
> org.apache.cassandra.net.IncomingTcpConnection.receiveMessages(IncomingTcpConnection.java:180)
> ~[apache-cassandra-3.11.4.jar:3.11.4]
> at
> org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:94)
> ~[apache-cassandra-3.11.4.jar:3.11.4]
> {code}
> I've noticed that system_schema.dropped_columns has a new column called
> "kind".
> No issues arise from this error message, and the error disappeared after
> upgrading all nodes. But it still caused concerns due to the ERROR logging
> level, although "nodetool describecluster" reported only one schema version.
> It makes sense for the system keyspaces to not be included for the
> "describecluster" schema version check, but it seems to me that these
> internal schema mismatches should be ignored if the versions are different
> between the nodes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16292) upgraded nodes encountered "Unknown column kind" RuntimeException during upgrade C* from 3.0 to 3.2
[
https://issues.apache.org/jira/browse/CASSANDRA-16292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-16292:
-
Resolution: Won't Fix
Status: Resolved (was: Triage Needed)
3.2 is long gone.
> upgraded nodes encountered "Unknown column kind" RuntimeException during
> upgrade C* from 3.0 to 3.2
> ---
>
> Key: CASSANDRA-16292
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16292
> Project: Cassandra
> Issue Type: Bug
>Reporter: Yongle Zhang
>Priority: Normal
>
> We tried to upgrade a 3.0.21 C* cluster to 3.2 and run into the following
> runtime exception.
>
> Error message:
>
> {code:java}
> INFO 04:56:43 Initializing system_schema.dropped_columns
> ERROR 04:56:43 Exception in thread Thread[SSTableBatchOpen:2,5,main]
> java.lang.RuntimeException: Unknown column kind during deserialization
> at
> org.apache.cassandra.db.SerializationHeader$Component.toHeader(SerializationHeader.java:331)
> ~[main/:na]
> at
> org.apache.cassandra.io.sstable.format.SSTableReader.open(SSTableReader.java:477)
> ~[main/:na]
> at
> org.apache.cassandra.io.sstable.format.SSTableReader.open(SSTableReader.java:366)
> ~[main/:na]
> at
> org.apache.cassandra.io.sstable.format.SSTableReader$4.run(SSTableReader.java:525)
> ~[main/:na]
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> ~[na:1.8.0_252]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[na:1.8.0_252]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> ~[na:1.8.0_252]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> [na:1.8.0_252]
> at java.lang.Thread.run(Thread.java:748) [na:1.8.0_252]
> {code}
>
> Steps to reproduce:
> # Start up a cluster of version 3.0 with 3 nodes and one seed
> # Run these commands to create keyspaces and tables:
> {code:java}
> CREATE KEYSPACE ks WITH replication = { 'class':'SimpleStrategy',
> 'replication_factor':1} AND DURABLE_WRITES = true";{code}
>
> {code:java}
> CREATE KEYSPACE IF NOT EXISTS foo WITH replication = {'class':
> 'SimpleStrategy', 'replication_factor': '1'}{code}
>
> {code:java}
> CREATE TABLE foo.bar (key text PRIMARY KEY, val int);{code}
>
> {code:java}
> CREATE TABLE testTable (pk int PRIMARY KEY, val text){code}
> # Drop one of the keyspaces
> {code:java}
> DROP KEYSPACE foo;{code}
> # stopp all the nodes, and started the C* nodes running C* compiled from 3.2
> # After upgrading, we noticed some of the nodes encountered the
> RuntimeException (Unknown column kind during deserialization)
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16883) Weak visibility guarantees of Accumulator can lead to failure to recognize digest mismatches
[
https://issues.apache.org/jira/browse/CASSANDRA-16883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17406048#comment-17406048
]
Caleb Rackliffe edited comment on CASSANDRA-16883 at 8/31/21, 6:56 PM:
---
||branch||Circle CI||Apache CI|
|[3.0|https://github.com/apache/cassandra/pull/1173]|[J8|https://app.circleci.com/pipelines/github/maedhroz/cassandra?branch=CASSANDRA-16883-3.0]|[1078|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/1078/]|
|[3.11|https://github.com/apache/cassandra/pull/1181]|[J8|https://app.circleci.com/pipelines/github/maedhroz/cassandra/342/workflows/d6850818-6c5f-4427-9e63-f29a6bf17bd3]|[1088|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/1088/]|
(This should be a pretty clean merge up to 3.11, and won't be necessary in 4.0.)
was (Author: maedhroz):
||branch||Circle CI||Apache CI|
|[3.0|https://github.com/apache/cassandra/pull/1173]|[J8|https://app.circleci.com/pipelines/github/maedhroz/cassandra?branch=CASSANDRA-16883-3.0]|[1078|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/1078/]
(This should be a pretty clean merge up to 3.11, and won't be necessary in 4.0.)
> Weak visibility guarantees of Accumulator can lead to failure to recognize
> digest mismatches
>
>
> Key: CASSANDRA-16883
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16883
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Coordination
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The context for this problem is largely the same as CASSANDRA-16807. The
> difference is that for 4.0+, CASSANDRA-16097 added an assertion to
> {{DigestResolver#responseMatch()}} that ensures the responses snapshot has at
> least one visible element (although of course only one element trivially
> cannot generate a mismatch and short-circuits immediately). In 3.0 and 3.11,
> this assertion does not exist, and when the underlying problem occurs (i.e.
> zero responses are visible on {{Accumulator}} when there should be 2), we can
> silently avoid the digest matching entirely. This seems like it would make it
> both impossible to do a potentially necessary full data read to resolve the
> correct response and prevent repair.
> The fix here should be similar to the one in CASSANDRA-16807, although there
> might be some test infrastructure that needs porting in order to make that
> work.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16906) Formula in document looks strange.
[ https://issues.apache.org/jira/browse/CASSANDRA-16906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-16906: - Bug Category: Parent values: Correctness(12982) Complexity: Normal Component/s: Legacy/Documentation and Website Discovered By: User Report Severity: Low Assignee: Erick Ramirez (was: eric ramirez) Status: Open (was: Triage Needed) > Formula in document looks strange. > -- > > Key: CASSANDRA-16906 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16906 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Documentation and Website >Reporter: Takuya inagaki >Assignee: Erick Ramirez >Priority: Normal > Attachments: スクリーンショット 2021-08-31 18.03.57.png > > > In latest document, all of formulas does not display correctly. > please refer to the following > [document|https://cassandra.apache.org/doc/latest/cassandra/data_modeling/data_modeling_refining.html] > and attached image. > > h3. Environment > browser: chrome 92.0.4515.159 > os: macOS Big Sur 11.5.2 > > h3. Slack > [https://the-asf.slack.com/archives/CJZLTM05A/p1630400708095100] > https://the-asf.slack.com/archives/CJZLTM05A/p1630400951095900 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14466) Enable Direct I/O
[ https://issues.apache.org/jira/browse/CASSANDRA-14466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-14466: - Fix Version/s: 4.x > Enable Direct I/O > -- > > Key: CASSANDRA-14466 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14466 > Project: Cassandra > Issue Type: New Feature > Components: Legacy/Local Write-Read Paths >Reporter: Mulugeta Mammo >Assignee: Mulugeta Mammo >Priority: Normal > Fix For: 4.x > > > Hi, > JDK 10 introduced a new API for Direct IO that enables applications to bypass > the file system cache and potentially improve performance. Details of this > feature can be found at [https://bugs.openjdk.java.net/browse/JDK-8164900]. > This patch uses the JDK 10 API to enable Direct IO for the Cassandra read > path. By default, we have disabled this feature; but it can be enabled using > a new configuration parameter, enable_direct_io_for_read_path. We have > conducted a Cassandra read-only stress test and measured a throughput gain of > up to 60% on flash drives. > The patch requires JDK 10 Cassandra Support - > https://issues.apache.org/jira/browse/CASSANDRA-9608 > Please review the patch and let us know your feedback. > Thanks, > [^direct_io.patch] > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14466) Enable Direct I/O
[ https://issues.apache.org/jira/browse/CASSANDRA-14466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407585#comment-17407585 ] Brandon Williams commented on CASSANDRA-14466: -- This needs a rebase at this point, but with 4.0 released it should be easier to find time to get this reviewed and committed. > Enable Direct I/O > -- > > Key: CASSANDRA-14466 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14466 > Project: Cassandra > Issue Type: New Feature > Components: Legacy/Local Write-Read Paths >Reporter: Mulugeta Mammo >Assignee: Mulugeta Mammo >Priority: Normal > > Hi, > JDK 10 introduced a new API for Direct IO that enables applications to bypass > the file system cache and potentially improve performance. Details of this > feature can be found at [https://bugs.openjdk.java.net/browse/JDK-8164900]. > This patch uses the JDK 10 API to enable Direct IO for the Cassandra read > path. By default, we have disabled this feature; but it can be enabled using > a new configuration parameter, enable_direct_io_for_read_path. We have > conducted a Cassandra read-only stress test and measured a throughput gain of > up to 60% on flash drives. > The patch requires JDK 10 Cassandra Support - > https://issues.apache.org/jira/browse/CASSANDRA-9608 > Please review the patch and let us know your feedback. > Thanks, > [^direct_io.patch] > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16906) Formula in document looks strange.
[ https://issues.apache.org/jira/browse/CASSANDRA-16906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Takuya inagaki updated CASSANDRA-16906: --- Description: In latest document, all of formulas does not display correctly. please refer to the following [document|https://cassandra.apache.org/doc/latest/cassandra/data_modeling/data_modeling_refining.html] and attached image. h3. Environment browser: chrome 92.0.4515.159 os: macOS Big Sur 11.5.2 h3. Slack [https://the-asf.slack.com/archives/CJZLTM05A/p1630400708095100] https://the-asf.slack.com/archives/CJZLTM05A/p1630400951095900 was: In latest document, all of formulas does not display correctly. please refer to the following [document|https://cassandra.apache.org/doc/latest/cassandra/data_modeling/data_modeling_refining.html] and image. h3. Environment browser: chrome 92.0.4515.159 os: macOS Big Sur 11.5.2 > Formula in document looks strange. > -- > > Key: CASSANDRA-16906 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16906 > Project: Cassandra > Issue Type: Bug >Reporter: Takuya inagaki >Assignee: eric ramirez >Priority: Normal > Attachments: スクリーンショット 2021-08-31 18.03.57.png > > > In latest document, all of formulas does not display correctly. > please refer to the following > [document|https://cassandra.apache.org/doc/latest/cassandra/data_modeling/data_modeling_refining.html] > and attached image. > > h3. Environment > browser: chrome 92.0.4515.159 > os: macOS Big Sur 11.5.2 > > h3. Slack > [https://the-asf.slack.com/archives/CJZLTM05A/p1630400708095100] > https://the-asf.slack.com/archives/CJZLTM05A/p1630400951095900 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16906) Formula in document looks strange.
Takuya inagaki created CASSANDRA-16906: -- Summary: Formula in document looks strange. Key: CASSANDRA-16906 URL: https://issues.apache.org/jira/browse/CASSANDRA-16906 Project: Cassandra Issue Type: Bug Reporter: Takuya inagaki Assignee: eric ramirez Attachments: スクリーンショット 2021-08-31 18.03.57.png In latest document, all of formulas does not display correctly. please refer to the following [document|https://cassandra.apache.org/doc/latest/cassandra/data_modeling/data_modeling_refining.html] and image. h3. Environment browser: chrome 92.0.4515.159 os: macOS Big Sur 11.5.2 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16092) Add Index Group Interface for Storage Attached Index
[ https://issues.apache.org/jira/browse/CASSANDRA-16092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407575#comment-17407575 ] Caleb Rackliffe commented on CASSANDRA-16092: - There has been some discussion about the breaking API changes in this patch, and whether we should move forward with merging it now, given that would essentially move trunk forward to 5.0. We may need to consider pausing this for now, wrapping up the CEP-7 discussion, and then moving official development to a trunk-based feature branch, which would merge with both breaking API changes and a complete implementation (moving us to 5.0 if that hadn't already happened). On the bright side, it seems unlikely that any of the work here will be wasted. > Add Index Group Interface for Storage Attached Index > > > Key: CASSANDRA-16092 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16092 > Project: Cassandra > Issue Type: New Feature > Components: Feature/SASI >Reporter: Zhao Yang >Assignee: Zhao Yang >Priority: Normal > Fix For: 4.x > > > [Index > group|https://github.com/datastax/cassandra/blob/storage_attached_index/src/java/org/apache/cassandra/index/Index.java#L634] > interface allows: > * indexes on the same table to receive centralized lifecycle events called > secondary index groups. Sharing of data between multiple column indexes on > the same table allows SAI disk usage to realise significant space savings > over other index implementations. > * index-group to analyze user query and provide a query plan that leverages > all available indexes within the group. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16092) Add Index Group Interface for Storage Attached Index
[ https://issues.apache.org/jira/browse/CASSANDRA-16092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caleb Rackliffe updated CASSANDRA-16092: Status: Patch Available (was: Review In Progress) > Add Index Group Interface for Storage Attached Index > > > Key: CASSANDRA-16092 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16092 > Project: Cassandra > Issue Type: New Feature > Components: Feature/SASI >Reporter: Zhao Yang >Assignee: Zhao Yang >Priority: Normal > Fix For: 4.x > > > [Index > group|https://github.com/datastax/cassandra/blob/storage_attached_index/src/java/org/apache/cassandra/index/Index.java#L634] > interface allows: > * indexes on the same table to receive centralized lifecycle events called > secondary index groups. Sharing of data between multiple column indexes on > the same table allows SAI disk usage to realise significant space savings > over other index implementations. > * index-group to analyze user query and provide a query plan that leverages > all available indexes within the group. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-16843) auto-snapshots for dropped tables don't appear in nodetool listsnapshots
[
https://issues.apache.org/jira/browse/CASSANDRA-16843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams reassigned CASSANDRA-16843:
Assignee: (was: Brandon Williams)
> auto-snapshots for dropped tables don't appear in nodetool listsnapshots
>
>
> Key: CASSANDRA-16843
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16843
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Other
>Reporter: James Brown
>Priority: Normal
> Fix For: 3.11.x, 4.0.x
>
>
> Auto snapshots from dropped tables don't seem to show up in {{nodetool
> listsnapshots}} (even though they do get cleared by {{nodetool
> clearsnapshot}}). This makes them kind of annoying to clean up, since you
> need to muck about in the data directory to find them.
> Erick on the mailing list said that this seems to be an oversight and that
> clearsnapshot was fixed by
> [CASSANDRA-6418|https://issues.apache.org/jira/browse/CASSANDRA-6418].
> I reproduced this both on 3.11.11 and 4.0.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16896) Add soft/hard limits to local reads to protect against reading too much data in a single query
[ https://issues.apache.org/jira/browse/CASSANDRA-16896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-16896: -- Test and Documentation Plan: added tests Status: Patch Available (was: In Progress) > Add soft/hard limits to local reads to protect against reading too much data > in a single query > -- > > Key: CASSANDRA-16896 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16896 > Project: Cassandra > Issue Type: New Feature > Components: Legacy/Local Write-Read Paths >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.1 > > > Add soft/hard limits to local reads to protect against reading too much data > in a single query. > This is an extension of the existing work to add warnings/aborts to large > partitions (CASSANDRA-16850), with the core difference is that this applies > locally rather than at the coordinator. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15290) Avoid token cache invalidation for removing proxy node
[ https://issues.apache.org/jira/browse/CASSANDRA-15290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407522#comment-17407522 ] Brandon Williams commented on CASSANDRA-15290: -- ||Heading 1||Heading 2|| |[rebased|https://github.com/driftx/cassandra/tree/CASSANDRA-15290]|[circle|https://app.circleci.com/pipelines/github/driftx/cassandra?branch=CASSANDRA-15290], [!https://ci-cassandra.apache.org/job/Cassandra-devbranch/1087/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/1087/pipeline]| > Avoid token cache invalidation for removing proxy node > -- > > Key: CASSANDRA-15290 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15290 > Project: Cassandra > Issue Type: Improvement > Components: Cluster/Membership >Reporter: Jay Zhuang >Assignee: Jay Zhuang >Priority: Low > Fix For: 4.x > > > As proxy node doesn't own token, adding/removing doesn't change token > ownership and no need to invalidate the token cache. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15290) Avoid token cache invalidation for removing proxy node
[ https://issues.apache.org/jira/browse/CASSANDRA-15290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407522#comment-17407522 ] Brandon Williams edited comment on CASSANDRA-15290 at 8/31/21, 4:46 PM: ||Branch||CI|| |[rebased|https://github.com/driftx/cassandra/tree/CASSANDRA-15290]|[circle|https://app.circleci.com/pipelines/github/driftx/cassandra?branch=CASSANDRA-15290], [!https://ci-cassandra.apache.org/job/Cassandra-devbranch/1087/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/1087/pipeline]| was (Author: brandon.williams): ||Heading 1||Heading 2|| |[rebased|https://github.com/driftx/cassandra/tree/CASSANDRA-15290]|[circle|https://app.circleci.com/pipelines/github/driftx/cassandra?branch=CASSANDRA-15290], [!https://ci-cassandra.apache.org/job/Cassandra-devbranch/1087/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/1087/pipeline]| > Avoid token cache invalidation for removing proxy node > -- > > Key: CASSANDRA-15290 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15290 > Project: Cassandra > Issue Type: Improvement > Components: Cluster/Membership >Reporter: Jay Zhuang >Assignee: Jay Zhuang >Priority: Low > Fix For: 4.x > > > As proxy node doesn't own token, adding/removing doesn't change token > ownership and no need to invalidate the token cache. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16905) Further restrict schema column drop/recreate conversions
Josh McKenzie created CASSANDRA-16905: - Summary: Further restrict schema column drop/recreate conversions Key: CASSANDRA-16905 URL: https://issues.apache.org/jira/browse/CASSANDRA-16905 Project: Cassandra Issue Type: Improvement Components: Cluster/Schema Reporter: Josh McKenzie Assignee: Josh McKenzie CASSANDRA-14948 took us a good bit of the way to preventing recreation issues with columns, however we should take the safety a bit further and disallow recreation on fixed/variable length mismatches and simple/complex mismatches. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16904) Check if size of object being added to RowCache and KeyCache is bigger than cache capacity
Josh McKenzie created CASSANDRA-16904: - Summary: Check if size of object being added to RowCache and KeyCache is bigger than cache capacity Key: CASSANDRA-16904 URL: https://issues.apache.org/jira/browse/CASSANDRA-16904 Project: Cassandra Issue Type: Improvement Components: Local/Caching Reporter: Josh McKenzie Assignee: Josh McKenzie We don't check if the size of an object being added to the RowCache/KeyCache itself exceeds the max configured size of the cache. For instance, if a RowCache object is ~5GB due to IndexInfo objects, but the cache is configured to have a max capacity of 100MB, we will still add the 5GB object into the cache and then need to wait for the eviction thread in the cache to come around, realize we're over capacity, and remove the object from the cache. We could check the size of the object with jamm and ensure it's smaller than the max size of the cache. If it exceeds the size of the cache don't cache it at all. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16666) Make SSLContext creation pluggable/extensible
[ https://issues.apache.org/jira/browse/CASSANDRA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407517#comment-17407517 ] Maulin Vasavada commented on CASSANDRA-1: - Sure, so we can focus on getting code review comments closed and then be ready with doing doc changes when we have more clarity around it. > Make SSLContext creation pluggable/extensible > - > > Key: CASSANDRA-1 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1 > Project: Cassandra > Issue Type: Improvement > Components: Messaging/Internode >Reporter: Maulin Vasavada >Assignee: Maulin Vasavada >Priority: Normal > Fix For: 4.x > > > Currently Cassandra creates the SSLContext via SSLFactory.java. SSLFactory is > a final class with static methods and not overridable. The SSLFactory loads > the keys and certs from the file based artifacts for the same. While this > works for many, in the industry where security is stricter and contextual, > this approach falls short. Many big organizations need flexibility to load > the SSL artifacts from a custom resource (like custom Key Management > Solution, HashiCorp Vault, Amazon KMS etc). While JSSE SecurityProvider > architecture allows us flexibility to build our custom mechanisms to validate > and process security artifacts, many times all we need is to build upon > Java's existing extensibility that Trust/Key Manager interfaces provide to > load keystores from various resources in the absence of any customized > requirements on the Keys/Certificate formats. > My proposal here is to make the SSLContext creation pluggable/extensible and > have the current SSLFactory.java implement an extensible interface. > I contributed a similar change that is live now in Apache Kafka (2.6.0) - > https://issues.apache.org/jira/browse/KAFKA-8890 > I can spare some time writing the pluggable interface and run by the required > reviewers. > > Created [CEP-9: Make SSLContext creation > pluggable|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-9%3A+Make+SSLContext+creation+pluggable] > > > cc: [~dcapwell] [~djoshi] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-13270) Add function hooks to deliver Elasticsearch as a Cassandra plugin
[ https://issues.apache.org/jira/browse/CASSANDRA-13270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-13270: - Status: Open (was: Patch Available) > Add function hooks to deliver Elasticsearch as a Cassandra plugin > - > > Key: CASSANDRA-13270 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13270 > Project: Cassandra > Issue Type: New Feature > Components: Legacy/Core >Reporter: vincent royer >Priority: Low > Labels: features > Fix For: 4.x > > Attachments: 0001-CASSANDRA-13270-elasticsearch-as-a-plugin.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > With these basic modifications (see the patch) and the following tickets, the > Elassandra project (see https://github.com/strapdata/elassandra) could be an > Elasticsearch plugin for Cassandra. > * CASSANDRA-12837 Add multi-threaded support to nodetool rebuild_index. > * CASSANDRA-13267 Add CQL functions. > * CASSANDRA-13268 Allow to create custom secondary index on static columns. > * CASSANDRA-13269 Snapshot support for custom secondary indices > * CASSANDRA-13499 Avoid duplicate calls to the same custom row index > * CASSANDRA-13500 Fix String default Locale with a javassit transformer > * CASSANDRA-13501 Upgrade some dependencies. > * CASSANDRA-13502 Don't overwrite the DefaultUncaughtExceptionHandler when > testing -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-13002) per table slow query times
[ https://issues.apache.org/jira/browse/CASSANDRA-13002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-13002: - Status: Open (was: Patch Available) > per table slow query times > -- > > Key: CASSANDRA-13002 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13002 > Project: Cassandra > Issue Type: New Feature > Components: Legacy/Observability >Reporter: Jon Haddad >Assignee: Murukesh Mohanan >Priority: Normal > Fix For: 4.x > > Attachments: > 0001-Add-per-table-slow_query_log_timeout_in_ms-property.patch, > 0001-Add-per-table-slow_query_log_timeout_in_ms-property.patch, > 0001-Add-per-table-slow_query_log_timeout_in_ms-property.patch > > > CASSANDRA-12403 made it possible to log slow queries, but the time specified > is a global one. This isn't useful if we know different tables have > different access patterns, as we'll end up with a lot of noise. We should be > able to override the slow query time at a per table level. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-12837) Add multi-threaded support to nodetool rebuild_index
[ https://issues.apache.org/jira/browse/CASSANDRA-12837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-12837: - Status: Open (was: Patch Available) > Add multi-threaded support to nodetool rebuild_index > > > Key: CASSANDRA-12837 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12837 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Core >Reporter: vincent royer >Priority: Low > Labels: patch, performance > Fix For: 3.11.x, 4.x > > Attachments: 0001-CASSANDRA-12837-multi-threaded-rebuild_index.patch, > CASSANDRA-12837-2.2.9.txt > > > Add multi-thread nodetool rebuild_index to improve performances. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-9387) Add snitch supporting Windows Azure
[ https://issues.apache.org/jira/browse/CASSANDRA-9387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-9387: Status: Open (was: Patch Available) > Add snitch supporting Windows Azure > --- > > Key: CASSANDRA-9387 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9387 > Project: Cassandra > Issue Type: New Feature > Components: Legacy/Core, Local/Config >Reporter: Jonathan Ellis >Assignee: Yoshua Wakeham >Priority: Normal > Fix For: 4.x > > > Looks like regions / fault domains are a pretty close analogue to C* > DCs/racks. > http://blogs.technet.com/b/yungchou/archive/2011/05/16/window-azure-fault-domain-and-update-domain-explained-for-it-pros.aspx -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-11334) Make compaction operations (scrub, etc) asynchronous
[
https://issues.apache.org/jira/browse/CASSANDRA-11334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-11334:
-
Status: Open (was: Patch Available)
> Make compaction operations (scrub, etc) asynchronous
>
>
> Key: CASSANDRA-11334
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11334
> Project: Cassandra
> Issue Type: Sub-task
> Components: Legacy/Tools
>Reporter: Yuki Morishita
>Assignee: Varun Gupta
>Priority: Low
> Fix For: 4.x
>
> Attachments: make-compaction-manager-return-Future.patch
>
>
> Prior to make nodetool to use JMX notification, we need to make scrub,
> verify, cleanup etc. to asynchronous.
> Right now, those operations block in {{CompactionManager}}, so instead we
> want to be able to get {{Future}} object that can be listened for completion.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16903) UDTs named after built-in data types
[ https://issues.apache.org/jira/browse/CASSANDRA-16903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407498#comment-17407498 ] Brandon Williams commented on CASSANDRA-16903: -- It looks like map and set are just getting lucky and tripping up the parser, where the others don't. We should probably explicitly disallow them all with a proper message. > UDTs named after built-in data types > > > Key: CASSANDRA-16903 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16903 > Project: Cassandra > Issue Type: Bug > Components: Feature/UDT >Reporter: Brandon Bordeaux >Priority: Normal > Fix For: 4.0.x > > > Working with Cassandra 4.0 I found UDTs can be named after some built-in data > type, like map, list, and tuple, but not for other types, like text or set. > This behavior should be consistent across all built-in types where Cassandra > shouldn't allow a UDT to be named after any built-in type. > Having UDTs named after built-in types cause confusion working with table > schemas and may introduce downstream issues when Cassandra works with these > types. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16903) UDTs named after built-in data types
[ https://issues.apache.org/jira/browse/CASSANDRA-16903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-16903: - Bug Category: Parent values: Correctness(12982) Complexity: Normal Discovered By: User Report Fix Version/s: 4.0.x Severity: Normal Status: Open (was: Triage Needed) > UDTs named after built-in data types > > > Key: CASSANDRA-16903 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16903 > Project: Cassandra > Issue Type: Bug > Components: Feature/UDT >Reporter: Brandon Bordeaux >Priority: Normal > Fix For: 4.0.x > > > Working with Cassandra 4.0 I found UDTs can be named after some built-in data > type, like map, list, and tuple, but not for other types, like text or set. > This behavior should be consistent across all built-in types where Cassandra > shouldn't allow a UDT to be named after any built-in type. > Having UDTs named after built-in types cause confusion working with table > schemas and may introduce downstream issues when Cassandra works with these > types. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16903) UDTs named after built-in data types
Brandon Bordeaux created CASSANDRA-16903: Summary: UDTs named after built-in data types Key: CASSANDRA-16903 URL: https://issues.apache.org/jira/browse/CASSANDRA-16903 Project: Cassandra Issue Type: Bug Components: Feature/UDT Reporter: Brandon Bordeaux Working with Cassandra 4.0 I found UDTs can be named after some built-in data type, like map, list, and tuple, but not for other types, like text or set. This behavior should be consistent across all built-in types where Cassandra shouldn't allow a UDT to be named after any built-in type. Having UDTs named after built-in types cause confusion working with table schemas and may introduce downstream issues when Cassandra works with these types. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16900) org.apache.cassandra.db.rows.ArrayCell#unsharedHeapSizeExcludingData includes data twice
[ https://issues.apache.org/jira/browse/CASSANDRA-16900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Capwell updated CASSANDRA-16900: -- Since Version: 4.0.0 Source Control Link: https://github.com/apache/cassandra/commit/39a3054950c16f6ca9bdaf45a3a74e4267541df0 Resolution: Fixed Status: Resolved (was: Ready to Commit) > org.apache.cassandra.db.rows.ArrayCell#unsharedHeapSizeExcludingData includes > data twice > > > Key: CASSANDRA-16900 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16900 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Local Write-Read Paths >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.0.1, 4.1 > > Time Spent: 1h > Remaining Estimate: 0h > > org.apache.cassandra.db.rows.ArrayCell#unsharedHeapSizeExcludingData includes > data and adds the length; so includes data twice -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0 updated: org.apache.cassandra.db.rows.ArrayCell#unsharedHeapSizeExcludingData includes data twice
This is an automated email from the ASF dual-hosted git repository.
dcapwell pushed a commit to branch cassandra-4.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-4.0 by this push:
new ca4f6b8
org.apache.cassandra.db.rows.ArrayCell#unsharedHeapSizeExcludingData includes
data twice
ca4f6b8 is described below
commit ca4f6b80563aeb3614fe3bce47e4fb620a8f0e8e
Author: David Capwell
AuthorDate: Mon Aug 30 16:37:53 2021 -0700
org.apache.cassandra.db.rows.ArrayCell#unsharedHeapSizeExcludingData
includes data twice
patch by David Capwell; reviewed by Caleb Rackliffe for CASSANDRA-16900
---
CHANGES.txt| 1 +
.../apache/cassandra/cql3/ColumnIdentifier.java| 2 +-
.../org/apache/cassandra/db/rows/ArrayCell.java| 2 +-
.../org/apache/cassandra/db/rows/BufferCell.java | 6 +-
.../org/apache/cassandra/db/rows/CellPath.java | 2 +-
.../org/apache/cassandra/db/rows/NativeCell.java | 2 +-
.../org/apache/cassandra/fql/FullQueryLogger.java | 2 +-
.../org/apache/cassandra/utils/ObjectSizes.java| 8 +-
.../unit/org/apache/cassandra/db/CellSpecTest.java | 121 +
9 files changed, 138 insertions(+), 8 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index aef6fe1..f79cf30 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -2,6 +2,7 @@
* Fix clustering order logic in CREATE MATERIALIZED VIEW (CASSANDRA-16898)
4.0.1
+ * org.apache.cassandra.db.rows.ArrayCell#unsharedHeapSizeExcludingData
includes data twice (CASSANDRA-16900)
* Exclude Jackson 1.x transitive dependency of hadoop* provided dependencies
(CASSANDRA-16854)
* Tolerate missing DNS entry when completing a host replacement
(CASSANDRA-16873)
* Harden PrunableArrayQueue against Pruner implementations that might throw
exceptions (CASSANDRA-16866)
diff --git a/src/java/org/apache/cassandra/cql3/ColumnIdentifier.java
b/src/java/org/apache/cassandra/cql3/ColumnIdentifier.java
index e7bf7b9..889f23a 100644
--- a/src/java/org/apache/cassandra/cql3/ColumnIdentifier.java
+++ b/src/java/org/apache/cassandra/cql3/ColumnIdentifier.java
@@ -205,7 +205,7 @@ public class ColumnIdentifier implements IMeasurableMemory,
Comparable
public long unsharedHeapSizeExcludingData()
{
-return EMPTY_SIZE + ObjectSizes.sizeOfArray(value) + value.length +
(path == null ? 0 : path.unsharedHeapSizeExcludingData());
+return EMPTY_SIZE + ObjectSizes.sizeOfEmptyByteArray() + (path == null
? 0 : path.unsharedHeapSizeExcludingData());
}
}
diff --git a/src/java/org/apache/cassandra/db/rows/BufferCell.java
b/src/java/org/apache/cassandra/db/rows/BufferCell.java
index 3795b0c..55fc4b4 100644
--- a/src/java/org/apache/cassandra/db/rows/BufferCell.java
+++ b/src/java/org/apache/cassandra/db/rows/BufferCell.java
@@ -28,6 +28,8 @@ import org.apache.cassandra.utils.ByteBufferUtil;
import org.apache.cassandra.utils.ObjectSizes;
import org.apache.cassandra.utils.memory.AbstractAllocator;
+import static java.lang.String.format;
+
public class BufferCell extends AbstractCell
{
private static final long EMPTY_SIZE = ObjectSizes.measure(new
BufferCell(ColumnMetadata.regularColumn("", "", "", ByteType.instance), 0L, 0,
0, ByteBufferUtil.EMPTY_BYTE_BUFFER, null));
@@ -43,7 +45,7 @@ public class BufferCell extends AbstractCell
{
super(column);
assert !column.isPrimaryKeyColumn();
-assert column.isComplex() == (path != null);
+assert column.isComplex() == (path != null) : format("Column %s.%s(%s:
%s) isComplex: %b with cellpath: %s", column.ksName, column.cfName,
column.name, column.type.toString(), column.isComplex(), path);
this.timestamp = timestamp;
this.ttl = ttl;
this.localDeletionTime = localDeletionTime;
@@ -142,6 +144,6 @@ public class BufferCell extends AbstractCell
public long unsharedHeapSizeExcludingData()
{
-return EMPTY_SIZE + ObjectSizes.sizeOnHeapExcludingData(value) + (path
== null ? 0 : path.unsharedHeapSizeExcludingData());
+return EMPTY_SIZE + ObjectSizes.sizeOfEmptyHeapByteBuffer() + (path ==
null ? 0 : path.unsharedHeapSizeExcludingData());
}
}
diff --git a/src/java/org/apache/cassandra/db/rows/CellPath.java
b/src/java/org/apache/cassandra/db/rows/CellPath.java
index 1bf8b8f..50496a1 100644
--- a/src/java/org/apache/cassandra/db/rows/CellPath.java
+++ b/src/java/org/apache/cassandra/db/rows/CellPath.java
@@ -127,7 +127,7 @@ public abstract class CellPath
public long unsharedHeapSizeExcludingData()
{
-return EMPTY_SIZE + ObjectSizes.sizeOnHeapExcludingData(value);
+return EMPTY_SIZE + ObjectSizes.sizeOfEmptyHeapByteBuffer();
}
}
diff --git a/src/java/org/apache/cassandra/db/rows/NativeCell.java
b/src/java/org/apache/cassandra/db/rows/NativeCell.java
index 52d9ab9..02e0008 100644
[cassandra] 01/01: Merge branch 'cassandra-4.0' into trunk
This is an automated email from the ASF dual-hosted git repository. dcapwell pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 4e0d8e0d5e0ad7d123ba5af55ad2cd8f857778ca Merge: 057f8e5 ca4f6b8 Author: David Capwell AuthorDate: Tue Aug 31 08:38:10 2021 -0700 Merge branch 'cassandra-4.0' into trunk CHANGES.txt| 1 + .../apache/cassandra/cql3/ColumnIdentifier.java| 2 +- .../org/apache/cassandra/db/rows/ArrayCell.java| 2 +- .../org/apache/cassandra/db/rows/BufferCell.java | 6 +- .../org/apache/cassandra/db/rows/CellPath.java | 2 +- .../org/apache/cassandra/db/rows/NativeCell.java | 2 +- .../org/apache/cassandra/fql/FullQueryLogger.java | 2 +- .../org/apache/cassandra/utils/ObjectSizes.java| 8 +- .../unit/org/apache/cassandra/db/CellSpecTest.java | 121 + 9 files changed, 138 insertions(+), 8 deletions(-) diff --cc CHANGES.txt index 17a5c99,f79cf30..864b596 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,28 -1,11 +1,29 @@@ -4.0.2 - * Fix clustering order logic in CREATE MATERIALIZED VIEW (CASSANDRA-16898) - -4.0.1 - * org.apache.cassandra.db.rows.ArrayCell#unsharedHeapSizeExcludingData includes data twice (CASSANDRA-16900) +4.1 * Exclude Jackson 1.x transitive dependency of hadoop* provided dependencies (CASSANDRA-16854) + * Add client warnings and abort to tombstone and coordinator reads which go past a low/high watermark (CASSANDRA-16850) + * Add TTL support to nodetool snapshots (CASSANDRA-16789) + * Allow CommitLogSegmentReader to optionally skip sync marker CRC checks (CASSANDRA-16842) + * allow blocking IPs from updating metrics about traffic (CASSANDRA-16859) + * Request-Based Native Transport Rate-Limiting (CASSANDRA-16663) + * Implement nodetool getauditlog command (CASSANDRA-16725) + * Clean up repair code (CASSANDRA-13720) + * Background schedule to clean up orphaned hints files (CASSANDRA-16815) + * Modify SecondaryIndexManager#indexPartition() to retrieve only columns for which indexes are actually being built (CASSANDRA-16776) + * Batch the token metadata update to improve the speed (CASSANDRA-15291) + * Reduce the log level on "expected" repair exceptions (CASSANDRA-16775) + * Make JMXTimer expose attributes using consistent time unit (CASSANDRA-16760) + * Remove check on gossip status from DynamicEndpointSnitch::updateScores (CASSANDRA-11671) + * Fix AbstractReadQuery::toCQLString not returning valid CQL (CASSANDRA-16510) + * Log when compacting many tombstones (CASSANDRA-16780) + * Display bytes per level in tablestats for LCS tables (CASSANDRA-16799) + * Add isolated flush timer to CommitLogMetrics and ensure writes correspond to single WaitingOnCommit data points (CASSANDRA-16701) + * Add a system property to set hostId if not yet initialized (CASSANDRA-14582) + * GossiperTest.testHasVersion3Nodes didn't take into account trunk version changes, fixed to rely on latest version (CASSANDRA-16651) +Merged from 4.0: ++ * org.apache.cassandra.db.rows.ArrayCell#unsharedHeapSizeExcludingData includes data twice (CASSANDRA-16900) + * Fix clustering order logic in CREATE MATERIALIZED VIEW (CASSANDRA-16898) * Tolerate missing DNS entry when completing a host replacement (CASSANDRA-16873) - * Harden PrunableArrayQueue against Pruner implementations that might throw exceptions (CASSANDRA-16866) + * Harden PrunableArrayQueue against Pruner implementations that might throw exceptions (CASSANDRA-16866) * Move RepairedDataInfo to the execution controller rather than the ReadCommand to avoid unintended sharing (CASSANDRA-16721) * Bump zstd-jni version to 1.5.0-4 (CASSANDRA-16884) * Remove assumption that all urgent messages are small (CASSANDRA-16877) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (057f8e5 -> 4e0d8e0)
This is an automated email from the ASF dual-hosted git repository. dcapwell pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 057f8e5 Merge branch cassandra-4.0 into trunk new ca4f6b8 org.apache.cassandra.db.rows.ArrayCell#unsharedHeapSizeExcludingData includes data twice new 4e0d8e0 Merge branch 'cassandra-4.0' into trunk The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + .../apache/cassandra/cql3/ColumnIdentifier.java| 2 +- .../org/apache/cassandra/db/rows/ArrayCell.java| 2 +- .../org/apache/cassandra/db/rows/BufferCell.java | 6 +- .../org/apache/cassandra/db/rows/CellPath.java | 2 +- .../org/apache/cassandra/db/rows/NativeCell.java | 2 +- .../org/apache/cassandra/fql/FullQueryLogger.java | 2 +- .../org/apache/cassandra/utils/ObjectSizes.java| 8 +- .../unit/org/apache/cassandra/db/CellSpecTest.java | 121 + 9 files changed, 138 insertions(+), 8 deletions(-) create mode 100644 test/unit/org/apache/cassandra/db/CellSpecTest.java - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16898) The clustering order logic in Materialized view creation changed in 4.0
[
https://issues.apache.org/jira/browse/CASSANDRA-16898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Lerer updated CASSANDRA-16898:
---
Fix Version/s: (was: 4.0.x)
4.0.2
Since Version: 4.0-rc1
Source Control Link:
https://github.com/apache/cassandra/commit/af17f136e58910fa23f1b8c6b8f13de62787e823
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
Committed into cassandra-4.0 at af17f136e58910fa23f1b8c6b8f13de62787e823 and
merged into trunk
> The clustering order logic in Materialized view creation changed in 4.0
> ---
>
> Key: CASSANDRA-16898
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16898
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Materialized Views
>Reporter: Benjamin Lerer
>Assignee: Benjamin Lerer
>Priority: Normal
> Fix For: 4.0.2
>
>
> Before 4.0, when a Materialized view was created with no {{CLUSTERING ORDER}}
> specified the clustering order was based on the base table clustering order
> (see [3.11
> code|https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/cql3/statements/CreateViewStatement.java#L108]).
> In 4.0 this behaviour changed and the clustering order was defaulted to ASC
> for all columns.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (a569803 -> 057f8e5)
This is an automated email from the ASF dual-hosted git repository. blerer pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from a569803 Merge branch 'cassandra-4.0' into trunk add af17f13 Fix clustering order logic in CREATE MATERIALIZED VIEW new 057f8e5 Merge branch cassandra-4.0 into trunk The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + .../statements/schema/CreateViewStatement.java | 19 +-- src/java/org/apache/cassandra/db/Columns.java | 1 - .../org/apache/cassandra/cql3/ViewSchemaTest.java | 134 + .../cql3/statements/DescribeStatementTest.java | 45 ++- 5 files changed, 190 insertions(+), 10 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch cassandra-4.0 into trunk
This is an automated email from the ASF dual-hosted git repository. blerer pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 057f8e5007d5c00d13e8af500b04b93b1eb7f855 Merge: a569803 af17f13 Author: Benjamin Lerer AuthorDate: Tue Aug 31 16:59:06 2021 +0200 Merge branch cassandra-4.0 into trunk CHANGES.txt| 1 + .../statements/schema/CreateViewStatement.java | 19 +-- src/java/org/apache/cassandra/db/Columns.java | 1 - .../org/apache/cassandra/cql3/ViewSchemaTest.java | 134 + .../cql3/statements/DescribeStatementTest.java | 45 ++- 5 files changed, 190 insertions(+), 10 deletions(-) diff --cc CHANGES.txt index 7b792e4,aef6fe1..17a5c99 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,27 -1,10 +1,28 @@@ -4.0.2 - * Fix clustering order logic in CREATE MATERIALIZED VIEW (CASSANDRA-16898) - -4.0.1 +4.1 * Exclude Jackson 1.x transitive dependency of hadoop* provided dependencies (CASSANDRA-16854) + * Add client warnings and abort to tombstone and coordinator reads which go past a low/high watermark (CASSANDRA-16850) + * Add TTL support to nodetool snapshots (CASSANDRA-16789) + * Allow CommitLogSegmentReader to optionally skip sync marker CRC checks (CASSANDRA-16842) + * allow blocking IPs from updating metrics about traffic (CASSANDRA-16859) + * Request-Based Native Transport Rate-Limiting (CASSANDRA-16663) + * Implement nodetool getauditlog command (CASSANDRA-16725) + * Clean up repair code (CASSANDRA-13720) + * Background schedule to clean up orphaned hints files (CASSANDRA-16815) + * Modify SecondaryIndexManager#indexPartition() to retrieve only columns for which indexes are actually being built (CASSANDRA-16776) + * Batch the token metadata update to improve the speed (CASSANDRA-15291) + * Reduce the log level on "expected" repair exceptions (CASSANDRA-16775) + * Make JMXTimer expose attributes using consistent time unit (CASSANDRA-16760) + * Remove check on gossip status from DynamicEndpointSnitch::updateScores (CASSANDRA-11671) + * Fix AbstractReadQuery::toCQLString not returning valid CQL (CASSANDRA-16510) + * Log when compacting many tombstones (CASSANDRA-16780) + * Display bytes per level in tablestats for LCS tables (CASSANDRA-16799) + * Add isolated flush timer to CommitLogMetrics and ensure writes correspond to single WaitingOnCommit data points (CASSANDRA-16701) + * Add a system property to set hostId if not yet initialized (CASSANDRA-14582) + * GossiperTest.testHasVersion3Nodes didn't take into account trunk version changes, fixed to rely on latest version (CASSANDRA-16651) +Merged from 4.0: ++ * Fix clustering order logic in CREATE MATERIALIZED VIEW (CASSANDRA-16898) * Tolerate missing DNS entry when completing a host replacement (CASSANDRA-16873) - * Harden PrunableArrayQueue against Pruner implementations that might throw exceptions (CASSANDRA-16866) + * Harden PrunableArrayQueue against Pruner implementations that might throw exceptions (CASSANDRA-16866) * Move RepairedDataInfo to the execution controller rather than the ReadCommand to avoid unintended sharing (CASSANDRA-16721) * Bump zstd-jni version to 1.5.0-4 (CASSANDRA-16884) * Remove assumption that all urgent messages are small (CASSANDRA-16877) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0 updated (78c6279 -> af17f13)
This is an automated email from the ASF dual-hosted git repository. blerer pushed a change to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 78c6279 Replace spinAsserts code with Awaitility code add af17f13 Fix clustering order logic in CREATE MATERIALIZED VIEW No new revisions were added by this update. Summary of changes: CHANGES.txt| 3 + .../statements/schema/CreateViewStatement.java | 19 +-- src/java/org/apache/cassandra/db/Columns.java | 1 - .../org/apache/cassandra/cql3/ViewSchemaTest.java | 134 + .../cql3/statements/DescribeStatementTest.java | 45 ++- 5 files changed, 192 insertions(+), 10 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16902) A user should be able to view permissions of role they created
[
https://issues.apache.org/jira/browse/CASSANDRA-16902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Lerer updated CASSANDRA-16902:
---
Reviewers: Benjamin Lerer
> A user should be able to view permissions of role they created
> --
>
> Key: CASSANDRA-16902
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16902
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Authorization
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
>
> Currently users are denied to view permissions to see a role they created:
> {code}
> CREATE ROLE parent WITH PASSWORD = 'x' AND LOGIN = true;
> GRANT CREATE ON ALL ROLES TO parent;
> LOGIN parent;
> CREATE ROLE child WITH PASSWORD = 'x' AND LOGIN = true;
> LIST ALL PERMISSIONS OF 'child'; -- You are not authorized to view child's
> permissions
> {code}
> When a user creates a role they should get the {{DESCRIBE}} permission on
> that role by default.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16894) Java 11 support - remove the experimental flag
[ https://issues.apache.org/jira/browse/CASSANDRA-16894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407385#comment-17407385 ] Ekaterina Dimitrova commented on CASSANDRA-16894: - [4.0 patch|https://github.com/ekaterinadimitrova2/cassandra/pull/new/CASSANDRA-16894-4.0] I am wondering only whether we want to say that it is not experimental anymore in 4.0.2 or what I did is enough. As soon as we agree on that, I will propagate also to trunk. [~mck], do you think you will have some time to take a look, please? > Java 11 support - remove the experimental flag > -- > > Key: CASSANDRA-16894 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16894 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x > > > As per this [thread. > |https://lists.apache.org/thread.html/r06a4768bae215dc19469491a1faec64dd90e1c3d4d10ed34b85ba248%40%3Cdev.cassandra.apache.org%3E]the > goal of this ticket is to remove the experimental flag for Java 11 support. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16894) Java 11 support - remove the experimental flag
[ https://issues.apache.org/jira/browse/CASSANDRA-16894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-16894: Test and Documentation Plan: https://issues.apache.org/jira/browse/CASSANDRA-16894?focusedCommentId=17407385=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17407385 Status: Patch Available (was: In Progress) > Java 11 support - remove the experimental flag > -- > > Key: CASSANDRA-16894 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16894 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x > > > As per this [thread. > |https://lists.apache.org/thread.html/r06a4768bae215dc19469491a1faec64dd90e1c3d4d10ed34b85ba248%40%3Cdev.cassandra.apache.org%3E]the > goal of this ticket is to remove the experimental flag for Java 11 support. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16891) WEBSITE - Update supported versions, mark 2.2 as EOL
[
https://issues.apache.org/jira/browse/CASSANDRA-16891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407381#comment-17407381
]
Michael Semb Wever commented on CASSANDRA-16891:
Change is on cassandra.staged.apache.org
> WEBSITE - Update supported versions, mark 2.2 as EOL
>
>
> Key: CASSANDRA-16891
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16891
> Project: Cassandra
> Issue Type: Task
> Components: Legacy/Documentation and Website
>Reporter: Erick Ramirez
>Assignee: Paul Au
>Priority: Normal
> Fix For: 4.0.x
>
> Attachments: CASSANDRA-16891-download-page.png
>
>
> The [Download|https://cassandra.apache.org/_/download.html] page incorrectly
> lists Cassandra 2.2 as:
> {quote}Apache Cassandra 2.2
> Released on 2020-11-04, and supported until 4.1 release (April 2022) with
> critical fixes only
> {quote}
> At this point, only Cassandra 3.0 is supported until the 4.1 release.
>
> !CASSANDRA-16891-download-page.png|width=300!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-16894) Java 11 support - remove the experimental flag
[ https://issues.apache.org/jira/browse/CASSANDRA-16894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova reassigned CASSANDRA-16894: --- Assignee: Ekaterina Dimitrova > Java 11 support - remove the experimental flag > -- > > Key: CASSANDRA-16894 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16894 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0.x > > > As per this [thread. > |https://lists.apache.org/thread.html/r06a4768bae215dc19469491a1faec64dd90e1c3d4d10ed34b85ba248%40%3Cdev.cassandra.apache.org%3E]the > goal of this ticket is to remove the experimental flag for Java 11 support. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16790) Add auto_snapshot_ttl configuration
[
https://issues.apache.org/jira/browse/CASSANDRA-16790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abuli Palagashvili updated CASSANDRA-16790:
---
Test and Documentation Plan: [pull
request|https://github.com/apache/cassandra/pull/1135]
Status: Patch Available (was: Open)
> Add auto_snapshot_ttl configuration
> ---
>
> Key: CASSANDRA-16790
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16790
> Project: Cassandra
> Issue Type: Sub-task
> Components: Local/Config
>Reporter: Paulo Motta
>Assignee: Abuli Palagashvili
>Priority: Normal
>
> This property should take a human readable parameter (ie. 6h, 3days). When
> specified and {{auto_snapshot: true}}, auto snapshots created should use the
> specified TTL.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16790) Add auto_snapshot_ttl configuration
[
https://issues.apache.org/jira/browse/CASSANDRA-16790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abuli Palagashvili updated CASSANDRA-16790:
---
Resolution: (was: Implemented)
Status: Open (was: Resolved)
> Add auto_snapshot_ttl configuration
> ---
>
> Key: CASSANDRA-16790
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16790
> Project: Cassandra
> Issue Type: Sub-task
> Components: Local/Config
>Reporter: Paulo Motta
>Assignee: Abuli Palagashvili
>Priority: Normal
>
> This property should take a human readable parameter (ie. 6h, 3days). When
> specified and {{auto_snapshot: true}}, auto snapshots created should use the
> specified TTL.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16790) Add auto_snapshot_ttl configuration
[
https://issues.apache.org/jira/browse/CASSANDRA-16790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abuli Palagashvili updated CASSANDRA-16790:
---
Resolution: Implemented
Status: Resolved (was: Triage Needed)
> Add auto_snapshot_ttl configuration
> ---
>
> Key: CASSANDRA-16790
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16790
> Project: Cassandra
> Issue Type: Sub-task
> Components: Local/Config
>Reporter: Paulo Motta
>Assignee: Abuli Palagashvili
>Priority: Normal
>
> This property should take a human readable parameter (ie. 6h, 3days). When
> specified and {{auto_snapshot: true}}, auto snapshots created should use the
> specified TTL.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16902) A user should be able to view permissions of role they created
[
https://issues.apache.org/jira/browse/CASSANDRA-16902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407313#comment-17407313
]
Andres de la Peña edited comment on CASSANDRA-16902 at 8/31/21, 12:47 PM:
--
The proposed patch adds {{DESCRIBE}} permissions to roles:
||PR||CI||
|[trunk|https://github.com/apache/cassandra/pull/1179]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/812/workflows/8727c0e0-2b78-4320-9e71-b2e93eee695d]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/812/workflows/37bc1376-00af-4822-82f7-0e09b45765cd]|
|[dtest|https://github.com/apache/cassandra-dtest/pull/157]|
Probably we should apply this fix to older branches.
All praise to [~snazy], who is the original author of the patch.
was (Author: adelapena):
The proposed patch add {{DESCRIBE}} permissions to roles:
||PR||CI||
|[trunk|https://github.com/apache/cassandra/pull/1179]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/812/workflows/8727c0e0-2b78-4320-9e71-b2e93eee695d]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/812/workflows/37bc1376-00af-4822-82f7-0e09b45765cd]|
|[dtest|https://github.com/apache/cassandra-dtest/pull/157]|
Probably we should apply this fix to older branches.
All praise to [~snazy], who is the original author of the patch.
> A user should be able to view permissions of role they created
> --
>
> Key: CASSANDRA-16902
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16902
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Authorization
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
>
> Currently users are denied to view permissions to see a role they created:
> {code}
> CREATE ROLE parent WITH PASSWORD = 'x' AND LOGIN = true;
> GRANT CREATE ON ALL ROLES TO parent;
> LOGIN parent;
> CREATE ROLE child WITH PASSWORD = 'x' AND LOGIN = true;
> LIST ALL PERMISSIONS OF 'child'; -- You are not authorized to view child's
> permissions
> {code}
> When a user creates a role they should get the {{DESCRIBE}} permission on
> that role by default.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16902) A user should be able to view permissions of role they created
[
https://issues.apache.org/jira/browse/CASSANDRA-16902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-16902:
--
Test and Documentation Plan: Dtests are modified to reflect the changes in
permissions
Status: Patch Available (was: In Progress)
> A user should be able to view permissions of role they created
> --
>
> Key: CASSANDRA-16902
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16902
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Authorization
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
>
> Currently users are denied to view permissions to see a role they created:
> {code}
> CREATE ROLE parent WITH PASSWORD = 'x' AND LOGIN = true;
> GRANT CREATE ON ALL ROLES TO parent;
> LOGIN parent;
> CREATE ROLE child WITH PASSWORD = 'x' AND LOGIN = true;
> LIST ALL PERMISSIONS OF 'child'; -- You are not authorized to view child's
> permissions
> {code}
> When a user creates a role they should get the {{DESCRIBE}} permission on
> that role by default.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16902) A user should be able to view permissions of role they created
[
https://issues.apache.org/jira/browse/CASSANDRA-16902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-16902:
--
Bug Category: Parent values: Code(13163)Level 1 values: Bug - Unclear
Impact(13164)
Complexity: Normal
Discovered By: User Report
Severity: Low
Status: Open (was: Triage Needed)
> A user should be able to view permissions of role they created
> --
>
> Key: CASSANDRA-16902
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16902
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Authorization
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
>
> Currently users are denied to view permissions to see a role they created:
> {code}
> CREATE ROLE parent WITH PASSWORD = 'x' AND LOGIN = true;
> GRANT CREATE ON ALL ROLES TO parent;
> LOGIN parent;
> CREATE ROLE child WITH PASSWORD = 'x' AND LOGIN = true;
> LIST ALL PERMISSIONS OF 'child'; -- You are not authorized to view child's
> permissions
> {code}
> When a user creates a role they should get the {{DESCRIBE}} permission on
> that role by default.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16902) A user should be able to view permissions of role they created
[
https://issues.apache.org/jira/browse/CASSANDRA-16902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407313#comment-17407313
]
Andres de la Peña commented on CASSANDRA-16902:
---
The proposed patch add {{DESCRIBE}} permissions to roles:
||PR||CI||
|[trunk|https://github.com/apache/cassandra/pull/1179]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/812/workflows/8727c0e0-2b78-4320-9e71-b2e93eee695d]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/812/workflows/37bc1376-00af-4822-82f7-0e09b45765cd]|
|[dtest|https://github.com/apache/cassandra-dtest/pull/157]|
Probably we should apply this fix to older branches.
All praise to [~snazy], who is the original author of the patch.
> A user should be able to view permissions of role they created
> --
>
> Key: CASSANDRA-16902
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16902
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Authorization
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
>
> Currently users are denied to view permissions to see a role they created:
> {code}
> CREATE ROLE parent WITH PASSWORD = 'x' AND LOGIN = true;
> GRANT CREATE ON ALL ROLES TO parent;
> LOGIN parent;
> CREATE ROLE child WITH PASSWORD = 'x' AND LOGIN = true;
> LIST ALL PERMISSIONS OF 'child'; -- You are not authorized to view child's
> permissions
> {code}
> When a user creates a role they should get the {{DESCRIBE}} permission on
> that role by default.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16902) A user should be able to view permissions of role they created
Andres de la Peña created CASSANDRA-16902:
-
Summary: A user should be able to view permissions of role they
created
Key: CASSANDRA-16902
URL: https://issues.apache.org/jira/browse/CASSANDRA-16902
Project: Cassandra
Issue Type: Bug
Components: Feature/Authorization
Reporter: Andres de la Peña
Assignee: Andres de la Peña
Currently users are denied to view permissions to see a role they created:
{code}
CREATE ROLE parent WITH PASSWORD = 'x' AND LOGIN = true;
GRANT CREATE ON ALL ROLES TO parent;
LOGIN parent;
CREATE ROLE child WITH PASSWORD = 'x' AND LOGIN = true;
LIST ALL PERMISSIONS OF 'child'; -- You are not authorized to view child's
permissions
{code}
When a user creates a role they should get the {{DESCRIBE}} permission on that
role by default.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14557) Consider adding default and required keyspace replication options
[
https://issues.apache.org/jira/browse/CASSANDRA-14557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407290#comment-17407290
]
Aleksei Zotov commented on CASSANDRA-14557:
---
[~sumanth.pasupuleti]
Thank you! I'm sorry for being scrupulous, but I put a few more comments to
[https://github.com/sumanth-pasupuleti/cassandra/commit/5deffedf07186f0af5f5dcf7436bc3a459ed6b42].
> Consider adding default and required keyspace replication options
> -
>
> Key: CASSANDRA-14557
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14557
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config
>Reporter: Sumanth Pasupuleti
>Assignee: Sumanth Pasupuleti
>Priority: Low
> Labels: 4.0-feature-freeze-review-requested
> Fix For: 4.x
>
> Attachments: 14557-4.0.txt, 14557-trunk.patch
>
>
> Ending up with a keyspace of RF=1 is unfortunately pretty easy in C* right
> now - the system_auth table for example is created with RF=1 (to take into
> account single node setups afaict from CASSANDRA-5112), and a user can
> further create a keyspace with RF=1 posing availability and streaming risks
> (e.g. rebuild).
> I propose we add two configuration options in cassandra.yaml:
> # {{default_keyspace_rf}} (default: 1) - If replication factors are not
> specified, use this number.
> # {{required_minimum_keyspace_rf}} (default: unset) - Prevent users from
> creating a keyspace with an RF less than what is configured
> These settings could further be re-used to:
> * Provide defaults for new keyspaces created with SimpleStrategy or
> NetworkTopologyStrategy (CASSANDRA-14303)
> * Make the automatic token [allocation
> algorithm|https://issues.apache.org/jira/browse/CASSANDRA-13701?focusedCommentId=16095662=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16095662]
> interface more intuitive allowing easy use of the new token allocation
> algorithm.
> At the end of the day, if someone really wants to allow RF=1, they simply
> don’t set the setting. For backwards compatibility the default remains 1 and
> C* would create with RF=1, and would default to current behavior of allowing
> any RF on keyspaces.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16666) Make SSLContext creation pluggable/extensible
[ https://issues.apache.org/jira/browse/CASSANDRA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407280#comment-17407280 ] Stefan Miklosovic commented on CASSANDRA-1: --- Hi Maulin, as I understand it, docs are under heavy-lifting right now so I would hold on for a moment until things will be more clear. > Make SSLContext creation pluggable/extensible > - > > Key: CASSANDRA-1 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1 > Project: Cassandra > Issue Type: Improvement > Components: Messaging/Internode >Reporter: Maulin Vasavada >Assignee: Maulin Vasavada >Priority: Normal > Fix For: 4.x > > > Currently Cassandra creates the SSLContext via SSLFactory.java. SSLFactory is > a final class with static methods and not overridable. The SSLFactory loads > the keys and certs from the file based artifacts for the same. While this > works for many, in the industry where security is stricter and contextual, > this approach falls short. Many big organizations need flexibility to load > the SSL artifacts from a custom resource (like custom Key Management > Solution, HashiCorp Vault, Amazon KMS etc). While JSSE SecurityProvider > architecture allows us flexibility to build our custom mechanisms to validate > and process security artifacts, many times all we need is to build upon > Java's existing extensibility that Trust/Key Manager interfaces provide to > load keystores from various resources in the absence of any customized > requirements on the Keys/Certificate formats. > My proposal here is to make the SSLContext creation pluggable/extensible and > have the current SSLFactory.java implement an extensible interface. > I contributed a similar change that is live now in Apache Kafka (2.6.0) - > https://issues.apache.org/jira/browse/KAFKA-8890 > I can spare some time writing the pluggable interface and run by the required > reviewers. > > Created [CEP-9: Make SSLContext creation > pluggable|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-9%3A+Make+SSLContext+creation+pluggable] > > > cc: [~dcapwell] [~djoshi] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16404) Provide a nodetool way of invalidating auth caches
[ https://issues.apache.org/jira/browse/CASSANDRA-16404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407244#comment-17407244 ] Aleksei Zotov commented on CASSANDRA-16404: --- [~samt] Were you able to check the dtest? > Provide a nodetool way of invalidating auth caches > -- > > Key: CASSANDRA-16404 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16404 > Project: Cassandra > Issue Type: Improvement > Components: Feature/Authorization >Reporter: Sumanth Pasupuleti >Assignee: Aleksei Zotov >Priority: Normal > Fix For: 4.x > > Time Spent: 1h > Remaining Estimate: 0h > > We currently have nodetool commands to invalidate certain caches like > KeyCache, RowCache and CounterCache. > Being able to invalidate auth caches as well can come in handy in situations > where, critical backend auth changes may need to be in effect right away for > all the connections, especially in configurations where cache validity is > chosen to be for a longer duration. An example can be that an authenticated > user "User1" is no longer authorized to access a table resource "table1" and > it is vital that this change is reflected right away, without having to wait > for cache expiry/refresh to trigger. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16806) Allow DELETE and TRUNCATE to work on Virtual Tables if the implementation allows it
[
https://issues.apache.org/jira/browse/CASSANDRA-16806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407236#comment-17407236
]
Aleksei Zotov commented on CASSANDRA-16806:
---
[~blerer]
I updated the PR with all the changes. Could you please take a look and provide
some feedback.
Summary of the PR:
* implemented TRUNCATE support
* implemented DELETE support
* added a restriction for custom timestamps
* updated unit tests
* added {{SimpleWritableVirtualTable}} for easier implementation of new VTs
What is not in the PR:
* support for complex type cell deletes
* restrictions for static columns, secondary indexes and materialized views
(at least need to check that they exist, I found none of them)
I'd like to address these items while working on VTs for auth caches.
> Allow DELETE and TRUNCATE to work on Virtual Tables if the implementation
> allows it
> ---
>
> Key: CASSANDRA-16806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16806
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/Virtual Tables
>Reporter: Benjamin Lerer
>Assignee: Aleksei Zotov
>Priority: Normal
> Fix For: 4.x
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> {{TRUNCATE}} statements are currently not supported by Virtual Tables. For
> some Virtual Tables it makes sense to allow it.
> It can be done by adding a {{truncate}} method to the {{VirtualTable}}
> interface and calling that method from {{TruncateStatement}}. The default
> implementation of the method should be to fire an {{InvalidRequestException}}
> saying that truncate is not supported on that specific table.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16761) New Cassandra Website and Documentation
[
https://issues.apache.org/jira/browse/CASSANDRA-16761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380763#comment-17380763
]
Michael Semb Wever edited comment on CASSANDRA-16761 at 8/31/21, 10:23 AM:
---
the antora built version of the new website design is on staging:
https://cassandra.staged.apache.org/
following manual steps were required, after the antora generation…
{code}
# push to staging, after having built with antora
git switch asf-staging
# copy everything to content/ directory
cp -r site-content/build/html/* content/
# move around the in-tree docs
rm -fR content/doc/4.0 content/doc/4.0.0 content/doc/3.11 content/doc/3.11.11
content/doc/stable content/doc/latest
cp -r content/Cassandra/3.11 content/doc/3.11.11
mv content/Cassandra/3.11 content/doc/
cp -r content/Cassandra/4.0 content/doc/4.0.0
cp -r content/Cassandra/4.0 content/doc/stable
cp -r content/Cassandra/4.0 content/doc/latest
mv content/Cassandra/4.0 content/doc/
# update the .htaccess file
nano content/.htaccess
# remove hardcoded domain name
for f in $(rg -l "https://cassandra.apache.org/; content/_) ; do sed -i ''
's/https:\/\/cassandra.apache.org\//\//g' $f ; done
git add content
git commit content
git push origin asf-staging
{code}
The {{.htaccess}} addition is
{code}
RedirectMatch 301 "^/$" "/_/index.html"
RewriteCond %{REQUEST_URI} !^/doc/.*
RewriteCond %{REQUEST_URI} ^(.*)/$
RewriteRule ^(.*)/$ /_/$1.html [R=301,L]
# temp – while in-tree antora are building to /Cassandra/
RewriteCond %{REQUEST_URI} !^/doc/.*
RewriteCond %{REQUEST_URI} ^/Cassandra/(.*)$
RewriteRule ^/?Cassandra/(.*)$ /doc/$1 [R=301,L]
# development in-tree docs have been moved to cassandra-website
RewriteCond %{REQUEST_URI} ^/doc/latest/development/(.+).html [NC]
RewriteRule ^/?doc/latest/development/(.+).html$ /_/development/$1.html
[R=301,L]
# redirects to new antora in-tree docs
RewriteCond %{REQUEST_URI} !^/doc/latest/index.html [NC]
RewriteCond %{REQUEST_URI} !^/doc/latest/cassandra [NC]
RewriteRule ^/?doc/latest/(.+)$ /doc/latest/cassandra/$1 [R=301,L]
RewriteCond %{REQUEST_URI} !^/doc/stable/index.html [NC]
RewriteCond %{REQUEST_URI} !^/doc/stable/cassandra [NC]
RewriteRule ^/?doc/stable/(.+)$ /doc/stable/cassandra/$1 [R=301,L]
RewriteCond %{REQUEST_URI} !^/doc/4.0/index.html [NC]
RewriteCond %{REQUEST_URI} !^/doc/4.0/cassandra [NC]
RewriteRule ^/?doc/4.0/(.+)$ /doc/4.0/cassandra/$1 [R=301,L]
RewriteCond %{REQUEST_URI} !^/doc/3.11/index.html [NC]
RewriteCond %{REQUEST_URI} !^/doc/3.11/cassandra [NC]
RewriteRule ^/?doc/3.11/(.+)$ /doc/3.11/cassandra/$1 [R=301,L]
{code}
was (Author: michaelsembwever):
the antora built version of the new website design is on staging:
https://cassandra.staged.apache.org/
following manual steps were required, after the antora generation…
{code}
# push to staging, after having built with antora
git switch asf-staging
# copy everything to content/ directory
cp -r site-content/build/html/* content/
cp content/_/index.html content/index.html
# move around the in-tree docs
rm -fR content/doc/4.0 content/doc/4.0.0 content/doc/3.11 content/doc/3.11.11
content/doc/stable content/doc/latest
cp -r content/Cassandra/3.11 content/doc/3.11.11
mv content/Cassandra/3.11 content/doc/
cp -r content/Cassandra/4.0 content/doc/4.0.0
cp -r content/Cassandra/4.0 content/doc/stable
cp -r content/Cassandra/4.0 content/doc/latest
mv content/Cassandra/4.0 content/doc/
# update the .htaccess file
nano content/.htaccess
# remove hardcoded domain name
for f in $(rg -l "https://cassandra.apache.org/; content/_) ; do sed -i ''
's/https:\/\/cassandra.apache.org\//\//g' $f ; done
git add content
git commit content
git push origin asf-staging
{code}
The {{.htaccess}} addition is
{code}
RedirectMatch 301 "^/$" "/_/index.html"
RewriteCond %{REQUEST_URI} !^/doc/.*
RewriteCond %{REQUEST_URI} ^(.*)/$
RewriteRule ^(.*)/$ /_/$1.html [R=301,L]
# temp – while in-tree antora are building to /Cassandra/
RewriteCond %{REQUEST_URI} !^/doc/.*
RewriteCond %{REQUEST_URI} ^/Cassandra/(.*)$
RewriteRule ^/?Cassandra/(.*)$ /doc/$1 [R=301,L]
# development in-tree docs have been moved to cassandra-website
RewriteCond %{REQUEST_URI} ^/doc/latest/development/(.+).html [NC]
RewriteRule ^/?doc/latest/development/(.+).html$ /_/development/$1.html
[R=301,L]
# redirects to new antora in-tree docs
RewriteCond %{REQUEST_URI} !^/doc/latest/index.html [NC]
RewriteCond %{REQUEST_URI} !^/doc/latest/cassandra [NC]
RewriteRule ^/?doc/latest/(.+)$ /doc/latest/cassandra/$1 [R=301,L]
RewriteCond %{REQUEST_URI} !^/doc/stable/index.html [NC]
RewriteCond %{REQUEST_URI} !^/doc/stable/cassandra [NC]
RewriteRule ^/?doc/stable/(.+)$ /doc/stable/cassandra/$1 [R=301,L]
RewriteCond %{REQUEST_URI} !^/doc/4.0/index.html [NC]
RewriteCond %{REQUEST_URI} !^/doc/4.0/cassandra [NC]
RewriteRule ^/?doc/4.0/(.+)$ /doc/4.0/cassandra/$1 [R=301,L]
RewriteCond %{REQUEST_URI}
[cassandra-website] branch asf-staging updated: remove old index.html
This is an automated email from the ASF dual-hosted git repository.
mck pushed a commit to branch asf-staging
in repository https://gitbox.apache.org/repos/asf/cassandra-website.git
The following commit(s) were added to refs/heads/asf-staging by this push:
new 5522933 remove old index.html
5522933 is described below
commit 55229332c68bd8590ebbe6b3cc95fd7f1139dcfc
Author: mck
AuthorDate: Tue Aug 31 12:23:23 2021 +0200
remove old index.html
---
content/index.html | 1069
1 file changed, 1069 deletions(-)
diff --git a/content/index.html b/content/index.html
deleted file mode 100644
index f7b6270..000
--- a/content/index.html
+++ /dev/null
@@ -1,1069 +0,0 @@
-
-
-
-
-
-Apache Cassandra | Apache Cassandra Documentation
-
-https://fonts.googleapis.com/css2?family=Open+Sans:ital,wght@0,400;0,700;1,400family=Red+Hat+Display:ital,wght@0,400;0,500;0,700;1,400;1,500display=swap;
rel="stylesheet">
-
-
-
-https://purl.org/dc/terms/;>
-
-
-
-
-
- const script = document.createElement("script");
- const domain = window.location.hostname;
- script.type = "text/javascript";
- script.src = "https://plausible.cassandra.apache.org/js/plausible.js";;
- script.setAttribute("data-domain",domain);
- script.setAttribute("defer",'true');
- script.setAttribute("async",'true');
- document.getElementsByTagName("head")[0].appendChild(script);
-
-
-
-https://ajax.googleapis.com/ajax/libs/jquery/3.6.0/jquery.min.js";>
-
-
- https://cassandra.apache.org; />
-
-
-
-
-https://cassandra.apache.org;>
-
-
-
-
-
-Get Started
-
-
-
-
-
-
-
-Cassandra Basics
-
-
-
-
-
-
-
-
-
-Quickstart
-
-
-
-
-
-
-
-
-
-Ecosystem
-
-
-
-
-
-Documentation
-
-Community
-
-
-
-
-
-
-
-Welcome
-
-
-
-
-
-
-
-
-
-Discussions
-
-
-
-
-
-
-
-
-
-Governance
-
-
-
-
-
-
-
-
-
-Contribute
-
-
-
-
-
-
-
-
-
-Meet the Community
-
-
-
-
-
-
-Learn
-
-
-
-
-
-
-
-Case Studies
-
-
-
-
-
-
-
-
-
-Resources
-
-
-
-
-
-
-
-
-
-Blog
-
-
-
-
-
-Download
Now
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-Open Source NoSQL Database
-Manage massive amounts of data, fast, without losing
sleep
-
-Learn More
-
-
-Quickstart
-
-
-
-
-
-
-
-
-
-
-
-
-Cassandra 4.0 is now GA! How did we deliver the most stable database
release ever shipped?
-
-
-
-
-
-
-Read the
Blog
-
-
-
-
-
-
-
-
-
-
-
-What is Apache Cassandra?
-Apache Cassandra is an open source NoSQL distributed
database trusted by thousands of companies for scalability and high
availability without compromising performance. Linear scalability and proven
fault-tolerance on commodity hardware or cloud
[jira] [Comment Edited] (CASSANDRA-16761) New Cassandra Website and Documentation
[
https://issues.apache.org/jira/browse/CASSANDRA-16761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380763#comment-17380763
]
Michael Semb Wever edited comment on CASSANDRA-16761 at 8/31/21, 10:18 AM:
---
the antora built version of the new website design is on staging:
https://cassandra.staged.apache.org/
following manual steps were required, after the antora generation…
{code}
# push to staging, after having built with antora
git switch asf-staging
# copy everything to content/ directory
cp -r site-content/build/html/* content/
cp content/_/index.html content/index.html
# move around the in-tree docs
rm -fR content/doc/4.0 content/doc/4.0.0 content/doc/3.11 content/doc/3.11.11
content/doc/stable content/doc/latest
cp -r content/Cassandra/3.11 content/doc/3.11.11
mv content/Cassandra/3.11 content/doc/
cp -r content/Cassandra/4.0 content/doc/4.0.0
cp -r content/Cassandra/4.0 content/doc/stable
cp -r content/Cassandra/4.0 content/doc/latest
mv content/Cassandra/4.0 content/doc/
# update the .htaccess file
nano content/.htaccess
# remove hardcoded domain name
for f in $(rg -l "https://cassandra.apache.org/; content/_) ; do sed -i ''
's/https:\/\/cassandra.apache.org\//\//g' $f ; done
git add content
git commit content
git push origin asf-staging
{code}
The {{.htaccess}} addition is
{code}
RedirectMatch 301 "^/$" "/_/index.html"
RewriteCond %{REQUEST_URI} !^/doc/.*
RewriteCond %{REQUEST_URI} ^(.*)/$
RewriteRule ^(.*)/$ /_/$1.html [R=301,L]
# temp – while in-tree antora are building to /Cassandra/
RewriteCond %{REQUEST_URI} !^/doc/.*
RewriteCond %{REQUEST_URI} ^/Cassandra/(.*)$
RewriteRule ^/?Cassandra/(.*)$ /doc/$1 [R=301,L]
# development in-tree docs have been moved to cassandra-website
RewriteCond %{REQUEST_URI} ^/doc/latest/development/(.+).html [NC]
RewriteRule ^/?doc/latest/development/(.+).html$ /_/development/$1.html
[R=301,L]
# redirects to new antora in-tree docs
RewriteCond %{REQUEST_URI} !^/doc/latest/index.html [NC]
RewriteCond %{REQUEST_URI} !^/doc/latest/cassandra [NC]
RewriteRule ^/?doc/latest/(.+)$ /doc/latest/cassandra/$1 [R=301,L]
RewriteCond %{REQUEST_URI} !^/doc/stable/index.html [NC]
RewriteCond %{REQUEST_URI} !^/doc/stable/cassandra [NC]
RewriteRule ^/?doc/stable/(.+)$ /doc/stable/cassandra/$1 [R=301,L]
RewriteCond %{REQUEST_URI} !^/doc/4.0/index.html [NC]
RewriteCond %{REQUEST_URI} !^/doc/4.0/cassandra [NC]
RewriteRule ^/?doc/4.0/(.+)$ /doc/4.0/cassandra/$1 [R=301,L]
RewriteCond %{REQUEST_URI} !^/doc/3.11/index.html [NC]
RewriteCond %{REQUEST_URI} !^/doc/3.11/cassandra [NC]
RewriteRule ^/?doc/3.11/(.+)$ /doc/3.11/cassandra/$1 [R=301,L]
{code}
was (Author: michaelsembwever):
the antora built version of the new website design is on staging:
https://cassandra.staged.apache.org/
following manual steps were required, after the antora generation…
{code}
# push to staging, after having built with antora
git switch asf-staging
# copy everything to content/ directory
cp -r site-content/build/html/* content/
# move around the in-tree docs
rm -fR content/doc/4.0 content/doc/4.0.0 content/doc/3.11 content/doc/3.11.11
content/doc/stable content/doc/latest
cp -r content/Cassandra/3.11 content/doc/3.11.11
mv content/Cassandra/3.11 content/doc/
cp -r content/Cassandra/4.0 content/doc/4.0.0
cp -r content/Cassandra/4.0 content/doc/stable
cp -r content/Cassandra/4.0 content/doc/latest
mv content/Cassandra/4.0 content/doc/
# update the .htaccess file
nano content/.htaccess
# remove hardcoded domain name
for f in $(rg -l "https://cassandra.apache.org/; content/_) ; do sed -i ''
's/https:\/\/cassandra.apache.org\//\//g' $f ; done
git add content
git commit content
git push origin asf-staging
{code}
The {{.htaccess}} addition is
{code}
RedirectMatch 301 "^/$" "/_/index.html"
RewriteCond %{REQUEST_URI} !^/doc/.*
RewriteCond %{REQUEST_URI} ^(.*)/$
RewriteRule ^(.*)/$ /_/$1.html [R=301,L]
# temp – while in-tree antora are building to /Cassandra/
RewriteCond %{REQUEST_URI} !^/doc/.*
RewriteCond %{REQUEST_URI} ^/Cassandra/(.*)$
RewriteRule ^/?Cassandra/(.*)$ /doc/$1 [R=301,L]
# development in-tree docs have been moved to cassandra-website
RewriteCond %{REQUEST_URI} ^/doc/latest/development/(.+).html [NC]
RewriteRule ^/?doc/latest/development/(.+).html$ /_/development/$1.html
[R=301,L]
# redirects to new antora in-tree docs
RewriteCond %{REQUEST_URI} !^/doc/latest/index.html [NC]
RewriteCond %{REQUEST_URI} !^/doc/latest/cassandra [NC]
RewriteRule ^/?doc/latest/(.+)$ /doc/latest/cassandra/$1 [R=301,L]
RewriteCond %{REQUEST_URI} !^/doc/stable/index.html [NC]
RewriteCond %{REQUEST_URI} !^/doc/stable/cassandra [NC]
RewriteRule ^/?doc/stable/(.+)$ /doc/stable/cassandra/$1 [R=301,L]
RewriteCond %{REQUEST_URI} !^/doc/4.0/index.html [NC]
RewriteCond %{REQUEST_URI} !^/doc/4.0/cassandra [NC]
RewriteRule ^/?doc/4.0/(.+)$ /doc/4.0/cassandra/$1 [R=301,L]
RewriteCond %{REQUEST_URI}
[jira] [Comment Edited] (CASSANDRA-16066) Create tooling and update repository layout to render new website
[
https://issues.apache.org/jira/browse/CASSANDRA-16066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17393398#comment-17393398
]
Michael Semb Wever edited comment on CASSANDRA-16066 at 8/31/21, 10:10 AM:
---
This work is already being used to deploy to the {{asf-staging}} and
{{asf-site}} branches.
Specifying the following steps:
{code}
cd cassandra-website
git switch anthony/CASSANDRA-16066_full_history
git pull
git switch paul/new-website
git pull
git rebase anthony/CASSANDRA-16066_full_history
./run.sh website-ui bundle
./run.sh website build -i -b cassandra:trunk,cassandra-3.11 -u
cassandra:https://github.com/polandll/cassandra.git -z
./site-ui/build/ui-bundle.zip
open site-content/build/html/_/index.html
# see parent ticket for further steps required before pushing to staging
{code}
Review Feedback:
- the doap.rdf file must remain (see why
[here|https://projects.apache.org/doap.html])
- the {{run.sh}} is intense. Could this have been python, or a makefile, for
the sake of encouraging contributors to it? (not a blocker)
- in {{site-content/Dockerfile}} the defaults should be
{code}
ENV ANTORA_SITE_URL="/"
ENV ANTORA_SITE_START_PAGE="_"
{code}
- currently the pull request contains 70 commits, many check-point and many
duplicated commits. It should only be ~6 commits, like the
{{anthony/CASSANDRA\-16066}} branch.
was (Author: michaelsembwever):
This work is already being used to deploy to the {{asf-staging}} and
{{asf-site}} branches.
Specifying the following steps:
{code}
cd cassandra-website
git switch anthony/CASSANDRA-16066_full_history
git pull
git switch paul/new-website
git pull
git rebase anthony/CASSANDRA-16066_full_history
./run.sh website-ui bundle
./run.sh website build -i -b cassandra:trunk,cassandra-3.11 -u
cassandra:https://github.com/polandll/cassandra.git -z
./site-ui/build/ui-bundle.zip
open site-content/build/html/_/home.html
# see parent ticket for further steps required before pushing to staging
{code}
Review Feedback:
- the doap.rdf file must remain (see why
[here|https://projects.apache.org/doap.html])
- the {{run.sh}} is intense. Could this have been python, or a makefile, for
the sake of encouraging contributors to it? (not a blocker)
- in {{site-content/Dockerfile}} the defaults should be
{code}
ENV ANTORA_SITE_URL="/"
ENV ANTORA_SITE_START_PAGE="_"
{code}
- currently the pull request contains 70 commits, many check-point and many
duplicated commits. It should only be ~6 commits, like the
{{anthony/CASSANDRA\-16066}} branch.
> Create tooling and update repository layout to render new website
> -
>
> Key: CASSANDRA-16066
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16066
> Project: Cassandra
> Issue Type: Task
> Components: Documentation/Website
>Reporter: Anthony Grasso
>Assignee: Michael Semb Wever
>Priority: Normal
> Labels: pull-request-available
> Attachments: image-2020-09-05-13-24-13-606.png,
> image-2020-09-06-07-17-14-705.png
>
>
> *We want to modernise the way the website is built*
> Rework the cassandra-website repository to generate a UI bundle containing
> resources that Antora will use when generating the Cassandra documents and
> website.
> *The existing method is starting to become dated*
> The documentation and website templates are currently in markdown format.
> Sphinx is used to generate the Cassandra documentation and Jekyll generates
> the website content. One of the major issues with the existing website
> tooling is that the live preview server (render site as it is being updated)
> is really slow. There is a preview server that is really fast, however it is
> unable to detect changes to the content and render automatically.
> *We are migrating the docs to be rendered with Antora*
> The work in CASSANDRA-16029 is converting the document templates to AsciiDoc
> format. Sphinx is being replaced by Antora to generate the documentation
> content. This change has two advantages:
> * More flexibility if the Apache Cassandra documentation look and feel needs
> to be updated or redesigned.
> * More modern look and feel to the documentation.
> *We can use Antora to generate the website as well*
> Antora could also be used to generate the Cassandra website content. As
> suggested on the [mailing
> list|https://www.mail-archive.com/dev@cassandra.apache.org/msg15577.html]
> this would require the existing markdown templates to be converted to
> AsciiDoc as well.
> *Antora needs a UI bundle to style content*
> For Antora to generate the document content and potentially the website
> content it requires a UI bundle (ui-bundle.zip). The UI bundle contains the
> HTML templates (layouts, partials, and helpers), CSS,
[jira] [Comment Edited] (CASSANDRA-16066) Create tooling and update repository layout to render new website
[
https://issues.apache.org/jira/browse/CASSANDRA-16066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17393398#comment-17393398
]
Michael Semb Wever edited comment on CASSANDRA-16066 at 8/31/21, 10:10 AM:
---
This work is already being used to deploy to the {{asf-staging}} and
{{asf-site}} branches.
Specifying the following steps:
{code}
cd cassandra-website
git switch anthony/CASSANDRA-16066_full_history
git pull
git switch paul/new-website
git pull
git rebase anthony/CASSANDRA-16066_full_history
./run.sh website-ui bundle
./run.sh website build -i -b cassandra:trunk,cassandra-3.11 -u
cassandra:https://github.com/polandll/cassandra.git -z
./site-ui/build/ui-bundle.zip
open site-content/build/html/_/home.html
# see parent ticket for further steps required before pushing to staging
{code}
Review Feedback:
- the doap.rdf file must remain (see why
[here|https://projects.apache.org/doap.html])
- the {{run.sh}} is intense. Could this have been python, or a makefile, for
the sake of encouraging contributors to it? (not a blocker)
- in {{site-content/Dockerfile}} the defaults should be
{code}
ENV ANTORA_SITE_URL="/"
ENV ANTORA_SITE_START_PAGE="_"
{code}
- currently the pull request contains 70 commits, many check-point and many
duplicated commits. It should only be ~6 commits, like the
{{anthony/CASSANDRA\-16066}} branch.
was (Author: michaelsembwever):
This work is already being used to deploy to the {{asf-staging}} and
{{asf-site}} branches.
Specifying the following steps:
{code}
cd cassandra-website
git switch anthony/CASSANDRA-16066_full_history
git pull
git switch paul/new-website
git pull
git rebase anthony/CASSANDRA-16066_full_history
./run.sh website-ui bundle
./run.sh website build -i -b cassandra:trunk,cassandra-3.11 -u
cassandra:https://github.com/polandll/cassandra.git -z
./site-ui/build/ui-bundle.zip
open site-content/build/html/Project/home.html
# see parent ticket for further steps required before pushing to staging
{code}
Review Feedback:
- the doap.rdf file must remain (see why
[here|https://projects.apache.org/doap.html])
- the {{run.sh}} is intense. Could this have been python, or a makefile, for
the sake of encouraging contributors to it? (not a blocker)
- in {{site-content/Dockerfile}} the defaults should be
{code}
ENV ANTORA_SITE_URL="/"
ENV ANTORA_SITE_START_PAGE="_"
{code}
- currently the pull request contains 70 commits, many check-point and many
duplicated commits. It should only be ~6 commits, like the
{{anthony/CASSANDRA\-16066}} branch.
> Create tooling and update repository layout to render new website
> -
>
> Key: CASSANDRA-16066
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16066
> Project: Cassandra
> Issue Type: Task
> Components: Documentation/Website
>Reporter: Anthony Grasso
>Assignee: Michael Semb Wever
>Priority: Normal
> Labels: pull-request-available
> Attachments: image-2020-09-05-13-24-13-606.png,
> image-2020-09-06-07-17-14-705.png
>
>
> *We want to modernise the way the website is built*
> Rework the cassandra-website repository to generate a UI bundle containing
> resources that Antora will use when generating the Cassandra documents and
> website.
> *The existing method is starting to become dated*
> The documentation and website templates are currently in markdown format.
> Sphinx is used to generate the Cassandra documentation and Jekyll generates
> the website content. One of the major issues with the existing website
> tooling is that the live preview server (render site as it is being updated)
> is really slow. There is a preview server that is really fast, however it is
> unable to detect changes to the content and render automatically.
> *We are migrating the docs to be rendered with Antora*
> The work in CASSANDRA-16029 is converting the document templates to AsciiDoc
> format. Sphinx is being replaced by Antora to generate the documentation
> content. This change has two advantages:
> * More flexibility if the Apache Cassandra documentation look and feel needs
> to be updated or redesigned.
> * More modern look and feel to the documentation.
> *We can use Antora to generate the website as well*
> Antora could also be used to generate the Cassandra website content. As
> suggested on the [mailing
> list|https://www.mail-archive.com/dev@cassandra.apache.org/msg15577.html]
> this would require the existing markdown templates to be converted to
> AsciiDoc as well.
> *Antora needs a UI bundle to style content*
> For Antora to generate the document content and potentially the website
> content it requires a UI bundle (ui-bundle.zip). The UI bundle contains the
> HTML templates (layouts, partials, and helpers), CSS,
[jira] [Assigned] (CASSANDRA-13874) nodetool setcachecapacity behaves oddly when cache disabled
[ https://issues.apache.org/jira/browse/CASSANDRA-13874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi reassigned CASSANDRA-13874: --- Assignee: Berenguer Blasi (was: Michal Szczepanski) > nodetool setcachecapacity behaves oddly when cache disabled > --- > > Key: CASSANDRA-13874 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13874 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core, Local/Config >Reporter: Jon Haddad >Assignee: Berenguer Blasi >Priority: Low > Labels: lhf, user-experience > Fix For: 3.11.x, 4.0.x, 4.x > > Attachments: 13874-trunk.txt > > > If a node has row cache disabled, trying to turn it on via setcachecapacity > doesn't issue an error, and doesn't turn it on, it just silently doesn't work. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-13874) nodetool setcachecapacity behaves oddly when cache disabled
[ https://issues.apache.org/jira/browse/CASSANDRA-13874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-13874: Test and Documentation Plan: See PR (was: See .txt) Status: Patch Available (was: In Progress) > nodetool setcachecapacity behaves oddly when cache disabled > --- > > Key: CASSANDRA-13874 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13874 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core, Local/Config >Reporter: Jon Haddad >Assignee: Michal Szczepanski >Priority: Low > Labels: lhf, user-experience > Fix For: 3.11.x, 4.0.x, 4.x > > Attachments: 13874-trunk.txt > > > If a node has row cache disabled, trying to turn it on via setcachecapacity > doesn't issue an error, and doesn't turn it on, it just silently doesn't work. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16762) Create content and UI components for new website
[ https://issues.apache.org/jira/browse/CASSANDRA-16762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-16762: --- Test and Documentation Plan: staging Status: Patch Available (was: In Progress) > Create content and UI components for new website > > > Key: CASSANDRA-16762 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16762 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Anthony Grasso >Assignee: Paul Au >Priority: High > > We need create the content (asciidoc) and UI components to render the website > using Antora. This work can commence once the following has happened: > * Website and documentation proof of concept is done - CASSANDRA-16029 > * Website design and concept is done - CASSANDRA-16115 > * Website and document tooling is done - CASSANDRA-16066 > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16762) Create content and UI components for new website
[ https://issues.apache.org/jira/browse/CASSANDRA-16762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407144#comment-17407144 ] Michael Semb Wever commented on CASSANDRA-16762: Patch for review: https://github.com/ossarga/cassandra-website/compare/ossarga:anthony/CASSANDRA-16066...ossarga:paul/new-website_squashed_rebased > Create content and UI components for new website > > > Key: CASSANDRA-16762 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16762 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Anthony Grasso >Assignee: Paul Au >Priority: High > > We need create the content (asciidoc) and UI components to render the website > using Antora. This work can commence once the following has happened: > * Website and documentation proof of concept is done - CASSANDRA-16029 > * Website design and concept is done - CASSANDRA-16115 > * Website and document tooling is done - CASSANDRA-16066 > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16762) Create content and UI components for new website
[ https://issues.apache.org/jira/browse/CASSANDRA-16762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-16762: --- Reviewers: Michael Semb Wever Status: Review In Progress (was: Patch Available) > Create content and UI components for new website > > > Key: CASSANDRA-16762 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16762 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Anthony Grasso >Assignee: Paul Au >Priority: High > > We need create the content (asciidoc) and UI components to render the website > using Antora. This work can commence once the following has happened: > * Website and documentation proof of concept is done - CASSANDRA-16029 > * Website design and concept is done - CASSANDRA-16115 > * Website and document tooling is done - CASSANDRA-16066 > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16066) Create tooling and update repository layout to render new website
[ https://issues.apache.org/jira/browse/CASSANDRA-16066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407133#comment-17407133 ] Michael Semb Wever commented on CASSANDRA-16066: Final patch for review: https://github.com/apache/cassandra-website/compare/trunk...ossarga:anthony/CASSANDRA-16066 > Create tooling and update repository layout to render new website > - > > Key: CASSANDRA-16066 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16066 > Project: Cassandra > Issue Type: Task > Components: Documentation/Website >Reporter: Anthony Grasso >Assignee: Michael Semb Wever >Priority: Normal > Labels: pull-request-available > Attachments: image-2020-09-05-13-24-13-606.png, > image-2020-09-06-07-17-14-705.png > > > *We want to modernise the way the website is built* > Rework the cassandra-website repository to generate a UI bundle containing > resources that Antora will use when generating the Cassandra documents and > website. > *The existing method is starting to become dated* > The documentation and website templates are currently in markdown format. > Sphinx is used to generate the Cassandra documentation and Jekyll generates > the website content. One of the major issues with the existing website > tooling is that the live preview server (render site as it is being updated) > is really slow. There is a preview server that is really fast, however it is > unable to detect changes to the content and render automatically. > *We are migrating the docs to be rendered with Antora* > The work in CASSANDRA-16029 is converting the document templates to AsciiDoc > format. Sphinx is being replaced by Antora to generate the documentation > content. This change has two advantages: > * More flexibility if the Apache Cassandra documentation look and feel needs > to be updated or redesigned. > * More modern look and feel to the documentation. > *We can use Antora to generate the website as well* > Antora could also be used to generate the Cassandra website content. As > suggested on the [mailing > list|https://www.mail-archive.com/dev@cassandra.apache.org/msg15577.html] > this would require the existing markdown templates to be converted to > AsciiDoc as well. > *Antora needs a UI bundle to style content* > For Antora to generate the document content and potentially the website > content it requires a UI bundle (ui-bundle.zip). The UI bundle contains the > HTML templates (layouts, partials, and helpers), CSS, JavaScript, fonts, and > (site-wide) images. As such, it provides both the visual theme and user > interactions for the documentation. Effectively the UI bundle is the > templates and styling that are applied to the documentation and website > content. > *The [cassandra-website|https://github.com/apache/cassandra-website] > repository can be used to generate the UI bundle* > All the resources associated with templating and styling the documentation > and website can be placed in the > [cassandra-website|https://github.com/apache/cassandra-website] repository. > In this case the repository would serve two purposes; > * Generation of the UI bundle resources. > * Serve the production website content. > *The [cassandra|https://github.com/apache/cassandra] repository would contain > the documentation material, while the rest of the non-versioned pages would > contain that material* > * All other material that is used to generate documentation would live in > the [cassandra|https://github.com/apache/cassandra] repository. In this case > Antora would run on the > [cassandra/doc|https://github.com/apache/cassandra/doc] directory and pull in > a UI bundle released on the GitHub > [cassandra-website|https://github.com/apache/cassandra-website] repository. > The content generated by Antora using the site.yml file located in this repo > can be used to preview the docs for review. > * All other non-versioned material, such as the blogs, development > instructions, and third-party page would live in the GitHub > [cassandra-website|https://github.com/apache/cassandra-website] repository. > Antora will generate the full website using the site.yml located in this > repo, using both as content sources the material located in both the > [cassandra|https://github.com/apache/cassandra] and > [cassandra-website|https://github.com/apache/cassandra-website] repositories. > *Design, content, and layout would remain the same* > This proposal means the roles of each repository will change. In addition, > the workflow to publish material will change as well. However, the website > design, content, and layout will remain the same. > As an added bonus the tooling would allow for a live preview server that is > fast and
