[jira] [Comment Edited] (CASSANDRA-16981) Respect com.sun.management.jxmremote.host
[ https://issues.apache.org/jira/browse/CASSANDRA-16981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423441#comment-17423441 ] Ekaterina Dimitrova edited comment on CASSANDRA-16981 at 10/1/21, 11:33 PM: I committed the Cassandra-builds patch [here |https://github.com/apache/cassandra-builds/commit/f42088d5e42d5aaaba3d272e58620a868e349fe8] but I will leave CircleCI to point to the old image over the weekend and test all branches(also 2.2) on Monday before I commit that change too. (to be sure there are no more weird surprises after pulling new versions of tools, etc - for reference CASSANDRA-17020) Also, one of the tests of my patch fails with Java 11 on 4.0 and trunk, I should investigate it on Monday. was (Author: e.dimitrova): I committed the Cassandra-builds patch [here |https://github.com/apache/cassandra-builds/commit/f42088d5e42d5aaaba3d272e58620a868e349fe8] but I will leave CircleCI to point to the old image over the weekend and test all branches(also 2.2) on Monday before I commit that change too. Also, one of the tests of my patch fails with Java 11 on 4.0 and trunk, I should investigate it on Monday. > Respect com.sun.management.jxmremote.host > -- > > Key: CASSANDRA-16981 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16981 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 3.11.x, 4.0.x, 4.x > > Attachments: Screenshot 2021-09-27 at 22.27.57.png > > > It seems we don't respect com.sun.management.jxmremote.host in > [createJMXServer()|https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/utils/JMXServerUtils.java#L64] > The flow should be - when_ local _is true, we only bind localhost, otherwise > we bind everything, unless com.sun.management.jmxremote.host is set, then we > use that. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16981) Respect com.sun.management.jxmremote.host
[ https://issues.apache.org/jira/browse/CASSANDRA-16981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423441#comment-17423441 ] Ekaterina Dimitrova commented on CASSANDRA-16981: - I committed the Cassandra-builds patch [here |https://github.com/apache/cassandra-builds/commit/f42088d5e42d5aaaba3d272e58620a868e349fe8] but I will leave CircleCI to point to the old image over the weekend and test all branches(also 2.2) on Monday before I commit that change too. Also, one of the tests of my patch fails with Java 11 on 4.0 and trunk, I should investigate it on Monday. > Respect com.sun.management.jxmremote.host > -- > > Key: CASSANDRA-16981 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16981 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 3.11.x, 4.0.x, 4.x > > Attachments: Screenshot 2021-09-27 at 22.27.57.png > > > It seems we don't respect com.sun.management.jxmremote.host in > [createJMXServer()|https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/utils/JMXServerUtils.java#L64] > The flow should be - when_ local _is true, we only bind localhost, otherwise > we bind everything, unless com.sun.management.jmxremote.host is set, then we > use that. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-builds] branch trunk updated: Install lsof and update the README file patch by Ekaterina Dimitrova; reviewed by Brandon Williams, Michael Semb Wever for CASSANDRA-16981
This is an automated email from the ASF dual-hosted git repository. edimitrova pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra-builds.git The following commit(s) were added to refs/heads/trunk by this push: new f42088d Install lsof and update the README file patch by Ekaterina Dimitrova; reviewed by Brandon Williams, Michael Semb Wever for CASSANDRA-16981 f42088d is described below commit f42088d5e42d5aaaba3d272e58620a868e349fe8 Author: Ekaterina Dimitrova AuthorDate: Sun Sep 26 13:18:36 2021 -0400 Install lsof and update the README file patch by Ekaterina Dimitrova; reviewed by Brandon Williams, Michael Semb Wever for CASSANDRA-16981 --- docker/testing/README.md | 1 + docker/testing/ubuntu2004_j11.docker | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/docker/testing/README.md b/docker/testing/README.md index 96ce247..1baaaf2 100644 --- a/docker/testing/README.md +++ b/docker/testing/README.md @@ -29,6 +29,7 @@ Caching image: Please make sure to always tag also by date, so we can go back to that version in case anything breaks after the next update! We are using Docker Hub for storing published images. See [Quick Start Guide](https://docs.docker.com/docker-hub/) on how to setup docker. +To push the image you will need to use your own Docker Hub account and open an Apache Jira ticket to Infra to add your account to the apache organization. ## Updating circleci.yml diff --git a/docker/testing/ubuntu2004_j11.docker b/docker/testing/ubuntu2004_j11.docker index 14bba2a..19521bb 100644 --- a/docker/testing/ubuntu2004_j11.docker +++ b/docker/testing/ubuntu2004_j11.docker @@ -21,7 +21,8 @@ RUN echo 'APT::Acquire::Retries "9";' > /etc/apt/apt.conf.d/80-retries RUN export DEBIAN_FRONTEND=noninteractive && \ apt-get update && \ -apt-get install -y --no-install-recommends software-properties-common apt-utils vim +apt-get install -y --no-install-recommends software-properties-common apt-utils vim && \ +apt-get install -y lsof RUN export DEBIAN_FRONTEND=noninteractive && \ add-apt-repository -y ppa:deadsnakes/ppa && \ - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17020) Cqlshlib failure
[ https://issues.apache.org/jira/browse/CASSANDRA-17020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17020: Test and Documentation Plan: https://issues.apache.org/jira/browse/CASSANDRA-17020?focusedCommentId=17423326=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17423326 Status: Patch Available (was: In Progress) > Cqlshlib failure > > > Key: CASSANDRA-17020 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17020 > Project: Cassandra > Issue Type: Bug > Components: CI >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x > > > Failing for 4.0 and trunk - > [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/3e76993a-8ff0-442b-ae19-e3c6abf09ee6/jobs/6670] > > Also 3.11 here - > https://jenkins-cm4.apache.org/job/Cassandra-devbranch/1152/#showFailuresLink > > /CC [~brandon.williams] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17020) Cqlshlib failure
[ https://issues.apache.org/jira/browse/CASSANDRA-17020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17020: Reviewers: Ekaterina Dimitrova, Ekaterina Dimitrova (was: Ekaterina Dimitrova) Ekaterina Dimitrova, Ekaterina Dimitrova Status: Review In Progress (was: Patch Available) > Cqlshlib failure > > > Key: CASSANDRA-17020 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17020 > Project: Cassandra > Issue Type: Bug > Components: CI >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x > > > Failing for 4.0 and trunk - > [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/3e76993a-8ff0-442b-ae19-e3c6abf09ee6/jobs/6670] > > Also 3.11 here - > https://jenkins-cm4.apache.org/job/Cassandra-devbranch/1152/#showFailuresLink > > /CC [~brandon.williams] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-17020) Cqlshlib failure
[ https://issues.apache.org/jira/browse/CASSANDRA-17020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova reassigned CASSANDRA-17020: --- Assignee: Brandon Williams > Cqlshlib failure > > > Key: CASSANDRA-17020 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17020 > Project: Cassandra > Issue Type: Bug > Components: CI >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x > > > Failing for 4.0 and trunk - > [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/3e76993a-8ff0-442b-ae19-e3c6abf09ee6/jobs/6670] > > Also 3.11 here - > https://jenkins-cm4.apache.org/job/Cassandra-devbranch/1152/#showFailuresLink > > /CC [~brandon.williams] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-17021) Enhance Zstd support in Cassandra with dictionaries
Dinesh Joshi created CASSANDRA-17021: Summary: Enhance Zstd support in Cassandra with dictionaries Key: CASSANDRA-17021 URL: https://issues.apache.org/jira/browse/CASSANDRA-17021 Project: Cassandra Issue Type: Improvement Components: Feature/Compression Reporter: Dinesh Joshi Assignee: Yifan Cai Currently Cassandra supports zstd compression. However, Zstd also supports dictionaries to enhance not only the compression ratio but also the speed. Dictionaries can show 3-4x savings. We should add support to train dictionaries, ideally per SSTable this will yield the maximum gains. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17020) Cqlshlib failure
[ https://issues.apache.org/jira/browse/CASSANDRA-17020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423439#comment-17423439 ] Ekaterina Dimitrova commented on CASSANDRA-17020: - I found that the same issue with the paths is appearing from time to time - like I found logs for it on the 3.0 branch from a week ago. Eventually the next builds were fine. Maybe [~mck] will know already something about that. I pushed 3.0, 3.11, 4.0, trunk tests as I had to test also one patch I have. 3.0 cqlsh finished [ok| https://ci-cassandra.apache.org/job/Cassandra-devbranch-cqlsh-tests/1074/], 3.11 [also finished fine |https://jenkins-cm4.apache.org/job/Cassandra-devbranch-cqlsh-tests/1073/#showFailuresLink] in the sense the logs look fine, there are some failing tests that we already know from before. > Cqlshlib failure > > > Key: CASSANDRA-17020 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17020 > Project: Cassandra > Issue Type: Bug > Components: CI >Reporter: Ekaterina Dimitrova >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x > > > Failing for 4.0 and trunk - > [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/3e76993a-8ff0-442b-ae19-e3c6abf09ee6/jobs/6670] > > Also 3.11 here - > https://jenkins-cm4.apache.org/job/Cassandra-devbranch/1152/#showFailuresLink > > /CC [~brandon.williams] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16986) DROP Table should not recycle active CommitLog segments
[
https://issues.apache.org/jira/browse/CASSANDRA-16986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423436#comment-17423436
]
Caleb Rackliffe commented on CASSANDRA-16986:
-
[~Ge] Does this need a committer?
> DROP Table should not recycle active CommitLog segments
> ---
>
> Key: CASSANDRA-16986
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16986
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Commit Log
>Reporter: Aleksandr Sorokoumov
>Assignee: Aleksandr Sorokoumov
>Priority: Low
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> Right now, DROP TABLE recycles all active CL segments and explicitly marks
> intervals as clean for all dropping tables. I believe that this is not
> necessary.
> Recycling of CL segments was introduced in CASSANDRA-3578. Back then, it was
> necessary to recycle all active segments because:
> 1. CommitLog reused old segments after they were clean. This is no longer the
> case, I believe, since CASSANDRA-6809.
> 2. CommitLog segments must have been closed and recycled on {{DROP TABLE}} to
> avoid resurrecting data if a table with the same name is created. This was an
> issue because tables didn't have unique ids yet (CASSANDRA-5202).
> Given that {{DROP TABLE}} triggers flush, which in turn cleans CL intervals
> in Keyspace#unloadCF, I think that we can avoid the call to
> {{forceRecycleAll}} there.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16996) Prevent broken concurrent schema read/writes
[ https://issues.apache.org/jira/browse/CASSANDRA-16996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423435#comment-17423435 ] Caleb Rackliffe commented on CASSANDRA-16996: - Just made a pass at the PR, and dropped some comments. Looks like it's headed in the right direction. > Prevent broken concurrent schema read/writes > > > Key: CASSANDRA-16996 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16996 > Project: Cassandra > Issue Type: Bug > Components: Cluster/Schema >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 3.11.x, 4.0, 4.x > > > See CASSANDRA-16856 where the concurrent read/write path was left out -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16981) Respect com.sun.management.jxmremote.host
[ https://issues.apache.org/jira/browse/CASSANDRA-16981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423387#comment-17423387 ] Ekaterina Dimitrova commented on CASSANDRA-16981: - I updated the links after I rebased on top of the fix for the latest issues from CASSANDRA-17020. Also, submitted Jenkins runs #1162, #1164, #1166. > Respect com.sun.management.jxmremote.host > -- > > Key: CASSANDRA-16981 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16981 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 3.11.x, 4.0.x, 4.x > > Attachments: Screenshot 2021-09-27 at 22.27.57.png > > > It seems we don't respect com.sun.management.jxmremote.host in > [createJMXServer()|https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/utils/JMXServerUtils.java#L64] > The flow should be - when_ local _is true, we only bind localhost, otherwise > we bind everything, unless com.sun.management.jmxremote.host is set, then we > use that. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16981) Respect com.sun.management.jxmremote.host
[ https://issues.apache.org/jira/browse/CASSANDRA-16981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423387#comment-17423387 ] Ekaterina Dimitrova edited comment on CASSANDRA-16981 at 10/1/21, 5:52 PM: --- I updated the links after I rebased on top of the fix for the latest issues from CASSANDRA-17020. Also, submitted Jenkins runs #1162(3.11), #1164(4.0), #1166(trunk). was (Author: e.dimitrova): I updated the links after I rebased on top of the fix for the latest issues from CASSANDRA-17020. Also, submitted Jenkins runs #1162, #1164, #1166. > Respect com.sun.management.jxmremote.host > -- > > Key: CASSANDRA-16981 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16981 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 3.11.x, 4.0.x, 4.x > > Attachments: Screenshot 2021-09-27 at 22.27.57.png > > > It seems we don't respect com.sun.management.jxmremote.host in > [createJMXServer()|https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/utils/JMXServerUtils.java#L64] > The flow should be - when_ local _is true, we only bind localhost, otherwise > we bind everything, unless com.sun.management.jmxremote.host is set, then we > use that. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16981) Respect com.sun.management.jxmremote.host
[ https://issues.apache.org/jira/browse/CASSANDRA-16981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423057#comment-17423057 ] Ekaterina Dimitrova edited comment on CASSANDRA-16981 at 10/1/21, 5:44 PM: --- It seems the builds and the new 3.11 tests were fine. For the record, the ongoing Jenkins issue started before I pushed the image and it is not related. ||Patch||CI|| |[3.11|https://github.com/ekaterinadimitrova2/cassandra/commit/1f987f43ea2bc7bcac2ddfab9852026efa9ed133]|[Circle|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1136/workflows/2cb30763-d93f-479e-b23e-dc51b98011ed], [Jenkins|https://jenkins-cm4.apache.org/job/Cassandra-devbranch/1152/]| |[4.0|https://github.com/ekaterinadimitrova2/cassandra/pull/182/commits/1e2e1871dddc7a21b20dcb81e4b9ec6f594fafac]|[j8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1138/workflows/cd63ae56-abc3-4f8f-acbd-4713e0eda300], [j11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1138/workflows/e0e1a731-82e8-4bda-ada3-38e34a6004b7]| |[trunk|https://github.com/apache/cassandra/commit/3bdb364edc97839f094fa4a95e445099c3c9ec2a]|[j8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1139/workflows/bdc826bf-05e9-42fc-a123-0ce89c1cb4f7], [j11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1139/workflows/38601c8e-52ab-42ca-b750-dc771e7d3274]| I propagated the patch to all branches and pushed build and unit tests. Should be fine. I can submit full Jenkins build when we solved the issues there was (Author: e.dimitrova): It seems the builds and the new 3.11 tests were fine. For the record, the ongoing Jenkins issue started before I pushed the image and it is not related. ||Patch||CI|| |[3.11|https://github.com/ekaterinadimitrova2/cassandra/commit/1f987f43ea2bc7bcac2ddfab9852026efa9ed133]|[Circle|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1136/workflows/2cb30763-d93f-479e-b23e-dc51b98011ed], [Jenkins|https://jenkins-cm4.apache.org/job/Cassandra-devbranch/1152/]| |[4.0|https://github.com/ekaterinadimitrova2/cassandra/pull/182/commits/1e2e1871dddc7a21b20dcb81e4b9ec6f594fafac]|[j8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1138/workflows/cd63ae56-abc3-4f8f-acbd-4713e0eda300], [j11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1138/workflows/e0e1a731-82e8-4bda-ada3-38e34a6004b7]| |[trunk|https://github.com/apache/cassandra/commit/3bdb364edc97839f094fa4a95e445099c3c9ec2a]|[j8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/3e76993a-8ff0-442b-ae19-e3c6abf09ee6], [j11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/a36af32c-ce61-47cf-b0bd-f8343025ca05]| I propagated the patch to all branches and pushed build and unit tests. Should be fine. I can submit full Jenkins build when we solved the issues there > Respect com.sun.management.jxmremote.host > -- > > Key: CASSANDRA-16981 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16981 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 3.11.x, 4.0.x, 4.x > > Attachments: Screenshot 2021-09-27 at 22.27.57.png > > > It seems we don't respect com.sun.management.jxmremote.host in > [createJMXServer()|https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/utils/JMXServerUtils.java#L64] > The flow should be - when_ local _is true, we only bind localhost, otherwise > we bind everything, unless com.sun.management.jmxremote.host is set, then we > use that. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16981) Respect com.sun.management.jxmremote.host
[ https://issues.apache.org/jira/browse/CASSANDRA-16981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423057#comment-17423057 ] Ekaterina Dimitrova edited comment on CASSANDRA-16981 at 10/1/21, 5:35 PM: --- It seems the builds and the new 3.11 tests were fine. For the record, the ongoing Jenkins issue started before I pushed the image and it is not related. ||Patch||CI|| |[3.11|https://github.com/ekaterinadimitrova2/cassandra/commit/1f987f43ea2bc7bcac2ddfab9852026efa9ed133]|[Circle|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1136/workflows/2cb30763-d93f-479e-b23e-dc51b98011ed], [Jenkins|https://jenkins-cm4.apache.org/job/Cassandra-devbranch/1152/]| |[4.0|https://github.com/ekaterinadimitrova2/cassandra/pull/182/commits/1e2e1871dddc7a21b20dcb81e4b9ec6f594fafac]|[j8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1138/workflows/cd63ae56-abc3-4f8f-acbd-4713e0eda300], [j11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1138/workflows/e0e1a731-82e8-4bda-ada3-38e34a6004b7]| |[trunk|https://github.com/apache/cassandra/commit/3bdb364edc97839f094fa4a95e445099c3c9ec2a]|[j8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/3e76993a-8ff0-442b-ae19-e3c6abf09ee6], [j11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/a36af32c-ce61-47cf-b0bd-f8343025ca05]| I propagated the patch to all branches and pushed build and unit tests. Should be fine. I can submit full Jenkins build when we solved the issues there was (Author: e.dimitrova): It seems the builds and the new 3.11 tests were fine. For the record, the ongoing Jenkins issue started before I pushed the image and it is not related. ||Patch||CI|| |[3.11|https://github.com/ekaterinadimitrova2/cassandra/commit/1f987f43ea2bc7bcac2ddfab9852026efa9ed133]|[Circle|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1136/workflows/2cb30763-d93f-479e-b23e-dc51b98011ed], [Jenkins|https://jenkins-cm4.apache.org/job/Cassandra-devbranch/1152/]| |[4.0|https://github.com/ekaterinadimitrova2/cassandra/pull/182/commits/1e2e1871dddc7a21b20dcb81e4b9ec6f594fafac]|[j8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1137/workflows/a5704d93-eec8-4930-85a0-bfcfe8f7818b], [j11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1137/workflows/dc9b54f4-a175-4662-b7a3-7aadf8cde41c]| |[trunk|https://github.com/apache/cassandra/commit/3bdb364edc97839f094fa4a95e445099c3c9ec2a]|[j8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/3e76993a-8ff0-442b-ae19-e3c6abf09ee6], [j11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/a36af32c-ce61-47cf-b0bd-f8343025ca05]| I propagated the patch to all branches and pushed build and unit tests. Should be fine. I can submit full Jenkins build when we solved the issues there > Respect com.sun.management.jxmremote.host > -- > > Key: CASSANDRA-16981 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16981 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 3.11.x, 4.0.x, 4.x > > Attachments: Screenshot 2021-09-27 at 22.27.57.png > > > It seems we don't respect com.sun.management.jxmremote.host in > [createJMXServer()|https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/utils/JMXServerUtils.java#L64] > The flow should be - when_ local _is true, we only bind localhost, otherwise > we bind everything, unless com.sun.management.jmxremote.host is set, then we > use that. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16981) Respect com.sun.management.jxmremote.host
[ https://issues.apache.org/jira/browse/CASSANDRA-16981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423057#comment-17423057 ] Ekaterina Dimitrova edited comment on CASSANDRA-16981 at 10/1/21, 5:32 PM: --- It seems the builds and the new 3.11 tests were fine. For the record, the ongoing Jenkins issue started before I pushed the image and it is not related. ||Patch||CI|| |[3.11|https://github.com/ekaterinadimitrova2/cassandra/commit/1f987f43ea2bc7bcac2ddfab9852026efa9ed133]|[Circle|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1136/workflows/2cb30763-d93f-479e-b23e-dc51b98011ed], [Jenkins|https://jenkins-cm4.apache.org/job/Cassandra-devbranch/1152/]| |[4.0|https://github.com/ekaterinadimitrova2/cassandra/pull/182/commits/1e2e1871dddc7a21b20dcb81e4b9ec6f594fafac]|[j8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1137/workflows/a5704d93-eec8-4930-85a0-bfcfe8f7818b], [j11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1137/workflows/dc9b54f4-a175-4662-b7a3-7aadf8cde41c]| |[trunk|https://github.com/apache/cassandra/commit/3bdb364edc97839f094fa4a95e445099c3c9ec2a]|[j8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/3e76993a-8ff0-442b-ae19-e3c6abf09ee6], [j11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/a36af32c-ce61-47cf-b0bd-f8343025ca05]| I propagated the patch to all branches and pushed build and unit tests. Should be fine. I can submit full Jenkins build when we solved the issues there was (Author: e.dimitrova): It seems the builds and the new 3.11 tests were fine. For the record, the ongoing Jenkins issue started before I pushed the image and it is not related. ||Patch||CI|| |[3.11|https://github.com/ekaterinadimitrova2/cassandra/commit/1f987f43ea2bc7bcac2ddfab9852026efa9ed133]|[Circle|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1136/workflows/2cb30763-d93f-479e-b23e-dc51b98011ed], [Jenkins|https://jenkins-cm4.apache.org/job/Cassandra-devbranch/1152/]| |[4.0|https://github.com/ekaterinadimitrova2/cassandra/pull/182/commits/1e2e1871dddc7a21b20dcb81e4b9ec6f594fafac]|[j8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1134/workflows/82fc0892-6978-41e3-b234-840b24d13fb0], [j11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=16981-4.0]| |[trunk|https://github.com/apache/cassandra/commit/3bdb364edc97839f094fa4a95e445099c3c9ec2a]|[j8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/3e76993a-8ff0-442b-ae19-e3c6abf09ee6], [j11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/a36af32c-ce61-47cf-b0bd-f8343025ca05]| I propagated the patch to all branches and pushed build and unit tests. Should be fine. I can submit full Jenkins build when we solved the issues there > Respect com.sun.management.jxmremote.host > -- > > Key: CASSANDRA-16981 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16981 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 3.11.x, 4.0.x, 4.x > > Attachments: Screenshot 2021-09-27 at 22.27.57.png > > > It seems we don't respect com.sun.management.jxmremote.host in > [createJMXServer()|https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/utils/JMXServerUtils.java#L64] > The flow should be - when_ local _is true, we only bind localhost, otherwise > we bind everything, unless com.sun.management.jmxremote.host is set, then we > use that. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16981) Respect com.sun.management.jxmremote.host
[ https://issues.apache.org/jira/browse/CASSANDRA-16981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423057#comment-17423057 ] Ekaterina Dimitrova edited comment on CASSANDRA-16981 at 10/1/21, 5:18 PM: --- It seems the builds and the new 3.11 tests were fine. For the record, the ongoing Jenkins issue started before I pushed the image and it is not related. ||Patch||CI|| |[3.11|https://github.com/ekaterinadimitrova2/cassandra/commit/1f987f43ea2bc7bcac2ddfab9852026efa9ed133]|[Circle|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1136/workflows/2cb30763-d93f-479e-b23e-dc51b98011ed], [Jenkins|https://jenkins-cm4.apache.org/job/Cassandra-devbranch/1152/]| |[4.0|https://github.com/ekaterinadimitrova2/cassandra/pull/182/commits/1e2e1871dddc7a21b20dcb81e4b9ec6f594fafac]|[j8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1134/workflows/82fc0892-6978-41e3-b234-840b24d13fb0], [j11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=16981-4.0]| |[trunk|https://github.com/apache/cassandra/commit/3bdb364edc97839f094fa4a95e445099c3c9ec2a]|[j8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/3e76993a-8ff0-442b-ae19-e3c6abf09ee6], [j11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/a36af32c-ce61-47cf-b0bd-f8343025ca05]| I propagated the patch to all branches and pushed build and unit tests. Should be fine. I can submit full Jenkins build when we solved the issues there was (Author: e.dimitrova): It seems the builds and the new 3.11 tests were fine. For the record, the ongoing Jenkins issue started before I pushed the image and it is not related. ||Patch||CI|| |[3.11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1136/workflows/2cb30763-d93f-479e-b23e-dc51b98011ed]|[Circle|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1131/workflows/52ed7138-c1ab-4604-bfc9-d68c8ba1292c], [Jenkins|https://jenkins-cm4.apache.org/job/Cassandra-devbranch/1152/]| |[4.0|https://github.com/ekaterinadimitrova2/cassandra/pull/182/commits/1e2e1871dddc7a21b20dcb81e4b9ec6f594fafac]|[j8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1134/workflows/82fc0892-6978-41e3-b234-840b24d13fb0], [j11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=16981-4.0]| |[trunk|https://github.com/apache/cassandra/commit/3bdb364edc97839f094fa4a95e445099c3c9ec2a]|[j8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/3e76993a-8ff0-442b-ae19-e3c6abf09ee6], [j11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/a36af32c-ce61-47cf-b0bd-f8343025ca05]| I propagated the patch to all branches and pushed build and unit tests. Should be fine. I can submit full Jenkins build when we solved the issues there > Respect com.sun.management.jxmremote.host > -- > > Key: CASSANDRA-16981 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16981 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 3.11.x, 4.0.x, 4.x > > Attachments: Screenshot 2021-09-27 at 22.27.57.png > > > It seems we don't respect com.sun.management.jxmremote.host in > [createJMXServer()|https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/utils/JMXServerUtils.java#L64] > The flow should be - when_ local _is true, we only bind localhost, otherwise > we bind everything, unless com.sun.management.jmxremote.host is set, then we > use that. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16879) Verify correct ownership of attached locations on disk at C* startup
[ https://issues.apache.org/jira/browse/CASSANDRA-16879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423369#comment-17423369 ] Caleb Rackliffe commented on CASSANDRA-16879: - +1 > Verify correct ownership of attached locations on disk at C* startup > > > Key: CASSANDRA-16879 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16879 > Project: Cassandra > Issue Type: Improvement > Components: Local/Startup and Shutdown >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Fix For: 4.x > > > There's two primary things related to startup and disk ownership we should > mitigate. > First, an instance can come up with an incorrectly mounted volume attached as > its configured data directory. This causes the wrong system tables to be > read. If the instance which was previously using the volume is also down, its > token could be taken over by the instance coming up. > Secondly, in a JBOD setup, the non-system keyspaces may reside on a separate > volume to the system tables. In this scenario, we need to ensure that all > directories belong to the same instance, and that as the instance starts up > it can access all the directories it expects to be able to. (including data, > commit log, hints and saved cache dirs) > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-12106) Add ability to blocklist / denylist a CQL partition so all requests are ignored
[ https://issues.apache.org/jira/browse/CASSANDRA-12106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McKenzie updated CASSANDRA-12106: -- Test and Documentation Plan: New documentation to be written when API is settled upon from review. Status: Patch Available (was: Open) > Add ability to blocklist / denylist a CQL partition so all requests are > ignored > --- > > Key: CASSANDRA-12106 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12106 > Project: Cassandra > Issue Type: New Feature > Components: Legacy/Local Write-Read Paths, Local/Config >Reporter: Geoffrey Yu >Assignee: Josh McKenzie >Priority: Low > Fix For: 4.x > > Attachments: 12106-trunk.txt > > > Sometimes reads/writes to a given partition may cause problems due to the > data present. It would be useful to have a manual way to blocklist / denylist > such partitions so all read and write requests to them are rejected. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16879) Verify correct ownership of attached locations on disk at C* startup
[ https://issues.apache.org/jira/browse/CASSANDRA-16879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh McKenzie updated CASSANDRA-16879: -- Status: Patch Available (was: In Progress) > Verify correct ownership of attached locations on disk at C* startup > > > Key: CASSANDRA-16879 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16879 > Project: Cassandra > Issue Type: Improvement > Components: Local/Startup and Shutdown >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Fix For: 4.x > > > There's two primary things related to startup and disk ownership we should > mitigate. > First, an instance can come up with an incorrectly mounted volume attached as > its configured data directory. This causes the wrong system tables to be > read. If the instance which was previously using the volume is also down, its > token could be taken over by the instance coming up. > Secondly, in a JBOD setup, the non-system keyspaces may reside on a separate > volume to the system tables. In this scenario, we need to ensure that all > directories belong to the same instance, and that as the instance starts up > it can access all the directories it expects to be able to. (including data, > commit log, hints and saved cache dirs) > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15252) Don't consider current keyspace in prepared statement id when the query is qualified
[
https://issues.apache.org/jira/browse/CASSANDRA-15252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Petrov updated CASSANDRA-15252:
Fix Version/s: 4.1
4.0.2
3.11.12
3.0.26
Since Version: 3.0.0
Source Control Link:
https://github.com/apache/cassandra/commit/13632e9a99e8256a565bd6919d2d11b3e476e973
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> Don't consider current keyspace in prepared statement id when the query is
> qualified
>
>
> Key: CASSANDRA-15252
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15252
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Client
>Reporter: Olivier Michallat
>Assignee: Alex Petrov
>Priority: Normal
> Fix For: 3.0.26, 3.11.12, 4.0.2, 4.1
>
>
> {{QueryProcessor.computeId}} takes into account the session's current
> keyspace in the MD5 digest.
> {code}
> String toHash = keyspace == null ? queryString : keyspace + queryString;
> {code}
> This is desirable for unqualified queries, because switching to a different
> keyspace produces a different statement. However, for a qualified query, the
> current keyspace makes no difference, the prepared id should always be the
> same.
> This can lead to an infinite reprepare loop on the client. Consider this
> example (Java driver 3.x):
> {code}
> Cluster cluster = null;
> try {
> cluster = Cluster.builder().addContactPoint("127.0.0.1").build();
> Session session = cluster.connect();
> session.execute(
> "CREATE KEYSPACE IF NOT EXISTS test WITH replication = {'class':
> 'SimpleStrategy', 'replication_factor': 1}");
> session.execute("CREATE TABLE IF NOT EXISTS test.foo(k int PRIMARY
> KEY)");
> PreparedStatement pst = session.prepare("SELECT * FROM test.foo WHERE
> k=?");
> // Drop and recreate the table to invalidate the prepared statement
> server-side
> session.execute("DROP TABLE test.foo");
> session.execute("CREATE TABLE test.foo(k int PRIMARY KEY)");
> session.execute("USE test");
> // This will try to reprepare on the fly
> session.execute(pst.bind(0));
> } finally {
> if (cluster != null) cluster.close();
> }
> {code}
> When the driver goes to execute the bound statement (last line before the
> finally block), it will get an UNPREPARED response because the statement was
> evicted from the server cache (as a result of dropping the table earlier).
> In those cases, the driver recovers transparently by sending another PREPARE
> message and retrying the bound statement.
> However, that second PREPARE cached the statement under a different id,
> because we switched to another keyspace. Yet the driver is still using the
> original id (stored in {{pst}}) when it retries, so it will get UNPREPARED
> again, etc.
> I would consider this low priority because issuing a {{USE}} statement after
> having prepared statements is a bad idea to begin with. And even if we fix
> the generated id for qualified query strings, the issue will remain for
> unqualified ones.
> We'll add a check in the driver to fail fast and avoid the infinite loop if
> the id returned by the second PREPARE doesn't match the original one. That
> might be enough to cover this issue.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16879) Verify correct ownership of attached locations on disk at C* startup
[ https://issues.apache.org/jira/browse/CASSANDRA-16879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423360#comment-17423360 ] Josh McKenzie commented on CASSANDRA-16879: --- Pushed a commit w/the review feedback from offline slack convo [~maedhroz]. We good to go? > Verify correct ownership of attached locations on disk at C* startup > > > Key: CASSANDRA-16879 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16879 > Project: Cassandra > Issue Type: Improvement > Components: Local/Startup and Shutdown >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Fix For: 4.x > > > There's two primary things related to startup and disk ownership we should > mitigate. > First, an instance can come up with an incorrectly mounted volume attached as > its configured data directory. This causes the wrong system tables to be > read. If the instance which was previously using the volume is also down, its > token could be taken over by the instance coming up. > Secondly, in a JBOD setup, the non-system keyspaces may reside on a separate > volume to the system tables. In this scenario, we need to ensure that all > directories belong to the same instance, and that as the instance starts up > it can access all the directories it expects to be able to. (including data, > commit log, hints and saved cache dirs) > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15252) Don't consider current keyspace in prepared statement id when the query is qualified
[
https://issues.apache.org/jira/browse/CASSANDRA-15252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Petrov updated CASSANDRA-15252:
Reviewers: Marcus Eriksson, Alex Petrov (was: Alex Petrov, Marcus Eriksson)
Marcus Eriksson, Alex Petrov (was: Marcus Eriksson)
Status: Review In Progress (was: Patch Available)
> Don't consider current keyspace in prepared statement id when the query is
> qualified
>
>
> Key: CASSANDRA-15252
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15252
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Client
>Reporter: Olivier Michallat
>Assignee: Alex Petrov
>Priority: Normal
>
> {{QueryProcessor.computeId}} takes into account the session's current
> keyspace in the MD5 digest.
> {code}
> String toHash = keyspace == null ? queryString : keyspace + queryString;
> {code}
> This is desirable for unqualified queries, because switching to a different
> keyspace produces a different statement. However, for a qualified query, the
> current keyspace makes no difference, the prepared id should always be the
> same.
> This can lead to an infinite reprepare loop on the client. Consider this
> example (Java driver 3.x):
> {code}
> Cluster cluster = null;
> try {
> cluster = Cluster.builder().addContactPoint("127.0.0.1").build();
> Session session = cluster.connect();
> session.execute(
> "CREATE KEYSPACE IF NOT EXISTS test WITH replication = {'class':
> 'SimpleStrategy', 'replication_factor': 1}");
> session.execute("CREATE TABLE IF NOT EXISTS test.foo(k int PRIMARY
> KEY)");
> PreparedStatement pst = session.prepare("SELECT * FROM test.foo WHERE
> k=?");
> // Drop and recreate the table to invalidate the prepared statement
> server-side
> session.execute("DROP TABLE test.foo");
> session.execute("CREATE TABLE test.foo(k int PRIMARY KEY)");
> session.execute("USE test");
> // This will try to reprepare on the fly
> session.execute(pst.bind(0));
> } finally {
> if (cluster != null) cluster.close();
> }
> {code}
> When the driver goes to execute the bound statement (last line before the
> finally block), it will get an UNPREPARED response because the statement was
> evicted from the server cache (as a result of dropping the table earlier).
> In those cases, the driver recovers transparently by sending another PREPARE
> message and retrying the bound statement.
> However, that second PREPARE cached the statement under a different id,
> because we switched to another keyspace. Yet the driver is still using the
> original id (stored in {{pst}}) when it retries, so it will get UNPREPARED
> again, etc.
> I would consider this low priority because issuing a {{USE}} statement after
> having prepared statements is a bad idea to begin with. And even if we fix
> the generated id for qualified query strings, the issue will remain for
> unqualified ones.
> We'll add a check in the driver to fail fast and avoid the infinite loop if
> the id returned by the second PREPARE doesn't match the original one. That
> might be enough to cover this issue.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15252) Don't consider current keyspace in prepared statement id when the query is qualified
[
https://issues.apache.org/jira/browse/CASSANDRA-15252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423358#comment-17423358
]
Alex Petrov commented on CASSANDRA-15252:
-
Committed to 3.0 with [13632e9a99e8256a565bd6919d2d11b3e476e973
|https://github.com/apache/cassandra/commit/13632e9a99e8256a565bd6919d2d11b3e476e973],
and merged up to
[3.11|https://github.com/apache/cassandra/commit/32a15f0e9b90ff467cc8a686461cb1b769539672],
[4.0|https://github.com/apache/cassandra/commit/01080613789961c7e7f7655dd6d0065f4ef8ff21]
and
[trunk|https://github.com/apache/cassandra/commit/72722e521f5d22fc630f76f6b43e1216597c841a].
> Don't consider current keyspace in prepared statement id when the query is
> qualified
>
>
> Key: CASSANDRA-15252
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15252
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Client
>Reporter: Olivier Michallat
>Assignee: Alex Petrov
>Priority: Normal
>
> {{QueryProcessor.computeId}} takes into account the session's current
> keyspace in the MD5 digest.
> {code}
> String toHash = keyspace == null ? queryString : keyspace + queryString;
> {code}
> This is desirable for unqualified queries, because switching to a different
> keyspace produces a different statement. However, for a qualified query, the
> current keyspace makes no difference, the prepared id should always be the
> same.
> This can lead to an infinite reprepare loop on the client. Consider this
> example (Java driver 3.x):
> {code}
> Cluster cluster = null;
> try {
> cluster = Cluster.builder().addContactPoint("127.0.0.1").build();
> Session session = cluster.connect();
> session.execute(
> "CREATE KEYSPACE IF NOT EXISTS test WITH replication = {'class':
> 'SimpleStrategy', 'replication_factor': 1}");
> session.execute("CREATE TABLE IF NOT EXISTS test.foo(k int PRIMARY
> KEY)");
> PreparedStatement pst = session.prepare("SELECT * FROM test.foo WHERE
> k=?");
> // Drop and recreate the table to invalidate the prepared statement
> server-side
> session.execute("DROP TABLE test.foo");
> session.execute("CREATE TABLE test.foo(k int PRIMARY KEY)");
> session.execute("USE test");
> // This will try to reprepare on the fly
> session.execute(pst.bind(0));
> } finally {
> if (cluster != null) cluster.close();
> }
> {code}
> When the driver goes to execute the bound statement (last line before the
> finally block), it will get an UNPREPARED response because the statement was
> evicted from the server cache (as a result of dropping the table earlier).
> In those cases, the driver recovers transparently by sending another PREPARE
> message and retrying the bound statement.
> However, that second PREPARE cached the statement under a different id,
> because we switched to another keyspace. Yet the driver is still using the
> original id (stored in {{pst}}) when it retries, so it will get UNPREPARED
> again, etc.
> I would consider this low priority because issuing a {{USE}} statement after
> having prepared statements is a bad idea to begin with. And even if we fix
> the generated id for qualified query strings, the issue will remain for
> unqualified ones.
> We'll add a check in the driver to fail fast and avoid the infinite loop if
> the id returned by the second PREPARE doesn't match the original one. That
> might be enough to cover this issue.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15252) Don't consider current keyspace in prepared statement id when the query is qualified
[
https://issues.apache.org/jira/browse/CASSANDRA-15252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Petrov updated CASSANDRA-15252:
Status: Ready to Commit (was: Review In Progress)
> Don't consider current keyspace in prepared statement id when the query is
> qualified
>
>
> Key: CASSANDRA-15252
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15252
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Client
>Reporter: Olivier Michallat
>Assignee: Alex Petrov
>Priority: Normal
>
> {{QueryProcessor.computeId}} takes into account the session's current
> keyspace in the MD5 digest.
> {code}
> String toHash = keyspace == null ? queryString : keyspace + queryString;
> {code}
> This is desirable for unqualified queries, because switching to a different
> keyspace produces a different statement. However, for a qualified query, the
> current keyspace makes no difference, the prepared id should always be the
> same.
> This can lead to an infinite reprepare loop on the client. Consider this
> example (Java driver 3.x):
> {code}
> Cluster cluster = null;
> try {
> cluster = Cluster.builder().addContactPoint("127.0.0.1").build();
> Session session = cluster.connect();
> session.execute(
> "CREATE KEYSPACE IF NOT EXISTS test WITH replication = {'class':
> 'SimpleStrategy', 'replication_factor': 1}");
> session.execute("CREATE TABLE IF NOT EXISTS test.foo(k int PRIMARY
> KEY)");
> PreparedStatement pst = session.prepare("SELECT * FROM test.foo WHERE
> k=?");
> // Drop and recreate the table to invalidate the prepared statement
> server-side
> session.execute("DROP TABLE test.foo");
> session.execute("CREATE TABLE test.foo(k int PRIMARY KEY)");
> session.execute("USE test");
> // This will try to reprepare on the fly
> session.execute(pst.bind(0));
> } finally {
> if (cluster != null) cluster.close();
> }
> {code}
> When the driver goes to execute the bound statement (last line before the
> finally block), it will get an UNPREPARED response because the statement was
> evicted from the server cache (as a result of dropping the table earlier).
> In those cases, the driver recovers transparently by sending another PREPARE
> message and retrying the bound statement.
> However, that second PREPARE cached the statement under a different id,
> because we switched to another keyspace. Yet the driver is still using the
> original id (stored in {{pst}}) when it retries, so it will get UNPREPARED
> again, etc.
> I would consider this low priority because issuing a {{USE}} statement after
> having prepared statements is a bad idea to begin with. And even if we fix
> the generated id for qualified query strings, the issue will remain for
> unqualified ones.
> We'll add a check in the driver to fail fast and avoid the infinite loop if
> the id returned by the second PREPARE doesn't match the original one. That
> might be enough to cover this issue.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.0 updated (0c46531 -> 13632e9)
This is an automated email from the ASF dual-hosted git repository.
ifesdjeen pushed a change to branch cassandra-3.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git.
from 0c46531 Make -Dtest.methods consistently optional in all Ant test
targets
add 13632e9 Avoid re-prepare storm on qualified statements after `use`
No new revisions were added by this update.
Summary of changes:
NEWS.txt | 7 +
.../org/apache/cassandra/cql3/QueryProcessor.java | 52 +++-
.../cassandra/cql3/statements/BatchStatement.java | 2 +-
.../cassandra/cql3/statements/CFStatement.java | 2 +-
.../cql3/statements/ModificationStatement.java | 2 +-
.../cassandra/cql3/statements/ParsedStatement.java | 19 +-
.../cassandra/cql3/statements/SelectStatement.java | 7 +-
src/java/org/apache/cassandra/gms/Gossiper.java| 102
.../gms/IEndpointStateChangeSubscriber.java| 14 +-
.../org/apache/cassandra/repair/RepairSession.java | 6 -
.../apache/cassandra/service/LoadBroadcaster.java | 8 -
.../apache/cassandra/streaming/StreamSession.java | 6 -
.../cassandra/utils/RecomputingSupplier.java | 122 +
.../distributed/test/GossipShutdownTest.java | 7 -
.../distributed/test/NativeProtocolTest.java | 6 +-
.../test/ReprepareNewBehaviourTest.java} | 21 +-
.../distributed/test/ReprepareTestBase.java| 281 +
.../test/ReprepareTestOldBehaviour.java| 129 ++
.../apache/cassandra/metrics/CQLMetricsTest.java | 5 +-
.../cassandra/utils/RecomputingSupplierTest.java | 150 +++
20 files changed, 890 insertions(+), 58 deletions(-)
create mode 100644 src/java/org/apache/cassandra/utils/RecomputingSupplier.java
copy test/{unit/org/apache/cassandra/cql3/validation/operations/UseTest.java
=>
distributed/org/apache/cassandra/distributed/test/ReprepareNewBehaviourTest.java}
(64%)
create mode 100644
test/distributed/org/apache/cassandra/distributed/test/ReprepareTestBase.java
create mode 100644
test/distributed/org/apache/cassandra/distributed/test/ReprepareTestOldBehaviour.java
create mode 100644
test/unit/org/apache/cassandra/utils/RecomputingSupplierTest.java
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0 updated (b22749b -> 0108061)
This is an automated email from the ASF dual-hosted git repository.
ifesdjeen pushed a change to branch cassandra-4.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git.
from b22749b Remove thrift dep from cqlsh tests.
add 13632e9 Avoid re-prepare storm on qualified statements after `use`
add 32a15f0 Merge branch 'cassandra-3.0' into cassandra-3.11
add 0108061 Merge branch 'cassandra-3.11' into cassandra-4.0
No new revisions were added by this update.
Summary of changes:
.../org/apache/cassandra/cql3/CQLStatement.java| 5 +
.../org/apache/cassandra/cql3/QueryProcessor.java | 58 -
.../cql3/statements/ModificationStatement.java | 3 +-
.../cassandra/cql3/statements/SelectStatement.java | 3 +-
.../cassandra/cql3/statements/UseStatement.java| 5 +
.../statements/schema/AlterSchemaStatement.java| 8 +-
src/java/org/apache/cassandra/gms/Gossiper.java| 105 +++-
.../gms/IEndpointStateChangeSubscriber.java| 14 +-
.../net/StartupClusterConnectivityChecker.java | 24 --
.../org/apache/cassandra/repair/RepairSession.java | 6 -
.../apache/cassandra/service/LoadBroadcaster.java | 8 -
.../apache/cassandra/streaming/StreamSession.java | 6 -
.../cassandra/utils/RecomputingSupplier.java | 122 +
.../distributed/test/GossipShutdownTest.java | 7 -
.../distributed/test/NativeProtocolTest.java | 14 +-
...ingTest.java => ReprepareNewBehaviourTest.java} | 14 +-
.../distributed/test/ReprepareTestBase.java| 281 +
.../test/ReprepareTestOldBehaviour.java| 129 ++
.../cassandra/cql3/PreparedStatementsTest.java | 4 +-
.../cassandra/cql3/PstmtPersistenceTest.java | 36 +--
.../apache/cassandra/metrics/CQLMetricsTest.java | 5 +-
.../cassandra/utils/RecomputingSupplierTest.java | 150 +++
22 files changed, 911 insertions(+), 96 deletions(-)
create mode 100644 src/java/org/apache/cassandra/utils/RecomputingSupplier.java
copy
test/distributed/org/apache/cassandra/distributed/test/{NetstatsBootstrapWithEntireSSTablesCompressionStreamingTest.java
=> ReprepareNewBehaviourTest.java} (69%)
create mode 100644
test/distributed/org/apache/cassandra/distributed/test/ReprepareTestBase.java
create mode 100644
test/distributed/org/apache/cassandra/distributed/test/ReprepareTestOldBehaviour.java
create mode 100644
test/unit/org/apache/cassandra/utils/RecomputingSupplierTest.java
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.11 updated (2614f7e -> 32a15f0)
This is an automated email from the ASF dual-hosted git repository. ifesdjeen pushed a change to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 2614f7e Merge branch 'cassandra-3.0' into cassandra-3.11 add 13632e9 Avoid re-prepare storm on qualified statements after `use` add 32a15f0 Merge branch 'cassandra-3.0' into cassandra-3.11 No new revisions were added by this update. Summary of changes: NEWS.txt | 7 + .../org/apache/cassandra/cql3/QueryProcessor.java | 53 +++- .../cassandra/cql3/statements/BatchStatement.java | 2 +- .../cassandra/cql3/statements/CFStatement.java | 2 +- .../cql3/statements/ModificationStatement.java | 2 +- .../cassandra/cql3/statements/ParsedStatement.java | 20 +- .../cassandra/cql3/statements/SelectStatement.java | 7 +- src/java/org/apache/cassandra/gms/Gossiper.java| 101 .../gms/IEndpointStateChangeSubscriber.java| 14 +- .../org/apache/cassandra/repair/RepairSession.java | 6 - .../apache/cassandra/service/LoadBroadcaster.java | 8 - .../apache/cassandra/streaming/StreamSession.java | 6 - .../cassandra/utils/RecomputingSupplier.java | 122 + .../distributed/test/GossipShutdownTest.java | 7 - .../distributed/test/NativeProtocolTest.java | 6 +- .../test/ReprepareNewBehaviourTest.java| 22 +- .../distributed/test/ReprepareTestBase.java| 281 + .../test/ReprepareTestOldBehaviour.java| 129 ++ .../cassandra/cql3/PstmtPersistenceTest.java | 37 +-- .../apache/cassandra/metrics/CQLMetricsTest.java | 5 +- .../cassandra/utils/RecomputingSupplierTest.java | 150 +++ 21 files changed, 908 insertions(+), 79 deletions(-) create mode 100644 src/java/org/apache/cassandra/utils/RecomputingSupplier.java copy tools/stress/test/unit/org/apache/cassandra/stress/settings/OptionReplicationTest.java => test/distributed/org/apache/cassandra/distributed/test/ReprepareNewBehaviourTest.java (64%) create mode 100644 test/distributed/org/apache/cassandra/distributed/test/ReprepareTestBase.java create mode 100644 test/distributed/org/apache/cassandra/distributed/test/ReprepareTestOldBehaviour.java create mode 100644 test/unit/org/apache/cassandra/utils/RecomputingSupplierTest.java - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (0945002 -> 72722e5)
This is an automated email from the ASF dual-hosted git repository.
ifesdjeen pushed a change to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git.
from 0945002 Merge branch 'cassandra-4.0' into trunk
add 13632e9 Avoid re-prepare storm on qualified statements after `use`
add 32a15f0 Merge branch 'cassandra-3.0' into cassandra-3.11
add 0108061 Merge branch 'cassandra-3.11' into cassandra-4.0
new 72722e5 Merge branch 'cassandra-4.0' into trunk
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../org/apache/cassandra/cql3/CQLStatement.java| 5 +
.../org/apache/cassandra/cql3/QueryProcessor.java | 58 -
.../cql3/statements/ModificationStatement.java | 3 +-
.../cassandra/cql3/statements/SelectStatement.java | 3 +-
.../cassandra/cql3/statements/UseStatement.java| 5 +
.../statements/schema/AlterSchemaStatement.java| 8 +-
src/java/org/apache/cassandra/gms/Gossiper.java| 105 +++-
.../gms/IEndpointStateChangeSubscriber.java| 14 +-
.../net/StartupClusterConnectivityChecker.java | 24 --
.../org/apache/cassandra/repair/RepairSession.java | 6 -
.../apache/cassandra/service/LoadBroadcaster.java | 8 -
.../apache/cassandra/streaming/StreamSession.java | 6 -
.../cassandra/utils/RecomputingSupplier.java | 122 +
.../distributed/test/GossipShutdownTest.java | 7 -
.../distributed/test/NativeProtocolTest.java | 14 +-
...ingTest.java => ReprepareNewBehaviourTest.java} | 14 +-
.../distributed/test/ReprepareTestBase.java| 281 +
.../test/ReprepareTestOldBehaviour.java| 129 ++
.../cassandra/cql3/PreparedStatementsTest.java | 4 +-
.../cassandra/cql3/PstmtPersistenceTest.java | 36 +--
.../apache/cassandra/metrics/CQLMetricsTest.java | 5 +-
.../cassandra/utils/RecomputingSupplierTest.java | 150 +++
22 files changed, 911 insertions(+), 96 deletions(-)
create mode 100644 src/java/org/apache/cassandra/utils/RecomputingSupplier.java
copy
test/distributed/org/apache/cassandra/distributed/test/{NetstatsBootstrapWithEntireSSTablesCompressionStreamingTest.java
=> ReprepareNewBehaviourTest.java} (69%)
create mode 100644
test/distributed/org/apache/cassandra/distributed/test/ReprepareTestBase.java
create mode 100644
test/distributed/org/apache/cassandra/distributed/test/ReprepareTestOldBehaviour.java
create mode 100644
test/unit/org/apache/cassandra/utils/RecomputingSupplierTest.java
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.0' into trunk
This is an automated email from the ASF dual-hosted git repository. ifesdjeen pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 72722e521f5d22fc630f76f6b43e1216597c841a Merge: 0945002 0108061 Author: Alex Petrov AuthorDate: Fri Oct 1 18:14:59 2021 +0200 Merge branch 'cassandra-4.0' into trunk .../org/apache/cassandra/cql3/CQLStatement.java| 5 + .../org/apache/cassandra/cql3/QueryProcessor.java | 58 - .../cql3/statements/ModificationStatement.java | 3 +- .../cassandra/cql3/statements/SelectStatement.java | 3 +- .../cassandra/cql3/statements/UseStatement.java| 5 + .../statements/schema/AlterSchemaStatement.java| 8 +- src/java/org/apache/cassandra/gms/Gossiper.java| 105 +++- .../gms/IEndpointStateChangeSubscriber.java| 14 +- .../net/StartupClusterConnectivityChecker.java | 24 -- .../org/apache/cassandra/repair/RepairSession.java | 6 - .../apache/cassandra/service/LoadBroadcaster.java | 8 - .../apache/cassandra/streaming/StreamSession.java | 6 - .../cassandra/utils/RecomputingSupplier.java | 122 + .../distributed/test/GossipShutdownTest.java | 7 - .../distributed/test/NativeProtocolTest.java | 14 +- .../test/ReprepareNewBehaviourTest.java| 38 +++ .../distributed/test/ReprepareTestBase.java| 281 + .../test/ReprepareTestOldBehaviour.java| 129 ++ .../cassandra/cql3/PreparedStatementsTest.java | 4 +- .../cassandra/cql3/PstmtPersistenceTest.java | 36 +-- .../apache/cassandra/metrics/CQLMetricsTest.java | 5 +- .../cassandra/utils/RecomputingSupplierTest.java | 150 +++ 22 files changed, 941 insertions(+), 90 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17017) Add required -f / --force option to nodetool verify
[ https://issues.apache.org/jira/browse/CASSANDRA-17017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423353#comment-17423353 ] Josh McKenzie commented on CASSANDRA-17017: --- Pushed a commit with the doc change. Regarding the test [~bereng], if someone goes in and yanks the code out that has a comment linking a JIRA saying "Hey! Be careful here because this thing is a problem", having a unit test they have to steamroll too isn't really going to slow them down. > Add required -f / --force option to nodetool verify > --- > > Key: CASSANDRA-17017 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17017 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > > nodetool verify has some pretty significant problems with it (see > CASSANDRA-9947). > Until such time as we do the heavy(er) lift to fix the command, we should > make it harder for people to shoot themselves in the foot with it. Adding a > required "-f" flag to it with a requisite "Do you really know what you're > doing? Check out this JIRA first" seems like it'd be the right thing to do in > the interim. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17020) Cqlshlib failure
[
https://issues.apache.org/jira/browse/CASSANDRA-17020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423350#comment-17423350
]
Ekaterina Dimitrova commented on CASSANDRA-17020:
-
It seems like a different issue.
I am waiting for [this
build|https://jenkins-cm4.apache.org/job/Cassandra-3.0/204/console] to finish
soon.
What I found from [this build
|https://jenkins-cm4.apache.org/job/Cassandra-devbranch-cqlsh-tests/1068/] and
in [this log
|https://jenkins-cm4.apache.org/job/Cassandra-devbranch-cqlsh-tests/1068/cython=yes,jdk=jdk_1.8_latest,label=cassandra/console]
is:
{code:java}
21:16:55 ./cassandra-builds/build-scripts/cassandra-test-docker.sh: line 134:
30217 Terminated tail -F build/test/logs/docker_attach_$(( $i + 1
)).log
21:16:55 Error: No such container:path:
090399aa7b6d41f4516812432ae9fdc27447b1ff0fce2584031d0d1e615f5eec:/home/cassandra/cassandra/build/test/output/.
21:16:55 Error: No such container:path:
{code}
The cqlsh tests are running but logs are not saved it seems. I don't have
immediate answer to what happened. Keep on digging...
> Cqlshlib failure
>
>
> Key: CASSANDRA-17020
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17020
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> Failing for 4.0 and trunk -
> [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/3e76993a-8ff0-442b-ae19-e3c6abf09ee6/jobs/6670]
>
> Also 3.11 here -
> https://jenkins-cm4.apache.org/job/Cassandra-devbranch/1152/#showFailuresLink
>
> /CC [~brandon.williams]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17017) Add required -f / --force option to nodetool verify
[ https://issues.apache.org/jira/browse/CASSANDRA-17017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422887#comment-17422887 ] Josh McKenzie edited comment on CASSANDRA-17017 at 10/1/21, 3:38 PM: - [PR|https://github.com/apache/cassandra/pull/1246] Kicked off a slow burn of dtests on CI just in case any of them relied on verify somehow and I'm not seeing it by grepping. [JDK8|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/99/workflows/487a4862-68b6-47f9-9690-ddfdbea69bf2] [JDK11|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/99/workflows/3b267582-d698-44b6-9231-9d4638423b8a] (edit: updated test runs w/highres circle settings. Wasn't aware it'd just barf on default. /sigh) was (Author: jmckenzie): [PR|https://github.com/apache/cassandra/pull/1246] Kicked off a slow burn of dtests on CI just in case any of them relied on verify somehow and I'm not seeing it by grepping. [JDK8|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/96/workflows/7686b1fb-267a-464c-8f49-6de00dc8baea] [JDK11|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/96/workflows/8dbd2169-1147-4215-889e-3ef4071148d6] > Add required -f / --force option to nodetool verify > --- > > Key: CASSANDRA-17017 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17017 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > > nodetool verify has some pretty significant problems with it (see > CASSANDRA-9947). > Until such time as we do the heavy(er) lift to fix the command, we should > make it harder for people to shoot themselves in the foot with it. Adding a > required "-f" flag to it with a requisite "Do you really know what you're > doing? Check out this JIRA first" seems like it'd be the right thing to do in > the interim. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17020) Cqlshlib failure
[ https://issues.apache.org/jira/browse/CASSANDRA-17020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17020: Description: Failing for 4.0 and trunk - [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/3e76993a-8ff0-442b-ae19-e3c6abf09ee6/jobs/6670] Also 3.11 here - https://jenkins-cm4.apache.org/job/Cassandra-devbranch/1152/#showFailuresLink /CC [~brandon.williams] was: Failing for 4.0 and trunk - [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/3e76993a-8ff0-442b-ae19-e3c6abf09ee6/jobs/6670] /CC [~brandon.williams] > Cqlshlib failure > > > Key: CASSANDRA-17020 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17020 > Project: Cassandra > Issue Type: Bug > Components: CI >Reporter: Ekaterina Dimitrova >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x > > > Failing for 4.0 and trunk - > [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/3e76993a-8ff0-442b-ae19-e3c6abf09ee6/jobs/6670] > > Also 3.11 here - > https://jenkins-cm4.apache.org/job/Cassandra-devbranch/1152/#showFailuresLink > > /CC [~brandon.williams] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17020) Cqlshlib failure
[ https://issues.apache.org/jira/browse/CASSANDRA-17020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17020: Fix Version/s: 4.x 4.0.x 3.11.x 3.0.x > Cqlshlib failure > > > Key: CASSANDRA-17020 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17020 > Project: Cassandra > Issue Type: Bug > Components: CI >Reporter: Ekaterina Dimitrova >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x > > > Failing for 4.0 and trunk - > [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/3e76993a-8ff0-442b-ae19-e3c6abf09ee6/jobs/6670] > > > /CC [~brandon.williams] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17020) Cqlshlib failure
[ https://issues.apache.org/jira/browse/CASSANDRA-17020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423329#comment-17423329 ] Ekaterina Dimitrova commented on CASSANDRA-17020: - Thanks! Looking into 3.11 now > Cqlshlib failure > > > Key: CASSANDRA-17020 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17020 > Project: Cassandra > Issue Type: Bug > Components: CI >Reporter: Ekaterina Dimitrova >Priority: Normal > > Failing for 4.0 and trunk - > [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/3e76993a-8ff0-442b-ae19-e3c6abf09ee6/jobs/6670] > > > /CC [~brandon.williams] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17020) Cqlshlib failure
[ https://issues.apache.org/jira/browse/CASSANDRA-17020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423326#comment-17423326 ] Brandon Williams commented on CASSANDRA-17020: -- [Removed|https://github.com/apache/cassandra/commit/b22749bbb2c5f5dc91312c7e0f7107e9a301b8eb] thrift from 4.0 and trunk. > Cqlshlib failure > > > Key: CASSANDRA-17020 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17020 > Project: Cassandra > Issue Type: Bug > Components: CI >Reporter: Ekaterina Dimitrova >Priority: Normal > > Failing for 4.0 and trunk - > [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/3e76993a-8ff0-442b-ae19-e3c6abf09ee6/jobs/6670] > > > /CC [~brandon.williams] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (bcdb575 -> 0945002)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from bcdb575 Merge branch 'cassandra-4.0' into trunk new b22749b Remove thrift dep from cqlsh tests. new 0945002 Merge branch 'cassandra-4.0' into trunk The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: pylib/requirements.txt | 1 - 1 file changed, 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0 updated: Remove thrift dep from cqlsh tests.
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/cassandra-4.0 by this push: new b22749b Remove thrift dep from cqlsh tests. b22749b is described below commit b22749bbb2c5f5dc91312c7e0f7107e9a301b8eb Author: Brandon Williams AuthorDate: Fri Oct 1 10:02:05 2021 -0500 Remove thrift dep from cqlsh tests. Patch by brandonwilliams; reviewed by edimitrova for CASSANDRA-17020 --- pylib/requirements.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/pylib/requirements.txt b/pylib/requirements.txt index 17d4ab0..45efb5e 100644 --- a/pylib/requirements.txt +++ b/pylib/requirements.txt @@ -18,4 +18,3 @@ nose-test-select parse pycodestyle psutil -thrift==0.9.3 - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.0' into trunk
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 0945002457738f4c256bc6a262a8d8aaadcdf392 Merge: bcdb575 b22749b Author: Brandon Williams AuthorDate: Fri Oct 1 10:02:40 2021 -0500 Merge branch 'cassandra-4.0' into trunk pylib/requirements.txt | 1 - 1 file changed, 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17020) Cqlshlib failure
[ https://issues.apache.org/jira/browse/CASSANDRA-17020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423321#comment-17423321 ] Ekaterina Dimitrova commented on CASSANDRA-17020: - +1 on the fix for 4.0 and trunk, we need to look at the previous branches. I confirm, we use cached base image and it seems when the new image was pushed the new version was pulled. I can try to fix this now for the previous branches too or as an intermediate solution we can point to the old image until it's fixed. Circle CI should be working fine though as it still points on all branches to the old cached image where we use the older version. > Cqlshlib failure > > > Key: CASSANDRA-17020 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17020 > Project: Cassandra > Issue Type: Bug > Components: CI >Reporter: Ekaterina Dimitrova >Priority: Normal > > Failing for 4.0 and trunk - > [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/3e76993a-8ff0-442b-ae19-e3c6abf09ee6/jobs/6670] > > > /CC [~brandon.williams] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17020) Cqlshlib failure
[ https://issues.apache.org/jira/browse/CASSANDRA-17020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423316#comment-17423316 ] Brandon Williams commented on CASSANDRA-17020: -- Removing thrift works: https://ci-cassandra.apache.org/job/Cassandra-devbranch-cqlsh-tests/1072/ > Cqlshlib failure > > > Key: CASSANDRA-17020 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17020 > Project: Cassandra > Issue Type: Bug > Components: CI >Reporter: Ekaterina Dimitrova >Priority: Normal > > Failing for 4.0 and trunk - > [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/3e76993a-8ff0-442b-ae19-e3c6abf09ee6/jobs/6670] > > > /CC [~brandon.williams] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17014) Make -Dtest.methods optional in all Ant test targets
[
https://issues.apache.org/jira/browse/CASSANDRA-17014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-17014:
--
Fix Version/s: 4.1
4.0.2
3.11.12
3.0.26
Source Control Link:
https://github.com/apache/cassandra/commit/0c4653110d80f411d2c50445d48478967bcaa095
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> Make -Dtest.methods optional in all Ant test targets
>
>
> Key: CASSANDRA-17014
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17014
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Low
> Fix For: 3.0.26, 3.11.12, 4.0.2, 4.1
>
>
> The Ant build file contains several targets to run specific tests:
> * testsome
> * long-testsome
> * burn-testsome
> * cql-test-some
> * stress-test-some
> * test-jvm-dtest-some
> These targets take two arguments, {{test.name}} and {{test.methods}}. The
> first argument, {{test.name}}, is always mandatory. However, {{test.methods}}
> can be either mandatory or optional depending on the target and the project
> branch. For example, in {{testsome}} the argument is mandatory in 3.0 and
> 3.11 and optional in 4.0 and trunk. Also, in trunk {{test.methods}} is
> optional for all the targets except {{cql-test-some}}.
> The purpose of this ticket is making {{test.methods}} consistently optional
> for all the {{*some}} targets.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17014) Make -Dtest.methods optional in all Ant test targets
[
https://issues.apache.org/jira/browse/CASSANDRA-17014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423309#comment-17423309
]
Andres de la Peña commented on CASSANDRA-17014:
---
Committed to 3.0 as
[0c4653110d80f411d2c50445d48478967bcaa095|https://github.com/apache/cassandra/commit/0c4653110d80f411d2c50445d48478967bcaa095]and
merged up to
[3.11|https://github.com/apache/cassandra/commit/2614f7eeb4343b1d752a16688a1dc55ab245ca8f],
[4.0|https://github.com/apache/cassandra/commit/36266ce257e62b74a1e68aadba637b2dc75b32fc]
and
[trunk|https://github.com/apache/cassandra/commit/bcdb575fd32bccf196c8b398c7bb9f95f2591b73].
> Make -Dtest.methods optional in all Ant test targets
>
>
> Key: CASSANDRA-17014
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17014
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Low
>
> The Ant build file contains several targets to run specific tests:
> * testsome
> * long-testsome
> * burn-testsome
> * cql-test-some
> * stress-test-some
> * test-jvm-dtest-some
> These targets take two arguments, {{test.name}} and {{test.methods}}. The
> first argument, {{test.name}}, is always mandatory. However, {{test.methods}}
> can be either mandatory or optional depending on the target and the project
> branch. For example, in {{testsome}} the argument is mandatory in 3.0 and
> 3.11 and optional in 4.0 and trunk. Also, in trunk {{test.methods}} is
> optional for all the targets except {{cql-test-some}}.
> The purpose of this ticket is making {{test.methods}} consistently optional
> for all the {{*some}} targets.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17014) Make -Dtest.methods optional in all Ant test targets
[
https://issues.apache.org/jira/browse/CASSANDRA-17014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-17014:
--
Status: Ready to Commit (was: Review In Progress)
> Make -Dtest.methods optional in all Ant test targets
>
>
> Key: CASSANDRA-17014
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17014
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Low
>
> The Ant build file contains several targets to run specific tests:
> * testsome
> * long-testsome
> * burn-testsome
> * cql-test-some
> * stress-test-some
> * test-jvm-dtest-some
> These targets take two arguments, {{test.name}} and {{test.methods}}. The
> first argument, {{test.name}}, is always mandatory. However, {{test.methods}}
> can be either mandatory or optional depending on the target and the project
> branch. For example, in {{testsome}} the argument is mandatory in 3.0 and
> 3.11 and optional in 4.0 and trunk. Also, in trunk {{test.methods}} is
> optional for all the targets except {{cql-test-some}}.
> The purpose of this ticket is making {{test.methods}} consistently optional
> for all the {{*some}} targets.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.11' into cassandra-4.0
This is an automated email from the ASF dual-hosted git repository. adelapena pushed a commit to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 36266ce257e62b74a1e68aadba637b2dc75b32fc Merge: 339e8b7 2614f7e Author: Andrés de la Peña AuthorDate: Fri Oct 1 15:19:35 2021 +0100 Merge branch 'cassandra-3.11' into cassandra-4.0 CHANGES.txt | 1 + build.xml | 25 ++--- 2 files changed, 19 insertions(+), 7 deletions(-) diff --cc CHANGES.txt index 2bc99b4,a40b226..f6d3610 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,22 -1,16 +1,23 @@@ -3.11.12 +4.0.2 + * Correct the internode message timestamp if sending node has wrapped (CASSANDRA-16997) + * Avoid race causing us to return null in RangesAtEndpoint (CASSANDRA-16965) + * Avoid rewriting all sstables during cleanup when transient replication is enabled (CASSANDRA-16966) + * Prevent CQLSH from failure on Python 3.10 (CASSANDRA-16987) + * Avoid trying to acquire 0 permits from the rate limiter when taking snapshot (CASSANDRA-16872) + * Upgrade Caffeine to 2.5.6 (CASSANDRA-15153) + * Include SASI components to snapshots (CASSANDRA-15134) + * Fix missed wait latencies in the output of `nodetool tpstats -F` (CASSANDRA-16938) + * Remove all the state pollution between tests in SSTableReaderTest (CASSANDRA-16888) + * Delay auth setup until after gossip has settled to avoid unavailables on startup (CASSANDRA-16783) + * Fix clustering order logic in CREATE MATERIALIZED VIEW (CASSANDRA-16898) + * org.apache.cassandra.db.rows.ArrayCell#unsharedHeapSizeExcludingData includes data twice (CASSANDRA-16900) + * Exclude Jackson 1.x transitive dependency of hadoop* provided dependencies (CASSANDRA-16854) +Merged from 3.11: * Add key validation to ssstablescrub (CASSANDRA-16969) * Update Jackson from 2.9.10 to 2.12.5 (CASSANDRA-16851) - * Include SASI components to snapshots (CASSANDRA-15134) * Make assassinate more resilient to missing tokens (CASSANDRA-16847) - * Exclude Jackson 1.x transitive dependency of hadoop* provided dependencies (CASSANDRA-16854) - * Validate SASI tokenizer options before adding index to schema (CASSANDRA-15135) - * Fixup scrub output when no data post-scrub and clear up old use of row, which really means partition (CASSANDRA-16835) - * Fix ant-junit dependency issue (CASSANDRA-16827) - * Reduce thread contention in CommitLogSegment and HintsBuffer (CASSANDRA-16072) - * Avoid sending CDC column if not enabled (CASSANDRA-16770) Merged from 3.0: + * Make -Dtest.methods consistently optional in all Ant test targets (CASSANDRA-17014) * Immediately apply stream throughput, considering negative values as unthrottled (CASSANDRA-16959) * Do not release new SSTables in offline transactions (CASSANDRA-16975) * ArrayIndexOutOfBoundsException in FunctionResource#fromName (CASSANDRA-16977, CASSANDRA-16995) diff --cc build.xml index 58487fa,fe77098..405ab89 --- a/build.xml +++ b/build.xml @@@ -940,59 -776,9 +940,63 @@@ ++ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - @@@ -1504,7 -1296,8 +1508,7 @@@ - @@@ -1519,20 -1313,9 +1523,22 @@@ - + + + + + + + + + - @@@ -1858,7 -1613,9 +1869,7 @@@ - - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.0' into trunk
This is an automated email from the ASF dual-hosted git repository. adelapena pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit bcdb575fd32bccf196c8b398c7bb9f95f2591b73 Merge: 0ccca8d 36266ce Author: Andrés de la Peña AuthorDate: Fri Oct 1 15:20:32 2021 +0100 Merge branch 'cassandra-4.0' into trunk CHANGES.txt | 1 + build.xml | 27 --- 2 files changed, 21 insertions(+), 7 deletions(-) diff --cc build.xml index ca404a4,405ab89..e16e936 --- a/build.xml +++ b/build.xml @@@ -1512,7 -1508,7 +1516,8 @@@ - @@@ -1664,6 -1662,10 +1671,10 @@@ + ++ant cql-test-some -Dtest.name=ListsTest ++ant cql-test-some -Dtest.name=ListsTest -Dtest.methods=testPrecisionTime_getNext_simple ++ --> @@@ -1866,7 -1869,7 +1878,8 @@@ - - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.11 updated (c6e897d -> 2614f7e)
This is an automated email from the ASF dual-hosted git repository. adelapena pushed a change to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from c6e897d Merge branch 'cassandra-3.0' into cassandra-3.11 new 0c46531 Make -Dtest.methods consistently optional in all Ant test targets new 2614f7e Merge branch 'cassandra-3.0' into cassandra-3.11 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt | 1 + build.xml | 29 + 2 files changed, 22 insertions(+), 8 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (0ccca8d -> bcdb575)
This is an automated email from the ASF dual-hosted git repository. adelapena pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 0ccca8d Merge branch 'cassandra-4.0' into trunk new 0c46531 Make -Dtest.methods consistently optional in all Ant test targets new 2614f7e Merge branch 'cassandra-3.0' into cassandra-3.11 new 36266ce Merge branch 'cassandra-3.11' into cassandra-4.0 new bcdb575 Merge branch 'cassandra-4.0' into trunk The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt | 1 + build.xml | 27 --- 2 files changed, 21 insertions(+), 7 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.0' into cassandra-3.11
This is an automated email from the ASF dual-hosted git repository. adelapena pushed a commit to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 2614f7eeb4343b1d752a16688a1dc55ab245ca8f Merge: c6e897d 0c46531 Author: Andrés de la Peña AuthorDate: Fri Oct 1 15:18:40 2021 +0100 Merge branch 'cassandra-3.0' into cassandra-3.11 CHANGES.txt | 1 + build.xml | 29 + 2 files changed, 22 insertions(+), 8 deletions(-) diff --cc CHANGES.txt index 37ec9c1,2ca4481..a40b226 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,15 -1,5 +1,16 @@@ -3.0.26: +3.11.12 + * Add key validation to ssstablescrub (CASSANDRA-16969) + * Update Jackson from 2.9.10 to 2.12.5 (CASSANDRA-16851) + * Include SASI components to snapshots (CASSANDRA-15134) + * Make assassinate more resilient to missing tokens (CASSANDRA-16847) + * Exclude Jackson 1.x transitive dependency of hadoop* provided dependencies (CASSANDRA-16854) + * Validate SASI tokenizer options before adding index to schema (CASSANDRA-15135) + * Fixup scrub output when no data post-scrub and clear up old use of row, which really means partition (CASSANDRA-16835) + * Fix ant-junit dependency issue (CASSANDRA-16827) + * Reduce thread contention in CommitLogSegment and HintsBuffer (CASSANDRA-16072) + * Avoid sending CDC column if not enabled (CASSANDRA-16770) +Merged from 3.0: + * Make -Dtest.methods consistently optional in all Ant test targets (CASSANDRA-17014) * Immediately apply stream throughput, considering negative values as unthrottled (CASSANDRA-16959) * Do not release new SSTables in offline transactions (CASSANDRA-16975) * ArrayIndexOutOfBoundsException in FunctionResource#fromName (CASSANDRA-16977, CASSANDRA-16995) diff --cc build.xml index 5c80b6d,c11a796..fe77098 --- a/build.xml +++ b/build.xml @@@ -1294,7 -1305,8 +1296,8 @@@ -- @@@ -1309,15 -1322,22 +1313,17 @@@ -- - + + - - - - - - + @@@ -1603,7 -1612,8 +1614,8 @@@ -- - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.0 updated: Make -Dtest.methods consistently optional in all Ant test targets
This is an automated email from the ASF dual-hosted git repository. adelapena pushed a commit to branch cassandra-3.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/cassandra-3.0 by this push: new 0c46531 Make -Dtest.methods consistently optional in all Ant test targets 0c46531 is described below commit 0c4653110d80f411d2c50445d48478967bcaa095 Author: Andrés de la Peña AuthorDate: Fri Oct 1 15:17:07 2021 +0100 Make -Dtest.methods consistently optional in all Ant test targets patch by Andrés de la Peña; reviewed by Berenguer Blasi for CASSANDRA-17014 --- CHANGES.txt | 1 + build.xml | 23 ++- 2 files changed, 19 insertions(+), 5 deletions(-) diff --git a/CHANGES.txt b/CHANGES.txt index 53858ac..2ca4481 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,4 +1,5 @@ 3.0.26: + * Make -Dtest.methods consistently optional in all Ant test targets (CASSANDRA-17014) * Immediately apply stream throughput, considering negative values as unthrottled (CASSANDRA-16959) * Do not release new SSTables in offline transactions (CASSANDRA-16975) * ArrayIndexOutOfBoundsException in FunctionResource#fromName (CASSANDRA-16977, CASSANDRA-16995) diff --git a/build.xml b/build.xml index d9ea7ca..c11a796 100644 --- a/build.xml +++ b/build.xml @@ -15,7 +15,9 @@ limitations under the License. --> + xmlns:artifact="antlib:org.apache.maven.artifact.ant" + xmlns:if="ant:if" + xmlns:unless="ant:unless"> @@ -1304,11 +1306,13 @@ - + + @@ -1319,11 +1323,13 @@ - + + @@ -1422,6 +1428,10 @@ + @@ -1445,7 +1455,8 @@ - + + @@ -1602,11 +1613,13 @@ - + + - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0 updated (339e8b7 -> 36266ce)
This is an automated email from the ASF dual-hosted git repository. adelapena pushed a change to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 339e8b7 Merge branch 'cassandra-3.11' into cassandra-4.0 new 0c46531 Make -Dtest.methods consistently optional in all Ant test targets new 2614f7e Merge branch 'cassandra-3.0' into cassandra-3.11 new 36266ce Merge branch 'cassandra-3.11' into cassandra-4.0 The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt | 1 + build.xml | 25 ++--- 2 files changed, 19 insertions(+), 7 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-harry] 03/05: Adjust config files
This is an automated email from the ASF dual-hosted git repository.
ifesdjeen pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-harry.git
commit 59604dbac36a9749c81c29e3739229c64237323c
Author: Alex Petrov
AuthorDate: Tue Jul 13 10:41:18 2021 +0200
Adjust config files
---
README.md | 3 --
conf/{example.yaml => default.yaml} | 56 +++--
conf/external.yaml | 56 +++--
docker/Dockerfile.local | 2 +-
docker/run.sh | 2 +-
pom.xml | 24 ++--
run-jvm.sh | 2 +-
7 files changed, 94 insertions(+), 51 deletions(-)
diff --git a/README.md b/README.md
index ec93b22..841e4ea 100644
--- a/README.md
+++ b/README.md
@@ -491,10 +491,8 @@ Harry is by no means feature-complete. Main things that
are missing are:
* Some types (such as collections) are not deflatable
* Some types are implemented, but are not hooked up (`blob` and `text`) to
DSL/generator
- * Partition deletions are not implemented
* 2i queries are not implemented
* Compact storage is not implemented
- * Static columns are not implemented
* Fault injection is not implemented
* Runner and scheduler are rather rudimentary and require significant rework
and proper scheduling
* TTL is not supported
@@ -508,7 +506,6 @@ Some things, even though are implemented, can be improved
or optimized:
* Inflated partition state and per-row operation log should be done in a
compact
off-heap data structure
* Exhaustive checker can be significantly optimized
- * Harry shouldn't rely on java-driver for query generation
* Exhaustive checker should use more precise information from data tracker,
not
just watermarks
* Decision-making about _when_ we visit partitions and/or rows should be
improved
diff --git a/conf/example.yaml b/conf/default.yaml
similarity index 77%
rename from conf/example.yaml
rename to conf/default.yaml
index d28185d..cdbc34c 100644
--- a/conf/example.yaml
+++ b/conf/default.yaml
@@ -35,16 +35,6 @@ clock:
epoch_length: 1
epoch_time_unit: "SECONDS"
-# Runner is a is a component that schedules operations that change the cluster
(system under test)
-# and model state.
-runner:
- concurrent:
-concurrency: 2
-partition_visitors:
- - mutating:
- row_visitor:
-mutating: {}
-
run_time: 2
run_time_unit: "HOURS"
@@ -73,17 +63,53 @@ clustering_descriptor_selector:
default:
modifications_per_lts:
type: "constant"
- constant: 10
+ constant: 4
rows_per_modification:
type: "constant"
- constant: 10
+ constant: 2
operation_kind_weights:
- WRITE: 97
DELETE_RANGE: 1
+ DELETE_SLICE: 1
DELETE_ROW: 1
DELETE_COLUMN: 1
+ DELETE_PARTITION: 1
+ DELETE_COLUMN_WITH_STATICS: 1
+ INSERT_WITH_STATICS: 50
+ INSERT: 50
+ UPDATE_WITH_STATICS: 50
+ UPDATE: 50
column_mask_bitsets: null
-max_partition_size: 100
+max_partition_size: 1000
+
+# Runner is a is a component that schedules operations that change the cluster
(system under test)
+# and model state.
+runner:
+ sequential:
+partition_visitors:
+ - logging:
+ row_visitor:
+mutating: {}
+ - sampler:
+ trigger_after: 1000
+ sample_partitions: 10
+ - parallel_validate_recent_partitions:
+ partition_count: 100
+ queries_per_partition: 2
+ concurrency: 20
+ trigger_after: 1
+ model:
+quiescent_checker: {}
+ - validate_all_partitions:
+ concurrency: 20
+ trigger_after: 10
+ model:
+quiescent_checker: {}
+
+# Model is responsible for tracking logical timestamps that
+data_tracker:
+ default:
+max_seen_lts: -1
+max_complete_lts: -1
metric_reporter:
- default: {}
\ No newline at end of file
+ no_op: {}
\ No newline at end of file
diff --git a/conf/external.yaml b/conf/external.yaml
index b4d8217..52943b8 100644
--- a/conf/external.yaml
+++ b/conf/external.yaml
@@ -35,16 +35,6 @@ clock:
epoch_length: 1
epoch_time_unit: "SECONDS"
-# Runner is a is a component that schedules operations that change the cluster
(system under test)
-# and model state.
-runner:
- concurrent:
-concurrency: 2
-partition_visitors:
- - mutating:
- row_visitor:
-mutating: {}
-
run_time: 2
run_time_unit: "HOURS"
@@ -57,6 +47,12 @@ system_under_test:
username: null
password: null
+# Model is responsible for tracking logical timestamps that
+model:
+ exhaustive_checker:
+max_seen_lts: 19
+max_complete_lts: 16
+
# Partition descriptor selector controls how partitions is selected based on
the current logical
# timestamp. Default implementation is a
[cassandra-harry] 01/05: Core improvements
This is an automated email from the ASF dual-hosted git repository. ifesdjeen pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra-harry.git commit df40fa39ff1cee5165257a8334eee1ce78f829fe Author: Alex Petrov AuthorDate: Mon Jul 12 17:04:37 2021 +0200 Core improvements Major features: * Implement updates * Make sure we can advance RNGs from zero as well * Fix a problem with predictable descriptor Bugfixes: * Fix column mask inconsistencies * Fix a problem with partition key liveness info Quality of life improvements: * Get rid of driver dependency for query generation * Get rid of guava dependency * Add reusable config files * Switch from streams to iterables General improvements: * Make unset and nil descriptors more distinct and harder to generate particularly for the smaller descriptors * Fixed schema configurator to allow empty column sets * Move workloads to a common dir * Fixed schema configurator to output correct json * No-op checker to execute with Quorum, not ALL * Make tag for build unique Patch by Alex Petrov for CASSANDRA-16262 --- harry-core/pom.xml | 9 +- harry-core/src/harry/core/Configuration.java | 44 +- harry-core/src/harry/core/VisibleForTesting.java | 5 + harry-core/src/harry/corruptor/RowCorruptor.java | 2 +- harry-core/src/harry/ddl/ColumnSpec.java | 10 +- harry-core/src/harry/ddl/SchemaGenerators.java | 76 + harry-core/src/harry/ddl/SchemaSpec.java | 102 ++--- .../src/harry/generators/DataGenerators.java | 17 ++- .../src/harry/generators/RandomGenerator.java | 3 +- harry-core/src/harry/generators/RngUtils.java | 6 +- harry-core/src/harry/generators/Surjections.java | 2 +- .../harry/model/AlwaysSamePartitionSelector.java | 69 + harry-core/src/harry/model/NoOpChecker.java| 3 +- harry-core/src/harry/model/OpSelectors.java| 54 +-- harry-core/src/harry/model/SelectHelper.java | 114 ++ .../model/clock/ApproximateMonotonicClock.java | 3 +- harry-core/src/harry/model/clock/OffsetClock.java | 20 +++ harry-core/src/harry/model/sut/PrintlnSut.java | 18 +++ harry-core/src/harry/operations/DeleteHelper.java | 61 harry-core/src/harry/operations/Relation.java | 80 ++ harry-core/src/harry/operations/WriteHelper.java | 170 +++-- harry-core/src/harry/reconciler/Reconciler.java| 61 +--- .../harry/runner/CorruptingPartitionVisitor.java | 1 - harry-core/src/harry/runner/DataTracker.java | 3 + .../src/harry/runner/DefaultDataTracker.java | 2 +- .../src/harry/runner/MutatingPartitionVisitor.java | 1 + .../src/harry/runner/MutatingRowVisitor.java | 44 +- harry-core/src/harry/runner/Operation.java | 20 ++- harry-core/src/harry/runner/QueryGenerator.java| 2 +- harry-core/src/harry/util/BitSet.java | 2 +- harry-core/src/harry/util/TestRunner.java | 9 +- harry-core/test/harry/model/OpSelectorsTest.java | 34 +++-- 32 files changed, 690 insertions(+), 357 deletions(-) diff --git a/harry-core/pom.xml b/harry-core/pom.xml index fef070d..d313e7a 100755 --- a/harry-core/pom.xml +++ b/harry-core/pom.xml @@ -33,10 +33,11 @@ Harry Core - -com.datastax.cassandra -cassandra-driver-core - + +org.slf4j +slf4j-api +1.7.25 + org.apache.commons diff --git a/harry-core/src/harry/core/Configuration.java b/harry-core/src/harry/core/Configuration.java index f843e94..4a2a1e6 100644 --- a/harry-core/src/harry/core/Configuration.java +++ b/harry-core/src/harry/core/Configuration.java @@ -38,10 +38,13 @@ import harry.ddl.SchemaGenerators; import harry.ddl.SchemaSpec; import harry.generators.Surjections; import harry.generators.distribution.Distribution; +import harry.model.AlwaysSamePartitionSelector; import harry.model.Model; import harry.model.OpSelectors; import harry.model.QuiescentChecker; import harry.model.clock.ApproximateMonotonicClock; +import harry.model.clock.OffsetClock; +import harry.model.sut.PrintlnSut; import harry.model.sut.SystemUnderTest; import harry.runner.AllPartitionsValidator; import harry.runner.CorruptingPartitionVisitor; @@ -92,7 +95,10 @@ public class Configuration mapper.registerSubtypes(CorruptingPartitionVisitorConfiguration.class); mapper.registerSubtypes(RecentPartitionsValidatorConfiguration.class); mapper.registerSubtypes(FixedSchemaProviderConfiguration.class); - +
[cassandra-harry] 04/05: Move classes to appropriate packages
This is an automated email from the ASF dual-hosted git repository.
ifesdjeen pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-harry.git
commit 83dd5a64edf9f62f5b3c5c468c6435f49b580cf3
Author: Alex Petrov
AuthorDate: Thu Jul 15 08:29:57 2021 +0200
Move classes to appropriate packages
---
harry-core/src/harry/core/Configuration.java | 20
harry-core/src/harry/core/Run.java | 2 +-
.../src/harry/corruptor/AddExtraRowCorruptor.java | 2 +-
.../harry/corruptor/QueryResponseCorruptor.java| 3 +-
harry-core/src/harry/model/Model.java | 3 +-
harry-core/src/harry/model/NoOpChecker.java| 2 +-
harry-core/src/harry/model/QuiescentChecker.java | 4 +-
harry-core/src/harry/model/SelectHelper.java | 2 +-
.../src/harry/{runner => operations}/Query.java| 5 +-
.../{runner => operations}/QueryGenerator.java | 4 +-
harry-core/src/harry/reconciler/Reconciler.java| 8 ++--
harry-core/src/harry/runner/Runner.java| 2 +-
.../AbstractPartitionVisitor.java | 7 ++-
.../AllPartitionsValidator.java| 3 +-
.../CorruptingPartitionVisitor.java| 4 +-
.../visitors}/FaultInjectingPartitionVisitor.java | 4 +-
.../LoggingPartitionVisitor.java | 2 +-
.../MutatingPartitionVisitor.java | 4 +-
.../{runner => visitors}/MutatingRowVisitor.java | 4 +-
.../src/harry/{runner => visitors}/Operation.java | 2 +-
.../ParallelRecentPartitionValidator.java | 4 +-
.../{runner => visitors}/ParallelValidator.java| 2 +-
.../{runner => visitors}/PartitionVisitor.java | 2 +-
.../RecentPartitionValidator.java | 6 +--
.../src/harry/{runner => visitors}/Sampler.java| 2 +-
.../SinglePartitionValidator.java | 5 +-
harry-core/test/harry/model/OpSelectorsTest.java | 6 +--
harry-core/test/harry/operations/RelationTest.java | 2 -
.../dependency-reduced-pom.xml | 54 ++
.../src/harry/runner/QueryingNoOpChecker.java | 1 +
.../harry/runner/RepairingLocalStateValidator.java | 3 ++
harry-integration/src/harry/runner/Reproduce.java | 1 +
.../src/harry/runner/TrivialShrinker.java | 53 ++---
.../harry/visitors/SkippingPartitionVisitor.java | 53 +
.../test/harry/ddl/SchemaGenTest.java | 2 +-
.../generators/DataGeneratorsIntegrationTest.java | 8 ++--
.../test/harry/model/ModelTestBase.java| 8 ++--
.../harry/model/QuerySelectorNegativeTest.java | 10 ++--
.../test/harry/model/QuerySelectorTest.java| 10 ++--
.../model/QuiescentCheckerIntegrationTest.java | 6 +--
.../test/harry/model/TestEveryClustering.java | 24 --
.../test/harry/op/RowVisitorTest.java | 2 +-
42 files changed, 206 insertions(+), 145 deletions(-)
diff --git a/harry-core/src/harry/core/Configuration.java
b/harry-core/src/harry/core/Configuration.java
index 4a2a1e6..0e065d5 100644
--- a/harry-core/src/harry/core/Configuration.java
+++ b/harry-core/src/harry/core/Configuration.java
@@ -46,19 +46,19 @@ import harry.model.clock.ApproximateMonotonicClock;
import harry.model.clock.OffsetClock;
import harry.model.sut.PrintlnSut;
import harry.model.sut.SystemUnderTest;
-import harry.runner.AllPartitionsValidator;
-import harry.runner.CorruptingPartitionVisitor;
+import harry.visitors.AllPartitionsValidator;
+import harry.visitors.CorruptingPartitionVisitor;
import harry.runner.DataTracker;
import harry.runner.DefaultDataTracker;
-import harry.runner.LoggingPartitionVisitor;
-import harry.runner.MutatingPartitionVisitor;
-import harry.runner.MutatingRowVisitor;
-import harry.runner.Operation;
-import harry.runner.ParallelRecentPartitionValidator;
-import harry.runner.PartitionVisitor;
-import harry.runner.RecentPartitionValidator;
+import harry.visitors.LoggingPartitionVisitor;
+import harry.visitors.MutatingPartitionVisitor;
+import harry.visitors.MutatingRowVisitor;
+import harry.visitors.Operation;
+import harry.visitors.ParallelRecentPartitionValidator;
+import harry.visitors.PartitionVisitor;
+import harry.visitors.RecentPartitionValidator;
import harry.runner.Runner;
-import harry.runner.Sampler;
+import harry.visitors.Sampler;
import harry.util.BitSet;
public class Configuration
diff --git a/harry-core/src/harry/core/Run.java
b/harry-core/src/harry/core/Run.java
index d31e7ad..b0c8afc 100644
--- a/harry-core/src/harry/core/Run.java
+++ b/harry-core/src/harry/core/Run.java
@@ -22,7 +22,7 @@ import harry.ddl.SchemaSpec;
import harry.model.OpSelectors;
import harry.model.sut.SystemUnderTest;
import harry.runner.DataTracker;
-import harry.runner.QueryGenerator;
+import harry.operations.QueryGenerator;
public class Run
{
diff --git a/harry-core/src/harry/corruptor/AddExtraRowCorruptor.java
[cassandra-harry] 02/05: Integration improvements
This is an automated email from the ASF dual-hosted git repository.
ifesdjeen pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-harry.git
commit 469533e2944fc12d4c82f13736160dd2eb143d44
Author: Alex Petrov
AuthorDate: Mon Jul 12 17:54:42 2021 +0200
Integration improvements
---
.../test/resources/single_partition_test.yml | 55 ++
harry-integration-external/pom.xml | 5 +
.../model/sut/external/ExternalClusterSut.java | 14 +-
harry-integration/pom.xml | 14 +-
.../src/harry/model/sut/ExternalClusterSut.java| 187 -
.../src/harry/model/sut/InJvmSutBase.java | 3 +-
.../src/harry/runner/HarryRunnerJvm.java | 43 +
harry-integration/test/conf/cassandra.yaml | 44 +
.../test/harry/ddl/SchemaGenTest.java | 15 +-
.../generators/DataGeneratorsIntegrationTest.java | 104
.../test/harry/model/IntegrationTestBase.java | 6 +-
.../model/QuiescentCheckerIntegrationTest.java | 3 +-
.../test/harry/model/TestEveryClustering.java | 89 ++
.../test/harry/op/RowVisitorTest.java | 8 +-
.../test/resources/single_partition_test.yml | 55 ++
15 files changed, 435 insertions(+), 210 deletions(-)
diff --git a/harry-integration-backup/test/resources/single_partition_test.yml
b/harry-integration-backup/test/resources/single_partition_test.yml
new file mode 100644
index 000..0ebe2aa
--- /dev/null
+++ b/harry-integration-backup/test/resources/single_partition_test.yml
@@ -0,0 +1,55 @@
+seed: 1
+
+# Default schema provider generates random schema
+schema_provider:
+ default: {}
+
+drop_schema: false
+create_schema: true
+truncate_table: false
+
+clock:
+ offset:
+offset: 1000
+
+run_time: 10
+run_time_unit: "MINUTES"
+
+system_under_test:
+ println: {}
+
+partition_descriptor_selector:
+ always_same:
+pd: 12345
+
+clustering_descriptor_selector:
+ default:
+modifications_per_lts:
+ type: "constant"
+ constant: 2
+rows_per_modification:
+ type: "constant"
+ constant: 2
+operation_kind_weights:
+ DELETE_RANGE: 1
+ DELETE_SLICE: 1
+ DELETE_ROW: 1
+ DELETE_COLUMN: 1
+ DELETE_PARTITION: 1
+ DELETE_COLUMN_WITH_STATICS: 1
+ INSERT_WITH_STATICS: 24
+ INSERT: 24
+ UPDATE_WITH_STATICS: 23
+ UPDATE: 23
+column_mask_bitsets: null
+max_partition_size: 100
+
+data_tracker:
+ no_op: {}
+
+runner:
+ sequential:
+partition_visitors: []
+
+metric_reporter:
+ no_op: {}
\ No newline at end of file
diff --git a/harry-integration-external/pom.xml
b/harry-integration-external/pom.xml
index 8c57e0e..0b49f6d 100755
--- a/harry-integration-external/pom.xml
+++ b/harry-integration-external/pom.xml
@@ -34,6 +34,11 @@
+com.datastax.cassandra
+cassandra-driver-core
+
+
+
org.apache.cassandra
harry-core
${project.parent.version}
diff --git
a/harry-integration-external/src/harry/model/sut/external/ExternalClusterSut.java
b/harry-integration-external/src/harry/model/sut/external/ExternalClusterSut.java
index e471ede..76a4e3c 100644
---
a/harry-integration-external/src/harry/model/sut/external/ExternalClusterSut.java
+++
b/harry-integration-external/src/harry/model/sut/external/ExternalClusterSut.java
@@ -93,9 +93,7 @@ public class ExternalClusterSut implements SystemUnderTest
{
try
{
-Statement st = new SimpleStatement(statement, bindings);
-st.setConsistencyLevel(toDriverCl(cl));
-return resultSetToObjectArray(session.execute(st));
+return resultSetToObjectArray(session.execute(statement,
bindings));
}
catch (Throwable t)
{
@@ -134,9 +132,7 @@ public class ExternalClusterSut implements SystemUnderTest
public CompletableFuture executeAsync(String statement,
ConsistencyLevel cl, Object... bindings)
{
CompletableFuture future = new CompletableFuture<>();
-Statement st = new SimpleStatement(statement, bindings);
-st.setConsistencyLevel(toDriverCl(cl));
-Futures.addCallback(session.executeAsync(st),
+Futures.addCallback(session.executeAsync(statement, bindings),
new FutureCallback()
{
public void onSuccess(ResultSet rows)
@@ -185,8 +181,10 @@ public class ExternalClusterSut implements SystemUnderTest
{
switch (cl)
{
-case ALL:return com.datastax.driver.core.ConsistencyLevel.ALL;
-case QUORUM: return
com.datastax.driver.core.ConsistencyLevel.QUORUM;
+case ALL:
+return com.datastax.driver.core.ConsistencyLevel.ALL;
+case QUORUM:
+
[cassandra-harry] branch trunk updated (ddd643e -> f6b4df6)
This is an automated email from the ASF dual-hosted git repository.
ifesdjeen pushed a change to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-harry.git.
from ddd643e Fix MetricReporter serialization; Update example yaml configs
for required props.
new df40fa3 Core improvements
new 469533e Integration improvements
new 59604db Adjust config files
new 83dd5a6 Move classes to appropriate packages
new f6b4df6 Add history builder and an ability to write unit-tests with
Harry
The 5 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
README.md | 221 +++-
conf/{example.yaml => default.yaml}| 56 +-
conf/external.yaml | 56 +-
docker/Dockerfile.local| 2 +-
docker/run.sh | 2 +-
harry-core/pom.xml | 9 +-
harry-core/src/harry/core/Configuration.java | 128 +++--
harry-core/src/harry/core/Run.java | 2 +-
harry-core/src/harry/core/VisibleForTesting.java | 5 +
.../src/harry/corruptor/AddExtraRowCorruptor.java | 4 +-
.../harry/corruptor/QueryResponseCorruptor.java| 3 +-
harry-core/src/harry/corruptor/RowCorruptor.java | 2 +-
harry-core/src/harry/ddl/ColumnSpec.java | 10 +-
harry-core/src/harry/ddl/SchemaGenerators.java | 76 ++-
harry-core/src/harry/ddl/SchemaSpec.java | 102 +++-
harry-core/src/harry/dsl/HistoryBuilder.java | 625 +
.../src/harry/generators/DataGenerators.java | 17 +-
.../src/harry/generators/RandomGenerator.java | 3 +-
harry-core/src/harry/generators/RngUtils.java | 6 +-
harry-core/src/harry/generators/Surjections.java | 2 +-
.../harry/model/AlwaysSamePartitionSelector.java | 69 +++
harry-core/src/harry/model/Model.java | 3 +-
harry-core/src/harry/model/NoOpChecker.java| 5 +-
harry-core/src/harry/model/OpSelectors.java| 67 ++-
harry-core/src/harry/model/QuiescentChecker.java | 18 +-
harry-core/src/harry/model/SelectHelper.java | 116 ++--
.../model/clock/ApproximateMonotonicClock.java | 8 +-
harry-core/src/harry/model/clock/OffsetClock.java | 25 +
harry-core/src/harry/model/sut/PrintlnSut.java | 18 +
harry-core/src/harry/operations/DeleteHelper.java | 61 +-
.../src/harry/{runner => operations}/Query.java| 5 +-
.../{runner => operations}/QueryGenerator.java | 6 +-
harry-core/src/harry/operations/Relation.java | 80 +--
harry-core/src/harry/operations/WriteHelper.java | 171 +++---
harry-core/src/harry/reconciler/Reconciler.java| 145 +++--
harry-core/src/harry/runner/DataTracker.java | 1 +
.../src/harry/runner/DefaultDataTracker.java | 7 +-
.../src/harry/runner/LoggingPartitionVisitor.java | 79 ---
.../src/harry/runner/MutatingPartitionVisitor.java | 144 -
harry-core/src/harry/runner/Runner.java| 46 +-
harry-core/src/harry/util/BitSet.java | 2 +-
harry-core/src/harry/util/TestRunner.java | 48 +-
.../AllPartitionsValidator.java| 7 +-
.../CorruptingVisitor.java}| 13 +-
.../DelegatingVisitor.java}| 38 +-
.../GeneratingVisitor.java}| 60 +-
harry-core/src/harry/visitors/LoggingVisitor.java | 90 +++
.../{runner => visitors}/MutatingRowVisitor.java | 60 +-
harry-core/src/harry/visitors/MutatingVisitor.java | 169 ++
.../OperationExecutor.java}| 26 +-
.../ParallelRecentValidator.java} | 30 +-
.../{runner => visitors}/ParallelValidator.java| 6 +-
.../RecentValidator.java} | 22 +-
.../src/harry/visitors/ReplayingVisitor.java | 121
.../src/harry/{runner => visitors}/Sampler.java| 10 +-
.../SingleValidator.java} | 14 +-
.../VisitExecutor.java}| 31 +-
.../Visitor.java} | 14 +-
harry-core/test/harry/model/OpSelectorsTest.java | 46 +-
harry-core/test/harry/operations/RelationTest.java | 4 +-
.../dependency-reduced-pom.xml | 54 ++
harry-integration-external/pom.xml | 5 +
.../model/sut/external/ExternalClusterSut.java | 14 +-
harry-integration/pom.xml | 14 +-
.../src/harry/model/sut/ExternalClusterSut.java| 187 --
.../model/sut/InJVMTokenAwareVisitExecutor.java| 114
.../src/harry/model/sut/InJvmSut.java | 22 +
.../src/harry/model/sut/InJvmSutBase.java | 3 +-
[cassandra-harry] branch CASSANDRA-16262-2 updated (af4bb14 -> b452c6f)
This is an automated email from the ASF dual-hosted git repository.
ifesdjeen pushed a change to branch CASSANDRA-16262-2
in repository https://gitbox.apache.org/repos/asf/cassandra-harry.git.
discard af4bb14 Move classes to appropriate packages
discard 32a9200 Adjust config files
discard 57053de Integration improvements
discard f22d52e Core improvements
add ddd643e Fix MetricReporter serialization; Update example yaml configs
for required props.
add 9406aad Core improvements
add 1890434 Integration improvements
add 76e87fd Adjust config files
add 5dffda9 Move classes to appropriate packages
add b452c6f Add history builder and an ability to write unit-tests with
Harry
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (af4bb14)
\
N -- N -- N refs/heads/CASSANDRA-16262-2 (b452c6f)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
No new revisions were added by this update.
Summary of changes:
README.md | 218 ++-
conf/default.yaml | 2 +-
conf/external.yaml | 2 +-
harry-core/src/harry/core/Configuration.java | 78 +--
.../src/harry/corruptor/AddExtraRowCorruptor.java | 2 +-
harry-core/src/harry/dsl/HistoryBuilder.java | 625 +
harry-core/src/harry/model/OpSelectors.java| 25 +-
harry-core/src/harry/model/QuiescentChecker.java | 14 +-
.../model/clock/ApproximateMonotonicClock.java | 5 +
harry-core/src/harry/model/clock/OffsetClock.java | 5 +
harry-core/src/harry/operations/WriteHelper.java | 3 +-
harry-core/src/harry/reconciler/Reconciler.java| 86 +--
harry-core/src/harry/runner/DataTracker.java | 2 -
.../src/harry/runner/DefaultDataTracker.java | 5 +-
harry-core/src/harry/runner/Runner.java| 46 +-
harry-core/src/harry/util/TestRunner.java | 39 ++
.../src/harry/visitors/AllPartitionsValidator.java | 4 +-
...artitionVisitor.java => CorruptingVisitor.java} | 8 +-
.../DelegatingVisitor.java}| 46 +-
...artitionVisitor.java => GeneratingVisitor.java} | 63 +--
.../harry/visitors/LoggingPartitionVisitor.java| 79 ---
harry-core/src/harry/visitors/LoggingVisitor.java | 90 +++
.../harry/visitors/MutatingPartitionVisitor.java | 145 -
.../src/harry/visitors/MutatingRowVisitor.java | 18 +-
harry-core/src/harry/visitors/MutatingVisitor.java | 169 ++
.../{Operation.java => OperationExecutor.java} | 4 +-
...Validator.java => ParallelRecentValidator.java} | 26 +-
.../src/harry/visitors/ParallelValidator.java | 4 +-
...artitionValidator.java => RecentValidator.java} | 16 +-
.../src/harry/visitors/ReplayingVisitor.java | 121
harry-core/src/harry/visitors/Sampler.java | 8 +-
...artitionValidator.java => SingleValidator.java} | 11 +-
.../{PartitionVisitor.java => VisitExecutor.java} | 23 +-
.../{PartitionVisitor.java => Visitor.java}| 12 +-
harry-core/test/harry/model/OpSelectorsTest.java | 12 +-
harry-core/test/harry/operations/RelationTest.java | 2 +-
.../test/resources/single_partition_test.yml | 55 --
.../model/sut/InJVMTokenAwareVisitExecutor.java| 114
.../src/harry/model/sut/InJvmSut.java | 22 +
...tionVisitor.java => FaultInjectingVisitor.java} | 25 +-
.../harry/runner/RepairingLocalStateValidator.java | 20 +-
.../src/harry/runner/TrivialShrinker.java | 29 +-
.../harry/visitors/SkippingPartitionVisitor.java | 53 --
.../src/harry/visitors/SkippingVisitor.java| 36 +-
.../generators/DataGeneratorsIntegrationTest.java | 32 +-
.../harry/model/HistoryBuilderIntegrationTest.java | 197 +++
.../test/harry/model/HistoryBuilderTest.java | 186 ++
.../harry/model/InJVMTokenAwareExecutorTest.java | 91 +++
.../test/harry/model/ModelTestBase.java| 22 +-
.../harry/model/QuerySelectorNegativeTest.java | 10 +-
.../test/harry/model/QuerySelectorTest.java| 12 +-
.../model/QuiescentCheckerIntegrationTest.java | 8 +-
.../test/harry/model/TestEveryClustering.java | 83 ---
.../test/resources/single_partition_test.yml | 2 +-
54 files changed, 2251 insertions(+), 764 deletions(-)
create mode 100644 harry-core/src/harry/dsl/HistoryBuilder.java
rename
[jira] [Comment Edited] (CASSANDRA-16981) Respect com.sun.management.jxmremote.host
[ https://issues.apache.org/jira/browse/CASSANDRA-16981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423057#comment-17423057 ] Ekaterina Dimitrova edited comment on CASSANDRA-16981 at 10/1/21, 2:10 PM: --- It seems the builds and the new 3.11 tests were fine. For the record, the ongoing Jenkins issue started before I pushed the image and it is not related. ||Patch||CI|| |[3.11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1136/workflows/2cb30763-d93f-479e-b23e-dc51b98011ed]|[Circle|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1131/workflows/52ed7138-c1ab-4604-bfc9-d68c8ba1292c], [Jenkins|https://jenkins-cm4.apache.org/job/Cassandra-devbranch/1152/]| |[4.0|https://github.com/ekaterinadimitrova2/cassandra/pull/182/commits/1e2e1871dddc7a21b20dcb81e4b9ec6f594fafac]|[j8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1134/workflows/82fc0892-6978-41e3-b234-840b24d13fb0], [j11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=16981-4.0]| |[trunk|https://github.com/apache/cassandra/commit/3bdb364edc97839f094fa4a95e445099c3c9ec2a]|[j8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/3e76993a-8ff0-442b-ae19-e3c6abf09ee6], [j11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/a36af32c-ce61-47cf-b0bd-f8343025ca05]| I propagated the patch to all branches and pushed build and unit tests. Should be fine. I can submit full Jenkins build when we solved the issues there was (Author: e.dimitrova): It seems the builds and the new 3.11 tests were fine. For the record, the ongoing Jenkins issue started before I pushed the image and it is not related. ||Patch||CI|| |[3.11|https://github.com/apache/cassandra/commit/2bbeecabb787a1aed1593399c29f3b9bcdc1e923]|[Circle|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1131/workflows/52ed7138-c1ab-4604-bfc9-d68c8ba1292c], [Jenkins|https://jenkins-cm4.apache.org/job/Cassandra-devbranch/1152/]| |[4.0|https://github.com/ekaterinadimitrova2/cassandra/pull/182/commits/1e2e1871dddc7a21b20dcb81e4b9ec6f594fafac]|[j8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1134/workflows/82fc0892-6978-41e3-b234-840b24d13fb0], [j11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=16981-4.0]| |[trunk|https://github.com/apache/cassandra/commit/3bdb364edc97839f094fa4a95e445099c3c9ec2a]|[j8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/3e76993a-8ff0-442b-ae19-e3c6abf09ee6], [j11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/a36af32c-ce61-47cf-b0bd-f8343025ca05]| I propagated the patch to all branches and pushed build and unit tests. Should be fine. I can submit full Jenkins build when we solved the issues there > Respect com.sun.management.jxmremote.host > -- > > Key: CASSANDRA-16981 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16981 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 3.11.x, 4.0.x, 4.x > > Attachments: Screenshot 2021-09-27 at 22.27.57.png > > > It seems we don't respect com.sun.management.jxmremote.host in > [createJMXServer()|https://github.com/apache/cassandra/blob/cassandra-3.11/src/java/org/apache/cassandra/utils/JMXServerUtils.java#L64] > The flow should be - when_ local _is true, we only bind localhost, otherwise > we bind everything, unless com.sun.management.jmxremote.host is set, then we > use that. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17020) Cqlshlib failure
[ https://issues.apache.org/jira/browse/CASSANDRA-17020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423303#comment-17423303 ] Brandon Williams commented on CASSANDRA-17020: -- Also, I believe this will fail all builds, not just 4.0 and trunk, since they all use thrift and the setuptools version is pulled automagically. For 4.0 and trunk we can just [remove thrift|https://github.com/apache/cassandra/blob/trunk/pylib/requirements.txt#L21]. > Cqlshlib failure > > > Key: CASSANDRA-17020 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17020 > Project: Cassandra > Issue Type: Bug > Components: CI >Reporter: Ekaterina Dimitrova >Priority: Normal > > Failing for 4.0 and trunk - > [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/3e76993a-8ff0-442b-ae19-e3c6abf09ee6/jobs/6670] > > > /CC [~brandon.williams] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17020) Cqlshlib failure
[ https://issues.apache.org/jira/browse/CASSANDRA-17020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423300#comment-17423300 ] Brandon Williams commented on CASSANDRA-17020: -- setuptools deprecated 'use_2to3': https://github.com/pypa/setuptools/issues/2086 which the thrift 0.9.3 package sets to True. When we began pulling in setuptools 0.58.1, this broke the build. > Cqlshlib failure > > > Key: CASSANDRA-17020 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17020 > Project: Cassandra > Issue Type: Bug > Components: CI >Reporter: Ekaterina Dimitrova >Priority: Normal > > Failing for 4.0 and trunk - > [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/3e76993a-8ff0-442b-ae19-e3c6abf09ee6/jobs/6670] > > > /CC [~brandon.williams] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17020) Cqlshlib failure
[ https://issues.apache.org/jira/browse/CASSANDRA-17020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17020: Description: Failing for 4.0 and trunk - [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/3e76993a-8ff0-442b-ae19-e3c6abf09ee6/jobs/6670] /CC [~brandon.williams] was:Failing for 4.0 and trunk - https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/3e76993a-8ff0-442b-ae19-e3c6abf09ee6/jobs/6670 > Cqlshlib failure > > > Key: CASSANDRA-17020 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17020 > Project: Cassandra > Issue Type: Bug > Components: CI >Reporter: Ekaterina Dimitrova >Priority: Normal > > Failing for 4.0 and trunk - > [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/3e76993a-8ff0-442b-ae19-e3c6abf09ee6/jobs/6670] > > > /CC [~brandon.williams] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17020) Cqlshlib failure
[ https://issues.apache.org/jira/browse/CASSANDRA-17020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17020: Bug Category: Parent values: Degradation(12984) Complexity: Normal Component/s: CI Discovered By: User Report Severity: Normal Status: Open (was: Triage Needed) > Cqlshlib failure > > > Key: CASSANDRA-17020 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17020 > Project: Cassandra > Issue Type: Bug > Components: CI >Reporter: Ekaterina Dimitrova >Priority: Normal > > Failing for 4.0 and trunk - > https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/3e76993a-8ff0-442b-ae19-e3c6abf09ee6/jobs/6670 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-17020) Cqlshlib failure
Ekaterina Dimitrova created CASSANDRA-17020: --- Summary: Cqlshlib failure Key: CASSANDRA-17020 URL: https://issues.apache.org/jira/browse/CASSANDRA-17020 Project: Cassandra Issue Type: Bug Reporter: Ekaterina Dimitrova Failing for 4.0 and trunk - https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1135/workflows/3e76993a-8ff0-442b-ae19-e3c6abf09ee6/jobs/6670 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-11181) Add broadcast_rpc_address to system.local
[ https://issues.apache.org/jira/browse/CASSANDRA-11181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423286#comment-17423286 ] Aleksei Zotov commented on CASSANDRA-11181: --- Sounds good to me. +1 to the current changes (please, don't forget to pick the unit test up). Or let me know and I'll get it merged. > Add broadcast_rpc_address to system.local > - > > Key: CASSANDRA-11181 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11181 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Distributed Metadata >Reporter: Nick Bailey >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > Right now it's impossible to get the broadcast_rpc_address of the node you > are connected to via the drivers. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-11181) Add broadcast_rpc_address to system.local
[ https://issues.apache.org/jira/browse/CASSANDRA-11181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-11181: -- Status: Review In Progress (was: Needs Committer) > Add broadcast_rpc_address to system.local > - > > Key: CASSANDRA-11181 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11181 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Distributed Metadata >Reporter: Nick Bailey >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > Right now it's impossible to get the broadcast_rpc_address of the node you > are connected to via the drivers. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-11181) Add broadcast_rpc_address to system.local
[
https://issues.apache.org/jira/browse/CASSANDRA-11181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422426#comment-17422426
]
Aleksei Zotov edited comment on CASSANDRA-11181 at 10/1/21, 12:17 PM:
--
h3. ssl_storage_port
I have a different perception on {{ssl_storage_port}}. Even if 16830 gets
delayed, I see no need to expose {{ssl_storage_port}} since it is deprecated.
People should not generally use deprecated properties, so there should be no
much value of exposing it. For me it seems to be a work without much value: we
introduce the field (without having enough justification that someone really
needs it) and then soon remove.
I'm not really familiar with many real use cases, maybe some people really
struggle without this functionality. But, frankly speaking, I'm not clear what
the use of such exposing is unless someone develops a library or smth very
flexible. Within an organization some static value is generally used (even if
it might be non default) and people may simply assume (as a workaround until
the property is completely removed) the port number since it is not dynamic.
Please, share your thoughts.
h3. listen_on_broadcast_address
{quote}While the settings are kept as they they, uses of that method will
ignore any defined {{listen_address}}.
{quote}
[~mck] are you sure? Here is what I can see locally:
{code:java}
INFO [Messaging-EventLoop-3-3] 2021-09-30 02:01:07,675
OutboundConnection.java:1150 -
/127.0.0.4:7000(/127.0.0.1:49010)->/127.0.0.1:7000-URGENT_MESSAGES-736a3123
successfully connected, version = 12, framing = CRC, encryption = unencrypted
INFO [Messaging-EventLoop-3-4] 2021-09-30 02:01:07,692
InboundConnectionInitiator.java:484 -
/127.0.0.4:7000(/127.0.0.1:49010)->localhost/127.0.0.1:7000-URGENT_MESSAGES-393447d2
messaging connection established, version = 12, framing = CRC, encryption =
unencrypted
INFO [Messaging-EventLoop-3-3] 2021-09-30 02:01:07,712
OutboundConnection.java:1150 -
/127.0.0.4:7000(/127.0.0.1:47290)->/127.0.0.4:7000-URGENT_MESSAGES-d8dd5b25
successfully connected, version = 12, framing = CRC, encryption = unencrypted
INFO [Messaging-EventLoop-3-4] 2021-09-30 02:01:07,713
InboundConnectionInitiator.java:484 -
/127.0.0.4:7000(/127.0.0.1:47290)->localhost/127.0.0.1:7000(/127.0.0.4:7000)-URGENT_MESSAGES-d3120790
messaging connection established, version = 12, framing = CRC, encryption =
unencrypted{code}
for configuration:
{code:java}
broadcast_address: 127.0.0.4
listen_address: localhost
listen_on_broadcast_address: true
{code}
This configuration failed with "listen_address: localhost" (I have not checked
why, maybe that would dispel my confusion - the devil is in the details :)),
but the point is that C* seems to listen on both IPs. So the behavior you
explained earlier:
{code:java}
broadcast_address = FBUtilities.getJustBroadcastAddress() # broadcast_address
orElse same-as-listen_address-below
listen_address = FBUtilities.getJustLocalAddress()
# listen_address orElse listen_interface orElse InetAddress.getLocalHost()
orElse InetAddress.getLoopbackAddress()
{code}
seems to be correct to me.
I'm just confused on what seems to be wrong. Could you please highlight what
I'm missing.
was (Author: azotcsit):
h3. ssl_storage_port
I have a different perception on {{ssl_storage_port}}. Even if 16830 gets
delayed, I see no need to expose {{ssl_storage_port}} since it is deprecated.
People should not generally use deprecated properties, so there should be no
much value of exposing it. For me it seems to be a work without much value: we
introduce the field (without having enough justification that someone really
needs it) and then soon remove.
I'm not really familiar with many real use cases, maybe some people really
struggle without this functionality. But, frankly speaking, I'm not clear what
the use of such exposing is unless someone develops a library or smth very
flexible. Within an organization some static value is generally used (even if
it might be non default) and people may simply assume (as a workaround until
the property is completely removed) the port number since it is not dynamic.
Please, share your thoughts.
h3. listen_on_broadcast_address
{quote}While the settings are kept as they they, uses of that method will
ignore any defined {{listen_address}}.
{quote}
[~mck] are you sure? Here is what I can see locally:
{code:java}
INFO [Messaging-EventLoop-3-3] 2021-09-30 02:01:07,675
OutboundConnection.java:1150 -
/127.0.0.4:7000(/127.0.0.1:49010)->/127.0.0.1:7000-URGENT_MESSAGES-736a3123
successfully connected, version = 12, framing = CRC, encryption = unencrypted
INFO [Messaging-EventLoop-3-4] 2021-09-30 02:01:07,692
InboundConnectionInitiator.java:484 -
/127.0.0.4:7000(/127.0.0.1:49010)->localhost/127.0.0.1:7000-URGENT_MESSAGES-393447d2
messaging connection established, version = 12, framing = CRC,
[jira] [Updated] (CASSANDRA-17019) JNA 5.6.0 does not support arm64
[ https://issues.apache.org/jira/browse/CASSANDRA-17019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-17019: - Bug Category: Parent values: Availability(12983)Level 1 values: Unavailable(12994) Complexity: Normal Component/s: Dependencies Discovered By: User Report Platform: ARM (was: All) Severity: Normal Status: Open (was: Triage Needed) > JNA 5.6.0 does not support arm64 > > > Key: CASSANDRA-17019 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17019 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: Igamr Palsenberg >Priority: Normal > > Cassandra depends on net.java.dev.jna.jna version 5.6.0 to do the native > binding into the C library. > JNA 5.6.0 does not support arm64 architecture (Apple M1 devices), causing > cassandra to fail on bootstrap. > Bumping the dependency to 5.9.0 adds arm64 support. Will a PR to bump the > dependency be acceptable ? -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16959) nodetool setstreamthroughput accepts invalid arguments that are not immediately applied
[
https://issues.apache.org/jira/browse/CASSANDRA-16959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-16959:
--
Fix Version/s: (was: 4.0.x)
(was: 3.11.x)
(was: 4.x)
(was: 3.0.x)
4.1
4.0.2
3.11.12
3.0.26
Since Version: NA
Source Control Link:
https://github.com/apache/cassandra/commit/4f8afe85bfb2633d98beed39e665463bf19b8789
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> nodetool setstreamthroughput accepts invalid arguments that are not
> immediately applied
> ---
>
> Key: CASSANDRA-16959
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16959
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 3.0.26, 3.11.12, 4.0.2, 4.1
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Both {{nodetool setstreamthroughput}} and {{nodetool
> setinterdcstreamthroughput}} accept a negative throughput. The throughput
> value is not immediately applied to the corresponding rate limiters. Instead,
> the value is [set in the
> {{Config}}|https://github.com/apache/cassandra/blob/09c89e5f5f8604301c233130dfb6e82a36ae30f3/src/java/org/apache/cassandra/service/StorageService.java#L1488]
> and it's only applied to the singleton rate limiter when new sstable stream
> writer are created (see
> [here|https://github.com/apache/cassandra/blob/09c89e5f5f8604301c233130dfb6e82a36ae30f3/src/java/org/apache/cassandra/streaming/StreamManager.java#L66-L76]).
> This could happen much later than the definition of the new throughput, and
> by then the setting of the new rate in the rate limiter will fail with an
> {{IllegalArgumentException}} due to the negative value.
> I think we should either immediately reject negative throughputs or consider
> them unlimited, as we do with zero. Also we should probably apply the new
> throughput to the rate limiter immediately, since I don't see why we should
> wait to start using the new throughput.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16959) nodetool setstreamthroughput accepts invalid arguments that are not immediately applied
[
https://issues.apache.org/jira/browse/CASSANDRA-16959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423236#comment-17423236
]
Andres de la Peña commented on CASSANDRA-16959:
---
Thanks for the reviews, committed to 3.0 as
[4f8afe85bfb2633d98beed39e665463bf19b8789|https://github.com/apache/cassandra/commit/4f8afe85bfb2633d98beed39e665463bf19b8789]
and merged to
[3.11|https://github.com/apache/cassandra/commit/c6e897d2d43bd8c2dff9553cee466231247b9840],
[4.0|https://github.com/apache/cassandra/commit/339e8b74bff715f112e4b5947645c9e6cd00de7f]
and
[trunk|https://github.com/apache/cassandra/commit/0ccca8dab21719cc9248a87542a504cc057700e1].
> nodetool setstreamthroughput accepts invalid arguments that are not
> immediately applied
> ---
>
> Key: CASSANDRA-16959
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16959
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Both {{nodetool setstreamthroughput}} and {{nodetool
> setinterdcstreamthroughput}} accept a negative throughput. The throughput
> value is not immediately applied to the corresponding rate limiters. Instead,
> the value is [set in the
> {{Config}}|https://github.com/apache/cassandra/blob/09c89e5f5f8604301c233130dfb6e82a36ae30f3/src/java/org/apache/cassandra/service/StorageService.java#L1488]
> and it's only applied to the singleton rate limiter when new sstable stream
> writer are created (see
> [here|https://github.com/apache/cassandra/blob/09c89e5f5f8604301c233130dfb6e82a36ae30f3/src/java/org/apache/cassandra/streaming/StreamManager.java#L66-L76]).
> This could happen much later than the definition of the new throughput, and
> by then the setting of the new rate in the rate limiter will fail with an
> {{IllegalArgumentException}} due to the negative value.
> I think we should either immediately reject negative throughputs or consider
> them unlimited, as we do with zero. Also we should probably apply the new
> throughput to the rate limiter immediately, since I don't see why we should
> wait to start using the new throughput.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0 updated (59f5e57 -> 339e8b7)
This is an automated email from the ASF dual-hosted git repository. adelapena pushed a change to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 59f5e57 Merge branch 'cassandra-3.11' into cassandra-4.0 new 4f8afe8 Immediately apply stream throughput, considering negative values as unthrottled new c6e897d Merge branch 'cassandra-3.0' into cassandra-3.11 new 339e8b7 Merge branch 'cassandra-3.11' into cassandra-4.0 The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + .../apache/cassandra/service/StorageService.java | 8 +- .../apache/cassandra/streaming/StreamManager.java | 58 +++ .../tools/nodetool/SetInterDCStreamThroughput.java | 3 +- .../tools/nodetool/SetStreamThroughput.java| 3 +- .../cassandra/streaming/StreamManagerTest.java | 91 ++ .../SetGetInterDCStreamThroughputTest.java | 105 .../tools/nodetool/SetGetStreamThroughputTest.java | 106 + 8 files changed, 353 insertions(+), 22 deletions(-) create mode 100644 test/unit/org/apache/cassandra/streaming/StreamManagerTest.java create mode 100644 test/unit/org/apache/cassandra/tools/nodetool/SetGetInterDCStreamThroughputTest.java create mode 100644 test/unit/org/apache/cassandra/tools/nodetool/SetGetStreamThroughputTest.java - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.11' into cassandra-4.0
This is an automated email from the ASF dual-hosted git repository.
adelapena pushed a commit to branch cassandra-4.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit 339e8b74bff715f112e4b5947645c9e6cd00de7f
Merge: 59f5e57 c6e897d
Author: Andrés de la Peña
AuthorDate: Fri Oct 1 11:55:30 2021 +0100
Merge branch 'cassandra-3.11' into cassandra-4.0
CHANGES.txt| 1 +
.../apache/cassandra/service/StorageService.java | 8 +-
.../apache/cassandra/streaming/StreamManager.java | 58 +++
.../tools/nodetool/SetInterDCStreamThroughput.java | 3 +-
.../tools/nodetool/SetStreamThroughput.java| 3 +-
.../cassandra/streaming/StreamManagerTest.java | 91 ++
.../SetGetInterDCStreamThroughputTest.java | 105
.../tools/nodetool/SetGetStreamThroughputTest.java | 106 +
8 files changed, 353 insertions(+), 22 deletions(-)
diff --cc CHANGES.txt
index 4c487cc,37ec9c1..2bc99b4
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,22 -1,16 +1,23 @@@
-3.11.12
+4.0.2
+ * Correct the internode message timestamp if sending node has wrapped
(CASSANDRA-16997)
+ * Avoid race causing us to return null in RangesAtEndpoint (CASSANDRA-16965)
+ * Avoid rewriting all sstables during cleanup when transient replication is
enabled (CASSANDRA-16966)
+ * Prevent CQLSH from failure on Python 3.10 (CASSANDRA-16987)
+ * Avoid trying to acquire 0 permits from the rate limiter when taking
snapshot (CASSANDRA-16872)
+ * Upgrade Caffeine to 2.5.6 (CASSANDRA-15153)
+ * Include SASI components to snapshots (CASSANDRA-15134)
+ * Fix missed wait latencies in the output of `nodetool tpstats -F`
(CASSANDRA-16938)
+ * Remove all the state pollution between tests in SSTableReaderTest
(CASSANDRA-16888)
+ * Delay auth setup until after gossip has settled to avoid unavailables on
startup (CASSANDRA-16783)
+ * Fix clustering order logic in CREATE MATERIALIZED VIEW (CASSANDRA-16898)
+ * org.apache.cassandra.db.rows.ArrayCell#unsharedHeapSizeExcludingData
includes data twice (CASSANDRA-16900)
+ * Exclude Jackson 1.x transitive dependency of hadoop* provided dependencies
(CASSANDRA-16854)
+Merged from 3.11:
* Add key validation to ssstablescrub (CASSANDRA-16969)
* Update Jackson from 2.9.10 to 2.12.5 (CASSANDRA-16851)
- * Include SASI components to snapshots (CASSANDRA-15134)
* Make assassinate more resilient to missing tokens (CASSANDRA-16847)
- * Exclude Jackson 1.x transitive dependency of hadoop* provided dependencies
(CASSANDRA-16854)
- * Validate SASI tokenizer options before adding index to schema
(CASSANDRA-15135)
- * Fixup scrub output when no data post-scrub and clear up old use of row,
which really means partition (CASSANDRA-16835)
- * Fix ant-junit dependency issue (CASSANDRA-16827)
- * Reduce thread contention in CommitLogSegment and HintsBuffer
(CASSANDRA-16072)
- * Avoid sending CDC column if not enabled (CASSANDRA-16770)
Merged from 3.0:
+ * Immediately apply stream throughput, considering negative values as
unthrottled (CASSANDRA-16959)
* Do not release new SSTables in offline transactions (CASSANDRA-16975)
* ArrayIndexOutOfBoundsException in FunctionResource#fromName
(CASSANDRA-16977, CASSANDRA-16995)
* CVE-2015-0886 Security vulnerability in jbcrypt is addressed
(CASSANDRA-9384)
diff --cc src/java/org/apache/cassandra/streaming/StreamManager.java
index fa157a8,2b6bc46..c8c091d
--- a/src/java/org/apache/cassandra/streaming/StreamManager.java
+++ b/src/java/org/apache/cassandra/streaming/StreamManager.java
@@@ -62,19 -64,13 +63,13 @@@ public class StreamManager implements S
public static class StreamRateLimiter
{
- private static final double BYTES_PER_MEGABIT = (1024 * 1024) / 8; //
from bits
- private static final RateLimiter limiter =
RateLimiter.create(Double.MAX_VALUE);
- private static final RateLimiter interDCLimiter =
RateLimiter.create(Double.MAX_VALUE);
+ public static final double BYTES_PER_MEGABIT = (1024 * 1024) / 8; //
from bits
+ private static final RateLimiter limiter =
RateLimiter.create(calculateRateInBytes());
+ private static final RateLimiter interDCLimiter =
RateLimiter.create(calculateInterDCRateInBytes());
private final boolean isLocalDC;
-public StreamRateLimiter(InetAddress peer)
+public StreamRateLimiter(InetAddressAndPort peer)
{
- double throughput =
DatabaseDescriptor.getStreamThroughputOutboundMegabitsPerSec() *
BYTES_PER_MEGABIT;
- mayUpdateThroughput(throughput, limiter);
-
- double interDCThroughput =
DatabaseDescriptor.getInterDCStreamThroughputOutboundMegabitsPerSec() *
BYTES_PER_MEGABIT;
- mayUpdateThroughput(interDCThroughput, interDCLimiter);
-
if (DatabaseDescriptor.getLocalDataCenter() != null &&
[cassandra] branch cassandra-3.11 updated (9bf14a6 -> c6e897d)
This is an automated email from the ASF dual-hosted git repository. adelapena pushed a change to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 9bf14a6 Merge branch 'cassandra-3.0' into cassandra-3.11 new 4f8afe8 Immediately apply stream throughput, considering negative values as unthrottled new c6e897d Merge branch 'cassandra-3.0' into cassandra-3.11 The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + .../apache/cassandra/service/StorageService.java | 8 +- .../apache/cassandra/streaming/StreamManager.java | 58 +- .../tools/nodetool/SetInterDCStreamThroughput.java | 3 +- .../tools/nodetool/SetStreamThroughput.java| 3 +- .../cassandra/streaming/StreamManagerTest.java | 91 ++ 6 files changed, 142 insertions(+), 22 deletions(-) create mode 100644 test/unit/org/apache/cassandra/streaming/StreamManagerTest.java - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.0' into trunk
This is an automated email from the ASF dual-hosted git repository. adelapena pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 0ccca8dab21719cc9248a87542a504cc057700e1 Merge: 97108ef 339e8b7 Author: Andrés de la Peña AuthorDate: Fri Oct 1 11:59:09 2021 +0100 Merge branch 'cassandra-4.0' into trunk CHANGES.txt| 1 + .../apache/cassandra/service/StorageService.java | 8 +- .../apache/cassandra/streaming/StreamManager.java | 58 +++ .../tools/nodetool/SetInterDCStreamThroughput.java | 3 +- .../tools/nodetool/SetStreamThroughput.java| 3 +- .../cassandra/streaming/StreamManagerTest.java | 91 ++ .../SetGetInterDCStreamThroughputTest.java | 105 .../tools/nodetool/SetGetStreamThroughputTest.java | 106 + 8 files changed, 353 insertions(+), 22 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (97108ef -> 0ccca8d)
This is an automated email from the ASF dual-hosted git repository. adelapena pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git. from 97108ef Revert "Ninja lock setuptools version for thrift" new 4f8afe8 Immediately apply stream throughput, considering negative values as unthrottled new c6e897d Merge branch 'cassandra-3.0' into cassandra-3.11 new 339e8b7 Merge branch 'cassandra-3.11' into cassandra-4.0 new 0ccca8d Merge branch 'cassandra-4.0' into trunk The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + .../apache/cassandra/service/StorageService.java | 8 +- .../apache/cassandra/streaming/StreamManager.java | 58 +++ .../tools/nodetool/SetInterDCStreamThroughput.java | 3 +- .../tools/nodetool/SetStreamThroughput.java| 3 +- .../cassandra/streaming/StreamManagerTest.java | 91 ++ .../SetGetInterDCStreamThroughputTest.java | 105 .../tools/nodetool/SetGetStreamThroughputTest.java | 106 + 8 files changed, 353 insertions(+), 22 deletions(-) create mode 100644 test/unit/org/apache/cassandra/streaming/StreamManagerTest.java create mode 100644 test/unit/org/apache/cassandra/tools/nodetool/SetGetInterDCStreamThroughputTest.java create mode 100644 test/unit/org/apache/cassandra/tools/nodetool/SetGetStreamThroughputTest.java - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.0 updated: Immediately apply stream throughput, considering negative values as unthrottled
This is an automated email from the ASF dual-hosted git repository.
adelapena pushed a commit to branch cassandra-3.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-3.0 by this push:
new 4f8afe8 Immediately apply stream throughput, considering negative
values as unthrottled
4f8afe8 is described below
commit 4f8afe85bfb2633d98beed39e665463bf19b8789
Author: Andrés de la Peña
AuthorDate: Fri Oct 1 11:27:28 2021 +0100
Immediately apply stream throughput, considering negative values as
unthrottled
patch by Andrés de la Peña; reviewed by Aleksei Zotov, Brandon Williams and
Berenguer Blasi for CASSANDRA-16959
Co-authored-by: Niteshwar Kumar
Co-authored-by: Andrés de la Peña
---
CHANGES.txt| 1 +
.../apache/cassandra/service/StorageService.java | 8 +-
.../apache/cassandra/streaming/StreamManager.java | 58 +-
.../tools/nodetool/SetInterDCStreamThroughput.java | 3 +-
.../tools/nodetool/SetStreamThroughput.java| 3 +-
.../cassandra/streaming/StreamManagerTest.java | 90 ++
6 files changed, 141 insertions(+), 22 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index 6ef52e4..53858ac 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
3.0.26:
+ * Immediately apply stream throughput, considering negative values as
unthrottled (CASSANDRA-16959)
* Do not release new SSTables in offline transactions (CASSANDRA-16975)
* ArrayIndexOutOfBoundsException in FunctionResource#fromName
(CASSANDRA-16977, CASSANDRA-16995)
* CVE-2015-0886 Security vulnerability in jbcrypt is addressed
(CASSANDRA-9384)
diff --git a/src/java/org/apache/cassandra/service/StorageService.java
b/src/java/org/apache/cassandra/service/StorageService.java
index 0958513..78d1120 100644
--- a/src/java/org/apache/cassandra/service/StorageService.java
+++ b/src/java/org/apache/cassandra/service/StorageService.java
@@ -1259,8 +1259,10 @@ public class StorageService extends
NotificationBroadcasterSupport implements IE
public void setStreamThroughputMbPerSec(int value)
{
+int oldValue =
DatabaseDescriptor.getStreamThroughputOutboundMegabitsPerSec();
DatabaseDescriptor.setStreamThroughputOutboundMegabitsPerSec(value);
-logger.info("setstreamthroughput: throttle set to {}", value);
+StreamManager.StreamRateLimiter.updateThroughput();
+logger.info("setstreamthroughput: throttle set to {} Mb/s (was {}
Mb/s)", value, oldValue);
}
public int getStreamThroughputMbPerSec()
@@ -1270,8 +1272,10 @@ public class StorageService extends
NotificationBroadcasterSupport implements IE
public void setInterDCStreamThroughputMbPerSec(int value)
{
+int oldValue =
DatabaseDescriptor.getInterDCStreamThroughputOutboundMegabitsPerSec();
DatabaseDescriptor.setInterDCStreamThroughputOutboundMegabitsPerSec(value);
-logger.info("setinterdcstreamthroughput: throttle set to {}", value);
+StreamManager.StreamRateLimiter.updateInterDCThroughput();
+logger.info("setinterdcstreamthroughput: throttle set to {} Mb/s (was
{} Mb/s)", value, oldValue);
}
public int getInterDCStreamThroughputMbPerSec()
diff --git a/src/java/org/apache/cassandra/streaming/StreamManager.java
b/src/java/org/apache/cassandra/streaming/StreamManager.java
index dc8ec19..23638b9 100644
--- a/src/java/org/apache/cassandra/streaming/StreamManager.java
+++ b/src/java/org/apache/cassandra/streaming/StreamManager.java
@@ -28,6 +28,7 @@ import javax.management.NotificationFilter;
import javax.management.NotificationListener;
import javax.management.openmbean.CompositeData;
+import com.google.common.annotations.VisibleForTesting;
import com.google.common.base.Function;
import com.google.common.collect.Iterables;
import com.google.common.collect.Sets;
@@ -63,19 +64,13 @@ public class StreamManager implements StreamManagerMBean
public static class StreamRateLimiter
{
-private static final double BYTES_PER_MEGABIT = (1024 * 1024) / 8; //
from bits
-private static final RateLimiter limiter =
RateLimiter.create(Double.MAX_VALUE);
-private static final RateLimiter interDCLimiter =
RateLimiter.create(Double.MAX_VALUE);
+public static final double BYTES_PER_MEGABIT = (1024 * 1024) / 8; //
from bits
+private static final RateLimiter limiter =
RateLimiter.create(calculateRateInBytes());
+private static final RateLimiter interDCLimiter =
RateLimiter.create(calculateInterDCRateInBytes());
private final boolean isLocalDC;
public StreamRateLimiter(InetAddress peer)
{
-double throughput =
DatabaseDescriptor.getStreamThroughputOutboundMegabitsPerSec() *
BYTES_PER_MEGABIT;
-mayUpdateThroughput(throughput, limiter);
-
-double interDCThroughput =
[cassandra] 01/01: Merge branch 'cassandra-3.0' into cassandra-3.11
This is an automated email from the ASF dual-hosted git repository.
adelapena pushed a commit to branch cassandra-3.11
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit c6e897d2d43bd8c2dff9553cee466231247b9840
Merge: 9bf14a6 4f8afe8
Author: Andrés de la Peña
AuthorDate: Fri Oct 1 11:52:07 2021 +0100
Merge branch 'cassandra-3.0' into cassandra-3.11
CHANGES.txt| 1 +
.../apache/cassandra/service/StorageService.java | 8 +-
.../apache/cassandra/streaming/StreamManager.java | 58 +-
.../tools/nodetool/SetInterDCStreamThroughput.java | 3 +-
.../tools/nodetool/SetStreamThroughput.java| 3 +-
.../cassandra/streaming/StreamManagerTest.java | 91 ++
6 files changed, 142 insertions(+), 22 deletions(-)
diff --cc CHANGES.txt
index 84c5bcf,53858ac..37ec9c1
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,15 -1,5 +1,16 @@@
-3.0.26:
+3.11.12
+ * Add key validation to ssstablescrub (CASSANDRA-16969)
+ * Update Jackson from 2.9.10 to 2.12.5 (CASSANDRA-16851)
+ * Include SASI components to snapshots (CASSANDRA-15134)
+ * Make assassinate more resilient to missing tokens (CASSANDRA-16847)
+ * Exclude Jackson 1.x transitive dependency of hadoop* provided dependencies
(CASSANDRA-16854)
+ * Validate SASI tokenizer options before adding index to schema
(CASSANDRA-15135)
+ * Fixup scrub output when no data post-scrub and clear up old use of row,
which really means partition (CASSANDRA-16835)
+ * Fix ant-junit dependency issue (CASSANDRA-16827)
+ * Reduce thread contention in CommitLogSegment and HintsBuffer
(CASSANDRA-16072)
+ * Avoid sending CDC column if not enabled (CASSANDRA-16770)
+Merged from 3.0:
+ * Immediately apply stream throughput, considering negative values as
unthrottled (CASSANDRA-16959)
* Do not release new SSTables in offline transactions (CASSANDRA-16975)
* ArrayIndexOutOfBoundsException in FunctionResource#fromName
(CASSANDRA-16977, CASSANDRA-16995)
* CVE-2015-0886 Security vulnerability in jbcrypt is addressed
(CASSANDRA-9384)
diff --cc src/java/org/apache/cassandra/service/StorageService.java
index 9cfdd80,78d1120..1a0d5b0
--- a/src/java/org/apache/cassandra/service/StorageService.java
+++ b/src/java/org/apache/cassandra/service/StorageService.java
@@@ -1390,98 -1257,12 +1390,100 @@@ public class StorageService extends Not
}
}
+public void setRpcTimeout(long value)
+{
+DatabaseDescriptor.setRpcTimeout(value);
+logger.info("set rpc timeout to {} ms", value);
+}
+
+public long getRpcTimeout()
+{
+return DatabaseDescriptor.getRpcTimeout();
+}
+
+public void setReadRpcTimeout(long value)
+{
+DatabaseDescriptor.setReadRpcTimeout(value);
+logger.info("set read rpc timeout to {} ms", value);
+}
+
+public long getReadRpcTimeout()
+{
+return DatabaseDescriptor.getReadRpcTimeout();
+}
+
+public void setRangeRpcTimeout(long value)
+{
+DatabaseDescriptor.setRangeRpcTimeout(value);
+logger.info("set range rpc timeout to {} ms", value);
+}
+
+public long getRangeRpcTimeout()
+{
+return DatabaseDescriptor.getRangeRpcTimeout();
+}
+
+public void setWriteRpcTimeout(long value)
+{
+DatabaseDescriptor.setWriteRpcTimeout(value);
+logger.info("set write rpc timeout to {} ms", value);
+}
+
+public long getWriteRpcTimeout()
+{
+return DatabaseDescriptor.getWriteRpcTimeout();
+}
+
+public void setCounterWriteRpcTimeout(long value)
+{
+DatabaseDescriptor.setCounterWriteRpcTimeout(value);
+logger.info("set counter write rpc timeout to {} ms", value);
+}
+
+public long getCounterWriteRpcTimeout()
+{
+return DatabaseDescriptor.getCounterWriteRpcTimeout();
+}
+
+public void setCasContentionTimeout(long value)
+{
+DatabaseDescriptor.setCasContentionTimeout(value);
+logger.info("set cas contention rpc timeout to {} ms", value);
+}
+
+public long getCasContentionTimeout()
+{
+return DatabaseDescriptor.getCasContentionTimeout();
+}
+
+public void setTruncateRpcTimeout(long value)
+{
+DatabaseDescriptor.setTruncateRpcTimeout(value);
+logger.info("set truncate rpc timeout to {} ms", value);
+}
+
+public long getTruncateRpcTimeout()
+{
+return DatabaseDescriptor.getTruncateRpcTimeout();
+}
+
+public void setStreamingSocketTimeout(int value)
+{
+DatabaseDescriptor.setStreamingSocketTimeout(value);
+logger.info("set streaming socket timeout to {} ms", value);
+}
+
+public int getStreamingSocketTimeout()
+{
+return DatabaseDescriptor.getStreamingSocketTimeout();
+}
+
public void setStreamThroughputMbPerSec(int
[jira] [Commented] (CASSANDRA-11181) Add broadcast_rpc_address to system.local
[ https://issues.apache.org/jira/browse/CASSANDRA-11181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423226#comment-17423226 ] Stefan Miklosovic commented on CASSANDRA-11181: --- We will go with the original patch leaving other bits behind for now. I will create a separate ticket for ssl_storage_port if somebody really needs it. The patch already makes the current state better which is enough for me to move it finally forward after all these years. > Add broadcast_rpc_address to system.local > - > > Key: CASSANDRA-11181 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11181 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Distributed Metadata >Reporter: Nick Bailey >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > Right now it's impossible to get the broadcast_rpc_address of the node you > are connected to via the drivers. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16666) Make SSLContext creation pluggable/extensible
[ https://issues.apache.org/jira/browse/CASSANDRA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-1: -- Fix Version/s: (was: 4.x) 4.1 > Make SSLContext creation pluggable/extensible > - > > Key: CASSANDRA-1 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1 > Project: Cassandra > Issue Type: Improvement > Components: Messaging/Internode >Reporter: Maulin Vasavada >Assignee: Maulin Vasavada >Priority: Normal > Fix For: 4.1 > > Attachments: Screenshot from 2021-09-28 10-56-24.png > > > Currently Cassandra creates the SSLContext via SSLFactory.java. SSLFactory is > a final class with static methods and not overridable. The SSLFactory loads > the keys and certs from the file based artifacts for the same. While this > works for many, in the industry where security is stricter and contextual, > this approach falls short. Many big organizations need flexibility to load > the SSL artifacts from a custom resource (like custom Key Management > Solution, HashiCorp Vault, Amazon KMS etc). While JSSE SecurityProvider > architecture allows us flexibility to build our custom mechanisms to validate > and process security artifacts, many times all we need is to build upon > Java's existing extensibility that Trust/Key Manager interfaces provide to > load keystores from various resources in the absence of any customized > requirements on the Keys/Certificate formats. > My proposal here is to make the SSLContext creation pluggable/extensible and > have the current SSLFactory.java implement an extensible interface. > I contributed a similar change that is live now in Apache Kafka (2.6.0) - > https://issues.apache.org/jira/browse/KAFKA-8890 > I can spare some time writing the pluggable interface and run by the required > reviewers. > > Created [CEP-9: Make SSLContext creation > pluggable|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-9%3A+Make+SSLContext+creation+pluggable] > > > cc: [~dcapwell] [~djoshi] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16666) Make SSLContext creation pluggable/extensible
[ https://issues.apache.org/jira/browse/CASSANDRA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-1: -- Status: Review In Progress (was: Patch Available) > Make SSLContext creation pluggable/extensible > - > > Key: CASSANDRA-1 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1 > Project: Cassandra > Issue Type: Improvement > Components: Messaging/Internode >Reporter: Maulin Vasavada >Assignee: Maulin Vasavada >Priority: Normal > Fix For: 4.x > > Attachments: Screenshot from 2021-09-28 10-56-24.png > > > Currently Cassandra creates the SSLContext via SSLFactory.java. SSLFactory is > a final class with static methods and not overridable. The SSLFactory loads > the keys and certs from the file based artifacts for the same. While this > works for many, in the industry where security is stricter and contextual, > this approach falls short. Many big organizations need flexibility to load > the SSL artifacts from a custom resource (like custom Key Management > Solution, HashiCorp Vault, Amazon KMS etc). While JSSE SecurityProvider > architecture allows us flexibility to build our custom mechanisms to validate > and process security artifacts, many times all we need is to build upon > Java's existing extensibility that Trust/Key Manager interfaces provide to > load keystores from various resources in the absence of any customized > requirements on the Keys/Certificate formats. > My proposal here is to make the SSLContext creation pluggable/extensible and > have the current SSLFactory.java implement an extensible interface. > I contributed a similar change that is live now in Apache Kafka (2.6.0) - > https://issues.apache.org/jira/browse/KAFKA-8890 > I can spare some time writing the pluggable interface and run by the required > reviewers. > > Created [CEP-9: Make SSLContext creation > pluggable|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-9%3A+Make+SSLContext+creation+pluggable] > > > cc: [~dcapwell] [~djoshi] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16666) Make SSLContext creation pluggable/extensible
[ https://issues.apache.org/jira/browse/CASSANDRA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-1: -- Test and Documentation Plan: https://github.com/apache/cassandra/pull/1243 (was: [PR#1027|https://github.com/apache/cassandra/pull/1027/]) Status: Patch Available (was: In Progress) > Make SSLContext creation pluggable/extensible > - > > Key: CASSANDRA-1 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1 > Project: Cassandra > Issue Type: Improvement > Components: Messaging/Internode >Reporter: Maulin Vasavada >Assignee: Maulin Vasavada >Priority: Normal > Fix For: 4.x > > Attachments: Screenshot from 2021-09-28 10-56-24.png > > > Currently Cassandra creates the SSLContext via SSLFactory.java. SSLFactory is > a final class with static methods and not overridable. The SSLFactory loads > the keys and certs from the file based artifacts for the same. While this > works for many, in the industry where security is stricter and contextual, > this approach falls short. Many big organizations need flexibility to load > the SSL artifacts from a custom resource (like custom Key Management > Solution, HashiCorp Vault, Amazon KMS etc). While JSSE SecurityProvider > architecture allows us flexibility to build our custom mechanisms to validate > and process security artifacts, many times all we need is to build upon > Java's existing extensibility that Trust/Key Manager interfaces provide to > load keystores from various resources in the absence of any customized > requirements on the Keys/Certificate formats. > My proposal here is to make the SSLContext creation pluggable/extensible and > have the current SSLFactory.java implement an extensible interface. > I contributed a similar change that is live now in Apache Kafka (2.6.0) - > https://issues.apache.org/jira/browse/KAFKA-8890 > I can spare some time writing the pluggable interface and run by the required > reviewers. > > Created [CEP-9: Make SSLContext creation > pluggable|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-9%3A+Make+SSLContext+creation+pluggable] > > > cc: [~dcapwell] [~djoshi] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16666) Make SSLContext creation pluggable/extensible
[ https://issues.apache.org/jira/browse/CASSANDRA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-1: -- Status: Ready to Commit (was: Review In Progress) > Make SSLContext creation pluggable/extensible > - > > Key: CASSANDRA-1 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1 > Project: Cassandra > Issue Type: Improvement > Components: Messaging/Internode >Reporter: Maulin Vasavada >Assignee: Maulin Vasavada >Priority: Normal > Fix For: 4.x > > Attachments: Screenshot from 2021-09-28 10-56-24.png > > > Currently Cassandra creates the SSLContext via SSLFactory.java. SSLFactory is > a final class with static methods and not overridable. The SSLFactory loads > the keys and certs from the file based artifacts for the same. While this > works for many, in the industry where security is stricter and contextual, > this approach falls short. Many big organizations need flexibility to load > the SSL artifacts from a custom resource (like custom Key Management > Solution, HashiCorp Vault, Amazon KMS etc). While JSSE SecurityProvider > architecture allows us flexibility to build our custom mechanisms to validate > and process security artifacts, many times all we need is to build upon > Java's existing extensibility that Trust/Key Manager interfaces provide to > load keystores from various resources in the absence of any customized > requirements on the Keys/Certificate formats. > My proposal here is to make the SSLContext creation pluggable/extensible and > have the current SSLFactory.java implement an extensible interface. > I contributed a similar change that is live now in Apache Kafka (2.6.0) - > https://issues.apache.org/jira/browse/KAFKA-8890 > I can spare some time writing the pluggable interface and run by the required > reviewers. > > Created [CEP-9: Make SSLContext creation > pluggable|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-9%3A+Make+SSLContext+creation+pluggable] > > > cc: [~dcapwell] [~djoshi] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16959) nodetool setstreamthroughput accepts invalid arguments that are not immediately applied
[
https://issues.apache.org/jira/browse/CASSANDRA-16959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-16959:
--
Status: Ready to Commit (was: Review In Progress)
> nodetool setstreamthroughput accepts invalid arguments that are not
> immediately applied
> ---
>
> Key: CASSANDRA-16959
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16959
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Both {{nodetool setstreamthroughput}} and {{nodetool
> setinterdcstreamthroughput}} accept a negative throughput. The throughput
> value is not immediately applied to the corresponding rate limiters. Instead,
> the value is [set in the
> {{Config}}|https://github.com/apache/cassandra/blob/09c89e5f5f8604301c233130dfb6e82a36ae30f3/src/java/org/apache/cassandra/service/StorageService.java#L1488]
> and it's only applied to the singleton rate limiter when new sstable stream
> writer are created (see
> [here|https://github.com/apache/cassandra/blob/09c89e5f5f8604301c233130dfb6e82a36ae30f3/src/java/org/apache/cassandra/streaming/StreamManager.java#L66-L76]).
> This could happen much later than the definition of the new throughput, and
> by then the setting of the new rate in the rate limiter will fail with an
> {{IllegalArgumentException}} due to the negative value.
> I think we should either immediately reject negative throughputs or consider
> them unlimited, as we do with zero. Also we should probably apply the new
> throughput to the rate limiter immediately, since I don't see why we should
> wait to start using the new throughput.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17019) JNA 5.6.0 does not support arm64
[ https://issues.apache.org/jira/browse/CASSANDRA-17019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igamr Palsenberg updated CASSANDRA-17019: - Description: Cassandra depends on net.java.dev.jna.jna version 5.6.0 to do the native binding into the C library. JNA 5.6.0 does not support arm64 architecture (Apple M1 devices), causing cassandra to fail on bootstrap. Bumping the dependency to 5.9.0 adds arm64 support. Will a PR to bump the dependency be acceptable ? was: Cassandra depends on net.java.dev.jna.jna version 5.6.0 to do the native binding into the C library. JNA 5.6.0 does not support arm64 architecture (Apple M1 devices), causing Apache to fail on bootstrap. Bumping the dependency to 5.9.0 adds arm64 support. Will a PR to bump the dependency be acceptable ? > JNA 5.6.0 does not support arm64 > > > Key: CASSANDRA-17019 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17019 > Project: Cassandra > Issue Type: Bug >Reporter: Igamr Palsenberg >Priority: Normal > > Cassandra depends on net.java.dev.jna.jna version 5.6.0 to do the native > binding into the C library. > JNA 5.6.0 does not support arm64 architecture (Apple M1 devices), causing > cassandra to fail on bootstrap. > Bumping the dependency to 5.9.0 adds arm64 support. Will a PR to bump the > dependency be acceptable ? -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-17019) JNA 5.6.0 does not support arm64
Igamr Palsenberg created CASSANDRA-17019: Summary: JNA 5.6.0 does not support arm64 Key: CASSANDRA-17019 URL: https://issues.apache.org/jira/browse/CASSANDRA-17019 Project: Cassandra Issue Type: Bug Reporter: Igamr Palsenberg Cassandra depends on net.java.dev.jna.jna version 5.6.0 to do the native binding into the C library. JNA 5.6.0 does not support arm64 architecture (Apple M1 devices), causing Apache to fail on bootstrap. Bumping the dependency to 5.9.0 adds arm64 support. Will a PR to bump the dependency be acceptable ? -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17017) Add required -f / --force option to nodetool verify
[
https://issues.apache.org/jira/browse/CASSANDRA-17017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423147#comment-17423147
]
Berenguer Blasi commented on CASSANDRA-17017:
-
Would we want to add docs changes for the new option and a {{ToolRunner}} test
like
[this|https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/tools/StandaloneVerifierTest.java#L35]
one to protect such changes?
> Add required -f / --force option to nodetool verify
> ---
>
> Key: CASSANDRA-17017
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17017
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/nodetool
>Reporter: Josh McKenzie
>Assignee: Josh McKenzie
>Priority: Normal
>
> nodetool verify has some pretty significant problems with it (see
> CASSANDRA-9947).
> Until such time as we do the heavy(er) lift to fix the command, we should
> make it harder for people to shoot themselves in the foot with it. Adding a
> required "-f" flag to it with a requisite "Do you really know what you're
> doing? Check out this JIRA first" seems like it'd be the right thing to do in
> the interim.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17009) Sstableverify unit test operate on SSTables
[
https://issues.apache.org/jira/browse/CASSANDRA-17009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423135#comment-17423135
]
Berenguer Blasi commented on CASSANDRA-17009:
-
> I accidentally turned off the spell checker in the ide as it turns out...
> blerg I'll fix them, sorry about that.
No need to apologize! I do these sort of things all the time unfortunately lol!
> The fix for this is small, but I was trying to keep the change small,
> incremental and focused on the unit test. No sweat though, I can fix it
> (basically just force an early exit).
And you're absolutely right. But from experience I can tell you each ticket is
sandwiched between CI and contributor review cycle time. That tends to be not
negligible so if it's a few loc of a related fix that'd be my suggestion to
keep things moving. But feel free to do whatever you think is best ofc!
> The issue with the git ignore of test/data sounds weird to me it didn't came
> up sooner. I have to give it another thought.
Ok I'll buy that.
> On the {{Verifier}} and coverage discussion
Icwym and I think you are right. Still I would suggest:
- Adding to all verify test classes a javadoc detailing all the files involved:
VerifyTest, StandaloneVerifierOnSSTablesTest, etc This way a reader will learn
immediately about coverage and what classes are involved instead of wondering
around and finding it out himself. Wdyt?
- Yes replicating those tests would be redundant and we already have existing
tests on the cmd line options making sure the tool doesn't explode but
- The -c test we need to add to {{StandaloneVerifierTest}} bc we have no test
proving this option doesn't explode the tool or that the tool is ignoring it
i.e. Same as with the token option which in this case is another ticket. But
-c, being minimal effort, I'd suggest doing in this ticket.
Wdyt makes sense? I'll move the state of the ticket to help me track things if
you don't mind.
> Sstableverify unit test operate on SSTables
> ---
>
> Key: CASSANDRA-17009
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17009
> Project: Cassandra
> Issue Type: Sub-task
> Components: Tool/sstable
>Reporter: Brian Houser
>Assignee: Brian Houser
>Priority: Normal
> Time Spent: 2h
> Remaining Estimate: 0h
>
> as part of https://issues.apache.org/jira/browse/CASSANDRA-16009, unit
> coverage is a bit lax and doesn't run through the verifier (based on my
> coverage results).
> There should be a unit test that exercises the internal verifier both for a
> corrupt example and a working example.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17009) Sstableverify unit test operate on SSTables
[ https://issues.apache.org/jira/browse/CASSANDRA-17009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-17009: Status: Changes Suggested (was: Review In Progress) > Sstableverify unit test operate on SSTables > --- > > Key: CASSANDRA-17009 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17009 > Project: Cassandra > Issue Type: Sub-task > Components: Tool/sstable >Reporter: Brian Houser >Assignee: Brian Houser >Priority: Normal > Time Spent: 2h > Remaining Estimate: 0h > > as part of https://issues.apache.org/jira/browse/CASSANDRA-16009, unit > coverage is a bit lax and doesn't run through the verifier (based on my > coverage results). > There should be a unit test that exercises the internal verifier both for a > corrupt example and a working example. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14612) Please add OWASP Dependency Check to the build (pom.xml)
[ https://issues.apache.org/jira/browse/CASSANDRA-14612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423126#comment-17423126 ] Stefan Miklosovic commented on CASSANDRA-14612: --- Successful OWASP check against trunk is visible here - timestamp aroud 08:39:59 - https://ci-cassandra.apache.org/job/Cassandra-devbranch-artifacts/1085/jdk=jdk_1.8_latest,label=cassandra/console I consider this ticket to be fully resolved. > Please add OWASP Dependency Check to the build (pom.xml) > > > Key: CASSANDRA-14612 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14612 > Project: Cassandra > Issue Type: New Feature > Components: Build > Environment: All development, build, test, environments. >Reporter: Albert Baker >Assignee: Stefan Miklosovic >Priority: Normal > Labels: build, security > Fix For: 3.0.26, 3.11.12, 4.0.2, 4.1 > > Original Estimate: 1h > Remaining Estimate: 1h > > Please add OWASP Dependency Check to the build (pom.xml). OWASP DC makes an > outbound REST call to MITRE Common Vulnerabilities & Exposures (CVE) to > perform a lookup for each dependant .jar to list any/all known > vulnerabilities for each jar. This step is needed because a manual MITRE CVE > lookup/check on the main component does not include checking for > vulnerabilities in components or in dependant libraries. > OWASP Dependency check : > https://www.owasp.org/index.php/OWASP_Dependency_Check has plug-ins for most > Java build/make types (ant, maven, ivy, gradle). > Also, add the appropriate command to the nightly build to generate a report > of all known vulnerabilities in any/all third party libraries/dependencies > that get pulled in. example : mvn -Powasp -Dtest=false -DfailIfNoTests=false > clean aggregate > Generating this report nightly/weekly will help inform the project's > development team if any dependant libraries have a reported known > vulnerailities. Project teams that keep up with removing vulnerabilities on a > weekly basis will help protect businesses that rely on these open source > componets. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
