[jira] [Assigned] (CASSANDRA-17723) Add support for big endian architecture (s390x)
[ https://issues.apache.org/jira/browse/CASSANDRA-17723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi reassigned CASSANDRA-17723: --- Assignee: Shahid Shaikh > Add support for big endian architecture (s390x) > --- > > Key: CASSANDRA-17723 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17723 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Observability, Legacy/Testing >Reporter: Shahid Shaikh >Assignee: Shahid Shaikh >Priority: Normal > Fix For: 4.x > > Attachments: CASSANDRA-17723-4.0.patch > > > Noticed that some of the Cassandra tests are failing on big endian > architectures (s390x). Please find the attached code patch which corrects the > data handling for big endian architecture. It also corrects the byte ordering > when dealing with sun.misc.Unsafe methods. After the patch following tests > are passing for s390x which were failing earlier: > TTLTest > ScrubTest > LegacySSTableTest > SSTableExportSchemaLoadingTest > SSTableMetadataViewerTest > StandaloneUpgraderOnSStablesTest > StandaloneVerifierOnSSTablesTest > The code change ensures that Cassandra for little endian architectures remain > unaffected. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16562) Fix flaky testSkipScrubCorruptedCounterRowWithTool
[
https://issues.apache.org/jira/browse/CASSANDRA-16562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-16562:
Resolution: Duplicate
Status: Resolved (was: Open)
> Fix flaky testSkipScrubCorruptedCounterRowWithTool
> --
>
> Key: CASSANDRA-16562
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16562
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> See CASSANDRA-16532 where extra flakiness was detected on 3.0 and 3.11
> branches for {{testSkipScrubCorruptedCounterRowWithTool}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17314) Test Failure: org.apache.cassandra.db.ScrubTest.testScrubCorruptedCounterRow
[
https://issues.apache.org/jira/browse/CASSANDRA-17314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-17314:
Reviewers: Andres de la Peña, Berenguer Blasi (was: Andres de la Peña)
> Test Failure: org.apache.cassandra.db.ScrubTest.testScrubCorruptedCounterRow
>
>
> Key: CASSANDRA-17314
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17314
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Josh McKenzie
>Assignee: Runtian Liu
>Priority: Normal
> Fix For: 3.0.28
>
>
> Failed 10 times in the last 14 runs. Flakiness: 61%, Stability: 28%
> Error Message
> Timeout occurred. Please note the time in the report does not reflect the
> time until the timeout.
> {code}
> Stacktrace
> junit.framework.AssertionFailedError: Timeout occurred. Please note the time
> in the report does not reflect the time until the timeout.
> at java.util.Vector.forEach(Vector.java:1277)
> at java.util.Vector.forEach(Vector.java:1277)
> at java.util.Vector.forEach(Vector.java:1277)
> at jdk.nashorn.internal.scripts.Script$3$\^eval\_.:program(:13)
> at
> jdk.nashorn.internal.runtime.ScriptFunctionData.invoke(ScriptFunctionData.java:637)
> at
> jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:494)
> at
> jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:393)
> at
> jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:449)
> at
> jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:406)
> at
> jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:402)
> at
> jdk.nashorn.api.scripting.NashornScriptEngine.eval(NashornScriptEngine.java:155)
> at javax.script.AbstractScriptEngine.eval(AbstractScriptEngine.java:264)
> at java.util.Vector.forEach(Vector.java:1277)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16562) Fix flaky testSkipScrubCorruptedCounterRowWithTool
[
https://issues.apache.org/jira/browse/CASSANDRA-16562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17577766#comment-17577766
]
Berenguer Blasi commented on CASSANDRA-16562:
-
+1
> Fix flaky testSkipScrubCorruptedCounterRowWithTool
> --
>
> Key: CASSANDRA-16562
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16562
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> See CASSANDRA-16532 where extra flakiness was detected on 3.0 and 3.11
> branches for {{testSkipScrubCorruptedCounterRowWithTool}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17806) Flaky test_rolling_upgrade
[
https://issues.apache.org/jira/browse/CASSANDRA-17806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-17806:
Fix Version/s: 3.0.28
3.11.14
4.0.6
(was: 3.0.x)
(was: 4.0)
Since Version: 4.1-beta
Source Control Link:
https://github.com/apache/cassandra-dtest/commit/24b58342eca597b375a424d08b64f6d001bc220a
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> Flaky test_rolling_upgrade
> --
>
> Key: CASSANDRA-17806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17806
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 3.0.28, 3.11.14, 4.0.6, 4.1-beta, 4.2
>
>
> The fix on CASSANDRA-17140 needs to be extended into other places as it seems
> it now fails only one in a billion but still we can fix that one.
> {noformat}
> Regression
> dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_3_11_X_HEAD.test_rolling_upgrade
> (from Cassandra dtests)
> Failing for the past 1 build (Since
> #115 )
> Took 10 min.
> Failed 1 times in the last 9 runs. Flakiness: 12%, Stability: 88%
> Error Message
> RuntimeError: A subprocess has terminated early. Subprocess statuses:
> Process-1 (is_alive: True), Process-2 (is_alive: False), attempting to
> terminate remaining subprocesses now.
> Stacktrace
> self =
> object at 0x7f4d313e4e50>
> @pytest.mark.timeout(3000)
> def test_rolling_upgrade(self):
> """
> Test rolling upgrade of the cluster, so we have mixed versions
> part way through.
> """
> > self.upgrade_scenario(rolling=True)
> upgrade_tests/upgrade_through_versions_test.py:340:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> upgrade_tests/upgrade_through_versions_test.py:417: in upgrade_scenario
> self._check_on_subprocs(self.fixture_dtest_setup.subprocs)
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> self =
> object at 0x7f4d313e4e50>
> subprocs = [ exitcode=-SIGKILL daemon>, stopped exitcode=1 daemon>]
> def _check_on_subprocs(self, subprocs):
> """
> Check on given subprocesses.
>
> If any are not alive, we'll go ahead and terminate any remaining
> alive subprocesses since this test is going to fail.
> """
> subproc_statuses = [s.is_alive() for s in subprocs]
> if not all(subproc_statuses):
> message = "A subprocess has terminated early. Subprocess
> statuses: "
> for s in subprocs:
> message += "{name} (is_alive: {aliveness}),
> ".format(name=s.name, aliveness=s.is_alive())
> message += "attempting to terminate remaining subprocesses now."
> self._terminate_subprocs()
> > raise RuntimeError(message)
> E RuntimeError: A subprocess has terminated early. Subprocess
> statuses: Process-1 (is_alive: True), Process-2 (is_alive: False), attempting
> to terminate remaining subprocesses now.
> upgrade_tests/upgrade_through_versions_test.py:475: RuntimeError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-dtest] branch trunk updated: Flaky test_rolling_upgrade
This is an automated email from the ASF dual-hosted git repository.
bereng pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-dtest.git
The following commit(s) were added to refs/heads/trunk by this push:
new 24b58342 Flaky test_rolling_upgrade
24b58342 is described below
commit 24b58342eca597b375a424d08b64f6d001bc220a
Author: Bereng
AuthorDate: Tue Aug 9 08:44:23 2022 +0200
Flaky test_rolling_upgrade
patch by Berenguer Blasi; reviewed by Benjamin Lerer for CASSANDRA-17806
---
upgrade_tests/upgrade_through_versions_test.py | 16
1 file changed, 16 insertions(+)
diff --git a/upgrade_tests/upgrade_through_versions_test.py
b/upgrade_tests/upgrade_through_versions_test.py
index 746772aa..47f54281 100644
--- a/upgrade_tests/upgrade_through_versions_test.py
+++ b/upgrade_tests/upgrade_through_versions_test.py
@@ -210,6 +210,14 @@ def counter_incrementer(tester, to_verify_queue,
verification_done_queue, rewrit
session.execute(prepared, (key))
to_verify_queue.put_nowait((key, count + 1,))
+except DriverException as dex:
+if "ID mismatch while trying to reprepare" in str(dex):
+time.sleep(1) # Pstmnt id mismatch, retry. See
CASSANDRA-15252/17140
+continue
+else:
+logger.error("Error in counter incrementer process!", dex)
+shutdown_gently()
+raise
except Exception as ex:
logger.error("Error in counter incrementer process!", ex)
shutdown_gently()
@@ -258,6 +266,14 @@ def counter_checker(tester, to_verify_queue,
verification_done_queue):
except Empty:
time.sleep(0.1) # let's not eat CPU if the queue is empty
continue
+except DriverException as dex:
+if "ID mismatch while trying to reprepare" in str(dex):
+time.sleep(1) # Pstmnt id mismatch, retry. See
CASSANDRA-15252/17140
+continue
+else:
+logger.error("Error in counter verifier process!", dex)
+shutdown_gently()
+raise
except Exception as ex:
logger.error("Error in counter verifier process!", ex)
shutdown_gently()
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16940) Confusing ProtocolException msg Invalid or unsupported protocol version (4)
[
https://issues.apache.org/jira/browse/CASSANDRA-16940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brad Schoening updated CASSANDRA-16940:
---
Resolution: Cannot Reproduce
Status: Resolved (was: Open)
> Confusing ProtocolException msg Invalid or unsupported protocol version (4)
> ---
>
> Key: CASSANDRA-16940
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16940
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Client
>Reporter: Brad Schoening
>Priority: Normal
>
> The following warning was seen frequently after upgrading from 3.0.15 to
> 3.11.11 in the cassandra.log:
> {noformat}
> ProtocolException: Invalid or unsupported protocol version (4); supported
> versions are (3/v3, 4/v4, 5/v5-beta){noformat}
> It is at best unclear, or maybe a bug in the code throwing this exception
> stating version '4' not supported but 4/v4 is.
> from org/apache/cassandra/transport/ProtocolVersion.java
> public static String invalidVersionMessage(int version)
> { return String.format("Invalid or unsupported protocol version (%d);
> supported versions are (%s)", version, String.join(", ",
> ProtocolVersion.supportedVersions())); }
> We later found invalid IP addresses in the system.peers table and once
> removed, this exception went away.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-17684) Add MacOS path /usr/local/share/doc/cassandra path for cqlsh docs
[
https://issues.apache.org/jira/browse/CASSANDRA-17684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brad Schoening reassigned CASSANDRA-17684:
--
Assignee: (was: Brad Schoening)
> Add MacOS path /usr/local/share/doc/cassandra path for cqlsh docs
> -
>
> Key: CASSANDRA-17684
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17684
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: Brad Schoening
>Priority: Normal
> Fix For: 4.x
>
>
> On MacOS, /usr/share is not writable – even by root. Instead,
> /usr/local/share is the preferred location.
> The current share directory path is /usr/share/doc/cassandra/CQL.html. This
> would just add an alternative path.
> Using a list comprehension would simplify the current code. E.g.,
> {quote}import pathlib
> HTML_FALLBACK = 'https://cassandra.apache.org/doc/latest/cql/index.html'
> loc = ( Path('./doc/cql3/CQL.html'),
> Path('/usr/share/doc/cassandra/CQL.html'),
> Path('{color:#4c9aff}/usr/local/share{color}/doc/cassandra/CQL.html' ))
> item = next((x.as_uri() for x in loc if os.path.exists( x )), HTML_FALLBACK)
> {quote}
> Homebrew doesn't seem to install the doc files, so that would likely need to
> be added also in
> [https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/cassandra.rb]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17684) Add MacOS path /usr/local/share/doc/cassandra path for cqlsh docs
[
https://issues.apache.org/jira/browse/CASSANDRA-17684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brad Schoening updated CASSANDRA-17684:
---
Change Category: Operability
Complexity: Low Hanging Fruit
Component/s: CQL/Interpreter
Fix Version/s: 4.x
Status: Open (was: Triage Needed)
> Add MacOS path /usr/local/share/doc/cassandra path for cqlsh docs
> -
>
> Key: CASSANDRA-17684
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17684
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: Brad Schoening
>Assignee: Brad Schoening
>Priority: Normal
> Fix For: 4.x
>
>
> On MacOS, /usr/share is not writable – even by root. Instead,
> /usr/local/share is the preferred location.
> The current share directory path is /usr/share/doc/cassandra/CQL.html. This
> would just add an alternative path.
> Using a list comprehension would simplify the current code. E.g.,
> {quote}import pathlib
> HTML_FALLBACK = 'https://cassandra.apache.org/doc/latest/cql/index.html'
> loc = ( Path('./doc/cql3/CQL.html'),
> Path('/usr/share/doc/cassandra/CQL.html'),
> Path('{color:#4c9aff}/usr/local/share{color}/doc/cassandra/CQL.html' ))
> item = next((x.as_uri() for x in loc if os.path.exists( x )), HTML_FALLBACK)
> {quote}
> Homebrew doesn't seem to install the doc files, so that would likely need to
> be added also in
> [https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/cassandra.rb]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17684) Add MacOS path /usr/local/share/doc/cassandra path for cqlsh docs
[
https://issues.apache.org/jira/browse/CASSANDRA-17684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brad Schoening updated CASSANDRA-17684:
---
Description:
On MacOS, /usr/share is not writable – even by root. Instead, /usr/local/share
is the preferred location.
The current share directory path is /usr/share/doc/cassandra/CQL.html. This
would just add an alternative path.
Using a list comprehension would simplify the current code. E.g.,
{quote}import pathlib
HTML_FALLBACK = 'https://cassandra.apache.org/doc/latest/cql/index.html'
loc = ( Path('./doc/cql3/CQL.html'), Path('/usr/share/doc/cassandra/CQL.html'),
Path('{color:#4c9aff}/usr/local/share{color}/doc/cassandra/CQL.html' ))
item = next((x.as_uri() for x in loc if os.path.exists( x )), HTML_FALLBACK)
{quote}
Homebrew doesn't seem to install the doc files, so that would likely need to be
added also in
[https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/cassandra.rb]
was:
On MacOS, /usr/share is not writable – even by root. Instead, /usr/local/share
is the preferred location.
The current share directory path is /usr/share/doc/cassandra/CQL.html. This
would just add an alternative path.
Using a list comprehension would simplify the current code. E.g.,
{quote}import pathlib
HTML_FALLBACK = 'https://cassandra.apache.org/doc/latest/cql/index.html'
loc = ( Path('./doc/cql3/CQL.html'), Path('/usr/share/doc/cassandra/CQL.html'),
Path('{color:#4c9aff}/usr/local/share{color}/doc/cassandra/CQL.html' ))
item = next((x.as_uri() for x in loc if os.path.exists( x )), HTML_FALLBACK)
{quote}
> Add MacOS path /usr/local/share/doc/cassandra path for cqlsh docs
> -
>
> Key: CASSANDRA-17684
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17684
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Brad Schoening
>Assignee: Brad Schoening
>Priority: Normal
>
> On MacOS, /usr/share is not writable – even by root. Instead,
> /usr/local/share is the preferred location.
> The current share directory path is /usr/share/doc/cassandra/CQL.html. This
> would just add an alternative path.
> Using a list comprehension would simplify the current code. E.g.,
> {quote}import pathlib
> HTML_FALLBACK = 'https://cassandra.apache.org/doc/latest/cql/index.html'
> loc = ( Path('./doc/cql3/CQL.html'),
> Path('/usr/share/doc/cassandra/CQL.html'),
> Path('{color:#4c9aff}/usr/local/share{color}/doc/cassandra/CQL.html' ))
> item = next((x.as_uri() for x in loc if os.path.exists( x )), HTML_FALLBACK)
> {quote}
> Homebrew doesn't seem to install the doc files, so that would likely need to
> be added also in
> [https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/cassandra.rb]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17782) `DatabaseDescriptor#clientInitialization` should set the `newFailureDetector` (maybe to a NoOpFailureDetector?)
[
https://issues.apache.org/jira/browse/CASSANDRA-17782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caleb Rackliffe updated CASSANDRA-17782:
Reviewers: Caleb Rackliffe, Caleb Rackliffe
Caleb Rackliffe, Caleb Rackliffe (was: Caleb Rackliffe)
Status: Review In Progress (was: Patch Available)
> `DatabaseDescriptor#clientInitialization` should set the `newFailureDetector`
> (maybe to a NoOpFailureDetector?)
> ---
>
> Key: CASSANDRA-17782
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17782
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Startup and Shutdown
>Reporter: Doug Rohrer
>Assignee: Doug Rohrer
>Priority: Normal
> Fix For: 4.1.x
>
> Attachments: CASSANDRA-17782.patch
>
>
> With the introduction of a configurable FailureDetector, client users of the
> {{cassandra-all}} jar now need to call not just `clientInitialization` but
> also `setDefaultFailureDetector` in order to avoid an NPE when the failure
> detector is constructed. This is a breaking change from previous versions
> where this was not necessary.
> Calls to {{DatabaseDescriptor#clientInitialization}} should set
> {{newFailureDetector}} to +something+, either by calling
> {{setDefaultFailureDetector}} or creating a different (NoOp?) FailureDetector.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17782) `DatabaseDescriptor#clientInitialization` should set the `newFailureDetector` (maybe to a NoOpFailureDetector?)
[
https://issues.apache.org/jira/browse/CASSANDRA-17782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17577667#comment-17577667
]
Caleb Rackliffe commented on CASSANDRA-17782:
-
+1
Agree the side effects of instantiating {{FailureDetector}} look harmless if
the Gossiper or someone else refers to the singleton.
> `DatabaseDescriptor#clientInitialization` should set the `newFailureDetector`
> (maybe to a NoOpFailureDetector?)
> ---
>
> Key: CASSANDRA-17782
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17782
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Startup and Shutdown
>Reporter: Doug Rohrer
>Assignee: Doug Rohrer
>Priority: Normal
> Fix For: 4.1.x
>
> Attachments: CASSANDRA-17782.patch
>
>
> With the introduction of a configurable FailureDetector, client users of the
> {{cassandra-all}} jar now need to call not just `clientInitialization` but
> also `setDefaultFailureDetector` in order to avoid an NPE when the failure
> detector is constructed. This is a breaking change from previous versions
> where this was not necessary.
> Calls to {{DatabaseDescriptor#clientInitialization}} should set
> {{newFailureDetector}} to +something+, either by calling
> {{setDefaultFailureDetector}} or creating a different (NoOp?) FailureDetector.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (562fc950 -> 57486412)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 562fc950 generate docs for 31a3d0b7 new 57486412 generate docs for 31a3d0b7 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (562fc950) \ N -- N -- N refs/heads/asf-staging (57486412) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4740078 -> 4740078 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16471) org.apache.cassandra.io.util.DataOutputBuffer#scratchBuffer is around 50% of all memory allocations
[ https://issues.apache.org/jira/browse/CASSANDRA-16471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17577610#comment-17577610 ] Caleb Rackliffe commented on CASSANDRA-16471: - +1 > org.apache.cassandra.io.util.DataOutputBuffer#scratchBuffer is around 50% of > all memory allocations > --- > > Key: CASSANDRA-16471 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16471 > Project: Cassandra > Issue Type: Improvement > Components: Local/Caching >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.x > > Attachments: Screen Shot 2021-02-25 at 3.34.28 PM.png, Screen Shot > 2021-02-25 at 4.14.19 PM.png > > Time Spent: 1.5h > Remaining Estimate: 0h > > While running workflows to compare 3.0 with trunk we found that allocations > and GC are significantly higher for a write mostly workload (22% read, 3% > delete, 75% write); below is what we saw for a 2h run > Allocations > 30: 1.64TB > 40: 2.99TB > GC Events > 30: 7.39k events > 40: 13.93k events > When looking at the allocation output we saw the follow for memory allocations > !https://issues.apache.org/jira/secure/attachment/13021238/Screen%20Shot%202021-02-25%20at%203.34.28%20PM.png! > Here we see that org.apache.cassandra.io.util.DataOutputBuffer#expandToFit is > around 52% of the memory allocations. When looking at this logic I see that > allocations are on-heap and constantly throw away the buffer (as a means to > allow GC to clean up). > With the patch, allocations/gc are the following > Allocations > 30: 1.64TB > 40 w/ patch: 1.77TB > 40: 2.99TB > GC Events > 30: 7.39k events > 40 w/ patch: 8k events > 40: 13.93k events > With the patch only 0.8% allocations > !https://issues.apache.org/jira/secure/attachment/13021239/Screen%20Shot%202021-02-25%20at%204.14.19%20PM.png! -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17655) Prevent JVM Humongous allocations
[ https://issues.apache.org/jira/browse/CASSANDRA-17655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17577603#comment-17577603 ] Brad Schoening commented on CASSANDRA-17655: Agreed, we need a heap dump or other sample of the problem to determine what type of objects are being allocated in the humongous region. If is something like the partition summary table, maybe there is an opportunity to move it off heap or tweak the data structure so it doesn't require a humongous allocation. > Prevent JVM Humongous allocations > - > > Key: CASSANDRA-17655 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17655 > Project: Cassandra > Issue Type: Bug >Reporter: Brad Schoening >Priority: Normal > > Several articles on Cassandra note that certain workloads, especially large > partitions, can cause humongous allocations in Java, which can be reduced, > but not always eliminated by increasing RegionSize. RegionSize max is 32MB. > Humongous allocations are an undesirable performance issue because new > objects get directly allocated in old space. > Below is a sample message seen in the gc.log > 2022-05-23T18:46:58.743+0800: 3758624.170: [GC pause (G1 Humongous > Allocation) (young) (initial-mark) 3758624.171: [G1Ergonomics (CSet > Construction) start choosing CSet, _pending_cards: 56725, predicted base > time: 39.83 ms, remaining time: 160.17 ms, target pause time: 200.00 ms] > Instead of Cassandra users tuning RegionSize manually, a better solution > would be for Cassandra to limit the size of allocations, or consider moving > humongous allocations off heap. > > References > [https://docs.oracle.com/en/java/javase/11/gctuning/garbage-first-g1-garbage-collector1.html#GUID-D74F3CC7-CC9F-45B5-B03D-510AEEAC2DAC] > [https://stevenlacerda.medium.com/identifying-and-fixing-humongous-allocations-in-cassandra-bf46444cec41] > https://krzysztofslusarski.github.io/2020/11/10/humongous.html -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17694) Remove additional legacy python code fragments
[ https://issues.apache.org/jira/browse/CASSANDRA-17694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-17694: - Fix Version/s: 4.2 (was: 4.x) Source Control Link: https://github.com/apache/cassandra/commit/9a4a67782311e4a6ffe3aad0516c33016f187c54 Resolution: Fixed Status: Resolved (was: Ready to Commit) A missed blank line was [failing|https://app.circleci.com/pipelines/github/driftx/cassandra/570/workflows/a578fc55-db91-4ecd-a1a0-dd4833dcc0de] but I added it and everything [looks good|https://app.circleci.com/pipelines/github/driftx/cassandra/571/workflows/34b98383-3f92-4be0-93aa-cb4692af3cee], so committed. Thanks! > Remove additional legacy python code fragments > -- > > Key: CASSANDRA-17694 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17694 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Bernardo Botella Corbi >Priority: Normal > Fix For: 4.2 > > Time Spent: 10m > Remaining Estimate: 0h > > The code in formatting.py has this comment: > > |# We can get rid of this in cassandra-2.2| > || > > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: Removed Python < 2.7 support from formatting.py
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/trunk by this push:
new 9a4a677823 Removed Python < 2.7 support from formatting.py
9a4a677823 is described below
commit 9a4a67782311e4a6ffe3aad0516c33016f187c54
Author: Bernardo Botella Corbi
AuthorDate: Mon Aug 1 10:57:04 2022 -0700
Removed Python < 2.7 support from formatting.py
Patch by Bernardo Botella Corbi, reviewed by Brad Schoening, ycai and
brandonwilliams for CASSANDRA-17694
---
CHANGES.txt | 1 +
pylib/cqlshlib/formatting.py | 16 +++-
2 files changed, 4 insertions(+), 13 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index d1957a4667..e25c228828 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
4.2
+ * Removed Python < 2.7 support from formatting.py (CASSANDRA-17694)
* Cleanup pylint issues with pylexotron.py (CASSANDRA-17779)
* NPE bug in streaming checking if SSTable is being repaired (CASSANDRA-17801)
* Users of NativeLibrary should handle lack of JNA appropriately when running
in client mode (CASSANDRA-17794)
diff --git a/pylib/cqlshlib/formatting.py b/pylib/cqlshlib/formatting.py
index b49a29aebd..39bc060485 100644
--- a/pylib/cqlshlib/formatting.py
+++ b/pylib/cqlshlib/formatting.py
@@ -326,19 +326,9 @@ def format_integer_type(val, colormap, thousands_sep=None,
**_):
return colorme(bval, colormap, 'int')
-# We can get rid of this in cassandra-2.2
-if sys.version_info >= (2, 7):
-def format_integer_with_thousands_sep(val, thousands_sep=','):
-return "{:,.0f}".format(val).replace(',', thousands_sep)
-else:
-def format_integer_with_thousands_sep(val, thousands_sep=','):
-if val < 0:
-return '-' + format_integer_with_thousands_sep(-val, thousands_sep)
-result = ''
-while val >= 1000:
-val, r = divmod(val, 1000)
-result = "%s%03d%s" % (thousands_sep, r, result)
-return "%d%s" % (val, result)
+def format_integer_with_thousands_sep(val, thousands_sep=','):
+return "{:,.0f}".format(val).replace(',', thousands_sep)
+
formatter_for('long')(format_integer_type)
formatter_for('int')(format_integer_type)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17694) Remove additional legacy python code fragments
[ https://issues.apache.org/jira/browse/CASSANDRA-17694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-17694: - Status: Ready to Commit (was: Review In Progress) > Remove additional legacy python code fragments > -- > > Key: CASSANDRA-17694 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17694 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Bernardo Botella Corbi >Priority: Normal > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > The code in formatting.py has this comment: > > |# We can get rid of this in cassandra-2.2| > || > > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17804) AutoSnapshotTtlTest#testAutoSnapshotTTlOnDropAfterRestart fails sporadically on missing stdout contents
[
https://issues.apache.org/jira/browse/CASSANDRA-17804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17577541#comment-17577541
]
Paulo Motta commented on CASSANDRA-17804:
-
Thanks for checking [~maedhroz], I'll take a look.
> AutoSnapshotTtlTest#testAutoSnapshotTTlOnDropAfterRestart fails sporadically
> on missing stdout contents
> ---
>
> Key: CASSANDRA-17804
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17804
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Snapshots
>Reporter: Caleb Rackliffe
>Assignee: Paulo Motta
>Priority: Normal
> Fix For: 4.1-beta, 4.x
>
>
> See
> [https://app.circleci.com/pipelines/github/maedhroz/cassandra/487/workflows/0ad42210-2979-4c5d-a4e8-d8cedf9285a7/jobs/4686/tests#failed-test-0]
>
> My guess is that in some resource constrained environment, even the first
> {{nodeool listsnapshots}} invocation doesn’t have “dropped” in the stdout. In
> other words, we skip to the state of the world the last assertion in the test
> is checking.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17694) Remove additional legacy python code fragments
[ https://issues.apache.org/jira/browse/CASSANDRA-17694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-17694: - Reviewers: Brad Schoening, Brandon Williams, Yifan Cai (was: Brad Schoening, Yifan Cai) Status: Review In Progress (was: Needs Committer) > Remove additional legacy python code fragments > -- > > Key: CASSANDRA-17694 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17694 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Bernardo Botella Corbi >Priority: Normal > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > The code in formatting.py has this comment: > > |# We can get rid of this in cassandra-2.2| > || > > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17694) Remove additional legacy python code fragments
[ https://issues.apache.org/jira/browse/CASSANDRA-17694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bernardo Botella Corbi updated CASSANDRA-17694: --- Status: Needs Committer (was: Review In Progress) > Remove additional legacy python code fragments > -- > > Key: CASSANDRA-17694 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17694 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Bernardo Botella Corbi >Priority: Normal > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > The code in formatting.py has this comment: > > |# We can get rid of this in cassandra-2.2| > || > > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-17709) CQL.textile needs to be made current
[ https://issues.apache.org/jira/browse/CASSANDRA-17709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Lerer reassigned CASSANDRA-17709: -- Assignee: Benjamin Lerer > CQL.textile needs to be made current > > > Key: CASSANDRA-17709 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17709 > Project: Cassandra > Issue Type: Bug > Components: Legacy/CQL >Reporter: Brandon Williams >Assignee: Benjamin Lerer >Priority: Normal > Fix For: 4.0.x, 4.1-beta > > > Per CASSANDRA-17570 > https://github.com/apache/cassandra/blob/trunk/doc/cql3/CQL.textile is > outdated, and the document we ship inside packages, so this should be made > current. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (72c2270a80 -> afa7dfb5a4)
This is an automated email from the ASF dual-hosted git repository. bdeggleston pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from 72c2270a80 Resolve pylint issues in pylexotron.py and improve readability add 2bc4a36179 Use seeded crc for PaxosBallotTracker checksum new afa7dfb5a4 Merge branch 'cassandra-4.1' into trunk The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.1 updated (bd08798c13 -> 2bc4a36179)
This is an automated email from the ASF dual-hosted git repository. bdeggleston pushed a change to branch cassandra-4.1 in repository https://gitbox.apache.org/repos/asf/cassandra.git from bd08798c13 Add tests for MILLIS_CUSTOM_DURATION and MILLIS_DURATION_DOUBLE patch by Ekaterina Dimitrova; reviewed by Andres de la Pena for CASSANDRA-17737 add 2bc4a36179 Use seeded crc for PaxosBallotTracker checksum No new revisions were added by this update. Summary of changes: src/java/org/apache/cassandra/net/Crc.java | 2 +- .../cassandra/service/paxos/uncommitted/PaxosBallotTracker.java | 9 - 2 files changed, 5 insertions(+), 6 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.1' into trunk
This is an automated email from the ASF dual-hosted git repository. bdeggleston pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit afa7dfb5a48ecb56abc2d8bbb1de0fc8f1ca77b9 Merge: 72c2270a80 2bc4a36179 Author: Blake Eggleston AuthorDate: Tue Aug 9 08:59:38 2022 -0700 Merge branch 'cassandra-4.1' into trunk - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17779) Resolve pylint issues in pylexotron.py and improve readability
[ https://issues.apache.org/jira/browse/CASSANDRA-17779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-17779: - Fix Version/s: 4.2 (was: 4.x) Source Control Link: https://github.com/apache/cassandra/commit/72c2270a80f2acc8ece3eade4d6a2f8e8cb12356 Resolution: Fixed Status: Resolved (was: Ready to Commit) Committed, thanks. > Resolve pylint issues in pylexotron.py and improve readability > -- > > Key: CASSANDRA-17779 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17779 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.2 > > > Add comments to clarify behavior > Convert short form constants to long form (e.g., re.I == re.IGNORECASE) > Camel case class names > > > [Original pylint] code has been rated at 6.71/10 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17779) Resolve pylint issues in pylexotron.py and improve readability
[ https://issues.apache.org/jira/browse/CASSANDRA-17779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-17779: - Status: Ready to Commit (was: Review In Progress) > Resolve pylint issues in pylexotron.py and improve readability > -- > > Key: CASSANDRA-17779 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17779 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.x > > > Add comments to clarify behavior > Convert short form constants to long form (e.g., re.I == re.IGNORECASE) > Camel case class names > > > [Original pylint] code has been rated at 6.71/10 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17779) Resolve pylint issues in pylexotron.py and improve readability
[ https://issues.apache.org/jira/browse/CASSANDRA-17779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-17779: - Status: Review In Progress (was: Patch Available) > Resolve pylint issues in pylexotron.py and improve readability > -- > > Key: CASSANDRA-17779 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17779 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.x > > > Add comments to clarify behavior > Convert short form constants to long form (e.g., re.I == re.IGNORECASE) > Camel case class names > > > [Original pylint] code has been rated at 6.71/10 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: Resolve pylint issues in pylexotron.py and improve readability
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/trunk by this push: new 72c2270a80 Resolve pylint issues in pylexotron.py and improve readability 72c2270a80 is described below commit 72c2270a80f2acc8ece3eade4d6a2f8e8cb12356 Author: Brad Schoening <5796692+bschoen...@users.noreply.github.com> AuthorDate: Wed Jul 27 22:57:52 2022 -0400 Resolve pylint issues in pylexotron.py and improve readability Patch by Brad Schoening; reviewed by brandonwilliams and smiklosovic for CASSANDRA-17779 --- CHANGES.txt | 1 + pylib/cqlshlib/pylexotron.py | 148 +++ 2 files changed, 82 insertions(+), 67 deletions(-) diff --git a/CHANGES.txt b/CHANGES.txt index e33cd45a78..d1957a4667 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,4 +1,5 @@ 4.2 + * Cleanup pylint issues with pylexotron.py (CASSANDRA-17779) * NPE bug in streaming checking if SSTable is being repaired (CASSANDRA-17801) * Users of NativeLibrary should handle lack of JNA appropriately when running in client mode (CASSANDRA-17794) * Warn on unknown directories found in system keyspace directory rather than kill node during startup checks (CASSANDRA-1) diff --git a/pylib/cqlshlib/pylexotron.py b/pylib/cqlshlib/pylexotron.py index 69f31dced7..c1fd55edbf 100644 --- a/pylib/cqlshlib/pylexotron.py +++ b/pylib/cqlshlib/pylexotron.py @@ -14,7 +14,12 @@ # See the License for the specific language governing permissions and # limitations under the License. +"""Pylexotron uses Python's re.Scanner module as a simple regex-based tokenizer for BNF production rules""" + import re +import inspect +import sys +from typing import Union from cqlshlib.saferscanner import SaferScanner @@ -56,8 +61,8 @@ class Hint: return '%s(%r)' % (self.__class__, self.text) -def is_hint(x): -return isinstance(x, Hint) +def is_hint(obj): +return isinstance(obj, Hint) class ParseContext: @@ -115,7 +120,7 @@ class ParseContext: % (self.__class__.__name__, self.matched, self.remainder, self.productionname, self.bindings) -class matcher: +class Matcher: def __init__(self, arg): self.arg = arg @@ -155,38 +160,38 @@ class matcher: return '%s(%r)' % (self.__class__.__name__, self.arg) -class choice(matcher): +class Choice(Matcher): def match(self, ctxt, completions): foundctxts = [] -for a in self.arg: -subctxts = a.match(ctxt, completions) +for each in self.arg: +subctxts = each.match(ctxt, completions) foundctxts.extend(subctxts) return foundctxts -class one_or_none(matcher): +class OneOrNone(Matcher): def match(self, ctxt, completions): return [ctxt] + list(self.arg.match(ctxt, completions)) -class repeat(matcher): +class Repeat(Matcher): def match(self, ctxt, completions): found = [ctxt] ctxts = [ctxt] while True: new_ctxts = [] -for c in ctxts: -new_ctxts.extend(self.arg.match(c, completions)) +for each in ctxts: +new_ctxts.extend(self.arg.match(each, completions)) if not new_ctxts: return found found.extend(new_ctxts) ctxts = new_ctxts -class rule_reference(matcher): +class RuleReference(Matcher): def match(self, ctxt, completions): prevname = ctxt.productionname @@ -198,24 +203,24 @@ class rule_reference(matcher): return [c.with_production_named(prevname) for c in output] -class rule_series(matcher): +class RuleSeries(Matcher): def match(self, ctxt, completions): ctxts = [ctxt] for patpiece in self.arg: new_ctxts = [] -for c in ctxts: -new_ctxts.extend(patpiece.match(c, completions)) +for each in ctxts: +new_ctxts.extend(patpiece.match(each, completions)) if not new_ctxts: return () ctxts = new_ctxts return ctxts -class named_symbol(matcher): +class NamedSymbol(Matcher): def __init__(self, name, arg): -matcher.__init__(self, arg) +Matcher.__init__(self, arg) self.name = name def match(self, ctxt, completions): @@ -224,13 +229,14 @@ class named_symbol(matcher): # don't collect other completions under this; use a dummy pass_in_compls = set() results = self.arg.match_with_results(ctxt, pass_in_compls) -return [c.with_binding(self.name, ctxt.extract_orig(matchtoks)) for (c, matchtoks) in results] +return [c.with_binding(self.name, ctxt.extract_orig(matchtoks)) +for (c, matchtoks) in results] def
[jira] [Commented] (CASSANDRA-17613) Avoid getting hanging repairs due to repair message timeouts
[ https://issues.apache.org/jira/browse/CASSANDRA-17613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17577428#comment-17577428 ] Marcus Eriksson commented on CASSANDRA-17613: - 4.1: https://github.com/apache/cassandra/pull/1775 / https://app.circleci.com/pipelines/github/krummas/cassandra/809/workflows/f99a3c25-0d16-4bd4-89db-d1c835ce7b6c trunk: https://github.com/apache/cassandra/pull/1776 / https://app.circleci.com/pipelines/github/krummas/cassandra/807/workflows/72a6a1ef-2052-480e-a396-0cccfdf17efa > Avoid getting hanging repairs due to repair message timeouts > > > Key: CASSANDRA-17613 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17613 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Marcus Eriksson >Assignee: Marcus Eriksson >Priority: Normal > Fix For: 4.0.x, 4.1-beta > > Time Spent: 20m > Remaining Estimate: 0h > > In 4.0 repair messages can get expired before reaching a replica, this causes > repairs to hang. > CASSANDRA-16909 is meant to fix this, but we need a stopgap fix in 4.0. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17575) forceCompactionForTokenRange when using a wrapped range may include sstables not within that range
[ https://issues.apache.org/jira/browse/CASSANDRA-17575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17577418#comment-17577418 ] Andres de la Peña commented on CASSANDRA-17575: --- Thanks for the review, I have addressed the suggestions, rebased and run CI: ||PR||CI|| |[3.11 |https://github.com/apache/cassandra/pull/1742]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1978/workflows/daea157d-071d-46e4-be96-a5035cb5e2a4]| |[4.0 |https://github.com/apache/cassandra/pull/1743]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1977/workflows/af17c3e8-d48e-4da4-bc89-7ef60bcec53b] [j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1977/workflows/fb5a4071-d713-41fc-946d-50e6507d67be]| |[4.1 |https://github.com/apache/cassandra/pull/1744]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1976/workflows/73720f5c-2a47-44ed-8b16-97a281d6ebcf] [j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1976/workflows/d26aa01f-5d98-4e38-991c-313c052546ec]| |[trunk|https://github.com/apache/cassandra/pull/1745]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1975/workflows/7d8af703-ef47-4fa9-abd0-c750644d6041] [j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1975/workflows/46086c73-53c5-4d2c-9a5b-6e2a5a23b0bb]| > forceCompactionForTokenRange when using a wrapped range may include sstables > not within that range > -- > > Key: CASSANDRA-17575 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17575 > Project: Cassandra > Issue Type: Bug > Components: Local/Compaction >Reporter: David Capwell >Assignee: Andres de la Peña >Priority: Normal > Fix For: 3.11.x, 4.0.x, 4.1.x > > Time Spent: 0.5h > Remaining Estimate: 0h > > This was found in CASSANDRA-17537 > When you compact the range (32, 31] this should include everything BUT 32, > but in the test > org.apache.cassandra.db.compaction.LeveledCompactionStrategyTest#testTokenRangeCompaction > it found that SSTables with the bounds (32, 32) were getting included in the > set of SSTables to compact -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17765) RPM Installation on centos 7 is broken by CASSANDRA-17669
[ https://issues.apache.org/jira/browse/CASSANDRA-17765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17577397#comment-17577397 ] APatel commented on CASSANDRA-17765: Thanks Brandon, Raised on ML > RPM Installation on centos 7 is broken by CASSANDRA-17669 > - > > Key: CASSANDRA-17765 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17765 > Project: Cassandra > Issue Type: Bug > Components: Packaging >Reporter: Jeremiah Jordan >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.0.x, 4.1-rc, 4.x > > > With CASSANDRA-17669 adding use of "or" in the dependencies for the RPM so it > can depend on java 8 or java 11 it broke installation on CentOS Linux 7. > This is bad because CentOS Linux 7 is the "current" release of CentOS Linux, > version 8 was EOL'ed in favor of the new pre-release distribution model being > used for CentOS Stream 8. > I don't know what the best answer is here, maybe making a CentOS 7 specific > package that reverts back to just java 8 in the requirements? But I think > should needs to be done. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-15767) /usr/bin/cassandra looking for wrong libjemalloc.so file
[
https://issues.apache.org/jira/browse/CASSANDRA-15767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17577391#comment-17577391
]
Stefan Miklosovic edited comment on CASSANDRA-15767 at 8/9/22 12:35 PM:
I was debugging this jemalloc loading little bit more and there is also an
issue with directory parsing where to look for that library. I updated my
branch to reflect that.
Directories to load that library from is base on this (1). That seems to be
wrong on the first sight as ldconfig is present in Ubuntu, for example as well.
I do not think we should decide what operating system (or its fork) we are on
based on whether there is ldconfig command present as it is (or it might be)
basically everywhere.
Hence, even I am on Ubuntu, because I have ldconfig present, it will act as if
I am on "Centos" and it will not include some paths. For example, if it was
detected correctly, it would add these paths to search in (this is from Ubuntu
Jelly).
{code:java}
$ cat /etc/ld.so.conf /etc/ld.so.conf.d/*.conf | grep '^/'
/usr/local/lib
/usr/local/lib/x86_64-linux-gnu
/lib/x86_64-linux-gnu
/usr/lib/x86_64-linux-gnu <-- my libjemalloc is here
{code}
So, it will not add the directory my lib is in so it will not find it.
I derived Debian-based distribution from the fact if there is / is not
/etc/lsb-release file.
Then there is a different problem with symlinks. Some distributions will create
a symlink from libjemalloc.so to a library file, like, libjemalloc.so.1 (or
.2). However, not all distributions have symlinks. For example Ubuntu Jelly has
just a proper file (libjemalloc.so.2) however Mint distribution has a symlink
to these files.
For that reason I changed the regexp to
{noformat}
.*/libjemalloc\.so.*
{noformat}
which will take into account symlinks as well as all other files. Then I sort
them in reverse order if there are two libs of different number but there is no
symlink, I filter duplicates via uniq and I take the first entry via head.
(1) [https://github.com/apache/cassandra/blob/trunk/bin/cassandra#L140-L147]
EDIT: we should make distribution parsing more robust, it seems to me that
/etc/lsb-release is not enough as it can be present on rpm-based distro too.
https://stackoverflow.com/questions/47838800/etc-lsb-release-vs-etc-os-release
was (Author: smiklosovic):
I was debugging this jemalloc loading little bit more and there is also an
issue with directory parsing where to look for that library. I updated my
branch to reflect that.
Directories to load that library from is base on this (1). That seems to be
wrong on the first sight as ldconfig is present in Ubuntu, for example as well.
I do not think we should decide what operating system (or its fork) we are on
based on whether there is ldconfig command present as it is (or it might be)
basically everywhere.
Hence, even I am on Ubuntu, because I have ldconfig present, it will act as if
I am on "Centos" and it will not include some paths. For example, if it was
detected correctly, it would add these paths to search in (this is from Ubuntu
Jelly).
{code:java}
$ cat /etc/ld.so.conf /etc/ld.so.conf.d/*.conf | grep '^/'
/usr/local/lib
/usr/local/lib/x86_64-linux-gnu
/lib/x86_64-linux-gnu
/usr/lib/x86_64-linux-gnu <-- my libjemalloc is here
{code}
So, it will not add the directory my lib is in so it will not find it.
I derived Debian-based distribution from the fact if there is / is not
/etc/lsb-release file.
Then there is a different problem with symlinks. Some distributions will create
a symlink from libjemalloc.so to a library file, like, libjemalloc.so.1 (or
.2). However, not all distributions have symlinks. For example Ubuntu Jelly has
just a proper file (libjemalloc.so.2) however Mint distribution has a symlink
to these files.
For that reason I changed the regexp to
{noformat}
.*/libjemalloc\.so.*
{noformat}
which will take into account symlinks as well as all other files. Then I sort
them in reverse order if there are two libs of different number but there is no
symlink, I filter duplicates via uniq and I take the first entry via head.
(1) [https://github.com/apache/cassandra/blob/trunk/bin/cassandra#L140-L147]
> /usr/bin/cassandra looking for wrong libjemalloc.so file
>
>
> Key: CASSANDRA-15767
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15767
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Scripts
>Reporter: Brian Bellrose
>Priority: Normal
> Labels: centos8, debian, jemalloc
>
> In /usr/sbin/cassandra
> Linux)
> if [ -z $CASSANDRA_LIBJEMALLOC ] ; then
> which ldconfig > /dev/null 2>&1
> if [ $? = 0 ] ; then
> # e.g. for CentOS
> dirs="/lib64 /lib /usr/lib64 /usr/lib `ldconfig -v 2>/dev/null | grep -v
> '^\s'
[jira] [Comment Edited] (CASSANDRA-15767) /usr/bin/cassandra looking for wrong libjemalloc.so file
[
https://issues.apache.org/jira/browse/CASSANDRA-15767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17577391#comment-17577391
]
Stefan Miklosovic edited comment on CASSANDRA-15767 at 8/9/22 12:32 PM:
I was debugging this jemalloc loading little bit more and there is also an
issue with directory parsing where to look for that library. I updated my
branch to reflect that.
Directories to load that library from is base on this (1). That seems to be
wrong on the first sight as ldconfig is present in Ubuntu, for example as well.
I do not think we should decide what operating system (or its fork) we are on
based on whether there is ldconfig command present as it is (or it might be)
basically everywhere.
Hence, even I am on Ubuntu, because I have ldconfig present, it will act as if
I am on "Centos" and it will not include some paths. For example, if it was
detected correctly, it would add these paths to search in (this is from Ubuntu
Jelly).
{code:java}
$ cat /etc/ld.so.conf /etc/ld.so.conf.d/*.conf | grep '^/'
/usr/local/lib
/usr/local/lib/x86_64-linux-gnu
/lib/x86_64-linux-gnu
/usr/lib/x86_64-linux-gnu <-- my libjemalloc is here
{code}
So, it will not add the directory my lib is in so it will not find it.
I derived Debian-based distribution from the fact if there is / is not
/etc/lsb-release file.
Then there is a different problem with symlinks. Some distributions will create
a symlink from libjemalloc.so to a library file, like, libjemalloc.so.1 (or
.2). However, not all distributions have symlinks. For example Ubuntu Jelly has
just a proper file (libjemalloc.so.2) however Mint distribution has a symlink
to these files.
For that reason I changed the regexp to
{noformat}
.*/libjemalloc\.so.*
{noformat}
which will take into account symlinks as well as all other files. Then I sort
them in reverse order if there are two libs of different number but there is no
symlink, I filter duplicates via uniq and I take the first entry via head.
(1) [https://github.com/apache/cassandra/blob/trunk/bin/cassandra#L140-L147]
was (Author: smiklosovic):
I was debugging this jemalloc loading little bit more and there is also an
issue with directory parsing where to look for that library. I updated my
branch to reflect that.
Directories to load that library from is base on this (1). That seems to be
wrong on the first sight as ldconfig is present in Ubuntu, for example as well.
I do not think we should decide what operating system (or its fork) we are on
based on whether there is ldconfig command present as it is (or it might be)
basically everywhere.
Hence, even I am on Ubuntu, because I have ldconfig present, it will act as if
I am on "Centos" and it will not include some paths. For example, if it was
detected correctly, it would add these paths to search in (this is from Ubuntu
Jelly).
{code}
$ cat /etc/ld.so.conf /etc/ld.so.conf.d/*.conf | grep '^/'
/usr/local/lib
/usr/local/lib/x86_64-linux-gnu
/lib/x86_64-linux-gnu
/usr/lib/x86_64-linux-gnu <-- my libjemalloc is here
{code}
So, it will not add the directory my lib is in so it will not find it.
Then there is a different problem with symlinks. Some distributions will create
a symlink from libjemalloc.so to a library file, like, libjemalloc.so.1 (or
.2). However, not all distributions have symlinks. For example Ubuntu Jelly has
just a proper file (libjemalloc.so.2) however Mint distribution has a symlink
to these files.
For that reason I changed the regexp to
{noformat}
.*/libjemalloc\.so.*
{noformat}
which will take into account symlinks as well as all other files. Then I sort
them in reverse order if there are two libs of different number but there is
no symlink, I filter duplicates via uniq and I take the first entry via head.
(1) https://github.com/apache/cassandra/blob/trunk/bin/cassandra#L140-L147
> /usr/bin/cassandra looking for wrong libjemalloc.so file
>
>
> Key: CASSANDRA-15767
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15767
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Scripts
>Reporter: Brian Bellrose
>Priority: Normal
> Labels: centos8, debian, jemalloc
>
> In /usr/sbin/cassandra
> Linux)
> if [ -z $CASSANDRA_LIBJEMALLOC ] ; then
> which ldconfig > /dev/null 2>&1
> if [ $? = 0 ] ; then
> # e.g. for CentOS
> dirs="/lib64 /lib /usr/lib64 /usr/lib `ldconfig -v 2>/dev/null | grep -v
> '^\s' | sed 's/^\([^:]*\):.*$/\1/'`"
> else
> # e.g. for Debian, OpenSUSE
> dirs="/lib64 /lib /usr/lib64 /usr/lib `cat /etc/ld.so.conf
> /etc/ld.so.conf.d/*.conf | grep '^/'`"
> fi
> dirs=`echo $dirs | tr " " ":"`
> CASSANDRA_LIBJEMALLOC=$(find_library '.*/libjemalloc\.so\(\.1\)*' $dirs)
>
> However...
> # find /usr/lib64 -name
[jira] [Commented] (CASSANDRA-15767) /usr/bin/cassandra looking for wrong libjemalloc.so file
[
https://issues.apache.org/jira/browse/CASSANDRA-15767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17577391#comment-17577391
]
Stefan Miklosovic commented on CASSANDRA-15767:
---
I was debugging this jemalloc loading little bit more and there is also an
issue with directory parsing where to look for that library. I updated my
branch to reflect that.
Directories to load that library from is base on this (1). That seems to be
wrong on the first sight as ldconfig is present in Ubuntu, for example as well.
I do not think we should decide what operating system (or its fork) we are on
based on whether there is ldconfig command present as it is (or it might be)
basically everywhere.
Hence, even I am on Ubuntu, because I have ldconfig present, it will act as if
I am on "Centos" and it will not include some paths. For example, if it was
detected correctly, it would add these paths to search in (this is from Ubuntu
Jelly).
{code}
$ cat /etc/ld.so.conf /etc/ld.so.conf.d/*.conf | grep '^/'
/usr/local/lib
/usr/local/lib/x86_64-linux-gnu
/lib/x86_64-linux-gnu
/usr/lib/x86_64-linux-gnu <-- my libjemalloc is here
{code}
So, it will not add the directory my lib is in so it will not find it.
Then there is a different problem with symlinks. Some distributions will create
a symlink from libjemalloc.so to a library file, like, libjemalloc.so.1 (or
.2). However, not all distributions have symlinks. For example Ubuntu Jelly has
just a proper file (libjemalloc.so.2) however Mint distribution has a symlink
to these files.
For that reason I changed the regexp to
{noformat}
.*/libjemalloc\.so.*
{noformat}
which will take into account symlinks as well as all other files. Then I sort
them in reverse order if there are two libs of different number but there is
no symlink, I filter duplicates via uniq and I take the first entry via head.
(1) https://github.com/apache/cassandra/blob/trunk/bin/cassandra#L140-L147
> /usr/bin/cassandra looking for wrong libjemalloc.so file
>
>
> Key: CASSANDRA-15767
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15767
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Scripts
>Reporter: Brian Bellrose
>Priority: Normal
> Labels: centos8, debian, jemalloc
>
> In /usr/sbin/cassandra
> Linux)
> if [ -z $CASSANDRA_LIBJEMALLOC ] ; then
> which ldconfig > /dev/null 2>&1
> if [ $? = 0 ] ; then
> # e.g. for CentOS
> dirs="/lib64 /lib /usr/lib64 /usr/lib `ldconfig -v 2>/dev/null | grep -v
> '^\s' | sed 's/^\([^:]*\):.*$/\1/'`"
> else
> # e.g. for Debian, OpenSUSE
> dirs="/lib64 /lib /usr/lib64 /usr/lib `cat /etc/ld.so.conf
> /etc/ld.so.conf.d/*.conf | grep '^/'`"
> fi
> dirs=`echo $dirs | tr " " ":"`
> CASSANDRA_LIBJEMALLOC=$(find_library '.*/libjemalloc\.so\(\.1\)*' $dirs)
>
> However...
> # find /usr/lib64 -name "*jemalloc*"
> /usr/lib64/libjemalloc.so.2
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17806) Flaky test_rolling_upgrade
[
https://issues.apache.org/jira/browse/CASSANDRA-17806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17577384#comment-17577384
]
Benjamin Lerer commented on CASSANDRA-17806:
The patch looks good to me.
> Flaky test_rolling_upgrade
> --
>
> Key: CASSANDRA-17806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17806
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 3.0.x, 4.0, 4.1-beta, 4.2
>
>
> The fix on CASSANDRA-17140 needs to be extended into other places as it seems
> it now fails only one in a billion but still we can fix that one.
> {noformat}
> Regression
> dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_3_11_X_HEAD.test_rolling_upgrade
> (from Cassandra dtests)
> Failing for the past 1 build (Since
> #115 )
> Took 10 min.
> Failed 1 times in the last 9 runs. Flakiness: 12%, Stability: 88%
> Error Message
> RuntimeError: A subprocess has terminated early. Subprocess statuses:
> Process-1 (is_alive: True), Process-2 (is_alive: False), attempting to
> terminate remaining subprocesses now.
> Stacktrace
> self =
> object at 0x7f4d313e4e50>
> @pytest.mark.timeout(3000)
> def test_rolling_upgrade(self):
> """
> Test rolling upgrade of the cluster, so we have mixed versions
> part way through.
> """
> > self.upgrade_scenario(rolling=True)
> upgrade_tests/upgrade_through_versions_test.py:340:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> upgrade_tests/upgrade_through_versions_test.py:417: in upgrade_scenario
> self._check_on_subprocs(self.fixture_dtest_setup.subprocs)
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> self =
> object at 0x7f4d313e4e50>
> subprocs = [ exitcode=-SIGKILL daemon>, stopped exitcode=1 daemon>]
> def _check_on_subprocs(self, subprocs):
> """
> Check on given subprocesses.
>
> If any are not alive, we'll go ahead and terminate any remaining
> alive subprocesses since this test is going to fail.
> """
> subproc_statuses = [s.is_alive() for s in subprocs]
> if not all(subproc_statuses):
> message = "A subprocess has terminated early. Subprocess
> statuses: "
> for s in subprocs:
> message += "{name} (is_alive: {aliveness}),
> ".format(name=s.name, aliveness=s.is_alive())
> message += "attempting to terminate remaining subprocesses now."
> self._terminate_subprocs()
> > raise RuntimeError(message)
> E RuntimeError: A subprocess has terminated early. Subprocess
> statuses: Process-1 (is_alive: True), Process-2 (is_alive: False), attempting
> to terminate remaining subprocesses now.
> upgrade_tests/upgrade_through_versions_test.py:475: RuntimeError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17806) Flaky test_rolling_upgrade
[
https://issues.apache.org/jira/browse/CASSANDRA-17806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Lerer updated CASSANDRA-17806:
---
Status: Ready to Commit (was: Review In Progress)
> Flaky test_rolling_upgrade
> --
>
> Key: CASSANDRA-17806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17806
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 3.0.x, 4.0, 4.1-beta, 4.2
>
>
> The fix on CASSANDRA-17140 needs to be extended into other places as it seems
> it now fails only one in a billion but still we can fix that one.
> {noformat}
> Regression
> dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_3_11_X_HEAD.test_rolling_upgrade
> (from Cassandra dtests)
> Failing for the past 1 build (Since
> #115 )
> Took 10 min.
> Failed 1 times in the last 9 runs. Flakiness: 12%, Stability: 88%
> Error Message
> RuntimeError: A subprocess has terminated early. Subprocess statuses:
> Process-1 (is_alive: True), Process-2 (is_alive: False), attempting to
> terminate remaining subprocesses now.
> Stacktrace
> self =
> object at 0x7f4d313e4e50>
> @pytest.mark.timeout(3000)
> def test_rolling_upgrade(self):
> """
> Test rolling upgrade of the cluster, so we have mixed versions
> part way through.
> """
> > self.upgrade_scenario(rolling=True)
> upgrade_tests/upgrade_through_versions_test.py:340:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> upgrade_tests/upgrade_through_versions_test.py:417: in upgrade_scenario
> self._check_on_subprocs(self.fixture_dtest_setup.subprocs)
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> self =
> object at 0x7f4d313e4e50>
> subprocs = [ exitcode=-SIGKILL daemon>, stopped exitcode=1 daemon>]
> def _check_on_subprocs(self, subprocs):
> """
> Check on given subprocesses.
>
> If any are not alive, we'll go ahead and terminate any remaining
> alive subprocesses since this test is going to fail.
> """
> subproc_statuses = [s.is_alive() for s in subprocs]
> if not all(subproc_statuses):
> message = "A subprocess has terminated early. Subprocess
> statuses: "
> for s in subprocs:
> message += "{name} (is_alive: {aliveness}),
> ".format(name=s.name, aliveness=s.is_alive())
> message += "attempting to terminate remaining subprocesses now."
> self._terminate_subprocs()
> > raise RuntimeError(message)
> E RuntimeError: A subprocess has terminated early. Subprocess
> statuses: Process-1 (is_alive: True), Process-2 (is_alive: False), attempting
> to terminate remaining subprocesses now.
> upgrade_tests/upgrade_through_versions_test.py:475: RuntimeError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17806) Flaky test_rolling_upgrade
[
https://issues.apache.org/jira/browse/CASSANDRA-17806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Lerer updated CASSANDRA-17806:
---
Reviewers: Benjamin Lerer, Benjamin Lerer
Benjamin Lerer, Benjamin Lerer (was: Benjamin Lerer)
Status: Review In Progress (was: Patch Available)
> Flaky test_rolling_upgrade
> --
>
> Key: CASSANDRA-17806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17806
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 3.0.x, 4.0, 4.1-beta, 4.2
>
>
> The fix on CASSANDRA-17140 needs to be extended into other places as it seems
> it now fails only one in a billion but still we can fix that one.
> {noformat}
> Regression
> dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_3_11_X_HEAD.test_rolling_upgrade
> (from Cassandra dtests)
> Failing for the past 1 build (Since
> #115 )
> Took 10 min.
> Failed 1 times in the last 9 runs. Flakiness: 12%, Stability: 88%
> Error Message
> RuntimeError: A subprocess has terminated early. Subprocess statuses:
> Process-1 (is_alive: True), Process-2 (is_alive: False), attempting to
> terminate remaining subprocesses now.
> Stacktrace
> self =
> object at 0x7f4d313e4e50>
> @pytest.mark.timeout(3000)
> def test_rolling_upgrade(self):
> """
> Test rolling upgrade of the cluster, so we have mixed versions
> part way through.
> """
> > self.upgrade_scenario(rolling=True)
> upgrade_tests/upgrade_through_versions_test.py:340:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> upgrade_tests/upgrade_through_versions_test.py:417: in upgrade_scenario
> self._check_on_subprocs(self.fixture_dtest_setup.subprocs)
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> self =
> object at 0x7f4d313e4e50>
> subprocs = [ exitcode=-SIGKILL daemon>, stopped exitcode=1 daemon>]
> def _check_on_subprocs(self, subprocs):
> """
> Check on given subprocesses.
>
> If any are not alive, we'll go ahead and terminate any remaining
> alive subprocesses since this test is going to fail.
> """
> subproc_statuses = [s.is_alive() for s in subprocs]
> if not all(subproc_statuses):
> message = "A subprocess has terminated early. Subprocess
> statuses: "
> for s in subprocs:
> message += "{name} (is_alive: {aliveness}),
> ".format(name=s.name, aliveness=s.is_alive())
> message += "attempting to terminate remaining subprocesses now."
> self._terminate_subprocs()
> > raise RuntimeError(message)
> E RuntimeError: A subprocess has terminated early. Subprocess
> statuses: Process-1 (is_alive: True), Process-2 (is_alive: False), attempting
> to terminate remaining subprocesses now.
> upgrade_tests/upgrade_through_versions_test.py:475: RuntimeError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17765) RPM Installation on centos 7 is broken by CASSANDRA-17669
[ https://issues.apache.org/jira/browse/CASSANDRA-17765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17577350#comment-17577350 ] Brandon Williams edited comment on CASSANDRA-17765 at 8/9/22 11:09 AM: --- You should take this question to the user ML since Jira is not a good support vehicle, and this is really a question about how to use your distro's package manager. That said, a search for "yum install specific version" will likely yield the results you seek. was (Author: brandon.williams): You should this question on the user ML since Jira is not a good support vehicle, and this is really a question about how to use your distro's package manager. That said, a search for "yum install specific version" will likely yield the results you seek. > RPM Installation on centos 7 is broken by CASSANDRA-17669 > - > > Key: CASSANDRA-17765 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17765 > Project: Cassandra > Issue Type: Bug > Components: Packaging >Reporter: Jeremiah Jordan >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.0.x, 4.1-rc, 4.x > > > With CASSANDRA-17669 adding use of "or" in the dependencies for the RPM so it > can depend on java 8 or java 11 it broke installation on CentOS Linux 7. > This is bad because CentOS Linux 7 is the "current" release of CentOS Linux, > version 8 was EOL'ed in favor of the new pre-release distribution model being > used for CentOS Stream 8. > I don't know what the best answer is here, maybe making a CentOS 7 specific > package that reverts back to just java 8 in the requirements? But I think > should needs to be done. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16562) Fix flaky testSkipScrubCorruptedCounterRowWithTool
[
https://issues.apache.org/jira/browse/CASSANDRA-16562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17577351#comment-17577351
]
Andres de la Peña commented on CASSANDRA-16562:
---
CASSANDRA-17314 was committed yesterday, I think we can close this as a
duplicate.
> Fix flaky testSkipScrubCorruptedCounterRowWithTool
> --
>
> Key: CASSANDRA-16562
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16562
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> See CASSANDRA-16532 where extra flakiness was detected on 3.0 and 3.11
> branches for {{testSkipScrubCorruptedCounterRowWithTool}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17765) RPM Installation on centos 7 is broken by CASSANDRA-17669
[ https://issues.apache.org/jira/browse/CASSANDRA-17765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17577350#comment-17577350 ] Brandon Williams commented on CASSANDRA-17765: -- You should this question on the user ML since Jira is not a good support vehicle, and this is really a question about how to use your distro's package manager. That said, a search for "yum install specific version" will likely yield the results you seek. > RPM Installation on centos 7 is broken by CASSANDRA-17669 > - > > Key: CASSANDRA-17765 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17765 > Project: Cassandra > Issue Type: Bug > Components: Packaging >Reporter: Jeremiah Jordan >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.0.x, 4.1-rc, 4.x > > > With CASSANDRA-17669 adding use of "or" in the dependencies for the RPM so it > can depend on java 8 or java 11 it broke installation on CentOS Linux 7. > This is bad because CentOS Linux 7 is the "current" release of CentOS Linux, > version 8 was EOL'ed in favor of the new pre-release distribution model being > used for CentOS Stream 8. > I don't know what the best answer is here, maybe making a CentOS 7 specific > package that reverts back to just java 8 in the requirements? But I think > should needs to be done. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17709) CQL.textile needs to be made current
[ https://issues.apache.org/jira/browse/CASSANDRA-17709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17577338#comment-17577338 ] Michael Semb Wever commented on CASSANDRA-17709: bq. I have vague recollections of some effort to be able to generate the docs in tree That would be CASSANDRA-17260 and CASSANDRA-17375, any updates there [~anthonygrasso]? > CQL.textile needs to be made current > > > Key: CASSANDRA-17709 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17709 > Project: Cassandra > Issue Type: Bug > Components: Legacy/CQL >Reporter: Brandon Williams >Priority: Normal > Fix For: 4.0.x, 4.1-beta > > > Per CASSANDRA-17570 > https://github.com/apache/cassandra/blob/trunk/doc/cql3/CQL.textile is > outdated, and the document we ship inside packages, so this should be made > current. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-17260) Antora site.yml in-tree so in-tree html can be generated (again)
[ https://issues.apache.org/jira/browse/CASSANDRA-17260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever reassigned CASSANDRA-17260: -- Assignee: Anthony Grasso > Antora site.yml in-tree so in-tree html can be generated (again) > > > Key: CASSANDRA-17260 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17260 > Project: Cassandra > Issue Type: Task > Components: Documentation >Reporter: Michael Semb Wever >Assignee: Anthony Grasso >Priority: Normal > > With the migration of the doc to asciidoc and antora we (intentionally) lost > the ability to generate in-tree html via `ant gen-doc`. > This was intentional as our first priority was publishing the docs to the > website. > But it is also beneficial to have plain html docs bundled into our packages > (tar, deb, rpm, docker, etc), so tackling this was expected and planned for a > later date. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17765) RPM Installation on centos 7 is broken by CASSANDRA-17669
[ https://issues.apache.org/jira/browse/CASSANDRA-17765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17577294#comment-17577294 ] APatel commented on CASSANDRA-17765: Is there any other repositories I can use for 4.0.x ? As currently 4.0.5 available on the repo which has issue? How can I install previous stable version of 4.0.x ? [Index of /cassandra/redhat/40x (apache.org)|https://downloads.apache.org/cassandra/redhat/40x/] (repo rpm packages) has only 4.0.5 which is broken and replace with the stable version? Also might need to update on installation documentation as well. Under Installing the RPM packages [Installing Cassandra | Apache Cassandra Documentation|https://cassandra.apache.org/doc/latest/cassandra/getting_started/installing.html#installing-the-rpm-packages] Can you please guide how can I install the stable version? > RPM Installation on centos 7 is broken by CASSANDRA-17669 > - > > Key: CASSANDRA-17765 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17765 > Project: Cassandra > Issue Type: Bug > Components: Packaging >Reporter: Jeremiah Jordan >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.0.x, 4.1-rc, 4.x > > > With CASSANDRA-17669 adding use of "or" in the dependencies for the RPM so it > can depend on java 8 or java 11 it broke installation on CentOS Linux 7. > This is bad because CentOS Linux 7 is the "current" release of CentOS Linux, > version 8 was EOL'ed in favor of the new pre-release distribution model being > used for CentOS Stream 8. > I don't know what the best answer is here, maybe making a CentOS 7 specific > package that reverts back to just java 8 in the requirements? But I think > should needs to be done. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17779) Resolve pylint issues in pylexotron.py and improve readability
[ https://issues.apache.org/jira/browse/CASSANDRA-17779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17577282#comment-17577282 ] Stefan Miklosovic commented on CASSANDRA-17779: --- +1 > Resolve pylint issues in pylexotron.py and improve readability > -- > > Key: CASSANDRA-17779 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17779 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.x > > > Add comments to clarify behavior > Convert short form constants to long form (e.g., re.I == re.IGNORECASE) > Camel case class names > > > [Original pylint] code has been rated at 6.71/10 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17806) Flaky test_rolling_upgrade
[
https://issues.apache.org/jira/browse/CASSANDRA-17806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-17806:
Description:
The fix on CASSANDRA-17140 needs to be extended into other places as it seems
it now fails only one in a billion but still we can fix that one.
{noformat}
Regression
dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_3_11_X_HEAD.test_rolling_upgrade
(from Cassandra dtests)
Failing for the past 1 build (Since
#115 )
Took 10 min.
Failed 1 times in the last 9 runs. Flakiness: 12%, Stability: 88%
Error Message
RuntimeError: A subprocess has terminated early. Subprocess statuses: Process-1
(is_alive: True), Process-2 (is_alive: False), attempting to terminate
remaining subprocesses now.
Stacktrace
self =
@pytest.mark.timeout(3000)
def test_rolling_upgrade(self):
"""
Test rolling upgrade of the cluster, so we have mixed versions part
way through.
"""
> self.upgrade_scenario(rolling=True)
upgrade_tests/upgrade_through_versions_test.py:340:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
upgrade_tests/upgrade_through_versions_test.py:417: in upgrade_scenario
self._check_on_subprocs(self.fixture_dtest_setup.subprocs)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self =
subprocs = [, ]
def _check_on_subprocs(self, subprocs):
"""
Check on given subprocesses.
If any are not alive, we'll go ahead and terminate any remaining
alive subprocesses since this test is going to fail.
"""
subproc_statuses = [s.is_alive() for s in subprocs]
if not all(subproc_statuses):
message = "A subprocess has terminated early. Subprocess statuses: "
for s in subprocs:
message += "{name} (is_alive: {aliveness}),
".format(name=s.name, aliveness=s.is_alive())
message += "attempting to terminate remaining subprocesses now."
self._terminate_subprocs()
> raise RuntimeError(message)
E RuntimeError: A subprocess has terminated early. Subprocess
statuses: Process-1 (is_alive: True), Process-2 (is_alive: False), attempting
to terminate remaining subprocesses now.
upgrade_tests/upgrade_through_versions_test.py:475: RuntimeError
{noformat}
was:
The fix on CASSANDRA-17140 needs to be extended into other places as it seems
it now fails one in a billion but we can fix it.
{noformat}
Regression
dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_3_11_X_HEAD.test_rolling_upgrade
(from Cassandra dtests)
Failing for the past 1 build (Since
#115 )
Took 10 min.
Failed 1 times in the last 9 runs. Flakiness: 12%, Stability: 88%
Error Message
RuntimeError: A subprocess has terminated early. Subprocess statuses: Process-1
(is_alive: True), Process-2 (is_alive: False), attempting to terminate
remaining subprocesses now.
Stacktrace
self =
@pytest.mark.timeout(3000)
def test_rolling_upgrade(self):
"""
Test rolling upgrade of the cluster, so we have mixed versions part
way through.
"""
> self.upgrade_scenario(rolling=True)
upgrade_tests/upgrade_through_versions_test.py:340:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
upgrade_tests/upgrade_through_versions_test.py:417: in upgrade_scenario
self._check_on_subprocs(self.fixture_dtest_setup.subprocs)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self =
subprocs = [, ]
def _check_on_subprocs(self, subprocs):
"""
Check on given subprocesses.
If any are not alive, we'll go ahead and terminate any remaining
alive subprocesses since this test is going to fail.
"""
subproc_statuses = [s.is_alive() for s in subprocs]
if not all(subproc_statuses):
message = "A subprocess has terminated early. Subprocess statuses: "
for s in subprocs:
message += "{name} (is_alive: {aliveness}),
".format(name=s.name, aliveness=s.is_alive())
message += "attempting to terminate remaining subprocesses now."
self._terminate_subprocs()
> raise RuntimeError(message)
E RuntimeError: A subprocess has terminated early. Subprocess
statuses: Process-1 (is_alive: True), Process-2 (is_alive: False), attempting
to terminate remaining subprocesses now.
upgrade_tests/upgrade_through_versions_test.py:475: RuntimeError
{noformat}
> Flaky test_rolling_upgrade
> --
>
> Key: CASSANDRA-17806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17806
> Project:
[jira] [Updated] (CASSANDRA-17806) Flaky test_rolling_upgrade
[
https://issues.apache.org/jira/browse/CASSANDRA-17806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-17806:
Fix Version/s: 3.0.x
> Flaky test_rolling_upgrade
> --
>
> Key: CASSANDRA-17806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17806
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 3.0.x, 4.0, 4.1-beta, 4.2
>
>
> The fix on CASSANDRA-17140 needs to be extended into other places as it seems
> it now fails only one in a billion but still we can fix that one.
> {noformat}
> Regression
> dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_3_11_X_HEAD.test_rolling_upgrade
> (from Cassandra dtests)
> Failing for the past 1 build (Since
> #115 )
> Took 10 min.
> Failed 1 times in the last 9 runs. Flakiness: 12%, Stability: 88%
> Error Message
> RuntimeError: A subprocess has terminated early. Subprocess statuses:
> Process-1 (is_alive: True), Process-2 (is_alive: False), attempting to
> terminate remaining subprocesses now.
> Stacktrace
> self =
> object at 0x7f4d313e4e50>
> @pytest.mark.timeout(3000)
> def test_rolling_upgrade(self):
> """
> Test rolling upgrade of the cluster, so we have mixed versions
> part way through.
> """
> > self.upgrade_scenario(rolling=True)
> upgrade_tests/upgrade_through_versions_test.py:340:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> upgrade_tests/upgrade_through_versions_test.py:417: in upgrade_scenario
> self._check_on_subprocs(self.fixture_dtest_setup.subprocs)
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> self =
> object at 0x7f4d313e4e50>
> subprocs = [ exitcode=-SIGKILL daemon>, stopped exitcode=1 daemon>]
> def _check_on_subprocs(self, subprocs):
> """
> Check on given subprocesses.
>
> If any are not alive, we'll go ahead and terminate any remaining
> alive subprocesses since this test is going to fail.
> """
> subproc_statuses = [s.is_alive() for s in subprocs]
> if not all(subproc_statuses):
> message = "A subprocess has terminated early. Subprocess
> statuses: "
> for s in subprocs:
> message += "{name} (is_alive: {aliveness}),
> ".format(name=s.name, aliveness=s.is_alive())
> message += "attempting to terminate remaining subprocesses now."
> self._terminate_subprocs()
> > raise RuntimeError(message)
> E RuntimeError: A subprocess has terminated early. Subprocess
> statuses: Process-1 (is_alive: True), Process-2 (is_alive: False), attempting
> to terminate remaining subprocesses now.
> upgrade_tests/upgrade_through_versions_test.py:475: RuntimeError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17140) Broken test_rolling_upgrade - upgrade_tests.upgrade_through_versions_test.TestUpgrade_indev_3_0_x_To_indev_4_0_x
[
https://issues.apache.org/jira/browse/CASSANDRA-17140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17577194#comment-17577194
]
Berenguer Blasi edited comment on CASSANDRA-17140 at 8/9/22 8:42 AM:
-
I really dislike creating a new ticket CASSANDRA-17806 for this, I should
reopen and fix, but given the span in time, we have a new trunk, etc I thought
it would be easier to follow history with a new ticket and not entangle this
one further.
Edit: new ticket ready for a quick review as it's the same fix as here #justfyi
was (Author: bereng):
I really dislike creating a new ticket CASSANDRA-17806 for this, I should
reopen and fix, but given the span in time, we have a new trunk, etc I thought
it would be easier to follow history with a new ticket and not entangle this
one further.
> Broken test_rolling_upgrade -
> upgrade_tests.upgrade_through_versions_test.TestUpgrade_indev_3_0_x_To_indev_4_0_x
>
>
> Key: CASSANDRA-17140
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17140
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Yifan Cai
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 3.0.27, 3.11.13, 4.0.4, 4.1, 4.1-alpha1
>
>
> The tests "test_rolling_upgrade" fail with the below error.
>
> [https://app.circleci.com/pipelines/github/yifan-c/cassandra/279/workflows/6340cd42-0b27-42c2-8418-9f8b56c57bea/jobs/1990]
>
> I am able to alway produce it by running the test locally too.
> {{$ pytest --execute-upgrade-tests-only --upgrade-target-version-only
> --upgrade-version-selection all --cassandra-version=4.0
> upgrade_tests/upgrade_through_versions_test.py::TestUpgrade_indev_3_11_x_To_indev_4_0_x::test_rolling_upgrade}}
>
> {code:java}
> self =
> object at 0x7ffba4242fd0>
> subprocs = [,
> ]
> def _check_on_subprocs(self, subprocs):
> """
> Check on given subprocesses.
>
> If any are not alive, we'll go ahead and terminate any remaining
> alive subprocesses since this test is going to fail.
> """
> subproc_statuses = [s.is_alive() for s in subprocs]
> if not all(subproc_statuses):
> message = "A subprocess has terminated early. Subprocess
> statuses: "
> for s in subprocs:
> message += "{name} (is_alive: {aliveness}),
> ".format(name=s.name, aliveness=s.is_alive())
> message += "attempting to terminate remaining subprocesses now."
> self._terminate_subprocs()
> > raise RuntimeError(message)
> E RuntimeError: A subprocess has terminated early. Subprocess
> statuses: Process-1 (is_alive: True), Process-2 (is_alive: False), attempting
> to terminate remaining subprocesses now.{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17806) Flaky test_rolling_upgrade
[
https://issues.apache.org/jira/browse/CASSANDRA-17806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-17806:
Fix Version/s: 4.1-beta
(was: 4.1)
> Flaky test_rolling_upgrade
> --
>
> Key: CASSANDRA-17806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17806
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0, 4.1-beta, 4.2
>
>
> The fix on CASSANDRA-17140 needs to be extended into other places as it seems
> it now fails one in a billion but we can fix it.
> {noformat}
> Regression
> dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_3_11_X_HEAD.test_rolling_upgrade
> (from Cassandra dtests)
> Failing for the past 1 build (Since
> #115 )
> Took 10 min.
> Failed 1 times in the last 9 runs. Flakiness: 12%, Stability: 88%
> Error Message
> RuntimeError: A subprocess has terminated early. Subprocess statuses:
> Process-1 (is_alive: True), Process-2 (is_alive: False), attempting to
> terminate remaining subprocesses now.
> Stacktrace
> self =
> object at 0x7f4d313e4e50>
> @pytest.mark.timeout(3000)
> def test_rolling_upgrade(self):
> """
> Test rolling upgrade of the cluster, so we have mixed versions
> part way through.
> """
> > self.upgrade_scenario(rolling=True)
> upgrade_tests/upgrade_through_versions_test.py:340:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> upgrade_tests/upgrade_through_versions_test.py:417: in upgrade_scenario
> self._check_on_subprocs(self.fixture_dtest_setup.subprocs)
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> self =
> object at 0x7f4d313e4e50>
> subprocs = [ exitcode=-SIGKILL daemon>, stopped exitcode=1 daemon>]
> def _check_on_subprocs(self, subprocs):
> """
> Check on given subprocesses.
>
> If any are not alive, we'll go ahead and terminate any remaining
> alive subprocesses since this test is going to fail.
> """
> subproc_statuses = [s.is_alive() for s in subprocs]
> if not all(subproc_statuses):
> message = "A subprocess has terminated early. Subprocess
> statuses: "
> for s in subprocs:
> message += "{name} (is_alive: {aliveness}),
> ".format(name=s.name, aliveness=s.is_alive())
> message += "attempting to terminate remaining subprocesses now."
> self._terminate_subprocs()
> > raise RuntimeError(message)
> E RuntimeError: A subprocess has terminated early. Subprocess
> statuses: Process-1 (is_alive: True), Process-2 (is_alive: False), attempting
> to terminate remaining subprocesses now.
> upgrade_tests/upgrade_through_versions_test.py:475: RuntimeError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17806) Flaky test_rolling_upgrade
[
https://issues.apache.org/jira/browse/CASSANDRA-17806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-17806:
Fix Version/s: 4.1
4.2
4.0
> Flaky test_rolling_upgrade
> --
>
> Key: CASSANDRA-17806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17806
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 4.0, 4.1, 4.2
>
>
> The fix on CASSANDRA-17140 needs to be extended into other places as it seems
> it now fails one in a billion but we can fix it.
> {noformat}
> Regression
> dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_3_11_X_HEAD.test_rolling_upgrade
> (from Cassandra dtests)
> Failing for the past 1 build (Since
> #115 )
> Took 10 min.
> Failed 1 times in the last 9 runs. Flakiness: 12%, Stability: 88%
> Error Message
> RuntimeError: A subprocess has terminated early. Subprocess statuses:
> Process-1 (is_alive: True), Process-2 (is_alive: False), attempting to
> terminate remaining subprocesses now.
> Stacktrace
> self =
> object at 0x7f4d313e4e50>
> @pytest.mark.timeout(3000)
> def test_rolling_upgrade(self):
> """
> Test rolling upgrade of the cluster, so we have mixed versions
> part way through.
> """
> > self.upgrade_scenario(rolling=True)
> upgrade_tests/upgrade_through_versions_test.py:340:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> upgrade_tests/upgrade_through_versions_test.py:417: in upgrade_scenario
> self._check_on_subprocs(self.fixture_dtest_setup.subprocs)
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> self =
> object at 0x7f4d313e4e50>
> subprocs = [ exitcode=-SIGKILL daemon>, stopped exitcode=1 daemon>]
> def _check_on_subprocs(self, subprocs):
> """
> Check on given subprocesses.
>
> If any are not alive, we'll go ahead and terminate any remaining
> alive subprocesses since this test is going to fail.
> """
> subproc_statuses = [s.is_alive() for s in subprocs]
> if not all(subproc_statuses):
> message = "A subprocess has terminated early. Subprocess
> statuses: "
> for s in subprocs:
> message += "{name} (is_alive: {aliveness}),
> ".format(name=s.name, aliveness=s.is_alive())
> message += "attempting to terminate remaining subprocesses now."
> self._terminate_subprocs()
> > raise RuntimeError(message)
> E RuntimeError: A subprocess has terminated early. Subprocess
> statuses: Process-1 (is_alive: True), Process-2 (is_alive: False), attempting
> to terminate remaining subprocesses now.
> upgrade_tests/upgrade_through_versions_test.py:475: RuntimeError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17806) Flaky test_rolling_upgrade
[
https://issues.apache.org/jira/browse/CASSANDRA-17806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-17806:
Test and Documentation Plan: See PR
Status: Patch Available (was: In Progress)
> Flaky test_rolling_upgrade
> --
>
> Key: CASSANDRA-17806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17806
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
>
> The fix on CASSANDRA-17140 needs to be extended into other places as it seems
> it now fails one in a billion but we can fix it.
> {noformat}
> Regression
> dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_3_11_X_HEAD.test_rolling_upgrade
> (from Cassandra dtests)
> Failing for the past 1 build (Since
> #115 )
> Took 10 min.
> Failed 1 times in the last 9 runs. Flakiness: 12%, Stability: 88%
> Error Message
> RuntimeError: A subprocess has terminated early. Subprocess statuses:
> Process-1 (is_alive: True), Process-2 (is_alive: False), attempting to
> terminate remaining subprocesses now.
> Stacktrace
> self =
> object at 0x7f4d313e4e50>
> @pytest.mark.timeout(3000)
> def test_rolling_upgrade(self):
> """
> Test rolling upgrade of the cluster, so we have mixed versions
> part way through.
> """
> > self.upgrade_scenario(rolling=True)
> upgrade_tests/upgrade_through_versions_test.py:340:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> upgrade_tests/upgrade_through_versions_test.py:417: in upgrade_scenario
> self._check_on_subprocs(self.fixture_dtest_setup.subprocs)
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> self =
> object at 0x7f4d313e4e50>
> subprocs = [ exitcode=-SIGKILL daemon>, stopped exitcode=1 daemon>]
> def _check_on_subprocs(self, subprocs):
> """
> Check on given subprocesses.
>
> If any are not alive, we'll go ahead and terminate any remaining
> alive subprocesses since this test is going to fail.
> """
> subproc_statuses = [s.is_alive() for s in subprocs]
> if not all(subproc_statuses):
> message = "A subprocess has terminated early. Subprocess
> statuses: "
> for s in subprocs:
> message += "{name} (is_alive: {aliveness}),
> ".format(name=s.name, aliveness=s.is_alive())
> message += "attempting to terminate remaining subprocesses now."
> self._terminate_subprocs()
> > raise RuntimeError(message)
> E RuntimeError: A subprocess has terminated early. Subprocess
> statuses: Process-1 (is_alive: True), Process-2 (is_alive: False), attempting
> to terminate remaining subprocesses now.
> upgrade_tests/upgrade_through_versions_test.py:475: RuntimeError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17709) CQL.textile needs to be made current
[ https://issues.apache.org/jira/browse/CASSANDRA-17709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17577272#comment-17577272 ] Berenguer Blasi edited comment on CASSANDRA-17709 at 8/9/22 8:38 AM: - [~mck] I have vague recollections of some effort to be able to generate the docs in tree. Is that ready or where can I get up to date on this to start pulling the thread? Then we can decide if want to pursue that on the release date or what to do here now. Thx in advance was (Author: bereng): [~mck] I have vague recollections of some effort to be able to generate the doc in tree. Is that ready or where can I get up to date on this to start pulling the thread? Then we can decide if want to pursue that on the release date or what to do here now. Thx in advance > CQL.textile needs to be made current > > > Key: CASSANDRA-17709 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17709 > Project: Cassandra > Issue Type: Bug > Components: Legacy/CQL >Reporter: Brandon Williams >Priority: Normal > Fix For: 4.0.x, 4.1-beta > > > Per CASSANDRA-17570 > https://github.com/apache/cassandra/blob/trunk/doc/cql3/CQL.textile is > outdated, and the document we ship inside packages, so this should be made > current. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17709) CQL.textile needs to be made current
[ https://issues.apache.org/jira/browse/CASSANDRA-17709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17577272#comment-17577272 ] Berenguer Blasi commented on CASSANDRA-17709: - [~mck] I have vague recollections of some effort to be able to generate the doc in tree. Is that ready or where can I get up to date on this to start pulling the thread? Then we can decide if want to pursue that on the release date or what to do here now. Thx in advance > CQL.textile needs to be made current > > > Key: CASSANDRA-17709 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17709 > Project: Cassandra > Issue Type: Bug > Components: Legacy/CQL >Reporter: Brandon Williams >Priority: Normal > Fix For: 4.0.x, 4.1-beta > > > Per CASSANDRA-17570 > https://github.com/apache/cassandra/blob/trunk/doc/cql3/CQL.textile is > outdated, and the document we ship inside packages, so this should be made > current. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14914) Deserialization Error
[
https://issues.apache.org/jira/browse/CASSANDRA-14914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Claude Warren updated CASSANDRA-14914:
--
Resolution: Cannot Reproduce
Status: Resolved (was: Open)
Incomplete data provided. Reporter moved on to implement on a different DB.
> Deserialization Error
> -
>
> Key: CASSANDRA-14914
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14914
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Core
> Environment: I use cassandra 3.9, but I tried to upgrade to 3.11 and
> nothing has changed.
>Reporter: EDSON VICENTE CARLI JUNIOR
>Priority: Urgent
> Fix For: 3.11.x
>
> Attachments: mutation4465429258841992355dat
>
>
>
> I have a single cassandra, now this error appears when I start the server:
> {code:java}
> ERROR 11:18:45 Exiting due to error while processing commit log during
> initialization.
> org.apache.cassandra.db.commitlog.CommitLogReadHandler$CommitLogReadException:
> Unexpected error deserializing mutation; saved to
> /tmp/mutation4787806670239768067dat. This may be caused by replaying a
> mutation against a table with the same name but incompatible schema.
> Exception follows: org.apache.cassandra.serializers.MarshalException: A local
> deletion time should not be negative
> {code}
> If I delete all the commitlog and saved_cached files the server goes up, but
> the next day when I reboot the cassandra, the error occurs again.
> The file mutationDDdat change name for each restart. I attachament a
> example mutation file .
> What's wrong? How to make cassandra stable again?
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17806) Flaky test_rolling_upgrade
[
https://issues.apache.org/jira/browse/CASSANDRA-17806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-17806:
Bug Category: Parent values: Correctness(12982)
Complexity: Normal
Discovered By: Unit Test
Severity: Normal
Status: Open (was: Triage Needed)
> Flaky test_rolling_upgrade
> --
>
> Key: CASSANDRA-17806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17806
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
>
> The fix on CASSANDRA-17140 needs to be extended into other places as it seems
> it now fails one in a billion but we can fix it.
> {noformat}
> Regression
> dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_3_11_X_HEAD.test_rolling_upgrade
> (from Cassandra dtests)
> Failing for the past 1 build (Since
> #115 )
> Took 10 min.
> Failed 1 times in the last 9 runs. Flakiness: 12%, Stability: 88%
> Error Message
> RuntimeError: A subprocess has terminated early. Subprocess statuses:
> Process-1 (is_alive: True), Process-2 (is_alive: False), attempting to
> terminate remaining subprocesses now.
> Stacktrace
> self =
> object at 0x7f4d313e4e50>
> @pytest.mark.timeout(3000)
> def test_rolling_upgrade(self):
> """
> Test rolling upgrade of the cluster, so we have mixed versions
> part way through.
> """
> > self.upgrade_scenario(rolling=True)
> upgrade_tests/upgrade_through_versions_test.py:340:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> upgrade_tests/upgrade_through_versions_test.py:417: in upgrade_scenario
> self._check_on_subprocs(self.fixture_dtest_setup.subprocs)
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> self =
> object at 0x7f4d313e4e50>
> subprocs = [ exitcode=-SIGKILL daemon>, stopped exitcode=1 daemon>]
> def _check_on_subprocs(self, subprocs):
> """
> Check on given subprocesses.
>
> If any are not alive, we'll go ahead and terminate any remaining
> alive subprocesses since this test is going to fail.
> """
> subproc_statuses = [s.is_alive() for s in subprocs]
> if not all(subproc_statuses):
> message = "A subprocess has terminated early. Subprocess
> statuses: "
> for s in subprocs:
> message += "{name} (is_alive: {aliveness}),
> ".format(name=s.name, aliveness=s.is_alive())
> message += "attempting to terminate remaining subprocesses now."
> self._terminate_subprocs()
> > raise RuntimeError(message)
> E RuntimeError: A subprocess has terminated early. Subprocess
> statuses: Process-1 (is_alive: True), Process-2 (is_alive: False), attempting
> to terminate remaining subprocesses now.
> upgrade_tests/upgrade_through_versions_test.py:475: RuntimeError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17806) Flaky test_rolling_upgrade
[
https://issues.apache.org/jira/browse/CASSANDRA-17806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-17806:
Summary: Flaky test_rolling_upgrade (was: Broken test_rolling_upgrade)
> Flaky test_rolling_upgrade
> --
>
> Key: CASSANDRA-17806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17806
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Berenguer Blasi
>Assignee: Berenguer Blasi
>Priority: Normal
>
> The fix on CASSANDRA-17140 needs to be extended into other places as it seems
> it now fails one in a billion but we can fix it.
> {noformat}
> Regression
> dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_3_11_X_HEAD.test_rolling_upgrade
> (from Cassandra dtests)
> Failing for the past 1 build (Since
> #115 )
> Took 10 min.
> Failed 1 times in the last 9 runs. Flakiness: 12%, Stability: 88%
> Error Message
> RuntimeError: A subprocess has terminated early. Subprocess statuses:
> Process-1 (is_alive: True), Process-2 (is_alive: False), attempting to
> terminate remaining subprocesses now.
> Stacktrace
> self =
> object at 0x7f4d313e4e50>
> @pytest.mark.timeout(3000)
> def test_rolling_upgrade(self):
> """
> Test rolling upgrade of the cluster, so we have mixed versions
> part way through.
> """
> > self.upgrade_scenario(rolling=True)
> upgrade_tests/upgrade_through_versions_test.py:340:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> upgrade_tests/upgrade_through_versions_test.py:417: in upgrade_scenario
> self._check_on_subprocs(self.fixture_dtest_setup.subprocs)
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> self =
> object at 0x7f4d313e4e50>
> subprocs = [ exitcode=-SIGKILL daemon>, stopped exitcode=1 daemon>]
> def _check_on_subprocs(self, subprocs):
> """
> Check on given subprocesses.
>
> If any are not alive, we'll go ahead and terminate any remaining
> alive subprocesses since this test is going to fail.
> """
> subproc_statuses = [s.is_alive() for s in subprocs]
> if not all(subproc_statuses):
> message = "A subprocess has terminated early. Subprocess
> statuses: "
> for s in subprocs:
> message += "{name} (is_alive: {aliveness}),
> ".format(name=s.name, aliveness=s.is_alive())
> message += "attempting to terminate remaining subprocesses now."
> self._terminate_subprocs()
> > raise RuntimeError(message)
> E RuntimeError: A subprocess has terminated early. Subprocess
> statuses: Process-1 (is_alive: True), Process-2 (is_alive: False), attempting
> to terminate remaining subprocesses now.
> upgrade_tests/upgrade_through_versions_test.py:475: RuntimeError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17140) Broken test_rolling_upgrade - upgrade_tests.upgrade_through_versions_test.TestUpgrade_indev_3_0_x_To_indev_4_0_x
[
https://issues.apache.org/jira/browse/CASSANDRA-17140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17577194#comment-17577194
]
Berenguer Blasi commented on CASSANDRA-17140:
-
I really dislike creating a new ticket CASSANDRA-17806 for this, I should
reopen and fix, but given the span in time, we have a new trunk, etc I thought
it would be easier to follow history with a new ticket and not entangle this
one further.
> Broken test_rolling_upgrade -
> upgrade_tests.upgrade_through_versions_test.TestUpgrade_indev_3_0_x_To_indev_4_0_x
>
>
> Key: CASSANDRA-17140
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17140
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Yifan Cai
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 3.0.27, 3.11.13, 4.0.4, 4.1, 4.1-alpha1
>
>
> The tests "test_rolling_upgrade" fail with the below error.
>
> [https://app.circleci.com/pipelines/github/yifan-c/cassandra/279/workflows/6340cd42-0b27-42c2-8418-9f8b56c57bea/jobs/1990]
>
> I am able to alway produce it by running the test locally too.
> {{$ pytest --execute-upgrade-tests-only --upgrade-target-version-only
> --upgrade-version-selection all --cassandra-version=4.0
> upgrade_tests/upgrade_through_versions_test.py::TestUpgrade_indev_3_11_x_To_indev_4_0_x::test_rolling_upgrade}}
>
> {code:java}
> self =
> object at 0x7ffba4242fd0>
> subprocs = [,
> ]
> def _check_on_subprocs(self, subprocs):
> """
> Check on given subprocesses.
>
> If any are not alive, we'll go ahead and terminate any remaining
> alive subprocesses since this test is going to fail.
> """
> subproc_statuses = [s.is_alive() for s in subprocs]
> if not all(subproc_statuses):
> message = "A subprocess has terminated early. Subprocess
> statuses: "
> for s in subprocs:
> message += "{name} (is_alive: {aliveness}),
> ".format(name=s.name, aliveness=s.is_alive())
> message += "attempting to terminate remaining subprocesses now."
> self._terminate_subprocs()
> > raise RuntimeError(message)
> E RuntimeError: A subprocess has terminated early. Subprocess
> statuses: Process-1 (is_alive: True), Process-2 (is_alive: False), attempting
> to terminate remaining subprocesses now.{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-17806) Broken test_rolling_upgrade
Berenguer Blasi created CASSANDRA-17806:
---
Summary: Broken test_rolling_upgrade
Key: CASSANDRA-17806
URL: https://issues.apache.org/jira/browse/CASSANDRA-17806
Project: Cassandra
Issue Type: Bug
Components: Test/dtest/python
Reporter: Berenguer Blasi
Assignee: Berenguer Blasi
The fix on CASSANDRA-17140 needs to be extended into other places as it seems
it now fails one in a billion but we can fix it.
{noformat}
Regression
dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_3_11_X_HEAD.test_rolling_upgrade
(from Cassandra dtests)
Failing for the past 1 build (Since
#115 )
Took 10 min.
Failed 1 times in the last 9 runs. Flakiness: 12%, Stability: 88%
Error Message
RuntimeError: A subprocess has terminated early. Subprocess statuses: Process-1
(is_alive: True), Process-2 (is_alive: False), attempting to terminate
remaining subprocesses now.
Stacktrace
self =
@pytest.mark.timeout(3000)
def test_rolling_upgrade(self):
"""
Test rolling upgrade of the cluster, so we have mixed versions part
way through.
"""
> self.upgrade_scenario(rolling=True)
upgrade_tests/upgrade_through_versions_test.py:340:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
upgrade_tests/upgrade_through_versions_test.py:417: in upgrade_scenario
self._check_on_subprocs(self.fixture_dtest_setup.subprocs)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self =
subprocs = [, ]
def _check_on_subprocs(self, subprocs):
"""
Check on given subprocesses.
If any are not alive, we'll go ahead and terminate any remaining
alive subprocesses since this test is going to fail.
"""
subproc_statuses = [s.is_alive() for s in subprocs]
if not all(subproc_statuses):
message = "A subprocess has terminated early. Subprocess statuses: "
for s in subprocs:
message += "{name} (is_alive: {aliveness}),
".format(name=s.name, aliveness=s.is_alive())
message += "attempting to terminate remaining subprocesses now."
self._terminate_subprocs()
> raise RuntimeError(message)
E RuntimeError: A subprocess has terminated early. Subprocess
statuses: Process-1 (is_alive: True), Process-2 (is_alive: False), attempting
to terminate remaining subprocesses now.
upgrade_tests/upgrade_through_versions_test.py:475: RuntimeError
{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
