[jira] [Commented] (CASSANDRA-18144) org.apache.cassandra.db.compaction.CompactionStrategyManagerBoundaryReloadTest.testReload fails when running with TrieMemtables
[
https://issues.apache.org/jira/browse/CASSANDRA-18144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679501#comment-17679501
]
Kamalesh Palanisamy commented on CASSANDRA-18144:
-
Submitted PR to fix this issue: https://github.com/apache/cassandra/pull/2107
> org.apache.cassandra.db.compaction.CompactionStrategyManagerBoundaryReloadTest.testReload
> fails when running with TrieMemtables
> ---
>
> Key: CASSANDRA-18144
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18144
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: David Capwell
>Assignee: Kamalesh Palanisamy
>Priority: Normal
> Fix For: 4.x
>
>
> https://app.circleci.com/pipelines/github/dcapwell/cassandra/1771/workflows/1bd920c8-8568-44b3-9e8b-b152a73cf4fc/jobs/15393
> {code}
> java.lang.RuntimeException: Error setting schema for test (query was: alter
> table cql_test_keyspace.table_01 with compaction = {'class':
> 'SizeTieredCompactionStrategy', 'enabled': false})
> at org.apache.cassandra.cql3.CQLTester.schemaChange(CQLTester.java:1222)
> at org.apache.cassandra.cql3.CQLTester.alterTable(CQLTester.java:1009)
> at
> org.apache.cassandra.db.compaction.CompactionStrategyManagerBoundaryReloadTest.testReload(CompactionStrategyManagerBoundaryReloadTest.java:82)
> Caused by: java.lang.ClassCastException:
> org.apache.cassandra.dht.ByteOrderedPartitioner$BytesToken cannot be cast to
> org.apache.cassandra.dht.Murmur3Partitioner$LongToken
> at
> org.apache.cassandra.dht.Murmur3Partitioner$1.valueForToken(Murmur3Partitioner.java:68)
> at
> org.apache.cassandra.dht.Splitter$WeightedRange.totalTokens(Splitter.java:278)
> at org.apache.cassandra.dht.Splitter.splitOwnedRanges(Splitter.java:129)
> at
> org.apache.cassandra.db.ColumnFamilyStore.localRangeSplits(ColumnFamilyStore.java:1504)
> at
> org.apache.cassandra.db.memtable.AbstractShardedMemtable.(AbstractShardedMemtable.java:65)
> at
> org.apache.cassandra.db.memtable.TrieMemtable.(TrieMemtable.java:142)
> at
> org.apache.cassandra.db.memtable.TrieMemtable$Factory.create(TrieMemtable.java:688)
> at
> org.apache.cassandra.db.ColumnFamilyStore.createMemtable(ColumnFamilyStore.java:1375)
> at
> org.apache.cassandra.db.ColumnFamilyStore$Flush.(ColumnFamilyStore.java:1173)
> at
> org.apache.cassandra.db.ColumnFamilyStore$Flush.(ColumnFamilyStore.java:1137)
> at
> org.apache.cassandra.db.ColumnFamilyStore.switchMemtable(ColumnFamilyStore.java:1000)
> at
> org.apache.cassandra.db.ColumnFamilyStore.switchMemtableIfCurrent(ColumnFamilyStore.java:981)
> at
> org.apache.cassandra.db.ColumnFamilyStore.switchMemtableOrNotify(ColumnFamilyStore.java:966)
> at
> org.apache.cassandra.db.ColumnFamilyStore.reload(ColumnFamilyStore.java:393)
> {code}
> First reported to slack:
> https://the-asf.slack.com/archives/CK23JSY2K/p1673382016638189
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18139) Revert changes to units output in FileUtils#stringifyFileSize
[ https://issues.apache.org/jira/browse/CASSANDRA-18139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18139: Summary: Revert changes to units output in FileUtils#stringifyFileSize (was: Revert changes to units output in FileUtils#stringifyFileSize post CASSANDRA-15234) > Revert changes to units output in FileUtils#stringifyFileSize > - > > Key: CASSANDRA-18139 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18139 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.x > > > As discussed in CASSANDRA-15234, FileUtils#stringifyFileSize is used in > nodetool output which can break people parsing the nodetool output -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18181) Fix tests post JDK-8210522
[
https://issues.apache.org/jira/browse/CASSANDRA-18181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679489#comment-17679489
]
Ekaterina Dimitrova commented on CASSANDRA-18181:
-
I just started the simulator tests in CircleCI as they are not added yet to
Jenkins (CASSANDRA-18003) - they finished successfully
[here|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2185/workflows/5370326f-a9b9-472a-a226-675b24201f3c]
> Fix tests post JDK-8210522
> --
>
> Key: CASSANDRA-18181
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18181
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.x
>
>
>
> From JDK-8210522:
> {code:java}
> Core reflection has a filtering mechanism to hide security and integrity
> sensitive fields and methods from Class getXXXField(s) and getXXXMethod(s).
> The filtering mechanism has been used for several releases to hide security
> sensitive fields such as System.security and Class.classLoader.
> This CSR proposes to extend the filters to hide fields from a number of
> highly security sensitive classes in java.lang.reflect and java.lang.invoke.
> {code}
> We are using at a few places in our tests
> {code:java}
> Field.class.getDeclaredField("modifiers");{code}
> This breaks as expected when tests are run with JDK17, example:
>
> {code:java}
> java.lang.RuntimeException: java.lang.NoSuchFieldException: modifiers
> at
> org.apache.cassandra.transport.MessagePayloadTest.makeCqlQueryHandlerAccessible(MessagePayloadTest.java:79)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:568)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at
> org.junit.runner.JUnitCore.run(JUnitCore.java:137)
> at
> com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
> at
> com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
> at
> com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:221)
> at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54)
> Caused by: java.lang.NoSuchFieldException: modifiers at
> java.base/java.lang.Class.getDeclaredField(Class.java:2610)
> at
> org.apache.cassandra.transport.MessagePayloadTest.makeCqlQueryHandlerAccessible(MessagePayloadTest.java:70)
>
> ... 15 more{code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18181) Fix tests post JDK-8210522
[
https://issues.apache.org/jira/browse/CASSANDRA-18181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679481#comment-17679481
]
Ekaterina Dimitrova edited comment on CASSANDRA-18181 at 1/21/23 10:26 PM:
---
Wall of failures in DTests, probably it didn't download the updated DTest trunk
branch
Just pushed it again
[here|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2214/]
was (Author: e.dimitrova):
Wall of failures in DTests, probably it didn't download the updated DTest trunk
branch
Just pushed it again
[here|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2213/]
> Fix tests post JDK-8210522
> --
>
> Key: CASSANDRA-18181
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18181
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.x
>
>
>
> From JDK-8210522:
> {code:java}
> Core reflection has a filtering mechanism to hide security and integrity
> sensitive fields and methods from Class getXXXField(s) and getXXXMethod(s).
> The filtering mechanism has been used for several releases to hide security
> sensitive fields such as System.security and Class.classLoader.
> This CSR proposes to extend the filters to hide fields from a number of
> highly security sensitive classes in java.lang.reflect and java.lang.invoke.
> {code}
> We are using at a few places in our tests
> {code:java}
> Field.class.getDeclaredField("modifiers");{code}
> This breaks as expected when tests are run with JDK17, example:
>
> {code:java}
> java.lang.RuntimeException: java.lang.NoSuchFieldException: modifiers
> at
> org.apache.cassandra.transport.MessagePayloadTest.makeCqlQueryHandlerAccessible(MessagePayloadTest.java:79)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:568)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at
> org.junit.runner.JUnitCore.run(JUnitCore.java:137)
> at
> com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
> at
> com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
> at
> com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:221)
> at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54)
> Caused by: java.lang.NoSuchFieldException: modifiers at
> java.base/java.lang.Class.getDeclaredField(Class.java:2610)
> at
> org.apache.cassandra.transport.MessagePayloadTest.makeCqlQueryHandlerAccessible(MessagePayloadTest.java:70)
>
> ... 15 more{code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18179) Update current trunk build.xml and conf scripts for JDK17
[ https://issues.apache.org/jira/browse/CASSANDRA-18179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679485#comment-17679485 ] Ekaterina Dimitrova edited comment on CASSANDRA-18179 at 1/21/23 10:11 PM: --- Overall looks good, I left just a few questions/comments on the commit. Further to testing J11 and J8 current CI, I can pull the change to my branch and test with JDK17 with the removed UDFs. I can get to this probably tomorrow Considering trunk does not yet compile I guess we can just leave a comment about that in build.xml. And considering that I do not see it a breaking change that CCM is still not ready as we can't even compile...yet was (Author: e.dimitrova): Overall looks good, I left just a few questions/comments on the commit. Further to testing J11 and J8 current CI, I can pull the change to my branch and test with JDK17 with the removed UDFs. Considering trunk does not yet compile I guess we can just leave a comment about that in build.xml. And considering that I do not see it a breaking change that CCM is still not ready as we can't even compile...yet > Update current trunk build.xml and conf scripts for JDK17 > - > > Key: CASSANDRA-18179 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18179 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 4.x > > > To support JDK17 we need to make changes to build.xml and our scripts. There > is a preliminary patch which makes a switch from JDK8+JDK11 to JDK11+JDK17 > but it will need a change considering CASSANDRA-18133 > CC [~mck] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18179) Update current trunk build.xml and conf scripts for JDK17
[ https://issues.apache.org/jira/browse/CASSANDRA-18179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679485#comment-17679485 ] Ekaterina Dimitrova commented on CASSANDRA-18179: - Overall looks good, I left just a few questions/comments on the commit. Further to testing J11 and J8 current CI, I can pull the change to my branch and test with JDK17 with the removed UDFs. Considering trunk does not yet compile I guess we can just leave a comment about that in build.xml. And considering that I do not see it a breaking change that CCM is still not ready as we can't even compile...yet > Update current trunk build.xml and conf scripts for JDK17 > - > > Key: CASSANDRA-18179 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18179 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 4.x > > > To support JDK17 we need to make changes to build.xml and our scripts. There > is a preliminary patch which makes a switch from JDK8+JDK11 to JDK11+JDK17 > but it will need a change considering CASSANDRA-18133 > CC [~mck] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17964) Some tests are never executed due to naming violation - fix it and add checkstyle where applicable
[ https://issues.apache.org/jira/browse/CASSANDRA-17964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679484#comment-17679484 ] Ekaterina Dimitrova commented on CASSANDRA-17964: - QQ: why should we @ignore the tests that are failing if they will have tickets anyway and we need to fix them? How many are those that fail? > Some tests are never executed due to naming violation - fix it and add > checkstyle where applicable > -- > > Key: CASSANDRA-17964 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17964 > Project: Cassandra > Issue Type: Task > Components: Test/unit >Reporter: Ruslan Fomkin >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 4.x > > Time Spent: 2h 50m > Remaining Estimate: 0h > > [BatchTests|https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/cql3/BatchTests.java] > doesn't follow naming convention to be run as unit tests and, thus, is never > run. > The rule in build expects names as `*Test`. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18181) Fix tests post JDK-8210522
[
https://issues.apache.org/jira/browse/CASSANDRA-18181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679481#comment-17679481
]
Ekaterina Dimitrova commented on CASSANDRA-18181:
-
Wall of failures in DTests, probably it didn't download the updated DTest trunk
branch
Just pushed it again
[here|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2213/]
> Fix tests post JDK-8210522
> --
>
> Key: CASSANDRA-18181
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18181
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.x
>
>
>
> From JDK-8210522:
> {code:java}
> Core reflection has a filtering mechanism to hide security and integrity
> sensitive fields and methods from Class getXXXField(s) and getXXXMethod(s).
> The filtering mechanism has been used for several releases to hide security
> sensitive fields such as System.security and Class.classLoader.
> This CSR proposes to extend the filters to hide fields from a number of
> highly security sensitive classes in java.lang.reflect and java.lang.invoke.
> {code}
> We are using at a few places in our tests
> {code:java}
> Field.class.getDeclaredField("modifiers");{code}
> This breaks as expected when tests are run with JDK17, example:
>
> {code:java}
> java.lang.RuntimeException: java.lang.NoSuchFieldException: modifiers
> at
> org.apache.cassandra.transport.MessagePayloadTest.makeCqlQueryHandlerAccessible(MessagePayloadTest.java:79)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:568)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at
> org.junit.runner.JUnitCore.run(JUnitCore.java:137)
> at
> com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
> at
> com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
> at
> com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:221)
> at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54)
> Caused by: java.lang.NoSuchFieldException: modifiers at
> java.base/java.lang.Class.getDeclaredField(Class.java:2610)
> at
> org.apache.cassandra.transport.MessagePayloadTest.makeCqlQueryHandlerAccessible(MessagePayloadTest.java:70)
>
> ... 15 more{code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18179) Update current trunk build.xml and conf scripts for JDK17
[ https://issues.apache.org/jira/browse/CASSANDRA-18179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18179: Status: Review In Progress (was: Patch Available) > Update current trunk build.xml and conf scripts for JDK17 > - > > Key: CASSANDRA-18179 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18179 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 4.x > > > To support JDK17 we need to make changes to build.xml and our scripts. There > is a preliminary patch which makes a switch from JDK8+JDK11 to JDK11+JDK17 > but it will need a change considering CASSANDRA-18133 > CC [~mck] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18077) Add SpotBugs to the build
[ https://issues.apache.org/jira/browse/CASSANDRA-18077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18077: Reviewers: (was: Ekaterina Dimitrova) > Add SpotBugs to the build > - > > Key: CASSANDRA-18077 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18077 > Project: Cassandra > Issue Type: Improvement > Components: Build, CI >Reporter: David Capwell >Priority: Normal > Fix For: 4.x > > Attachments: spotbugs.html > > Time Spent: 50m > Remaining Estimate: 0h > > When working on CASSANDRA-17178 I found that several classes were being > reported by the Simulator for not defining serializer version when they are > Serializable; this may cause issues for the Simulator so felt it would be > best to detect these earlier on before merging new ones. > SpotBugs has a large set of checks, some more valuable than others for the > project; so we should maintain a curated list of issues to fail the build on, > and others to warn on. > This topic was discussed in the following mail threads: > * Should we add?: > https://lists.apache.org/thread/1ro1mvkpvt4vr24nw7dbpdlxo82mq3hz > * Should we fix UTF-8 issues? > https://lists.apache.org/thread/sokxf46s7hyoxr9q4wm7dv3q2nm19nt3 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16615) Incompatible JNA libraries cause unnecessary failures when using cassandra-all jar.
[ https://issues.apache.org/jira/browse/CASSANDRA-16615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-16615: --- Reviewers: (was: Michael Semb Wever) > Incompatible JNA libraries cause unnecessary failures when using > cassandra-all jar. > --- > > Key: CASSANDRA-16615 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16615 > Project: Cassandra > Issue Type: Bug > Components: Local/Other >Reporter: Doug Rohrer >Priority: Normal > > There are some additional use-cases where lack of JNA libraries is causing > issues for users of cassandra-all libraries - cases where the native > libraries were not loaded but we should be able to continue should be handled > without throwing exceptions. Note that the Cassandra +server+ will not start > up without an appropriate/compatible JNA jar available, but users of the > cassandra-all libraries will have a more difficult time maintaining > compatibility across JNA versions as they deploy to, for example, Spark > setups that have newer/older JNA versions. > Proposal: > - Audit usages of `NativeLibrary` > - Wherever possible, handle the -1 return values without failing +if > `DatabaseDescriptor.isClientInitialized()` returns true+. > - Maintain existing failure behavior if the system is not in client mode but > the call returns -1. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18077) Add SpotBugs to the build
[ https://issues.apache.org/jira/browse/CASSANDRA-18077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-18077: --- Reviewers: Ekaterina Dimitrova (was: Ekaterina Dimitrova, Michael Semb Wever) > Add SpotBugs to the build > - > > Key: CASSANDRA-18077 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18077 > Project: Cassandra > Issue Type: Improvement > Components: Build, CI >Reporter: David Capwell >Priority: Normal > Fix For: 4.x > > Attachments: spotbugs.html > > Time Spent: 50m > Remaining Estimate: 0h > > When working on CASSANDRA-17178 I found that several classes were being > reported by the Simulator for not defining serializer version when they are > Serializable; this may cause issues for the Simulator so felt it would be > best to detect these earlier on before merging new ones. > SpotBugs has a large set of checks, some more valuable than others for the > project; so we should maintain a curated list of issues to fail the build on, > and others to warn on. > This topic was discussed in the following mail threads: > * Should we add?: > https://lists.apache.org/thread/1ro1mvkpvt4vr24nw7dbpdlxo82mq3hz > * Should we fix UTF-8 issues? > https://lists.apache.org/thread/sokxf46s7hyoxr9q4wm7dv3q2nm19nt3 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18179) Update current trunk build.xml and conf scripts for JDK17
[ https://issues.apache.org/jira/browse/CASSANDRA-18179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-18179: --- Reviewers: Ekaterina Dimitrova > Update current trunk build.xml and conf scripts for JDK17 > - > > Key: CASSANDRA-18179 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18179 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 4.x > > > To support JDK17 we need to make changes to build.xml and our scripts. There > is a preliminary patch which makes a switch from JDK8+JDK11 to JDK11+JDK17 > but it will need a change considering CASSANDRA-18133 > CC [~mck] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-18179) Update current trunk build.xml and conf scripts for JDK17
[ https://issues.apache.org/jira/browse/CASSANDRA-18179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever reassigned CASSANDRA-18179: -- Assignee: Michael Semb Wever > Update current trunk build.xml and conf scripts for JDK17 > - > > Key: CASSANDRA-18179 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18179 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 4.x > > > To support JDK17 we need to make changes to build.xml and our scripts. There > is a preliminary patch which makes a switch from JDK8+JDK11 to JDK11+JDK17 > but it will need a change considering CASSANDRA-18133 > CC [~mck] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18179) Update current trunk build.xml and conf scripts for JDK17
[ https://issues.apache.org/jira/browse/CASSANDRA-18179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-18179: --- Test and Documentation Plan: CI Status: Patch Available (was: Open) > Update current trunk build.xml and conf scripts for JDK17 > - > > Key: CASSANDRA-18179 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18179 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.x > > > To support JDK17 we need to make changes to build.xml and our scripts. There > is a preliminary patch which makes a switch from JDK8+JDK11 to JDK11+JDK17 > but it will need a change considering CASSANDRA-18133 > CC [~mck] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18179) Update current trunk build.xml and conf scripts for JDK17
[ https://issues.apache.org/jira/browse/CASSANDRA-18179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679443#comment-17679443 ] Michael Semb Wever commented on CASSANDRA-18179: Patch at https://github.com/apache/cassandra/compare/trunk...michaelsembwever:cassandra:mck/18179/trunk This introduces jdk17, but keeps jdk8 (and keeps it as the default). This allows us to incrementally progress on the jdk17 tickets. > Update current trunk build.xml and conf scripts for JDK17 > - > > Key: CASSANDRA-18179 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18179 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.x > > > To support JDK17 we need to make changes to build.xml and our scripts. There > is a preliminary patch which makes a switch from JDK8+JDK11 to JDK11+JDK17 > but it will need a change considering CASSANDRA-18133 > CC [~mck] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
