[jira] [Commented] (CASSANDRA-18062) On-disk string index with index building and on-disk query path
[ https://issues.apache.org/jira/browse/CASSANDRA-18062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684959#comment-17684959 ] Caleb Rackliffe commented on CASSANDRA-18062: - Minor note: I had forgotten to actually push the trunk rebase for the CASSANDRA-16052 feature branch on the 19th. That's done, so the branch here will need a quick rebase. > On-disk string index with index building and on-disk query path > --- > > Key: CASSANDRA-18062 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18062 > Project: Cassandra > Issue Type: New Feature > Components: Feature/SAI >Reporter: Mike Adamson >Assignee: Mike Adamson >Priority: Normal > > An on-disk index for string (literal) datatypes. This index is used for the > following datatypes: > * UTF8Type > * AsciiType > * CompositeType > * Frozen types > This includes the ability to write the index to disk at index creation, by > specific index rebuild and during SSTable compaction. > Also the ability to query the on-disk index and combine the results with > those from the in-memory indexes created by CASSANDRA-18058. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16052) CEP-7 Storage Attached Indexes
[ https://issues.apache.org/jira/browse/CASSANDRA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17678846#comment-17678846 ] Caleb Rackliffe edited comment on CASSANDRA-16052 at 2/6/23 10:05 PM: -- The patch for phase 1 (CASSANDRA-18058) has been merged to the [feature branch|https://github.com/maedhroz/cassandra/commits/CASSANDRA-16052], and the feature branch has been rebased to trunk. Next up, CASSANDRA-18062! was (Author: maedhroz): The patch for phase 1 (CASSANDRA-18058) has been merged to the [feature branch|[https://github.com/maedhroz/cassandra/commits/CASSANDRA-16052]], and the feature branch has been rebased to trunk. Next up, CASSANDRA-18062! > CEP-7 Storage Attached Indexes > -- > > Key: CASSANDRA-16052 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16052 > Project: Cassandra > Issue Type: Epic > Components: Feature/2i Index >Reporter: Zhao Yang >Assignee: Caleb Rackliffe >Priority: Normal > Fix For: 4.x > > Time Spent: 40m > Remaining Estimate: 0h > > [CEP|https://docs.google.com/document/d/1V830eAMmQAspjJdjviVZIaSolVGvZ1hVsqOLWyV0DS4/edit#heading=h.67ap6rr1mxr] > - A new index implementation, called Storage > Attached Index(SAI), based on the advancement made by SASI. > * disk usage by sharing of common data between multiple column indexes on > the same table and better compression of on-disk structures. > * numeric range query performance with modified KDTree and collection type > support. > * compaction performance and stability for larger data set. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18204) CEP-15: (C*) Add git submodule for Accord
[ https://issues.apache.org/jira/browse/CASSANDRA-18204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684955#comment-17684955 ] Caleb Rackliffe commented on CASSANDRA-18204: - +1 on both PRs (w/ minor comments inline) > CEP-15: (C*) Add git submodule for Accord > - > > Key: CASSANDRA-18204 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18204 > Project: Cassandra > Issue Type: Task > Components: Accord >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.x > > Time Spent: 3h 50m > Remaining Estimate: 0h > > As talked about in dev@ thread "Intra-project dependencies”, we talked about > adding git submodules but before doing this had to work out a few issues > first; this ticket is to track this work. > Goals > * when checking out an older commit, or pulling in newer commits, the > submodule should also be updated automatically > * release artifact must include the submodule and must be able to build > without issue > * build.xml must be updated to build the submodule > * build.xml must be updated to release the submodule jar -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17979) Fix flaky test:org.apache.cassandra.net.HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades
[
https://issues.apache.org/jira/browse/CASSANDRA-17979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684939#comment-17684939
]
Brandon Williams edited comment on CASSANDRA-17979 at 2/6/23 8:50 PM:
--
The one failure in j8 is a circle env problem (ran OOS) and the one in j11 is
CASSANDRA-18151. +1 from me.
was (Author: brandon.williams):
The one failure in j8 is a circle env problem (ran OOS) and the one in j11 is
CASSANDRa-18151. +1 from me.
> Fix flaky
> test:org.apache.cassandra.net.HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades
> ---
>
> Key: CASSANDRA-17979
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17979
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Internode
>Reporter: Brandon Williams
>Assignee: Derek Chen-Becker
>Priority: Normal
> Fix For: 4.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1339/testReport/org.apache.cassandra.net/HandshakeTest/testOutboundConnectionfFallbackDuringUpgrades_cdc/
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1336/testReport/org.apache.cassandra.net/HandshakeTest/testOutboundConnectionfFallbackDuringUpgrades_compression/
> https://app.circleci.com/pipelines/github/instaclustr/cassandra/1466/workflows/ffb52616-92d7-4089-a0c9-a9ebf28333c0/jobs/6296/tests
> {noformat}
> junit.framework.AssertionFailedError
> at
> org.apache.cassandra.net.HandshakeTest.testOutboundFallbackOnSSLHandshakeFailure(HandshakeTest.java:384)
> at
> org.apache.cassandra.net.HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades(HandshakeTest.java:243)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17979) Fix flaky test:org.apache.cassandra.net.HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades
[
https://issues.apache.org/jira/browse/CASSANDRA-17979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-17979:
-
Status: Needs Committer (was: Review In Progress)
> Fix flaky
> test:org.apache.cassandra.net.HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades
> ---
>
> Key: CASSANDRA-17979
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17979
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Internode
>Reporter: Brandon Williams
>Assignee: Derek Chen-Becker
>Priority: Normal
> Fix For: 4.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1339/testReport/org.apache.cassandra.net/HandshakeTest/testOutboundConnectionfFallbackDuringUpgrades_cdc/
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1336/testReport/org.apache.cassandra.net/HandshakeTest/testOutboundConnectionfFallbackDuringUpgrades_compression/
> https://app.circleci.com/pipelines/github/instaclustr/cassandra/1466/workflows/ffb52616-92d7-4089-a0c9-a9ebf28333c0/jobs/6296/tests
> {noformat}
> junit.framework.AssertionFailedError
> at
> org.apache.cassandra.net.HandshakeTest.testOutboundFallbackOnSSLHandshakeFailure(HandshakeTest.java:384)
> at
> org.apache.cassandra.net.HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades(HandshakeTest.java:243)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17979) Fix flaky test:org.apache.cassandra.net.HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades
[
https://issues.apache.org/jira/browse/CASSANDRA-17979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684939#comment-17684939
]
Brandon Williams commented on CASSANDRA-17979:
--
The one failure in j8 is a circle env problem (ran OOS) and the one in j11 is
CASSANDRa-18151. +1 from me.
> Fix flaky
> test:org.apache.cassandra.net.HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades
> ---
>
> Key: CASSANDRA-17979
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17979
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Internode
>Reporter: Brandon Williams
>Assignee: Derek Chen-Becker
>Priority: Normal
> Fix For: 4.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1339/testReport/org.apache.cassandra.net/HandshakeTest/testOutboundConnectionfFallbackDuringUpgrades_cdc/
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1336/testReport/org.apache.cassandra.net/HandshakeTest/testOutboundConnectionfFallbackDuringUpgrades_compression/
> https://app.circleci.com/pipelines/github/instaclustr/cassandra/1466/workflows/ffb52616-92d7-4089-a0c9-a9ebf28333c0/jobs/6296/tests
> {noformat}
> junit.framework.AssertionFailedError
> at
> org.apache.cassandra.net.HandshakeTest.testOutboundFallbackOnSSLHandshakeFailure(HandshakeTest.java:384)
> at
> org.apache.cassandra.net.HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades(HandshakeTest.java:243)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17979) Fix flaky test:org.apache.cassandra.net.HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades
[
https://issues.apache.org/jira/browse/CASSANDRA-17979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684915#comment-17684915
]
Brandon Williams commented on CASSANDRA-17979:
--
We need to remove [this
one|https://github.com/driftx/cassandra/commit/37ccbbef2c22fefd137275ef47dfaa1b1cf8d153]
too.
||Branch||CI||
|[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-17979-trunk]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/854/workflows/e4a4f08c-825b-4dc2-a1d0-ed20ec208e0d],
[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/854/workflows/234db71c-ee84-4497-a369-83be08ac3fd5]|
> Fix flaky
> test:org.apache.cassandra.net.HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades
> ---
>
> Key: CASSANDRA-17979
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17979
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Internode
>Reporter: Brandon Williams
>Assignee: Derek Chen-Becker
>Priority: Normal
> Fix For: 4.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1339/testReport/org.apache.cassandra.net/HandshakeTest/testOutboundConnectionfFallbackDuringUpgrades_cdc/
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1336/testReport/org.apache.cassandra.net/HandshakeTest/testOutboundConnectionfFallbackDuringUpgrades_compression/
> https://app.circleci.com/pipelines/github/instaclustr/cassandra/1466/workflows/ffb52616-92d7-4089-a0c9-a9ebf28333c0/jobs/6296/tests
> {noformat}
> junit.framework.AssertionFailedError
> at
> org.apache.cassandra.net.HandshakeTest.testOutboundFallbackOnSSLHandshakeFailure(HandshakeTest.java:384)
> at
> org.apache.cassandra.net.HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades(HandshakeTest.java:243)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18198) "AttributeError: module 'py' has no attribute 'io'" reported in multiple tests
[
https://issues.apache.org/jira/browse/CASSANDRA-18198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684884#comment-17684884
]
Brandon Williams commented on CASSANDRA-18198:
--
Can you point me to the error that is in the title?
> "AttributeError: module 'py' has no attribute 'io'" reported in multiple tests
> --
>
> Key: CASSANDRA-18198
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18198
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Claude Warren
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 3.0.29, 3.11.15, 4.0.8, 4.1.1, 4.2
>
>
> {{title = 'Timeout'}}
> {{stream = <_io.TextIOWrapper name='' mode='w' encoding='utf-8'>}}
> {{{}sep = '+'{}}}{{{}def write_title(title, stream=None, sep="~"):{}}}
> {{{}"""Write a section title.{}}}{{{}If *stream* is None sys.stderr will be
> used, *sep* is used to{}}}
> {{draw the line.}}
> {{"""}}
> {{if stream is None:}}
> {{stream = sys.stderr}}
> {{> width = py.io.get_terminal_width()}}
> {{E AttributeError: module 'py' has no attribute 'io}}
>
> is reported in multiple tests as noted below.
> possibly a class loader issue associated with CASSANDRA-18150
> 4.1
> [https://ci-cassandra.apache.org/job/Cassandra-4.1/256/testReport/dtest-offheap.repair_tests.incremental_repair_test/TestIncRepair/test_multiple_full_repairs_lcs]
> 3.11
> [https://ci-cassandra.apache.org/job/Cassandra-3.11/424/testReport/dtest.bootstrap_test/TestBootstrap/test_simultaneous_bootstrap/]
> 3.0
> [https://ci-cassandra.apache.org/job/Cassandra-3.0/328/testReport/dtest-upgrade.upgrade_tests.upgrade_supercolumns_test/TestSCUpgrade/test_upgrade_super_columns_through_all_versions/]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17611) Fix replace_address_test.TestReplaceAddress.test_fail_when_seed
[
https://issues.apache.org/jira/browse/CASSANDRA-17611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
German Eichberger updated CASSANDRA-17611:
--
Resolution: (was: Fixed)
Status: Open (was: Resolved)
Butler:
Branch: trunk
Build: #1448
https://butler.cassandra.apache.org/#/ci/upstream/workflow/Cassandra-trunk/failure/replace_address_test/TestReplaceAddress/test_fail_when_seed
> Fix replace_address_test.TestReplaceAddress.test_fail_when_seed
> ---
>
> Key: CASSANDRA-17611
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17611
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 3.0.27, 3.11.13
>
>
> Seen
> [with|https://ci-cassandra.apache.org/job/Cassandra-3.11/349/testReport/dtest.replace_address_test/TestReplaceAddress/test_fail_when_seed/]
> and [without
> vnode|https://ci-cassandra.apache.org/job/Cassandra-3.11/348/testReport/dtest-novnode.replace_address_test/TestReplaceAddress/test_fail_when_seed/]:
> {code:java}
> Error Message
> test teardown failure
> Stacktrace
> Unexpected error found in node logs (see stdout for full details). Errors:
> [ERROR [MessagingService-Incoming-/127.0.0.1] 2022-04-28 22:04:36,765
> CassandraDaemon.java:244 - Exception in thread
> Thread[MessagingService-Incoming-/127.0.0.1,5,main]
> java.util.concurrent.RejectedExecutionException: ThreadPoolExecutor has shut
> down at
> org.apache.cassandra.concurrent.DebuggableThreadPoolExecutor$1.rejectedExecution(DebuggableThreadPoolExecutor.java:58)
> at
> java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:830)
> at
> java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1379)
> at
> org.apache.cassandra.concurrent.DebuggableThreadPoolExecutor.execute(DebuggableThreadPoolExecutor.java:148)
> at
> org.apache.cassandra.net.MessagingService.receive(MessagingService.java:1035)
> at
> org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:215)
> at
> org.apache.cassandra.net.IncomingTcpConnection.receiveMessages(IncomingTcpConnection.java:195)
> at
> org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:98),
> ERROR [MessagingService-Incoming-/127.0.0.1] 2022-04-28 22:04:36,765
> CassandraDaemon.java:244 - Exception in thread
> Thread[MessagingService-Incoming-/127.0.0.1,5,main]
> java.util.concurrent.RejectedExecutionException: ThreadPoolExecutor has shut
> down at
> org.apache.cassandra.concurrent.DebuggableThreadPoolExecutor$1.rejectedExecution(DebuggableThreadPoolExecutor.java:58)
> at
> java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:830)
> at
> java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1379)
> at
> org.apache.cassandra.concurrent.DebuggableThreadPoolExecutor.execute(DebuggableThreadPoolExecutor.java:148)
> at
> org.apache.cassandra.net.MessagingService.receive(MessagingService.java:1035)
> at
> org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:215)
> at
> org.apache.cassandra.net.IncomingTcpConnection.receiveMessages(IncomingTcpConnection.java:195)
> at
> org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:98)]
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18198) "AttributeError: module 'py' has no attribute 'io'" reported in multiple tests
[
https://issues.apache.org/jira/browse/CASSANDRA-18198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
German Eichberger updated CASSANDRA-18198:
--
Resolution: (was: Fixed)
Status: Open (was: Resolved)
Butler:
https://butler.cassandra.apache.org/#/ci/upstream/workflow/Cassandra-4.0/failure/bootstrap_test/TestBootstrap/test_simultaneous_bootstrap
> "AttributeError: module 'py' has no attribute 'io'" reported in multiple tests
> --
>
> Key: CASSANDRA-18198
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18198
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Claude Warren
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 3.0.29, 3.11.15, 4.0.8, 4.1.1, 4.2
>
>
> {{title = 'Timeout'}}
> {{stream = <_io.TextIOWrapper name='' mode='w' encoding='utf-8'>}}
> {{{}sep = '+'{}}}{{{}def write_title(title, stream=None, sep="~"):{}}}
> {{{}"""Write a section title.{}}}{{{}If *stream* is None sys.stderr will be
> used, *sep* is used to{}}}
> {{draw the line.}}
> {{"""}}
> {{if stream is None:}}
> {{stream = sys.stderr}}
> {{> width = py.io.get_terminal_width()}}
> {{E AttributeError: module 'py' has no attribute 'io}}
>
> is reported in multiple tests as noted below.
> possibly a class loader issue associated with CASSANDRA-18150
> 4.1
> [https://ci-cassandra.apache.org/job/Cassandra-4.1/256/testReport/dtest-offheap.repair_tests.incremental_repair_test/TestIncRepair/test_multiple_full_repairs_lcs]
> 3.11
> [https://ci-cassandra.apache.org/job/Cassandra-3.11/424/testReport/dtest.bootstrap_test/TestBootstrap/test_simultaneous_bootstrap/]
> 3.0
> [https://ci-cassandra.apache.org/job/Cassandra-3.0/328/testReport/dtest-upgrade.upgrade_tests.upgrade_supercolumns_test/TestSCUpgrade/test_upgrade_super_columns_through_all_versions/]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17979) Fix flaky test:org.apache.cassandra.net.HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades
[
https://issues.apache.org/jira/browse/CASSANDRA-17979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684833#comment-17684833
]
Brandon Williams commented on CASSANDRA-17979:
--
I agree with your analysis. This only affects trunk since the test was added
as part of CASSANDRA-17923.
||Branch||CI||
|[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-17979-trunk]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/853/workflows/5439b983-4b50-41a3-9cf9-2def4f6cda00],
[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/853/workflows/4b689d33-6688-4c6a-9531-984ba07facc7]|
> Fix flaky
> test:org.apache.cassandra.net.HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades
> ---
>
> Key: CASSANDRA-17979
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17979
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Internode
>Reporter: Brandon Williams
>Assignee: Derek Chen-Becker
>Priority: Normal
> Fix For: 4.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1339/testReport/org.apache.cassandra.net/HandshakeTest/testOutboundConnectionfFallbackDuringUpgrades_cdc/
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1336/testReport/org.apache.cassandra.net/HandshakeTest/testOutboundConnectionfFallbackDuringUpgrades_compression/
> https://app.circleci.com/pipelines/github/instaclustr/cassandra/1466/workflows/ffb52616-92d7-4089-a0c9-a9ebf28333c0/jobs/6296/tests
> {noformat}
> junit.framework.AssertionFailedError
> at
> org.apache.cassandra.net.HandshakeTest.testOutboundFallbackOnSSLHandshakeFailure(HandshakeTest.java:384)
> at
> org.apache.cassandra.net.HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades(HandshakeTest.java:243)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17979) Fix flaky test:org.apache.cassandra.net.HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades
[
https://issues.apache.org/jira/browse/CASSANDRA-17979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-17979:
-
Reviewers: Brandon Williams, Brandon Williams
Brandon Williams, Brandon Williams (was: Brandon Williams)
Status: Review In Progress (was: Patch Available)
> Fix flaky
> test:org.apache.cassandra.net.HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades
> ---
>
> Key: CASSANDRA-17979
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17979
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Internode
>Reporter: Brandon Williams
>Assignee: Derek Chen-Becker
>Priority: Normal
> Fix For: 4.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1339/testReport/org.apache.cassandra.net/HandshakeTest/testOutboundConnectionfFallbackDuringUpgrades_cdc/
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1336/testReport/org.apache.cassandra.net/HandshakeTest/testOutboundConnectionfFallbackDuringUpgrades_compression/
> https://app.circleci.com/pipelines/github/instaclustr/cassandra/1466/workflows/ffb52616-92d7-4089-a0c9-a9ebf28333c0/jobs/6296/tests
> {noformat}
> junit.framework.AssertionFailedError
> at
> org.apache.cassandra.net.HandshakeTest.testOutboundFallbackOnSSLHandshakeFailure(HandshakeTest.java:384)
> at
> org.apache.cassandra.net.HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades(HandshakeTest.java:243)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18223) Byteman rule in stop_data_reads.btm cannot compile against accord.messages.ReplyContext
[
https://issues.apache.org/jira/browse/CASSANDRA-18223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684824#comment-17684824
]
Caleb Rackliffe commented on CASSANDRA-18223:
-
Once the sub-module is in place, I think the easiest way to fix this is going
to be adding the following to {{byteman_validate}}:
{noformat}
if os.path.exists(os.path.join(cdir, 'accordz')):
jars.append(glob.glob(os.path.join(cdir, 'accord', 'accord-core',
'build', 'libs', 'accord-core-[0-9].[0-9]-SNAPSHOT.jar'))[0])
{noformat}
CC [~dcapwell]
> Byteman rule in stop_data_reads.btm cannot compile against
> accord.messages.ReplyContext
> ---
>
> Key: CASSANDRA-18223
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18223
> Project: Cassandra
> Issue Type: Bug
> Components: Accord
>Reporter: Caleb Rackliffe
>Assignee: Caleb Rackliffe
>Priority: Normal
> Labels: byteman, dtest, python
> Fix For: NA
>
>
> The Python {{read_repair_test}} relies on a Byteman rule on the {{doVerb()}}
> method in {{ReadCommandVerbHandler}}, but {{accord.messages.ReplyContext}}
> isn’t on the classpath. This is probably because we don't include it in the
> list of jars created in {{byteman_validate}}.
> {noformat}
> AssertionError: byteman script didn't compile
> Checking rule disable data reads against class
> org.apache.cassandra.db.ReadCommandVerbHandler
> Parsed rule "disable data reads" for class
> org.apache.cassandra.db.ReadCommandVerbHandler
> ERROR : Failed to check rule "disable data reads" loaded from
> /home/cassandra/cassandra-dtest/byteman/read_repair/stop_data_reads.btm line
> 8 against method doVerb(org.apache.cassandra.net.Message) void
> java.lang.NoClassDefFoundError: accord/messages/ReplyContext
> {noformat}
> ex.
> https://app.circleci.com/pipelines/github/maedhroz/cassandra/686/workflows/ffd1e528-b8ec-4534-a333-ab450e110e89/jobs/6481/tests#failed-test-0
> It might make sense to fix this after CASSANDRA-18204 wraps up, so we know
> exactly how the Accord library is pulled into C*. Then, once we do fix it, we
> should fix in a way that still works w/ 4.0 and 4.1, etc. (i.e. Don't assume
> the Accord library must be present.)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17979) Fix flaky test:org.apache.cassandra.net.HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades
[
https://issues.apache.org/jira/browse/CASSANDRA-17979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Derek Chen-Becker updated CASSANDRA-17979:
--
Test and Documentation Plan:
Tested in CircleCI and locally with multiple runs and I no longer hit the error
encountered.
https://github.com/apache/cassandra/pull/2143
Status: Patch Available (was: Open)
> Fix flaky
> test:org.apache.cassandra.net.HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades
> ---
>
> Key: CASSANDRA-17979
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17979
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Internode
>Reporter: Brandon Williams
>Assignee: Derek Chen-Becker
>Priority: Normal
> Fix For: 4.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1339/testReport/org.apache.cassandra.net/HandshakeTest/testOutboundConnectionfFallbackDuringUpgrades_cdc/
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1336/testReport/org.apache.cassandra.net/HandshakeTest/testOutboundConnectionfFallbackDuringUpgrades_compression/
> https://app.circleci.com/pipelines/github/instaclustr/cassandra/1466/workflows/ffb52616-92d7-4089-a0c9-a9ebf28333c0/jobs/6296/tests
> {noformat}
> junit.framework.AssertionFailedError
> at
> org.apache.cassandra.net.HandshakeTest.testOutboundFallbackOnSSLHandshakeFailure(HandshakeTest.java:384)
> at
> org.apache.cassandra.net.HandshakeTest.testOutboundConnectionfFallbackDuringUpgrades(HandshakeTest.java:243)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18179) Update build.xml for experimental JDK17 use
[ https://issues.apache.org/jira/browse/CASSANDRA-18179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684803#comment-17684803 ] Ekaterina Dimitrova commented on CASSANDRA-18179: - Thanks, do we want to open a separate thread dedicated to JDK 17 where we state the exact steps we propose to do it and introduce this ticket? I can do it but wasn't sure what is your plan at this point. Thanks > Update build.xml for experimental JDK17 use > --- > > Key: CASSANDRA-18179 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18179 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 4.x > > > To support JDK17 we need to make changes to build.xml and our scripts. There > is a preliminary patch which makes a switch from JDK8+JDK11 to JDK11+JDK17 > but it will need a change considering CASSANDRA-18133 > CC [~mck] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18135) Accord: transition Node.Id from long to int
[ https://issues.apache.org/jira/browse/CASSANDRA-18135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684792#comment-17684792 ] Benedict Elliott Smith commented on CASSANDRA-18135: Yep. CEP-21 should in fact allow us to keep it to 16 bits or less in most clusters. > Accord: transition Node.Id from long to int > --- > > Key: CASSANDRA-18135 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18135 > Project: Cassandra > Issue Type: Improvement > Components: Accord >Reporter: Aleksey Yeschenko >Assignee: Aleksey Yeschenko >Priority: Normal > Fix For: 4.2 > > > Trimmed down version of the patch, swapping long for int, but still keeping > Node.Id class. Delaying the rest (elimination of Node.Id as a class) until > immutability work lands, to ease rebase pain. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18135) Accord: transition Node.Id from long to int
[ https://issues.apache.org/jira/browse/CASSANDRA-18135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684791#comment-17684791 ] Jacek Lewandowski commented on CASSANDRA-18135: --- So what is the plan for id - is going to stay 32bit? > Accord: transition Node.Id from long to int > --- > > Key: CASSANDRA-18135 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18135 > Project: Cassandra > Issue Type: Improvement > Components: Accord >Reporter: Aleksey Yeschenko >Assignee: Aleksey Yeschenko >Priority: Normal > Fix For: 4.2 > > > Trimmed down version of the patch, swapping long for int, but still keeping > Node.Id class. Delaying the rest (elimination of Node.Id as a class) until > immutability work lands, to ease rebase pain. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18001) Add missing tests suites to CircleCI
[
https://issues.apache.org/jira/browse/CASSANDRA-18001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684780#comment-17684780
]
Andres de la Peña commented on CASSANDRA-18001:
---
{quote}PS I opted out of raising the repeated jobs containers to XLarge, only
when we run the whole suite. I think we can leave a comment in the docs that
for those two people will need more resources.
{quote}
So the regular jobs use xlarge, and the repeated job still uses large. Works
for me. There could be a brief comment on [the {{REPEATED_LARGE_DTESTS}} env
var|https://github.com/apache/cassandra/blob/73f6098d012169a0ce18000ef73454291cd036f6/.circleci/config-2_1.yml#L91-L96]
mentioning that those two tests won't work on the multiplexer.
Also, one of the tests that won't work with the multiplexer,
{{{}test_network_topology_strategy{}}}, is used as an example value of
{{REPEATED_LARGE_DTESTS}} in
[{{config-2_1.yml}}|https://github.com/apache/cassandra/blob/73f6098d012169a0ce18000ef73454291cd036f6/.circleci/config-2_1.yml#L94],
[{{generate.sh}}|https://github.com/apache/cassandra/blob/73f6098d012169a0ce18000ef73454291cd036f6/.circleci/generate.sh#L54]
and {{{}readme.md{}}}. If we are going to special case them to save us the
executor we should probably choose a test that actually works as an example of
a valid value for {{{}REPEATED_LARGE_DTESTS{}}}.
Other than that the changes look good to me.
> Add missing tests suites to CircleCI
>
>
> Key: CASSANDRA-18001
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18001
> Project: Cassandra
> Issue Type: Task
> Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Urgent
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1-rc1, 4.1, 4.1.x, 4.2, 4.x
>
>
> Burn tests to all branches, large Python DTests (with/without vnodes),
> cqlshlib not tested in all branches and with all jdks; Java distributed tests
> not running with J8/J11 4.0+
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18238) Implicitly enable ALLOW FILTERING on virtual tables
[ https://issues.apache.org/jira/browse/CASSANDRA-18238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684755#comment-17684755 ] Aleksey Yeschenko commented on CASSANDRA-18238: --- +1 > Implicitly enable ALLOW FILTERING on virtual tables > --- > > Key: CASSANDRA-18238 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18238 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Virtual Tables >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > Ticket to track work / discussion of this thread (1) > (1) https://lists.apache.org/thread/104fld746d6qtggq5132n3hqtjqqpkjp -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18239) Remove eclipse warnings task
[
https://issues.apache.org/jira/browse/CASSANDRA-18239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684749#comment-17684749
]
Jacek Lewandowski commented on CASSANDRA-18239:
---
cc [~mck]
> Remove eclipse warnings task
>
>
> Key: CASSANDRA-18239
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18239
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Jacek Lewandowski
>Priority: Normal
>
> Eclipse warnings is used for static code analysis. However, it does not fit
> well into Cassandra code and practically we end up explicitly adding
> suppressions in many places just to satisfy that tool rather than fix the
> real issues.
> This is an incomplete list of reasons to remove it:
> - not closed resources are detected incorrectly
> - does not recognize custom utility methods used to close the resources,
> which use use heavily in the code, like {{Throwables.close}},
> {{FileUtils.close}}, {{closeQuietly}}...
> - because of the above, we cannot make important things like {{Ref}} to
> implement {{Closeable}} as it would make the tool to explode with tons of
> warnings
> - it complains about correct generics - something like "method X is not
> applicable for ..." when the code compiles successfully is not acceptable
> - it is old and not maintained
> There are better tools like IntelliJ inspections for example, which can also
> be run in headless mode
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15254) Allow UPDATE on settings virtual table to change running configurations
[
https://issues.apache.org/jira/browse/CASSANDRA-15254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684732#comment-17684732
]
Maxim Muzafarov commented on CASSANDRA-15254:
-
[~blerer]
{quote}Just to make sure that we have all the same understanding. The plan is
only to allow setting the properties that can be set dynamically today (which
is a small subset of the properties), right? I have not checked but it might be
possible that some setters or getters are actually not used by JMX.
{quote}
This is a good comment. Yes, we will provide the same guarantees here as we do
today - changing only those properties through the SettingsTable that can
already be updated at runtime. Let's focus on the set of properties that can be
altered with JMX and provide a user ability to change the same set of
properties with SettingsTable, leaving the rest of the changeable set of
properties to another patch.
{quote}I am simply not sure that it is feasible in practice as setting the
property is also often only a minor part of the logic involved in changing a
configuration. Configuration are often use at start up to initialize some C*
components and in case of configuration update that component somehow need to
be modified in a non generic way. Up to now that logic was performed in the
different JMX implementation classes. Each of them was usually setting the
config parameter and then updating the impacted component that they were
managing.
{quote}
If I have understood your concerns correctly, the case you are talking about is
also handled by this solution with the subscription mechanism for a property
change event in the Registry. These listeners cover all the cases:
{code:java}
void onBeforeChange(String propertyName, T oldValue, T newValue);
void onAfterChange(String propertyName, T oldValue, T newValue);
{code}
Did I get your point right?
I'd also like to clarify my term _"auto-generated classes"_ for better
understanding. Such classes based on DatabaseDescriptor/GuardrailsOptions
metadata will not be generated every time on build or at runtime. I plan to
provide a util class that will create a new class body that implements all the
necessary interfaces (SetterWalker, GetterWalker) that we rely on and will be
committed as a regular class to remove the manual work of coupling a property
name with its getter/setter methods.
> Allow UPDATE on settings virtual table to change running configurations
> ---
>
> Key: CASSANDRA-15254
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15254
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Virtual Tables
>Reporter: Chris Lohfink
>Assignee: Maxim Muzafarov
>Priority: Normal
> Attachments: Configuration Registry Diagram.png
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Allow using UPDATE on the system_views.settings virtual table to update
> configs at runtime for the equivalent of the dispersed JMX
> attributes/operations.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16718) Changing listen_address with prefer_local may lead to issues
[ https://issues.apache.org/jira/browse/CASSANDRA-16718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684731#comment-17684731 ] Maciej Sokol commented on CASSANDRA-16718: -- There's a Jira for the handshake being flaky CASSANDRA-17979 > Changing listen_address with prefer_local may lead to issues > > > Key: CASSANDRA-16718 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16718 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Jan Karlsson >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.11.x, 4.0.x, 4.1.x, 4.x > > > Many container based solution function by assigning new listen_addresses when > nodes are stopped. Changing the listen_address is usually as simple as > turning off the node and changing the yaml file. > However, if prefer_local is enabled, I observed that nodes were unable to > join the cluster and fail with 'Unable to gossip with any seeds'. > Trace shows that the changing node will try to communicate with the existing > node but the response is never received. I assume it is because the existing > node attempts to communicate with the local address during the shadow round. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18135) Accord: transition Node.Id from long to int
[ https://issues.apache.org/jira/browse/CASSANDRA-18135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Yeschenko updated CASSANDRA-18135: -- Resolution: Fixed Status: Resolved (was: Triage Needed) > Accord: transition Node.Id from long to int > --- > > Key: CASSANDRA-18135 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18135 > Project: Cassandra > Issue Type: Improvement > Components: Accord >Reporter: Aleksey Yeschenko >Assignee: Aleksey Yeschenko >Priority: Normal > Fix For: 4.2 > > > Trimmed down version of the patch, swapping long for int, but still keeping > Node.Id class. Delaying the rest (elimination of Node.Id as a class) until > immutability work lands, to ease rebase pain. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cep-15-accord updated: Switch Node.Id from long to int
This is an automated email from the ASF dual-hosted git repository.
aleksey pushed a commit to branch cep-15-accord
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cep-15-accord by this push:
new 7abbb337de Switch Node.Id from long to int
7abbb337de is described below
commit 7abbb337dea6de3c28dca55f081fd476b8b7ef7c
Author: Aleksey Yeschenko
AuthorDate: Thu Feb 2 16:37:39 2023 +
Switch Node.Id from long to int
patch by Aleksey Yeschenko; reviewed by Benedict Elliott Smith for
CASSANDRA-18135
---
.build/include-accord.sh | 2 +-
.../cassandra/service/accord/AccordKeyspace.java | 6 +++---
.../cassandra/service/accord/EndpointMapping.java | 24 --
.../accord/serializers/TopologySerializers.java| 10 -
.../cassandra/service/accord/AccordTestUtils.java | 6 +++---
.../service/accord/EndpointMappingTest.java| 2 +-
.../serializers/TopologySerializersTest.java | 2 +-
7 files changed, 18 insertions(+), 34 deletions(-)
diff --git a/.build/include-accord.sh b/.build/include-accord.sh
index 5609ea0585..34ee959221 100755
--- a/.build/include-accord.sh
+++ b/.build/include-accord.sh
@@ -25,7 +25,7 @@ set -o nounset
bin="$(cd "$(dirname "$0")" > /dev/null; pwd)"
accord_repo='https://github.com/apache/cassandra-accord.git'
-accord_sha='0cc9e273b2eaa37d82a1ae1ac2681aec65aa0f6d'
+accord_sha='da77b744e4fdb5f39656e4269f4f1806e485c9c0'
accord_src="$bin/cassandra-accord"
_main() {
diff --git a/src/java/org/apache/cassandra/service/accord/AccordKeyspace.java
b/src/java/org/apache/cassandra/service/accord/AccordKeyspace.java
index 9148bb4311..6cd1d6dddf 100644
--- a/src/java/org/apache/cassandra/service/accord/AccordKeyspace.java
+++ b/src/java/org/apache/cassandra/service/accord/AccordKeyspace.java
@@ -122,8 +122,8 @@ public class AccordKeyspace
public static final String COMMANDS = "commands";
public static final String COMMANDS_FOR_KEY = "commands_for_key";
-private static final String TIMESTAMP_TUPLE = "tuple";
-private static final TupleType TIMESTAMP_TYPE = new
TupleType(Lists.newArrayList(LongType.instance, LongType.instance,
LongType.instance));
+private static final String TIMESTAMP_TUPLE = "tuple";
+private static final TupleType TIMESTAMP_TYPE = new
TupleType(Lists.newArrayList(LongType.instance, LongType.instance,
Int32Type.instance));
private static final String KEY_TUPLE = "tuple";
private static final ClusteringIndexFilter FULL_PARTITION = new
ClusteringIndexSliceFilter(Slices.ALL, false);
@@ -532,7 +532,7 @@ public class AccordKeyspace
if (bytes == null || ByteBufferAccessor.instance.isEmpty(bytes))
return null;
ByteBuffer[] split = TIMESTAMP_TYPE.split(ByteBufferAccessor.instance,
bytes);
-return factory.create(split[0].getLong(), split[1].getLong(), new
Node.Id(split[2].getLong()));
+return factory.create(split[0].getLong(), split[1].getLong(), new
Node.Id(split[2].getInt()));
}
private static T
deserializeTimestampOrNull(UntypedResultSet.Row row, String name,
TimestampFactory factory)
diff --git a/src/java/org/apache/cassandra/service/accord/EndpointMapping.java
b/src/java/org/apache/cassandra/service/accord/EndpointMapping.java
index 49717801a9..a863ca7410 100644
--- a/src/java/org/apache/cassandra/service/accord/EndpointMapping.java
+++ b/src/java/org/apache/cassandra/service/accord/EndpointMapping.java
@@ -25,6 +25,7 @@ import java.net.UnknownHostException;
import com.google.common.base.Preconditions;
import com.google.common.collect.ImmutableCollection;
import com.google.common.collect.ImmutableMap;
+import com.google.common.primitives.Ints;
import accord.local.Node;
import org.apache.cassandra.locator.InetAddressAndPort;
@@ -36,33 +37,16 @@ public class EndpointMapping
{
Preconditions.checkArgument(endpoint.getAddress() instanceof
Inet4Address);
Inet4Address address = (Inet4Address) endpoint.getAddress();
-byte[] bytes = address.getAddress();
-long id = 0;
-for (int i=0; i<4; i++)
-id = (id * 1000) + Byte.toUnsignedLong(bytes[i]);
-id = (id * 10) + endpoint.getPort();
+int id = Ints.fromByteArray(address.getAddress());
return new Node.Id(id);
}
static InetAddressAndPort idToEndpoint(Node.Id node)
{
-long id = node.id;
-Preconditions.checkArgument(id >= 0);
-
-int port = (int) (id % 10);
-id = id / 10;
-byte[] bytes = new byte[4];
-for (int i=0; i<4; i++)
-{
-long octet = id % 1000;
-Preconditions.checkArgument(octet >= 0 && octet <= 255, "Malformed
id");
-bytes[3-i] = (byte) (octet);
-id = id / 1000;
-}
-Preconditions.checkArgument(id == 0);
+byte[] bytes =
[cassandra-accord] branch trunk updated: Swap long for int inside Node.Id
This is an automated email from the ASF dual-hosted git repository.
aleksey pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-accord.git
The following commit(s) were added to refs/heads/trunk by this push:
new da77b74 Swap long for int inside Node.Id
da77b74 is described below
commit da77b744e4fdb5f39656e4269f4f1806e485c9c0
Author: Aleksey Yeschenko
AuthorDate: Tue Jan 31 16:02:37 2023 +
Swap long for int inside Node.Id
patch by Aleksey Yeschenko; reviewed by Benedict Elliott Smith for
CASSANDRA-18135
---
accord-core/build.gradle | 2 +-
.../src/main/java/accord/local/CommandStores.java | 8
accord-core/src/main/java/accord/local/Node.java | 14 ++
accord-core/src/main/java/accord/local/Status.java| 3 ++-
accord-core/src/main/java/accord/messages/Defer.java | 4 ++--
.../src/main/java/accord/utils/ArrayBuffers.java | 2 +-
.../verify/StrictSerializabilityVerifierTest.java | 19 +++
.../src/main/java/accord/maelstrom/Json.java | 4 ++--
8 files changed, 21 insertions(+), 35 deletions(-)
diff --git a/accord-core/build.gradle b/accord-core/build.gradle
index 146f9fa..32e1164 100644
--- a/accord-core/build.gradle
+++ b/accord-core/build.gradle
@@ -36,7 +36,7 @@ dependencies {
// Dependencies we depend on that are not part of our API.
// These act as runtimeOnly dependencies to users
implementation 'org.slf4j:slf4j-api:1.7.36'
-implementation 'com.carrotsearch:hppc:0.8.1'
+implementation 'org.agrona:agrona:1.17.1'
}
task burn(type: JavaExec) {
diff --git a/accord-core/src/main/java/accord/local/CommandStores.java
b/accord-core/src/main/java/accord/local/CommandStores.java
index 09ad0fc..467e23e 100644
--- a/accord-core/src/main/java/accord/local/CommandStores.java
+++ b/accord-core/src/main/java/accord/local/CommandStores.java
@@ -26,9 +26,9 @@ import accord.utils.MapReduce;
import accord.utils.MapReduceConsume;
import accord.utils.ReducingFuture;
-import com.carrotsearch.hppc.IntObjectMap;
-import com.carrotsearch.hppc.IntObjectScatterMap;
import com.google.common.annotations.VisibleForTesting;
+import org.agrona.collections.Hashing;
+import org.agrona.collections.Int2ObjectHashMap;
import org.apache.cassandra.utils.concurrent.Future;
import java.util.ArrayList;
@@ -200,14 +200,14 @@ public abstract class CommandStores
static class Snapshot
{
final ShardHolder[] shards;
-final IntObjectMap byId;
+final Int2ObjectHashMap byId;
final Topology local;
final Topology global;
Snapshot(ShardHolder[] shards, Topology local, Topology global)
{
this.shards = shards;
-this.byId = new IntObjectScatterMap<>(shards.length);
+this.byId = new Int2ObjectHashMap<>(shards.length,
Hashing.DEFAULT_LOAD_FACTOR, true);
for (ShardHolder shard : shards)
byId.put(shard.store.id(), shard.store);
this.local = local;
diff --git a/accord-core/src/main/java/accord/local/Node.java
b/accord-core/src/main/java/accord/local/Node.java
index 4ccc05c..70be03a 100644
--- a/accord-core/src/main/java/accord/local/Node.java
+++ b/accord-core/src/main/java/accord/local/Node.java
@@ -57,18 +57,16 @@ import net.nicoulaj.compilecommand.annotations.Inline;
import org.apache.cassandra.utils.concurrent.AsyncFuture;
import org.apache.cassandra.utils.concurrent.Future;
-import static accord.primitives.Routable.Domain.Key;
-
public class Node implements ConfigurationService.Listener, NodeTimeService
{
public static class Id implements Comparable
{
public static final Id NONE = new Id(0);
-public static final Id MAX = new Id(Long.MAX_VALUE);
+public static final Id MAX = new Id(Integer.MAX_VALUE);
-public final long id;
+public final int id;
-public Id(long id)
+public Id(int id)
{
this.id = id;
}
@@ -76,7 +74,7 @@ public class Node implements ConfigurationService.Listener,
NodeTimeService
@Override
public int hashCode()
{
-return Long.hashCode(id);
+return Integer.hashCode(id);
}
@Override
@@ -93,12 +91,12 @@ public class Node implements ConfigurationService.Listener,
NodeTimeService
@Override
public int compareTo(Id that)
{
-return Long.compare(this.id, that.id);
+return Integer.compare(this.id, that.id);
}
public String toString()
{
-return Long.toString(id);
+return Integer.toString(id);
}
}
diff --git a/accord-core/src/main/java/accord/local/Status.java
b/accord-core/src/main/java/accord/local/Status.java
index 158bb89..98e9e23 100644
--- a/accord-core/src/main/java/accord/local/Status.java
[jira] [Updated] (CASSANDRA-18070) Add a new SELECT_MASKED permission
[
https://issues.apache.org/jira/browse/CASSANDRA-18070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-18070:
--
Change Category: Semantic
Complexity: Normal
Assignee: Andres de la Peña
Status: Open (was: Triage Needed)
> Add a new SELECT_MASKED permission
> --
>
> Key: CASSANDRA-18070
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18070
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Dynamic Data Masking
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
>
> Add a table-level SELECT_MASKED permission allowing certain users to query
> but not see the unmasked columns introduced by CASSANDRA-18068, assuming that
> they also have the SELECT permission on the table, as defined by
> [CEP-20|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-20%3A+Dynamic+Data+Masking].
>
> It would look like:
> {code}
> > CREATE USER unprivileged_user WITH PASSWORD 'xyz';
> > CREATE USER privileged_user WITH PASSWORD 'zyx';
>
> > GRANT SELECT ON ALL TABLE patients TO unprivileged_user;
> > GRANT SELECT ON ALL TABLE patients TO privileged_user;
> > GRANT SELECT_MASKED ON ALL TABLE patients TO privileged_user;
>
> > LOGIN unprivileged_user
> > SELECT name, birth FROM patients WHERE name='alice' ALLOW FILTERING;
>
> Unauthorized: Error from server: code=2100 [Unauthorized] message="User has
> no UNMASK nor SELECT_UNMASK permission on "
>
> > LOGIN privileged_user
> > SELECT name, birth FROM patients WHERE name='alice' ALLOW FILTERING;
>
> name| birth
> -+
> ale | 1900-01-01
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18239) Remove eclipse warnings task
[
https://issues.apache.org/jira/browse/CASSANDRA-18239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684680#comment-17684680
]
Jacek Lewandowski commented on CASSANDRA-18239:
---
another stupid example:
This is reported:
{code:java}
return reversed
? new SSTableReversedIterator(this, file, key, indexEntry,
slices, selectedColumns, ifile)
: new SSTableIterator(this, file, key, indexEntry, slices,
selectedColumns, ifile);
{code}
and this is not reported:
{code:java}
if (reversed) {
return new SSTableReversedIterator(this, file, key, indexEntry,
slices, selectedColumns, ifile);
} else {
return new SSTableIterator(this, file, key, indexEntry, slices,
selectedColumns, ifile);
}
{code}
> Remove eclipse warnings task
>
>
> Key: CASSANDRA-18239
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18239
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Jacek Lewandowski
>Priority: Normal
>
> Eclipse warnings is used for static code analysis. However, it does not fit
> well into Cassandra code and practically we end up explicitly adding
> suppressions in many places just to satisfy that tool rather than fix the
> real issues.
> This is an incomplete list of reasons to remove it:
> - not closed resources are detected incorrectly
> - does not recognize custom utility methods used to close the resources,
> which use use heavily in the code, like {{Throwables.close}},
> {{FileUtils.close}}, {{closeQuietly}}...
> - because of the above, we cannot make important things like {{Ref}} to
> implement {{Closeable}} as it would make the tool to explode with tons of
> warnings
> - it complains about correct generics - something like "method X is not
> applicable for ..." when the code compiles successfully is not acceptable
> - it is old and not maintained
> There are better tools like IntelliJ inspections for example, which can also
> be run in headless mode
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18239) Remove eclipse warnings task
[
https://issues.apache.org/jira/browse/CASSANDRA-18239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684676#comment-17684676
]
Jacek Lewandowski commented on CASSANDRA-18239:
---
Perhaps something like
https://www.jetbrains.com/help/qodana/about-qodana.html#Qodana+playground
Anyway, for now, eclipse-warnings currently fail my build with an error like
{{is not applicable for the arguments}} for the correctly compiling code. That
cannot be suppressed because this is not a warning - this is a bug in
eclipse-warnings so that it cannot understand generics.
> Remove eclipse warnings task
>
>
> Key: CASSANDRA-18239
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18239
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Jacek Lewandowski
>Priority: Normal
>
> Eclipse warnings is used for static code analysis. However, it does not fit
> well into Cassandra code and practically we end up explicitly adding
> suppressions in many places just to satisfy that tool rather than fix the
> real issues.
> This is an incomplete list of reasons to remove it:
> - not closed resources are detected incorrectly
> - does not recognize custom utility methods used to close the resources,
> which use use heavily in the code, like {{Throwables.close}},
> {{FileUtils.close}}, {{closeQuietly}}...
> - because of the above, we cannot make important things like {{Ref}} to
> implement {{Closeable}} as it would make the tool to explode with tons of
> warnings
> - it complains about correct generics - something like "method X is not
> applicable for ..." when the code compiles successfully is not acceptable
> - it is old and not maintained
> There are better tools like IntelliJ inspections for example, which can also
> be run in headless mode
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18239) Remove eclipse warnings task
[
https://issues.apache.org/jira/browse/CASSANDRA-18239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684664#comment-17684664
]
Benedict Elliott Smith commented on CASSANDRA-18239:
I've found it is on the whole pretty useful? There aren't many errant
suppressions. If we are to remove it, we should ensure we replace it with an
equivalent suite of checks that are maintained.
> Remove eclipse warnings task
>
>
> Key: CASSANDRA-18239
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18239
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Jacek Lewandowski
>Priority: Normal
>
> Eclipse warnings is used for static code analysis. However, it does not fit
> well into Cassandra code and practically we end up explicitly adding
> suppressions in many places just to satisfy that tool rather than fix the
> real issues.
> This is an incomplete list of reasons to remove it:
> - not closed resources are detected incorrectly
> - does not recognize custom utility methods used to close the resources,
> which use use heavily in the code, like {{Throwables.close}},
> {{FileUtils.close}}, {{closeQuietly}}...
> - because of the above, we cannot make important things like {{Ref}} to
> implement {{Closeable}} as it would make the tool to explode with tons of
> warnings
> - it complains about correct generics - something like "method X is not
> applicable for ..." when the code compiles successfully is not acceptable
> - it is old and not maintained
> There are better tools like IntelliJ inspections for example, which can also
> be run in headless mode
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18239) Remove eclipse warnings task
Jacek Lewandowski created CASSANDRA-18239:
-
Summary: Remove eclipse warnings task
Key: CASSANDRA-18239
URL: https://issues.apache.org/jira/browse/CASSANDRA-18239
Project: Cassandra
Issue Type: Task
Components: Build
Reporter: Jacek Lewandowski
Eclipse warnings is used for static code analysis. However, it does not fit
well into Cassandra code and practically we end up explicitly adding
suppressions in many places just to satisfy that tool rather than fix the real
issues.
This is an incomplete list of reasons to remove it:
- not closed resources are detected incorrectly
- does not recognize custom utility methods used to close the resources, which
use use heavily in the code, like {{Throwables.close}}, {{FileUtils.close}},
{{closeQuietly}}...
- because of the above, we cannot make important things like {{Ref}} to
implement {{Closeable}} as it would make the tool to explode with tons of
warnings
- it complains about correct generics - something like "method X is not
applicable for ..." when the code compiles successfully is not acceptable
- it is old and not maintained
There are better tools like IntelliJ inspections for example, which can also be
run in headless mode
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18238) Implicitly enable ALLOW FILTERING on virtual tables
[ https://issues.apache.org/jira/browse/CASSANDRA-18238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684655#comment-17684655 ] Aleksey Yeschenko commented on CASSANDRA-18238: --- It doesn't need to be a table param and doesn't need to be put in schema. > Implicitly enable ALLOW FILTERING on virtual tables > --- > > Key: CASSANDRA-18238 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18238 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Virtual Tables >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > Ticket to track work / discussion of this thread (1) > (1) https://lists.apache.org/thread/104fld746d6qtggq5132n3hqtjqqpkjp -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18238) Implicitly enable ALLOW FILTERING on virtual tables
[ https://issues.apache.org/jira/browse/CASSANDRA-18238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684632#comment-17684632 ] Stefan Miklosovic edited comment on CASSANDRA-18238 at 2/6/23 12:51 PM: [~aleksey] Where do you suggest I should put that in? I would need to create a custom field just for this which would inflate the schema. Are you OK with that? We would then need to ensure that it is not possible to change it by user by ALTER command. EDIT: disregard my comment, please, I confused two concepts here. I ll try to model it with an additional field in TableMetadata. EDIT 2: actually, no ... how I understand it is that in order to let user know how that flag looks like, it would need to be among TableParams and we would need to deal with that in SchemaKeyspace etc ... So it does make schema bigger because of that. was (Author: smiklosovic): [~aleksey] Where do you suggest I should put that in? I would need to create a custom field just for this which would inflate the schema. Are you OK with that? We would then need to ensure that it is not possible to change it by user by ALTER command. EDIT: disregard my comment, please, I confused two concepts here. I ll try to model it with an additional field in TableMetadata. > Implicitly enable ALLOW FILTERING on virtual tables > --- > > Key: CASSANDRA-18238 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18238 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Virtual Tables >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > Ticket to track work / discussion of this thread (1) > (1) https://lists.apache.org/thread/104fld746d6qtggq5132n3hqtjqqpkjp -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18238) Implicitly enable ALLOW FILTERING on virtual tables
[ https://issues.apache.org/jira/browse/CASSANDRA-18238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684632#comment-17684632 ] Stefan Miklosovic edited comment on CASSANDRA-18238 at 2/6/23 12:49 PM: [~aleksey] Where do you suggest I should put that in? I would need to create a custom field just for this which would inflate the schema. Are you OK with that? We would then need to ensure that it is not possible to change it by user by ALTER command. EDIT: disregard my comment, please, I confused two concepts here. I ll try to model it with an additional field in TableMetadata. was (Author: smiklosovic): [~aleksey] Where do you suggest I should put that in? I would need to create a custom field just for this which would inflate the schema. Are you OK with that? We would then need to ensure that it is not possible to change it by user by ALTER command. > Implicitly enable ALLOW FILTERING on virtual tables > --- > > Key: CASSANDRA-18238 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18238 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Virtual Tables >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > Ticket to track work / discussion of this thread (1) > (1) https://lists.apache.org/thread/104fld746d6qtggq5132n3hqtjqqpkjp -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18219) Warning message on aggregation queries doesn't specify table name or aggregate type
[
https://issues.apache.org/jira/browse/CASSANDRA-18219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684636#comment-17684636
]
Stefan Miklosovic commented on CASSANDRA-18219:
---
[~bschoeni] warn or debug? Now it is "debug". Making it "warn" would simplify
the PR even more as we would not need to introduce DEBUG level for NoSpamLogger.
> Warning message on aggregation queries doesn't specify table name or
> aggregate type
> ---
>
> Key: CASSANDRA-18219
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18219
> Project: Cassandra
> Issue Type: Improvement
> Components: Observability/Logging
>Reporter: Brad Schoening
>Assignee: Stefan Miklosovic
>Priority: Normal
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The existing aggregation query warning messages in cassandra.log from
> SelectStatement.java:
> _'[WARN] Aggregation query used without partition key'_
> {_}'{_}{_}[WARN]{_} _Aggregation query used on multiple partition keys
> (IN restriction)'_
> are missing the helpful details which would assist users in quickly
> identifying the offending query. The table name and type of aggregation would
> be useful additions in the WARN message.
> In addition, following the example of the slow query logger and printing out
> the query string at DEBUG level would be especially helpful.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14227) Extend maximum expiration date
[
https://issues.apache.org/jira/browse/CASSANDRA-14227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Adamson updated CASSANDRA-14227:
-
Reviewers: Mike Adamson, Mike Adamson
Mike Adamson, Mike Adamson (was: Mike Adamson)
Status: Review In Progress (was: Patch Available)
> Extend maximum expiration date
> --
>
> Key: CASSANDRA-14227
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14227
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Local Write-Read Paths
>Reporter: Paulo Motta (Deprecated)
>Assignee: Berenguer Blasi
>Priority: Urgent
> Fix For: 4.x
>
> Attachments: screenshot-1.png, screenshot-2.png, screenshot-3.png,
> screenshot-4.png, unnamed-1.png
>
>
> The maximum expiration timestamp that can be represented by the storage
> engine is
> 2038-01-19T03:14:06+00:00 due to the encoding of {{localExpirationTime}} as
> an int32.
> On CASSANDRA-14092 we added an overflow policy which rejects requests with
> expiration above the maximum date as a temporary measure, but we should
> remove this limitation by updating the storage engine to support at least the
> maximum allowed TTL of 20 years.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18238) Implicitly enable ALLOW FILTERING on virtual tables
[ https://issues.apache.org/jira/browse/CASSANDRA-18238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684632#comment-17684632 ] Stefan Miklosovic commented on CASSANDRA-18238: --- [~aleksey] Where do you suggest I should put that in? I would need to create a custom field just for this which would inflate the schema. Are you OK with that? > Implicitly enable ALLOW FILTERING on virtual tables > --- > > Key: CASSANDRA-18238 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18238 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Virtual Tables >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > Ticket to track work / discussion of this thread (1) > (1) https://lists.apache.org/thread/104fld746d6qtggq5132n3hqtjqqpkjp -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18238) Implicitly enable ALLOW FILTERING on virtual tables
[ https://issues.apache.org/jira/browse/CASSANDRA-18238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684632#comment-17684632 ] Stefan Miklosovic edited comment on CASSANDRA-18238 at 2/6/23 12:34 PM: [~aleksey] Where do you suggest I should put that in? I would need to create a custom field just for this which would inflate the schema. Are you OK with that? We would then need to ensure that it is not possible to change it by user by ALTER command. was (Author: smiklosovic): [~aleksey] Where do you suggest I should put that in? I would need to create a custom field just for this which would inflate the schema. Are you OK with that? > Implicitly enable ALLOW FILTERING on virtual tables > --- > > Key: CASSANDRA-18238 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18238 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Virtual Tables >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > Ticket to track work / discussion of this thread (1) > (1) https://lists.apache.org/thread/104fld746d6qtggq5132n3hqtjqqpkjp -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18238) Implicitly enable ALLOW FILTERING on virtual tables
[ https://issues.apache.org/jira/browse/CASSANDRA-18238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684631#comment-17684631 ] Aleksey Yeschenko commented on CASSANDRA-18238: --- Comment param is not there to encode arbitrary attributes, let's not hijack that field, please. > Implicitly enable ALLOW FILTERING on virtual tables > --- > > Key: CASSANDRA-18238 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18238 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Virtual Tables >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > Ticket to track work / discussion of this thread (1) > (1) https://lists.apache.org/thread/104fld746d6qtggq5132n3hqtjqqpkjp -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18238) Implicitly enable ALLOW FILTERING on virtual tables
[ https://issues.apache.org/jira/browse/CASSANDRA-18238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684614#comment-17684614 ] Stefan Miklosovic edited comment on CASSANDRA-18238 at 2/6/23 12:03 PM: I made it via TableMetadata. Doing it through that is quite handy as there is the construction of comment for DESCRIBE which adds the information to the comment in case it is not possible to filter on it. >From the mailing list, there might be cases when we do not want a virtual >table to be implicitly allowed to be filtered on so this might result in a >situation when some vtables are allowed and some disallowed. Operators should >have some possibility to know what tables are allowed and what disallowed. As >we do not want to have another table schema parameter (we would eventually >need to propagate via gossip etc), I just included this information in tables >comment for vtables. By default, vtables will be implicitly allowed to be filtered on if that flag is not set to false. Normal tables will never be able to be implicitly allowed to be filtered on. [https://github.com/apache/cassandra/pull/2142] was (Author: smiklosovic): I made it via TableMetadata. Doing it through that is quite handy as there is the construction of comment for DESCRIBE which adds the information to the comment in case it is not possible to filter on it. By default, vtables will be implicitly allowed to be filtered on if that flag is not set to false. Normal tables will never be able to be implicitly allowed to be filtered on. [https://github.com/apache/cassandra/pull/2142] > Implicitly enable ALLOW FILTERING on virtual tables > --- > > Key: CASSANDRA-18238 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18238 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Virtual Tables >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > Ticket to track work / discussion of this thread (1) > (1) https://lists.apache.org/thread/104fld746d6qtggq5132n3hqtjqqpkjp -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18238) Implicitly enable ALLOW FILTERING on virtual tables
[ https://issues.apache.org/jira/browse/CASSANDRA-18238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684614#comment-17684614 ] Stefan Miklosovic edited comment on CASSANDRA-18238 at 2/6/23 11:56 AM: I made it via TableMetadata. Doing it through that is quite handy as there is the construction of comment for DESCRIBE which adds the information to the comment in case it is not possible to filter on it. By default, vtables will be implicitly allowed to be filtered on if that flag is not set to false. Normal tables will never be able to be implicitly allowed to be filtered on. [https://github.com/apache/cassandra/pull/2142] was (Author: smiklosovic): I made it via TableMetadata. Doing it through that is quite handy as there is the construction of comment for DESCRIBE which tells if that vtable is implicitly allowed to be filtered on or not. By default, vtables will be implicitly allowed to be filtered on if that flag is not set to false. Normal tables will never be able to be implicitly allowed to be filtered on. [https://github.com/apache/cassandra/pull/2142] > Implicitly enable ALLOW FILTERING on virtual tables > --- > > Key: CASSANDRA-18238 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18238 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Virtual Tables >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > Ticket to track work / discussion of this thread (1) > (1) https://lists.apache.org/thread/104fld746d6qtggq5132n3hqtjqqpkjp -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18177) Support AbstractCompositeType with toJSONString method
[ https://issues.apache.org/jira/browse/CASSANDRA-18177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18177: - Change Category: Semantic Complexity: Normal Component/s: Local/SSTable Fix Version/s: 4.x Status: Open (was: Triage Needed) > Support AbstractCompositeType with toJSONString method > -- > > Key: CASSANDRA-18177 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18177 > Project: Cassandra > Issue Type: New Feature > Components: Local/SSTable >Reporter: maxwellguo >Assignee: Yong Jiang >Priority: Normal > Fix For: 4.x > > > As we know AbstractCompositeType do not support toJSONString method , but > some times > we do need this. > See the discusstion of > [CASSANDRA-17698|https://issues.apache.org/jira/browse/CASSANDRA-17698]. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18238) Implicitly enable ALLOW FILTERING on virtual tables
[ https://issues.apache.org/jira/browse/CASSANDRA-18238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684614#comment-17684614 ] Stefan Miklosovic edited comment on CASSANDRA-18238 at 2/6/23 11:55 AM: I made it via TableMetadata. Doing it through that is quite handy as there is the construction of comment for DESCRIBE which tells if that vtable is implicitly allowed to be filtered on or not. By default, vtables will be implicitly allowed to be filtered on if that flag is not set to false. Normal tables will never be able to be implicitly allowed to be filtered on. [https://github.com/apache/cassandra/pull/2142] was (Author: smiklosovic): I made it via TableMetadata. Doing it through that is quite handy as there is a construction of comment for DESCRIBE which tells if that vtable is implicitly allowed to be filtered on or not. By default, vtables will be implicitly allowed to be filtered on if that flag is not set to false. Normal tables will never be able to be implicitly allowed to be filtered on. [https://github.com/apache/cassandra/pull/2142] > Implicitly enable ALLOW FILTERING on virtual tables > --- > > Key: CASSANDRA-18238 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18238 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Virtual Tables >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > Ticket to track work / discussion of this thread (1) > (1) https://lists.apache.org/thread/104fld746d6qtggq5132n3hqtjqqpkjp -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18238) Implicitly enable ALLOW FILTERING on virtual tables
[ https://issues.apache.org/jira/browse/CASSANDRA-18238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684614#comment-17684614 ] Stefan Miklosovic edited comment on CASSANDRA-18238 at 2/6/23 11:55 AM: I made it via TableMetadata. Doing it through that is quite handy as there is a construction of comment for DESCRIBE which tells if that vtable is implicitly allowed to be filtered on or not. By default, vtables will be implicitly allowed to be filtered on if that flag is not set to false. Normal tables will never be able to be implicitly allowed to be filtered on. [https://github.com/apache/cassandra/pull/2142] was (Author: smiklosovic): https://github.com/apache/cassandra/pull/2142 > Implicitly enable ALLOW FILTERING on virtual tables > --- > > Key: CASSANDRA-18238 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18238 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Virtual Tables >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > Ticket to track work / discussion of this thread (1) > (1) https://lists.apache.org/thread/104fld746d6qtggq5132n3hqtjqqpkjp -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18238) Implicitly enable ALLOW FILTERING on virtual tables
[ https://issues.apache.org/jira/browse/CASSANDRA-18238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18238: -- Test and Documentation Plan: unit test will be added Status: Patch Available (was: Open) https://github.com/apache/cassandra/pull/2142 > Implicitly enable ALLOW FILTERING on virtual tables > --- > > Key: CASSANDRA-18238 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18238 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Virtual Tables >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > Ticket to track work / discussion of this thread (1) > (1) https://lists.apache.org/thread/104fld746d6qtggq5132n3hqtjqqpkjp -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18238) Implicitly enable ALLOW FILTERING on virtual tables
Stefan Miklosovic created CASSANDRA-18238: - Summary: Implicitly enable ALLOW FILTERING on virtual tables Key: CASSANDRA-18238 URL: https://issues.apache.org/jira/browse/CASSANDRA-18238 Project: Cassandra Issue Type: New Feature Components: Feature/Virtual Tables Reporter: Stefan Miklosovic Assignee: Stefan Miklosovic Ticket to track work / discussion of this thread (1) (1) https://lists.apache.org/thread/104fld746d6qtggq5132n3hqtjqqpkjp -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18238) Implicitly enable ALLOW FILTERING on virtual tables
[ https://issues.apache.org/jira/browse/CASSANDRA-18238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18238: -- Change Category: Operability Complexity: Normal Fix Version/s: 4.x Status: Open (was: Triage Needed) > Implicitly enable ALLOW FILTERING on virtual tables > --- > > Key: CASSANDRA-18238 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18238 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Virtual Tables >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.x > > > Ticket to track work / discussion of this thread (1) > (1) https://lists.apache.org/thread/104fld746d6qtggq5132n3hqtjqqpkjp -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18219) Warning message on aggregation queries doesn't specify table name or aggregate type
[
https://issues.apache.org/jira/browse/CASSANDRA-18219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684609#comment-17684609
]
Brad Schoening commented on CASSANDRA-18219:
[~smiklosovic] yes, just the WARN level info works fine.
> Warning message on aggregation queries doesn't specify table name or
> aggregate type
> ---
>
> Key: CASSANDRA-18219
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18219
> Project: Cassandra
> Issue Type: Improvement
> Components: Observability/Logging
>Reporter: Brad Schoening
>Assignee: Stefan Miklosovic
>Priority: Normal
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The existing aggregation query warning messages in cassandra.log from
> SelectStatement.java:
> _'[WARN] Aggregation query used without partition key'_
> {_}'{_}{_}[WARN]{_} _Aggregation query used on multiple partition keys
> (IN restriction)'_
> are missing the helpful details which would assist users in quickly
> identifying the offending query. The table name and type of aggregation would
> be useful additions in the WARN message.
> In addition, following the example of the slow query logger and printing out
> the query string at DEBUG level would be especially helpful.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18215) Fix the output of FQL dump tool to properly separate entries
[
https://issues.apache.org/jira/browse/CASSANDRA-18215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684550#comment-17684550
]
n.v.harikrishna commented on CASSANDRA-18215:
-
[~smiklosovic] Thanks for taking a look. Added test case and pushed the changes
to PR.
> Fix the output of FQL dump tool to properly separate entries
>
>
> Key: CASSANDRA-18215
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18215
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/fql
>Reporter: Stefan Miklosovic
>Assignee: n.v.harikrishna
>Priority: Normal
> Fix For: 4.0.x, 4.1.x, 4.x
>
>
> This was reported in (1)
> (1) https://github.com/apache/cassandra/pull/2050
> If I create a table something like this:
> {code}
> CREATE TABLE t1 ( id int PRIMARY KEY , v1 int, v2 int, v3 int) ;
> {code}
> and inserted a row using:
> {code}
> try (CqlSession cqlSession = CqlSession.builder().build()) {
> PreparedStatement preparedStatement = cqlSession.prepare("INSERT INTO
> ks1.t1 (id, v1, v2, v3) VALUES (?, ?, ?, ?)");
> cqlSession.execute(preparedStatement.bind(1, 1, 1, 1));
> }
> {code}
> The output of fqltool looks something like this:
> {code}
> Type: single-query
> Query start time: 1673373829119
> Protocol version: 5
> Generated timestamp:-9223372036854775808
> Generated nowInSeconds:1673373829
> Query: INSERT INTO ks1.t1 (id, v1, v2, v3) VALUES (?, ?, ?, ?)
> Values:
> 00 00 00 01
> 00 00 00 01
> -
> 00 00 00 01
> -
> 00 00 00 01
> -
> {code}
> - is not printed between the first and second value
> {code}
> Values:
> 00 00 00 01
> 00 00 00 01
> {code}
> We are normally very cautious about changing the output of the tooling but in
> this case I think this is a legit bug which should be fixed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18177) Support AbstractCompositeType with toJSONString method
[ https://issues.apache.org/jira/browse/CASSANDRA-18177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684544#comment-17684544 ] Yong Jiang edited comment on CASSANDRA-18177 at 2/6/23 9:41 AM: Thank you, [~maxwellguo]! I will work on the patch and update this task when it is available. was (Author: JIRAUSER296963): Thank you, [~maxwellguo]! I will working on the patch and update this task when it is available. > Support AbstractCompositeType with toJSONString method > -- > > Key: CASSANDRA-18177 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18177 > Project: Cassandra > Issue Type: New Feature >Reporter: maxwellguo >Assignee: Yong Jiang >Priority: Normal > > As we know AbstractCompositeType do not support toJSONString method , but > some times > we do need this. > See the discusstion of > [CASSANDRA-17698|https://issues.apache.org/jira/browse/CASSANDRA-17698]. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18177) Support AbstractCompositeType with toJSONString method
[ https://issues.apache.org/jira/browse/CASSANDRA-18177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684544#comment-17684544 ] Yong Jiang commented on CASSANDRA-18177: Thank you, [~maxwellguo]! I will working on the patch and update this task when it is available. > Support AbstractCompositeType with toJSONString method > -- > > Key: CASSANDRA-18177 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18177 > Project: Cassandra > Issue Type: New Feature >Reporter: maxwellguo >Assignee: Yong Jiang >Priority: Normal > > As we know AbstractCompositeType do not support toJSONString method , but > some times > we do need this. > See the discusstion of > [CASSANDRA-17698|https://issues.apache.org/jira/browse/CASSANDRA-17698]. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18219) Warning message on aggregation queries doesn't specify table name or aggregate type
[
https://issues.apache.org/jira/browse/CASSANDRA-18219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684540#comment-17684540
]
Stefan Miklosovic commented on CASSANDRA-18219:
---
[~bschoeni] is it fine to log it without the actual query? There is a bug in
cql dumping if you look into the PR (cc [~blerer] )
> Warning message on aggregation queries doesn't specify table name or
> aggregate type
> ---
>
> Key: CASSANDRA-18219
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18219
> Project: Cassandra
> Issue Type: Improvement
> Components: Observability/Logging
>Reporter: Brad Schoening
>Assignee: Stefan Miklosovic
>Priority: Normal
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The existing aggregation query warning messages in cassandra.log from
> SelectStatement.java:
> _'[WARN] Aggregation query used without partition key'_
> {_}'{_}{_}[WARN]{_} _Aggregation query used on multiple partition keys
> (IN restriction)'_
> are missing the helpful details which would assist users in quickly
> identifying the offending query. The table name and type of aggregation would
> be useful additions in the WARN message.
> In addition, following the example of the slow query logger and printing out
> the query string at DEBUG level would be especially helpful.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15254) Allow UPDATE on settings virtual table to change running configurations
[ https://issues.apache.org/jira/browse/CASSANDRA-15254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684536#comment-17684536 ] Benjamin Lerer commented on CASSANDRA-15254: Just to make sure that we have all the same understanding. The plan is only to allow setting the properties that can be set dynamically today (which is a small sub-set of the properties), right? I have not checked but it might be possible that some setter or getters are actually not used by JMX. [~mmuzaf] Your schema mention Auto-Generated classes which is a good idea. I am simply not sure that it is feasible in practice as setting the property is also often only a minor part of the logic involved in changing a configuration. Configuration are often use at start up to initialize some C* components and in case of configuration update that component somehow need to be modified in a non generic way. Up to now that logic was performed in the different JMX implementation classes. Each of them was usually setting the config parameter and then updating the impacted component that they were managing. > Allow UPDATE on settings virtual table to change running configurations > --- > > Key: CASSANDRA-15254 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15254 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Virtual Tables >Reporter: Chris Lohfink >Assignee: Maxim Muzafarov >Priority: Normal > Attachments: Configuration Registry Diagram.png > > Time Spent: 0.5h > Remaining Estimate: 0h > > Allow using UPDATE on the system_views.settings virtual table to update > configs at runtime for the equivalent of the dispersed JMX > attributes/operations. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-18177) Support AbstractCompositeType with toJSONString method
[ https://issues.apache.org/jira/browse/CASSANDRA-18177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] maxwellguo reassigned CASSANDRA-18177: -- Assignee: Yong Jiang > Support AbstractCompositeType with toJSONString method > -- > > Key: CASSANDRA-18177 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18177 > Project: Cassandra > Issue Type: New Feature >Reporter: maxwellguo >Assignee: Yong Jiang >Priority: Normal > > As we know AbstractCompositeType do not support toJSONString method , but > some times > we do need this. > See the discusstion of > [CASSANDRA-17698|https://issues.apache.org/jira/browse/CASSANDRA-17698]. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18177) Support AbstractCompositeType with toJSONString method
[ https://issues.apache.org/jira/browse/CASSANDRA-18177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684531#comment-17684531 ] maxwellguo commented on CASSANDRA-18177: Hi [~yongjiang]， I'm not working on it now. > Support AbstractCompositeType with toJSONString method > -- > > Key: CASSANDRA-18177 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18177 > Project: Cassandra > Issue Type: New Feature >Reporter: maxwellguo >Priority: Normal > > As we know AbstractCompositeType do not support toJSONString method , but > some times > we do need this. > See the discusstion of > [CASSANDRA-17698|https://issues.apache.org/jira/browse/CASSANDRA-17698]. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-15254) Allow UPDATE on settings virtual table to change running configurations
[ https://issues.apache.org/jira/browse/CASSANDRA-15254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Lerer updated CASSANDRA-15254: --- Reviewers: Benjamin Lerer, David Capwell (was: David Capwell) > Allow UPDATE on settings virtual table to change running configurations > --- > > Key: CASSANDRA-15254 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15254 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Virtual Tables >Reporter: Chris Lohfink >Assignee: Maxim Muzafarov >Priority: Normal > Attachments: Configuration Registry Diagram.png > > Time Spent: 0.5h > Remaining Estimate: 0h > > Allow using UPDATE on the system_views.settings virtual table to update > configs at runtime for the equivalent of the dispersed JMX > attributes/operations. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18177) Support AbstractCompositeType with toJSONString method
[ https://issues.apache.org/jira/browse/CASSANDRA-18177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684519#comment-17684519 ] Yong Jiang commented on CASSANDRA-18177: Hi, [~maxwellguo], just wondering if you are working on this jira? I would be happy to take it if help is needed. I believe this could a great task for me to contribute since I can refer to CASSANDRA-17698 to study your implementation on partitionorder type. > Support AbstractCompositeType with toJSONString method > -- > > Key: CASSANDRA-18177 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18177 > Project: Cassandra > Issue Type: New Feature >Reporter: maxwellguo >Priority: Normal > > As we know AbstractCompositeType do not support toJSONString method , but > some times > we do need this. > See the discusstion of > [CASSANDRA-17698|https://issues.apache.org/jira/browse/CASSANDRA-17698]. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
