[cassandra-website] branch asf-staging updated (d0489ee4 -> c59ae340)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard d0489ee4 generate docs for c4206294 new c59ae340 generate docs for c4206294 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (d0489ee4) \ N -- N -- N refs/heads/asf-staging (c59ae340) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: site-ui/build/ui-bundle.zip | Bin 4796442 -> 4796442 bytes 1 file changed, 0 insertions(+), 0 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18303) Feature documentation lost / moved out of focus
[ https://issues.apache.org/jira/browse/CASSANDRA-18303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698748#comment-17698748 ] Tibor Repasi commented on CASSANDRA-18303: -- No worries. Thank you! > Feature documentation lost / moved out of focus > --- > > Key: CASSANDRA-18303 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18303 > Project: Cassandra > Issue Type: Bug > Components: Documentation/Website >Reporter: Tibor Repasi >Assignee: Tibor Repasi >Priority: Normal > Fix For: 4.1.1, 5.0 > > > Documentation added with CASSANDRA-17344 wasn't moved with CASSANDRA-17976 > and now the documentation on the website page "Cassandra/Operating/Virtual > tables" shows an outdated version for > [4.1|https://cassandra.apache.org/doc/4.1/cassandra/operating/virtualtables.html] > and > [latest|https://cassandra.apache.org/doc/latest/cassandra/operating/virtualtables.html]. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-18222) Fix flaky test org.apache.cassandra.distributed.test.accord.AccordIntegrationTest
[ https://issues.apache.org/jira/browse/CASSANDRA-18222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caleb Rackliffe reassigned CASSANDRA-18222: --- Assignee: Caleb Rackliffe > Fix flaky test > org.apache.cassandra.distributed.test.accord.AccordIntegrationTest > - > > Key: CASSANDRA-18222 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18222 > Project: Cassandra > Issue Type: Bug > Components: Accord, CI >Reporter: David Capwell >Assignee: Caleb Rackliffe >Priority: Normal > Fix For: 5.x > > > The accord integration tests are currently flaky due to Preempt happening (we > convert that to a timeout). We need to address this to make sure the tests > are stable. > One solution may be make SimpleProgressLog’s frequency run different for > jvm-dtest (likely to depend on CASSANDRA-18221 ), this would be similar to > what we already do as timeouts maybe larger in jvm-dtest due to the extra > complexity running multiple processes in the same JVM. Another solution may > be to have the client coordinator “attach” to the new coordinator, this would > avoid the user being impacted by this preempt when the coordinator is > healthy. > Example: > https://app.circleci.com/pipelines/github/dcapwell/cassandra/1822/workflows/0d92898f-ad7d-4a7d-9198-3a7ce844ee93/jobs/16464 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (9cde15ab -> d0489ee4)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 9cde15ab generate docs for c4206294 new d0489ee4 generate docs for c4206294 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (9cde15ab) \ N -- N -- N refs/heads/asf-staging (d0489ee4) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4796442 -> 4796442 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18317) Properly synchronize CQLSSTableWriter#build on the Schema.instance
[
https://issues.apache.org/jira/browse/CASSANDRA-18317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francisco Guerrero updated CASSANDRA-18317:
---
Test and Documentation Plan: Added unit tests that surface the issue.
Status: Patch Available (was: In Progress)
The issue seems to be resolved in trunk, I've added a PR against trunk with
only the unit tests, but it is still desirable to fix this in 4.0 and 4.1
PR (trunk) : https://github.com/apache/cassandra/pull/2207
CI (trunk) : https://app.circleci.com/pipelines/github/frankgh/cassandra/119
PR (4.0) : https://github.com/apache/cassandra/pull/2208
CI (4.0) : https://app.circleci.com/pipelines/github/frankgh/cassandra/118
> Properly synchronize CQLSSTableWriter#build on the Schema.instance
> --
>
> Key: CASSANDRA-18317
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18317
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/bulk load
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The {{CQLSSTableWriter#build}} method should properly synchronize on the
> {{Schema.instance}} class to prevent concurrent Schema operations fail, [when
> the offline tool also updates schema].
> For example, a table creation operation, which modifies the keyspaces tables
> metadata, might end up missing the update when a concurrent call to the
> {{CQLSSTableWriter#build}} method is accessing the {{Schema}} instance.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (e8546f61 -> 9cde15ab)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard e8546f61 generate docs for c4206294 new 9cde15ab generate docs for c4206294 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (e8546f61) \ N -- N -- N refs/heads/asf-staging (9cde15ab) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4796442 -> 4796442 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18124) Config parameter keystore_password should be nullable
[ https://issues.apache.org/jira/browse/CASSANDRA-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698669#comment-17698669 ] Brandon Williams edited comment on CASSANDRA-18124 at 3/10/23 1:04 AM: --- I think you should base this patch off of 4.1 and trunk, regardless of other tickets. was (Author: brandon.williams): I think you should base this patch off of trunk, regardless of other tickets. > Config parameter keystore_password should be nullable > - > > Key: CASSANDRA-18124 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18124 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Tibor Repasi >Assignee: Maulin Vasavada >Priority: Normal > Fix For: 4.1.x, 5.x > > > Some SSL configuration may pass unencrypted private keys. PEMReader might > accept that by assuming keyPassword to be null in that case (e.g. > https://github.com/apache/cassandra/blob/f9e033f519c14596da4dc954875756a69aea4e78/src/java/org/apache/cassandra/security/PEMReader.java#L103). > Current configuration reader does not accept keystore_password parameter to > be set null or empty in the cassandra.yaml. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18124) Config parameter keystore_password should be nullable
[ https://issues.apache.org/jira/browse/CASSANDRA-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698670#comment-17698670 ] Francisco Guerrero commented on CASSANDRA-18124: Thanks [~maulin.vasavada]. I won't be able to get to this for at least a couple of weeks. > Config parameter keystore_password should be nullable > - > > Key: CASSANDRA-18124 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18124 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Tibor Repasi >Assignee: Maulin Vasavada >Priority: Normal > Fix For: 4.1.x, 5.x > > > Some SSL configuration may pass unencrypted private keys. PEMReader might > accept that by assuming keyPassword to be null in that case (e.g. > https://github.com/apache/cassandra/blob/f9e033f519c14596da4dc954875756a69aea4e78/src/java/org/apache/cassandra/security/PEMReader.java#L103). > Current configuration reader does not accept keystore_password parameter to > be set null or empty in the cassandra.yaml. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18124) Config parameter keystore_password should be nullable
[ https://issues.apache.org/jira/browse/CASSANDRA-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698669#comment-17698669 ] Brandon Williams commented on CASSANDRA-18124: -- I think you should base this patch off of trunk, regardless of other tickets. > Config parameter keystore_password should be nullable > - > > Key: CASSANDRA-18124 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18124 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Tibor Repasi >Assignee: Maulin Vasavada >Priority: Normal > Fix For: 4.1.x, 5.x > > > Some SSL configuration may pass unencrypted private keys. PEMReader might > accept that by assuming keyPassword to be null in that case (e.g. > https://github.com/apache/cassandra/blob/f9e033f519c14596da4dc954875756a69aea4e78/src/java/org/apache/cassandra/security/PEMReader.java#L103). > Current configuration reader does not accept keystore_password parameter to > be set null or empty in the cassandra.yaml. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18124) Config parameter keystore_password should be nullable
[ https://issues.apache.org/jira/browse/CASSANDRA-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698660#comment-17698660 ] Maulin Vasavada edited comment on CASSANDRA-18124 at 3/10/23 12:39 AM: --- [~smiklosovic] I'll take this. Sorry last couple of weeks have been crazy. was (Author: maulin.vasavada): [~smiklosovic] I'll take this. Sorry last couple of weeks has been crazy. > Config parameter keystore_password should be nullable > - > > Key: CASSANDRA-18124 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18124 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Tibor Repasi >Assignee: Maulin Vasavada >Priority: Normal > Fix For: 4.1.x, 5.x > > > Some SSL configuration may pass unencrypted private keys. PEMReader might > accept that by assuming keyPassword to be null in that case (e.g. > https://github.com/apache/cassandra/blob/f9e033f519c14596da4dc954875756a69aea4e78/src/java/org/apache/cassandra/security/PEMReader.java#L103). > Current configuration reader does not accept keystore_password parameter to > be set null or empty in the cassandra.yaml. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18124) Config parameter keystore_password should be nullable
[ https://issues.apache.org/jira/browse/CASSANDRA-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698661#comment-17698661 ] Maulin Vasavada commented on CASSANDRA-18124: - One question- Since the trunk was broken for example/ssl-factory, what should be the base I. can use to build for this if the trunk is still broken? > Config parameter keystore_password should be nullable > - > > Key: CASSANDRA-18124 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18124 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Tibor Repasi >Assignee: Maulin Vasavada >Priority: Normal > Fix For: 4.1.x, 5.x > > > Some SSL configuration may pass unencrypted private keys. PEMReader might > accept that by assuming keyPassword to be null in that case (e.g. > https://github.com/apache/cassandra/blob/f9e033f519c14596da4dc954875756a69aea4e78/src/java/org/apache/cassandra/security/PEMReader.java#L103). > Current configuration reader does not accept keystore_password parameter to > be set null or empty in the cassandra.yaml. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18124) Config parameter keystore_password should be nullable
[ https://issues.apache.org/jira/browse/CASSANDRA-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698660#comment-17698660 ] Maulin Vasavada commented on CASSANDRA-18124: - [~smiklosovic] I'll take this. Sorry last couple of weeks has been crazy. > Config parameter keystore_password should be nullable > - > > Key: CASSANDRA-18124 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18124 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Tibor Repasi >Assignee: Maulin Vasavada >Priority: Normal > Fix For: 4.1.x, 5.x > > > Some SSL configuration may pass unencrypted private keys. PEMReader might > accept that by assuming keyPassword to be null in that case (e.g. > https://github.com/apache/cassandra/blob/f9e033f519c14596da4dc954875756a69aea4e78/src/java/org/apache/cassandra/security/PEMReader.java#L103). > Current configuration reader does not accept keystore_password parameter to > be set null or empty in the cassandra.yaml. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-18124) Config parameter keystore_password should be nullable
[ https://issues.apache.org/jira/browse/CASSANDRA-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maulin Vasavada reassigned CASSANDRA-18124: --- Assignee: Maulin Vasavada > Config parameter keystore_password should be nullable > - > > Key: CASSANDRA-18124 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18124 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Tibor Repasi >Assignee: Maulin Vasavada >Priority: Normal > Fix For: 4.1.x, 5.x > > > Some SSL configuration may pass unencrypted private keys. PEMReader might > accept that by assuming keyPassword to be null in that case (e.g. > https://github.com/apache/cassandra/blob/f9e033f519c14596da4dc954875756a69aea4e78/src/java/org/apache/cassandra/security/PEMReader.java#L103). > Current configuration reader does not accept keystore_password parameter to > be set null or empty in the cassandra.yaml. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18305) Enhance nodetool compactionstats with existing MBean metrics
[
https://issues.apache.org/jira/browse/CASSANDRA-18305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brad Schoening updated CASSANDRA-18305:
---
Description:
Nodetool compactionstats reports only on active compactions, if nothing is
active, you see only:
{quote}$nodetool compactionstats
pending tasks: 0
{quote}
but in the MBean Compaction/TotalCompactionsCompleted there are recent
statistic in events/second for:
* Count
* FifteenMinueRate
* FiveMinueRate
* MeanRate
* OneMinuteRate
1) It would be useful to see in addition:
{quote}pending tasks: 0
compactions completed: 20
1 minute rate: 0/second
5 minute rate: 2.3/second
15 minute rate: 4.6/second
{quote}
2) Since compaction_throughput_mb_per_sec is a throttling parameter in
cassandra.yaml (default 64 MBps), it would be nice to show the actual
compaction throughput and be able to observe if you're close to the limit.
I.e.,
{quote}compaction throughput 13.2 MBps / 16 MBps (82.5%)
{quote}
3) for completness, compactionstats should list the number of concurrent
compactors configured, perhaps simply add to existing 'pending tasks' line:
{quote}4 concurrent compactors, 0 pending tasks
{quote}
was:
Nodetool compactionstats reports only on active compactions, if nothing is
active, you see only:
{quote}$nodetool compactionstats
pending tasks: 0
{quote}
but in the MBean Compaction/TotalCompactionsCompleted there are recent
statistic in events/second for:
* Count
* FifteenMinueRate
* FiveMinueRate
* MeanRate
* OneMinuteRate
1) It would be useful to see in addition:
{quote}pending tasks: 0
compactions completed: 20
1 minute rate: 0/second
5 minute rate: 2.3/second
15 minute rate: 4.6/second
{quote}
2) Since compaction_throughput_mb_per_sec is a throttling parameter in
cassandra.yaml (default 64 MBps), it would be nice to show the actual
compaction throughput and be able to observe if you're close to the limit.
I.e.,
{quote}compaction throughput 13.2 MBps / 16 MBps (82.5%)
{quote}
3) for completness, compactionstats should list the number of concurrent
compactors configured
{quote}concurrent compactions permitted: 2
{quote}
or perhaps simply add to existing 'pending tasks' line:
{quote}2 concurrent compactors, 0 pending tasks
{quote}
> Enhance nodetool compactionstats with existing MBean metrics
>
>
> Key: CASSANDRA-18305
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18305
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/nodetool
>Reporter: Brad Schoening
>Priority: Normal
>
> Nodetool compactionstats reports only on active compactions, if nothing is
> active, you see only:
> {quote}$nodetool compactionstats
> pending tasks: 0
> {quote}
> but in the MBean Compaction/TotalCompactionsCompleted there are recent
> statistic in events/second for:
> * Count
> * FifteenMinueRate
> * FiveMinueRate
> * MeanRate
> * OneMinuteRate
> 1) It would be useful to see in addition:
> {quote}pending tasks: 0
> compactions completed: 20
> 1 minute rate: 0/second
> 5 minute rate: 2.3/second
> 15 minute rate: 4.6/second
> {quote}
> 2) Since compaction_throughput_mb_per_sec is a throttling parameter in
> cassandra.yaml (default 64 MBps), it would be nice to show the actual
> compaction throughput and be able to observe if you're close to the limit.
> I.e.,
> {quote}compaction throughput 13.2 MBps / 16 MBps (82.5%)
> {quote}
> 3) for completness, compactionstats should list the number of concurrent
> compactors configured, perhaps simply add to existing 'pending tasks' line:
> {quote}4 concurrent compactors, 0 pending tasks
> {quote}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18309) Remove git hook for pre-push as it is redundant and causes issues when merging to mainline
[
https://issues.apache.org/jira/browse/CASSANDRA-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-18309:
--
Fix Version/s: 5.0
(was: 5.x)
Since Version: 5.0
Source Control Link:
https://github.com/apache/cassandra/commit/51b0dca71df94631519fdf1639aeb5f9ba43c570
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> Remove git hook for pre-push as it is redundant and causes issues when
> merging to mainline
> --
>
> Key: CASSANDRA-18309
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18309
> Project: Cassandra
> Issue Type: Bug
> Components: Accord
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 5.0
>
>
> {code}
> [cep-15-accord][~/repos/apache-cassandra]$ git push origin cep-15-accord
> Warning: Permanently added 'github.com' (ED25519) to the list of known hosts.
> Entering 'modules/accord'
> Username for 'https://github.com':
> {code}
> This is caused by .build/git/git-hooks/pre-push/100-push-submodules.sh logic
> {code}
> local -r cmd='
> branch="$(git rev-parse --abbrev-ref HEAD)"
> [[ "$branch" == "HEAD" ]] && exit 0
> default_remote="$(git config --local --get branch."${branch}".remote || true)"
> remote="${default_remote:-origin}"
> git push --atomic "$remote" "$branch"
> '
> git submodule foreach --recursive "$cmd"
> {code}
> This logic was to make sure that the submodule is pushed before you push your
> changes, but this is slightly redundant as
> .build/git/git-hooks/pre-commit/100-verify-submodules-pushed.sh will not
> allow you to commit the submodule SHA until it can confirm its on GitHub.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cep-15-accord updated: Remove git hook for pre-push as it is redundant and causes issues when merging to mainline
This is an automated email from the ASF dual-hosted git repository.
dcapwell pushed a commit to branch cep-15-accord
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cep-15-accord by this push:
new 51b0dca71d Remove git hook for pre-push as it is redundant and causes
issues when merging to mainline
51b0dca71d is described below
commit 51b0dca71df94631519fdf1639aeb5f9ba43c570
Author: David Capwell
AuthorDate: Thu Mar 9 15:20:48 2023 -0800
Remove git hook for pre-push as it is redundant and causes issues when
merging to mainline
patch by David Capwell; reviewed by Caleb Rackliffe for CASSANDRA-18309
---
.../git/git-hooks/pre-push/100-push-submodules.sh | 51 --
.build/git/install-git-defaults.sh | 1 -
2 files changed, 52 deletions(-)
diff --git a/.build/git/git-hooks/pre-push/100-push-submodules.sh
b/.build/git/git-hooks/pre-push/100-push-submodules.sh
deleted file mode 100755
index c3daa95597..00
--- a/.build/git/git-hooks/pre-push/100-push-submodules.sh
+++ /dev/null
@@ -1,51 +0,0 @@
-#!/usr/bin/env bash
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-# Redirect output to stderr.
-exec 1>&2
-
-#set -o xtrace
-set -o errexit
-set -o pipefail
-set -o nounset
-
-bin="$(cd "$(dirname "$0")" > /dev/null; pwd)"
-
-_main() {
- # In case the usage happens at a different layer, make sure to cd to the
toplevel
- local root_dir
- root_dir="$(git rev-parse --show-toplevel)"
- cd "$root_dir"
-
- if [[ ! -e .gitmodules ]]; then
-# nothing to see here, look away!
-return 0
- fi
-
- local -r cmd='
-branch="$(git rev-parse --abbrev-ref HEAD)"
-[[ "$branch" == "HEAD" ]] && exit 0
-
-default_remote="$(git config --local --get branch."${branch}".remote || true)"
-remote="${default_remote:-origin}"
-
-git push --atomic "$remote" "$branch"
-'
- git submodule foreach --recursive "$cmd"
-}
-
-_main "$@"
diff --git a/.build/git/install-git-defaults.sh
b/.build/git/install-git-defaults.sh
index 00f1dc435d..7c26ed5eda 100755
--- a/.build/git/install-git-defaults.sh
+++ b/.build/git/install-git-defaults.sh
@@ -89,7 +89,6 @@ _install_hooks() {
install_hook "$git_dir" "post-checkout" true
install_hook "$git_dir" "post-switch" false
install_hook "$git_dir" "pre-commit"false
- install_hook "$git_dir" "pre-push" false
}
_git_config_set() {
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18309) Remove git hook for pre-push as it is redundant and causes issues when merging to mainline
[
https://issues.apache.org/jira/browse/CASSANDRA-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-18309:
--
Status: Ready to Commit (was: Review In Progress)
> Remove git hook for pre-push as it is redundant and causes issues when
> merging to mainline
> --
>
> Key: CASSANDRA-18309
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18309
> Project: Cassandra
> Issue Type: Bug
> Components: Accord
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 5.x
>
>
> {code}
> [cep-15-accord][~/repos/apache-cassandra]$ git push origin cep-15-accord
> Warning: Permanently added 'github.com' (ED25519) to the list of known hosts.
> Entering 'modules/accord'
> Username for 'https://github.com':
> {code}
> This is caused by .build/git/git-hooks/pre-push/100-push-submodules.sh logic
> {code}
> local -r cmd='
> branch="$(git rev-parse --abbrev-ref HEAD)"
> [[ "$branch" == "HEAD" ]] && exit 0
> default_remote="$(git config --local --get branch."${branch}".remote || true)"
> remote="${default_remote:-origin}"
> git push --atomic "$remote" "$branch"
> '
> git submodule foreach --recursive "$cmd"
> {code}
> This logic was to make sure that the submodule is pushed before you push your
> changes, but this is slightly redundant as
> .build/git/git-hooks/pre-commit/100-verify-submodules-pushed.sh will not
> allow you to commit the submodule SHA until it can confirm its on GitHub.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (3951a006 -> e8546f61)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 3951a006 generate docs for c4206294 new e8546f61 generate docs for c4206294 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (3951a006) \ N -- N -- N refs/heads/asf-staging (e8546f61) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4796442 -> 4796442 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18239) Replace eclipse warnings based static code analysis with something better (Sonar)
[
https://issues.apache.org/jira/browse/CASSANDRA-18239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698634#comment-17698634
]
Ekaterina Dimitrova edited comment on CASSANDRA-18239 at 3/9/23 10:37 PM:
--
All good ideas and I would be also happy to see eclipse warnings replaced by
something better.
Currently we are trying to put everything into place for JDK17. Lots of moving
parts. We need to ensure we have eclipse warnings or whatever else we want to
perform the analysis with JDK11 so we can drop JDK8. So my ask here is either
we enable a replacement of eclipse-warnings (if it doesn't take months) and do
further improvements in follow up tickets or we switch eclipse warnings to be
run with JDK11 so we do not block for long the drop of JDK8. Then we can
replace them and do whatever else improvements we want in the future win trunk.
I also found a comment in build.xml:
[|https://github.com/apache/cassandra/blob/trunk/build.xml#L1909]
was (Author: e.dimitrova):
All good ideas and I would be also happy to see eclipse warnings replaced by
something better.
Currently we are trying to put everything into place for JDK17. Lots of moving
parts. We need to ensure we have eclipse warnings or whatever else we want to
perform the analysis with JDK11 so we can drop JDK8. So my ask here is either
we enable a replacement of eclipse-warnings (if it doesn't take months) and do
further improvements in follow up tickets or we switch eclipse warnings to be
run with JDK11 so we do not block for long the drop of JDK8.
I also found a comment in build.xml:
[|https://github.com/apache/cassandra/blob/trunk/build.xml#L1909]
> Replace eclipse warnings based static code analysis with something better
> (Sonar)
> -
>
> Key: CASSANDRA-18239
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18239
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Jacek Lewandowski
>Priority: Normal
>
> Eclipse warnings is used for static code analysis. However, it does not fit
> well into Cassandra code and practically we end up explicitly adding
> suppressions in many places just to satisfy that tool rather than fix the
> real issues.
> This is an incomplete list of reasons to remove it:
> - not closed resources are detected incorrectly
> - does not recognize custom utility methods used to close the resources,
> which use use heavily in the code, like {{Throwables.close}},
> {{FileUtils.close}}, {{closeQuietly}}...
> - because of the above, we cannot make important things like {{Ref}} to
> implement {{Closeable}} as it would make the tool to explode with tons of
> warnings
> - it complains about correct generics - something like "method X is not
> applicable for ..." when the code compiles successfully is not acceptable
> - it is old and not maintained
> There are better tools like IntelliJ inspections for example, which can also
> be run in headless mode
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18239) Replace eclipse warnings based static code analysis with something better (Sonar)
[
https://issues.apache.org/jira/browse/CASSANDRA-18239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698634#comment-17698634
]
Ekaterina Dimitrova commented on CASSANDRA-18239:
-
All good ideas and I would be also happy to see eclipse warnings replaced by
something better.
Currently we are trying to put everything into place for JDK17. Lots of moving
parts. We need to ensure we have eclipse warnings or whatever else we want to
perform the analysis with JDK11 so we can drop JDK8. So my ask here is either
we enable a replacement of eclipse-warnings (if it doesn't take months) and do
further improvements in follow up tickets or we switch eclipse warnings to be
run with JDK11 so we do not block for long the drop of JDK8.
I also found a comment in build.xml:
[|https://github.com/apache/cassandra/blob/trunk/build.xml#L1909]
> Replace eclipse warnings based static code analysis with something better
> (Sonar)
> -
>
> Key: CASSANDRA-18239
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18239
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Jacek Lewandowski
>Priority: Normal
>
> Eclipse warnings is used for static code analysis. However, it does not fit
> well into Cassandra code and practically we end up explicitly adding
> suppressions in many places just to satisfy that tool rather than fix the
> real issues.
> This is an incomplete list of reasons to remove it:
> - not closed resources are detected incorrectly
> - does not recognize custom utility methods used to close the resources,
> which use use heavily in the code, like {{Throwables.close}},
> {{FileUtils.close}}, {{closeQuietly}}...
> - because of the above, we cannot make important things like {{Ref}} to
> implement {{Closeable}} as it would make the tool to explode with tons of
> warnings
> - it complains about correct generics - something like "method X is not
> applicable for ..." when the code compiles successfully is not acceptable
> - it is old and not maintained
> There are better tools like IntelliJ inspections for example, which can also
> be run in headless mode
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (18c70646 -> 3951a006)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 18c70646 generate docs for c4206294 new 3951a006 generate docs for c4206294 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (18c70646) \ N -- N -- N refs/heads/asf-staging (3951a006) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../doc/4.1/cassandra/operating/virtualtables.html | 94 ++--- .../doc/4.2/cassandra/operating/virtualtables.html | 94 ++--- .../latest/cassandra/operating/virtualtables.html | 94 ++--- .../trunk/cassandra/operating/virtualtables.html | 94 ++--- content/search-index.js| 2 +- site-ui/build/ui-bundle.zip| Bin 4796442 -> 4796442 bytes 6 files changed, 325 insertions(+), 53 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18239) Replace eclipse warnings based static code analysis with something better (Sonar)
[
https://issues.apache.org/jira/browse/CASSANDRA-18239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698623#comment-17698623
]
Maxim Muzafarov edited comment on CASSANDRA-18239 at 3/9/23 9:50 PM:
-
My guess is that we can use an IDE-agnostic tool to perform static code
analysis, so Checkstyle + SpotBug + Sonar is a very good choice. I was
mentioning it here:
[https://lists.apache.org/thread/11j0hrv2bkx60xk7zvlgqgjwo982qv6h]
So we can remove the eclipse-warnings because they don't give us the expected
accuracy for source code checks, this will simplify the maintenance. I think it
will be better to have the shared Intellij code-style and inspections config as
I described it here CASSANDRA-18277 (we have almost everything for it).
Should we create an issue to configure Sonar's statistics updates on a commit
to the trunk (guess we can use GitHub Actions here)?
was (Author: mmuzaf):
My guess is that we can use an IDE-agnostic tool to perform static code
analysis, so Checkstyle + Sonar is a very good choice. I was mentioning it here:
[https://lists.apache.org/thread/11j0hrv2bkx60xk7zvlgqgjwo982qv6h]
So we can remove the eclipse-warnings because they don't give us the expected
accuracy for source code checks, this will simplify the maintenance. I think it
will be better to have the shared Intellij code-style and inspections config as
I described it here CASSANDRA-18277 (we have almost everything for it).
Should we create an issue to configure Sonar's statistics updates on a commit
to the trunk (guess we can use GitHub Actions here)?
> Replace eclipse warnings based static code analysis with something better
> (Sonar)
> -
>
> Key: CASSANDRA-18239
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18239
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Jacek Lewandowski
>Priority: Normal
>
> Eclipse warnings is used for static code analysis. However, it does not fit
> well into Cassandra code and practically we end up explicitly adding
> suppressions in many places just to satisfy that tool rather than fix the
> real issues.
> This is an incomplete list of reasons to remove it:
> - not closed resources are detected incorrectly
> - does not recognize custom utility methods used to close the resources,
> which use use heavily in the code, like {{Throwables.close}},
> {{FileUtils.close}}, {{closeQuietly}}...
> - because of the above, we cannot make important things like {{Ref}} to
> implement {{Closeable}} as it would make the tool to explode with tons of
> warnings
> - it complains about correct generics - something like "method X is not
> applicable for ..." when the code compiles successfully is not acceptable
> - it is old and not maintained
> There are better tools like IntelliJ inspections for example, which can also
> be run in headless mode
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18239) Replace eclipse warnings based static code analysis with something better (Sonar)
[
https://issues.apache.org/jira/browse/CASSANDRA-18239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698623#comment-17698623
]
Maxim Muzafarov commented on CASSANDRA-18239:
-
My guess is that we can use an IDE-agnostic tool to perform static code
analysis, so Checkstyle + Sonar is a very good choice. I was mentioning it here:
[https://lists.apache.org/thread/11j0hrv2bkx60xk7zvlgqgjwo982qv6h]
So we can remove the eclipse-warnings because they don't give us the expected
accuracy for source code checks, this will simplify the maintenance. I think it
will be better to have the shared Intellij code-style and inspections config as
I described it here CASSANDRA-18277 (we have almost everything for it).
Should we create an issue to configure Sonar's statistics updates on a commit
to the trunk (guess we can use GitHub Actions here)?
> Replace eclipse warnings based static code analysis with something better
> (Sonar)
> -
>
> Key: CASSANDRA-18239
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18239
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Jacek Lewandowski
>Priority: Normal
>
> Eclipse warnings is used for static code analysis. However, it does not fit
> well into Cassandra code and practically we end up explicitly adding
> suppressions in many places just to satisfy that tool rather than fix the
> real issues.
> This is an incomplete list of reasons to remove it:
> - not closed resources are detected incorrectly
> - does not recognize custom utility methods used to close the resources,
> which use use heavily in the code, like {{Throwables.close}},
> {{FileUtils.close}}, {{closeQuietly}}...
> - because of the above, we cannot make important things like {{Ref}} to
> implement {{Closeable}} as it would make the tool to explode with tons of
> warnings
> - it complains about correct generics - something like "method X is not
> applicable for ..." when the code compiles successfully is not acceptable
> - it is old and not maintained
> There are better tools like IntelliJ inspections for example, which can also
> be run in headless mode
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18239) Replace eclipse warnings based static code analysis with something better (Sonar)
[
https://issues.apache.org/jira/browse/CASSANDRA-18239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Muzafarov updated CASSANDRA-18239:
Epic Link: CASSANDRA-18090
> Replace eclipse warnings based static code analysis with something better
> (Sonar)
> -
>
> Key: CASSANDRA-18239
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18239
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Jacek Lewandowski
>Priority: Normal
>
> Eclipse warnings is used for static code analysis. However, it does not fit
> well into Cassandra code and practically we end up explicitly adding
> suppressions in many places just to satisfy that tool rather than fix the
> real issues.
> This is an incomplete list of reasons to remove it:
> - not closed resources are detected incorrectly
> - does not recognize custom utility methods used to close the resources,
> which use use heavily in the code, like {{Throwables.close}},
> {{FileUtils.close}}, {{closeQuietly}}...
> - because of the above, we cannot make important things like {{Ref}} to
> implement {{Closeable}} as it would make the tool to explode with tons of
> warnings
> - it complains about correct generics - something like "method X is not
> applicable for ..." when the code compiles successfully is not acceptable
> - it is old and not maintained
> There are better tools like IntelliJ inspections for example, which can also
> be run in headless mode
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18277) Move the IntelliJ Idea code style and inspections configuration to the project's root .idea directory
[ https://issues.apache.org/jira/browse/CASSANDRA-18277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov updated CASSANDRA-18277: Epic Link: CASSANDRA-18090 > Move the IntelliJ Idea code style and inspections configuration to the > project's root .idea directory > - > > Key: CASSANDRA-18277 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18277 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.x > > > h4. Current State > Each IDE supported by Cassandra has its own configuration files, which we > store in a special 'ide' directory in the project root. idea - for the > IntelliJ IDEA configuration, nbproject - for the NetBeans, and there is > currently no directory for the Eclipse configuration exist. > We use ant tasks for initial project setup for a particular IDE: > * generate-idea-files > * generate-eclipse-files > For NetBeans you always choose the ide/nbproject directory as the root of the > project, so that the code style configuration for the NetBeans is always > shared between developers. > h4. The Issues With Current State > There are a few inconveniences we are currently facing that could be resolved > by sharing the IntelliJ IDEA code style settings through VCS: > # Once a new checkstyle lint is implemented, and the IDE's code style > configuration is updated they are not immediately available to a developer. > The developer must track the git history to use the latest code style changes > and manually copy the updated code style files into the .idea directory, or > re-run the generate-idea-files task which will erase any locally saved > settings (e.g. words dictionaries); > # The code style usually changes by adding new rules one by one, and new > checkstyle lints are implemented, so it may differ between release branches. > It is a common practice to keep the code style on the same branch so that > IntelliJ can use an appropriate configuration for the branch being checked > out. > # The IntelliJ IDEA code style configuration format that stored the > codeStyleSettings.xml file is outdated, from version 2017.3 the codeStyle > directory is used. This prevents us from updating the code style > configuration without a lot of tedious manual changes. > The share project settings through VCS approach is well described in the > documentation pages: > https://www.jetbrains.com/help/idea/configure-project-settings.html#share-project-through-vcs > h4. What To Do > # Migrate the IntelliJ code style configuration to the new format, assuming > nobody is using such an old version of IntelliJ IDEA; > # Move the code style configuration and inspections configuration files to > the project's root .idea directory to address the issues described above; > # Rely on the IntelliJ IDEA code style for backward compatibility instead of > supporting it ourselves; -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18077) Add SpotBugs to the build
[ https://issues.apache.org/jira/browse/CASSANDRA-18077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov updated CASSANDRA-18077: Epic Link: CASSANDRA-18090 > Add SpotBugs to the build > - > > Key: CASSANDRA-18077 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18077 > Project: Cassandra > Issue Type: Improvement > Components: Build, CI >Reporter: David Capwell >Priority: Normal > Fix For: 5.x > > Attachments: spotbugs.html > > Time Spent: 50m > Remaining Estimate: 0h > > When working on CASSANDRA-17178 I found that several classes were being > reported by the Simulator for not defining serializer version when they are > Serializable; this may cause issues for the Simulator so felt it would be > best to detect these earlier on before merging new ones. > SpotBugs has a large set of checks, some more valuable than others for the > project; so we should maintain a curated list of issues to fail the build on, > and others to warn on. > This topic was discussed in the following mail threads: > * Should we add?: > https://lists.apache.org/thread/1ro1mvkpvt4vr24nw7dbpdlxo82mq3hz > * Should we fix UTF-8 issues? > https://lists.apache.org/thread/sokxf46s7hyoxr9q4wm7dv3q2nm19nt3 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-5108) expose overall progress of cleanup tasks in jmx
[ https://issues.apache.org/jira/browse/CASSANDRA-5108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yaman Ziadeh reassigned CASSANDRA-5108: --- Assignee: Yaman Ziadeh (was: Krishna Vadali) > expose overall progress of cleanup tasks in jmx > --- > > Key: CASSANDRA-5108 > URL: https://issues.apache.org/jira/browse/CASSANDRA-5108 > Project: Cassandra > Issue Type: New Feature > Components: Legacy/Observability, Local/Compaction >Affects Versions: 1.2.0 >Reporter: Michael Kjellman >Assignee: Yaman Ziadeh >Priority: Low > Labels: lhf > Fix For: 5.x > > > it would be nice if, upon starting a cleanup operation, cassandra could > maintain a Set (i assume this already exists as we have to know which file to > act on next) and a new set of "completed" sstables. When each is compacted > remove it from the pending list. That way C* could give an overall completion > of the long running and pending cleanup tasks. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18313) Remove legacy 3.x buffer pool metrics
[ https://issues.apache.org/jira/browse/CASSANDRA-18313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-18313: --- Summary: Remove legacy 3.x buffer pool metrics (was: Remove deprecated 3.x buffer pool metrics) > Remove legacy 3.x buffer pool metrics > - > > Key: CASSANDRA-18313 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18313 > Project: Cassandra > Issue Type: Task > Components: Observability/JMX >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 5.x > > > Remove BufferPoolMetrics.register3xAlias() > Patch: > https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/18313/trunk -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18239) Replace eclipse warnings based static code analysis with something better (Sonar)
[
https://issues.apache.org/jira/browse/CASSANDRA-18239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698589#comment-17698589
]
Brandon Williams commented on CASSANDRA-18239:
--
What is the next step here? I would like eclipse warnings to be removed for
CASSANDRA-18262.
> Replace eclipse warnings based static code analysis with something better
> (Sonar)
> -
>
> Key: CASSANDRA-18239
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18239
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Jacek Lewandowski
>Priority: Normal
>
> Eclipse warnings is used for static code analysis. However, it does not fit
> well into Cassandra code and practically we end up explicitly adding
> suppressions in many places just to satisfy that tool rather than fix the
> real issues.
> This is an incomplete list of reasons to remove it:
> - not closed resources are detected incorrectly
> - does not recognize custom utility methods used to close the resources,
> which use use heavily in the code, like {{Throwables.close}},
> {{FileUtils.close}}, {{closeQuietly}}...
> - because of the above, we cannot make important things like {{Ref}} to
> implement {{Closeable}} as it would make the tool to explode with tons of
> warnings
> - it complains about correct generics - something like "method X is not
> applicable for ..." when the code compiles successfully is not acceptable
> - it is old and not maintained
> There are better tools like IntelliJ inspections for example, which can also
> be run in headless mode
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18303) Feature documentation lost / moved out of focus
[ https://issues.apache.org/jira/browse/CASSANDRA-18303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698588#comment-17698588 ] Michael Semb Wever commented on CASSANDRA-18303: And apologies [~rtib] that your original patch got lost like this. > Feature documentation lost / moved out of focus > --- > > Key: CASSANDRA-18303 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18303 > Project: Cassandra > Issue Type: Bug > Components: Documentation/Website >Reporter: Tibor Repasi >Assignee: Tibor Repasi >Priority: Normal > Fix For: 4.1.1, 5.0 > > > Documentation added with CASSANDRA-17344 wasn't moved with CASSANDRA-17976 > and now the documentation on the website page "Cassandra/Operating/Virtual > tables" shows an outdated version for > [4.1|https://cassandra.apache.org/doc/4.1/cassandra/operating/virtualtables.html] > and > [latest|https://cassandra.apache.org/doc/latest/cassandra/operating/virtualtables.html]. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18303) Feature documentation lost / moved out of focus
[ https://issues.apache.org/jira/browse/CASSANDRA-18303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-18303: --- Fix Version/s: 4.1.1 5.0 (was: 5.x) (was: 4.1.x) Since Version: 4.1-rc1 Source Control Link: https://github.com/apache/cassandra/commit/af82b941a88f511605578d8eaa9b3d04634c34ac https://github.com/apache/cassandra/commit/414f4143e6128bcc129f731bbf98d84ac18da33d Resolution: Fixed Status: Resolved (was: Ready to Commit) 4.1 committed as [af82b941a88f511605578d8eaa9b3d04634c34ac|https://github.com/apache/cassandra/commit/af82b941a88f511605578d8eaa9b3d04634c34ac]. > Feature documentation lost / moved out of focus > --- > > Key: CASSANDRA-18303 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18303 > Project: Cassandra > Issue Type: Bug > Components: Documentation/Website >Reporter: Tibor Repasi >Assignee: Tibor Repasi >Priority: Normal > Fix For: 4.1.1, 5.0 > > > Documentation added with CASSANDRA-17344 wasn't moved with CASSANDRA-17976 > and now the documentation on the website page "Cassandra/Operating/Virtual > tables" shows an outdated version for > [4.1|https://cassandra.apache.org/doc/4.1/cassandra/operating/virtualtables.html] > and > [latest|https://cassandra.apache.org/doc/latest/cassandra/operating/virtualtables.html]. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.1' into trunk
This is an automated email from the ASF dual-hosted git repository. mck pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 91193e0fdf42ffdfcc351763855d356f3458c3f2 Merge: 414f4143e6 af82b941a8 Author: Mick Semb Wever AuthorDate: Thu Mar 9 20:55:49 2023 +0100 Merge branch 'cassandra-4.1' into trunk * cassandra-4.1: Restore 4.1's doc update for virtual table system_views.clients - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.1 updated: Restore 4.1's doc update for virtual table system_views.clients
This is an automated email from the ASF dual-hosted git repository.
mck pushed a commit to branch cassandra-4.1
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-4.1 by this push:
new af82b941a8 Restore 4.1's doc update for virtual table
system_views.clients
af82b941a8 is described below
commit af82b941a88f511605578d8eaa9b3d04634c34ac
Author: Tibor Répási
AuthorDate: Mon Mar 6 15:10:14 2023 +0100
Restore 4.1's doc update for virtual table system_views.clients
patch by Tibor Répási; reviewed by Ekaterina Dimitrova, Michael Semb Wever
for CASSANDRA-18303, CASSANDRA-17344
---
.../cassandra/pages/operating/virtualtables.adoc | 94 +++---
1 file changed, 81 insertions(+), 13 deletions(-)
diff --git a/doc/modules/cassandra/pages/operating/virtualtables.adoc
b/doc/modules/cassandra/pages/operating/virtualtables.adoc
index b18ba31316..2963ecbe38 100644
--- a/doc/modules/cassandra/pages/operating/virtualtables.adoc
+++ b/doc/modules/cassandra/pages/operating/virtualtables.adoc
@@ -106,18 +106,80 @@ We shall discuss some of the virtual tables in more
detail next.
=== Clients Virtual Table
The `clients` virtual table lists all active connections (connected
-clients) including their ip address, port, connection stage, driver
+clients) including their ip address, port, client_options, connection stage,
driver
name, driver version, hostname, protocol version, request count, ssl
enabled, ssl protocol and user name:
-cqlsh:system_views> select * from system_views.clients;
- address | port | connection_stage | driver_name | driver_version |
hostname | protocol_version | request_count | ssl_cipher_suite | ssl_enabled |
ssl_protocol | username
+---+--+-++---+--+---+--+-+--+---
- 127.0.0.1 | 50628 |ready |null | null |
localhost |4 |55 | null | False |
null | anonymous
- 127.0.0.1 | 50630 |ready |null | null |
localhost |4 |70 | null | False |
null | anonymous
+cqlsh> EXPAND ON ;
+Now Expanded output is enabled
+cqlsh> SELECT * FROM system_views.clients;
+
+@ Row 1
+--+-
+ address | 127.0.0.1
+ port | 50687
+ client_options | {'CQL_VERSION': '3.4.6', 'DRIVER_NAME': 'DataStax Python
Driver', 'DRIVER_VERSION': '3.25.0'}
+ connection_stage | ready
+ driver_name | DataStax Python Driver
+ driver_version | 3.25.0
+ hostname | localhost
+ protocol_version | 5
+ request_count| 16
+ ssl_cipher_suite | null
+ ssl_enabled | False
+ ssl_protocol | null
+ username | anonymous
+
+@ Row 2
+--+-
+ address | 127.0.0.1
+ port | 50688
+ client_options | {'CQL_VERSION': '3.4.6', 'DRIVER_NAME': 'DataStax Python
Driver', 'DRIVER_VERSION': '3.25.0'}
+ connection_stage | ready
+ driver_name | DataStax Python Driver
+ driver_version | 3.25.0
+ hostname | localhost
+ protocol_version | 5
+ request_count| 4
+ ssl_cipher_suite | null
+ ssl_enabled | False
+ ssl_protocol | null
+ username | anonymous
+
+@ Row 3
+--+-
+ address | 127.0.0.1
+ port | 50753
+ client_options | {'APPLICATION_NAME': 'TestApp', 'APPLICATION_VERSION':
'1.0.0', 'CLIENT_ID': '55b3efbd-c56b-469d-8cca-016b860b2f03', 'CQL_VERSION':
'3.0.0', 'DRIVER_NAME': 'DataStax Java driver for Apache Cassandra(R)',
'DRIVER_VERSION': '4.13.0'}
+ connection_stage | ready
+ driver_name | DataStax Java driver for Apache Cassandra(R)
+ driver_version | 4.13.0
+ hostname | localhost
+ protocol_version | 5
+ request_count| 18
+ ssl_cipher_suite | null
+ ssl_enabled | False
+ ssl_protocol | null
+ username | anonymous
+
+@ Row 4
[cassandra] branch trunk updated (414f4143e6 -> 91193e0fdf)
This is an automated email from the ASF dual-hosted git repository. mck pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from 414f4143e6 Restore 4.1's doc update for virtual table system_views.clients new af82b941a8 Restore 4.1's doc update for virtual table system_views.clients new 91193e0fdf Merge branch 'cassandra-4.1' into trunk The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18303) Feature documentation lost / moved out of focus
[ https://issues.apache.org/jira/browse/CASSANDRA-18303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698584#comment-17698584 ] Michael Semb Wever edited comment on CASSANDRA-18303 at 3/9/23 7:55 PM: Committed as [414f4143e6128bcc129f731bbf98d84ac18da33d|https://github.com/apache/cassandra/commit/414f4143e6128bcc129f731bbf98d84ac18da33d]. But I've forgotten 4.1 :( was (Author: michaelsembwever): Committed as [|https://github.com/apache/cassandra/commit/414f4143e6128bcc129f731bbf98d84ac18da33d]. But I've forgotten 4.1 :( > Feature documentation lost / moved out of focus > --- > > Key: CASSANDRA-18303 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18303 > Project: Cassandra > Issue Type: Bug > Components: Documentation/Website >Reporter: Tibor Repasi >Assignee: Tibor Repasi >Priority: Normal > Fix For: 4.1.x, 5.x > > > Documentation added with CASSANDRA-17344 wasn't moved with CASSANDRA-17976 > and now the documentation on the website page "Cassandra/Operating/Virtual > tables" shows an outdated version for > [4.1|https://cassandra.apache.org/doc/4.1/cassandra/operating/virtualtables.html] > and > [latest|https://cassandra.apache.org/doc/latest/cassandra/operating/virtualtables.html]. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18303) Feature documentation lost / moved out of focus
[ https://issues.apache.org/jira/browse/CASSANDRA-18303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698584#comment-17698584 ] Michael Semb Wever commented on CASSANDRA-18303: Committed as [|https://github.com/apache/cassandra/commit/414f4143e6128bcc129f731bbf98d84ac18da33d]. But I've forgotten 4.1 :( > Feature documentation lost / moved out of focus > --- > > Key: CASSANDRA-18303 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18303 > Project: Cassandra > Issue Type: Bug > Components: Documentation/Website >Reporter: Tibor Repasi >Assignee: Tibor Repasi >Priority: Normal > Fix For: 4.1.x, 5.x > > > Documentation added with CASSANDRA-17344 wasn't moved with CASSANDRA-17976 > and now the documentation on the website page "Cassandra/Operating/Virtual > tables" shows an outdated version for > [4.1|https://cassandra.apache.org/doc/4.1/cassandra/operating/virtualtables.html] > and > [latest|https://cassandra.apache.org/doc/latest/cassandra/operating/virtualtables.html]. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: Restore 4.1's doc update for virtual table system_views.clients
This is an automated email from the ASF dual-hosted git repository.
mck pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/trunk by this push:
new 414f4143e6 Restore 4.1's doc update for virtual table
system_views.clients
414f4143e6 is described below
commit 414f4143e6128bcc129f731bbf98d84ac18da33d
Author: Tibor Répási
AuthorDate: Mon Mar 6 15:10:14 2023 +0100
Restore 4.1's doc update for virtual table system_views.clients
patch by Tibor Répási; reviewed by Ekaterina Dimitrova, Michael Semb Wever
for CASSANDRA-18303, CASSANDRA-17344
---
.../cassandra/pages/operating/virtualtables.adoc | 94 +++---
1 file changed, 81 insertions(+), 13 deletions(-)
diff --git a/doc/modules/cassandra/pages/operating/virtualtables.adoc
b/doc/modules/cassandra/pages/operating/virtualtables.adoc
index f05966096b..d5fd85de8c 100644
--- a/doc/modules/cassandra/pages/operating/virtualtables.adoc
+++ b/doc/modules/cassandra/pages/operating/virtualtables.adoc
@@ -112,18 +112,80 @@ We shall discuss some of the virtual tables in more
detail next.
=== Clients Virtual Table
The `clients` virtual table lists all active connections (connected
-clients) including their ip address, port, connection stage, driver
+clients) including their ip address, port, client_options, connection stage,
driver
name, driver version, hostname, protocol version, request count, ssl
enabled, ssl protocol and user name:
-cqlsh:system_views> select * from system_views.clients;
- address | port | connection_stage | driver_name | driver_version |
hostname | protocol_version | request_count | ssl_cipher_suite | ssl_enabled |
ssl_protocol | username
+---+--+-++---+--+---+--+-+--+---
- 127.0.0.1 | 50628 |ready |null | null |
localhost |4 |55 | null | False |
null | anonymous
- 127.0.0.1 | 50630 |ready |null | null |
localhost |4 |70 | null | False |
null | anonymous
+cqlsh> EXPAND ON ;
+Now Expanded output is enabled
+cqlsh> SELECT * FROM system_views.clients;
+
+@ Row 1
+--+-
+ address | 127.0.0.1
+ port | 50687
+ client_options | {'CQL_VERSION': '3.4.6', 'DRIVER_NAME': 'DataStax Python
Driver', 'DRIVER_VERSION': '3.25.0'}
+ connection_stage | ready
+ driver_name | DataStax Python Driver
+ driver_version | 3.25.0
+ hostname | localhost
+ protocol_version | 5
+ request_count| 16
+ ssl_cipher_suite | null
+ ssl_enabled | False
+ ssl_protocol | null
+ username | anonymous
+
+@ Row 2
+--+-
+ address | 127.0.0.1
+ port | 50688
+ client_options | {'CQL_VERSION': '3.4.6', 'DRIVER_NAME': 'DataStax Python
Driver', 'DRIVER_VERSION': '3.25.0'}
+ connection_stage | ready
+ driver_name | DataStax Python Driver
+ driver_version | 3.25.0
+ hostname | localhost
+ protocol_version | 5
+ request_count| 4
+ ssl_cipher_suite | null
+ ssl_enabled | False
+ ssl_protocol | null
+ username | anonymous
+
+@ Row 3
+--+-
+ address | 127.0.0.1
+ port | 50753
+ client_options | {'APPLICATION_NAME': 'TestApp', 'APPLICATION_VERSION':
'1.0.0', 'CLIENT_ID': '55b3efbd-c56b-469d-8cca-016b860b2f03', 'CQL_VERSION':
'3.0.0', 'DRIVER_NAME': 'DataStax Java driver for Apache Cassandra(R)',
'DRIVER_VERSION': '4.13.0'}
+ connection_stage | ready
+ driver_name | DataStax Java driver for Apache Cassandra(R)
+ driver_version | 4.13.0
+ hostname | localhost
+ protocol_version | 5
+ request_count| 18
+ ssl_cipher_suite | null
+ ssl_enabled | False
+ ssl_protocol | null
+ username | anonymous
+
+@ Row 4
[jira] [Commented] (CASSANDRA-18131) LongBTreeTest times out after btree improvements from CASSANDRA-15510
[ https://issues.apache.org/jira/browse/CASSANDRA-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698583#comment-17698583 ] Brandon Williams commented on CASSANDRA-18131: -- /cc [~blerer] > LongBTreeTest times out after btree improvements from CASSANDRA-15510 > - > > Key: CASSANDRA-18131 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18131 > Project: Cassandra > Issue Type: Bug > Components: Local/Memtable >Reporter: Michael Semb Wever >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > Happening in both ci-cassandra.a.o and circleci. > LongBTreeTest is timing out on 4.0, 4.1, trunk branches. > Started back in mid April > (https://github.com/apache/cassandra/commit/018c8e0d5e and > https://github.com/apache/cassandra/commit/596daeb7f08). > Nightlies shows when the failures started, evident by the > 'jdk=jdk_1.8_latest,label=cassandra,split=7/' subfolder missing in the > following… > - > https://nightlies.apache.org/cassandra/trunk/Cassandra-trunk-test-burn/1254/Cassandra-trunk-test-burn/ > - > https://nightlies.apache.org/cassandra/cassandra-4.0/Cassandra-4.0-test-burn/343/ -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18317) Properly synchronize CQLSSTableWriter#build on the Schema.instance
[
https://issues.apache.org/jira/browse/CASSANDRA-18317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francisco Guerrero updated CASSANDRA-18317:
---
Bug Category: Parent values: Correctness(12982)Level 1 values:
Unrecoverable Corruption / Loss(13161)
Complexity: Low Hanging Fruit
Discovered By: User Report
Reviewers: Yifan Cai
Severity: Normal
Status: Open (was: Triage Needed)
> Properly synchronize CQLSSTableWriter#build on the Schema.instance
> --
>
> Key: CASSANDRA-18317
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18317
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/bulk load
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
>
> The {{CQLSSTableWriter#build}} method should properly synchronize on the
> {{Schema.instance}} class to prevent concurrent Schema operations fail, [when
> the offline tool also updates schema].
> For example, a table creation operation, which modifies the keyspaces tables
> metadata, might end up missing the update when a concurrent call to the
> {{CQLSSTableWriter#build}} method is accessing the {{Schema}} instance.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18317) Properly synchronize CQLSSTableWriter#build on the Schema.instance
Francisco Guerrero created CASSANDRA-18317:
--
Summary: Properly synchronize CQLSSTableWriter#build on the
Schema.instance
Key: CASSANDRA-18317
URL: https://issues.apache.org/jira/browse/CASSANDRA-18317
Project: Cassandra
Issue Type: Bug
Components: Tool/bulk load
Reporter: Francisco Guerrero
Assignee: Francisco Guerrero
The {{CQLSSTableWriter#build}} method should properly synchronize on the
{{Schema.instance}} class to prevent concurrent Schema operations fail, [when
the offline tool also updates schema].
For example, a table creation operation, which modifies the keyspaces tables
metadata, might end up missing the update when a concurrent call to the
{{CQLSSTableWriter#build}} method is accessing the {{Schema}} instance.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18316) Add feature flag for dynamic data masking
[
https://issues.apache.org/jira/browse/CASSANDRA-18316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-18316:
--
Test and Documentation Plan:
||Patch||CI||
|[trunk|https://github.com/apache/cassandra/compare/trunk...adelapena:18316-trunk]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/2707/workflows/87f8fae7-8d4b-4838-9280-a9b3ee67f026]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/2707/workflows/78c1d6e0-aa96-4775-b6ff-771768940809]|
Status: Patch Available (was: In Progress)
> Add feature flag for dynamic data masking
> -
>
> Key: CASSANDRA-18316
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18316
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Dynamic Data Masking
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.x
>
>
> Dynamic data masking
> ([CEP-20|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-20%3A+Dynamic+Data+Masking])
> is a new feature, so it will need a feature flag in {{cassandra.yaml}}.
> Something like:
> {code}
> # If enabled, dynamic data masking allows to attach CQL masking functions to
> the columns of a table.
> # Users without the UNMASK permission will see an obscured version of the
> values of the columns with an attached mask.
> # If dynamic data masking is disabled it won't be allowed to create new
> column masks, although it will still be possible
> # to drop any previously existing masks. Also, any existing mask will be
> ignored at query time, so all users will see
> # the clear values of the masked columns.
> dynamic_data_masking_enabled: false
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18316) Add feature flag for dynamic data masking
[
https://issues.apache.org/jira/browse/CASSANDRA-18316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698557#comment-17698557
]
Andres de la Peña commented on CASSANDRA-18316:
---
Here is the patch adding the feature flag, on top of the other DDM patches:
||Patch||CI||
|[trunk|https://github.com/apache/cassandra/compare/trunk...adelapena:18316-trunk]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/2707/workflows/87f8fae7-8d4b-4838-9280-a9b3ee67f026]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/2707/workflows/78c1d6e0-aa96-4775-b6ff-771768940809]|
It forbids creating new masks if the yaml property
{{dynamic_data_masking_enabled}} is disabled. If DDM is disabled but there are
previously existing masks, those masks will be kept but they won't be applied.
Any existing masks can be dropped even if DDM is disabled, so users have a way
to get rid of the masks if they have disabled them due to some problem. This is
the same we do with, for example, {{{}user_defined_functions_enabled{}}}.
I'm intentionally not exposing the feature flag through JMX, so a malicious
user can’t disable it and expose the clear values.
[~Bereng] / [~blerer] would any of you have cycles to take a look? This should
be the last bit on DDM.
> Add feature flag for dynamic data masking
> -
>
> Key: CASSANDRA-18316
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18316
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Dynamic Data Masking
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.x
>
>
> Dynamic data masking
> ([CEP-20|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-20%3A+Dynamic+Data+Masking])
> is a new feature, so it will need a feature flag in {{cassandra.yaml}}.
> Something like:
> {code}
> # If enabled, dynamic data masking allows to attach CQL masking functions to
> the columns of a table.
> # Users without the UNMASK permission will see an obscured version of the
> values of the columns with an attached mask.
> # If dynamic data masking is disabled it won't be allowed to create new
> column masks, although it will still be possible
> # to drop any previously existing masks. Also, any existing mask will be
> ignored at query time, so all users will see
> # the clear values of the masked columns.
> dynamic_data_masking_enabled: false
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18316) Add feature flag for dynamic data masking
[
https://issues.apache.org/jira/browse/CASSANDRA-18316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-18316:
--
Change Category: Semantic
Complexity: Low Hanging Fruit
Fix Version/s: 5.x
Status: Open (was: Triage Needed)
> Add feature flag for dynamic data masking
> -
>
> Key: CASSANDRA-18316
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18316
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Dynamic Data Masking
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.x
>
>
> Dynamic data masking
> ([CEP-20|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-20%3A+Dynamic+Data+Masking])
> is a new feature, so it will need a feature flag in {{cassandra.yaml}}.
> Something like:
> {code}
> # If enabled, dynamic data masking allows to attach CQL masking functions to
> the columns of a table.
> # Users without the UNMASK permission will see an obscured version of the
> values of the columns with an attached mask.
> # If dynamic data masking is disabled it won't be allowed to create new
> column masks, although it will still be possible
> # to drop any previously existing masks. Also, any existing mask will be
> ignored at query time, so all users will see
> # the clear values of the masked columns.
> dynamic_data_masking_enabled: false
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18316) Add feature flag for dynamic data masking
[
https://issues.apache.org/jira/browse/CASSANDRA-18316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-18316:
--
Summary: Add feature flag for dynamic data masking (was: Add feature flag
for dynamic data masking.)
> Add feature flag for dynamic data masking
> -
>
> Key: CASSANDRA-18316
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18316
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Dynamic Data Masking
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
>
> Dynamic data masking
> ([CEP-20|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-20%3A+Dynamic+Data+Masking])
> is a new feature, so it will need a feature flag in {{cassandra.yaml}}.
> Something like:
> {code}
> # If enabled, dynamic data masking allows to attach CQL masking functions to
> the columns of a table.
> # Users without the UNMASK permission will see an obscured version of the
> values of the columns with an attached mask.
> # If dynamic data masking is disabled it won't be allowed to create new
> column masks, although it will still be possible
> # to drop any previously existing masks. Also, any existing mask will be
> ignored at query time, so all users will see
> # the clear values of the masked columns.
> dynamic_data_masking_enabled: false
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18316) Add feature flag for dynamic data masking.
Andres de la Peña created CASSANDRA-18316:
-
Summary: Add feature flag for dynamic data masking.
Key: CASSANDRA-18316
URL: https://issues.apache.org/jira/browse/CASSANDRA-18316
Project: Cassandra
Issue Type: New Feature
Components: Feature/Dynamic Data Masking
Reporter: Andres de la Peña
Assignee: Andres de la Peña
Dynamic data masking
([CEP-20|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-20%3A+Dynamic+Data+Masking])
is a new feature, so it will need a feature flag in {{cassandra.yaml}}.
Something like:
{code}
# If enabled, dynamic data masking allows to attach CQL masking functions to
the columns of a table.
# Users without the UNMASK permission will see an obscured version of the
values of the columns with an attached mask.
# If dynamic data masking is disabled it won't be allowed to create new column
masks, although it will still be possible
# to drop any previously existing masks. Also, any existing mask will be
ignored at query time, so all users will see
# the clear values of the masked columns.
dynamic_data_masking_enabled: false
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18315) Implement Concurrent Quiescent Checker
[ https://issues.apache.org/jira/browse/CASSANDRA-18315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698487#comment-17698487 ] Alex Petrov commented on CASSANDRA-18315: - Patch https://github.com/apache/cassandra-harry/pull/20 > Implement Concurrent Quiescent Checker > --- > > Key: CASSANDRA-18315 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18315 > Project: Cassandra > Issue Type: New Feature > Components: Test/fuzz >Reporter: Alex Petrov >Assignee: Alex Petrov >Priority: High > > It is possible to implement a concurrent quiescent checker, which allows for > a high degree of concurrency, while allowing to pinpoint partition state > precisely. > Additional minor improvements: > * formatting > * thread shutdown on failed run creation > * idempotent query execution > * retry delay -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18315) Implement Concurrent Quiescent Checker
[ https://issues.apache.org/jira/browse/CASSANDRA-18315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Petrov updated CASSANDRA-18315: Change Category: Quality Assurance Complexity: Challenging Reviewers: Abe Ratnofsky, Caleb Rackliffe Priority: High (was: Normal) Status: Open (was: Triage Needed) > Implement Concurrent Quiescent Checker > --- > > Key: CASSANDRA-18315 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18315 > Project: Cassandra > Issue Type: New Feature > Components: Test/fuzz >Reporter: Alex Petrov >Assignee: Alex Petrov >Priority: High > > It is possible to implement a concurrent quiescent checker, which allows for > a high degree of concurrency, while allowing to pinpoint partition state > precisely. > Additional minor improvements: > * formatting > * thread shutdown on failed run creation > * idempotent query execution > * retry delay -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18315) Implement Concurrent Quiescent Checker
[ https://issues.apache.org/jira/browse/CASSANDRA-18315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Petrov updated CASSANDRA-18315: Test and Documentation Plan: this is a test Status: Patch Available (was: Open) > Implement Concurrent Quiescent Checker > --- > > Key: CASSANDRA-18315 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18315 > Project: Cassandra > Issue Type: New Feature > Components: Test/fuzz >Reporter: Alex Petrov >Assignee: Alex Petrov >Priority: High > > It is possible to implement a concurrent quiescent checker, which allows for > a high degree of concurrency, while allowing to pinpoint partition state > precisely. > Additional minor improvements: > * formatting > * thread shutdown on failed run creation > * idempotent query execution > * retry delay -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-18315) Implement Concurrent Quiescent Checker
[ https://issues.apache.org/jira/browse/CASSANDRA-18315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Petrov reassigned CASSANDRA-18315: --- Assignee: Alex Petrov > Implement Concurrent Quiescent Checker > --- > > Key: CASSANDRA-18315 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18315 > Project: Cassandra > Issue Type: New Feature > Components: Test/fuzz >Reporter: Alex Petrov >Assignee: Alex Petrov >Priority: Normal > > It is possible to implement a concurrent quiescent checker, which allows for > a high degree of concurrency, while allowing to pinpoint partition state > precisely. > Additional minor improvements: > * formatting > * thread shutdown on failed run creation > * idempotent query execution > * retry delay -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18315) Implement Concurrent Quiescent Checker
[ https://issues.apache.org/jira/browse/CASSANDRA-18315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Petrov updated CASSANDRA-18315: Authors: Abe Ratnofsky, Alex Petrov (was: Alex Petrov) > Implement Concurrent Quiescent Checker > --- > > Key: CASSANDRA-18315 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18315 > Project: Cassandra > Issue Type: New Feature > Components: Test/fuzz >Reporter: Alex Petrov >Assignee: Alex Petrov >Priority: Normal > > It is possible to implement a concurrent quiescent checker, which allows for > a high degree of concurrency, while allowing to pinpoint partition state > precisely. > Additional minor improvements: > * formatting > * thread shutdown on failed run creation > * idempotent query execution > * retry delay -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18303) Feature documentation lost / moved out of focus
[ https://issues.apache.org/jira/browse/CASSANDRA-18303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18303: Status: Ready to Commit (was: Review In Progress) > Feature documentation lost / moved out of focus > --- > > Key: CASSANDRA-18303 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18303 > Project: Cassandra > Issue Type: Bug > Components: Documentation/Website >Reporter: Tibor Repasi >Assignee: Tibor Repasi >Priority: Normal > Fix For: 4.1.x, 5.x > > > Documentation added with CASSANDRA-17344 wasn't moved with CASSANDRA-17976 > and now the documentation on the website page "Cassandra/Operating/Virtual > tables" shows an outdated version for > [4.1|https://cassandra.apache.org/doc/4.1/cassandra/operating/virtualtables.html] > and > [latest|https://cassandra.apache.org/doc/latest/cassandra/operating/virtualtables.html]. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18303) Feature documentation lost / moved out of focus
[ https://issues.apache.org/jira/browse/CASSANDRA-18303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18303: Reviewers: Ekaterina Dimitrova, Michael Semb Wever (was: Michael Semb Wever) Status: Review In Progress (was: Needs Committer) > Feature documentation lost / moved out of focus > --- > > Key: CASSANDRA-18303 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18303 > Project: Cassandra > Issue Type: Bug > Components: Documentation/Website >Reporter: Tibor Repasi >Assignee: Tibor Repasi >Priority: Normal > Fix For: 4.1.x, 5.x > > > Documentation added with CASSANDRA-17344 wasn't moved with CASSANDRA-17976 > and now the documentation on the website page "Cassandra/Operating/Virtual > tables" shows an outdated version for > [4.1|https://cassandra.apache.org/doc/4.1/cassandra/operating/virtualtables.html] > and > [latest|https://cassandra.apache.org/doc/latest/cassandra/operating/virtualtables.html]. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18303) Feature documentation lost / moved out of focus
[ https://issues.apache.org/jira/browse/CASSANDRA-18303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698479#comment-17698479 ] Ekaterina Dimitrova commented on CASSANDRA-18303: - +1 from me too. I can commit it later today if [~mck] doesn't get to it before me > Feature documentation lost / moved out of focus > --- > > Key: CASSANDRA-18303 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18303 > Project: Cassandra > Issue Type: Bug > Components: Documentation/Website >Reporter: Tibor Repasi >Assignee: Tibor Repasi >Priority: Normal > Fix For: 4.1.x, 5.x > > > Documentation added with CASSANDRA-17344 wasn't moved with CASSANDRA-17976 > and now the documentation on the website page "Cassandra/Operating/Virtual > tables" shows an outdated version for > [4.1|https://cassandra.apache.org/doc/4.1/cassandra/operating/virtualtables.html] > and > [latest|https://cassandra.apache.org/doc/latest/cassandra/operating/virtualtables.html]. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18106) Update CCM for JDK17 and revise current JDK detection strategy
[ https://issues.apache.org/jira/browse/CASSANDRA-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698436#comment-17698436 ] Brandon Williams edited comment on CASSANDRA-18106 at 3/9/23 4:13 PM: -- We can remove jdk switching altogether, which I thought I did, but I missed that one. I've updated it and -am running again- it passed [here|https://app.circleci.com/pipelines/github/driftx/cassandra/901/workflows/30e2c354-80e9-4eb9-984f-e1f4629032e6/jobs/13076]. was (Author: brandon.williams): We can remove jdk switching altogether, which I thought I did, but I missed that one. I've updated it and am running again [here|https://app.circleci.com/pipelines/github/driftx/cassandra/901/workflows/30e2c354-80e9-4eb9-984f-e1f4629032e6/jobs/13076]. > Update CCM for JDK17 and revise current JDK detection strategy > -- > > Key: CASSANDRA-18106 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18106 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.x > > Attachments: Screenshot 2023-03-03 at 09.24.50.png > > > As part of CASSANDRA-16895 initial POC an initial version of CCM patch was > created. This needs to be revisited and reviewed > Recently we closed CASSANDRA-18039 which brought questions, probably we need > to revise how we detect JDK versions in CCM and whether it is correct. To the > best of my knowledge there are certain tests in the repo around that and they > pass so my guess is we need to revise just the strategy and maybe document it > explicitly or consider if we want any changes to be applied. Also, we need to > be careful with breaking changes. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18294) die disk failure policy will not kill jvm as documented
[ https://issues.apache.org/jira/browse/CASSANDRA-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18294: - Since Version: 3.0.22 (was: 3.0.27) > die disk failure policy will not kill jvm as documented > --- > > Key: CASSANDRA-18294 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18294 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Runtian Liu >Assignee: Runtian Liu >Priority: Normal > Fix For: 3.0.29, 4.0.9, 4.1.1, 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > After Cassandra has successfully starts up with disk_failure_policy die, when > encounter a file system error, Cassandra server will only throw exception > instead of shut down gossip and client transport and kill JVM. Document: > [https://cassandra.apache.org/doc/latest/cassandra/configuration/cass_yaml_file.html#disk_failure_policy] > > The reason for this is the default FS error handler is not handing policy die > correctly. Instead of shutting down gossip and native transport, it throws an > error. > > The JVMStabilityInspectorTest is passing because the error handler is not set > so no exception is thrown. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18294) die disk failure policy will not kill jvm as documented
[ https://issues.apache.org/jira/browse/CASSANDRA-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18294: - Since Version: 3.0.27 (was: 3.0.28) > die disk failure policy will not kill jvm as documented > --- > > Key: CASSANDRA-18294 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18294 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Runtian Liu >Assignee: Runtian Liu >Priority: Normal > Fix For: 3.0.29, 4.0.9, 4.1.1, 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > After Cassandra has successfully starts up with disk_failure_policy die, when > encounter a file system error, Cassandra server will only throw exception > instead of shut down gossip and client transport and kill JVM. Document: > [https://cassandra.apache.org/doc/latest/cassandra/configuration/cass_yaml_file.html#disk_failure_policy] > > The reason for this is the default FS error handler is not handing policy die > correctly. Instead of shutting down gossip and native transport, it throws an > error. > > The JVMStabilityInspectorTest is passing because the error handler is not set > so no exception is thrown. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18294) die disk failure policy will not kill jvm as documented
[ https://issues.apache.org/jira/browse/CASSANDRA-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18294: - Fix Version/s: 3.0.29 4.0.9 4.1.1 5.0 (was: 3.0.x) (was: 4.0.x) (was: 4.1.x) Since Version: 3.0.28 Source Control Link: https://github.com/apache/cassandra/commit/be574fc34ba9834929f1618ab63dd74446cd2683 Resolution: Fixed Status: Resolved (was: Ready to Commit) Committed, thanks everyone! > die disk failure policy will not kill jvm as documented > --- > > Key: CASSANDRA-18294 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18294 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Runtian Liu >Assignee: Runtian Liu >Priority: Normal > Fix For: 3.0.29, 4.0.9, 4.1.1, 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > After Cassandra has successfully starts up with disk_failure_policy die, when > encounter a file system error, Cassandra server will only throw exception > instead of shut down gossip and client transport and kill JVM. Document: > [https://cassandra.apache.org/doc/latest/cassandra/configuration/cass_yaml_file.html#disk_failure_policy] > > The reason for this is the default FS error handler is not handing policy die > correctly. Instead of shutting down gossip and native transport, it throws an > error. > > The JVMStabilityInspectorTest is passing because the error handler is not set > so no exception is thrown. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.0' into cassandra-4.1
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch cassandra-4.1
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit 0ea1d384d45765f8c8b1dbed8e7ce5595ca92412
Merge: 5f7175d59d a874e02eec
Author: Brandon Williams
AuthorDate: Thu Mar 9 10:03:42 2023 -0600
Merge branch 'cassandra-4.0' into cassandra-4.1
CHANGES.txt| 1 +
.../cassandra/service/DefaultFSErrorHandler.java | 2 +
...ava => JVMStabilityInspectorThrowableTest.java} | 75 +---
.../service/DefaultFSErrorHandlerTest.java | 121 ++
.../cassandra/service/DiskFailurePolicyTest.java | 135 +
.../org/apache/cassandra/utils/KillerForTests.java | 5 +
6 files changed, 323 insertions(+), 16 deletions(-)
diff --cc CHANGES.txt
index ae1a1a46e9,3aadd0c78c..beea5ba21f
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -23,8 -20,13 +23,9 @@@ Merged from 4.0
* Fix sstable loading of keyspaces named snapshots or backups
(CASSANDRA-14013)
* Avoid ConcurrentModificationException in STCS/DTCS/TWCS.getSSTables
(CASSANDRA-17977)
* Restore internode custom tracing on 4.0's new messaging system
(CASSANDRA-17981)
- * Harden parsing of boolean values in CQL in PropertyDefinitions
(CASSANDRA-17878)
- * Fix error message about type hints (CASSANDRA-17915)
- * Fix possible race condition on repair snapshots (CASSANDRA-17955)
- * Fix ASM bytecode version inconsistency (CASSANDRA-17873)
Merged from 3.11:
- * Fix Splitter sometimes creating more splits than requested
(CASSANDRA-18013)
Merged from 3.0:
++ * Fix default file system error handler for disk_failure_policy die
(CASSANDRA-18294)
* Introduce check for names of test classes (CASSANDRA-17964)
* Suppress CVE-2022-41915 (CASSANDRA-18147)
* Suppress CVE-2021-1471, CVE-2021-3064, CVE-2021-4235 (CASSANDRA-18149)
diff --cc
test/distributed/org/apache/cassandra/distributed/test/JVMStabilityInspectorThrowableTest.java
index 1bf2d22d1e,f8b9f010c8..665d58c12a
---
a/test/distributed/org/apache/cassandra/distributed/test/JVMStabilityInspectorThrowableTest.java
+++
b/test/distributed/org/apache/cassandra/distributed/test/JVMStabilityInspectorThrowableTest.java
@@@ -24,8 -26,9 +26,10 @@@ import java.util.Set
import org.junit.Assert;
import org.junit.Test;
+ import org.junit.runner.RunWith;
+ import org.junit.runners.Parameterized;
+import org.apache.cassandra.Util;
import org.apache.cassandra.config.Config.DiskFailurePolicy;
import org.apache.cassandra.db.ColumnFamilyStore;
import org.apache.cassandra.db.DecoratedKey;
@@@ -73,7 -102,6 +104,8 @@@ public class JVMStabilityInspectorThrow
String table = policy.name();
try (final Cluster cluster = init(getCluster(policy).start()))
{
- cluster.setUncaughtExceptionsFilter(t ->
Throwables.anyCauseMatches(t, t2 ->
t2.getClass().getCanonicalName().equals(CorruptSSTableException.class.getCanonicalName(;
++cluster.setUncaughtExceptionsFilter(t ->
Throwables.anyCauseMatches(
++t, t2 ->
Arrays.asList(CorruptSSTableException.class.getCanonicalName(),
FSReadError.class.getCanonicalName()).contains(t2.getClass().getCanonicalName(;
IInvokableInstance node = cluster.get(1);
boolean[] setup = node.callOnInstance(() -> {
CassandraDaemon instanceForTesting =
CassandraDaemon.getInstanceForTesting();
@@@ -190,15 -220,19 +224,19 @@@
}
@Override
-public UnfilteredRowIterator iterator(DecoratedKey key, Slices
slices, ColumnFilter selectedColumns, boolean reversed, SSTableReadsListener
listener)
+public UnfilteredRowIterator rowIterator(DecoratedKey key, Slices
slices, ColumnFilter selectedColumns, boolean reversed, SSTableReadsListener
listener)
{
- throw throwCorrupted();
+ if (shouldThrowCorrupted)
+ throw throwCorrupted();
+ throw throwFSError();
}
@Override
-public UnfilteredRowIterator iterator(FileDataInput file,
DecoratedKey key, RowIndexEntry indexEntry, Slices slices, ColumnFilter
selectedColumns, boolean reversed)
+public UnfilteredRowIterator rowIterator(FileDataInput file,
DecoratedKey key, RowIndexEntry indexEntry, Slices slices, ColumnFilter
selectedColumns, boolean reversed)
{
- throw throwCorrupted();
+ if (shouldThrowCorrupted)
+ throw throwCorrupted();
+ throw throwFSError();
}
private CorruptSSTableException throwCorrupted()
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.1' into trunk
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit bace51ce8e24a8c6a97ac35309536e8b1c8132be
Merge: f14fa978e4 0ea1d384d4
Author: Brandon Williams
AuthorDate: Thu Mar 9 10:04:52 2023 -0600
Merge branch 'cassandra-4.1' into trunk
CHANGES.txt| 1 +
.../cassandra/service/DefaultFSErrorHandler.java | 2 +
...ava => JVMStabilityInspectorThrowableTest.java} | 71 ---
.../service/DefaultFSErrorHandlerTest.java | 121 ++
.../cassandra/service/DiskFailurePolicyTest.java | 135 +
.../org/apache/cassandra/utils/KillerForTests.java | 5 +
6 files changed, 320 insertions(+), 15 deletions(-)
diff --cc
test/distributed/org/apache/cassandra/distributed/test/JVMStabilityInspectorThrowableTest.java
index 4ca4f707d7,665d58c12a..b63179b70e
---
a/test/distributed/org/apache/cassandra/distributed/test/JVMStabilityInspectorThrowableTest.java
+++
b/test/distributed/org/apache/cassandra/distributed/test/JVMStabilityInspectorThrowableTest.java
@@@ -40,10 -45,13 +44,12 @@@ import org.apache.cassandra.distributed
import org.apache.cassandra.distributed.shared.AbstractBuilder;
import org.apache.cassandra.distributed.shared.NetworkTopology;
import org.apache.cassandra.gms.Gossiper;
+ import org.apache.cassandra.io.FSError;
+ import org.apache.cassandra.io.FSReadError;
import org.apache.cassandra.io.sstable.CorruptSSTableException;
+import org.apache.cassandra.io.sstable.SSTableReadsListener;
import org.apache.cassandra.io.sstable.format.ForwardingSSTableReader;
import org.apache.cassandra.io.sstable.format.SSTableReader;
-import org.apache.cassandra.io.sstable.format.SSTableReadsListener;
-import org.apache.cassandra.io.util.FileDataInput;
import org.apache.cassandra.service.CassandraDaemon;
import org.apache.cassandra.service.StorageService;
import org.apache.cassandra.utils.Throwables;
@@@ -190,12 -226,27 +224,19 @@@ public class JVMStabilityInspectorThrow
@Override
public UnfilteredRowIterator rowIterator(DecoratedKey key, Slices
slices, ColumnFilter selectedColumns, boolean reversed, SSTableReadsListener
listener)
{
- throw throwCorrupted();
+ if (shouldThrowCorrupted)
+ throw throwCorrupted();
+ throw throwFSError();
}
-@Override
-public UnfilteredRowIterator rowIterator(FileDataInput file,
DecoratedKey key, RowIndexEntry indexEntry, Slices slices, ColumnFilter
selectedColumns, boolean reversed)
-{
-if (shouldThrowCorrupted)
-throw throwCorrupted();
-throw throwFSError();
-}
-
private CorruptSSTableException throwCorrupted()
{
-throw new CorruptSSTableException(new IOException("failed to get
position"), descriptor.baseFilename());
+throw new CorruptSSTableException(new IOException("failed to get
position"), descriptor.baseFile());
}
+
+ private FSError throwFSError()
+ {
-throw new FSReadError(new IOException("failed to get position"),
descriptor.baseFilename());
++throw new FSReadError(new IOException("failed to get position"),
descriptor.baseFile());
+ }
}
}
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (f14fa978e4 -> bace51ce8e)
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a change to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
from f14fa978e4 Upgrade to Opcodes.ASM9
new be574fc34b Fix default file system error handler for
disk_failure_policy die
new 326b5aceb1 Merge branch 'cassandra-3.0' into cassandra-3.11
new a874e02eec Merge branch 'cassandra-3.11' into cassandra-4.0
new 0ea1d384d4 Merge branch 'cassandra-4.0' into cassandra-4.1
new bace51ce8e Merge branch 'cassandra-4.1' into trunk
The 5 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
CHANGES.txt| 1 +
.../cassandra/service/DefaultFSErrorHandler.java | 2 +
...ava => JVMStabilityInspectorThrowableTest.java} | 71 ---
.../service/DefaultFSErrorHandlerTest.java | 121 ++
.../cassandra/service/DiskFailurePolicyTest.java | 135 +
.../org/apache/cassandra/utils/KillerForTests.java | 5 +
6 files changed, 320 insertions(+), 15 deletions(-)
rename
test/distributed/org/apache/cassandra/distributed/test/{JVMStabilityInspectorCorruptSSTableExceptionTest.java
=> JVMStabilityInspectorThrowableTest.java} (69%)
create mode 100644
test/unit/org/apache/cassandra/service/DefaultFSErrorHandlerTest.java
create mode 100644
test/unit/org/apache/cassandra/service/DiskFailurePolicyTest.java
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.11 updated (4b84a8d7ac -> 326b5aceb1)
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a change to branch cassandra-3.11
in repository https://gitbox.apache.org/repos/asf/cassandra.git
from 4b84a8d7ac Merge branch 'cassandra-3.0' into cassandra-3.11
new be574fc34b Fix default file system error handler for
disk_failure_policy die
new 326b5aceb1 Merge branch 'cassandra-3.0' into cassandra-3.11
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
CHANGES.txt| 1 +
.../cassandra/service/DefaultFSErrorHandler.java | 2 +
...ava => JVMStabilityInspectorThrowableTest.java} | 72 ---
.../service/DefaultFSErrorHandlerTest.java | 121 ++
.../cassandra/service/DiskFailurePolicyTest.java | 135 +
.../org/apache/cassandra/utils/KillerForTests.java | 6 +
6 files changed, 322 insertions(+), 15 deletions(-)
rename
test/distributed/org/apache/cassandra/distributed/test/{JVMStabilityInspectorCorruptSSTableExceptionTest.java
=> JVMStabilityInspectorThrowableTest.java} (70%)
create mode 100644
test/unit/org/apache/cassandra/service/DefaultFSErrorHandlerTest.java
create mode 100644
test/unit/org/apache/cassandra/service/DiskFailurePolicyTest.java
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.0 updated: Fix default file system error handler for disk_failure_policy die
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch cassandra-3.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-3.0 by this push:
new be574fc34b Fix default file system error handler for
disk_failure_policy die
be574fc34b is described below
commit be574fc34ba9834929f1618ab63dd74446cd2683
Author: Brandon Williams
AuthorDate: Thu Mar 9 09:53:58 2023 -0600
Fix default file system error handler for disk_failure_policy die
Patch by Runtian Liu; reviewed by brandonwilliams and smiklosovic for
CASSANDRA-18294
---
CHANGES.txt| 1 +
.../cassandra/service/DefaultFSErrorHandler.java | 2 +
...ava => JVMStabilityInspectorThrowableTest.java} | 72 ---
.../service/DefaultFSErrorHandlerTest.java | 121 ++
.../cassandra/service/DiskFailurePolicyTest.java | 135 +
.../org/apache/cassandra/utils/KillerForTests.java | 5 +
6 files changed, 321 insertions(+), 15 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index 7994824ad3..aa1e60427a 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
3.0.29
+ * Fix default file system error handler for disk_failure_policy die
(CASSANDRA-18294)
* Introduce check for names of test classes (CASSANDRA-17964)
* Suppress CVE-2022-41915 (CASSANDRA-18147)
* Suppress CVE-2021-1471, CVE-2021-3064, CVE-2021-4235 (CASSANDRA-18149)
diff --git a/src/java/org/apache/cassandra/service/DefaultFSErrorHandler.java
b/src/java/org/apache/cassandra/service/DefaultFSErrorHandler.java
index 1c81f65e44..00029e3f40 100644
--- a/src/java/org/apache/cassandra/service/DefaultFSErrorHandler.java
+++ b/src/java/org/apache/cassandra/service/DefaultFSErrorHandler.java
@@ -44,6 +44,7 @@ public class DefaultFSErrorHandler implements FSErrorHandler
switch (DatabaseDescriptor.getDiskFailurePolicy())
{
+case die:
case stop_paranoid:
// exception not logged here on purpose as it is already logged
logger.error("Stopping transports as disk_failure_policy is "
+ DatabaseDescriptor.getDiskFailurePolicy());
@@ -60,6 +61,7 @@ public class DefaultFSErrorHandler implements FSErrorHandler
switch (DatabaseDescriptor.getDiskFailurePolicy())
{
+case die:
case stop_paranoid:
case stop:
// exception not logged here on purpose as it is already logged
diff --git
a/test/distributed/org/apache/cassandra/distributed/test/JVMStabilityInspectorCorruptSSTableExceptionTest.java
b/test/distributed/org/apache/cassandra/distributed/test/JVMStabilityInspectorThrowableTest.java
similarity index 70%
rename from
test/distributed/org/apache/cassandra/distributed/test/JVMStabilityInspectorCorruptSSTableExceptionTest.java
rename to
test/distributed/org/apache/cassandra/distributed/test/JVMStabilityInspectorThrowableTest.java
index 98ca496ffc..d7aeccaf6f 100644
---
a/test/distributed/org/apache/cassandra/distributed/test/JVMStabilityInspectorCorruptSSTableExceptionTest.java
+++
b/test/distributed/org/apache/cassandra/distributed/test/JVMStabilityInspectorThrowableTest.java
@@ -19,11 +19,15 @@
package org.apache.cassandra.distributed.test;
import java.io.IOException;
+import java.util.Arrays;
+import java.util.Collection;
import java.util.HashSet;
import java.util.Set;
import org.junit.Assert;
import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
import org.apache.cassandra.config.Config.DiskFailurePolicy;
import org.apache.cassandra.db.ColumnFamilyStore;
@@ -39,6 +43,8 @@ import
org.apache.cassandra.distributed.api.IIsolatedExecutor.SerializableCallab
import org.apache.cassandra.distributed.shared.AbstractBuilder;
import org.apache.cassandra.distributed.shared.NetworkTopology;
import org.apache.cassandra.gms.Gossiper;
+import org.apache.cassandra.io.FSError;
+import org.apache.cassandra.io.FSReadError;
import org.apache.cassandra.io.sstable.CorruptSSTableException;
import org.apache.cassandra.io.sstable.format.ForwardingSSTableReader;
import org.apache.cassandra.io.sstable.format.SSTableReader;
@@ -51,21 +57,46 @@ import static
org.apache.cassandra.distributed.api.Feature.GOSSIP;
import static org.apache.cassandra.distributed.api.Feature.NATIVE_PROTOCOL;
import static org.apache.cassandra.distributed.api.Feature.NETWORK;
-public class JVMStabilityInspectorCorruptSSTableExceptionTest extends
TestBaseImpl
+@RunWith(Parameterized.class)
+public class JVMStabilityInspectorThrowableTest extends TestBaseImpl
{
-@Test
-public void
testAbstractLocalAwareExecutorServiceOnIgnoredDiskFailurePolicy() throws
Exception
+private DiskFailurePolicy testPolicy;
+private boolean testCorrupted;
+private boolean expectNativeTransportRunning;;
+
[jira] [Created] (CASSANDRA-18315) Implement Concurrent Quiescent Checker
Alex Petrov created CASSANDRA-18315: --- Summary: Implement Concurrent Quiescent Checker Key: CASSANDRA-18315 URL: https://issues.apache.org/jira/browse/CASSANDRA-18315 Project: Cassandra Issue Type: New Feature Components: Test/fuzz Reporter: Alex Petrov It is possible to implement a concurrent quiescent checker, which allows for a high degree of concurrency, while allowing to pinpoint partition state precisely. Additional minor improvements: * formatting * thread shutdown on failed run creation * idempotent query execution * retry delay -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.1 updated (5f7175d59d -> 0ea1d384d4)
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a change to branch cassandra-4.1
in repository https://gitbox.apache.org/repos/asf/cassandra.git
from 5f7175d59d Small fixes around Schema management
new be574fc34b Fix default file system error handler for
disk_failure_policy die
new 326b5aceb1 Merge branch 'cassandra-3.0' into cassandra-3.11
new a874e02eec Merge branch 'cassandra-3.11' into cassandra-4.0
new 0ea1d384d4 Merge branch 'cassandra-4.0' into cassandra-4.1
The 4 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
CHANGES.txt| 1 +
.../cassandra/service/DefaultFSErrorHandler.java | 2 +
...ava => JVMStabilityInspectorThrowableTest.java} | 75 +---
.../service/DefaultFSErrorHandlerTest.java | 121 ++
.../cassandra/service/DiskFailurePolicyTest.java | 135 +
.../org/apache/cassandra/utils/KillerForTests.java | 5 +
6 files changed, 323 insertions(+), 16 deletions(-)
rename
test/distributed/org/apache/cassandra/distributed/test/{JVMStabilityInspectorCorruptSSTableExceptionTest.java
=> JVMStabilityInspectorThrowableTest.java} (69%)
create mode 100644
test/unit/org/apache/cassandra/service/DefaultFSErrorHandlerTest.java
create mode 100644
test/unit/org/apache/cassandra/service/DiskFailurePolicyTest.java
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.11' into cassandra-4.0
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch cassandra-4.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit a874e02eecb282287929db6dfe76f1694c87a217
Merge: 40f9ca60f1 326b5aceb1
Author: Brandon Williams
AuthorDate: Thu Mar 9 10:02:33 2023 -0600
Merge branch 'cassandra-3.11' into cassandra-4.0
CHANGES.txt| 1 +
.../cassandra/service/DefaultFSErrorHandler.java | 2 +
...ava => JVMStabilityInspectorThrowableTest.java} | 72 ---
.../service/DefaultFSErrorHandlerTest.java | 121 ++
.../cassandra/service/DiskFailurePolicyTest.java | 135 +
.../org/apache/cassandra/utils/KillerForTests.java | 5 +
6 files changed, 321 insertions(+), 15 deletions(-)
diff --cc CHANGES.txt
index f2064c098e,2812ae77d1..3aadd0c78c
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,31 -1,7 +1,32 @@@
-3.11.15
- * Fix Splitter sometimes creating more splits than requested
(CASSANDRA-18013)
+4.0.9
+ * Improve memtable allocator accounting when updating AtomicBTreePartition
(CASSANDRA-18125)
+ * Update zstd-jni to version 1.5.4-1 (CASSANDRA-18259)
+ * Split and order IDEA workspace template VM_PARAMETERS (CASSANDRA-18242)
+Merged from 3.11:
Merged from 3.0:
+ * Fix default file system error handler for disk_failure_policy die
(CASSANDRA-18294)
+
+4.0.8
+ * Log warning message on aggregation queries without key or on multiple keys
(CASSANDRA-18219)
+ * Fix the output of FQL dump tool to properly separate entries
(CASSANDRA-18215)
+ * Add cache type information for maximum memory usage warning message
(CASSANDRA-18184)
+ * Fix NPE in fqltool dump on null value (CASSANDRA-18113)
+ * Improve unit tests performance (CASSANDRA-17427)
+ * Connect to listen address when own broadcast address is requested
(CASSANDRA-18200)
+ * Add safeguard so cleanup fails when node has pending ranges
(CASSANDRA-16418)
+ * Fix legacy clustering serialization for paging with compact storage
(CASSANDRA-17507)
+ * Add support for python 3.11 (CASSANDRA-18088)
+ * Fix formatting of duration in cqlsh (CASSANDRA-18141)
+ * Fix sstable loading of keyspaces named snapshots or backups
(CASSANDRA-14013)
+ * Avoid ConcurrentModificationException in STCS/DTCS/TWCS.getSSTables
(CASSANDRA-17977)
+ * Restore internode custom tracing on 4.0's new messaging system
(CASSANDRA-17981)
+ * Harden parsing of boolean values in CQL in PropertyDefinitions
(CASSANDRA-17878)
+ * Fix error message about type hints (CASSANDRA-17915)
+ * Fix possible race condition on repair snapshots (CASSANDRA-17955)
+ * Fix ASM bytecode version inconsistency (CASSANDRA-17873)
+Merged from 3.11:
+ * Fix Splitter sometimes creating more splits than requested
(CASSANDRA-18013)
+Merged from 3.0:
* Introduce check for names of test classes (CASSANDRA-17964)
* Suppress CVE-2022-41915 (CASSANDRA-18147)
* Suppress CVE-2021-1471, CVE-2021-3064, CVE-2021-4235 (CASSANDRA-18149)
diff --cc
test/distributed/org/apache/cassandra/distributed/test/JVMStabilityInspectorThrowableTest.java
index c7abfc5571,efe05ca1a6..f8b9f010c8
---
a/test/distributed/org/apache/cassandra/distributed/test/JVMStabilityInspectorThrowableTest.java
+++
b/test/distributed/org/apache/cassandra/distributed/test/JVMStabilityInspectorThrowableTest.java
@@@ -181,26 -212,35 +212,37 @@@ public class JVMStabilityInspectorThrow
private static final class CorruptedSSTableReader extends
ForwardingSSTableReader
{
- public CorruptedSSTableReader(SSTableReader delegate)
+ private boolean shouldThrowCorrupted;
+ public CorruptedSSTableReader(SSTableReader delegate, boolean
shouldThrowCorrupted)
{
super(delegate);
+ this.shouldThrowCorrupted = shouldThrowCorrupted;
}
-public UnfilteredRowIterator iterator(DecoratedKey key, Slices
slices, ColumnFilter selectedColumns, boolean reversed, boolean isForThrift,
SSTableReadsListener listener)
+@Override
+public UnfilteredRowIterator iterator(DecoratedKey key, Slices
slices, ColumnFilter selectedColumns, boolean reversed, SSTableReadsListener
listener)
{
- throw throwCorrupted();
+ if (shouldThrowCorrupted)
+ throw throwCorrupted();
+ throw throwFSError();
}
-public UnfilteredRowIterator iterator(FileDataInput file,
DecoratedKey key, RowIndexEntry indexEntry, Slices slices, ColumnFilter
selectedColumns, boolean reversed, boolean isForThrift)
+@Override
+public UnfilteredRowIterator iterator(FileDataInput file,
DecoratedKey key, RowIndexEntry indexEntry, Slices slices, ColumnFilter
selectedColumns, boolean reversed)
{
- throw throwCorrupted();
+ if (shouldThrowCorrupted)
+ throw throwCorrupted();
+
[cassandra] branch cassandra-4.0 updated (40f9ca60f1 -> a874e02eec)
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a change to branch cassandra-4.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
from 40f9ca60f1 Improve memtable allocator accounting when updating
AtomicBTreePartition
new be574fc34b Fix default file system error handler for
disk_failure_policy die
new 326b5aceb1 Merge branch 'cassandra-3.0' into cassandra-3.11
new a874e02eec Merge branch 'cassandra-3.11' into cassandra-4.0
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
CHANGES.txt| 1 +
.../cassandra/service/DefaultFSErrorHandler.java | 2 +
...ava => JVMStabilityInspectorThrowableTest.java} | 72 ---
.../service/DefaultFSErrorHandlerTest.java | 121 ++
.../cassandra/service/DiskFailurePolicyTest.java | 135 +
.../org/apache/cassandra/utils/KillerForTests.java | 5 +
6 files changed, 321 insertions(+), 15 deletions(-)
rename
test/distributed/org/apache/cassandra/distributed/test/{JVMStabilityInspectorCorruptSSTableExceptionTest.java
=> JVMStabilityInspectorThrowableTest.java} (70%)
create mode 100644
test/unit/org/apache/cassandra/service/DefaultFSErrorHandlerTest.java
create mode 100644
test/unit/org/apache/cassandra/service/DiskFailurePolicyTest.java
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-3.0' into cassandra-3.11
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch cassandra-3.11
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit 326b5aceb188912f377aac1e36485e0054605851
Merge: 4b84a8d7ac be574fc34b
Author: Brandon Williams
AuthorDate: Thu Mar 9 10:01:06 2023 -0600
Merge branch 'cassandra-3.0' into cassandra-3.11
CHANGES.txt| 1 +
.../cassandra/service/DefaultFSErrorHandler.java | 2 +
...ava => JVMStabilityInspectorThrowableTest.java} | 72 ---
.../service/DefaultFSErrorHandlerTest.java | 121 ++
.../cassandra/service/DiskFailurePolicyTest.java | 135 +
.../org/apache/cassandra/utils/KillerForTests.java | 6 +
6 files changed, 322 insertions(+), 15 deletions(-)
diff --cc CHANGES.txt
index c00315d495,aa1e60427a..2812ae77d1
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,6 -1,5 +1,7 @@@
-3.0.29
+3.11.15
+ * Fix Splitter sometimes creating more splits than requested
(CASSANDRA-18013)
+Merged from 3.0:
+ * Fix default file system error handler for disk_failure_policy die
(CASSANDRA-18294)
* Introduce check for names of test classes (CASSANDRA-17964)
* Suppress CVE-2022-41915 (CASSANDRA-18147)
* Suppress CVE-2021-1471, CVE-2021-3064, CVE-2021-4235 (CASSANDRA-18149)
diff --cc
test/distributed/org/apache/cassandra/distributed/test/JVMStabilityInspectorThrowableTest.java
index b9e8d679b8,d7aeccaf6f..efe05ca1a6
---
a/test/distributed/org/apache/cassandra/distributed/test/JVMStabilityInspectorThrowableTest.java
+++
b/test/distributed/org/apache/cassandra/distributed/test/JVMStabilityInspectorThrowableTest.java
@@@ -181,19 -211,27 +212,25 @@@ public class JVMStabilityInspectorThrow
private static final class CorruptedSSTableReader extends
ForwardingSSTableReader
{
- public CorruptedSSTableReader(SSTableReader delegate)
+ private boolean shouldThrowCorrupted;
+ public CorruptedSSTableReader(SSTableReader delegate, boolean
shouldThrowCorrupted)
{
super(delegate);
+ this.shouldThrowCorrupted = shouldThrowCorrupted;
}
-@Override
-public SliceableUnfilteredRowIterator iterator(DecoratedKey key,
ColumnFilter selectedColumns, boolean reversed, boolean isForThrift,
SSTableReadsListener listener)
+public UnfilteredRowIterator iterator(DecoratedKey key, Slices
slices, ColumnFilter selectedColumns, boolean reversed, boolean isForThrift,
SSTableReadsListener listener)
{
- throw throwCorrupted();
+ if (shouldThrowCorrupted)
+ throw throwCorrupted();
+ throw throwFSError();
}
-@Override
-public SliceableUnfilteredRowIterator iterator(FileDataInput file,
DecoratedKey key, RowIndexEntry indexEntry, ColumnFilter selectedColumns,
boolean reversed, boolean isForThrift)
+public UnfilteredRowIterator iterator(FileDataInput file,
DecoratedKey key, RowIndexEntry indexEntry, Slices slices, ColumnFilter
selectedColumns, boolean reversed, boolean isForThrift)
{
- throw throwCorrupted();
+ if (shouldThrowCorrupted)
+ throw throwCorrupted();
+ throw throwFSError();
}
private CorruptSSTableException throwCorrupted()
diff --cc test/unit/org/apache/cassandra/utils/KillerForTests.java
index fe9aa4599c,ad3a27436e..a802809722
--- a/test/unit/org/apache/cassandra/utils/KillerForTests.java
+++ b/test/unit/org/apache/cassandra/utils/KillerForTests.java
@@@ -42,9 -29,11 +42,15 @@@ public class KillerForTests extends JVM
@Override
protected void killCurrentJVM(Throwable t, boolean quiet)
{
+if (!expected)
+Assert.fail("Saw JVM Kill but did not expect it.");
+
+ if (killed)
+ {
+ // Can only be killed once
+ return;
+ }
++
this.killed = true;
this.quiet = quiet;
}
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18303) Feature documentation lost / moved out of focus
[ https://issues.apache.org/jira/browse/CASSANDRA-18303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-18303: --- Reviewers: Michael Semb Wever > Feature documentation lost / moved out of focus > --- > > Key: CASSANDRA-18303 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18303 > Project: Cassandra > Issue Type: Bug > Components: Documentation/Website >Reporter: Tibor Repasi >Assignee: Tibor Repasi >Priority: Normal > Fix For: 4.1.x, 5.x > > > Documentation added with CASSANDRA-17344 wasn't moved with CASSANDRA-17976 > and now the documentation on the website page "Cassandra/Operating/Virtual > tables" shows an outdated version for > [4.1|https://cassandra.apache.org/doc/4.1/cassandra/operating/virtualtables.html] > and > [latest|https://cassandra.apache.org/doc/latest/cassandra/operating/virtualtables.html]. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18303) Feature documentation lost / moved out of focus
[ https://issues.apache.org/jira/browse/CASSANDRA-18303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-18303: --- Status: Needs Committer (was: Patch Available) > Feature documentation lost / moved out of focus > --- > > Key: CASSANDRA-18303 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18303 > Project: Cassandra > Issue Type: Bug > Components: Documentation/Website >Reporter: Tibor Repasi >Assignee: Tibor Repasi >Priority: Normal > Fix For: 4.1.x, 5.x > > > Documentation added with CASSANDRA-17344 wasn't moved with CASSANDRA-17976 > and now the documentation on the website page "Cassandra/Operating/Virtual > tables" shows an outdated version for > [4.1|https://cassandra.apache.org/doc/4.1/cassandra/operating/virtualtables.html] > and > [latest|https://cassandra.apache.org/doc/latest/cassandra/operating/virtualtables.html]. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18304) hinted_handoff_enabled=false is not honored
[
https://issues.apache.org/jira/browse/CASSANDRA-18304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698453#comment-17698453
]
Aleksey Yeschenko commented on CASSANDRA-18304:
---
As for the {{shouldHint()}} check, that could easily live in
{{{}AbstractWriteResponseHandler#onFailure(){}}}, which would be a more direct
translation of previous logic, without risk of unintended consequences of
introducing filtering to the {{StorageProxy}} method.
{code}
if (hintOnFailure != null &&
StorageProxy.shouldHint(replicaPlan.lookup(from)))
{
StorageProxy.submitHint(hintOnFailure.get(),
replicaPlan.lookup(from), null);
}
{code}
> hinted_handoff_enabled=false is not honored
> ---
>
> Key: CASSANDRA-18304
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18304
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Hints
>Reporter: Paulo Motta
>Assignee: Paulo Motta
>Priority: Normal
> Fix For: 4.1.x, 5.x
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> I've had some dtests with disabled hints failing.
> After investigation it seems that CASSANDRA-17164 moved hint submission on
> timeout from
> [RequestCallbacks.onExpired|https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b#diff-b73c13ea8cae91a215495917fe5e90d55c9f4a283f9e053110992bc9a60004b8L176]
> to
> [AbstractWriteResponseHandler.onFailure|https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b#diff-3b202de0d077638bede7bf4076a15eb4d483b717f955f11e743efb8d27c6eb1dR285],
> but it no longer checks if {{CallbackInfo.shouldHint}} which checks for
> {{StorageProxy.shouldHint}} which ultimately checks if
> {{{}hinted_handoff_enabled=true{}}}.
> This could cause some tests which expect hints to be disabled to fail
> intermittently.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18303) Feature documentation lost / moved out of focus
[ https://issues.apache.org/jira/browse/CASSANDRA-18303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698452#comment-17698452 ] Michael Semb Wever commented on CASSANDRA-18303: +1 > Feature documentation lost / moved out of focus > --- > > Key: CASSANDRA-18303 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18303 > Project: Cassandra > Issue Type: Bug > Components: Documentation/Website >Reporter: Tibor Repasi >Assignee: Tibor Repasi >Priority: Normal > Fix For: 4.1.x, 5.x > > > Documentation added with CASSANDRA-17344 wasn't moved with CASSANDRA-17976 > and now the documentation on the website page "Cassandra/Operating/Virtual > tables" shows an outdated version for > [4.1|https://cassandra.apache.org/doc/4.1/cassandra/operating/virtualtables.html] > and > [latest|https://cassandra.apache.org/doc/latest/cassandra/operating/virtualtables.html]. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18312) Drop support for sstable formats before `na`
[
https://issues.apache.org/jira/browse/CASSANDRA-18312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698450#comment-17698450
]
Michael Semb Wever commented on CASSANDRA-18312:
bq. When did we agree this?
The statement is indeed questioned in the description.
bq. This should have a DISCUSS thread.
There will be, as mentioned in the epic's description.
> Drop support for sstable formats before `na`
>
>
> Key: CASSANDRA-18312
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18312
> Project: Cassandra
> Issue Type: Task
> Components: Local/SSTable
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 5.x
>
>
> From 5.0 sstable formats before {{\-na\-}} are unsupported.
> This patch cleans up code related to the older formats.
> https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/18312/trunk
>
> Raises the question whether backward compatibility to the previous major is
> defined by the Cassandra version or by the internal component version
> (sstable format).
> Also raises the question on whether downstream forks are wanting to support
> such upgrade paths, e.g. offline, and to what versions the {{sstableupgrade}}
> tool supports. This also touches on recent discussions around
> [Downgradability|https://lists.apache.org/thread/tcp339k5ph8ql35wxr085to4qgp8tpg7].
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18312) Drop support for sstable formats before `na`
[
https://issues.apache.org/jira/browse/CASSANDRA-18312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698445#comment-17698445
]
Benedict Elliott Smith commented on CASSANDRA-18312:
bq. From 5.0 sstable formats before -na- are unsupported.
When did we agree this? This should have a DISCUSS thread.
> Drop support for sstable formats before `na`
>
>
> Key: CASSANDRA-18312
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18312
> Project: Cassandra
> Issue Type: Task
> Components: Local/SSTable
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 5.x
>
>
> From 5.0 sstable formats before {{\-na\-}} are unsupported.
> This patch cleans up code related to the older formats.
> https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/18312/trunk
>
> Raises the question whether backward compatibility to the previous major is
> defined by the Cassandra version or by the internal component version
> (sstable format).
> Also raises the question on whether downstream forks are wanting to support
> such upgrade paths, e.g. offline, and to what versions the {{sstableupgrade}}
> tool supports. This also touches on recent discussions around
> [Downgradability|https://lists.apache.org/thread/tcp339k5ph8ql35wxr085to4qgp8tpg7].
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18106) Update CCM for JDK17 and revise current JDK detection strategy
[ https://issues.apache.org/jira/browse/CASSANDRA-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698436#comment-17698436 ] Brandon Williams commented on CASSANDRA-18106: -- We can remove jdk switching altogether, which I thought I did, but I missed that one. I've updated it and am running again [here|https://app.circleci.com/pipelines/github/driftx/cassandra/901/workflows/30e2c354-80e9-4eb9-984f-e1f4629032e6/jobs/13076]. > Update CCM for JDK17 and revise current JDK detection strategy > -- > > Key: CASSANDRA-18106 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18106 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.x > > Attachments: Screenshot 2023-03-03 at 09.24.50.png > > > As part of CASSANDRA-16895 initial POC an initial version of CCM patch was > created. This needs to be revisited and reviewed > Recently we closed CASSANDRA-18039 which brought questions, probably we need > to revise how we detect JDK versions in CCM and whether it is correct. To the > best of my knowledge there are certain tests in the repo around that and they > pass so my guess is we need to revise just the strategy and maybe document it > explicitly or consider if we want any changes to be applied. Also, we need to > be careful with breaking changes. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18106) Update CCM for JDK17 and revise current JDK detection strategy
[
https://issues.apache.org/jira/browse/CASSANDRA-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698435#comment-17698435
]
Michael Semb Wever commented on CASSANDRA-18106:
Can we avoid the switch if the requested jdk is the current jdk ? (or just
remove {{.java_version}} from {{test_version_metas}} as suggested to do
afterwards…?)
ref:
https://github.com/apache/cassandra-dtest/blob/trunk/upgrade_tests/upgrade_through_versions_test.py#L331
> Update CCM for JDK17 and revise current JDK detection strategy
> --
>
> Key: CASSANDRA-18106
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18106
> Project: Cassandra
> Issue Type: Task
> Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.x
>
> Attachments: Screenshot 2023-03-03 at 09.24.50.png
>
>
> As part of CASSANDRA-16895 initial POC an initial version of CCM patch was
> created. This needs to be revisited and reviewed
> Recently we closed CASSANDRA-18039 which brought questions, probably we need
> to revise how we detect JDK versions in CCM and whether it is correct. To the
> best of my knowledge there are certain tests in the repo around that and they
> pass so my guess is we need to revise just the strategy and maybe document it
> explicitly or consider if we want any changes to be applied. Also, we need to
> be careful with breaking changes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18312) Drop support for sstable formats before `na`
[
https://issues.apache.org/jira/browse/CASSANDRA-18312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Semb Wever updated CASSANDRA-18312:
---
Description:
>From 5.0 sstable formats before {{\-na\-}} are unsupported.
This patch cleans up code related to the older formats.
https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/18312/trunk
Raises the question whether backward compatibility to the previous major is
defined by the Cassandra version or by the internal component version (sstable
format).
Also raises the question on whether downstream forks are wanting to support
such upgrade paths, e.g. offline, and to what versions the {{sstableupgrade}}
tool supports. This also touches on recent discussions around
[Downgradability|https://lists.apache.org/thread/tcp339k5ph8ql35wxr085to4qgp8tpg7].
was:
>From 5.0 sstable formats before {{\-na\-}} are unsupported.
This patch cleans up code related to the older formats.
https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/18312/trunk
Raises the question whether backward compatibility to the previous major is
defined by the Cassandra version or by the internal component version (sstable
format).
> Drop support for sstable formats before `na`
>
>
> Key: CASSANDRA-18312
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18312
> Project: Cassandra
> Issue Type: Task
> Components: Local/SSTable
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 5.x
>
>
> From 5.0 sstable formats before {{\-na\-}} are unsupported.
> This patch cleans up code related to the older formats.
> https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/18312/trunk
>
> Raises the question whether backward compatibility to the previous major is
> defined by the Cassandra version or by the internal component version
> (sstable format).
> Also raises the question on whether downstream forks are wanting to support
> such upgrade paths, e.g. offline, and to what versions the {{sstableupgrade}}
> tool supports. This also touches on recent discussions around
> [Downgradability|https://lists.apache.org/thread/tcp339k5ph8ql35wxr085to4qgp8tpg7].
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18106) Update CCM for JDK17 and revise current JDK detection strategy
[
https://issues.apache.org/jira/browse/CASSANDRA-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698421#comment-17698421
]
Ekaterina Dimitrova edited comment on CASSANDRA-18106 at 3/9/23 2:57 PM:
-
Maybe we look at different links?
I see
[here|https://app.circleci.com/pipelines/github/driftx/cassandra/901/workflows/c2bf3302-4eb4-4e70-95dc-2ce419ad56af/jobs/13028]
(took it from the last table, trunk
[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/901/workflows/c2bf3302-4eb4-4e70-95dc-2ce419ad56af]
you posted earlier, maybe you have newer run):
{code:java}
test_parallel_upgrade failed and was not selected for rerun.
You need to set JAVA8_HOME to run these tests!{code}
was (Author: e.dimitrova):
Maybe we look at different links?
I see
[here|https://app.circleci.com/pipelines/github/driftx/cassandra/901/workflows/c2bf3302-4eb4-4e70-95dc-2ce419ad56af/jobs/13028]
(took it from the last table trunk
[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/901/workflows/c2bf3302-4eb4-4e70-95dc-2ce419ad56af]
you posted earlier, maybe you have newer run):
{code:java}
test_parallel_upgrade failed and was not selected for rerun.
You need to set JAVA8_HOME to run these tests!{code}
> Update CCM for JDK17 and revise current JDK detection strategy
> --
>
> Key: CASSANDRA-18106
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18106
> Project: Cassandra
> Issue Type: Task
> Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.x
>
> Attachments: Screenshot 2023-03-03 at 09.24.50.png
>
>
> As part of CASSANDRA-16895 initial POC an initial version of CCM patch was
> created. This needs to be revisited and reviewed
> Recently we closed CASSANDRA-18039 which brought questions, probably we need
> to revise how we detect JDK versions in CCM and whether it is correct. To the
> best of my knowledge there are certain tests in the repo around that and they
> pass so my guess is we need to revise just the strategy and maybe document it
> explicitly or consider if we want any changes to be applied. Also, we need to
> be careful with breaking changes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18106) Update CCM for JDK17 and revise current JDK detection strategy
[
https://issues.apache.org/jira/browse/CASSANDRA-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698421#comment-17698421
]
Ekaterina Dimitrova edited comment on CASSANDRA-18106 at 3/9/23 2:57 PM:
-
Maybe we look at different links?
I see
[here|https://app.circleci.com/pipelines/github/driftx/cassandra/901/workflows/c2bf3302-4eb4-4e70-95dc-2ce419ad56af/jobs/13028]
(took it from the last table trunk
[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/901/workflows/c2bf3302-4eb4-4e70-95dc-2ce419ad56af]
you posted earlier, maybe you have newer run):
{code:java}
test_parallel_upgrade failed and was not selected for rerun.
You need to set JAVA8_HOME to run these tests!{code}
was (Author: e.dimitrova):
Maybe we look at different links?
I see
[here|https://app.circleci.com/pipelines/github/driftx/cassandra/901/workflows/c2bf3302-4eb4-4e70-95dc-2ce419ad56af/jobs/13028]
(took it from the last table trunk you posted, maybe you have newer run):
{code:java}
test_parallel_upgrade failed and was not selected for rerun.
You need to set JAVA8_HOME to run these tests!{code}
> Update CCM for JDK17 and revise current JDK detection strategy
> --
>
> Key: CASSANDRA-18106
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18106
> Project: Cassandra
> Issue Type: Task
> Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.x
>
> Attachments: Screenshot 2023-03-03 at 09.24.50.png
>
>
> As part of CASSANDRA-16895 initial POC an initial version of CCM patch was
> created. This needs to be revisited and reviewed
> Recently we closed CASSANDRA-18039 which brought questions, probably we need
> to revise how we detect JDK versions in CCM and whether it is correct. To the
> best of my knowledge there are certain tests in the repo around that and they
> pass so my guess is we need to revise just the strategy and maybe document it
> explicitly or consider if we want any changes to be applied. Also, we need to
> be careful with breaking changes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18106) Update CCM for JDK17 and revise current JDK detection strategy
[
https://issues.apache.org/jira/browse/CASSANDRA-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698421#comment-17698421
]
Ekaterina Dimitrova edited comment on CASSANDRA-18106 at 3/9/23 2:56 PM:
-
Maybe we look at different links?
I see
[here|https://app.circleci.com/pipelines/github/driftx/cassandra/901/workflows/c2bf3302-4eb4-4e70-95dc-2ce419ad56af/jobs/13028]
(took it from the last table trunk you posted, maybe you have newer run):
{code:java}
test_parallel_upgrade failed and was not selected for rerun.
You need to set JAVA8_HOME to run these tests!{code}
was (Author: e.dimitrova):
Maybe we look at different links?
I see
[here|https://app.circleci.com/pipelines/github/driftx/cassandra/901/workflows/c2bf3302-4eb4-4e70-95dc-2ce419ad56af/jobs/13028]:
{code:java}
test_parallel_upgrade failed and was not selected for rerun.
You need to set JAVA8_HOME to run these tests!{code}
> Update CCM for JDK17 and revise current JDK detection strategy
> --
>
> Key: CASSANDRA-18106
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18106
> Project: Cassandra
> Issue Type: Task
> Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.x
>
> Attachments: Screenshot 2023-03-03 at 09.24.50.png
>
>
> As part of CASSANDRA-16895 initial POC an initial version of CCM patch was
> created. This needs to be revisited and reviewed
> Recently we closed CASSANDRA-18039 which brought questions, probably we need
> to revise how we detect JDK versions in CCM and whether it is correct. To the
> best of my knowledge there are certain tests in the repo around that and they
> pass so my guess is we need to revise just the strategy and maybe document it
> explicitly or consider if we want any changes to be applied. Also, we need to
> be careful with breaking changes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18106) Update CCM for JDK17 and revise current JDK detection strategy
[
https://issues.apache.org/jira/browse/CASSANDRA-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698421#comment-17698421
]
Ekaterina Dimitrova commented on CASSANDRA-18106:
-
Maybe we look at different links?
I see
[here|https://app.circleci.com/pipelines/github/driftx/cassandra/901/workflows/c2bf3302-4eb4-4e70-95dc-2ce419ad56af/jobs/13028]:
{code:java}
test_parallel_upgrade failed and was not selected for rerun.
You need to set JAVA8_HOME to run these tests!{code}
> Update CCM for JDK17 and revise current JDK detection strategy
> --
>
> Key: CASSANDRA-18106
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18106
> Project: Cassandra
> Issue Type: Task
> Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.x
>
> Attachments: Screenshot 2023-03-03 at 09.24.50.png
>
>
> As part of CASSANDRA-16895 initial POC an initial version of CCM patch was
> created. This needs to be revisited and reviewed
> Recently we closed CASSANDRA-18039 which brought questions, probably we need
> to revise how we detect JDK versions in CCM and whether it is correct. To the
> best of my knowledge there are certain tests in the repo around that and they
> pass so my guess is we need to revise just the strategy and maybe document it
> explicitly or consider if we want any changes to be applied. Also, we need to
> be careful with breaking changes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (3869d79d -> 18c70646)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 3869d79d generate docs for c4206294 new 18c70646 generate docs for c4206294 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (3869d79d) \ N -- N -- N refs/heads/asf-staging (18c70646) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: site-ui/build/ui-bundle.zip | Bin 4796442 -> 4796442 bytes 1 file changed, 0 insertions(+), 0 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18106) Update CCM for JDK17 and revise current JDK detection strategy
[ https://issues.apache.org/jira/browse/CASSANDRA-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698412#comment-17698412 ] Brandon Williams commented on CASSANDRA-18106: -- I don't see any jdk-related failures. > Update CCM for JDK17 and revise current JDK detection strategy > -- > > Key: CASSANDRA-18106 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18106 > Project: Cassandra > Issue Type: Task > Components: CI >Reporter: Ekaterina Dimitrova >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.x > > Attachments: Screenshot 2023-03-03 at 09.24.50.png > > > As part of CASSANDRA-16895 initial POC an initial version of CCM patch was > created. This needs to be revisited and reviewed > Recently we closed CASSANDRA-18039 which brought questions, probably we need > to revise how we detect JDK versions in CCM and whether it is correct. To the > best of my knowledge there are certain tests in the repo around that and they > pass so my guess is we need to revise just the strategy and maybe document it > explicitly or consider if we want any changes to be applied. Also, we need to > be careful with breaking changes. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18311) BufferPool incorrectly counts memoryInUse when putUnusedPortion is used
[ https://issues.apache.org/jira/browse/CASSANDRA-18311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacek Lewandowski updated CASSANDRA-18311: -- Test and Documentation Plan: regression tests + new test Status: Patch Available (was: Open) > BufferPool incorrectly counts memoryInUse when putUnusedPortion is used > --- > > Key: CASSANDRA-18311 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18311 > Project: Cassandra > Issue Type: Bug > Components: Local/Caching >Reporter: Jaroslaw Grabowski >Assignee: Jaroslaw Grabowski >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > The counter is incorrectly decremented by the size of the unused portion of > the provided buffer. > It should be decremented by the number of bytes actually returned to the pool > (that may be different than "size"). The number should be calculated as a > difference between original and resulting buffer capacity. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18311) BufferPool incorrectly counts memoryInUse when putUnusedPortion is used
[ https://issues.apache.org/jira/browse/CASSANDRA-18311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacek Lewandowski updated CASSANDRA-18311: -- Bug Category: Parent values: Correctness(12982) Complexity: Low Hanging Fruit Component/s: Local/Caching Discovered By: User Report Fix Version/s: 4.0.x 4.1.x 5.0 Severity: Low Status: Open (was: Triage Needed) +1, thanks for the patch > BufferPool incorrectly counts memoryInUse when putUnusedPortion is used > --- > > Key: CASSANDRA-18311 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18311 > Project: Cassandra > Issue Type: Bug > Components: Local/Caching >Reporter: Jaroslaw Grabowski >Assignee: Jaroslaw Grabowski >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > The counter is incorrectly decremented by the size of the unused portion of > the provided buffer. > It should be decremented by the number of bytes actually returned to the pool > (that may be different than "size"). The number should be calculated as a > difference between original and resulting buffer capacity. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18314) Lift MessagingService.minimum_version to 40
[ https://issues.apache.org/jira/browse/CASSANDRA-18314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-18314: --- Description: MessagingService's VERSION_30 and VERSION_3014 don't have to be supported in Cassandra 5.0 anymore. (Cassandra 5.0 currently is still using VERSION_40) Patch: https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/18314/trunk Raises the question whether backward compatibility to the previous major is defined by the Cassandra version or by the internal component version (MessagingService). was: MessagingService's VERSION_30 and VERSION_3014 don't have to be supported in Cassandra 5.0 anymore. (Cassandra 5.0 currently is still using VERSION_40) Patch: https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/18314/trunk > Lift MessagingService.minimum_version to 40 > --- > > Key: CASSANDRA-18314 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18314 > Project: Cassandra > Issue Type: Task > Components: Messaging/Internode >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 5.x > > > MessagingService's VERSION_30 and VERSION_3014 don't have to be supported in > Cassandra 5.0 anymore. > (Cassandra 5.0 currently is still using VERSION_40) > Patch: > https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/18314/trunk > Raises the question whether backward compatibility to the previous major is > defined by the Cassandra version or by the internal component version > (MessagingService). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18312) Drop support for sstable formats before `na`
[
https://issues.apache.org/jira/browse/CASSANDRA-18312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Semb Wever updated CASSANDRA-18312:
---
Description:
>From 5.0 sstable formats before {{\-na\-}} are unsupported.
This patch cleans up code related to the older formats.
https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/18312/trunk
Raises the question whether backward compatibility to the previous major is
defined by the Cassandra version or by the internal component version (sstable
format).
was:
>From 5.0 sstable formats before {{\-na\-}} are unsupported.
This patch cleans up code related to the older formats.
https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/18312/trunk
> Drop support for sstable formats before `na`
>
>
> Key: CASSANDRA-18312
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18312
> Project: Cassandra
> Issue Type: Task
> Components: Local/SSTable
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 5.x
>
>
> From 5.0 sstable formats before {{\-na\-}} are unsupported.
> This patch cleans up code related to the older formats.
> https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/18312/trunk
>
> Raises the question whether backward compatibility to the previous major is
> defined by the Cassandra version or by the internal component version
> (sstable format).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18311) BufferPool incorrectly counts memoryInUse when putUnusedPortion is used
[ https://issues.apache.org/jira/browse/CASSANDRA-18311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698328#comment-17698328 ] Jaroslaw Grabowski edited comment on CASSANDRA-18311 at 3/9/23 1:40 PM: [https://github.com/apache/cassandra/pull/2206] (trunk) [https://github.com/jtgrabowski/cassandra/tree/CASSANDRA-18311-4.1] (4.1) [https://github.com/jtgrabowski/cassandra/tree/CASSANDRA-18311-4.0] (4.0) was (Author: jtgrabowski): https://github.com/apache/cassandra/pull/2206 > BufferPool incorrectly counts memoryInUse when putUnusedPortion is used > --- > > Key: CASSANDRA-18311 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18311 > Project: Cassandra > Issue Type: Bug >Reporter: Jaroslaw Grabowski >Assignee: Jaroslaw Grabowski >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > The counter is incorrectly decremented by the size of the unused portion of > the provided buffer. > It should be decremented by the number of bytes actually returned to the pool > (that may be different than "size"). The number should be calculated as a > difference between original and resulting buffer capacity. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18304) hinted_handoff_enabled=false is not honored
[
https://issues.apache.org/jira/browse/CASSANDRA-18304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksey Yeschenko updated CASSANDRA-18304:
--
Reviewers: Aleksey Yeschenko, Stefan Miklosovic (was: Stefan Miklosovic)
> hinted_handoff_enabled=false is not honored
> ---
>
> Key: CASSANDRA-18304
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18304
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Hints
>Reporter: Paulo Motta
>Assignee: Paulo Motta
>Priority: Normal
> Fix For: 4.1.x, 5.x
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> I've had some dtests with disabled hints failing.
> After investigation it seems that CASSANDRA-17164 moved hint submission on
> timeout from
> [RequestCallbacks.onExpired|https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b#diff-b73c13ea8cae91a215495917fe5e90d55c9f4a283f9e053110992bc9a60004b8L176]
> to
> [AbstractWriteResponseHandler.onFailure|https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b#diff-3b202de0d077638bede7bf4076a15eb4d483b717f955f11e743efb8d27c6eb1dR285],
> but it no longer checks if {{CallbackInfo.shouldHint}} which checks for
> {{StorageProxy.shouldHint}} which ultimately checks if
> {{{}hinted_handoff_enabled=true{}}}.
> This could cause some tests which expect hints to be disabled to fail
> intermittently.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18304) hinted_handoff_enabled=false is not honored
[
https://issues.apache.org/jira/browse/CASSANDRA-18304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698376#comment-17698376
]
Aleksey Yeschenko commented on CASSANDRA-18304:
---
So, {{WriteCallbackInfo}} code is all dead weight and should be removed. Pushed
a commit that does it here:
https://github.com/iamaleksey/cassandra/commits/18304-dead-code-removal
{{allowHints}} argument to some of the upstream methods needs to make its way
to {{AbstractWriteResponseHandler}}, or, alternatively, we need to make sure
that mutation supplier is always null when when {{!allowHints}} and never null
when {{allowHints}}.
> hinted_handoff_enabled=false is not honored
> ---
>
> Key: CASSANDRA-18304
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18304
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Hints
>Reporter: Paulo Motta
>Assignee: Paulo Motta
>Priority: Normal
> Fix For: 4.1.x, 5.x
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> I've had some dtests with disabled hints failing.
> After investigation it seems that CASSANDRA-17164 moved hint submission on
> timeout from
> [RequestCallbacks.onExpired|https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b#diff-b73c13ea8cae91a215495917fe5e90d55c9f4a283f9e053110992bc9a60004b8L176]
> to
> [AbstractWriteResponseHandler.onFailure|https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b#diff-3b202de0d077638bede7bf4076a15eb4d483b717f955f11e743efb8d27c6eb1dR285],
> but it no longer checks if {{CallbackInfo.shouldHint}} which checks for
> {{StorageProxy.shouldHint}} which ultimately checks if
> {{{}hinted_handoff_enabled=true{}}}.
> This could cause some tests which expect hints to be disabled to fail
> intermittently.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18314) Lift MessagingService.minimum_version to 40
[ https://issues.apache.org/jira/browse/CASSANDRA-18314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-18314: --- Description: MessagingService's VERSION_30 and VERSION_3014 don't have to be supported in Cassandra 5.0 anymore. (Cassandra 5.0 currently is still using VERSION_40) Patch: https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/18314/trunk was: MessagingService's VERSION_30 and VERSION_3014 don't have to be supported in Cassandra 5.0 anymore. (Cassandra 5.0 currently is still using VERSION_40) Patch: > Lift MessagingService.minimum_version to 40 > --- > > Key: CASSANDRA-18314 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18314 > Project: Cassandra > Issue Type: Task > Components: Messaging/Internode >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 5.x > > > MessagingService's VERSION_30 and VERSION_3014 don't have to be supported in > Cassandra 5.0 anymore. > (Cassandra 5.0 currently is still using VERSION_40) > Patch: > https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/18314/trunk -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18314) Lift MessagingService.minimum_version to 40
[ https://issues.apache.org/jira/browse/CASSANDRA-18314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-18314: --- Fix Version/s: 5.x > Lift MessagingService.minimum_version to 40 > --- > > Key: CASSANDRA-18314 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18314 > Project: Cassandra > Issue Type: Task > Components: Messaging/Internode >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 5.x > > > MessagingService's VERSION_30 and VERSION_3014 don't have to be supported in > Cassandra 5.0 anymore. > (Cassandra 5.0 currently is still using VERSION_40) > Patch: -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-18314) Lift MessagingService.minimum_version to 40
[ https://issues.apache.org/jira/browse/CASSANDRA-18314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever reassigned CASSANDRA-18314: -- Assignee: Michael Semb Wever > Lift MessagingService.minimum_version to 40 > --- > > Key: CASSANDRA-18314 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18314 > Project: Cassandra > Issue Type: Task > Components: Messaging/Internode >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > > MessagingService's VERSION_30 and VERSION_3014 don't have to be supported in > Cassandra 5.0 anymore. > (Cassandra 5.0 currently is still using VERSION_40) > Patch: -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-18313) Remove deprecated 3.x buffer pool metrics
[ https://issues.apache.org/jira/browse/CASSANDRA-18313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever reassigned CASSANDRA-18313: -- Assignee: Michael Semb Wever > Remove deprecated 3.x buffer pool metrics > - > > Key: CASSANDRA-18313 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18313 > Project: Cassandra > Issue Type: Task > Components: Observability/JMX >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 5.x > > > Remove BufferPoolMetrics.register3xAlias() > Patch: > https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/18313/trunk -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18314) Lift MessagingService.minimum_version to 40
Michael Semb Wever created CASSANDRA-18314: -- Summary: Lift MessagingService.minimum_version to 40 Key: CASSANDRA-18314 URL: https://issues.apache.org/jira/browse/CASSANDRA-18314 Project: Cassandra Issue Type: Task Components: Messaging/Internode Reporter: Michael Semb Wever MessagingService's VERSION_30 and VERSION_3014 don't have to be supported in Cassandra 5.0 anymore. (Cassandra 5.0 currently is still using VERSION_40) Patch: -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18313) Remove deprecated 3.x buffer pool metrics
[ https://issues.apache.org/jira/browse/CASSANDRA-18313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-18313: --- Fix Version/s: 5.x > Remove deprecated 3.x buffer pool metrics > - > > Key: CASSANDRA-18313 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18313 > Project: Cassandra > Issue Type: Task > Components: Observability/JMX >Reporter: Michael Semb Wever >Priority: Normal > Fix For: 5.x > > > Remove BufferPoolMetrics.register3xAlias() > Patch: > https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/18313/trunk -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18313) Remove deprecated 3.x buffer pool metrics
[ https://issues.apache.org/jira/browse/CASSANDRA-18313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-18313: --- Description: Remove BufferPoolMetrics.register3xAlias() Patch: https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/18313/trunk was: Remove BufferPoolMetrics.register3xAlias() Patch: > Remove deprecated 3.x buffer pool metrics > - > > Key: CASSANDRA-18313 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18313 > Project: Cassandra > Issue Type: Task > Components: Observability/JMX >Reporter: Michael Semb Wever >Priority: Normal > > Remove BufferPoolMetrics.register3xAlias() > Patch: > https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/18313/trunk -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18313) Remove deprecated 3.x buffer pool metrics
Michael Semb Wever created CASSANDRA-18313: -- Summary: Remove deprecated 3.x buffer pool metrics Key: CASSANDRA-18313 URL: https://issues.apache.org/jira/browse/CASSANDRA-18313 Project: Cassandra Issue Type: Task Components: Observability/JMX Reporter: Michael Semb Wever Remove BufferPoolMetrics.register3xAlias() Patch: -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18312) Drop support for sstable formats before `na`
[
https://issues.apache.org/jira/browse/CASSANDRA-18312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Semb Wever updated CASSANDRA-18312:
---
Description:
>From 5.0 sstable formats before {{\-na\-}} are unsupported.
This patch cleans up code related to the older formats.
https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/18312/trunk
was:
>From 5.0 sstable formats before {{\-na\-}} are unsupported.
This patch cleans up code related to the older formats.
> Drop support for sstable formats before `na`
>
>
> Key: CASSANDRA-18312
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18312
> Project: Cassandra
> Issue Type: Task
> Components: Local/SSTable
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 5.x
>
>
> From 5.0 sstable formats before {{\-na\-}} are unsupported.
> This patch cleans up code related to the older formats.
> https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/18312/trunk
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18312) Drop support for sstable formats before `na`
Michael Semb Wever created CASSANDRA-18312:
--
Summary: Drop support for sstable formats before `na`
Key: CASSANDRA-18312
URL: https://issues.apache.org/jira/browse/CASSANDRA-18312
Project: Cassandra
Issue Type: Task
Components: Local/SSTable
Reporter: Michael Semb Wever
Assignee: Michael Semb Wever
>From 5.0 sstable formats before {{\-na\-}} are unsupported.
This patch cleans up code related to the older formats.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18312) Drop support for sstable formats before `na`
[
https://issues.apache.org/jira/browse/CASSANDRA-18312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Semb Wever updated CASSANDRA-18312:
---
Fix Version/s: 5.x
> Drop support for sstable formats before `na`
>
>
> Key: CASSANDRA-18312
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18312
> Project: Cassandra
> Issue Type: Task
> Components: Local/SSTable
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 5.x
>
>
> From 5.0 sstable formats before {{\-na\-}} are unsupported.
> This patch cleans up code related to the older formats.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
