[jira] [Commented] (CASSANDRA-18302) Fix AIOOBE and improve validation messages for transaction statements

2023-03-13 Thread Jacek Lewandowski (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699961#comment-17699961
 ] 

Jacek Lewandowski commented on CASSANDRA-18302:
---

[~maedhroz] my main motivation was that {{asCQL}} is not able to generate back 
the original query. For example, {{ColumnFilter}} does not represent what the 
user specified in selection but just which columns we need to fetch to generate 
the result set. Therefore, using {{asCQL}} may confuse the users, if they see 
an error message they may think there is a bug in Cassandra, and their queries 
got malformed.

Fixing {{asCQL}} would require at least adding something like {{asCQL}} to all 
implementations of {{Selectable}}, as the list of {{Selectable}} is what the 
user actually specified. I don't know if that makes more sense. To me, if we 
want to display what the user specified, the simplest way to do that is just 
store the original input, just like we do for {{Prepared}}


> Fix AIOOBE and improve validation messages for transaction statements
> -
>
> Key: CASSANDRA-18302
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18302
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Accord
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 5.x
>
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Currently it happens sometimes that ArrayIndexOutOfBoundsException is thrown 
> from asCql method when validation transaction statement. In addition, asCql 
> does not return precisely the query user entered so the whole error message 
> can be misleading.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[cassandra-website] branch asf-staging updated (97c694f5 -> 7b6fcdaa)

2023-03-13 Thread git-site-role
This is an automated email from the ASF dual-hosted git repository.

git-site-role pushed a change to branch asf-staging
in repository https://gitbox.apache.org/repos/asf/cassandra-website.git


 discard 97c694f5 generate docs for c4206294
 new 7b6fcdaa generate docs for c4206294

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (97c694f5)
\
 N -- N -- N   refs/heads/asf-staging (7b6fcdaa)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 content/search-index.js |   2 +-
 site-ui/build/ui-bundle.zip | Bin 4796442 -> 4796442 bytes
 2 files changed, 1 insertion(+), 1 deletion(-)


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Created] (CASSANDRA-18325) dtest.bootstrap_test.TestBootstrap.test_cleanup

2023-03-13 Thread maxwellguo (Jira)
maxwellguo created CASSANDRA-18325:
--

 Summary: dtest.bootstrap_test.TestBootstrap.test_cleanup
 Key: CASSANDRA-18325
 URL: https://issues.apache.org/jira/browse/CASSANDRA-18325
 Project: Cassandra
  Issue Type: Bug
  Components: Test/dtest/python
Reporter: maxwellguo


assert not True
 +  where True = >()
 +where > = .is_set
Stacktrace
self = 

def test_cleanup(self):
"""
@jira_ticket CASSANDRA-11179
Make sure we remove processed files during cleanup
"""
cluster = self.cluster

cluster.set_environment_variable('CASSANDRA_TOKEN_PREGENERATION_DISABLED', 
'True')
cluster.set_configuration_options(values={'concurrent_compactors': 4})
cluster.populate(1)
cluster.start()
node1, = cluster.nodelist()
for x in range(0, 5):
node1.stress(['write', 'n=100k', 'no-warmup', '-schema', 
'compaction(strategy=SizeTieredCompactionStrategy,enabled=false)', 
'replication(factor=1)', '-rate', 'threads=10'])
node1.flush()
node2 = new_node(cluster)
node2.start(wait_for_binary_proto=True)
event = threading.Event()
failed = threading.Event()
jobs = 1
thread = threading.Thread(target=self._monitor_datadir, args=(node1, 
event, len(node1.get_sstables("keyspace1", "standard1")), jobs, failed))
thread.setDaemon(True)
thread.start()
node1.nodetool("cleanup -j {} keyspace1 standard1".format(jobs))
event.set()
thread.join()
>   assert not failed.is_set()
E   assert not True
E+  where True = >()
E+where > = .is_set

bootstrap_test.py:912: AssertionError


failed twice 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-18124) Config parameter keystore_password should be nullable

2023-03-13 Thread Maulin Vasavada (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699885#comment-17699885
 ] 

Maulin Vasavada commented on CASSANDRA-18124:
-

[~smiklosovic] Here you go with [a 
PR|https://github.com/instaclustr/cassandra/pull/49] on the 
instaclustr/cassandra. Let us review that and I can start porting those changes 
to 4.1/trunk on apache/cassandra.

> Config parameter keystore_password should be nullable
> -
>
> Key: CASSANDRA-18124
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18124
> Project: Cassandra
>  Issue Type: Bug
>  Components: Local/Config
>Reporter: Tibor Repasi
>Assignee: Maulin Vasavada
>Priority: Normal
> Fix For: 4.1.x, 5.x
>
>
> Some SSL configuration may pass unencrypted private keys. PEMReader might 
> accept that by assuming keyPassword to be null in that case (e.g. 
> https://github.com/apache/cassandra/blob/f9e033f519c14596da4dc954875756a69aea4e78/src/java/org/apache/cassandra/security/PEMReader.java#L103).
> Current configuration reader does not accept keystore_password parameter to 
> be set null or empty in the cassandra.yaml.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Comment Edited] (CASSANDRA-18302) Fix AIOOBE and improve validation messages for transaction statements

2023-03-13 Thread Caleb Rackliffe (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699878#comment-17699878
 ] 

Caleb Rackliffe edited comment on CASSANDRA-18302 at 3/13/23 11:30 PM:
---

Started looking through the patch, but I want to stop and talk through some 
high-level things here.

The proximate cause of the original problem is that {{asCQL()}} seems to want 
to call {{queriedColumns()}} to get the {{SELECT}} clause to show the user. If 
you just use the {{ColumnFilter}} already calculated from the actual 
`ClientState`, I think that just works:

{noformat}
public String asCQL(QueryOptions options, ClientState state)
{
ColumnFilter columnFilter = 
selection.newSelectors(options).getColumnFilter();
StringBuilder sb = new StringBuilder();

sb.append("SELECT ").append(columnFilter.toCQLString());
...
{noformat}

(Side note: It looks like there are a couple places where {{asCQL()}} could be 
called lazily and it isn't?)

CC [~dcapwell]

The other thing we're driving at here is making the error message as useful as 
possible. Toward that end, we have line and character numbers, as well as raw 
query text being propagated and filtered in the patch. What if, as a compromise 
proposal, we 1.) fix {{asCQL()}} (which is used other places like 
{{maybeWarn()}}) to avoid our immediate issue and 2.) pare down the patch to 
just track the most important bit of the enhanced error message: the line 
number?

My basic arguments are that 1.) even if they're not perfect, the statements 
(lazily!) generated by {{asCQL()}} are useful enough and avoid having to add 
all the new fragment extraction logic, 2.) the line number is usually all we 
need for properly formatted transactions, and 3.) the character position isn't 
actually that helpful for a poorly formatted transaction w/ multiple 
expressions.

WDYT?


was (Author: maedhroz):
Started looking through the patch, but I want to stop and talk through some 
high-level things here.

The proximate cause of the original problem is that {{asCQL()}} seems to want 
to call {{queriedColumns()}} to get the {{SELECT}} clause to show the user. If 
you just use the {{ColumnFilter}} already calculated from the actual 
`ClientState`, I think that just works:

{noformat}
public String asCQL(QueryOptions options, ClientState state)
{
ColumnFilter columnFilter = 
selection.newSelectors(options).getColumnFilter();
StringBuilder sb = new StringBuilder();

sb.append("SELECT ").append(columnFilter.toCQLString());
...
{noformat}

(Side note: It looks like there are a couple places where {{asCQL()}} could be 
called lazily and it isn't?)

CC [~dcapwell]

The other thing we're driving at here is making the error message as useful as 
possible. Toward that end, we have line and character numbers, as well as raw 
query text being propagated and filtered in the patch. What if, as a compromise 
proposal, we 1.) fix {{asCQL()}} (which is used other places like 
{{maybeWarn()}}) to avoid our immediate issue and 2.) pare down the patch a 
tiny bit to just track the most important bit of the enhanced error message: 
the line number?

My basic arguments are that 1.) even if they're not perfect, the statements 
(lazily!) generated by {{asCQL()}} are useful enough and avoid having to add 
all the new fragment extraction logic, 2.) the line number is usually all we 
need for properly formatted transactions, and 3.) the character position isn't 
actually that helpful for a poorly formatted transaction w/ multiple 
expressions.

WDYT?

> Fix AIOOBE and improve validation messages for transaction statements
> -
>
> Key: CASSANDRA-18302
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18302
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Accord
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 5.x
>
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Currently it happens sometimes that ArrayIndexOutOfBoundsException is thrown 
> from asCql method when validation transaction statement. In addition, asCql 
> does not return precisely the query user entered so the whole error message 
> can be misleading.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-18302) Fix AIOOBE and improve validation messages for transaction statements

2023-03-13 Thread Caleb Rackliffe (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699878#comment-17699878
 ] 

Caleb Rackliffe commented on CASSANDRA-18302:
-

Started looking through the patch, but I want to stop and talk through some 
high-level things here.

The proximate cause of the original problem is that {{asCQL()}} seems to want 
to call {{queriedColumns()}} to get the {{SELECT}} clause to show the user. If 
you just use the {{ColumnFilter}} already calculated from the actual 
`ClientState`, I think that just works:

{noformat}
public String asCQL(QueryOptions options, ClientState state)
{
ColumnFilter columnFilter = 
selection.newSelectors(options).getColumnFilter();
StringBuilder sb = new StringBuilder();

sb.append("SELECT ").append(columnFilter.toCQLString());
...
{noformat}

(Side note: It looks like there are a couple places where {{asCQL()}} could be 
called lazily and it isn't?)

CC [~dcapwell]

The other thing we're driving at here is making the error message as useful as 
possible. Toward that end, we have line and character numbers, as well as raw 
query text being propagated and filtered in the patch. What if, as a compromise 
proposal, we 1.) fix {{asCQL()}} (which is used other places like 
{{maybeWarn()}}) to avoid our immediate issue and 2.) pare down the patch a 
tiny bit to just track the most important bit of the enhanced error message: 
the line number?

My basic arguments are that 1.) even if they're not perfect, the statements 
(lazily!) generated by {{asCQL()}} are useful enough and avoid having to add 
all the new fragment extraction logic, 2.) the line number is usually all we 
need for properly formatted transactions, and 3.) the character position isn't 
actually that helpful for a poorly formatted transaction w/ multiple 
expressions.

WDYT?

> Fix AIOOBE and improve validation messages for transaction statements
> -
>
> Key: CASSANDRA-18302
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18302
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Accord
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 5.x
>
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Currently it happens sometimes that ArrayIndexOutOfBoundsException is thrown 
> from asCql method when validation transaction statement. In addition, asCql 
> does not return precisely the query user entered so the whole error message 
> can be misleading.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-18320) Incompatible file system thrown while running Simulator

2023-03-13 Thread Stefan Miklosovic (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699876#comment-17699876
 ] 

Stefan Miklosovic commented on CASSANDRA-18320:
---

I will wait until this is merged so we can release 4.1.1 with it.

I dont see any problem with the patch.

> Incompatible file system thrown while running Simulator
> ---
>
> Key: CASSANDRA-18320
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18320
> Project: Cassandra
>  Issue Type: Bug
>  Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: David Capwell
>Priority: Normal
> Fix For: 4.1.x, 5.x
>
>
> {code}
> java.io.UncheckedIOException
>   at 
> org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:831)
>   at 
> org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:816)
>   at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:257)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:381)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
>   at java.util.ArrayList.forEach(ArrayList.java:1259)
>   at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395)
>   at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483)
>   at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
>   at 
> java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
>   at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
>   at 
> java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485)
>   at org.apache.cassandra.io.util.PathUtils.forEach(PathUtils.java:155)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:378)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
>   at java.util.ArrayList.forEach(ArrayList.java:1259)
>   at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395)
>   at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483)
>   at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
>   at 
> java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
>   at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
>   at 
> java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485)
>   at org.apache.cassandra.io.util.PathUtils.forEach(PathUtils.java:155)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:378)
>   at 
> org.apache.cassandra.distributed.impl.AbstractCluster.close(AbstractCluster.java:1047)
>   at 
> org.apache.cassandra.simulator.ClusterSimulation.close(ClusterSimulation.java:816)
>   at 
> org.apache.cassandra.simulator.SimulationRunner$Run.run(SimulationRunner.java:370)
>   at 
> org.apache.cassandra.simulator.SimulationRunner$BasicCommand.run(SimulationRunner.java:345)
>   at 
> org.apache.cassandra.simulator.paxos.PaxosSimulationRunner.main(PaxosSimulationRunner.java:148)
>   at 
> org.apache.cassandra.simulator.test.ShortPaxosSimulationTest.simulationTest(ShortPaxosSimulationTest.java:33)
> Caused by: java.nio.file.DirectoryNotEmptyException: 
> /cassandra/node1/commitlog
>   at 
> com.google.common.jimfs.FileSystemView.checkEmpty(FileSystemView.java:535)
>   at 
> com.google.common.jimfs.FileSystemView.checkDeletable(FileSystemView.java:517)
>   at 
> com.google.common.jimfs.FileSystemView.delete(FileSystemView.java:479)
>   at 
> com.google.common.jimfs.FileSystemView.deleteFile(FileSystemView.java:465)
>   at 
> com.google.common.jimfs.JimfsFileSystemProvider.delete(JimfsFileSystemProvider.java:261)
>   at java.nio.file.Files.delete(Files.java:1126)
>   at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:252)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[cassandra-website] branch asf-staging updated (686dd2d8 -> 97c694f5)

2023-03-13 Thread git-site-role
This is an automated email from the ASF dual-hosted git repository.

git-site-role pushed a change to branch asf-staging
in repository https://gitbox.apache.org/repos/asf/cassandra-website.git


 discard 686dd2d8 generate docs for c4206294
 new 97c694f5 generate docs for c4206294

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (686dd2d8)
\
 N -- N -- N   refs/heads/asf-staging (97c694f5)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 content/search-index.js |   2 +-
 site-ui/build/ui-bundle.zip | Bin 4796442 -> 4796442 bytes
 2 files changed, 1 insertion(+), 1 deletion(-)


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-18320) Incompatible file system thrown while running Simulator

2023-03-13 Thread David Capwell (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-18320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Capwell updated CASSANDRA-18320:
--
Status: Ready to Commit  (was: Review In Progress)

won't commit today, want to give time to others to see if desired

> Incompatible file system thrown while running Simulator
> ---
>
> Key: CASSANDRA-18320
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18320
> Project: Cassandra
>  Issue Type: Bug
>  Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: David Capwell
>Priority: Normal
> Fix For: 4.1.x, 5.x
>
>
> {code}
> java.io.UncheckedIOException
>   at 
> org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:831)
>   at 
> org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:816)
>   at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:257)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:381)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
>   at java.util.ArrayList.forEach(ArrayList.java:1259)
>   at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395)
>   at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483)
>   at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
>   at 
> java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
>   at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
>   at 
> java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485)
>   at org.apache.cassandra.io.util.PathUtils.forEach(PathUtils.java:155)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:378)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
>   at java.util.ArrayList.forEach(ArrayList.java:1259)
>   at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395)
>   at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483)
>   at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
>   at 
> java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
>   at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
>   at 
> java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485)
>   at org.apache.cassandra.io.util.PathUtils.forEach(PathUtils.java:155)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:378)
>   at 
> org.apache.cassandra.distributed.impl.AbstractCluster.close(AbstractCluster.java:1047)
>   at 
> org.apache.cassandra.simulator.ClusterSimulation.close(ClusterSimulation.java:816)
>   at 
> org.apache.cassandra.simulator.SimulationRunner$Run.run(SimulationRunner.java:370)
>   at 
> org.apache.cassandra.simulator.SimulationRunner$BasicCommand.run(SimulationRunner.java:345)
>   at 
> org.apache.cassandra.simulator.paxos.PaxosSimulationRunner.main(PaxosSimulationRunner.java:148)
>   at 
> org.apache.cassandra.simulator.test.ShortPaxosSimulationTest.simulationTest(ShortPaxosSimulationTest.java:33)
> Caused by: java.nio.file.DirectoryNotEmptyException: 
> /cassandra/node1/commitlog
>   at 
> com.google.common.jimfs.FileSystemView.checkEmpty(FileSystemView.java:535)
>   at 
> com.google.common.jimfs.FileSystemView.checkDeletable(FileSystemView.java:517)
>   at 
> com.google.common.jimfs.FileSystemView.delete(FileSystemView.java:479)
>   at 
> com.google.common.jimfs.FileSystemView.deleteFile(FileSystemView.java:465)
>   at 
> com.google.common.jimfs.JimfsFileSystemProvider.delete(JimfsFileSystemProvider.java:261)
>   at java.nio.file.Files.delete(Files.java:1126)
>   at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:252)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-18228) Reorganize Apache C* docs in trunk branch to match the IA

2023-03-13 Thread Lorina Poland (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-18228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lorina Poland updated CASSANDRA-18228:
--
Reviewers: Michael Semb Wever

> Reorganize Apache C* docs in trunk branch to match the IA
> -
>
> Key: CASSANDRA-18228
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18228
> Project: Cassandra
>  Issue Type: New Feature
>  Components: Documentation
>Reporter: Lorina Poland
>Assignee: Lorina Poland
>Priority: Normal
> Fix For: 5.x
>
>
> An agreed-upon Information Architecture will be used to reorganize the C* 5.0 
> docs.
> IA doc: 
> https://docs.google.com/document/d/1A96K73vj9MbJoD7wJNgIKWrOkLq-ZL2cNZAEXSWrciY/edit?usp=sharing



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-18324) CEP-15: (C*) Head of line blocking of Txn causes large latencies and some Txn to no longer make progress

2023-03-13 Thread Blake Eggleston (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-18324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Blake Eggleston updated CASSANDRA-18324:

Change Category: Performance
 Complexity: Normal
  Fix Version/s: 5.0
 Status: Open  (was: Triage Needed)

> CEP-15: (C*) Head of line blocking of Txn causes large latencies and some Txn 
> to no longer make progress
> 
>
> Key: CASSANDRA-18324
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18324
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Accord
>Reporter: Blake Eggleston
>Assignee: Blake Eggleston
>Priority: Normal
> Fix For: 5.0
>
>
> Accord perf tests discovered an issue where a command becomes stuck in the 
> Preaccept phase and dependent operations aren't able to make progress



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Created] (CASSANDRA-18324) CEP-15: (C*) Head of line blocking of Txn causes large latencies and some Txn to no longer make progress

2023-03-13 Thread Blake Eggleston (Jira)
Blake Eggleston created CASSANDRA-18324:
---

 Summary: CEP-15: (C*) Head of line blocking of Txn causes large 
latencies and some Txn to no longer make progress
 Key: CASSANDRA-18324
 URL: https://issues.apache.org/jira/browse/CASSANDRA-18324
 Project: Cassandra
  Issue Type: Improvement
  Components: Accord
Reporter: Blake Eggleston
Assignee: Blake Eggleston


Accord perf tests discovered an issue where a command becomes stuck in the 
Preaccept phase and dependent operations aren't able to make progress



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-18320) Incompatible file system thrown while running Simulator

2023-03-13 Thread David Capwell (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-18320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Capwell updated CASSANDRA-18320:
--
Reviewers: Caleb Rackliffe, David Capwell
   Status: Review In Progress  (was: Patch Available)

> Incompatible file system thrown while running Simulator
> ---
>
> Key: CASSANDRA-18320
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18320
> Project: Cassandra
>  Issue Type: Bug
>  Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: David Capwell
>Priority: Normal
> Fix For: 4.1.x, 5.x
>
>
> {code}
> java.io.UncheckedIOException
>   at 
> org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:831)
>   at 
> org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:816)
>   at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:257)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:381)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
>   at java.util.ArrayList.forEach(ArrayList.java:1259)
>   at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395)
>   at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483)
>   at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
>   at 
> java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
>   at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
>   at 
> java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485)
>   at org.apache.cassandra.io.util.PathUtils.forEach(PathUtils.java:155)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:378)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
>   at java.util.ArrayList.forEach(ArrayList.java:1259)
>   at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395)
>   at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483)
>   at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
>   at 
> java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
>   at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
>   at 
> java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485)
>   at org.apache.cassandra.io.util.PathUtils.forEach(PathUtils.java:155)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:378)
>   at 
> org.apache.cassandra.distributed.impl.AbstractCluster.close(AbstractCluster.java:1047)
>   at 
> org.apache.cassandra.simulator.ClusterSimulation.close(ClusterSimulation.java:816)
>   at 
> org.apache.cassandra.simulator.SimulationRunner$Run.run(SimulationRunner.java:370)
>   at 
> org.apache.cassandra.simulator.SimulationRunner$BasicCommand.run(SimulationRunner.java:345)
>   at 
> org.apache.cassandra.simulator.paxos.PaxosSimulationRunner.main(PaxosSimulationRunner.java:148)
>   at 
> org.apache.cassandra.simulator.test.ShortPaxosSimulationTest.simulationTest(ShortPaxosSimulationTest.java:33)
> Caused by: java.nio.file.DirectoryNotEmptyException: 
> /cassandra/node1/commitlog
>   at 
> com.google.common.jimfs.FileSystemView.checkEmpty(FileSystemView.java:535)
>   at 
> com.google.common.jimfs.FileSystemView.checkDeletable(FileSystemView.java:517)
>   at 
> com.google.common.jimfs.FileSystemView.delete(FileSystemView.java:479)
>   at 
> com.google.common.jimfs.FileSystemView.deleteFile(FileSystemView.java:465)
>   at 
> com.google.common.jimfs.JimfsFileSystemProvider.delete(JimfsFileSystemProvider.java:261)
>   at java.nio.file.Files.delete(Files.java:1126)
>   at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:252)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-18320) Incompatible file system thrown while running Simulator

2023-03-13 Thread David Capwell (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-18320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Capwell updated CASSANDRA-18320:
--
Reviewers: Caleb Rackliffe  (was: Caleb Rackliffe, David Capwell)

> Incompatible file system thrown while running Simulator
> ---
>
> Key: CASSANDRA-18320
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18320
> Project: Cassandra
>  Issue Type: Bug
>  Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: David Capwell
>Priority: Normal
> Fix For: 4.1.x, 5.x
>
>
> {code}
> java.io.UncheckedIOException
>   at 
> org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:831)
>   at 
> org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:816)
>   at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:257)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:381)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
>   at java.util.ArrayList.forEach(ArrayList.java:1259)
>   at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395)
>   at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483)
>   at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
>   at 
> java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
>   at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
>   at 
> java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485)
>   at org.apache.cassandra.io.util.PathUtils.forEach(PathUtils.java:155)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:378)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
>   at java.util.ArrayList.forEach(ArrayList.java:1259)
>   at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395)
>   at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483)
>   at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
>   at 
> java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
>   at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
>   at 
> java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485)
>   at org.apache.cassandra.io.util.PathUtils.forEach(PathUtils.java:155)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:378)
>   at 
> org.apache.cassandra.distributed.impl.AbstractCluster.close(AbstractCluster.java:1047)
>   at 
> org.apache.cassandra.simulator.ClusterSimulation.close(ClusterSimulation.java:816)
>   at 
> org.apache.cassandra.simulator.SimulationRunner$Run.run(SimulationRunner.java:370)
>   at 
> org.apache.cassandra.simulator.SimulationRunner$BasicCommand.run(SimulationRunner.java:345)
>   at 
> org.apache.cassandra.simulator.paxos.PaxosSimulationRunner.main(PaxosSimulationRunner.java:148)
>   at 
> org.apache.cassandra.simulator.test.ShortPaxosSimulationTest.simulationTest(ShortPaxosSimulationTest.java:33)
> Caused by: java.nio.file.DirectoryNotEmptyException: 
> /cassandra/node1/commitlog
>   at 
> com.google.common.jimfs.FileSystemView.checkEmpty(FileSystemView.java:535)
>   at 
> com.google.common.jimfs.FileSystemView.checkDeletable(FileSystemView.java:517)
>   at 
> com.google.common.jimfs.FileSystemView.delete(FileSystemView.java:479)
>   at 
> com.google.common.jimfs.FileSystemView.deleteFile(FileSystemView.java:465)
>   at 
> com.google.common.jimfs.JimfsFileSystemProvider.delete(JimfsFileSystemProvider.java:261)
>   at java.nio.file.Files.delete(Files.java:1126)
>   at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:252)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-18320) Incompatible file system thrown while running Simulator

2023-03-13 Thread Caleb Rackliffe (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699850#comment-17699850
 ] 

Caleb Rackliffe commented on CASSANDRA-18320:
-

+1

> Incompatible file system thrown while running Simulator
> ---
>
> Key: CASSANDRA-18320
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18320
> Project: Cassandra
>  Issue Type: Bug
>  Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: David Capwell
>Priority: Normal
> Fix For: 4.1.x, 5.x
>
>
> {code}
> java.io.UncheckedIOException
>   at 
> org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:831)
>   at 
> org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:816)
>   at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:257)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:381)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
>   at java.util.ArrayList.forEach(ArrayList.java:1259)
>   at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395)
>   at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483)
>   at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
>   at 
> java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
>   at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
>   at 
> java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485)
>   at org.apache.cassandra.io.util.PathUtils.forEach(PathUtils.java:155)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:378)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
>   at java.util.ArrayList.forEach(ArrayList.java:1259)
>   at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395)
>   at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483)
>   at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
>   at 
> java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
>   at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
>   at 
> java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485)
>   at org.apache.cassandra.io.util.PathUtils.forEach(PathUtils.java:155)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:378)
>   at 
> org.apache.cassandra.distributed.impl.AbstractCluster.close(AbstractCluster.java:1047)
>   at 
> org.apache.cassandra.simulator.ClusterSimulation.close(ClusterSimulation.java:816)
>   at 
> org.apache.cassandra.simulator.SimulationRunner$Run.run(SimulationRunner.java:370)
>   at 
> org.apache.cassandra.simulator.SimulationRunner$BasicCommand.run(SimulationRunner.java:345)
>   at 
> org.apache.cassandra.simulator.paxos.PaxosSimulationRunner.main(PaxosSimulationRunner.java:148)
>   at 
> org.apache.cassandra.simulator.test.ShortPaxosSimulationTest.simulationTest(ShortPaxosSimulationTest.java:33)
> Caused by: java.nio.file.DirectoryNotEmptyException: 
> /cassandra/node1/commitlog
>   at 
> com.google.common.jimfs.FileSystemView.checkEmpty(FileSystemView.java:535)
>   at 
> com.google.common.jimfs.FileSystemView.checkDeletable(FileSystemView.java:517)
>   at 
> com.google.common.jimfs.FileSystemView.delete(FileSystemView.java:479)
>   at 
> com.google.common.jimfs.FileSystemView.deleteFile(FileSystemView.java:465)
>   at 
> com.google.common.jimfs.JimfsFileSystemProvider.delete(JimfsFileSystemProvider.java:261)
>   at java.nio.file.Files.delete(Files.java:1126)
>   at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:252)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-18320) Incompatible file system thrown while running Simulator

2023-03-13 Thread David Capwell (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-18320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Capwell updated CASSANDRA-18320:
--
Summary: Incompatible file system thrown while running Simulator  (was: 
simulationTest is flaky )

> Incompatible file system thrown while running Simulator
> ---
>
> Key: CASSANDRA-18320
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18320
> Project: Cassandra
>  Issue Type: Bug
>  Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: David Capwell
>Priority: Normal
> Fix For: 4.1.x, 5.x
>
>
> {code}
> java.io.UncheckedIOException
>   at 
> org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:831)
>   at 
> org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:816)
>   at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:257)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:381)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
>   at java.util.ArrayList.forEach(ArrayList.java:1259)
>   at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395)
>   at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483)
>   at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
>   at 
> java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
>   at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
>   at 
> java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485)
>   at org.apache.cassandra.io.util.PathUtils.forEach(PathUtils.java:155)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:378)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
>   at java.util.ArrayList.forEach(ArrayList.java:1259)
>   at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395)
>   at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483)
>   at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
>   at 
> java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
>   at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
>   at 
> java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485)
>   at org.apache.cassandra.io.util.PathUtils.forEach(PathUtils.java:155)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:378)
>   at 
> org.apache.cassandra.distributed.impl.AbstractCluster.close(AbstractCluster.java:1047)
>   at 
> org.apache.cassandra.simulator.ClusterSimulation.close(ClusterSimulation.java:816)
>   at 
> org.apache.cassandra.simulator.SimulationRunner$Run.run(SimulationRunner.java:370)
>   at 
> org.apache.cassandra.simulator.SimulationRunner$BasicCommand.run(SimulationRunner.java:345)
>   at 
> org.apache.cassandra.simulator.paxos.PaxosSimulationRunner.main(PaxosSimulationRunner.java:148)
>   at 
> org.apache.cassandra.simulator.test.ShortPaxosSimulationTest.simulationTest(ShortPaxosSimulationTest.java:33)
> Caused by: java.nio.file.DirectoryNotEmptyException: 
> /cassandra/node1/commitlog
>   at 
> com.google.common.jimfs.FileSystemView.checkEmpty(FileSystemView.java:535)
>   at 
> com.google.common.jimfs.FileSystemView.checkDeletable(FileSystemView.java:517)
>   at 
> com.google.common.jimfs.FileSystemView.delete(FileSystemView.java:479)
>   at 
> com.google.common.jimfs.FileSystemView.deleteFile(FileSystemView.java:465)
>   at 
> com.google.common.jimfs.JimfsFileSystemProvider.delete(JimfsFileSystemProvider.java:261)
>   at java.nio.file.Files.delete(Files.java:1126)
>   at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:252)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-18320) Incompatible file system thrown while running Simulator

2023-03-13 Thread David Capwell (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-18320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Capwell updated CASSANDRA-18320:
--
Test and Documentation Plan: ran ci
 Status: Patch Available  (was: In Progress)

> Incompatible file system thrown while running Simulator
> ---
>
> Key: CASSANDRA-18320
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18320
> Project: Cassandra
>  Issue Type: Bug
>  Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: David Capwell
>Priority: Normal
> Fix For: 4.1.x, 5.x
>
>
> {code}
> java.io.UncheckedIOException
>   at 
> org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:831)
>   at 
> org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:816)
>   at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:257)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:381)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
>   at java.util.ArrayList.forEach(ArrayList.java:1259)
>   at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395)
>   at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483)
>   at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
>   at 
> java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
>   at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
>   at 
> java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485)
>   at org.apache.cassandra.io.util.PathUtils.forEach(PathUtils.java:155)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:378)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
>   at java.util.ArrayList.forEach(ArrayList.java:1259)
>   at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395)
>   at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483)
>   at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
>   at 
> java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
>   at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
>   at 
> java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485)
>   at org.apache.cassandra.io.util.PathUtils.forEach(PathUtils.java:155)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:378)
>   at 
> org.apache.cassandra.distributed.impl.AbstractCluster.close(AbstractCluster.java:1047)
>   at 
> org.apache.cassandra.simulator.ClusterSimulation.close(ClusterSimulation.java:816)
>   at 
> org.apache.cassandra.simulator.SimulationRunner$Run.run(SimulationRunner.java:370)
>   at 
> org.apache.cassandra.simulator.SimulationRunner$BasicCommand.run(SimulationRunner.java:345)
>   at 
> org.apache.cassandra.simulator.paxos.PaxosSimulationRunner.main(PaxosSimulationRunner.java:148)
>   at 
> org.apache.cassandra.simulator.test.ShortPaxosSimulationTest.simulationTest(ShortPaxosSimulationTest.java:33)
> Caused by: java.nio.file.DirectoryNotEmptyException: 
> /cassandra/node1/commitlog
>   at 
> com.google.common.jimfs.FileSystemView.checkEmpty(FileSystemView.java:535)
>   at 
> com.google.common.jimfs.FileSystemView.checkDeletable(FileSystemView.java:517)
>   at 
> com.google.common.jimfs.FileSystemView.delete(FileSystemView.java:479)
>   at 
> com.google.common.jimfs.FileSystemView.deleteFile(FileSystemView.java:465)
>   at 
> com.google.common.jimfs.JimfsFileSystemProvider.delete(JimfsFileSystemProvider.java:261)
>   at java.nio.file.Files.delete(Files.java:1126)
>   at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:252)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-18320) simulationTest is flaky

2023-03-13 Thread David Capwell (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699848#comment-17699848
 ] 

David Capwell commented on CASSANDRA-18320:
---

patch is mostly stable (OOMs from time to time...; but jdk11 is stable 
https://app.circleci.com/pipelines/github/dcapwell/cassandra/1928/workflows/e38a054b-a97f-4a84-bf88-b4abceb5947f/jobs/18273)



> simulationTest is flaky 
> 
>
> Key: CASSANDRA-18320
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18320
> Project: Cassandra
>  Issue Type: Bug
>  Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: David Capwell
>Priority: Normal
> Fix For: 4.1.x, 5.x
>
>
> {code}
> java.io.UncheckedIOException
>   at 
> org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:831)
>   at 
> org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:816)
>   at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:257)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:381)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
>   at java.util.ArrayList.forEach(ArrayList.java:1259)
>   at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395)
>   at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483)
>   at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
>   at 
> java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
>   at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
>   at 
> java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485)
>   at org.apache.cassandra.io.util.PathUtils.forEach(PathUtils.java:155)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:378)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
>   at java.util.ArrayList.forEach(ArrayList.java:1259)
>   at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395)
>   at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483)
>   at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
>   at 
> java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
>   at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
>   at 
> java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485)
>   at org.apache.cassandra.io.util.PathUtils.forEach(PathUtils.java:155)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:378)
>   at 
> org.apache.cassandra.distributed.impl.AbstractCluster.close(AbstractCluster.java:1047)
>   at 
> org.apache.cassandra.simulator.ClusterSimulation.close(ClusterSimulation.java:816)
>   at 
> org.apache.cassandra.simulator.SimulationRunner$Run.run(SimulationRunner.java:370)
>   at 
> org.apache.cassandra.simulator.SimulationRunner$BasicCommand.run(SimulationRunner.java:345)
>   at 
> org.apache.cassandra.simulator.paxos.PaxosSimulationRunner.main(PaxosSimulationRunner.java:148)
>   at 
> org.apache.cassandra.simulator.test.ShortPaxosSimulationTest.simulationTest(ShortPaxosSimulationTest.java:33)
> Caused by: java.nio.file.DirectoryNotEmptyException: 
> /cassandra/node1/commitlog
>   at 
> com.google.common.jimfs.FileSystemView.checkEmpty(FileSystemView.java:535)
>   at 
> com.google.common.jimfs.FileSystemView.checkDeletable(FileSystemView.java:517)
>   at 
> com.google.common.jimfs.FileSystemView.delete(FileSystemView.java:479)
>   at 
> com.google.common.jimfs.FileSystemView.deleteFile(FileSystemView.java:465)
>   at 
> com.google.common.jimfs.JimfsFileSystemProvider.delete(JimfsFileSystemProvider.java:261)
>   at java.nio.file.Files.delete(Files.java:1126)
>   at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:252)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-18323) Remove org.apache.cassandra.hadoop code

2023-03-13 Thread Brandon Williams (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699846#comment-17699846
 ] 

Brandon Williams commented on CASSANDRA-18323:
--

Looks good and I'm +1 but we should run the hsqldb dep by the ML.

> Remove org.apache.cassandra.hadoop code
> ---
>
> Key: CASSANDRA-18323
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18323
> Project: Cassandra
>  Issue Type: Task
>  Components: Legacy/Core
>Reporter: Stefan Miklosovic
>Assignee: Stefan Miklosovic
>Priority: Normal
> Fix For: 5.x
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-18323) Remove org.apache.cassandra.hadoop code

2023-03-13 Thread Stefan Miklosovic (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699843#comment-17699843
 ] 

Stefan Miklosovic commented on CASSANDRA-18323:
---

fyi [~brandon.williams] 

> Remove org.apache.cassandra.hadoop code
> ---
>
> Key: CASSANDRA-18323
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18323
> Project: Cassandra
>  Issue Type: Task
>  Components: Legacy/Core
>Reporter: Stefan Miklosovic
>Assignee: Stefan Miklosovic
>Priority: Normal
> Fix For: 5.x
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-18323) Remove org.apache.cassandra.hadoop code

2023-03-13 Thread Stefan Miklosovic (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-18323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Miklosovic updated CASSANDRA-18323:
--
Test and Documentation Plan: CI
 Status: Patch Available  (was: In Progress)

j11 
[https://app.circleci.com/pipelines/github/instaclustr/cassandra/1987/workflows/05eb2f04-bbe1-444b-8b67-35958419faaf]

j8 
[https://app.circleci.com/pipelines/github/instaclustr/cassandra/1987/workflows/704965b0-f646-42e7-abe7-8a475c29f3a4]

PR: [https://github.com/apache/cassandra/pull/2212]

> Remove org.apache.cassandra.hadoop code
> ---
>
> Key: CASSANDRA-18323
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18323
> Project: Cassandra
>  Issue Type: Task
>  Components: Legacy/Core
>Reporter: Stefan Miklosovic
>Assignee: Stefan Miklosovic
>Priority: Normal
> Fix For: 5.x
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-18239) Replace eclipse warnings based static code analysis with something better (Sonar)

2023-03-13 Thread Jacek Lewandowski (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699840#comment-17699840
 ] 

Jacek Lewandowski commented on CASSANDRA-18239:
---

great, let's finalize that effort

> Replace eclipse warnings based static code analysis with something better 
> (Sonar)
> -
>
> Key: CASSANDRA-18239
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18239
> Project: Cassandra
>  Issue Type: Task
>  Components: Build
>Reporter: Jacek Lewandowski
>Priority: Normal
>
> Eclipse warnings is used for static code analysis. However, it does not fit 
> well into Cassandra code and practically we end up explicitly adding 
> suppressions in many places just to satisfy that tool rather than fix the 
> real issues.
> This is an incomplete list of reasons to remove it:
> - not closed resources are detected incorrectly
> - does not recognize custom utility methods used to close the resources, 
> which use use heavily in the code, like {{Throwables.close}}, 
> {{FileUtils.close}}, {{closeQuietly}}...
> - because of the above, we cannot make important things like {{Ref}} to 
> implement {{Closeable}} as it would make the tool to explode with tons of 
> warnings
> - it complains about correct generics - something like "method X is not 
> applicable for ..." when the code compiles successfully is not acceptable
> - it is old and not maintained
> There are better tools like IntelliJ inspections for example, which can also 
> be run in headless mode



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-18239) Replace eclipse warnings based static code analysis with something better (Sonar)

2023-03-13 Thread Ekaterina Dimitrova (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699835#comment-17699835
 ] 

Ekaterina Dimitrova commented on CASSANDRA-18239:
-

[~jlewandowski] For SpotBugs there is already a ticket you might want to check 
- CASSANDRA-18077

> Replace eclipse warnings based static code analysis with something better 
> (Sonar)
> -
>
> Key: CASSANDRA-18239
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18239
> Project: Cassandra
>  Issue Type: Task
>  Components: Build
>Reporter: Jacek Lewandowski
>Priority: Normal
>
> Eclipse warnings is used for static code analysis. However, it does not fit 
> well into Cassandra code and practically we end up explicitly adding 
> suppressions in many places just to satisfy that tool rather than fix the 
> real issues.
> This is an incomplete list of reasons to remove it:
> - not closed resources are detected incorrectly
> - does not recognize custom utility methods used to close the resources, 
> which use use heavily in the code, like {{Throwables.close}}, 
> {{FileUtils.close}}, {{closeQuietly}}...
> - because of the above, we cannot make important things like {{Ref}} to 
> implement {{Closeable}} as it would make the tool to explode with tons of 
> warnings
> - it complains about correct generics - something like "method X is not 
> applicable for ..." when the code compiles successfully is not acceptable
> - it is old and not maintained
> There are better tools like IntelliJ inspections for example, which can also 
> be run in headless mode



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-18239) Replace eclipse warnings based static code analysis with something better (Sonar)

2023-03-13 Thread Jacek Lewandowski (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699833#comment-17699833
 ] 

Jacek Lewandowski commented on CASSANDRA-18239:
---

It may end up with SpotBugs ([~mmuzaf] your summary is very useful). We can use 
Sonar but it seems like it cannot be considered as a strict replacement of 
Eclipse-Warnings as the way how we would have to use it is completely 
different. 

We can try adding it SpotBugs task in Ant script for now and see how it works.


> Replace eclipse warnings based static code analysis with something better 
> (Sonar)
> -
>
> Key: CASSANDRA-18239
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18239
> Project: Cassandra
>  Issue Type: Task
>  Components: Build
>Reporter: Jacek Lewandowski
>Priority: Normal
>
> Eclipse warnings is used for static code analysis. However, it does not fit 
> well into Cassandra code and practically we end up explicitly adding 
> suppressions in many places just to satisfy that tool rather than fix the 
> real issues.
> This is an incomplete list of reasons to remove it:
> - not closed resources are detected incorrectly
> - does not recognize custom utility methods used to close the resources, 
> which use use heavily in the code, like {{Throwables.close}}, 
> {{FileUtils.close}}, {{closeQuietly}}...
> - because of the above, we cannot make important things like {{Ref}} to 
> implement {{Closeable}} as it would make the tool to explode with tons of 
> warnings
> - it complains about correct generics - something like "method X is not 
> applicable for ..." when the code compiles successfully is not acceptable
> - it is old and not maintained
> There are better tools like IntelliJ inspections for example, which can also 
> be run in headless mode



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-18262) Switch checkstyle running only with JDK8 to be run with JDK11

2023-03-13 Thread Ekaterina Dimitrova (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ekaterina Dimitrova updated CASSANDRA-18262:

Summary: Switch checkstyle running only with JDK8 to be run with JDK11  
(was: Switch ant targets running only with JDK8 to be run with JDK11)

> Switch checkstyle running only with JDK8 to be run with JDK11
> -
>
> Key: CASSANDRA-18262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18262
> Project: Cassandra
>  Issue Type: Task
>  Components: Build
>Reporter: Ekaterina Dimitrova
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.0
>
>
> Currently we run checkstyle, eclipse warnings (and probably anything else?) 
> only with JDK8.
> In preparation to remove JDK8 we need to switch those to run with JDK11.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-18320) simulationTest is flaky

2023-03-13 Thread David Capwell (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699830#comment-17699830
 ] 

David Capwell commented on CASSANDRA-18320:
---

Turns out File has a TODO to remove Paths.get... so I added a check style to 
block it and migrated all usage away.

There was one issue with Checkstyle... Paths.get matches absolutePaths.get... 
so I block Paths class from being imported...

> simulationTest is flaky 
> 
>
> Key: CASSANDRA-18320
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18320
> Project: Cassandra
>  Issue Type: Bug
>  Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: David Capwell
>Priority: Normal
> Fix For: 4.1.x, 5.x
>
>
> {code}
> java.io.UncheckedIOException
>   at 
> org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:831)
>   at 
> org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:816)
>   at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:257)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:381)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
>   at java.util.ArrayList.forEach(ArrayList.java:1259)
>   at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395)
>   at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483)
>   at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
>   at 
> java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
>   at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
>   at 
> java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485)
>   at org.apache.cassandra.io.util.PathUtils.forEach(PathUtils.java:155)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:378)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
>   at java.util.ArrayList.forEach(ArrayList.java:1259)
>   at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395)
>   at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483)
>   at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
>   at 
> java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
>   at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
>   at 
> java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485)
>   at org.apache.cassandra.io.util.PathUtils.forEach(PathUtils.java:155)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:378)
>   at 
> org.apache.cassandra.distributed.impl.AbstractCluster.close(AbstractCluster.java:1047)
>   at 
> org.apache.cassandra.simulator.ClusterSimulation.close(ClusterSimulation.java:816)
>   at 
> org.apache.cassandra.simulator.SimulationRunner$Run.run(SimulationRunner.java:370)
>   at 
> org.apache.cassandra.simulator.SimulationRunner$BasicCommand.run(SimulationRunner.java:345)
>   at 
> org.apache.cassandra.simulator.paxos.PaxosSimulationRunner.main(PaxosSimulationRunner.java:148)
>   at 
> org.apache.cassandra.simulator.test.ShortPaxosSimulationTest.simulationTest(ShortPaxosSimulationTest.java:33)
> Caused by: java.nio.file.DirectoryNotEmptyException: 
> /cassandra/node1/commitlog
>   at 
> com.google.common.jimfs.FileSystemView.checkEmpty(FileSystemView.java:535)
>   at 
> com.google.common.jimfs.FileSystemView.checkDeletable(FileSystemView.java:517)
>   at 
> com.google.common.jimfs.FileSystemView.delete(FileSystemView.java:479)
>   at 
> com.google.common.jimfs.FileSystemView.deleteFile(FileSystemView.java:465)
>   at 
> com.google.common.jimfs.JimfsFileSystemProvider.delete(JimfsFileSystemProvider.java:261)
>   at java.nio.file.Files.delete(Files.java:1126)
>   at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:252)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Comment Edited] (CASSANDRA-18106) Update CCM for JDK17 and revise current JDK detection strategy

2023-03-13 Thread Ekaterina Dimitrova (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699829#comment-17699829
 ] 

Ekaterina Dimitrova edited comment on CASSANDRA-18106 at 3/13/23 8:52 PM:
--

As requested offline, I checked the CircleCI patches, they seem fine to me. 
Also, I took a quick look into the tests submitted and I didn't see any issues.

Upgrade tests were not run, but if the CircleCI patches were the only change I 
do not expect surprises.

Thank you. my +1 still stands


was (Author: e.dimitrova):
As requested offline, I checked the CircleCI patches, they seem fine to me. 
Also, I took a quick look into the tests submitted and I didn't see any issues.

Upgrade tests were not run, but if the CircleCI patches were the only change I 
do not expect surprises.

Thank you

> Update CCM for JDK17 and revise current JDK detection strategy
> --
>
> Key: CASSANDRA-18106
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18106
> Project: Cassandra
>  Issue Type: Task
>  Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.x
>
> Attachments: Screenshot 2023-03-03 at 09.24.50.png
>
>
> As part of CASSANDRA-16895 initial POC an initial version of CCM patch was 
> created. This needs to be revisited and reviewed
> Recently we closed CASSANDRA-18039 which brought questions, probably we need 
> to revise how we detect JDK versions in CCM and whether it is correct. To the 
> best of my knowledge there are certain tests in the repo around that and they 
> pass so my guess is we need to revise just the strategy and maybe document it 
> explicitly or consider if we want any changes to be applied. Also, we need to 
> be careful with breaking changes. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-18106) Update CCM for JDK17 and revise current JDK detection strategy

2023-03-13 Thread Ekaterina Dimitrova (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699829#comment-17699829
 ] 

Ekaterina Dimitrova commented on CASSANDRA-18106:
-

As requested offline, I checked the CircleCI patches, they seem fine to me. 
Also, I took a quick look into the tests submitted and I didn't see any issues.

Upgrade tests were not run, but if the CircleCI patches were the only change I 
do not expect surprises.

Thank you

> Update CCM for JDK17 and revise current JDK detection strategy
> --
>
> Key: CASSANDRA-18106
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18106
> Project: Cassandra
>  Issue Type: Task
>  Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.x
>
> Attachments: Screenshot 2023-03-03 at 09.24.50.png
>
>
> As part of CASSANDRA-16895 initial POC an initial version of CCM patch was 
> created. This needs to be revisited and reviewed
> Recently we closed CASSANDRA-18039 which brought questions, probably we need 
> to revise how we detect JDK versions in CCM and whether it is correct. To the 
> best of my knowledge there are certain tests in the repo around that and they 
> pass so my guess is we need to revise just the strategy and maybe document it 
> explicitly or consider if we want any changes to be applied. Also, we need to 
> be careful with breaking changes. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-17603) Harry: improve column subset testing capabilities

2023-03-13 Thread Abe Ratnofsky (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-17603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699823#comment-17699823
 ] 

Abe Ratnofsky commented on CASSANDRA-17603:
---

Left a few comments on [https://github.com/apache/cassandra-harry/pull/17] 
(matches ticket number but not your previous link)

> Harry: improve column subset testing capabilities
> -
>
> Key: CASSANDRA-17603
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17603
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Test/fuzz
>Reporter: Alex Petrov
>Assignee: Alex Petrov
>Priority: Normal
>
> 1. Extend bitset to support > 64 bits
> 2. Allow for wildcard queries
> 3. Allow for validation of a subset of columns
> 4. Open API for hand-crafting both mutation and read queries



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-18124) Config parameter keystore_password should be nullable

2023-03-13 Thread Maulin Vasavada (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699821#comment-17699821
 ] 

Maulin Vasavada commented on CASSANDRA-18124:
-

Sure, soon enough. I was on instaclustr branch (inherited from the other 
issue's discussion). I can quickly raise a PR there while I work on the 4.1 
patch as per Brandon's suggestion.

> Config parameter keystore_password should be nullable
> -
>
> Key: CASSANDRA-18124
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18124
> Project: Cassandra
>  Issue Type: Bug
>  Components: Local/Config
>Reporter: Tibor Repasi
>Assignee: Maulin Vasavada
>Priority: Normal
> Fix For: 4.1.x, 5.x
>
>
> Some SSL configuration may pass unencrypted private keys. PEMReader might 
> accept that by assuming keyPassword to be null in that case (e.g. 
> https://github.com/apache/cassandra/blob/f9e033f519c14596da4dc954875756a69aea4e78/src/java/org/apache/cassandra/security/PEMReader.java#L103).
> Current configuration reader does not accept keystore_password parameter to 
> be set null or empty in the cassandra.yaml.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-18262) Switch ant targets running only with JDK8 to be run with JDK11

2023-03-13 Thread Ekaterina Dimitrova (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699822#comment-17699822
 ] 

Ekaterina Dimitrova commented on CASSANDRA-18262:
-

Ant jar, apologize I missed to say it earlier

> Switch ant targets running only with JDK8 to be run with JDK11
> --
>
> Key: CASSANDRA-18262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18262
> Project: Cassandra
>  Issue Type: Task
>  Components: Build
>Reporter: Ekaterina Dimitrova
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.0
>
>
> Currently we run checkstyle, eclipse warnings (and probably anything else?) 
> only with JDK8.
> In preparation to remove JDK8 we need to switch those to run with JDK11.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-18262) Switch ant targets running only with JDK8 to be run with JDK11

2023-03-13 Thread Brandon Williams (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699820#comment-17699820
 ] 

Brandon Williams commented on CASSANDRA-18262:
--

Which ant target are those times against?

> Switch ant targets running only with JDK8 to be run with JDK11
> --
>
> Key: CASSANDRA-18262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18262
> Project: Cassandra
>  Issue Type: Task
>  Components: Build
>Reporter: Ekaterina Dimitrova
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.0
>
>
> Currently we run checkstyle, eclipse warnings (and probably anything else?) 
> only with JDK8.
> In preparation to remove JDK8 we need to switch those to run with JDK11.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-18320) simulationTest is flaky

2023-03-13 Thread David Capwell (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699819#comment-17699819
 ] 

David Capwell commented on CASSANDRA-18320:
---

so far simulator looks stable with my patch, which is just

{code}
diff --git a/src/java/org/apache/cassandra/service/snapshot/SnapshotLoader.java 
b/src/java/org/apache/cassandra/service/snapshot/SnapshotLoader.java
index 532ea79f1b..37d286d721 100644
--- a/src/java/org/apache/cassandra/service/snapshot/SnapshotLoader.java
+++ b/src/java/org/apache/cassandra/service/snapshot/SnapshotLoader.java
@@ -23,7 +23,6 @@ import java.nio.file.FileVisitResult;
 import java.nio.file.Files;
 import java.nio.file.NoSuchFileException;
 import java.nio.file.Path;
-import java.nio.file.Paths;
 import java.nio.file.SimpleFileVisitor;
 import java.nio.file.attribute.BasicFileAttributes;
 import java.util.Arrays;
@@ -66,7 +65,7 @@ public class SnapshotLoader

 public SnapshotLoader(String[] dataDirectories)
 {
-
this(Arrays.stream(dataDirectories).map(Paths::get).collect(Collectors.toList()));
+
this(Arrays.stream(dataDirectories).map(File::new).map(File::toPath).collect(Collectors.toList()));
 }

 public SnapshotLoader(Collection dataDirs)
{code}

This looks like Paths.get is unsafe as its defined as

{code}
public static Path get(String first, String... more) {
return FileSystems.getDefault().getPath(first, more);
}
{code}

Since we don't override the default file system (its app ClassLoader and final) 
all usage will produce a Path that has a different FileSystem than File does; 
this implies that mixing Path and File may not be safe in the context of 
Simulator...

Ill talk to [~benedict] about this when he gets back

> simulationTest is flaky 
> 
>
> Key: CASSANDRA-18320
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18320
> Project: Cassandra
>  Issue Type: Bug
>  Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: David Capwell
>Priority: Normal
> Fix For: 4.1.x, 5.x
>
>
> {code}
> java.io.UncheckedIOException
>   at 
> org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:831)
>   at 
> org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:816)
>   at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:257)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:381)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
>   at java.util.ArrayList.forEach(ArrayList.java:1259)
>   at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395)
>   at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483)
>   at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
>   at 
> java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
>   at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
>   at 
> java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485)
>   at org.apache.cassandra.io.util.PathUtils.forEach(PathUtils.java:155)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:378)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
>   at java.util.ArrayList.forEach(ArrayList.java:1259)
>   at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395)
>   at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483)
>   at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
>   at 
> java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
>   at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
>   at 
> java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485)
>   at org.apache.cassandra.io.util.PathUtils.forEach(PathUtils.java:155)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:378)
>   at 
> org.apache.cassandra.distributed.impl.AbstractCluster.close(AbstractCluster.java:1047)
>   at 
> org.apache.cassandra.simulator.ClusterSimulation.close(ClusterSimulation.java:816)
>   at 
> org.apache.cassandra.simulator.SimulationRunner$Run.run(SimulationRunner.java:370)
>   at 
> org.apache.cassandra.simulator.SimulationRunner$BasicCommand.run(SimulationRunner.java:345)
>   at 
> org.apache.cassandra.simulator.paxos.PaxosSimulationRunner.main(PaxosSimulationRunner.java:148)
>   at 
> 

[jira] [Commented] (CASSANDRA-18262) Switch ant targets running only with JDK8 to be run with JDK11

2023-03-13 Thread Ekaterina Dimitrova (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699818#comment-17699818
 ] 

Ekaterina Dimitrova commented on CASSANDRA-18262:
-

{quote}it needs to be coordinated with CASSANDRA-18255.
{quote}
This ticket is part of CASSANDRA-18255 epic, we can close it last as part of 
that epic, but I think we already got a solution.
{quote}I run Brandon's branch CASSANDRA-18262-trunk.
{quote}
I also did some testing. 
My local build on trunk with the old checkstyle version we committed initially 
and JDK11:
{code:java}
BUILD SUCCESSFUL
Total time: 4 minutes 28 seconds
{code}
For comparison, again my mac, J11 before the switch of checkstyle J8 to J11, 
trunk:
{code:java}
BUILD SUCCESSFUL
Total time: 1 minute 12 seconds
{code}
With [~brandon.williams]'s last patch
{code:java}
BUILD SUCCESSFUL
Total time: 2 minutes 17 seconds
{code}

> Switch ant targets running only with JDK8 to be run with JDK11
> --
>
> Key: CASSANDRA-18262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18262
> Project: Cassandra
>  Issue Type: Task
>  Components: Build
>Reporter: Ekaterina Dimitrova
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.0
>
>
> Currently we run checkstyle, eclipse warnings (and probably anything else?) 
> only with JDK8.
> In preparation to remove JDK8 we need to switch those to run with JDK11.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-18262) Switch ant targets running only with JDK8 to be run with JDK11

2023-03-13 Thread Stefan Miklosovic (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699810#comment-17699810
 ] 

Stefan Miklosovic commented on CASSANDRA-18262:
---

{code}
$ java -version
openjdk version "11.0.18" 2023-01-17
OpenJDK Runtime Environment (build 11.0.18+10-post-Ubuntu-0ubuntu122.04)
OpenJDK 64-Bit Server VM (build 11.0.18+10-post-Ubuntu-0ubuntu122.04, mixed 
mode, sharing)
{code}

I run Brandon's branch CASSANDRA-18262-trunk.
 
It seems to be faster. Checkstyle on src / tests takes around 30s.

> Switch ant targets running only with JDK8 to be run with JDK11
> --
>
> Key: CASSANDRA-18262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18262
> Project: Cassandra
>  Issue Type: Task
>  Components: Build
>Reporter: Ekaterina Dimitrova
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.0
>
>
> Currently we run checkstyle, eclipse warnings (and probably anything else?) 
> only with JDK8.
> In preparation to remove JDK8 we need to switch those to run with JDK11.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-18221) CEP-15: (Accord) Define a configuration system for Accord to allow overriding of internal configs and integrate with Cassandra yaml

2023-03-13 Thread Kamalesh Palanisamy (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699804#comment-17699804
 ] 

Kamalesh Palanisamy commented on CASSANDRA-18221:
-

I will look into it, thanks [~maedhroz] 

> CEP-15: (Accord) Define a configuration system for Accord to allow overriding 
> of internal configs and integrate with Cassandra yaml
> ---
>
> Key: CASSANDRA-18221
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18221
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Accord
>Reporter: David Capwell
>Assignee: Kamalesh Palanisamy
>Priority: Normal
> Fix For: 5.x
>
>
> Users are used to modifying cassandra via yaml and JMX (for dynamic configs) 
> but accord does not integrate with this right now; we should enhance Accord 
> to expose configs that are defined in cassandra yaml.
> As an extension on this, we should figure out which configs are “dynamic” and 
> allow overriding via JMX or system vtable.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-18315) Implement Concurrent Quiescent Checker

2023-03-13 Thread Abe Ratnofsky (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699796#comment-17699796
 ] 

Abe Ratnofsky commented on CASSANDRA-18315:
---

+1'd

> Implement Concurrent Quiescent Checker 
> ---
>
> Key: CASSANDRA-18315
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18315
> Project: Cassandra
>  Issue Type: New Feature
>  Components: Test/fuzz
>Reporter: Alex Petrov
>Assignee: Alex Petrov
>Priority: High
>
> It is possible to implement a concurrent quiescent checker, which allows for 
> a high degree of concurrency, while allowing to pinpoint partition state 
> precisely. 
> Additional minor improvements:
>       * formatting
>       * thread shutdown on failed run creation
>       * idempotent query execution
>       * retry delay



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-18262) Switch ant targets running only with JDK8 to be run with JDK11

2023-03-13 Thread Brandon Williams (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699795#comment-17699795
 ] 

Brandon Williams commented on CASSANDRA-18262:
--

{noformat}
13:59:05 [checkstyle] Running Checkstyle 10.8.1 on 1519 files

13:59:46 
{noformat}

Looks like this cut the time to 41s on arm64.  The bad news is, 10.8.1 doesn't 
work with j8, so while it solves the problem it needs to be coordinated with 
CASSANDRA-18255.

> Switch ant targets running only with JDK8 to be run with JDK11
> --
>
> Key: CASSANDRA-18262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18262
> Project: Cassandra
>  Issue Type: Task
>  Components: Build
>Reporter: Ekaterina Dimitrova
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.0
>
>
> Currently we run checkstyle, eclipse warnings (and probably anything else?) 
> only with JDK8.
> In preparation to remove JDK8 we need to switch those to run with JDK11.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Comment Edited] (CASSANDRA-18318) Implement parsing schema provider for external SUT in Harry

2023-03-13 Thread Abe Ratnofsky (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699793#comment-17699793
 ] 

Abe Ratnofsky edited comment on CASSANDRA-18318 at 3/13/23 6:59 PM:


+1'd on GH: https://github.com/apache/cassandra-harry/pull/21


was (Author: aratnofsky):
+1'd on GH

> Implement parsing schema provider for external SUT in Harry
> ---
>
> Key: CASSANDRA-18318
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18318
> Project: Cassandra
>  Issue Type: New Feature
>  Components: Test/fuzz
>Reporter: Alex Petrov
>Assignee: Alex Petrov
>Priority: Normal
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-18318) Implement parsing schema provider for external SUT in Harry

2023-03-13 Thread Abe Ratnofsky (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699793#comment-17699793
 ] 

Abe Ratnofsky commented on CASSANDRA-18318:
---

+1'd on GH

> Implement parsing schema provider for external SUT in Harry
> ---
>
> Key: CASSANDRA-18318
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18318
> Project: Cassandra
>  Issue Type: New Feature
>  Components: Test/fuzz
>Reporter: Alex Petrov
>Assignee: Alex Petrov
>Priority: Normal
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-18320) simulationTest is flaky

2023-03-13 Thread David Capwell (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699787#comment-17699787
 ] 

David Capwell commented on CASSANDRA-18320:
---

think I have a patch but to help verify I changed simulator to throw error with 
seed rather than log the seed

PR: https://github.com/apache/cassandra/pull/2213
CI: 
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=CASSANDRA-18320

once I can get a repo, I can see if the patch I have (which is reverted in this 
branch) fixes it.

> simulationTest is flaky 
> 
>
> Key: CASSANDRA-18320
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18320
> Project: Cassandra
>  Issue Type: Bug
>  Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: David Capwell
>Priority: Normal
> Fix For: 4.1.x, 5.x
>
>
> {code}
> java.io.UncheckedIOException
>   at 
> org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:831)
>   at 
> org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:816)
>   at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:257)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:381)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
>   at java.util.ArrayList.forEach(ArrayList.java:1259)
>   at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395)
>   at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483)
>   at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
>   at 
> java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
>   at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
>   at 
> java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485)
>   at org.apache.cassandra.io.util.PathUtils.forEach(PathUtils.java:155)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:378)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
>   at java.util.ArrayList.forEach(ArrayList.java:1259)
>   at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395)
>   at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483)
>   at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
>   at 
> java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
>   at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
>   at 
> java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485)
>   at org.apache.cassandra.io.util.PathUtils.forEach(PathUtils.java:155)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:378)
>   at 
> org.apache.cassandra.distributed.impl.AbstractCluster.close(AbstractCluster.java:1047)
>   at 
> org.apache.cassandra.simulator.ClusterSimulation.close(ClusterSimulation.java:816)
>   at 
> org.apache.cassandra.simulator.SimulationRunner$Run.run(SimulationRunner.java:370)
>   at 
> org.apache.cassandra.simulator.SimulationRunner$BasicCommand.run(SimulationRunner.java:345)
>   at 
> org.apache.cassandra.simulator.paxos.PaxosSimulationRunner.main(PaxosSimulationRunner.java:148)
>   at 
> org.apache.cassandra.simulator.test.ShortPaxosSimulationTest.simulationTest(ShortPaxosSimulationTest.java:33)
> Caused by: java.nio.file.DirectoryNotEmptyException: 
> /cassandra/node1/commitlog
>   at 
> com.google.common.jimfs.FileSystemView.checkEmpty(FileSystemView.java:535)
>   at 
> com.google.common.jimfs.FileSystemView.checkDeletable(FileSystemView.java:517)
>   at 
> com.google.common.jimfs.FileSystemView.delete(FileSystemView.java:479)
>   at 
> com.google.common.jimfs.FileSystemView.deleteFile(FileSystemView.java:465)
>   at 
> com.google.common.jimfs.JimfsFileSystemProvider.delete(JimfsFileSystemProvider.java:261)
>   at java.nio.file.Files.delete(Files.java:1126)
>   at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:252)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Comment Edited] (CASSANDRA-18262) Switch ant targets running only with JDK8 to be run with JDK11

2023-03-13 Thread Brandon Williams (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699784#comment-17699784
 ] 

Brandon Williams edited comment on CASSANDRA-18262 at 3/13/23 6:23 PM:
---

Rather than figure out why this is slower, I upgraded checkstyle to 10.8.1 and 
that cut the time for checkstyle-test on my machine from 3 minutes to 30 
seconds.  Let's see how it fares in Jenkins' amd64 hosts.

||Branch||CI||
|[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-18262-trunk]|[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/2348/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/2348/pipeline]
  
[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/909/workflows/213ba26d-7e9b-4dc2-be69-73b215a9a466]|



was (Author: brandon.williams):
Rather than figure out why this is slower, I upgrade checkstyle to 10.8.1 and 
that cut the time for checkstyle-test on my machine from 3 minutes to 30 
seconds.  Let's see how it fares in Jenkins' amd64 hosts.

||Branch||CI||
|[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-18262-trunk]|[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/2348/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/2348/pipeline]
  
[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/909/workflows/213ba26d-7e9b-4dc2-be69-73b215a9a466]|


> Switch ant targets running only with JDK8 to be run with JDK11
> --
>
> Key: CASSANDRA-18262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18262
> Project: Cassandra
>  Issue Type: Task
>  Components: Build
>Reporter: Ekaterina Dimitrova
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.0
>
>
> Currently we run checkstyle, eclipse warnings (and probably anything else?) 
> only with JDK8.
> In preparation to remove JDK8 we need to switch those to run with JDK11.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-18262) Switch ant targets running only with JDK8 to be run with JDK11

2023-03-13 Thread Brandon Williams (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699784#comment-17699784
 ] 

Brandon Williams commented on CASSANDRA-18262:
--

Rather than figure out why this is slower, I upgrade checkstyle to 10.8.1 and 
that cut the time for checkstyle-test on my machine from 3 minutes to 30 
seconds.  Let's see how it fares in Jenkins' amd64 hosts.

||Branch||CI||
|[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-18262-trunk]|[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/2348/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/2348/pipeline]
  
[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/909/workflows/213ba26d-7e9b-4dc2-be69-73b215a9a466]|


> Switch ant targets running only with JDK8 to be run with JDK11
> --
>
> Key: CASSANDRA-18262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18262
> Project: Cassandra
>  Issue Type: Task
>  Components: Build
>Reporter: Ekaterina Dimitrova
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.0
>
>
> Currently we run checkstyle, eclipse warnings (and probably anything else?) 
> only with JDK8.
> In preparation to remove JDK8 we need to switch those to run with JDK11.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-18320) simulationTest is flaky

2023-03-13 Thread David Capwell (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699777#comment-17699777
 ] 

David Capwell commented on CASSANDRA-18320:
---

going to see if I can reproduce, I want to make sure we don't loose the seed 
and if blocking on awaitTermination even if another thread did shutdown

> simulationTest is flaky 
> 
>
> Key: CASSANDRA-18320
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18320
> Project: Cassandra
>  Issue Type: Bug
>  Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: David Capwell
>Priority: Normal
> Fix For: 4.1.x, 5.x
>
>
> {code}
> java.io.UncheckedIOException
>   at 
> org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:831)
>   at 
> org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:816)
>   at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:257)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:381)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
>   at java.util.ArrayList.forEach(ArrayList.java:1259)
>   at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395)
>   at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483)
>   at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
>   at 
> java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
>   at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
>   at 
> java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485)
>   at org.apache.cassandra.io.util.PathUtils.forEach(PathUtils.java:155)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:378)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
>   at java.util.ArrayList.forEach(ArrayList.java:1259)
>   at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395)
>   at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483)
>   at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
>   at 
> java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
>   at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
>   at 
> java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485)
>   at org.apache.cassandra.io.util.PathUtils.forEach(PathUtils.java:155)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:378)
>   at 
> org.apache.cassandra.distributed.impl.AbstractCluster.close(AbstractCluster.java:1047)
>   at 
> org.apache.cassandra.simulator.ClusterSimulation.close(ClusterSimulation.java:816)
>   at 
> org.apache.cassandra.simulator.SimulationRunner$Run.run(SimulationRunner.java:370)
>   at 
> org.apache.cassandra.simulator.SimulationRunner$BasicCommand.run(SimulationRunner.java:345)
>   at 
> org.apache.cassandra.simulator.paxos.PaxosSimulationRunner.main(PaxosSimulationRunner.java:148)
>   at 
> org.apache.cassandra.simulator.test.ShortPaxosSimulationTest.simulationTest(ShortPaxosSimulationTest.java:33)
> Caused by: java.nio.file.DirectoryNotEmptyException: 
> /cassandra/node1/commitlog
>   at 
> com.google.common.jimfs.FileSystemView.checkEmpty(FileSystemView.java:535)
>   at 
> com.google.common.jimfs.FileSystemView.checkDeletable(FileSystemView.java:517)
>   at 
> com.google.common.jimfs.FileSystemView.delete(FileSystemView.java:479)
>   at 
> com.google.common.jimfs.FileSystemView.deleteFile(FileSystemView.java:465)
>   at 
> com.google.common.jimfs.JimfsFileSystemProvider.delete(JimfsFileSystemProvider.java:261)
>   at java.nio.file.Files.delete(Files.java:1126)
>   at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:252)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Assigned] (CASSANDRA-18320) simulationTest is flaky

2023-03-13 Thread David Capwell (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-18320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Capwell reassigned CASSANDRA-18320:
-

Assignee: David Capwell

> simulationTest is flaky 
> 
>
> Key: CASSANDRA-18320
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18320
> Project: Cassandra
>  Issue Type: Bug
>  Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: David Capwell
>Priority: Normal
> Fix For: 4.1.x, 5.x
>
>
> {code}
> java.io.UncheckedIOException
>   at 
> org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:831)
>   at 
> org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:816)
>   at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:257)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:381)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
>   at java.util.ArrayList.forEach(ArrayList.java:1259)
>   at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395)
>   at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483)
>   at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
>   at 
> java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
>   at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
>   at 
> java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485)
>   at org.apache.cassandra.io.util.PathUtils.forEach(PathUtils.java:155)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:378)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
>   at java.util.ArrayList.forEach(ArrayList.java:1259)
>   at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395)
>   at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483)
>   at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
>   at 
> java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
>   at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
>   at 
> java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485)
>   at org.apache.cassandra.io.util.PathUtils.forEach(PathUtils.java:155)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:378)
>   at 
> org.apache.cassandra.distributed.impl.AbstractCluster.close(AbstractCluster.java:1047)
>   at 
> org.apache.cassandra.simulator.ClusterSimulation.close(ClusterSimulation.java:816)
>   at 
> org.apache.cassandra.simulator.SimulationRunner$Run.run(SimulationRunner.java:370)
>   at 
> org.apache.cassandra.simulator.SimulationRunner$BasicCommand.run(SimulationRunner.java:345)
>   at 
> org.apache.cassandra.simulator.paxos.PaxosSimulationRunner.main(PaxosSimulationRunner.java:148)
>   at 
> org.apache.cassandra.simulator.test.ShortPaxosSimulationTest.simulationTest(ShortPaxosSimulationTest.java:33)
> Caused by: java.nio.file.DirectoryNotEmptyException: 
> /cassandra/node1/commitlog
>   at 
> com.google.common.jimfs.FileSystemView.checkEmpty(FileSystemView.java:535)
>   at 
> com.google.common.jimfs.FileSystemView.checkDeletable(FileSystemView.java:517)
>   at 
> com.google.common.jimfs.FileSystemView.delete(FileSystemView.java:479)
>   at 
> com.google.common.jimfs.FileSystemView.deleteFile(FileSystemView.java:465)
>   at 
> com.google.common.jimfs.JimfsFileSystemProvider.delete(JimfsFileSystemProvider.java:261)
>   at java.nio.file.Files.delete(Files.java:1126)
>   at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:252)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-18320) simulationTest is flaky

2023-03-13 Thread David Capwell (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699759#comment-17699759
 ] 

David Capwell commented on CASSANDRA-18320:
---

looking at the code I feel the following could be happening

{code}
synchronized public void shutdownBlocking() throws InterruptedException
{
if (!started)
return;

started = false;
executor.shutdown();
executor.awaitTermination();
segmentManager.shutdown();
segmentManager.awaitTermination(1L, TimeUnit.MINUTES);
}
{code}

If we shutdown before close calls this, then the close future will be success 
right away as there isn't actually a blocking call... creating a shutdown 
future would help solve that

Sadly Simulator isn't showing you the seed in the exception, so hard to confirm 
such a patch actually solves the problem.

> simulationTest is flaky 
> 
>
> Key: CASSANDRA-18320
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18320
> Project: Cassandra
>  Issue Type: Bug
>  Components: CI
>Reporter: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 4.1.x, 5.x
>
>
> {code}
> java.io.UncheckedIOException
>   at 
> org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:831)
>   at 
> org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:816)
>   at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:257)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:381)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
>   at java.util.ArrayList.forEach(ArrayList.java:1259)
>   at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395)
>   at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483)
>   at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
>   at 
> java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
>   at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
>   at 
> java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485)
>   at org.apache.cassandra.io.util.PathUtils.forEach(PathUtils.java:155)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:378)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
>   at java.util.ArrayList.forEach(ArrayList.java:1259)
>   at java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395)
>   at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:483)
>   at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
>   at 
> java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
>   at 
> java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
>   at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
>   at 
> java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485)
>   at org.apache.cassandra.io.util.PathUtils.forEach(PathUtils.java:155)
>   at 
> org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:378)
>   at 
> org.apache.cassandra.distributed.impl.AbstractCluster.close(AbstractCluster.java:1047)
>   at 
> org.apache.cassandra.simulator.ClusterSimulation.close(ClusterSimulation.java:816)
>   at 
> org.apache.cassandra.simulator.SimulationRunner$Run.run(SimulationRunner.java:370)
>   at 
> org.apache.cassandra.simulator.SimulationRunner$BasicCommand.run(SimulationRunner.java:345)
>   at 
> org.apache.cassandra.simulator.paxos.PaxosSimulationRunner.main(PaxosSimulationRunner.java:148)
>   at 
> org.apache.cassandra.simulator.test.ShortPaxosSimulationTest.simulationTest(ShortPaxosSimulationTest.java:33)
> Caused by: java.nio.file.DirectoryNotEmptyException: 
> /cassandra/node1/commitlog
>   at 
> com.google.common.jimfs.FileSystemView.checkEmpty(FileSystemView.java:535)
>   at 
> com.google.common.jimfs.FileSystemView.checkDeletable(FileSystemView.java:517)
>   at 
> com.google.common.jimfs.FileSystemView.delete(FileSystemView.java:479)
>   at 
> com.google.common.jimfs.FileSystemView.deleteFile(FileSystemView.java:465)
>   at 
> com.google.common.jimfs.JimfsFileSystemProvider.delete(JimfsFileSystemProvider.java:261)
>   at java.nio.file.Files.delete(Files.java:1126)
>   at org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:252)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (CASSANDRA-18320) simulationTest is flaky

2023-03-13 Thread David Capwell (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699752#comment-17699752
 ] 

David Capwell edited comment on CASSANDRA-18320 at 3/13/23 5:35 PM:


[~maedhroz] is rebasing accord branch and has an interesting stack trace

https://app.circleci.com/pipelines/github/maedhroz/cassandra/696/workflows/180e9555-6796-4733-8214-ba94fb9484fd/jobs/6936/tests#failed-test-0

{code}
java.lang.IllegalArgumentException: Incompatible file system
at org.apache.cassandra.io.util.File.(File.java:135)
at 
org.apache.cassandra.service.snapshot.SnapshotLoader.loadSnapshots(SnapshotLoader.java:173)
at 
org.apache.cassandra.service.snapshot.SnapshotLoader.loadSnapshots(SnapshotLoader.java:189)
at 
org.apache.cassandra.service.snapshot.SnapshotManager.loadSnapshots(SnapshotManager.java:119)
at 
org.apache.cassandra.service.snapshot.SnapshotManager.start(SnapshotManager.java:88)
at 
org.apache.cassandra.service.StorageService.startSnapshotManager(StorageService.java:1160)
at 
org.apache.cassandra.distributed.impl.Instance.lambda$startup$12(Instance.java:712)
at org.apache.cassandra.concurrent.FutureTask$1.call(FutureTask.java:96)
at 
org.apache.cassandra.concurrent.SyncFutureTask.run(SyncFutureTask.java:68)
at 
org.apache.cassandra.simulator.systems.InterceptingExecutor$InterceptingPooledExecutor$WaitingThread.lambda$new$1(InterceptingExecutor.java:317)
at 
io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.base/java.lang.Thread.run(Thread.java:829)
Suppressed: java.io.UncheckedIOException
at 
org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:831)
at 
org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:816)
at 
org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:257)
at 
org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:381)
at 
java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
at 
java.base/java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395)
at 
java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:485)
at 
java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
at 
java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
at 
java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
at 
java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at 
java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:497)
at 
org.apache.cassandra.io.util.PathUtils.forEach(PathUtils.java:155)
at 
org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:378)
at 
java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
at 
java.base/java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395)
at 
java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:485)
at 
java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
at 
java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
at 
java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
at 
java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at 
java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:497)
at 
org.apache.cassandra.io.util.PathUtils.forEach(PathUtils.java:155)
at 
org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:378)
at 
org.apache.cassandra.distributed.impl.AbstractCluster.close(AbstractCluster.java:1047)
at 
org.apache.cassandra.simulator.ClusterSimulation.close(ClusterSimulation.java:819)
at 
org.apache.cassandra.simulator.SimulationRunner$Run.run(SimulationRunner.java:370)
at 
org.apache.cassandra.simulator.paxos.AccordSimulationRunner$Run.run(AccordSimulationRunner.java:39)
at 
org.apache.cassandra.simulator.paxos.AccordSimulationRunner$Run.run(AccordSimulationRunner.java:30)
at 

[jira] [Commented] (CASSANDRA-18320) simulationTest is flaky

2023-03-13 Thread David Capwell (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699752#comment-17699752
 ] 

David Capwell commented on CASSANDRA-18320:
---

[~maedhroz] is rebasing accord branch and has an interesting stack trace

https://app.circleci.com/pipelines/github/maedhroz/cassandra/696/workflows/180e9555-6796-4733-8214-ba94fb9484fd/jobs/6936/tests#failed-test-0

{code}
java.lang.IllegalArgumentException: Incompatible file system
at org.apache.cassandra.io.util.File.(File.java:135)
at 
org.apache.cassandra.service.snapshot.SnapshotLoader.loadSnapshots(SnapshotLoader.java:173)
at 
org.apache.cassandra.service.snapshot.SnapshotLoader.loadSnapshots(SnapshotLoader.java:189)
at 
org.apache.cassandra.service.snapshot.SnapshotManager.loadSnapshots(SnapshotManager.java:119)
at 
org.apache.cassandra.service.snapshot.SnapshotManager.start(SnapshotManager.java:88)
at 
org.apache.cassandra.service.StorageService.startSnapshotManager(StorageService.java:1160)
at 
org.apache.cassandra.distributed.impl.Instance.lambda$startup$12(Instance.java:712)
at org.apache.cassandra.concurrent.FutureTask$1.call(FutureTask.java:96)
at 
org.apache.cassandra.concurrent.SyncFutureTask.run(SyncFutureTask.java:68)
at 
org.apache.cassandra.simulator.systems.InterceptingExecutor$InterceptingPooledExecutor$WaitingThread.lambda$new$1(InterceptingExecutor.java:317)
at 
io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.base/java.lang.Thread.run(Thread.java:829)
Suppressed: java.io.UncheckedIOException
at 
org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:831)
at 
org.apache.cassandra.io.util.PathUtils.propagateUnchecked(PathUtils.java:816)
at 
org.apache.cassandra.io.util.PathUtils.delete(PathUtils.java:257)
at 
org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:381)
at 
java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
at 
java.base/java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395)
at 
java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:485)
at 
java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
at 
java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
at 
java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
at 
java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at 
java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:497)
at 
org.apache.cassandra.io.util.PathUtils.forEach(PathUtils.java:155)
at 
org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:378)
at 
java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
at 
java.base/java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395)
at 
java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:485)
at 
java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
at 
java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
at 
java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
at 
java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at 
java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:497)
at 
org.apache.cassandra.io.util.PathUtils.forEach(PathUtils.java:155)
at 
org.apache.cassandra.io.util.PathUtils.deleteRecursive(PathUtils.java:378)
at 
org.apache.cassandra.distributed.impl.AbstractCluster.close(AbstractCluster.java:1047)
at 
org.apache.cassandra.simulator.ClusterSimulation.close(ClusterSimulation.java:819)
at 
org.apache.cassandra.simulator.SimulationRunner$Run.run(SimulationRunner.java:370)
at 
org.apache.cassandra.simulator.paxos.AccordSimulationRunner$Run.run(AccordSimulationRunner.java:39)
at 
org.apache.cassandra.simulator.paxos.AccordSimulationRunner$Run.run(AccordSimulationRunner.java:30)
at 
org.apache.cassandra.simulator.SimulationRunner$BasicCommand.run(SimulationRunner.java:355)
at 

[jira] [Updated] (CASSANDRA-18262) Switch ant targets running only with JDK8 to be run with JDK11

2023-03-13 Thread Brandon Williams (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brandon Williams updated CASSANDRA-18262:
-
Resolution: (was: Fixed)
Status: Open  (was: Resolved)

Reopened to investigate why this takes so much longer to run on (at least) 
arm64.

> Switch ant targets running only with JDK8 to be run with JDK11
> --
>
> Key: CASSANDRA-18262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18262
> Project: Cassandra
>  Issue Type: Task
>  Components: Build
>Reporter: Ekaterina Dimitrova
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.0
>
>
> Currently we run checkstyle, eclipse warnings (and probably anything else?) 
> only with JDK8.
> In preparation to remove JDK8 we need to switch those to run with JDK11.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[cassandra] branch trunk updated: Revert "Switch checkstyle to j11."

2023-03-13 Thread brandonwilliams
This is an automated email from the ASF dual-hosted git repository.

brandonwilliams pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git


The following commit(s) were added to refs/heads/trunk by this push:
 new 7ad746cc83 Revert "Switch checkstyle to j11."
7ad746cc83 is described below

commit 7ad746cc839199ac9b8d7ba9a6f2b2f980ea3461
Author: Brandon Williams 
AuthorDate: Mon Mar 13 11:59:37 2023 -0500

Revert "Switch checkstyle to j11."

This reverts commit 4e3447ae1727a0d01c9d81792acbdeeef94d86d2.
---
 build.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/build.xml b/build.xml
index 9603db41bf..197f720472 100644
--- a/build.xml
+++ b/build.xml
@@ -1948,7 +1948,7 @@
classpathref="checkstyle.lib.path"/>
   
 
-  
+  
   
   
   
@@ -1964,7 +1964,7 @@
   
   
 
-  
+  
   
   
   


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[cassandra-website] branch asf-staging updated (765f01a4 -> 686dd2d8)

2023-03-13 Thread git-site-role
This is an automated email from the ASF dual-hosted git repository.

git-site-role pushed a change to branch asf-staging
in repository https://gitbox.apache.org/repos/asf/cassandra-website.git


 discard 765f01a4 generate docs for c4206294
 new 686dd2d8 generate docs for c4206294

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (765f01a4)
\
 N -- N -- N   refs/heads/asf-staging (686dd2d8)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 content/search-index.js |   2 +-
 site-ui/build/ui-bundle.zip | Bin 4796442 -> 4796442 bytes
 2 files changed, 1 insertion(+), 1 deletion(-)


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-18221) CEP-15: (Accord) Define a configuration system for Accord to allow overriding of internal configs and integrate with Cassandra yaml

2023-03-13 Thread Caleb Rackliffe (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-18221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caleb Rackliffe updated CASSANDRA-18221:

Reviewers: Caleb Rackliffe, David Capwell

> CEP-15: (Accord) Define a configuration system for Accord to allow overriding 
> of internal configs and integrate with Cassandra yaml
> ---
>
> Key: CASSANDRA-18221
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18221
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Accord
>Reporter: David Capwell
>Assignee: Kamalesh Palanisamy
>Priority: Normal
> Fix For: 5.x
>
>
> Users are used to modifying cassandra via yaml and JMX (for dynamic configs) 
> but accord does not integrate with this right now; we should enhance Accord 
> to expose configs that are defined in cassandra yaml.
> As an extension on this, we should figure out which configs are “dynamic” and 
> allow overriding via JMX or system vtable.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-18302) Fix AIOOBE and improve validation messages for transaction statements

2023-03-13 Thread Caleb Rackliffe (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-18302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Caleb Rackliffe updated CASSANDRA-18302:

Reviewers: Caleb Rackliffe, David Capwell  (was: Caleb Rackliffe)

> Fix AIOOBE and improve validation messages for transaction statements
> -
>
> Key: CASSANDRA-18302
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18302
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Accord
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 5.x
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Currently it happens sometimes that ArrayIndexOutOfBoundsException is thrown 
> from asCql method when validation transaction statement. In addition, asCql 
> does not return precisely the query user entered so the whole error message 
> can be misleading.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Comment Edited] (CASSANDRA-18222) Fix flaky test org.apache.cassandra.distributed.test.accord.AccordIntegrationTest

2023-03-13 Thread Caleb Rackliffe (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699124#comment-17699124
 ] 

Caleb Rackliffe edited comment on CASSANDRA-18222 at 3/13/23 3:30 PM:
--

After some quick discussion w/ [~dcapwell], it looks like there might not be a 
way to both stabilize this test and preserve its original purpose w/o 
CASSANDRA-18221 in place to disable (or at least make much less aggressive) the 
new {{SimpleProgressLog}}, which appears to be very aggressively pre-empting 
the write transaction in the test.

Temporarily stopping progress...


was (Author: maedhroz):
After some quick discussion w/ [~dcapwell], it looks like there might not be a 
way to both stabilize this test and preserve its original purpose w/o 
CASSANDRA-18221 in place to disable (or at least make much less aggressive) the 
new `SimpleProgressLog`, which appears to be very aggressively pre-empting the 
write transaction in the test.

Temporarily stopping progress...

> Fix flaky test 
> org.apache.cassandra.distributed.test.accord.AccordIntegrationTest
> -
>
> Key: CASSANDRA-18222
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18222
> Project: Cassandra
>  Issue Type: Bug
>  Components: Accord, CI
>Reporter: David Capwell
>Assignee: Caleb Rackliffe
>Priority: Normal
> Fix For: 5.x
>
>
> The accord integration tests are currently flaky due to Preempt happening (we 
> convert that to a timeout).  We need to address this to make sure the tests 
> are stable.
> One solution may be make SimpleProgressLog’s frequency run different for 
> jvm-dtest (likely to depend on CASSANDRA-18221 ), this would be similar to 
> what we already do as timeouts maybe larger in jvm-dtest due to the extra 
> complexity running multiple processes in the same JVM.  Another solution may 
> be to have the client coordinator “attach” to the new coordinator, this would 
> avoid the user being impacted by this preempt when the coordinator is 
> healthy.  
> Example: 
> https://app.circleci.com/pipelines/github/dcapwell/cassandra/1822/workflows/0d92898f-ad7d-4a7d-9198-3a7ce844ee93/jobs/16464



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-17281) Add hooks for the Javascript UDF to enable people to plugin their own implementations of scripted UDFs

2023-03-13 Thread Ekaterina Dimitrova (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-17281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ekaterina Dimitrova updated CASSANDRA-17281:

Epic Link:   (was: CASSANDRA-16895)

> Add hooks for the Javascript UDF to enable people to plugin their own 
> implementations of scripted UDFs
> --
>
> Key: CASSANDRA-17281
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17281
> Project: Cassandra
>  Issue Type: Task
>  Components: Feature/UDF
>Reporter: Ekaterina Dimitrova
>Assignee: Benjamin Lerer
>Priority: Normal
> Fix For: 5.x
>
>
> [Consensus |https://lists.apache.org/thread/mnxh94lg9v94bfntq88051z3ww16q2fk] 
>  was reached to remove JavaScript UDF with the next major release. 
> We need to leave an interface for those who would like to supply a UDF 
> implementation. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[cassandra-website] branch asf-staging updated (7df77e19 -> 765f01a4)

2023-03-13 Thread git-site-role
This is an automated email from the ASF dual-hosted git repository.

git-site-role pushed a change to branch asf-staging
in repository https://gitbox.apache.org/repos/asf/cassandra-website.git


 discard 7df77e19 generate docs for c4206294
 new 765f01a4 generate docs for c4206294

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (7df77e19)
\
 N -- N -- N   refs/heads/asf-staging (765f01a4)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 content/search-index.js |   2 +-
 site-ui/build/ui-bundle.zip | Bin 4796442 -> 4796442 bytes
 2 files changed, 1 insertion(+), 1 deletion(-)


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-18314) Lift MessagingService.minimum_version to 40

2023-03-13 Thread Michael Semb Wever (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699635#comment-17699635
 ] 

Michael Semb Wever commented on CASSANDRA-18314:


dev@ thread: https://lists.apache.org/thread/1pcnth265xb3jyf832dlgtbgsnqvtdot

> Lift MessagingService.minimum_version to 40
> ---
>
> Key: CASSANDRA-18314
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18314
> Project: Cassandra
>  Issue Type: Task
>  Components: Messaging/Internode
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 5.x
>
>
> MessagingService's VERSION_30 and VERSION_3014 don't have to be supported in 
> Cassandra 5.0 anymore.
> (Cassandra 5.0 currently is still using VERSION_40)
> Patch: 
> https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/18314/trunk
> Raises the question whether backward compatibility to the previous major is 
> defined by the Cassandra version or by the internal component version 
> (MessagingService).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-18049) Update Chronicle Queue

2023-03-13 Thread Michael Semb Wever (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699634#comment-17699634
 ] 

Michael Semb Wever commented on CASSANDRA-18049:


dev@ thread: https://lists.apache.org/thread/hp5tokf2gr20dp3w5mzssgm4xgt97wg6

> Update Chronicle Queue
> --
>
> Key: CASSANDRA-18049
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18049
> Project: Cassandra
>  Issue Type: Task
>Reporter: Ekaterina Dimitrova
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 5.x
>
>
> According to [this|https://chronicle.software/chronicle-support-java-17] 
> article:
> {code:java}
> Starting from chronicle-bom-2.22ea26, all new releases can be run under Java 
> 17 when run on the class path (but not yet under the module path).{code}
> This BOM is newer than what we currently have in both 4.1 and trunk. 4.1 
> points in comments to 
> [https://mvnrepository.com/artifact/net.openhft/chronicle-bom/1.16.23] which 
> I believe was just forgotten to be updated/removed. The versions we see 
> correspond to this BOM 
> [https://mvnrepository.com/artifact/net.openhft/chronicle-bom/2.20.226]
> It is still older than chronicle-bom-2.22ea26 so we need to upgrade. I 
> suggest we also add a comment again which BOM is considered, this makes 
> things easier.
> Further to running CI, review of the CHANGE logs needs to happen to ensure we 
> do not miss anything that can impact us and it is not caught by our tests.
> For testing with JDK17, please, contact [~e.dimitrova] for latest branch and 
> CI config (at this point feature branch in the cassandra repo does not exist)
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-18049) Update Chronicle Queue

2023-03-13 Thread Michael Semb Wever (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-18049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Semb Wever updated CASSANDRA-18049:
---
Status: Patch Available  (was: In Progress)

> Update Chronicle Queue
> --
>
> Key: CASSANDRA-18049
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18049
> Project: Cassandra
>  Issue Type: Task
>Reporter: Ekaterina Dimitrova
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 5.x
>
>
> According to [this|https://chronicle.software/chronicle-support-java-17] 
> article:
> {code:java}
> Starting from chronicle-bom-2.22ea26, all new releases can be run under Java 
> 17 when run on the class path (but not yet under the module path).{code}
> This BOM is newer than what we currently have in both 4.1 and trunk. 4.1 
> points in comments to 
> [https://mvnrepository.com/artifact/net.openhft/chronicle-bom/1.16.23] which 
> I believe was just forgotten to be updated/removed. The versions we see 
> correspond to this BOM 
> [https://mvnrepository.com/artifact/net.openhft/chronicle-bom/2.20.226]
> It is still older than chronicle-bom-2.22ea26 so we need to upgrade. I 
> suggest we also add a comment again which BOM is considered, this makes 
> things easier.
> Further to running CI, review of the CHANGE logs needs to happen to ensure we 
> do not miss anything that can impact us and it is not caught by our tests.
> For testing with JDK17, please, contact [~e.dimitrova] for latest branch and 
> CI config (at this point feature branch in the cassandra repo does not exist)
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-18323) Remove org.apache.cassandra.hadoop code

2023-03-13 Thread Stefan Miklosovic (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-18323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Miklosovic updated CASSANDRA-18323:
--
Epic Link: CASSANDRA-18306

> Remove org.apache.cassandra.hadoop code
> ---
>
> Key: CASSANDRA-18323
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18323
> Project: Cassandra
>  Issue Type: Task
>  Components: Legacy/Core
>Reporter: Stefan Miklosovic
>Assignee: Stefan Miklosovic
>Priority: Normal
> Fix For: 5.x
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-16984) Deprecate org.apache.cassandra.hadoop code

2023-03-13 Thread Brandon Williams (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699604#comment-17699604
 ] 

Brandon Williams commented on CASSANDRA-16984:
--

I linked it.

> Deprecate org.apache.cassandra.hadoop code
> --
>
> Key: CASSANDRA-16984
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16984
> Project: Cassandra
>  Issue Type: Task
>  Components: Local/Other
>Reporter: Stefan Miklosovic
>Assignee: Stefan Miklosovic
>Priority: Normal
> Fix For: 4.1.1, 5.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The code under org.apache.cassandra.hadoop is becoming a legacy and probably 
> should be deleted.
> The code does not have any example / test how to use it, it is not documented 
> and it depends on Hadoop of version 1 which is hardly used nowadays.
> This ticket should track its deletion.
> Feel free to object and we might revisit this decision. If we remove it in 
> 4.1, it will still be present in 4.0.x where we can still patch.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-16984) Deprecate org.apache.cassandra.hadoop code

2023-03-13 Thread Jacek Lewandowski (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699603#comment-17699603
 ] 

Jacek Lewandowski commented on CASSANDRA-16984:
---

[~stefan.miklosovic] is there a one with removal?

> Deprecate org.apache.cassandra.hadoop code
> --
>
> Key: CASSANDRA-16984
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16984
> Project: Cassandra
>  Issue Type: Task
>  Components: Local/Other
>Reporter: Stefan Miklosovic
>Assignee: Stefan Miklosovic
>Priority: Normal
> Fix For: 4.1.1, 5.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The code under org.apache.cassandra.hadoop is becoming a legacy and probably 
> should be deleted.
> The code does not have any example / test how to use it, it is not documented 
> and it depends on Hadoop of version 1 which is hardly used nowadays.
> This ticket should track its deletion.
> Feel free to object and we might revisit this decision. If we remove it in 
> 4.1, it will still be present in 4.0.x where we can still patch.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-18176) Merged SSTable files not reclaimed by OS

2023-03-13 Thread Pere Balaguer (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699596#comment-17699596
 ] 

Pere Balaguer commented on CASSANDRA-18176:
---

Hey [~benedict] , if that's the situation on your end don't worry, I'll try to 
backport it myself and see how it goes from there. If I can't figure it out 
I'll ping here again.

This effort is not meant to stop nor delay [~jmckenzie] but to happen in 
parallel.

> Merged SSTable files not reclaimed by OS
> 
>
> Key: CASSANDRA-18176
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18176
> Project: Cassandra
>  Issue Type: Bug
>  Components: Local/Compaction
>Reporter: Pere Balaguer
>Priority: Normal
> Fix For: 4.0.x
>
>
> (EDIT: Looks like this is masked by the lack of backport of CASSANDRA-17205 
> just on the 4.0 line - will backport that and block here on it)
> After upgrading to Cassandra 4.x (4.0.1 and 4.0.5) we've noticed that at 
> times after a compaction deleted sstables diskspace doesn't get reclaimed by 
> the OS until the cassandra process is restarted (which kinda points at some 
> sort of resource leak), I do not recall this happening in cassandra 3, at 
> least not to such degree.
> We've seen the behavior in multiple clusters with different schemas, access 
> patterns and consistency levels at somewhat "random" points in time, the only 
> interesting thing is that there were active repair sessions at the time 
> affecting the node, keyspace and table.
> {noformat}
> $ date +%Y-%m-%d
> 2023-01-17
> $ nodetool version
> ReleaseVersion: 4.0.5
> {noformat}
> {noformat}
> $ lsof +L1 | grep cassandra | grep myawesomecluster | wc -l
> 2772
> $ lsof +L1 | grep cassandra | grep myawesomecluster | tail -n1
> java  59003 cassandra *979u   REG  253,810 0 1208053768 
> /cassandra-data/data/myawesomecluster/schema_one-randomchecksum/nb-2274426-big-Digest.crc32
>  (deleted)
> {noformat}
> {noformat}
> $ grep 2274426 /cassandra/systemlog.log
> INFO  [Stream-Deserializer-/10.214.79.62:randomport-b904af67] 2023-01-15 
> 13:06:24,969 BigTableZeroCopyWriter.java:203 - Writing component DATA to 
> /cassandra-data/data/myawesomecluster/schema_one-randomchecksum/nb-2274426-big-Data.db
>  length 2.900KiB
> INFO  [Stream-Deserializer-/10.214.79.62:randomport-b904af67] 2023-01-15 
> 13:06:24,969 BigTableZeroCopyWriter.java:213 - Block Writing component to 
> /cassandra-data/data/myawesomecluster/schema_one-randomchecksum/nb-2274426-big-Data.db
>  length 2.900KiB
> INFO  [Stream-Deserializer-/10.214.79.62:randomport-b904af67] 2023-01-15 
> 13:06:24,970 BigTableZeroCopyWriter.java:203 - Writing component 
> PRIMARY_INDEX to 
> /cassandra-data/data/myawesomecluster/schema_one-randomchecksum/nb-2274426-big-Index.db
>  length 3.739KiB
> INFO  [Stream-Deserializer-/10.214.79.62:randomport-b904af67] 2023-01-15 
> 13:06:24,970 BigTableZeroCopyWriter.java:213 - Block Writing component to 
> /cassandra-data/data/myawesomecluster/schema_one-randomchecksum/nb-2274426-big-Index.db
>  length 3.739KiB
> INFO  [Stream-Deserializer-/10.214.79.62:randomport-b904af67] 2023-01-15 
> 13:06:24,970 BigTableZeroCopyWriter.java:203 - Writing component STATS to 
> /cassandra-data/data/myawesomecluster/schema_one-randomchecksum/nb-2274426-big-Statistics.db
>  length 5.062KiB
> INFO  [Stream-Deserializer-/10.214.79.62:randomport-b904af67] 2023-01-15 
> 13:06:24,970 BigTableZeroCopyWriter.java:213 - Block Writing component to 
> /cassandra-data/data/myawesomecluster/schema_one-randomchecksum/nb-2274426-big-Statistics.db
>  length 5.062KiB
> INFO  [Stream-Deserializer-/10.214.79.62:randomport-b904af67] 2023-01-15 
> 13:06:24,971 BigTableZeroCopyWriter.java:203 - Writing component 
> COMPRESSION_INFO to 
> /cassandra-data/data/myawesomecluster/schema_one-randomchecksum/nb-2274426-big-CompressionInfo.db
>  length 0.054KiB
> INFO  [Stream-Deserializer-/10.214.79.62:randomport-b904af67] 2023-01-15 
> 13:06:24,971 BigTableZeroCopyWriter.java:213 - Block Writing component to 
> /cassandra-data/data/myawesomecluster/schema_one-randomchecksum/nb-2274426-big-CompressionInfo.db
>  length 0.054KiB
> INFO  [Stream-Deserializer-/10.214.79.62:randomport-b904af67] 2023-01-15 
> 13:06:24,971 BigTableZeroCopyWriter.java:203 - Writing component FILTER to 
> /cassandra-data/data/myawesomecluster/schema_one-randomchecksum/nb-2274426-big-Filter.db
>  length 0.031KiB
> INFO  [Stream-Deserializer-/10.214.79.62:randomport-b904af67] 2023-01-15 
> 13:06:24,971 BigTableZeroCopyWriter.java:213 - Block Writing component to 
> /cassandra-data/data/myawesomecluster/schema_one-randomchecksum/nb-2274426-big-Filter.db
>  length 0.031KiB
> INFO  [Stream-Deserializer-/10.214.79.62:randomport-b904af67] 2023-01-15 
> 13:06:24,972 BigTableZeroCopyWriter.java:203 - Writing 

[jira] [Commented] (CASSANDRA-18124) Config parameter keystore_password should be nullable

2023-03-13 Thread Stefan Miklosovic (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699582#comment-17699582
 ] 

Stefan Miklosovic commented on CASSANDRA-18124:
---

I guess the second approach is fine. Hard to tell without having the code to 
see the changes. Would you mind to prepare a PR for your 2nd idea?

> Config parameter keystore_password should be nullable
> -
>
> Key: CASSANDRA-18124
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18124
> Project: Cassandra
>  Issue Type: Bug
>  Components: Local/Config
>Reporter: Tibor Repasi
>Assignee: Maulin Vasavada
>Priority: Normal
> Fix For: 4.1.x, 5.x
>
>
> Some SSL configuration may pass unencrypted private keys. PEMReader might 
> accept that by assuming keyPassword to be null in that case (e.g. 
> https://github.com/apache/cassandra/blob/f9e033f519c14596da4dc954875756a69aea4e78/src/java/org/apache/cassandra/security/PEMReader.java#L103).
> Current configuration reader does not accept keystore_password parameter to 
> be set null or empty in the cassandra.yaml.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-17603) Harry: improve column subset testing capabilities

2023-03-13 Thread Alex Petrov (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-17603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Petrov updated CASSANDRA-17603:

Test and Documentation Plan: tests included
 Status: Patch Available  (was: Open)

> Harry: improve column subset testing capabilities
> -
>
> Key: CASSANDRA-17603
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17603
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Test/fuzz
>Reporter: Alex Petrov
>Assignee: Alex Petrov
>Priority: Normal
>
> 1. Extend bitset to support > 64 bits
> 2. Allow for wildcard queries
> 3. Allow for validation of a subset of columns
> 4. Open API for hand-crafting both mutation and read queries



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-17603) Harry: improve column subset testing capabilities

2023-03-13 Thread Alex Petrov (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-17603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699573#comment-17699573
 ] 

Alex Petrov commented on CASSANDRA-17603:
-

Patch: [https://github.com/apache/cassandra-harry/pull/20]

 

> Harry: improve column subset testing capabilities
> -
>
> Key: CASSANDRA-17603
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17603
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Test/fuzz
>Reporter: Alex Petrov
>Assignee: Alex Petrov
>Priority: Normal
>
> 1. Extend bitset to support > 64 bits
> 2. Allow for wildcard queries
> 3. Allow for validation of a subset of columns
> 4. Open API for hand-crafting both mutation and read queries



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-17603) Harry: improve column subset testing capabilities

2023-03-13 Thread Alex Petrov (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-17603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Petrov updated CASSANDRA-17603:

Change Category: Quality Assurance
 Complexity: Challenging
 Status: Open  (was: Triage Needed)

> Harry: improve column subset testing capabilities
> -
>
> Key: CASSANDRA-17603
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17603
> Project: Cassandra
>  Issue Type: Improvement
>  Components: Test/fuzz
>Reporter: Alex Petrov
>Assignee: Alex Petrov
>Priority: Normal
>
> 1. Extend bitset to support > 64 bits
> 2. Allow for wildcard queries
> 3. Allow for validation of a subset of columns
> 4. Open API for hand-crafting both mutation and read queries



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-18318) Implement parsing schema provider for external SUT in Harry

2023-03-13 Thread Alex Petrov (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-18318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Petrov updated CASSANDRA-18318:

Change Category: Quality Assurance
 Complexity: Normal
Component/s: Test/fuzz
  Reviewers: Abe Ratnofsky
 Status: Open  (was: Triage Needed)

> Implement parsing schema provider for external SUT in Harry
> ---
>
> Key: CASSANDRA-18318
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18318
> Project: Cassandra
>  Issue Type: New Feature
>  Components: Test/fuzz
>Reporter: Alex Petrov
>Assignee: Alex Petrov
>Priority: Normal
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-18316) Add feature flag for dynamic data masking

2023-03-13 Thread Jira


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-18316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andres de la Peña updated CASSANDRA-18316:
--
Status: Ready to Commit  (was: Review In Progress)

> Add feature flag for dynamic data masking
> -
>
> Key: CASSANDRA-18316
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18316
> Project: Cassandra
>  Issue Type: New Feature
>  Components: Feature/Dynamic Data Masking
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.x
>
>
> Dynamic data masking 
> ([CEP-20|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-20%3A+Dynamic+Data+Masking])
>  is a new feature, so it will need a feature flag in {{cassandra.yaml}}. 
> Something like:
> {code}
> # If enabled, dynamic data masking allows to attach CQL masking functions to 
> the columns of a table.
> # Users without the UNMASK permission will see an obscured version of the 
> values of the columns with an attached mask.
> # If dynamic data masking is disabled it won't be allowed to create new 
> column masks, although it will still be possible
> # to drop any previously existing masks. Also, any existing mask will be 
> ignored at query time, so all users will see
> # the clear values of the masked columns.
> dynamic_data_masking_enabled: false
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-18316) Add feature flag for dynamic data masking

2023-03-13 Thread Jira


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699569#comment-17699569
 ] 

Andres de la Peña commented on CASSANDRA-18316:
---

Thanks for the review. Indeed we'll need a rebase and final CI and review 
rounds before merging the feature branch.

> Add feature flag for dynamic data masking
> -
>
> Key: CASSANDRA-18316
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18316
> Project: Cassandra
>  Issue Type: New Feature
>  Components: Feature/Dynamic Data Masking
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.x
>
>
> Dynamic data masking 
> ([CEP-20|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-20%3A+Dynamic+Data+Masking])
>  is a new feature, so it will need a feature flag in {{cassandra.yaml}}. 
> Something like:
> {code}
> # If enabled, dynamic data masking allows to attach CQL masking functions to 
> the columns of a table.
> # Users without the UNMASK permission will see an obscured version of the 
> values of the columns with an attached mask.
> # If dynamic data masking is disabled it won't be allowed to create new 
> column masks, although it will still be possible
> # to drop any previously existing masks. Also, any existing mask will be 
> ignored at query time, so all users will see
> # the clear values of the masked columns.
> dynamic_data_masking_enabled: false
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-18323) Remove org.apache.cassandra.hadoop code

2023-03-13 Thread Stefan Miklosovic (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-18323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Miklosovic updated CASSANDRA-18323:
--
Change Category: Code Clarity
 Complexity: Normal
  Fix Version/s: 5.x
 Status: Open  (was: Triage Needed)

> Remove org.apache.cassandra.hadoop code
> ---
>
> Key: CASSANDRA-18323
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18323
> Project: Cassandra
>  Issue Type: Task
>  Components: Legacy/Core
>Reporter: Stefan Miklosovic
>Assignee: Stefan Miklosovic
>Priority: Normal
> Fix For: 5.x
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Created] (CASSANDRA-18323) Remove org.apache.cassandra.hadoop code

2023-03-13 Thread Stefan Miklosovic (Jira)
Stefan Miklosovic created CASSANDRA-18323:
-

 Summary: Remove org.apache.cassandra.hadoop code
 Key: CASSANDRA-18323
 URL: https://issues.apache.org/jira/browse/CASSANDRA-18323
 Project: Cassandra
  Issue Type: Task
  Components: Legacy/Core
Reporter: Stefan Miklosovic
Assignee: Stefan Miklosovic






--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Comment Edited] (CASSANDRA-18069) Add a new UNMASK permission

2023-03-13 Thread Jira


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699566#comment-17699566
 ] 

Andres de la Peña edited comment on CASSANDRA-18069 at 3/13/23 10:56 AM:
-

Committed to [the feature branch|https://github.com/apache/cassandra/pull/2193] 
for CASSANDRA-17940 as 
[95b17c8ae319fc156d20d456735150d65e7f2cd8|https://github.com/apache/cassandra/pull/2193/commits/95b17c8ae319fc156d20d456735150d65e7f2cd8].

Dtests committed to [the feature branch for 
dtests|https://github.com/apache/cassandra-dtest/pull/213] as 
[06c0a2b68cfe333db8b01ac9c420f5a5d515b5c6|https://github.com/apache/cassandra-dtest/pull/213/commits/06c0a2b68cfe333db8b01ac9c420f5a5d515b5c6].

Thanks for the reviews.


was (Author: adelapena):
Committed to [the feature branch|https://github.com/apache/cassandra/pull/2193] 
for CASSANDRA-17940 as 
[95b17c8ae319fc156d20d456735150d65e7f2cd8|https://github.com/apache/cassandra/pull/2193/commits/95b17c8ae319fc156d20d456735150d65e7f2cd8].

Thanks for the reviews.

> Add a new UNMASK permission
> ---
>
> Key: CASSANDRA-18069
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18069
> Project: Cassandra
>  Issue Type: New Feature
>  Components: Feature/Dynamic Data Masking
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.x
>
>  Time Spent: 6h 40m
>  Remaining Estimate: 0h
>
> Add a new UNMASK permission allowing users with that permission to see the 
> data masked by the masking functions attached to columns introduced by 
> CASSANDRA-18068, as defined by 
> [CEP-20|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-20%3A+Dynamic+Data+Masking].
> It would look like:
> {code}
> > CREATE TABLE patients (
>   id timeuuid PRIMARY KEY,
>   name text MASKED WITH default(),
>   birth date MASKED WITH default()
>   );
>  
> > INSERT INTO patients(id, name, birth) VALUES (now(), 'alice', '1982-12-21');
>  
> > CREATE USER unprivileged_user WITH PASSWORD 'xyz';
> > CREATE USER privileged_user WITH PASSWORD 'zyx';
>  
> > GRANT SELECT ON TABLE patients TO unprivileged_user;
> > GRANT SELECT ON TABLE patients TO privileged_user;
> > GRANT UNMASK ON TABLE patients TO privileged_user;
>  
> > LOGIN unprivileged_user
>  
> > SELECT name, birth FROM patients WHERE 
> > id=db2b372f-f91b-4537-b46b-c478f8330c29;
>  
>  name| birth
> -+
>  ale | 1900-01-01 
>  
> > LOGIN privileged_user
> > SELECT name, birth FROM patients WHERE 
> > id=db2b372f-f91b-4537-b46b-c478f8330c29;
>  
>  name  | birth
> ---+
>  alice | 1982-12-21
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-18069) Add a new UNMASK permission

2023-03-13 Thread Jira


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699566#comment-17699566
 ] 

Andres de la Peña commented on CASSANDRA-18069:
---

Committed to [the feature branch|https://github.com/apache/cassandra/pull/2193] 
for CASSANDRA-17940 as 
[95b17c8ae319fc156d20d456735150d65e7f2cd8|https://github.com/apache/cassandra/pull/2193/commits/95b17c8ae319fc156d20d456735150d65e7f2cd8].

Thanks for the reviews.

> Add a new UNMASK permission
> ---
>
> Key: CASSANDRA-18069
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18069
> Project: Cassandra
>  Issue Type: New Feature
>  Components: Feature/Dynamic Data Masking
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.x
>
>  Time Spent: 6h 40m
>  Remaining Estimate: 0h
>
> Add a new UNMASK permission allowing users with that permission to see the 
> data masked by the masking functions attached to columns introduced by 
> CASSANDRA-18068, as defined by 
> [CEP-20|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-20%3A+Dynamic+Data+Masking].
> It would look like:
> {code}
> > CREATE TABLE patients (
>   id timeuuid PRIMARY KEY,
>   name text MASKED WITH default(),
>   birth date MASKED WITH default()
>   );
>  
> > INSERT INTO patients(id, name, birth) VALUES (now(), 'alice', '1982-12-21');
>  
> > CREATE USER unprivileged_user WITH PASSWORD 'xyz';
> > CREATE USER privileged_user WITH PASSWORD 'zyx';
>  
> > GRANT SELECT ON TABLE patients TO unprivileged_user;
> > GRANT SELECT ON TABLE patients TO privileged_user;
> > GRANT UNMASK ON TABLE patients TO privileged_user;
>  
> > LOGIN unprivileged_user
>  
> > SELECT name, birth FROM patients WHERE 
> > id=db2b372f-f91b-4537-b46b-c478f8330c29;
>  
>  name| birth
> -+
>  ale | 1900-01-01 
>  
> > LOGIN privileged_user
> > SELECT name, birth FROM patients WHERE 
> > id=db2b372f-f91b-4537-b46b-c478f8330c29;
>  
>  name  | birth
> ---+
>  alice | 1982-12-21
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-18069) Add a new UNMASK permission

2023-03-13 Thread Jira


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-18069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andres de la Peña updated CASSANDRA-18069:
--
Source Control Link: 
https://github.com/apache/cassandra/pull/2193/commits/95b17c8ae319fc156d20d456735150d65e7f2cd8
 Resolution: Fixed
 Status: Resolved  (was: Ready to Commit)

> Add a new UNMASK permission
> ---
>
> Key: CASSANDRA-18069
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18069
> Project: Cassandra
>  Issue Type: New Feature
>  Components: Feature/Dynamic Data Masking
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.x
>
>  Time Spent: 6h 40m
>  Remaining Estimate: 0h
>
> Add a new UNMASK permission allowing users with that permission to see the 
> data masked by the masking functions attached to columns introduced by 
> CASSANDRA-18068, as defined by 
> [CEP-20|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-20%3A+Dynamic+Data+Masking].
> It would look like:
> {code}
> > CREATE TABLE patients (
>   id timeuuid PRIMARY KEY,
>   name text MASKED WITH default(),
>   birth date MASKED WITH default()
>   );
>  
> > INSERT INTO patients(id, name, birth) VALUES (now(), 'alice', '1982-12-21');
>  
> > CREATE USER unprivileged_user WITH PASSWORD 'xyz';
> > CREATE USER privileged_user WITH PASSWORD 'zyx';
>  
> > GRANT SELECT ON TABLE patients TO unprivileged_user;
> > GRANT SELECT ON TABLE patients TO privileged_user;
> > GRANT UNMASK ON TABLE patients TO privileged_user;
>  
> > LOGIN unprivileged_user
>  
> > SELECT name, birth FROM patients WHERE 
> > id=db2b372f-f91b-4537-b46b-c478f8330c29;
>  
>  name| birth
> -+
>  ale | 1900-01-01 
>  
> > LOGIN privileged_user
> > SELECT name, birth FROM patients WHERE 
> > id=db2b372f-f91b-4537-b46b-c478f8330c29;
>  
>  name  | birth
> ---+
>  alice | 1982-12-21
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-18043) remove deprecated DateTieredCompactionStrategy

2023-03-13 Thread Stefan Miklosovic (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699562#comment-17699562
 ] 

Stefan Miklosovic commented on CASSANDRA-18043:
---

[~mck] [~brandon.williams] could you please approve this? I think I am done, 
builds are above.

> remove deprecated DateTieredCompactionStrategy
> --
>
> Key: CASSANDRA-18043
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18043
> Project: Cassandra
>  Issue Type: Task
>  Components: Local/Compaction/DTCS
>Reporter: Stefan Miklosovic
>Assignee: Stefan Miklosovic
>Priority: Normal
> Fix For: 5.x
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> DTCS was marked as deprecated in CASSANDRA-9666 which was released in 3.0.8 
> and 3.8. If I get our deprecation policies right, we wait one major release 
> (4.0) and we can remove it in the next one (5.0). Having 4.1 about to be 
> released soon and 4.2 will be 5.0, I think nothing blocks us from removing 
> this strategy in trunk.
> This also makes CASSANDRA-18042 easier as it would most probably have to 
> cover this strategy as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Commented] (CASSANDRA-18316) Add feature flag for dynamic data masking

2023-03-13 Thread Berenguer Blasi (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699544#comment-17699544
 ] 

Berenguer Blasi commented on CASSANDRA-18316:
-

It's quite a small one. I'm +1 on it to merge into the feature branch. But I 
will still need one pass when everything merges into the main feature branch.

> Add feature flag for dynamic data masking
> -
>
> Key: CASSANDRA-18316
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18316
> Project: Cassandra
>  Issue Type: New Feature
>  Components: Feature/Dynamic Data Masking
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.x
>
>
> Dynamic data masking 
> ([CEP-20|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-20%3A+Dynamic+Data+Masking])
>  is a new feature, so it will need a feature flag in {{cassandra.yaml}}. 
> Something like:
> {code}
> # If enabled, dynamic data masking allows to attach CQL masking functions to 
> the columns of a table.
> # Users without the UNMASK permission will see an obscured version of the 
> values of the columns with an attached mask.
> # If dynamic data masking is disabled it won't be allowed to create new 
> column masks, although it will still be possible
> # to drop any previously existing masks. Also, any existing mask will be 
> ignored at query time, so all users will see
> # the clear values of the masked columns.
> dynamic_data_masking_enabled: false
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[cassandra-harry] 06/06: Parsing schema provider

2023-03-13 Thread ifesdjeen
This is an automated email from the ASF dual-hosted git repository.

ifesdjeen pushed a commit to branch CASSANDRA-18318
in repository https://gitbox.apache.org/repos/asf/cassandra-harry.git

commit 82240a579ced676caa65610de2975d26031144a7
Author: Alex Petrov 
AuthorDate: Fri Mar 10 13:00:39 2023 +0100

Parsing schema provider
---
 .../model/sut/external/ExternalClusterSut.java |  5 ++
 .../src/harry/schema/ParsingSchemaProvider.java| 69 
 .../src/harry/schema/SchemaHelper.java | 91 ++
 3 files changed, 165 insertions(+)

diff --git 
a/harry-integration-external/src/harry/model/sut/external/ExternalClusterSut.java
 
b/harry-integration-external/src/harry/model/sut/external/ExternalClusterSut.java
index ae2808c..d141be1 100644
--- 
a/harry-integration-external/src/harry/model/sut/external/ExternalClusterSut.java
+++ 
b/harry-integration-external/src/harry/model/sut/external/ExternalClusterSut.java
@@ -62,6 +62,11 @@ public class ExternalClusterSut implements SystemUnderTest
 return session;
 }
 
+public Metadata metadata()
+{
+return this.session.getCluster().getMetadata();
+}
+
 public static ExternalClusterSut create(ExternalSutConfiguration config)
 {
 // TODO: close Cluster and Session!
diff --git 
a/harry-integration-external/src/harry/schema/ParsingSchemaProvider.java 
b/harry-integration-external/src/harry/schema/ParsingSchemaProvider.java
new file mode 100644
index 000..0661f6f
--- /dev/null
+++ b/harry-integration-external/src/harry/schema/ParsingSchemaProvider.java
@@ -0,0 +1,69 @@
+/*
+ *  Licensed to the Apache Software Foundation (ASF) under one
+ *  or more contributor license agreements.  See the NOTICE file
+ *  distributed with this work for additional information
+ *  regarding copyright ownership.  The ASF licenses this file
+ *  to you under the Apache License, Version 2.0 (the
+ *  "License"); you may not use this file except in compliance
+ *  with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+
+package harry.schema;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.fasterxml.jackson.annotation.JsonCreator;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.annotation.JsonTypeName;
+import harry.core.Configuration;
+import harry.ddl.SchemaSpec;
+import harry.model.sut.SystemUnderTest;
+import harry.model.sut.external.ExternalClusterSut;
+
+@JsonTypeName("parsing")
+public class ParsingSchemaProvider implements 
Configuration.SchemaProviderConfiguration
+{
+private static final Logger logger = 
LoggerFactory.getLogger(ParsingSchemaProvider.class);
+
+public static void init()
+{
+Configuration.registerSubtypes(ParsingSchemaProvider.class);
+}
+
+public final String keyspace;
+public final String table;
+public final String ddl;
+public final boolean ignore_unknown_types;
+
+@JsonCreator
+public ParsingSchemaProvider(@JsonProperty("keyspace") String keyspace,
+ @JsonProperty("table") String table,
+ @JsonProperty("ddl") String ddl,
+ @JsonProperty("ignore_unknown_types") Boolean 
ignoreUnknown)
+{
+this.keyspace = keyspace;
+this.table = table;
+this.ddl = ddl;
+this.ignore_unknown_types = ignoreUnknown != null && ignoreUnknown;
+}
+public SchemaSpec make(long seed, SystemUnderTest sut)
+{
+assert sut instanceof ExternalClusterSut;
+if (ddl != null)
+sut.schemaChange(ddl);
+
+ExternalClusterSut externalSut = (ExternalClusterSut) sut;
+SchemaSpec schemaSpec = 
SchemaHelper.createSchemaSpec(externalSut.metadata(), keyspace, table, 
ignore_unknown_types);
+logger.info("Using schema: " + schemaSpec.compile().cql());
+return schemaSpec;
+}
+}
diff --git a/harry-integration-external/src/harry/schema/SchemaHelper.java 
b/harry-integration-external/src/harry/schema/SchemaHelper.java
new file mode 100644
index 000..24ad5a8
--- /dev/null
+++ b/harry-integration-external/src/harry/schema/SchemaHelper.java
@@ -0,0 +1,91 @@
+/*
+ *  Licensed to the Apache Software Foundation (ASF) under one
+ *  or more contributor license agreements.  See the NOTICE file
+ *  distributed with this work for additional information
+ *  regarding copyright ownership.  The ASF licenses this file
+ *  to you under the Apache License, Version 2.0 (the
+ *  "License"); you may not use this file except 

[cassandra-harry] 01/06: Improvements:

2023-03-13 Thread ifesdjeen
This is an automated email from the ASF dual-hosted git repository.

ifesdjeen pushed a commit to branch CASSANDRA-18318
in repository https://gitbox.apache.org/repos/asf/cassandra-harry.git

commit 4efa503e0da99fce74312e74a2d7a6da9bbcc9f6
Author: Abe Ratnofsky 
AuthorDate: Mon Oct 17 12:54:44 2022 +0200

Improvements:

  * formatting
  * thread shutdown on failed run creation
  * idempotent query execution
  * retry delay

Patch by Abe Ratnofsky; reviewed by Alex Petrov for CASSANDRA-18315.
---
 harry-core/src/harry/core/Configuration.java   | 56 ++
 harry-core/src/harry/ddl/ColumnSpec.java   | 16 +++
 harry-core/src/harry/ddl/SchemaGenerators.java | 41 ++--
 harry-core/src/harry/generators/Bijections.java| 35 +-
 harry-core/src/harry/generators/PCGFastPure.java   |  2 +-
 harry-core/src/harry/model/SelectHelper.java   |  2 +-
 .../src/harry/model/sut/SystemUnderTest.java   | 12 -
 harry-core/src/harry/runner/HarryRunner.java   |  6 +++
 harry-core/src/harry/runner/Runner.java|  9 +++-
 harry-core/src/harry/visitors/MutatingVisitor.java |  6 ++-
 .../harry/visitors/ParallelRecentValidator.java|  4 +-
 harry-core/src/harry/visitors/RecentValidator.java |  2 +-
 12 files changed, 145 insertions(+), 46 deletions(-)

diff --git a/harry-core/src/harry/core/Configuration.java 
b/harry-core/src/harry/core/Configuration.java
index 3545e18..7cd8f72 100644
--- a/harry-core/src/harry/core/Configuration.java
+++ b/harry-core/src/harry/core/Configuration.java
@@ -65,6 +65,8 @@ public class Configuration
 {
 private static final ObjectMapper mapper;
 
+private static final String DEFAULT_KEYSPACE = "harry";
+
 static
 {
 mapper = new ObjectMapper(new YAMLFactory()
@@ -220,34 +222,46 @@ public class Configuration
 
 public static Run createRun(Configuration snapshot)
 {
-validate(snapshot);
+SystemUnderTest sut = null;
+try
+{
+validate(snapshot);
 
-long seed = snapshot.seed;
+long seed = snapshot.seed;
 
-DataTracker tracker = snapshot.data_tracker == null ? new 
DefaultDataTrackerConfiguration().make() : snapshot.data_tracker.make();
-OpSelectors.Rng rng = new OpSelectors.PCGFast(seed);
+DataTracker tracker = snapshot.data_tracker == null ? new 
DefaultDataTrackerConfiguration().make() : snapshot.data_tracker.make();
+OpSelectors.Rng rng = new OpSelectors.PCGFast(seed);
 
-OpSelectors.MonotonicClock clock = snapshot.clock.make();
+OpSelectors.MonotonicClock clock = snapshot.clock.make();
 
-MetricReporter metricReporter = snapshot.metric_reporter.make();
+MetricReporter metricReporter = snapshot.metric_reporter.make();
 
-// TODO: validate that operation kind is compatible with schema, due 
to statics etc
-SystemUnderTest sut = snapshot.system_under_test.make();
+// TODO: validate that operation kind is compatible with schema, 
due to statics etc
+sut = snapshot.system_under_test.make();
 
-SchemaSpec schemaSpec = snapshot.schema_provider.make(seed, sut);
-schemaSpec.validate();
+SchemaSpec schemaSpec = snapshot.schema_provider.make(seed, sut);
+schemaSpec.validate();
 
-OpSelectors.PdSelector pdSelector = 
snapshot.partition_descriptor_selector.make(rng);
-OpSelectors.DescriptorSelector descriptorSelector = 
snapshot.clustering_descriptor_selector.make(rng, schemaSpec);
+OpSelectors.PdSelector pdSelector = 
snapshot.partition_descriptor_selector.make(rng);
+OpSelectors.DescriptorSelector descriptorSelector = 
snapshot.clustering_descriptor_selector.make(rng, schemaSpec);
 
-return new Run(rng,
-   clock,
-   pdSelector,
-   descriptorSelector,
-   schemaSpec,
-   tracker,
-   sut,
-   metricReporter);
+return new Run(rng,
+   clock,
+   pdSelector,
+   descriptorSelector,
+   schemaSpec,
+   tracker,
+   sut,
+   metricReporter);
+}
+catch (Throwable t)
+{
+// Make sure to shut down all SUT threads if it has been started
+if (sut != null) {
+sut.shutdown();
+}
+throw t;
+}
 }
 
 public static Runner createRunner(Configuration config)
@@ -1058,7 +1072,7 @@ public class Configuration
 {
 public SchemaSpec make(long seed, SystemUnderTest sut)
 {
-return SchemaGenerators.defaultSchemaSpecGen("harry", "table0")
+return 

[cassandra-harry] branch CASSANDRA-18318 created (now 82240a5)

2023-03-13 Thread ifesdjeen
This is an automated email from the ASF dual-hosted git repository.

ifesdjeen pushed a change to branch CASSANDRA-18318
in repository https://gitbox.apache.org/repos/asf/cassandra-harry.git


  at 82240a5  Parsing schema provider

This branch includes the following new commits:

 new 4efa503  Improvements:
 new 75c3c0b  Pull in Cassandra concurrent utils until there is a common 
shared library
 new 54c16fa  Pull in token util from Cassandra to avoid circular dependency
 new e465026  Implement concurrent quiescent checker
 new 78f1099  Make it possible to run multiple Harry runners concurrently 
against the same keyspace
 new 82240a5  Parsing schema provider

The 6 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[cassandra-harry] 03/06: Pull in token util from Cassandra to avoid circular dependency

2023-03-13 Thread ifesdjeen
This is an automated email from the ASF dual-hosted git repository.

ifesdjeen pushed a commit to branch CASSANDRA-18318
in repository https://gitbox.apache.org/repos/asf/cassandra-harry.git

commit 54c16faaff05c36e69a231e38a89803cbd092d50
Author: Alex Petrov 
AuthorDate: Thu Mar 9 17:17:41 2023 +0100

Pull in token util from Cassandra to avoid circular dependency

Patch by Alex Petrov; reviewed by Caleb Rackliffe and Abe Ratnofsky for 
CASSANDRA-18315
---
 harry-core/src/harry/util/TokenUtil.java | 150 +++
 1 file changed, 150 insertions(+)

diff --git a/harry-core/src/harry/util/TokenUtil.java 
b/harry-core/src/harry/util/TokenUtil.java
new file mode 100644
index 000..db210b6
--- /dev/null
+++ b/harry-core/src/harry/util/TokenUtil.java
@@ -0,0 +1,150 @@
+/*
+ *  Licensed to the Apache Software Foundation (ASF) under one
+ *  or more contributor license agreements.  See the NOTICE file
+ *  distributed with this work for additional information
+ *  regarding copyright ownership.  The ASF licenses this file
+ *  to you under the Apache License, Version 2.0 (the
+ *  "License"); you may not use this file except in compliance
+ *  with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+
+package harry.util;
+
+import java.nio.ByteBuffer;
+
+/**
+ * Copied verbatim from Apache Cassandra codebase to avoid having a dependency 
on Cassandra.
+ */
+public class TokenUtil
+{
+public static long token(ByteBuffer key)
+{
+if (key.remaining() == 0)
+return Long.MIN_VALUE;
+
+return normalize(getHash(key)[0]);
+}
+
+private static long normalize(long v)
+{
+// We exclude the MINIMUM value; see getToken()
+return v == Long.MIN_VALUE ? Long.MAX_VALUE : v;
+}
+
+private static long[] getHash(ByteBuffer key)
+{
+long[] hash = new long[2];
+hash3_x64_128(key, key.position(), key.remaining(), 0, hash);
+return hash;
+}
+
+public static void hash3_x64_128(ByteBuffer key, int offset, int length, 
long seed, long[] result)
+{
+final int nblocks = length >> 4; // Process as 128-bit blocks.
+
+long h1 = seed;
+long h2 = seed;
+
+long c1 = 0x87c37b91114253d5L;
+long c2 = 0x4cf5ad432745937fL;
+
+//--
+// body
+
+for(int i = 0; i < nblocks; i++)
+{
+long k1 = getBlock(key, offset, i * 2 + 0);
+long k2 = getBlock(key, offset, i * 2 + 1);
+
+k1 *= c1; k1 = rotl64(k1,31); k1 *= c2; h1 ^= k1;
+
+h1 = rotl64(h1,27); h1 += h2; h1 = h1*5+0x52dce729;
+
+k2 *= c2; k2  = rotl64(k2,33); k2 *= c1; h2 ^= k2;
+
+h2 = rotl64(h2,31); h2 += h1; h2 = h2*5+0x38495ab5;
+}
+
+//--
+// tail
+
+// Advance offset to the unprocessed tail of the data.
+offset += nblocks * 16;
+
+long k1 = 0;
+long k2 = 0;
+
+switch(length & 15)
+{
+case 15: k2 ^= ((long) key.get(offset+14)) << 48;
+case 14: k2 ^= ((long) key.get(offset+13)) << 40;
+case 13: k2 ^= ((long) key.get(offset+12)) << 32;
+case 12: k2 ^= ((long) key.get(offset+11)) << 24;
+case 11: k2 ^= ((long) key.get(offset+10)) << 16;
+case 10: k2 ^= ((long) key.get(offset+9)) << 8;
+case  9: k2 ^= ((long) key.get(offset+8)) << 0;
+k2 *= c2; k2  = rotl64(k2,33); k2 *= c1; h2 ^= k2;
+
+case  8: k1 ^= ((long) key.get(offset+7)) << 56;
+case  7: k1 ^= ((long) key.get(offset+6)) << 48;
+case  6: k1 ^= ((long) key.get(offset+5)) << 40;
+case  5: k1 ^= ((long) key.get(offset+4)) << 32;
+case  4: k1 ^= ((long) key.get(offset+3)) << 24;
+case  3: k1 ^= ((long) key.get(offset+2)) << 16;
+case  2: k1 ^= ((long) key.get(offset+1)) << 8;
+case  1: k1 ^= ((long) key.get(offset));
+k1 *= c1; k1  = rotl64(k1,31); k1 *= c2; h1 ^= k1;
+};
+
+//--
+// finalization
+
+h1 ^= length; h2 ^= length;
+
+h1 += h2;
+h2 += h1;
+
+h1 = fmix(h1);
+h2 = fmix(h2);
+
+h1 += h2;
+h2 += h1;
+
+result[0] = h1;
+result[1] = h2;
+}
+
+protected static long getBlock(ByteBuffer key, int offset, int index)
+{
+int i_8 = index << 3;
+int blockOffset = offset + i_8;
+return ((long) key.get(blockOffset + 0) & 0xff) + (((long) 

[cassandra-harry] 05/06: Make it possible to run multiple Harry runners concurrently against the same keyspace

2023-03-13 Thread ifesdjeen
This is an automated email from the ASF dual-hosted git repository.

ifesdjeen pushed a commit to branch CASSANDRA-18318
in repository https://gitbox.apache.org/repos/asf/cassandra-harry.git

commit 78f10998ff8cb24d9fa64de7db234b4084576f6e
Author: Alex Petrov 
AuthorDate: Fri Mar 3 12:46:39 2023 +0100

Make it possible to run multiple Harry runners concurrently against the 
same keyspace

Patch by Alex Petrov; reviewed by Abe Ratnofsky for CASSANDRA-18315
---
 harry-core/src/harry/core/Configuration.java   | 51 +++---
 harry-core/src/harry/generators/RngUtils.java  | 12 +
 harry-core/src/harry/model/OpSelectors.java| 19 +--
 harry-core/src/harry/runner/Runner.java|  5 ++
 .../{RecentValidator.java => RandomValidator.java} | 62 +++---
 harry-core/src/harry/visitors/RecentValidator.java | 26 ++---
 .../test/harry/model/IntegrationTestBase.java  |  2 +-
 .../model/QuiescentCheckerIntegrationTest.java |  4 +-
 8 files changed, 102 insertions(+), 79 deletions(-)

diff --git a/harry-core/src/harry/core/Configuration.java 
b/harry-core/src/harry/core/Configuration.java
index 88474b9..0c0e3f5 100644
--- a/harry-core/src/harry/core/Configuration.java
+++ b/harry-core/src/harry/core/Configuration.java
@@ -61,8 +61,9 @@ import harry.visitors.LoggingVisitor;
 import harry.visitors.MutatingVisitor;
 import harry.visitors.MutatingRowVisitor;
 import harry.visitors.OperationExecutor;
-import harry.visitors.Visitor;
 import harry.visitors.RecentValidator;
+import harry.visitors.Visitor;
+import harry.visitors.RandomValidator;
 import harry.runner.Runner;
 import harry.util.BitSet;
 import org.reflections.Reflections;
@@ -291,7 +292,7 @@ public class Configuration
 DataTrackerConfiguration data_tracker = new 
DefaultDataTrackerConfiguration();
 RunnerConfiguration runner;
 SutConfiguration system_under_test;
-PDSelectorConfiguration partition_descriptor_selector = new 
Configuration.DefaultPDSelectorConfiguration(10, 100);
+PDSelectorConfiguration partition_descriptor_selector = new 
Configuration.DefaultPDSelectorConfiguration(10, 100, 0);
 CDSelectorConfiguration clustering_descriptor_selector; // TODO: 
sensible default value
 
 public ConfigurationBuilder setSeed(long seed)
@@ -719,18 +720,30 @@ public class Configuration
 {
 public final int window_size;
 public final int slide_after_repeats;
+public final long position_offset;
+
+@Deprecated
+public DefaultPDSelectorConfiguration(int window_size,
+  int slide_after_repeats)
+{
+this.window_size = window_size;
+this.slide_after_repeats = slide_after_repeats;
+this.position_offset = 0L;
+}
 
 @JsonCreator
 public DefaultPDSelectorConfiguration(@JsonProperty(value = 
"window_size", defaultValue = "10") int window_size,
-  @JsonProperty(value = 
"slide_after_repeats", defaultValue = "100") int slide_after_repeats)
+  @JsonProperty(value = 
"slide_after_repeats", defaultValue = "100") int slide_after_repeats,
+  @JsonProperty(value = 
"position_offset", defaultValue = "0") long position_offset)
 {
 this.window_size = window_size;
 this.slide_after_repeats = slide_after_repeats;
+this.position_offset = position_offset;
 }
 
 public OpSelectors.PdSelector make(OpSelectors.Rng rng)
 {
-return new OpSelectors.DefaultPdSelector(rng, window_size, 
slide_after_repeats);
+return new OpSelectors.DefaultPdSelector(rng, window_size, 
slide_after_repeats, position_offset);
 }
 }
 
@@ -1083,27 +1096,49 @@ public class Configuration
 public static class RecentPartitionsValidatorConfiguration implements 
VisitorConfiguration
 {
 public final int partition_count;
-public final int trigger_after;
 public final int queries;
 public final Configuration.ModelConfiguration modelConfiguration;
 
 // TODO: make query selector configurable
 @JsonCreator
 public 
RecentPartitionsValidatorConfiguration(@JsonProperty("partition_count") int 
partition_count,
-  
@JsonProperty("trigger_after") int trigger_after,
   
@JsonProperty("queries_per_partition") int queries,
   @JsonProperty("model") 
Configuration.ModelConfiguration model)
 {
 this.partition_count = partition_count;
 this.queries = queries;
-this.trigger_after = trigger_after;
 this.modelConfiguration = model;
 }
 
 @Override
  

[cassandra-harry] 02/06: Pull in Cassandra concurrent utils until there is a common shared library

2023-03-13 Thread ifesdjeen
This is an automated email from the ASF dual-hosted git repository.

ifesdjeen pushed a commit to branch CASSANDRA-18318
in repository https://gitbox.apache.org/repos/asf/cassandra-harry.git

commit 75c3c0bd18c217cedbafbf3d64a29fb94ff1b359
Author: Alex Petrov 
AuthorDate: Thu Mar 9 17:13:18 2023 +0100

Pull in Cassandra concurrent utils until there is a common shared library

Patch by Alex Petrov; reviewed by Caleb Rackliffe and Abe Ratnofsky for 
CASSANDRA-18315
---
 harry-core/src/harry/concurrent/Awaitable.java | 399 +
 harry-core/src/harry/concurrent/Clock.java | 103 ++
 harry-core/src/harry/concurrent/Condition.java |  99 +
 .../src/harry/concurrent/CountDownLatch.java   | 107 ++
 .../src/harry/concurrent/ExecutorFactory.java  | 155 
 .../src/harry/concurrent/InfiniteLoopExecutor.java | 178 +
 harry-core/src/harry/concurrent/Interruptible.java |  50 +++
 .../src/harry/concurrent/NamedThreadFactory.java   | 195 ++
 harry-core/src/harry/concurrent/Shutdownable.java  |  44 +++
 .../concurrent/UncheckedInterruptedException.java  |  35 ++
 harry-core/src/harry/concurrent/WaitQueue.java | 390 
 11 files changed, 1755 insertions(+)

diff --git a/harry-core/src/harry/concurrent/Awaitable.java 
b/harry-core/src/harry/concurrent/Awaitable.java
new file mode 100644
index 000..3781e78
--- /dev/null
+++ b/harry-core/src/harry/concurrent/Awaitable.java
@@ -0,0 +1,399 @@
+/*
+ *  Licensed to the Apache Software Foundation (ASF) under one
+ *  or more contributor license agreements.  See the NOTICE file
+ *  distributed with this work for additional information
+ *  regarding copyright ownership.  The ASF licenses this file
+ *  to you under the Apache License, Version 2.0 (the
+ *  "License"); you may not use this file except in compliance
+ *  with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+
+package harry.concurrent;
+
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicReferenceFieldUpdater;
+import java.util.function.Predicate;
+
+import static harry.concurrent.Clock.Global.nanoTime;
+import static harry.concurrent.WaitQueue.newWaitQueue;
+
+/**
+ * A generic signal consumer, supporting all of the typical patterns used in 
Cassandra.
+ * All of the methods defined in {@link Awaitable} may be waited on without a 
loop,
+ * as this interface declares that there are no spurious wake-ups.
+ *
+ * This class was borrowed from Apache Cassandra, 
org.cassandra.utils.concurrent, until there's a shared concurrency lib.
+ */
+public interface Awaitable
+{
+/**
+ * Await until the deadline (in nanoTime), throwing any interrupt.
+ * No spurious wakeups.
+ * @return true if we were signalled, false if the deadline elapsed
+ * @throws InterruptedException if interrupted
+ */
+boolean awaitUntil(long nanoTimeDeadline) throws InterruptedException;
+
+/**
+ * Await until the deadline (in nanoTime), throwing any interrupt as an 
unchecked exception.
+ * No spurious wakeups.
+ * @return true if we were signalled, false if the deadline elapsed
+ * @throws UncheckedInterruptedException if interrupted
+ */
+boolean awaitUntilThrowUncheckedOnInterrupt(long nanoTimeDeadline) throws 
UncheckedInterruptedException;
+
+/**
+ * Await until the deadline (in nanoTime), ignoring interrupts (but 
maintaining the interrupt flag on exit).
+ * No spurious wakeups.
+ * @return true if we were signalled, false if the deadline elapsed
+ */
+boolean awaitUntilUninterruptibly(long nanoTimeDeadline);
+
+/**
+ * Await for the specified period, throwing any interrupt.
+ * No spurious wakeups.
+ * @return true if we were signalled, false if the timeout elapses
+ * @throws InterruptedException if interrupted
+ */
+boolean await(long time, TimeUnit units) throws InterruptedException;
+
+/**
+ * Await for the specified period, throwing any interrupt as an unchecked 
exception.
+ * No spurious wakeups.
+ * @return true if we were signalled, false if the timeout elapses
+ * @throws UncheckedInterruptedException if interrupted
+ */
+boolean awaitThrowUncheckedOnInterrupt(long time, TimeUnit units) throws 
UncheckedInterruptedException;
+
+/**
+ * Await until the deadline (in nanoTime), ignoring interrupts (but 
maintaining the interrupt flag on exit).
+ * No spurious wakeups.
+ * @return true if we were signalled, false if the timeout elapses
+ */
+boolean 

[jira] [Commented] (CASSANDRA-18176) Merged SSTable files not reclaimed by OS

2023-03-13 Thread Benedict Elliott Smith (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699540#comment-17699540
 ] 

Benedict Elliott Smith commented on CASSANDRA-18176:


Sorry [~pbalaguer], I have a lot on and had mentally handed this off to others 
for the moment.

I could very easily back port this to a version you are running (please 
nominate one), and post a branch to GitHub that you could build and deploy with 
the strong reference loop only fixed, so that you could enable logging so that 
we might be able to track down the underlying resource leak.

If you're happy with this course of action, I'll post a branch either today or 
tomorrow. Otherwise, we can prod [~jmckenzie] and see about when we can get it 
properly backported and merged into a release.

I agree that we should get to the bottom of this sooner than later, for the 
project as well as yourself.

> Merged SSTable files not reclaimed by OS
> 
>
> Key: CASSANDRA-18176
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18176
> Project: Cassandra
>  Issue Type: Bug
>  Components: Local/Compaction
>Reporter: Pere Balaguer
>Priority: Normal
> Fix For: 4.0.x
>
>
> (EDIT: Looks like this is masked by the lack of backport of CASSANDRA-17205 
> just on the 4.0 line - will backport that and block here on it)
> After upgrading to Cassandra 4.x (4.0.1 and 4.0.5) we've noticed that at 
> times after a compaction deleted sstables diskspace doesn't get reclaimed by 
> the OS until the cassandra process is restarted (which kinda points at some 
> sort of resource leak), I do not recall this happening in cassandra 3, at 
> least not to such degree.
> We've seen the behavior in multiple clusters with different schemas, access 
> patterns and consistency levels at somewhat "random" points in time, the only 
> interesting thing is that there were active repair sessions at the time 
> affecting the node, keyspace and table.
> {noformat}
> $ date +%Y-%m-%d
> 2023-01-17
> $ nodetool version
> ReleaseVersion: 4.0.5
> {noformat}
> {noformat}
> $ lsof +L1 | grep cassandra | grep myawesomecluster | wc -l
> 2772
> $ lsof +L1 | grep cassandra | grep myawesomecluster | tail -n1
> java  59003 cassandra *979u   REG  253,810 0 1208053768 
> /cassandra-data/data/myawesomecluster/schema_one-randomchecksum/nb-2274426-big-Digest.crc32
>  (deleted)
> {noformat}
> {noformat}
> $ grep 2274426 /cassandra/systemlog.log
> INFO  [Stream-Deserializer-/10.214.79.62:randomport-b904af67] 2023-01-15 
> 13:06:24,969 BigTableZeroCopyWriter.java:203 - Writing component DATA to 
> /cassandra-data/data/myawesomecluster/schema_one-randomchecksum/nb-2274426-big-Data.db
>  length 2.900KiB
> INFO  [Stream-Deserializer-/10.214.79.62:randomport-b904af67] 2023-01-15 
> 13:06:24,969 BigTableZeroCopyWriter.java:213 - Block Writing component to 
> /cassandra-data/data/myawesomecluster/schema_one-randomchecksum/nb-2274426-big-Data.db
>  length 2.900KiB
> INFO  [Stream-Deserializer-/10.214.79.62:randomport-b904af67] 2023-01-15 
> 13:06:24,970 BigTableZeroCopyWriter.java:203 - Writing component 
> PRIMARY_INDEX to 
> /cassandra-data/data/myawesomecluster/schema_one-randomchecksum/nb-2274426-big-Index.db
>  length 3.739KiB
> INFO  [Stream-Deserializer-/10.214.79.62:randomport-b904af67] 2023-01-15 
> 13:06:24,970 BigTableZeroCopyWriter.java:213 - Block Writing component to 
> /cassandra-data/data/myawesomecluster/schema_one-randomchecksum/nb-2274426-big-Index.db
>  length 3.739KiB
> INFO  [Stream-Deserializer-/10.214.79.62:randomport-b904af67] 2023-01-15 
> 13:06:24,970 BigTableZeroCopyWriter.java:203 - Writing component STATS to 
> /cassandra-data/data/myawesomecluster/schema_one-randomchecksum/nb-2274426-big-Statistics.db
>  length 5.062KiB
> INFO  [Stream-Deserializer-/10.214.79.62:randomport-b904af67] 2023-01-15 
> 13:06:24,970 BigTableZeroCopyWriter.java:213 - Block Writing component to 
> /cassandra-data/data/myawesomecluster/schema_one-randomchecksum/nb-2274426-big-Statistics.db
>  length 5.062KiB
> INFO  [Stream-Deserializer-/10.214.79.62:randomport-b904af67] 2023-01-15 
> 13:06:24,971 BigTableZeroCopyWriter.java:203 - Writing component 
> COMPRESSION_INFO to 
> /cassandra-data/data/myawesomecluster/schema_one-randomchecksum/nb-2274426-big-CompressionInfo.db
>  length 0.054KiB
> INFO  [Stream-Deserializer-/10.214.79.62:randomport-b904af67] 2023-01-15 
> 13:06:24,971 BigTableZeroCopyWriter.java:213 - Block Writing component to 
> /cassandra-data/data/myawesomecluster/schema_one-randomchecksum/nb-2274426-big-CompressionInfo.db
>  length 0.054KiB
> INFO  [Stream-Deserializer-/10.214.79.62:randomport-b904af67] 2023-01-15 
> 13:06:24,971 BigTableZeroCopyWriter.java:203 - Writing component FILTER to 
> 

[jira] [Commented] (CASSANDRA-18176) Merged SSTable files not reclaimed by OS

2023-03-13 Thread Pere Balaguer (Jira)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-18176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699539#comment-17699539
 ] 

Pere Balaguer commented on CASSANDRA-18176:
---

Hey folks, sorry for bumping this but the issue is rather annoying when there 
are a lot of ongoing ring movements as it triggers quite often forcing node 
restarts which in turn delay everything. Do you happen to have an idea on when 
can this be worked on and if I can do something to contribute a bit more to 
make it happen sooner? (not so sure about deep down diving and coding but hey, 
maybe).

> Merged SSTable files not reclaimed by OS
> 
>
> Key: CASSANDRA-18176
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18176
> Project: Cassandra
>  Issue Type: Bug
>  Components: Local/Compaction
>Reporter: Pere Balaguer
>Priority: Normal
> Fix For: 4.0.x
>
>
> (EDIT: Looks like this is masked by the lack of backport of CASSANDRA-17205 
> just on the 4.0 line - will backport that and block here on it)
> After upgrading to Cassandra 4.x (4.0.1 and 4.0.5) we've noticed that at 
> times after a compaction deleted sstables diskspace doesn't get reclaimed by 
> the OS until the cassandra process is restarted (which kinda points at some 
> sort of resource leak), I do not recall this happening in cassandra 3, at 
> least not to such degree.
> We've seen the behavior in multiple clusters with different schemas, access 
> patterns and consistency levels at somewhat "random" points in time, the only 
> interesting thing is that there were active repair sessions at the time 
> affecting the node, keyspace and table.
> {noformat}
> $ date +%Y-%m-%d
> 2023-01-17
> $ nodetool version
> ReleaseVersion: 4.0.5
> {noformat}
> {noformat}
> $ lsof +L1 | grep cassandra | grep myawesomecluster | wc -l
> 2772
> $ lsof +L1 | grep cassandra | grep myawesomecluster | tail -n1
> java  59003 cassandra *979u   REG  253,810 0 1208053768 
> /cassandra-data/data/myawesomecluster/schema_one-randomchecksum/nb-2274426-big-Digest.crc32
>  (deleted)
> {noformat}
> {noformat}
> $ grep 2274426 /cassandra/systemlog.log
> INFO  [Stream-Deserializer-/10.214.79.62:randomport-b904af67] 2023-01-15 
> 13:06:24,969 BigTableZeroCopyWriter.java:203 - Writing component DATA to 
> /cassandra-data/data/myawesomecluster/schema_one-randomchecksum/nb-2274426-big-Data.db
>  length 2.900KiB
> INFO  [Stream-Deserializer-/10.214.79.62:randomport-b904af67] 2023-01-15 
> 13:06:24,969 BigTableZeroCopyWriter.java:213 - Block Writing component to 
> /cassandra-data/data/myawesomecluster/schema_one-randomchecksum/nb-2274426-big-Data.db
>  length 2.900KiB
> INFO  [Stream-Deserializer-/10.214.79.62:randomport-b904af67] 2023-01-15 
> 13:06:24,970 BigTableZeroCopyWriter.java:203 - Writing component 
> PRIMARY_INDEX to 
> /cassandra-data/data/myawesomecluster/schema_one-randomchecksum/nb-2274426-big-Index.db
>  length 3.739KiB
> INFO  [Stream-Deserializer-/10.214.79.62:randomport-b904af67] 2023-01-15 
> 13:06:24,970 BigTableZeroCopyWriter.java:213 - Block Writing component to 
> /cassandra-data/data/myawesomecluster/schema_one-randomchecksum/nb-2274426-big-Index.db
>  length 3.739KiB
> INFO  [Stream-Deserializer-/10.214.79.62:randomport-b904af67] 2023-01-15 
> 13:06:24,970 BigTableZeroCopyWriter.java:203 - Writing component STATS to 
> /cassandra-data/data/myawesomecluster/schema_one-randomchecksum/nb-2274426-big-Statistics.db
>  length 5.062KiB
> INFO  [Stream-Deserializer-/10.214.79.62:randomport-b904af67] 2023-01-15 
> 13:06:24,970 BigTableZeroCopyWriter.java:213 - Block Writing component to 
> /cassandra-data/data/myawesomecluster/schema_one-randomchecksum/nb-2274426-big-Statistics.db
>  length 5.062KiB
> INFO  [Stream-Deserializer-/10.214.79.62:randomport-b904af67] 2023-01-15 
> 13:06:24,971 BigTableZeroCopyWriter.java:203 - Writing component 
> COMPRESSION_INFO to 
> /cassandra-data/data/myawesomecluster/schema_one-randomchecksum/nb-2274426-big-CompressionInfo.db
>  length 0.054KiB
> INFO  [Stream-Deserializer-/10.214.79.62:randomport-b904af67] 2023-01-15 
> 13:06:24,971 BigTableZeroCopyWriter.java:213 - Block Writing component to 
> /cassandra-data/data/myawesomecluster/schema_one-randomchecksum/nb-2274426-big-CompressionInfo.db
>  length 0.054KiB
> INFO  [Stream-Deserializer-/10.214.79.62:randomport-b904af67] 2023-01-15 
> 13:06:24,971 BigTableZeroCopyWriter.java:203 - Writing component FILTER to 
> /cassandra-data/data/myawesomecluster/schema_one-randomchecksum/nb-2274426-big-Filter.db
>  length 0.031KiB
> INFO  [Stream-Deserializer-/10.214.79.62:randomport-b904af67] 2023-01-15 
> 13:06:24,971 BigTableZeroCopyWriter.java:213 - Block Writing component to 
> /cassandra-data/data/myawesomecluster/schema_one-randomchecksum/nb-2274426-big-Filter.db
>  length 0.031KiB
> 

[jira] [Updated] (CASSANDRA-18316) Add feature flag for dynamic data masking

2023-03-13 Thread Berenguer Blasi (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-18316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Berenguer Blasi updated CASSANDRA-18316:

Reviewers: Berenguer Blasi
   Status: Review In Progress  (was: Patch Available)

> Add feature flag for dynamic data masking
> -
>
> Key: CASSANDRA-18316
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18316
> Project: Cassandra
>  Issue Type: New Feature
>  Components: Feature/Dynamic Data Masking
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.x
>
>
> Dynamic data masking 
> ([CEP-20|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-20%3A+Dynamic+Data+Masking])
>  is a new feature, so it will need a feature flag in {{cassandra.yaml}}. 
> Something like:
> {code}
> # If enabled, dynamic data masking allows to attach CQL masking functions to 
> the columns of a table.
> # Users without the UNMASK permission will see an obscured version of the 
> values of the columns with an attached mask.
> # If dynamic data masking is disabled it won't be allowed to create new 
> column masks, although it will still be possible
> # to drop any previously existing masks. Also, any existing mask will be 
> ignored at query time, so all users will see
> # the clear values of the masked columns.
> dynamic_data_masking_enabled: false
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[jira] [Updated] (CASSANDRA-18311) BufferPool incorrectly counts memoryInUse when putUnusedPortion is used

2023-03-13 Thread Jacek Lewandowski (Jira)


 [ 
https://issues.apache.org/jira/browse/CASSANDRA-18311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacek Lewandowski updated CASSANDRA-18311:
--
  Fix Version/s: 4.0.9
 4.1.1
 (was: 4.0.x)
 (was: 4.1.x)
  Since Version: 4.0
Source Control Link: 
https://github.com/apache/cassandra/commit/3cfb2221223a7631f116108aec0a45646e775705
 Resolution: Fixed
 Status: Resolved  (was: Ready to Commit)

> BufferPool incorrectly counts memoryInUse when putUnusedPortion is used
> ---
>
> Key: CASSANDRA-18311
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18311
> Project: Cassandra
>  Issue Type: Bug
>  Components: Local/Caching
>Reporter: Jaroslaw Grabowski
>Assignee: Jaroslaw Grabowski
>Priority: Normal
> Fix For: 4.0.9, 4.1.1, 5.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The counter is incorrectly decremented by the size of the unused portion of 
> the provided buffer.
> It should be decremented by the number of bytes actually returned to the pool 
> (that may be different than "size"). The number should be calculated as a 
> difference between original and resulting buffer capacity.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[cassandra] branch trunk updated (6eeb61d504 -> 3eff9e755c)

2023-03-13 Thread jlewandowski
This is an automated email from the ASF dual-hosted git repository.

jlewandowski pushed a change to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git


from 6eeb61d504 Merge branch 'cassandra-4.1' into trunk
 add 3cfb222122 Fix BufferPool.memoryInUse counter
 add 8ba3888fcf Merge branch 'cassandra-4.0' into cassandra-4.1
 new 3eff9e755c Merge branch 'cassandra-4.1' into trunk

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 CHANGES.txt|  1 +
 .../apache/cassandra/utils/memory/BufferPool.java  |  6 ++--
 .../cassandra/utils/memory/BufferPoolTest.java | 32 ++
 3 files changed, 37 insertions(+), 2 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[cassandra] 01/01: Merge branch 'cassandra-4.1' into trunk

2023-03-13 Thread jlewandowski
This is an automated email from the ASF dual-hosted git repository.

jlewandowski pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git

commit 3eff9e755c46ca1e0011f2c91f8cb48e48cec025
Merge: 6eeb61d504 8ba3888fcf
Author: Jacek Lewandowski 
AuthorDate: Mon Mar 13 09:57:48 2023 +0100

Merge branch 'cassandra-4.1' into trunk

 CHANGES.txt|  1 +
 .../apache/cassandra/utils/memory/BufferPool.java  |  6 ++--
 .../cassandra/utils/memory/BufferPoolTest.java | 32 ++
 3 files changed, 37 insertions(+), 2 deletions(-)



-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[cassandra] branch cassandra-4.0 updated (2aedb58123 -> 3cfb222122)

2023-03-13 Thread jlewandowski
This is an automated email from the ASF dual-hosted git repository.

jlewandowski pushed a change to branch cassandra-4.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git


from 2aedb58123 Merge branch 'cassandra-3.11' into cassandra-4.0
 add 3cfb222122 Fix BufferPool.memoryInUse counter

No new revisions were added by this update.

Summary of changes:
 CHANGES.txt|  1 +
 .../apache/cassandra/utils/memory/BufferPool.java  |  6 ++--
 .../cassandra/utils/memory/BufferPoolTest.java | 32 ++
 3 files changed, 37 insertions(+), 2 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org



[cassandra] branch cassandra-4.1 updated (b7eaa2d209 -> 8ba3888fcf)

2023-03-13 Thread jlewandowski
This is an automated email from the ASF dual-hosted git repository.

jlewandowski pushed a change to branch cassandra-4.1
in repository https://gitbox.apache.org/repos/asf/cassandra.git


from b7eaa2d209 Deprecate org.apache.cassandra.hadoop code
 add 3cfb222122 Fix BufferPool.memoryInUse counter
 add 8ba3888fcf Merge branch 'cassandra-4.0' into cassandra-4.1

No new revisions were added by this update.

Summary of changes:
 CHANGES.txt|  1 +
 .../apache/cassandra/utils/memory/BufferPool.java  |  6 ++--
 .../cassandra/utils/memory/BufferPoolTest.java | 32 ++
 3 files changed, 37 insertions(+), 2 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org