[cassandra-website] branch asf-staging updated (1a67384b1 -> a5d9e549e)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 1a67384b1 generate docs for 8612e581 new a5d9e549e generate docs for 8612e581 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (1a67384b1) \ N -- N -- N refs/heads/asf-staging (a5d9e549e) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: site-ui/build/ui-bundle.zip | Bin 4796442 -> 4796442 bytes 1 file changed, 0 insertions(+), 0 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (8ed70a8fd -> 1a67384b1)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 8ed70a8fd generate docs for 8612e581 new 1a67384b1 generate docs for 8612e581 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (8ed70a8fd) \ N -- N -- N refs/heads/asf-staging (1a67384b1) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4796442 -> 4796442 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18343) JDK17 - fix nodetool_test.TestNodetool.test_sjk
[
https://issues.apache.org/jira/browse/CASSANDRA-18343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-18343:
Test and Documentation Plan:
[Patch|https://github.com/apache/cassandra/compare/trunk...ekaterinadimitrova2:cassandra:CASSANDRA-18343],
[CI
run|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2322/workflows/20db9d1b-90ee-44dc-9cd5-6360b5f9671d]
I ran only the JDK17 tests because the change affects only them. We add the
export in the jvm17-clients.options
Status: Patch Available (was: In Progress)
> JDK17 - fix nodetool_test.TestNodetool.test_sjk
> ---
>
> Key: CASSANDRA-18343
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18343
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 5.x
>
>
>
> [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2321/workflows/de1f521d-c5cb-4ddd-bc45-9ec71b577bf3/jobs/19923/tests]
>
> {code:java}
> AssertionError: Expected 'SJK hh' output assert False == True self =
> @since('4.0') def
> test_sjk(self): """ Verify that SJK generally works. """ cluster =
> self.cluster cluster.populate([1]).start() node = cluster.nodelist()[0] out,
> err, _ = node.nodetool('sjk --help') logger.debug(out) hasPattern = False for
> line in out.split(os.linesep): if " ttop [Thread Top] Displays threads from
> JVM process" == line: hasPattern = True assert hasPattern == True, "Expected
> help about SJK ttop" out, err, _ = node.nodetool('sjk') logger.debug(out)
> hasPattern = False for line in out.split(os.linesep): if " ttop [Thread Top]
> Displays threads from JVM process" == line: hasPattern = True assert
> hasPattern == True, "Expected help about SJK ttop" out, err, _ =
> node.nodetool('sjk hh -n 10 --live') logger.debug(out) hasPattern = False for
> line in out.split(os.linesep): if re.match('.*Instances.*Bytes.*Type.*',
> line): hasPattern = True > assert hasPattern == True, "Expected 'SJK hh'
> output" E AssertionError: Expected 'SJK hh' output E assert False == True
> nodetool_test.py:482: AssertionError{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18343) JDK17 - fix nodetool_test.TestNodetool.test_sjk
[
https://issues.apache.org/jira/browse/CASSANDRA-18343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703816#comment-17703816
]
Ekaterina Dimitrova commented on CASSANDRA-18343:
-
[Patch|https://github.com/apache/cassandra/compare/trunk...ekaterinadimitrova2:cassandra:CASSANDRA-18343],
[CI
run|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2322/workflows/20db9d1b-90ee-44dc-9cd5-6360b5f9671d]
I ran only the JDK17 tests because the change affects only them. We add the
export in the jvm17-clients.options
> JDK17 - fix nodetool_test.TestNodetool.test_sjk
> ---
>
> Key: CASSANDRA-18343
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18343
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 5.x
>
>
>
> [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2321/workflows/de1f521d-c5cb-4ddd-bc45-9ec71b577bf3/jobs/19923/tests]
>
> {code:java}
> AssertionError: Expected 'SJK hh' output assert False == True self =
> @since('4.0') def
> test_sjk(self): """ Verify that SJK generally works. """ cluster =
> self.cluster cluster.populate([1]).start() node = cluster.nodelist()[0] out,
> err, _ = node.nodetool('sjk --help') logger.debug(out) hasPattern = False for
> line in out.split(os.linesep): if " ttop [Thread Top] Displays threads from
> JVM process" == line: hasPattern = True assert hasPattern == True, "Expected
> help about SJK ttop" out, err, _ = node.nodetool('sjk') logger.debug(out)
> hasPattern = False for line in out.split(os.linesep): if " ttop [Thread Top]
> Displays threads from JVM process" == line: hasPattern = True assert
> hasPattern == True, "Expected help about SJK ttop" out, err, _ =
> node.nodetool('sjk hh -n 10 --live') logger.debug(out) hasPattern = False for
> line in out.split(os.linesep): if re.match('.*Instances.*Bytes.*Type.*',
> line): hasPattern = True > assert hasPattern == True, "Expected 'SJK hh'
> output" E AssertionError: Expected 'SJK hh' output E assert False == True
> nodetool_test.py:482: AssertionError{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18319) Cassandra in Kubernetes: IP switch decommission issue
[
https://issues.apache.org/jira/browse/CASSANDRA-18319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703813#comment-17703813
]
Raymond Huffman commented on CASSANDRA-18319:
-
I was able to reproduce in a dtest having a write fail once old_ip rejoined the
cluster. This is with a 6 node cluster, RF=3.
cassandra.Unavailable: Error from server: code=1000 [Unavailable exception]
message="Cannot achieve consistency level ALL" info=\{'consistency': 'ALL',
'required_replicas': 3, 'alive_replicas': 2}
trace from cql: [^write_failure.txt]
{quote}
Something else must be going on here since fat clients aren't members and
aren't considered for consistency
{quote}
The issue here is that old_ip is not a FatClient. The other nodes in the
cluster believes it has joined the ring, but has status ?N.
{quote}
No, that probably creates edge cases like trying to rebootstrap a recently
decom'd node will be impossible.
{quote}
Could you possibly elaborate on this more? My understanding is that if a node
decommissions and then immediately rebootstraps, it will increment its
generation. If we were to hit the above check, the bootstrapping node will
appear newer so it won't be purged from gossip.
Something else I've experimented with has been refreshing the timestamps in
justRemovedEndpoints every time a node receives gossip about a quarantined
endpoint. I modified justRemovedEndpoints to also include hostId so that we
specifically quarantine (endpoint, hostId) pairs. Refreshing the endpoint
quarantine makes my tests pass, and including hostId allows you to still
bootstrap a new node at the FatClient IP (and also handles the case where an
existing node has its IP re-assigned to the FatClient IP).
https://github.com/apache/cassandra/compare/trunk...rhuffy:cassandra:CASSANDRA-18319
> Cassandra in Kubernetes: IP switch decommission issue
> -
>
> Key: CASSANDRA-18319
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18319
> Project: Cassandra
> Issue Type: Bug
>Reporter: Ines Potier
>Priority: Normal
> Attachments: 3.11_gossipinfo.zip, node1_gossipinfo.txt,
> test_decommission_after_ip_change_logs.zip,
> v4.0_1678853171792_test_decommission_after_ip_change.zip, write_failure.txt
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We have recently encountered a recurring old IP reappearance issue while
> testing decommissions on some of our Kubernetes Cassandra staging clusters.
> *Issue Description*
> In Kubernetes, a Cassandra node can change IP at each pod bounce. We have
> noticed that this behavior, associated with a decommission operation, can get
> the cluster into an erroneous state.
> Consider the following situation: a Cassandra node {{node1}} , with
> {{{}hostId1{}}}, owning 20.5% of the token ring, bounces and switches IP
> ({{{}old_IP{}}} → {{{}new_IP{}}}). After a couple gossip iterations, all
> other nodes’ nodetool status output includes a {{new_IP}} UN entry owning
> 20.5% of the token ring and no {{old_IP}} entry.
> Shortly after the bounce, {{node1}} gets decommissioned. Our cluster does not
> have a lot of data, and the decommission operation completes pretty quickly.
> Logs on other nodes start showing acknowledgment that {{node1}} has left and
> soon, nodetool status’ {{new_IP}} UL entry disappears. {{node1}} ‘s pod is
> deleted.
> After a minute delay, the cluster enters the erroneous state. An {{old_IP}}
> DN entry reappears in nodetool status, owning 20.5% of the token ring. No
> node owns this IP anymore and according to logs, {{old_IP}} is still
> associated with {{{}hostId1{}}}.
> *Issue Root Cause*
> By digging through Cassandra logs, and re-testing this scenario over and over
> again, we have reached the following conclusion:
> * Other nodes will continue exchanging gossip about {{old_IP}} , even after
> it becomes a fatClient.
> * The fatClient timeout and subsequent quarantine does not stop {{old_IP}}
> from reappearing in a node’s Gossip state, once its quarantine is over. We
> believe that this is due to a misalignment on all nodes’ {{old_IP}}
> expiration time.
> * Once {{new_IP}} has left the cluster, and {{old_IP}} next gossip state
> message is received by a node, StorageService will no longer face collisions
> (or will, but with an even older IP) for {{hostId1}} and its corresponding
> tokens. As a result, {{old_IP}} will regain ownership of 20.5% of the token
> ring.
> *Proposed fix*
> Following the above investigation, we were thinking about implementing the
> following fix:
> When a node receives a gossip status change with {{STATE_LEFT}} for a leaving
> endpoint {{{}new_IP{}}}, before evicting {{{}new_IP from the token ring,
> purge from Gossip (ie evictFromMembership{}}}) all endpoints that meet the
>
[jira] [Commented] (CASSANDRA-18049) Update Chronicle Queue
[
https://issues.apache.org/jira/browse/CASSANDRA-18049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703805#comment-17703805
]
Michael Semb Wever commented on CASSANDRA-18049:
I missed this too.
It does not appear to have any material effect, but we still need to exclude
`third-party-bom/3.22.4-SNAPSHOT`.
> Update Chronicle Queue
> --
>
> Key: CASSANDRA-18049
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18049
> Project: Cassandra
> Issue Type: Task
>Reporter: Ekaterina Dimitrova
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 5.0
>
>
> According to [this|https://chronicle.software/chronicle-support-java-17]
> article:
> {code:java}
> Starting from chronicle-bom-2.22ea26, all new releases can be run under Java
> 17 when run on the class path (but not yet under the module path).{code}
> This BOM is newer than what we currently have in both 4.1 and trunk. 4.1
> points in comments to
> [https://mvnrepository.com/artifact/net.openhft/chronicle-bom/1.16.23] which
> I believe was just forgotten to be updated/removed. The versions we see
> correspond to this BOM
> [https://mvnrepository.com/artifact/net.openhft/chronicle-bom/2.20.226]
> It is still older than chronicle-bom-2.22ea26 so we need to upgrade. I
> suggest we also add a comment again which BOM is considered, this makes
> things easier.
> Further to running CI, review of the CHANGE logs needs to happen to ensure we
> do not miss anything that can impact us and it is not caught by our tests.
> For testing with JDK17, please, contact [~e.dimitrova] for latest branch and
> CI config (at this point feature branch in the cassandra repo does not exist)
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14667) Upgrade Dropwizard Metrics to 4.x
[
https://issues.apache.org/jira/browse/CASSANDRA-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703803#comment-17703803
]
Ekaterina Dimitrova commented on CASSANDRA-14667:
-
{quote}Sure, this is good notice. I have found that version 3.1.5 is no longer
maintained by Dropwizard, so it might cause some problems for us with JDK 17.
{quote}
At least in our CI I do not see any related failures but I agree that it is a
good call. Thank you!
Now everyone can already test very easily with JDK 17 in CircleCI after
CASSANDRA-18247 got committed.
The CI run from the other day is available here
[#2321|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=18247-trunk-v2]
and the current failures are described in the CASSANDRA-16895 description with
attached respective tickets. Nothing strikes me to be related but this doesn't
mean there may be submarines...
> Upgrade Dropwizard Metrics to 4.x
> -
>
> Key: CASSANDRA-14667
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14667
> Project: Cassandra
> Issue Type: Task
> Components: Observability/Metrics
>Reporter: Stig Rohde Døssing
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Cassandra currently uses Metrics 3.1.5. Version 4.0.0 added some fixes for
> Java 9 compatibility. It would be good to upgrade the Metrics library as part
> of the version of Cassandra that adds Java 9 compatibility
> (https://issues.apache.org/jira/browse/CASSANDRA-9608).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18049) Update Chronicle Queue
[
https://issues.apache.org/jira/browse/CASSANDRA-18049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703802#comment-17703802
]
Ekaterina Dimitrova commented on CASSANDRA-18049:
-
{quote}I am not sure how much of an issue is this but I see this in logs doing
ant jar:
{quote}
Honestly, me too, I missed those messages pre-commit. I can take a look at them
tomorrow. Thank you for the ping, appreciate it!
On a quick look I _suspect_ it is not a real problem:
{code:java}
[resolver:resolve] Downloading
https://nexus.chronicle.software/content/repositories/thirdparty/net/openhft/third-party-bom/3.22.4-SNAPSHOT/maven-metadata.xml
[resolver:resolve] Downloading
https://nexus.chronicle.software/content/repositories/snapshots/net/openhft/third-party-bom/3.22.4-SNAPSHOT/maven-metadata.xml
[resolver:resolve] Downloading
https://nexus.chronicle.software/content/repositories/releases/net/openhft/third-party-bom/3.22.4-SNAPSHOT/maven-metadata.xml
[resolver:resolve] Downloading
https://oss.sonatype.org/content/repositories/staging/net/openhft/third-party-bom/3.22.4-SNAPSHOT/maven-metadata.xml
[resolver:resolve] Downloaded
https://oss.sonatype.org/content/repositories/staging/net/openhft/third-party-bom/3.22.4-SNAPSHOT/maven-metadata.xml
(786 B at 1.5 KB/sec)
[resolver:resolve] Downloading
https://oss.sonatype.org/content/repositories/snapshots/net/openhft/third-party-bom/3.22.4-SNAPSHOT/maven-metadata.xml
[resolver:resolve] Downloaded
https://oss.sonatype.org/content/repositories/snapshots/net/openhft/third-party-bom/3.22.4-SNAPSHOT/maven-metadata.xml
(786 B at 32.0 KB/sec){code}
If I read this correctly, download happened successfully from the other repo
and the build completes successfully.
So I guess we need to see how we can skip trying to download from the one we
are not authorized but I have to dig into this more.
> Update Chronicle Queue
> --
>
> Key: CASSANDRA-18049
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18049
> Project: Cassandra
> Issue Type: Task
>Reporter: Ekaterina Dimitrova
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 5.0
>
>
> According to [this|https://chronicle.software/chronicle-support-java-17]
> article:
> {code:java}
> Starting from chronicle-bom-2.22ea26, all new releases can be run under Java
> 17 when run on the class path (but not yet under the module path).{code}
> This BOM is newer than what we currently have in both 4.1 and trunk. 4.1
> points in comments to
> [https://mvnrepository.com/artifact/net.openhft/chronicle-bom/1.16.23] which
> I believe was just forgotten to be updated/removed. The versions we see
> correspond to this BOM
> [https://mvnrepository.com/artifact/net.openhft/chronicle-bom/2.20.226]
> It is still older than chronicle-bom-2.22ea26 so we need to upgrade. I
> suggest we also add a comment again which BOM is considered, this makes
> things easier.
> Further to running CI, review of the CHANGE logs needs to happen to ensure we
> do not miss anything that can impact us and it is not caught by our tests.
> For testing with JDK17, please, contact [~e.dimitrova] for latest branch and
> CI config (at this point feature branch in the cassandra repo does not exist)
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14667) Upgrade Dropwizard Metrics to 4.x
[ https://issues.apache.org/jira/browse/CASSANDRA-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703801#comment-17703801 ] Maxim Muzafarov commented on CASSANDRA-14667: - Sure, this is good notice. I have found that version 3.1.5 is no longer maintained by Dropwizard, so it might cause some problems for us with JDK 17. The 4.2.17 seems to be OK according to the build matrix, so I decided to raise the PR with an upgrade https://github.com/dropwizard/metrics/blob/release/4.2.x/.github/workflows/maven.yml#L16 > Upgrade Dropwizard Metrics to 4.x > - > > Key: CASSANDRA-14667 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14667 > Project: Cassandra > Issue Type: Task > Components: Observability/Metrics >Reporter: Stig Rohde Døssing >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > Cassandra currently uses Metrics 3.1.5. Version 4.0.0 added some fixes for > Java 9 compatibility. It would be good to upgrade the Metrics library as part > of the version of Cassandra that adds Java 9 compatibility > (https://issues.apache.org/jira/browse/CASSANDRA-9608). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14667) Upgrade Dropwizard Metrics to 4.x
[ https://issues.apache.org/jira/browse/CASSANDRA-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703796#comment-17703796 ] Ekaterina Dimitrova commented on CASSANDRA-14667: - If I recall correctly, I was told long ago that this will be a breaking change for tools, but I was not provided any other details so you might want to investigate or even ask on the mailing list. > Upgrade Dropwizard Metrics to 4.x > - > > Key: CASSANDRA-14667 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14667 > Project: Cassandra > Issue Type: Task > Components: Observability/Metrics >Reporter: Stig Rohde Døssing >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > Cassandra currently uses Metrics 3.1.5. Version 4.0.0 added some fixes for > Java 9 compatibility. It would be good to upgrade the Metrics library as part > of the version of Cassandra that adds Java 9 compatibility > (https://issues.apache.org/jira/browse/CASSANDRA-9608). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18319) Cassandra in Kubernetes: IP switch decommission issue
[
https://issues.apache.org/jira/browse/CASSANDRA-18319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Raymond Huffman updated CASSANDRA-18319:
Attachment: write_failure.txt
> Cassandra in Kubernetes: IP switch decommission issue
> -
>
> Key: CASSANDRA-18319
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18319
> Project: Cassandra
> Issue Type: Bug
>Reporter: Ines Potier
>Priority: Normal
> Attachments: 3.11_gossipinfo.zip, node1_gossipinfo.txt,
> test_decommission_after_ip_change_logs.zip,
> v4.0_1678853171792_test_decommission_after_ip_change.zip, write_failure.txt
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We have recently encountered a recurring old IP reappearance issue while
> testing decommissions on some of our Kubernetes Cassandra staging clusters.
> *Issue Description*
> In Kubernetes, a Cassandra node can change IP at each pod bounce. We have
> noticed that this behavior, associated with a decommission operation, can get
> the cluster into an erroneous state.
> Consider the following situation: a Cassandra node {{node1}} , with
> {{{}hostId1{}}}, owning 20.5% of the token ring, bounces and switches IP
> ({{{}old_IP{}}} → {{{}new_IP{}}}). After a couple gossip iterations, all
> other nodes’ nodetool status output includes a {{new_IP}} UN entry owning
> 20.5% of the token ring and no {{old_IP}} entry.
> Shortly after the bounce, {{node1}} gets decommissioned. Our cluster does not
> have a lot of data, and the decommission operation completes pretty quickly.
> Logs on other nodes start showing acknowledgment that {{node1}} has left and
> soon, nodetool status’ {{new_IP}} UL entry disappears. {{node1}} ‘s pod is
> deleted.
> After a minute delay, the cluster enters the erroneous state. An {{old_IP}}
> DN entry reappears in nodetool status, owning 20.5% of the token ring. No
> node owns this IP anymore and according to logs, {{old_IP}} is still
> associated with {{{}hostId1{}}}.
> *Issue Root Cause*
> By digging through Cassandra logs, and re-testing this scenario over and over
> again, we have reached the following conclusion:
> * Other nodes will continue exchanging gossip about {{old_IP}} , even after
> it becomes a fatClient.
> * The fatClient timeout and subsequent quarantine does not stop {{old_IP}}
> from reappearing in a node’s Gossip state, once its quarantine is over. We
> believe that this is due to a misalignment on all nodes’ {{old_IP}}
> expiration time.
> * Once {{new_IP}} has left the cluster, and {{old_IP}} next gossip state
> message is received by a node, StorageService will no longer face collisions
> (or will, but with an even older IP) for {{hostId1}} and its corresponding
> tokens. As a result, {{old_IP}} will regain ownership of 20.5% of the token
> ring.
> *Proposed fix*
> Following the above investigation, we were thinking about implementing the
> following fix:
> When a node receives a gossip status change with {{STATE_LEFT}} for a leaving
> endpoint {{{}new_IP{}}}, before evicting {{{}new_IP from the token ring,
> purge from Gossip (ie evictFromMembership{}}}) all endpoints that meet the
> following criteria:
> * {{endpointStateMap}} contains this endpoint
> * The endpoint is not currently a token owner
> ({{{}!tokenMetadata.isMember(endpoint){}}})
> * The endpoint’s {{hostId}} matches the {{hostId}} of {{new_IP}}
> * The endpoint is older than {{leaving_IP}}
> ({{{}Gossiper.instance.compareEndpointStartup{}}})
> * The endpoint’s token range (from {{{}endpointStateMap{}}}) intersects with
> {{{}new_IP{}}}’s
> This modification’s intention is to force nodes to realign on {{old_IP}}
> expiration, and expunge it from Gossip so it does not reappear after
> {{new_IP}} leaves the ring.
> Another approach we have also been considering is expunging {{old_IP}} at the
> moment of the StorageService collision resolution.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16356) Add size histogram for Cassandra read operations
[ https://issues.apache.org/jira/browse/CASSANDRA-16356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Motta updated CASSANDRA-16356: Change Category: Operability Complexity: Low Hanging Fruit Status: Open (was: Triage Needed) > Add size histogram for Cassandra read operations > > > Key: CASSANDRA-16356 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16356 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Metrics >Reporter: Adelina Vidovici >Priority: Normal > > Similar to MutationSizeHistogram which exists for write operations, there is > a need for having metrics also regarding the size of the read operations. > More details for client documentation metrics can be found here: > https://cassandra.apache.org/doc/latest/operating/metrics.html -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16356) Add size histogram for Cassandra read operations
[ https://issues.apache.org/jira/browse/CASSANDRA-16356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Motta updated CASSANDRA-16356: Labels: lhf (was: ) > Add size histogram for Cassandra read operations > > > Key: CASSANDRA-16356 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16356 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Metrics >Reporter: Adelina Vidovici >Priority: Normal > Labels: lhf > > Similar to MutationSizeHistogram which exists for write operations, there is > a need for having metrics also regarding the size of the read operations. > More details for client documentation metrics can be found here: > https://cassandra.apache.org/doc/latest/operating/metrics.html -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14667) Upgrade Dropwizard Metrics to 4.x
[ https://issues.apache.org/jira/browse/CASSANDRA-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703779#comment-17703779 ] Stefan Miklosovic commented on CASSANDRA-14667: --- It would be cool if we also tested that this version also runs flawlessly on Java 17. > Upgrade Dropwizard Metrics to 4.x > - > > Key: CASSANDRA-14667 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14667 > Project: Cassandra > Issue Type: Task > Components: Observability/Metrics >Reporter: Stig Rohde Døssing >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > Cassandra currently uses Metrics 3.1.5. Version 4.0.0 added some fixes for > Java 9 compatibility. It would be good to upgrade the Metrics library as part > of the version of Cassandra that adds Java 9 compatibility > (https://issues.apache.org/jira/browse/CASSANDRA-9608). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18049) Update Chronicle Queue
[
https://issues.apache.org/jira/browse/CASSANDRA-18049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703778#comment-17703778
]
Stefan Miklosovic commented on CASSANDRA-18049:
---
I am not sure how much of an issue is this but I see this in logs doing ant jar:
{code}
resolver-dist-lib:
[resolver:resolve] Downloading
https://nexus.chronicle.software/content/repositories/thirdparty/net/openhft/third-party-bom/3.22.4-SNAPSHOT/maven-metadata.xml
[resolver:resolve] Downloading
https://nexus.chronicle.software/content/repositories/snapshots/net/openhft/third-party-bom/3.22.4-SNAPSHOT/maven-metadata.xml
[resolver:resolve] Downloading
https://nexus.chronicle.software/content/repositories/releases/net/openhft/third-party-bom/3.22.4-SNAPSHOT/maven-metadata.xml
[resolver:resolve] Could not transfer metadata
net.openhft:third-party-bom:3.22.4-SNAPSHOT/maven-metadata.xml from/to
third-party-release
(https://nexus.chronicle.software/content/repositories/thirdparty/): status
code: 401, reason phrase: Unauthorized (401)
[resolver:resolve] Could not transfer metadata
net.openhft:third-party-bom:3.22.4-SNAPSHOT/maven-metadata.xml from/to
chronicle-enterprise-snapshots
(https://nexus.chronicle.software/content/repositories/snapshots): status code:
401, reason phrase: Unauthorized (401)
[resolver:resolve] Could not transfer metadata
net.openhft:third-party-bom:3.22.4-SNAPSHOT/maven-metadata.xml from/to
chronicle-enterprise-release
(https://nexus.chronicle.software/content/repositories/releases): status code:
401, reason phrase: Unauthorized (401)
{code}
> Update Chronicle Queue
> --
>
> Key: CASSANDRA-18049
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18049
> Project: Cassandra
> Issue Type: Task
>Reporter: Ekaterina Dimitrova
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 5.0
>
>
> According to [this|https://chronicle.software/chronicle-support-java-17]
> article:
> {code:java}
> Starting from chronicle-bom-2.22ea26, all new releases can be run under Java
> 17 when run on the class path (but not yet under the module path).{code}
> This BOM is newer than what we currently have in both 4.1 and trunk. 4.1
> points in comments to
> [https://mvnrepository.com/artifact/net.openhft/chronicle-bom/1.16.23] which
> I believe was just forgotten to be updated/removed. The versions we see
> correspond to this BOM
> [https://mvnrepository.com/artifact/net.openhft/chronicle-bom/2.20.226]
> It is still older than chronicle-bom-2.22ea26 so we need to upgrade. I
> suggest we also add a comment again which BOM is considered, this makes
> things easier.
> Further to running CI, review of the CHANGE logs needs to happen to ensure we
> do not miss anything that can impact us and it is not caught by our tests.
> For testing with JDK17, please, contact [~e.dimitrova] for latest branch and
> CI config (at this point feature branch in the cassandra repo does not exist)
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18301) Let the user select the sstable version to write
[
https://issues.apache.org/jira/browse/CASSANDRA-18301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703772#comment-17703772
]
Andres de la Peña commented on CASSANDRA-18301:
---
{quote}Another reason why the setting name IMHO needs to be more explicit about
what it is limiting (storage) (and why this is not just about
downgrading).{quote}
Sure, that needs a better name and detailed documentation, that was just an
example. The point was that using the Cassandra version is probably more
friendly for users. I think it would be a victory for usability if users don't
need to know what sstable version is used in what version of Cassandra.
> Let the user select the sstable version to write
>
>
> Key: CASSANDRA-18301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18301
> Project: Cassandra
> Issue Type: New Feature
> Components: Local/Config, Local/SSTable
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Normal
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-14667) Upgrade Dropwizard Metrics to 4.x
[ https://issues.apache.org/jira/browse/CASSANDRA-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov reassigned CASSANDRA-14667: --- Assignee: Maxim Muzafarov > Upgrade Dropwizard Metrics to 4.x > - > > Key: CASSANDRA-14667 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14667 > Project: Cassandra > Issue Type: Task > Components: Observability/Metrics >Reporter: Stig Rohde Døssing >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > Cassandra currently uses Metrics 3.1.5. Version 4.0.0 added some fixes for > Java 9 compatibility. It would be good to upgrade the Metrics library as part > of the version of Cassandra that adds Java 9 compatibility > (https://issues.apache.org/jira/browse/CASSANDRA-9608). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14667) Upgrade Dropwizard Metrics to 4.x
[ https://issues.apache.org/jira/browse/CASSANDRA-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703767#comment-17703767 ] Maxim Muzafarov commented on CASSANDRA-14667: - [~smiklosovic] Thank you for helping with this, waiting for the build results. > Upgrade Dropwizard Metrics to 4.x > - > > Key: CASSANDRA-14667 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14667 > Project: Cassandra > Issue Type: Task > Components: Observability/Metrics >Reporter: Stig Rohde Døssing >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > Cassandra currently uses Metrics 3.1.5. Version 4.0.0 added some fixes for > Java 9 compatibility. It would be good to upgrade the Metrics library as part > of the version of Cassandra that adds Java 9 compatibility > (https://issues.apache.org/jira/browse/CASSANDRA-9608). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18301) Let the user select the sstable version to write
[
https://issues.apache.org/jira/browse/CASSANDRA-18301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703765#comment-17703765
]
Andres de la Peña commented on CASSANDRA-18301:
---
{quote}
we still don't know which format implementation was used in the previous
version of Cassandra
{quote}
We sure know the major sstable version for the previous Cassandra version we
want to be downgradable to. Perhaps we should use the last known version for
that branch?
{quote}the user may want to enable other features while keep the old sstables
format version - after enabling other features but not bumping sstable format
version, the user is still able to go back. Without enabling other new
features, the user will not be able to evaluate a new version{quote}
The list of disabled features when one decides to stay on that kind of
"compatibility mode" would not be the full list of new features in the new
version, but only those that require a new sstable version. For example,
Cassandra 5.0 compatible with 4.0 would disable extended TTLs and SSTable
tries, but the new dynamic data masking would be enabled because it doesn't
require a new sstable format.
> Let the user select the sstable version to write
>
>
> Key: CASSANDRA-18301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18301
> Project: Cassandra
> Issue Type: New Feature
> Components: Local/Config, Local/SSTable
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Normal
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17199) Provide summary of failed SessionInfo's in StreamResultFuture
[
https://issues.apache.org/jira/browse/CASSANDRA-17199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703764#comment-17703764
]
David Capwell commented on CASSANDRA-17199:
---
not found the root cause yet but pushed logic that will not cause await to
block forever (we now timeout after 1m)
https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=pr%2Fupstream_2104
My theory is that the JVM hangs due to this as we keep waiting for the trigger
> Provide summary of failed SessionInfo's in StreamResultFuture
> -
>
> Key: CASSANDRA-17199
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17199
> Project: Cassandra
> Issue Type: Improvement
> Components: Observability/Logging
>Reporter: Brendan Cicchi
>Assignee: Natnael Adere
>Priority: Normal
> Labels: AdventCalendar2021, lhf
> Fix For: 5.x
>
>
> Currently, we warn about the presence of one or more failed sessions existing
> in the final state and then an operator/user traces back through the logs to
> find any failed streams for troubleshooting.
> {code:java}
> private synchronized void maybeComplete()
> {
> if (finishedAllSessions())
> {
> StreamState finalState = getCurrentState();
> if (finalState.hasFailedSession())
> {
> logger.warn("[Stream #{}] Stream failed", planId);
> tryFailure(new StreamException(finalState, "Stream failed"));
> }
> else
> {
> logger.info("[Stream #{}] All sessions completed", planId);
> trySuccess(finalState);
> }
> }
> } {code}
> It would be helpful to log out a summary of the SessionInfo for each failed
> session since that should be accessible via the StreamState.
>
> This can be especially helpful for longer streaming operations like bootstrap
> where the failure could have been a long time back and all recent streams
> leading up to the warning actually are successful.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18301) Let the user select the sstable version to write
[ https://issues.apache.org/jira/browse/CASSANDRA-18301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703759#comment-17703759 ] Michael Semb Wever commented on CASSANDRA-18301: IIUC specifying the version does not imply limiting (preventing) non-format features. Another reason why the setting name IMHO needs to be more explicit about what it is limiting (storage) (and why this is not just about downgrading). > Let the user select the sstable version to write > > > Key: CASSANDRA-18301 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18301 > Project: Cassandra > Issue Type: New Feature > Components: Local/Config, Local/SSTable >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17341) Merge guardrails and track warnings configurations
[
https://issues.apache.org/jira/browse/CASSANDRA-17341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-17341:
--
Resolution: Fixed
Status: Resolved (was: Open)
> Merge guardrails and track warnings configurations
> --
>
> Key: CASSANDRA-17341
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17341
> Project: Cassandra
> Issue Type: Task
> Components: Feature/Guardrails, Local/Config
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.x
>
>
> As discussed in CASSANDRA-17148, a first step for the integration between
> guardrails and track warnings is merging their configurations, which are
> almost identical. This ticket would cover merging their config sections in
> {{cassandra.yaml}} and their corresponding JMX getters and setters. A tighter
> integration between the internals of both features wouldn't be part of this
> ticket, but of either CASSANDRA-17148 or a new subtask of it.
> Neither guardrails nor track warnings have included in any release, so it
> would be desirable to do this before releasing 4.1 so we don't have to
> deprecate properties.
> There's an ongoing discussion about refactoring {{cassandra.yaml}} spread
> across CASSANDRA-17292, CASSANDRA-17188 and CASSANDRA-17212. I understand
> that any change affecting the config for guardrails also affects the config
> track warnings, because they are almost identical. Thus, I think that merging
> both config sections would ease any refactoring plan that is agreed on that
> discussion.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17341) Merge guardrails and track warnings configurations
[
https://issues.apache.org/jira/browse/CASSANDRA-17341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-17341:
--
Status: Open (was: Patch Available)
> Merge guardrails and track warnings configurations
> --
>
> Key: CASSANDRA-17341
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17341
> Project: Cassandra
> Issue Type: Task
> Components: Feature/Guardrails, Local/Config
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.x
>
>
> As discussed in CASSANDRA-17148, a first step for the integration between
> guardrails and track warnings is merging their configurations, which are
> almost identical. This ticket would cover merging their config sections in
> {{cassandra.yaml}} and their corresponding JMX getters and setters. A tighter
> integration between the internals of both features wouldn't be part of this
> ticket, but of either CASSANDRA-17148 or a new subtask of it.
> Neither guardrails nor track warnings have included in any release, so it
> would be desirable to do this before releasing 4.1 so we don't have to
> deprecate properties.
> There's an ongoing discussion about refactoring {{cassandra.yaml}} spread
> across CASSANDRA-17292, CASSANDRA-17188 and CASSANDRA-17212. I understand
> that any change affecting the config for guardrails also affects the config
> track warnings, because they are almost identical. Thus, I think that merging
> both config sections would ease any refactoring plan that is agreed on that
> discussion.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18301) Let the user select the sstable version to write
[ https://issues.apache.org/jira/browse/CASSANDRA-18301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703757#comment-17703757 ] Jacek Lewandowski commented on CASSANDRA-18301: --- [~bereng] what behaviour do you mean in particular? I'm not sure I'm in favour of making it work like that - specify the Cassandra version instead the exact sstable format version. I have my reasons: - we still don't know which format implementation was used in the previous version of Cassandra - the user may want to enable other features while keep the old sstables format version - after enabling other features but not bumping sstable format version, the user is still able to go back. Without enabling other new features, the user will not be able to evaluate a new version > Let the user select the sstable version to write > > > Key: CASSANDRA-18301 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18301 > Project: Cassandra > Issue Type: New Feature > Components: Local/Config, Local/SSTable >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18353) Cqlsh command "COPY … TO STDOUT" fails with "… object is not callable"
[
https://issues.apache.org/jira/browse/CASSANDRA-18353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-18353:
-
Fix Version/s: 5.0
4.1.2
(was: 5.x)
(was: 4.1.x)
Since Version: 4.1.0
Source Control Link:
https://github.com/apache/cassandra/commit/70b95d80985e9165528e0b22f32fec187098e0ff
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
Thanks for the review! Committed.
> Cqlsh command "COPY … TO STDOUT" fails with "… object is not callable"
> --
>
> Key: CASSANDRA-18353
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18353
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Gustav Broberg
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.0, 4.1.2
>
>
> Since 4.1.0, cqlsh fails on COPY commands with standard output as target.
> Steps to reproduce:
> {noformat}
> $> docker run -d --name cassandra --rm cassandra:4.1.1
> $> docker exec cassandra cqlsh -e 'COPY system.local(cluster_name) TO STDOUT'
> :1:'NoneType' object is not callable
> {noformat}
> Possibly a regression introduced by this commit
> [6341319|https://github.com/apache/cassandra/commit/634131961af9c1d88b34797c1c45000f71a76dae#diff-584645e6e932edd7a17f03c79ae87b1f1f8ed54919a31ce8785af156b89c0b76L260].
> Also, it looks like it has happened before: CASSANDRA-12497
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18353) Cqlsh command "COPY … TO STDOUT" fails with "… object is not callable"
[
https://issues.apache.org/jira/browse/CASSANDRA-18353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-18353:
-
Status: Ready to Commit (was: Review In Progress)
> Cqlsh command "COPY … TO STDOUT" fails with "… object is not callable"
> --
>
> Key: CASSANDRA-18353
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18353
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Gustav Broberg
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.1.x, 5.x
>
>
> Since 4.1.0, cqlsh fails on COPY commands with standard output as target.
> Steps to reproduce:
> {noformat}
> $> docker run -d --name cassandra --rm cassandra:4.1.1
> $> docker exec cassandra cqlsh -e 'COPY system.local(cluster_name) TO STDOUT'
> :1:'NoneType' object is not callable
> {noformat}
> Possibly a regression introduced by this commit
> [6341319|https://github.com/apache/cassandra/commit/634131961af9c1d88b34797c1c45000f71a76dae#diff-584645e6e932edd7a17f03c79ae87b1f1f8ed54919a31ce8785af156b89c0b76L260].
> Also, it looks like it has happened before: CASSANDRA-12497
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-dtest] branch trunk updated: Add COPY TO ... STDOUT test
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-dtest.git
The following commit(s) were added to refs/heads/trunk by this push:
new 2f8b0d59 Add COPY TO ... STDOUT test
2f8b0d59 is described below
commit 2f8b0d5949bea63ad642ea84cfae716fb3dbce59
Author: Brandon Williams
AuthorDate: Tue Mar 21 17:42:54 2023 -0500
Add COPY TO ... STDOUT test
Patch by brandonwilliams; reviewed by adelapena for CASSANDRA-18353
---
cqlsh_tests/test_cqlsh.py | 7 +++
1 file changed, 7 insertions(+)
diff --git a/cqlsh_tests/test_cqlsh.py b/cqlsh_tests/test_cqlsh.py
index 4f4d1b75..1f5c3767 100644
--- a/cqlsh_tests/test_cqlsh.py
+++ b/cqlsh_tests/test_cqlsh.py
@@ -2564,6 +2564,13 @@ class TestCqlshSmoke(Tester, CqlshMixin):
assert_all(self.session, 'SELECT key FROM ks.test',
[['eggs'], ['spam'], ['sausage']])
+def test_copy_stdout(self):
+"""
+Smoke test COPY ... TO STDOUT
+CASSANDRA-12497, CASSANDRA-18353
+"""
+self.node1.run_cqlsh("COPY system.local(cluster_name) TO STDOUT")
+
def test_create_keyspace(self):
assert 'created' not in self.get_keyspace_names()
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.1 updated: Restore COPY ... TO STDOUT behavior in cqlsh
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch cassandra-4.1 in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/cassandra-4.1 by this push: new 70b95d8098 Restore COPY ... TO STDOUT behavior in cqlsh 70b95d8098 is described below commit 70b95d80985e9165528e0b22f32fec187098e0ff Author: Brandon Williams AuthorDate: Tue Mar 21 16:07:49 2023 -0500 Restore COPY ... TO STDOUT behavior in cqlsh Patch by brandonwilliams; reviewed by adelapena for CASSANDRA-18353 --- CHANGES.txt| 1 + pylib/cqlshlib/copyutil.py | 7 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/CHANGES.txt b/CHANGES.txt index 27e7d998f2..7c7290f133 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,4 +1,5 @@ 4.1.2 + * Fix COPY ... TO STDOUT behavior in cqlsh (CASSANDRA-18353) * Remove six and Py2SaferScanner merge cruft (CASSANDRA-18354) diff --git a/pylib/cqlshlib/copyutil.py b/pylib/cqlshlib/copyutil.py index 31c881c595..2a8a11d1bf 100644 --- a/pylib/cqlshlib/copyutil.py +++ b/pylib/cqlshlib/copyutil.py @@ -86,6 +86,11 @@ def printmsg(msg, eol='\n'): sys.stdout.flush() +# Keep arguments in sync with printmsg +def swallowmsg(msg, eol='\n'): +None + + class OneWayPipe(object): """ A one way pipe protected by two process level locks, one for reading and one for writing. @@ -249,7 +254,7 @@ class CopyTask(object): DEBUG = True # do not display messages when exporting to STDOUT unless --debug is set -self.printmsg = printmsg if self.fname is not None or direction == 'from' or DEBUG else None +self.printmsg = printmsg if self.fname is not None or direction == 'from' or DEBUG else swallowmsg self.options = self.parse_options(opts, direction) self.num_processes = self.options.copy['numprocesses'] - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.1' into trunk
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit b4d4cf716b9596120f565d0286cd7dfbbe0a84f1 Merge: 080ad4963c 70b95d8098 Author: Brandon Williams AuthorDate: Wed Mar 22 13:29:20 2023 -0500 Merge branch 'cassandra-4.1' into trunk CHANGES.txt| 1 + pylib/cqlshlib/copyutil.py | 7 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --cc CHANGES.txt index 00b5933aad,7c7290f133..be048ff248 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,130 -1,8 +1,131 @@@ +5.0 + * Add system_views.snapshots virtual table (CASSANDRA-18102) + * Update OpenHFT dependencies (chronicle-queue, chronicle-core, chronicle-bytes, chronicle-wire, chronicle-threads) (CASSANDRA-18049) + * Remove org.apache.cassandra.hadoop code (CASSANDRA-18323) + * Remove deprecated CQL functions dateOf and unixTimestampOf (CASSANDRA-18328) + * Remove DateTieredCompactionStrategy (CASSANDRA-18043) + * Add system_views.max_sstable_size and system_views.max_sstable_duration tables (CASSANDRA-18333) + * Extend implicit allow-filtering for virtual tables to clustering columns (CASSANDRA-18331) + * Upgrade maven-shade-plugin to 3.4.1 to fix shaded dtest JAR build (CASSANDRA-18136) + * Upgrade to Opcodes.ASM9 (CASSANDRA-17971) + * Add MaxSSTableSize and MaxSSTableDuration metrics and propagate them together with local read/write ratio to tablestats (CASSANDRA-18283) + * Add more logging around CompactionManager operations (CASSANDRA-18268) + * Reduce memory allocations of calls to ByteBufer.duplicate() made in org.apache.cassandra.transport.CBUtil#writeValue (CASSANDRA-18212) + * CEP-17: SSTable API (CASSANDRA-17056) + * Gossip stateMapOrdering does not have correct ordering when both EndpointState are in the bootstrapping set (CASSANDRA-18292) + * Snapshot only sstables containing mismatching ranges on preview repair mismatch (CASSANDRA-17561) + * More accurate skipping of sstables in read path (CASSANDRA-18134) + * Prepare for JDK17 experimental support (CASSANDRA-18179, CASSANDRA-18258) + * Remove Scripted UDFs internals; hooks to be added later in CASSANDRA-17281 (CASSANDRA-18252) + * Update JNA to 5.13.0 (CASSANDRA-18050) + * Make virtual tables decide if they implicitly enable ALLOW FILTERING (CASSANDRA-18238) + * Add row, tombstone, and sstable count to nodetool profileload (CASSANDRA-18022) + * Coordinator level metrics for read response and mutation row and column counts (CASSANDRA-18155) + * Add CQL functions for dynamic data masking (CASSANDRA-17941) + * Print friendly error when nodetool attempts to connect to uninitialized server (CASSANDRA-11537) + * Use G1GC by default, and update default G1GC settings (CASSANDRA-18027) + * SimpleSeedProvider can resolve multiple IP addresses per DNS record (CASSANDRA-14361) + * Remove mocking in InternalNodeProbe spying on StorageServiceMBean (CASSANDRA-18152) + * Add compaction_properties column to system.compaction_history table and nodetool compactionhistory command (CASSANDRA-18061) + * Remove ProtocolVersion entirely from the CollectionSerializer ecosystem (CASSANDRA-18114) + * Fix serialization error in new getsstables --show-levels option (CASSANDRA-18140) + * Use checked casts when reading vints as ints (CASSANDRA-18099) + * Add Mutation Serialization Caching (CASSANDRA-17998) + * Only reload compaction strategies if disk boundaries change (CASSANDRA-17874) + * CEP-10: Simulator Java11 Support (CASSANDRA-17178) + * Set the major compaction type correctly for compactionstats (CASSANDRA-18055) + * Print exception message without stacktrace when nodetool commands fail on probe.getOwnershipWithPort() (CASSANDRA-18079) + * Add option to print level in nodetool getsstables output (CASSANDRA-18023) + * Implement a guardrail for not having zero default_time_to_live on tables with TWCS (CASSANDRA-18042) + * Add CQL scalar functions for collection aggregation (CASSANDRA-18060) + * Make cassandra.replayList property for CommitLogReplayer possible to react on keyspaces only (CASSANDRA-18044) + * Add Mathematical functions (CASSANDRA-17221) + * Make incremental backup configurable per table (CASSANDRA-15402) + * Change shebangs of Python scripts to resolve Python 3 from env command (CASSANDRA-17832) + * Add reasons to guardrail messages and consider guardrails in the error message for needed ALLOW FILTERING (CASSANDRA-17967) + * Add support for CQL functions on collections, tuples and UDTs (CASSANDRA-17811) + * Add flag to exclude nodes from local DC when running nodetool rebuild (CASSANDRA-17870) + * Adding endpoint verification option to client_encryption_options (CASSANDRA-18034) + * Replace 'wcwidth.py' with pypi module (CASSANDRA-17287) + * Add nodetool forcecompact to remove tombstoned or ttl'd data ignoring GC grace for given table and partition keys
[cassandra] branch trunk updated (080ad4963c -> b4d4cf716b)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from 080ad4963c Merge branch 'cassandra-4.1' into trunk new 70b95d8098 Restore COPY ... TO STDOUT behavior in cqlsh new b4d4cf716b Merge branch 'cassandra-4.1' into trunk The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 1 + pylib/cqlshlib/copyutil.py | 7 ++- 2 files changed, 7 insertions(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14667) Upgrade Dropwizard Metrics to 4.x
[ https://issues.apache.org/jira/browse/CASSANDRA-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703740#comment-17703740 ] Stefan Miklosovic commented on CASSANDRA-14667: --- I am trying to run a build here https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2380/ > Upgrade Dropwizard Metrics to 4.x > - > > Key: CASSANDRA-14667 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14667 > Project: Cassandra > Issue Type: Task > Components: Observability/Metrics >Reporter: Stig Rohde Døssing >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > Cassandra currently uses Metrics 3.1.5. Version 4.0.0 added some fixes for > Java 9 compatibility. It would be good to upgrade the Metrics library as part > of the version of Cassandra that adds Java 9 compatibility > (https://issues.apache.org/jira/browse/CASSANDRA-9608). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18356) Cassandra Debian Repository is not available and will be redirected to landing.jfrog.com
[ https://issues.apache.org/jira/browse/CASSANDRA-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18356: -- Resolution: Fixed Status: Resolved (was: Triage Needed) > Cassandra Debian Repository is not available and will be redirected to > landing.jfrog.com > > > Key: CASSANDRA-18356 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18356 > Project: Cassandra > Issue Type: Task > Components: Packaging >Reporter: Zoltan Lanyi >Priority: High > > Hi, > Debian Repo ist not available and redirected to landing.jfrog.com > Time flies when you’re having fun. > Your 14-day trial may be over, but you have options! > Could you pls fix that? > Thanks in advance > Zoltan -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18356) Cassandra Debian Repository is not available and will be redirected to landing.jfrog.com
[ https://issues.apache.org/jira/browse/CASSANDRA-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703735#comment-17703735 ] Stefan Miklosovic commented on CASSANDRA-18356: --- [~zlanyi] it works again. I am closing this ticket. > Cassandra Debian Repository is not available and will be redirected to > landing.jfrog.com > > > Key: CASSANDRA-18356 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18356 > Project: Cassandra > Issue Type: Task > Components: Packaging >Reporter: Zoltan Lanyi >Priority: High > > Hi, > Debian Repo ist not available and redirected to landing.jfrog.com > Time flies when you’re having fun. > Your 14-day trial may be over, but you have options! > Could you pls fix that? > Thanks in advance > Zoltan -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18357) Make nodetool describecluster print all configuration parameters of topology strategies
[
https://issues.apache.org/jira/browse/CASSANDRA-18357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic updated CASSANDRA-18357:
--
Description:
If there is a custom implementation of topology strategy, that strategy can
accept more options, not only "class" and "replication factors for datacenters".
I can have a replication strategy like this:
{code}
CREATE KEYSPACE ks WITH replication = {'class': 'CustomTopologyStrategy',
'datacenter1': '1', 'some_other_option': 'myoptionvalue'};
{code}
There is nothing which prevents users to put whatever options they want into a
strategy as it is a map. Currently, we treat all options except "class" as
names of datacenters and the current code is pretty much opinionated about that
(KeyspaceParams class).
However, when I create a keyspace like this:
{code}
CREATE KEYSPACE ks WITH replication = {'class': 'CustomTopologyStrategy',
'datacenter1': '1'};
{code}
nodetool describecluster command prints this:
{code}
Keyspaces:
system_schema -> Replication class: LocalStrategy {}
system -> Replication class: LocalStrategy {}
test -> Replication class: SimpleStrategy {replication_factor=1}
system_auth -> Replication class: SimpleStrategy {replication_factor=1}
system_distributed -> Replication class: SimpleStrategy
{replication_factor=3}
system_traces -> Replication class: SimpleStrategy
{replication_factor=2}
testks -> Replication class: CustomTopologyStrategy {datacenter1=1}
{code}
But it should print (or whatever the default is for some_other_option)
{code}
testks -> Replication class: CustomTopologyStrategy {datacenter1=1,
some_other_option=somedefaultvalue}
{code}
The reason this is happening is that params are saved to
system_schema.keyspaces into "replication" column and if I do not specify all
parameters upon keyspace creation, they will not be persisted so describing it
via nodetool will print only that.
I want to see all options, even I have not set them explicitly in CQL CREATE
KEYSPACE ...
Another option would be to modify CQL like this:
{code}
CREATE KEYSPACE ks WITH replication = {'class': 'CustomTopologyStrategy',
'datacenter1': '1'} AND options = {'some_other_option': 'myoptionvalue'}
{code}
I would start with simply adding other options to that output. We can still
modify it later to have "AND options ..." in CQL, it is OK to expand CQL like
that if we decide. This ticket does not prevent that. Adding of "options" is
more complicated. We would need to have another column for that in
system_schema.keyspaces and (Java) drivers would need to be accommodated too.
Too much work ...
PR here: https://github.com/apache/cassandra/pull/2239/files
was:
If there is a custom implementation of topology strategy, that strategy can
accept more options, not only "class" and "replication factors for datacenters".
I can have a replication strategy like this:
{code}
CREATE KEYSPACE ks WITH replication = {'class': 'CustomTopologyStrategy',
'datacenter1': '1', 'some_other_option': 'myoptionvalue'};
{code}
There is nothing which prevents users to put whatever options they want into a
strategy as it is a map. Currently, we treat all options except "class" as
names of datacenters and the current code is pretty much opinionated about that
(KeyspaceParams class).
However, when I create a keyspace like this:
{code}
CREATE KEYSPACE ks WITH replication = {'class': 'CustomTopologyStrategy',
'datacenter1': '1'};
{code}
nodetool describecluster command prints this:
{code}
Keyspaces:
system_schema -> Replication class: LocalStrategy {}
system -> Replication class: LocalStrategy {}
test -> Replication class: SimpleStrategy {replication_factor=1}
system_auth -> Replication class: SimpleStrategy {replication_factor=1}
system_distributed -> Replication class: SimpleStrategy
{replication_factor=3}
system_traces -> Replication class: SimpleStrategy
{replication_factor=2}
testks -> Replication class: CustomTopologyStrategy {datacenter1=1}
{code}
But it should print:
{code}
testks -> Replication class: CustomTopologyStrategy {datacenter1=1,
some_other_option=myoptionvalue}
{code}
The reason this is happening is that params are saved to
system_schema.keyspaces into "replication" column and if I do not specify all
parameters upon keyspace creation, they will not be persisted so describing it
via nodetool will print only that.
I want to see all options, even I have not set them explicitly in CQL CREATE
KEYSPACE ...
Another option would be to modify CQL like this:
{code}
CREATE KEYSPACE ks WITH replication = {'class': 'CustomTopologyStrategy',
'datacenter1': '1'} AND options = {'some_other_option': 'myoptionvalue'}
{code}
I would start with simply adding other options to that output. We can still
modify it later to have "AND options ..."
[jira] [Commented] (CASSANDRA-18357) Make nodetool describecluster print all configuration parameters of topology strategies
[
https://issues.apache.org/jira/browse/CASSANDRA-18357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703734#comment-17703734
]
Stefan Miklosovic commented on CASSANDRA-18357:
---
[~aleksey] what do you think? PR is at the bottom of the description.
> Make nodetool describecluster print all configuration parameters of topology
> strategies
> ---
>
> Key: CASSANDRA-18357
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18357
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Stefan Miklosovic
>Assignee: Stefan Miklosovic
>Priority: Normal
> Time Spent: 10m
> Remaining Estimate: 0h
>
> If there is a custom implementation of topology strategy, that strategy can
> accept more options, not only "class" and "replication factors for
> datacenters".
> I can have a replication strategy like this:
> {code}
> CREATE KEYSPACE ks WITH replication = {'class': 'CustomTopologyStrategy',
> 'datacenter1': '1', 'some_other_option': 'myoptionvalue'};
> {code}
> There is nothing which prevents users to put whatever options they want into
> a strategy as it is a map. Currently, we treat all options except "class" as
> names of datacenters and the current code is pretty much opinionated about
> that (KeyspaceParams class).
> However, when I create a keyspace like this:
> {code}
> CREATE KEYSPACE ks WITH replication = {'class': 'CustomTopologyStrategy',
> 'datacenter1': '1'};
> {code}
> nodetool describecluster command prints this:
> {code}
> Keyspaces:
> system_schema -> Replication class: LocalStrategy {}
> system -> Replication class: LocalStrategy {}
> test -> Replication class: SimpleStrategy {replication_factor=1}
> system_auth -> Replication class: SimpleStrategy
> {replication_factor=1}
> system_distributed -> Replication class: SimpleStrategy
> {replication_factor=3}
> system_traces -> Replication class: SimpleStrategy
> {replication_factor=2}
> testks -> Replication class: CustomTopologyStrategy {datacenter1=1}
> {code}
> But it should print:
> {code}
> testks -> Replication class: CustomTopologyStrategy {datacenter1=1,
> some_other_option=myoptionvalue}
> {code}
> The reason this is happening is that params are saved to
> system_schema.keyspaces into "replication" column and if I do not specify all
> parameters upon keyspace creation, they will not be persisted so describing
> it via nodetool will print only that.
> I want to see all options, even I have not set them explicitly in CQL CREATE
> KEYSPACE ...
> Another option would be to modify CQL like this:
> {code}
> CREATE KEYSPACE ks WITH replication = {'class': 'CustomTopologyStrategy',
> 'datacenter1': '1'} AND options = {'some_other_option': 'myoptionvalue'}
> {code}
> I would start with simply adding other options to that output. We can still
> modify it later to have "AND options ..." in CQL, it is OK to expand CQL like
> that if we decide. This ticket does not prevent that. Adding of "options" is
> more complicated. We would need to have another column for that in
> system_schema.keyspaces and (Java) drivers would need to be accommodated too.
> Too much work ...
> PR here: https://github.com/apache/cassandra/pull/2239/files
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18357) Make nodetool describecluster print all configuration parameters of topology strategies
[
https://issues.apache.org/jira/browse/CASSANDRA-18357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic updated CASSANDRA-18357:
--
Description:
If there is a custom implementation of topology strategy, that strategy can
accept more options, not only "class" and "replication factors for datacenters".
I can have a replication strategy like this:
{code}
CREATE KEYSPACE ks WITH replication = {'class': 'CustomTopologyStrategy',
'datacenter1': '1', 'some_other_option': 'myoptionvalue'};
{code}
There is nothing which prevents users to put whatever options they want into a
strategy as it is a map. Currently, we treat all options except "class" as
names of datacenters and the current code is pretty much opinionated about that
(KeyspaceParams class).
However, when I create a keyspace like this:
{code}
CREATE KEYSPACE ks WITH replication = {'class': 'CustomTopologyStrategy',
'datacenter1': '1'};
{code}
nodetool describecluster command prints this:
{code}
Keyspaces:
system_schema -> Replication class: LocalStrategy {}
system -> Replication class: LocalStrategy {}
test -> Replication class: SimpleStrategy {replication_factor=1}
system_auth -> Replication class: SimpleStrategy {replication_factor=1}
system_distributed -> Replication class: SimpleStrategy
{replication_factor=3}
system_traces -> Replication class: SimpleStrategy
{replication_factor=2}
testks -> Replication class: CustomTopologyStrategy {datacenter1=1}
{code}
But it should print:
{code}
testks -> Replication class: CustomTopologyStrategy {datacenter1=1,
some_other_option=myoptionvalue}
{code}
The reason this is happening is that params are saved to
system_schema.keyspaces into "replication" column and if I do not specify all
parameters upon keyspace creation, they will not be persisted so describing it
via nodetool will print only that.
I want to see all options, even I have not set them explicitly in CQL CREATE
KEYSPACE ...
Another option would be to modify CQL like this:
{code}
CREATE KEYSPACE ks WITH replication = {'class': 'CustomTopologyStrategy',
'datacenter1': '1'} AND options = {'some_other_option': 'myoptionvalue'}
{code}
I would start with simply adding other options to that output. We can still
modify it later to have "AND options ..." in CQL, it is OK to expand CQL like
that if we decide. This ticket does not prevent that. Adding of "options" is
more complicated. We would need to have another column for that in
system_schema.keyspaces and (Java) drivers would need to be accommodated too.
Too much work ...
PR here: https://github.com/apache/cassandra/pull/2239/files
was:
If there is a custom implementation of topology strategy, that strategy can
accept more options, not only "class" and "replication factors for datacenters".
I can have a replication strategy like this:
{code}
CREATE KEYSPACE ks WITH replication = {'class': 'CustomTopologyStrategy',
'datacenter1': '1', 'some_other_option': 'myoptionvalue'};
{code}
There is nothing which prevents users to put whatever options they want into a
strategy as it is a map. Currently, we treat all options except "class" as
names of datacenters and the current code is pretty much opinionated about that
(KeyspaceParams class).
However, when I create a keyspace like this:
{code}
CREATE KEYSPACE ks WITH replication = {'class': 'CustomTopologyStrategy',
'datacenter1': '1'};
{code}
nodetool describecluster command prints this:
{code}
Keyspaces:
system_schema -> Replication class: LocalStrategy {}
system -> Replication class: LocalStrategy {}
test -> Replication class: SimpleStrategy {replication_factor=1}
system_auth -> Replication class: SimpleStrategy {replication_factor=1}
system_distributed -> Replication class: SimpleStrategy
{replication_factor=3}
system_traces -> Replication class: SimpleStrategy
{replication_factor=2}
testks -> Replication class: CustomTopologyStrategy {datacenter1=1}
{code}
But it should print:
{code}
testks -> Replication class: CustomTopologyStrategy {datacenter1=1,
some_other_option=myoptionvalue}
{code}
The reason this is happening is that params are saved to
system_schema.keyspaces into "replication" column and if I do not specify all
parameters upon keyspace creation, they will not be persisted so describing it
via nodetool will print only that.
I want to see all options, even I have not set them explicitly in CQL CREATE
KEYSPACE ...
Another option would be to modify CQL like this:
{code}
CREATE KEYSPACE ks WITH replication = {'class': 'CustomTopologyStrategy',
'datacenter1': '1'} AND options = {'some_other_option': 'myoptionvalue'}
{code}
I would start with simply adding other options to that output. We can still
modify it later to have "AND options ..." in CQL, it is OK to expand CQL like
that if we
[jira] [Updated] (CASSANDRA-18357) Make nodetool describecluster print all configuration parameters of topology strategies
[
https://issues.apache.org/jira/browse/CASSANDRA-18357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic updated CASSANDRA-18357:
--
Description:
If there is a custom implementation of topology strategy, that strategy can
accept more options, not only "class" and "replication factors for datacenters".
I can have a replication strategy like this:
{code}
CREATE KEYSPACE ks WITH replication = {'class': 'CustomTopologyStrategy',
'datacenter1': '1', 'some_other_option': 'myoptionvalue'};
{code}
There is nothing which prevents users to put whatever options they want into a
strategy as it is a map. Currently, we treat all options except "class" as
names of datacenters and the current code is pretty much opinionated about that
(KeyspaceParams class).
However, when I create a keyspace like this:
{code}
CREATE KEYSPACE ks WITH replication = {'class': 'CustomTopologyStrategy',
'datacenter1': '1'};
{code}
nodetool describecluster command prints this:
{code}
Keyspaces:
system_schema -> Replication class: LocalStrategy {}
system -> Replication class: LocalStrategy {}
test -> Replication class: SimpleStrategy {replication_factor=1}
system_auth -> Replication class: SimpleStrategy {replication_factor=1}
system_distributed -> Replication class: SimpleStrategy
{replication_factor=3}
system_traces -> Replication class: SimpleStrategy
{replication_factor=2}
testks -> Replication class: CustomTopologyStrategy {datacenter1=1}
{code}
But it should print:
{code}
testks -> Replication class: CustomTopologyStrategy {datacenter1=1,
some_other_option=myoptionvalue}
{code}
The reason this is happening is that params are saved to
system_schema.keyspaces into "replication" column and if I do not specify all
parameters upon keyspace creation, they will not be persisted so describing it
via nodetool will print only that.
I want to see all options, even I have not set them explicitly in CQL CREATE
KEYSPACE ...
Another option would be to modify CQL like this:
{code}
CREATE KEYSPACE ks WITH replication = {'class': 'CustomTopologyStrategy',
'datacenter1': '1'} AND options = {'some_other_option': 'myoptionvalue'}
{code}
I would start with simply adding other options to that output. We can still
modify it later to have "AND options ..." in CQL, it is OK to expand CQL like
that if we decide. This ticket does not prevent that. Adding of "options" is
more complicated. We would need to have another column for that in
system_schema.keyspaces and (Java) drivers would need to be accommodated too.
Too much work ...
was:
If there is a custom implementation of topology strategy, that strategy can
accept more options, not only "class" and "replication factors for datacenters".
I can have a replication strategy like this:
{code}
CREATE KEYSPACE ks WITH replication = {'class': 'CustomTopologyStrategy',
'datacenter1': '1', 'some_other_option': 'myoptionvalue'};
{code}
There is nothing which prevents users to put whatever options they want into a
strategy as it is a map. Currently, we treat all options except "class" as
names of datacenters and the current code is pretty much opinionated about that
(KeyspaceParams class).
nodetool describecluster command prints this:
{code}
Keyspaces:
system_schema -> Replication class: LocalStrategy {}
system -> Replication class: LocalStrategy {}
test -> Replication class: SimpleStrategy {replication_factor=1}
system_auth -> Replication class: SimpleStrategy {replication_factor=1}
system_distributed -> Replication class: SimpleStrategy
{replication_factor=3}
system_traces -> Replication class: SimpleStrategy
{replication_factor=2}
testks -> Replication class: CustomTopologyStrategy {datacenter1=1}
{code}
But it should print:
{code}
testks -> Replication class: CustomTopologyStrategy {datacenter1=1,
some_other_option=myoptionvalue}
{code}
Another option would be to modify CQL like this:
{code}
CREATE KEYSPACE ks WITH replication = {'class': 'CustomTopologyStrategy',
'datacenter1': '1'} AND options = {'some_other_option': 'myoptionvalue'}
{code}
I would start with simply adding other options to that output. We can still
modify it later to have "AND options ..." in CQL, it is OK to expand CQL like
that if we decide. This ticket does not prevent that.
> Make nodetool describecluster print all configuration parameters of topology
> strategies
> ---
>
> Key: CASSANDRA-18357
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18357
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Stefan Miklosovic
>Assignee: Stefan Miklosovic
>Priority: Normal
>
> If there is a custom implementation of
[jira] [Commented] (CASSANDRA-18353) Cqlsh command "COPY … TO STDOUT" fails with "… object is not callable"
[
https://issues.apache.org/jira/browse/CASSANDRA-18353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703732#comment-17703732
]
Andres de la Peña commented on CASSANDRA-18353:
---
The changes look good to me.
It seems that some runners on some cqlsh_dtests jobs have failed, but none of
the failed runners contains the tests for COPY. The tests for COPY seem to have
succeeded when looking into the artifacts.
> Cqlsh command "COPY … TO STDOUT" fails with "… object is not callable"
> --
>
> Key: CASSANDRA-18353
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18353
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Gustav Broberg
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.1.x, 5.x
>
>
> Since 4.1.0, cqlsh fails on COPY commands with standard output as target.
> Steps to reproduce:
> {noformat}
> $> docker run -d --name cassandra --rm cassandra:4.1.1
> $> docker exec cassandra cqlsh -e 'COPY system.local(cluster_name) TO STDOUT'
> :1:'NoneType' object is not callable
> {noformat}
> Possibly a regression introduced by this commit
> [6341319|https://github.com/apache/cassandra/commit/634131961af9c1d88b34797c1c45000f71a76dae#diff-584645e6e932edd7a17f03c79ae87b1f1f8ed54919a31ce8785af156b89c0b76L260].
> Also, it looks like it has happened before: CASSANDRA-12497
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18353) Cqlsh command "COPY … TO STDOUT" fails with "… object is not callable"
[
https://issues.apache.org/jira/browse/CASSANDRA-18353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-18353:
--
Reviewers: Andres de la Peña, Andres de la Peña (was: Andres de la Peña)
Andres de la Peña, Andres de la Peña (was: Andres de la Peña)
Status: Review In Progress (was: Patch Available)
> Cqlsh command "COPY … TO STDOUT" fails with "… object is not callable"
> --
>
> Key: CASSANDRA-18353
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18353
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Gustav Broberg
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.1.x, 5.x
>
>
> Since 4.1.0, cqlsh fails on COPY commands with standard output as target.
> Steps to reproduce:
> {noformat}
> $> docker run -d --name cassandra --rm cassandra:4.1.1
> $> docker exec cassandra cqlsh -e 'COPY system.local(cluster_name) TO STDOUT'
> :1:'NoneType' object is not callable
> {noformat}
> Possibly a regression introduced by this commit
> [6341319|https://github.com/apache/cassandra/commit/634131961af9c1d88b34797c1c45000f71a76dae#diff-584645e6e932edd7a17f03c79ae87b1f1f8ed54919a31ce8785af156b89c0b76L260].
> Also, it looks like it has happened before: CASSANDRA-12497
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18353) Cqlsh command "COPY … TO STDOUT" fails with "… object is not callable"
[
https://issues.apache.org/jira/browse/CASSANDRA-18353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andres de la Peña updated CASSANDRA-18353:
--
Reviewers: Andres de la Peña
> Cqlsh command "COPY … TO STDOUT" fails with "… object is not callable"
> --
>
> Key: CASSANDRA-18353
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18353
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Gustav Broberg
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.1.x, 5.x
>
>
> Since 4.1.0, cqlsh fails on COPY commands with standard output as target.
> Steps to reproduce:
> {noformat}
> $> docker run -d --name cassandra --rm cassandra:4.1.1
> $> docker exec cassandra cqlsh -e 'COPY system.local(cluster_name) TO STDOUT'
> :1:'NoneType' object is not callable
> {noformat}
> Possibly a regression introduced by this commit
> [6341319|https://github.com/apache/cassandra/commit/634131961af9c1d88b34797c1c45000f71a76dae#diff-584645e6e932edd7a17f03c79ae87b1f1f8ed54919a31ce8785af156b89c0b76L260].
> Also, it looks like it has happened before: CASSANDRA-12497
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18354) Remove obsolete 'six' package reintroduced by a merge
[ https://issues.apache.org/jira/browse/CASSANDRA-18354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18354: - Fix Version/s: 5.0 4.1.2 (was: 5.x) (was: 4.1.x) Since Version: 4.1.1 Source Control Link: https://github.com/apache/cassandra/commit/a6f8dd10cd8b283339c08b50ed6357b213b89dc4 Resolution: Fixed Status: Resolved (was: Ready to Commit) Thanks, committed. > Remove obsolete 'six' package reintroduced by a merge > - > > Key: CASSANDRA-18354 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18354 > Project: Cassandra > Issue Type: Bug > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brandon Williams >Priority: Normal > Fix For: 5.0, 4.1.2 > > > The 4.1.x and trunk commits for CASSANDRA-18088 inadvertently re-introduced > 'six' and obsolete python 2.7 conditional checks and should be removed. > I.e., SaferScanner = Py36SaferScanner if six.PY3 else Py2SaferScanner – but > there is no Py2SaferScanner anymore. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18354) Remove obsolete 'six' package reintroduced by a merge
[ https://issues.apache.org/jira/browse/CASSANDRA-18354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18354: - Status: Ready to Commit (was: Review In Progress) > Remove obsolete 'six' package reintroduced by a merge > - > > Key: CASSANDRA-18354 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18354 > Project: Cassandra > Issue Type: Bug > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.1.x, 5.x > > > The 4.1.x and trunk commits for CASSANDRA-18088 inadvertently re-introduced > 'six' and obsolete python 2.7 conditional checks and should be removed. > I.e., SaferScanner = Py36SaferScanner if six.PY3 else Py2SaferScanner – but > there is no Py2SaferScanner anymore. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.1' into trunk
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 080ad4963c62f402cf3e3342971719917d89ac0b Merge: 4138dd697a a6f8dd10cd Author: Brandon Williams AuthorDate: Wed Mar 22 10:20:08 2023 -0500 Merge branch 'cassandra-4.1' into trunk CHANGES.txt| 4 ++-- pylib/cqlshlib/saferscanner.py | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --cc CHANGES.txt index 27a15725ca,27e7d998f2..00b5933aad --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,130 -1,7 +1,130 @@@ +5.0 + * Add system_views.snapshots virtual table (CASSANDRA-18102) + * Update OpenHFT dependencies (chronicle-queue, chronicle-core, chronicle-bytes, chronicle-wire, chronicle-threads) (CASSANDRA-18049) + * Remove org.apache.cassandra.hadoop code (CASSANDRA-18323) + * Remove deprecated CQL functions dateOf and unixTimestampOf (CASSANDRA-18328) + * Remove DateTieredCompactionStrategy (CASSANDRA-18043) + * Add system_views.max_sstable_size and system_views.max_sstable_duration tables (CASSANDRA-18333) + * Extend implicit allow-filtering for virtual tables to clustering columns (CASSANDRA-18331) + * Upgrade maven-shade-plugin to 3.4.1 to fix shaded dtest JAR build (CASSANDRA-18136) + * Upgrade to Opcodes.ASM9 (CASSANDRA-17971) + * Add MaxSSTableSize and MaxSSTableDuration metrics and propagate them together with local read/write ratio to tablestats (CASSANDRA-18283) + * Add more logging around CompactionManager operations (CASSANDRA-18268) + * Reduce memory allocations of calls to ByteBufer.duplicate() made in org.apache.cassandra.transport.CBUtil#writeValue (CASSANDRA-18212) + * CEP-17: SSTable API (CASSANDRA-17056) + * Gossip stateMapOrdering does not have correct ordering when both EndpointState are in the bootstrapping set (CASSANDRA-18292) + * Snapshot only sstables containing mismatching ranges on preview repair mismatch (CASSANDRA-17561) + * More accurate skipping of sstables in read path (CASSANDRA-18134) + * Prepare for JDK17 experimental support (CASSANDRA-18179, CASSANDRA-18258) + * Remove Scripted UDFs internals; hooks to be added later in CASSANDRA-17281 (CASSANDRA-18252) + * Update JNA to 5.13.0 (CASSANDRA-18050) + * Make virtual tables decide if they implicitly enable ALLOW FILTERING (CASSANDRA-18238) + * Add row, tombstone, and sstable count to nodetool profileload (CASSANDRA-18022) + * Coordinator level metrics for read response and mutation row and column counts (CASSANDRA-18155) + * Add CQL functions for dynamic data masking (CASSANDRA-17941) + * Print friendly error when nodetool attempts to connect to uninitialized server (CASSANDRA-11537) + * Use G1GC by default, and update default G1GC settings (CASSANDRA-18027) + * SimpleSeedProvider can resolve multiple IP addresses per DNS record (CASSANDRA-14361) + * Remove mocking in InternalNodeProbe spying on StorageServiceMBean (CASSANDRA-18152) + * Add compaction_properties column to system.compaction_history table and nodetool compactionhistory command (CASSANDRA-18061) + * Remove ProtocolVersion entirely from the CollectionSerializer ecosystem (CASSANDRA-18114) + * Fix serialization error in new getsstables --show-levels option (CASSANDRA-18140) + * Use checked casts when reading vints as ints (CASSANDRA-18099) + * Add Mutation Serialization Caching (CASSANDRA-17998) + * Only reload compaction strategies if disk boundaries change (CASSANDRA-17874) + * CEP-10: Simulator Java11 Support (CASSANDRA-17178) + * Set the major compaction type correctly for compactionstats (CASSANDRA-18055) + * Print exception message without stacktrace when nodetool commands fail on probe.getOwnershipWithPort() (CASSANDRA-18079) + * Add option to print level in nodetool getsstables output (CASSANDRA-18023) + * Implement a guardrail for not having zero default_time_to_live on tables with TWCS (CASSANDRA-18042) + * Add CQL scalar functions for collection aggregation (CASSANDRA-18060) + * Make cassandra.replayList property for CommitLogReplayer possible to react on keyspaces only (CASSANDRA-18044) + * Add Mathematical functions (CASSANDRA-17221) + * Make incremental backup configurable per table (CASSANDRA-15402) + * Change shebangs of Python scripts to resolve Python 3 from env command (CASSANDRA-17832) + * Add reasons to guardrail messages and consider guardrails in the error message for needed ALLOW FILTERING (CASSANDRA-17967) + * Add support for CQL functions on collections, tuples and UDTs (CASSANDRA-17811) + * Add flag to exclude nodes from local DC when running nodetool rebuild (CASSANDRA-17870) + * Adding endpoint verification option to client_encryption_options (CASSANDRA-18034) + * Replace 'wcwidth.py' with pypi module (CASSANDRA-17287) + * Add nodetool forcecompact to remove tombstoned or ttl'd data ignoring GC grace for given table and partition keys
[cassandra] branch cassandra-4.1 updated: Remove six and Py2SaferScanner merge cruft
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a commit to branch cassandra-4.1 in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/cassandra-4.1 by this push: new a6f8dd10cd Remove six and Py2SaferScanner merge cruft a6f8dd10cd is described below commit a6f8dd10cd8b283339c08b50ed6357b213b89dc4 Author: Brandon Williams AuthorDate: Wed Mar 22 06:24:05 2023 -0500 Remove six and Py2SaferScanner merge cruft Patch by brandonwilliams; reviewed by smiklosovic for CASSANDRA-18354 --- CHANGES.txt| 1 + pylib/cqlshlib/saferscanner.py | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGES.txt b/CHANGES.txt index aa3f9a9a4f..27e7d998f2 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,4 +1,5 @@ 4.1.2 + * Remove six and Py2SaferScanner merge cruft (CASSANDRA-18354) 4.1.1 diff --git a/pylib/cqlshlib/saferscanner.py b/pylib/cqlshlib/saferscanner.py index 5afd8ef172..2c2b6100d9 100644 --- a/pylib/cqlshlib/saferscanner.py +++ b/pylib/cqlshlib/saferscanner.py @@ -19,7 +19,6 @@ # regex in-pattern flags. Any of those can break correct operation of Scanner. import re -import six try: from sre_constants import BRANCH, SUBPATTERN, GROUPREF, GROUPREF_IGNORE, GROUPREF_EXISTS except ImportError: @@ -101,7 +100,7 @@ class Py311SaferScanner(SaferScannerBase): self.scanner = re._compiler.compile(p) -SaferScanner = Py36SaferScanner if six.PY3 else Py2SaferScanner +SaferScanner = Py36SaferScanner if version_info >= (3, 11): SaferScanner = Py311SaferScanner elif version_info >= (3, 8): - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (4138dd697a -> 080ad4963c)
This is an automated email from the ASF dual-hosted git repository. brandonwilliams pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from 4138dd697a Fix trunk CHANGES.txt new a6f8dd10cd Remove six and Py2SaferScanner merge cruft new 080ad4963c Merge branch 'cassandra-4.1' into trunk The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt| 4 ++-- pylib/cqlshlib/saferscanner.py | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18304) hinted_handoff_enabled=false is not honored
[
https://issues.apache.org/jira/browse/CASSANDRA-18304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksey Yeschenko updated CASSANDRA-18304:
--
Reviewers: Aleksey Yeschenko, Stefan Miklosovic, Aleksey Yeschenko (was:
Aleksey Yeschenko, Stefan Miklosovic)
Aleksey Yeschenko, Stefan Miklosovic, Aleksey Yeschenko (was:
Aleksey Yeschenko, Stefan Miklosovic)
Status: Review In Progress (was: Patch Available)
> hinted_handoff_enabled=false is not honored
> ---
>
> Key: CASSANDRA-18304
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18304
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Hints
>Reporter: Paulo Motta
>Assignee: Paulo Motta
>Priority: Normal
> Fix For: 4.1.x, 5.x
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> I've had some dtests with disabled hints failing.
> After investigation it seems that CASSANDRA-17164 moved hint submission on
> timeout from
> [RequestCallbacks.onExpired|https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b#diff-b73c13ea8cae91a215495917fe5e90d55c9f4a283f9e053110992bc9a60004b8L176]
> to
> [AbstractWriteResponseHandler.onFailure|https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b#diff-3b202de0d077638bede7bf4076a15eb4d483b717f955f11e743efb8d27c6eb1dR285],
> but it no longer checks if {{CallbackInfo.shouldHint}} which checks for
> {{StorageProxy.shouldHint}} which ultimately checks if
> {{{}hinted_handoff_enabled=true{}}}.
> This could cause some tests which expect hints to be disabled to fail
> intermittently.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18304) hinted_handoff_enabled=false is not honored
[
https://issues.apache.org/jira/browse/CASSANDRA-18304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703703#comment-17703703
]
Aleksey Yeschenko commented on CASSANDRA-18304:
---
+1. I can't say that the code around hint submission is currently correct, but
the changes are strictly an improvement, and don't make anything worse.
> hinted_handoff_enabled=false is not honored
> ---
>
> Key: CASSANDRA-18304
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18304
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Hints
>Reporter: Paulo Motta
>Assignee: Paulo Motta
>Priority: Normal
> Fix For: 4.1.x, 5.x
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> I've had some dtests with disabled hints failing.
> After investigation it seems that CASSANDRA-17164 moved hint submission on
> timeout from
> [RequestCallbacks.onExpired|https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b#diff-b73c13ea8cae91a215495917fe5e90d55c9f4a283f9e053110992bc9a60004b8L176]
> to
> [AbstractWriteResponseHandler.onFailure|https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b#diff-3b202de0d077638bede7bf4076a15eb4d483b717f955f11e743efb8d27c6eb1dR285],
> but it no longer checks if {{CallbackInfo.shouldHint}} which checks for
> {{StorageProxy.shouldHint}} which ultimately checks if
> {{{}hinted_handoff_enabled=true{}}}.
> This could cause some tests which expect hints to be disabled to fail
> intermittently.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18304) hinted_handoff_enabled=false is not honored
[
https://issues.apache.org/jira/browse/CASSANDRA-18304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksey Yeschenko updated CASSANDRA-18304:
--
Status: Ready to Commit (was: Review In Progress)
> hinted_handoff_enabled=false is not honored
> ---
>
> Key: CASSANDRA-18304
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18304
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Hints
>Reporter: Paulo Motta
>Assignee: Paulo Motta
>Priority: Normal
> Fix For: 4.1.x, 5.x
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> I've had some dtests with disabled hints failing.
> After investigation it seems that CASSANDRA-17164 moved hint submission on
> timeout from
> [RequestCallbacks.onExpired|https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b#diff-b73c13ea8cae91a215495917fe5e90d55c9f4a283f9e053110992bc9a60004b8L176]
> to
> [AbstractWriteResponseHandler.onFailure|https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b#diff-3b202de0d077638bede7bf4076a15eb4d483b717f955f11e743efb8d27c6eb1dR285],
> but it no longer checks if {{CallbackInfo.shouldHint}} which checks for
> {{StorageProxy.shouldHint}} which ultimately checks if
> {{{}hinted_handoff_enabled=true{}}}.
> This could cause some tests which expect hints to be disabled to fail
> intermittently.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: Fix trunk CHANGES.txt
This is an automated email from the ASF dual-hosted git repository. aleksey pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/trunk by this push: new 4138dd697a Fix trunk CHANGES.txt 4138dd697a is described below commit 4138dd697a1c6f3430b99f8b3feb4386d31f90ac Author: Aleksey Yeschenko AuthorDate: Wed Mar 22 14:49:55 2023 + Fix trunk CHANGES.txt --- CHANGES.txt | 56 +--- 1 file changed, 33 insertions(+), 23 deletions(-) diff --git a/CHANGES.txt b/CHANGES.txt index 6d234a7055..27a15725ca 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -121,9 +121,13 @@ * Add new CQL function maxWritetime (CASSANDRA-17425) * Add guardrail for ALTER TABLE ADD / DROP / REMOVE column operations (CASSANDRA-17495) * Rename DisableFlag class to EnableFlag on guardrails (CASSANDRA-17544) -Merged from 4.1: + +4.1.2 + + +4.1.1 * Deprecate org.apache.cassandra.hadoop code (CASSANDRA-16984) - * Fix too early schema version change in system local table (CASSANDRA-18291) + * Fix too early schema version change in sysem local table (CASSANDRA-18291) * Fix copying of JAR of a trigger to temporary file (CASSANDRA-18264) * Fix possible NoSuchFileException when removing a snapshot (CASSANDRA-18211) * PaxosPrepare may add instances to the Electorate that are not in gossip (CASSANDRA-18194) @@ -166,13 +170,39 @@ Merged from 3.0: 4.1.0 * Fix ContentionStrategy backoff and Clock.waitUntil (CASSANDRA-18086) +Merged from 4.0: +Merged from 3.11: +Merged from 3.0: + * Fix incorrect resource name in LIST PERMISSION output (CASSANDRA-17848) + * Suppress CVE-2022-41854 and similar (CASSANDRA-18083) + + +4.1-rc1 * Avoid schema mismatch problems on memtable API misconfiguration (CASSANDRA-18040) * Start Paxos auto repair in CassandraDaemon (CASSANDRA-18029) - * Fix error message about type hints (CASSANDRA-17915) * Restore streaming_keep_alive_period on the netty control streaming channel (CASSANDRA-17768) * Move Schema.FORCE_LOAD_KEYSPACES and Schema.FORCE_LOAD_KEYSPACES_PROP to CassandraRelevantProps (CASSANDRA-17783) * Add --resolve-ip option to nodetool gossipinfo (CASSANDRA-17934) * Allow pre-V5 global limit on bytes in flight to revert to zero asynchronously in RateLimitingTest (CASSANDRA-17927) +Merged from 4.0: + * Harden parsing of boolean values in CQL in PropertyDefinitions (CASSANDRA-17878) + * Fix error message about type hints (CASSANDRA-17915) + * Fix possible race condition on repair snapshots (CASSANDRA-17955) + * Fix ASM bytecode version inconsistency (CASSANDRA-17873) + * Remove empty cq4 files in log directory to not fail the startup of BinLog (CASSANDRA-17933) + * Fix multiple BufferPool bugs (CASSANDRA-16681) + * Fix StorageService.getNativeaddress handling of IPv6 addresses (CASSANDRA-17945) +Merged from 3.11: + * Fix Splitter sometimes creating more splits than requested (CASSANDRA-18013) + * Suppress CVE-2022-42003 and CVE-2022-42004 (CASSANDRA-17966) + * Make LongBufferPoolTest insensitive to timing (CASSANDRA-16681) +Merged from 3.0: + * Fix running Ant rat targets without git (CASSANDRA-17974) + * Harden JMX by resolving beanshooter issues (CASSANDRA-17921) + * Suppress CVE-2019-2684 (CASSANDRA-17965) + * Fix auto-completing "WITH" when creating a materialized view (CASSANDRA-17879) + +4.1-beta1 * We should not emit deprecation warning on startup for `key_cache_save_period`, `row_cache_save_period`, `counter_cache_save_period` (CASSANDRA-17904) * upsert with adder support is not consistent with numbers and strings in LWT (CASSANDRA-17857) * Fix race and return after failing connections (CASSANDRA-17618) @@ -202,13 +232,6 @@ Merged from 3.0: * Revert removal of withBufferSizeInMB(int size) in CQLSSTableWriter.Builder class and deprecate it in favor of withBufferSizeInMiB(int size) (CASSANDRA-17675) * Remove expired snapshots of dropped tables after restart (CASSANDRA-17619) Merged from 4.0: - * Restore internode custom tracing on 4.0's new messaging system (CASSANDRA-17981) - * Harden parsing of boolean values in CQL in PropertyDefinitions (CASSANDRA-17878) - * Fix possible race condition on repair snapshots (CASSANDRA-17955) - * Fix ASM bytecode version inconsistency (CASSANDRA-17873) - * Remove empty cq4 files in log directory to not fail the startup of BinLog (CASSANDRA-17933) - * Fix multiple BufferPool bugs (CASSANDRA-16681) - * Fix StorageService.getNativeaddress handling of IPv6 addresses (CASSANDRA-17945) * Mitigate direct buffer memory OOM on replacements (CASSANDRA-17895) * Fix repair failure on assertion if two peers have overlapping mismatching ranges (CASSANDRA-17900) * Better handle null state in Gossip schema migration to avoid NPE (CASSANDRA-17864) @@ -231,23 +254,11 @@ Merged from 4.0: * Ensure FileStreamTask cannot compromise shared channel proxy for system table when
[jira] [Updated] (CASSANDRA-18357) Make nodetool describecluster print all configuration parameters of topology strategies
[
https://issues.apache.org/jira/browse/CASSANDRA-18357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic updated CASSANDRA-18357:
--
Description:
If there is a custom implementation of topology strategy, that strategy can
accept more options, not only "class" and "replication factors for datacenters".
I can have a replication strategy like this:
{code}
CREATE KEYSPACE ks WITH replication = {'class': 'CustomTopologyStrategy',
'datacenter1': '1', 'some_other_option': 'myoptionvalue'};
{code}
There is nothing which prevents users to put whatever options they want into a
strategy as it is a map. Currently, we treat all options except "class" as
names of datacenters and the current code is pretty much opinionated about that
(KeyspaceParams class).
nodetool describecluster command prints this:
{code}
Keyspaces:
system_schema -> Replication class: LocalStrategy {}
system -> Replication class: LocalStrategy {}
test -> Replication class: SimpleStrategy {replication_factor=1}
system_auth -> Replication class: SimpleStrategy {replication_factor=1}
system_distributed -> Replication class: SimpleStrategy
{replication_factor=3}
system_traces -> Replication class: SimpleStrategy
{replication_factor=2}
testks -> Replication class: CustomTopologyStrategy {datacenter1=1}
{code}
But it should print:
{code}
testks -> Replication class: CustomTopologyStrategy {datacenter1=1,
some_other_option=myoptionvalue}
{code}
Another option would be to modify CQL like this:
{code}
CREATE KEYSPACE ks WITH replication = {'class': 'CustomTopologyStrategy',
'datacenter1': '1'} AND options = {'some_other_option': 'myoptionvalue'}
{code}
I would start with simply adding other options to that output. We can still
modify it later to have "AND options ..." in CQL, it is OK to expand CQL like
that if we decide. This ticket does not prevent that.
was:
If there is a custom implementation of topology strategy, that strategy can
accept more options, not only "class" and "replication factors for datacenters".
I can have a replication strategy like this:
{code}
CREATE KEYSPACE ks WITH replication = {'class': 'CustomTopologyStrategy',
'datacenter1': '1', 'some_other_option': 'myoptionvalue'};
{code}
There is nothing which prevents users to put whatever options they want into a
strategy as it is a map. Currently, we treat all options except "class" as
names of datacenters and the current code is pretty much opinionated about that
(KeyspaceParams class).
nodetool describecluster command prints this:
{code}
Keyspaces:
system_schema -> Replication class: LocalStrategy {}
system -> Replication class: LocalStrategy {}
test -> Replication class: SimpleStrategy {replication_factor=1}
system_auth -> Replication class: SimpleStrategy {replication_factor=1}
system_distributed -> Replication class: SimpleStrategy
{replication_factor=3}
system_traces -> Replication class: SimpleStrategy
{replication_factor=2}
testks -> Replication class: CustomTopologyStrategy {datacenter1=1}
{code}
But it should print:
{code}
testks -> Replication class: CustomTopologyStrategy {datacenter1=1,
some_other_option=myoptionvalue}
{code}
> Make nodetool describecluster print all configuration parameters of topology
> strategies
> ---
>
> Key: CASSANDRA-18357
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18357
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Stefan Miklosovic
>Assignee: Stefan Miklosovic
>Priority: Normal
>
> If there is a custom implementation of topology strategy, that strategy can
> accept more options, not only "class" and "replication factors for
> datacenters".
> I can have a replication strategy like this:
> {code}
> CREATE KEYSPACE ks WITH replication = {'class': 'CustomTopologyStrategy',
> 'datacenter1': '1', 'some_other_option': 'myoptionvalue'};
> {code}
> There is nothing which prevents users to put whatever options they want into
> a strategy as it is a map. Currently, we treat all options except "class" as
> names of datacenters and the current code is pretty much opinionated about
> that (KeyspaceParams class).
> nodetool describecluster command prints this:
> {code}
> Keyspaces:
> system_schema -> Replication class: LocalStrategy {}
> system -> Replication class: LocalStrategy {}
> test -> Replication class: SimpleStrategy {replication_factor=1}
> system_auth -> Replication class: SimpleStrategy
> {replication_factor=1}
> system_distributed -> Replication class: SimpleStrategy
> {replication_factor=3}
> system_traces -> Replication class: SimpleStrategy
>
[jira] [Commented] (CASSANDRA-18301) Let the user select the sstable version to write
[ https://issues.apache.org/jira/browse/CASSANDRA-18301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703689#comment-17703689 ] Berenguer Blasi commented on CASSANDRA-18301: - This ticket should probably also bring in the mechanics to be able to test a given feature in both pre and post upgrade scenarios whose behavior might differ. > Let the user select the sstable version to write > > > Key: CASSANDRA-18301 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18301 > Project: Cassandra > Issue Type: New Feature > Components: Local/Config, Local/SSTable >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18301) Let the user select the sstable version to write
[ https://issues.apache.org/jira/browse/CASSANDRA-18301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703684#comment-17703684 ] Michael Semb Wever commented on CASSANDRA-18301: Agree with using the version instead of the format. Not sold on the "downgradable_to_version" name… Downgrading may imply something different to many users compared to both - being able to still stream in mix-versioned clusters (ref CASSANDRA-8110 ), - being able to not continue with a rolling upgrade > Let the user select the sstable version to write > > > Key: CASSANDRA-18301 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18301 > Project: Cassandra > Issue Type: New Feature > Components: Local/Config, Local/SSTable >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18357) Make nodetool describecluster print all configuration parameters of topology strategies
Stefan Miklosovic created CASSANDRA-18357:
-
Summary: Make nodetool describecluster print all configuration
parameters of topology strategies
Key: CASSANDRA-18357
URL: https://issues.apache.org/jira/browse/CASSANDRA-18357
Project: Cassandra
Issue Type: Improvement
Reporter: Stefan Miklosovic
Assignee: Stefan Miklosovic
If there is a custom implementation of topology strategy, that strategy can
accept more options, not only "class" and "replication factors for datacenters".
I can have a replication strategy like this:
{code}
CREATE KEYSPACE ks WITH replication = {'class': 'CustomTopologyStrategy',
'datacenter1': '1', 'some_other_option': 'myoptionvalue'};
{code}
There is nothing which prevents users to put whatever options they want into a
strategy as it is a map. Currently, we treat all options except "class" as
names of datacenters and the current code is pretty much opinionated about that
(KeyspaceParams class).
nodetool describecluster command prints this:
{code}
Keyspaces:
system_schema -> Replication class: LocalStrategy {}
system -> Replication class: LocalStrategy {}
test -> Replication class: SimpleStrategy {replication_factor=1}
system_auth -> Replication class: SimpleStrategy {replication_factor=1}
system_distributed -> Replication class: SimpleStrategy
{replication_factor=3}
system_traces -> Replication class: SimpleStrategy
{replication_factor=2}
testks -> Replication class: CustomTopologyStrategy {datacenter1=1}
{code}
But it should print:
{code}
testks -> Replication class: CustomTopologyStrategy {datacenter1=1,
some_other_option=myoptionvalue}
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (9b51b3e32 -> 8ed70a8fd)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 9b51b3e32 generate docs for 8612e581 new 8ed70a8fd generate docs for 8612e581 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (9b51b3e32) \ N -- N -- N refs/heads/asf-staging (8ed70a8fd) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../4.2/cassandra/tools/nodetool/bootstrap.html| 4 +- .../doc/4.2/cassandra/tools/nodetool/import.html | 6 +-- .../doc/4.2/cassandra/tools/nodetool/nodetool.html | 4 +- .../4.2/cassandra/tools/nodetool/repair_admin.html | 41 +++-- .../trunk/cassandra/tools/nodetool/bootstrap.html | 4 +- .../doc/trunk/cassandra/tools/nodetool/import.html | 6 +-- .../trunk/cassandra/tools/nodetool/nodetool.html | 4 +- .../cassandra/tools/nodetool/repair_admin.html | 41 +++-- content/search-index.js| 2 +- site-ui/build/ui-bundle.zip| Bin 4796442 -> 4796442 bytes 10 files changed, 57 insertions(+), 55 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14667) Upgrade Dropwizard Metrics to 4.x
[ https://issues.apache.org/jira/browse/CASSANDRA-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov updated CASSANDRA-14667: Fix Version/s: 5.x > Upgrade Dropwizard Metrics to 4.x > - > > Key: CASSANDRA-14667 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14667 > Project: Cassandra > Issue Type: Task > Components: Observability/Metrics >Reporter: Stig Rohde Døssing >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > Cassandra currently uses Metrics 3.1.5. Version 4.0.0 added some fixes for > Java 9 compatibility. It would be good to upgrade the Metrics library as part > of the version of Cassandra that adds Java 9 compatibility > (https://issues.apache.org/jira/browse/CASSANDRA-9608). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17797) All system properties and environment variables should be accessed via the new CassandraRelevantProperties and CassandraRelevantEnv classes
[ https://issues.apache.org/jira/browse/CASSANDRA-17797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703671#comment-17703671 ] Stefan Miklosovic commented on CASSANDRA-17797: --- Based on the thread here (1), I want to review this again so we are sure all is still OK. It was a long time I reviewed it. (1) https://lists.apache.org/thread/jy0fdh2jjv4k3z13ww7ffbmqw1ytycrb > All system properties and environment variables should be accessed via the > new CassandraRelevantProperties and CassandraRelevantEnv classes > --- > > Key: CASSANDRA-17797 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17797 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Low > Fix For: 5.x > > Time Spent: 13h 50m > Remaining Estimate: 0h > > Follow up ticket for CASSANDRA-15876 - > "Always access system properties and environment variables via the new > CassandraRelevantProperties and CassandraRelevantEnv classes" > As part of that ticket we moved to the two new classes only > properties/variables that were currently listed in System Properties Virtual > Table. > We have to move to those classes the rest of the properties around the code > and start using those classes to access all of them. > +Additional information for newcomers:+ > You might want to start by getting acquainted with > CassandraRelevantProperties and CassandraRelevantEnv classes. Also, you might > want to check what changes were done and how the first batch was transferred > to this new framework as part of > [CASSANDRA-15876|https://github.com/apache/cassandra/commit/7694c1d191531ac152db55e83bc0db6864a5441e] > We are interested into the properties accessed currently through > getProperties around the code. > As part of CASSANDRA-15876 relevant unit tests were added > (CassandraRelevantPropertiesTest). To verify the new patch we need to ensure > that all tests Cassandra pass and also to think about potential update of the > mentioned test class. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17797) All system properties and environment variables should be accessed via the new CassandraRelevantProperties and CassandraRelevantEnv classes
[ https://issues.apache.org/jira/browse/CASSANDRA-17797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-17797: -- Status: Review In Progress (was: Needs Committer) > All system properties and environment variables should be accessed via the > new CassandraRelevantProperties and CassandraRelevantEnv classes > --- > > Key: CASSANDRA-17797 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17797 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Low > Fix For: 5.x > > Time Spent: 13h 50m > Remaining Estimate: 0h > > Follow up ticket for CASSANDRA-15876 - > "Always access system properties and environment variables via the new > CassandraRelevantProperties and CassandraRelevantEnv classes" > As part of that ticket we moved to the two new classes only > properties/variables that were currently listed in System Properties Virtual > Table. > We have to move to those classes the rest of the properties around the code > and start using those classes to access all of them. > +Additional information for newcomers:+ > You might want to start by getting acquainted with > CassandraRelevantProperties and CassandraRelevantEnv classes. Also, you might > want to check what changes were done and how the first batch was transferred > to this new framework as part of > [CASSANDRA-15876|https://github.com/apache/cassandra/commit/7694c1d191531ac152db55e83bc0db6864a5441e] > We are interested into the properties accessed currently through > getProperties around the code. > As part of CASSANDRA-15876 relevant unit tests were added > (CassandraRelevantPropertiesTest). To verify the new patch we need to ensure > that all tests Cassandra pass and also to think about potential update of the > mentioned test class. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18354) Remove obsolete 'six' package reintroduced by a merge
[ https://issues.apache.org/jira/browse/CASSANDRA-18354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703667#comment-17703667 ] Stefan Miklosovic commented on CASSANDRA-18354: --- +1 > Remove obsolete 'six' package reintroduced by a merge > - > > Key: CASSANDRA-18354 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18354 > Project: Cassandra > Issue Type: Bug > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.1.x, 5.x > > > The 4.1.x and trunk commits for CASSANDRA-18088 inadvertently re-introduced > 'six' and obsolete python 2.7 conditional checks and should be removed. > I.e., SaferScanner = Py36SaferScanner if six.PY3 else Py2SaferScanner – but > there is no Py2SaferScanner anymore. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18354) Remove obsolete 'six' package reintroduced by a merge
[ https://issues.apache.org/jira/browse/CASSANDRA-18354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18354: -- Reviewers: Stefan Miklosovic, Stefan Miklosovic Stefan Miklosovic, Stefan Miklosovic (was: Stefan Miklosovic) Status: Review In Progress (was: Patch Available) > Remove obsolete 'six' package reintroduced by a merge > - > > Key: CASSANDRA-18354 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18354 > Project: Cassandra > Issue Type: Bug > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.1.x, 5.x > > > The 4.1.x and trunk commits for CASSANDRA-18088 inadvertently re-introduced > 'six' and obsolete python 2.7 conditional checks and should be removed. > I.e., SaferScanner = Py36SaferScanner if six.PY3 else Py2SaferScanner – but > there is no Py2SaferScanner anymore. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18102) Add a virtual table to list snapshots
[
https://issues.apache.org/jira/browse/CASSANDRA-18102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Miklosovic updated CASSANDRA-18102:
--
Source Control Link:
https://github.com/apache/cassandra/commit/fc9efd6357fb4255174689b3c107b897254a7d2f
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> Add a virtual table to list snapshots
> -
>
> Key: CASSANDRA-18102
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18102
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/Virtual Tables, Local/Snapshots
>Reporter: Paulo Motta
>Assignee: maxwellguo
>Priority: Normal
> Fix For: 5.0
>
> Time Spent: 8h 40m
> Remaining Estimate: 0h
>
> It should be possible to query a node's snapshots via virtual tables.
> The table should expose the same fields/columns as the
> [TableSnapshot|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/service/snapshot/TableSnapshot.java]
> class.
> Something along these lines:
> {noformat}
> cqlsh> SELECT * FROM system_views.snapshots;
>
> tag | keyspace_name | table_name | table_id | is_ephemeral | created_at |
> expires_at | directories
> +---++---+--+---++
> 1670460346841 | system | compaction_info |
> 123e4567-e89b-12d3-a456-426614174000 | false | 2022-12-08T00:45:47.108Z |
> null |
> {'/var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/snapshots/1670460346841'}
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: Add virtual table system_views.snapshots
This is an automated email from the ASF dual-hosted git repository.
smiklosovic pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/trunk by this push:
new fc9efd6357 Add virtual table system_views.snapshots
fc9efd6357 is described below
commit fc9efd6357fb4255174689b3c107b897254a7d2f
Author: maxwellguo
AuthorDate: Thu Mar 9 11:18:14 2023 +0800
Add virtual table system_views.snapshots
patch by Maxwell Guo; reviewed by Stefan Miklosovic and Paulo Motta for
CASSANDRA-18102
Co-authored-by: Stefan Miklosovic
---
CHANGES.txt| 1 +
NEWS.txt | 1 +
.../cassandra/db/virtual/SnapshotsTable.java | 82
.../cassandra/db/virtual/SystemViewsKeyspace.java | 1 +
.../apache/cassandra/service/StorageService.java | 2 +-
.../cassandra/db/virtual/SnapshotsTableTest.java | 105 +
6 files changed, 191 insertions(+), 1 deletion(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index 1b6dcf3c5e..6d234a7055 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
5.0
+ * Add system_views.snapshots virtual table (CASSANDRA-18102)
* Update OpenHFT dependencies (chronicle-queue, chronicle-core,
chronicle-bytes, chronicle-wire, chronicle-threads) (CASSANDRA-18049)
* Remove org.apache.cassandra.hadoop code (CASSANDRA-18323)
* Remove deprecated CQL functions dateOf and unixTimestampOf (CASSANDRA-18328)
diff --git a/NEWS.txt b/NEWS.txt
index c1fe5427f2..48789e4bbe 100644
--- a/NEWS.txt
+++ b/NEWS.txt
@@ -131,6 +131,7 @@ New features
`maxTimestamp - minTimestamp`, effectively non-zero for SSTables
produced by TimeWindowCompactionStrategy.
- Added local read/write ratio to tablestats.
- Added system_views.max_sstable_size and
system_views.max_sstable_duration tables.
+- Added virtual table system_views.snapshots to see all snapshots from CQL
shell.
Upgrading
-
diff --git a/src/java/org/apache/cassandra/db/virtual/SnapshotsTable.java
b/src/java/org/apache/cassandra/db/virtual/SnapshotsTable.java
new file mode 100644
index 00..d3df293903
--- /dev/null
+++ b/src/java/org/apache/cassandra/db/virtual/SnapshotsTable.java
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.cassandra.db.virtual;
+
+import java.util.Date;
+
+import org.apache.cassandra.db.marshal.BooleanType;
+import org.apache.cassandra.db.marshal.LongType;
+import org.apache.cassandra.db.marshal.TimestampType;
+import org.apache.cassandra.db.marshal.UTF8Type;
+import org.apache.cassandra.dht.LocalPartitioner;
+import org.apache.cassandra.schema.TableMetadata;
+import org.apache.cassandra.service.StorageService;
+import org.apache.cassandra.service.snapshot.TableSnapshot;
+
+public class SnapshotsTable extends AbstractVirtualTable
+{
+private static final String NAME = "name";
+private static final String KEYSPACE_NAME = "keyspace_name";
+private static final String TABLE_NAME = "table_name";
+private static final String TRUE_SIZE = "true_size";
+private static final String SIZE_ON_DISK = "size_on_disk";
+private static final String CREATED_AT = "created_at";
+private static final String EXPIRES_AT = "expires_at";
+private static final String EPHEMERAL = "ephemeral";
+
+SnapshotsTable(String keyspace)
+{
+super(TableMetadata.builder(keyspace, "snapshots")
+ .comment("available snapshots")
+ .kind(TableMetadata.Kind.VIRTUAL)
+ .partitioner(new
LocalPartitioner(UTF8Type.instance))
+ .addPartitionKeyColumn(NAME, UTF8Type.instance)
+ .addClusteringColumn(KEYSPACE_NAME,
UTF8Type.instance)
+ .addClusteringColumn(TABLE_NAME, UTF8Type.instance)
+ .addRegularColumn(TRUE_SIZE, LongType.instance)
+ .addRegularColumn(SIZE_ON_DISK, LongType.instance)
+ .addRegularColumn(CREATED_AT,
TimestampType.instance)
+
[jira] [Commented] (CASSANDRA-18301) Let the user select the sstable version to write
[
https://issues.apache.org/jira/browse/CASSANDRA-18301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703651#comment-17703651
]
Andres de la Peña commented on CASSANDRA-18301:
---
I think that if we are going to use this to allow users to downgrade to a
previous major version, rather than a {{max_stable_version: nc}} yaml property
we could simply specify what Cassandra version we want to be able to downgrade
to.
The yaml property could look like:
{code:java}
# Minimum major Cassandra version it will be possible to directly downgrade to.
# If you stay downgradable to version 4.0 you won't be able to uses features a,
b, c...
downgradable_to_version: 4.0
{code}
Its documentation comment would say what features you are missing if you stay
on certain versions.
That way we wouldn’t bother users with sstable versions, which is an obscure
internal concept. Also, we can make more things than the sstable version depend
on that property. For example, the messaging version.
> Let the user select the sstable version to write
>
>
> Key: CASSANDRA-18301
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18301
> Project: Cassandra
> Issue Type: New Feature
> Components: Local/Config, Local/SSTable
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Normal
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18102) Add a virtual table to list snapshots
[
https://issues.apache.org/jira/browse/CASSANDRA-18102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703647#comment-17703647
]
Stefan Miklosovic commented on CASSANDRA-18102:
---
I ve run one more j8 pre-commit here
https://app.circleci.com/pipelines/github/instaclustr/cassandra/2016/workflows/798fd5fd-7199-43a6-a030-bedf5333a538
> Add a virtual table to list snapshots
> -
>
> Key: CASSANDRA-18102
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18102
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/Virtual Tables, Local/Snapshots
>Reporter: Paulo Motta
>Assignee: maxwellguo
>Priority: Normal
> Fix For: 5.0
>
> Time Spent: 8h 40m
> Remaining Estimate: 0h
>
> It should be possible to query a node's snapshots via virtual tables.
> The table should expose the same fields/columns as the
> [TableSnapshot|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/service/snapshot/TableSnapshot.java]
> class.
> Something along these lines:
> {noformat}
> cqlsh> SELECT * FROM system_views.snapshots;
>
> tag | keyspace_name | table_name | table_id | is_ephemeral | created_at |
> expires_at | directories
> +---++---+--+---++
> 1670460346841 | system | compaction_info |
> 123e4567-e89b-12d3-a456-426614174000 | false | 2022-12-08T00:45:47.108Z |
> null |
> {'/var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/snapshots/1670460346841'}
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18353) Cqlsh command "COPY … TO STDOUT" fails with "… object is not callable"
[
https://issues.apache.org/jira/browse/CASSANDRA-18353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-18353:
-
Test and Documentation Plan: run CI
Status: Patch Available (was: Open)
> Cqlsh command "COPY … TO STDOUT" fails with "… object is not callable"
> --
>
> Key: CASSANDRA-18353
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18353
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Gustav Broberg
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.1.x, 5.x
>
>
> Since 4.1.0, cqlsh fails on COPY commands with standard output as target.
> Steps to reproduce:
> {noformat}
> $> docker run -d --name cassandra --rm cassandra:4.1.1
> $> docker exec cassandra cqlsh -e 'COPY system.local(cluster_name) TO STDOUT'
> :1:'NoneType' object is not callable
> {noformat}
> Possibly a regression introduced by this commit
> [6341319|https://github.com/apache/cassandra/commit/634131961af9c1d88b34797c1c45000f71a76dae#diff-584645e6e932edd7a17f03c79ae87b1f1f8ed54919a31ce8785af156b89c0b76L260].
> Also, it looks like it has happened before: CASSANDRA-12497
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18354) Remove obsolete 'six' package reintroduced by a merge
[ https://issues.apache.org/jira/browse/CASSANDRA-18354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18354: - Test and Documentation Plan: run CI Status: Patch Available (was: Open) > Remove obsolete 'six' package reintroduced by a merge > - > > Key: CASSANDRA-18354 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18354 > Project: Cassandra > Issue Type: Bug > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brandon Williams >Priority: Normal > Fix For: 4.1.x, 5.x > > > The 4.1.x and trunk commits for CASSANDRA-18088 inadvertently re-introduced > 'six' and obsolete python 2.7 conditional checks and should be removed. > I.e., SaferScanner = Py36SaferScanner if six.PY3 else Py2SaferScanner – but > there is no Py2SaferScanner anymore. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18037) Use snake case for the names of CQL native functions
[ https://issues.apache.org/jira/browse/CASSANDRA-18037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andres de la Peña updated CASSANDRA-18037: -- Test and Documentation Plan: ||PR||CI|| |[trunk|https://github.com/apache/cassandra/pull/2236]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/2727/workflows/1c22ea8a-bd97-47d9-8c7a-9ea7ede84926] [j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/2727/workflows/1be4eb86-899b-46d2-b06b-3bf08dc56abd]| |[dtest|https://github.com/apache/cassandra-dtest/pull/217]|| was: ||PR||CI|| |[trunk|https://github.com/apache/cassandra/pull/2236]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/2722/workflows/e4fc72c4-ebd0-49e1-9425-1333b53849b8] [j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/2722/workflows/91d86ea4-9ee5-4efa-8615-eac8fd9ff5e4]| |[dtest|https://github.com/apache/cassandra-dtest/pull/217]|| Status: Patch Available (was: In Progress) > Use snake case for the names of CQL native functions > > > Key: CASSANDRA-18037 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18037 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Syntax >Reporter: Andres de la Peña >Assignee: Andres de la Peña >Priority: Normal > Fix For: 5.x > > > Most native functions are named all lower case, without underscore nor hyphen > to separate words. That's the case, for example, of "intasblob" or > "blobasint". > We also have some functions using camel case, as in "castAsInt" or > "castAsTimestamp". Note that the came cased names require quoting due to > CQL's case insensitivity. > Differently to CQL native functions, system keyspaces, tables and columns > consistently use snake case. For example, we have "system_schema", > "dropped_columns", "default_time_to_live". > As discussed in [this > thread|https://lists.apache.org/thread/k9ml1k4fg6o7mfby1nr3y0mnq9r90dym], we > should adopt snake_case for CQL native function names. Also we should provide > aliases for the current function names, so we don't break compatibility. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18037) Use snake case for the names of CQL native functions
[
https://issues.apache.org/jira/browse/CASSANDRA-18037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703224#comment-17703224
]
Andres de la Peña edited comment on CASSANDRA-18037 at 3/22/23 11:27 AM:
-
Here is the patch adopting the new naming conventions for native CQL functions:
||PR||CI||
|[trunk|https://github.com/apache/cassandra/pull/2236]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/2722/workflows/e4fc72c4-ebd0-49e1-9425-1333b53849b8]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/2722/workflows/91d86ea4-9ee5-4efa-8615-eac8fd9ff5e4]|
|[dtest|https://github.com/apache/cassandra-dtest/pull/217]||
The approach for compatibility with old function names consists on simply
having two instances of each renamed function, one with the new name and
another with the old name.
The reason for not simply having duplicated entries on
[{{NativeFunctions.functions}}|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/NativeFunctions.java#L53]
pointing to the same function instance is that the functions use their own
names to produce the associated column names in query results, print error
messages, etc.
The list of new function names is:
||Old name||New name||
|castAsAscii|cast_as_ascii|
|castAsBigint|cast_as_bigint|
|castAsDate|cast_as_date|
|castAsDecimal|cast_as_decimal|
|castAsDouble|cast_as_double|
|castAsFloat|cast_as_float|
|castAsInt|cast_as_int|
|castAsSmallint|cast_as_smallint|
|castAsText|cast_as_text|
|castAsTimestamp|cast_as_timestamp|
|castAsTinyint|cast_as_tinyint|
|castAsVarint|cast_as_varint|
|blobasascii|blob_as_ascii|
|blobasbigint|blob_as_bigint|
|blobasboolean|blob_as_boolean|
|blobascounter|blob_as_counter|
|blobasdate|blob_as_date|
|blobasdecimal|blob_as_decimal|
|blobasdouble|blob_as_double|
|blobasduration|blob_as_duration|
|blobasempty|blob_as_empty|
|blobasfloat|blob_as_float|
|blobasinet|blob_as_inet|
|blobasint|blob_as_int|
|blobassmallint|blob_as_smallint|
|blobastext|blob_as_text|
|blobastime|blob_as_time|
|blobastimestamp|blob_as_timestamp|
|blobastimeuuid|blob_as_timeuuid|
|blobastinyint|blob_as_tinyint|
|blobasuuid|blob_as_uuid|
|blobasvarchar|blob_as_varchar|
|blobasvarint|blob_as_varint|
|asciiasblob|ascii_as_blob|
|bigintasblob|bigint_as_blob|
|booleanasblob|boolean_as_blob|
|counterasblob|counter_as_blob|
|dateasblob|date_as_blob|
|decimalasblob|decimal_as_blob|
|doubleasblob|double_as_blob|
|durationasblob|duration_as_blob|
|emptyasblob|empty_as_blob|
|floatasblob|float_as_blob|
|inetasblob|inet_as_blob|
|intasblob|int_as_blob|
|smallintasblob|smallint_as_blob|
|textasblob|text_as_blob|
|timeasblob|time_as_blob|
|timestampasblob|timestamp_as_blob|
|timeuuidasblob|timeuuid_as_blob|
|tinyintasblob|tinyint_as_blob|
|uuidasblob|uuid_as_blob|
|varcharasblob|varchar_as_blob|
|varintasblob|varint_as_blob|
|countRows|count_rows|
|maxtimeuuid|max_timeuuid|
|mintimeuuid|min_timeuuid|
|currentdate|current_date|
|currenttime|current_time|
|currenttimestamp|current_timestamp|
|currenttimeuuid|current_timeuuid|
|todate|to_date|
|totimestamp|to_timestamp|
|tounixtimestamp|to_unix_timestamp|
|tojson|to_json|
|fromjson|from_json|
was (Author: adelapena):
Here is the patch adopting the new naming conventions for native CQL functions:
||PR||CI||
|[trunk|https://github.com/apache/cassandra/pull/2236]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/2722/workflows/e4fc72c4-ebd0-49e1-9425-1333b53849b8]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/2722/workflows/91d86ea4-9ee5-4efa-8615-eac8fd9ff5e4]|
|[dtest|https://github.com/apache/cassandra-dtest/pull/217]||
The approach for compatibility with old function names consists on simply
having two instances of each renamed function, one with the new name and
another with the old name.
The reason for not simply having duplicated entries on
[{{NativeFunctions.functions}}|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/functions/NativeFunctions.java#L53]
pointing to the same function instance is that the functions use their own
names to produce the associated column names in query results, print error
messages, etc.
The list of new function names is:
||Old name||New name||
|castAsAscii|cast_as_ascii|
|castAsBigint|cast_as_bigint|
|castAsDate|cast_as_date|
|castAsDecimal|cast_as_decimal|
|castAsDouble|cast_as_double|
|castAsFloat|cast_as_float|
|castAsInt|cast_as_int|
|castAsSmallint|cast_as_smallint|
|castAsText|cast_as_text|
|castAsTimestamp|cast_as_timestamp|
|castAsTinyint|cast_as_tinyint|
|castAsVarint|cast_as_varint|
|blobasascii|blob_as_ascii|
|blobasbigint|blob_as_bigint|
|blobasboolean|blob_as_boolean|
|blobascounter|blob_as_counter|
|blobasdate|blob_as_date|
|blobasdecimal|blob_as_decimal|
|blobasdouble|blob_as_double|
|blobasduration|blob_as_duration|
[jira] [Commented] (CASSANDRA-18037) Use snake case for the names of CQL native functions
[ https://issues.apache.org/jira/browse/CASSANDRA-18037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703613#comment-17703613 ] Andres de la Peña commented on CASSANDRA-18037: --- It is patch available again, I had totally forgotten the json functions: ||PR||CI|| |[trunk|https://github.com/apache/cassandra/pull/2236]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/2727/workflows/1c22ea8a-bd97-47d9-8c7a-9ea7ede84926] [j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/2727/workflows/1be4eb86-899b-46d2-b06b-3bf08dc56abd]| |[dtest|https://github.com/apache/cassandra-dtest/pull/217]|| > Use snake case for the names of CQL native functions > > > Key: CASSANDRA-18037 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18037 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Syntax >Reporter: Andres de la Peña >Assignee: Andres de la Peña >Priority: Normal > Fix For: 5.x > > > Most native functions are named all lower case, without underscore nor hyphen > to separate words. That's the case, for example, of "intasblob" or > "blobasint". > We also have some functions using camel case, as in "castAsInt" or > "castAsTimestamp". Note that the came cased names require quoting due to > CQL's case insensitivity. > Differently to CQL native functions, system keyspaces, tables and columns > consistently use snake case. For example, we have "system_schema", > "dropped_columns", "default_time_to_live". > As discussed in [this > thread|https://lists.apache.org/thread/k9ml1k4fg6o7mfby1nr3y0mnq9r90dym], we > should adopt snake_case for CQL native function names. Also we should provide > aliases for the current function names, so we don't break compatibility. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18353) Cqlsh command "COPY … TO STDOUT" fails with "… object is not callable"
[
https://issues.apache.org/jira/browse/CASSANDRA-18353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703402#comment-17703402
]
Brandon Williams edited comment on CASSANDRA-18353 at 3/22/23 11:14 AM:
Smoke test added
[here|https://github.com/driftx/cassandra-dtest/tree/CASSANDRA-18353].
||Branch||CI||
|[4.1|https://github.com/driftx/cassandra/tree/CASSANDRA-18353-4.1]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/922/workflows/6cd2b3fe-9836-422d-b765-5d9498893455],
[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/922/workflows/6ed14810-4900-45d8-9f29-d3cf5dbc5956]|
|[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-18353-trunk]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/921/workflows/dc725119-7752-420f-9538-2218391f318f],
[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/921/workflows/ab212108-7924-40d9-bc73-8522a02a9df3]|
was (Author: brandon.williams):
Smoke test added
[here|https://github.com/driftx/cassandra-dtest/tree/CASSANDRA-18353].
||Branch||CI||
|[4.1|https://github.com/driftx/cassandra/tree/CASSANDRA-18353-4.1]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/920/workflows/0981782b-05d3-477a-8e50-c62cb3e72454],
[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/920/workflows/eda54ced-beb2-44cb-968c-e500025f099c]|
|[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-18353-trunk]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/919/workflows/79fb096d-33f3-492e-bcdc-629fcd0feb59],
[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/919/workflows/cf90aa9a-4a05-4131-8a7d-b078fff578ab]|
> Cqlsh command "COPY … TO STDOUT" fails with "… object is not callable"
> --
>
> Key: CASSANDRA-18353
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18353
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Gustav Broberg
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 4.1.x, 5.x
>
>
> Since 4.1.0, cqlsh fails on COPY commands with standard output as target.
> Steps to reproduce:
> {noformat}
> $> docker run -d --name cassandra --rm cassandra:4.1.1
> $> docker exec cassandra cqlsh -e 'COPY system.local(cluster_name) TO STDOUT'
> :1:'NoneType' object is not callable
> {noformat}
> Possibly a regression introduced by this commit
> [6341319|https://github.com/apache/cassandra/commit/634131961af9c1d88b34797c1c45000f71a76dae#diff-584645e6e932edd7a17f03c79ae87b1f1f8ed54919a31ce8785af156b89c0b76L260].
> Also, it looks like it has happened before: CASSANDRA-12497
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14632) cqlsh can't describe when index options contain unicode
[
https://issues.apache.org/jira/browse/CASSANDRA-14632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-14632:
-
Resolution: (was: Cannot Reproduce)
Status: Open (was: Resolved)
100% repros on 3.11:
{noformat}
[cqlsh 5.0.1 | Cassandra 3.11.15-SNAPSHOT | CQL spec 3.4.4 | Native protocol v4]
Use HELP for help.
cqlsh> CREATE KEYSPACE test WITH replication = {'class': 'SimpleStrategy',
'replication_factor': 1};
cqlsh> CREATE TABLE test ( one text, two int, three text, PRIMARY KEY (one,two)
);
InvalidRequest: Error from server: code=2200 [Invalid query] message="No
keyspace has been specified. USE a keyspace, or explicitly specify
keyspace.tablename"
cqlsh> use test;
cqlsh:test> CREATE TABLE test ( one text, two int, three text, PRIMARY KEY
(one,two) );
cqlsh:test> CREATE CUSTOM INDEX ON test.test (three) USING
'org.apache.cassandra.index.sasi.SASIIndex' WITH OPTIONS = { 'delimiter': '░'};
Warnings :
SASI indexes are experimental and are not recommended for production use.
cqlsh:test> DESCRIBE KEYSPACE test ;
'ascii' codec can't decode byte 0xe2 in position 31: ordinal not in range(128)
cqlsh:test>
{noformat}
> cqlsh can't describe when index options contain unicode
>
>
> Key: CASSANDRA-14632
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14632
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Tools
>Reporter: Michael Semb Wever
>Priority: Normal
>
> The following `describe` fails in `cqlsh`:
>
> {code:java}
> $ cqlsh
> cqlsh> CREATE KEYSPACE test WITH replication = {'class': 'SimpleStrategy',
> 'replication_factor': 1};
> cqlsh> CREATE TABLE test ( one text, two int, three text, PRIMARY KEY
> (one,two) );
> cqlsh> CREATE CUSTOM INDEX ON test.test (three) USING
> 'org.apache.cassandra.index.sasi.SASIIndex' WITH OPTIONS = { 'delimiter':
> '░'};
> cqlsh> DESCRIBE KEYSPACE test ;
> 'ascii' codec can't decode byte 0xe2 in position 31: ordinal not in range(128)
> {code}
>
> Full error is
> {noformat}
> Traceback (most recent call last):
> File "/usr/bin/cqlsh.py", line 919, in onecmd
> self.handle_statement(st, statementtext)
> File "/usr/bin/cqlsh.py", line 956, in handle_statement
> return custom_handler(parsed)
> File "/usr/bin/cqlsh.py", line 1539, in do_describe
> self.describe_keyspace(ksname)
> File "/usr/bin/cqlsh.py", line 1275, in describe_keyspace
> self.print_recreate_keyspace(self.get_keyspace_meta(ksname), sys.stdout)
> File "/usr/bin/cqlsh.py", line 1225, in print_recreate_keyspace
> out.write(ksdef.export_as_string())
> File
> "/usr/share/cassandra/lib/cassandra-driver-internal-only-3.10.zip/cassandra-driver-3.10/cassandra/metadata.py",
> line 661, in export_as_string
> + [t.export_as_string() for t in self.tables.values()])
> File
> "/usr/share/cassandra/lib/cassandra-driver-internal-only-3.10.zip/cassandra-driver-3.10/cassandra/metadata.py",
> line 1116, in export_as_string
> ret = self._all_as_cql()
> File
> "/usr/share/cassandra/lib/cassandra-driver-internal-only-3.10.zip/cassandra-driver-3.10/cassandra/metadata.py",
> line 1125, in _all_as_cql
> ret += "\n%s;" % index.as_cql_query()
> File
> "/usr/share/cassandra/lib/cassandra-driver-internal-only-3.10.zip/cassandra-driver-3.10/cassandra/metadata.py",
> line 1402, in as_cql_query
> ret += " WITH OPTIONS = %s" %
> Encoder().cql_encode_all_types(options){noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14632) cqlsh can't describe when index options contain unicode
[
https://issues.apache.org/jira/browse/CASSANDRA-14632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-14632:
-
Fix Version/s: 3.11.x
> cqlsh can't describe when index options contain unicode
>
>
> Key: CASSANDRA-14632
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14632
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Tools
>Reporter: Michael Semb Wever
>Priority: Normal
> Fix For: 3.11.x
>
>
> The following `describe` fails in `cqlsh`:
>
> {code:java}
> $ cqlsh
> cqlsh> CREATE KEYSPACE test WITH replication = {'class': 'SimpleStrategy',
> 'replication_factor': 1};
> cqlsh> CREATE TABLE test ( one text, two int, three text, PRIMARY KEY
> (one,two) );
> cqlsh> CREATE CUSTOM INDEX ON test.test (three) USING
> 'org.apache.cassandra.index.sasi.SASIIndex' WITH OPTIONS = { 'delimiter':
> '░'};
> cqlsh> DESCRIBE KEYSPACE test ;
> 'ascii' codec can't decode byte 0xe2 in position 31: ordinal not in range(128)
> {code}
>
> Full error is
> {noformat}
> Traceback (most recent call last):
> File "/usr/bin/cqlsh.py", line 919, in onecmd
> self.handle_statement(st, statementtext)
> File "/usr/bin/cqlsh.py", line 956, in handle_statement
> return custom_handler(parsed)
> File "/usr/bin/cqlsh.py", line 1539, in do_describe
> self.describe_keyspace(ksname)
> File "/usr/bin/cqlsh.py", line 1275, in describe_keyspace
> self.print_recreate_keyspace(self.get_keyspace_meta(ksname), sys.stdout)
> File "/usr/bin/cqlsh.py", line 1225, in print_recreate_keyspace
> out.write(ksdef.export_as_string())
> File
> "/usr/share/cassandra/lib/cassandra-driver-internal-only-3.10.zip/cassandra-driver-3.10/cassandra/metadata.py",
> line 661, in export_as_string
> + [t.export_as_string() for t in self.tables.values()])
> File
> "/usr/share/cassandra/lib/cassandra-driver-internal-only-3.10.zip/cassandra-driver-3.10/cassandra/metadata.py",
> line 1116, in export_as_string
> ret = self._all_as_cql()
> File
> "/usr/share/cassandra/lib/cassandra-driver-internal-only-3.10.zip/cassandra-driver-3.10/cassandra/metadata.py",
> line 1125, in _all_as_cql
> ret += "\n%s;" % index.as_cql_query()
> File
> "/usr/share/cassandra/lib/cassandra-driver-internal-only-3.10.zip/cassandra-driver-3.10/cassandra/metadata.py",
> line 1402, in as_cql_query
> ret += " WITH OPTIONS = %s" %
> Encoder().cql_encode_all_types(options){noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18153) Memtable being flushed without hostId in version "me" and newer during CommitLogReplay
[
https://issues.apache.org/jira/browse/CASSANDRA-18153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702463#comment-17702463
]
Jacek Lewandowski edited comment on CASSANDRA-18153 at 3/22/23 11:05 AM:
-
3.0 - [PR|https://github.com/apache/cassandra/pull/2234],
[CI|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2363/]
(/)
3.11 - [PR|https://github.com/apache/cassandra/pull/2215],
[CI|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2364/]
(/)
4.0 - [PR|https://github.com/apache/cassandra/pull/2231],
[CI|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2373/]
(!),
fixed just two unit tests, so rerunning the unit tests only:
[regular|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch-test/1775/]
(/),
[cdc|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch-test-cdc/1755/]
(!),
[compression|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch-test-compression/1761/]
(/)
since some other unrelated unit test failed for CDC, I did repeatable runs in
[CircleCI|https://app.circleci.com/pipelines/github/jacek-lewandowski/cassandra/644/workflows/42afa702-4500-46f3-96d6-b2e14f5e1b75](/)
4.1 - [PR|https://github.com/apache/cassandra/pull/2232],
[CI|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2378/]
(?)
5.0 - [PR|https://github.com/apache/cassandra/pull/2233]
dtest - [PR|https://github.com/apache/cassandra-dtest/pull/216]
was (Author: jlewandowski):
3.0 - [PR|https://github.com/apache/cassandra/pull/2234],
[CI|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2363/]
(/)
3.11 - [PR|https://github.com/apache/cassandra/pull/2215],
[CI|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2364/]
(/)
4.0 - [PR|https://github.com/apache/cassandra/pull/2231],
[CI|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2373/]
(!),
fixed just two unit tests, so rerunning the unit tests only:
[regular|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch-test/1775/]
(/),
[cdc|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch-test-cdc/1755/]
(!),
[compression|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch-test-compression/1761/]
(/)
since some other unrelated unit test failed for CDC, I did repeatable runs in
[CircleCI|https://app.circleci.com/pipelines/github/jacek-lewandowski/cassandra/644/workflows/42afa702-4500-46f3-96d6-b2e14f5e1b75](/)
4.1 - [PR|https://github.com/apache/cassandra/pull/2232]
5.0 - [PR|https://github.com/apache/cassandra/pull/2233]
dtest - [PR|https://github.com/apache/cassandra-dtest/pull/216]
> Memtable being flushed without hostId in version "me" and newer during
> CommitLogReplay
> --
>
> Key: CASSANDRA-18153
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18153
> Project: Cassandra
> Issue Type: Bug
> Components: Local/SSTable
>Reporter: Adriano Bonacin
>Assignee: Adriano Bonacin
>Priority: Normal
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> On ticket CASSANDRA-16619 some files were changed to allow Cassandra to store
> HostID in the new "me" SSTable version.
> But SSTables flushed during CommitLogReplay miss this HostID info.
>
> In the next Cassandra startup, if these SSTables were still present,
> system.log will show:
> {{WARN Origin of 3 sstables is unknown or doesn't match the local node;
> commitLogIntervals for them were ignored}}
> {{WARN }}{{{}Origin of 3 sstables is unknown or doesn't match the local node;
> commitLogIntervals for them were ignored{}}}{{{}{}}}{{ }}
>
> And debug.log will show a list of SSTables, witch can include "md" and "me"
> version (before upgradesstables):
>
> {{Ignored commitLogIntervals from the following sstables:
> [/var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/me-3-big-Data.db,
>
> /var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/md-1-big-Data.db,
>
> /var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/md-2-big-Data.db]}}
>
> https://issues.apache.org/jira/browse/CASSANDRA-16619
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18156) Test Failure: repair_tests.deprecated_repair_test.TestDeprecatedRepairNotifications.test_deprecated_repair_error_notification
[ https://issues.apache.org/jira/browse/CASSANDRA-18156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18156: - Fix Version/s: 3.0.29 3.11.15 (was: 3.0.x) (was: 3.11.x) Since Version: NA Source Control Link: https://github.com/apache/cassandra-dtest/commit/5f725067532589161ae8c5ca60c05782480a452c Resolution: Fixed Status: Resolved (was: Ready to Commit) Thanks for the quick review! Committed. > Test Failure: > repair_tests.deprecated_repair_test.TestDeprecatedRepairNotifications.test_deprecated_repair_error_notification > - > > Key: CASSANDRA-18156 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18156 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Michael Semb Wever >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.29, 3.11.15 > > > Failing since > https://ci-cassandra.apache.org/job/Cassandra-3.0/313/testReport/dtest.repair_tests.deprecated_repair_test/TestDeprecatedRepairNotifications > which is > https://github.com/apache/cassandra/commit/13d495aa7d5b7a7c121fcc9e105f79107c5c2a1c > from CASSANDRA-17254 > but can be reproduced earlier in circleci, e.g. > https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/64/workflows/f99abc05-aa9b-42de-a424-44ab7c247e76/jobs/3175 > > Only two commits are in this time-range (10th to 30th November) in > cassandra-dtest > - > https://github.com/apache/cassandra-dtest/commit/7f2b8eda5c52fb6f637aa7166e2d48cd34a64eec > (CASSANDRA-17679) > - > https://github.com/apache/cassandra-dtest/commit/e0d3cc90558a17b63634d15ee6df339ceb87b225 > (CASSANDRA-15402) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-dtest] branch trunk updated: Add legacy parsing to test_deprecated_repair_error_notification
This is an automated email from the ASF dual-hosted git repository.
brandonwilliams pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-dtest.git
The following commit(s) were added to refs/heads/trunk by this push:
new 5f725067 Add legacy parsing to
test_deprecated_repair_error_notification
5f725067 is described below
commit 5f725067532589161ae8c5ca60c05782480a452c
Author: Brandon Williams
AuthorDate: Tue Mar 21 10:15:11 2023 -0500
Add legacy parsing to test_deprecated_repair_error_notification
Patch by brandonwilliams; reviewed by bereng for CASSANDRA-18156
---
dtest.py | 28
repair_tests/deprecated_repair_test.py | 9 +
2 files changed, 21 insertions(+), 16 deletions(-)
diff --git a/dtest.py b/dtest.py
index 1c295ab4..15f0be0b 100644
--- a/dtest.py
+++ b/dtest.py
@@ -520,16 +520,20 @@ def run_scenarios(scenarios, handler,
deferred_exceptions=tuple()):
raise MultiError(errors, tracebacks)
def hack_legacy_parsing(node):
- """ Hack node's shell script for nodetool legacy URL parsing, ala
CASSANDRA-17581 """
- nodetool = os.path.join(node.get_install_dir(), 'bin', 'nodetool')
- with open(nodetool, 'r+') as fd:
- contents = fd.readlines()
- if "legacy" in contents[len(contents)-6]:
- logger.debug("nodetool already hacked")
- elif not contents[len(contents)-5].endswith('\\\n'):
- logger.debug("version does not appear to need hacking")
- else:
- contents.insert(len(contents)-5, "
-Dcom.sun.jndi.rmiURLParsing=legacy \\\n")
- fd.seek(0)
- fd.writelines(contents)
+""" Hack node's shell script for nodetool legacy URL parsing, ala
CASSANDRA-17581 """
+if hasattr(node, 'get_install_dir'):
+nodetool = os.path.join(node.get_install_dir(), 'bin', 'nodetool')
+else:
+# assume raw path
+nodetool = node
+with open(nodetool, 'r+') as fd:
+contents = fd.readlines()
+if "legacy" in contents[len(contents)-6]:
+logger.debug("nodetool already hacked")
+elif not contents[len(contents)-5].endswith('\\\n'):
+logger.debug("version does not appear to need hacking")
+else:
+contents.insert(len(contents)-5, "
-Dcom.sun.jndi.rmiURLParsing=legacy \\\n")
+fd.seek(0)
+fd.writelines(contents)
diff --git a/repair_tests/deprecated_repair_test.py
b/repair_tests/deprecated_repair_test.py
index 75c770e4..2b0fc0e2 100644
--- a/repair_tests/deprecated_repair_test.py
+++ b/repair_tests/deprecated_repair_test.py
@@ -10,7 +10,7 @@ from ccmlib.common import is_win
from ccmlib.node import handle_external_tool_process, ToolError
import ccmlib.repository
-from dtest import Tester, create_ks, create_cf
+from dtest import Tester, create_ks, create_cf, hack_legacy_parsing
from tools.assertions import assert_length_equal
from tools.data import insert_c1c2
from tools.jmxutils import (JolokiaAgent, make_mbean)
@@ -256,6 +256,7 @@ class TestDeprecatedRepairNotifications(Tester):
logger.debug("Running repair on node1 using legacy nodetool (using
options that will cause failure with error)")
legacy_dirpath = ccmlib.repository.directory_name(legacy_version)
legacy_nodetool_path = os.path.join(legacy_dirpath, "bin", "nodetool")
+hack_legacy_parsing(legacy_nodetool_path)
repair_env = self.get_legacy_environment(legacy_version,
node_env=node1.get_env())
repair_args = [legacy_nodetool_path, "-h", "localhost", "-p",
str(node1.jmx_port), "repair", "-hosts", "127.0.0.2"]
p = subprocess.Popen(repair_args, env=repair_env,
stdout=subprocess.PIPE, stderr=subprocess.PIPE, universal_newlines=True)
@@ -266,9 +267,9 @@ class TestDeprecatedRepairNotifications(Tester):
except ToolError as tool_error:
nodetool_stderr = tool_error.stderr
-# Check for repair failed message in node1 log
-repair_failed_logs = node1.grep_log(r"ERROR
\[(Repair-Task|Thread)-\d+\] \d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2},\d{3}
RepairRunnable.java:\d+ - Repair failed")
-assert len(repair_failed_logs) > 0, "Node logs don't have an error
message for the failed repair"
# Check for error and stacktrace in nodetool output
assert nodetool_stderr.find("error") > -1, "Legacy nodetool didn't
print an error message for the failed repair"
assert nodetool_stderr.find("-- StackTrace --") > -1, "Legacy nodetool
didn't print a stack trace for the failed repair"
+# Check for repair failed message in node1 log
+repair_failed_logs = node1.grep_log(r"ERROR
\[(Repair-Task|Thread)-\d+\] \d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2},\d{3}
RepairRunnable.java:\d+ - Repair failed")
+assert
[jira] [Comment Edited] (CASSANDRA-18153) Memtable being flushed without hostId in version "me" and newer during CommitLogReplay
[
https://issues.apache.org/jira/browse/CASSANDRA-18153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702463#comment-17702463
]
Jacek Lewandowski edited comment on CASSANDRA-18153 at 3/22/23 10:43 AM:
-
3.0 - [PR|https://github.com/apache/cassandra/pull/2234],
[CI|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2363/]
(/)
3.11 - [PR|https://github.com/apache/cassandra/pull/2215],
[CI|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2364/]
(/)
4.0 - [PR|https://github.com/apache/cassandra/pull/2231],
[CI|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2373/]
(!),
fixed just two unit tests, so rerunning the unit tests only:
[regular|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch-test/1775/]
(/),
[cdc|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch-test-cdc/1755/]
(!),
[compression|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch-test-compression/1761/]
(/)
since some other unrelated unit test failed for CDC, I did repeatable runs in
[CircleCI|https://app.circleci.com/pipelines/github/jacek-lewandowski/cassandra/644/workflows/42afa702-4500-46f3-96d6-b2e14f5e1b75](/)
4.1 - [PR|https://github.com/apache/cassandra/pull/2232]
5.0 - [PR|https://github.com/apache/cassandra/pull/2233]
dtest - [PR|https://github.com/apache/cassandra-dtest/pull/216]
was (Author: jlewandowski):
3.0 - [PR|https://github.com/apache/cassandra/pull/2234],
[CI|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2363/]
(/)
3.11 - [PR|https://github.com/apache/cassandra/pull/2215],
[CI|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2364/]
(/)
4.0 - [PR|https://github.com/apache/cassandra/pull/2231],
[CI|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2373/]
(!), fixed just two unit tests, so rerunning the unit tests only:
[regular|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch-test/1775/]
(?),
[cdc|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch-test-cdc/1755/]
(?),
[compression|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch-test-compression/1761/]
(?)
4.1 - [PR|https://github.com/apache/cassandra/pull/2232]
5.0 - [PR|https://github.com/apache/cassandra/pull/2233]
dtest - [PR|https://github.com/apache/cassandra-dtest/pull/216]
> Memtable being flushed without hostId in version "me" and newer during
> CommitLogReplay
> --
>
> Key: CASSANDRA-18153
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18153
> Project: Cassandra
> Issue Type: Bug
> Components: Local/SSTable
>Reporter: Adriano Bonacin
>Assignee: Adriano Bonacin
>Priority: Normal
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> On ticket CASSANDRA-16619 some files were changed to allow Cassandra to store
> HostID in the new "me" SSTable version.
> But SSTables flushed during CommitLogReplay miss this HostID info.
>
> In the next Cassandra startup, if these SSTables were still present,
> system.log will show:
> {{WARN Origin of 3 sstables is unknown or doesn't match the local node;
> commitLogIntervals for them were ignored}}
> {{WARN }}{{{}Origin of 3 sstables is unknown or doesn't match the local node;
> commitLogIntervals for them were ignored{}}}{{{}{}}}{{ }}
>
> And debug.log will show a list of SSTables, witch can include "md" and "me"
> version (before upgradesstables):
>
> {{Ignored commitLogIntervals from the following sstables:
> [/var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/me-3-big-Data.db,
>
> /var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/md-1-big-Data.db,
>
> /var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/md-2-big-Data.db]}}
>
> https://issues.apache.org/jira/browse/CASSANDRA-16619
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18124) Config parameter keystore_password should be nullable
[ https://issues.apache.org/jira/browse/CASSANDRA-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703578#comment-17703578 ] Tibor Repasi commented on CASSANDRA-18124: -- Sorry for the delay, I was busy the last few days. Of course, I'll have a look and test it. > Config parameter keystore_password should be nullable > - > > Key: CASSANDRA-18124 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18124 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Tibor Repasi >Assignee: Maulin Vasavada >Priority: Normal > Fix For: 4.1.x, 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > Some SSL configuration may pass unencrypted private keys. PEMReader might > accept that by assuming keyPassword to be null in that case (e.g. > https://github.com/apache/cassandra/blob/f9e033f519c14596da4dc954875756a69aea4e78/src/java/org/apache/cassandra/security/PEMReader.java#L103). > Current configuration reader does not accept keystore_password parameter to > be set null or empty in the cassandra.yaml. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18356) Cassandra Debian Repository is not available and will be redirected to landing.jfrog.com
[ https://issues.apache.org/jira/browse/CASSANDRA-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703565#comment-17703565 ] Stefan Miklosovic edited comment on CASSANDRA-18356 at 3/22/23 9:25 AM: Infra team is on it! https://issues.apache.org/jira/browse/INFRA-24371 It is not only Cassandra-specific issue. Other projects are experiencing the same. was (Author: smiklosovic): Infra team is on it! https://issues.apache.org/jira/browse/INFRA-24371 > Cassandra Debian Repository is not available and will be redirected to > landing.jfrog.com > > > Key: CASSANDRA-18356 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18356 > Project: Cassandra > Issue Type: Task > Components: Packaging >Reporter: Zoltan Lanyi >Priority: High > > Hi, > Debian Repo ist not available and redirected to landing.jfrog.com > Time flies when you’re having fun. > Your 14-day trial may be over, but you have options! > Could you pls fix that? > Thanks in advance > Zoltan -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18356) Cassandra Debian Repository is not available and will be redirected to landing.jfrog.com
[ https://issues.apache.org/jira/browse/CASSANDRA-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703565#comment-17703565 ] Stefan Miklosovic commented on CASSANDRA-18356: --- Infra team is on it! https://issues.apache.org/jira/browse/INFRA-24371 > Cassandra Debian Repository is not available and will be redirected to > landing.jfrog.com > > > Key: CASSANDRA-18356 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18356 > Project: Cassandra > Issue Type: Task > Components: Packaging >Reporter: Zoltan Lanyi >Priority: High > > Hi, > Debian Repo ist not available and redirected to landing.jfrog.com > Time flies when you’re having fun. > Your 14-day trial may be over, but you have options! > Could you pls fix that? > Thanks in advance > Zoltan -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18037) Use snake case for the names of CQL native functions
[ https://issues.apache.org/jira/browse/CASSANDRA-18037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703562#comment-17703562 ] Berenguer Blasi commented on CASSANDRA-18037: - Should this be patch available? > Use snake case for the names of CQL native functions > > > Key: CASSANDRA-18037 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18037 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Syntax >Reporter: Andres de la Peña >Assignee: Andres de la Peña >Priority: Normal > Fix For: 5.x > > > Most native functions are named all lower case, without underscore nor hyphen > to separate words. That's the case, for example, of "intasblob" or > "blobasint". > We also have some functions using camel case, as in "castAsInt" or > "castAsTimestamp". Note that the came cased names require quoting due to > CQL's case insensitivity. > Differently to CQL native functions, system keyspaces, tables and columns > consistently use snake case. For example, we have "system_schema", > "dropped_columns", "default_time_to_live". > As discussed in [this > thread|https://lists.apache.org/thread/k9ml1k4fg6o7mfby1nr3y0mnq9r90dym], we > should adopt snake_case for CQL native function names. Also we should provide > aliases for the current function names, so we don't break compatibility. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18037) Use snake case for the names of CQL native functions
[ https://issues.apache.org/jira/browse/CASSANDRA-18037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-18037: Reviewers: Berenguer Blasi > Use snake case for the names of CQL native functions > > > Key: CASSANDRA-18037 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18037 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Syntax >Reporter: Andres de la Peña >Assignee: Andres de la Peña >Priority: Normal > Fix For: 5.x > > > Most native functions are named all lower case, without underscore nor hyphen > to separate words. That's the case, for example, of "intasblob" or > "blobasint". > We also have some functions using camel case, as in "castAsInt" or > "castAsTimestamp". Note that the came cased names require quoting due to > CQL's case insensitivity. > Differently to CQL native functions, system keyspaces, tables and columns > consistently use snake case. For example, we have "system_schema", > "dropped_columns", "default_time_to_live". > As discussed in [this > thread|https://lists.apache.org/thread/k9ml1k4fg6o7mfby1nr3y0mnq9r90dym], we > should adopt snake_case for CQL native function names. Also we should provide > aliases for the current function names, so we don't break compatibility. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18156) Test Failure: repair_tests.deprecated_repair_test.TestDeprecatedRepairNotifications.test_deprecated_repair_error_notification
[ https://issues.apache.org/jira/browse/CASSANDRA-18156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-18156: Reviewers: Berenguer Blasi, Berenguer Blasi Berenguer Blasi, Berenguer Blasi (was: Berenguer Blasi) Status: Review In Progress (was: Patch Available) > Test Failure: > repair_tests.deprecated_repair_test.TestDeprecatedRepairNotifications.test_deprecated_repair_error_notification > - > > Key: CASSANDRA-18156 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18156 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Michael Semb Wever >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.x, 3.11.x > > > Failing since > https://ci-cassandra.apache.org/job/Cassandra-3.0/313/testReport/dtest.repair_tests.deprecated_repair_test/TestDeprecatedRepairNotifications > which is > https://github.com/apache/cassandra/commit/13d495aa7d5b7a7c121fcc9e105f79107c5c2a1c > from CASSANDRA-17254 > but can be reproduced earlier in circleci, e.g. > https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/64/workflows/f99abc05-aa9b-42de-a424-44ab7c247e76/jobs/3175 > > Only two commits are in this time-range (10th to 30th November) in > cassandra-dtest > - > https://github.com/apache/cassandra-dtest/commit/7f2b8eda5c52fb6f637aa7166e2d48cd34a64eec > (CASSANDRA-17679) > - > https://github.com/apache/cassandra-dtest/commit/e0d3cc90558a17b63634d15ee6df339ceb87b225 > (CASSANDRA-15402) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18356) Cassandra Debian Repository is not available and will be redirected to landing.jfrog.com
[ https://issues.apache.org/jira/browse/CASSANDRA-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Lanyi updated CASSANDRA-18356: - Priority: High (was: Normal) > Cassandra Debian Repository is not available and will be redirected to > landing.jfrog.com > > > Key: CASSANDRA-18356 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18356 > Project: Cassandra > Issue Type: Task > Components: Packaging >Reporter: Zoltan Lanyi >Priority: High > > Hi, > Debian Repo ist not available and redirected to landing.jfrog.com > Time flies when you’re having fun. > Your 14-day trial may be over, but you have options! > Could you pls fix that? > Thanks in advance > Zoltan -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18356) Cassandra Debian Repository is not available redirected to landing.jfrog.com
Zoltan Lanyi created CASSANDRA-18356: Summary: Cassandra Debian Repository is not available redirected to landing.jfrog.com Key: CASSANDRA-18356 URL: https://issues.apache.org/jira/browse/CASSANDRA-18356 Project: Cassandra Issue Type: Task Components: Packaging Reporter: Zoltan Lanyi Hi, Debian Repo ist not available and redirected to landing.jfrog.com Time flies when you’re having fun. Your 14-day trial may be over, but you have options! Could you pls fix that? Thanks in advance Zoltan -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18356) Cassandra Debian Repository is not available and will be redirected to landing.jfrog.com
[ https://issues.apache.org/jira/browse/CASSANDRA-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Lanyi updated CASSANDRA-18356: - Summary: Cassandra Debian Repository is not available and will be redirected to landing.jfrog.com (was: Cassandra Debian Repository is not available redirected to landing.jfrog.com) > Cassandra Debian Repository is not available and will be redirected to > landing.jfrog.com > > > Key: CASSANDRA-18356 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18356 > Project: Cassandra > Issue Type: Task > Components: Packaging >Reporter: Zoltan Lanyi >Priority: Normal > > Hi, > Debian Repo ist not available and redirected to landing.jfrog.com > Time flies when you’re having fun. > Your 14-day trial may be over, but you have options! > Could you pls fix that? > Thanks in advance > Zoltan -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18153) Memtable being flushed without hostId in version "me" and newer during CommitLogReplay
[
https://issues.apache.org/jira/browse/CASSANDRA-18153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702463#comment-17702463
]
Jacek Lewandowski edited comment on CASSANDRA-18153 at 3/22/23 9:14 AM:
3.0 - [PR|https://github.com/apache/cassandra/pull/2234],
[CI|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2363/]
(/)
3.11 - [PR|https://github.com/apache/cassandra/pull/2215],
[CI|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2364/]
(/)
4.0 - [PR|https://github.com/apache/cassandra/pull/2231],
[CI|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2373/]
(!), fixed just two unit tests, so rerunning the unit tests only:
[regular|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch-test/1775/]
(?),
[cdc|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch-test-cdc/1755/]
(?),
[compression|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch-test-compression/1761/]
(?)
4.1 - [PR|https://github.com/apache/cassandra/pull/2232]
5.0 - [PR|https://github.com/apache/cassandra/pull/2233]
dtest - [PR|https://github.com/apache/cassandra-dtest/pull/216]
was (Author: jlewandowski):
3.0 - [PR|https://github.com/apache/cassandra/pull/2234],
[CI|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2363/]
(/)
3.11 - [PR|https://github.com/apache/cassandra/pull/2215],
[CI|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2364/]
(/)
4.0 - [PR|https://github.com/apache/cassandra/pull/2231],
[CI|https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2373/]
(?)
4.1 - [PR|https://github.com/apache/cassandra/pull/2232]
5.0 - [PR|https://github.com/apache/cassandra/pull/2233]
dtest - [PR|https://github.com/apache/cassandra-dtest/pull/216]
> Memtable being flushed without hostId in version "me" and newer during
> CommitLogReplay
> --
>
> Key: CASSANDRA-18153
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18153
> Project: Cassandra
> Issue Type: Bug
> Components: Local/SSTable
>Reporter: Adriano Bonacin
>Assignee: Adriano Bonacin
>Priority: Normal
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> On ticket CASSANDRA-16619 some files were changed to allow Cassandra to store
> HostID in the new "me" SSTable version.
> But SSTables flushed during CommitLogReplay miss this HostID info.
>
> In the next Cassandra startup, if these SSTables were still present,
> system.log will show:
> {{WARN Origin of 3 sstables is unknown or doesn't match the local node;
> commitLogIntervals for them were ignored}}
> {{WARN }}{{{}Origin of 3 sstables is unknown or doesn't match the local node;
> commitLogIntervals for them were ignored{}}}{{{}{}}}{{ }}
>
> And debug.log will show a list of SSTables, witch can include "md" and "me"
> version (before upgradesstables):
>
> {{Ignored commitLogIntervals from the following sstables:
> [/var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/me-3-big-Data.db,
>
> /var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/md-1-big-Data.db,
>
> /var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/md-2-big-Data.db]}}
>
> https://issues.apache.org/jira/browse/CASSANDRA-16619
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18156) Test Failure: repair_tests.deprecated_repair_test.TestDeprecatedRepairNotifications.test_deprecated_repair_error_notification
[ https://issues.apache.org/jira/browse/CASSANDRA-18156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703561#comment-17703561 ] Berenguer Blasi commented on CASSANDRA-18156: - LGMT and failures are aligned to current CI status > Test Failure: > repair_tests.deprecated_repair_test.TestDeprecatedRepairNotifications.test_deprecated_repair_error_notification > - > > Key: CASSANDRA-18156 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18156 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Michael Semb Wever >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.x, 3.11.x > > > Failing since > https://ci-cassandra.apache.org/job/Cassandra-3.0/313/testReport/dtest.repair_tests.deprecated_repair_test/TestDeprecatedRepairNotifications > which is > https://github.com/apache/cassandra/commit/13d495aa7d5b7a7c121fcc9e105f79107c5c2a1c > from CASSANDRA-17254 > but can be reproduced earlier in circleci, e.g. > https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/64/workflows/f99abc05-aa9b-42de-a424-44ab7c247e76/jobs/3175 > > Only two commits are in this time-range (10th to 30th November) in > cassandra-dtest > - > https://github.com/apache/cassandra-dtest/commit/7f2b8eda5c52fb6f637aa7166e2d48cd34a64eec > (CASSANDRA-17679) > - > https://github.com/apache/cassandra-dtest/commit/e0d3cc90558a17b63634d15ee6df339ceb87b225 > (CASSANDRA-15402) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18156) Test Failure: repair_tests.deprecated_repair_test.TestDeprecatedRepairNotifications.test_deprecated_repair_error_notification
[ https://issues.apache.org/jira/browse/CASSANDRA-18156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Berenguer Blasi updated CASSANDRA-18156: Status: Ready to Commit (was: Review In Progress) > Test Failure: > repair_tests.deprecated_repair_test.TestDeprecatedRepairNotifications.test_deprecated_repair_error_notification > - > > Key: CASSANDRA-18156 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18156 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python >Reporter: Michael Semb Wever >Assignee: Brandon Williams >Priority: Normal > Fix For: 3.0.x, 3.11.x > > > Failing since > https://ci-cassandra.apache.org/job/Cassandra-3.0/313/testReport/dtest.repair_tests.deprecated_repair_test/TestDeprecatedRepairNotifications > which is > https://github.com/apache/cassandra/commit/13d495aa7d5b7a7c121fcc9e105f79107c5c2a1c > from CASSANDRA-17254 > but can be reproduced earlier in circleci, e.g. > https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/64/workflows/f99abc05-aa9b-42de-a424-44ab7c247e76/jobs/3175 > > Only two commits are in this time-range (10th to 30th November) in > cassandra-dtest > - > https://github.com/apache/cassandra-dtest/commit/7f2b8eda5c52fb6f637aa7166e2d48cd34a64eec > (CASSANDRA-17679) > - > https://github.com/apache/cassandra-dtest/commit/e0d3cc90558a17b63634d15ee6df339ceb87b225 > (CASSANDRA-15402) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17869) Add JDK17 option to cassandra-builds (build-scripts and jenkins dsl) and on jenkins agents
[
https://issues.apache.org/jira/browse/CASSANDRA-17869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Semb Wever updated CASSANDRA-17869:
---
Description:
Add JDK17 option to cassandra-builds build-scripts, they only currently support
options {{8}} and {{11}}.
Add JDK17 to the matrix axes in the jenkins dsl.
Ensure JDK17 is installed on all the jenkins agents.
was:
Add JDK17 option to cassandra-builds build-scripts, they only currently support
options {{8}} and {{1}}.
Add JDK17 to the matrix axes in the jenkins dsl.
Ensure JDK17 is installed on all the jenkins agents.
> Add JDK17 option to cassandra-builds (build-scripts and jenkins dsl) and on
> jenkins agents
> --
>
> Key: CASSANDRA-17869
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17869
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Add JDK17 option to cassandra-builds build-scripts, they only currently
> support options {{8}} and {{11}}.
> Add JDK17 to the matrix axes in the jenkins dsl.
> Ensure JDK17 is installed on all the jenkins agents.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18049) Update Chronicle Queue
[
https://issues.apache.org/jira/browse/CASSANDRA-18049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Semb Wever updated CASSANDRA-18049:
---
Fix Version/s: 5.0
(was: 5.x)
Source Control Link:
https://github.com/apache/cassandra/commit/eee211fdbb517c1b0e0a8635e0813bda7cf655e5
https://github.com/apache/cassandra-dtest/commit/24a677ac420ec64b98164c37a346dc5384582a7c
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
> Update Chronicle Queue
> --
>
> Key: CASSANDRA-18049
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18049
> Project: Cassandra
> Issue Type: Task
>Reporter: Ekaterina Dimitrova
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 5.0
>
>
> According to [this|https://chronicle.software/chronicle-support-java-17]
> article:
> {code:java}
> Starting from chronicle-bom-2.22ea26, all new releases can be run under Java
> 17 when run on the class path (but not yet under the module path).{code}
> This BOM is newer than what we currently have in both 4.1 and trunk. 4.1
> points in comments to
> [https://mvnrepository.com/artifact/net.openhft/chronicle-bom/1.16.23] which
> I believe was just forgotten to be updated/removed. The versions we see
> correspond to this BOM
> [https://mvnrepository.com/artifact/net.openhft/chronicle-bom/2.20.226]
> It is still older than chronicle-bom-2.22ea26 so we need to upgrade. I
> suggest we also add a comment again which BOM is considered, this makes
> things easier.
> Further to running CI, review of the CHANGE logs needs to happen to ensure we
> do not miss anything that can impact us and it is not caught by our tests.
> For testing with JDK17, please, contact [~e.dimitrova] for latest branch and
> CI config (at this point feature branch in the cassandra repo does not exist)
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18049) Update Chronicle Queue
[
https://issues.apache.org/jira/browse/CASSANDRA-18049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703532#comment-17703532
]
Michael Semb Wever commented on CASSANDRA-18049:
Committed:
-
https://github.com/apache/cassandra/commit/eee211fdbb517c1b0e0a8635e0813bda7cf655e5
-
https://github.com/apache/cassandra-dtest/commit/24a677ac420ec64b98164c37a346dc5384582a7c
> Update Chronicle Queue
> --
>
> Key: CASSANDRA-18049
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18049
> Project: Cassandra
> Issue Type: Task
>Reporter: Ekaterina Dimitrova
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 5.x
>
>
> According to [this|https://chronicle.software/chronicle-support-java-17]
> article:
> {code:java}
> Starting from chronicle-bom-2.22ea26, all new releases can be run under Java
> 17 when run on the class path (but not yet under the module path).{code}
> This BOM is newer than what we currently have in both 4.1 and trunk. 4.1
> points in comments to
> [https://mvnrepository.com/artifact/net.openhft/chronicle-bom/1.16.23] which
> I believe was just forgotten to be updated/removed. The versions we see
> correspond to this BOM
> [https://mvnrepository.com/artifact/net.openhft/chronicle-bom/2.20.226]
> It is still older than chronicle-bom-2.22ea26 so we need to upgrade. I
> suggest we also add a comment again which BOM is considered, this makes
> things easier.
> Further to running CI, review of the CHANGE logs needs to happen to ensure we
> do not miss anything that can impact us and it is not caught by our tests.
> For testing with JDK17, please, contact [~e.dimitrova] for latest branch and
> CI config (at this point feature branch in the cassandra repo does not exist)
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated: Update OpenHFT dependencies (chronicle-queue, chronicle-core, chronicle-bytes, chronicle-wire, chronicle-threads)
This is an automated email from the ASF dual-hosted git repository.
mck pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/trunk by this push:
new eee211fdbb Update OpenHFT dependencies (chronicle-queue,
chronicle-core, chronicle-bytes, chronicle-wire, chronicle-threads)
eee211fdbb is described below
commit eee211fdbb517c1b0e0a8635e0813bda7cf655e5
Author: Mick Semb Wever
AuthorDate: Fri Feb 10 09:16:14 2023 +0100
Update OpenHFT dependencies (chronicle-queue, chronicle-core,
chronicle-bytes, chronicle-wire, chronicle-threads)
Some transitive dependencies to these have also been added to raise their
versions. asm-* transitive dependencies have been excluded.
patch by Mick Semb Wever; reviewed by Ekaterina Dimitrova for
CASSANDRA-18049
---
.build/cassandra-deps-template.xml | 36 +
.build/parent-pom-template.xml | 89 +-
CHANGES.txt| 1 +
conf/jvm11-server.options | 1 +
conf/jvm17-server.options | 1 +
.../org/apache/cassandra/utils/binlog/BinLog.java | 12 ++-
6 files changed, 120 insertions(+), 20 deletions(-)
diff --git a/.build/cassandra-deps-template.xml
b/.build/cassandra-deps-template.xml
index b1db0fd0b7..69a184a832 100644
--- a/.build/cassandra-deps-template.xml
+++ b/.build/cassandra-deps-template.xml
@@ -183,6 +183,8 @@
io.netty
netty-all
+
+
net.openhft
chronicle-queue
@@ -203,6 +205,40 @@
net.openhft
chronicle-threads
+
+
+ net.openhft
+ posix
+
+
+
+ net.java.dev.jna
+ jna-platform
+
+
+
+ com.github.jnr
+ jnr-ffi
+
+
+
+ com.github.jnr
+ jffi
+
+
+
+ com.github.jnr
+ jffi
+ native
+
+
+
+ com.github.jnr
+ jnr-constants
+
+
+
+
org.fusesource
sigar
diff --git a/.build/parent-pom-template.xml b/.build/parent-pom-template.xml
index 6809fcd74a..70f85d033e 100644
--- a/.build/parent-pom-template.xml
+++ b/.build/parent-pom-template.xml
@@ -508,6 +508,57 @@
jna
5.13.0
+
+
+
+net.java.dev.jna
+jna-platform
+5.13.0
+
+
+
+com.github.jnr
+jnr-ffi
+2.2.13
+
+
+org.ow2.asm
+asm-analysis
+
+
+org.ow2.asm
+asm-commons
+
+
+org.ow2.asm
+asm-tree
+
+
+org.ow2.asm
+asm-util
+
+
+
+
+
+com.github.jnr
+jffi
+1.3.11
+
+
+
+com.github.jnr
+jffi
+native
+1.3.11
+
+
+
+com.github.jnr
+jnr-constants
+0.10.4
+
+
org.jacoco
org.jacoco.agent
@@ -645,7 +696,7 @@
net.openhft
chronicle-queue
-5.20.123
+5.23.37
tools
@@ -656,7 +707,7 @@
net.openhft
chronicle-core
-2.20.126
+2.23.36
chronicle-analytics
@@ -671,7 +722,7 @@
net.openhft
chronicle-bytes
-2.20.111
+2.23.33
annotations
@@ -682,7 +733,7 @@
net.openhft
chronicle-wire
-2.20.117
+2.23.39
compiler
@@ -693,21 +744,13 @@
net.openhft
chronicle-threads
-2.20.111
-
-
-affinity
-net.openhft
-
-
-jna
-net.java.dev.jna
-
-
-jna-platform
-net.java.dev.jna
-
-
+2.23.25
+
+
+
+net.openhft
+posix
+2.24ea4
com.google.code.findbugs
@@ -835,11 +878,18 @@
jctools-core
3.1.0
+
org.ow2.asm
asm
${asm.version}
+
+org.ow2.asm
+asm-analysis
+${asm.version}
+test
+
org.ow2.asm
asm-tree
@@ -858,6 +908,7 @@
${asm.version}
test
+
org.gridkit.jvmtool
sjk-cli
diff --git a/CHANGES.txt b/CHANGES.txt
index 149c9b0992..1b6dcf3c5e 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
5.0
+ * Update OpenHFT dependencies (chronicle-queue, chronicle-core,
chronicle-bytes, chronicle-wire, chronicle-threads)
[jira] [Commented] (CASSANDRA-14227) Extend maximum expiration date
[
https://issues.apache.org/jira/browse/CASSANDRA-14227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703527#comment-17703527
]
Berenguer Blasi commented on CASSANDRA-14227:
-
Perf check report post review and big rebase [^C14227 Perf check
2023.03.21.pdf] LGTM
> Extend maximum expiration date
> --
>
> Key: CASSANDRA-14227
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14227
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Local Write-Read Paths
>Reporter: Paulo Motta (Deprecated)
>Assignee: Berenguer Blasi
>Priority: Urgent
> Fix For: 5.x
>
> Attachments: C14227 Perf check 2023.03.21.pdf, screenshot-1.png,
> screenshot-2.png, screenshot-3.png, screenshot-4.png, unnamed-1.png
>
>
> The maximum expiration timestamp that can be represented by the storage
> engine is
> 2038-01-19T03:14:06+00:00 due to the encoding of {{localExpirationTime}} as
> an int32.
> On CASSANDRA-14092 we added an overflow policy which rejects requests with
> expiration above the maximum date as a temporary measure, but we should
> remove this limitation by updating the storage engine to support at least the
> maximum allowed TTL of 20 years.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-dtest] branch trunk updated: Configure auditlog and fqltool tests to do chronicle-queue file-shrinking synchronously
This is an automated email from the ASF dual-hosted git repository.
mck pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-dtest.git
The following commit(s) were added to refs/heads/trunk by this push:
new 24a677ac Configure auditlog and fqltool tests to do chronicle-queue
file-shrinking synchronously
24a677ac is described below
commit 24a677ac420ec64b98164c37a346dc5384582a7c
Author: Mick Semb Wever
AuthorDate: Sat Mar 11 23:32:22 2023 +0100
Configure auditlog and fqltool tests to do chronicle-queue file-shrinking
synchronously
patch by Mick Semb Wever; reviewed by Ekaterina Dimitrova for
CASSANDRA-18049
---
auditlog_test.py | 12 +++-
fqltool_test.py | 11 ++-
2 files changed, 13 insertions(+), 10 deletions(-)
diff --git a/auditlog_test.py b/auditlog_test.py
index eb16d6bd..76d022e4 100644
--- a/auditlog_test.py
+++ b/auditlog_test.py
@@ -14,6 +14,8 @@ from dtest import Tester
since = pytest.mark.since
logger = logging.getLogger(__name__)
+JVM_ARGS = ['-Dchronicle.queue.synchronousFileShrinking=true']
+
@since('4.0')
class TestAuditlog(Tester):
def test_archiving(self):
@@ -24,7 +26,7 @@ class TestAuditlog(Tester):
'audit_logs_dir': log_dir,
'roll_cycle': 'TEST_SECONDLY',
'archive_command':'%s %%path'%(move_script)}})
-cluster.populate(1).start()
+cluster.populate(1).start(jvm_args=JVM_ARGS)
node = cluster.nodelist()[0]
node.stress(['write', 'n=100k', "no-warmup", "cl=ONE", "-rate",
"threads=300"])
node.nodetool("disableauditlog")
@@ -38,7 +40,7 @@ class TestAuditlog(Tester):
moved_log_dir, move_script = self._create_script()
cluster.set_configuration_options(values={'full_query_logging_options':
{'log_dir': log_dir,
'archive_command': 'conf should not be used'}})
-cluster.populate(1).start()
+cluster.populate(1).start(jvm_args=JVM_ARGS)
node = cluster.nodelist()[0]
node.nodetool("enablefullquerylog --archive-command \"%s %%path\"
--roll-cycle=TEST_SECONDLY"%move_script)
node.stress(['write', 'n=100k', "no-warmup", "cl=ONE", "-rate",
"threads=300"])
@@ -58,7 +60,7 @@ class TestAuditlog(Tester):
cluster.set_configuration_options(values={'full_query_logging_options':
{'log_dir': log_dir,
'roll_cycle': 'TEST_SECONDLY',
'archive_command':'%s %%path'%(move_script)}})
-cluster.populate(1).start()
+cluster.populate(1).start(jvm_args=JVM_ARGS)
node = cluster.nodelist()[0]
node.nodetool("enablefullquerylog")
node.stress(['write', 'n=100k', "no-warmup", "cl=ONE", "-rate",
"threads=300"])
@@ -93,7 +95,7 @@ class TestAuditlog(Tester):
cluster.set_configuration_options(values={'full_query_logging_options':
{'log_dir': log_dir,
'roll_cycle': 'TEST_SECONDLY',
'archive_command':'%s %%path'%(move_script)}})
-cluster.populate(1).start()
+cluster.populate(1).start(jvm_args=JVM_ARGS)
node = cluster.nodelist()[0]
node.nodetool("enablefullquerylog")
@@ -110,7 +112,7 @@ class TestAuditlog(Tester):
cluster.set_configuration_options(values={'full_query_logging_options':
{'log_dir': log_dir,
'roll_cycle': 'TEST_SECONDLY',
'archive_command':'%s %%path'%(move_script)}})
-cluster.populate(1).start()
+cluster.populate(1).start(jvm_args=JVM_ARGS)
node = cluster.nodelist()[0]
node.nodetool("enablefullquerylog")
diff --git a/fqltool_test.py b/fqltool_test.py
index cfe590c4..4b4f379a 100644
--- a/fqltool_test.py
+++ b/fqltool_test.py
@@ -10,6 +10,7 @@ from shutil import rmtree
since = pytest.mark.since
logger = logging.getLogger(__name__)
+JVM_ARGS = ['-Dchronicle.queue.synchronousFileShrinking=true']
@since('4.0')
class TestFQLTool(Tester):
@@ -23,7 +24,7 @@ class TestFQLTool(Tester):
query log, then makes sure that the data is correct.
@jira_ticket CASSANDRA-14690
"""
-self.cluster.populate(2).start()
+self.cluster.populate(2).start(jvm_args=JVM_ARGS)
node1, node2 = self.cluster.nodelist()
with
[jira] [Updated] (CASSANDRA-14227) Extend maximum expiration date
[
https://issues.apache.org/jira/browse/CASSANDRA-14227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-14227:
Attachment: C14227 Perf check 2023.03.21.pdf
> Extend maximum expiration date
> --
>
> Key: CASSANDRA-14227
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14227
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Local Write-Read Paths
>Reporter: Paulo Motta (Deprecated)
>Assignee: Berenguer Blasi
>Priority: Urgent
> Fix For: 5.x
>
> Attachments: C14227 Perf check 2023.03.21.pdf, screenshot-1.png,
> screenshot-2.png, screenshot-3.png, screenshot-4.png, unnamed-1.png
>
>
> The maximum expiration timestamp that can be represented by the storage
> engine is
> 2038-01-19T03:14:06+00:00 due to the encoding of {{localExpirationTime}} as
> an int32.
> On CASSANDRA-14092 we added an overflow policy which rejects requests with
> expiration above the maximum date as a temporary measure, but we should
> remove this limitation by updating the storage engine to support at least the
> maximum allowed TTL of 20 years.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14632) cqlsh can't describe when index options contain unicode
[
https://issues.apache.org/jira/browse/CASSANDRA-14632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703510#comment-17703510
]
Michael Semb Wever commented on CASSANDRA-14632:
It was reported against 3.11
> cqlsh can't describe when index options contain unicode
>
>
> Key: CASSANDRA-14632
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14632
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Tools
>Reporter: Michael Semb Wever
>Priority: Normal
>
> The following `describe` fails in `cqlsh`:
>
> {code:java}
> $ cqlsh
> cqlsh> CREATE KEYSPACE test WITH replication = {'class': 'SimpleStrategy',
> 'replication_factor': 1};
> cqlsh> CREATE TABLE test ( one text, two int, three text, PRIMARY KEY
> (one,two) );
> cqlsh> CREATE CUSTOM INDEX ON test.test (three) USING
> 'org.apache.cassandra.index.sasi.SASIIndex' WITH OPTIONS = { 'delimiter':
> '░'};
> cqlsh> DESCRIBE KEYSPACE test ;
> 'ascii' codec can't decode byte 0xe2 in position 31: ordinal not in range(128)
> {code}
>
> Full error is
> {noformat}
> Traceback (most recent call last):
> File "/usr/bin/cqlsh.py", line 919, in onecmd
> self.handle_statement(st, statementtext)
> File "/usr/bin/cqlsh.py", line 956, in handle_statement
> return custom_handler(parsed)
> File "/usr/bin/cqlsh.py", line 1539, in do_describe
> self.describe_keyspace(ksname)
> File "/usr/bin/cqlsh.py", line 1275, in describe_keyspace
> self.print_recreate_keyspace(self.get_keyspace_meta(ksname), sys.stdout)
> File "/usr/bin/cqlsh.py", line 1225, in print_recreate_keyspace
> out.write(ksdef.export_as_string())
> File
> "/usr/share/cassandra/lib/cassandra-driver-internal-only-3.10.zip/cassandra-driver-3.10/cassandra/metadata.py",
> line 661, in export_as_string
> + [t.export_as_string() for t in self.tables.values()])
> File
> "/usr/share/cassandra/lib/cassandra-driver-internal-only-3.10.zip/cassandra-driver-3.10/cassandra/metadata.py",
> line 1116, in export_as_string
> ret = self._all_as_cql()
> File
> "/usr/share/cassandra/lib/cassandra-driver-internal-only-3.10.zip/cassandra-driver-3.10/cassandra/metadata.py",
> line 1125, in _all_as_cql
> ret += "\n%s;" % index.as_cql_query()
> File
> "/usr/share/cassandra/lib/cassandra-driver-internal-only-3.10.zip/cassandra-driver-3.10/cassandra/metadata.py",
> line 1402, in as_cql_query
> ret += " WITH OPTIONS = %s" %
> Encoder().cql_encode_all_types(options){noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (813ac80eb -> 9b51b3e32)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 813ac80eb generate docs for 8612e581 new 9b51b3e32 generate docs for 8612e581 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (813ac80eb) \ N -- N -- N refs/heads/asf-staging (9b51b3e32) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4796442 -> 4796442 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
