[jira] [Updated] (CASSANDRA-17194) Migrate thresholds for compaction to guardrails
[
https://issues.apache.org/jira/browse/CASSANDRA-17194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxwell Guo updated CASSANDRA-17194:
Status: Ready to Commit (was: Review In Progress)
> Migrate thresholds for compaction to guardrails
> ---
>
> Key: CASSANDRA-17194
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17194
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Migrate the existing thresholds for compaction:
> {code:java}
> compaction_large_partition_warning_threshold_mb: 100
> compaction_tombstone_warning_threshold: 10
> {code}
> To a new set of guardrails under the {{guardrails}} section, for example:
> {code:java}
> partition_size_warn_threshold: 50MiB
> partition_size_fail_threshold: 100MiB
> partition_tombstones_fail_threshold: 5
> partition_tombstones_fail_threshold: 10
> {code}
> Note that since these guardrails would be attached to a background process
> there wouldn't be abort/fail thresholds because we don't want to stop
> compaction.
> At the moment these thresholds are enabled by default, while guardrails are
> globally disabled by default, so we should consider whether we want to
> globally enable guardrails, or change these thresholds to disabled by
> default, or don't migrate the thresholds.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (f688bb92 -> 2c7cbf03)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard f688bb92 generate docs for 1b144e50 new 2c7cbf03 generate docs for 1b144e50 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (f688bb92) \ N -- N -- N refs/heads/asf-staging (2c7cbf03) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4796900 -> 4796900 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17194) Migrate thresholds for compaction to guardrails
[
https://issues.apache.org/jira/browse/CASSANDRA-17194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728216#comment-17728216
]
Berenguer Blasi commented on CASSANDRA-17194:
-
+1
> Migrate thresholds for compaction to guardrails
> ---
>
> Key: CASSANDRA-17194
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17194
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Migrate the existing thresholds for compaction:
> {code:java}
> compaction_large_partition_warning_threshold_mb: 100
> compaction_tombstone_warning_threshold: 10
> {code}
> To a new set of guardrails under the {{guardrails}} section, for example:
> {code:java}
> partition_size_warn_threshold: 50MiB
> partition_size_fail_threshold: 100MiB
> partition_tombstones_fail_threshold: 5
> partition_tombstones_fail_threshold: 10
> {code}
> Note that since these guardrails would be attached to a background process
> there wouldn't be abort/fail thresholds because we don't want to stop
> compaction.
> At the moment these thresholds are enabled by default, while guardrails are
> globally disabled by default, so we should consider whether we want to
> globally enable guardrails, or change these thresholds to disabled by
> default, or don't migrate the thresholds.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (f6c10391 -> f688bb92)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard f6c10391 generate docs for 1b144e50 new f688bb92 generate docs for 1b144e50 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (f6c10391) \ N -- N -- N refs/heads/asf-staging (f688bb92) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4796900 -> 4796900 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18559) Upgrade to 4.1.1 fails with NullPointerException
[
https://issues.apache.org/jira/browse/CASSANDRA-18559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Evans updated CASSANDRA-18559:
---
Since Version: 4.1.1
> Upgrade to 4.1.1 fails with NullPointerException
>
>
> Key: CASSANDRA-18559
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18559
> Project: Cassandra
> Issue Type: Bug
>Reporter: Eric Evans
>Priority: Normal
>
> When upgrading from 3.11.14 to 4.1.1 —and when {{internode_encryption}} is
> one of {{dc}} or {{{}rack{}}}— startup fails with an NPE.
>
> {noformat}
> io.netty.handler.codec.DecoderException: java.lang.NullPointerException
> at
> io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:478)
> at
> io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:276)
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
> at
> io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
> at
> io.netty.handler.codec.ByteToMessageDecoder.handlerRemoved(ByteToMessageDecoder.java:253)
> at
> io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:515)
> at
> io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:447)
> at
> io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:276)
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
> at
> io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
> at
> io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
> at
> io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919)
> at
> io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:795)
> at
> io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:480)
> at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:378)
> at
> io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989)
> at
> io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.lang.Thread.run(Thread.java:750)
> Caused by: java.lang.NullPointerException: null
> at
> org.apache.cassandra.locator.GossipingPropertyFileSnitch.getRack(GossipingPropertyFileSnitch.java:116)
> at
> org.apache.cassandra.locator.DynamicEndpointSnitch.getRack(DynamicEndpointSnitch.java:162)
> at
> org.apache.cassandra.config.EncryptionOptions$ServerEncryptionOptions.shouldEncrypt(EncryptionOptions.java:682)
> at
> org.apache.cassandra.net.InboundConnectionInitiator$Handler.isEncryptionRequired(InboundConnectionInitiator.java:363)
> at
> org.apache.cassandra.net.InboundConnectionInitiator$Handler.initiate(InboundConnectionInitiator.java:278)
> at
> org.apache.cassandra.net.InboundConnectionInitiator$Handler.decode(InboundConnectionInitiator.java:265)
> at
> io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:508)
> at
> io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:447)
> ... 22 common frames omitted
> {noformat}
>
> {noformat}
> io.netty.handler.codec.DecoderException: java.lang.NullPointerException
> at
> io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:478)
> at
> io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:276)
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
> at
> io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
> at
>
[jira] [Updated] (CASSANDRA-18559) Upgrade to 4.1.1 fails with NullPointerException
[
https://issues.apache.org/jira/browse/CASSANDRA-18559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Evans updated CASSANDRA-18559:
---
Description:
When upgrading from 3.11.14 to 4.1.1 —and when {{internode_encryption}} is one
of {{dc}} or {{{}rack{}}}— startup fails with an NPE.
{noformat}
io.netty.handler.codec.DecoderException: java.lang.NullPointerException
at
io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:478)
at
io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:276)
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
at
io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
at
io.netty.handler.codec.ByteToMessageDecoder.handlerRemoved(ByteToMessageDecoder.java:253)
at
io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:515)
at
io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:447)
at
io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:276)
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
at
io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
at
io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
at
io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919)
at
io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:795)
at
io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:480)
at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:378)
at
io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989)
at
io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
at
io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.lang.Thread.run(Thread.java:750)
Caused by: java.lang.NullPointerException: null
at
org.apache.cassandra.locator.GossipingPropertyFileSnitch.getRack(GossipingPropertyFileSnitch.java:116)
at
org.apache.cassandra.locator.DynamicEndpointSnitch.getRack(DynamicEndpointSnitch.java:162)
at
org.apache.cassandra.config.EncryptionOptions$ServerEncryptionOptions.shouldEncrypt(EncryptionOptions.java:682)
at
org.apache.cassandra.net.InboundConnectionInitiator$Handler.isEncryptionRequired(InboundConnectionInitiator.java:363)
at
org.apache.cassandra.net.InboundConnectionInitiator$Handler.initiate(InboundConnectionInitiator.java:278)
at
org.apache.cassandra.net.InboundConnectionInitiator$Handler.decode(InboundConnectionInitiator.java:265)
at
io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:508)
at
io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:447)
... 22 common frames omitted
{noformat}
{noformat}
io.netty.handler.codec.DecoderException: java.lang.NullPointerException
at
io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:478)
at
io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:276)
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
at
io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
at
io.netty.handler.codec.ByteToMessageDecoder.handlerRemoved(ByteToMessageDecoder.java:253)
at
io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:515)
at
io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:447)
at
io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:276)
at
[jira] [Created] (CASSANDRA-18559) Upgrade to 4.1.1 fails with NullPointerException
Eric Evans created CASSANDRA-18559:
--
Summary: Upgrade to 4.1.1 fails with NullPointerException
Key: CASSANDRA-18559
URL: https://issues.apache.org/jira/browse/CASSANDRA-18559
Project: Cassandra
Issue Type: Bug
Reporter: Eric Evans
When upgrading from 3.11.14 to 4.1.1 —and when {{internode_encryption}} is one
of {{dc}} or {{{}rack{}}}— startup fails with an NPE.
{noformat}
io.netty.handler.codec.DecoderException: java.lang.NullPointerException
at
io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:478)
at
io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:276)
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
at
io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
at
io.netty.handler.codec.ByteToMessageDecoder.handlerRemoved(ByteToMessageDecoder.java:253)
at
io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:515)
at
io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:447)
at
io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:276)
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
at
io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
at
io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
at
io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919)
at
io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:795)
at
io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:480)
at
io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:378)
at
io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989)
at
io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
at
io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.lang.Thread.run(Thread.java:750)
Caused by: java.lang.NullPointerException: null
at
org.apache.cassandra.locator.GossipingPropertyFileSnitch.getRack(GossipingPropertyFileSnitch.java:116)
at
org.apache.cassandra.locator.DynamicEndpointSnitch.getRack(DynamicEndpointSnitch.java:162)
at
org.apache.cassandra.config.EncryptionOptions$ServerEncryptionOptions.shouldEncrypt(EncryptionOptions.java:682)
at
org.apache.cassandra.net.InboundConnectionInitiator$Handler.isEncryptionRequired(InboundConnectionInitiator.java:363)
at
org.apache.cassandra.net.InboundConnectionInitiator$Handler.initiate(InboundConnectionInitiator.java:278)
at
org.apache.cassandra.net.InboundConnectionInitiator$Handler.decode(InboundConnectionInitiator.java:265)
at
io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:508)
at
io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:447)
... 22 common frames omitted
{noformat}
{noformat}
io.netty.handler.codec.DecoderException: java.lang.NullPointerException
at
io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:478)
at
io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:276)
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
at
io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
at
[jira] [Commented] (CASSANDRA-17194) Migrate thresholds for compaction to guardrails
[
https://issues.apache.org/jira/browse/CASSANDRA-17194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728179#comment-17728179
]
Maxwell Guo commented on CASSANDRA-17194:
-
of course, I'm +1 on this; [~bereng]WDYT?
> Migrate thresholds for compaction to guardrails
> ---
>
> Key: CASSANDRA-17194
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17194
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Migrate the existing thresholds for compaction:
> {code:java}
> compaction_large_partition_warning_threshold_mb: 100
> compaction_tombstone_warning_threshold: 10
> {code}
> To a new set of guardrails under the {{guardrails}} section, for example:
> {code:java}
> partition_size_warn_threshold: 50MiB
> partition_size_fail_threshold: 100MiB
> partition_tombstones_fail_threshold: 5
> partition_tombstones_fail_threshold: 10
> {code}
> Note that since these guardrails would be attached to a background process
> there wouldn't be abort/fail thresholds because we don't want to stop
> compaction.
> At the moment these thresholds are enabled by default, while guardrails are
> globally disabled by default, so we should consider whether we want to
> globally enable guardrails, or change these thresholds to disabled by
> default, or don't migrate the thresholds.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18190) ECJ upgrade
[ https://issues.apache.org/jira/browse/CASSANDRA-18190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728178#comment-17728178 ] Ekaterina Dimitrova commented on CASSANDRA-18190: - I started looking into the eclipse-warnings errors - ~360. I looked already in around 10, and all were false positives. I checked the bug tracker of ecj compiler, but so far, I found no related ticket filed. I suggest raising a bug report to the Eclipse community and putting this effort on hold until we get some fix/response. I will sleep on this and decide how to continue tomorrow. > ECJ upgrade > --- > > Key: CASSANDRA-18190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18190 > Project: Cassandra > Issue Type: Task > Components: Feature/UDF >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.x > > > During testing it was identified that we will need to update ECJ for the Java > UDF functions in order to bring Java 17 in. > It seems the compiler artifacts are moved from > [here|https://mvnrepository.com/artifact/org.eclipse.jdt.core.compiler/ecj ] > to [here|https://mvnrepository.com/artifact/org.eclipse.jdt/ecj] and there is > change of license from EPL1.0 to EPL2.0 too. But if I read correctly > [here|https://www.apache.org/legal/resolved.html#weak-copyleft-licenses] that > should not affect us > Further testing and review of all changes between artifacts to be done. > ECJ is used for the eclipse-warnings and Java UDFs -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18540) negotiatedProtocolMustBeAcceptedProtocolTest tests fail with "TLSv1.1 failed to negotiate" on JDK17
[
https://issues.apache.org/jira/browse/CASSANDRA-18540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-18540:
Reviewers: Ekaterina Dimitrova, Ekaterina Dimitrova
Ekaterina Dimitrova, Ekaterina Dimitrova (was: Ekaterina
Dimitrova)
Status: Review In Progress (was: Patch Available)
> negotiatedProtocolMustBeAcceptedProtocolTest tests fail with "TLSv1.1 failed
> to negotiate" on JDK17
> ---
>
> Key: CASSANDRA-18540
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18540
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: dan jatnieks
>Assignee: dan jatnieks
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Note: This depends on having a fix for CASSANDRA-18180, otherwise most/all
> tests in {{NativeTransportEncryptionOptionsTest}} and
> {{InternodeEncryptionOptionsTest}} are failing due to that issue.
> Using the patch for CASSANDRA-18180, the
> {{negotiatedProtocolMustBeAcceptedProtocolTest}} test in both
> {{NativeTransportEncryptionOptionsTest}} and
> {{InternodeEncryptionOptionsTest}} fails with "TLSv1.1 failed to negotiate"
> on JDK17.
> From what I can see, the {{negotiatedProtocolMustBeAcceptedProtocolTest}} is
> failing because in JDK11 and JDK17 the "TLSv1.1" protocol is disabled.
> Since TLSv1.1 is disabled in JDK11 and 17, one possibility is to change the
> test to use TLSv1.2 instead of TLSv1.1. That should work directly with JDK11
> and 17, since TLSv1.2 is one of the defaults, and it won't be an issue for
> JDK8 as that will be dropped.
> Also, I think the point of the
> {{negotiatedProtocolMustBeAcceptedProtocolTest}} is to test that the
> {{accepted_protocols}} option is working correctly rather than the choice of
> _which_ protocol is used. Meaning, I don’t think the intent was to test
> TLSv1.1 specifically, rather that the mechanism of accepted protocols works
> and choosing TLSv1.1 was at the time convenient - but I could be wrong.
> It also seems to me like bit of a coincidence that these tests are currently
> working on JDK11, at least on CI. Indeed, running locally with JDK11, these
> fail for me:
> {noformat}
> $ pwd
> /Users/dan.jatnieks/apache/cassandra-4.0
> $ java -version
> openjdk version "11.0.11" 2021-04-20
> OpenJDK Runtime Environment AdoptOpenJDK-11.0.11+9 (build 11.0.11+9)
> OpenJDK 64-Bit Server VM AdoptOpenJDK-11.0.11+9 (build 11.0.11+9, mixed mode)
> $ ant test-jvm-dtest-some
> -Dtest.name=org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest
> -Duse.jdk11=true
> ...
> [junit-timeout] Testcase:
> negotiatedProtocolMustBeAcceptedProtocolTest(org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest):
>FAILED
> [junit-timeout] Should be possible to establish a TLSv1.1 connection
> expected: but was:
> [junit-timeout] junit.framework.AssertionFailedError: Should be possible to
> establish a TLSv1.1 connection expected: but
> was:
> [junit-timeout] at
> org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest.negotiatedProtocolMustBeAcceptedProtocolTest(NativeTransportEncryptionOptionsTest.java:160)
> [junit-timeout] at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> [junit-timeout] at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> [junit-timeout] at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {noformat}
> I believe these work on CI because of CASSANDRA-16848 - in that ticket, after
> 2021-Apr JDK8 dropped TLSv1.1 which led to a fix in
> [cassandra-build|https://github.com/apache/cassandra-builds/commit/d1a3a0c59b3c5c17697d6a6656cd5d4f3a1cdbe9]
> docker code to make sure TLSv1.1 is accepted.
> I say coincidence because this change also makes it work for JDK11 and JDK17,
> and I've been able to verify that making a change locally to the JDK
> {{java.security}} file. I’m not sure that at the time of CASSANDRA-16848 it
> was intended for any JDK versions.
> The point of mentioning this is that if
> {{negotiatedProtocolMustBeAcceptedProtocolTest}} is changed to use TLSv1.2,
> and support for JDK8 is dropped, then the changes made in CASSANDRA-16848
> could also be reverted.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18540) negotiatedProtocolMustBeAcceptedProtocolTest tests fail with "TLSv1.1 failed to negotiate" on JDK17
[
https://issues.apache.org/jira/browse/CASSANDRA-18540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-18540:
Status: Changes Suggested (was: Review In Progress)
> negotiatedProtocolMustBeAcceptedProtocolTest tests fail with "TLSv1.1 failed
> to negotiate" on JDK17
> ---
>
> Key: CASSANDRA-18540
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18540
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: dan jatnieks
>Assignee: dan jatnieks
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Note: This depends on having a fix for CASSANDRA-18180, otherwise most/all
> tests in {{NativeTransportEncryptionOptionsTest}} and
> {{InternodeEncryptionOptionsTest}} are failing due to that issue.
> Using the patch for CASSANDRA-18180, the
> {{negotiatedProtocolMustBeAcceptedProtocolTest}} test in both
> {{NativeTransportEncryptionOptionsTest}} and
> {{InternodeEncryptionOptionsTest}} fails with "TLSv1.1 failed to negotiate"
> on JDK17.
> From what I can see, the {{negotiatedProtocolMustBeAcceptedProtocolTest}} is
> failing because in JDK11 and JDK17 the "TLSv1.1" protocol is disabled.
> Since TLSv1.1 is disabled in JDK11 and 17, one possibility is to change the
> test to use TLSv1.2 instead of TLSv1.1. That should work directly with JDK11
> and 17, since TLSv1.2 is one of the defaults, and it won't be an issue for
> JDK8 as that will be dropped.
> Also, I think the point of the
> {{negotiatedProtocolMustBeAcceptedProtocolTest}} is to test that the
> {{accepted_protocols}} option is working correctly rather than the choice of
> _which_ protocol is used. Meaning, I don’t think the intent was to test
> TLSv1.1 specifically, rather that the mechanism of accepted protocols works
> and choosing TLSv1.1 was at the time convenient - but I could be wrong.
> It also seems to me like bit of a coincidence that these tests are currently
> working on JDK11, at least on CI. Indeed, running locally with JDK11, these
> fail for me:
> {noformat}
> $ pwd
> /Users/dan.jatnieks/apache/cassandra-4.0
> $ java -version
> openjdk version "11.0.11" 2021-04-20
> OpenJDK Runtime Environment AdoptOpenJDK-11.0.11+9 (build 11.0.11+9)
> OpenJDK 64-Bit Server VM AdoptOpenJDK-11.0.11+9 (build 11.0.11+9, mixed mode)
> $ ant test-jvm-dtest-some
> -Dtest.name=org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest
> -Duse.jdk11=true
> ...
> [junit-timeout] Testcase:
> negotiatedProtocolMustBeAcceptedProtocolTest(org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest):
>FAILED
> [junit-timeout] Should be possible to establish a TLSv1.1 connection
> expected: but was:
> [junit-timeout] junit.framework.AssertionFailedError: Should be possible to
> establish a TLSv1.1 connection expected: but
> was:
> [junit-timeout] at
> org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest.negotiatedProtocolMustBeAcceptedProtocolTest(NativeTransportEncryptionOptionsTest.java:160)
> [junit-timeout] at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> [junit-timeout] at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> [junit-timeout] at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {noformat}
> I believe these work on CI because of CASSANDRA-16848 - in that ticket, after
> 2021-Apr JDK8 dropped TLSv1.1 which led to a fix in
> [cassandra-build|https://github.com/apache/cassandra-builds/commit/d1a3a0c59b3c5c17697d6a6656cd5d4f3a1cdbe9]
> docker code to make sure TLSv1.1 is accepted.
> I say coincidence because this change also makes it work for JDK11 and JDK17,
> and I've been able to verify that making a change locally to the JDK
> {{java.security}} file. I’m not sure that at the time of CASSANDRA-16848 it
> was intended for any JDK versions.
> The point of mentioning this is that if
> {{negotiatedProtocolMustBeAcceptedProtocolTest}} is changed to use TLSv1.2,
> and support for JDK8 is dropped, then the changes made in CASSANDRA-16848
> could also be reverted.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18540) negotiatedProtocolMustBeAcceptedProtocolTest tests fail with "TLSv1.1 failed to negotiate" on JDK17
[
https://issues.apache.org/jira/browse/CASSANDRA-18540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728176#comment-17728176
]
Ekaterina Dimitrova commented on CASSANDRA-18540:
-
The
[article|https://senthilnayagan.medium.com/tlsv1-and-tlsv1-1-protocols-disabled-by-default-in-javas-latest-patch-released-on-april-20-2021-52c309f6b16d]
posted in CASSANDRA-16848 points to disabling it in 8, 11, and 17 but not
removing it because there might still be legacy applications that require it.
I support the below statement from CASSANDRA-16848.
{quote}Bq. Given that users can still use TLSv1 and TLSv1.1 (older JDKs or
adjusting the java. security file), I would think it makes sense to keep the
tests for now.
{quote}
I suggest instead adding a comment and quoting the article in the test, so if
someone tries to run it locally and it fails, they can quickly figure out what
happened.
> negotiatedProtocolMustBeAcceptedProtocolTest tests fail with "TLSv1.1 failed
> to negotiate" on JDK17
> ---
>
> Key: CASSANDRA-18540
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18540
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: dan jatnieks
>Assignee: dan jatnieks
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Note: This depends on having a fix for CASSANDRA-18180, otherwise most/all
> tests in {{NativeTransportEncryptionOptionsTest}} and
> {{InternodeEncryptionOptionsTest}} are failing due to that issue.
> Using the patch for CASSANDRA-18180, the
> {{negotiatedProtocolMustBeAcceptedProtocolTest}} test in both
> {{NativeTransportEncryptionOptionsTest}} and
> {{InternodeEncryptionOptionsTest}} fails with "TLSv1.1 failed to negotiate"
> on JDK17.
> From what I can see, the {{negotiatedProtocolMustBeAcceptedProtocolTest}} is
> failing because in JDK11 and JDK17 the "TLSv1.1" protocol is disabled.
> Since TLSv1.1 is disabled in JDK11 and 17, one possibility is to change the
> test to use TLSv1.2 instead of TLSv1.1. That should work directly with JDK11
> and 17, since TLSv1.2 is one of the defaults, and it won't be an issue for
> JDK8 as that will be dropped.
> Also, I think the point of the
> {{negotiatedProtocolMustBeAcceptedProtocolTest}} is to test that the
> {{accepted_protocols}} option is working correctly rather than the choice of
> _which_ protocol is used. Meaning, I don’t think the intent was to test
> TLSv1.1 specifically, rather that the mechanism of accepted protocols works
> and choosing TLSv1.1 was at the time convenient - but I could be wrong.
> It also seems to me like bit of a coincidence that these tests are currently
> working on JDK11, at least on CI. Indeed, running locally with JDK11, these
> fail for me:
> {noformat}
> $ pwd
> /Users/dan.jatnieks/apache/cassandra-4.0
> $ java -version
> openjdk version "11.0.11" 2021-04-20
> OpenJDK Runtime Environment AdoptOpenJDK-11.0.11+9 (build 11.0.11+9)
> OpenJDK 64-Bit Server VM AdoptOpenJDK-11.0.11+9 (build 11.0.11+9, mixed mode)
> $ ant test-jvm-dtest-some
> -Dtest.name=org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest
> -Duse.jdk11=true
> ...
> [junit-timeout] Testcase:
> negotiatedProtocolMustBeAcceptedProtocolTest(org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest):
>FAILED
> [junit-timeout] Should be possible to establish a TLSv1.1 connection
> expected: but was:
> [junit-timeout] junit.framework.AssertionFailedError: Should be possible to
> establish a TLSv1.1 connection expected: but
> was:
> [junit-timeout] at
> org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest.negotiatedProtocolMustBeAcceptedProtocolTest(NativeTransportEncryptionOptionsTest.java:160)
> [junit-timeout] at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> [junit-timeout] at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> [junit-timeout] at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {noformat}
> I believe these work on CI because of CASSANDRA-16848 - in that ticket, after
> 2021-Apr JDK8 dropped TLSv1.1 which led to a fix in
> [cassandra-build|https://github.com/apache/cassandra-builds/commit/d1a3a0c59b3c5c17697d6a6656cd5d4f3a1cdbe9]
> docker code to make sure TLSv1.1 is accepted.
> I say coincidence because this change also makes it work for JDK11 and JDK17,
> and I've been able to verify that making a change locally to the JDK
> {{java.security}} file. I’m not sure that at the time of CASSANDRA-16848 it
> was intended for any JDK versions.
>
[jira] [Updated] (CASSANDRA-18180) bulkLoaderSuccessfullyStreamsOverSsl fails with ClassCastException on JDK17
[
https://issues.apache.org/jira/browse/CASSANDRA-18180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-18180:
Fix Version/s: 5.x
> bulkLoaderSuccessfullyStreamsOverSsl fails with ClassCastException on JDK17
> ---
>
> Key: CASSANDRA-18180
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18180
> Project: Cassandra
> Issue Type: Bug
> Components: CI
>Reporter: Ekaterina Dimitrova
>Assignee: dan jatnieks
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> While working on CASSANDRA-17992 we hit:
> {code:java}
> java.lang.ClassCastException: class
> org.apache.cassandra.utils.memory.BufferPool$Chunk cannot be cast to class
> sun.nio.ch.DirectBuffer (org.apache.cassandra.utils.memory.BufferPool$Chunk
> is in unnamed module of loader 'app'; sun.nio.ch.DirectBuffer is in module
> java.base of loader 'bootstrap')\n\tat
> java.base/com.sun.crypto.provider.GaloisCounterMode$GCMEngine.overlapDetection(GaloisCounterMode.java:865)\n\tat
>
> java.base/com.sun.crypto.provider.GaloisCounterMode$GCMDecrypt.doFinal(GaloisCounterMode.java:1502)\n\tat
>
> java.base/com.sun.crypto.provider.GaloisCounterMode.engineDoFinal(GaloisCounterMode.java:447)\n\tat
>
> {code}
> -The issue is exposed with JDK 17, trunk; if interested, ping- [~e.dimitrova]
> -for current branch as there is no feature branch at the moment- we can
> build and start from trunk with JDK17 already. Circle CI can be run for JDK17
> too. For more information how to do that - .circleci/readme.md
> CC [~benedict]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRASC-52) Sidecar Should Return Own Version in Node Settings
[ https://issues.apache.org/jira/browse/CASSANDRASC-52?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi reassigned CASSANDRASC-52: --- Assignee: Yuriy Semchyshyn (was: Dinesh Joshi) > Sidecar Should Return Own Version in Node Settings > -- > > Key: CASSANDRASC-52 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-52 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement >Reporter: Yuriy Semchyshyn >Assignee: Yuriy Semchyshyn >Priority: Normal > Labels: pull-request-available > > As of now, Sidecar's node settings endpoint returns Cassandra version and > partitioner only. > Sidecar should add its own build version into the node settings object for > reporting purposes. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-52) Sidecar Should Return Own Version in Node Settings
[ https://issues.apache.org/jira/browse/CASSANDRASC-52?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Joshi updated CASSANDRASC-52: Reviewers: Dinesh Joshi, Yifan Cai > Sidecar Should Return Own Version in Node Settings > -- > > Key: CASSANDRASC-52 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-52 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement >Reporter: Yuriy Semchyshyn >Assignee: Yuriy Semchyshyn >Priority: Normal > Labels: pull-request-available > > As of now, Sidecar's node settings endpoint returns Cassandra version and > partitioner only. > Sidecar should add its own build version into the node settings object for > reporting purposes. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18558) remove dh_python2 from debian packaging
[
https://issues.apache.org/jira/browse/CASSANDRA-18558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728157#comment-17728157
]
Brandon Williams commented on CASSANDRA-18558:
--
Test build on 3.11 (since that is currently broken) running:
[!https://ci-cassandra.apache.org/job/Cassandra-devbranch/2499/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/2499/pipeline]
> remove dh_python2 from debian packaging
> ---
>
> Key: CASSANDRA-18558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18558
> Project: Cassandra
> Issue Type: Bug
> Components: Packaging
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.x
>
>
> It looks like this has been removed from debian, but it also looks like we
> don't need it:
> {noformat}
> E: dh_python2 dh_python2:408: no package to act on (python-foo or one with
> ${python:Depends} in Depends)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18558) remove dh_python2 from debian packaging
[
https://issues.apache.org/jira/browse/CASSANDRA-18558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728156#comment-17728156
]
Brandon Williams commented on CASSANDRA-18558:
--
We should also see if our use of dh_python3 in later branches is needed.
> remove dh_python2 from debian packaging
> ---
>
> Key: CASSANDRA-18558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18558
> Project: Cassandra
> Issue Type: Bug
> Components: Packaging
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.x
>
>
> It looks like this has been removed from debian, but it also looks like we
> don't need it:
> {noformat}
> E: dh_python2 dh_python2:408: no package to act on (python-foo or one with
> ${python:Depends} in Depends)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18558) remove dh_python2 from debian packaging
[
https://issues.apache.org/jira/browse/CASSANDRA-18558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-18558:
-
Bug Category: Parent values: Packaging(13660)Level 1 values: Package
Distribution(13662)
Complexity: Normal
Discovered By: User Report
Fix Version/s: 3.0.x
3.11.x
4.0.x
4.1.x
5.x
Severity: Normal
Status: Open (was: Triage Needed)
> remove dh_python2 from debian packaging
> ---
>
> Key: CASSANDRA-18558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18558
> Project: Cassandra
> Issue Type: Bug
> Components: Packaging
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.x
>
>
> It looks like this has been removed from debian, but it also looks like we
> don't need it:
> {noformat}
> E: dh_python2 dh_python2:408: no package to act on (python-foo or one with
> ${python:Depends} in Depends)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-18558) remove dh_python2 from debian packaging
[
https://issues.apache.org/jira/browse/CASSANDRA-18558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams reassigned CASSANDRA-18558:
Assignee: Brandon Williams
> remove dh_python2 from debian packaging
> ---
>
> Key: CASSANDRA-18558
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18558
> Project: Cassandra
> Issue Type: Bug
> Components: Packaging
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
>
> It looks like this has been removed from debian, but it also looks like we
> don't need it:
> {noformat}
> E: dh_python2 dh_python2:408: no package to act on (python-foo or one with
> ${python:Depends} in Depends)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18558) remove dh_python2 from debian packaging
Brandon Williams created CASSANDRA-18558:
Summary: remove dh_python2 from debian packaging
Key: CASSANDRA-18558
URL: https://issues.apache.org/jira/browse/CASSANDRA-18558
Project: Cassandra
Issue Type: Bug
Components: Packaging
Reporter: Brandon Williams
It looks like this has been removed from debian, but it also looks like we
don't need it:
{noformat}
E: dh_python2 dh_python2:408: no package to act on (python-foo or one with
${python:Depends} in Depends)
{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-52) Sidecar Should Return Own Version in Node Settings
[ https://issues.apache.org/jira/browse/CASSANDRASC-52?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CASSANDRASC-52: -- Labels: pull-request-available (was: ) > Sidecar Should Return Own Version in Node Settings > -- > > Key: CASSANDRASC-52 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-52 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement >Reporter: Yuriy Semchyshyn >Assignee: Dinesh Joshi >Priority: Normal > Labels: pull-request-available > > As of now, Sidecar's node settings endpoint returns Cassandra version and > partitioner only. > Sidecar should add its own build version into the node settings object for > reporting purposes. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-52) Sidecar Should Return Own Version in Node Settings
[ https://issues.apache.org/jira/browse/CASSANDRASC-52?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuriy Semchyshyn updated CASSANDRASC-52: Source Control Link: https://github.com/apache/cassandra-sidecar/pull/47 > Sidecar Should Return Own Version in Node Settings > -- > > Key: CASSANDRASC-52 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-52 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement >Reporter: Yuriy Semchyshyn >Assignee: Dinesh Joshi >Priority: Normal > > As of now, Sidecar's node settings endpoint returns Cassandra version and > partitioner only. > Sidecar should add its own build version into the node settings object for > reporting purposes. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRASC-52) Sidecar Should Return Own Version in Node Settings
Yuriy Semchyshyn created CASSANDRASC-52: --- Summary: Sidecar Should Return Own Version in Node Settings Key: CASSANDRASC-52 URL: https://issues.apache.org/jira/browse/CASSANDRASC-52 Project: Sidecar for Apache Cassandra Issue Type: Improvement Reporter: Yuriy Semchyshyn Assignee: Dinesh Joshi As of now, Sidecar's node settings endpoint returns Cassandra version and partitioner only. Sidecar should add its own build version into the node settings object for reporting purposes. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRASC-51) Leverage in-jvm dtest framework for improved Sidecar testing
Doug Rohrer created CASSANDRASC-51: -- Summary: Leverage in-jvm dtest framework for improved Sidecar testing Key: CASSANDRASC-51 URL: https://issues.apache.org/jira/browse/CASSANDRASC-51 Project: Sidecar for Apache Cassandra Issue Type: Improvement Reporter: Doug Rohrer Today, the sidecar uses TestContainers ([testcontainers.org|http://testcontainers.org/]) and a single-node, single-data-directory Cassandra instance for all of its tests. While this has worked well so far, it is incapable of doing some of the more complex testing necessary to validate new endpoints and requires Docker locally and special CircleCI setup for CI builds. Now that the in-jvm dtest framework supports JMX, we can leverage it to do our testing in stead. It will enable us to do multi-node testing and exercise code paths under conditions like joining/leaving/moving nodes, which is critical for correctness. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18511) Add support for JMX in the in-jvm dtest framework
[ https://issues.apache.org/jira/browse/CASSANDRA-18511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Meredith updated CASSANDRA-18511: - Fix Version/s: 3.11.16 4.0.11 4.1.3 (was: 3.11.x) (was: 4.0.x) (was: 4.1.x) Source Control Link: https://github.com/apache/cassandra/commit/43ec1843918aba9e81d3c2dc1433a1ef4740a51f Resolution: Fixed Status: Resolved (was: Ready to Commit) > Add support for JMX in the in-jvm dtest framework > - > > Key: CASSANDRA-18511 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18511 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest/java >Reporter: Doug Rohrer >Assignee: Doug Rohrer >Priority: Normal > Labels: pull-request-available > Fix For: 3.11.16, 4.0.11, 4.1.3, 5.0 > > Time Spent: 5h 10m > Remaining Estimate: 0h > > In many cases, it would be useful to be able to enable JMX endpoints within > the in-jvm dtest framework, including the existing JMX Getter test, which > used to simply spin up a JMX registry and then leave it running. There are > quite a few JMX-related functions that don’t have tests today, and some > external usages of the in-jvm dtest framework could also benefit from > exposing JMX like we did Native before. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.0' into cassandra-4.1
This is an automated email from the ASF dual-hosted git repository.
jonmeredith pushed a commit to branch cassandra-4.1
in repository https://gitbox.apache.org/repos/asf/cassandra.git
commit 208a71c00841ae9e79a2f17496beb61d42486094
Merge: 441285d58e 57293e8281
Author: Jon Meredith
AuthorDate: Wed May 31 12:04:58 2023 -0600
Merge branch 'cassandra-4.0' into cassandra-4.1
build.xml | 9 +-
relocate-dependencies.pom | 2 +-
.../config/CassandraRelevantProperties.java| 16 ++
.../org/apache/cassandra/service/GCInspector.java | 8 +-
.../org/apache/cassandra/utils/JMXServerUtils.java | 28 ++-
.../org/apache/cassandra/utils/MBeanWrapper.java | 212 ++-
.../utils/RMIClientSocketFactoryImpl.java | 62 ++
.../apache/cassandra/utils/ReflectionUtils.java| 55 +
.../distributed/impl/AbstractCluster.java | 12 ++
.../impl/CollectingRMIServerSocketFactoryImpl.java | 87
.../distributed/impl/INodeProvisionStrategy.java | 11 +
.../cassandra/distributed/impl/Instance.java | 33 +++
.../cassandra/distributed/impl/InstanceConfig.java | 16 +-
.../cassandra/distributed/impl/IsolatedJmx.java| 230 +
.../distributed/test/ResourceLeakTest.java | 62 +-
.../distributed/test/jmx/JMXFeatureTest.java | 113 ++
.../distributed/test/jmx/JMXGetterCheckTest.java | 26 +--
.../distributed/test/metric/TableMetricTest.java | 29 ++-
18 files changed, 962 insertions(+), 49 deletions(-)
diff --cc build.xml
index e56c1f8e8a,f50cb9bf4d..da21569de7
--- a/build.xml
+++ b/build.xml
@@@ -152,8 -146,6 +152,8 @@@
-
++
+
diff --cc src/java/org/apache/cassandra/config/CassandraRelevantProperties.java
index 3e45ebc3ed,67637ac76e..75e36b4693
--- a/src/java/org/apache/cassandra/config/CassandraRelevantProperties.java
+++ b/src/java/org/apache/cassandra/config/CassandraRelevantProperties.java
@@@ -226,14 -209,9 +239,17 @@@ public enum CassandraRelevantPropertie
/** what class to use for mbean registeration */
MBEAN_REGISTRATION_CLASS("org.apache.cassandra.mbean_registration_class"),
+ /** This property indicates if the code is running under the in-jvm dtest
framework */
+ DTEST_IS_IN_JVM_DTEST("org.apache.cassandra.dtest.is_in_jvm_dtest"),
+
+
BATCH_COMMIT_LOG_SYNC_INTERVAL("cassandra.batch_commitlog_sync_interval_millis",
"1000"),
+
+SYSTEM_AUTH_DEFAULT_RF("cassandra.system_auth.default_rf", "1"),
+SYSTEM_TRACES_DEFAULT_RF("cassandra.system_traces.default_rf", "2"),
+SYSTEM_DISTRIBUTED_DEFAULT_RF("cassandra.system_distributed.default_rf",
"3"),
+
+MEMTABLE_OVERHEAD_SIZE("cassandra.memtable.row_overhead_size", "-1"),
+
MEMTABLE_OVERHEAD_COMPUTE_STEPS("cassandra.memtable_row_overhead_computation_step",
"10"),
MIGRATION_DELAY("cassandra.migration_delay_ms", "6"),
/** Defines how often schema definitions are pulled from the other nodes
*/
SCHEMA_PULL_INTERVAL_MS("cassandra.schema_pull_interval_ms", "6"),
diff --cc
test/distributed/org/apache/cassandra/distributed/impl/AbstractCluster.java
index 7d333726e5,fcbef4c220..47371772b9
---
a/test/distributed/org/apache/cassandra/distributed/impl/AbstractCluster.java
+++
b/test/distributed/org/apache/cassandra/distributed/impl/AbstractCluster.java
@@@ -183,9 -163,10 +183,11 @@@ public abstract class AbstractCluster<
extends org.apache.cassandra.distributed.shared.AbstractBuilder
{
private INodeProvisionStrategy.Strategy nodeProvisionStrategy =
INodeProvisionStrategy.Strategy.MultipleNetworkInterfaces;
+private ShutdownExecutor shutdownExecutor = DEFAULT_SHUTDOWN_EXECUTOR;
{
+ // Indicate that we are running in the in-jvm dtest environment
+
CassandraRelevantProperties.DTEST_IS_IN_JVM_DTEST.setBoolean(true);
// those properties may be set for unit-test optimizations; those
should not be used when running dtests
CassandraRelevantProperties.FLUSH_LOCAL_SCHEMA_CHANGES.reset();
CassandraRelevantProperties.NON_GRACEFUL_SHUTDOWN.reset();
diff --cc
test/distributed/org/apache/cassandra/distributed/impl/CollectingRMIServerSocketFactoryImpl.java
index 00,0f16286b4d..5e67eafef6
mode 00,100644..100644
---
a/test/distributed/org/apache/cassandra/distributed/impl/CollectingRMIServerSocketFactoryImpl.java
+++
b/test/distributed/org/apache/cassandra/distributed/impl/CollectingRMIServerSocketFactoryImpl.java
@@@ -1,0 -1,87 +1,87 @@@
+ /*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+
[cassandra] branch trunk updated (cccc46cb23 -> 4bcadc6bfb)
This is an automated email from the ASF dual-hosted git repository.
jonmeredith pushed a change to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra.git
from 46cb23 Merge branch 'cassandra-4.1' into trunk
new 43ec184391 Add support for JMX in the in-jvm dtest framework
new 57293e8281 Merge branch 'cassandra-3.11' into cassandra-4.0
new 208a71c008 Merge branch 'cassandra-4.0' into cassandra-4.1
new 4bcadc6bfb Merge branch 'cassandra-4.1' into trunk
The 4 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.build/parent-pom-template.xml | 2 +-
build.xml | 27 ++-
.../config/CassandraRelevantProperties.java| 12 ++
.../org/apache/cassandra/service/GCInspector.java | 8 +-
.../apache/cassandra/service/StorageService.java | 3 +-
.../org/apache/cassandra/utils/JMXServerUtils.java | 28 ++-
.../org/apache/cassandra/utils/MBeanWrapper.java | 208 ++-
.../RMIClientSocketFactoryImpl.java} | 37 ++--
.../apache/cassandra/utils/ReflectionUtils.java| 11 +-
.../distributed/impl/AbstractCluster.java | 2 +
.../impl/CollectingRMIServerSocketFactoryImpl.java | 88
.../distributed/impl/INodeProvisionStrategy.java | 11 +
.../cassandra/distributed/impl/Instance.java | 22 ++
.../cassandra/distributed/impl/InstanceConfig.java | 16 +-
.../cassandra/distributed/impl/IsolatedJmx.java| 230 +
.../distributed/test/ResourceLeakTest.java | 62 +-
.../distributed/test/VirtualTableLogsTest.java | 14 +-
.../distributed/test/jmx/JMXFeatureTest.java | 113 ++
.../distributed/test/jmx/JMXGetterCheckTest.java | 26 +--
.../distributed/test/metric/TableMetricTest.java | 29 ++-
20 files changed, 881 insertions(+), 68 deletions(-)
copy
src/java/org/apache/cassandra/{io/sstable/format/AbstractSSTableFormat.java =>
utils/RMIClientSocketFactoryImpl.java} (50%)
create mode 100644
test/distributed/org/apache/cassandra/distributed/impl/CollectingRMIServerSocketFactoryImpl.java
create mode 100644
test/distributed/org/apache/cassandra/distributed/impl/IsolatedJmx.java
create mode 100644
test/distributed/org/apache/cassandra/distributed/test/jmx/JMXFeatureTest.java
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-4.1' into trunk
This is an automated email from the ASF dual-hosted git repository. jonmeredith pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 4bcadc6bfb96e2d1693f74d5135c8408211beede Merge: 46cb23 208a71c008 Author: Jon Meredith AuthorDate: Wed May 31 12:27:36 2023 -0600 Merge branch 'cassandra-4.1' into trunk .build/parent-pom-template.xml | 2 +- build.xml | 27 ++- .../config/CassandraRelevantProperties.java| 12 ++ .../org/apache/cassandra/service/GCInspector.java | 8 +- .../apache/cassandra/service/StorageService.java | 3 +- .../org/apache/cassandra/utils/JMXServerUtils.java | 28 ++- .../org/apache/cassandra/utils/MBeanWrapper.java | 208 ++- .../utils/RMIClientSocketFactoryImpl.java | 62 ++ .../apache/cassandra/utils/ReflectionUtils.java| 11 +- .../distributed/impl/AbstractCluster.java | 2 + .../impl/CollectingRMIServerSocketFactoryImpl.java | 88 .../distributed/impl/INodeProvisionStrategy.java | 11 + .../cassandra/distributed/impl/Instance.java | 22 ++ .../cassandra/distributed/impl/InstanceConfig.java | 16 +- .../cassandra/distributed/impl/IsolatedJmx.java| 230 + .../distributed/test/ResourceLeakTest.java | 62 +- .../distributed/test/VirtualTableLogsTest.java | 14 +- .../distributed/test/jmx/JMXFeatureTest.java | 113 ++ .../distributed/test/jmx/JMXGetterCheckTest.java | 26 +-- .../distributed/test/metric/TableMetricTest.java | 29 ++- 20 files changed, 921 insertions(+), 53 deletions(-) diff --cc .build/parent-pom-template.xml index 7200bb43ee,00..e4b63bf3a8 mode 100644,00..100644 --- a/.build/parent-pom-template.xml +++ b/.build/parent-pom-template.xml @@@ -1,1052 -1,0 +1,1052 @@@ + + +http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd; xmlns="http://maven.apache.org/POM/4.0.0; +xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;> + 4.0.0 + +apache +org.apache +22 + + org.apache.cassandra + cassandra-parent + @version@ + pom + Apache Cassandra + The Apache Cassandra Project develops a highly scalable second-generation distributed database, bringing together Dynamo's fully distributed design and Bigtable's ColumnFamily-based data model. + https://cassandra.apache.org + 2009 + + + The Apache Software License, Version 2.0 + https://www.apache.org/licenses/LICENSE-2.0.txt + + + +1.12.13 +4.0.20 +0.5.1 + + +@asm.version@ +@jamm.version@ + @allocation-instrumenter.version@ +@ecj.version@ +@jacoco.version@ +@jflex.version@ + + + + adelapena + Andres de la Peña + + + alakshman + Avinash Lakshman + + + aleksey + Aleksey Yeschenko + + + amorton + Aaron Morton + + + aweisberg + Ariel Weisberg + + + bdeggleston + Blake Eggleston + + + benedict + Benedict Elliott Smith + + + benjamin + Benjamin Lerer + + + blambov + Branimir Lambov + + + brandonwilliams + Brandon Williams + + + carl + Carl Yeksigian + + + dbrosius + David Brosiusd + + + dikang + Dikang Gu + + + eevans + Eric Evans + + + edimitrova + Ekaterina Dimitrova + + + gdusbabek + Gary Dusbabek + + + goffinet + Chris Goffinet + + + ifesdjeen + Alex Petrov + + + jaakko + Laine Jaakko Olavi + + + jake + T Jake Luciani + + + jasonbrown + Jason Brown + + + jbellis + Jonathan Ellis + + + jfarrell + Jake Farrell + + + jjirsa + Jeff Jirsa + + + jkni + Joel Knighton + + + jmckenzie + Josh McKenzie + + + johan + Johan Oskarsson + + + junrao + Jun Rao + + + jzhuang + Jay Zhuang + + + kohlisankalp + Sankalp Kohli + + + marcuse + Marcus Eriksson + + + mck + Michael Semb Wever + + + mishail + Mikhail Stepura + + + mshuler + Michael Shuler + + + paulo + Paulo Motta + + + pmalik + Prashant Malik + + + rstupp + Robert Stupp + + + scode + Peter Schuller + + + beobal + Sam Tunnicliffe + + + slebresne + Sylvain Lebresne + + + stefania +
[cassandra] branch cassandra-4.0 updated (f66adb0278 -> 57293e8281)
This is an automated email from the ASF dual-hosted git repository.
jonmeredith pushed a change to branch cassandra-4.0
in repository https://gitbox.apache.org/repos/asf/cassandra.git
from f66adb0278 Remove unnecessary shuffling of GossipDigests in
Gossiper#makeRandomGossipDigest
new 43ec184391 Add support for JMX in the in-jvm dtest framework
new 57293e8281 Merge branch 'cassandra-3.11' into cassandra-4.0
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.build/build-resolver.xml | 2 +
build.xml | 9 +-
relocate-dependencies.pom | 2 +-
.../config/CassandraRelevantProperties.java| 16 ++
.../org/apache/cassandra/service/GCInspector.java | 8 +-
.../java/org/apache/cassandra/utils}/Isolated.java | 4 +-
.../org/apache/cassandra/utils/JMXServerUtils.java | 28 ++-
.../org/apache/cassandra/utils/MBeanWrapper.java | 212 ++-
.../org/apache/cassandra/utils/NativeLibrary.java | 2 +
.../cassandra/utils/NativeLibraryDarwin.java | 1 +
.../apache/cassandra/utils/NativeLibraryLinux.java | 1 +
.../cassandra/utils/NativeLibraryWindows.java | 1 +
.../cassandra/utils/NativeLibraryWrapper.java | 1 +
.../utils/RMIClientSocketFactoryImpl.java | 62 ++
.../apache/cassandra/utils/ReflectionUtils.java| 55 +
.../java/org/apache/cassandra/utils}/Shared.java | 2 +-
.../distributed/impl/AbstractCluster.java | 16 +-
.../impl/CollectingRMIServerSocketFactoryImpl.java | 87
.../distributed/impl/INodeProvisionStrategy.java | 11 +
.../cassandra/distributed/impl/Instance.java | 33 +++
.../cassandra/distributed/impl/InstanceConfig.java | 18 +-
.../distributed/impl/IsolatedExecutor.java | 2 +-
.../cassandra/distributed/impl/IsolatedJmx.java| 230 +
.../cassandra/distributed/shared/ClusterUtils.java | 1 +
.../test/BootstrapBinaryDisabledTest.java | 2 +-
.../distributed/test/ResourceLeakTest.java | 60 ++
.../distributed/test/jmx/JMXFeatureTest.java | 113 ++
.../distributed/test/jmx/JMXGetterCheckTest.java | 136
.../distributed/test/metric/TableMetricTest.java | 29 ++-
.../upgrade/MixedModeMessageForwardTest.java | 2 +-
30 files changed, 1107 insertions(+), 39 deletions(-)
rename {test/distributed/org/apache/cassandra/distributed/shared =>
src/java/org/apache/cassandra/utils}/Isolated.java (95%)
create mode 100644
src/java/org/apache/cassandra/utils/RMIClientSocketFactoryImpl.java
create mode 100644 src/java/org/apache/cassandra/utils/ReflectionUtils.java
rename {test/distributed/org/apache/cassandra/distributed/shared =>
src/java/org/apache/cassandra/utils}/Shared.java (96%)
create mode 100644
test/distributed/org/apache/cassandra/distributed/impl/CollectingRMIServerSocketFactoryImpl.java
create mode 100644
test/distributed/org/apache/cassandra/distributed/impl/IsolatedJmx.java
create mode 100644
test/distributed/org/apache/cassandra/distributed/test/jmx/JMXFeatureTest.java
create mode 100644
test/distributed/org/apache/cassandra/distributed/test/jmx/JMXGetterCheckTest.java
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.1 updated (441285d58e -> 208a71c008)
This is an automated email from the ASF dual-hosted git repository. jonmeredith pushed a change to branch cassandra-4.1 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 441285d58e Merge branch 'cassandra-4.0' into cassandra-4.1 new 43ec184391 Add support for JMX in the in-jvm dtest framework new 57293e8281 Merge branch 'cassandra-3.11' into cassandra-4.0 new 208a71c008 Merge branch 'cassandra-4.0' into cassandra-4.1 The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: build.xml | 9 +- relocate-dependencies.pom | 2 +- .../config/CassandraRelevantProperties.java| 16 ++ .../org/apache/cassandra/service/GCInspector.java | 8 +- .../org/apache/cassandra/utils/JMXServerUtils.java | 28 ++- .../org/apache/cassandra/utils/MBeanWrapper.java | 212 ++- .../utils/RMIClientSocketFactoryImpl.java | 62 ++ .../apache/cassandra/utils/ReflectionUtils.java| 55 + .../distributed/impl/AbstractCluster.java | 12 ++ .../impl/CollectingRMIServerSocketFactoryImpl.java | 87 .../distributed/impl/INodeProvisionStrategy.java | 11 + .../cassandra/distributed/impl/Instance.java | 33 +++ .../cassandra/distributed/impl/InstanceConfig.java | 16 +- .../cassandra/distributed/impl/IsolatedJmx.java| 230 + .../distributed/test/ResourceLeakTest.java | 62 +- .../distributed/test/jmx/JMXFeatureTest.java | 113 ++ .../distributed/test/jmx/JMXGetterCheckTest.java | 26 +-- .../distributed/test/metric/TableMetricTest.java | 29 ++- 18 files changed, 962 insertions(+), 49 deletions(-) create mode 100644 src/java/org/apache/cassandra/utils/RMIClientSocketFactoryImpl.java create mode 100644 src/java/org/apache/cassandra/utils/ReflectionUtils.java create mode 100644 test/distributed/org/apache/cassandra/distributed/impl/CollectingRMIServerSocketFactoryImpl.java create mode 100644 test/distributed/org/apache/cassandra/distributed/impl/IsolatedJmx.java create mode 100644 test/distributed/org/apache/cassandra/distributed/test/jmx/JMXFeatureTest.java - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.11 updated: Add support for JMX in the in-jvm dtest framework
This is an automated email from the ASF dual-hosted git repository.
jonmeredith pushed a commit to branch cassandra-3.11
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cassandra-3.11 by this push:
new 43ec184391 Add support for JMX in the in-jvm dtest framework
43ec184391 is described below
commit 43ec1843918aba9e81d3c2dc1433a1ef4740a51f
Author: Doug Rohrer
AuthorDate: Tue May 30 15:01:59 2023 -0600
Add support for JMX in the in-jvm dtest framework
patch by Doug Rohrer; reviewed by Alex Petrov, Jon Meredith, Francisco
Guerrero Hernandez for CASSANDRA-18511
---
.build/build-resolver.xml | 2 +
build.xml | 2 +-
.../org/apache/cassandra/service/GCInspector.java | 11 +-
.../org/apache/cassandra/utils/JMXServerUtils.java | 29 ++-
.../org/apache/cassandra/utils/MBeanWrapper.java | 272 ++---
.../utils/RMIClientSocketFactoryImpl.java | 62 +
.../distributed/impl/AbstractCluster.java | 15 ++
.../impl/CollectingRMIServerSocketFactoryImpl.java | 87 +++
.../cassandra/distributed/impl/Instance.java | 26 ++
.../cassandra/distributed/impl/InstanceConfig.java | 16 +-
.../distributed/impl/IsolatedExecutor.java | 2 +-
.../cassandra/distributed/impl/IsolatedJmx.java| 231 +
.../distributed/test/ResourceLeakTest.java | 60 +
.../distributed/test/jmx/JMXFeatureTest.java | 86 +++
.../distributed/test/jmx/JMXGetterCheckTest.java | 138 +++
15 files changed, 994 insertions(+), 45 deletions(-)
diff --git a/.build/build-resolver.xml b/.build/build-resolver.xml
index 698fb57718..99bfe4bdc7 100644
--- a/.build/build-resolver.xml
+++ b/.build/build-resolver.xml
@@ -51,6 +51,8 @@
+
+
diff --git a/build.xml b/build.xml
index 6985c8c45a..8f26c5e8f2 100644
--- a/build.xml
+++ b/build.xml
@@ -383,7 +383,7 @@
-
+
diff --git a/src/java/org/apache/cassandra/service/GCInspector.java
b/src/java/org/apache/cassandra/service/GCInspector.java
index 787d79a34f..0c0f9e4704 100644
--- a/src/java/org/apache/cassandra/service/GCInspector.java
+++ b/src/java/org/apache/cassandra/service/GCInspector.java
@@ -137,18 +137,17 @@ public class GCInspector implements NotificationListener,
GCInspectorMXBean
public GCInspector()
{
-MBeanServer mbs = ManagementFactory.getPlatformMBeanServer();
-
try
{
ObjectName gcName = new
ObjectName(ManagementFactory.GARBAGE_COLLECTOR_MXBEAN_DOMAIN_TYPE + ",*");
-for (ObjectName name : mbs.queryNames(gcName, null))
+for (ObjectName name : MBeanWrapper.instance.queryNames(gcName,
null))
{
-GarbageCollectorMXBean gc =
ManagementFactory.newPlatformMXBeanProxy(mbs, name.getCanonicalName(),
GarbageCollectorMXBean.class);
+GarbageCollectorMXBean gc =
ManagementFactory.newPlatformMXBeanProxy(MBeanWrapper.instance.getMBeanServer(),
name.getCanonicalName(), GarbageCollectorMXBean.class);
gcStates.put(gc.getName(), new GCState(gc,
assumeGCIsPartiallyConcurrent(gc), assumeGCIsOldGen(gc)));
}
-
-MBeanWrapper.instance.registerMBean(this, new
ObjectName(MBEAN_NAME));
+ObjectName me = new ObjectName(MBEAN_NAME);
+if (!MBeanWrapper.instance.isRegistered(me))
+MBeanWrapper.instance.registerMBean(this, me);
}
catch (Exception e)
{
diff --git a/src/java/org/apache/cassandra/utils/JMXServerUtils.java
b/src/java/org/apache/cassandra/utils/JMXServerUtils.java
index fc36c6c065..aad4f0512c 100644
--- a/src/java/org/apache/cassandra/utils/JMXServerUtils.java
+++ b/src/java/org/apache/cassandra/utils/JMXServerUtils.java
@@ -33,6 +33,7 @@ import java.rmi.RemoteException;
import java.rmi.registry.Registry;
import java.rmi.server.RMIClientSocketFactory;
import java.rmi.server.RMIServerSocketFactory;
+import java.rmi.server.UnicastRemoteObject;
import java.util.Arrays;
import java.util.HashMap;
import java.util.Map;
@@ -44,6 +45,7 @@ import javax.rmi.ssl.SslRMIClientSocketFactory;
import javax.rmi.ssl.SslRMIServerSocketFactory;
import javax.security.auth.Subject;
+import com.google.common.annotations.VisibleForTesting;
import com.google.common.collect.ImmutableMap;
import org.apache.commons.lang3.StringUtils;
import org.slf4j.Logger;
@@ -234,7 +236,8 @@ public class JMXServerUtils
return env;
}
-private static void logJmxServiceUrl(InetAddress serverAddress, int port)
+@VisibleForTesting
+public static void logJmxServiceUrl(InetAddress serverAddress, int port)
{
String urlTemplate =
[cassandra-website] branch asf-staging updated (785fc775 -> f6c10391)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 785fc775 generate docs for 1b144e50 new f6c10391 generate docs for 1b144e50 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (785fc775) \ N -- N -- N refs/heads/asf-staging (f6c10391) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4796900 -> 4796900 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18190) ECJ upgrade
[
https://issues.apache.org/jira/browse/CASSANDRA-18190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728070#comment-17728070
]
Ekaterina Dimitrova commented on CASSANDRA-18190:
-
Cross-posting from CASSANDRA-18239:
{quote}Some draft for using error-prone in the build
{quote}
That looks good, but unfortunately, to take advantage of the
[pattern|https://errorprone.info/bugpattern/MustBeClosedChecker] we are
interested in to replace eclipse-warnings, we need to start adding
@MustBeClosed for the methods that produce resources that must be closed.
I suspect this will regress quickly as we will be human-dependent; people will
start forgetting to use the annotation.
So to summarize:
* SpotBugs is not ready for newer JDK versions
* ErrorProne would involve manual work, and it will be human dependent
* sonar was mentioned not to be an option for direct replacement of eclipse
warnings
With that said, I should go back to CASSANDRA-18190 and review all the 100+ new
warnings we have with eclipse-warnings after upgrading it for newer JDK
versions...
> ECJ upgrade
> ---
>
> Key: CASSANDRA-18190
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18190
> Project: Cassandra
> Issue Type: Task
> Components: Feature/UDF
>Reporter: Ekaterina Dimitrova
>Assignee: Ekaterina Dimitrova
>Priority: Normal
> Fix For: 5.x
>
>
> During testing it was identified that we will need to update ECJ for the Java
> UDF functions in order to bring Java 17 in.
> It seems the compiler artifacts are moved from
> [here|https://mvnrepository.com/artifact/org.eclipse.jdt.core.compiler/ecj ]
> to [here|https://mvnrepository.com/artifact/org.eclipse.jdt/ecj] and there is
> change of license from EPL1.0 to EPL2.0 too. But if I read correctly
> [here|https://www.apache.org/legal/resolved.html#weak-copyleft-licenses] that
> should not affect us
> Further testing and review of all changes between artifacts to be done.
> ECJ is used for the eclipse-warnings and Java UDFs
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17194) Migrate thresholds for compaction to guardrails
[
https://issues.apache.org/jira/browse/CASSANDRA-17194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728047#comment-17728047
]
Andres de la Peña commented on CASSANDRA-17194:
---
[~bereng] [~maxwellguo] are we ready commit?
> Migrate thresholds for compaction to guardrails
> ---
>
> Key: CASSANDRA-17194
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17194
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Migrate the existing thresholds for compaction:
> {code:java}
> compaction_large_partition_warning_threshold_mb: 100
> compaction_tombstone_warning_threshold: 10
> {code}
> To a new set of guardrails under the {{guardrails}} section, for example:
> {code:java}
> partition_size_warn_threshold: 50MiB
> partition_size_fail_threshold: 100MiB
> partition_tombstones_fail_threshold: 5
> partition_tombstones_fail_threshold: 10
> {code}
> Note that since these guardrails would be attached to a background process
> there wouldn't be abort/fail thresholds because we don't want to stop
> compaction.
> At the moment these thresholds are enabled by default, while guardrails are
> globally disabled by default, so we should consider whether we want to
> globally enable guardrails, or change these thresholds to disabled by
> default, or don't migrate the thresholds.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18239) Replace eclipse warnings based static code analysis with something better (Sonar)
[
https://issues.apache.org/jira/browse/CASSANDRA-18239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728018#comment-17728018
]
Ekaterina Dimitrova edited comment on CASSANDRA-18239 at 5/31/23 3:03 PM:
--
{quote}some draft for using error-prone in the build
{quote}
That looks good, but unfortunately, to take advantage of the
[pattern|https://errorprone.info/bugpattern/MustBeClosedChecker] we are
interested in to replace eclipse-warnings, we need to start adding
@MustBeClosed for the methods that produce resources that must be closed.
I suspect this will regress quickly as we will be human-dependent; people will
start forgetting to use the annotation.
So to summarize:
* SpotBugs is not ready for newer JDK versions
* ErrorProne would involve manual work, and it will be human dependent
* sonar was mentioned not to be an option for direct replacement of eclipse
warnings
With that said, I should go back to CASSANDRA-18190 and review all the 100+ new
warnings we have with eclipse-warnings after upgrading it for newer JDK
versions...
was (Author: e.dimitrova):
{quote}some draft for using error-prone in the build
{quote}
That looks good, but unfortunately, to take advantage of the pattern we are
interested in to replace eclipse-warnings, we need to start adding
@MustBeClosed for the methods that produce resources that must be closed.
I suspect this will regress quickly as we will be human-dependent; people will
start forgetting to use the annotation.
So to summarize:
* SpotBugs is not ready for newer JDK versions
* ErrorProne would involve manual work, and it will be human dependent
* sonar was mentioned not to be an option for direct replacement of eclipse
warnings
With that said, I should go back to CASSANDRA-18190 and review all the 100+ new
warnings we have with eclipse-warnings after upgrading it for newer JDK
versions...
> Replace eclipse warnings based static code analysis with something better
> (Sonar)
> -
>
> Key: CASSANDRA-18239
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18239
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Jacek Lewandowski
>Priority: Normal
>
> Eclipse warnings is used for static code analysis. However, it does not fit
> well into Cassandra code and practically we end up explicitly adding
> suppressions in many places just to satisfy that tool rather than fix the
> real issues.
> This is an incomplete list of reasons to remove it:
> - not closed resources are detected incorrectly
> - does not recognize custom utility methods used to close the resources,
> which use use heavily in the code, like {{Throwables.close}},
> {{FileUtils.close}}, {{closeQuietly}}...
> - because of the above, we cannot make important things like {{Ref}} to
> implement {{Closeable}} as it would make the tool to explode with tons of
> warnings
> - it complains about correct generics - something like "method X is not
> applicable for ..." when the code compiles successfully is not acceptable
> - it is old and not maintained
> There are better tools like IntelliJ inspections for example, which can also
> be run in headless mode
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18239) Replace eclipse warnings based static code analysis with something better (Sonar)
[
https://issues.apache.org/jira/browse/CASSANDRA-18239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17728018#comment-17728018
]
Ekaterina Dimitrova commented on CASSANDRA-18239:
-
{quote}some draft for using error-prone in the build
{quote}
That looks good, but unfortunately, to take advantage of the pattern we are
interested in to replace eclipse-warnings, we need to start adding
@MustBeClosed for the methods that produce resources that must be closed.
I suspect this will regress quickly as we will be human-dependent; people will
start forgetting to use the annotation.
So to summarize:
* SpotBugs is not ready for newer JDK versions
* ErrorProne would involve manual work, and it will be human dependent
* sonar was mentioned not to be an option for direct replacement of eclipse
warnings
With that said, I should go back to CASSANDRA-18190 and review all the 100+ new
warnings we have with eclipse-warnings after upgrading it for newer JDK
versions...
> Replace eclipse warnings based static code analysis with something better
> (Sonar)
> -
>
> Key: CASSANDRA-18239
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18239
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Jacek Lewandowski
>Priority: Normal
>
> Eclipse warnings is used for static code analysis. However, it does not fit
> well into Cassandra code and practically we end up explicitly adding
> suppressions in many places just to satisfy that tool rather than fix the
> real issues.
> This is an incomplete list of reasons to remove it:
> - not closed resources are detected incorrectly
> - does not recognize custom utility methods used to close the resources,
> which use use heavily in the code, like {{Throwables.close}},
> {{FileUtils.close}}, {{closeQuietly}}...
> - because of the above, we cannot make important things like {{Ref}} to
> implement {{Closeable}} as it would make the tool to explode with tons of
> warnings
> - it complains about correct generics - something like "method X is not
> applicable for ..." when the code compiles successfully is not acceptable
> - it is old and not maintained
> There are better tools like IntelliJ inspections for example, which can also
> be run in headless mode
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18467) Update generate-idea-files for J17
[ https://issues.apache.org/jira/browse/CASSANDRA-18467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18467: Status: Changes Suggested (was: Review In Progress) > Update generate-idea-files for J17 > -- > > Key: CASSANDRA-18467 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18467 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Jakub Zytka >Priority: Low > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > There was a discussion in CASSANDRA-18258 how to update generate-idea-files. > The final agreement was to create one target to cover both Java 11 and Java > 17. > It will be good to figure out CASSANDRA-18263 and reshuffle arguments and > tasks based on what we decide to use as gc in testing for both Java 11 and > Java 17. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (c1fa74af -> 785fc775)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard c1fa74af generate docs for 1b144e50 new 785fc775 generate docs for 1b144e50 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (c1fa74af) \ N -- N -- N refs/heads/asf-staging (785fc775) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4796900 -> 4796900 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-18329) Upgrade jamm
[ https://issues.apache.org/jira/browse/CASSANDRA-18329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Lerer reassigned CASSANDRA-18329: -- Assignee: Benjamin Lerer > Upgrade jamm > > > Key: CASSANDRA-18329 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18329 > Project: Cassandra > Issue Type: Task > Components: Jamm >Reporter: Ekaterina Dimitrova >Assignee: Benjamin Lerer >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.x > > > Jamm is currently under maintenance that will solve JDK11 issues and enable > it to work with post JDK11+ versions up to JDK17. > This ticket will serve as a placeholder for upgrading Jamm in Cassandra when > the new Jamm release is out. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
