[jira] [Commented] (CASSANDRA-18438) Refactor the code for public cloud platform snitch to be configurable
[ https://issues.apache.org/jira/browse/CASSANDRA-18438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738869#comment-17738869 ] Maxwell Guo commented on CASSANDRA-18438: - [~smiklosovic] I can reassign this to you if you like > Refactor the code for public cloud platform snitch to be configurable > - > > Key: CASSANDRA-18438 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18438 > Project: Cassandra > Issue Type: Improvement > Components: Local/Other >Reporter: Maxwell Guo >Assignee: Maxwell Guo >Priority: Normal > Fix For: 5.x > > Time Spent: 20m > Remaining Estimate: 0h > > Nowadays we have got about four public cloud platform snitchs : EC2 snitch > for aws, google cloud snitch for google cloud, alibaba cloud snitch for > alibaba cloud and multi region snitch for ec2. And the common place for the > first three is that we just need to query the zone center to get the ec2 / > ecs id , so I think we can refactor the code , and if some new public cloud > platform want to add one more snitch for himself, there is no need to pull a > pr for him and configure some options in yaml is enough . > Besides it would be even better that we may reuse the multic region snitch > for ec2 for other public cloud platform. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18438) Refactor the code for public cloud platform snitch to be configurable
[ https://issues.apache.org/jira/browse/CASSANDRA-18438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738857#comment-17738857 ] Maxwell Guo commented on CASSANDRA-18438: - Thanks [~smiklosovic]. -> "I think that this approach is good enough in not repeating the same logic but flexible enough to implement something custom if necessary." So far ,I agree with the above point of view. If this also can met [~xgerman42] 's requirement , then I think it’s ok. If I encounter other needs in the future, I can open jira and do it again. Besides , I have a point that I want to discuss with you. There is a difference between the old version and the new version in the meta center of ec2, but the other two cloud platforms I see are similar. If Azure is the same(only need a a meta center url ), then can we template this similar in the future, configure the cloud platform name url center is enough and in the property file, and there is no need to customize the snitch code to implement some new snitch class besides we can re-use the ec2multiregion snitch if other cloud platform only need to provide public and private ip center url (as I know this feature is need for most users). Of course, there will be several problems in this way the firs is compatibility, but as I said before , if I encounter more needs, I may be inclined to do like this. > Refactor the code for public cloud platform snitch to be configurable > - > > Key: CASSANDRA-18438 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18438 > Project: Cassandra > Issue Type: Improvement > Components: Local/Other >Reporter: Maxwell Guo >Assignee: Maxwell Guo >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > Nowadays we have got about four public cloud platform snitchs : EC2 snitch > for aws, google cloud snitch for google cloud, alibaba cloud snitch for > alibaba cloud and multi region snitch for ec2. And the common place for the > first three is that we just need to query the zone center to get the ec2 / > ecs id , so I think we can refactor the code , and if some new public cloud > platform want to add one more snitch for himself, there is no need to pull a > pr for him and configure some options in yaml is enough . > Besides it would be even better that we may reuse the multic region snitch > for ec2 for other public cloud platform. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (dfad2b34a -> 6a014c33a)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard dfad2b34a generate docs for 466d6ffe new 6a014c33a generate docs for 466d6ffe This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (dfad2b34a) \ N -- N -- N refs/heads/asf-staging (6a014c33a) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: site-ui/build/ui-bundle.zip | Bin 4796900 -> 4796900 bytes 1 file changed, 0 insertions(+), 0 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17909) Clean SyncUtil from dead code and update it for new JDK versions
[ https://issues.apache.org/jira/browse/CASSANDRA-17909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17909: Status: Patch Available (was: Review In Progress) > Clean SyncUtil from dead code and update it for new JDK versions > > > Key: CASSANDRA-17909 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17909 > Project: Cassandra > Issue Type: Bug > Components: Local/Other >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.x > > > During code inspection I noticed [dead > code|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L77-L87] > (JDK 7) in SyncUtil. > From a very quick skim _I think_ the [Java 8 > section|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L65-L75] > is applicable in JDK 11, not sure for JDK 17 but it seems it should stay at > least until we have JDK11. To be revisited. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17909) Clean SyncUtil from dead code and update it for new JDK versions
[ https://issues.apache.org/jira/browse/CASSANDRA-17909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738831#comment-17738831 ] Ekaterina Dimitrova commented on CASSANDRA-17909: - CI results seem ok to me. Outstanding failures that do not match what we see with JDK17 are below, and they are unrelated to this ticket: * testTimeout [failed in the JDK17 run,|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2399/workflows/db9c862b-bf3b-4f5d-928b-530838b05e3c/jobs/28006/tests] but It doesn't seem related to what we do here. Running it in a loop on trunk without this patch proved it rare and flaky. I opened ticket CASSANDRA-18641 for it. * testPagingWithClustering-.jdk17 is a known failure from CASSANDRA-18432 > Clean SyncUtil from dead code and update it for new JDK versions > > > Key: CASSANDRA-17909 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17909 > Project: Cassandra > Issue Type: Bug > Components: Local/Other >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.x > > > During code inspection I noticed [dead > code|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L77-L87] > (JDK 7) in SyncUtil. > From a very quick skim _I think_ the [Java 8 > section|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L65-L75] > is applicable in JDK 11, not sure for JDK 17 but it seems it should stay at > least until we have JDK11. To be revisited. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18641) Fix flaky org.apache.cassandra.net.ConnectionTest.testTimeout
[ https://issues.apache.org/jira/browse/CASSANDRA-18641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738830#comment-17738830 ] Ekaterina Dimitrova edited comment on CASSANDRA-18641 at 6/30/23 12:19 AM: --- As per the run posted, I can see the assertion failing with different numbers like this: {code:java} org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a org.apache.cassandra.Util sent count values don't match Expected: <1L> but: was <8L> within 5 seconds. at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:165) at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119) at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31) at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:895) at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:679) at org.apache.cassandra.Util.spinAssertEquals(Util.java:691) at org.apache.cassandra.net.ConnectionUtils$OutboundCountChecker.lambda$check$0(ConnectionUtils.java:99) at org.apache.cassandra.net.ConnectionUtils$OutboundCountChecker.doCheck(ConnectionUtils.java:120) at org.apache.cassandra.net.ConnectionUtils$OutboundCountChecker.check(ConnectionUtils.java:99) at org.apache.cassandra.net.ConnectionTest.lambda$testTimeout$28(ConnectionTest.java:538) at org.apache.cassandra.net.ConnectionTest.lambda$doTest$8(ConnectionTest.java:246) at org.apache.cassandra.net.ConnectionTest.doTestManual(ConnectionTest.java:266) at org.apache.cassandra.net.ConnectionTest.doTest(ConnectionTest.java:244) at org.apache.cassandra.net.ConnectionTest.test(ConnectionTest.java:233) at org.apache.cassandra.net.ConnectionTest.testTimeout(ConnectionTest.java:507) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) Caused by: java.lang.AssertionError: sent count values don't match Expected: <1L> but: was <8L> at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at org.apache.cassandra.Util.lambda$spinAssertEquals$0(Util.java:691) at org.awaitility.core.AssertionCondition.lambda$new$0(AssertionCondition.java:53) at org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:222) at org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:209) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) at java.base/java.util.concurrent.ThreadPoolExecutor${code}{code} was (Author: e.dimitrova): As per the run posted, I can see the assertion failing with different numbers like this: {code:java} org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a org.apache.cassandra.Util sent count values don't match Expected: <1L> but: was <8L> within 5 seconds. at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:165) at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119) at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31) at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:895) at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:679) at org.apache.cassandra.Util.spinAssertEquals(Util.java:691) at org.apache.cassandra.net.ConnectionUtils$OutboundCountChecker.lambda$check$0(ConnectionUtils.java:99) at org.apache.cassandra.net.ConnectionUtils$OutboundCountChecker.doCheck(ConnectionUtils.java:120) at org.apache.cassandra.net.ConnectionUtils$OutboundCountChecker.check(ConnectionUtils.java:99) at org.apache.cassandra.net.ConnectionTest.lambda$testTimeout$28(ConnectionTest.java:538) at org.apache.cassandra.net.ConnectionTest.lambda$doTest$8(ConnectionTest.java:246) at org.apache.cassandra.net.ConnectionTest.doTestManual(ConnectionTest.java:266) at org.apache.cassandra.net.ConnectionTest.doTest(ConnectionTest.java:244) at org.apache.cassandra.net.ConnectionTest.test(ConnectionTest.java:233) at org.apache.cassandra.net.ConnectionTest.testTimeout(ConnectionTest.java:507) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) Caused by: java.lang.AssertionError: sent count values don't match Expected: <1L> but: was <8L> at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at org.apache.cassandra.Util.lambda$spinAssertEquals$0(Util.java:691) at
[jira] [Commented] (CASSANDRA-18641) Fix flaky org.apache.cassandra.net.ConnectionTest.testTimeout
[ https://issues.apache.org/jira/browse/CASSANDRA-18641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738830#comment-17738830 ] Ekaterina Dimitrova commented on CASSANDRA-18641: - As per the run posted, I can see the assertion failing with different numbers like this: {code:java} org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a org.apache.cassandra.Util sent count values don't match Expected: <1L> but: was <8L> within 5 seconds. at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:165) at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119) at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31) at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:895) at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:679) at org.apache.cassandra.Util.spinAssertEquals(Util.java:691) at org.apache.cassandra.net.ConnectionUtils$OutboundCountChecker.lambda$check$0(ConnectionUtils.java:99) at org.apache.cassandra.net.ConnectionUtils$OutboundCountChecker.doCheck(ConnectionUtils.java:120) at org.apache.cassandra.net.ConnectionUtils$OutboundCountChecker.check(ConnectionUtils.java:99) at org.apache.cassandra.net.ConnectionTest.lambda$testTimeout$28(ConnectionTest.java:538) at org.apache.cassandra.net.ConnectionTest.lambda$doTest$8(ConnectionTest.java:246) at org.apache.cassandra.net.ConnectionTest.doTestManual(ConnectionTest.java:266) at org.apache.cassandra.net.ConnectionTest.doTest(ConnectionTest.java:244) at org.apache.cassandra.net.ConnectionTest.test(ConnectionTest.java:233) at org.apache.cassandra.net.ConnectionTest.testTimeout(ConnectionTest.java:507) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) Caused by: java.lang.AssertionError: sent count values don't match Expected: <1L> but: was <8L> at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at org.apache.cassandra.Util.lambda$spinAssertEquals$0(Util.java:691) at org.awaitility.core.AssertionCondition.lambda$new$0(AssertionCondition.java:53) at org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:222) at org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:209) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) at java.base/java.util.concurrent.ThreadPoolExecutor${code} > Fix flaky org.apache.cassandra.net.ConnectionTest.testTimeout > - > > Key: CASSANDRA-18641 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18641 > Project: Cassandra > Issue Type: Bug > Components: CI >Reporter: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.x > > > [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2404/workflows/df5b69e6-78c0-41fc-9f37-3191a2578f6f/jobs/28590/tests] > {code:java} > org.awaitility.core.ConditionTimeoutException: Assertion condition defined as > a org.apache.cassandra.Util sent count values don't match Expected: <1L> but: > was <3L> within 5 seconds. at > org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:165) at > org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119) at > org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31) at > org.awaitility.core.ConditionFactory.until(ConditionFactory.java:895) at > org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:679) > at org.apache.cassandra.Util.spinAssertEquals(Util.java:691) at > org.apache.cassandra.net.ConnectionUtils$OutboundCountChecker.lambda$check$0(ConnectionUtils.java:99) > at > org.apache.cassandra.net.ConnectionUtils$OutboundCountChecker.doCheck(ConnectionUtils.java:120) > at > org.apache.cassandra.net.ConnectionUtils$OutboundCountChecker.check(ConnectionUtils.java:99) > at > org.apache.cassandra.net.ConnectionTest.lambda$testTimeout$28(ConnectionTest.java:538) > at > org.apache.cassandra.net.ConnectionTest.lambda$doTest$8(ConnectionTest.java:246) > at > org.apache.cassandra.net.ConnectionTest.doTestManual(ConnectionTest.java:266) > at org.apache.cassandra.net.ConnectionTest.doTest(ConnectionTest.java:244) at > org.apache.cassandra.net.ConnectionTest.test(ConnectionTest.java:233) at > org.apache.cassandra.net.ConnectionTest.testTimeout(ConnectionTest.java:507) > at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native > Method) at >
[jira] [Created] (CASSANDRA-18641) Fix flaky org.apache.cassandra.net.ConnectionTest.testTimeout
Ekaterina Dimitrova created CASSANDRA-18641: --- Summary: Fix flaky org.apache.cassandra.net.ConnectionTest.testTimeout Key: CASSANDRA-18641 URL: https://issues.apache.org/jira/browse/CASSANDRA-18641 Project: Cassandra Issue Type: Bug Reporter: Ekaterina Dimitrova [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2404/workflows/df5b69e6-78c0-41fc-9f37-3191a2578f6f/jobs/28590/tests] {code:java} org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a org.apache.cassandra.Util sent count values don't match Expected: <1L> but: was <3L> within 5 seconds. at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:165) at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119) at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31) at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:895) at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:679) at org.apache.cassandra.Util.spinAssertEquals(Util.java:691) at org.apache.cassandra.net.ConnectionUtils$OutboundCountChecker.lambda$check$0(ConnectionUtils.java:99) at org.apache.cassandra.net.ConnectionUtils$OutboundCountChecker.doCheck(ConnectionUtils.java:120) at org.apache.cassandra.net.ConnectionUtils$OutboundCountChecker.check(ConnectionUtils.java:99) at org.apache.cassandra.net.ConnectionTest.lambda$testTimeout$28(ConnectionTest.java:538) at org.apache.cassandra.net.ConnectionTest.lambda$doTest$8(ConnectionTest.java:246) at org.apache.cassandra.net.ConnectionTest.doTestManual(ConnectionTest.java:266) at org.apache.cassandra.net.ConnectionTest.doTest(ConnectionTest.java:244) at org.apache.cassandra.net.ConnectionTest.test(ConnectionTest.java:233) at org.apache.cassandra.net.ConnectionTest.testTimeout(ConnectionTest.java:507) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) Caused by: java.lang.AssertionError: sent count values don't match Expected: <1L> but: was <3L> at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at org.apache.cassandra.Util.lambda$spinAssertEquals$0(Util.java:691) at org.awaitility.core.AssertionCondition.lambda$new$0(AssertionCondition.java:53) at org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:222) at org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:209) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) at java.base/java.lang.Thread.run(Thread.java:833){code} -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18641) Fix flaky org.apache.cassandra.net.ConnectionTest.testTimeout
[ https://issues.apache.org/jira/browse/CASSANDRA-18641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18641: Bug Category: Parent values: Correctness(12982)Level 1 values: Test Failure(12990) Complexity: Normal Component/s: CI Discovered By: User Report Severity: Normal Status: Open (was: Triage Needed) > Fix flaky org.apache.cassandra.net.ConnectionTest.testTimeout > - > > Key: CASSANDRA-18641 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18641 > Project: Cassandra > Issue Type: Bug > Components: CI >Reporter: Ekaterina Dimitrova >Priority: Normal > > [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2404/workflows/df5b69e6-78c0-41fc-9f37-3191a2578f6f/jobs/28590/tests] > {code:java} > org.awaitility.core.ConditionTimeoutException: Assertion condition defined as > a org.apache.cassandra.Util sent count values don't match Expected: <1L> but: > was <3L> within 5 seconds. at > org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:165) at > org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119) at > org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31) at > org.awaitility.core.ConditionFactory.until(ConditionFactory.java:895) at > org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:679) > at org.apache.cassandra.Util.spinAssertEquals(Util.java:691) at > org.apache.cassandra.net.ConnectionUtils$OutboundCountChecker.lambda$check$0(ConnectionUtils.java:99) > at > org.apache.cassandra.net.ConnectionUtils$OutboundCountChecker.doCheck(ConnectionUtils.java:120) > at > org.apache.cassandra.net.ConnectionUtils$OutboundCountChecker.check(ConnectionUtils.java:99) > at > org.apache.cassandra.net.ConnectionTest.lambda$testTimeout$28(ConnectionTest.java:538) > at > org.apache.cassandra.net.ConnectionTest.lambda$doTest$8(ConnectionTest.java:246) > at > org.apache.cassandra.net.ConnectionTest.doTestManual(ConnectionTest.java:266) > at org.apache.cassandra.net.ConnectionTest.doTest(ConnectionTest.java:244) at > org.apache.cassandra.net.ConnectionTest.test(ConnectionTest.java:233) at > org.apache.cassandra.net.ConnectionTest.testTimeout(ConnectionTest.java:507) > at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native > Method) at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > Caused by: java.lang.AssertionError: sent count values don't match Expected: > <1L> but: was <3L> at > org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at > org.apache.cassandra.Util.lambda$spinAssertEquals$0(Util.java:691) at > org.awaitility.core.AssertionCondition.lambda$new$0(AssertionCondition.java:53) > at > org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:222) > at > org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:209) > at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at > java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) > at > java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) > at java.base/java.lang.Thread.run(Thread.java:833){code} -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18641) Fix flaky org.apache.cassandra.net.ConnectionTest.testTimeout
[ https://issues.apache.org/jira/browse/CASSANDRA-18641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18641: Fix Version/s: 5.x > Fix flaky org.apache.cassandra.net.ConnectionTest.testTimeout > - > > Key: CASSANDRA-18641 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18641 > Project: Cassandra > Issue Type: Bug > Components: CI >Reporter: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.x > > > [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2404/workflows/df5b69e6-78c0-41fc-9f37-3191a2578f6f/jobs/28590/tests] > {code:java} > org.awaitility.core.ConditionTimeoutException: Assertion condition defined as > a org.apache.cassandra.Util sent count values don't match Expected: <1L> but: > was <3L> within 5 seconds. at > org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:165) at > org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119) at > org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31) at > org.awaitility.core.ConditionFactory.until(ConditionFactory.java:895) at > org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:679) > at org.apache.cassandra.Util.spinAssertEquals(Util.java:691) at > org.apache.cassandra.net.ConnectionUtils$OutboundCountChecker.lambda$check$0(ConnectionUtils.java:99) > at > org.apache.cassandra.net.ConnectionUtils$OutboundCountChecker.doCheck(ConnectionUtils.java:120) > at > org.apache.cassandra.net.ConnectionUtils$OutboundCountChecker.check(ConnectionUtils.java:99) > at > org.apache.cassandra.net.ConnectionTest.lambda$testTimeout$28(ConnectionTest.java:538) > at > org.apache.cassandra.net.ConnectionTest.lambda$doTest$8(ConnectionTest.java:246) > at > org.apache.cassandra.net.ConnectionTest.doTestManual(ConnectionTest.java:266) > at org.apache.cassandra.net.ConnectionTest.doTest(ConnectionTest.java:244) at > org.apache.cassandra.net.ConnectionTest.test(ConnectionTest.java:233) at > org.apache.cassandra.net.ConnectionTest.testTimeout(ConnectionTest.java:507) > at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native > Method) at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > Caused by: java.lang.AssertionError: sent count values don't match Expected: > <1L> but: was <3L> at > org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at > org.apache.cassandra.Util.lambda$spinAssertEquals$0(Util.java:691) at > org.awaitility.core.AssertionCondition.lambda$new$0(AssertionCondition.java:53) > at > org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:222) > at > org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:209) > at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at > java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) > at > java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) > at java.base/java.lang.Thread.run(Thread.java:833){code} -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[GitHub] [cassandra-analytics] yifan-c commented on a diff in pull request #9: [CASSANDRA-18633] Added Caching of Node Settings to Improve Efficiency
yifan-c commented on code in PR #9: URL: https://github.com/apache/cassandra-analytics/pull/9#discussion_r1247271887 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraClusterInfo.java: ## @@ -338,11 +346,14 @@ public String getVersionFromFeature() public String getVersionFromSidecar() { -LOGGER.info("Getting Cassandra versions from all nodes"); -List allNodeSettings = Sidecar.allNodeSettingsBlocking(conf, - cassandraContext.getSidecarClient(), - cassandraContext.clusterConfig); -return getLowestVersion(allNodeSettings); +try +{ +return getLowestVersion(allNodeSettings.get()); +} +catch (InterruptedException | ExecutionException exception) Review Comment: for `InterruptedException`, it is better to restore the interrupted state for the thread. It might not be a big issue as the actual effect here is to exit the job, which makes the comment just a nit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[GitHub] [cassandra-analytics] yifan-c commented on a diff in pull request #9: [CASSANDRA-18633] Added Caching of Node Settings to Improve Efficiency
yifan-c commented on code in PR #9: URL: https://github.com/apache/cassandra-analytics/pull/9#discussion_r1247271887 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraClusterInfo.java: ## @@ -338,11 +346,14 @@ public String getVersionFromFeature() public String getVersionFromSidecar() { -LOGGER.info("Getting Cassandra versions from all nodes"); -List allNodeSettings = Sidecar.allNodeSettingsBlocking(conf, - cassandraContext.getSidecarClient(), - cassandraContext.clusterConfig); -return getLowestVersion(allNodeSettings); +try +{ +return getLowestVersion(allNodeSettings.get()); +} +catch (InterruptedException | ExecutionException exception) Review Comment: for `InterruptedException`, it is better to restore the interrupted state for the thread. It might not be a big issue as the actually effect here is to exit the job, which makes the comment just a nit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[GitHub] [cassandra-analytics] yifan-c commented on a diff in pull request #9: [CASSANDRA-18633] Added Caching of Node Settings to Improve Efficiency
yifan-c commented on code in PR #9: URL: https://github.com/apache/cassandra-analytics/pull/9#discussion_r1247271478 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraClusterInfo.java: ## @@ -64,11 +65,18 @@ public class CassandraClusterInfo implements ClusterInfo, Closeable protected transient GossipInfoResponse gossipInfo; protected transient CassandraContext cassandraContext; protected transient NodeSettings nodeSettings; +protected final transient CompletableFuture> allNodeSettings; public CassandraClusterInfo(BulkSparkConf conf) { this.conf = conf; this.cassandraContext = buildCassandraContext(); +this.allNodeSettings = CompletableFuture.supplyAsync(() -> { Review Comment: I think it is wasting one thread that is only used to wait for the blocking code to complete. The blocking code is actually a future underlying. `Sidecar.allNodeSettingsBlocking` could be revised to return the future directly, and rename the method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-18601) Repair vtable uses number of records rather than memory limits, which can cause more memory allocated than expected
[ https://issues.apache.org/jira/browse/CASSANDRA-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abe Ratnofsky reassigned CASSANDRA-18601: - Assignee: Abe Ratnofsky > Repair vtable uses number of records rather than memory limits, which can > cause more memory allocated than expected > --- > > Key: CASSANDRA-18601 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18601 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Repair >Reporter: David Capwell >Assignee: Abe Ratnofsky >Priority: Normal > > The config “repair_state_size” is used by 2 caches: the coordinator side of > repair, and the participate side of repair. At this point in time we use > number of records rather than memory side, and the default is 100k… In one > case it was found that there were 95k records of participate history causing > 550mb of allocation! > To resolve this we should: > 1) migrate to memory size > 2) have the 2 caches have 2 different configs (maybe you want more history > for one than the other?); this also makes things explicit and doesn’t have > any confusion in terms of cost (atm you can have 200k records for repair with > a 100k limit) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (5469afc28 -> dfad2b34a)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 5469afc28 generate docs for 466d6ffe new dfad2b34a generate docs for 466d6ffe This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (5469afc28) \ N -- N -- N refs/heads/asf-staging (dfad2b34a) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: site-ui/build/ui-bundle.zip | Bin 4796900 -> 4796900 bytes 1 file changed, 0 insertions(+), 0 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[GitHub] [cassandra-analytics] frankgh closed pull request #8: CASSANDRA-18631: Add Release Audit Tool (RAT) plugin to Analytics
frankgh closed pull request #8: CASSANDRA-18631: Add Release Audit Tool (RAT) plugin to Analytics URL: https://github.com/apache/cassandra-analytics/pull/8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[GitHub] [cassandra-analytics] frankgh commented on pull request #8: CASSANDRA-18631: Add Release Audit Tool (RAT) plugin to Analytics
frankgh commented on PR #8: URL: https://github.com/apache/cassandra-analytics/pull/8#issuecomment-1613876236 Closed via https://github.com/apache/cassandra-analytics/commit/02d9136cfa72c8990120eca0f4fe5f52587bceb5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18631) [Cassandra Analytics] Add Release Audit Tool (RAT) plugin
[ https://issues.apache.org/jira/browse/CASSANDRA-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRA-18631: -- Fix Version/s: NA Source Control Link: https://github.com/apache/cassandra-analytics/commit/02d9136cfa72c8990120eca0f4fe5f52587bceb5 Resolution: Fixed Status: Resolved (was: Ready to Commit) > [Cassandra Analytics] Add Release Audit Tool (RAT) plugin > - > > Key: CASSANDRA-18631 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18631 > Project: Cassandra > Issue Type: Improvement > Components: Analytics Library >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Fix For: NA > > Time Spent: 10m > Remaining Estimate: 0h > > Add the Release Audit Tool plugin to Cassandra Analytics to automate the > {{check}} process and make it part of the regular Analytics build. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-analytics] branch trunk updated: CASSANDRA-18631: Add Release Audit Tool (RAT) plugin to Analytics
This is an automated email from the ASF dual-hosted git repository. ycai pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra-analytics.git The following commit(s) were added to refs/heads/trunk by this push: new 02d9136 CASSANDRA-18631: Add Release Audit Tool (RAT) plugin to Analytics 02d9136 is described below commit 02d9136cfa72c8990120eca0f4fe5f52587bceb5 Author: Francisco Guerrero AuthorDate: Tue Jun 27 10:28:04 2023 -0700 CASSANDRA-18631: Add Release Audit Tool (RAT) plugin to Analytics This commit adds the Release Audit Tool (RAT) plugin to `build.gradle` which adds a new task `rat`. This new task makes sure that the license headers are valid and present in the source files during the `check` task. To run the RAT plugin, you can run: ``` ./gradlew rat ``` patch by Francisco Guerrero; reviewed by Dinesh Joshi, Michael Semb Wever for CASSANDRA-18631 --- .asf.yaml | 18 +++ .circleci/config.yml | 16 ++ DEV-README.md | 20 LICENSE.txt| 23 + README.md | 20 build.gradle | 57 +- cassandra-analytics-core-example/README.md | 20 cassandra-analytics-core/build.gradle | 3 +- .../spark/utils/streaming/SSTableInputStream.java | 12 ++--- cassandra-three-zero/TODO.md | 20 githooks/pre-push | 18 +++ 11 files changed, 217 insertions(+), 10 deletions(-) diff --git a/.asf.yaml b/.asf.yaml index 3861ca5..2388c89 100644 --- a/.asf.yaml +++ b/.asf.yaml @@ -1,3 +1,21 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + github: enabled_merge_buttons: squash: true diff --git a/.circleci/config.yml b/.circleci/config.yml index 2f6b769..4b9da6f 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -34,6 +34,10 @@ jobs: SCALA_VERSION: "2.11" JDK_VERSION: "1.8" + - store_artifacts: + path: build/reports + destination: test-reports + cassandra-analytics-core-spark2-2_12-jdk8: docker: - image: cimg/openjdk:8.0 @@ -50,6 +54,10 @@ jobs: SCALA_VERSION: "2.12" JDK_VERSION: "1.8" + - store_artifacts: + path: build/reports + destination: test-reports + cassandra-analytics-core-spark3-2_12-jdk11: docker: - image: cimg/openjdk:11.0 @@ -66,6 +74,10 @@ jobs: SCALA_VERSION: "2.12" JDK_VERSION: "11" + - store_artifacts: + path: build/reports + destination: test-reports + cassandra-analytics-core-spark3-2_13-jdk11: docker: - image: cimg/openjdk:11.0 @@ -82,6 +94,10 @@ jobs: SCALA_VERSION: "2.13" JDK_VERSION: "11" + - store_artifacts: + path: build/reports + destination: test-reports + workflows: version: 2 build-and-test: diff --git a/DEV-README.md b/DEV-README.md index d85755c..89791d1 100644 --- a/DEV-README.md +++ b/DEV-README.md @@ -1,3 +1,23 @@ + + # Cassandra Analytics Cassandra Analytics supports Spark 2 (Scala 2.11 and 2.12) and Spark 3 (Scala 2.12). diff --git a/LICENSE.txt b/LICENSE.txt index d645695..1170530 100644 --- a/LICENSE.txt +++ b/LICENSE.txt @@ -200,3 +200,26 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. + + APACHE CASSANDRA SIDECAR SUBCOMPONENTS: + + Apache Cassandra Sidecar includes a number of subcomponents with + separate copyright notices and license terms. Your use of the source + code for these subcomponents is subject to the terms and + conditions of the following licenses. + + This product bundles a file (FastByteOperations.java) from Guava, + copyright The Guava Authors, which is available under an + Apache License version 2. + + This product
[jira] [Commented] (CASSANDRA-18631) [Cassandra Analytics] Add Release Audit Tool (RAT) plugin
[ https://issues.apache.org/jira/browse/CASSANDRA-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738802#comment-17738802 ] Yifan Cai commented on CASSANDRA-18631: --- @mck +1'd in the PR. The patch is ready to commit. > [Cassandra Analytics] Add Release Audit Tool (RAT) plugin > - > > Key: CASSANDRA-18631 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18631 > Project: Cassandra > Issue Type: Improvement > Components: Analytics Library >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > Add the Release Audit Tool plugin to Cassandra Analytics to automate the > {{check}} process and make it part of the regular Analytics build. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18631) [Cassandra Analytics] Add Release Audit Tool (RAT) plugin
[ https://issues.apache.org/jira/browse/CASSANDRA-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRA-18631: -- Status: Ready to Commit (was: Review In Progress) > [Cassandra Analytics] Add Release Audit Tool (RAT) plugin > - > > Key: CASSANDRA-18631 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18631 > Project: Cassandra > Issue Type: Improvement > Components: Analytics Library >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > Add the Release Audit Tool plugin to Cassandra Analytics to automate the > {{check}} process and make it part of the regular Analytics build. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18631) [Cassandra Analytics] Add Release Audit Tool (RAT) plugin
[ https://issues.apache.org/jira/browse/CASSANDRA-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738802#comment-17738802 ] Yifan Cai edited comment on CASSANDRA-18631 at 6/29/23 10:01 PM: - [~mck] +1'd in the PR. The patch is ready to commit. was (Author: yifanc): @mck +1'd in the PR. The patch is ready to commit. > [Cassandra Analytics] Add Release Audit Tool (RAT) plugin > - > > Key: CASSANDRA-18631 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18631 > Project: Cassandra > Issue Type: Improvement > Components: Analytics Library >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > Add the Release Audit Tool plugin to Cassandra Analytics to automate the > {{check}} process and make it part of the regular Analytics build. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18631) [Cassandra Analytics] Add Release Audit Tool (RAT) plugin
[ https://issues.apache.org/jira/browse/CASSANDRA-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRA-18631: -- Reviewers: Dinesh Joshi, Michael Semb Wever Status: Review In Progress (was: Needs Committer) > [Cassandra Analytics] Add Release Audit Tool (RAT) plugin > - > > Key: CASSANDRA-18631 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18631 > Project: Cassandra > Issue Type: Improvement > Components: Analytics Library >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > Add the Release Audit Tool plugin to Cassandra Analytics to automate the > {{check}} process and make it part of the regular Analytics build. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18631) [Cassandra Analytics] Add Release Audit Tool (RAT) plugin
[ https://issues.apache.org/jira/browse/CASSANDRA-18631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francisco Guerrero updated CASSANDRA-18631: --- Status: Needs Committer (was: Patch Available) > [Cassandra Analytics] Add Release Audit Tool (RAT) plugin > - > > Key: CASSANDRA-18631 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18631 > Project: Cassandra > Issue Type: Improvement > Components: Analytics Library >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > Add the Release Audit Tool plugin to Cassandra Analytics to automate the > {{check}} process and make it part of the regular Analytics build. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18467) Update generate-idea-files for J17
[ https://issues.apache.org/jira/browse/CASSANDRA-18467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738790#comment-17738790 ] Michael Semb Wever commented on CASSANDRA-18467: [~jakubzytka], do you have an opinion on Jon's comment directly above? You added the .idea deletion in relation to this comment of yours: https://issues.apache.org/jira/browse/CASSANDRA-18467?focusedCommentId=17720607=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17720607 > Update generate-idea-files for J17 > -- > > Key: CASSANDRA-18467 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18467 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Jakub Zytka >Priority: Low > Fix For: 5.x > > Time Spent: 1h > Remaining Estimate: 0h > > There was a discussion in CASSANDRA-18258 how to update generate-idea-files. > The final agreement was to create one target to cover both Java 11 and Java > 17. > It will be good to figure out CASSANDRA-18263 and reshuffle arguments and > tasks based on what we decide to use as gc in testing for both Java 11 and > Java 17. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add a metadata option to sstabledump
[ https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738785#comment-17738785 ] Brandon Williams commented on CASSANDRA-18639: -- That makes more sense to me. > Add a metadata option to sstabledump > > > Key: CASSANDRA-18639 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18639 > Project: Cassandra > Issue Type: Improvement > Components: Tool/sstable >Reporter: Timothy Tu >Assignee: Timothy Tu >Priority: Normal > > The new -m option will output metadata information for: > * Partition Key Count > * SSTable Level > * Droppable Tombstones (%age) > * Min Timestamp > * Max Timestamp > * Duration > Partition key count is the total number of partitions in the sstable. Level > is zero for STCS and TWC, and varies for LTCS. > For Time Window Compaction (TWC), the min and max timestamps together with > duration describe the bounds of the time window in the table. > {quote}Partition Key Count: 24306 > Droppable Tombstones: 1000.0 (0.01%) > SSTable Level: 1 > Min Timestamp: 06/28/2023 15:15:04 > Max Timestamp: 06/28/2023 15:15:58 > Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53 > {quote} -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18467) Update generate-idea-files for J17
[ https://issues.apache.org/jira/browse/CASSANDRA-18467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738781#comment-17738781 ] Jon Meredith commented on CASSANDRA-18467: -- +1 on commit 596bfadab5e385ed254e34c38b8210311887c239 - I checked the JMXFeatureTest worked under Java 8/11/17. My only slight concern is the change to remove and existing .idea directory before regeneration, losing custom test configurations. They can be saved to the project directory instead if people still need them, but may be burned the first few times. > Update generate-idea-files for J17 > -- > > Key: CASSANDRA-18467 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18467 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Jakub Zytka >Priority: Low > Fix For: 5.x > > Time Spent: 1h > Remaining Estimate: 0h > > There was a discussion in CASSANDRA-18258 how to update generate-idea-files. > The final agreement was to create one target to cover both Java 11 and Java > 17. > It will be good to figure out CASSANDRA-18263 and reshuffle arguments and > tasks based on what we decide to use as gc in testing for both Java 11 and > Java 17. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18345) Enable streaming SAI components as part of repair
[ https://issues.apache.org/jira/browse/CASSANDRA-18345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caleb Rackliffe updated CASSANDRA-18345: Source Control Link: https://github.com/apache/cassandra/commit/5d3f257477cba2d7f33f842dba4582d0660f5738 (was: https://github.com/apache/cassandra/pull/2420) Resolution: Fixed Status: Resolved (was: Ready to Commit) Committed to {{cep-7-sai}} as https://github.com/apache/cassandra/commit/5d3f257477cba2d7f33f842dba4582d0660f5738 > Enable streaming SAI components as part of repair > - > > Key: CASSANDRA-18345 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18345 > Project: Cassandra > Issue Type: Improvement > Components: Feature/2i Index >Reporter: Mike Adamson >Assignee: Piotr Kolaczkowski >Priority: Normal > Labels: SAI > Fix For: 5.x > > Time Spent: 1h > Remaining Estimate: 0h > > SAI registers it's components with the SSTable descriptor expecting them to > form part of the SSTable lifecycle, including streaming. This is not the case. > The current SSTable format in Cassandra uses a fixed set of components > (Components.STREAMING_COMPONENTS) when streaming SSTables. This needs to > change to use the set of components that are registered with a specific > SSTable by calls to SSTable.registerComponents. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cep-7-sai updated: Stream all compatible components registered by an SSTable
This is an automated email from the ASF dual-hosted git repository. maedhroz pushed a commit to branch cep-7-sai in repository https://gitbox.apache.org/repos/asf/cassandra.git The following commit(s) were added to refs/heads/cep-7-sai by this push: new 5d3f257477 Stream all compatible components registered by an SSTable 5d3f257477 is described below commit 5d3f257477cba2d7f33f842dba4582d0660f5738 Author: Piotr Kołaczkowski AuthorDate: Thu Jun 15 15:07:18 2023 +0200 Stream all compatible components registered by an SSTable patch by Piotr Kołaczkowski; reviewed by Andrés de la Peña and Caleb Rackliffe for CASSANDRA-18345 --- .../CassandraEntireSSTableStreamReader.java| 2 +- .../db/streaming/CassandraOutgoingFile.java| 4 +- .../cassandra/db/streaming/ComponentContext.java | 6 +- .../cassandra/db/streaming/ComponentManifest.java | 12 +- .../index/sai/disk/format/IndexComponent.java | 18 +++ .../cassandra/index/sai/disk/format/Version.java | 9 +- .../index/sai/disk/v1/V1OnDiskFormat.java | 14 +- .../org/apache/cassandra/io/sstable/Component.java | 26 ++-- .../org/apache/cassandra/io/sstable/SSTable.java | 11 ++ .../io/sstable/SSTableZeroCopyWriter.java | 26 ++-- .../org/apache/cassandra/io/sstable/SSTable_API.md | 14 +- .../cassandra/io/sstable/format/SSTableFormat.java | 19 ++- .../cassandra/io/sstable/format/big/BigFormat.java | 20 +-- .../cassandra/io/sstable/format/bti/BtiFormat.java | 19 +-- .../distributed/test/sai/IndexStreamingTest.java | 155 + .../microbench/ZeroCopyStreamingBenchmark.java | 2 +- .../CassandraEntireSSTableStreamWriterTest.java| 4 +- .../db/streaming/CassandraStreamHeaderTest.java| 4 +- .../apache/cassandra/io/sstable/ComponentTest.java | 20 +-- .../io/sstable/SSTableZeroCopyWriterTest.java | 2 +- ...ntireSSTableStreamingCorrectFilesCountTest.java | 2 +- 21 files changed, 278 insertions(+), 111 deletions(-) diff --git a/src/java/org/apache/cassandra/db/streaming/CassandraEntireSSTableStreamReader.java b/src/java/org/apache/cassandra/db/streaming/CassandraEntireSSTableStreamReader.java index 9c5e048a12..98e2b6f7ef 100644 --- a/src/java/org/apache/cassandra/db/streaming/CassandraEntireSSTableStreamReader.java +++ b/src/java/org/apache/cassandra/db/streaming/CassandraEntireSSTableStreamReader.java @@ -121,7 +121,7 @@ public class CassandraEntireSSTableStreamReader implements IStreamReader prettyPrintMemory(bytesRead), prettyPrintMemory(totalSize)); -writer.writeComponent(component.type, in, length); +writer.writeComponent(component, in, length); session.progress(writer.descriptor.fileFor(component).toString(), ProgressInfo.Direction.IN, length, length, length); bytesRead += length; diff --git a/src/java/org/apache/cassandra/db/streaming/CassandraOutgoingFile.java b/src/java/org/apache/cassandra/db/streaming/CassandraOutgoingFile.java index 88ecff8a44..9569769eba 100644 --- a/src/java/org/apache/cassandra/db/streaming/CassandraOutgoingFile.java +++ b/src/java/org/apache/cassandra/db/streaming/CassandraOutgoingFile.java @@ -65,7 +65,7 @@ public class CassandraOutgoingFile implements OutgoingStream this.filename = sstable.getFilename(); this.shouldStreamEntireSSTable = computeShouldStreamEntireSSTables(); -ComponentManifest manifest = ComponentManifest.create(sstable.descriptor); +ComponentManifest manifest = ComponentManifest.create(sstable); this.header = makeHeader(sstable, operation, sections, estimatedKeys, shouldStreamEntireSSTable, manifest); } @@ -154,7 +154,7 @@ public class CassandraOutgoingFile implements OutgoingStream // redistribution, otherwise file sizes recorded in component manifest will be different from actual // file sizes. // Recreate the latest manifest and hard links for mutatable components in case they are modified. -try (ComponentContext context = sstable.runWithLock(ignored -> ComponentContext.create(sstable.descriptor))) +try (ComponentContext context = sstable.runWithLock(ignored -> ComponentContext.create(sstable))) { CassandraStreamHeader current = makeHeader(sstable, operation, sections, estimatedKeys, true, context.manifest()); CassandraStreamHeader.serializer.serialize(current, out, version); diff --git a/src/java/org/apache/cassandra/db/streaming/ComponentContext.java b/src/java/org/apache/cassandra/db/streaming/ComponentContext.java index 164dd6ba5c..c03e7b4c34 100644 --- a/src/java/org/apache/cassandra/db/streaming/ComponentContext.java +++ b/src/java/org/apache/cassandra/db/streaming/ComponentContext.java @@ -28,6 +28,7 @@ import org.slf4j.LoggerFactory; import
[jira] [Comment Edited] (CASSANDRA-18345) Enable streaming SAI components as part of repair
[ https://issues.apache.org/jira/browse/CASSANDRA-18345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738769#comment-17738769 ] Ekaterina Dimitrova edited comment on CASSANDRA-18345 at 6/29/23 8:24 PM: -- Happy to see people consider the JDK17 experimental CircleCI config. (Jenkins runs only the test suites that are already fixed, but we can run all tests and see the failures in CircleCI) List of failures we are still seeing is regularly updated in the description of CASSANDRA-16895. Last update: || ||Failing Test Classes||Ticket Numbers|| | |_Python DTests_| | |1|-test_sjk-|CASSANDRA-18343| | |_Java Ditributed Tests_| | |1-6|org.apache.cassandra.distributed.test.ReprepareOldBehaviourTest - all tests, org.apache.cassandra.distributed.test.PrepareBatchStatementsTest - all tests, org.apache.cassandra.distributed.test.IPMembershipTest - both tests, org.apache.cassandra.distributed.test.MixedModeFuzzTest, org.apache.cassandra.distributed.test.ReprepareFuzzTest, org.apache.cassandra.distributed.test.ReprepareNewBehaviourTest|CASSANDRA-16304| |7,8|-org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest - all tests- -org.apache.cassandra.distributed.test.InternodeEncryptionOptionsTest - all tests-|Both tests suffer from CASSANDRA-18180 - *ready to commit; blocked on being ready to drop JDK8* fwiw, using the CASSANDRA-18180 branch, only the negotiatedProtocolMustBeAcceptedProtocolTest fails in both these tests. EDIT: We will need a ticket for this one post CASSANDRA-18180. TLSv1.1 failed to negotiate (netty complains about certificate_unknown). Changes in JDK17 config to be checked - done EDIT2: CASSANDRA-18540| |-9-|-org.apache.cassandra.distributed.test.SSTableLoaderEncryptionOptionsTest - 2 tests-|CASSANDRA-18180 ready to commit; blocked on being ready to drop JDK8| | |_Unit Tests_| | |1|org.apache.cassandra.repair.RepairJobTest - 1 test|CASSANDRA-17884| |2|org.apache.cassandra.security.SSLFactoryTest - all tests|CASSANDRA-17992| |3,4|org.apache.cassandra.db.memtable.MemtableSizeOffheapBuffersTest, org.apache.cassandra.utils.concurrent.RefCountedTest|CASSANDRA-18329| |5,6|-org.apache.cassandra.cql3.validation.entities.UFJavaTest,- -org.apache.cassandra.cql3.validation.entities.UFSecurityTest-|CASSANDRA-18190; ready to commit; blocked on being ready to drop JDK8| |7|-org.apache.cassandra.cql3.EmptyValuesTest-|CASSANDRA-18436| |8|{-}org.apache.cassandra.transport.MessagePayloadTest{-}.jdk17-|CASSANDRA-18437| | |_Burn tests_| | |1|org.apache.cassandra.transport.DriverBurnTest.measureLargeV4WithCompression|CASSANDRA-18570| I keep on updating it regularly. was (Author: e.dimitrova): Happy to see people consider the JDK17 experimental CircleCI config. (Jenkins runs only the test suites that are already fixed, but we can run all tests and see the failures in CircleCI) List of failures we are still seeing is regularly updated in the description of CASSANDRA-16895. Last update: || ||Failing Test Classes||Ticket Numbers|| | |_Python DTests_| | |1|-test_sjk-|CASSANDRA-18343| | |_Java Ditributed Tests_| | |1-6|org.apache.cassandra.distributed.test.ReprepareOldBehaviourTest - all tests, org.apache.cassandra.distributed.test.PrepareBatchStatementsTest - all tests, org.apache.cassandra.distributed.test.IPMembershipTest - both tests, org.apache.cassandra.distributed.test.MixedModeFuzzTest, org.apache.cassandra.distributed.test.ReprepareFuzzTest, org.apache.cassandra.distributed.test.ReprepareNewBehaviourTest|CASSANDRA-16304| |7,8|-org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest - all tests- -org.apache.cassandra.distributed.test.InternodeEncryptionOptionsTest - all tests-|Both tests suffer from CASSANDRA-18180 - *ready to commit; blocked on being ready to drop JDK8* fwiw, using the CASSANDRA-18180 branch, only the negotiatedProtocolMustBeAcceptedProtocolTest fails in both these tests. EDIT: We will need a ticket for this one post CASSANDRA-18180. TLSv1.1 failed to negotiate (netty complains about certificate_unknown). Changes in JDK17 config to be checked - done EDIT2: CASSANDRA-18540| |-9-|-org.apache.cassandra.distributed.test.SSTableLoaderEncryptionOptionsTest - 2 tests-|CASSANDRA-18180 ready to commit; blocked on being ready to drop JDK8| | |_Unit Tests_| | |1|org.apache.cassandra.repair.RepairJobTest - 1 test|CASSANDRA-17884| |2|org.apache.cassandra.security.SSLFactoryTest - all tests|CASSANDRA-17992| |3,4|org.apache.cassandra.db.memtable.MemtableSizeOffheapBuffersTest, org.apache.cassandra.utils.concurrent.RefCountedTest|CASSANDRA-18329| |5,6|-org.apache.cassandra.cql3.validation.entities.UFJavaTest,- -org.apache.cassandra.cql3.validation.entities.UFSecurityTest-|CASSANDRA-18190; ready to commit; blocked on being ready to drop JDK8| |7|-org.apache.cassandra.cql3.EmptyValuesTest-|CASSANDRA-18436|
[jira] [Comment Edited] (CASSANDRA-18345) Enable streaming SAI components as part of repair
[ https://issues.apache.org/jira/browse/CASSANDRA-18345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738769#comment-17738769 ] Ekaterina Dimitrova edited comment on CASSANDRA-18345 at 6/29/23 8:23 PM: -- Happy to see people consider the JDK17 experimental CircleCI config. (Jenkins runs only the test suites that are already fixed, but we can run all tests and see the failures in CircleCI) List of failures we are still seeing is regularly updated in the description of CASSANDRA-16895. Last update: || ||Failing Test Classes||Ticket Numbers|| | |_Python DTests_| | |1|-test_sjk-|CASSANDRA-18343| | |_Java Ditributed Tests_| | |1-6|org.apache.cassandra.distributed.test.ReprepareOldBehaviourTest - all tests, org.apache.cassandra.distributed.test.PrepareBatchStatementsTest - all tests, org.apache.cassandra.distributed.test.IPMembershipTest - both tests, org.apache.cassandra.distributed.test.MixedModeFuzzTest, org.apache.cassandra.distributed.test.ReprepareFuzzTest, org.apache.cassandra.distributed.test.ReprepareNewBehaviourTest|CASSANDRA-16304| |7,8|-org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest - all tests- -org.apache.cassandra.distributed.test.InternodeEncryptionOptionsTest - all tests-|Both tests suffer from CASSANDRA-18180 - *ready to commit; blocked on being ready to drop JDK8* fwiw, using the CASSANDRA-18180 branch, only the negotiatedProtocolMustBeAcceptedProtocolTest fails in both these tests. EDIT: We will need a ticket for this one post CASSANDRA-18180. TLSv1.1 failed to negotiate (netty complains about certificate_unknown). Changes in JDK17 config to be checked - done EDIT2: CASSANDRA-18540| |-9-|-org.apache.cassandra.distributed.test.SSTableLoaderEncryptionOptionsTest - 2 tests-|CASSANDRA-18180 ready to commit; blocked on being ready to drop JDK8| | |_Unit Tests_| | |1|org.apache.cassandra.repair.RepairJobTest - 1 test|CASSANDRA-17884| |2|org.apache.cassandra.security.SSLFactoryTest - all tests|CASSANDRA-17992| |3,4|org.apache.cassandra.db.memtable.MemtableSizeOffheapBuffersTest, org.apache.cassandra.utils.concurrent.RefCountedTest|CASSANDRA-18329| |5,6|-org.apache.cassandra.cql3.validation.entities.UFJavaTest,- -org.apache.cassandra.cql3.validation.entities.UFSecurityTest-|CASSANDRA-18190; ready to commit; blocked on being ready to drop JDK8| |7|-org.apache.cassandra.cql3.EmptyValuesTest-|CASSANDRA-18436| |8|{-}org.apache.cassandra.transport.MessagePayloadTest{-}.jdk17-|CASSANDRA-18437| | |_Burn tests_| | |1|org.apache.cassandra.transport.DriverBurnTest.measureLargeV4WithCompression|CASSANDRA-18570| I keep on updating it. regularly. was (Author: e.dimitrova): Happy to see people consider the JDK17 experimental CircleCI config. (Jenkins runs only the test suites that are already fixed) List of failures we are still seeing is regularly updated in the description of CASSANDRA-16895. Last update: || ||Failing Test Classes||Ticket Numbers|| | |_Python DTests_| | |1|-test_sjk-|CASSANDRA-18343| | |_Java Ditributed Tests_| | |1-6|org.apache.cassandra.distributed.test.ReprepareOldBehaviourTest - all tests, org.apache.cassandra.distributed.test.PrepareBatchStatementsTest - all tests, org.apache.cassandra.distributed.test.IPMembershipTest - both tests, org.apache.cassandra.distributed.test.MixedModeFuzzTest, org.apache.cassandra.distributed.test.ReprepareFuzzTest, org.apache.cassandra.distributed.test.ReprepareNewBehaviourTest|CASSANDRA-16304| |7,8|-org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest - all tests- -org.apache.cassandra.distributed.test.InternodeEncryptionOptionsTest - all tests-|Both tests suffer from CASSANDRA-18180 - *ready to commit; blocked on being ready to drop JDK8* fwiw, using the CASSANDRA-18180 branch, only the negotiatedProtocolMustBeAcceptedProtocolTest fails in both these tests. EDIT: We will need a ticket for this one post CASSANDRA-18180. TLSv1.1 failed to negotiate (netty complains about certificate_unknown). Changes in JDK17 config to be checked - done EDIT2: CASSANDRA-18540| |-9-|-org.apache.cassandra.distributed.test.SSTableLoaderEncryptionOptionsTest - 2 tests-|CASSANDRA-18180 ready to commit; blocked on being ready to drop JDK8| | |_Unit Tests_| | |1|org.apache.cassandra.repair.RepairJobTest - 1 test|CASSANDRA-17884| |2|org.apache.cassandra.security.SSLFactoryTest - all tests|CASSANDRA-17992| |3,4|org.apache.cassandra.db.memtable.MemtableSizeOffheapBuffersTest, org.apache.cassandra.utils.concurrent.RefCountedTest|CASSANDRA-18329| |5,6|-org.apache.cassandra.cql3.validation.entities.UFJavaTest,- -org.apache.cassandra.cql3.validation.entities.UFSecurityTest-|CASSANDRA-18190; ready to commit; blocked on being ready to drop JDK8| |7|-org.apache.cassandra.cql3.EmptyValuesTest-|CASSANDRA-18436| |8|{-}org.apache.cassandra.transport.MessagePayloadTest{-}.jdk17-|CASSANDRA-18437| |
[jira] [Comment Edited] (CASSANDRA-18345) Enable streaming SAI components as part of repair
[ https://issues.apache.org/jira/browse/CASSANDRA-18345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738769#comment-17738769 ] Ekaterina Dimitrova edited comment on CASSANDRA-18345 at 6/29/23 8:23 PM: -- Happy to see people consider the JDK17 experimental CircleCI config. (Jenkins runs only the test suites that are already fixed) List of failures we are still seeing is regularly updated in the description of CASSANDRA-16895. Last update: || ||Failing Test Classes||Ticket Numbers|| | |_Python DTests_| | |1|-test_sjk-|CASSANDRA-18343| | |_Java Ditributed Tests_| | |1-6|org.apache.cassandra.distributed.test.ReprepareOldBehaviourTest - all tests, org.apache.cassandra.distributed.test.PrepareBatchStatementsTest - all tests, org.apache.cassandra.distributed.test.IPMembershipTest - both tests, org.apache.cassandra.distributed.test.MixedModeFuzzTest, org.apache.cassandra.distributed.test.ReprepareFuzzTest, org.apache.cassandra.distributed.test.ReprepareNewBehaviourTest|CASSANDRA-16304| |7,8|-org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest - all tests- -org.apache.cassandra.distributed.test.InternodeEncryptionOptionsTest - all tests-|Both tests suffer from CASSANDRA-18180 - *ready to commit; blocked on being ready to drop JDK8* fwiw, using the CASSANDRA-18180 branch, only the negotiatedProtocolMustBeAcceptedProtocolTest fails in both these tests. EDIT: We will need a ticket for this one post CASSANDRA-18180. TLSv1.1 failed to negotiate (netty complains about certificate_unknown). Changes in JDK17 config to be checked - done EDIT2: CASSANDRA-18540| |-9-|-org.apache.cassandra.distributed.test.SSTableLoaderEncryptionOptionsTest - 2 tests-|CASSANDRA-18180 ready to commit; blocked on being ready to drop JDK8| | |_Unit Tests_| | |1|org.apache.cassandra.repair.RepairJobTest - 1 test|CASSANDRA-17884| |2|org.apache.cassandra.security.SSLFactoryTest - all tests|CASSANDRA-17992| |3,4|org.apache.cassandra.db.memtable.MemtableSizeOffheapBuffersTest, org.apache.cassandra.utils.concurrent.RefCountedTest|CASSANDRA-18329| |5,6|-org.apache.cassandra.cql3.validation.entities.UFJavaTest,- -org.apache.cassandra.cql3.validation.entities.UFSecurityTest-|CASSANDRA-18190; ready to commit; blocked on being ready to drop JDK8| |7|-org.apache.cassandra.cql3.EmptyValuesTest-|CASSANDRA-18436| |8|{-}org.apache.cassandra.transport.MessagePayloadTest{-}.jdk17-|CASSANDRA-18437| | |_Burn tests_| | |1|org.apache.cassandra.transport.DriverBurnTest.measureLargeV4WithCompression|CASSANDRA-18570| I keep on updating it. regularly. was (Author: e.dimitrova): Happy to see people consider the JDK17 experimental CI run. List of failures we are still seeing is regularly updated in the description of CASSANDRA-16895. Last update: || ||Failing Test Classes||Ticket Numbers|| | |_Python DTests_| | |1|-test_sjk-|CASSANDRA-18343| | |_Java Ditributed Tests_| | |1-6|org.apache.cassandra.distributed.test.ReprepareOldBehaviourTest - all tests, org.apache.cassandra.distributed.test.PrepareBatchStatementsTest - all tests, org.apache.cassandra.distributed.test.IPMembershipTest - both tests, org.apache.cassandra.distributed.test.MixedModeFuzzTest, org.apache.cassandra.distributed.test.ReprepareFuzzTest, org.apache.cassandra.distributed.test.ReprepareNewBehaviourTest|CASSANDRA-16304| |7,8|-org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest - all tests- -org.apache.cassandra.distributed.test.InternodeEncryptionOptionsTest - all tests-|Both tests suffer from CASSANDRA-18180 - *ready to commit; blocked on being ready to drop JDK8* fwiw, using the CASSANDRA-18180 branch, only the negotiatedProtocolMustBeAcceptedProtocolTest fails in both these tests. EDIT: We will need a ticket for this one post CASSANDRA-18180. TLSv1.1 failed to negotiate (netty complains about certificate_unknown). Changes in JDK17 config to be checked - done EDIT2: CASSANDRA-18540| |-9-|-org.apache.cassandra.distributed.test.SSTableLoaderEncryptionOptionsTest - 2 tests-|CASSANDRA-18180 ready to commit; blocked on being ready to drop JDK8| | |_Unit Tests_| | |1|org.apache.cassandra.repair.RepairJobTest - 1 test|CASSANDRA-17884| |2|org.apache.cassandra.security.SSLFactoryTest - all tests|CASSANDRA-17992| |3,4|org.apache.cassandra.db.memtable.MemtableSizeOffheapBuffersTest, org.apache.cassandra.utils.concurrent.RefCountedTest|CASSANDRA-18329| |5,6|-org.apache.cassandra.cql3.validation.entities.UFJavaTest,- -org.apache.cassandra.cql3.validation.entities.UFSecurityTest-|CASSANDRA-18190; ready to commit; blocked on being ready to drop JDK8| |7|-org.apache.cassandra.cql3.EmptyValuesTest-|CASSANDRA-18436| |8|{-}org.apache.cassandra.transport.MessagePayloadTest{-}.jdk17-|CASSANDRA-18437| | |_Burn tests_| | |1|org.apache.cassandra.transport.DriverBurnTest.measureLargeV4WithCompression|CASSANDRA-18570| I keep on
[jira] [Commented] (CASSANDRA-18345) Enable streaming SAI components as part of repair
[ https://issues.apache.org/jira/browse/CASSANDRA-18345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738769#comment-17738769 ] Ekaterina Dimitrova commented on CASSANDRA-18345: - Happy to see people consider the JDK17 experimental CI run. List of failures we are still seeing is regularly updated in the description of CASSANDRA-16895. Last update: || ||Failing Test Classes||Ticket Numbers|| | |_Python DTests_| | |1|-test_sjk-|CASSANDRA-18343| | |_Java Ditributed Tests_| | |1-6|org.apache.cassandra.distributed.test.ReprepareOldBehaviourTest - all tests, org.apache.cassandra.distributed.test.PrepareBatchStatementsTest - all tests, org.apache.cassandra.distributed.test.IPMembershipTest - both tests, org.apache.cassandra.distributed.test.MixedModeFuzzTest, org.apache.cassandra.distributed.test.ReprepareFuzzTest, org.apache.cassandra.distributed.test.ReprepareNewBehaviourTest|CASSANDRA-16304| |7,8|-org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest - all tests- -org.apache.cassandra.distributed.test.InternodeEncryptionOptionsTest - all tests-|Both tests suffer from CASSANDRA-18180 - *ready to commit; blocked on being ready to drop JDK8* fwiw, using the CASSANDRA-18180 branch, only the negotiatedProtocolMustBeAcceptedProtocolTest fails in both these tests. EDIT: We will need a ticket for this one post CASSANDRA-18180. TLSv1.1 failed to negotiate (netty complains about certificate_unknown). Changes in JDK17 config to be checked - done EDIT2: CASSANDRA-18540| |-9-|-org.apache.cassandra.distributed.test.SSTableLoaderEncryptionOptionsTest - 2 tests-|CASSANDRA-18180 ready to commit; blocked on being ready to drop JDK8| | |_Unit Tests_| | |1|org.apache.cassandra.repair.RepairJobTest - 1 test|CASSANDRA-17884| |2|org.apache.cassandra.security.SSLFactoryTest - all tests|CASSANDRA-17992| |3,4|org.apache.cassandra.db.memtable.MemtableSizeOffheapBuffersTest, org.apache.cassandra.utils.concurrent.RefCountedTest|CASSANDRA-18329| |5,6|-org.apache.cassandra.cql3.validation.entities.UFJavaTest,- -org.apache.cassandra.cql3.validation.entities.UFSecurityTest-|CASSANDRA-18190; ready to commit; blocked on being ready to drop JDK8| |7|-org.apache.cassandra.cql3.EmptyValuesTest-|CASSANDRA-18436| |8|{-}org.apache.cassandra.transport.MessagePayloadTest{-}.jdk17-|CASSANDRA-18437| | |_Burn tests_| | |1|org.apache.cassandra.transport.DriverBurnTest.measureLargeV4WithCompression|CASSANDRA-18570| I keep on updating it. regularly. > Enable streaming SAI components as part of repair > - > > Key: CASSANDRA-18345 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18345 > Project: Cassandra > Issue Type: Improvement > Components: Feature/2i Index >Reporter: Mike Adamson >Assignee: Piotr Kolaczkowski >Priority: Normal > Labels: SAI > Fix For: 5.x > > Time Spent: 40m > Remaining Estimate: 0h > > SAI registers it's components with the SSTable descriptor expecting them to > form part of the SSTable lifecycle, including streaming. This is not the case. > The current SSTable format in Cassandra uses a fixed set of components > (Components.STREAMING_COMPONENTS) when streaming SSTables. This needs to > change to use the set of components that are registered with a specific > SSTable by calls to SSTable.registerComponents. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18345) Enable streaming SAI components as part of repair
[ https://issues.apache.org/jira/browse/CASSANDRA-18345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738757#comment-17738757 ] Caleb Rackliffe commented on CASSANDRA-18345: - [~adelapena] Yeah, fine w/ me > Enable streaming SAI components as part of repair > - > > Key: CASSANDRA-18345 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18345 > Project: Cassandra > Issue Type: Improvement > Components: Feature/2i Index >Reporter: Mike Adamson >Assignee: Piotr Kolaczkowski >Priority: Normal > Labels: SAI > Fix For: 5.x > > Time Spent: 40m > Remaining Estimate: 0h > > SAI registers it's components with the SSTable descriptor expecting them to > form part of the SSTable lifecycle, including streaming. This is not the case. > The current SSTable format in Cassandra uses a fixed set of components > (Components.STREAMING_COMPONENTS) when streaming SSTables. This needs to > change to use the set of components that are registered with a specific > SSTable by calls to SSTable.registerComponents. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18345) Enable streaming SAI components as part of repair
[ https://issues.apache.org/jira/browse/CASSANDRA-18345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738756#comment-17738756 ] Andres de la Peña edited comment on CASSANDRA-18345 at 6/29/23 7:49 PM: Here are some runs based on {{cep-7-sai}} for reference: * [https://app.circleci.com/pipelines/github/adelapena/cassandra/2994/workflows/520107d4-6890-45d4-bf15-22cfec2e01f5] * [https://app.circleci.com/pipelines/github/adelapena/cassandra/2994/workflows/92cb9830-3ad0-42bc-9a5b-931108934360] J17 looks more or less the same mess. I guess it will improve a bit with rebase, but even trunk has quite a bunch of failures for j17, see this run for a small PR over current trunk: [https://app.circleci.com/pipelines/github/adelapena/cassandra/2996/workflows/b6e8904f-6fbd-43b6-83af-3167c8e2040b/jobs/55699/tests] I guess we can merge based on the j11 results? was (Author: adelapena): Here are some runs based on {{cep-7-sai}} for reference: * [https://app.circleci.com/pipelines/github/adelapena/cassandra/2994/workflows/520107d4-6890-45d4-bf15-22cfec2e01f5] * [https://app.circleci.com/pipelines/github/adelapena/cassandra/2994/workflows/92cb9830-3ad0-42bc-9a5b-931108934360] J17 looks more or less the same mess. I guess it will improve a bit with rebase, but even trunk has quite a bunch of failures for j17, see this run for small PR over current trunk: [https://app.circleci.com/pipelines/github/adelapena/cassandra/2996/workflows/b6e8904f-6fbd-43b6-83af-3167c8e2040b/jobs/55699/tests] I guess we can merge based on the j11 results? > Enable streaming SAI components as part of repair > - > > Key: CASSANDRA-18345 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18345 > Project: Cassandra > Issue Type: Improvement > Components: Feature/2i Index >Reporter: Mike Adamson >Assignee: Piotr Kolaczkowski >Priority: Normal > Labels: SAI > Fix For: 5.x > > Time Spent: 40m > Remaining Estimate: 0h > > SAI registers it's components with the SSTable descriptor expecting them to > form part of the SSTable lifecycle, including streaming. This is not the case. > The current SSTable format in Cassandra uses a fixed set of components > (Components.STREAMING_COMPONENTS) when streaming SSTables. This needs to > change to use the set of components that are registered with a specific > SSTable by calls to SSTable.registerComponents. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18345) Enable streaming SAI components as part of repair
[ https://issues.apache.org/jira/browse/CASSANDRA-18345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738756#comment-17738756 ] Andres de la Peña commented on CASSANDRA-18345: --- Here are some runs based on {{cep-7-sai}} for reference: * [https://app.circleci.com/pipelines/github/adelapena/cassandra/2994/workflows/520107d4-6890-45d4-bf15-22cfec2e01f5] * [https://app.circleci.com/pipelines/github/adelapena/cassandra/2994/workflows/92cb9830-3ad0-42bc-9a5b-931108934360] J17 looks more or less the same mess. I guess it will improve a bit with rebase, but even trunk has quite a bunch of failures for j17, see this run for small PR over current trunk: [https://app.circleci.com/pipelines/github/adelapena/cassandra/2996/workflows/b6e8904f-6fbd-43b6-83af-3167c8e2040b/jobs/55699/tests] I guess we can merge based on the j11 results? > Enable streaming SAI components as part of repair > - > > Key: CASSANDRA-18345 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18345 > Project: Cassandra > Issue Type: Improvement > Components: Feature/2i Index >Reporter: Mike Adamson >Assignee: Piotr Kolaczkowski >Priority: Normal > Labels: SAI > Fix For: 5.x > > Time Spent: 40m > Remaining Estimate: 0h > > SAI registers it's components with the SSTable descriptor expecting them to > form part of the SSTable lifecycle, including streaming. This is not the case. > The current SSTable format in Cassandra uses a fixed set of components > (Components.STREAMING_COMPONENTS) when streaming SSTables. This needs to > change to use the set of components that are registered with a specific > SSTable by calls to SSTable.registerComponents. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18639) Add a metadata option to sstabledump
[ https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738755#comment-17738755 ] Timothy Tu commented on CASSANDRA-18639: [~brandon.williams] that’s a good point, perhaps instead the suggested improvement should be to sstablemetadata * add Duration and Total Partitions to sstablemetadata > Add a metadata option to sstabledump > > > Key: CASSANDRA-18639 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18639 > Project: Cassandra > Issue Type: Improvement > Components: Tool/sstable >Reporter: Timothy Tu >Assignee: Timothy Tu >Priority: Normal > > The new -m option will output metadata information for: > * Partition Key Count > * SSTable Level > * Droppable Tombstones (%age) > * Min Timestamp > * Max Timestamp > * Duration > Partition key count is the total number of partitions in the sstable. Level > is zero for STCS and TWC, and varies for LTCS. > For Time Window Compaction (TWC), the min and max timestamps together with > duration describe the bounds of the time window in the table. > {quote}Partition Key Count: 24306 > Droppable Tombstones: 1000.0 (0.01%) > SSTable Level: 1 > Min Timestamp: 06/28/2023 15:15:04 > Max Timestamp: 06/28/2023 15:15:58 > Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53 > {quote} -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-63) Support credential rotation in JmxClient
[ https://issues.apache.org/jira/browse/CASSANDRASC-63?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francisco Guerrero updated CASSANDRASC-63: -- Test and Documentation Plan: Added unit tests covering the new code in JmxClient Status: Patch Available (was: In Progress) PR: https://github.com/apache/cassandra-sidecar/pull/59 CI: https://app.circleci.com/pipelines/github/frankgh/cassandra-sidecar/172 > Support credential rotation in JmxClient > > > Key: CASSANDRASC-63 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-63 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Configuration >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > JMX credentials in a Cassandra instance can be rotated on a cadence, on every > bounce, or by some other means. In those cases, the {{JmxClient}} will no > longer be able to connect to the instance completely losing the ability to > talk to that instance. > In those cases, it is desirable for the {{JmxClient}} to support changes to > be able to continue working correctly, without any potential downtime to the > Sidecar service. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18529) Remove legacy command line options from cassandra-stress
[ https://issues.apache.org/jira/browse/CASSANDRA-18529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738746#comment-17738746 ] Timothy Tu commented on CASSANDRA-18529: I will look at the prepared statement problem > Remove legacy command line options from cassandra-stress > > > Key: CASSANDRA-18529 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18529 > Project: Cassandra > Issue Type: Improvement > Components: Tool/stress >Reporter: Brad Schoening >Assignee: Timothy Tu >Priority: Low > Fix For: 5.x > > Attachments: signature.asc > > > The cassandra-stress *mode* option allows specifying options for native > protocol and cql3, but these don't seem useful as there would seem to be no > other valid options now that cql3 is the standard and thrift no longer > supported. > -mode "native cql3 user=cassandra password=xx" > Perhaps change the arguments for user and password to match those used with > cqlsh would align the tools. > I.e., > cassandra-stress -u cassandra -p x > Also, the readme.txt in tools/stress states "cassandra-stress supports > benchmarking any Cassandra cluster of version 2.0+" but maybe should be > updated to a supported Cassandra version, i.e., 3.11.x. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-63) Support credential rotation in JmxClient
[ https://issues.apache.org/jira/browse/CASSANDRASC-63?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CASSANDRASC-63: -- Labels: pull-request-available (was: ) > Support credential rotation in JmxClient > > > Key: CASSANDRASC-63 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-63 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Configuration >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > Labels: pull-request-available > > JMX credentials in a Cassandra instance can be rotated on a cadence, on every > bounce, or by some other means. In those cases, the {{JmxClient}} will no > longer be able to connect to the instance completely losing the ability to > talk to that instance. > In those cases, it is desirable for the {{JmxClient}} to support changes to > be able to continue working correctly, without any potential downtime to the > Sidecar service. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-18529) Remove legacy command line options from cassandra-stress
[ https://issues.apache.org/jira/browse/CASSANDRA-18529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Tu reassigned CASSANDRA-18529: -- Assignee: Timothy Tu > Remove legacy command line options from cassandra-stress > > > Key: CASSANDRA-18529 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18529 > Project: Cassandra > Issue Type: Improvement > Components: Tool/stress >Reporter: Brad Schoening >Assignee: Timothy Tu >Priority: Low > Fix For: 5.x > > Attachments: signature.asc > > > The cassandra-stress *mode* option allows specifying options for native > protocol and cql3, but these don't seem useful as there would seem to be no > other valid options now that cql3 is the standard and thrift no longer > supported. > -mode "native cql3 user=cassandra password=xx" > Perhaps change the arguments for user and password to match those used with > cqlsh would align the tools. > I.e., > cassandra-stress -u cassandra -p x > Also, the readme.txt in tools/stress states "cassandra-stress supports > benchmarking any Cassandra cluster of version 2.0+" but maybe should be > updated to a supported Cassandra version, i.e., 3.11.x. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-63) Support credential rotation in JmxClient
[ https://issues.apache.org/jira/browse/CASSANDRASC-63?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francisco Guerrero updated CASSANDRASC-63: -- Change Category: Operability Complexity: Normal Component/s: Configuration Status: Open (was: Triage Needed) > Support credential rotation in JmxClient > > > Key: CASSANDRASC-63 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-63 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Configuration >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > > JMX credentials in a Cassandra instance can be rotated on a cadence, on every > bounce, or by some other means. In those cases, the {{JmxClient}} will no > longer be able to connect to the instance completely losing the ability to > talk to that instance. > In those cases, it is desirable for the {{JmxClient}} to support changes to > be able to continue working correctly, without any potential downtime to the > Sidecar service. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRASC-63) Support credential rotation in JmxClient
Francisco Guerrero created CASSANDRASC-63: - Summary: Support credential rotation in JmxClient Key: CASSANDRASC-63 URL: https://issues.apache.org/jira/browse/CASSANDRASC-63 Project: Sidecar for Apache Cassandra Issue Type: Improvement Reporter: Francisco Guerrero Assignee: Francisco Guerrero JMX credentials in a Cassandra instance can be rotated on a cadence, on every bounce, or by some other means. In those cases, the {{JmxClient}} will no longer be able to connect to the instance completely losing the ability to talk to that instance. In those cases, it is desirable for the {{JmxClient}} to support changes to be able to continue working correctly, without any potential downtime to the Sidecar service. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17992) Upgrade Netty on 5.0
[ https://issues.apache.org/jira/browse/CASSANDRA-17992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738743#comment-17738743 ] Ekaterina Dimitrova edited comment on CASSANDRA-17992 at 6/29/23 6:59 PM: -- GH is back. Pushed new CI run [here|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=CASSANDRA-17992] While building locally I noticed we download quite a lot of things. I am wondering whether everything is really needed. For example: {code:java} [resolver:resolve] Downloaded https://repo1.maven.org/maven2/io/netty/netty-tcnative-boringssl-static/2.0.61.Final/netty-tcnative-boringssl-static-2.0.61.Final-windows-x86_64.jar{code} was (Author: e.dimitrova): GH is back. Pushed new CI run [here|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=CASSANDRA-17992] While building locally I noticed we download quite a lot of things. I am wondering whether everythng is really needed. For example: {code:java} [resolver:resolve] Downloaded https://repo1.maven.org/maven2/io/netty/netty-tcnative-boringssl-static/2.0.61.Final/netty-tcnative-boringssl-static-2.0.61.Final-windows-x86_64.jar{code} > Upgrade Netty on 5.0 > > > Key: CASSANDRA-17992 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17992 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Jacek Lewandowski >Priority: Low > Fix For: 5.x > > > I haven't been able to identify from the Netty docs which was the lowest > version where JDK17 was added but we are about 40 versions behind in netty 4 > so I suspect we better update. > -We need to consider there was an issue with class cast exceptions when > building with JDK17 with newer versions of netty (the newest available in > March 2022). For the record, we didn't see those when running CI on JDK8 and > JDK11. We also need to carefully revise the changes between the netty > versions. -->- CASSANDRA-18180 > Upgrading will cover also a fix in netty that was discussed in > [this|https://the-asf.slack.com/archives/CK23JSY2K/p1665567660202989] ASF > Slack thread. > CC [~benedict] , [~aleksey] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17992) Upgrade Netty on 5.0
[ https://issues.apache.org/jira/browse/CASSANDRA-17992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738743#comment-17738743 ] Ekaterina Dimitrova commented on CASSANDRA-17992: - GH is back. Pushed new CI run [here|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=CASSANDRA-17992] While building locally I noticed we download quite a lot of things. I am wondering whether everythng is really needed. For example: {code:java} [resolver:resolve] Downloaded https://repo1.maven.org/maven2/io/netty/netty-tcnative-boringssl-static/2.0.61.Final/netty-tcnative-boringssl-static-2.0.61.Final-windows-x86_64.jar{code} > Upgrade Netty on 5.0 > > > Key: CASSANDRA-17992 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17992 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Jacek Lewandowski >Priority: Low > Fix For: 5.x > > > I haven't been able to identify from the Netty docs which was the lowest > version where JDK17 was added but we are about 40 versions behind in netty 4 > so I suspect we better update. > -We need to consider there was an issue with class cast exceptions when > building with JDK17 with newer versions of netty (the newest available in > March 2022). For the record, we didn't see those when running CI on JDK8 and > JDK11. We also need to carefully revise the changes between the netty > versions. -->- CASSANDRA-18180 > Upgrading will cover also a fix in netty that was discussed in > [this|https://the-asf.slack.com/archives/CK23JSY2K/p1665567660202989] ASF > Slack thread. > CC [~benedict] , [~aleksey] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17914) Argparse migration as the Python Optparse library is deprecated
[ https://issues.apache.org/jira/browse/CASSANDRA-17914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738732#comment-17738732 ] Stefan Miklosovic commented on CASSANDRA-17914: --- build looks healthier https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2527/ I have one comment on the PR thought. > Argparse migration as the Python Optparse library is deprecated > --- > > Key: CASSANDRA-17914 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17914 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Vineet Gali >Priority: Normal > > [Deprecated since version 2.7: The optparse module is deprecated and will not > be developed further; development will continue with the argparse > module.|https://docs.python.org/2/library/optparse.html] > Argparse is described in [PEP 389 – argparse - New Command Line Parsing > Module|https://peps.python.org/pep-0389/] > > A partial upgrade path from > [{{optparse}}|https://docs.python.org/3/library/optparse.html#module-optparse] > to > [{{argparse}}|https://docs.python.org/3/library/argparse.html#module-argparse]: > https://docs.python.org/3/library/argparse.html#upgrading-optparse-code > * Replace all > [{{optparse.OptionParser.add_option()}}|https://docs.python.org/3/library/optparse.html#optparse.OptionParser.add_option] > calls with > [{{ArgumentParser.add_argument()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.add_argument] > calls. > * Replace {{(options, args) = parser.parse_args()}} with {{args = > parser.parse_args()}} and add additional > [{{ArgumentParser.add_argument()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.add_argument] > calls for the positional arguments. Keep in mind that what was previously > called {{{}options{}}}, now in the > [{{argparse}}|https://docs.python.org/3/library/argparse.html#module-argparse] > context is called {{{}args{}}}. > * Replace > [{{optparse.OptionParser.disable_interspersed_args()}}|https://docs.python.org/3/library/optparse.html#optparse.OptionParser.disable_interspersed_args] > by using > [{{parse_intermixed_args()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.parse_intermixed_args] > instead of > [{{parse_args()}}|https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.parse_args]. > * Replace callback actions and the {{callback_*}} keyword arguments with > {{type}} or {{action}} arguments. > * Replace string names for {{type}} keyword arguments with the corresponding > type objects (e.g. int, float, complex, etc). > * Replace {{optparse.Values}} with > [{{Namespace}}|https://docs.python.org/3/library/argparse.html#argparse.Namespace] > and {{optparse.OptionError}} and {{optparse.OptionValueError}} with > {{{}ArgumentError{}}}. > * Replace strings with implicit arguments such as {{%default}} or {{%prog}} > with the standard Python syntax to use dictionaries to format strings, that > is, {{%(default)s}} and {{{}%(prog)s{}}}. > * Replace the OptionParser constructor {{version}} argument with a call to > {{{}parser.add_argument('--version', action='version', version=' version>'){}}}. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[GitHub] [cassandra-analytics] frankgh commented on a diff in pull request #9: [CASSANDRA-18633] Added Caching of Node Settings to Improve Efficiency
frankgh commented on code in PR #9: URL: https://github.com/apache/cassandra-analytics/pull/9#discussion_r1246965532 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraClusterInfo.java: ## @@ -338,11 +339,23 @@ public String getVersionFromFeature() public String getVersionFromSidecar() { -LOGGER.info("Getting Cassandra versions from all nodes"); -List allNodeSettings = Sidecar.allNodeSettingsBlocking(conf, - cassandraContext.getSidecarClient(), - cassandraContext.clusterConfig); -return getLowestVersion(allNodeSettings); +List currentAllNodeSettings = allNodeSettings; +if (currentAllNodeSettings != null) +{ +return getLowestVersion(currentAllNodeSettings); +} + +synchronized (this) +{ +if (allNodeSettings == null) +{ +LOGGER.info("Getting Cassandra versions from all nodes"); +allNodeSettings = Sidecar.allNodeSettingsBlocking(conf, + cassandraContext.getSidecarClient(), + cassandraContext.clusterConfig); +} +return getLowestVersion(allNodeSettings); Review Comment: I agree that getLowestVersion should be out of the critical section -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[GitHub] [cassandra-analytics] frankgh commented on a diff in pull request #9: [CASSANDRA-18633] Added Caching of Node Settings to Improve Efficiency
frankgh commented on code in PR #9: URL: https://github.com/apache/cassandra-analytics/pull/9#discussion_r1246965210 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraClusterInfo.java: ## @@ -338,11 +339,23 @@ public String getVersionFromFeature() public String getVersionFromSidecar() { -LOGGER.info("Getting Cassandra versions from all nodes"); -List allNodeSettings = Sidecar.allNodeSettingsBlocking(conf, - cassandraContext.getSidecarClient(), - cassandraContext.clusterConfig); -return getLowestVersion(allNodeSettings); +List currentAllNodeSettings = allNodeSettings; +if (currentAllNodeSettings != null) +{ +return getLowestVersion(currentAllNodeSettings); +} + +synchronized (this) +{ +if (allNodeSettings == null) +{ +LOGGER.info("Getting Cassandra versions from all nodes"); +allNodeSettings = Sidecar.allNodeSettingsBlocking(conf, + cassandraContext.getSidecarClient(), + cassandraContext.clusterConfig); +} +return getLowestVersion(allNodeSettings); Review Comment: To me, the [original implementation provided in the PR](https://github.com/apache/cassandra-analytics/commit/10725fb9f29076637eb2e9a9206d97287b239bc7) is the correct* classic double checked locking pattern. By some definition of correct -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18640) Add vector similarity functions
[ https://issues.apache.org/jira/browse/CASSANDRA-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738724#comment-17738724 ] Andres de la Peña commented on CASSANDRA-18640: --- Here we go: ||PR||CI|| |[trunk|https://github.com/apache/cassandra/pull/2459]|[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/2996/workflows/f7280fc5-2527-40c4-bad0-516d1804695d] [j17|https://app.circleci.com/pipelines/github/adelapena/cassandra/2996/workflows/b6e8904f-6fbd-43b6-83af-3167c8e2040b]| > Add vector similarity functions > --- > > Key: CASSANDRA-18640 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18640 > Project: Cassandra > Issue Type: New Feature > Components: CQL/Semantics >Reporter: Andres de la Peña >Assignee: Andres de la Peña >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > Add the CQL vector similarity functions described by > [CEP-30|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-30%3A+Approximate+Nearest+Neighbor%28ANN%29+Vector+Search+via+Storage-Attached+Indexes]: > * similarity_cosine > * similarity_euclidean > * similarity_dot_product > The three functions take two vectors of floats of the same dimensions and > return a float indicating the similarity score for the vectors. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18640) Add vector similarity functions
[ https://issues.apache.org/jira/browse/CASSANDRA-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andres de la Peña updated CASSANDRA-18640: -- Fix Version/s: 5.x > Add vector similarity functions > --- > > Key: CASSANDRA-18640 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18640 > Project: Cassandra > Issue Type: New Feature > Components: CQL/Semantics >Reporter: Andres de la Peña >Assignee: Andres de la Peña >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > Add the CQL vector similarity functions described by > [CEP-30|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-30%3A+Approximate+Nearest+Neighbor%28ANN%29+Vector+Search+via+Storage-Attached+Indexes]: > * similarity_cosine > * similarity_euclidean > * similarity_dot_product > The three functions take two vectors of floats of the same dimensions and > return a float indicating the similarity score for the vectors. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18640) Add vector similarity functions
[ https://issues.apache.org/jira/browse/CASSANDRA-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738721#comment-17738721 ] Andres de la Peña commented on CASSANDRA-18640: --- [The proposed patch|https://github.com/apache/cassandra/pull/2459] is based on a previous patch by [~jbellis]. The CQL functions internally use Lucene's {{{}VectorSimilarityFunction{}}}. So this patch adds a new dependency on Lucene's latest version, 9.7.0. That's the same version that [CEP-7|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-7%3A+Storage+Attached+Index] will add. Lucene requires JDK 11, so both SAI and vector search will depend on us dropping the support for JDK 8 (CASSANDRA-18255). In the meantime, I think we can have a feature branch for CEP-30. It seems there is an outage in CircleCI at the moment. I'll run CI when it's back. > Add vector similarity functions > --- > > Key: CASSANDRA-18640 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18640 > Project: Cassandra > Issue Type: New Feature > Components: CQL/Semantics >Reporter: Andres de la Peña >Assignee: Andres de la Peña >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > Add the CQL vector similarity functions described by > [CEP-30|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-30%3A+Approximate+Nearest+Neighbor%28ANN%29+Vector+Search+via+Storage-Attached+Indexes]: > * similarity_cosine > * similarity_euclidean > * similarity_dot_product > The three functions take two vectors of floats of the same dimensions and > return a float indicating the similarity score for the vectors. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18640) Add vector similarity functions
[ https://issues.apache.org/jira/browse/CASSANDRA-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andres de la Peña updated CASSANDRA-18640: -- Test and Documentation Plan: A new {{VectorFctsTest}} adds tests for the new functions. Status: Patch Available (was: In Progress) > Add vector similarity functions > --- > > Key: CASSANDRA-18640 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18640 > Project: Cassandra > Issue Type: New Feature > Components: CQL/Semantics >Reporter: Andres de la Peña >Assignee: Andres de la Peña >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > Add the CQL vector similarity functions described by > [CEP-30|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-30%3A+Approximate+Nearest+Neighbor%28ANN%29+Vector+Search+via+Storage-Attached+Indexes]: > * similarity_cosine > * similarity_euclidean > * similarity_dot_product > The three functions take two vectors of floats of the same dimensions and > return a float indicating the similarity score for the vectors. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18640) Add vector similarity functions
[ https://issues.apache.org/jira/browse/CASSANDRA-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andres de la Peña updated CASSANDRA-18640: -- Description: Add the CQL vector similarity functions described by [CEP-30|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-30%3A+Approximate+Nearest+Neighbor%28ANN%29+Vector+Search+via+Storage-Attached+Indexes]: * similarity_cosine * similarity_euclidean * similarity_dot_product The three functions take two vectors of floats of the same dimensions and return a float indicating the similarity score for the vectors. was:Add the vector similarity functions as described by [CEP-30|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-30%3A+Approximate+Nearest+Neighbor%28ANN%29+Vector+Search+via+Storage-Attached+Indexes]. > Add vector similarity functions > --- > > Key: CASSANDRA-18640 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18640 > Project: Cassandra > Issue Type: New Feature > Components: CQL/Semantics >Reporter: Andres de la Peña >Assignee: Andres de la Peña >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > Add the CQL vector similarity functions described by > [CEP-30|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-30%3A+Approximate+Nearest+Neighbor%28ANN%29+Vector+Search+via+Storage-Attached+Indexes]: > * similarity_cosine > * similarity_euclidean > * similarity_dot_product > The three functions take two vectors of floats of the same dimensions and > return a float indicating the similarity score for the vectors. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18640) Add vector similarity functions
[ https://issues.apache.org/jira/browse/CASSANDRA-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andres de la Peña updated CASSANDRA-18640: -- Description: Add the CQL vector similarity functions described by [CEP-30|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-30%3A+Approximate+Nearest+Neighbor%28ANN%29+Vector+Search+via+Storage-Attached+Indexes]: * similarity_cosine * similarity_euclidean * similarity_dot_product The three functions take two vectors of floats of the same dimensions and return a float indicating the similarity score for the vectors. was: Add the CQL vector similarity functions described by [CEP-30|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-30%3A+Approximate+Nearest+Neighbor%28ANN%29+Vector+Search+via+Storage-Attached+Indexes]: * similarity_cosine * similarity_euclidean * similarity_dot_product The three functions take two vectors of floats of the same dimensions and return a float indicating the similarity score for the vectors. > Add vector similarity functions > --- > > Key: CASSANDRA-18640 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18640 > Project: Cassandra > Issue Type: New Feature > Components: CQL/Semantics >Reporter: Andres de la Peña >Assignee: Andres de la Peña >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > Add the CQL vector similarity functions described by > [CEP-30|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-30%3A+Approximate+Nearest+Neighbor%28ANN%29+Vector+Search+via+Storage-Attached+Indexes]: > * similarity_cosine > * similarity_euclidean > * similarity_dot_product > The three functions take two vectors of floats of the same dimensions and > return a float indicating the similarity score for the vectors. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17992) Upgrade Netty on 5.0
[ https://issues.apache.org/jira/browse/CASSANDRA-17992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738714#comment-17738714 ] Ekaterina Dimitrova commented on CASSANDRA-17992: - Ok, I had to remove the netty release notes that were added for revision as they missed Apache License and failed the rat check. The builds failed, but now GH has an outage, so I will get back to this later... > Upgrade Netty on 5.0 > > > Key: CASSANDRA-17992 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17992 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Jacek Lewandowski >Priority: Low > Fix For: 5.x > > > I haven't been able to identify from the Netty docs which was the lowest > version where JDK17 was added but we are about 40 versions behind in netty 4 > so I suspect we better update. > -We need to consider there was an issue with class cast exceptions when > building with JDK17 with newer versions of netty (the newest available in > March 2022). For the record, we didn't see those when running CI on JDK8 and > JDK11. We also need to carefully revise the changes between the netty > versions. -->- CASSANDRA-18180 > Upgrading will cover also a fix in netty that was discussed in > [this|https://the-asf.slack.com/archives/CK23JSY2K/p1665567660202989] ASF > Slack thread. > CC [~benedict] , [~aleksey] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18640) Add vector similarity functions
[ https://issues.apache.org/jira/browse/CASSANDRA-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andres de la Peña updated CASSANDRA-18640: -- Change Category: Semantic Complexity: Normal Component/s: CQL/Semantics Status: Open (was: Triage Needed) > Add vector similarity functions > --- > > Key: CASSANDRA-18640 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18640 > Project: Cassandra > Issue Type: New Feature > Components: CQL/Semantics >Reporter: Andres de la Peña >Assignee: Andres de la Peña >Priority: Normal > > Add the vector similarity functions as described by > [CEP-30|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-30%3A+Approximate+Nearest+Neighbor%28ANN%29+Vector+Search+via+Storage-Attached+Indexes]. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18640) Add vector similarity functions
Andres de la Peña created CASSANDRA-18640: - Summary: Add vector similarity functions Key: CASSANDRA-18640 URL: https://issues.apache.org/jira/browse/CASSANDRA-18640 Project: Cassandra Issue Type: New Feature Reporter: Andres de la Peña Assignee: Andres de la Peña Add the vector similarity functions as described by [CEP-30|https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-30%3A+Approximate+Nearest+Neighbor%28ANN%29+Vector+Search+via+Storage-Attached+Indexes]. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18618) Update tasks configuration to run checks locally when requested
[ https://issues.apache.org/jira/browse/CASSANDRA-18618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738711#comment-17738711 ] Ekaterina Dimitrova edited comment on CASSANDRA-18618 at 6/29/23 5:44 PM: -- (:sigh, I want to see the day when we would not need any add-exports, or add-opens added AT ALL) Let's focus this ticket on the checks and leave the JVM options to a follow-up one? was (Author: e.dimitrova): (:sigh, I want to see the day when we would not need any add-exports, or add-opens added AT ALL) > Update tasks configuration to run checks locally when requested > --- > > Key: CASSANDRA-18618 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18618 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > Time Spent: 1h 40m > Remaining Estimate: 0h > > Currently CheckStyle and RAT are run with almost every single Ant target, > which is annoying as when developing locally. The targets should be clear - > "test" - runs the tests, "jar" - builds the project and creates jars, and > then we should have a task "check" which runs all the static analysis, that > is CheckStyle, RAT and Eclipse-Warnings (or whatever we decide to replace > Eclipse-Warnings with). > Such goal should be include in "artifacts" and we should run it instead of > "eclipse-warnings" on CircleCI. This way building, static analysis and > testings are clearly separated. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18618) Update tasks configuration to run checks locally when requested
[ https://issues.apache.org/jira/browse/CASSANDRA-18618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738711#comment-17738711 ] Ekaterina Dimitrova commented on CASSANDRA-18618: - (:sigh, I want to see the day when we would not need any add-exports, or add-opens added AT ALL) > Update tasks configuration to run checks locally when requested > --- > > Key: CASSANDRA-18618 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18618 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > Time Spent: 1h 40m > Remaining Estimate: 0h > > Currently CheckStyle and RAT are run with almost every single Ant target, > which is annoying as when developing locally. The targets should be clear - > "test" - runs the tests, "jar" - builds the project and creates jars, and > then we should have a task "check" which runs all the static analysis, that > is CheckStyle, RAT and Eclipse-Warnings (or whatever we decide to replace > Eclipse-Warnings with). > Such goal should be include in "artifacts" and we should run it instead of > "eclipse-warnings" on CircleCI. This way building, static analysis and > testings are clearly separated. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18529) Remove legacy command line options from cassandra-stress
[ https://issues.apache.org/jira/browse/CASSANDRA-18529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] miklosovic updated CASSANDRA-18529: --- Attachment: signature.asc Yeah ... that could fly. Are you capable to deliver it? We should also primarily fix the bug / exception and then we can improve the commans line args. Sent from ProtonMail mobile \ > Remove legacy command line options from cassandra-stress > > > Key: CASSANDRA-18529 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18529 > Project: Cassandra > Issue Type: Improvement > Components: Tool/stress >Reporter: Brad Schoening >Priority: Low > Fix For: 5.x > > Attachments: signature.asc > > > The cassandra-stress *mode* option allows specifying options for native > protocol and cql3, but these don't seem useful as there would seem to be no > other valid options now that cql3 is the standard and thrift no longer > supported. > -mode "native cql3 user=cassandra password=xx" > Perhaps change the arguments for user and password to match those used with > cqlsh would align the tools. > I.e., > cassandra-stress -u cassandra -p x > Also, the readme.txt in tools/stress states "cassandra-stress supports > benchmarking any Cassandra cluster of version 2.0+" but maybe should be > updated to a supported Cassandra version, i.e., 3.11.x. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17992) Upgrade Netty on 5.0
[ https://issues.apache.org/jira/browse/CASSANDRA-17992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738705#comment-17738705 ] Ekaterina Dimitrova edited comment on CASSANDRA-17992 at 6/29/23 5:28 PM: -- Thank you for the investigation! Let's see first a CI run with all changes incorporated: [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=CASSANDRA-17992] Side note: there were tests ignored and fields marked with @Unmetered to reduce some of the noise of the Jamm related failures but we need to revert those and make a run to confirm no new failures pre-commit (when done with a review of course) was (Author: e.dimitrova): Thank you for the investigation! Let's see first a CI run with all changes incorporated: [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=CASSANDRA-17992] Side note: there were tests ignored and fields marked with @Unmetered to reduce some of the noise of the Jamm related failures but we need to revert those and make a run to confirm no new failures pre-commit > Upgrade Netty on 5.0 > > > Key: CASSANDRA-17992 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17992 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Jacek Lewandowski >Priority: Low > Fix For: 5.x > > > I haven't been able to identify from the Netty docs which was the lowest > version where JDK17 was added but we are about 40 versions behind in netty 4 > so I suspect we better update. > -We need to consider there was an issue with class cast exceptions when > building with JDK17 with newer versions of netty (the newest available in > March 2022). For the record, we didn't see those when running CI on JDK8 and > JDK11. We also need to carefully revise the changes between the netty > versions. -->- CASSANDRA-18180 > Upgrading will cover also a fix in netty that was discussed in > [this|https://the-asf.slack.com/archives/CK23JSY2K/p1665567660202989] ASF > Slack thread. > CC [~benedict] , [~aleksey] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17992) Upgrade Netty on 5.0
[ https://issues.apache.org/jira/browse/CASSANDRA-17992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738705#comment-17738705 ] Ekaterina Dimitrova commented on CASSANDRA-17992: - Thank you for the investigation! Let's see first a CI run with all changes incorporated: [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=CASSANDRA-17992] Side note: there were tests ignored and fields marked with @Unmetered to reduce some of the noise of the Jamm related failures but we need to revert those and make a run to confirm no new failures pre-commit > Upgrade Netty on 5.0 > > > Key: CASSANDRA-17992 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17992 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Jacek Lewandowski >Priority: Low > Fix For: 5.x > > > I haven't been able to identify from the Netty docs which was the lowest > version where JDK17 was added but we are about 40 versions behind in netty 4 > so I suspect we better update. > -We need to consider there was an issue with class cast exceptions when > building with JDK17 with newer versions of netty (the newest available in > March 2022). For the record, we didn't see those when running CI on JDK8 and > JDK11. We also need to carefully revise the changes between the netty > versions. -->- CASSANDRA-18180 > Upgrading will cover also a fix in netty that was discussed in > [this|https://the-asf.slack.com/archives/CK23JSY2K/p1665567660202989] ASF > Slack thread. > CC [~benedict] , [~aleksey] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18275) Harry model and in-JVM test for partition-restricted 2i queries
[ https://issues.apache.org/jira/browse/CASSANDRA-18275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caleb Rackliffe updated CASSANDRA-18275: Fix Version/s: 5.x (was: NA) > Harry model and in-JVM test for partition-restricted 2i queries > --- > > Key: CASSANDRA-18275 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18275 > Project: Cassandra > Issue Type: Task > Components: Feature/2i Index, Test/fuzz >Reporter: Caleb Rackliffe >Assignee: Caleb Rackliffe >Priority: Normal > Fix For: 5.x > > > The smallest useful scope for Harry testing w/ 2i would be to cover queries > within large partitions. Creating a model to do this should also be easier > than it would be for the “global” query case, so it seems like a good place > to start. The goal here should be to create something that can simply be run > for a specified amount of time as an in-JVM test and be run going forward as > part of our normal CI process. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18633) [Analytics] Add Caching of Node Settings to Improve Efficiency
[ https://issues.apache.org/jira/browse/CASSANDRA-18633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRA-18633: -- Change Category: Performance Complexity: Low Hanging Fruit Status: Open (was: Triage Needed) > [Analytics] Add Caching of Node Settings to Improve Efficiency > -- > > Key: CASSANDRA-18633 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18633 > Project: Cassandra > Issue Type: Improvement > Components: Analytics Library >Reporter: Yuriy Semchyshyn >Assignee: Yuriy Semchyshyn >Priority: Normal > Time Spent: 20m > Remaining Estimate: 0h > > Currently, `CassandraClusterInfo` does not reuse results of a call to > `allNodeSettingsBlocking` from `Sidecar`. > We should improve efficiency by caching these results in order to prevent > multiple expensive cluster-wide calls. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18345) Enable streaming SAI components as part of repair
[ https://issues.apache.org/jira/browse/CASSANDRA-18345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caleb Rackliffe updated CASSANDRA-18345: Fix Version/s: 5.x (was: NA) > Enable streaming SAI components as part of repair > - > > Key: CASSANDRA-18345 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18345 > Project: Cassandra > Issue Type: Improvement > Components: Feature/2i Index >Reporter: Mike Adamson >Assignee: Piotr Kolaczkowski >Priority: Normal > Labels: SAI > Fix For: 5.x > > Time Spent: 40m > Remaining Estimate: 0h > > SAI registers it's components with the SSTable descriptor expecting them to > form part of the SSTable lifecycle, including streaming. This is not the case. > The current SSTable format in Cassandra uses a fixed set of components > (Components.STREAMING_COMPONENTS) when streaming SSTables. This needs to > change to use the set of components that are registered with a specific > SSTable by calls to SSTable.registerComponents. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18345) Enable streaming SAI components as part of repair
[ https://issues.apache.org/jira/browse/CASSANDRA-18345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caleb Rackliffe updated CASSANDRA-18345: Status: Ready to Commit (was: Changes Suggested) > Enable streaming SAI components as part of repair > - > > Key: CASSANDRA-18345 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18345 > Project: Cassandra > Issue Type: Improvement > Components: Feature/2i Index >Reporter: Mike Adamson >Assignee: Piotr Kolaczkowski >Priority: Normal > Labels: SAI > Fix For: NA > > Time Spent: 40m > Remaining Estimate: 0h > > SAI registers it's components with the SSTable descriptor expecting them to > form part of the SSTable lifecycle, including streaming. This is not the case. > The current SSTable format in Cassandra uses a fixed set of components > (Components.STREAMING_COMPONENTS) when streaming SSTables. This needs to > change to use the set of components that are registered with a specific > SSTable by calls to SSTable.registerComponents. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18633) [Analytics] Add Caching of Node Settings to Improve Efficiency
[ https://issues.apache.org/jira/browse/CASSANDRA-18633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRA-18633: -- Test and Documentation Plan: unit test Status: Patch Available (was: Open) > [Analytics] Add Caching of Node Settings to Improve Efficiency > -- > > Key: CASSANDRA-18633 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18633 > Project: Cassandra > Issue Type: Improvement > Components: Analytics Library >Reporter: Yuriy Semchyshyn >Assignee: Yuriy Semchyshyn >Priority: Normal > Time Spent: 20m > Remaining Estimate: 0h > > Currently, `CassandraClusterInfo` does not reuse results of a call to > `allNodeSettingsBlocking` from `Sidecar`. > We should improve efficiency by caching these results in order to prevent > multiple expensive cluster-wide calls. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18633) [Analytics] Add Caching of Node Settings to Improve Efficiency
[ https://issues.apache.org/jira/browse/CASSANDRA-18633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRA-18633: -- Reviewers: Yifan Cai Status: Review In Progress (was: Patch Available) +1 on the patch. > [Analytics] Add Caching of Node Settings to Improve Efficiency > -- > > Key: CASSANDRA-18633 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18633 > Project: Cassandra > Issue Type: Improvement > Components: Analytics Library >Reporter: Yuriy Semchyshyn >Assignee: Yuriy Semchyshyn >Priority: Normal > Time Spent: 20m > Remaining Estimate: 0h > > Currently, `CassandraClusterInfo` does not reuse results of a call to > `allNodeSettingsBlocking` from `Sidecar`. > We should improve efficiency by caching these results in order to prevent > multiple expensive cluster-wide calls. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-18633) [Analytics] Add Caching of Node Settings to Improve Efficiency
[ https://issues.apache.org/jira/browse/CASSANDRA-18633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai reassigned CASSANDRA-18633: - Assignee: Yuriy Semchyshyn > [Analytics] Add Caching of Node Settings to Improve Efficiency > -- > > Key: CASSANDRA-18633 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18633 > Project: Cassandra > Issue Type: Improvement > Components: Analytics Library >Reporter: Yuriy Semchyshyn >Assignee: Yuriy Semchyshyn >Priority: Normal > Time Spent: 20m > Remaining Estimate: 0h > > Currently, `CassandraClusterInfo` does not reuse results of a call to > `allNodeSettingsBlocking` from `Sidecar`. > We should improve efficiency by caching these results in order to prevent > multiple expensive cluster-wide calls. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18529) Remove legacy command line options from cassandra-stress
[ https://issues.apache.org/jira/browse/CASSANDRA-18529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738634#comment-17738634 ] Brad Schoening commented on CASSANDRA-18529: [~smiklosovic] [~brandon.williams] to progress this, perhaps we could change the existing: {noformat} Usage: -mode native [unprepared] cql3 [compression=?] [port=?] [user=?] [password=?] [auth-provider=?] [maxPending=?] [connectionsPerHost=?] [protocolVersion=?] OR Usage: -mode simplenative [prepared] cql3 [port=?]{noformat} to be simplified as: {noformat} Usage: -mode [prepared] [compression=?] [port=?] [user=?] [password=?] [auth-provider=?] [maxPending=?] [connectionsPerHost=?] [protocolVersion=?] [simplenative]{noformat} This would remove the unnecessary and confusing cql3 and have native and unprepared as defaults. > Remove legacy command line options from cassandra-stress > > > Key: CASSANDRA-18529 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18529 > Project: Cassandra > Issue Type: Improvement > Components: Tool/stress >Reporter: Brad Schoening >Priority: Low > Fix For: 5.x > > > The cassandra-stress *mode* option allows specifying options for native > protocol and cql3, but these don't seem useful as there would seem to be no > other valid options now that cql3 is the standard and thrift no longer > supported. > -mode "native cql3 user=cassandra password=xx" > Perhaps change the arguments for user and password to match those used with > cqlsh would align the tools. > I.e., > cassandra-stress -u cassandra -p x > Also, the readme.txt in tools/stress states "cassandra-stress supports > benchmarking any Cassandra cluster of version 2.0+" but maybe should be > updated to a supported Cassandra version, i.e., 3.11.x. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18467) Update generate-idea-files for J17
[ https://issues.apache.org/jira/browse/CASSANDRA-18467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738630#comment-17738630 ] Ekaterina Dimitrova commented on CASSANDRA-18467: - My +1 still stands on rebase and green CI. I did not see any other change than removing [https://github.com/apache/cassandra/pull/2320/files#diff-766797f233c18114f9499750cf1ffbf3829aeea50283850619c01bd173132021R1822-R1827] Good point that one can be polished as wording and included for all JDKs. I also support what was said here in favor of not adding new separate cleaning tasks. - [https://github.com/apache/cassandra/pull/2320/files#r1246637341] (just adding it here so it is clear that was not forgotten/ignored but there was a reasonable discussion) > Update generate-idea-files for J17 > -- > > Key: CASSANDRA-18467 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18467 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Jakub Zytka >Priority: Low > Fix For: 5.x > > Time Spent: 40m > Remaining Estimate: 0h > > There was a discussion in CASSANDRA-18258 how to update generate-idea-files. > The final agreement was to create one target to cover both Java 11 and Java > 17. > It will be good to figure out CASSANDRA-18263 and reshuffle arguments and > tasks based on what we decide to use as gc in testing for both Java 11 and > Java 17. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18438) Refactor the code for public cloud platform snitch to be configurable
[ https://issues.apache.org/jira/browse/CASSANDRA-18438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738623#comment-17738623 ] Stefan Miklosovic edited comment on CASSANDRA-18438 at 6/29/23 3:58 PM: This is my idea about the simplification of all snitches https://github.com/apache/cassandra/pull/2458 [~jlewandowski] what do you think? Coding Azure snitch as [~xgerman42] wants that would be even easier. For example, this is refactored Alibaba ([~maxwellguo]) (1) Google snitch is similar (2). Ec2 snitches also extends abstract cloud snitch but there is some additional logic so it is not so straightforward. I think that this approach is good enough in not repeating the same logic but flexible enough to implement something custom if necessary. We could also have some "DefaultCloudMetadataServiceSnitch" where the only variables would be service url and endpoint. Alibaba and Google could extend that. For all other cases, if a snitch is super simple - just calling an endpoint and datacenter / rack format in the response would be something standard - a user might reference it in cassandra.yaml and configure endpoint and service url in cassandra-rackdc.properties. That way we are backward compatible with Alibaba and GoogleSnitch etc ... then we are also generic enough if somebody wants to integrate their own metadata service and DefaultCloudMetadataServiceSnitch is enough for them and it is also very easy to implement something very custom which needs to be committed into the repository. (1) https://github.com/apache/cassandra/blob/56ad1ffa2921530b44bcdfab4ffdcf0c375c2448/src/java/org/apache/cassandra/locator/AlibabaCloudSnitch.java (2) https://github.com/apache/cassandra/blob/56ad1ffa2921530b44bcdfab4ffdcf0c375c2448/src/java/org/apache/cassandra/locator/GoogleCloudSnitch.java was (Author: smiklosovic): This is my idea about the simplification of all snitches https://github.com/apache/cassandra/pull/2458 [~jlewandowski] what do you think? Coding Azure snitch as [~xgerman42] wants that would be even easier. For example, this is refactored Alibaba ([~maxwellguo]) (1) Google snitch is similar (2). Ec2 snitches also extends abstract cloud snitch but there is some additional logic so it is not so straightforward. I think that this approach is good enough in not repeating the same logic but flexible enough to implement something custom if necessary. (1) https://github.com/apache/cassandra/blob/56ad1ffa2921530b44bcdfab4ffdcf0c375c2448/src/java/org/apache/cassandra/locator/AlibabaCloudSnitch.java (2) https://github.com/apache/cassandra/blob/56ad1ffa2921530b44bcdfab4ffdcf0c375c2448/src/java/org/apache/cassandra/locator/GoogleCloudSnitch.java > Refactor the code for public cloud platform snitch to be configurable > - > > Key: CASSANDRA-18438 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18438 > Project: Cassandra > Issue Type: Improvement > Components: Local/Other >Reporter: Maxwell Guo >Assignee: Maxwell Guo >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > Nowadays we have got about four public cloud platform snitchs : EC2 snitch > for aws, google cloud snitch for google cloud, alibaba cloud snitch for > alibaba cloud and multi region snitch for ec2. And the common place for the > first three is that we just need to query the zone center to get the ec2 / > ecs id , so I think we can refactor the code , and if some new public cloud > platform want to add one more snitch for himself, there is no need to pull a > pr for him and configure some options in yaml is enough . > Besides it would be even better that we may reuse the multic region snitch > for ec2 for other public cloud platform. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18438) Refactor the code for public cloud platform snitch to be configurable
[ https://issues.apache.org/jira/browse/CASSANDRA-18438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738623#comment-17738623 ] Stefan Miklosovic edited comment on CASSANDRA-18438 at 6/29/23 3:40 PM: This is my idea about the simplification of all snitches https://github.com/apache/cassandra/pull/2458 [~jlewandowski] what do you think? Coding Azure snitch as [~xgerman42] wants that would be even easier. For example, this is refactored Alibaba ([~maxwellguo]) (1) Google snitch is similar (2). Ec2 snitches also extends abstract cloud snitch but there is some additional logic so it is not so straightforward. I think that this approach is good enough in not repeating the same logic but flexible enough to implement something custom if necessary. (1) https://github.com/apache/cassandra/blob/56ad1ffa2921530b44bcdfab4ffdcf0c375c2448/src/java/org/apache/cassandra/locator/AlibabaCloudSnitch.java (2) https://github.com/apache/cassandra/blob/56ad1ffa2921530b44bcdfab4ffdcf0c375c2448/src/java/org/apache/cassandra/locator/GoogleCloudSnitch.java was (Author: smiklosovic): This is my idea about the simplification of all snitches https://github.com/apache/cassandra/pull/2458 [~jlewandowski] what do you think? Coding Azure snitch as [~xgerman42] wants that would be even easier. For example, this is refactored Alibaba ([~maxwellguo]) (1) (1) https://github.com/apache/cassandra/blob/56ad1ffa2921530b44bcdfab4ffdcf0c375c2448/src/java/org/apache/cassandra/locator/AlibabaCloudSnitch.java > Refactor the code for public cloud platform snitch to be configurable > - > > Key: CASSANDRA-18438 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18438 > Project: Cassandra > Issue Type: Improvement > Components: Local/Other >Reporter: Maxwell Guo >Assignee: Maxwell Guo >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > Nowadays we have got about four public cloud platform snitchs : EC2 snitch > for aws, google cloud snitch for google cloud, alibaba cloud snitch for > alibaba cloud and multi region snitch for ec2. And the common place for the > first three is that we just need to query the zone center to get the ec2 / > ecs id , so I think we can refactor the code , and if some new public cloud > platform want to add one more snitch for himself, there is no need to pull a > pr for him and configure some options in yaml is enough . > Besides it would be even better that we may reuse the multic region snitch > for ec2 for other public cloud platform. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[GitHub] [cassandra-analytics] 5 commented on a diff in pull request #9: [CASSANDRA-18633] Added Caching of Node Settings to Improve Efficiency
5 commented on code in PR #9: URL: https://github.com/apache/cassandra-analytics/pull/9#discussion_r1246812708 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraClusterInfo.java: ## @@ -338,11 +339,23 @@ public String getVersionFromFeature() public String getVersionFromSidecar() { -LOGGER.info("Getting Cassandra versions from all nodes"); -List allNodeSettings = Sidecar.allNodeSettingsBlocking(conf, - cassandraContext.getSidecarClient(), - cassandraContext.clusterConfig); -return getLowestVersion(allNodeSettings); +List currentAllNodeSettings = allNodeSettings; +if (currentAllNodeSettings != null) +{ +return getLowestVersion(currentAllNodeSettings); +} + +synchronized (this) +{ +if (allNodeSettings == null) +{ +LOGGER.info("Getting Cassandra versions from all nodes"); +allNodeSettings = Sidecar.allNodeSettingsBlocking(conf, + cassandraContext.getSidecarClient(), + cassandraContext.clusterConfig); +} +return getLowestVersion(allNodeSettings); Review Comment: Refactored. (I was trying to keep style consistent with other methods within the same class.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18438) Refactor the code for public cloud platform snitch to be configurable
[ https://issues.apache.org/jira/browse/CASSANDRA-18438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738623#comment-17738623 ] Stefan Miklosovic commented on CASSANDRA-18438: --- This is my idea about the simplification of all snitches https://github.com/apache/cassandra/pull/2458 [~jlewandowski] what do you think? Coding Azure snitch as [~xgerman42] wants that would be even easier. For example, this is refactored Alibaba ([~maxwellguo]) (1) (1) https://github.com/apache/cassandra/blob/56ad1ffa2921530b44bcdfab4ffdcf0c375c2448/src/java/org/apache/cassandra/locator/AlibabaCloudSnitch.java > Refactor the code for public cloud platform snitch to be configurable > - > > Key: CASSANDRA-18438 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18438 > Project: Cassandra > Issue Type: Improvement > Components: Local/Other >Reporter: Maxwell Guo >Assignee: Maxwell Guo >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > Nowadays we have got about four public cloud platform snitchs : EC2 snitch > for aws, google cloud snitch for google cloud, alibaba cloud snitch for > alibaba cloud and multi region snitch for ec2. And the common place for the > first three is that we just need to query the zone center to get the ec2 / > ecs id , so I think we can refactor the code , and if some new public cloud > platform want to add one more snitch for himself, there is no need to pull a > pr for him and configure some options in yaml is enough . > Besides it would be even better that we may reuse the multic region snitch > for ec2 for other public cloud platform. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-7147) Add a new snitch for Apache Cloudstack platforms
[ https://issues.apache.org/jira/browse/CASSANDRA-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738622#comment-17738622 ] Stefan Miklosovic commented on CASSANDRA-7147: -- for reference, this is my take in simplifying the cloud snitches https://github.com/apache/cassandra/pull/2458 that work is being tracked under CASSANDRA-18438 Let's wait if there is some feedback on Cloudstack snich and then we can either refactor similarly or just remove it. > Add a new snitch for Apache Cloudstack platforms > > > Key: CASSANDRA-7147 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7147 > Project: Cassandra > Issue Type: Improvement > Environment: Virtual machine on Apache Cloudstack environments >Reporter: Pierre-Yves Ritschard >Assignee: Pierre-Yves Ritschard >Priority: Low > Fix For: 1.2.18, 2.0.8, 2.1 rc1 > > Attachments: 0001-initial-work-on-a-cloudstack-snitch.patch > > > The attached patch adds a new Snitch that queries meta data for a host on > Apache Cloudstack environments. Since the metadata service is colocated with > the DHCP service in Cloudstack, common lease file locations are looked up to > retrieve. > Since zone naming is freeform in Apache Cloudstack, the widely used > -- notation is assumed. > The patch includes a simple unit test and has been tested on exoscale.ch, a > public cloud based on Apache Cloudstack -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17909) Clean SyncUtil from dead code and update it for new JDK versions
[ https://issues.apache.org/jira/browse/CASSANDRA-17909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-17909: Status: Review In Progress (was: Changes Suggested) > Clean SyncUtil from dead code and update it for new JDK versions > > > Key: CASSANDRA-17909 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17909 > Project: Cassandra > Issue Type: Bug > Components: Local/Other >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.x > > > During code inspection I noticed [dead > code|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L77-L87] > (JDK 7) in SyncUtil. > From a very quick skim _I think_ the [Java 8 > section|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L65-L75] > is applicable in JDK 11, not sure for JDK 17 but it seems it should stay at > least until we have JDK11. To be revisited. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17909) Clean SyncUtil from dead code and update it for new JDK versions
[ https://issues.apache.org/jira/browse/CASSANDRA-17909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738619#comment-17738619 ] Ekaterina Dimitrova commented on CASSANDRA-17909: - {quote}It is used only in one test. {quote} That was a good catch! Using it in a single test to shred 10 seconds of a single test (check the original motivation behind creating SyncUtil in CASSANDRA-9403) does not justify opening internals. On the other hand, syncing is also not the last operation we do on a file, so if we skip dealing with SyncFailedException when we do not even sync in the test, it should not be an issue. [PR|https://github.com/apache/cassandra/compare/trunk...ekaterinadimitrova2:cassandra:17909-trunk] was updated accordingly. Running CI [here|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17909-trunk], run #2399 > Clean SyncUtil from dead code and update it for new JDK versions > > > Key: CASSANDRA-17909 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17909 > Project: Cassandra > Issue Type: Bug > Components: Local/Other >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.x > > > During code inspection I noticed [dead > code|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L77-L87] > (JDK 7) in SyncUtil. > From a very quick skim _I think_ the [Java 8 > section|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/SyncUtil.java#L65-L75] > is applicable in JDK 11, not sure for JDK 17 but it seems it should stay at > least until we have JDK11. To be revisited. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18636) AssertionError: Unknown keyspace after dropping a keyspace
[ https://issues.apache.org/jira/browse/CASSANDRA-18636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738618#comment-17738618 ] Stefan Miklosovic commented on CASSANDRA-18636: --- Sure, but I think that this has nothing to do with fast schema changes. It is just one thread intertwined with another, I dont think that cep 21 would address that, would it? [~samt] > AssertionError: Unknown keyspace after dropping a keyspace > -- > > Key: CASSANDRA-18636 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18636 > Project: Cassandra > Issue Type: Bug >Reporter: Ke Han >Priority: Normal > Attachments: system.log > > Time Spent: 10m > Remaining Estimate: 0h > > When running Cassandra cluster (3 nodes) in 3.11.15, I noticed that there is > an ERROR message in system.log after drop keyspace command is executed. > {code:java} > INFO [Native-Transport-Requests-1] 2023-06-26 06:11:48,575 > MigrationManager.java:205 - Create new Keyspace: > KeyspaceMetadata{name=uuide1b80964f06a424c8a57884564127745, > params=KeyspaceParams{durable_writes=true, > replication=ReplicationParams{class=org.apache.cassandra.locator.SimpleStrategy, > replication_factor=2}}, tables=[], views=[], functions=[], types=[]} > INFO [Native-Transport-Requests-1] 2023-06-26 06:11:53,106 > MigrationManager.java:205 - Create new Keyspace: > KeyspaceMetadata{name=uuidd17c2b7bfea545d0801a3c05e0e5307a, > params=KeyspaceParams{durable_writes=true, > replication=ReplicationParams{class=org.apache.cassandra.locator.SimpleStrategy, > replication_factor=1}}, tables=[], views=[], functions=[], types=[]} > INFO [Native-Transport-Requests-2] 2023-06-26 06:11:56,673 > MigrationManager.java:235 - Create new table: > org.apache.cassandra.config.CFMetaData@705b690b[cfId=5a7fcf10-13e8-11ee-9cb7-e10fdc7464a5,ksName=uuidd17c2b7bfea545d0801a3c05e0e5307a,cfName=vzkzguyh,flags=[COMPOUND],params=TableParams{comment=, > read_repair_chance=0.0, dclocal_read_repair_chance=0.1, > bloom_filter_fp_chance=0.01, crc_check_chance=1.0, gc_grace_seconds=864000, > default_time_to_live=0, memtable_flush_period_in_ms=0, > min_index_interval=128, max_index_interval=2048, speculative_retry=50.0ms, > caching={'keys' : 'ALL', 'rows_per_partition' : 'NONE'}, > compaction=CompactionParams{class=org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy, > options={min_threshold=4, max_threshold=32}}, > compression=org.apache.cassandra.schema.CompressionParams@a8f0c342, > extensions={}, cdc=false},comparator=comparator(),partitionColumns=[[] | > [condcduzca o ukwhjwbdljqnz > vzkzguyh]],partitionKeyColumns=[gveohmecfdwx],clusteringColumns=[],keyValidator=org.apache.cassandra.db.marshal.UTF8Type,columnMetadata=[gveohmecfdwx, > condcduzca, vzkzguyh, o, > ukwhjwbdljqnz],droppedColumns={},triggers=[],indexes=[]] > INFO [MigrationStage:1] 2023-06-26 06:12:03,118 ColumnFamilyStore.java:432 - > Initializing uuidd17c2b7bfea545d0801a3c05e0e5307a.vzkzguyh > INFO [Native-Transport-Requests-9] 2023-06-26 06:12:04,634 > MigrationManager.java:235 - Create new table: > org.apache.cassandra.config.CFMetaData@61f10dd7[cfId=5f3e8fa0-13e8-11ee-9cb7-e10fdc7464a5,ksName=uuidd17c2b7bfea545d0801a3c05e0e5307a,cfName=o,flags=[COMPOUND],params=TableParams{comment=, > read_repair_chance=0.0, dclocal_read_repair_chance=0.1, > bloom_filter_fp_chance=0.01, crc_check_chance=1.0, gc_grace_seconds=864000, > default_time_to_live=0, memtable_flush_period_in_ms=0, > min_index_interval=128, max_index_interval=2048, speculative_retry=ALWAYS, > caching={'keys' : 'ALL', 'rows_per_partition' : 'NONE'}, > compaction=CompactionParams{class=org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy, > options={min_threshold=4, max_threshold=32}}, > compression=org.apache.cassandra.schema.CompressionParams@a8f0c342, > extensions={}, cdc=false},comparator=comparator(),partitionColumns=[[] | > [dzwqnsv gveohmecfdwx o > ukwhjwbdljqnz]],partitionKeyColumns=[vzkzguyh],clusteringColumns=[],keyValidator=org.apache.cassandra.db.marshal.Int32Type,columnMetadata=[dzwqnsv, > vzkzguyh, gveohmecfdwx, o, > ukwhjwbdljqnz],droppedColumns={},triggers=[],indexes=[]] > INFO [MigrationStage:1] 2023-06-26 06:12:11,862 ColumnFamilyStore.java:432 - > Initializing uuidd17c2b7bfea545d0801a3c05e0e5307a.o > INFO [Native-Transport-Requests-6] 2023-06-26 06:12:13,165 > MigrationManager.java:205 - Create new Keyspace: > KeyspaceMetadata{name=uuid1602df26aef747d6af8f6d0c36fb1a44, > params=KeyspaceParams{durable_writes=true, > replication=ReplicationParams{class=org.apache.cassandra.locator.SimpleStrategy, > replication_factor=1}}, tables=[], views=[], functions=[], types=[]} > INFO [MigrationStage:1] 2023-06-26 06:12:20,413 > MigrationCoordinator.java:531 - Sending
[jira] [Commented] (CASSANDRA-18639) Add a metadata option to sstabledump
[ https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738602#comment-17738602 ] Brandon Williams commented on CASSANDRA-18639: -- Is there a reason to repeat the info that sstablemetadata provides here? > Add a metadata option to sstabledump > > > Key: CASSANDRA-18639 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18639 > Project: Cassandra > Issue Type: Improvement > Components: Tool/sstable >Reporter: Timothy Tu >Assignee: Timothy Tu >Priority: Normal > > The new -m option will output metadata information for: > * Partition Key Count > * SSTable Level > * Droppable Tombstones (%age) > * Min Timestamp > * Max Timestamp > * Duration > Partition key count is the total number of partitions in the sstable. Level > is zero for STCS and TWC, and varies for LTCS. > For Time Window Compaction (TWC), the min and max timestamps together with > duration describe the bounds of the time window in the table. > {quote}Partition Key Count: 24306 > Droppable Tombstones: 1000.0 (0.01%) > SSTable Level: 1 > Min Timestamp: 06/28/2023 15:15:04 > Max Timestamp: 06/28/2023 15:15:58 > Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53 > {quote} -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-18639) Add a metadata option to sstabledump
[ https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Tu reassigned CASSANDRA-18639: -- Assignee: Timothy Tu > Add a metadata option to sstabledump > > > Key: CASSANDRA-18639 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18639 > Project: Cassandra > Issue Type: Improvement > Components: Tool/sstable >Reporter: Timothy Tu >Assignee: Timothy Tu >Priority: Normal > > The new -m option will output metadata information for: > * Partition Key Count > * SSTable Level > * Droppable Tombstones (%age) > * Min Timestamp > * Max Timestamp > * Duration > Partition key count is the total number of partitions in the sstable. Level > is zero for STCS and TWC, and varies for LTCS. > For Time Window Compaction (TWC), the min and max timestamps together with > duration describe the bounds of the time window in the table. > {quote}Partition Key Count: 24306 > Droppable Tombstones: 1000.0 (0.01%) > SSTable Level: 1 > Min Timestamp: 06/28/2023 15:15:04 > Max Timestamp: 06/28/2023 15:15:58 > Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53 > {quote} -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18639) Add a metadata option to sstabledump
Timothy Tu created CASSANDRA-18639: -- Summary: Add a metadata option to sstabledump Key: CASSANDRA-18639 URL: https://issues.apache.org/jira/browse/CASSANDRA-18639 Project: Cassandra Issue Type: Improvement Components: Tool/sstable Reporter: Timothy Tu The new -m option will output metadata information for: * Partition Key Count * SSTable Level * Droppable Tombstones (%age) * Min Timestamp * Max Timestamp * Duration Partition key count is the total number of partitions in the sstable. Level is zero for STCS and TWC, and varies for LTCS. For Time Window Compaction (TWC), the min and max timestamps together with duration describe the bounds of the time window in the table. {quote}Partition Key Count: 24306 Droppable Tombstones: 1000.0 (0.01%) SSTable Level: 1 Min Timestamp: 06/28/2023 15:15:04 Max Timestamp: 06/28/2023 15:15:58 Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53 {quote} -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18638) ERROR: Invalid consistency level: NODE_LOCAL when using partition denylist in 4.1.2
[ https://issues.apache.org/jira/browse/CASSANDRA-18638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18638: - Resolution: Invalid Status: Resolved (was: Triage Needed) As you have found, NODE_LOCAL is not a supported consistency level and is not intended for end users. > ERROR: Invalid consistency level: NODE_LOCAL when using partition denylist in > 4.1.2 > --- > > Key: CASSANDRA-18638 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18638 > Project: Cassandra > Issue Type: Bug >Reporter: Ke Han >Priority: Normal > Attachments: cassandra.yaml, system.log > > > When I was testing the upgrade from Cassandra-3.11.15 to Cassandra-4.1.2 > (single node), for the debugging purpose, I enabled > partition_denylist_enabled and set the partition consistency level to > {_}NODE_LOCAL{_}. > I encountered the following error message in the system log > {code:java} > ERROR [main] 2023-06-29 14:12:17,870 PartitionDenylist.java:156 - Failed to > load partition denylist > java.lang.UnsupportedOperationException: Invalid consistency level: NODE_LOCAL > at > org.apache.cassandra.db.ConsistencyLevel.blockFor(ConsistencyLevel.java:168) > at > org.apache.cassandra.locator.ReplicaPlans.contactForRead(ReplicaPlans.java:558) > at > org.apache.cassandra.locator.ReplicaPlans.forRangeRead(ReplicaPlans.java:611) > at > org.apache.cassandra.service.reads.range.ReplicaPlanIterator.computeNext(ReplicaPlanIterator.java:76) > at > org.apache.cassandra.service.reads.range.ReplicaPlanIterator.computeNext(ReplicaPlanIterator.java:42) > at > org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) > at java.util.Iterator.forEachRemaining(Iterator.java:115) > at > org.apache.cassandra.service.reads.range.RangeCommands.sufficientLiveNodesForSelectStar(RangeCommands.java:135) > at > org.apache.cassandra.schema.PartitionDenylist.checkDenylistNodeAvailability(PartitionDenylist.java:169) > at > org.apache.cassandra.schema.PartitionDenylist.initialLoad(PartitionDenylist.java:148) > at > org.apache.cassandra.service.StorageProxy.initialLoadPartitionDenylist(StorageProxy.java:2914) > at > org.apache.cassandra.service.StorageService.joinTokenRing(StorageService.java:1224) > at > org.apache.cassandra.service.StorageService.joinTokenRing(StorageService.java:1145) > at > org.apache.cassandra.service.StorageService.initServer(StorageService.java:936) > at > org.apache.cassandra.service.StorageService.initServer(StorageService.java:854) > at > org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:424) > at > org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:751) > at > org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:875) > INFO [main] 2023-06-29 14:12:17,870 PartitionDenylist.java:163 - Exception > while loading partition denylist cache. Scheduled retry in 5 seconds. {code} > h2. How to reproduce > I encountered it after the upgrade process. But I think it can also be > reproduced without the upgrade process. > 1. Set up Cassandra-4.1.2 single node, add the follow configurations to > cassandra.yaml > {code:java} > denylist_consistency_level: NODE_LOCAL > partition_denylist_enabled: true{code} > 2. Start up Cassandra, the error message will show in system.log file. > h2. Root Cause > After setting denylist_consistency_level to NODE LEVEL, when loading > denylist, it invokes the _blockFor_ method > {code:java} > public int blockFor(AbstractReplicationStrategy replicationStrategy) > { > switch (this) > { > case ONE: > case LOCAL_ONE: > return 1; > case ANY: > return 1; > case TWO: > return 2; > case THREE: > return 3; > case QUORUM: > case SERIAL: > return quorumFor(replicationStrategy); > case ALL: > return replicationStrategy.getReplicationFactor().allReplicas; > case LOCAL_QUORUM: > case LOCAL_SERIAL: > return localQuorumForOurDc(replicationStrategy); > case EACH_QUORUM: > if (replicationStrategy instanceof NetworkTopologyStrategy) > { > NetworkTopologyStrategy strategy = (NetworkTopologyStrategy) > replicationStrategy; > int n = 0; > for (String dc : strategy.getDatacenters()) > n += localQuorumFor(replicationStrategy, dc); > return n; > } > else > { > return
[jira] [Updated] (CASSANDRA-18638) ERROR: Invalid consistency level: NODE_LOCAL when using partition denylist in 4.1.2
[ https://issues.apache.org/jira/browse/CASSANDRA-18638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ke Han updated CASSANDRA-18638: --- Description: When I was testing the upgrade from Cassandra-3.11.15 to Cassandra-4.1.2 (single node), for the debugging purpose, I enabled partition_denylist_enabled and set the partition consistency level to {_}NODE_LOCAL{_}. I encountered the following error message in the system log {code:java} ERROR [main] 2023-06-29 14:12:17,870 PartitionDenylist.java:156 - Failed to load partition denylist java.lang.UnsupportedOperationException: Invalid consistency level: NODE_LOCAL at org.apache.cassandra.db.ConsistencyLevel.blockFor(ConsistencyLevel.java:168) at org.apache.cassandra.locator.ReplicaPlans.contactForRead(ReplicaPlans.java:558) at org.apache.cassandra.locator.ReplicaPlans.forRangeRead(ReplicaPlans.java:611) at org.apache.cassandra.service.reads.range.ReplicaPlanIterator.computeNext(ReplicaPlanIterator.java:76) at org.apache.cassandra.service.reads.range.ReplicaPlanIterator.computeNext(ReplicaPlanIterator.java:42) at org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) at java.util.Iterator.forEachRemaining(Iterator.java:115) at org.apache.cassandra.service.reads.range.RangeCommands.sufficientLiveNodesForSelectStar(RangeCommands.java:135) at org.apache.cassandra.schema.PartitionDenylist.checkDenylistNodeAvailability(PartitionDenylist.java:169) at org.apache.cassandra.schema.PartitionDenylist.initialLoad(PartitionDenylist.java:148) at org.apache.cassandra.service.StorageProxy.initialLoadPartitionDenylist(StorageProxy.java:2914) at org.apache.cassandra.service.StorageService.joinTokenRing(StorageService.java:1224) at org.apache.cassandra.service.StorageService.joinTokenRing(StorageService.java:1145) at org.apache.cassandra.service.StorageService.initServer(StorageService.java:936) at org.apache.cassandra.service.StorageService.initServer(StorageService.java:854) at org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:424) at org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:751) at org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:875) INFO [main] 2023-06-29 14:12:17,870 PartitionDenylist.java:163 - Exception while loading partition denylist cache. Scheduled retry in 5 seconds. {code} h2. How to reproduce I encountered it after the upgrade process. But I think it can also be reproduced without the upgrade process. 1. Set up Cassandra-4.1.2 single node, add the follow configurations to cassandra.yaml {code:java} denylist_consistency_level: NODE_LOCAL partition_denylist_enabled: true{code} 2. Start up Cassandra, the error message will show in system.log file. h2. Root Cause After setting denylist_consistency_level to NODE LEVEL, when loading denylist, it invokes the _blockFor_ method {code:java} public int blockFor(AbstractReplicationStrategy replicationStrategy) { switch (this) { case ONE: case LOCAL_ONE: return 1; case ANY: return 1; case TWO: return 2; case THREE: return 3; case QUORUM: case SERIAL: return quorumFor(replicationStrategy); case ALL: return replicationStrategy.getReplicationFactor().allReplicas; case LOCAL_QUORUM: case LOCAL_SERIAL: return localQuorumForOurDc(replicationStrategy); case EACH_QUORUM: if (replicationStrategy instanceof NetworkTopologyStrategy) { NetworkTopologyStrategy strategy = (NetworkTopologyStrategy) replicationStrategy; int n = 0; for (String dc : strategy.getDatacenters()) n += localQuorumFor(replicationStrategy, dc); return n; } else { return quorumFor(replicationStrategy); } default: throw new UnsupportedOperationException("Invalid consistency level: " + toString()); } } {code} However, the _NODE_LOCAL_ enum is not included in those cases and thus results in the exception message. Should this enum be included, or does Cassandra forbid users from using partition denylist with the _NODE_LOCAL_ consistency level (even for debugging purposes)? was: When I was testing upgrade from cassandra-3.11.15 to cassandra-4.1.2 (single node), for debugging purpose I enabled partition_denylist_enabled and set the parition consistency level to {_}NODE_LOCAL{_}. I encountered error message from the system log {code:java} ERROR [main] 2023-06-29 14:12:17,870 PartitionDenylist.java:156 - Failed to load partition denylist
[jira] [Created] (CASSANDRA-18638) ERROR: Invalid consistency level: NODE_LOCAL when using partition denylist in 4.1.2
Ke Han created CASSANDRA-18638: -- Summary: ERROR: Invalid consistency level: NODE_LOCAL when using partition denylist in 4.1.2 Key: CASSANDRA-18638 URL: https://issues.apache.org/jira/browse/CASSANDRA-18638 Project: Cassandra Issue Type: Bug Reporter: Ke Han Attachments: cassandra.yaml, system.log When I was testing upgrade from cassandra-3.11.15 to cassandra-4.1.2 (single node), for debugging purpose I enabled partition_denylist_enabled and set the parition consistency level to {_}NODE_LOCAL{_}. I encountered error message from the system log {code:java} ERROR [main] 2023-06-29 14:12:17,870 PartitionDenylist.java:156 - Failed to load partition denylist java.lang.UnsupportedOperationException: Invalid consistency level: NODE_LOCAL at org.apache.cassandra.db.ConsistencyLevel.blockFor(ConsistencyLevel.java:168) at org.apache.cassandra.locator.ReplicaPlans.contactForRead(ReplicaPlans.java:558) at org.apache.cassandra.locator.ReplicaPlans.forRangeRead(ReplicaPlans.java:611) at org.apache.cassandra.service.reads.range.ReplicaPlanIterator.computeNext(ReplicaPlanIterator.java:76) at org.apache.cassandra.service.reads.range.ReplicaPlanIterator.computeNext(ReplicaPlanIterator.java:42) at org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47) at java.util.Iterator.forEachRemaining(Iterator.java:115) at org.apache.cassandra.service.reads.range.RangeCommands.sufficientLiveNodesForSelectStar(RangeCommands.java:135) at org.apache.cassandra.schema.PartitionDenylist.checkDenylistNodeAvailability(PartitionDenylist.java:169) at org.apache.cassandra.schema.PartitionDenylist.initialLoad(PartitionDenylist.java:148) at org.apache.cassandra.service.StorageProxy.initialLoadPartitionDenylist(StorageProxy.java:2914) at org.apache.cassandra.service.StorageService.joinTokenRing(StorageService.java:1224) at org.apache.cassandra.service.StorageService.joinTokenRing(StorageService.java:1145) at org.apache.cassandra.service.StorageService.initServer(StorageService.java:936) at org.apache.cassandra.service.StorageService.initServer(StorageService.java:854) at org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:424) at org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:751) at org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:875) INFO [main] 2023-06-29 14:12:17,870 PartitionDenylist.java:163 - Exception while loading partition denylist cache. Scheduled retry in 5 seconds. {code} h2. How to reproduce I encountered it after the upgrade process. But I think it can also be reproduced without the upgrade process. 1. Set up Cassandra-4.1.2 single node, add the follow configurations to cassandra.yaml {code:java} denylist_consistency_level: NODE_LOCAL partition_denylist_enabled: true{code} 2. Start up Cassandra, the error message will show in system.log file. h2. Root Cause After setting denylist_consistency_level to NODE LEVEL, when loading denylist, it invokes the _blockFor_ method {code:java} public int blockFor(AbstractReplicationStrategy replicationStrategy) { switch (this) { case ONE: case LOCAL_ONE: return 1; case ANY: return 1; case TWO: return 2; case THREE: return 3; case QUORUM: case SERIAL: return quorumFor(replicationStrategy); case ALL: return replicationStrategy.getReplicationFactor().allReplicas; case LOCAL_QUORUM: case LOCAL_SERIAL: return localQuorumForOurDc(replicationStrategy); case EACH_QUORUM: if (replicationStrategy instanceof NetworkTopologyStrategy) { NetworkTopologyStrategy strategy = (NetworkTopologyStrategy) replicationStrategy; int n = 0; for (String dc : strategy.getDatacenters()) n += localQuorumFor(replicationStrategy, dc); return n; } else { return quorumFor(replicationStrategy); } default: throw new UnsupportedOperationException("Invalid consistency level: " + toString()); } } {code} However, the _NODE_LOCAL_ enum is not included in those cases and thus results in the exception message. Should this enum be included, or does Cassandra forbid users from using partition denylist with the _NODE_LOCAL_ consistency level (even for debugging purposes)? -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For
[jira] [Commented] (CASSANDRA-18636) AssertionError: Unknown keyspace after dropping a keyspace
[ https://issues.apache.org/jira/browse/CASSANDRA-18636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738590#comment-17738590 ] Brandon Williams commented on CASSANDRA-18636: -- That may help this specific exception but note that doing schema changes this quickly is always going to be brittle before CEP-21 and should be avoided if possible. > AssertionError: Unknown keyspace after dropping a keyspace > -- > > Key: CASSANDRA-18636 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18636 > Project: Cassandra > Issue Type: Bug >Reporter: Ke Han >Priority: Normal > Attachments: system.log > > Time Spent: 10m > Remaining Estimate: 0h > > When running Cassandra cluster (3 nodes) in 3.11.15, I noticed that there is > an ERROR message in system.log after drop keyspace command is executed. > {code:java} > INFO [Native-Transport-Requests-1] 2023-06-26 06:11:48,575 > MigrationManager.java:205 - Create new Keyspace: > KeyspaceMetadata{name=uuide1b80964f06a424c8a57884564127745, > params=KeyspaceParams{durable_writes=true, > replication=ReplicationParams{class=org.apache.cassandra.locator.SimpleStrategy, > replication_factor=2}}, tables=[], views=[], functions=[], types=[]} > INFO [Native-Transport-Requests-1] 2023-06-26 06:11:53,106 > MigrationManager.java:205 - Create new Keyspace: > KeyspaceMetadata{name=uuidd17c2b7bfea545d0801a3c05e0e5307a, > params=KeyspaceParams{durable_writes=true, > replication=ReplicationParams{class=org.apache.cassandra.locator.SimpleStrategy, > replication_factor=1}}, tables=[], views=[], functions=[], types=[]} > INFO [Native-Transport-Requests-2] 2023-06-26 06:11:56,673 > MigrationManager.java:235 - Create new table: > org.apache.cassandra.config.CFMetaData@705b690b[cfId=5a7fcf10-13e8-11ee-9cb7-e10fdc7464a5,ksName=uuidd17c2b7bfea545d0801a3c05e0e5307a,cfName=vzkzguyh,flags=[COMPOUND],params=TableParams{comment=, > read_repair_chance=0.0, dclocal_read_repair_chance=0.1, > bloom_filter_fp_chance=0.01, crc_check_chance=1.0, gc_grace_seconds=864000, > default_time_to_live=0, memtable_flush_period_in_ms=0, > min_index_interval=128, max_index_interval=2048, speculative_retry=50.0ms, > caching={'keys' : 'ALL', 'rows_per_partition' : 'NONE'}, > compaction=CompactionParams{class=org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy, > options={min_threshold=4, max_threshold=32}}, > compression=org.apache.cassandra.schema.CompressionParams@a8f0c342, > extensions={}, cdc=false},comparator=comparator(),partitionColumns=[[] | > [condcduzca o ukwhjwbdljqnz > vzkzguyh]],partitionKeyColumns=[gveohmecfdwx],clusteringColumns=[],keyValidator=org.apache.cassandra.db.marshal.UTF8Type,columnMetadata=[gveohmecfdwx, > condcduzca, vzkzguyh, o, > ukwhjwbdljqnz],droppedColumns={},triggers=[],indexes=[]] > INFO [MigrationStage:1] 2023-06-26 06:12:03,118 ColumnFamilyStore.java:432 - > Initializing uuidd17c2b7bfea545d0801a3c05e0e5307a.vzkzguyh > INFO [Native-Transport-Requests-9] 2023-06-26 06:12:04,634 > MigrationManager.java:235 - Create new table: > org.apache.cassandra.config.CFMetaData@61f10dd7[cfId=5f3e8fa0-13e8-11ee-9cb7-e10fdc7464a5,ksName=uuidd17c2b7bfea545d0801a3c05e0e5307a,cfName=o,flags=[COMPOUND],params=TableParams{comment=, > read_repair_chance=0.0, dclocal_read_repair_chance=0.1, > bloom_filter_fp_chance=0.01, crc_check_chance=1.0, gc_grace_seconds=864000, > default_time_to_live=0, memtable_flush_period_in_ms=0, > min_index_interval=128, max_index_interval=2048, speculative_retry=ALWAYS, > caching={'keys' : 'ALL', 'rows_per_partition' : 'NONE'}, > compaction=CompactionParams{class=org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy, > options={min_threshold=4, max_threshold=32}}, > compression=org.apache.cassandra.schema.CompressionParams@a8f0c342, > extensions={}, cdc=false},comparator=comparator(),partitionColumns=[[] | > [dzwqnsv gveohmecfdwx o > ukwhjwbdljqnz]],partitionKeyColumns=[vzkzguyh],clusteringColumns=[],keyValidator=org.apache.cassandra.db.marshal.Int32Type,columnMetadata=[dzwqnsv, > vzkzguyh, gveohmecfdwx, o, > ukwhjwbdljqnz],droppedColumns={},triggers=[],indexes=[]] > INFO [MigrationStage:1] 2023-06-26 06:12:11,862 ColumnFamilyStore.java:432 - > Initializing uuidd17c2b7bfea545d0801a3c05e0e5307a.o > INFO [Native-Transport-Requests-6] 2023-06-26 06:12:13,165 > MigrationManager.java:205 - Create new Keyspace: > KeyspaceMetadata{name=uuid1602df26aef747d6af8f6d0c36fb1a44, > params=KeyspaceParams{durable_writes=true, > replication=ReplicationParams{class=org.apache.cassandra.locator.SimpleStrategy, > replication_factor=1}}, tables=[], views=[], functions=[], types=[]} > INFO [MigrationStage:1] 2023-06-26 06:12:20,413 > MigrationCoordinator.java:531 - Sending schema pull request to
[cassandra-website] branch asf-staging updated (11620e781 -> 5469afc28)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 11620e781 generate docs for 466d6ffe new 5469afc28 generate docs for 466d6ffe This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (11620e781) \ N -- N -- N refs/heads/asf-staging (5469afc28) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/search-index.js | 2 +- site-ui/build/ui-bundle.zip | Bin 4796900 -> 4796900 bytes 2 files changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18467) Update generate-idea-files for J17
[ https://issues.apache.org/jira/browse/CASSANDRA-18467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-18467: --- Status: Review In Progress (was: Changes Suggested) > Update generate-idea-files for J17 > -- > > Key: CASSANDRA-18467 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18467 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Jakub Zytka >Priority: Low > Fix For: 5.x > > Time Spent: 0.5h > Remaining Estimate: 0h > > There was a discussion in CASSANDRA-18258 how to update generate-idea-files. > The final agreement was to create one target to cover both Java 11 and Java > 17. > It will be good to figure out CASSANDRA-18263 and reshuffle arguments and > tasks based on what we decide to use as gc in testing for both Java 11 and > Java 17. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18467) Update generate-idea-files for J17
[ https://issues.apache.org/jira/browse/CASSANDRA-18467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738583#comment-17738583 ] Michael Semb Wever commented on CASSANDRA-18467: Completed patch here: https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/18467/trunk [~jmeredithco], can you check this works for you ok? (it is not just to set your command line jdk to 17 and then run `ant generate-idea-files`) > Update generate-idea-files for J17 > -- > > Key: CASSANDRA-18467 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18467 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Jakub Zytka >Priority: Low > Fix For: 5.x > > Time Spent: 0.5h > Remaining Estimate: 0h > > There was a discussion in CASSANDRA-18258 how to update generate-idea-files. > The final agreement was to create one target to cover both Java 11 and Java > 17. > It will be good to figure out CASSANDRA-18263 and reshuffle arguments and > tasks based on what we decide to use as gc in testing for both Java 11 and > Java 17. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18467) Update generate-idea-files for J17
[ https://issues.apache.org/jira/browse/CASSANDRA-18467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Semb Wever updated CASSANDRA-18467: --- Reviewers: Ekaterina Dimitrova, Michael Semb Wever, Stefan Miklosovic (was: Ekaterina Dimitrova, Michael Semb Wever) > Update generate-idea-files for J17 > -- > > Key: CASSANDRA-18467 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18467 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Ekaterina Dimitrova >Assignee: Jakub Zytka >Priority: Low > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > There was a discussion in CASSANDRA-18258 how to update generate-idea-files. > The final agreement was to create one target to cover both Java 11 and Java > 17. > It will be good to figure out CASSANDRA-18263 and reshuffle arguments and > tasks based on what we decide to use as gc in testing for both Java 11 and > Java 17. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18636) AssertionError: Unknown keyspace after dropping a keyspace
[ https://issues.apache.org/jira/browse/CASSANDRA-18636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ke Han updated CASSANDRA-18636: --- Description: When running Cassandra cluster (3 nodes) in 3.11.15, I noticed that there is an ERROR message in system.log after drop keyspace command is executed. {code:java} INFO [Native-Transport-Requests-1] 2023-06-26 06:11:48,575 MigrationManager.java:205 - Create new Keyspace: KeyspaceMetadata{name=uuide1b80964f06a424c8a57884564127745, params=KeyspaceParams{durable_writes=true, replication=ReplicationParams{class=org.apache.cassandra.locator.SimpleStrategy, replication_factor=2}}, tables=[], views=[], functions=[], types=[]} INFO [Native-Transport-Requests-1] 2023-06-26 06:11:53,106 MigrationManager.java:205 - Create new Keyspace: KeyspaceMetadata{name=uuidd17c2b7bfea545d0801a3c05e0e5307a, params=KeyspaceParams{durable_writes=true, replication=ReplicationParams{class=org.apache.cassandra.locator.SimpleStrategy, replication_factor=1}}, tables=[], views=[], functions=[], types=[]} INFO [Native-Transport-Requests-2] 2023-06-26 06:11:56,673 MigrationManager.java:235 - Create new table: org.apache.cassandra.config.CFMetaData@705b690b[cfId=5a7fcf10-13e8-11ee-9cb7-e10fdc7464a5,ksName=uuidd17c2b7bfea545d0801a3c05e0e5307a,cfName=vzkzguyh,flags=[COMPOUND],params=TableParams{comment=, read_repair_chance=0.0, dclocal_read_repair_chance=0.1, bloom_filter_fp_chance=0.01, crc_check_chance=1.0, gc_grace_seconds=864000, default_time_to_live=0, memtable_flush_period_in_ms=0, min_index_interval=128, max_index_interval=2048, speculative_retry=50.0ms, caching={'keys' : 'ALL', 'rows_per_partition' : 'NONE'}, compaction=CompactionParams{class=org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy, options={min_threshold=4, max_threshold=32}}, compression=org.apache.cassandra.schema.CompressionParams@a8f0c342, extensions={}, cdc=false},comparator=comparator(),partitionColumns=[[] | [condcduzca o ukwhjwbdljqnz vzkzguyh]],partitionKeyColumns=[gveohmecfdwx],clusteringColumns=[],keyValidator=org.apache.cassandra.db.marshal.UTF8Type,columnMetadata=[gveohmecfdwx, condcduzca, vzkzguyh, o, ukwhjwbdljqnz],droppedColumns={},triggers=[],indexes=[]] INFO [MigrationStage:1] 2023-06-26 06:12:03,118 ColumnFamilyStore.java:432 - Initializing uuidd17c2b7bfea545d0801a3c05e0e5307a.vzkzguyh INFO [Native-Transport-Requests-9] 2023-06-26 06:12:04,634 MigrationManager.java:235 - Create new table: org.apache.cassandra.config.CFMetaData@61f10dd7[cfId=5f3e8fa0-13e8-11ee-9cb7-e10fdc7464a5,ksName=uuidd17c2b7bfea545d0801a3c05e0e5307a,cfName=o,flags=[COMPOUND],params=TableParams{comment=, read_repair_chance=0.0, dclocal_read_repair_chance=0.1, bloom_filter_fp_chance=0.01, crc_check_chance=1.0, gc_grace_seconds=864000, default_time_to_live=0, memtable_flush_period_in_ms=0, min_index_interval=128, max_index_interval=2048, speculative_retry=ALWAYS, caching={'keys' : 'ALL', 'rows_per_partition' : 'NONE'}, compaction=CompactionParams{class=org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy, options={min_threshold=4, max_threshold=32}}, compression=org.apache.cassandra.schema.CompressionParams@a8f0c342, extensions={}, cdc=false},comparator=comparator(),partitionColumns=[[] | [dzwqnsv gveohmecfdwx o ukwhjwbdljqnz]],partitionKeyColumns=[vzkzguyh],clusteringColumns=[],keyValidator=org.apache.cassandra.db.marshal.Int32Type,columnMetadata=[dzwqnsv, vzkzguyh, gveohmecfdwx, o, ukwhjwbdljqnz],droppedColumns={},triggers=[],indexes=[]] INFO [MigrationStage:1] 2023-06-26 06:12:11,862 ColumnFamilyStore.java:432 - Initializing uuidd17c2b7bfea545d0801a3c05e0e5307a.o INFO [Native-Transport-Requests-6] 2023-06-26 06:12:13,165 MigrationManager.java:205 - Create new Keyspace: KeyspaceMetadata{name=uuid1602df26aef747d6af8f6d0c36fb1a44, params=KeyspaceParams{durable_writes=true, replication=ReplicationParams{class=org.apache.cassandra.locator.SimpleStrategy, replication_factor=1}}, tables=[], views=[], functions=[], types=[]} INFO [MigrationStage:1] 2023-06-26 06:12:20,413 MigrationCoordinator.java:531 - Sending schema pull request to /192.168.103.3 at 1687759940413 with timeout 4287 INFO [Native-Transport-Requests-3] 2023-06-26 06:12:21,270 MigrationManager.java:286 - Update Keyspace 'uuid1602df26aef747d6af8f6d0c36fb1a44' From KeyspaceMetadata{name=uuid1602df26aef747d6af8f6d0c36fb1a44, params=KeyspaceParams{durable_writes=true, replication=ReplicationParams{class=org.apache.cassandra.locator.SimpleStrategy, replication_factor=1}}, tables=[], views=[], functions=[], types=[org.apache.cassandra.db.marshal.UserType(uuid1602df26aef747d6af8f6d0c36fb1a44,756c76796163,71:org.apache.cassandra.db.marshal.UTF8Type,756c76796163:org.apache.cassandra.db.marshal.Int32Type)]} To KeyspaceMetadata{name=uuid1602df26aef747d6af8f6d0c36fb1a44, params=KeyspaceParams{durable_writes=true,
[jira] [Commented] (CASSANDRA-7147) Add a new snitch for Apache Cloudstack platforms
[ https://issues.apache.org/jira/browse/CASSANDRA-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738561#comment-17738561 ] Pierre-Yves Ritschard commented on CASSANDRA-7147: -- Don't hesitate to use the provided account to validate the latter if you get around to it. Cheers, > Add a new snitch for Apache Cloudstack platforms > > > Key: CASSANDRA-7147 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7147 > Project: Cassandra > Issue Type: Improvement > Environment: Virtual machine on Apache Cloudstack environments >Reporter: Pierre-Yves Ritschard >Assignee: Pierre-Yves Ritschard >Priority: Low > Fix For: 1.2.18, 2.0.8, 2.1 rc1 > > Attachments: 0001-initial-work-on-a-cloudstack-snitch.patch > > > The attached patch adds a new Snitch that queries meta data for a host on > Apache Cloudstack environments. Since the metadata service is colocated with > the DHCP service in Cloudstack, common lease file locations are looked up to > retrieve. > Since zone naming is freeform in Apache Cloudstack, the widely used > -- notation is assumed. > The patch includes a simple unit test and has been tested on exoscale.ch, a > public cloud based on Apache Cloudstack -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-7147) Add a new snitch for Apache Cloudstack platforms
[ https://issues.apache.org/jira/browse/CASSANDRA-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738560#comment-17738560 ] Stefan Miklosovic commented on CASSANDRA-7147: -- Yeah, let's wait a while. Regardless of the user-base using this snitch or not, I still see the value in the refactoring of the existing cloud-based snitches (minus this one) to simplify the code and reuse as much as possible. > Add a new snitch for Apache Cloudstack platforms > > > Key: CASSANDRA-7147 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7147 > Project: Cassandra > Issue Type: Improvement > Environment: Virtual machine on Apache Cloudstack environments >Reporter: Pierre-Yves Ritschard >Assignee: Pierre-Yves Ritschard >Priority: Low > Fix For: 1.2.18, 2.0.8, 2.1 rc1 > > Attachments: 0001-initial-work-on-a-cloudstack-snitch.patch > > > The attached patch adds a new Snitch that queries meta data for a host on > Apache Cloudstack environments. Since the metadata service is colocated with > the DHCP service in Cloudstack, common lease file locations are looked up to > retrieve. > Since zone naming is freeform in Apache Cloudstack, the widely used > -- notation is assumed. > The patch includes a simple unit test and has been tested on exoscale.ch, a > public cloud based on Apache Cloudstack -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-7147) Add a new snitch for Apache Cloudstack platforms
[ https://issues.apache.org/jira/browse/CASSANDRA-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738557#comment-17738557 ] Brandon Williams commented on CASSANDRA-7147: - Unless users come forward for this snitch, I think retiring it is the best option. > Add a new snitch for Apache Cloudstack platforms > > > Key: CASSANDRA-7147 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7147 > Project: Cassandra > Issue Type: Improvement > Environment: Virtual machine on Apache Cloudstack environments >Reporter: Pierre-Yves Ritschard >Assignee: Pierre-Yves Ritschard >Priority: Low > Fix For: 1.2.18, 2.0.8, 2.1 rc1 > > Attachments: 0001-initial-work-on-a-cloudstack-snitch.patch > > > The attached patch adds a new Snitch that queries meta data for a host on > Apache Cloudstack environments. Since the metadata service is colocated with > the DHCP service in Cloudstack, common lease file locations are looked up to > retrieve. > Since zone naming is freeform in Apache Cloudstack, the widely used > -- notation is assumed. > The patch includes a simple unit test and has been tested on exoscale.ch, a > public cloud based on Apache Cloudstack -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18592) CIDR filtering authorizer for Cassandra
[ https://issues.apache.org/jira/browse/CASSANDRA-18592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738501#comment-17738501 ] Brandon Williams edited comment on CASSANDRA-18592 at 6/29/23 12:52 PM: I don't think we need to optimize for reverting, it probably won't happen and even so, it won't be difficult regardless since we can always squash commits. was (Author: brandon.williams): I don't think we need to optimize for reverting, it probably won't happen and even so, it won't be difficult regardless. > CIDR filtering authorizer for Cassandra > --- > > Key: CASSANDRA-18592 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18592 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Authorization >Reporter: Shailaja Koppu >Assignee: Shailaja Koppu >Priority: Normal > Labels: authorization, cidr, features, security > Time Spent: 0.5h > Remaining Estimate: 0h > > Introducing a new authorizer, to allow or disallow users accesses based on > client's IP or CIDR group. Please see the confluence page for requirements > and detailed design of this feature > [https://cwiki.apache.org/confluence/display/CASSANDRA/CIDR+filtering+authorizer]. > Will post PR link and dev discussion soon. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17992) Upgrade Netty on 5.0
[ https://issues.apache.org/jira/browse/CASSANDRA-17992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738556#comment-17738556 ] Jacek Lewandowski commented on CASSANDRA-17992: --- Summary: Among release notes between 4.1.58 and 4.1.94 I've found "important notes" in the following releases: - https://netty.io/news/2021/03/09/4-1-60-Final.html - https://netty.io/news/2021/03/30/4-1-61-Final.html - https://netty.io/news/2022/01/12/4-1-73-Final.html - https://netty.io/news/2022/03/10/4-1-75-Final.html - https://netty.io/news/2022/10/11/4-1-84-Final.html The following changes have been applied: - Added explicit dependency to {{org.bouncycastle:bcpkix-jdk15on:1.70}} ([~brandon.williams]) - https://github.com/netty/netty/pull/11495 - Updated version of {{io.netty:netty-tcnative-boringssl-static}} to {{2.0.61.Final}} ([~brandon.williams]) - https://github.com/netty/netty/commit/9d28ad5403 - Due to packaging changes, we needed to explicitly include the dependency {{io.netty:netty-transport-native-epoll:4.1.94.Final:linux-x86_64}} https://github.com/netty/netty/commit/04f0eedea8 - {{InternodeEncryptionOptionsTest}} now verifies also TLSv1.3, TLSv1.1 has been deprecated and is now disabled by default - - Some defaults has been changed, in particular thread local caching and chunk size in heap allocator, therefore system properties have been added to bring back the values we used before upgrade ({{io.netty.allocator.useCacheForAllThreads=true}}, {{io.netty.allocator.maxOrder=11}} - https://github.com/netty/netty/commit/b61d7d40f4, https://github.com/netty/netty/commit/4797b88d89 There is also a file attached to the PR: https://github.com/jacek-lewandowski/cassandra/blob/CASSANDRA-17992/netty-release-notes-filtered.md, which lists the release notes. Those were filtered by removing changes that were uninteresting, like changes in build, tests, related to http, brotli, udp, websockets, etc. Additionally there is also https://github.com/jacek-lewandowski/cassandra/blob/CASSANDRA-17992/netty-release-notes.md with all release notes. > Upgrade Netty on 5.0 > > > Key: CASSANDRA-17992 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17992 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Jacek Lewandowski >Priority: Low > Fix For: 5.x > > > I haven't been able to identify from the Netty docs which was the lowest > version where JDK17 was added but we are about 40 versions behind in netty 4 > so I suspect we better update. > -We need to consider there was an issue with class cast exceptions when > building with JDK17 with newer versions of netty (the newest available in > March 2022). For the record, we didn't see those when running CI on JDK8 and > JDK11. We also need to carefully revise the changes between the netty > versions. -->- CASSANDRA-18180 > Upgrading will cover also a fix in netty that was discussed in > [this|https://the-asf.slack.com/archives/CK23JSY2K/p1665567660202989] ASF > Slack thread. > CC [~benedict] , [~aleksey] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-7147) Add a new snitch for Apache Cloudstack platforms
[ https://issues.apache.org/jira/browse/CASSANDRA-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738552#comment-17738552 ] Stefan Miklosovic commented on CASSANDRA-7147: -- [~jlewandowski] look what a great discussion we have here. > Add a new snitch for Apache Cloudstack platforms > > > Key: CASSANDRA-7147 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7147 > Project: Cassandra > Issue Type: Improvement > Environment: Virtual machine on Apache Cloudstack environments >Reporter: Pierre-Yves Ritschard >Assignee: Pierre-Yves Ritschard >Priority: Low > Fix For: 1.2.18, 2.0.8, 2.1 rc1 > > Attachments: 0001-initial-work-on-a-cloudstack-snitch.patch > > > The attached patch adds a new Snitch that queries meta data for a host on > Apache Cloudstack environments. Since the metadata service is colocated with > the DHCP service in Cloudstack, common lease file locations are looked up to > retrieve. > Since zone naming is freeform in Apache Cloudstack, the widely used > -- notation is assumed. > The patch includes a simple unit test and has been tested on exoscale.ch, a > public cloud based on Apache Cloudstack -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-7147) Add a new snitch for Apache Cloudstack platforms
[ https://issues.apache.org/jira/browse/CASSANDRA-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738550#comment-17738550 ] Pierre-Yves Ritschard commented on CASSANDRA-7147: -- > this is offtopic to this ticket but I think we should harmonize all cloud > snitches we currently have. If we go with data-server. approach, this > approach is no different from Alibaba or GCP or even AWS which are calling > some metadata services and only endpoints are different. Yes, and as exhibited by `cloud-init` most use the same data format, if the url becomes configurable, the rest is mostly the same across IaaS providers > Add a new snitch for Apache Cloudstack platforms > > > Key: CASSANDRA-7147 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7147 > Project: Cassandra > Issue Type: Improvement > Environment: Virtual machine on Apache Cloudstack environments >Reporter: Pierre-Yves Ritschard >Assignee: Pierre-Yves Ritschard >Priority: Low > Fix For: 1.2.18, 2.0.8, 2.1 rc1 > > Attachments: 0001-initial-work-on-a-cloudstack-snitch.patch > > > The attached patch adds a new Snitch that queries meta data for a host on > Apache Cloudstack environments. Since the metadata service is colocated with > the DHCP service in Cloudstack, common lease file locations are looked up to > retrieve. > Since zone naming is freeform in Apache Cloudstack, the widely used > -- notation is assumed. > The patch includes a simple unit test and has been tested on exoscale.ch, a > public cloud based on Apache Cloudstack -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-7147) Add a new snitch for Apache Cloudstack platforms
[ https://issues.apache.org/jira/browse/CASSANDRA-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738547#comment-17738547 ] Stefan Miklosovic commented on CASSANDRA-7147: -- this is offtopic to this ticket but I think we should harmonize all cloud snitches we currently have. If we go with data-server. approach, this approach is no different from Alibaba or GCP or even AWS which are calling some metadata services and only endpoints are different. >From the implementation point of view, we would greatly simplify the code, I >can see how all snitches would extend some generic cloud-metadata-service >snitch where only URLs are different. > Add a new snitch for Apache Cloudstack platforms > > > Key: CASSANDRA-7147 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7147 > Project: Cassandra > Issue Type: Improvement > Environment: Virtual machine on Apache Cloudstack environments >Reporter: Pierre-Yves Ritschard >Assignee: Pierre-Yves Ritschard >Priority: Low > Fix For: 1.2.18, 2.0.8, 2.1 rc1 > > Attachments: 0001-initial-work-on-a-cloudstack-snitch.patch > > > The attached patch adds a new Snitch that queries meta data for a host on > Apache Cloudstack environments. Since the metadata service is colocated with > the DHCP service in Cloudstack, common lease file locations are looked up to > retrieve. > Since zone naming is freeform in Apache Cloudstack, the widely used > -- notation is assumed. > The patch includes a simple unit test and has been tested on exoscale.ch, a > public cloud based on Apache Cloudstack -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-7147) Add a new snitch for Apache Cloudstack platforms
[ https://issues.apache.org/jira/browse/CASSANDRA-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738545#comment-17738545 ] Pierre-Yves Ritschard commented on CASSANDRA-7147: -- To be honest, since 1) is available, I don't see a ton of value in keeping the cloudstack specific snitch around. I love the fact that there's a part of Cassandra I wrote code for, but wonder if it is worth the effort to keep this customization around, wdyt? > Add a new snitch for Apache Cloudstack platforms > > > Key: CASSANDRA-7147 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7147 > Project: Cassandra > Issue Type: Improvement > Environment: Virtual machine on Apache Cloudstack environments >Reporter: Pierre-Yves Ritschard >Assignee: Pierre-Yves Ritschard >Priority: Low > Fix For: 1.2.18, 2.0.8, 2.1 rc1 > > Attachments: 0001-initial-work-on-a-cloudstack-snitch.patch > > > The attached patch adds a new Snitch that queries meta data for a host on > Apache Cloudstack environments. Since the metadata service is colocated with > the DHCP service in Cloudstack, common lease file locations are looked up to > retrieve. > Since zone naming is freeform in Apache Cloudstack, the widely used > -- notation is assumed. > The patch includes a simple unit test and has been tested on exoscale.ch, a > public cloud based on Apache Cloudstack -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org