[jira] [Comment Edited] (CASSANDRA-18778) Empty keystore_password no longer allowed on encryption_options
[ https://issues.apache.org/jira/browse/CASSANDRA-18778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762263#comment-17762263 ] Maulin Vasavada edited comment on CASSANDRA-18778 at 9/6/23 4:31 AM: - Hi [~andrew.tolbert] [~smiklosovic] sorry I am late looking at this but I read the details here. Interestingly when we did CASSANDRA-18124 changes, we did talk about this exact issue- What to do with password check for the JKS based keystores- as you would be able to notice in that ticket, !image-2023-09-05-21-13-06-602.png! So at that point we decided to go with enforcing the JKS keystores to have the password. However, based on what [~andrew.tolbert] mentions here about PKCS12 keystores generated without a password via OpenSSL makes a valid case in terms of `What tools allow?`. In the Keytool/Java it clearly gives a warning when we read keystores without a password that the authenticity of the data can't be verified without the password and that made me think about the password's necessity for the JKS keystores. So while from the operational standpoint I would still think we should specify password for the keystore, if the tooling from OpenSSL allows passwordless keystore creation, we can make this exception to cover for it. For the Truststores, however I think we can live without password since it is just a collection of `public keys` and authenticity like keystore may be considered optional. That was the primary thinking that resulted into the state of code that we have prior to this change. One challenge, if I recollect it right, I ran into was- in the YAML file I could not simulate the `null` password because there was a default of `empty string` somewhere (most likely EncryptionOptions.java). Based on what I see in your changes that got merged- I see that you are testing for `null` case from the code and not from the YAML. Just something to double-click on and see if there is anything we need to do more. If practically YAML file makes it difficult to have a possibility of `null` password, the CASSANDRA-18124 should not create a backward incompatibility issue in my opinion. All-in-all, I don't mind having to support keystores without passwords and don't feel it may be worth requiring passwords for the truststores :) was (Author: maulin.vasavada): Hi [~andrew.tolbert] [~smiklosovic] sorry I am late looking at this but I read the details here. Interestingly when we did CASSANDRA-18124 changes, we did talk about this exact issue- What to do with password check for the JKS based keystores- as you would be able to notice in that ticket, !image-2023-09-05-21-13-06-602.png! So at that point we decided to go with enforcing the JKS keystores to have the password. However, based on what [~andrew.tolbert] mentions here about PKCS12 keystores generated without a password via OpenSSL makes a valid case in terms of `What tools allow?`. In the Keytool/Java it clearly gives a warning when we read keystores without a password that the authenticity of the data can't be verified without the password and that made me think about the password's necessity for the JKS keystores. So while from the operational standpoint I would still think we should specify password for the keystore, if the tooling from OpenSSL allows passwordless keystore creation, we can make this exception to cover for it. For the Truststores, however I think we can live without password since it is just a collection of `public keys` and authenticity like keystore may be considered optional. That was the primary thinking that resulted into the state of code that we have prior to this change. One challenge, if I recollect it right, I ran into was- in the YAML file I could not simulate the `null` password because there was a default of `empty string` somewhere (most likely EncryptionOptions.java). Based on what I see in your changes that got merged- I see that you are testing for `null` case from the code and not from the YAML. Just something to double-click on and see if there is anything we need to do more. All-in-all, I don't mind having to support keystores without passwords and don't feel it may be worth requiring passwords for the truststores :) > Empty keystore_password no longer allowed on encryption_options > --- > > Key: CASSANDRA-18778 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18778 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Andy Tolbert >Assignee: Andy Tolbert >Priority: Normal > Fix For: 4.1.4, 5.0 > > Attachments: image-2023-09-05-21-13-06-602.png > > > After CASSANDRA-18124 (introduced in 4.1.2 and 5.0) it is no longer possible > to set an empty
[jira] [Comment Edited] (CASSANDRA-18778) Empty keystore_password no longer allowed on encryption_options
[
https://issues.apache.org/jira/browse/CASSANDRA-18778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762263#comment-17762263
]
Maulin Vasavada edited comment on CASSANDRA-18778 at 9/6/23 4:28 AM:
-
Hi [~andrew.tolbert] [~smiklosovic] sorry I am late looking at this but I read
the details here. Interestingly when we did CASSANDRA-18124 changes, we did
talk about this exact issue- What to do with password check for the JKS based
keystores- as you would be able to notice in that ticket,
!image-2023-09-05-21-13-06-602.png!
So at that point we decided to go with enforcing the JKS keystores to have the
password. However, based on what [~andrew.tolbert] mentions here about PKCS12
keystores generated without a password via OpenSSL makes a valid case in terms
of `What tools allow?`. In the Keytool/Java it clearly gives a warning when we
read keystores without a password that the authenticity of the data can't be
verified without the password and that made me think about the password's
necessity for the JKS keystores. So while from the operational standpoint I
would still think we should specify password for the keystore, if the tooling
from OpenSSL allows passwordless keystore creation, we can make this exception
to cover for it.
For the Truststores, however I think we can live without password since it is
just a collection of `public keys` and authenticity like keystore may be
considered optional. That was the primary thinking that resulted into the state
of code that we have prior to this change.
One challenge, if I recollect it right, I ran into was- in the YAML file I
could not simulate the `null` password because there was a default of `empty
string` somewhere (most likely EncryptionOptions.java). Based on what I see in
your changes that got merged- I see that you are testing for `null` case from
the code and not from the YAML. Just something to double-click on and see if
there is anything we need to do more.
All-in-all, I don't mind having to support keystores without passwords and
don't feel it may be worth requiring passwords for the truststores :)
was (Author: maulin.vasavada):
Hi [~andrew.tolbert] [~smiklosovic] sorry I am late looking at this but I read
the details here. Interestingly when we did CASSANDRA-18124 changes, we did
talk about this exact issue- What to do with password check for the JKS based
keystores- as you would be able to notice in that ticket,
!image-2023-09-05-21-13-06-602.png!
So at that point we decided to go with enforcing the JKS keystores to have the
password. However, based on what [~andrew.tolbert] mentions here about PKCS12
keystores generated without a password via OpenSSL makes a valid case in terms
of `What tools allows`. In the Keytool it clearly gives a warning when we read
keystores without a password that the authenticity of the data can't be
verified without the password and that made me think about the password's
necessity for the JKS keystores. So while from the operational standpoint I
would still think we should specify password for the keystore, if the tooling
from OpenSSL allows passwordless keystore creation, we can make this exception.
For the Truststores, however I think we can live without password since it is
just a collection of `public keys` and authenticity like keystore may be
considered optional. That was the primary thinking that resulted into the state
of code that we have prior to this change.
One challenge, if I recollect it right, I ran into was- in the YAML file I
could not simulate the `null` password because there was a default of `empty
string` somewhere (most likely EncryptionOptions.java). Based on what I see in
your changes that got merged- I see that you are testing for `null` case from
the code and not from the YAML. Just something to double-click on and see if
there is anything we need to do more.
All-in-all, I don't mind having to support keystores without passwords and
don't feel it may be worth requiring passwords for the truststores :)
> Empty keystore_password no longer allowed on encryption_options
> ---
>
> Key: CASSANDRA-18778
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18778
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
>Reporter: Andy Tolbert
>Assignee: Andy Tolbert
>Priority: Normal
> Fix For: 4.1.4, 5.0
>
> Attachments: image-2023-09-05-21-13-06-602.png
>
>
> After CASSANDRA-18124 (introduced in 4.1.2 and 5.0) it is no longer possible
> to set an empty {{keystore_password}} under {{client_encryption_options}} or
> {{server_encryption_options}} using the default implementation
> {{{}DefaultSslContextFactory{}}}.
> While keytool does not allow
[jira] [Comment Edited] (CASSANDRA-18778) Empty keystore_password no longer allowed on encryption_options
[
https://issues.apache.org/jira/browse/CASSANDRA-18778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762263#comment-17762263
]
Maulin Vasavada edited comment on CASSANDRA-18778 at 9/6/23 4:27 AM:
-
Hi [~andrew.tolbert] [~smiklosovic] sorry I am late looking at this but I read
the details here. Interestingly when we did CASSANDRA-18124 changes, we did
talk about this exact issue- What to do with password check for the JKS based
keystores- as you would be able to notice in that ticket,
!image-2023-09-05-21-13-06-602.png!
So at that point we decided to go with enforcing the JKS keystores to have the
password. However, based on what [~andrew.tolbert] mentions here about PKCS12
keystores generated without a password via OpenSSL makes a valid case in terms
of `What tools allows`. In the Keytool it clearly gives a warning when we read
keystores without a password that the authenticity of the data can't be
verified without the password and that made me think about the password's
necessity for the JKS keystores. So while from the operational standpoint I
would still think we should specify password for the keystore, if the tooling
from OpenSSL allows passwordless keystore creation, we can make this exception.
For the Truststores, however I think we can live without password since it is
just a collection of `public keys` and authenticity like keystore may be
considered optional. That was the primary thinking that resulted into the state
of code that we have prior to this change.
One challenge, if I recollect it right, I ran into was- in the YAML file I
could not simulate the `null` password because there was a default of `empty
string` somewhere (most likely EncryptionOptions.java). Based on what I see in
your changes that got merged- I see that you are testing for `null` case from
the code and not from the YAML. Just something to double-click on and see if
there is anything we need to do more.
All-in-all, I don't mind having to support keystores without passwords and
don't feel it may be worth requiring passwords for the truststores :)
was (Author: maulin.vasavada):
Hi [~andrew.tolbert] [~smiklosovic] sorry I am late looking at this but I read
the details here. Interestingly when we did CASSANDRA-18124 changes, we did
talk about this exact issue- What to do with password check for the JKS based
keystores- as you would be able to notice in that ticket,
!image-2023-09-05-21-13-06-602.png!
So at that point we decided to go with enforcing the JKS keystores to have the
password. However, based on what [~andrew.tolbert] mentions here about PKCS12
keystores generated without a password via OpenSSL makes a valid case in terms
of `What tools allows`. In the Keytool it clearly gives a warning when we read
keystores without a password that the authenticity of the data can't be
verified without the password and that made me think about the password's
necessity for the JKS keystores. So while from the operational standpoint I
would still think we should specify password for the keystore, if the tooling
from OpenSSL allows passwordless keystore creation, we can make this exception.
For the Truststores, however I think we can live without password since it is
just a collection of `public keys` and authenticity like keystore may be
considered optional. That was the primary thinking that resulted into the state
of code that we have prior to this change.
One challenge, if I recollect it right, I ran into was- in the YAML file I
could not simulate the `null` password because there was a default of `empty
string` somewhere (most likely EncryptionOptions.java). However, if your
changes are tested already and merged I guess you have a test case for
differentiating `null` vs `empty string` (will check your PR).
All-in-all, I don't mind having to support keystores without passwords and
don't feel it may be worth requiring passwords for the truststores :)
> Empty keystore_password no longer allowed on encryption_options
> ---
>
> Key: CASSANDRA-18778
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18778
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
>Reporter: Andy Tolbert
>Assignee: Andy Tolbert
>Priority: Normal
> Fix For: 4.1.4, 5.0
>
> Attachments: image-2023-09-05-21-13-06-602.png
>
>
> After CASSANDRA-18124 (introduced in 4.1.2 and 5.0) it is no longer possible
> to set an empty {{keystore_password}} under {{client_encryption_options}} or
> {{server_encryption_options}} using the default implementation
> {{{}DefaultSslContextFactory{}}}.
> While keytool does not allow generating keystores with empty passwords, it
> does support reading
[jira] [Commented] (CASSANDRA-18778) Empty keystore_password no longer allowed on encryption_options
[
https://issues.apache.org/jira/browse/CASSANDRA-18778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762263#comment-17762263
]
Maulin Vasavada commented on CASSANDRA-18778:
-
Hi [~andrew.tolbert] [~smiklosovic] sorry I am late looking at this but I read
the details here. Interestingly when we did CASSANDRA-18124 changes, we did
talk about this exact issue- What to do with password check for the JKS based
keystores- as you would be able to notice in that ticket,
!image-2023-09-05-21-13-06-602.png!
So at that point we decided to go with enforcing the JKS keystores to have the
password. However, based on what [~andrew.tolbert] mentions here about PKCS12
keystores generated without a password via OpenSSL makes a valid case in terms
of `What tools allows`. In the Keytool it clearly gives a warning when we read
keystores without a password that the authenticity of the data can't be
verified without the password and that made me think about the password's
necessity for the JKS keystores. So while from the operational standpoint I
would still think we should specify password for the keystore, if the tooling
from OpenSSL allows passwordless keystore creation, we can make this exception.
For the Truststores, however I think we can live without password since it is
just a collection of `public keys` and authenticity like keystore may be
considered optional. That was the primary thinking that resulted into the state
of code that we have prior to this change.
One challenge, if I recollect it right, I ran into was- in the YAML file I
could not simulate the `null` password because there was a default of `empty
string` somewhere (most likely EncryptionOptions.java). However, if your
changes are tested already and merged I guess you have a test case for
differentiating `null` vs `empty string` (will check your PR).
All-in-all, I don't mind having to support keystores without passwords and
don't feel it may be worth requiring passwords for the truststores :)
> Empty keystore_password no longer allowed on encryption_options
> ---
>
> Key: CASSANDRA-18778
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18778
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
>Reporter: Andy Tolbert
>Assignee: Andy Tolbert
>Priority: Normal
> Fix For: 4.1.4, 5.0
>
> Attachments: image-2023-09-05-21-13-06-602.png
>
>
> After CASSANDRA-18124 (introduced in 4.1.2 and 5.0) it is no longer possible
> to set an empty {{keystore_password}} under {{client_encryption_options}} or
> {{server_encryption_options}} using the default implementation
> {{{}DefaultSslContextFactory{}}}.
> While keytool does not allow generating keystores with empty passwords, it
> does support reading them. It is not uncommon to use PKCS12 certificates
> generated by other tools (eg. openssl) that do not enforce passwords.
> The fix for this should be pretty straightforward, which should involve
> changing
> [FileBasedSslContextFactory.validatePassword|https://github.com/apache/cassandra/blob/cassandra-4.1.2/src/java/org/apache/cassandra/security/FileBasedSslContextFactory.java#L128-L135]
> to only disallow null passwords (which would be consistent with previous
> versions). I will create pull requests against the relevant branches shortly.
> {noformat}
> Exception (org.apache.cassandra.exceptions.ConfigurationException)
> encountered during startup: Failed to initialize SSL
> org.apache.cassandra.exceptions.ConfigurationException: Failed to initialize
> SSL
> at
> org.apache.cassandra.config.DatabaseDescriptor.applySslContext(DatabaseDescriptor.java:1155)
> at
> org.apache.cassandra.config.DatabaseDescriptor.applyAll(DatabaseDescriptor.java:390)
> at
> org.apache.cassandra.config.DatabaseDescriptor.daemonInitialization(DatabaseDescriptor.java:204)
> at
> org.apache.cassandra.config.DatabaseDescriptor.daemonInitialization(DatabaseDescriptor.java:188)
> at
> org.apache.cassandra.service.CassandraDaemon.applyConfig(CassandraDaemon.java:804)
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:747)
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:875)
> Caused by: java.io.IOException: Failed to create SSL context using Native
> transport
> at
> org.apache.cassandra.security.SSLFactory.validateSslContext(SSLFactory.java:405)
> at
> org.apache.cassandra.config.DatabaseDescriptor.applySslContext(DatabaseDescriptor.java:1150)
> ... 6 more
> Caused by: java.lang.IllegalArgumentException: 'keystore_password' must be
> specified
> at
>
[jira] [Updated] (CASSANDRA-18778) Empty keystore_password no longer allowed on encryption_options
[
https://issues.apache.org/jira/browse/CASSANDRA-18778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maulin Vasavada updated CASSANDRA-18778:
Attachment: image-2023-09-05-21-13-06-602.png
> Empty keystore_password no longer allowed on encryption_options
> ---
>
> Key: CASSANDRA-18778
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18778
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
>Reporter: Andy Tolbert
>Assignee: Andy Tolbert
>Priority: Normal
> Fix For: 4.1.4, 5.0
>
> Attachments: image-2023-09-05-21-13-06-602.png
>
>
> After CASSANDRA-18124 (introduced in 4.1.2 and 5.0) it is no longer possible
> to set an empty {{keystore_password}} under {{client_encryption_options}} or
> {{server_encryption_options}} using the default implementation
> {{{}DefaultSslContextFactory{}}}.
> While keytool does not allow generating keystores with empty passwords, it
> does support reading them. It is not uncommon to use PKCS12 certificates
> generated by other tools (eg. openssl) that do not enforce passwords.
> The fix for this should be pretty straightforward, which should involve
> changing
> [FileBasedSslContextFactory.validatePassword|https://github.com/apache/cassandra/blob/cassandra-4.1.2/src/java/org/apache/cassandra/security/FileBasedSslContextFactory.java#L128-L135]
> to only disallow null passwords (which would be consistent with previous
> versions). I will create pull requests against the relevant branches shortly.
> {noformat}
> Exception (org.apache.cassandra.exceptions.ConfigurationException)
> encountered during startup: Failed to initialize SSL
> org.apache.cassandra.exceptions.ConfigurationException: Failed to initialize
> SSL
> at
> org.apache.cassandra.config.DatabaseDescriptor.applySslContext(DatabaseDescriptor.java:1155)
> at
> org.apache.cassandra.config.DatabaseDescriptor.applyAll(DatabaseDescriptor.java:390)
> at
> org.apache.cassandra.config.DatabaseDescriptor.daemonInitialization(DatabaseDescriptor.java:204)
> at
> org.apache.cassandra.config.DatabaseDescriptor.daemonInitialization(DatabaseDescriptor.java:188)
> at
> org.apache.cassandra.service.CassandraDaemon.applyConfig(CassandraDaemon.java:804)
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:747)
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:875)
> Caused by: java.io.IOException: Failed to create SSL context using Native
> transport
> at
> org.apache.cassandra.security.SSLFactory.validateSslContext(SSLFactory.java:405)
> at
> org.apache.cassandra.config.DatabaseDescriptor.applySslContext(DatabaseDescriptor.java:1150)
> ... 6 more
> Caused by: java.lang.IllegalArgumentException: 'keystore_password' must be
> specified
> at
> org.apache.cassandra.security.FileBasedSslContextFactory.validatePassword(FileBasedSslContextFactory.java:133)
> at
> org.apache.cassandra.security.FileBasedSslContextFactory.buildKeyManagerFactory(FileBasedSslContextFactory.java:151)
> at
> org.apache.cassandra.security.AbstractSslContextFactory.createNettySslContext(AbstractSslContextFactory.java:181)
> at
> org.apache.cassandra.security.SSLFactory.createNettySslContext(SSLFactory.java:168)
> at
> org.apache.cassandra.security.SSLFactory.validateSslContext(SSLFactory.java:355)
> ... 7 more
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-71) Allow configuring permissions for uploaded SSTables
[
https://issues.apache.org/jira/browse/CASSANDRASC-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yifan Cai updated CASSANDRASC-71:
-
Reviewers: Yifan Cai
Status: Review In Progress (was: Patch Available)
+1 on the patch!
> Allow configuring permissions for uploaded SSTables
> ---
>
> Key: CASSANDRASC-71
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-71
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Configuration
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
>
> When uploading SSTables, the default permissions are being set. Currently,
> 644 or {{rw---}} are the default permissions. Ideally, a user should be
> able to configure the desired file permissions used during an SSTable upload.
> This allows the Cassandra process to import the SSTable with the permissions
> suitable for the import process.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-72) [CircleCI] Split unit tests and integration tests
[ https://issues.apache.org/jira/browse/CASSANDRASC-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRASC-72: - Reviewers: Yifan Cai Status: Review In Progress (was: Patch Available) Nice! +1 on the patch. > [CircleCI] Split unit tests and integration tests > - > > Key: CASSANDRASC-72 > URL: https://issues.apache.org/jira/browse/CASSANDRASC-72 > Project: Sidecar for Apache Cassandra > Issue Type: Improvement > Components: Configuration >Reporter: Francisco Guerrero >Assignee: Francisco Guerrero >Priority: Normal > > As the number of integration tests continues to grow, it is desirable to > split unit tests and integration tests. It is also desirable to parallelize > integration tests, each integration test should be its own job. The goals of > this improvement are: > * Fail fast on checkstyle or minor errors > * Speed up test runtime by running integration tests in parallel > * Isolate failing tests to specific combinations of Cassandra -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRASC-69) Refactor Configuration
[
https://issues.apache.org/jira/browse/CASSANDRASC-69?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yifan Cai updated CASSANDRASC-69:
-
Reviewers: Yifan Cai
Status: Review In Progress (was: Patch Available)
+1 on the patch. Thank you for addressing my comments!
> Refactor Configuration
> --
>
> Key: CASSANDRASC-69
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-69
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Configuration
>Reporter: Francisco Guerrero
>Assignee: Francisco Guerrero
>Priority: Normal
> Labels: pull-request-available
>
> Currently, the Sidecar Configuration is provided via a yaml file. The yaml
> file is parsed and a the configuration is used during the Sidecar application
> runtime.
> The configuration parsing is done manually, and adding a new configuration to
> the yaml file has become a big task where multiple files need to be touched.
> Ideally, we should add the configuration POJOs needed for new configurations
> and add the new fields in the yaml file.
> Additionally, we are leaking the configuration implementation to the
> {{InstancesConfig}}. We should improve the separation of concerns from the
> yaml configuration and the instances configuration.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-website] branch asf-staging updated (3445b5ef0 -> 4cb9aa982)
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/cassandra-website.git discard 3445b5ef0 generate docs for d7f28f31 new 4cb9aa982 generate docs for d7f28f31 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (3445b5ef0) \ N -- N -- N refs/heads/asf-staging (4cb9aa982) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../managing/tools/nodetool/bootstrap.html | 8 +- .../cassandra/managing/tools/nodetool/import.html | 6 +- .../managing/tools/nodetool/nodetool.html | 10 +-- .../managing/tools/nodetool/repair_admin.html | 87 +++-- .../managing/tools/nodetool/bootstrap.html | 8 +- .../cassandra/managing/tools/nodetool/import.html | 6 +- .../managing/tools/nodetool/nodetool.html | 10 +-- .../managing/tools/nodetool/repair_admin.html | 87 +++-- .../managing/tools/nodetool/bootstrap.html | 8 +- .../cassandra/managing/tools/nodetool/import.html | 6 +- .../managing/tools/nodetool/nodetool.html | 10 +-- .../managing/tools/nodetool/repair_admin.html | 87 +++-- content/search-index.js| 2 +- site-ui/build/ui-bundle.zip| Bin 4881369 -> 4881369 bytes 14 files changed, 169 insertions(+), 166 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18816) Add support for repair coordinator to retry messages that timeout
[ https://issues.apache.org/jira/browse/CASSANDRA-18816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caleb Rackliffe updated CASSANDRA-18816: Reviewers: Caleb Rackliffe Status: Review In Progress (was: Patch Available) > Add support for repair coordinator to retry messages that timeout > - > > Key: CASSANDRA-18816 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18816 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Repair >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 5.x > > > Now that CASSANDRA-15399 is in, most of the repair messages have a state that > they can check against to make message delivery idempotent, allowing the > coordinator to retry such messages; a few of the most critical messages to > retry are: PREPARE_MSG, VALIDATION_REQ, VALIDATION_RSP, SYNC_REQ, and > SYNC_RSP. > With this I propose making the coordinator able to retry these key messages > to try and make repair more resilient to ephemeral issues. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[GitHub] [cassandra-analytics] jberragan closed pull request #11: CASSANDRA-18683: Add PartitionSizeTableProvider for reading the compressed and uncompr…
jberragan closed pull request #11: CASSANDRA-18683: Add PartitionSizeTableProvider for reading the compressed and uncompr… URL: https://github.com/apache/cassandra-analytics/pull/11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[GitHub] [cassandra-analytics] jberragan commented on pull request #11: CASSANDRA-18683: Add PartitionSizeTableProvider for reading the compressed and uncompr…
jberragan commented on PR #11: URL: https://github.com/apache/cassandra-analytics/pull/11#issuecomment-1707284248 Committed: https://github.com/apache/cassandra-analytics/commit/014db08a79f00ef0d94e6855779e398c9dc689c1 Jira: https://issues.apache.org/jira/browse/CASSANDRA-18683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18621) Update Cassandra logos on ASF project logos site
[ https://issues.apache.org/jira/browse/CASSANDRA-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762212#comment-17762212 ] Melissa Logan commented on CASSANDRA-18621: --- Thanks Mick! > Update Cassandra logos on ASF project logos site > > > Key: CASSANDRA-18621 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18621 > Project: Cassandra > Issue Type: Task > Components: Legacy/Documentation and Website >Reporter: Melissa Logan >Assignee: Melissa Logan >Priority: Normal > Fix For: NA > > Attachments: Cassandra_R.zip > > > It appears that the Cassandra logos on the ASF project logos website are > outdated, as they include lowercase letters and no trademark: > https://www.apache.org/logos/#cassandra > The logo currently being used on the website is this one: > https://github.com/apache/cassandra-website/blob/trunk/site-content/source/modules/ROOT/images/logo-white.svg > To ensure proper usage by contributors and third parties, I propose the > creation of the following logo set based on the current website logo: > Version 1 - update and create black and white versions > Version 2- remove > Version 3 - update and create black and white versions > Version 4 - no change > If these already exist somewhere, then please upload them to the ASF project > logos page (requires a committer): https://www.apache.org/logos/about.html > Otherwise I will be asking our designer to create hi-res versions to be > uploaded. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18813) Simplify the bind marker and Term logic
[
https://issues.apache.org/jira/browse/CASSANDRA-18813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-18813:
Reviewers: Andres de la Peña, Ekaterina Dimitrova, Maxwell Guo (was:
Ekaterina Dimitrova)
Status: Review In Progress (was: Patch Available)
> Simplify the bind marker and Term logic
> ---
>
> Key: CASSANDRA-18813
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18813
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
>Reporter: Benjamin Lerer
>Assignee: Benjamin Lerer
>Priority: Normal
> Fix For: 5.x
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The current logic around {{Term}} and {{Terms}} classes is confusing
> specially with {{MultiItemTerminal}} and {{MultiColumnRaw}} that are used to
> handle different use cases that could be handled simply with the {{Term}}
> interface.
> On top of that IN marker add to the confusion because the are represented as
> single Term where in practice they are a set of terms. Representing them as a
> {{Terms}} could simplify the way we handle IN restrictions.
> The goal of this ticket is:
> * to refactor the {{Term}} and {{Terms}} interfaces to simplify the logic
> * Represents IN bind marker as {{Terms}} instead of having 2 different
> representations (a list of terms and a single {{MultiItemTerminal}}.
> * Simplify the {{AbstractMarker}} hierachy
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18473) Storage Attached Indexes (Phase 2)
[ https://issues.apache.org/jira/browse/CASSANDRA-18473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeremy Hanna updated CASSANDRA-18473: - Labels: SAI (was: ) > Storage Attached Indexes (Phase 2) > -- > > Key: CASSANDRA-18473 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18473 > Project: Cassandra > Issue Type: Epic > Components: Feature/2i Index >Reporter: Caleb Rackliffe >Assignee: Caleb Rackliffe >Priority: Normal > Labels: SAI > > At the completion of CASSANDRA-16052, we should be able to release the core > capabilities of SAI in a stable, production-ready package. Once that begins > to gain traction, we'll be able to make improvements and add features for the > next major release. The major initial theme of this epic is likely to be > performance, but it will likely expand to include features like basic text > analysis, etc. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18743) Remove dependency on archived project metrics-reporter-config
[ https://issues.apache.org/jira/browse/CASSANDRA-18743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18743: Status: Changes Suggested (was: Review In Progress) The 5.0 branch will need an update to remove it instead of deprecation. Probably cherry-pick the trunk one. > Remove dependency on archived project metrics-reporter-config > - > > Key: CASSANDRA-18743 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18743 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: Abe Ratnofsky >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 20m > Remaining Estimate: 0h > > metrics-reporter-config has been archived for over 3 years, and has received > no updates in nearly 6 years: > https://github.com/addthis/metrics-reporter-config > metrics-reporter-config processes YAML unsafely: > https://github.com/addthis/metrics-reporter-config/blob/master/reporter-config-base/src/main/java/com/addthis/metrics/reporter/config/AbstractReporterConfig.java#L39C34-L39C45 > This is related to CASSANDRA-18614, which is focused on migrating to safe > YAML processing for the main configuration files. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18743) Remove dependency on archived project metrics-reporter-config
[ https://issues.apache.org/jira/browse/CASSANDRA-18743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762183#comment-17762183 ] Ekaterina Dimitrova commented on CASSANDRA-18743: - There was a consensus to remove it on both 5.0 and trunk. Also, no concerns were raised on the ML list. Corresponding ML threads: [https://lists.apache.org/thread/pdq1y2xks629lh6h7nfc6mt5gp145bs6] https://lists.apache.org/thread/c4m3tc08zhd4d41zs05jcdkr3gjwlhno > Remove dependency on archived project metrics-reporter-config > - > > Key: CASSANDRA-18743 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18743 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: Abe Ratnofsky >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 20m > Remaining Estimate: 0h > > metrics-reporter-config has been archived for over 3 years, and has received > no updates in nearly 6 years: > https://github.com/addthis/metrics-reporter-config > metrics-reporter-config processes YAML unsafely: > https://github.com/addthis/metrics-reporter-config/blob/master/reporter-config-base/src/main/java/com/addthis/metrics/reporter/config/AbstractReporterConfig.java#L39C34-L39C45 > This is related to CASSANDRA-18614, which is focused on migrating to safe > YAML processing for the main configuration files. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18772) Remove dependency on commons-codec
[ https://issues.apache.org/jira/browse/CASSANDRA-18772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18772: Since Version: (was: 4.1.3) > Remove dependency on commons-codec > -- > > Key: CASSANDRA-18772 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18772 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0, 5.1 > > > The dependency doesn't seem to have any direct usage in our codebase. > The only reference to how it might be used was found in CASSANDRA-12790. > Considering we also deprecate in 5.0 and remove metrics-reporter-config as > part of CASSANDRA-18743, I do not see a reason not to remove this one too. > We should probably take the same approach as CASSANDRA-18743 - deprecate in > 5.0 and remove in 5.1. ML thread is to be opened too. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18743) Remove dependency on archived project metrics-reporter-config
[ https://issues.apache.org/jira/browse/CASSANDRA-18743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18743: Reviewers: Ekaterina Dimitrova Status: Review In Progress (was: Patch Available) > Remove dependency on archived project metrics-reporter-config > - > > Key: CASSANDRA-18743 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18743 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: Abe Ratnofsky >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 20m > Remaining Estimate: 0h > > metrics-reporter-config has been archived for over 3 years, and has received > no updates in nearly 6 years: > https://github.com/addthis/metrics-reporter-config > metrics-reporter-config processes YAML unsafely: > https://github.com/addthis/metrics-reporter-config/blob/master/reporter-config-base/src/main/java/com/addthis/metrics/reporter/config/AbstractReporterConfig.java#L39C34-L39C45 > This is related to CASSANDRA-18614, which is focused on migrating to safe > YAML processing for the main configuration files. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18772) Remove dependency on commons-codec
[ https://issues.apache.org/jira/browse/CASSANDRA-18772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18772: Since Version: 4.1.3 Source Control Link: https://github.com/apache/cassandra/commit/9be8369ae65be8eb4848eb9ef58e2909a8d89016 https://github.com/apache/cassandra/commit/f8d5a1aa162706771000eca18dd9f21282dd2be3 Resolution: Fixed Status: Resolved (was: Ready to Commit) > Remove dependency on commons-codec > -- > > Key: CASSANDRA-18772 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18772 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0, 5.1 > > > The dependency doesn't seem to have any direct usage in our codebase. > The only reference to how it might be used was found in CASSANDRA-12790. > Considering we also deprecate in 5.0 and remove metrics-reporter-config as > part of CASSANDRA-18743, I do not see a reason not to remove this one too. > We should probably take the same approach as CASSANDRA-18743 - deprecate in > 5.0 and remove in 5.1. ML thread is to be opened too. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18772) Remove dependency on commons-codec
[ https://issues.apache.org/jira/browse/CASSANDRA-18772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18772: Fix Version/s: 5.0 5.1 (was: 5.x) (was: 5.0.x) > Remove dependency on commons-codec > -- > > Key: CASSANDRA-18772 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18772 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0, 5.1 > > > The dependency doesn't seem to have any direct usage in our codebase. > The only reference to how it might be used was found in CASSANDRA-12790. > Considering we also deprecate in 5.0 and remove metrics-reporter-config as > part of CASSANDRA-18743, I do not see a reason not to remove this one too. > We should probably take the same approach as CASSANDRA-18743 - deprecate in > 5.0 and remove in 5.1. ML thread is to be opened too. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18772) Remove dependency on commons-codec
[ https://issues.apache.org/jira/browse/CASSANDRA-18772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762181#comment-17762181 ] Ekaterina Dimitrova commented on CASSANDRA-18772: - Committed to https://github.com/apache/cassandra.git bf39188cdc..9be8369ae6 cassandra-5.0 -> cassandra-5.0 7ecac39570..f8d5a1aa16 trunk -> trunk > Remove dependency on commons-codec > -- > > Key: CASSANDRA-18772 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18772 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0.x, 5.x > > > The dependency doesn't seem to have any direct usage in our codebase. > The only reference to how it might be used was found in CASSANDRA-12790. > Considering we also deprecate in 5.0 and remove metrics-reporter-config as > part of CASSANDRA-18743, I do not see a reason not to remove this one too. > We should probably take the same approach as CASSANDRA-18743 - deprecate in > 5.0 and remove in 5.1. ML thread is to be opened too. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-5.0 updated (bf39188cdc -> 9be8369ae6)
This is an automated email from the ASF dual-hosted git repository. edimitrova pushed a change to branch cassandra-5.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git from bf39188cdc Ninja fix for CASSANDRA-18606 add 9be8369ae6 Remove commons-codec dependency patch by Ekaterina Dimitrova; reviewed by Brandon Williams (CASSANDRA-18772) No new revisions were added by this update. Summary of changes: .build/cassandra-deps-template.xml | 4 .build/parent-pom-template.xml | 5 - CHANGES.txt| 1 + 3 files changed, 1 insertion(+), 9 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-5.0' into trunk
This is an automated email from the ASF dual-hosted git repository. edimitrova pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit f8d5a1aa162706771000eca18dd9f21282dd2be3 Merge: 7ecac39570 9be8369ae6 Author: Ekaterina Dimitrova AuthorDate: Tue Sep 5 13:58:28 2023 -0400 Merge branch 'cassandra-5.0' into trunk .build/cassandra-deps-template.xml | 4 .build/parent-pom-template.xml | 5 - CHANGES.txt| 1 + 3 files changed, 1 insertion(+), 9 deletions(-) diff --cc CHANGES.txt index 7294d99c8a,953ca7f3dc..26dab609c1 --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -1,6 -1,12 +1,7 @@@ -5.0-alpha2 +5.1 + * Clean up obsolete functions and simplify cql_version handling in cqlsh (CASSANDRA-18787) +Merged from 5.0: + * Remove commons-codec dependency (CASSANDRA-18772) -Merged from 4.1: -Merged from 4.0: -Merged from 3.11: -Merged from 3.0: - * Add cqlshrc.sample and credentials.sample into Debian package (CASSANDRA-18818) - -5.0-alpha1 * Fix rpm installations to work with jdk17 (CASSANDRA-18817) * Fix Depends and Build-Depends for Java for Debian packages (CASSANDRA-18809) * Update command line flags --add-exports and --add-opens for JDK17 (CASSANDRA-18439) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (7ecac39570 -> f8d5a1aa16)
This is an automated email from the ASF dual-hosted git repository. edimitrova pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from 7ecac39570 Merge branch 'cassandra-5.0' into trunk add 9be8369ae6 Remove commons-codec dependency patch by Ekaterina Dimitrova; reviewed by Brandon Williams (CASSANDRA-18772) new f8d5a1aa16 Merge branch 'cassandra-5.0' into trunk The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .build/cassandra-deps-template.xml | 4 .build/parent-pom-template.xml | 5 - CHANGES.txt| 1 + 3 files changed, 1 insertion(+), 9 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18683) Expose per partition on-disk usage through new DataFrame that utilizes the Index.db SSTable file components.
[ https://issues.apache.org/jira/browse/CASSANDRA-18683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRA-18683: -- Fix Version/s: NA Source Control Link: https://github.com/apache/cassandra-analytics/commit/014db08a79f00ef0d94e6855779e398c9dc689c1 Resolution: Fixed Status: Resolved (was: Ready to Commit) Merged into trunk as [014db08|https://github.com/apache/cassandra-analytics/commit/014db08a79f00ef0d94e6855779e398c9dc689c1] > Expose per partition on-disk usage through new DataFrame that utilizes the > Index.db SSTable file components. > > > Key: CASSANDRA-18683 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18683 > Project: Cassandra > Issue Type: New Feature > Components: Analytics Library >Reporter: James Berragan >Assignee: James Berragan >Priority: Normal > Fix For: NA > > Time Spent: 0.5h > Remaining Estimate: 0h > > This addition to Cassandra Analytics provides a new > PartitionSizeTableProvider that generates a DataFrame returning the > compressed and uncompressed partition sizes for all partitions in a table by > utilizing the Index.db SSTable file component. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra-analytics] branch trunk updated: CASSANDRA-18683: Add PartitionSizeTableProvider for reading the compressed and uncompressed sizes of all partitions in a table by utilizing the SSTable Inde
This is an automated email from the ASF dual-hosted git repository.
ycai pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-analytics.git
The following commit(s) were added to refs/heads/trunk by this push:
new 014db08 CASSANDRA-18683: Add PartitionSizeTableProvider for reading
the compressed and uncompressed sizes of all partitions in a table by utilizing
the SSTable Index.db files
014db08 is described below
commit 014db08a79f00ef0d94e6855779e398c9dc689c1
Author: James Berragan
AuthorDate: Wed Jul 19 12:23:07 2023 -0700
CASSANDRA-18683: Add PartitionSizeTableProvider for reading the compressed
and uncompressed sizes of all partitions in a table by utilizing the SSTable
Index.db files
Patch by James Berragan; Reviewed by Dinesh Joshi, Yifan Cai for
CASSANDRA-18683
---
CHANGES.txt| 1 +
cassandra-analytics-core/build.gradle | 11 +
.../cassandra/spark/data/FileSystemSSTable.java| 15 +-
.../spark/data/SidecarProvisionedSSTable.java | 10 +
.../spark/sparksql/SparkCellIterator.java | 48 +--
.../spark/sparksql/LocalPartitionSizeSource.java | 28 +-
.../spark/sparksql/PartitionSizeIterator.java | 93 ++
.../spark/sparksql/PartitionSizeTableProvider.java | 178 +++
.../org/apache/cassandra/spark/TestDataLayer.java | 11 +-
.../java/org/apache/cassandra/spark/TestUtils.java | 48 +++
.../apache/cassandra/spark/PartitionSizeTests.java | 95 ++
.../apache/cassandra/bridge/CassandraBridge.java | 56 ++--
.../apache/cassandra/spark/data/BasicSupplier.java | 0
.../org/apache/cassandra/spark/data/DataLayer.java | 64 +++-
.../org/apache/cassandra/spark/data/SSTable.java | 2 +
.../cassandra/spark/reader/EmptyStreamScanner.java | 2 +-
...{EmptyStreamScanner.java => IndexConsumer.java} | 28 +-
.../apache/cassandra/spark/reader/IndexEntry.java | 71 +
.../cassandra/spark/reader/StreamScanner.java | 29 +-
.../reader/common/AbstractCompressionMetadata.java | 15 +-
.../IIndexReader.java} | 29 +-
.../spark/reader/common/IndexIterator.java | 184
.../org/apache/cassandra/spark/stats/Stats.java| 137 +
.../cassandra/spark/utils/test/TestSSTable.java| 6 +
.../cassandra/spark/utils/test/TestSchema.java | 5 +-
cassandra-four-zero/build.gradle | 5 +
.../bridge/CassandraBridgeImplementation.java | 64 ++--
.../spark/reader/AbstractStreamScanner.java| 2 +-
.../cassandra/spark/reader/CdcScannerBuilder.java | 2 +-
.../spark/reader/CompressionMetadata.java | 4 +-
.../apache/cassandra/spark/reader/IndexReader.java | 324 +
.../apache/cassandra/spark/reader/ReaderUtils.java | 9 +-
.../cassandra/spark/reader/IndexReaderTests.java | 273 +
33 files changed, 1677 insertions(+), 172 deletions(-)
diff --git a/CHANGES.txt b/CHANGES.txt
index 41e2b04..37b126d 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
1.0.0
+ * Expose per partition on-disk usage through new DataFrame that utilizes the
Index.db SSTable file components (CASSANDRA-18683)
* Fix bulk writes with Buffered RowBufferMode (CASSANDRA-18692)
* Minor Refactoring to Improve Code Reusability (CASSANDRA-18684)
* Fix cassandra-analytics-core-example (CASSANDRA-18662)
diff --git a/cassandra-analytics-core/build.gradle
b/cassandra-analytics-core/build.gradle
index 572af8d..e1bd028 100644
--- a/cassandra-analytics-core/build.gradle
+++ b/cassandra-analytics-core/build.gradle
@@ -170,6 +170,17 @@ project(':cassandra-analytics-core') {
finalizedBy(tasks.jacocoTestReport)
}
/* End: JaCoCo check */
+
+configurations {
+testArtifacts
+}
+task testJar(type: Jar) {
+baseName = "${project.name}-test"
+from sourceSets.test.output
+}
+artifacts {
+testArtifacts testJar
+}
}
private void writeBuildVersion(version, projectDir) {
diff --git
a/cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/FileSystemSSTable.java
b/cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/FileSystemSSTable.java
index 512f4c9..c8c4296 100644
---
a/cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/FileSystemSSTable.java
+++
b/cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/FileSystemSSTable.java
@@ -31,8 +31,10 @@ import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.apache.cassandra.spark.stats.Stats;
+import org.apache.cassandra.spark.utils.IOUtils;
import org.apache.cassandra.spark.utils.ThrowableUtils;
import org.apache.cassandra.spark.utils.streaming.SSTableInputStream;
+import org.jetbrains.annotations.Nullable;
class FileSystemSSTable extends SSTable
{
@@ -75,10 +77,21 @@ class FileSystemSSTable extends SSTable
}
}
+
[jira] [Updated] (CASSANDRA-18683) Expose per partition on-disk usage through new DataFrame that utilizes the Index.db SSTable file components.
[ https://issues.apache.org/jira/browse/CASSANDRA-18683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRA-18683: -- Status: Ready to Commit (was: Review In Progress) > Expose per partition on-disk usage through new DataFrame that utilizes the > Index.db SSTable file components. > > > Key: CASSANDRA-18683 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18683 > Project: Cassandra > Issue Type: New Feature > Components: Analytics Library >Reporter: James Berragan >Assignee: James Berragan >Priority: Normal > Time Spent: 0.5h > Remaining Estimate: 0h > > This addition to Cassandra Analytics provides a new > PartitionSizeTableProvider that generates a DataFrame returning the > compressed and uncompressed partition sizes for all partitions in a table by > utilizing the Index.db SSTable file component. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18683) Expose per partition on-disk usage through new DataFrame that utilizes the Index.db SSTable file components.
[ https://issues.apache.org/jira/browse/CASSANDRA-18683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yifan Cai updated CASSANDRA-18683: -- Reviewers: Dinesh Joshi, Yifan Cai (was: Yifan Cai) > Expose per partition on-disk usage through new DataFrame that utilizes the > Index.db SSTable file components. > > > Key: CASSANDRA-18683 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18683 > Project: Cassandra > Issue Type: New Feature > Components: Analytics Library >Reporter: James Berragan >Assignee: James Berragan >Priority: Normal > Time Spent: 0.5h > Remaining Estimate: 0h > > This addition to Cassandra Analytics provides a new > PartitionSizeTableProvider that generates a DataFrame returning the > compressed and uncompressed partition sizes for all partitions in a table by > utilizing the Index.db SSTable file component. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18683) Expose per partition on-disk usage through new DataFrame that utilizes the Index.db SSTable file components.
[ https://issues.apache.org/jira/browse/CASSANDRA-18683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762170#comment-17762170 ] Dinesh Joshi commented on CASSANDRA-18683: -- +1, thanks for the patch. > Expose per partition on-disk usage through new DataFrame that utilizes the > Index.db SSTable file components. > > > Key: CASSANDRA-18683 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18683 > Project: Cassandra > Issue Type: New Feature > Components: Analytics Library >Reporter: James Berragan >Assignee: James Berragan >Priority: Normal > Time Spent: 0.5h > Remaining Estimate: 0h > > This addition to Cassandra Analytics provides a new > PartitionSizeTableProvider that generates a DataFrame returning the > compressed and uncompressed partition sizes for all partitions in a table by > utilizing the Index.db SSTable file component. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18815) Fix dtests: replace_address_test.TestReplaceAddress.test_restart_failed_replace and others
[
https://issues.apache.org/jira/browse/CASSANDRA-18815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-18815:
-
Test and Documentation Plan: run CI
Status: Patch Available (was: Open)
> Fix dtests:
> replace_address_test.TestReplaceAddress.test_restart_failed_replace and others
> --
>
> Key: CASSANDRA-18815
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18815
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Coordination
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
>
> https://ci-cassandra.apache.org/job/Cassandra-5.0/18/testReport/dtest-large.replace_address_test/TestReplaceAddress/test_restart_failed_replace/
> This and other similar tests recently started failing:
> {noformat}
> Unexpected error found in node logs (see stdout for full details). Errors:
> [[replacement] 'ERROR [Stream-Deserializer-/127.0.0.1:7000-91782e47]
> 2023-08-29 23:05:51,677 StreamSession.java:700 - [Stream
> #990152d0-46c0-11ee-9290-158c46e94542] Socket closed before session
> completion, peer 127.0.0.1:7000 is probably
> down.\njava.nio.channels.ClosedChannelException: null\n\tat
> org.apache.cassandra.net.AsyncStreamingInputPlus.reBuffer(AsyncStreamingInputPlus.java:119)\n\tat
>
> org.apache.cassandra.io.util.RebufferingInputStream.readByte(RebufferingInputStream.java:178)\n\tat
>
> org.apache.cassandra.streaming.messages.StreamMessage.deserialize(StreamMessage.java:49)\n\tat
>
> org.apache.cassandra.streaming.StreamDeserializingTask.run(StreamDeserializingTask.java:59)\n\tat
>
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)\n\tat
> java.base/java.lang.Thread.run(Thread.java:833)']
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18734) SAI result retriever is filtering too many rows
[ https://issues.apache.org/jira/browse/CASSANDRA-18734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caleb Rackliffe updated CASSANDRA-18734: Status: Requires Testing (was: Review In Progress) Sounds like we've got 2 +1's and just need a final test run? > SAI result retriever is filtering too many rows > --- > > Key: CASSANDRA-18734 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18734 > Project: Cassandra > Issue Type: Bug > Components: Feature/SAI >Reporter: Mike Adamson >Assignee: Mike Adamson >Priority: Normal > Attachments: flamegraph.svg, image-2023-08-08-13-48-19-701.png, > image-2023-08-08-13-49-19-576.png > > > Performance tests on SAI have shown that the number of rows being filtered > for wide row partitions is more than expected. For a 10k row/partition test - > limit 10, the following has been observed. > !image-2023-08-08-13-49-19-576.png|width=952,height=368! > This is not the expected outcome of row-awareness and needs investigating. > The number of rows read should, roughly, match the number of partitions read. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-5.0' into trunk
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit 7ecac395704fe519bf592438d99768ddfc01d918 Merge: d1a1c439f0 bf39188cdc Author: Stefan Miklosovic AuthorDate: Tue Sep 5 19:01:15 2023 +0200 Merge branch 'cassandra-5.0' into trunk .gitignore| 4 ++-- .../cassandra/pages/managing/configuration/cass_yaml_file.adoc| 0 2 files changed, 2 insertions(+), 2 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (d1a1c439f0 -> 7ecac39570)
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from d1a1c439f0 Merge branch 'cassandra-5.0' into trunk add bf39188cdc Ninja fix for CASSANDRA-18606 new 7ecac39570 Merge branch 'cassandra-5.0' into trunk The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .gitignore| 4 ++-- .../cassandra/pages/managing/configuration/cass_yaml_file.adoc| 0 2 files changed, 2 insertions(+), 2 deletions(-) delete mode 100644 doc/modules/cassandra/pages/managing/configuration/cass_yaml_file.adoc - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-5.0 updated (66bc1daf16 -> bf39188cdc)
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a change to branch cassandra-5.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 66bc1daf16 Merge branch 'cassandra-4.1' into cassandra-5.0 add bf39188cdc Ninja fix for CASSANDRA-18606 No new revisions were added by this update. Summary of changes: .gitignore| 4 ++-- .../cassandra/pages/managing/configuration/cass_yaml_file.adoc| 0 2 files changed, 2 insertions(+), 2 deletions(-) delete mode 100644 doc/modules/cassandra/pages/managing/configuration/cass_yaml_file.adoc - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18772) Remove dependency on commons-codec
[ https://issues.apache.org/jira/browse/CASSANDRA-18772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762148#comment-17762148 ] Ekaterina Dimitrova edited comment on CASSANDRA-18772 at 9/5/23 4:35 PM: - One failed container in trunk CI - restarted the job here - [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2494/workflows/81c934a3-7109-4454-949d-ba981bf4738e/jobs/38828] - finished successfully 5.0: # CASSANDRA-18737 # and one timeout - test_decommission was (Author: e.dimitrova): One failed container in trunk CI - restarted the job here - [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2494/workflows/81c934a3-7109-4454-949d-ba981bf4738e/jobs/38828] 5.0: # CASSANDRA-18737 # and one timeout - test_decommission > Remove dependency on commons-codec > -- > > Key: CASSANDRA-18772 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18772 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0.x, 5.x > > > The dependency doesn't seem to have any direct usage in our codebase. > The only reference to how it might be used was found in CASSANDRA-12790. > Considering we also deprecate in 5.0 and remove metrics-reporter-config as > part of CASSANDRA-18743, I do not see a reason not to remove this one too. > We should probably take the same approach as CASSANDRA-18743 - deprecate in > 5.0 and remove in 5.1. ML thread is to be opened too. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18815) Fix dtests: replace_address_test.TestReplaceAddress.test_restart_failed_replace and others
[
https://issues.apache.org/jira/browse/CASSANDRA-18815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762157#comment-17762157
]
Brandon Williams edited comment on CASSANDRA-18815 at 9/5/23 4:19 PM:
--
bq. If the test is causing the log error, then adding a suppression for it
seems like the way to go.
That is [simple
enough|https://github.com/driftx/cassandra-dtest/commit/f9396d5c6804d7f8d59b7e174fdf37ca6f6ed4cf],
and I think a single dtest-large run will suffice:
||Branch||CI||
|[5.0|https://github.com/driftx/cassandra/tree/CASSANDRA-18815-5.0]|[dtests-large|https://app.circleci.com/pipelines/github/driftx/cassandra/1259/workflows/dca68d84-4cf8-40fe-a660-30feca8edfa3/jobs/50195]|
was (Author: brandon.williams):
bq. If the test is causing the log error, then adding a suppression for it
seems like the way to go.
That is simple enough, and I think a single dtest-large run will suffice:
||Branch||CI||
|[5.0|https://github.com/driftx/cassandra/tree/CASSANDRA-18815-5.0]|[dtests-large|https://app.circleci.com/pipelines/github/driftx/cassandra/1259/workflows/dca68d84-4cf8-40fe-a660-30feca8edfa3/jobs/50195]|
> Fix dtests:
> replace_address_test.TestReplaceAddress.test_restart_failed_replace and others
> --
>
> Key: CASSANDRA-18815
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18815
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Coordination
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
>
> https://ci-cassandra.apache.org/job/Cassandra-5.0/18/testReport/dtest-large.replace_address_test/TestReplaceAddress/test_restart_failed_replace/
> This and other similar tests recently started failing:
> {noformat}
> Unexpected error found in node logs (see stdout for full details). Errors:
> [[replacement] 'ERROR [Stream-Deserializer-/127.0.0.1:7000-91782e47]
> 2023-08-29 23:05:51,677 StreamSession.java:700 - [Stream
> #990152d0-46c0-11ee-9290-158c46e94542] Socket closed before session
> completion, peer 127.0.0.1:7000 is probably
> down.\njava.nio.channels.ClosedChannelException: null\n\tat
> org.apache.cassandra.net.AsyncStreamingInputPlus.reBuffer(AsyncStreamingInputPlus.java:119)\n\tat
>
> org.apache.cassandra.io.util.RebufferingInputStream.readByte(RebufferingInputStream.java:178)\n\tat
>
> org.apache.cassandra.streaming.messages.StreamMessage.deserialize(StreamMessage.java:49)\n\tat
>
> org.apache.cassandra.streaming.StreamDeserializingTask.run(StreamDeserializingTask.java:59)\n\tat
>
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)\n\tat
> java.base/java.lang.Thread.run(Thread.java:833)']
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18815) Fix dtests: replace_address_test.TestReplaceAddress.test_restart_failed_replace and others
[
https://issues.apache.org/jira/browse/CASSANDRA-18815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762157#comment-17762157
]
Brandon Williams commented on CASSANDRA-18815:
--
bq. If the test is causing the log error, then adding a suppression for it
seems like the way to go.
That is simple enough, and I think a single dtest-large run will suffice:
||Branch||CI||
|[5.0|https://github.com/driftx/cassandra/tree/CASSANDRA-18815-5.0]|[dtests-large|https://app.circleci.com/pipelines/github/driftx/cassandra/1259/workflows/dca68d84-4cf8-40fe-a660-30feca8edfa3/jobs/50195]|
> Fix dtests:
> replace_address_test.TestReplaceAddress.test_restart_failed_replace and others
> --
>
> Key: CASSANDRA-18815
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18815
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Coordination
>Reporter: Brandon Williams
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
>
> https://ci-cassandra.apache.org/job/Cassandra-5.0/18/testReport/dtest-large.replace_address_test/TestReplaceAddress/test_restart_failed_replace/
> This and other similar tests recently started failing:
> {noformat}
> Unexpected error found in node logs (see stdout for full details). Errors:
> [[replacement] 'ERROR [Stream-Deserializer-/127.0.0.1:7000-91782e47]
> 2023-08-29 23:05:51,677 StreamSession.java:700 - [Stream
> #990152d0-46c0-11ee-9290-158c46e94542] Socket closed before session
> completion, peer 127.0.0.1:7000 is probably
> down.\njava.nio.channels.ClosedChannelException: null\n\tat
> org.apache.cassandra.net.AsyncStreamingInputPlus.reBuffer(AsyncStreamingInputPlus.java:119)\n\tat
>
> org.apache.cassandra.io.util.RebufferingInputStream.readByte(RebufferingInputStream.java:178)\n\tat
>
> org.apache.cassandra.streaming.messages.StreamMessage.deserialize(StreamMessage.java:49)\n\tat
>
> org.apache.cassandra.streaming.StreamDeserializingTask.run(StreamDeserializingTask.java:59)\n\tat
>
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)\n\tat
> java.base/java.lang.Thread.run(Thread.java:833)']
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18772) Remove dependency on commons-codec
[ https://issues.apache.org/jira/browse/CASSANDRA-18772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762148#comment-17762148 ] Ekaterina Dimitrova edited comment on CASSANDRA-18772 at 9/5/23 3:49 PM: - One failed container in trunk CI - restarted the job here - [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2494/workflows/81c934a3-7109-4454-949d-ba981bf4738e/jobs/38828] 5.0: # CASSANDRA-18737 # and one timeout - test_decommission was (Author: e.dimitrova): One failed container in trunk CI - restarted the job here - [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2494/workflows/81c934a3-7109-4454-949d-ba981bf4738e/jobs/38828] 5.0: # CASSANDRA-18737 # and one timeout > Remove dependency on commons-codec > -- > > Key: CASSANDRA-18772 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18772 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0.x, 5.x > > > The dependency doesn't seem to have any direct usage in our codebase. > The only reference to how it might be used was found in CASSANDRA-12790. > Considering we also deprecate in 5.0 and remove metrics-reporter-config as > part of CASSANDRA-18743, I do not see a reason not to remove this one too. > We should probably take the same approach as CASSANDRA-18743 - deprecate in > 5.0 and remove in 5.1. ML thread is to be opened too. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18772) Remove dependency on commons-codec
[ https://issues.apache.org/jira/browse/CASSANDRA-18772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762148#comment-17762148 ] Ekaterina Dimitrova commented on CASSANDRA-18772: - One failed container in trunk CI - restarted the job here - [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2494/workflows/81c934a3-7109-4454-949d-ba981bf4738e/jobs/38828] 5.0: # CASSANDRA-18737 # and one timeout > Remove dependency on commons-codec > -- > > Key: CASSANDRA-18772 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18772 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0.x, 5.x > > > The dependency doesn't seem to have any direct usage in our codebase. > The only reference to how it might be used was found in CASSANDRA-12790. > Considering we also deprecate in 5.0 and remove metrics-reporter-config as > part of CASSANDRA-18743, I do not see a reason not to remove this one too. > We should probably take the same approach as CASSANDRA-18743 - deprecate in > 5.0 and remove in 5.1. ML thread is to be opened too. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.0 updated (6c7ed52bb2 -> 65ee0d082c)
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a change to branch cassandra-3.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 6c7ed52bb2 Add cqlshrc.sample and credentials.sample into Debian package add 65ee0d082c Ninja fix for CASSANDRA-18745 No new revisions were added by this update. Summary of changes: bin/cqlsh.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.1 updated (c6f74d231f -> 57e10b64b2)
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a change to branch cassandra-4.1 in repository https://gitbox.apache.org/repos/asf/cassandra.git from c6f74d231f Merge branch 'cassandra-4.0' into cassandra-4.1 add 65ee0d082c Ninja fix for CASSANDRA-18745 add caad2f24f9 Merge branch 'cassandra-3.0' into cassandra-3.11 add 1f79c84925 Merge branch 'cassandra-3.11' into cassandra-4.0 add 57e10b64b2 Merge branch 'cassandra-4.0' into cassandra-4.1 No new revisions were added by this update. Summary of changes: bin/cqlsh.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-5.0 updated (a503ae4013 -> 66bc1daf16)
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a change to branch cassandra-5.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git from a503ae4013 Merge branch 'cassandra-4.1' into cassandra-5.0 add 65ee0d082c Ninja fix for CASSANDRA-18745 add caad2f24f9 Merge branch 'cassandra-3.0' into cassandra-3.11 add 1f79c84925 Merge branch 'cassandra-3.11' into cassandra-4.0 add 57e10b64b2 Merge branch 'cassandra-4.0' into cassandra-4.1 add 66bc1daf16 Merge branch 'cassandra-4.1' into cassandra-5.0 No new revisions were added by this update. Summary of changes: pylib/cqlshlib/cqlshmain.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.11 updated (50dae280d8 -> caad2f24f9)
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a change to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 50dae280d8 Merge branch 'cassandra-3.0' into cassandra-3.11 add 65ee0d082c Ninja fix for CASSANDRA-18745 add caad2f24f9 Merge branch 'cassandra-3.0' into cassandra-3.11 No new revisions were added by this update. Summary of changes: bin/cqlsh.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0 updated (8e34d1306b -> 1f79c84925)
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a change to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 8e34d1306b Merge branch 'cassandra-3.11' into cassandra-4.0 add 65ee0d082c Ninja fix for CASSANDRA-18745 add caad2f24f9 Merge branch 'cassandra-3.0' into cassandra-3.11 add 1f79c84925 Merge branch 'cassandra-3.11' into cassandra-4.0 No new revisions were added by this update. Summary of changes: bin/cqlsh.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (df94834b19 -> d1a1c439f0)
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from df94834b19 Merge branch 'cassandra-5.0' into trunk add 65ee0d082c Ninja fix for CASSANDRA-18745 add caad2f24f9 Merge branch 'cassandra-3.0' into cassandra-3.11 add 1f79c84925 Merge branch 'cassandra-3.11' into cassandra-4.0 add 57e10b64b2 Merge branch 'cassandra-4.0' into cassandra-4.1 add 66bc1daf16 Merge branch 'cassandra-4.1' into cassandra-5.0 new d1a1c439f0 Merge branch 'cassandra-5.0' into trunk The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: pylib/cqlshlib/cqlshmain.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-5.0' into trunk
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit d1a1c439f08db9f7160d711652537a89ae68e219 Merge: df94834b19 66bc1daf16 Author: Stefan Miklosovic AuthorDate: Tue Sep 5 16:59:28 2023 +0200 Merge branch 'cassandra-5.0' into trunk pylib/cqlshlib/cqlshmain.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18772) Remove dependency on commons-codec
[ https://issues.apache.org/jira/browse/CASSANDRA-18772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762112#comment-17762112 ] Ekaterina Dimitrova edited comment on CASSANDRA-18772 at 9/5/23 3:00 PM: - 5.0 branch: [https://github.com/ekaterinadimitrova2/cassandra/tree/18772-5.0]; CI: [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2493/workflows/f8b3fc1a-4640-4eac-8487-fda42f7e4311|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2493/workflows/59762ffe-b907-42f3-b6c1-558041f737c0] trunk branch: [https://github.com/ekaterinadimitrova2/cassandra/tree/18772-trunk]; CI: [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2494/workflows/81c934a3-7109-4454-949d-ba981bf4738e] I started only JDK11 tests, this change doesn't require both JDKs. Either something explodes from the removal or not. was (Author: e.dimitrova): 5.0 branch: https://github.com/ekaterinadimitrova2/cassandra/tree/18772-5.0; CI: https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2493/workflows/f8b3fc1a-4640-4eac-8487-fda42f7e4311 trunk branch: https://github.com/ekaterinadimitrova2/cassandra/tree/18772-trunk; CI: [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2494/workflows/81c934a3-7109-4454-949d-ba981bf4738e] I started only JDK11 tests, this change doesn't require both JDKs. Either something explodes from the removal or not. > Remove dependency on commons-codec > -- > > Key: CASSANDRA-18772 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18772 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0.x, 5.x > > > The dependency doesn't seem to have any direct usage in our codebase. > The only reference to how it might be used was found in CASSANDRA-12790. > Considering we also deprecate in 5.0 and remove metrics-reporter-config as > part of CASSANDRA-18743, I do not see a reason not to remove this one too. > We should probably take the same approach as CASSANDRA-18743 - deprecate in > 5.0 and remove in 5.1. ML thread is to be opened too. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18737) Test failure: org.apache.cassandra.io.sstable.SSTableLoaderTest (testLoadingIncompleteSSTable-.jdk17)
[
https://issues.apache.org/jira/browse/CASSANDRA-18737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762125#comment-17762125
]
Ekaterina Dimitrova commented on CASSANDRA-18737:
-
Seen again today:
https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2493/workflows/59762ffe-b907-42f3-b6c1-558041f737c0/jobs/38779/tests
> Test failure: org.apache.cassandra.io.sstable.SSTableLoaderTest
> (testLoadingIncompleteSSTable-.jdk17)
> -
>
> Key: CASSANDRA-18737
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18737
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/bulk load
>Reporter: Brandon Williams
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {noformat}
> java.lang.RuntimeException: Failed to list files in
> /tmp/1409486429862512729/SSTableLoaderTest/Standard2-57877ac036d311eea01f83fcb8f6fee5
> at
> org.apache.cassandra.db.lifecycle.LogAwareFileLister.list(LogAwareFileLister.java:77)
> at
> org.apache.cassandra.db.lifecycle.LifecycleTransaction.getFiles(LifecycleTransaction.java:626)
> at
> org.apache.cassandra.io.sstable.SSTableLoader.openSSTables(SSTableLoader.java:103)
> at
> org.apache.cassandra.io.sstable.SSTableLoader.stream(SSTableLoader.java:202)
> at
> org.apache.cassandra.io.sstable.SSTableLoaderTest.testLoadingIncompleteSSTable(SSTableLoaderTest.java:213)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> Caused by: org.apache.cassandra.io.sstable.CorruptSSTableException:
> Corrupted:
> /tmp/1409486429862512729/SSTableLoaderTest/Standard2-57877ac036d311eea01f83fcb8f6fee5/nc-17-big
> at
> org.apache.cassandra.io.sstable.format.SSTableReaderLoadingBuilder.build(SSTableReaderLoadingBuilder.java:111)
> at
> org.apache.cassandra.io.sstable.format.SSTableReader.open(SSTableReader.java:397)
> at
> org.apache.cassandra.io.sstable.format.SSTableReader.openForBatch(SSTableReader.java:373)
> at
> org.apache.cassandra.io.sstable.SSTableLoader.lambda$openSSTables$0(SSTableLoader.java:152)
> at
> org.apache.cassandra.db.lifecycle.LogAwareFileLister.lambda$innerList$2(LogAwareFileLister.java:99)
> at
> java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:178)
> at
> java.base/java.util.TreeMap$EntrySpliterator.forEachRemaining(TreeMap.java:3287)
> at
> java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
> at
> java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
> at
> java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
> at
> java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
> at
> java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682)
> at
> org.apache.cassandra.db.lifecycle.LogAwareFileLister.innerList(LogAwareFileLister.java:101)
> at
> org.apache.cassandra.db.lifecycle.LogAwareFileLister.list(LogAwareFileLister.java:73)
> Caused by: java.lang.NullPointerException
> at
> com.google.common.base.Preconditions.checkNotNull(Preconditions.java:903)
> at
> org.apache.cassandra.io.sstable.format.big.BigSSTableReaderLoadingBuilder.buildSummaryAndBloomFilter(BigSSTableReaderLoadingBuilder.java:193)
> at
> org.apache.cassandra.io.sstable.format.big.BigSSTableReaderLoadingBuilder.openComponents(BigSSTableReaderLoadingBuilder.java:116)
> at
> org.apache.cassandra.io.sstable.format.big.BigSSTableReaderLoadingBuilder.openComponents(BigSSTableReaderLoadingBuilder.java:58)
> at
> org.apache.cassandra.io.sstable.format.SSTableReaderLoadingBuilder.build(SSTableReaderLoadingBuilder.java:92)
> {noformat}
> Seen here:
> https://app.circleci.com/pipelines/github/driftx/cassandra/1174/workflows/263f1e22-e4d0-48b8-b3e2-496edb30a068/jobs/41924/tests
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18737) Test failure: org.apache.cassandra.io.sstable.SSTableLoaderTest (testLoadingIncompleteSSTable-.jdk17)
[
https://issues.apache.org/jira/browse/CASSANDRA-18737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-18737:
Fix Version/s: 5.0.x
> Test failure: org.apache.cassandra.io.sstable.SSTableLoaderTest
> (testLoadingIncompleteSSTable-.jdk17)
> -
>
> Key: CASSANDRA-18737
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18737
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/bulk load
>Reporter: Brandon Williams
>Priority: Normal
> Fix For: 5.0.x, 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {noformat}
> java.lang.RuntimeException: Failed to list files in
> /tmp/1409486429862512729/SSTableLoaderTest/Standard2-57877ac036d311eea01f83fcb8f6fee5
> at
> org.apache.cassandra.db.lifecycle.LogAwareFileLister.list(LogAwareFileLister.java:77)
> at
> org.apache.cassandra.db.lifecycle.LifecycleTransaction.getFiles(LifecycleTransaction.java:626)
> at
> org.apache.cassandra.io.sstable.SSTableLoader.openSSTables(SSTableLoader.java:103)
> at
> org.apache.cassandra.io.sstable.SSTableLoader.stream(SSTableLoader.java:202)
> at
> org.apache.cassandra.io.sstable.SSTableLoaderTest.testLoadingIncompleteSSTable(SSTableLoaderTest.java:213)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> Caused by: org.apache.cassandra.io.sstable.CorruptSSTableException:
> Corrupted:
> /tmp/1409486429862512729/SSTableLoaderTest/Standard2-57877ac036d311eea01f83fcb8f6fee5/nc-17-big
> at
> org.apache.cassandra.io.sstable.format.SSTableReaderLoadingBuilder.build(SSTableReaderLoadingBuilder.java:111)
> at
> org.apache.cassandra.io.sstable.format.SSTableReader.open(SSTableReader.java:397)
> at
> org.apache.cassandra.io.sstable.format.SSTableReader.openForBatch(SSTableReader.java:373)
> at
> org.apache.cassandra.io.sstable.SSTableLoader.lambda$openSSTables$0(SSTableLoader.java:152)
> at
> org.apache.cassandra.db.lifecycle.LogAwareFileLister.lambda$innerList$2(LogAwareFileLister.java:99)
> at
> java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:178)
> at
> java.base/java.util.TreeMap$EntrySpliterator.forEachRemaining(TreeMap.java:3287)
> at
> java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
> at
> java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
> at
> java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
> at
> java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
> at
> java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682)
> at
> org.apache.cassandra.db.lifecycle.LogAwareFileLister.innerList(LogAwareFileLister.java:101)
> at
> org.apache.cassandra.db.lifecycle.LogAwareFileLister.list(LogAwareFileLister.java:73)
> Caused by: java.lang.NullPointerException
> at
> com.google.common.base.Preconditions.checkNotNull(Preconditions.java:903)
> at
> org.apache.cassandra.io.sstable.format.big.BigSSTableReaderLoadingBuilder.buildSummaryAndBloomFilter(BigSSTableReaderLoadingBuilder.java:193)
> at
> org.apache.cassandra.io.sstable.format.big.BigSSTableReaderLoadingBuilder.openComponents(BigSSTableReaderLoadingBuilder.java:116)
> at
> org.apache.cassandra.io.sstable.format.big.BigSSTableReaderLoadingBuilder.openComponents(BigSSTableReaderLoadingBuilder.java:58)
> at
> org.apache.cassandra.io.sstable.format.SSTableReaderLoadingBuilder.build(SSTableReaderLoadingBuilder.java:92)
> {noformat}
> Seen here:
> https://app.circleci.com/pipelines/github/driftx/cassandra/1174/workflows/263f1e22-e4d0-48b8-b3e2-496edb30a068/jobs/41924/tests
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18822) Blog entry for 2023 User Survey
[ https://issues.apache.org/jira/browse/CASSANDRA-18822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ekaterina Dimitrova updated CASSANDRA-18822: Change Category: Semantic Complexity: Normal Status: Open (was: Triage Needed) > Blog entry for 2023 User Survey > --- > > Key: CASSANDRA-18822 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18822 > Project: Cassandra > Issue Type: Task > Components: Legacy/Documentation and Website >Reporter: Patrick McFadin >Assignee: Patrick McFadin >Priority: Normal > > The user survey results were published as a google doc but would like to > formalize this into a blog post with results for people to see from the web > site. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18772) Remove dependency on commons-codec
[ https://issues.apache.org/jira/browse/CASSANDRA-18772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762112#comment-17762112 ] Ekaterina Dimitrova commented on CASSANDRA-18772: - 5.0 branch: https://github.com/ekaterinadimitrova2/cassandra/tree/18772-5.0; CI: https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2493/workflows/f8b3fc1a-4640-4eac-8487-fda42f7e4311 trunk branch: https://github.com/ekaterinadimitrova2/cassandra/tree/18772-trunk; CI: [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2494/workflows/81c934a3-7109-4454-949d-ba981bf4738e] I started only JDK11 tests, this change doesn't require both JDKs. Either something explodes from the removal or not. > Remove dependency on commons-codec > -- > > Key: CASSANDRA-18772 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18772 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0.x, 5.x > > > The dependency doesn't seem to have any direct usage in our codebase. > The only reference to how it might be used was found in CASSANDRA-12790. > Considering we also deprecate in 5.0 and remove metrics-reporter-config as > part of CASSANDRA-18743, I do not see a reason not to remove this one too. > We should probably take the same approach as CASSANDRA-18743 - deprecate in > 5.0 and remove in 5.1. ML thread is to be opened too. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18821) org.apache.cassandra.distributed.test.guardrails.GuardrailDiskUsageTest failed with Authentication error on host /127.0.0.1:9042: Provided username cassandra and/o
[ https://issues.apache.org/jira/browse/CASSANDRA-18821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762104#comment-17762104 ] Jeremiah Jordan commented on CASSANDRA-18821: - Yes. There appear to be many tests which do that already. For example: [https://github.com/apache/cassandra/blob/trunk/test/distributed/org/apache/cassandra/distributed/test/UpdateSystemAuthAfterDCExpansionTest.java#L118] I wonder if dtests should just always set the delay to 0. > org.apache.cassandra.distributed.test.guardrails.GuardrailDiskUsageTest > failed with Authentication error on host /127.0.0.1:9042: Provided username > cassandra and/or password are incorrect > --- > > Key: CASSANDRA-18821 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18821 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/java >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18772) Remove dependency on commons-codec
[ https://issues.apache.org/jira/browse/CASSANDRA-18772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762100#comment-17762100 ] Ekaterina Dimitrova commented on CASSANDRA-18772: - One week with no concerns raised, I take that as a lazy consensus. > Remove dependency on commons-codec > -- > > Key: CASSANDRA-18772 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18772 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0.x, 5.x > > > The dependency doesn't seem to have any direct usage in our codebase. > The only reference to how it might be used was found in CASSANDRA-12790. > Considering we also deprecate in 5.0 and remove metrics-reporter-config as > part of CASSANDRA-18743, I do not see a reason not to remove this one too. > We should probably take the same approach as CASSANDRA-18743 - deprecate in > 5.0 and remove in 5.1. ML thread is to be opened too. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18822) Blog entry for 2023 User Survey
Patrick McFadin created CASSANDRA-18822: --- Summary: Blog entry for 2023 User Survey Key: CASSANDRA-18822 URL: https://issues.apache.org/jira/browse/CASSANDRA-18822 Project: Cassandra Issue Type: Task Components: Legacy/Documentation and Website Reporter: Patrick McFadin Assignee: Patrick McFadin The user survey results were published as a google doc but would like to formalize this into a blog post with results for people to see from the web site. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18818) Add cqlshrc.sample and credentials.sample into Debian package
[ https://issues.apache.org/jira/browse/CASSANDRA-18818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Miklosovic updated CASSANDRA-18818: -- Fix Version/s: 3.0.30 3.11.17 4.0.12 4.1.4 5.0 (was: 3.0.x) (was: 3.11.x) (was: 5.x) (was: 4.0.x) (was: 4.1.x) Source Control Link: https://github.com/apache/cassandra/commit/6c7ed52bb2d3bd22407ec70561f04cb6a9bea5cc Resolution: Fixed Status: Resolved (was: Ready to Commit) > Add cqlshrc.sample and credentials.sample into Debian package > - > > Key: CASSANDRA-18818 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18818 > Project: Cassandra > Issue Type: Task > Components: Packaging >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 3.0.30, 3.11.17, 4.0.12, 4.1.4, 5.0 > > > RPM package contains these two files buy DEB does not. Debian users suffer > from not having these files available so they need to craft them completely > from scratch. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.0 updated (ce49e775f7 -> 6c7ed52bb2)
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a change to branch cassandra-3.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git from ce49e775f7 Missing license info and headers add 6c7ed52bb2 Add cqlshrc.sample and credentials.sample into Debian package No new revisions were added by this update. Summary of changes: CHANGES.txt | 1 + debian/cassandra.install | 1 + 2 files changed, 2 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-3.11 updated (14e89fc3c7 -> 50dae280d8)
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a change to branch cassandra-3.11 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 14e89fc3c7 Merge branch 'cassandra-3.0' into cassandra-3.11 add 6c7ed52bb2 Add cqlshrc.sample and credentials.sample into Debian package add 50dae280d8 Merge branch 'cassandra-3.0' into cassandra-3.11 No new revisions were added by this update. Summary of changes: CHANGES.txt | 1 + debian/cassandra.install | 1 + 2 files changed, 2 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.0 updated (0b7310c010 -> 8e34d1306b)
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a change to branch cassandra-4.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 0b7310c010 Fix FailingRepairTest by making sure Gossip is started before each test add 6c7ed52bb2 Add cqlshrc.sample and credentials.sample into Debian package add 50dae280d8 Merge branch 'cassandra-3.0' into cassandra-3.11 add 8e34d1306b Merge branch 'cassandra-3.11' into cassandra-4.0 No new revisions were added by this update. Summary of changes: CHANGES.txt | 1 + debian/cassandra.install | 1 + 2 files changed, 2 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-4.1 updated (fcef3a2558 -> c6f74d231f)
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a change to branch cassandra-4.1 in repository https://gitbox.apache.org/repos/asf/cassandra.git from fcef3a2558 Merge branch 'cassandra-4.0' into cassandra-4.1 add 6c7ed52bb2 Add cqlshrc.sample and credentials.sample into Debian package add 50dae280d8 Merge branch 'cassandra-3.0' into cassandra-3.11 add 8e34d1306b Merge branch 'cassandra-3.11' into cassandra-4.0 add c6f74d231f Merge branch 'cassandra-4.0' into cassandra-4.1 No new revisions were added by this update. Summary of changes: CHANGES.txt | 1 + debian/cassandra.install | 2 ++ 2 files changed, 3 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch cassandra-5.0 updated (17d0eb138c -> a503ae4013)
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a change to branch cassandra-5.0 in repository https://gitbox.apache.org/repos/asf/cassandra.git from 17d0eb138c Fix rpm installation on jdk17 add 6c7ed52bb2 Add cqlshrc.sample and credentials.sample into Debian package add 50dae280d8 Merge branch 'cassandra-3.0' into cassandra-3.11 add 8e34d1306b Merge branch 'cassandra-3.11' into cassandra-4.0 add c6f74d231f Merge branch 'cassandra-4.0' into cassandra-4.1 add a503ae4013 Merge branch 'cassandra-4.1' into cassandra-5.0 No new revisions were added by this update. Summary of changes: CHANGES.txt | 1 + debian/cassandra.install | 2 ++ 2 files changed, 3 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] branch trunk updated (b966f6af11 -> df94834b19)
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a change to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git from b966f6af11 Merge branch 'cassandra-5.0' into trunk add 6c7ed52bb2 Add cqlshrc.sample and credentials.sample into Debian package add 50dae280d8 Merge branch 'cassandra-3.0' into cassandra-3.11 add 8e34d1306b Merge branch 'cassandra-3.11' into cassandra-4.0 add c6f74d231f Merge branch 'cassandra-4.0' into cassandra-4.1 add a503ae4013 Merge branch 'cassandra-4.1' into cassandra-5.0 new df94834b19 Merge branch 'cassandra-5.0' into trunk The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: CHANGES.txt | 1 + debian/cassandra.install | 2 ++ 2 files changed, 3 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[cassandra] 01/01: Merge branch 'cassandra-5.0' into trunk
This is an automated email from the ASF dual-hosted git repository. smiklosovic pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/cassandra.git commit df94834b1948727f282e8867a474ff4b51b5d9db Merge: b966f6af11 a503ae4013 Author: Stefan Miklosovic AuthorDate: Tue Sep 5 15:46:33 2023 +0200 Merge branch 'cassandra-5.0' into trunk CHANGES.txt | 1 + debian/cassandra.install | 2 ++ 2 files changed, 3 insertions(+) diff --cc CHANGES.txt index ade047d007,d6659399ac..7294d99c8a --- a/CHANGES.txt +++ b/CHANGES.txt @@@ -14,22 -19,6 +14,23 @@@ Merged from 5.0 * Remove commitlog_sync_batch_window_in_ms (CASSANDRA-17161) * Upgrade JMH from 1.21 to 1.36 (CASSANDRA-18696) * Add guardrail for vector dimensions (CASSANDRA-18730) +Merged from 4.1: + * Waiting indefinitely on ReceivedMessage response in StreamSession#receive() can cause deadlock (CASSANDRA-18733) + * Allow empty keystore_password in encryption_options (CASSANDRA-18778) +Merged from 4.0: +Merged from 3.11: + * Fix NPE when using udfContext in UDF after a restart of a node (CASSANDRA-18739) +Merged from 3.0: ++ * Add cqlshrc.sample and credentials.sample into Debian package (CASSANDRA-18818) + * Refactor validation logic in StorageService.rebuild (CASSANDRA-18803) + * Make alternation of a user type validate the same way as creation of a user type does (CASSANDRA-18585) + * Fix missing speculative retries in tablestats (CASSANDRA-18767) + * Fix Requires for Java for RPM package (CASSANDRA-18751) + * Fix CQLSH online help topic link (CASSANDRA-17534) + * Remove unused suppressions (CASSANDRA-18724) + + +5.0 * Upgraded Netty to 4.1.96, added BouncyCastle dependency (CASSANDRA-17992) * Fix for (unsupported) big endian unaligned architecture, eg s390x (CASSANDRA-17723) * CIDR filtering authorizer (CASSANDRA-18592) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18821) org.apache.cassandra.distributed.test.guardrails.GuardrailDiskUsageTest failed with Authentication error on host /127.0.0.1:9042: Provided username cassandra and/o
[
https://issues.apache.org/jira/browse/CASSANDRA-18821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762092#comment-17762092
]
Jacek Lewandowski commented on CASSANDRA-18821:
---
The problem in this test (and perhaps other flaky test which fail in the same
way) is that creating the superuser may happen too late, actually after we try
to connect to the cluster with the driver. In this case, we end up with
exceptions like that.
I managed to reproduce this problem by increasing
{{cassandra.superuser_setup_delay_ms}} to 30 seconds.
My plan to fix this is to make the tests wait at most
{{cassandra.superuser_setup_delay_ms}}, asserting the existence of the
superuser (for the distributed tests), and reducing that delay to 0 for the
unit tests.
> org.apache.cassandra.distributed.test.guardrails.GuardrailDiskUsageTest
> failed with Authentication error on host /127.0.0.1:9042: Provided username
> cassandra and/or password are incorrect
> ---
>
> Key: CASSANDRA-18821
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18821
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/java
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Normal
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18821) org.apache.cassandra.distributed.test.guardrails.GuardrailDiskUsageTest failed with Authentication error on host /127.0.0.1:9042: Provided username cassandra and/or
Jacek Lewandowski created CASSANDRA-18821: - Summary: org.apache.cassandra.distributed.test.guardrails.GuardrailDiskUsageTest failed with Authentication error on host /127.0.0.1:9042: Provided username cassandra and/or password are incorrect Key: CASSANDRA-18821 URL: https://issues.apache.org/jira/browse/CASSANDRA-18821 Project: Cassandra Issue Type: Bug Components: Test/dtest/java Reporter: Jacek Lewandowski -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18821) org.apache.cassandra.distributed.test.guardrails.GuardrailDiskUsageTest failed with Authentication error on host /127.0.0.1:9042: Provided username cassandra and/or
[ https://issues.apache.org/jira/browse/CASSANDRA-18821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacek Lewandowski updated CASSANDRA-18821: -- Bug Category: Parent values: Correctness(12982)Level 1 values: Test Failure(12990) Complexity: Low Hanging Fruit Discovered By: Unit Test Severity: Low Status: Open (was: Triage Needed) > org.apache.cassandra.distributed.test.guardrails.GuardrailDiskUsageTest > failed with Authentication error on host /127.0.0.1:9042: Provided username > cassandra and/or password are incorrect > --- > > Key: CASSANDRA-18821 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18821 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/java >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-18821) org.apache.cassandra.distributed.test.guardrails.GuardrailDiskUsageTest failed with Authentication error on host /127.0.0.1:9042: Provided username cassandra and/or
[ https://issues.apache.org/jira/browse/CASSANDRA-18821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacek Lewandowski reassigned CASSANDRA-18821: - Assignee: Jacek Lewandowski > org.apache.cassandra.distributed.test.guardrails.GuardrailDiskUsageTest > failed with Authentication error on host /127.0.0.1:9042: Provided username > cassandra and/or password are incorrect > --- > > Key: CASSANDRA-18821 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18821 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/java >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18820) Source location is lost when an exception is thrown from the coordinator in in-jvm dtests
[
https://issues.apache.org/jira/browse/CASSANDRA-18820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762053#comment-17762053
]
Jacek Lewandowski commented on CASSANDRA-18820:
---
https://github.com/apache/cassandra/pull/2671
> Source location is lost when an exception is thrown from the coordinator in
> in-jvm dtests
> -
>
> Key: CASSANDRA-18820
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18820
> Project: Cassandra
> Issue Type: Task
> Components: Test/dtest/java
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Normal
>
> The mechanism is simple - currently we only throw the cause and the enclosing
> stacktrace is dropped. Therefore, it is usually difficult to locate which
> test line is responsible for throwing the exception.
> For example, an induced error caused by an invalid query in {{BooleanTest}}
> yields the following message:
> {noformat}
> org.apache.cassandra.exceptions.InvalidRequestException: Undefined column
> name dk in table distributed_test_keyspace.tbl
> at
> org.apache.cassandra.schema.TableMetadata.getExistingColumn(TableMetadata.java:402)
> at
> org.apache.cassandra.cql3.SingleColumnRelation.newEQRestriction(SingleColumnRelation.java:184)
> at org.apache.cassandra.cql3.Relation.toRestriction(Relation.java:143)
> at
> org.apache.cassandra.cql3.restrictions.StatementRestrictions.(StatementRestrictions.java:205)
> at
> org.apache.cassandra.cql3.restrictions.StatementRestrictions.(StatementRestrictions.java:145)
> at
> org.apache.cassandra.cql3.statements.SelectStatement$RawStatement.prepareRestrictions(SelectStatement.java:1276)
> at
> org.apache.cassandra.cql3.statements.SelectStatement$RawStatement.prepare(SelectStatement.java:1136)
> at
> org.apache.cassandra.cql3.statements.SelectStatement$RawStatement.prepare(SelectStatement.java:1126)
> at
> org.apache.cassandra.cql3.statements.SelectStatement$RawStatement.prepare(SelectStatement.java:1098)
> at
> org.apache.cassandra.cql3.QueryProcessor.getStatement(QueryProcessor.java:857)
> at
> org.apache.cassandra.distributed.impl.Coordinator.unsafeExecuteInternal(Coordinator.java:109)
> at
> org.apache.cassandra.distributed.impl.Coordinator.unsafeExecuteInternal(Coordinator.java:103)
> at
> org.apache.cassandra.distributed.impl.Coordinator.lambda$executeWithResult$0(Coordinator.java:66)
> at org.apache.cassandra.concurrent.FutureTask.call(FutureTask.java:61)
> at org.apache.cassandra.concurrent.FutureTask.run(FutureTask.java:71)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.base/java.lang.Thread.run(Thread.java:829)
> {noformat}
> It does not provide any information on which line in the {{BooleanTest.java}}
> caused the problem.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18820) Source location is lost when an exception is thrown from the coordinator in in-jvm dtests
[
https://issues.apache.org/jira/browse/CASSANDRA-18820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacek Lewandowski updated CASSANDRA-18820:
--
Test and Documentation Plan: manual test
Status: Patch Available (was: Open)
> Source location is lost when an exception is thrown from the coordinator in
> in-jvm dtests
> -
>
> Key: CASSANDRA-18820
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18820
> Project: Cassandra
> Issue Type: Task
> Components: Test/dtest/java
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Normal
>
> The mechanism is simple - currently we only throw the cause and the enclosing
> stacktrace is dropped. Therefore, it is usually difficult to locate which
> test line is responsible for throwing the exception.
> For example, an induced error caused by an invalid query in {{BooleanTest}}
> yields the following message:
> {noformat}
> org.apache.cassandra.exceptions.InvalidRequestException: Undefined column
> name dk in table distributed_test_keyspace.tbl
> at
> org.apache.cassandra.schema.TableMetadata.getExistingColumn(TableMetadata.java:402)
> at
> org.apache.cassandra.cql3.SingleColumnRelation.newEQRestriction(SingleColumnRelation.java:184)
> at org.apache.cassandra.cql3.Relation.toRestriction(Relation.java:143)
> at
> org.apache.cassandra.cql3.restrictions.StatementRestrictions.(StatementRestrictions.java:205)
> at
> org.apache.cassandra.cql3.restrictions.StatementRestrictions.(StatementRestrictions.java:145)
> at
> org.apache.cassandra.cql3.statements.SelectStatement$RawStatement.prepareRestrictions(SelectStatement.java:1276)
> at
> org.apache.cassandra.cql3.statements.SelectStatement$RawStatement.prepare(SelectStatement.java:1136)
> at
> org.apache.cassandra.cql3.statements.SelectStatement$RawStatement.prepare(SelectStatement.java:1126)
> at
> org.apache.cassandra.cql3.statements.SelectStatement$RawStatement.prepare(SelectStatement.java:1098)
> at
> org.apache.cassandra.cql3.QueryProcessor.getStatement(QueryProcessor.java:857)
> at
> org.apache.cassandra.distributed.impl.Coordinator.unsafeExecuteInternal(Coordinator.java:109)
> at
> org.apache.cassandra.distributed.impl.Coordinator.unsafeExecuteInternal(Coordinator.java:103)
> at
> org.apache.cassandra.distributed.impl.Coordinator.lambda$executeWithResult$0(Coordinator.java:66)
> at org.apache.cassandra.concurrent.FutureTask.call(FutureTask.java:61)
> at org.apache.cassandra.concurrent.FutureTask.run(FutureTask.java:71)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.base/java.lang.Thread.run(Thread.java:829)
> {noformat}
> It does not provide any information on which line in the {{BooleanTest.java}}
> caused the problem.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18289) Test Failure: sslnodetonode_test.TestNodeToNodeSSLEncryption.test_ssl_client_auth_required_fail
[
https://issues.apache.org/jira/browse/CASSANDRA-18289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brandon Williams updated CASSANDRA-18289:
-
Authors: Berenguer Blasi, Brandon Williams (was: Brandon Williams)
> Test Failure:
> sslnodetonode_test.TestNodeToNodeSSLEncryption.test_ssl_client_auth_required_fail
> ---
>
> Key: CASSANDRA-18289
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18289
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Michael Semb Wever
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.0, 5.x
>
>
> from
> -
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1469/testReport/dtest-offheap.sslnodetonode_test/TestNodeToNodeSSLEncryption/test_ssl_client_auth_required_fail/
> -
> https://ci-cassandra.apache.org/job/Cassandra-trunk-dtest-offheap/1255/label=cassandra-dtest,split=26/testReport/junit/dtest-offheap.sslnodetonode_test/TestNodeToNodeSSLEncryption/test_ssl_client_auth_required_fail/
> Stacktrace
> {noformat}
> self = 0x7f9ff4fb84f0>
> def test_ssl_client_auth_required_fail(self):
> """peers need to perform mutual auth (cient auth required), but do
> not supply the local cert"""
> credNode1 = sslkeygen.generate_credentials("127.0.0.1")
> credNode2 = sslkeygen.generate_credentials("127.0.0.2")
>
> self.setup_nodes(credNode1, credNode2, client_auth=True)
>
> self.fixture_dtest_setup.allow_log_errors = True
> self.cluster.start(no_wait=True)
> time.sleep(2)
>
> found = self._grep_msg(self.node1, _LOG_ERR_HANDSHAKE,
> _LOG_ERR_GENERAL)
> > assert found
> E assert False
> sslnodetonode_test.py:83: AssertionError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18820) Source location is lost when an exception is thrown from the coordinator in in-jvm dtests
[
https://issues.apache.org/jira/browse/CASSANDRA-18820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacek Lewandowski updated CASSANDRA-18820:
--
Description:
The mechanism is simple - currently we only throw the cause and the enclosing
stacktrace is dropped. Therefore, it is usually difficult to locate which test
line is responsible for throwing the exception.
For example, an induced error caused by an invalid query in {{BooleanTest}}
yields the following message:
{noformat}
org.apache.cassandra.exceptions.InvalidRequestException: Undefined column name
dk in table distributed_test_keyspace.tbl
at
org.apache.cassandra.schema.TableMetadata.getExistingColumn(TableMetadata.java:402)
at
org.apache.cassandra.cql3.SingleColumnRelation.newEQRestriction(SingleColumnRelation.java:184)
at org.apache.cassandra.cql3.Relation.toRestriction(Relation.java:143)
at
org.apache.cassandra.cql3.restrictions.StatementRestrictions.(StatementRestrictions.java:205)
at
org.apache.cassandra.cql3.restrictions.StatementRestrictions.(StatementRestrictions.java:145)
at
org.apache.cassandra.cql3.statements.SelectStatement$RawStatement.prepareRestrictions(SelectStatement.java:1276)
at
org.apache.cassandra.cql3.statements.SelectStatement$RawStatement.prepare(SelectStatement.java:1136)
at
org.apache.cassandra.cql3.statements.SelectStatement$RawStatement.prepare(SelectStatement.java:1126)
at
org.apache.cassandra.cql3.statements.SelectStatement$RawStatement.prepare(SelectStatement.java:1098)
at
org.apache.cassandra.cql3.QueryProcessor.getStatement(QueryProcessor.java:857)
at
org.apache.cassandra.distributed.impl.Coordinator.unsafeExecuteInternal(Coordinator.java:109)
at
org.apache.cassandra.distributed.impl.Coordinator.unsafeExecuteInternal(Coordinator.java:103)
at
org.apache.cassandra.distributed.impl.Coordinator.lambda$executeWithResult$0(Coordinator.java:66)
at org.apache.cassandra.concurrent.FutureTask.call(FutureTask.java:61)
at org.apache.cassandra.concurrent.FutureTask.run(FutureTask.java:71)
at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at
io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.base/java.lang.Thread.run(Thread.java:829)
{noformat}
It does not provide any information on which line in the {{BooleanTest.java}}
caused the problem.
was:
The mechanism is simple - currently we only throw the cause and the enclosing
stacktrace is dropped. Therefore, it is usually difficult to locate which test
line is responsible for throwing the exception.
> Source location is lost when an exception is thrown from the coordinator in
> in-jvm dtests
> -
>
> Key: CASSANDRA-18820
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18820
> Project: Cassandra
> Issue Type: Task
> Components: Test/dtest/java
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Normal
>
> The mechanism is simple - currently we only throw the cause and the enclosing
> stacktrace is dropped. Therefore, it is usually difficult to locate which
> test line is responsible for throwing the exception.
> For example, an induced error caused by an invalid query in {{BooleanTest}}
> yields the following message:
> {noformat}
> org.apache.cassandra.exceptions.InvalidRequestException: Undefined column
> name dk in table distributed_test_keyspace.tbl
> at
> org.apache.cassandra.schema.TableMetadata.getExistingColumn(TableMetadata.java:402)
> at
> org.apache.cassandra.cql3.SingleColumnRelation.newEQRestriction(SingleColumnRelation.java:184)
> at org.apache.cassandra.cql3.Relation.toRestriction(Relation.java:143)
> at
> org.apache.cassandra.cql3.restrictions.StatementRestrictions.(StatementRestrictions.java:205)
> at
> org.apache.cassandra.cql3.restrictions.StatementRestrictions.(StatementRestrictions.java:145)
> at
> org.apache.cassandra.cql3.statements.SelectStatement$RawStatement.prepareRestrictions(SelectStatement.java:1276)
> at
> org.apache.cassandra.cql3.statements.SelectStatement$RawStatement.prepare(SelectStatement.java:1136)
> at
> org.apache.cassandra.cql3.statements.SelectStatement$RawStatement.prepare(SelectStatement.java:1126)
> at
> org.apache.cassandra.cql3.statements.SelectStatement$RawStatement.prepare(SelectStatement.java:1098)
> at
> org.apache.cassandra.cql3.QueryProcessor.getStatement(QueryProcessor.java:857)
> at
>
[jira] [Commented] (CASSANDRA-18818) Add cqlshrc.sample and credentials.sample into Debian package
[ https://issues.apache.org/jira/browse/CASSANDRA-18818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762038#comment-17762038 ] Brandon Williams commented on CASSANDRA-18818: -- +1 > Add cqlshrc.sample and credentials.sample into Debian package > - > > Key: CASSANDRA-18818 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18818 > Project: Cassandra > Issue Type: Task > Components: Packaging >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.x > > > RPM package contains these two files buy DEB does not. Debian users suffer > from not having these files available so they need to craft them completely > from scratch. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18818) Add cqlshrc.sample and credentials.sample into Debian package
[ https://issues.apache.org/jira/browse/CASSANDRA-18818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18818: - Reviewers: Brandon Williams Status: Review In Progress (was: Needs Committer) > Add cqlshrc.sample and credentials.sample into Debian package > - > > Key: CASSANDRA-18818 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18818 > Project: Cassandra > Issue Type: Task > Components: Packaging >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.x > > > RPM package contains these two files buy DEB does not. Debian users suffer > from not having these files available so they need to craft them completely > from scratch. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18818) Add cqlshrc.sample and credentials.sample into Debian package
[ https://issues.apache.org/jira/browse/CASSANDRA-18818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brandon Williams updated CASSANDRA-18818: - Status: Ready to Commit (was: Review In Progress) > Add cqlshrc.sample and credentials.sample into Debian package > - > > Key: CASSANDRA-18818 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18818 > Project: Cassandra > Issue Type: Task > Components: Packaging >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.x > > > RPM package contains these two files buy DEB does not. Debian users suffer > from not having these files available so they need to craft them completely > from scratch. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18322) Warn about unqualified prepared statement only if it is a select, update, delete, insert
[
https://issues.apache.org/jira/browse/CASSANDRA-18322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762037#comment-17762037
]
Brandon Williams commented on CASSANDRA-18322:
--
I think it would best if [~ifesdjeen] took a look at this.
> Warn about unqualified prepared statement only if it is a select, update,
> delete, insert
>
>
> Key: CASSANDRA-18322
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18322
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Client
>Reporter: Mohammad Aburadeh
>Assignee: Stefan Miklosovic
>Priority: Urgent
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.x
>
>
> Hi,
> We get the following warnings when we use prepared statements with "create
> keyspace ... " or "drop keyspace" statements.
> "
> {{USE }} with prepared statements is considered to be an
> anti-pattern due to ambiguity in non-qualified table names. Please consider
> removing instances of {{{}Session#setKeyspace(){}}},
> {{Session#execute("USE ")}} and {{cluster.newSession()}}
> from your code, and always use fully qualified table names (e.g.
> .). Keyspace used: null, statement keyspace: null, statement
> id: 8153d922390fdf9a9963bfeda85b2f3b at
> "
> Such statements are already full-qualified. So, why are we getting this
> warning?
> Regards
> Mohammad
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18820) Source location is lost when an exception is thrown from the coordinator in in-jvm dtests
[ https://issues.apache.org/jira/browse/CASSANDRA-18820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacek Lewandowski updated CASSANDRA-18820: -- Change Category: Code Clarity Complexity: Low Hanging Fruit Assignee: Jacek Lewandowski Status: Open (was: Triage Needed) > Source location is lost when an exception is thrown from the coordinator in > in-jvm dtests > - > > Key: CASSANDRA-18820 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18820 > Project: Cassandra > Issue Type: Task > Components: Test/dtest/java >Reporter: Jacek Lewandowski >Assignee: Jacek Lewandowski >Priority: Normal > > The mechanism is simple - currently we only throw the cause and the enclosing > stacktrace is dropped. Therefore, it is usually difficult to locate which > test line is responsible for throwing the exception. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18820) Source location is lost when an exception is thrown from the coordinator in in-jvm dtests
Jacek Lewandowski created CASSANDRA-18820: - Summary: Source location is lost when an exception is thrown from the coordinator in in-jvm dtests Key: CASSANDRA-18820 URL: https://issues.apache.org/jira/browse/CASSANDRA-18820 Project: Cassandra Issue Type: Task Components: Test/dtest/java Reporter: Jacek Lewandowski The mechanism is simple - currently we only throw the cause and the enclosing stacktrace is dropped. Therefore, it is usually difficult to locate which test line is responsible for throwing the exception. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18734) SAI result retriever is filtering too many rows
[ https://issues.apache.org/jira/browse/CASSANDRA-18734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andres de la Peña updated CASSANDRA-18734: -- Reviewers: Andres de la Peña, Caleb Rackliffe (was: Caleb Rackliffe) > SAI result retriever is filtering too many rows > --- > > Key: CASSANDRA-18734 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18734 > Project: Cassandra > Issue Type: Bug > Components: Feature/SAI >Reporter: Mike Adamson >Assignee: Mike Adamson >Priority: Normal > Attachments: flamegraph.svg, image-2023-08-08-13-48-19-701.png, > image-2023-08-08-13-49-19-576.png > > > Performance tests on SAI have shown that the number of rows being filtered > for wide row partitions is more than expected. For a 10k row/partition test - > limit 10, the following has been observed. > !image-2023-08-08-13-49-19-576.png|width=952,height=368! > This is not the expected outcome of row-awareness and needs investigating. > The number of rows read should, roughly, match the number of partitions read. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18360) Test Failure: o.a.c.cql3.validation.operations.AlterTest#testDropListAndAddListWithSameName
[
https://issues.apache.org/jira/browse/CASSANDRA-18360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761949#comment-17761949
]
Berenguer Blasi edited comment on CASSANDRA-18360 at 9/5/23 9:19 AM:
-
It seems it doesn't repro anymore:
- Not with RepeatableRunner in 5.0 or trunk
- Not on circle on either on 5.0
[500|https://app.circleci.com/pipelines/github/bereng/cassandra/1059/workflows/2a14c247-d90e-4b31-a58c-455f21395351/jobs/27942]
repeats or trunk
[5K|https://app.circleci.com/pipelines/github/bereng/cassandra/1061/workflows/7981875b-5956-4e02-b172-ef26d769046b/jobs/28168]
and
[500|https://app.circleci.com/pipelines/github/bereng/cassandra/1060/workflows/41f40ff6-3724-4121-b759-8f28edca509d/jobs/28055]
repeats.
Either it doesn't repro for me or it is gone. If sbdy could confirm with a
rebase I'd propose to close as won't repro until it does and reopen if needed.
Wdyt?
Edit:
[500|https://app.circleci.com/pipelines/github/bereng/cassandra/1062/workflows/431c84e0-17d2-4c87-b311-bd31299d4b7b/jobs/28281]
on the free tier doesn't repro either...
Edit2: Although it failed 4 days ago in
[jenkins|https://ci-cassandra.apache.org/job/Cassandra-trunk/1695/testReport/junit/org.apache.cassandra.cql3.validation.operations/AlterTest/testDropListAndAddListWithSameName_cdc_jdk17/]...
:-(
was (Author: bereng):
It seems it doesn't repro anymore:
- Not with RepeatableRunner in 5.0 or trunk
- Not on circle on either on 5.0
[500|https://app.circleci.com/pipelines/github/bereng/cassandra/1059/workflows/2a14c247-d90e-4b31-a58c-455f21395351/jobs/27942]
repeats or trunk
[5K|https://app.circleci.com/pipelines/github/bereng/cassandra/1061/workflows/7981875b-5956-4e02-b172-ef26d769046b/jobs/28168]
and
[500|https://app.circleci.com/pipelines/github/bereng/cassandra/1060/workflows/41f40ff6-3724-4121-b759-8f28edca509d/jobs/28055]
repeats.
Either it doesn't repro for me or it is gone. If sbdy could confirm with a
rebase I'd propose to close as won't repro until it does and reopen if needed.
Wdyt?
EDIT:
[500|https://app.circleci.com/pipelines/github/bereng/cassandra/1062/workflows/431c84e0-17d2-4c87-b311-bd31299d4b7b/jobs/28281]
on the free tier doesn't repro either...
> Test Failure:
> o.a.c.cql3.validation.operations.AlterTest#testDropListAndAddListWithSameName
> ---
>
> Key: CASSANDRA-18360
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18360
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 5.x
>
>
> The unit test
> {{org.apache.cassandra.cql3.validation.operations.AlterTest#testDropListAndAddListWithSameName}}
> is flaky at least on trunk. Flakiness seems lesser than 1%.
> While I haven't seen it on Jenkins yet, it can easily be reproduced on
> CircleCI with the multiplexer:
> *
> https://app.circleci.com/pipelines/github/adelapena/cassandra/2731/workflows/58edc2f6-9a21-4d09-b783-b7fb15e1b320/jobs/32235
> *
> https://app.circleci.com/pipelines/github/adelapena/cassandra/2731/workflows/58edc2f6-9a21-4d09-b783-b7fb15e1b320/jobs/32234
> *
> https://app.circleci.com/pipelines/github/adelapena/cassandra/2731/workflows/739a95d3-8e42-4447-93dd-122fc16fdd7d/jobs/32233/tests
> Those runs show two types of errors:
> {code}
> junit.framework.AssertionFailedError: Invalid value for row 0 column 1
> (content of type text), expected but got
> at org.apache.cassandra.cql3.CQLTester.assertRows(CQLTester.java:1506)
> at
> org.apache.cassandra.cql3.validation.operations.AlterTest.testDropListAndAddListWithSameName(AlterTest.java:102)
> {code}
> and:
> {code}
> org.apache.cassandra.serializers.MarshalException: Invalid UTF-8 bytes
> 00e0279515437f00
> at
> org.apache.cassandra.serializers.AbstractTextSerializer.deserialize(AbstractTextSerializer.java:46)
> at
> org.apache.cassandra.serializers.AbstractTextSerializer.deserialize(AbstractTextSerializer.java:29)
> at
> org.apache.cassandra.serializers.TypeSerializer.deserialize(TypeSerializer.java:37)
> at org.apache.cassandra.cql3.CQLTester.assertRows(CQLTester.java:1494)
> at
> org.apache.cassandra.cql3.validation.operations.AlterTest.testDropListAndAddListWithSameName(AlterTest.java:102)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
> The CircleCI config I used to reproduce the test failure can be generated
> with:
> {code}
>
[jira] [Updated] (CASSANDRA-18289) Test Failure: sslnodetonode_test.TestNodeToNodeSSLEncryption.test_ssl_client_auth_required_fail
[
https://issues.apache.org/jira/browse/CASSANDRA-18289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-18289:
Resolution: Cannot Reproduce
Status: Resolved (was: Open)
> Test Failure:
> sslnodetonode_test.TestNodeToNodeSSLEncryption.test_ssl_client_auth_required_fail
> ---
>
> Key: CASSANDRA-18289
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18289
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Michael Semb Wever
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.x
>
>
> from
> -
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1469/testReport/dtest-offheap.sslnodetonode_test/TestNodeToNodeSSLEncryption/test_ssl_client_auth_required_fail/
> -
> https://ci-cassandra.apache.org/job/Cassandra-trunk-dtest-offheap/1255/label=cassandra-dtest,split=26/testReport/junit/dtest-offheap.sslnodetonode_test/TestNodeToNodeSSLEncryption/test_ssl_client_auth_required_fail/
> Stacktrace
> {noformat}
> self = 0x7f9ff4fb84f0>
> def test_ssl_client_auth_required_fail(self):
> """peers need to perform mutual auth (cient auth required), but do
> not supply the local cert"""
> credNode1 = sslkeygen.generate_credentials("127.0.0.1")
> credNode2 = sslkeygen.generate_credentials("127.0.0.2")
>
> self.setup_nodes(credNode1, credNode2, client_auth=True)
>
> self.fixture_dtest_setup.allow_log_errors = True
> self.cluster.start(no_wait=True)
> time.sleep(2)
>
> found = self._grep_msg(self.node1, _LOG_ERR_HANDSHAKE,
> _LOG_ERR_GENERAL)
> > assert found
> E assert False
> sslnodetonode_test.py:83: AssertionError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18289) Test Failure: sslnodetonode_test.TestNodeToNodeSSLEncryption.test_ssl_client_auth_required_fail
[
https://issues.apache.org/jira/browse/CASSANDRA-18289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Berenguer Blasi updated CASSANDRA-18289:
Fix Version/s: 5.0
> Test Failure:
> sslnodetonode_test.TestNodeToNodeSSLEncryption.test_ssl_client_auth_required_fail
> ---
>
> Key: CASSANDRA-18289
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18289
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Michael Semb Wever
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.0, 5.x
>
>
> from
> -
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1469/testReport/dtest-offheap.sslnodetonode_test/TestNodeToNodeSSLEncryption/test_ssl_client_auth_required_fail/
> -
> https://ci-cassandra.apache.org/job/Cassandra-trunk-dtest-offheap/1255/label=cassandra-dtest,split=26/testReport/junit/dtest-offheap.sslnodetonode_test/TestNodeToNodeSSLEncryption/test_ssl_client_auth_required_fail/
> Stacktrace
> {noformat}
> self = 0x7f9ff4fb84f0>
> def test_ssl_client_auth_required_fail(self):
> """peers need to perform mutual auth (cient auth required), but do
> not supply the local cert"""
> credNode1 = sslkeygen.generate_credentials("127.0.0.1")
> credNode2 = sslkeygen.generate_credentials("127.0.0.2")
>
> self.setup_nodes(credNode1, credNode2, client_auth=True)
>
> self.fixture_dtest_setup.allow_log_errors = True
> self.cluster.start(no_wait=True)
> time.sleep(2)
>
> found = self._grep_msg(self.node1, _LOG_ERR_HANDSHAKE,
> _LOG_ERR_GENERAL)
> > assert found
> E assert False
> sslnodetonode_test.py:83: AssertionError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18289) Test Failure: sslnodetonode_test.TestNodeToNodeSSLEncryption.test_ssl_client_auth_required_fail
[
https://issues.apache.org/jira/browse/CASSANDRA-18289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762001#comment-17762001
]
Berenguer Blasi commented on CASSANDRA-18289:
-
Checking butler and jenkins it hasn't failed since. So I vote to close as won't
repro. We can reopen if it shows up again +1.
> Test Failure:
> sslnodetonode_test.TestNodeToNodeSSLEncryption.test_ssl_client_auth_required_fail
> ---
>
> Key: CASSANDRA-18289
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18289
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
>Reporter: Michael Semb Wever
>Assignee: Brandon Williams
>Priority: Normal
> Fix For: 5.x
>
>
> from
> -
> https://ci-cassandra.apache.org/job/Cassandra-trunk/1469/testReport/dtest-offheap.sslnodetonode_test/TestNodeToNodeSSLEncryption/test_ssl_client_auth_required_fail/
> -
> https://ci-cassandra.apache.org/job/Cassandra-trunk-dtest-offheap/1255/label=cassandra-dtest,split=26/testReport/junit/dtest-offheap.sslnodetonode_test/TestNodeToNodeSSLEncryption/test_ssl_client_auth_required_fail/
> Stacktrace
> {noformat}
> self = 0x7f9ff4fb84f0>
> def test_ssl_client_auth_required_fail(self):
> """peers need to perform mutual auth (cient auth required), but do
> not supply the local cert"""
> credNode1 = sslkeygen.generate_credentials("127.0.0.1")
> credNode2 = sslkeygen.generate_credentials("127.0.0.2")
>
> self.setup_nodes(credNode1, credNode2, client_auth=True)
>
> self.fixture_dtest_setup.allow_log_errors = True
> self.cluster.start(no_wait=True)
> time.sleep(2)
>
> found = self._grep_msg(self.node1, _LOG_ERR_HANDSHAKE,
> _LOG_ERR_GENERAL)
> > assert found
> E assert False
> sslnodetonode_test.py:83: AssertionError
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18322) Warn about unqualified prepared statement only if it is a select, update, delete, insert
[
https://issues.apache.org/jira/browse/CASSANDRA-18322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761819#comment-17761819
]
Stefan Miklosovic edited comment on CASSANDRA-18322 at 9/5/23 8:43 AM:
---
Ah as I dug deeper I see what is the problem ... No need to create another
ticket.
I prepared a patch for trunk here (1).
It applies cleanly back to 4.0.
(1) https://github.com/apache/cassandra/pull/2668
(2) 3.11 PR https://github.com/apache/cassandra/pull/2669
(3) 3.0 PR https://github.com/apache/cassandra/pull/2670/files
I ll do builds when it is reviewed ... it is going to 6 branches so I do not
want to build that prematurely.
[~brandon.williams] would you mind to take a look?
was (Author: smiklosovic):
Ah as I dug deeper I see what is the problem ... No need to create another
ticket.
I prepared a patch for trunk here (1).
It applies cleanly back to 4.0.
(1) https://github.com/apache/cassandra/pull/2668
(2) 3.11 PR https://github.com/apache/cassandra/pull/2669
(3) 3.0 PR https://github.com/apache/cassandra/pull/2670/files
I ll do builds when it is reviewed ... it is going to 6 branches so I do not
want to build that prematurely.
> Warn about unqualified prepared statement only if it is a select, update,
> delete, insert
>
>
> Key: CASSANDRA-18322
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18322
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Client
>Reporter: Mohammad Aburadeh
>Assignee: Stefan Miklosovic
>Priority: Urgent
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.x
>
>
> Hi,
> We get the following warnings when we use prepared statements with "create
> keyspace ... " or "drop keyspace" statements.
> "
> {{USE }} with prepared statements is considered to be an
> anti-pattern due to ambiguity in non-qualified table names. Please consider
> removing instances of {{{}Session#setKeyspace(){}}},
> {{Session#execute("USE ")}} and {{cluster.newSession()}}
> from your code, and always use fully qualified table names (e.g.
> .). Keyspace used: null, statement keyspace: null, statement
> id: 8153d922390fdf9a9963bfeda85b2f3b at
> "
> Such statements are already full-qualified. So, why are we getting this
> warning?
> Regards
> Mohammad
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18818) Add cqlshrc.sample and credentials.sample into Debian package
[ https://issues.apache.org/jira/browse/CASSANDRA-18818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761989#comment-17761989 ] Stefan Miklosovic commented on CASSANDRA-18818: --- [~brandonwilliams] very easy one! > Add cqlshrc.sample and credentials.sample into Debian package > - > > Key: CASSANDRA-18818 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18818 > Project: Cassandra > Issue Type: Task > Components: Packaging >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.x > > > RPM package contains these two files buy DEB does not. Debian users suffer > from not having these files available so they need to craft them completely > from scratch. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18322) Warn about unqualified prepared statement only if it is a select, update, delete, insert
[
https://issues.apache.org/jira/browse/CASSANDRA-18322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761988#comment-17761988
]
Stefan Miklosovic commented on CASSANDRA-18322:
---
sneak peek into trunk's build for j17
https://app.circleci.com/pipelines/github/instaclustr/cassandra/3075/workflows/0b284719-7d30-4f39-958e-18248bc7a97a
> Warn about unqualified prepared statement only if it is a select, update,
> delete, insert
>
>
> Key: CASSANDRA-18322
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18322
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Client
>Reporter: Mohammad Aburadeh
>Assignee: Stefan Miklosovic
>Priority: Urgent
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.x
>
>
> Hi,
> We get the following warnings when we use prepared statements with "create
> keyspace ... " or "drop keyspace" statements.
> "
> {{USE }} with prepared statements is considered to be an
> anti-pattern due to ambiguity in non-qualified table names. Please consider
> removing instances of {{{}Session#setKeyspace(){}}},
> {{Session#execute("USE ")}} and {{cluster.newSession()}}
> from your code, and always use fully qualified table names (e.g.
> .). Keyspace used: null, statement keyspace: null, statement
> id: 8153d922390fdf9a9963bfeda85b2f3b at
> "
> Such statements are already full-qualified. So, why are we getting this
> warning?
> Regards
> Mohammad
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18360) Test Failure: o.a.c.cql3.validation.operations.AlterTest#testDropListAndAddListWithSameName
[
https://issues.apache.org/jira/browse/CASSANDRA-18360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761949#comment-17761949
]
Berenguer Blasi edited comment on CASSANDRA-18360 at 9/5/23 7:45 AM:
-
It seems it doesn't repro anymore:
- Not with RepeatableRunner in 5.0 or trunk
- Not on circle on either on 5.0
[500|https://app.circleci.com/pipelines/github/bereng/cassandra/1059/workflows/2a14c247-d90e-4b31-a58c-455f21395351/jobs/27942]
repeats or trunk
[5K|https://app.circleci.com/pipelines/github/bereng/cassandra/1061/workflows/7981875b-5956-4e02-b172-ef26d769046b/jobs/28168]
and
[500|https://app.circleci.com/pipelines/github/bereng/cassandra/1060/workflows/41f40ff6-3724-4121-b759-8f28edca509d/jobs/28055]
repeats.
Either it doesn't repro for me or it is gone. If sbdy could confirm with a
rebase I'd propose to close as won't repro until it does and reopen if needed.
Wdyt?
EDIT:
[500|https://app.circleci.com/pipelines/github/bereng/cassandra/1062/workflows/431c84e0-17d2-4c87-b311-bd31299d4b7b/jobs/28281]
on the free tier doesn't repro either...
was (Author: bereng):
It seems it doesn't repro anymore:
- Not with RepeatableRunner in 5.0 or trunk
- Not on circle on either on 5.0
[500|https://app.circleci.com/pipelines/github/bereng/cassandra/1059/workflows/2a14c247-d90e-4b31-a58c-455f21395351/jobs/27942]
repeats or trunk
[5K|https://app.circleci.com/pipelines/github/bereng/cassandra/1061/workflows/7981875b-5956-4e02-b172-ef26d769046b/jobs/28168]
and
[500|https://app.circleci.com/pipelines/github/bereng/cassandra/1060/workflows/41f40ff6-3724-4121-b759-8f28edca509d/jobs/28055]
repeats.
Either it doesn't repro for me or it is gone. If sbdy could confirm with a
rebase I'd propose to close as won't repro until it does and reopen if needed.
Wdyt?
> Test Failure:
> o.a.c.cql3.validation.operations.AlterTest#testDropListAndAddListWithSameName
> ---
>
> Key: CASSANDRA-18360
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18360
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Berenguer Blasi
>Priority: Normal
> Fix For: 5.x
>
>
> The unit test
> {{org.apache.cassandra.cql3.validation.operations.AlterTest#testDropListAndAddListWithSameName}}
> is flaky at least on trunk. Flakiness seems lesser than 1%.
> While I haven't seen it on Jenkins yet, it can easily be reproduced on
> CircleCI with the multiplexer:
> *
> https://app.circleci.com/pipelines/github/adelapena/cassandra/2731/workflows/58edc2f6-9a21-4d09-b783-b7fb15e1b320/jobs/32235
> *
> https://app.circleci.com/pipelines/github/adelapena/cassandra/2731/workflows/58edc2f6-9a21-4d09-b783-b7fb15e1b320/jobs/32234
> *
> https://app.circleci.com/pipelines/github/adelapena/cassandra/2731/workflows/739a95d3-8e42-4447-93dd-122fc16fdd7d/jobs/32233/tests
> Those runs show two types of errors:
> {code}
> junit.framework.AssertionFailedError: Invalid value for row 0 column 1
> (content of type text), expected but got
> at org.apache.cassandra.cql3.CQLTester.assertRows(CQLTester.java:1506)
> at
> org.apache.cassandra.cql3.validation.operations.AlterTest.testDropListAndAddListWithSameName(AlterTest.java:102)
> {code}
> and:
> {code}
> org.apache.cassandra.serializers.MarshalException: Invalid UTF-8 bytes
> 00e0279515437f00
> at
> org.apache.cassandra.serializers.AbstractTextSerializer.deserialize(AbstractTextSerializer.java:46)
> at
> org.apache.cassandra.serializers.AbstractTextSerializer.deserialize(AbstractTextSerializer.java:29)
> at
> org.apache.cassandra.serializers.TypeSerializer.deserialize(TypeSerializer.java:37)
> at org.apache.cassandra.cql3.CQLTester.assertRows(CQLTester.java:1494)
> at
> org.apache.cassandra.cql3.validation.operations.AlterTest.testDropListAndAddListWithSameName(AlterTest.java:102)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
> The CircleCI config I used to reproduce the test failure can be generated
> with:
> {code}
> .circleci/generate.sh -p \
> -e REPEATED_UTESTS_COUNT=500 \
> -e REPEATED_UTESTS=org.apache.cassandra.cql3.validation.operations.AlterTest
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail:
[jira] [Commented] (CASSANDRA-18778) Empty keystore_password no longer allowed on encryption_options
[
https://issues.apache.org/jira/browse/CASSANDRA-18778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761971#comment-17761971
]
Tibor Repasi commented on CASSANDRA-18778:
--
Hi, thanks for pinging. Sorry for the delayed response, I'm just back from
holidays.
I've just tested 5.0-alpha1 (take3) on my test cluster set up with
PEMBasedSslContextFactory which has required CASSANDRA-18124. The patch seems
not inflicting with the features used there.
LGTM
> Empty keystore_password no longer allowed on encryption_options
> ---
>
> Key: CASSANDRA-18778
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18778
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
>Reporter: Andy Tolbert
>Assignee: Andy Tolbert
>Priority: Normal
> Fix For: 4.1.4, 5.0
>
>
> After CASSANDRA-18124 (introduced in 4.1.2 and 5.0) it is no longer possible
> to set an empty {{keystore_password}} under {{client_encryption_options}} or
> {{server_encryption_options}} using the default implementation
> {{{}DefaultSslContextFactory{}}}.
> While keytool does not allow generating keystores with empty passwords, it
> does support reading them. It is not uncommon to use PKCS12 certificates
> generated by other tools (eg. openssl) that do not enforce passwords.
> The fix for this should be pretty straightforward, which should involve
> changing
> [FileBasedSslContextFactory.validatePassword|https://github.com/apache/cassandra/blob/cassandra-4.1.2/src/java/org/apache/cassandra/security/FileBasedSslContextFactory.java#L128-L135]
> to only disallow null passwords (which would be consistent with previous
> versions). I will create pull requests against the relevant branches shortly.
> {noformat}
> Exception (org.apache.cassandra.exceptions.ConfigurationException)
> encountered during startup: Failed to initialize SSL
> org.apache.cassandra.exceptions.ConfigurationException: Failed to initialize
> SSL
> at
> org.apache.cassandra.config.DatabaseDescriptor.applySslContext(DatabaseDescriptor.java:1155)
> at
> org.apache.cassandra.config.DatabaseDescriptor.applyAll(DatabaseDescriptor.java:390)
> at
> org.apache.cassandra.config.DatabaseDescriptor.daemonInitialization(DatabaseDescriptor.java:204)
> at
> org.apache.cassandra.config.DatabaseDescriptor.daemonInitialization(DatabaseDescriptor.java:188)
> at
> org.apache.cassandra.service.CassandraDaemon.applyConfig(CassandraDaemon.java:804)
> at
> org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:747)
> at
> org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:875)
> Caused by: java.io.IOException: Failed to create SSL context using Native
> transport
> at
> org.apache.cassandra.security.SSLFactory.validateSslContext(SSLFactory.java:405)
> at
> org.apache.cassandra.config.DatabaseDescriptor.applySslContext(DatabaseDescriptor.java:1150)
> ... 6 more
> Caused by: java.lang.IllegalArgumentException: 'keystore_password' must be
> specified
> at
> org.apache.cassandra.security.FileBasedSslContextFactory.validatePassword(FileBasedSslContextFactory.java:133)
> at
> org.apache.cassandra.security.FileBasedSslContextFactory.buildKeyManagerFactory(FileBasedSslContextFactory.java:151)
> at
> org.apache.cassandra.security.AbstractSslContextFactory.createNettySslContext(AbstractSslContextFactory.java:181)
> at
> org.apache.cassandra.security.SSLFactory.createNettySslContext(SSLFactory.java:168)
> at
> org.apache.cassandra.security.SSLFactory.validateSslContext(SSLFactory.java:355)
> ... 7 more
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
